Re: [VOTE] Release Apache Liminal (incubating) 0.0.1-INCUBATING
I don’t consider as a blocker but just source archive should be on dist for now. It makes sense to have convenient binary archive but for liminal and Python not sure it’s fully ready now. Regards JB > Le 24 janv. 2021 à 13:55, Justin Mclean a écrit : > > Hi, > >> It is a tar that is created as part of the python setup process. >> We will not include it in releases going forward > > But I assume it is released somewhere and if that is the case it still needs > to comply with ASF please and distribution policy. > > Thanks. > Justin > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache Liminal (incubating) 0.0.1-INCUBATING
Hi, > It is a tar that is created as part of the python setup process. > We will not include it in releases going forward But I assume it is released somewhere and if that is the case it still needs to comply with ASF please and distribution policy. Thanks. Justin - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache Liminal (incubating) 0.0.1-INCUBATING
Hi, It is a tar that is created as part of the python setup process. We will not include it in releases going forward Thanks, aviem On Fri, Jan 22, 2021 at 1:05 AM Justin Mclean wrote: > Hi, > > > We will fix the issues and create a new release candidate. > > I’m still little confused why you have two release artefacts, if you can > explain that it would be helpful. > > Thanks, > Justin > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
Re: [VOTE] Release Apache Liminal (incubating) 0.0.1-INCUBATING
Hi, > We will fix the issues and create a new release candidate. I’m still little confused why you have two release artefacts, if you can explain that it would be helpful. Thanks, Justin - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache Liminal (incubating) 0.0.1-INCUBATING
Thanks for the feedback Justin. We will fix the issues and create a new release candidate. Lior On Thu, Jan 21, 2021 at 10:11 AM Justin Mclean wrote: > Hi, > > -1 (binding) until apache-liminal-0.0.1-INCUBATING.tar.gz vs > apache-liminal-0.0.1-INCUBATING-source.tar.gz is cleared up. > > > I checked: > - incubating in name > - signatures and hashes correct > - DISCLAIMER exists however here no need for the ASF header in the > DISLAIMER file and where is says "List of known issues goes here” you > should list them > - LICENSE seems OK as no 3rd party software is included. Is this correct? > - NOTICE looks to contain too much information. There no need to mention > license information here, that should be in LICENSE. You should only have > "This product uses software developed at” where headers have been removed > with permission not because you are using 3rd party software.If something > in not included in the release and just a dependancy there no need to > mention it in NOTICE or LICENSE. > - A couple of files are missing headers e.g. [1] > - No unexpected binaries > > I’m not sure what apache-liminal-0.0.1-INCUBATING.tar.gz is vs > apache-liminal-0.0.1-INCUBATING-source.tar.gz. > apache-liminal-0.0.1-INCUBATING.tar.gz is missing LICENSE, NOTICE and > DISCLAIMER. A release must include these file. > > Thanks, > Justin > > 1. ./tests/runners/airflow/dag/test_liminal_dags.py > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
Re: [VOTE] Release Apache Liminal (incubating) 0.0.1-INCUBATING
Hi, -1 (binding) until apache-liminal-0.0.1-INCUBATING.tar.gz vs apache-liminal-0.0.1-INCUBATING-source.tar.gz is cleared up. I checked: - incubating in name - signatures and hashes correct - DISCLAIMER exists however here no need for the ASF header in the DISLAIMER file and where is says "List of known issues goes here” you should list them - LICENSE seems OK as no 3rd party software is included. Is this correct? - NOTICE looks to contain too much information. There no need to mention license information here, that should be in LICENSE. You should only have "This product uses software developed at” where headers have been removed with permission not because you are using 3rd party software.If something in not included in the release and just a dependancy there no need to mention it in NOTICE or LICENSE. - A couple of files are missing headers e.g. [1] - No unexpected binaries I’m not sure what apache-liminal-0.0.1-INCUBATING.tar.gz is vs apache-liminal-0.0.1-INCUBATING-source.tar.gz. apache-liminal-0.0.1-INCUBATING.tar.gz is missing LICENSE, NOTICE and DISCLAIMER. A release must include these file. Thanks, Justin 1. ./tests/runners/airflow/dag/test_liminal_dags.py - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
