[gentoo-commits] proj/devmanual:master commit in: general-concepts/ebuild-revisions/
commit: 80a65cf5f16ebf75b7606fbdcdc4db5e3ea3e097 Author: Ulrich Müller gentoo org> AuthorDate: Sat Aug 19 14:01:19 2023 + Commit: Ulrich Müller gentoo org> CommitDate: Sat Aug 26 05:39:28 2023 + URL:https://gitweb.gentoo.org/proj/devmanual.git/commit/?id=80a65cf5 general-concepts/ebuild-revisions: License updates may require a revbump See for example bug 912458, where removal of the unused CMake license caused a blocker on users' systems. Signed-off-by: Ulrich Müller gentoo.org> general-concepts/ebuild-revisions/text.xml | 4 1 file changed, 4 insertions(+) diff --git a/general-concepts/ebuild-revisions/text.xml b/general-concepts/ebuild-revisions/text.xml index e0c8b01..b524a4b 100644 --- a/general-concepts/ebuild-revisions/text.xml +++ b/general-concepts/ebuild-revisions/text.xml @@ -74,6 +74,10 @@ of thumb could be used as a guideline: restricting a runtime dependency version, unless the := subslot operator is going to trigger a rebuild, + +updating the license, if any of the affected licenses is either non-free or +is about to be removed, + changing the EAPI (unless changes to the ebuild are trivial, and you can be sure it won't break stable or reverse dependencies).
[gentoo-commits] proj/devmanual:master commit in: general-concepts/ebuild-revisions/
commit: f5cec0886bed97956d047c73cb997f2aa2a15b5f Author: Sam James gentoo org> AuthorDate: Fri Aug 26 04:42:02 2022 + Commit: Sam James gentoo org> CommitDate: Sat Jan 14 20:04:05 2023 + URL:https://gitweb.gentoo.org/proj/devmanual.git/commit/?id=f5cec088 general-concepts/ebuild-revisions: clarify interaction with adding/removing USE flags Note that when adding a USE flag where the functionality was previously on (not off in build system), one must revbump because a dep was unconditional that now became conditional. Also, if removing a USE flag where the behaviour is now on, but was previously always off (not on in build system), one must revbump also, because people might have never set USE=foo (hence --changed-use wouldn't pick it up) but their deps have now effectively changed. Bug: https://github.com/pkgcore/pkgcheck/pull/435 Signed-off-by: Sam James gentoo.org> general-concepts/ebuild-revisions/text.xml | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/general-concepts/ebuild-revisions/text.xml b/general-concepts/ebuild-revisions/text.xml index ad394e8..e0c8b01 100644 --- a/general-concepts/ebuild-revisions/text.xml +++ b/general-concepts/ebuild-revisions/text.xml @@ -103,8 +103,14 @@ of thumb could be used as a guideline: (unless it is also a runtime dependency), -adding a new USE flag or removing an existing one (since change -in USE flags is going to trigger --changed-use rebuild), +adding a new USE flag if it controls a USE-dependency where the +functionality was hard-disabled in the build system before, + + +removing an existing USE flag if it controls a USE-dependency where the +functionality is now disabled entirely, rather than always being enabled +(since the change in USE flags is going to trigger a --changed-use +rebuild), a trivial stylistic / ebuild code change (as long as the new code
[gentoo-commits] proj/devmanual:master commit in: general-concepts/ebuild-revisions/
commit: 2b94b64306230dc3595150c5bba87ec0763d93a3 Author: Sam James gentoo org> AuthorDate: Tue Nov 8 04:31:16 2022 + Commit: Sam James gentoo org> CommitDate: Thu Nov 10 07:17:02 2022 + URL:https://gitweb.gentoo.org/proj/devmanual.git/commit/?id=2b94b643 general-concepts/ebuild-revisions: note which build-time fixes need a new revision Signed-off-by: Sam James gentoo.org> general-concepts/ebuild-revisions/text.xml | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/general-concepts/ebuild-revisions/text.xml b/general-concepts/ebuild-revisions/text.xml index fc5ba7c..b2fa57f 100644 --- a/general-concepts/ebuild-revisions/text.xml +++ b/general-concepts/ebuild-revisions/text.xml @@ -85,7 +85,11 @@ of thumb could be used as a guideline: adding a patch to fix a build-time issue that prevented users from building the package (since it does not affect users who already -managed to build it), +managed to build it) unless: it affected runtime behaviour in some way +(e.g. -Wformat or -Wimplicit-function-declaration fixes); +the package may have been miscompiled, or the change is substantial +(if adding a huge patch to fix a problem, the chances of an unexpected +issue being introduced by it are larger). adding a trivial documentation fix,
[gentoo-commits] proj/devmanual:master commit in: general-concepts/ebuild-revisions/
commit: ce68316d173482f9b82fb3255b1a657c08c80c56 Author: Sam James gentoo org> AuthorDate: Tue Nov 8 04:31:33 2022 + Commit: Sam James gentoo org> CommitDate: Thu Nov 10 07:17:03 2022 + URL:https://gitweb.gentoo.org/proj/devmanual.git/commit/?id=ce68316d general-concepts/ebuild-revisions: note that build failures may be a missing rdepend If, for example, a "qtcore" missing dependency results in a src_configure failure and a bug is filed, that doesn't mean a revbump can be skipped, as for others, if they had qtcore installed already, the package is silently linked against it without it being recorded as a dependency. Signed-off-by: Sam James gentoo.org> general-concepts/ebuild-revisions/text.xml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/general-concepts/ebuild-revisions/text.xml b/general-concepts/ebuild-revisions/text.xml index b2fa57f..ad394e8 100644 --- a/general-concepts/ebuild-revisions/text.xml +++ b/general-concepts/ebuild-revisions/text.xml @@ -89,7 +89,7 @@ of thumb could be used as a guideline: (e.g. -Wformat or -Wimplicit-function-declaration fixes); the package may have been miscompiled, or the change is substantial (if adding a huge patch to fix a problem, the chances of an unexpected -issue being introduced by it are larger). +issue being introduced by it are greater). adding a trivial documentation fix, @@ -99,7 +99,8 @@ of thumb could be used as a guideline: is expected soon), -adding a missing build-time dependency that caused a build failure, +adding a missing build-time dependency that caused a build failure +(unless it is also a runtime dependency), adding a new USE flag or removing an existing one (since change
[gentoo-commits] proj/devmanual:master commit in: general-concepts/ebuild-revisions/, ebuild-maintenance/removal/
commit: 118ac514581c8992df1b19aee1663b6a7f7607c4 Author: Sam James gentoo org> AuthorDate: Thu Oct 6 13:06:23 2022 + Commit: Sam James gentoo org> CommitDate: Fri Oct 14 21:49:36 2022 + URL:https://gitweb.gentoo.org/proj/devmanual.git/commit/?id=118ac514 ebuild-maintenance/removal: Change inconsistent virtual revbump policy This partly reverts commit f28b85f069c70538c618a3cedece77a359601dd8. There's no reason to treat virtuals differently here, there's no exception for it in how Portage works, and it may cause upgrade difficulties for users. It's also led to extensive confusion with contributors & new developers as we have to try to explain the inconsistency between devmanual and policy for non-virtuals. See: https://github.com/gentoo/gentoo/pull/27637 Closes: https://github.com/gentoo/devmanual/pull/303 Signed-off-by: Sam James gentoo.org> ebuild-maintenance/removal/text.xml| 6 ++ general-concepts/ebuild-revisions/text.xml | 5 - 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/ebuild-maintenance/removal/text.xml b/ebuild-maintenance/removal/text.xml index de3a9c1..5413a06 100644 --- a/ebuild-maintenance/removal/text.xml +++ b/ebuild-maintenance/removal/text.xml @@ -113,10 +113,8 @@ In order to remove a virtual package, follow the following procedure: Wait the time appropriate for the last rites. -Update all ebuilds not to reference the virtual. Since there is -no urgent need to remove the virtual from user systems -and the resulting rebuilds would be unnecessary, do not bump ebuilds -when replacing the dependency. +Update all ebuilds not to reference the virtual, following normal + policy Remove the package directly diff --git a/general-concepts/ebuild-revisions/text.xml b/general-concepts/ebuild-revisions/text.xml index b274841..fc5ba7c 100644 --- a/general-concepts/ebuild-revisions/text.xml +++ b/general-concepts/ebuild-revisions/text.xml @@ -108,11 +108,6 @@ of thumb could be used as a guideline: a dependency change that is a result of a package move (slot move), - -a dependency change due to - -removal of a virtual package. -
[gentoo-commits] proj/devmanual:master commit in: general-concepts/ebuild-revisions/
commit: 961b201b450c52b5835a995a7c6812497d36 Author: Ulrich Müller gentoo org> AuthorDate: Fri Sep 24 14:05:23 2021 + Commit: Ulrich Müller gentoo org> CommitDate: Fri Sep 24 14:05:23 2021 + URL:https://gitweb.gentoo.org/proj/devmanual.git/commit/?id=961b2033 general-concepts/ebuild-revisions: Fix link syntax Fixes: 22a7fb2ca3bc0897a80b27470da1f9b5f06dd874 Signed-off-by: Ulrich Müller gentoo.org> general-concepts/ebuild-revisions/text.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/general-concepts/ebuild-revisions/text.xml b/general-concepts/ebuild-revisions/text.xml index 55e1387..755e0cf 100644 --- a/general-concepts/ebuild-revisions/text.xml +++ b/general-concepts/ebuild-revisions/text.xml @@ -111,8 +111,8 @@ of thumb could be used as a guideline: a dependency change due to - -removal of a virtual package. + +removal of a virtual package.
[gentoo-commits] proj/devmanual:master commit in: general-concepts/ebuild-revisions/
commit: 22a7fb2ca3bc0897a80b27470da1f9b5f06dd874 Author: Joonas Niilola gentoo org> AuthorDate: Mon Sep 6 12:48:05 2021 + Commit: Joonas Niilola gentoo org> CommitDate: Fri Sep 24 11:59:38 2021 + URL:https://gitweb.gentoo.org/proj/devmanual.git/commit/?id=22a7fb2c general-concepts/ebuild-revisions: mention removing a virtual pkg Signed-off-by: Joonas Niilola gentoo.org> general-concepts/ebuild-revisions/text.xml | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/general-concepts/ebuild-revisions/text.xml b/general-concepts/ebuild-revisions/text.xml index 00e60c5..89ed8ea 100644 --- a/general-concepts/ebuild-revisions/text.xml +++ b/general-concepts/ebuild-revisions/text.xml @@ -105,7 +105,12 @@ of thumb could be used as a guideline: is equivalent to the old code), -a dependency change that is a result of a package move (slot move). +a dependency change that is a result of a package move (slot move), + + +a dependency change due to + +removal of a virtual package.
[gentoo-commits] proj/devmanual:master commit in: general-concepts/ebuild-revisions/
commit: cca1990a25e204e5c8dd6cbbad0f0436a26c3115 Author: Joonas Niilola gentoo org> AuthorDate: Mon Sep 6 12:56:23 2021 + Commit: Joonas Niilola gentoo org> CommitDate: Fri Sep 24 11:59:38 2021 + URL:https://gitweb.gentoo.org/proj/devmanual.git/commit/?id=cca1990a general-concepts/ebuild-revisions: clarify the automagic dep detection - the current example is very hard to realize what it means, I'm only guessing it means automagic dep detection? Let's update it to make it clearer? Signed-off-by: Joonas Niilola gentoo.org> general-concepts/ebuild-revisions/text.xml | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/general-concepts/ebuild-revisions/text.xml b/general-concepts/ebuild-revisions/text.xml index 89ed8ea..1bcd23f 100644 --- a/general-concepts/ebuild-revisions/text.xml +++ b/general-concepts/ebuild-revisions/text.xml @@ -69,10 +69,7 @@ of thumb could be used as a guideline: adding a missing runtime dependency to one of the existing blocks, adding a binding subslot operator (:=) to a dependency, updating a dependency with default on/off USE flags, - -adding a missing build-time dependency that contributed to -a successfully yet incorrect build (e.g. missing some feature), - + fixing an automagic dependency detection from a build system, restricting a runtime dependency version, unless the := subslot operator is going to trigger a rebuild.
[gentoo-commits] proj/devmanual:master commit in: general-concepts/ebuild-revisions/
commit: dcde372b99383c87ffe2fed23061f9f42b61b101 Author: Joonas Niilola gentoo org> AuthorDate: Tue Sep 7 08:12:55 2021 + Commit: Joonas Niilola gentoo org> CommitDate: Fri Sep 24 11:59:38 2021 + URL:https://gitweb.gentoo.org/proj/devmanual.git/commit/?id=dcde372b general-concepts/ebuild-revisions: mention EAPI bump Signed-off-by: Joonas Niilola gentoo.org> general-concepts/ebuild-revisions/text.xml | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/general-concepts/ebuild-revisions/text.xml b/general-concepts/ebuild-revisions/text.xml index 1bcd23f..f5e8be8 100644 --- a/general-concepts/ebuild-revisions/text.xml +++ b/general-concepts/ebuild-revisions/text.xml @@ -72,7 +72,11 @@ of thumb could be used as a guideline: fixing an automagic dependency detection from a build system, restricting a runtime dependency version, unless the := -subslot operator is going to trigger a rebuild. +subslot operator is going to trigger a rebuild, + + +changing the EAPI (unless changes to the ebuild are trivial, and you can be +sure it won't break stable or reverse dependencies).
[gentoo-commits] proj/devmanual:master commit in: general-concepts/ebuild-revisions/
commit: 384ff6b951ddc1ecb29c241b54e96bc4c90bef39 Author: Joonas Niilola gentoo org> AuthorDate: Tue Sep 7 08:15:01 2021 + Commit: Joonas Niilola gentoo org> CommitDate: Fri Sep 24 11:59:38 2021 + URL:https://gitweb.gentoo.org/proj/devmanual.git/commit/?id=384ff6b9 general-concepts/ebuild-revisions: mention pkgdev as alternative Signed-off-by: Joonas Niilola gentoo.org> Closes: https://github.com/gentoo/devmanual/pull/248 general-concepts/ebuild-revisions/text.xml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/general-concepts/ebuild-revisions/text.xml b/general-concepts/ebuild-revisions/text.xml index f5e8be8..55e1387 100644 --- a/general-concepts/ebuild-revisions/text.xml +++ b/general-concepts/ebuild-revisions/text.xml @@ -52,8 +52,9 @@ of thumb could be used as a guideline: etc.) and it would not be propagated using other means, then the ebuild should be renamed to a new revision. If the package has stable keywords, they should be moved to the new revision without -dropping. To commit the ebuild, repoman commit ---straight-to-stable option should be used. +dropping. To commit the ebuild, repoman commit --straight-to-stable +option should be used. (Alternatively, pkgdev commit or git +commit paired with pkgcheck scan --commits).
[gentoo-commits] proj/devmanual:master commit in: general-concepts/ebuild-revisions/
commit: cec523e3124cd7cc04d688c397262935875ae35a Author: Sam James gentoo org> AuthorDate: Wed Jun 23 07:25:15 2021 + Commit: Ulrich Müller gentoo org> CommitDate: Sat Jul 3 16:18:56 2021 + URL:https://gitweb.gentoo.org/proj/devmanual.git/commit/?id=cec523e3 general-concepts/ebuild-revisions: add 'updating USE flag defaults' in dep as revbump reason Without revision bumping in cases where we change USE dep defaults in a dependency, the package manager will refuse an upgrade because newer versions of the dependency will not satisfy the requirements in the package. Closes: https://github.com/gentoo/devmanual/pull/232 Signed-off-by: Sam James gentoo.org> Signed-off-by: Ulrich Müller gentoo.org> general-concepts/ebuild-revisions/text.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/general-concepts/ebuild-revisions/text.xml b/general-concepts/ebuild-revisions/text.xml index 395cc7f..00e60c5 100644 --- a/general-concepts/ebuild-revisions/text.xml +++ b/general-concepts/ebuild-revisions/text.xml @@ -68,6 +68,7 @@ of thumb could be used as a guideline: installing additional files that could be useful to the user, adding a missing runtime dependency to one of the existing blocks, adding a binding subslot operator (:=) to a dependency, + updating a dependency with default on/off USE flags, adding a missing build-time dependency that contributed to a successfully yet incorrect build (e.g. missing some feature),
[gentoo-commits] proj/devmanual:master commit in: general-concepts/ebuild-revisions/
commit: f16a1ca58fc9761c0a7a65d82c115b3da651f3eb Author: Sam James gentoo org> AuthorDate: Wed Jun 23 07:23:24 2021 + Commit: Ulrich Müller gentoo org> CommitDate: Sat Jul 3 16:18:52 2021 + URL:https://gitweb.gentoo.org/proj/devmanual.git/commit/?id=f16a1ca5 general-concepts/ebuild-revisions: add 'subscribing with :=' as revbump reason A revision bump is needed for a rebuild to occur when e.g. ABI is broken. Without doing this, we're relying on Portage's preserve-libs feature which does not have to be enabled and is not specified by PMS. Signed-off-by: Sam James gentoo.org> Signed-off-by: Ulrich Müller gentoo.org> general-concepts/ebuild-revisions/text.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/general-concepts/ebuild-revisions/text.xml b/general-concepts/ebuild-revisions/text.xml index c370d27..395cc7f 100644 --- a/general-concepts/ebuild-revisions/text.xml +++ b/general-concepts/ebuild-revisions/text.xml @@ -67,6 +67,7 @@ of thumb could be used as a guideline: adding a patch to fix a runtime issue, installing additional files that could be useful to the user, adding a missing runtime dependency to one of the existing blocks, + adding a binding subslot operator (:=) to a dependency, adding a missing build-time dependency that contributed to a successfully yet incorrect build (e.g. missing some feature),
[gentoo-commits] proj/devmanual:master commit in: general-concepts/ebuild-revisions/
commit: 253075dc4fcb9cac1567caff2891e47fd76453f4 Author: Michał Górny gentoo org> AuthorDate: Sun Aug 6 12:25:23 2017 + Commit: Göktürk Yüksek gentoo org> CommitDate: Mon Sep 25 04:14:52 2017 + URL:https://gitweb.gentoo.org/proj/devmanual.git/commit/?id=253075dc general-concepts/ebuild-revisions: Provide examples for when to revbump or not Provide a wider set of examples when to revbump or not. general-concepts/ebuild-revisions/text.xml | 51 ++ 1 file changed, 44 insertions(+), 7 deletions(-) diff --git a/general-concepts/ebuild-revisions/text.xml b/general-concepts/ebuild-revisions/text.xml index d18d333..c370d27 100644 --- a/general-concepts/ebuild-revisions/text.xml +++ b/general-concepts/ebuild-revisions/text.xml @@ -62,13 +62,50 @@ of thumb could be used as a guideline: - -Simple compile fixes do not warrant a revision bump; this is because they do -not affect the installed package for users who already managed to compile it. -Small documentation fixes are also usually not grounds for a new revision. -In particular, this applies if the package has a substantial compilation -time; developers should use their best judgement in these circumstances. - +Examples of changes that warrant a new revision are: + + adding a patch to fix a runtime issue, + installing additional files that could be useful to the user, + adding a missing runtime dependency to one of the existing blocks, + +adding a missing build-time dependency that contributed to +a successfully yet incorrect build (e.g. missing some feature), + + +restricting a runtime dependency version, unless the := +subslot operator is going to trigger a rebuild. + + + +Examples of changes that can be done without a revision bump are: + + +adding a patch to fix a build-time issue that prevented users from +building the package (since it does not affect users who already +managed to build it), + + adding a trivial documentation fix, + +installing an additional file of relatively little value (minor +documentation, editor syntax file, bash completion) compared +to the cost of rebuilding the package (especially if a new bump +is expected soon), + + +adding a missing build-time dependency that caused a build failure, + + +adding a new USE flag or removing an existing one (since change +in USE flags is going to trigger --changed-use rebuild), + + +a trivial stylistic / ebuild code change (as long as the new code +is equivalent to the old code), + + +a dependency change that is a result of a package move (slot move). + +
[gentoo-commits] proj/devmanual:master commit in: general-concepts/ebuild-revisions/
commit: ed57d7479b904aa765841b03d92742be9d8276db Author: Michał Górny gentoo org> AuthorDate: Sun Aug 6 11:38:41 2017 + Commit: Göktürk Yüksek gentoo org> CommitDate: Mon Sep 25 04:09:47 2017 + URL:https://gitweb.gentoo.org/proj/devmanual.git/commit/?id=ed57d747 general-concepts/ebuild-revisions: by default -> when empty (more precise) general-concepts/ebuild-revisions/text.xml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/general-concepts/ebuild-revisions/text.xml b/general-concepts/ebuild-revisions/text.xml index 012745f..f2d7234 100644 --- a/general-concepts/ebuild-revisions/text.xml +++ b/general-concepts/ebuild-revisions/text.xml @@ -8,8 +8,9 @@ Ebuilds may have a Gentoo revision number associated with them. This is a -rX suffix, where X is an integer see . This -component must only be used for Gentoo changes, not upstream releases. By -default, -r0 is implied. +component must only be used for Gentoo changes, not upstream releases. +An ebuild with no explicit revision number has the implicit -r0 +revision.
[gentoo-commits] proj/devmanual:master commit in: general-concepts/ebuild-revisions/
commit: 1025a862ea563b5ae0c2e42f36395c4d7b516f95 Author: Michał Górny gentoo org> AuthorDate: Sun Aug 6 12:14:34 2017 + Commit: Göktürk Yüksek gentoo org> CommitDate: Mon Sep 25 04:10:53 2017 + URL:https://gitweb.gentoo.org/proj/devmanual.git/commit/?id=1025a862 general-concepts/ebuild-revisions: Provide a 3-step guide for when to revbump general-concepts/ebuild-revisions/text.xml | 49 +++--- 1 file changed, 32 insertions(+), 17 deletions(-) diff --git a/general-concepts/ebuild-revisions/text.xml b/general-concepts/ebuild-revisions/text.xml index b0c0d97..d18d333 100644 --- a/general-concepts/ebuild-revisions/text.xml +++ b/general-concepts/ebuild-revisions/text.xml @@ -28,13 +28,39 @@ revision. -Ebuilds should have their -rX incremented whenever a change is made which -will make a substantial difference to what gets installed by the package by -substantial, we generally mean "something for which many users would want to -upgrade". This is usually for bugfixes. -For any such revision bump, the new ebuild should be based on the -previous revision to ensure that fixes aren't dropped accidentally. +Developers are encouraged to use common sense when determining +whether to introduce a new -rX revision. The following rule +of thumb could be used as a guideline: + + +If the change can cause the package to be broken to the point +of requiring users to revert to the previous version (in the case +of packages marked stable, every non-trivial change is classified +as such), then a new revision should be introduced and the old one +kept. If the package has stable keywords, the new revision should +be dropped to ~arch (see +). +For any such revision bump, the new ebuild should be based +on the previous revision to ensure that fixes aren't dropped +accidentally. + + + +If the change makes a substantial difference to the user who already +installed the package (fixes runtime issues, changes installed files, +etc.) and it would not be propagated using other means, then +the ebuild should be renamed to a new revision. If the package has +stable keywords, they should be moved to the new revision without +dropping. To commit the ebuild, repoman commit +--straight-to-stable option should be used. + + + +Otherwise, the change can be done in place in the current revision +of the ebuild. + + Simple compile fixes do not warrant a revision bump; this is because they do @@ -44,17 +70,6 @@ In particular, this applies if the package has a substantial compilation time; developers should use their best judgement in these circumstances. - -For ebuilds marked stable on at least one arch, only trivial edits can be made -without a bump (e.g. typo fixes in elog messages). Even simple changes may -result in a breakage. Modifying stable ebuilds should be avoided. - - - -When doing a revision bump, the usual rules about dropping to ~arch apply. -See . - -
[gentoo-commits] proj/devmanual:master commit in: general-concepts/ebuild-revisions/
commit: c487cdb2874911a5495f2f05dae89d4253fa260f Author: Michał Górny gentoo org> AuthorDate: Sun Aug 6 11:45:35 2017 + Commit: Göktürk Yüksek gentoo org> CommitDate: Mon Sep 25 04:10:26 2017 + URL:https://gitweb.gentoo.org/proj/devmanual.git/commit/?id=c487cdb2 general-concepts/ebuild-revisions: Clearly define the purpose of revisions general-concepts/ebuild-revisions/text.xml | 14 ++ 1 file changed, 14 insertions(+) diff --git a/general-concepts/ebuild-revisions/text.xml b/general-concepts/ebuild-revisions/text.xml index f2d7234..b0c0d97 100644 --- a/general-concepts/ebuild-revisions/text.xml +++ b/general-concepts/ebuild-revisions/text.xml @@ -13,6 +13,20 @@ An ebuild with no explicit revision number has the implicit -r0 revision. +Ebuild revisions usually serve two purposes: + + +keeping an older copy of an ebuild around when doing a potentially +breaking change, and + + + +propagating the rebuild of a package when performing a meaningful +change that would otherwise go unnoticed by users who have installed +the current version already. + + + Ebuilds should have their -rX incremented whenever a change is made which will make a substantial difference to what gets installed by the package by
[gentoo-commits] proj/devmanual:master commit in: general-concepts/ebuild-revisions/
commit: 2a7992696a79c344de41c814a756d5f9f4836f8e Author: Ulrich Müller ulm AT gentoo DOT org AuthorDate: Sun May 3 16:53:26 2015 + Commit: Ulrich Müller ulm AT gentoo DOT org CommitDate: Sun May 3 16:53:26 2015 + URL:https://gitweb.gentoo.org/proj/devmanual.git/commit/?id=2a799269 Merge remarks about revision bumps from Developer Handbook. This is taken from proj/en/devrel/handbook/hb-policy-ebuild.xml, section Ebuild policy, subsection Versioning and revision bumps. Permission to reuse the CC-BY-SA-1.0 work under CC-BY-SA-2.0 (or any later version) obtained from author plasmaroo per e-mail on 2015-04-16. general-concepts/ebuild-revisions/text.xml | 4 1 file changed, 4 insertions(+) diff --git a/general-concepts/ebuild-revisions/text.xml b/general-concepts/ebuild-revisions/text.xml index 9ddc39f..012745f 100644 --- a/general-concepts/ebuild-revisions/text.xml +++ b/general-concepts/ebuild-revisions/text.xml @@ -17,12 +17,16 @@ Ebuilds should have their c-rX/c incremented whenever a change is made which will make a substantial difference to what gets installed by the package d/ by substantial, we generally mean something for which many users would want to upgrade. This is usually for bugfixes. +For any such revision bump, the new ebuild should be based on the +previous revision to ensure that fixes aren't dropped accidentally. /p p Simple compile fixes do bnot/b warrant a revision bump; this is because they do not affect the installed package for users who already managed to compile it. Small documentation fixes are also usually not grounds for a new revision. +In particular, this applies if the package has a substantial compilation +time; developers should use their best judgement in these circumstances. /p important
