[gentoo-dev] USE flag name collision in use.local.desc "graphite"

2017-04-29 Thread Walter Dnes
  Is it considered a reportable bug?

[i660][waltdnes][~] grep :graphite /usr/portage/profiles/*.desc
/usr/portage/profiles/use.local.desc:dev-lang/gnat-gpl:graphite - Add support 
for the framework for loop optimizations based on a polyhedral intermediate 
representation
/usr/portage/profiles/use.local.desc:media-libs/harfbuzz:graphite - Use 
graphite to render complex non-Roman writing systems
/usr/portage/profiles/use.local.desc:sys-devel/gcc:graphite - Add support for 
the framework for loop optimizations based on a polyhedral intermediate 
representation

  The "graphite" USE flag means something entirely different for
harfbuzz, i.e. build media-libs/harfbuzz against media-gfx/graphite2

-- 
Walter Dnes 
I don't run "desktop environments"; I run useful applications



Re: [gentoo-dev] [PATCH] app-portage/eclass-manpages: @DEFAULT_UNSET -> @DEFAULT-UNSET

2017-04-29 Thread Davide Pesavento
On Sat, Apr 29, 2017 at 1:40 PM, Michał Górny  wrote:
> Dnia 29 kwietnia 2017 19:23:49 CEST, Davide Pesavento  
> napisał(a):
>>On Sat, Apr 29, 2017 at 1:57 AM, Michał Górny 
>>wrote:
>>> On sob, 2017-04-29 at 05:41 +0200, Ulrich Mueller wrote:
 > > > > > On Fri, 28 Apr 2017, Michał Górny wrote:
 > (and hyphens do not require holding shift).

 So they are awkward to type inside a string that is all-caps?

>>>
>>> Funny enough, yes. I naturally let shift go when pushing '-' ;-).
>>> Some habit, probably. And I bet some people might actually use caps
>>> lock.
>>
>>So please remind me why everyone else has to adapt to your habits?
>
> Because I cared enough to do the work. If you want it the other way around, 
> then send the reverse patch instead of giving asshole comments.
>

Fair enough. FTR, I have no preference either way, this is 100%
bikeshedding if you ask me.

Also, I didn't mean to be rude, just wanted to point out that what you
said about being easier to type might not apply to everybody (in fact,
the opposite is probably true for most people). Another point against
hyphens is that all ebuild variables use underscore. But as I said I'm
fine either way.



Re: [gentoo-dev] [PATCH] app-portage/eclass-manpages: @DEFAULT_UNSET -> @DEFAULT-UNSET

2017-04-29 Thread Kent Fredric
On Fri, 28 Apr 2017 16:39:45 +0200
Michał Górny  wrote:

> Change the unset value tag to '@DEFAULT-UNSET' to ensure consistent
> use of hyphen/underscore throughout eclassdoc. Before, one tag
> (@ECLASS-VARIABLE) has used hyphen while also one (@DEFAULT_UNSET)
> used underscore. Unify them to use the former since @ECLASS-VARIABLE
> tag is more common (and hyphens do not require holding shift).
> 
> Fixing all existing uses is perfectly within our power; however, I
> think it would be reasonable to delay it and combine with other
> eclass changes to avoid unnecessary cache regen. The script still
> allows the old tag name for compatibility.

I have a counter suggestion:

1. Leave @ECLASS-VARIABLE as-is
2. Leave @DEFAULT_UNSET as is
3. Document that underscores are to be used for all new tags
4. Add support for @ECLASS_VARIABLE that works the same as
   @ECLASS-VARIABLE
5. Don't go out of our way to migrate to @ECLASS_VARIABLE, just let it
   occur over time, particularly in conjunction with other major
   changes.

Mostly because @FOO_VARIABLE is suspiciously similar syntax to me as
other ALL CAPS variables used as ENV tokens in Bash.

And I can't think of a single instance where I've seen a language with
a convention that used ALL CAPS terms in conjunctions with hyphens,
( and regex with _ are ultimately simpler to reason about than ones
with - )



pgp7tMTHidiNj.pgp
Description: OpenPGP digital signature


Re: [gentoo-dev] [PATCH] app-portage/eclass-manpages: @DEFAULT_UNSET -> @DEFAULT-UNSET

2017-04-29 Thread Michał Górny
Dnia 29 kwietnia 2017 19:23:49 CEST, Davide Pesavento  
napisał(a):
>On Sat, Apr 29, 2017 at 1:57 AM, Michał Górny 
>wrote:
>> On sob, 2017-04-29 at 05:41 +0200, Ulrich Mueller wrote:
>>> > > > > > On Fri, 28 Apr 2017, Michał Górny wrote:
>>> > (and hyphens do not require holding shift).
>>>
>>> So they are awkward to type inside a string that is all-caps?
>>>
>>
>> Funny enough, yes. I naturally let shift go when pushing '-' ;-).
>> Some habit, probably. And I bet some people might actually use caps
>> lock.
>
>So please remind me why everyone else has to adapt to your habits?

Because I cared enough to do the work. If you want it the other way around, 
then send the reverse patch instead of giving asshole comments.

-- 
Best regards,
Michał Górny (by phone)



Re: [gentoo-dev] [PATCH] app-portage/eclass-manpages: @DEFAULT_UNSET -> @DEFAULT-UNSET

2017-04-29 Thread Davide Pesavento
On Sat, Apr 29, 2017 at 1:57 AM, Michał Górny  wrote:
> On sob, 2017-04-29 at 05:41 +0200, Ulrich Mueller wrote:
>> > > > > > On Fri, 28 Apr 2017, Michał Górny wrote:
>> > (and hyphens do not require holding shift).
>>
>> So they are awkward to type inside a string that is all-caps?
>>
>
> Funny enough, yes. I naturally let shift go when pushing '-' ;-).
> Some habit, probably. And I bet some people might actually use caps
> lock.

So please remind me why everyone else has to adapt to your habits?