Re: [gentoo-dev] about commits in the future

[Robin H. Johnson]

On Wed, Feb 21, 2018 at 09:47:29AM +0100, Fabian Groffen wrote:
> Please consider commit 2fb923d758749be609c1daab2a72ad4f1ec4c2a9
> (use something like
>git log --pretty=fuller app-emulation/nemu/nemu-1.4.0.ebuild)
> 
> It was made roughly one day in the future.  I'm wondering:
> 1) is this bad at all?
that's a very subjective question.

> 2) if it is bad (got me confused for another reason) is it technically
>possible to reject such commits?
> 3) if 2) should we decide on some clock skew and reject anything which
>is beyond that?
I thought the existing hook SHOULD have rejected this, but I'm going to
go back and review that.

-- 
Robin Hugh Johnson
Gentoo Linux: Dev, Infra Lead, Foundation Treasurer
E-Mail   : robb...@gentoo.org
GnuPG FP : 11ACBA4F 4778E3F6 E4EDF38E B27B944E 34884E85
GnuPG FP : 7D0B3CEB E9B85B1F 825BCECF EE05E6F6 A48F6136


signature.asc
Description: Digital signature

[gentoo-dev] Last rites: net-libs/webkit-gtk:{2,3}

[Mart Raudsepp]

# Mart Raudsepp  (23 Feb 2018)
# Old net-libs/webkit-gtk SLOTs have hundreds of known security issues.
# Use the security safe net-libs webkit-gtk SLOT=4 instead via
# libraries and applications ported to gtk3 and webkit2gtk API.
# Masked for removal in 30 days. Bug #577068.
# Please keep this package.mask entry until at least 25th May 2018 for
# extra notification of the security vulnerabilities.
net-libs/webkit-gtk:2
net-libs/webkit-gtk:3

[gentoo-dev] Last rites: media-video/mplayer-resume

[Steve Dibb]

# Steve Dibb  (22 Feb 2018)
# Very old project of mine, hasn't worked in years, no plans to
# support, and media-video/mpv can provide resume playback by default.
# Masked for removal in 30 days. Bug #648568
media-video/mplayer-resume

[gentoo-dev] Last rites: media-libs/libdvdplay

[Steve Dibb]

# Steve Dibb  (22 Feb 2018)
# Dead upstream, never really used, libdvdread and libdvdnav provide
# DVD access.
# Masked for removal in 30 days. Bug #648566
media-libs/libdvdplay

[gentoo-dev] Last rites: media-video/aacskeys

[Steve Dibb]

# Steve Dibb  (22 Feb 2018)
# Dead upstream, long since replaced by libaacs for functionality.
# Masked for removal in 30 days. Bug #648560
media-video/aacskeys

[gentoo-dev] [PATCH] profiles.desc: Mark amd64-fbsd 11.1 profile stable

[Michał Górny]

Mark the main amd64-fbsd profile stable now that all depgraph breakages
are fixed and the arch is actively maintained. This should prevent
regressions from occurring due to developers forgetting to use 'repoman
full -d' or forgetting to file keywordreqs to us.

For users, this does not change much since there is no other stable
amd64-fbsd profile. In other words, it remains being the only non-exp
profile.
---
 profiles/profiles.desc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/profiles/profiles.desc b/profiles/profiles.desc
index f9576f29e4d8..a1dc6d20e46e 100644
--- a/profiles/profiles.desc
+++ b/profiles/profiles.desc
@@ -250,7 +250,7 @@ x86 default/linux/x86/17.0/systemd  
stable
 # Gentoo/FreeBSD Profiles
 # @MAINTAINER: b...@gentoo.org
 amd64-fbsd default/bsd/fbsd/amd64/9.1  exp
-amd64-fbsd default/bsd/fbsd/amd64/11.1 dev
+amd64-fbsd default/bsd/fbsd/amd64/11.1 stable
 amd64-fbsd default/bsd/fbsd/amd64/9.1/clangexp
 amd64-fbsd default/bsd/fbsd/amd64/11.1/clang   exp
 x86-fbsd   default/bsd/fbsd/x86/9.1exp
-- 
2.16.2

Re: [gentoo-portage-dev] [PATCH v2] FreeBSD: use os.*chflags() instead of calling external tool

[Zac Medico]

On 02/22/2018 11:06 AM, Michał Górny wrote:
> Use os.chflags() and os.lchflags() built-in functions instead of calling
> external 'chflags' tool on FreeBSD. This fixes major performance
> problems Portage has on FreeBSD.
> 
> Bug: https://bugs.gentoo.org/648432
> ---
>  pym/portage/__init__.py | 50 
> +++--
>  1 file changed, 3 insertions(+), 47 deletions(-)
> 
> diff --git a/pym/portage/__init__.py b/pym/portage/__init__.py
> index 0e036b12e..99f3f98ac 100644
> --- a/pym/portage/__init__.py
> +++ b/pym/portage/__init__.py
> @@ -419,54 +419,10 @@ def _shell_quote(s):
>  bsd_chflags = None
>  
>  if platform.system() in ('FreeBSD',):
> -
> + # TODO: remove this class?
>   class bsd_chflags(object):
> -
> - @classmethod
> - def chflags(cls, path, flags, opts=""):
> - cmd = ['chflags']
> - if opts:
> - cmd.append(opts)
> - cmd.append('%o' % (flags,))
> - cmd.append(path)
> -
> - if sys.hexversion < 0x302 and sys.hexversion >= 
> 0x300:
> - # Python 3.1 _execvp throws TypeError for 
> non-absolute executable
> - # path passed as bytes (see 
> https://bugs.python.org/issue8513).
> - fullname = process.find_binary(cmd[0])
> - if fullname is None:
> - raise exception.CommandNotFound(cmd[0])
> - cmd[0] = fullname
> -
> - encoding = _encodings['fs']
> - cmd = [_unicode_encode(x, encoding=encoding, 
> errors='strict')
> - for x in cmd]
> - proc = subprocess.Popen(cmd, stdout=subprocess.PIPE,
> - stderr=subprocess.STDOUT)
> - output = proc.communicate()[0]
> - status = proc.wait()
> - if os.WIFEXITED(status) and os.WEXITSTATUS(status) == 
> os.EX_OK:
> - return
> - # Try to generate an ENOENT error if appropriate.
> - if 'h' in opts:
> - _os_merge.lstat(path)
> - else:
> - _os_merge.stat(path)
> - # Make sure the binary exists.
> - if not portage.process.find_binary('chflags'):
> - raise 
> portage.exception.CommandNotFound('chflags')
> - # Now we're not sure exactly why it failed or what
> - # the real errno was, so just report EPERM.
> - output = _unicode_decode(output, encoding=encoding)
> - e = OSError(errno.EPERM, output)
> - e.errno = errno.EPERM
> - e.filename = path
> - e.message = output
> - raise e
> -
> - @classmethod
> - def lchflags(cls, path, flags):
> - return cls.chflags(path, flags, opts='-h')
> + chflags = os.chflags
> + lchflags = os.lchflags
>  
>  def load_mod(name):
>   modname = ".".join(name.split(".")[:-1])
> 

Looks good, thanks!
-- 
Thanks,
Zac



signature.asc
Description: OpenPGP digital signature

[gentoo-portage-dev] [PATCH v2] FreeBSD: use os.*chflags() instead of calling external tool

[Michał Górny]

Use os.chflags() and os.lchflags() built-in functions instead of calling
external 'chflags' tool on FreeBSD. This fixes major performance
problems Portage has on FreeBSD.

Bug: https://bugs.gentoo.org/648432
---
 pym/portage/__init__.py | 50 +++--
 1 file changed, 3 insertions(+), 47 deletions(-)

diff --git a/pym/portage/__init__.py b/pym/portage/__init__.py
index 0e036b12e..99f3f98ac 100644
--- a/pym/portage/__init__.py
+++ b/pym/portage/__init__.py
@@ -419,54 +419,10 @@ def _shell_quote(s):
 bsd_chflags = None
 
 if platform.system() in ('FreeBSD',):
-
+   # TODO: remove this class?
class bsd_chflags(object):
-
-   @classmethod
-   def chflags(cls, path, flags, opts=""):
-   cmd = ['chflags']
-   if opts:
-   cmd.append(opts)
-   cmd.append('%o' % (flags,))
-   cmd.append(path)
-
-   if sys.hexversion < 0x302 and sys.hexversion >= 
0x300:
-   # Python 3.1 _execvp throws TypeError for 
non-absolute executable
-   # path passed as bytes (see 
https://bugs.python.org/issue8513).
-   fullname = process.find_binary(cmd[0])
-   if fullname is None:
-   raise exception.CommandNotFound(cmd[0])
-   cmd[0] = fullname
-
-   encoding = _encodings['fs']
-   cmd = [_unicode_encode(x, encoding=encoding, 
errors='strict')
-   for x in cmd]
-   proc = subprocess.Popen(cmd, stdout=subprocess.PIPE,
-   stderr=subprocess.STDOUT)
-   output = proc.communicate()[0]
-   status = proc.wait()
-   if os.WIFEXITED(status) and os.WEXITSTATUS(status) == 
os.EX_OK:
-   return
-   # Try to generate an ENOENT error if appropriate.
-   if 'h' in opts:
-   _os_merge.lstat(path)
-   else:
-   _os_merge.stat(path)
-   # Make sure the binary exists.
-   if not portage.process.find_binary('chflags'):
-   raise 
portage.exception.CommandNotFound('chflags')
-   # Now we're not sure exactly why it failed or what
-   # the real errno was, so just report EPERM.
-   output = _unicode_decode(output, encoding=encoding)
-   e = OSError(errno.EPERM, output)
-   e.errno = errno.EPERM
-   e.filename = path
-   e.message = output
-   raise e
-
-   @classmethod
-   def lchflags(cls, path, flags):
-   return cls.chflags(path, flags, opts='-h')
+   chflags = os.chflags
+   lchflags = os.lchflags
 
 def load_mod(name):
modname = ".".join(name.split(".")[:-1])
-- 
2.16.2

Re: [gentoo-portage-dev] [PATCH] FreeBSD: use os.*chflags() instead of calling external tool

[Zac Medico]

On 02/22/2018 07:18 AM, Michał Górny wrote:
> - @classmethod
> - def lchflags(cls, path, flags):
> - return cls.chflags(path, flags, opts='-h')
> + @staticmethod
> + def chflags(path, flags):
> + return os.chflags(path, flags)
> +
> + @staticmethod
> + def lchflags(path, flags):
> + return os.lchflags(path, flags)

Can eliminate the indirect function call like this:

chflags = os.chflags
lchflags = os.lchflags

-- 
Thanks,
Zac



signature.asc
Description: OpenPGP digital signature

Re: [gentoo-portage-dev] [PATCH] FreeBSD: use os.*chflags() instead of calling external tool

[Zac Medico]

On 02/22/2018 07:18 AM, Michał Górny wrote:
> Use os.chflags() and os.lchflags() built-in functions instead of calling
> external 'chflags' tool on FreeBSD. This fixes major performance
> problems Portage has on FreeBSD.
> 
> Bug: https://bugs.gentoo.org/648432
> ---
>  pym/portage/__init__.py | 52 
> +++--
>  1 file changed, 7 insertions(+), 45 deletions(-)
> 
> diff --git a/pym/portage/__init__.py b/pym/portage/__init__.py
> index 0e036b12e..4f43a2c32 100644
> --- a/pym/portage/__init__.py
> +++ b/pym/portage/__init__.py
> @@ -422,51 +422,13 @@ if platform.system() in ('FreeBSD',):
>  
>   class bsd_chflags(object):
>  
> - @classmethod
> - def chflags(cls, path, flags, opts=""):
> - cmd = ['chflags']
> - if opts:
> - cmd.append(opts)
> - cmd.append('%o' % (flags,))
> - cmd.append(path)
> -
> - if sys.hexversion < 0x302 and sys.hexversion >= 
> 0x300:
> - # Python 3.1 _execvp throws TypeError for 
> non-absolute executable
> - # path passed as bytes (see 
> https://bugs.python.org/issue8513).
> - fullname = process.find_binary(cmd[0])
> - if fullname is None:
> - raise exception.CommandNotFound(cmd[0])
> - cmd[0] = fullname
> -
> - encoding = _encodings['fs']
> - cmd = [_unicode_encode(x, encoding=encoding, 
> errors='strict')
> - for x in cmd]
> - proc = subprocess.Popen(cmd, stdout=subprocess.PIPE,
> - stderr=subprocess.STDOUT)
> - output = proc.communicate()[0]
> - status = proc.wait()
> - if os.WIFEXITED(status) and os.WEXITSTATUS(status) == 
> os.EX_OK:
> - return
> - # Try to generate an ENOENT error if appropriate.
> - if 'h' in opts:
> - _os_merge.lstat(path)
> - else:
> - _os_merge.stat(path)
> - # Make sure the binary exists.
> - if not portage.process.find_binary('chflags'):
> - raise 
> portage.exception.CommandNotFound('chflags')
> - # Now we're not sure exactly why it failed or what
> - # the real errno was, so just report EPERM.
> - output = _unicode_decode(output, encoding=encoding)
> - e = OSError(errno.EPERM, output)
> - e.errno = errno.EPERM
> - e.filename = path
> - e.message = output
> - raise e
> -
> - @classmethod
> - def lchflags(cls, path, flags):
> - return cls.chflags(path, flags, opts='-h')
> + @staticmethod
> + def chflags(path, flags):
> + return os.chflags(path, flags)
> +
> + @staticmethod
> + def lchflags(path, flags):
> + return os.lchflags(path, flags)
>  
>  def load_mod(name):
>   modname = ".".join(name.split(".")[:-1])
> 

Looks good, please merge.
-- 
Thanks,
Zac



signature.asc
Description: OpenPGP digital signature

[gentoo-portage-dev] [PATCH] FreeBSD: use os.*chflags() instead of calling external tool

[Michał Górny]

Use os.chflags() and os.lchflags() built-in functions instead of calling
external 'chflags' tool on FreeBSD. This fixes major performance
problems Portage has on FreeBSD.

Bug: https://bugs.gentoo.org/648432
---
 pym/portage/__init__.py | 52 +++--
 1 file changed, 7 insertions(+), 45 deletions(-)

diff --git a/pym/portage/__init__.py b/pym/portage/__init__.py
index 0e036b12e..4f43a2c32 100644
--- a/pym/portage/__init__.py
+++ b/pym/portage/__init__.py
@@ -422,51 +422,13 @@ if platform.system() in ('FreeBSD',):
 
class bsd_chflags(object):
 
-   @classmethod
-   def chflags(cls, path, flags, opts=""):
-   cmd = ['chflags']
-   if opts:
-   cmd.append(opts)
-   cmd.append('%o' % (flags,))
-   cmd.append(path)
-
-   if sys.hexversion < 0x302 and sys.hexversion >= 
0x300:
-   # Python 3.1 _execvp throws TypeError for 
non-absolute executable
-   # path passed as bytes (see 
https://bugs.python.org/issue8513).
-   fullname = process.find_binary(cmd[0])
-   if fullname is None:
-   raise exception.CommandNotFound(cmd[0])
-   cmd[0] = fullname
-
-   encoding = _encodings['fs']
-   cmd = [_unicode_encode(x, encoding=encoding, 
errors='strict')
-   for x in cmd]
-   proc = subprocess.Popen(cmd, stdout=subprocess.PIPE,
-   stderr=subprocess.STDOUT)
-   output = proc.communicate()[0]
-   status = proc.wait()
-   if os.WIFEXITED(status) and os.WEXITSTATUS(status) == 
os.EX_OK:
-   return
-   # Try to generate an ENOENT error if appropriate.
-   if 'h' in opts:
-   _os_merge.lstat(path)
-   else:
-   _os_merge.stat(path)
-   # Make sure the binary exists.
-   if not portage.process.find_binary('chflags'):
-   raise 
portage.exception.CommandNotFound('chflags')
-   # Now we're not sure exactly why it failed or what
-   # the real errno was, so just report EPERM.
-   output = _unicode_decode(output, encoding=encoding)
-   e = OSError(errno.EPERM, output)
-   e.errno = errno.EPERM
-   e.filename = path
-   e.message = output
-   raise e
-
-   @classmethod
-   def lchflags(cls, path, flags):
-   return cls.chflags(path, flags, opts='-h')
+   @staticmethod
+   def chflags(path, flags):
+   return os.chflags(path, flags)
+
+   @staticmethod
+   def lchflags(path, flags):
+   return os.lchflags(path, flags)
 
 def load_mod(name):
modname = ".".join(name.split(".")[:-1])
-- 
2.16.2

[gentoo-dev] Last rites: dev-php/ZendFramework

[Brian Evans]

# Brian Evans  (22 Feb 2018)
# Multiple vulnerablities, branch EOL upstream.
# Masked for removal in 30 days. Bug #604182
dev-php/ZendFramework



signature.asc
Description: OpenPGP digital signature

[gentoo-dev] Last rites: media-sound/moodbar

[Michael Palimaka]

# Michael Palimaka  (22 Feb 2018)
# Plugin for removed package media-sound/amarok. Dead upstream.
# Depends on vulnerable gstreamer:0.10.
# Masked for removal in 30 days. Bug #629184.
media-sound/moodbar

[gentoo-dev] Last rites: dev-libs/libgames-support

[Mart Raudsepp]

# Mart Raudsepp  (22 Feb 2018)
# This package was renamed to dev-libs/libgnome-games-support without
# a pkgmove; everything in tree uses it now instead of libgames-support.
# Masked for removal in 30 days. Bug #648468.
dev-libs/libgames-support