Re: [gentoo-dev] [PATCH] use.desc: Improve description of USE=test
On Tue, Aug 21, 2018 at 9:21 PM Thomas Deutschmann wrote:
>
> On 2018-08-21 18:23, Michał Górny wrote:
> >> Wait, are you saying that I can set USE=-test while FEATURES=test is
> >> enabled? Is that a valid combination?
> >
> > Yes.
>
> The only thing I still don't understand yet: Do we support things like that?
>
> I.e. should we add things like
>
> > if has test ${FEATURES} && ! use test ; then
> > eerror "FEATURES=test requires USE=test."
> > die "FEATURES=test set but not USE=test"
> > fi
You should never look at FEATURES in an ebuild; it is not defined in
PMS and is very Portage-specific.
> if a package's src_test phase requires some conditional stuff or is it
> something like "user shoot himself into the foot" so we do *not* care
> because we still assume "if FEATURES=test, USE=test is *normally* set"?
Ebuilds should be adjusted to not depend on FEATURES=test matching
USE=test. Setting RESTRICT="!test? ( test )" is generally sufficient.
> Asking from user experience point of view: Imagine a user tries to
> emerge a package which will compile multiple hours and src_test just
> fails because some conditional stuff didn't run due to USE=-test
> accidentally set by the user (in the past or was forgotten).
What user is going to set FEATURS=test and USE=-test? It's such a
silly thing to worry about.
Please stop inflating the scope of the issue.
Re: [gentoo-dev] [PATCH] use.desc: Improve description of USE=test
On 2018-08-21 18:23, Michał Górny wrote:
>> Wait, are you saying that I can set USE=-test while FEATURES=test is
>> enabled? Is that a valid combination?
>
> Yes.
The only thing I still don't understand yet: Do we support things like that?
I.e. should we add things like
> if has test ${FEATURES} && ! use test ; then
> eerror "FEATURES=test requires USE=test."
> die "FEATURES=test set but not USE=test"
> fi
if a package's src_test phase requires some conditional stuff or is it
something like "user shoot himself into the foot" so we do *not* care
because we still assume "if FEATURES=test, USE=test is *normally* set"?
Asking from user experience point of view: Imagine a user tries to
emerge a package which will compile multiple hours and src_test just
fails because some conditional stuff didn't run due to USE=-test
accidentally set by the user (in the past or was forgotten).
The code above in an early phase like pkg_setup would prevent such a bad
user experience, not?
--
Regards,
Thomas Deutschmann / Gentoo Linux Developer
C4DD 695F A713 8F24 2AA1 5638 5849 7EE5 1D5D 74A5
signature.asc
Description: OpenPGP digital signature
Re: [gentoo-dev] [PATCH] use.desc: Improve description of USE=test
On 2018-08-21 22:06, Juippisi . wrote: > It's really annoying if you try to make some conditional stuff apply > using "if use test;" because it doesn't work with FEATURES="test". Yes, but these are bugs which are getting fixed. See bugs like https://bugs.gentoo.org/show_bug.cgi?id=664104. -- Regards, Thomas Deutschmann / Gentoo Linux Developer C4DD 695F A713 8F24 2AA1 5638 5849 7EE5 1D5D 74A5 signature.asc Description: OpenPGP digital signature
Re: [gentoo-dev] [arm17] [PATCH 0/3] toolchain-funcs.eclass: tc-is-softfloat for ARM and associated functions
On 21/08/18 21:38, James Le Cuirot wrote: > On Tue, 14 Aug 2018 21:33:01 +0100 > James Le Cuirot wrote: > >> I previously sent a single patch to this list entitled >> "Update tc-is-softfloat for new ARM tuples" but I have now added two >> further patches following the initial feedback. >> >> For the additional background behind these changes, please see: >> https://archives.gentoo.org/gentoo-dev/message/b55b141e76ae1e08279d6f5b33be8151 >> >> James Le Cuirot (3): >> toolchain-funcs.eclass: New tc-getTARGET_CPP function >> toolchain-funcs.eclass: tc-cpp-is-true function to simplify helpers >> toolchain-funcs.eclass: Update tc-is-softfloat for new ARM tuples >> >> eclass/toolchain-funcs.eclass | 138 +++--- >> 1 file changed, 96 insertions(+), 42 deletions(-) > There were no further comments so this has been pushed. > A commit id is often popular - not because we don't believe you pushed, but for any potential future reference :). signature.asc Description: OpenPGP digital signature
Re: [gentoo-dev] [arm17] [PATCH 0/3] toolchain-funcs.eclass: tc-is-softfloat for ARM and associated functions
On Tue, 14 Aug 2018 21:33:01 +0100 James Le Cuirot wrote: > I previously sent a single patch to this list entitled > "Update tc-is-softfloat for new ARM tuples" but I have now added two > further patches following the initial feedback. > > For the additional background behind these changes, please see: > https://archives.gentoo.org/gentoo-dev/message/b55b141e76ae1e08279d6f5b33be8151 > > James Le Cuirot (3): > toolchain-funcs.eclass: New tc-getTARGET_CPP function > toolchain-funcs.eclass: tc-cpp-is-true function to simplify helpers > toolchain-funcs.eclass: Update tc-is-softfloat for new ARM tuples > > eclass/toolchain-funcs.eclass | 138 +++--- > 1 file changed, 96 insertions(+), 42 deletions(-) There were no further comments so this has been pushed. -- James Le Cuirot (chewi) Gentoo Linux Developer pgpLDGRuknJDK.pgp Description: OpenPGP digital signature
Re: [gentoo-dev] [PATCH] use.desc: Improve description of USE=test
On 08/21/2018 10:06 PM, Juippisi . wrote: > On Tue, Aug 21, 2018 at 3:57 PM, Davide Pesavento wrote: > >> >> Wait, are you saying that I can set USE=-test while FEATURES=test is >> enabled? Is that a valid combination? >> > > It's really annoying if you try to make some conditional stuff apply using > "if use test;" because it doesn't work with FEATURES="test". > if it doesn't work with FEATURES="test" but is othervise verified it might be a case for a RESTRICT=test instead? That said, you'll find RESTRICT="!test? ( test )" in plenty of ebuilds, disabling the test phase if the use flag is unset altogether. -- Kristian Fiskerstrand OpenPGP keyblock reachable at hkp://pool.sks-keyservers.net fpr:94CB AFDD 3034 5109 5618 35AA 0B7F 8B60 E3ED FAE3 signature.asc Description: OpenPGP digital signature
Re: [gentoo-dev] [PATCH] use.desc: Improve description of USE=test
On Tue, Aug 21, 2018 at 3:57 PM, Davide Pesavento wrote: > > Wait, are you saying that I can set USE=-test while FEATURES=test is > enabled? Is that a valid combination? > It's really annoying if you try to make some conditional stuff apply using "if use test;" because it doesn't work with FEATURES="test".
Re: [gentoo-dev] [PATCH] use.desc: Improve description of USE=test
Dnia 21 sierpnia 2018 17:57:48 CEST, Davide Pesavento napisał(a): >On Tue, Aug 21, 2018 at 2:46 AM Michał Górny wrote: >> >> On Tue, 2018-08-21 at 01:54 -0400, Davide Pesavento wrote: >> > On Mon, Aug 20, 2018 at 11:00 AM Michał Górny >wrote: >> > > >> > > Improve the description of USE=test to clearly indicate what the >flag >> > > does instead of claiming it workaround for Portage. >> > > --- >> > > profiles/use.desc | 2 +- >> > > 1 file changed, 1 insertion(+), 1 deletion(-) >> > > >> > > Changed in v2: added description of FEATURES=test relevance >> > > >> > > diff --git a/profiles/use.desc b/profiles/use.desc >> > > index 078226b92250..bd360194a09b 100644 >> > > --- a/profiles/use.desc >> > > +++ b/profiles/use.desc >> > > @@ -338,7 +338,7 @@ taglib - Enable tagging support with taglib >> > > tcl - Add support the Tcl language >> > > tcmalloc - Use the dev-util/google-perftools libraries to >replace the malloc() implementation with a possibly faster one >> > > tcpd - Add support for TCP wrappers >> > > -test - Workaround to pull in packages needed to run with >FEATURES=test. Portage-2.1.2 handles this internally, so don't set it >in make.conf/package.use anymore >> > > +test - Enable dependencies and/or preparations necessary to run >tests (usually automatically controled by FEATURES=test but can be >switched independently) >> > >> > s/controled/controlled/ >> > s/switched/enabled/ >> >> It can also be disabled. Maybe 'toggled'? >> > >Wait, are you saying that I can set USE=-test while FEATURES=test is >enabled? Is that a valid combination? Yes. -- Best regards, Michał Górny (by phone)
Re: [gentoo-dev] [PATCH] use.desc: Improve description of USE=test
On Tue, Aug 21, 2018 at 11:57 AM Davide Pesavento wrote: > > On Tue, Aug 21, 2018 at 2:46 AM Michał Górny wrote: > > > > On Tue, 2018-08-21 at 01:54 -0400, Davide Pesavento wrote: > > > On Mon, Aug 20, 2018 at 11:00 AM Michał Górny wrote: > > > > > > > > Improve the description of USE=test to clearly indicate what the flag > > > > does instead of claiming it workaround for Portage. > > > > --- > > > > profiles/use.desc | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > Changed in v2: added description of FEATURES=test relevance > > > > > > > > diff --git a/profiles/use.desc b/profiles/use.desc > > > > index 078226b92250..bd360194a09b 100644 > > > > --- a/profiles/use.desc > > > > +++ b/profiles/use.desc > > > > @@ -338,7 +338,7 @@ taglib - Enable tagging support with taglib > > > > tcl - Add support the Tcl language > > > > tcmalloc - Use the dev-util/google-perftools libraries to replace the > > > > malloc() implementation with a possibly faster one > > > > tcpd - Add support for TCP wrappers > > > > -test - Workaround to pull in packages needed to run with > > > > FEATURES=test. Portage-2.1.2 handles this internally, so don't set it > > > > in make.conf/package.use anymore > > > > +test - Enable dependencies and/or preparations necessary to run tests > > > > (usually automatically controled by FEATURES=test but can be switched > > > > independently) > > > > > > s/controled/controlled/ > > > s/switched/enabled/ > > > > It can also be disabled. Maybe 'toggled'? > > > > Wait, are you saying that I can set USE=-test while FEATURES=test is > enabled? Is that a valid combination? make.conf(5) says the following regarding FEATURES=test: This feature implies the "test"USE flag if it is a member of IUSE, either explicitly or implicitly [...]. The "test" USE flag is also automatically disabled when the "test" feature is disabled. So, it looks like the whole "independently" part in the use desc is incorrect.
Re: [gentoo-dev] [PATCH] use.desc: Improve description of USE=test
On Tue, Aug 21, 2018 at 2:46 AM Michał Górny wrote: > > On Tue, 2018-08-21 at 01:54 -0400, Davide Pesavento wrote: > > On Mon, Aug 20, 2018 at 11:00 AM Michał Górny wrote: > > > > > > Improve the description of USE=test to clearly indicate what the flag > > > does instead of claiming it workaround for Portage. > > > --- > > > profiles/use.desc | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > Changed in v2: added description of FEATURES=test relevance > > > > > > diff --git a/profiles/use.desc b/profiles/use.desc > > > index 078226b92250..bd360194a09b 100644 > > > --- a/profiles/use.desc > > > +++ b/profiles/use.desc > > > @@ -338,7 +338,7 @@ taglib - Enable tagging support with taglib > > > tcl - Add support the Tcl language > > > tcmalloc - Use the dev-util/google-perftools libraries to replace the > > > malloc() implementation with a possibly faster one > > > tcpd - Add support for TCP wrappers > > > -test - Workaround to pull in packages needed to run with FEATURES=test. > > > Portage-2.1.2 handles this internally, so don't set it in > > > make.conf/package.use anymore > > > +test - Enable dependencies and/or preparations necessary to run tests > > > (usually automatically controled by FEATURES=test but can be switched > > > independently) > > > > s/controled/controlled/ > > s/switched/enabled/ > > It can also be disabled. Maybe 'toggled'? > Wait, are you saying that I can set USE=-test while FEATURES=test is enabled? Is that a valid combination?
[gentoo-dev] [PATCH v3] use.desc: Improve description of USE=test
Improve the description of USE=test to clearly indicate what the flag does instead of claiming it workaround for Portage. --- profiles/use.desc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/profiles/use.desc b/profiles/use.desc index 078226b92250..36fa72009cb4 100644 --- a/profiles/use.desc +++ b/profiles/use.desc @@ -338,7 +338,7 @@ taglib - Enable tagging support with taglib tcl - Add support the Tcl language tcmalloc - Use the dev-util/google-perftools libraries to replace the malloc() implementation with a possibly faster one tcpd - Add support for TCP wrappers -test - Workaround to pull in packages needed to run with FEATURES=test. Portage-2.1.2 handles this internally, so don't set it in make.conf/package.use anymore +test - Enable dependencies and/or preparations necessary to run tests (usually controlled by FEATURES=test but can be toggled independently) theora - Add support for the Theora Video Compression Codec threads - Add threads support for various packages. Usually pthreads tidy - Add support for HTML Tidy -- 2.18.0
Re: [gentoo-dev] [PATCH] use.desc: Improve description of USE=test
On Tue, 2018-08-21 at 01:54 -0400, Davide Pesavento wrote: > On Mon, Aug 20, 2018 at 11:00 AM Michał Górny wrote: > > > > Improve the description of USE=test to clearly indicate what the flag > > does instead of claiming it workaround for Portage. > > --- > > profiles/use.desc | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Changed in v2: added description of FEATURES=test relevance > > > > diff --git a/profiles/use.desc b/profiles/use.desc > > index 078226b92250..bd360194a09b 100644 > > --- a/profiles/use.desc > > +++ b/profiles/use.desc > > @@ -338,7 +338,7 @@ taglib - Enable tagging support with taglib > > tcl - Add support the Tcl language > > tcmalloc - Use the dev-util/google-perftools libraries to replace the > > malloc() implementation with a possibly faster one > > tcpd - Add support for TCP wrappers > > -test - Workaround to pull in packages needed to run with FEATURES=test. > > Portage-2.1.2 handles this internally, so don't set it in > > make.conf/package.use anymore > > +test - Enable dependencies and/or preparations necessary to run tests > > (usually automatically controled by FEATURES=test but can be switched > > independently) > > s/controled/controlled/ > s/switched/enabled/ It can also be disabled. Maybe 'toggled'? > > > theora - Add support for the Theora Video Compression Codec > > threads - Add threads support for various packages. Usually pthreads > > tidy - Add support for HTML Tidy > > -- > > 2.18.0 > > > > Thanks, > Davide > -- Best regards, Michał Górny signature.asc Description: This is a digitally signed message part
