Re: [gentoo-dev] [PATCH] meson.eclass: export NM and READELF variables

2020-04-20 Thread David Seifert
On Mon, 2020-04-20 at 11:18 -0400, Mike Gilbert wrote:
> These are used by the symbolextractor.py script in meson.
> 
> Closes: https://bugs.gentoo.org/717720
> Signed-off-by: Mike Gilbert 
> ---
>  eclass/meson.eclass | 5 +
>  1 file changed, 5 insertions(+)
> 
> diff --git a/eclass/meson.eclass b/eclass/meson.eclass
> index 2bd1dc017609..81cfa7c38fc6 100644
> --- a/eclass/meson.eclass
> +++ b/eclass/meson.eclass
> @@ -261,6 +261,11 @@ meson_src_configure() {
>   "${BUILD_DIR}"
>   )
>  
> + # Used by symbolextractor.py
> + # https://bugs.gentoo.org/717720
> + tc-export NM
> + tc-getPROG READELF readelf >/dev/null
> +
>   # https://bugs.gentoo.org/625396
>   python_export_utf8_locale
>  

+1
Thanks for adding this, LGTM.




[gentoo-dev] [PATCH] meson.eclass: export NM and READELF variables

2020-04-20 Thread Mike Gilbert
These are used by the symbolextractor.py script in meson.

Closes: https://bugs.gentoo.org/717720
Signed-off-by: Mike Gilbert 
---
 eclass/meson.eclass | 5 +
 1 file changed, 5 insertions(+)

diff --git a/eclass/meson.eclass b/eclass/meson.eclass
index 2bd1dc017609..81cfa7c38fc6 100644
--- a/eclass/meson.eclass
+++ b/eclass/meson.eclass
@@ -261,6 +261,11 @@ meson_src_configure() {
"${BUILD_DIR}"
)
 
+   # Used by symbolextractor.py
+   # https://bugs.gentoo.org/717720
+   tc-export NM
+   tc-getPROG READELF readelf >/dev/null
+
# https://bugs.gentoo.org/625396
python_export_utf8_locale
 
-- 
2.26.1