Re: [gentoo-dev] [PATCH v2 05/10] ruby-ng-gnome2.eclass: Use [[ instead of [

2020-05-03 Thread Michał Górny
On Mon, 2020-05-04 at 11:22 +0900, Naohiro Aota wrote:
> Signed-off-by: Naohiro Aota 
> ---
>  eclass/ruby-ng-gnome2.eclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/eclass/ruby-ng-gnome2.eclass b/eclass/ruby-ng-gnome2.eclass
> index 4f3f6011501b..ac112e006205 100644
> --- a/eclass/ruby-ng-gnome2.eclass
> +++ b/eclass/ruby-ng-gnome2.eclass
> @@ -77,7 +77,7 @@ each_ruby_install() {
>  # Install the files common to all ruby targets.
>  all_ruby_install() {
>   for doc in ../AUTHORS ../NEWS ChangeLog README; do
> - [ -s "$doc" ] && dodoc $doc
> + [[ -s "$doc" ]] && dodoc $doc

Use ${doc} while at it, please.  Also quoting is no longer necessary
in [[ ]].

>   done
>   if [[ -d sample ]]; then
>   insinto /usr/share/doc/${PF}

-- 
Best regards,
Michał Górny



signature.asc
Description: This is a digitally signed message part


[gentoo-dev] [PATCH v2 05/10] ruby-ng-gnome2.eclass: Use [[ instead of [

2020-05-03 Thread Naohiro Aota
Signed-off-by: Naohiro Aota 
---
 eclass/ruby-ng-gnome2.eclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/eclass/ruby-ng-gnome2.eclass b/eclass/ruby-ng-gnome2.eclass
index 4f3f6011501b..ac112e006205 100644
--- a/eclass/ruby-ng-gnome2.eclass
+++ b/eclass/ruby-ng-gnome2.eclass
@@ -77,7 +77,7 @@ each_ruby_install() {
 # Install the files common to all ruby targets.
 all_ruby_install() {
for doc in ../AUTHORS ../NEWS ChangeLog README; do
-   [ -s "$doc" ] && dodoc $doc
+   [[ -s "$doc" ]] && dodoc $doc
done
if [[ -d sample ]]; then
insinto /usr/share/doc/${PF}
-- 
2.26.2