Re: [gentoo-dev] [PATCH v2 3/4] app-admin/kube-bench: convert to go-module go.sum
On Mon, Feb 17, 2020 at 01:22:31AM -0800, Robin H. Johnson wrote: > Signed-off-by: Robin H. Johnson > --- > app-admin/kube-bench/Manifest | 351 > .../kube-bench/kube-bench-0.2.3-r1.ebuild | 394 ++ > 2 files changed, 745 insertions(+) > create mode 100644 app-admin/kube-bench/kube-bench-0.2.3-r1.ebuild > *snip manifest* > diff --git app-admin/kube-bench/kube-bench-0.2.3-r1.ebuild > app-admin/kube-bench/kube-bench-0.2.3-r1.ebuild > new file mode 100644 > index ..fcab0aed86e9 > --- /dev/null > +++ app-admin/kube-bench/kube-bench-0.2.3-r1.ebuild > @@ -0,0 +1,394 @@ > +# Copyright 1999-2019 Gentoo Authors > +# Distributed under the terms of the GNU General Public License v2 > + > +EAPI=7 > +EGO_PN=github.com/aquasecurity/kube-bench You shouldn't need EGO_PN > +DESCRIPTION="Kubernetes Bench for Security runs the CIS Kubernetes Benchmark" > +HOMEPAGE="https://github.com/aquasecurity/kube-bench"; > + > +EGO_SUM=( > + "cloud.google.com/go v0.26.0/go.mod > h1:aQUYkXzVsufM+DwF1aE+0xfcU+56JwCaLick0ClmMTw=" > + "cloud.google.com/go v0.34.0/go.mod > h1:aQUYkXzVsufM+DwF1aE+0xfcU+56JwCaLick0ClmMTw=" > + "cloud.google.com/go v0.37.4 > h1:glPeL3BQJsbF6aIIYfZizMwc5LTYz250bDMjttbBGAU=" > + "cloud.google.com/go v0.37.4/go.mod > h1:NHPJ89PdicEuT9hdPXMROBD91xc5uRDxsMtSB16k7hw=" > + "github.com/BurntSushi/toml v0.3.1 > h1:WXkYYl6Yr3qBf1K79EBnL4mak0OimBfB0XUf9Vl28OQ=" > + "github.com/BurntSushi/toml v0.3.1/go.mod > h1:xHWCNGjB5oqiDr8zfno3MHue2Ht5sIBksp03qcyfWMU=" > + "github.com/NYTimes/gziphandler > v0.0.0-20170623195520-56545f4a5d46/go.mod > h1:3wb06e3pkSAbeQ52E9H9iFoQsEEwGN64994WTCIhntQ=" > + "github.com/OneOfOne/xxhash v1.2.2/go.mod > h1:HSdplMjZKSmBqAxg5vPj2TmRDmfkzw+cTzAElWljhcU=" > + "github.com/PuerkitoBio/purell v1.0.0/go.mod > h1:c11w/QuzBsJSee3cPx9rAFu61PvFxuPbtSwDGJws/X0=" > + "github.com/PuerkitoBio/purell v1.1.1 > h1:WEQqlqaGbrPkxLJWfBwQmfEAE1Z7ONdDLqrN38tNFfI=" > + "github.com/PuerkitoBio/purell v1.1.1/go.mod > h1:c11w/QuzBsJSee3cPx9rAFu61PvFxuPbtSwDGJws/X0=" > + "github.com/PuerkitoBio/urlesc > v0.0.0-20160726150825-5bd2802263f2/go.mod > h1:uGdkoq3SwY9Y+13GIhn11/XLaGBb4BfwItxLd5jeuXE=" > + "github.com/PuerkitoBio/urlesc v0.0.0-20170810143723-de5bf2ad4578 > h1:d+Bc7a5rLufV/sSk/8dngufqelfh6jnri85riMAaF/M=" > + "github.com/PuerkitoBio/urlesc > v0.0.0-20170810143723-de5bf2ad4578/go.mod > h1:uGdkoq3SwY9Y+13GIhn11/XLaGBb4BfwItxLd5jeuXE=" > + "github.com/Shopify/sarama v1.19.0/go.mod > h1:FVkBWblsNy7DGZRfXLU0O9RCGt5g3g3yEuWXgklEdEo=" > + "github.com/Shopify/toxiproxy v2.1.4+incompatible/go.mod > h1:OXgGpZ6Cli1/URJOF1DMxUHB2q5Ap20/P/eIdh4G0pI=" > + "github.com/alecthomas/template > v0.0.0-20160405071501-a0175ee3bccc/go.mod > h1:LOuyumcjzFXgccqObfd/Ljyb9UuFJ6TxHnclSeseNhc=" > + "github.com/alecthomas/units v0.0.0-20151022065526-2efee857e7cf/go.mod > h1:ybxpYRFXyAe+OPACYpWeL0wqObRcbAqCMya13uyzqw0=" > + "github.com/apache/thrift v0.12.0/go.mod > h1:cp2SuWMxlEZw2r+iP2GNCdIi4C1qmUzdZFSVb+bacwQ=" > + "github.com/armon/consul-api v0.0.0-20180202201655-eb2c6b5be1b6/go.mod > h1:grANhF5doyWs3UAsr3K4I6qtAmlQcZDesFNEHPZAzj8=" > + "github.com/beorn7/perks v0.0.0-20180321164747-3a771d992973/go.mod > h1:Dwedo/Wpr24TaqPxmxbtue+5NUziq4I4S80YR8gNf3Q=" > + "github.com/beorn7/perks v1.0.0/go.mod > h1:KWe93zE9D1o94FZ5RNwFwVgaQK1VOXiVxmqh+CedLV8=" > + "github.com/cespare/xxhash v1.1.0/go.mod > h1:XrSqR1VqqWfGrhpAt58auRo0WTKS1nRRg3ghfAqPWnc=" > + "github.com/client9/misspell v0.3.4/go.mod > h1:qj6jICC3Q7zFZvVWo7KLAzC3yx5G7kyvSDkc90ppPyw=" > + "github.com/coreos/bbolt v1.3.2/go.mod > h1:iRUV2dpdMOn7Bo10OQBFzIJO9kkE559Wcmn+qkEiiKk=" > + "github.com/coreos/etcd v3.3.10+incompatible/go.mod > h1:uF7uidLiAD3TWHmW31ZFd/JWoc32PjwdhPthX9715RE=" > + "github.com/coreos/go-semver v0.2.0/go.mod > h1:nnelYz7RCh+5ahJtPPxZlU+153eP4D4r3EedlOD2RNk=" > + "github.com/coreos/go-systemd v0.0.0-20190321100706-95778dfbb74e/go.mod > h1:F5haX7vjVVG0kc13fIWeqUViNPyEJxv/OmvnBo0Yme4=" > + "github.com/coreos/pkg v0.0.0-20180928190104-399ea9e2e55f/go.mod > h1:E3G3o1h8I7cfcXa63jLwjI0eiQQMgzzUDFVpN/nH/eA=" > + "github.com/davecgh/go-spew v0.0.0-20151105211317-5215b55f46b2/go.mod > h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=" > + "github.com/davecgh/go-spew v1.1.0/go.mod > h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=" > + "github.com/davecgh/go-spew v1.1.1 > h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=" > + "github.com/davecgh/go-spew v1.1.1/go.mod > h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=" > + "github.com/denisenkom/go-mssqldb v0.0.0-20190515213511-eb9f6a1743f3 > h1:tkum0XDgfR0jcVVXuTsYv/erY2NnEDqwRojbxR1rBYA=" > + "github.com/denisenkom/go-mssqldb > v0.0.0-20190515213511-eb9f6a1743f3/go.mod > h1:zAg7JM8CkOJ43xKXIj7eRO9kmWm/TW578qo+oDO6tuM=" > + "github.com/dgrijalva/jwt-go v3.2.0+incompatible/go.mod > h
Re: [gentoo-dev] [PATCH v2 3/4] app-admin/kube-bench: convert to go-module go.sum
(WilliamH: apologies for duplicate, I replied directly to you instead of the list the first time around) On Wed, Feb 19, 2020 at 12:10:46AM -0600, William Hubbs wrote: > > +EGO_PN=github.com/aquasecurity/kube-bench > You shouldn't need EGO_PN Copied from th previous -r0. > > > +DESCRIPTION="Kubernetes Bench for Security runs the CIS Kubernetes > > Benchmark" > > +HOMEPAGE="https://github.com/aquasecurity/kube-bench"; > > + > > +EGO_SUM=( > > + "cloud.google.com/go v0.26.0/go.mod > > h1:aQUYkXzVsufM+DwF1aE+0xfcU+56JwCaLick0ClmMTw=" > > + "cloud.google.com/go v0.34.0/go.mod > > h1:aQUYkXzVsufM+DwF1aE+0xfcU+56JwCaLick0ClmMTw=" > > + "cloud.google.com/go v0.37.4 > > h1:glPeL3BQJsbF6aIIYfZizMwc5LTYz250bDMjttbBGAU=" > > + "cloud.google.com/go v0.37.4/go.mod > > h1:NHPJ89PdicEuT9hdPXMROBD91xc5uRDxsMtSB16k7hw=" ... > > +) > > There's a lot of duplication in here. For example, the only difference > between the last two lines is one has /go.mod tacked onto the end of the > version. Do we need both lines for each module? If we intend on validating h1: then yes, because we need to do it for the .zip and .mod. > > +src_unpack() { > > + unpack ${P}.tar.gz > > + go-module_src_unpack > > +} > Can we do this some how in go-module_src_unpack so we don't have to > boiler-plate it to every consumer? See discussion in eclass thread. -- Robin Hugh Johnson Gentoo Linux: Dev, Infra Lead, Foundation Treasurer E-Mail : robb...@gentoo.org GnuPG FP : 11ACBA4F 4778E3F6 E4EDF38E B27B944E 34884E85 GnuPG FP : 7D0B3CEB E9B85B1F 825BCECF EE05E6F6 A48F6136 signature.asc Description: PGP signature