Re: [gentoo-dev] Mailing list for ebuild review
On 02/19/2015 03:43 PM, Rich Freeman wrote: > > I believe the proposal was for this to be purely optional. As such I > completely support it (though I think we should consider just using > the -dev-help list if it is still functional). Purely optional. To correct my original email, the mailing list is gentoo-devhelp@. The name was apparently made hyphenless to avoid a collision with the #gentoo-dev-help IRC channel =)
Re: [gentoo-dev] Mailing list for ebuild review
On Thu, Feb 19, 2015 at 2:06 PM, Andrew Savchenko wrote: > Please explain this proposal in more detail. If code review is > supposed to be mandatory for each commit, this will effectively stop > development. If it is supposed to be used as an auxiliary but > not mandatory tool, e.g. when people are unsure of their changes or > need to review proxy-maintained commits and so on, I fully support > this idea. I believe the proposal was for this to be purely optional. As such I completely support it (though I think we should consider just using the -dev-help list if it is still functional). No argument that trying to change the overall workflow needs great care. If anything it would be useful to see how optional use of a review workflow works out and maybe learn from that. -- Rich
Re: [gentoo-dev] Mailing list for ebuild review
On Wed, 18 Feb 2015 15:13:31 -0500 Michael Orlitzky wrote: > The topic of a review workflow comes up frequently, but Gitlab, Gerrit, > etc. are blocked on a host of other problems that may never be resolved. > It would still be nice to be able to request reviews somewhere, and for > ebuilds, a mailing list combined with a threaded MUA works fine. > > Would anyone else find gentoo-review@lists.g.o useful? I think a lot of > simple problems could be quickly caught with a second set of eyeballs. > > There is already gentoo-dev-help@, but it's /very/ quiet. If we could > all agree to subscribe and do reviews there, that would work as well. Please explain this proposal in more detail. If code review is supposed to be mandatory for each commit, this will effectively stop development. If it is supposed to be used as an auxiliary but not mandatory tool, e.g. when people are unsure of their changes or need to review proxy-maintained commits and so on, I fully support this idea. Best regards, Andrew Savchenko pgp2yMNj5jcLX.pgp Description: PGP signature
Re: [gentoo-dev] Mailing list for ebuild review
Michael Orlitzky writes: > Would anyone else find gentoo-review@lists.g.o useful? I think a lot > of simple problems could be quickly caught with a second set of > eyeballs. +1 Many opensource projects successfully run code review on mailing lists. Why not try that. But this should be loudly announced. > There is already gentoo-dev-help@, but it's /very/ quiet. If we could > all agree to subscribe and do reviews there, that would work as well. I didn't even know about gentoo-dev-help and maybe it's not just me. Cheers, -- Amadeusz Żołnowski signature.asc Description: PGP signature
[gentoo-dev] Mailing list for ebuild review
The topic of a review workflow comes up frequently, but Gitlab, Gerrit, etc. are blocked on a host of other problems that may never be resolved. It would still be nice to be able to request reviews somewhere, and for ebuilds, a mailing list combined with a threaded MUA works fine. Would anyone else find gentoo-review@lists.g.o useful? I think a lot of simple problems could be quickly caught with a second set of eyeballs. There is already gentoo-dev-help@, but it's /very/ quiet. If we could all agree to subscribe and do reviews there, that would work as well.
