[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-cluster/pvfs2: ChangeLog pvfs2-2.6.3-r1.ebuild

2007-10-14 Thread Donnie Berkholz 
On 13:36 Sat 13 Oct , Matti Bickel (mabi) wrote:
 1.1  sys-cluster/pvfs2/pvfs2-2.6.3-r1.ebuild
 
 file : 
 http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-cluster/pvfs2/pvfs2-2.6.3-r1.ebuild?rev=1.1view=markup
 plain: 
 http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-cluster/pvfs2/pvfs2-2.6.3-r1.ebuild?rev=1.1content-type=text/plain

   if kernel_is 2 4; then
   BUILD_TARGETS=just_kmod24
   ECONF_PARAMS=--with-kernel24=${KV_DIR}
   MODULE_NAMES=pvfs2(fs::src/kernel/linux-2.4)

Feel free to drop 2.4 support.

   if kernel_is gt 2 6 20 ; then
   epatch ${FILESDIR}/${PV}-register_sysctl_table.patch
   fi
 
   if kernel_is ge 2 6 22 ; then
   epatch ${FILESDIR}/${PV}-kmem-and-dtor-fix.patch
   fi

Mixing 'gt' and 'ge' is a bad idea.

Thanks,
Donnie
-- 
[EMAIL PROTECTED] mailing list

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-cluster/pvfs2: ChangeLog pvfs2-2.6.3-r1.ebuild

2007-10-14 Thread Drake Wyrm 
Donnie Berkholz [EMAIL PROTECTED] wrote:
 On 13:36 Sat 13 Oct , Matti Bickel (mabi) wrote:
  if kernel_is gt 2 6 20 ; then
  epatch ${FILESDIR}/${PV}-register_sysctl_table.patch
  fi
  
  if kernel_is ge 2 6 22 ; then
  epatch ${FILESDIR}/${PV}-kmem-and-dtor-fix.patch
  fi
 
 Mixing 'gt' and 'ge' is a bad idea.

Just outa curiosity, why?

-- 
Each night Father fills me with dread
When he sits on the foot of my bed.
I'd not mind that he speaks; In gibbers and squeaks,
But for the seventeen years he's been dead.  --  Edward Gorey


pgpgSZPixPSBi.pgp
Description: PGP signature

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-cluster/pvfs2: ChangeLog pvfs2-2.6.3-r1.ebuild

2007-10-14 Thread Donnie Berkholz 
On 23:45 Sat 13 Oct , Drake Wyrm wrote:
 Donnie Berkholz [EMAIL PROTECTED] wrote:
  On 13:36 Sat 13 Oct , Matti Bickel (mabi) wrote:
 if kernel_is gt 2 6 20 ; then
 epatch ${FILESDIR}/${PV}-register_sysctl_table.patch
 fi
   
 if kernel_is ge 2 6 22 ; then
 epatch ${FILESDIR}/${PV}-kmem-and-dtor-fix.patch
 fi
  
  Mixing 'gt' and 'ge' is a bad idea.
 
 Just outa curiosity, why?

Because it's inconsistent and one generally assumes that people will be 
consistent with the way they test numbers. That way you only need to 
read the number rather than continually checking every single line to 
see how exactly it's tested for.

Thanks,
Donnie
-- 
[EMAIL PROTECTED] mailing list