[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-lang/ruby: ChangeLog ruby-1.8.6_p110.ebuild

2007-09-24 Thread Donnie Berkholz 
On 09:38 Mon 24 Sep , Richard Brown (rbrown) wrote:
 rbrown  07/09/24 09:38:33
 
   Modified: ChangeLog
   Added:ruby-1.8.6_p110.ebuild
   Log:
   Version bump
   (Portage version: 2.1.3.9)

 1.1  dev-lang/ruby/ruby-1.8.6_p110.ebuild
 
 file : 
 http://sources.gentoo.org/viewcvs.py/gentoo-x86/dev-lang/ruby/ruby-1.8.6_p110.ebuild?rev=1.1view=markup
 plain: 
 http://sources.gentoo.org/viewcvs.py/gentoo-x86/dev-lang/ruby/ruby-1.8.6_p110.ebuild?rev=1.1content-type=text/plain

 SRC_URI=ftp://ftp.ruby-lang.org/pub/ruby/1.8/${MY_P}.tar.gz

 SLOT=1.8

   !=dev-lang/ruby-cvs-1.8*

Would be nice to see all instances of 1.8 use hacked-up PV instead, for 
easier bumps to 1.9 etc.

   econf --with-rubydir=${S} || die econf failed

   LD_LIBRARY_PATH=${D}/usr/$(get_libdir)
   RUBYLIB=${S}:${D}/usr/$(get_libdir)/ruby/${SLOT}
   for d in $(find ${S}/ext -type d) ; do

   cp -pPR sample ${D}/usr/share/doc/${PF}

   cp -pPR test ${D}/usr/share/${PN}-${SLOT}

Quotes ...

   make DESTDIR=${D} install-doc || die make install-doc failed

Why not emake?

   if [ ! -n $(readlink ${ROOT}usr/bin/ruby) ] ; then
   ${ROOT}usr/sbin/ruby-config ruby${SLOT/./}

   if [ ! -n $(readlink ${ROOT}usr/bin/ruby) ] ; then
   ${ROOT}usr/sbin/ruby-config ruby${SLOT/./}
   fi

ROOT can have spaces in it too.

Thanks,
Donnie
-- 
[EMAIL PROTECTED] mailing list

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-lang/ruby: ChangeLog ruby-1.8.6_p110.ebuild

2007-09-24 Thread Mike Frysinger 
On Monday 24 September 2007, Donnie Berkholz wrote:
 On 09:38 Mon 24 Sep , Richard Brown (rbrown) wrote:
  if [ ! -n $(readlink ${ROOT}usr/bin/ruby) ] ; then
  ${ROOT}usr/sbin/ruby-config ruby${SLOT/./}
 
  if [ ! -n $(readlink ${ROOT}usr/bin/ruby) ] ; then
  ${ROOT}usr/sbin/ruby-config ruby${SLOT/./}
  fi

 ROOT can have spaces in it too.

this is why the form:
[[ -n $(readlink ${ROOT}usr/bin/ruby) ]]
is preferred ... much easier to read and no nested quotes
-mike


signature.asc
Description: This is a digitally signed message part.

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-lang/ruby: ChangeLog ruby-1.8.6_p110.ebuild

2007-09-24 Thread René 'Necoro' Neumann 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Mike Frysinger schrieb:
 On Monday 24 September 2007, Donnie Berkholz wrote:
 On 09:38 Mon 24 Sep , Richard Brown (rbrown) wrote:
 if [ ! -n $(readlink ${ROOT}usr/bin/ruby) ] ; then
 ${ROOT}usr/sbin/ruby-config ruby${SLOT/./}

 if [ ! -n $(readlink ${ROOT}usr/bin/ruby) ] ; then
 ${ROOT}usr/sbin/ruby-config ruby${SLOT/./}
 fi
 ROOT can have spaces in it too.
 
 this is why the form:
 [[ -n $(readlink ${ROOT}usr/bin/ruby) ]]
 is preferred ... much easier to read and no nested quotes
 -mike

And: [[ ! -n ... ]] transforms to [[ -z ... ]]

Or am I wrong?

Regards,
- -- Necoro
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFG+A/04UOg/zhYFuARAg/dAJ9I5m/p7crLGG9JkIMu2vigtXlXVQCeLJwj
/zofTwO9Vtf+mu6EBYT8XiE=
=NIoO
-END PGP SIGNATURE-
-- 
[EMAIL PROTECTED] mailing list

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-lang/ruby: ChangeLog ruby-1.8.6_p110.ebuild

2007-09-24 Thread Mike Frysinger 
On Monday 24 September 2007, René 'Necoro' Neumann wrote:
 Mike Frysinger schrieb:
  On Monday 24 September 2007, Donnie Berkholz wrote:
  On 09:38 Mon 24 Sep , Richard Brown (rbrown) wrote:
if [ ! -n $(readlink ${ROOT}usr/bin/ruby) ] ; then
${ROOT}usr/sbin/ruby-config ruby${SLOT/./}
 
if [ ! -n $(readlink ${ROOT}usr/bin/ruby) ] ; then
${ROOT}usr/sbin/ruby-config ruby${SLOT/./}
fi
 
  ROOT can have spaces in it too.
 
  this is why the form:
  [[ -n $(readlink ${ROOT}usr/bin/ruby) ]]
  is preferred ... much easier to read and no nested quotes

 And: [[ ! -n ... ]] transforms to [[ -z ... ]]

! -n and -z are equivalent but there are no standards from the point of view 
of Gentoo ... this is purely whatever logic happens to spew out of the head 
of the developer as he composes the ebuild
-mike


signature.asc
Description: This is a digitally signed message part.