[gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: kde-base/kdepim-icons/
On 08/09/2015 08:25 PM, Agostino Sarubbo wrote: commit: 3fd6580a947db519cb60a4c2a05ec380ceb681d8 Author: Agostino Sarubbo ago AT gentoo DOT org AuthorDate: Sun Aug 9 18:23:44 2015 + Commit: Agostino Sarubbo ago AT gentoo DOT org CommitDate: Sun Aug 9 18:23:44 2015 + URL:https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3fd6580a Stable for amd64, wrt bug #556974 So, now we have 21 commits with the exact same commit message: = Stable for amd64, wrt bug #556974 = At that point, it's even debatable to have separate commits. IMO, if you stabilize a huge chunk of ebuilds, you have two possibilities: 1. just make it one giant commit (we don't revert stabilizations anyway)... if it's category-based, start the commit message with = kde-base: stable after dev-qt/qtgui bump for ia64 = if it is related to a particular package (e.g. a bump of dev-lang/ruby and very closely related packages that span across multiple categories) start it with = dev-lang/ruby: stabilize for ia64 including reverse dependencies = or somesuch (which is still not very nice, but better) 2. Have a sensical commit message for each saparate commit. E.g., make a local bash hack that automatically prepends category/pn to your commit message (I think zlogene has done that already) and hope for bug https://bugs.gentoo.org/show_bug.cgi?id=557148 to get more attention. This is better than mass commits if it can be sensibly automated. Anyway. 21 commits with the same message is really confusing. I can see that arch teams might have the most trouble with commit methods, becasue they have the highest commit rate, but we have to improve this.
[gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: kde-base/kdepim-icons/
On Sunday 09 August 2015 20:42:00 hasufell wrote: So, now we have 21 commits with the exact same commit message: = Stable for amd64, wrt bug #556974 = At that point, it's even debatable to have separate commits. IMO, if you stabilize a huge chunk of ebuilds, you have two possibilities: 1. just make it one giant commit (we don't revert stabilizations anyway)... if it's category-based, start the commit message with = kde-base: stable after dev-qt/qtgui bump for ia64 = if it is related to a particular package (e.g. a bump of dev-lang/ruby and very closely related packages that span across multiple categories) start it with = dev-lang/ruby: stabilize for ia64 including reverse dependencies = or somesuch (which is still not very nice, but better) 2. Have a sensical commit message for each saparate commit. E.g., make a local bash hack that automatically prepends category/pn to your commit message (I think zlogene has done that already) and hope for bug https://bugs.gentoo.org/show_bug.cgi?id=557148 to get more attention. This is better than mass commits if it can be sensibly automated. Anyway. 21 commits with the same message is really confusing. I can see that arch teams might have the most trouble with commit methods, becasue they have the highest commit rate, but we have to improve this. Since the repoman commit was done per package, I guess the feature requested in bug 557148 should fix this type of issue. -- Agostino Sarubbo Gentoo Linux Developer
Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: kde-base/kdepim-icons/
On 08/09/2015 08:59 PM, Agostino Sarubbo wrote:
On Sunday 09 August 2015 20:42:00 hasufell wrote:
So, now we have 21 commits with the exact same commit message:
=
Stable for amd64, wrt bug #556974
=
At that point, it's even debatable to have separate commits.
IMO, if you stabilize a huge chunk of ebuilds, you have two possibilities:
1. just make it one giant commit (we don't revert stabilizations
anyway)... if it's category-based, start the commit message with
=
kde-base: stable after dev-qt/qtgui bump for ia64
=
if it is related to a particular package (e.g. a bump of dev-lang/ruby
and very closely related packages that span across multiple categories)
start it with
=
dev-lang/ruby: stabilize for ia64 including reverse dependencies
=
or somesuch (which is still not very nice, but better)
2. Have a sensical commit message for each saparate commit. E.g., make a
local bash hack that automatically prepends category/pn to your commit
message (I think zlogene has done that already) and hope for bug
https://bugs.gentoo.org/show_bug.cgi?id=557148 to get more attention.
This is better than mass commits if it can be sensibly automated.
Anyway. 21 commits with the same message is really confusing. I can see
that arch teams might have the most trouble with commit methods, becasue
they have the highest commit rate, but we have to improve this.
Since the repoman commit was done per package, I guess the feature requested
in bug 557148 should fix this type of issue.
There's no reason to wait for that. You can automate that
with awk/bash/sed whatever too.
in bashrc e.g.:
cat_pn() {
awk -F/ '{print $(NF-1) / $(NF)}' ${PWD}
}
and then from within the ebuild directories:
repoman commit -m $(cat_pn): stable for amd64
Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: kde-base/kdepim-icons/
On Sun, 9 Aug 2015 20:42:00 +0200 hasufell wrote: On 08/09/2015 08:25 PM, Agostino Sarubbo wrote: commit: 3fd6580a947db519cb60a4c2a05ec380ceb681d8 Author: Agostino Sarubbo ago AT gentoo DOT org AuthorDate: Sun Aug 9 18:23:44 2015 + Commit: Agostino Sarubbo ago AT gentoo DOT org CommitDate: Sun Aug 9 18:23:44 2015 + URL:https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3fd6580a Stable for amd64, wrt bug #556974 So, now we have 21 commits with the exact same commit message: = Stable for amd64, wrt bug #556974 = And what is wrong with this? Git allows easily and undoubtedly show relations between each commit and files affected. This is _trivial_. I know, there is a rule about '^$cat/$pn:' syntax at present wiki page, but I don't see any strong reasoning behind such rule. Best regards, Andrew Savchenko pgpMwwQdM6Ic_.pgp Description: PGP signature
Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: kde-base/kdepim-icons/
On Sun, Aug 9, 2015 at 2:38 PM, Andrew Savchenko birc...@gentoo.org wrote: On Sun, 9 Aug 2015 20:42:00 +0200 hasufell wrote: On 08/09/2015 08:25 PM, Agostino Sarubbo wrote: commit: 3fd6580a947db519cb60a4c2a05ec380ceb681d8 Author: Agostino Sarubbo ago AT gentoo DOT org AuthorDate: Sun Aug 9 18:23:44 2015 + Commit: Agostino Sarubbo ago AT gentoo DOT org CommitDate: Sun Aug 9 18:23:44 2015 + URL:https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3fd6580a Stable for amd64, wrt bug #556974 So, now we have 21 commits with the exact same commit message: = Stable for amd64, wrt bug #556974 = And what is wrong with this? Git allows easily and undoubtedly show relations between each commit and files affected. This is _trivial_. I know, there is a rule about '^$cat/$pn:' syntax at present wiki page, but I don't see any strong reasoning behind such rule. So that git shortlog and tools that consume its output (e.g., cgit) will produce useful output.
