[gentoo-dev] Re: RFC: kde5 and kde5-functions eclass

[Michael Palimaka]

On 09/16/2014 02:19 AM, Davide Pesavento wrote:
  if [[ -a CMakeLists.txt ]]; then
 
 Unnecessary quoting. Also, -e is more common than -a
I guess both the eclasses (and a lot of Gentoo stuff in general) has
quoting that's not strictly necessary.

Thanks for the review, everything else has been actioned.

[gentoo-dev] Re: RFC: kde5 and kde5-functions eclass

[Jonathan Callen]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512

On 09/15/2014 12:19 PM, Davide Pesavento wrote:
 kde5-functions.eclass
 
 local ver=${1:-${PV}} local major=$(get_major_version ${ver}) 
 local minor=$(get_version_component_range 2 ${ver}) local
 micro=$(get_version_component_range 3 ${ver}) if [[ ${ver} ==
  ]]; then
 
 No wildcard match here? (*)

This is intentional, and comes from the kde4-functions equivalent.
The KDE version of the 5.0 branch is 5.0, not live.  Only the
master/trunk/etc. branch of the live repo gets the live designation.
(Under KDE SC 4, we used versions like 4.14.49. to reference the
4.14 branch, as upstream liked to use versions like 4.14.90 for a
beta/rc of 4.15; I haven't been involved enough with KDE5 to determine
what they're doing now.)

- -- 
Jonathan Callen
-BEGIN PGP SIGNATURE-
Version: GnuPG v2

iQIcBAEBCgAGBQJUF5MnAAoJELHSF2kinlg4mm0P/1DFUilFc8IfYNIsJqqK96Ec
hWrrDwK1Hy0yxCfJE4NccX7OGJjJDRi7r0O1XnEPc0vueXlCsTCzHFkOZDJOXz0M
+B6bbJm5WJCz9GYrU4rIY/BflSARPzCh+YZoEUu5Azvu2DuZkh3kHYw136mqnrvT
woqTAMPWaPZPQXMk3r8dmdSsjjtY+eplL68TSYh4x8p6qgSW/19UZcF0HjlfvHSd
JfrJ+TKupXa7i77PMOsR0GkHztVUyFbu2vVYnkPI52W7dLwlv9VuFDNGjprRl4ve
Xa5PzLGcz9Xr9JAtWSdPaTycRfkNpmYKJYwLRoOVIhJ3FvuZdT2ZD+P3x+uetem5
QumharQhkt5UNrwkWYC/KgVEJsLb0nVAYMDYUkaDTbYv1inEN6NkACjZrqvYTuSm
8zt4P9hhe73I7AliUD0AI70muvlOrGaseDXSrD0thsibqPHpK215IUgVyCNQjQ7U
NRu73bL2cEQ9fuoxzKmfTY3oPl5B9W9J3sXiKU4SEbWzplhJRQ2zBX1ZyqNgJMiP
ZZH1XWAiaotUzsrALcHcJ1iCCFE2rloIMA8unuxFhh7ch5MkMKsWfMLXio/pudTW
A0pHbnTAWonWIWdTy5HjBe7wUxu5Wxb09S5UbgCsnI6QhhorBNwvWfy/RGqdUThl
EUYzDpG+4ImziiPSm9Yu
=73JG
-END PGP SIGNATURE-