[gentoo-dev] commit reviewing ... new list or keep it on -dev ?
ive been sending private e-mails as i didnt want to make a lot of noise, but many of the comments i make i imagine would be applicable to a lot of people ... i also see others doing reviews and such how do people feel about responses ? keep them all on gentoo-dev or start a new list just for reviews ? -mike signature.asc Description: This is a digitally signed message part.
Re: [gentoo-dev] commit reviewing ... new list or keep it on -dev ?
Mike Frysinger wrote: > ive been sending private e-mails as i didnt want to make a lot of noise, but > many of the comments i make i imagine would be applicable to a lot of > people ... i also see others doing reviews and such > > how do people feel about responses ? keep them all on gentoo-dev or start a > new list just for reviews ? > -mike I don't think we need yet another list, we have far too many as it is. -dev is for discussion, it should be here. --taco -- [EMAIL PROTECTED] mailing list
Re: [gentoo-dev] commit reviewing ... new list or keep it on -dev ?
On Tuesday 18 September 2007 01:33:33 Mike Frysinger wrote: > ive been sending private e-mails as i didnt want to make a lot of noise, > but many of the comments i make i imagine would be applicable to a lot of > people ... i also see others doing reviews and such > > how do people feel about responses ? keep them all on gentoo-dev or start > a new list just for reviews ? You could use the gentoo-devhelp list which has been promised on bug #130886. https://bugs.gentoo.org/show_bug.cgi?id=130886 -- Bo Andresen signature.asc Description: This is a digitally signed message part.
Re: [gentoo-dev] commit reviewing ... new list or keep it on -dev ?
On Tue, Sep 18, 2007 at 01:38:15AM +0200, Bo ??rsted Andresen wrote: > On Tuesday 18 September 2007 01:33:33 Mike Frysinger wrote: > > ive been sending private e-mails as i didnt want to make a lot of noise, > > but many of the comments i make i imagine would be applicable to a lot of > > people ... i also see others doing reviews and such > > > > how do people feel about responses ? keep them all on gentoo-dev or start > > a new list just for reviews ? > You could use the gentoo-devhelp list which has been promised on bug #130886. > https://bugs.gentoo.org/show_bug.cgi?id=130886 antarus requested "-dev-help" before the -project and -dev-announce lists were created, and was not impressed that it couldn't be exactly -dev-help. Anyway, the stated goals for that list were to be a place for communication between advanced users and developers to interact. Review of commits would best belong on -dev, where a higher proportion of developers would read the reviewing. -- Robin Hugh Johnson Gentoo Linux Developer & Infra Guy E-Mail : [EMAIL PROTECTED] GnuPG FP : 11AC BA4F 4778 E3F6 E4ED F38E B27B 944E 3488 4E85 pgpS759NilNsc.pgp Description: PGP signature
Re: [gentoo-dev] commit reviewing ... new list or keep it on -dev ?
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 18.09.2007 um 01:33 schrieb Mike Frysinger: ive been sending private e-mails as i didnt want to make a lot of noise, but many of the comments i make i imagine would be applicable to a lot of people ... i also see others doing reviews and such /me also likes reading them on this list. If anyone wants to filter them, procmailing [gentoo-dev].*[gentoo- commits] will do. Robert -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.5 (Darwin) iD8DBQFG73cvyZx3L/ph1soRAidUAJ4hw+RE26wq1vaR5MHEaV2wdL9KjwCfeXzB ldFjS6tBKxjBLEd8SJz68AE= =Wpdu -END PGP SIGNATURE- -- [EMAIL PROTECTED] mailing list
Re: [gentoo-dev] commit reviewing ... new list or keep it on -dev ?
On Wed, Sep 19, 2007 at 01:28:54AM +0200, Lars Weiler wrote: > IMHO this list is a good place for the responses, so that > every dev can learn from them. Don't keep them in private > only. I can add an appropriate Reply-To in the > commit-messages, so that the replies show up here. Reply-To on gentoo-commits is already set to [EMAIL PROTECTED] -- Robin Hugh Johnson Gentoo Linux Developer & Infra Guy E-Mail : [EMAIL PROTECTED] GnuPG FP : 11AC BA4F 4778 E3F6 E4ED F38E B27B 944E 3488 4E85 pgpPWGCOVg23E.pgp Description: PGP signature
Re: [gentoo-dev] commit reviewing ... new list or keep it on -dev ?
* Mike Frysinger <[EMAIL PROTECTED]> [07/09/17 19:33 -0400]: > how do people feel about responses ? keep them all on gentoo-dev or start a > new list just for reviews ? IMHO this list is a good place for the responses, so that every dev can learn from them. Don't keep them in private only. I can add an appropriate Reply-To in the commit-messages, so that the replies show up here. Thanks a lot for reviewing! Regards, Lars -- Lars Weiler <[EMAIL PROTECTED]> +49-171-1963258 Instant Messaging : [EMAIL PROTECTED] Gentoo Linux PowerPC : Developer Gentoo Infrastructure : CVS/SVN Administrator pgpx8p14iJieY.pgp Description: PGP signature
Re: [gentoo-dev] commit reviewing ... new list or keep it on -dev ?
* Robin H. Johnson <[EMAIL PROTECTED]> [07/09/18 17:23 -0700]: > Reply-To on gentoo-commits is already set to [EMAIL PROTECTED] I guess this is set by the mailing-list-software? That collides with https://bugs.gentoo.org/193376. Regards, Lars -- Lars Weiler <[EMAIL PROTECTED]> +49-171-1963258 Instant Messaging : [EMAIL PROTECTED] Gentoo Linux PowerPC : Developer Gentoo Infrastructure : CVS/SVN Administrator pgpaRxLT7zb2x.pgp Description: PGP signature
Re: [gentoo-dev] commit reviewing ... new list or keep it on -dev ?
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Lars Weiler wrote: > * Robin H. Johnson <[EMAIL PROTECTED]> [07/09/18 17:23 -0700]: >> Reply-To on gentoo-commits is already set to [EMAIL PROTECTED] > > I guess this is set by the mailing-list-software? That > collides with https://bugs.gentoo.org/193376. > > Regards, Lars > Please keep the commit reviews coming on gentoo-dev. - -- Jeffrey Gardner Gentoo Developer Public PGP Key ID: 4A5D8F23 hkp://pgpkeys.mit.edu -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.7 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFG99PSiR2KxEpdjyMRAmEPAKDUame55tLUcfBmlHZzLw2B8v06hACgjQgN vOWNCpSbLXI89ROatHwgOwM= =zQ7Z -END PGP SIGNATURE- -- [EMAIL PROTECTED] mailing list
Re: [gentoo-dev] commit reviewing ... new list or keep it on -dev ?
* Jeffrey Gardner <[EMAIL PROTECTED]> [07/09/24 10:12 -0500]: > Please keep the commit reviews coming on gentoo-dev. I will not change that. The bug requests to send the commit review to the original author as well. That decreases manual work for our main-reviewers as they currently have to add the author into Cc manually. Regards, Lars -- Lars Weiler <[EMAIL PROTECTED]> +49-171-1963258 Instant Messaging : [EMAIL PROTECTED] Gentoo Linux PowerPC : Developer Gentoo Infrastructure : CVS/SVN Administrator pgphb2kMdpwr3.pgp Description: PGP signature
Re: [gentoo-dev] commit reviewing ... new list or keep it on -dev ?
On Mon, Sep 24, 2007 at 11:40:40AM +0200, Lars Weiler wrote: > * Robin H. Johnson <[EMAIL PROTECTED]> [07/09/18 17:23 -0700]: > > Reply-To on gentoo-commits is already set to [EMAIL PROTECTED] > I guess this is set by the mailing-list-software? That > collides with https://bugs.gentoo.org/193376. That was filed after the original creations of the commit mail system. Anyway, it's moot now, I updated the code to set Reply-To to both the list and the committer per that bug. However that is still going to suck, because now folk that ARE subscribed to gentoo-dev that get commit-reviewed are going to get duplicates. Additionally, responses after the first review that are on the list won't be seen by a non-subscribed dev. -- Robin Hugh Johnson Gentoo Linux Developer & Infra Guy E-Mail : [EMAIL PROTECTED] GnuPG FP : 11AC BA4F 4778 E3F6 E4ED F38E B27B 944E 3488 4E85 pgpHSI23oQKoa.pgp Description: PGP signature
Re: [gentoo-dev] commit reviewing ... new list or keep it on -dev ?
On Tuesday 25 September 2007, Robin H. Johnson wrote: > However that is still going to suck, because now folk that ARE > subscribed to gentoo-dev that get commit-reviewed are going to get > duplicates. i dont think so ... i'm pretty sure the default mailer settings are to not post duplicates at least, i dont recall ever seeing duplicates when someone e-mailed gentoo-dev and cc-ed me > Additionally, responses after the first review that are on > the list won't be seen by a non-subscribed dev. reply-all ! -mike signature.asc Description: This is a digitally signed message part.