Re: [gentoo-portage-dev] Portage team, Zac's development break and stepping down as lead
On Sun, 2014-01-12 at 04:27 -0200, Rafael Goncalves Martins wrote: Hi Brian, I'm somewhat familiar with portage code, and want to help a bit too. My main target would be to integrate distpatch (distfile delta support, a.k.a. my work on gsoc 2011) with portage. I sent the patch to the list years ago, but it never got any reviews, etc. I'm going to rewrite it and add some tests, etc. Can I join the team? :) Thanks! Sure. With more people, it will be less demanding on each of us. I know myself I've only spent maybe half an hour in the code so far, and still haven't finished it. The rest of the time I've spent in getting established as lead. Also with more people being familiar with the code, team decisions will help keep bad ideas from creeping in, etc.. Can you give us the link to any code you have (with g.o.g.o down) and a brief summary of how it works please. The we can start to have a look at it. Possibly come up with some better (if possible) ideas on integrating it. P.S. add yourself to the project wiki page as a member. -- Brian Dolbec dol...@gentoo.org signature.asc Description: This is a digitally signed message part
Re: [gentoo-portage-dev] Portage team, Zac's development break and stepping down as lead
On Sun, Jan 12, 2014 at 1:40 PM, Brian Dolbec dol...@gentoo.org wrote: On Sun, 2014-01-12 at 04:27 -0200, Rafael Goncalves Martins wrote: Hi Brian, I'm somewhat familiar with portage code, and want to help a bit too. My main target would be to integrate distpatch (distfile delta support, a.k.a. my work on gsoc 2011) with portage. I sent the patch to the list years ago, but it never got any reviews, etc. I'm going to rewrite it and add some tests, etc. Can I join the team? :) Thanks! Sure. With more people, it will be less demanding on each of us. I know myself I've only spent maybe half an hour in the code so far, and still haven't finished it. The rest of the time I've spent in getting established as lead. Also with more people being familiar with the code, team decisions will help keep bad ideas from creeping in, etc.. Can you give us the link to any code you have (with g.o.g.o down) and a brief summary of how it works please. The we can start to have a look at it. Possibly come up with some better (if possible) ideas on integrating it. P.S. add yourself to the project wiki page as a member. I'm currently rewriting the patch. It does not seems to work with current master. Will send to the list asap. General description of the feature is here: http://www.gentoo.org/proj/en/infrastructure/distpatch/ I'll migrate this page to the wiki soon. BR, Rafael Goncalves Martins Gentoo Linux developer http://rafaelmartins.eng.br/
[gentoo-portage-dev] [PATCH] Added support for variable expansion in source command. wrt bug #490896
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi all, Attached is a patch to allow variables in the argument for the source command in make.conf The implementation refactors what happens when allow_sourcing is True in the portage.util.getconfig function. Instead of just setting lex.source, now we also pass the expand_map dict. This patch fixes bug #490896 Jesus Rivero -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.16 (GNU/Linux) iEYEARECAAYFAlLS5XgACgkQdIssYB9vBoOUoQCdFA2JfPHvjLDVp0mqDTo01Z9E wMoAmgJLflNFTb9JoSnOJzZga6oJckYI =3Atz -END PGP SIGNATURE- 0001-Added-support-for-variable-expansion-in-source-command.patch Description: Binary data
[gentoo-portage-dev] [PATCH] [REV] Added support for variable expansion in source command. wrt bug #490896
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi all, In the previous patch, I didn't notice an error in the unittest I wrote for the feature. Attached is the correct patch, please disregard the previous one. Cheers, Jesus Rivero -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.16 (GNU/Linux) iEYEARECAAYFAlLS7oQACgkQdIssYB9vBoP5wgCgh0kIe28oKg5XECPkjoe36QaH oY8An0iUVqvPi5cftWbpbrHO2nSsUcqz =wZnl -END PGP SIGNATURE- 0002-Added-support-for-variable-expansion-in-source-command.patch Description: Binary data
[gentoo-portage-dev] Re: [gentoo-dev] Portage team, Zac's development break and stepping down as lead
On Sun, 2014-01-05 at 21:33 -0800, Brian Dolbec wrote: This is a general call for developers to join the portage development team. aka: Recruiting Drive If you have some Good python and/or bash skills and want/need to or already know portage's internals. WE NEED YOU! I want to thank all those that responded to my call (read cry) for help :D I think we have enough people that once everyone is more familiar with portage. It will be less likely to be in trouble if someone disappears from the project. Our team is now, I think quite well rounded, with interests in different areas of portage and it's utilities. We have also converted most of the old www.gentoo.org project pages to the wiki [1], still a few more to go. The portage team is now: Brian Dolbec (dolsen)...Interim lead, Public API Mike Frysinger (vapier).sandbox, etc. Thomas Sachau (Tommy[D])multilib portage Ulrich Müller (ulm).PMS liason GrobianFabian Groffen (grobian).Prefix portage Sebastian Luther (few_).bug squashing machine ;) Tom Wijsman (TomWij)Repoman Rafael Martins (rafaelmartins)..Distfile delta support Matthew Thode (promehteanfire) Pavel Kazakov (Nullishzero) Jesus Rivero (neurogeek) Chris Reffett (creffett) Alec Warner (antarus)...Code review, security Zac Medico (zmedico)Former lead, currently devaway Arfrever Frehtes Taifersar Arahesis (Arfrever) Vladimir Romanov (blueboar)..Russian Translation and 2 more contributing members Alexander Berntsen (bernalex) Douglas Dunn (djdunn) Of course we still accept patches sent to the portage-dev list :) [1] https://wiki.gentoo.org/wiki/Project:Portage -- Brian Dolbec dol...@gentoo.org signature.asc Description: This is a digitally signed message part
[gentoo-portage-dev] Meetings
Now that we have so many team members, we need to get ourselves more organized. I want to hold (semi)Regular meetings to go over outstanding issues, new proposals, difficult bugs, etc.. It is something we need to do as a team if we are to be successful in improving portage without overloading any one of two people. So, I've setup a new Meetings subpage [1]. Please fill in the the availability times. From there I'll try to determine the best day to hold a meeting for as many team members as possible. Hopefully we will be able to all attend. This will be the first of many (I hope). I have put up a meeting Agenda table with several items I would like to discuss. Please add to it any items you think need to be mentioned, discussed, voted on. I hope to go over any final patch submittals that are deemed controversial or otherwise not merged nor rejected from past submissions. Thank you [1] https://wiki.gentoo.org/wiki/Project:Portage/Meetings -- Brian Dolbec dol...@gentoo.org signature.asc Description: This is a digitally signed message part
Re: [gentoo-portage-dev] [PATCH] [REV] Added support for variable expansion in source command. wrt bug #490896
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/12/2014 03:57 PM, Jesus Rivero (Neurogeek) wrote: Hi all, In the previous patch, I didn't notice an error in the unittest I wrote for the feature. Attached is the correct patch, please disregard the previous one. Cheers, Jesus Rivero Neurogeek, Looks like we were working on the same patch, but I guess the patch is a good exercise in getting familiar with the portage code :P Overall it looks good. There were some complaints from git apply about trivial spacing issues (trailing whitespace), and there's a space included in indentation that causes python 3.3 to fail: 0002-Added-support-for-variable-expansion-in-source-commandd.patch:61: space before tab in indent. I'm not sure if it matters, but your code seems to do variable expansion for the source command even if the 'expand' variable in the getconfig() function is set to False (unless I'm wrong?). All, Although neurogeek already sent a patch, I figured I'd include mine as well at the request of dol-sen :) This patch does not include unit tests since it's meant to be more of a review against neurogeek's code. Regards, Pavel -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJS04RiAAoJENb1ecI556suiyYP/1X+CXK+WFoURBPUOlOyw9bN jKYg5My7wcz07VnWrIkPiuQf3Pq3bj2ckMc54kiL59bMWQgMXjtZMJzyzfegza/t Ks22+RYxmwdwU9OJ9prknFMLXdibEqT4zBk0MxHHfNeHqJtDM7j2Nc3Xcj+jP93R zRFzFLjWjOeT4kCzUvmnEewjd9WlhycAhXB/MMoEQM/stAROv9sai7RhF+6EpXsE XRP3ZagCdni5YA/Gz+eWZ59rihgo/8X1RLMzoK3MmPmh+LEi1Eop8NaHeTT4FumP 4ftr4mtc84qUpeo+pzzgi40Dse08oaHXCu5IX5lkVh0/Uu2vvVieTORGpLtDv9Mk sK2qCZJ9JQU8l3pE2tRVkZ935IN/DxDoUCt5EosOB5OQ3UG6RkIP+hqNmcpkA6wC OENrV5LCkAGzyuUNOCgqy4sL/rHWpSD+DqToc54vsnWTdkBCYO31AtwSKQ1xkihK gp3Re+7Z6dA6KhjF5ZM6LOd5KyH6gbEH2EqtEuWeNiaeBB+5eYJuhLiqVOrmfgkl nnatebh2DQum52OFDX4Q2M+6Cp0OHuYHUL0HxHcPRzmTnqBkwJtTxFoe2v3nQr5U cTTrkM8t0TD7/CqHTo0JQQBleIEQGaI3jzHBaOS1DWxU4ZXaTbBrq8gng3H7RVW/ 3mbx448SfEyeNGFiZqzE =g+z5 -END PGP SIGNATURE- From 59f30b1901227031531d196bd0dcf59990c68ec3 Mon Sep 17 00:00:00 2001 From: Pavel Kazakov nullishz...@gentoo.org Date: Sun, 12 Jan 2014 21:52:03 -0800 Subject: [PATCH] Add support for source variable expansion, bug #490896 --- pym/portage/util/__init__.py | 5 + 1 file changed, 5 insertions(+) diff --git a/pym/portage/util/__init__.py b/pym/portage/util/__init__.py index 24553da..555ac76 100644 --- a/pym/portage/util/__init__.py +++ b/pym/portage/util/__init__.py @@ -592,9 +592,12 @@ class _getconfig_shlex(shlex.shlex): def __init__(self, portage_tolerant=False, **kwargs): shlex.shlex.__init__(self, **kwargs) self.__portage_tolerant = portage_tolerant + self.expand_map = None def sourcehook(self, newfile): try: + if self.expand_map is not None: +newfile = varexpand(newfile, self.expand_map) return shlex.shlex.sourcehook(self, newfile) except EnvironmentError as e: if e.errno == PermissionDenied.errno: @@ -695,6 +698,8 @@ def getconfig(mycfg, tolerant=False, allow_sourcing=False, expand=True, lex.quotes = portage._native_string(\') if allow_sourcing: lex.source = portage._native_string(source) + if expand: + lex.expand_map = expand_map while True: key = _unicode_decode(lex.get_token()) -- 1.8.3.2
Re: [gentoo-portage-dev] Commit Policy
On Mon, 2014-01-13 at 07:43 +0100, Sebastian Luther wrote: Am 10.01.2014 11:35, schrieb Brian Dolbec: First off. Welcome and than you for responding to help with portage. With this many people, we should be able to make good progress without overloading any one person. General rule is to submit all patches to this list for review and approval before committing. Remember to do these always: 1) run pyflakes on your changes to check for faults, misssing imports, variables undefined,... 2) run the testsuite to check for breakage. It is in the base directory called runtests.sh. Please try to test it with all minimum supported python versions, but if you have pypy, and some others, then great. 3) any new code that could break things, make a test for it if at all possible. The general exception for patch submittal is for trivial changes such as typo fixes, etc.. It will take a bit of time for everyone to acclimate themselves into our new team. So, I was thinking we give it 2 months, then hold an election for lead in March. Is that alright with everyone? Thanks One more useful thing: Put this in ~/.gitconfig: [color] ui = auto This way git diff will use colors, including highlighting of trailing whitespace. I use an editor that I have set for both showing whitespace (you see tabs, spaces) and auto-strips trailing whitespace on save. nice tip for the git diff. I like using dev-vcs/gitg for doing commits, viewing different branch trees, cherry-picking (in color too). For commits it lets you pick changes 1 at a time (+ or -) when you've done several changes, but wish to split them into logical commits. Handy when you spot things that need fixing, but don't want to forget to do after your current change session commit. -- Brian Dolbec dol...@gentoo.org signature.asc Description: This is a digitally signed message part
