Re: [gentoo-portage-dev] [PATCH eapi6-pt2 v2 3/6] Add sandbox directory removal functions for EAPI 7
> On Fri, 9 Mar 2018, Michał Górny wrote:
> @@ -154,6 +165,12 @@ addread(){ __sb_append_var READ"$@" ; }
> addwrite() { __sb_append_var WRITE "$@" ; }
> adddeny(){ __sb_append_var DENY"$@" ; }
> addpredict() { __sb_append_var PREDICT "$@" ; }
> +if ___eapi_has_sandbox_rm_functions; then
> + rmread() { __sb_remove_var READ"$@" ; }
> + rmwrite(){ __sb_remove_var WRITE "$@" ; }
> + rmdeny() { __sb_remove_var DENY"$@" ; }
> + rmpredict() { __sb_remove_var PREDICT "$@" ; }
> +fi
See my message to gentoo-pms [1], where I suggest to omit this feature
from EAPI 7. We should rather rethink if this is the best possible
interface.
Ulrich
[1]
https://archives.gentoo.org/gentoo-pms/message/cf4bd0266f09245c02470e4fa3810947
pgpnhbMUIm3Z5.pgp
Description: PGP signature
Re: [gentoo-portage-dev] [PATCH eapi6-pt2 v2 2/6] nonfatal: Implement fallback executable for EAPI 7
> On Fri, 9 Mar 2018, Michał Górny wrote:
> +if ! ___eapi_has_nonfatal_as_executable; then
> + die "${0##*/} not supported as fallback helper in this EAPI"
> +fi
Nothing wrong with this, but this test isn't strictly necessary.
PMS says in [1]: "Except where otherwise noted, they may be internal
(shell functions or aliases) or external commands available in PATH;
where this is not specified, ebuilds may not rely upon either
behaviour."
So in EAPIs 0 to 6, Portage is free to implement it as shell function,
or external command, or both.
Ulrich
[1] https://projects.gentoo.org/pms/6/pms.html#x1-13100011.3.3
pgpQj9Jrmn1pd.pgp
Description: PGP signature
