[gentoo-portage-dev] [PATCH] ecompress-file: Support decompressing .lz

[Michał Górny]

Signed-off-by: Michał Górny 
---
 bin/ecompress-file | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/bin/ecompress-file b/bin/ecompress-file
index bc8fe5451..ccc2701c3 100755
--- a/bin/ecompress-file
+++ b/bin/ecompress-file
@@ -29,6 +29,9 @@ compress_file() {
*.lzma|*.xz)
unxz -f "${x}" || __helpers_die "unxz failed"
x=${x%.*};;
+   *.lz)
+   lzip -df "${x}" || __helpers_die "lzip -d 
failed"
+   x=${x%.lz};;
esac
 
filtered_args+=( "$x" )
-- 
2.19.1

Re: [gentoo-portage-dev] [PATCH] ecompress-file: Support decompressing .lz

[Ulrich Mueller]

> On Sat, 17 Nov 2018, Michał Górny wrote:

> Signed-off-by: Michał Górny 
> ---
>  bin/ecompress-file | 3 +++
>  1 file changed, 3 insertions(+)

> diff --git a/bin/ecompress-file b/bin/ecompress-file
> index bc8fe5451..ccc2701c3 100755
> --- a/bin/ecompress-file
> +++ b/bin/ecompress-file
> @@ -29,6 +29,9 @@ compress_file() {
>   *.lzma|*.xz)
>   unxz -f "${x}" || __helpers_die "unxz failed"
>   x=${x%.*};;
> + *.lz)
> + lzip -df "${x}" || __helpers_die "lzip -d 
> failed"
> + x=${x%.lz};;
>   esac
 
>   filtered_args+=( "$x" )
> -- 
> 2.19.1

Does that mean that portage will gain a dependency on lzip now?

Ulrich


signature.asc
Description: PGP signature

Re: [gentoo-portage-dev] [PATCH] ecompress-file: Support decompressing .lz

[Michał Górny]

On Sat, 2018-11-17 at 09:22 +0100, Ulrich Mueller wrote:
> > > > > > On Sat, 17 Nov 2018, Michał Górny wrote:
> > Signed-off-by: Michał Górny 
> > ---
> >  bin/ecompress-file | 3 +++
> >  1 file changed, 3 insertions(+)
> > diff --git a/bin/ecompress-file b/bin/ecompress-file
> > index bc8fe5451..ccc2701c3 100755
> > --- a/bin/ecompress-file
> > +++ b/bin/ecompress-file
> > @@ -29,6 +29,9 @@ compress_file() {
> > *.lzma|*.xz)
> > unxz -f "${x}" || __helpers_die "unxz failed"
> > x=${x%.*};;
> > +   *.lz)
> > +   lzip -df "${x}" || __helpers_die "lzip -d 
> > failed"
> > +   x=${x%.lz};;
> > esac
> 
>  
> > filtered_args+=( "$x" )
> > -- 
> > 2.19.1
> 
> Does that mean that portage will gain a dependency on lzip now?
> 

No, I don't think that's necessary.  That code is a cheap unsupported
hack that throws QA warnings.  I need it to support corner case of
PORTAGE_COMPRESS=lzip FEATURES=binpkg-docompress old binpackages after
switching to FEATURES=-binpkg-docompress.

-- 
Best regards,
Michał Górny


signature.asc
Description: This is a digitally signed message part

Re: [gentoo-portage-dev] [PATCH] ecompress-file: Support decompressing .lz

[Zac Medico]

On 11/17/18 12:14 AM, Michał Górny wrote:
> Signed-off-by: Michał Górny 
> ---
>  bin/ecompress-file | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/bin/ecompress-file b/bin/ecompress-file
> index bc8fe5451..ccc2701c3 100755
> --- a/bin/ecompress-file
> +++ b/bin/ecompress-file
> @@ -29,6 +29,9 @@ compress_file() {
>   *.lzma|*.xz)
>   unxz -f "${x}" || __helpers_die "unxz failed"
>   x=${x%.*};;
> + *.lz)
> + lzip -df "${x}" || __helpers_die "lzip -d 
> failed"
> + x=${x%.lz};;
>   esac
>  
>   filtered_args+=( "$x" )
> 

Looks good, please merge.
-- 
Thanks,
Zac



signature.asc
Description: OpenPGP digital signature