Re: [gentoo-portage-dev] [PATCH 0/4] Output rewrite for better clarify and greppability
On Tue, 2021-09-28 at 16:20 +0200, Michał Górny wrote: > Hi, > > Ok, so it's more major than I originally intended but I think it's > a good direction (once you get used to it). Roughly: > I'm retracting this in favor of whatever gentoo-dev participants come up with. -- Best regards, Michał Górny
Re: [gentoo-portage-dev] [PATCH 0/4] Output rewrite for better clarify and greppability
On Tue, 2021-09-28 at 11:28 -0400, Mike Gilbert wrote: > On Tue, Sep 28, 2021 at 10:20 AM Michał Górny wrote: > > > > Hi, > > > > Ok, so it's more major than I originally intended but I think it's > > a good direction (once you get used to it). Roughly: > > > > 1. All bash color vars are now prefixed with `PORTAGE_COLOR_` to avoid > >accidental collisions with ebuild vars (e.g. ebuild setting > >`GOOD=foo` broke `elog` before). > > 2. There are specific color vars for all kinds of output functions, > >and now `einfo` messages use distinct color (dark green) from `elog`, > >and `eqawarn` (brown) from `ewarn`. > > 3. Messages are now prefixed by their kind, making it possible to > >distinguish them without colors and grep for specific kind of logs: > >- `[--]` for einfo & ebegin > >- `[II]` for elog > >- `[WW]` for ewarn > >- `[QA]` for eqawarn > >- `[EE]` for eerror > > 4. Finally, I've replaced most of `>>>` and `!!!` in Portage output with > >four `` and `` to align the output again. > > I like it. > > Maybe add a reference to this bug? https://bugs.gentoo.org/728046 > Oh right, I also need to work on removing redundant 'QA Notice:' thingies. -- Best regards, Michał Górny
Re: [gentoo-portage-dev] [PATCH 0/4] Output rewrite for better clarify and greppability
On Tue, Sep 28, 2021 at 10:20 AM Michał Górny wrote: > > Hi, > > Ok, so it's more major than I originally intended but I think it's > a good direction (once you get used to it). Roughly: > > 1. All bash color vars are now prefixed with `PORTAGE_COLOR_` to avoid >accidental collisions with ebuild vars (e.g. ebuild setting >`GOOD=foo` broke `elog` before). > 2. There are specific color vars for all kinds of output functions, >and now `einfo` messages use distinct color (dark green) from `elog`, >and `eqawarn` (brown) from `ewarn`. > 3. Messages are now prefixed by their kind, making it possible to >distinguish them without colors and grep for specific kind of logs: >- `[--]` for einfo & ebegin >- `[II]` for elog >- `[WW]` for ewarn >- `[QA]` for eqawarn >- `[EE]` for eerror > 4. Finally, I've replaced most of `>>>` and `!!!` in Portage output with >four `` and `` to align the output again. I like it. Maybe add a reference to this bug? https://bugs.gentoo.org/728046
[gentoo-portage-dev] [PATCH 0/4] Output rewrite for better clarify and greppability
Hi, Ok, so it's more major than I originally intended but I think it's a good direction (once you get used to it). Roughly: 1. All bash color vars are now prefixed with `PORTAGE_COLOR_` to avoid accidental collisions with ebuild vars (e.g. ebuild setting `GOOD=foo` broke `elog` before). 2. There are specific color vars for all kinds of output functions, and now `einfo` messages use distinct color (dark green) from `elog`, and `eqawarn` (brown) from `ewarn`. 3. Messages are now prefixed by their kind, making it possible to distinguish them without colors and grep for specific kind of logs: - `[--]` for einfo & ebegin - `[II]` for elog - `[WW]` for ewarn - `[QA]` for eqawarn - `[EE]` for eerror 4. Finally, I've replaced most of `>>>` and `!!!` in Portage output with four `` and `` to align the output again. PR (includes screenshot): https://github.com/gentoo/portage/pull/759 Michał Górny (4): Prefix color vars with "PORTAGE_COLOR_" Use distinct colors for output msg types Use verbose prefixes for output messages Use "" and "" for output prefixes bin/clean_locks | 2 +- bin/dohtml.py | 2 +- bin/doins.py | 2 +- bin/ebuild| 8 +- bin/ebuild-helpers/dobin | 2 +- bin/ebuild-helpers/dodoc | 2 +- bin/ebuild-helpers/doexe | 2 +- bin/ebuild-helpers/doinfo | 2 +- bin/ebuild-helpers/dolib | 2 +- bin/ebuild-helpers/doman | 2 +- bin/ebuild-helpers/domo | 2 +- bin/ebuild-helpers/dosbin | 2 +- bin/ebuild-helpers/dosed | 4 +- bin/ebuild-helpers/keepdir| 2 +- bin/ebuild-helpers/newins | 4 +- bin/env-update| 2 +- bin/fixpackages | 4 +- bin/glsa-check| 14 +- bin/install-qa-check.d/10ignored-flags| 4 +- bin/install.py| 2 +- bin/isolated-functions.sh | 50 --- bin/misc-functions.sh | 22 +-- bin/phase-functions.sh| 64 - bin/phase-helpers.sh | 18 +-- bin/portageq | 6 +- bin/save-ebuild-env.sh| 18 ++- cnf/repo.postsync.d/example | 4 +- lib/_emerge/Binpkg.py | 10 +- lib/_emerge/BinpkgExtractorAsync.py | 4 +- lib/_emerge/BinpkgVerifier.py | 12 +- lib/_emerge/BlockerCache.py | 2 +- lib/_emerge/BlockerDB.py | 2 +- lib/_emerge/EbuildBuild.py| 2 +- lib/_emerge/EbuildIpcDaemon.py| 2 +- lib/_emerge/EbuildPhase.py| 2 +- lib/_emerge/JobStatusDisplay.py | 2 +- lib/_emerge/MergeListItem.py | 2 +- lib/_emerge/PackageUninstall.py | 6 +- lib/_emerge/Scheduler.py | 20 +-- lib/_emerge/SpawnProcess.py | 2 +- lib/_emerge/SubProcess.py | 2 +- lib/_emerge/actions.py| 126 ++ lib/_emerge/countdown.py | 4 +- lib/_emerge/depgraph.py | 121 + lib/_emerge/main.py | 6 +- lib/_emerge/post_emerge.py| 4 +- lib/_emerge/resolver/output_helpers.py| 4 +- lib/_emerge/resolver/slot_collision.py| 16 +-- lib/_emerge/show_invalid_depstring_notice.py | 2 +- lib/_emerge/unmerge.py| 44 +++--- lib/portage/__init__.py | 24 ++-- lib/portage/_selinux.py | 4 +- lib/portage/_sets/shell.py| 2 +- lib/portage/binrepo/config.py | 4 +- lib/portage/data.py | 2 +- lib/portage/dbapi/__init__.py | 2 +- lib/portage/dbapi/bintree.py | 45 --- lib/portage/dbapi/porttree.py | 12 +- lib/portage/dbapi/vartree.py | 94 ++--- lib/portage/dep/__init__.py | 48 +++ lib/portage/elog/__init__.py | 2 +- lib/portage/elog/messages.py | 15 ++- lib/portage/elog/mod_custom.py| 4 +- lib/portage/elog/mod_echo.py | 4 +- lib/portage/elog/mod_mail_summary.py | 2 +- lib/portage/elog/mod_save_summary.py | 2 +- lib/portage/emaint/modules/binhost/binhost.py | 3 +- lib/portage/env/loaders.py|
