[gentoo-portage-dev] Re: [PATCH v2] repoman: new QA error: slot operator under '||' alternative

[Sergei Trofimovich]

On Sat, 18 Jun 2016 14:15:54 -0700
Zac Medico  wrote:

> On 06/18/2016 12:27 PM, Sergei Trofimovich wrote:
> > +   if in_any_of and atom.slot_operator:
> > +   qatracker.add_error("dependency.badslotop", 
> > relative_path +
> > +   ": %s: '%s' uses ':=' slot operator under '||' 
> > dep clause." %
> > +   (mytype, atom))  
> 
> It should be like this:
> 
> if in_any_of and atom.slot_operator == '=':
> 
> Because the case of atom.slot_operator == '*' is not forbidden.

Nice catch! Sent V4.

-- 

  Sergei


pgpyl5mQIj5Eq.pgp
Description: Цифровая подпись OpenPGP

[gentoo-portage-dev] Re: [PATCH v2] repoman: new QA error: slot operator under '||' alternative

[Zac Medico]

On 06/18/2016 12:27 PM, Sergei Trofimovich wrote:
> + if in_any_of and atom.slot_operator:
> + qatracker.add_error("dependency.badslotop", 
> relative_path +
> + ": %s: '%s' uses ':=' slot operator under '||' 
> dep clause." %
> + (mytype, atom))

It should be like this:

if in_any_of and atom.slot_operator == '=':

Because the case of atom.slot_operator == '*' is not forbidden.
-- 
Thanks,
Zac