Re: [geos-devel] Pending Commit: changes to single sided buffering ogc validity checking
Thanks. Does it make sense to include copyright notices for each change? If they build up to the point people ignore them, if they aren't already ignoring them ;-), then it negates any value from having them there in the first place. On 16 July 2010 15:39, strk s...@keybit.net wrote: On Fri, Jul 16, 2010 at 02:38:52PM -0400, Andrew Ross wrote: Thanks for the explanation Paul. Very much appreciated. My apologies for prolonging this thread with one more question. In terms of coding style, does it make sense to have the copyright notices for each change in the code as this example? Should copyright notices from previous modifications ever be removed? Please point me at the style guidelines if this is already defined. Thanks again. There's no official style guidelines as far as I know (but could be wrong). What I try to do is follow the style I find in the file being edited. I started with TAB indenting for instance, but as others prefer spaces we're somewhere slowly moving there, for new code. You'll find a mix of TAB and spaces but hopefully only in different files. Changing the style of files has a bad effect on history tracking and regression debugging. About copyright, old notices shouldnt' be removed unless you're sure nothing is left from the original author. --strk; () Free GIS Flash consultant/developer /\ http://strk.keybit.net/services.html ___ geos-devel mailing list geos-devel@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/geos-devel -- Andrew http://bit.ly/geodb ___ geos-devel mailing list geos-devel@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/geos-devel
Re: [geos-devel] Pending Commit: changes to single sided buffering ogc validity checking
This may be why PostgreSQL chooses to use the fictitious PostgreSQL Developers Group for their copyright, however, I think we can cross the bridge when we come to it. Doesn't seem to be slowing down Linux at all. P On Mon, Jul 19, 2010 at 2:07 PM, Andrew Ross g...@rogers.com wrote: Thanks. Does it make sense to include copyright notices for each change? If they build up to the point people ignore them, if they aren't already ignoring them ;-), then it negates any value from having them there in the first place. On 16 July 2010 15:39, strk s...@keybit.net wrote: On Fri, Jul 16, 2010 at 02:38:52PM -0400, Andrew Ross wrote: Thanks for the explanation Paul. Very much appreciated. My apologies for prolonging this thread with one more question. In terms of coding style, does it make sense to have the copyright notices for each change in the code as this example? Should copyright notices from previous modifications ever be removed? Please point me at the style guidelines if this is already defined. Thanks again. There's no official style guidelines as far as I know (but could be wrong). What I try to do is follow the style I find in the file being edited. I started with TAB indenting for instance, but as others prefer spaces we're somewhere slowly moving there, for new code. You'll find a mix of TAB and spaces but hopefully only in different files. Changing the style of files has a bad effect on history tracking and regression debugging. About copyright, old notices shouldnt' be removed unless you're sure nothing is left from the original author. --strk; () Free GIS Flash consultant/developer /\ http://strk.keybit.net/services.html ___ geos-devel mailing list geos-devel@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/geos-devel -- Andrew http://bit.ly/geodb ___ geos-devel mailing list geos-devel@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/geos-devel ___ geos-devel mailing list geos-devel@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/geos-devel
Re: [geos-devel] Pending Commit: changes to single sided buffering ogc validity checking
On Thu, Jul 15, 2010 at 07:53:33PM -0400, Andrew Ross wrote: Hi Tom, All Saw the copyright notice in the change. Copyright for geos seems to be held by a number of people and organizations. That seems legally murky to me but I am not a lawyer. Has this been discussed previously? Not that I know about. I'm personally happy with multi-people copyright. --strk; () Free GIS Flash consultant/developer /\ http://strk.keybit.net/services.html ___ geos-devel mailing list geos-devel@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/geos-devel
Re: [geos-devel] Pending Commit: changes to single sided buffering ogc validity checking
Multi-people joint copyright with an organization like OSGeo also owning joint copyright is great and a very common model in open source. It doesn't seem that this is the case for geos though. A liberal license (such as LGPL) helps of course as it states very generous rights to use the source. My concern is what prevents a contributor from withdrawing the rights to use their source code on a whim? On 16 July 2010 04:56, strk s...@keybit.net wrote: On Thu, Jul 15, 2010 at 07:53:33PM -0400, Andrew Ross wrote: Hi Tom, All Saw the copyright notice in the change. Copyright for geos seems to be held by a number of people and organizations. That seems legally murky to me but I am not a lawyer. Has this been discussed previously? Not that I know about. I'm personally happy with multi-people copyright. --strk; () Free GIS Flash consultant/developer /\ http://strk.keybit.net/services.html ___ geos-devel mailing list geos-devel@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/geos-devel
Re: [geos-devel] Pending Commit: changes to single sided buffering ogc validity checking
On Fri, Jul 16, 2010 at 08:53:59AM -0400, Andrew Ross wrote: My concern is what prevents a contributor from withdrawing the rights to use their source code on a whim? I don't understand this concern. You mean what prevents people to assign a different licence to the code they commit to the GEOS repository ? --strk; () Free GIS Flash consultant/developer /\ http://strk.keybit.net/services.html ___ geos-devel mailing list geos-devel@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/geos-devel
Re: [geos-devel] Pending Commit: changes to single sided buffering ogc validity checking
They can't withdraw rights to use it, they've licensed it under the LGPL. Once it's out, it's out. Multi-copyright projects are all over the place, it's not a big deal. The only thing copyright assignment gets you is the ability to change the license of future releases of the code. (The old releases would remain under the previous license regime.) Why do you suppose MySQL AB allows Drizzle and MariaDB to go ahead and compete with them, using code that is entirely copyright MySQL AB (now owned by Oracle)? Because they don't have any choice -- copyright doesn't give them the ability to retroactively relicense the old work. Blah blah, license mathers, blah blah. :) Suffice to say, I've investigated this in some detail, since PostgreSQL is multi-copyright (there is no copyright assignment, and despite the headers saying (c) PostgreSQL Global Development Group the core group is cognizant that in fact the copyright vests in the people who wrote it, since the PGDG does not *exist*, legally, anywhere in the world. PostGIS, also multi-copyright. Linux is also multi-copyright (see attached file, which is from grep -i copyright *.c ~/linux.drivers.net.txt). So, if the new code is (c) Safe Software, that's fine. Live in freedom and happiness, Paul On Fri, Jul 16, 2010 at 5:53 AM, Andrew Ross g...@rogers.com wrote: Multi-people joint copyright with an organization like OSGeo also owning joint copyright is great and a very common model in open source. It doesn't seem that this is the case for geos though. A liberal license (such as LGPL) helps of course as it states very generous rights to use the source. My concern is what prevents a contributor from withdrawing the rights to use their source code on a whim? On 16 July 2010 04:56, strk s...@keybit.net wrote: On Thu, Jul 15, 2010 at 07:53:33PM -0400, Andrew Ross wrote: Hi Tom, All Saw the copyright notice in the change. Copyright for geos seems to be held by a number of people and organizations. That seems legally murky to me but I am not a lawyer. Has this been discussed previously? Not that I know about. I'm personally happy with multi-people copyright. --strk; () Free GIS Flash consultant/developer /\ http://strk.keybit.net/services.html ___ geos-devel mailing list geos-devel@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/geos-devel 3c501.c:Copyright 1993 United States Government as represented by the 3c503.c:Copyright 1993 United States Government as represented by the 3c507.c:Copyright 1993 United States Government as represented by the 3c509.c:Copyright 1994-2000 by Donald Becker. 3c509.c:Copyright 1993 United States Government as represented by the 3c523.c: Copyright 1995, 1996 by Chris Beauregard (cpbea...@undergrad.math.uwaterloo.ca) 3c527.c: * (c) Copyright 1998 Red Hat Software Inc 7990.c: * Copyright (C) 05/1998 Peter Maydell pmayd...@chiark.greenend.org.uk 8139cp.c: Copyright 2001-2004 Jeff Garzik jgar...@pobox.com 8139cp.c: Copyright (C) 2001, 2002 David S. Miller (da...@redhat.com) [tg3.c] 8139cp.c: Copyright (C) 2000, 2001 David S. Miller (da...@redhat.com) [sungem.c] 8139cp.c: Copyright 2001 Manfred Spraul [natsemi.c] 8139cp.c: Copyright 1999-2001 by Donald Becker. [natsemi.c] 8139cp.c: Copyright 1998-2001 by Jes Sorensen, j...@trained-monkey.org. [acenic.c] 8139cp.c: retain the authorship, copyright and license notice. This file is not 8139too.c: Copyright 2000-2002 Jeff Garzik 8139too.c: copyright and license notice. This file is not a complete 82596.c: Copyright 1993 United States Government as represented by the Director, a2065.c: * (C) Copyright 1995-2003 by Geert Uytterhoeven ge...@linux-m68k.org a2065.c: * (C) Copyright 1995 by Geert Uytterhoeven, ac3200.c: Copyright 1993 United States Government as represented by the Director, acenic.c: * Copyright 1998-2002 by Jes Sorensen, j...@trained-monkey.org. amd8111e.c: * Copyright (C) 2004 Advanced Micro Devices amd8111e.c: * Copyright 2001,2002 Jeff Garzik jgar...@mandrakesoft.com [ 8139cp.c,tg3.c ] amd8111e.c: * Copyright (C) 2001, 2002 David S. Miller (da...@redhat.com)[ tg3.c] amd8111e.c: * Copyright 1996-1999 Thomas Bogendoerfer [ pcnet32.c ] amd8111e.c: * Copyright 1993 United States Government as represented by the amd8111e.c: * Copyright (C) 2000 MIPS Technologies, Inc. All rights reserved. apne.c: * (C) Copyright 1997 Alain Malek ariadne.c: * © Copyright 1995-2003 by Geert Uytterhoeven (ge...@linux-m68k.org) at1700.c: Copyright 1993 United States Government as represented by the atp.c: retain the authorship, copyright and license notice. This file is not atp.c: Copyright 1993 United States Government as represented by the Director, atp.c: National Security Agency. Copyright 1994-2000
[geos-devel] Pending Commit: changes to single sided buffering ogc validity checking
Safe Software has made changes to GEOS code and would like to commit them back to trunk. A summary of the changes is below, and a patchfile is attached to trac ticket #364. BufferBuilder.cpp * Fixed a rare crash in BufferBuilder::bufferLineSingleSided(..) IsValidOp.cpp, ConnectedInteriorTester.cpp TestValid2.xml * Fixed handling of rare polygon cases to better adhere to the OGC spec on validity. * Added 3 cases as WKT to an existing Test Valid xml test. Take a look at ticket #364 for a patchfile. http://trac.osgeo.org/geos/ticket/364 -- ___ geos-devel mailing list geos-devel@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/geos-devel
Re: [geos-devel] Pending Commit: changes to single sided buffering ogc validity checking
Hi Tom, All Saw the copyright notice in the change. Copyright for geos seems to be held by a number of people and organizations. That seems legally murky to me but I am not a lawyer. Has this been discussed previously? Related, I saw there was an OSGeo CLA in the works ( http://wiki.osgeo.org/wiki/Individual_Contributor_License_Agreement_%28CLA%29) but it looks like it didn't get approved. Andrew On 15 July 2010 17:56, Tom Siedlaczek thomas.siedlac...@safe.com wrote: Safe Software has made changes to GEOS code and would like to commit them back to trunk. A summary of the changes is below, and a patchfile is attached to trac ticket #364. BufferBuilder.cpp * Fixed a rare crash in BufferBuilder::bufferLineSingleSided(..) IsValidOp.cpp, ConnectedInteriorTester.cpp TestValid2.xml * Fixed handling of rare polygon cases to better adhere to the OGC spec on validity. * Added 3 cases as WKT to an existing Test Valid xml test. Take a look at ticket #364 for a patchfile. http://trac.osgeo.org/geos/ticket/364 ___ geos-devel mailing list geos-devel@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/geos-devel
