Re: [Geoserver-devel] CLA for "less than one file" changes

2018-08-24 Thread Jody Garnett
I do not think we provided similar language for GeoServer.
On Fri, Aug 24, 2018 at 9:18 AM Andrea Aime 
wrote:

> Hi,
> the GeoTools contribution guidelines clearly state that a small change
> does not require a CLA:
> http://docs.geotools.org/latest/developer/procedures/contribute.html
>
> I thought we had the same in GeoServer, but I cannot find it:
>
>- https://github.com/geoserver/geoserver/blob/master/CONTRIBUTING.md
>-
>http://docs.geoserver.org/latest/en/developer/policies/pull_request.html
>-
>http://docs.geoserver.org/latest/en/developer/policies/committing.html
>
> Have I missed some change? Or did I just wrongly assume the policies were
> the same
> for the two projects, and they are not?
>
> Cheers
> Andrea
>
> ==
>
> GeoServer Professional Services from the experts! Visit
> http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf
> Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa
> (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549
> http://www.geo-solutions.it http://twitter.com/geosolutions_it
> --- *Con riferimento
> alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 -
> Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni
> circostanza inerente alla presente email (il suo contenuto, gli eventuali
> allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i
> destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per
> errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le
> sarei comunque grato se potesse darmene notizia. This email is intended
> only for the person or entity to which it is addressed and may contain
> information that is privileged, confidential or otherwise protected from
> disclosure. We remind that - as provided by European Regulation 2016/679
> “GDPR” - copying, dissemination or use of this e-mail or the information
> herein by anyone other than the intended recipient is prohibited. If you
> have received this email by mistake, please notify us immediately by
> telephone or e-mail.*
>
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> Geoserver-devel mailing list
> Geoserver-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/geoserver-devel
>
-- 
--
Jody Garnett
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel


[Geoserver-devel] Jenkins build is back to normal : geoserver-master #6174

2018-08-24 Thread monitor
See 


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel


Re: [Geoserver-devel] [GSIP-164] Promoting geofence and geofence-server as extensions modules

2018-08-24 Thread bradh
I should have noted I already added my vote on the GSIP. 

 

I was looking for Alessio’s opinion on the quality of the tests – test coverage 
(especially by line) isn’t the only thing that adds to value.

 

Brad

 

From: Andrea Aime  
Sent: Saturday, 25 August 2018 12:02 AM
To: Brad Hards 
Cc: Alessio Fabiani ; Geoserver-devel 

Subject: Re: [Geoserver-devel] [GSIP-164] Promoting geofence and 
geofence-server as extensions modules

 

Hi Brad,

the test coverage requirements are indeed on the low side, maybe we should 
discuss a separate GSIP about increasing them.

But as far as rules go, Alessio's proposal is within them.

 

Cheers

Andrea

 

On Sat, Aug 18, 2018 at 3:38 AM mailto:br...@frogmouth.net> > wrote:

The proposal wiki page still says 2.13. Are you targeting 2.14 or 2.15?

 

Also code coverage still seems pretty low for a security feature. Are you 
satisfied that the important parts have appropriate validation?

 

Brad

 

From: Alessio Fabiani mailto:alessio.fabi...@geo-solutions.it> > 
Sent: Friday, 17 August 2018 1:57 AM
To: Geoserver-devel mailto:geoserver-devel@lists.sourceforge.net> >
Subject: [Geoserver-devel] [GSIP-164] Promoting geofence and geofence-server as 
extensions modules

 

Dear PSC,

recently I worked on making geofence modules stable and complete enough to be 
evaluated as official GeoServer extensions.

 

Currently I have updated the checklist here

 

https://github.com/geoserver/geoserver/wiki/GSIP-164

 

and pushed a set of PRs [1][2][3][4] resulting in the following code coverage 
results


 





 

[1] https://github.com/geoserver/geoserver/pull/3058

[2] https://github.com/geoserver/geoserver/pull/3052

[3] https://github.com/geoserver/geoserver/pull/3046

[4] https://github.com/geoserver/geoserver/pull/3024

 

-- 

==

GeoServer Professional Services from the experts! Visit http://goo.gl/it488V 
for more information.
==
Ing. Alessio Fabiani

@alfa7691
Founder/Technical Lead

 

GeoSolutions S.A.S.
Via di Montramito 3/A - 55054  Massarosa (LU) - Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob:   +39 331 6233686


http://www.geo-solutions.it
http://twitter.com/geosolutions_it
---

Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 
2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa 
che ogni circostanza inerente alla presente email (il suo contenuto, gli 
eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i 
destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per 
errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei 
comunque grato se potesse darmene notizia.


This email is intended only for the person or entity to which it is addressed 
and may contain information that is privileged, confidential or otherwise 
protected from disclosure. We remind that - as provided by European Regulation 
2016/679 “GDPR” - copying, dissemination or use of this e-mail or the 
information herein by anyone other than the intended recipient is prohibited. 
If you have received this email by mistake, please notify us immediately by 
telephone or e-mail.

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! 
http://sdm.link/slashdot___
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net 
 
https://lists.sourceforge.net/lists/listinfo/geoserver-devel




 

-- 

Regards, Andrea Aime == GeoServer Professional Services from the experts! Visit 
http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf 
Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) 
phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 
http://www.geo-solutions.it http://twitter.com/geosolutions_it 
--- Con riferimento alla 
normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento 
generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza 
inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è 
un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo 
scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, 
ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene 
notizia. This email is intended only for the person or entity to which it is 
addressed and may contain information that is privileged, confidential or 
otherwise protected from disclosure. We remind that - as provided by European 
Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or 
the information herein by anyone other than the intended recipient is 
prohibited. If you have received this email 

[Geoserver-devel] GeoServer 2.12.5 released

2018-08-24 Thread Torben Barsballe
We are happy to announce the release of GeoServer 2.12.5
.
Downloads are available (zip

, war

, and exe
)
along with docs and extensions.

This is the last maintenance release for the 2.12.x series, so we recommend
users to plan an upgrade to 2.13.x or to the upcoming 2.14.x series. This
release is made in conjunction with GeoTools 18.5.

Highlights of this release are featured below, for more information please
see the release notes (2.12.5

, 2.12.4

, 2.12.3

,2.12.2

, 2.12.1

| 2.12.0

 | 2.12-RC1

 | 2.12-beta

).
Improvements

   - ImageMosaic should work when the images have no CRS information
   - Upgrade Apache POI dependencies
   - Upgrade jasypt dependency
   - Upgrade json-lib dependency to 2.4
   - Upgrade bouncycastle provider to 1.60

Bug Fixes

   -  NullPointerException during WMS request of layer group when caching
   is enabled
   - GeorectifyCoverage fails to handle paths with spaces
   -  CSS translator does not support mark offset/anchors based on
   expressions (but SLD does)
   - GeoServerSecuredPage might not redirect to login page in some obscure
   cases after Wicket upgrade

Security updates

Please update your production instances of GeoServer to receive the latest
security updates and fixes.

This release addresses several security vulnerabilities:

   - Prevent arbitrary code execution via Freemarker Template injection
   - XXE vulnerability in GeoTools XML Parser
   - XXE vulnerability in WPS Request builder
   - Various library upgrades (see above) from versions with known CVEs

Thanks to Steve Ikeoka, Kevin Smith, Brad Hards and Nuno Oliveira for
providing fixes to these issues.

These fixes are also included in the 2.13.2 release.

If you encounter a security vulnerability in GeoServer, or any other open
source software, please take care to report the issue in a responsible
fashion

.
About GeoServer 2.12 Series

Additional information on the 2.12 series:

   - State of GeoServer 2.12
   

   (SlideShare)
   - GeoServer Feature Frenzy
   

(SlideShare)
   - New REST API documentation
   
   - REST API Code Sprint Results
   
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel


[Geoserver-devel] [JIRA] (GEOS-8905) Cannot add CSV Store

2018-08-24 Thread Torben Barsballe (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Torben Barsballe created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 GeoServer /  GEOS-8905  
 
 
  Cannot add CSV Store   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Affects Versions: 
 2.13.2  
 
 
Assignee: 
 Unassigned  
 
 
Created: 
 24/Aug/18 9:27 PM  
 
 
Priority: 
  Medium  
 
 
Reporter: 
 Torben Barsballe  
 

  
 
 
 
 

 
 When trying to add a CSV store, I get the following error when publishing the layer: 

 
[wicket portion ommited]
...
Caused by: java.lang.RuntimeException: Error occurred while building the resources for the configuration page
	at org.geoserver.web.data.layer.NewLayerPage.buildLayerInfo(NewLayerPage.java:435)
	at org.geoserver.web.data.layer.NewLayerPage$9.onClick(NewLayerPage.java:324)
	at org.geoserver.web.wicket.SimpleAjaxLink$1.onClick(SimpleAjaxLink.java:47)
	at org.apache.wicket.ajax.markup.html.AjaxLink$1.onEvent(AjaxLink.java:85)
	at org.apache.wicket.ajax.AjaxEventBehavior.respond(AjaxEventBehavior.java:155)
	at org.apache.wicket.ajax.AbstractDefaultAjaxBehavior.onRequest(AbstractDefaultAjaxBehavior.java:601)
	... 105 more
Caused by: java.lang.RuntimeException: Failure reading csv file
	at org.geotools.data.csv.parse.CSVStrategy.createBuilder(CSVStrategy.java:80)
	at org.geotools.data.csv.parse.CSVAttributesOnlyStrategy.buildFeatureType(CSVAttributesOnlyStrategy.java:43)
	at org.geotools.data.csv.parse.CSVStrategy.getFeatureType(CSVStrategy.java:59)
	at org.geotools.data.csv.CSVDataStore.getSchema(CSVDataStore.java:77)
	at org.geotools.data.csv.CSVFeatureSource.buildFeatureType(CSVFeatureSource.java:94)
	at org.geotools.data.store.ContentFeatureSource.getAbsoluteSchema(ContentFeatureSource.java:328)
	at org.geotools.data.store.ContentFeatureSource.getSchema(ContentFeatureSource.java:297)
	at org.geotools.data.store.ContentFeatureSource.getSchema(ContentFeatureSource.java:106)
	at org.geoserver.catalog.CatalogBuilder.buildFeatureType(CatalogBuilder.java:343)

[Geoserver-devel] Build failed in Jenkins: geoserver-master #6173

2018-08-24 Thread monitor
See 

--
[...truncated 11.50 MB...]
at 
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:112)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189)
at 
org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165)
at 
org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85)
at 
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:115)
at 
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:75)

24 Aug 17:04:36 ERROR [geoserver.rest] - Unable to create import
org.geoserver.rest.RestException 500 INTERNAL_SERVER_ERROR: Unable to create 
import
at 
org.geoserver.importer.rest.ImportController.createImport(ImportController.java:242)
at 
org.geoserver.importer.rest.ImportController.postImports(ImportController.java:75)
at sun.reflect.GeneratedMethodAccessor284.invoke(Unknown Source)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.springframework.web.method.support.InvocableHandlerMethod.doInvoke(InvocableHandlerMethod.java:205)
at 
org.springframework.web.method.support.InvocableHandlerMethod.invokeForRequest(InvocableHandlerMethod.java:133)
at 
org.springframework.web.servlet.mvc.method.annotation.ServletInvocableHandlerMethod.invokeAndHandle(ServletInvocableHandlerMethod.java:97)
at 
org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.invokeHandlerMethod(RequestMappingHandlerAdapter.java:827)
at 
org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.handleInternal(RequestMappingHandlerAdapter.java:738)
at 
org.springframework.web.servlet.mvc.method.AbstractHandlerMethodAdapter.handle(AbstractHandlerMethodAdapter.java:85)
at 
org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:967)
at 
org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:901)
at 
org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:970)
at 
org.springframework.web.servlet.FrameworkServlet.doPost(FrameworkServlet.java:872)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:688)
at 
org.springframework.web.servlet.FrameworkServlet.service(FrameworkServlet.java:846)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:770)
at 
org.geoserver.test.GeoServerSystemTestSupport$2.service(GeoServerSystemTestSupport.java:1636)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:770)
at 
org.springframework.mock.web.MockFilterChain$ServletFilterProxy.doFilter(MockFilterChain.java:160)
at 
org.springframework.mock.web.MockFilterChain.doFilter(MockFilterChain.java:127)
at 
org.geoserver.test.GeoServerSystemTestSupport.dispatch(GeoServerSystemTestSupport.java:1665)
at 
org.geoserver.test.GeoServerSystemTestSupport.dispatch(GeoServerSystemTestSupport.java:1576)
at 
org.geoserver.test.GeoServerSystemTestSupport.dispatch(GeoServerSystemTestSupport.java:1564)
at 
org.geoserver.test.GeoServerSystemTestSupport.postAsServletResponse(GeoServerSystemTestSupport.java:1212)
at 
org.geoserver.importer.rest.ImporterIntegrationTest.testDirectWrongDir(ImporterIntegrationTest.java:203)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at 
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at 
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.rules.RunRules.evaluate(RunRules.java:20)
at 

[Geoserver-devel] CLA for "less than one file" changes

2018-08-24 Thread Andrea Aime
Hi,
the GeoTools contribution guidelines clearly state that a small change does
not require a CLA:
http://docs.geotools.org/latest/developer/procedures/contribute.html

I thought we had the same in GeoServer, but I cannot find it:

   - https://github.com/geoserver/geoserver/blob/master/CONTRIBUTING.md
   -
   http://docs.geoserver.org/latest/en/developer/policies/pull_request.html
   - http://docs.geoserver.org/latest/en/developer/policies/committing.html

Have I missed some change? Or did I just wrongly assume the policies were
the same
for the two projects, and they are not?

Cheers
Andrea

==

GeoServer Professional Services from the experts! Visit http://goo.gl/it488V
for more information. == Ing. Andrea Aime @geowolf Technical Lead
GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39
0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549
http://www.geo-solutions.it http://twitter.com/geosolutions_it
--- *Con riferimento
alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 -
Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni
circostanza inerente alla presente email (il suo contenuto, gli eventuali
allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i
destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per
errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le
sarei comunque grato se potesse darmene notizia. This email is intended
only for the person or entity to which it is addressed and may contain
information that is privileged, confidential or otherwise protected from
disclosure. We remind that - as provided by European Regulation 2016/679
“GDPR” - copying, dissemination or use of this e-mail or the information
herein by anyone other than the intended recipient is prohibited. If you
have received this email by mistake, please notify us immediately by
telephone or e-mail.*
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel