Hi all, you might have seen the mails on the geotools-devel list already, but during this Christmas break I've worked a bit on adding PMD and Error Prone quality checks in our builds (fixing the issues that popped up to make it possible to integrate the tools in our build server workflows).
The GeoServer version is here: https://github.com/geoserver/geoserver/pull/3306 With documentation in this page: https://github.com/geoserver/geoserver/blob/52923141c0638bab9ab42407c33df66b80fcee0a/doc/en/developer/source/qa-guide/index.rst (for those that have read the GeoTools version of this mail, yes, I've copy/pasted/adapted the following :-p ) As you can see, the PMD and Error-Prone tools are run with special profiles, and won't run by default. The idea is that the build servers will run them. Overall the build times on Travis after these changes should go down, as the QA machinery is run by a parallel build and the main build got offloaded of format checks and the compiler phase has been moved inline (it was running forked in a separate JVM before). I plan to setup a new QA build on Hudson as well, following the same setup as Travis. Ah, if you want to check out the Travis build changes, they are at the top of the changeset in the PR. The developer build setup does not change, with formatting being done automatically during the build. My GeoServer build is down to 5 minutes and a half (yes, all due to in-lining the javac call in maven). The changeset is not as large as the GeoTools one, with 125 files affected, but most changes are thankfully trivial: *https://github.com/geoserver/geoserver/pull/3306 <https://github.com/geoserver/geoserver/pull/3306>* I'm a bit torn in terms of backport, on one side it's very large, on the other side not backporting will likely make backports of future fixes/improvements harder. Just like in GeoTools, if you want me to write a proposal just ask, I'm only worried that it might drag things along out of the end of year break making the PR harder to merge (I'm doing this fully in my spare time, so I'll be limited to weekends again starting Jan 7th). Cheers Andrea GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- *Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.*
_______________________________________________ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
