Gabriel Roldan ha scritto:
On 4/1/10 3:35 AM, Andrea Aime wrote:
Gabriel Roldan ha scritto:
As far as I can tell the only code using this is the
ShapeZipOutputFormat? (for which I'm going to propose a refactor in a
separate email).
Dangerous business, every time I touch that class it breaks in some
way (it's handling a ton of use cases)
Well, intent is only to decouple the outputformat business from the
actual shape-zipping process.
Attempt results in the following patch: http://pastebin.com/RzkeVmeJ
Meaning the output format write method ends up as:
http://pastebin.com/4yNZxQKe and the utility class as
http://pastebin.com/FtXS8YVz.
Rationale being I need exactly this functionality for a geonode process
(the one in the utility class) but not the wfs output format's specific
concerns, and I would better avoid just copying and pasting?
Generally speaking it seems ok, besides the bit that exposes a static
method out of the utility writer (I think it's easy to make the method
non static as you create the utility objects a few lines later).
However I would like to look at it a bit closer, as I'm still half
asleep :-)
Can you open a jira and attach the patch there?
Cheers
Andrea
--
Andrea Aime
OpenGeo - http://opengeo.org
Expert service straight from the developers.
--
Download Intel#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
___
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
