Re: [Geotools-devel] Big bad reformat done

2018-05-02 Thread Jody Garnett 
The pull request links to google-java-format
, which provides a plugin for
installation.
--
Jody Garnett


On Mon, 30 Apr 2018 at 14:15, Ben Caradoc-Davies  wrote:

> [Resending as not delivered to geotools-devel, despite confirmed
> acceptance by mx.sourceforge.net]
>
> Thanks, Andrea.
>
> Do we have an AOSP formatter for Eclipse that we recommend? And a
> configuration for IntelliJ? We should update the developer manual.
>
> Kind regards,
> Ben.
>
> On 29/04/18 21:53, Andrea Aime wrote:
> > Hi,
> > the full reformat has been done on all 3 branches.
> >
> > A few updates:
> >
> > - I did not try to reformat the maven plugins and the docs before,
> that
> > threw me a few curve balls. See the thread about ":lines." usage for
> docs,
> > plugin wise, I gave up reformatting the xmlcodegen one as it caused
> build
> > failures, hopefully not a big deal, don't think we're going to touch
> it
> > anyways
> > - The formatter checkes are really strict, that is, it checks the
> file
> > is exactly identical to how it would format it. So, instead of
> adding the
> > checks, I've enabled the reformatting on build. That helps also
> those that
> > cannot use IDE plugins, just build once before committing and done.
> > - Since someone will forget to build before committing, I've also
> added
> > a noLocalChanges profile that checks there are no local changes
> during the
> > build, and enabled it during Travis builds. I'm thinking we should
> probably
> > have it also for build.geoserver.org, do you agree?
> >
> > Please follow up this mail with any issue/hiccup you encounter. Next
> > reformat is GeoServer, I'll try to work on it once the pull request queue
> > is (almost) empty, help to bring it down in that state appreciated :-)
> >
> > Cheers
> > Andrea
> >
> > ==
> >
> > GeoServer Professional Services from the experts! Visit
> http://goo.gl/it488V
> > for more information.
> > ==
> >
> > Ing. Andrea Aime
> > @geowolf
> > Technical Lead
> >
> > GeoSolutions S.A.S.
> > Via di Montramito 3/A
> > 55054  Massarosa (LU)
> > phone: +39 0584 962313
> > fax: +39 0584 1660272
> > mob: +39  339 8844549
> >
> > http://www.geo-solutions.it
> > http://twitter.com/geosolutions_it
> >
> > AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
> >
> > Le informazioni contenute in questo messaggio di posta elettronica e/o
> > nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
> > loro utilizzo è consentito esclusivamente al destinatario del messaggio,
> > per le finalità indicate nel messaggio stesso. Qualora riceviate questo
> > messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
> > darcene notizia via e-mail e di procedere alla distruzione del messaggio
> > stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
> > divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
> > utilizzarlo per finalità diverse, costituisce comportamento contrario ai
> > principi dettati dal D.Lgs. 196/2003.
> >
> > The information in this message and/or attachments, is intended solely
> for
> > the attention and use of the named addressee(s) and may be confidential
> or
> > proprietary in nature or covered by the provisions of privacy act
> > (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
> > Code).Any use not in accord with its purpose, any disclosure,
> reproduction,
> > copying, distribution, or either dissemination, either whole or partial,
> is
> > strictly forbidden except previous formal approval of the named
> > addressee(s). If you are not the intended recipient, please contact
> > immediately the sender by telephone, fax or e-mail and delete the
> > information in this message that has been received in error. The sender
> > does not give any warranty or accept liability as the content, accuracy
> or
> > completeness of sent messages and accepts no responsibility  for changes
> > made after they were sent or for other risks which arise as a result of
> > e-mail transmission, viruses, etc.
> >
> >
> >
> >
> --
> > Check out the vibrant tech community on one of the world's most
> > engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> >
> >
> >
> > ___
> > GeoTools-Devel mailing list
> > GeoTools-Devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/geotools-devel
> >
>
> --
> Ben Caradoc-Davies 
> Director
> Transient Software Limited 
> New Zealand
>
>
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> GeoTools-Devel mailing list
> GeoTools-Devel@lists.sourceforge.net
> https://lists

Re: [Geotools-devel] Big bad reformat done

2018-05-02 Thread Ben Caradoc-Davies 
[Resending as not delivered to geotools-devel, despite confirmed 
acceptance by mx.sourceforge.net]


On 30/04/18 09:57, Ben Caradoc-Davies wrote:

We should update the developer manual.


Andrea, I see that you have updated the developer manual. Thanks!

Kind regards,

--
Ben Caradoc-Davies 
Director
Transient Software Limited 
New Zealand

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Re: [Geotools-devel] Big bad reformat done

2018-05-02 Thread Ben Caradoc-Davies 

Thanks, Andrea.

Do we have an AOSP formatter for Eclipse that we recommend? And a 
configuration for IntelliJ? We should update the developer manual.


Kind regards,
Ben.

On 29/04/18 21:53, Andrea Aime wrote:

Hi,
the full reformat has been done on all 3 branches.

A few updates:

- I did not try to reformat the maven plugins and the docs before, that
threw me a few curve balls. See the thread about ":lines." usage for docs,
plugin wise, I gave up reformatting the xmlcodegen one as it caused build
failures, hopefully not a big deal, don't think we're going to touch it
anyways
- The formatter checkes are really strict, that is, it checks the file
is exactly identical to how it would format it. So, instead of adding the
checks, I've enabled the reformatting on build. That helps also those that
cannot use IDE plugins, just build once before committing and done.
- Since someone will forget to build before committing, I've also added
a noLocalChanges profile that checks there are no local changes during the
build, and enabled it during Travis builds. I'm thinking we should probably
have it also for build.geoserver.org, do you agree?

Please follow up this mail with any issue/hiccup you encounter. Next
reformat is GeoServer, I'll try to work on it once the pull request queue
is (almost) empty, help to bring it down in that state appreciated :-)

Cheers
Andrea

==

GeoServer Professional Services from the experts! Visit http://goo.gl/it488V
for more information.
==

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054  Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39  339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility  for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.



--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot



___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel



--
Ben Caradoc-Davies 
Director
Transient Software Limited 
New Zealand

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Re: [Geotools-devel] Big bad reformat done

2018-05-02 Thread Ben Caradoc-Davies 

On 30/04/18 09:57, Ben Caradoc-Davies wrote:

We should update the developer manual.


Andrea, I see that you have updated the developer manual. Thanks!

Kind regards,

--
Ben Caradoc-Davies 
Director
Transient Software Limited 
New Zealand

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Re: [Geotools-devel] Big bad reformat done

2018-05-01 Thread Andrea Aime 
Hi Ben,
bummer. Alternative plans:

   - Edit as usual, let the maven build reformat
   - The maven plugin also links to a Eclipse config file here:
   https://github.com/coveo/fmt-maven-plugin . This could be used to have a
   more-or-less view of how the file will become, before getting reformatted
   on the command line

Cheers
Andrea


On Tue, May 1, 2018 at 1:04 AM, Ben Caradoc-Davies  wrote:

> Note that Eclipse users might need to build an formatter plugin from
> source to get AOSP support:
>
> google-java-format Eclipse plugin does not provide AOSP Style option as
> google-java-format IntelliJ plugin
> https://github.com/google/google-java-format/issues/179
>
> This adds an AOSP formatter to the Eclipse plugin
> https://github.com/google/google-java-format/pull/251
>
> Kind regards,
> Ben.
>
>
> On 01/05/18 10:59, Ben Caradoc-Davies wrote:
>
>> Thanks, Jody. I see that Andrea added this link at the end of the coding
>> style page:
>> http://docs.geotools.org/latest/developer/conventions/code/
>> style.html#use-of-formatting-tools
>>
>> Kind regards,
>> Ben.
>>
>> On 01/05/18 10:54, Jody Garnett wrote:
>>
>>> The pull request links to google-java-format
>>> , which provides a plugin
>>> for
>>> installation.
>>> --
>>> Jody Garnett
>>>
>>>
>>> On Mon, 30 Apr 2018 at 14:15, Ben Caradoc-Davies 
>>> wrote:
>>>
>>> [Resending as not delivered to geotools-devel, despite confirmed
 acceptance by mx.sourceforge.net]

 Thanks, Andrea.

 Do we have an AOSP formatter for Eclipse that we recommend? And a
 configuration for IntelliJ? We should update the developer manual.

 Kind regards,
 Ben.

 On 29/04/18 21:53, Andrea Aime wrote:

> Hi,
> the full reformat has been done on all 3 branches.
>
> A few updates:
>
>  - I did not try to reformat the maven plugins and the docs before,
>
 that

>  threw me a few curve balls. See the thread about ":lines." usage
> for
>
 docs,

>  plugin wise, I gave up reformatting the xmlcodegen one as it
> caused
>
 build

>  failures, hopefully not a big deal, don't think we're going to
> touch
>
 it

>  anyways
>  - The formatter checkes are really strict, that is, it checks the
>
 file

>  is exactly identical to how it would format it. So, instead of
>
 adding the

>  checks, I've enabled the reformatting on build. That helps also
>
 those that

>  cannot use IDE plugins, just build once before committing and
> done.
>  - Since someone will forget to build before committing, I've also
>
 added

>  a noLocalChanges profile that checks there are no local changes
>
 during the

>  build, and enabled it during Travis builds. I'm thinking we should
>
 probably

>  have it also for build.geoserver.org, do you agree?
>
> Please follow up this mail with any issue/hiccup you encounter. Next
> reformat is GeoServer, I'll try to work on it once the pull request
> queue
> is (almost) empty, help to bring it down in that state appreciated :-)
>
> Cheers
> Andrea
>
> ==
>
> GeoServer Professional Services from the experts! Visit
>
 http://goo.gl/it488V

> for more information.
> ==
>
> Ing. Andrea Aime
> @geowolf
> Technical Lead
>
> GeoSolutions S.A.S.
> Via di Montramito 3/A
> 55054  Massarosa (LU)
> phone: +39 0584 962313
> fax: +39 0584 1660272
> mob: +39  339 8844549
>
> http://www.geo-solutions.it
> http://twitter.com/geosolutions_it
>
> AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
>
> Le informazioni contenute in questo messaggio di posta elettronica e/o
> nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
> loro utilizzo è consentito esclusivamente al destinatario del
> messaggio,
> per le finalità indicate nel messaggio stesso. Qualora riceviate questo
> messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
> darcene notizia via e-mail e di procedere alla distruzione del
> messaggio
> stesso, cancellandolo dal Vostro sistema. Conservare il messaggio
> stesso,
> divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
> utilizzarlo per finalità diverse, costituisce comportamento contrario
> ai
> principi dettati dal D.Lgs. 196/2003.
>
> The information in this message and/or attachments, is intended solely
>
 for

> the attention and use of the named addressee(s) and may be confidential
>
 or

> proprietary in nature or covered by the provisions of privacy act
> (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
> Code).Any use not i

Re: [Geotools-devel] Big bad reformat done

2018-04-30 Thread Ben Caradoc-Davies 
Note that Eclipse users might need to build an formatter plugin from 
source to get AOSP support:


google-java-format Eclipse plugin does not provide AOSP Style option as 
google-java-format IntelliJ plugin

https://github.com/google/google-java-format/issues/179

This adds an AOSP formatter to the Eclipse plugin
https://github.com/google/google-java-format/pull/251

Kind regards,
Ben.

On 01/05/18 10:59, Ben Caradoc-Davies wrote:
Thanks, Jody. I see that Andrea added this link at the end of the coding 
style page:
http://docs.geotools.org/latest/developer/conventions/code/style.html#use-of-formatting-tools 



Kind regards,
Ben.

On 01/05/18 10:54, Jody Garnett wrote:

The pull request links to google-java-format
, which provides a 
plugin for

installation.
--
Jody Garnett


On Mon, 30 Apr 2018 at 14:15, Ben Caradoc-Davies  
wrote:



[Resending as not delivered to geotools-devel, despite confirmed
acceptance by mx.sourceforge.net]

Thanks, Andrea.

Do we have an AOSP formatter for Eclipse that we recommend? And a
configuration for IntelliJ? We should update the developer manual.

Kind regards,
Ben.

On 29/04/18 21:53, Andrea Aime wrote:

Hi,
the full reformat has been done on all 3 branches.

A few updates:

 - I did not try to reformat the maven plugins and the docs before,

that
 threw me a few curve balls. See the thread about ":lines." 
usage for

docs,
 plugin wise, I gave up reformatting the xmlcodegen one as it 
caused

build
 failures, hopefully not a big deal, don't think we're going to 
touch

it

 anyways
 - The formatter checkes are really strict, that is, it checks the

file

 is exactly identical to how it would format it. So, instead of

adding the

 checks, I've enabled the reformatting on build. That helps also

those that
 cannot use IDE plugins, just build once before committing and 
done.

 - Since someone will forget to build before committing, I've also

added

 a noLocalChanges profile that checks there are no local changes

during the

 build, and enabled it during Travis builds. I'm thinking we should

probably

 have it also for build.geoserver.org, do you agree?

Please follow up this mail with any issue/hiccup you encounter. Next
reformat is GeoServer, I'll try to work on it once the pull request 
queue

is (almost) empty, help to bring it down in that state appreciated :-)

Cheers
Andrea

==

GeoServer Professional Services from the experts! Visit

http://goo.gl/it488V

for more information.
==

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054  Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39  339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del 
messaggio,

per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del 
messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio 
stesso,

divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento 
contrario ai

principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely

for

the attention and use of the named addressee(s) and may be confidential

or

proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure,

reproduction,
copying, distribution, or either dissemination, either whole or 
partial,

is

strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy

or
completeness of sent messages and accepts no responsibility  for 
changes

made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.




-- 


Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot



___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel



--
Ben Caradoc-Davies 
Director
Transient Software Limited 
New Ze

Re: [Geotools-devel] Big bad reformat done

2018-04-30 Thread Ben Caradoc-Davies 
Thanks, Jody. I see that Andrea added this link at the end of the coding 
style page:

http://docs.geotools.org/latest/developer/conventions/code/style.html#use-of-formatting-tools

Kind regards,
Ben.

On 01/05/18 10:54, Jody Garnett wrote:

The pull request links to google-java-format
, which provides a plugin for
installation.
--
Jody Garnett


On Mon, 30 Apr 2018 at 14:15, Ben Caradoc-Davies  wrote:


[Resending as not delivered to geotools-devel, despite confirmed
acceptance by mx.sourceforge.net]

Thanks, Andrea.

Do we have an AOSP formatter for Eclipse that we recommend? And a
configuration for IntelliJ? We should update the developer manual.

Kind regards,
Ben.

On 29/04/18 21:53, Andrea Aime wrote:

Hi,
the full reformat has been done on all 3 branches.

A few updates:

 - I did not try to reformat the maven plugins and the docs before,

that

 threw me a few curve balls. See the thread about ":lines." usage for

docs,

 plugin wise, I gave up reformatting the xmlcodegen one as it caused

build

 failures, hopefully not a big deal, don't think we're going to touch

it

 anyways
 - The formatter checkes are really strict, that is, it checks the

file

 is exactly identical to how it would format it. So, instead of

adding the

 checks, I've enabled the reformatting on build. That helps also

those that

 cannot use IDE plugins, just build once before committing and done.
 - Since someone will forget to build before committing, I've also

added

 a noLocalChanges profile that checks there are no local changes

during the

 build, and enabled it during Travis builds. I'm thinking we should

probably

 have it also for build.geoserver.org, do you agree?

Please follow up this mail with any issue/hiccup you encounter. Next
reformat is GeoServer, I'll try to work on it once the pull request queue
is (almost) empty, help to bring it down in that state appreciated :-)

Cheers
Andrea

==

GeoServer Professional Services from the experts! Visit

http://goo.gl/it488V

for more information.
==

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054  Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39  339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely

for

the attention and use of the named addressee(s) and may be confidential

or

proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure,

reproduction,

copying, distribution, or either dissemination, either whole or partial,

is

strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy

or

completeness of sent messages and accepts no responsibility  for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.





--

Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot



___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel



--
Ben Caradoc-Davies 
Director
Transient Software Limited 
New Zealand


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel





--
Ben Caradoc-Davies 
Director
Transient Software Limited

Re: [Geotools-devel] Big bad reformat done

2018-04-30 Thread Ben Caradoc-Davies 
[Resending as not delivered to geotools-devel, despite confirmed 
acceptance by mx.sourceforge.net]


Thanks, Andrea.

Do we have an AOSP formatter for Eclipse that we recommend? And a 
configuration for IntelliJ? We should update the developer manual.


Kind regards,
Ben.

On 29/04/18 21:53, Andrea Aime wrote:

Hi,
the full reformat has been done on all 3 branches.

A few updates:

- I did not try to reformat the maven plugins and the docs before, that
threw me a few curve balls. See the thread about ":lines." usage for docs,
plugin wise, I gave up reformatting the xmlcodegen one as it caused build
failures, hopefully not a big deal, don't think we're going to touch it
anyways
- The formatter checkes are really strict, that is, it checks the file
is exactly identical to how it would format it. So, instead of adding the
checks, I've enabled the reformatting on build. That helps also those that
cannot use IDE plugins, just build once before committing and done.
- Since someone will forget to build before committing, I've also added
a noLocalChanges profile that checks there are no local changes during the
build, and enabled it during Travis builds. I'm thinking we should probably
have it also for build.geoserver.org, do you agree?

Please follow up this mail with any issue/hiccup you encounter. Next
reformat is GeoServer, I'll try to work on it once the pull request queue
is (almost) empty, help to bring it down in that state appreciated :-)

Cheers
Andrea

==

GeoServer Professional Services from the experts! Visit http://goo.gl/it488V
for more information.
==

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054  Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39  339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility  for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.



--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot



___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel



--
Ben Caradoc-Davies 
Director
Transient Software Limited 
New Zealand

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Re: [Geotools-devel] Big bad reformat done

2018-04-30 Thread Torben Barsballe 
Thanks for doing the reformat!

Poking around a little bit, and doing a local build, I see no issues -
everything looks good.

Torben



On Sun, Apr 29, 2018 at 2:53 AM, Andrea Aime 
wrote:

> Hi,
> the full reformat has been done on all 3 branches.
>
> A few updates:
>
>- I did not try to reformat the maven plugins and the docs before,
>that threw me a few curve balls. See the thread about ":lines." usage for
>docs, plugin wise, I gave up reformatting the xmlcodegen one as it caused
>build failures, hopefully not a big deal, don't think we're going to touch
>it anyways
>- The formatter checkes are really strict, that is, it checks the file
>is exactly identical to how it would format it. So, instead of adding the
>checks, I've enabled the reformatting on build. That helps also those that
>cannot use IDE plugins, just build once before committing and done.
>- Since someone will forget to build before committing, I've also
>added a noLocalChanges profile that checks there are no local changes
>during the build, and enabled it during Travis builds. I'm thinking we
>should probably have it also for build.geoserver.org, do you agree?
>
> Please follow up this mail with any issue/hiccup you encounter. Next
> reformat is GeoServer, I'll try to work on it once the pull request queue
> is (almost) empty, help to bring it down in that state appreciated :-)
>
> Cheers
> Andrea
>
> ==
>
> GeoServer Professional Services from the experts! Visit
> http://goo.gl/it488V for more information.
> ==
>
> Ing. Andrea Aime
> @geowolf
> Technical Lead
>
> GeoSolutions S.A.S.
> Via di Montramito 3/A
> 55054  Massarosa (LU)
> phone: +39 0584 962313
> fax: +39 0584 1660272
> mob: +39  339 8844549
>
> http://www.geo-solutions.it
> http://twitter.com/geosolutions_it
>
> AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
>
> Le informazioni contenute in questo messaggio di posta elettronica e/o
> nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
> loro utilizzo è consentito esclusivamente al destinatario del messaggio,
> per le finalità indicate nel messaggio stesso. Qualora riceviate questo
> messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
> darcene notizia via e-mail e di procedere alla distruzione del messaggio
> stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
> divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
> utilizzarlo per finalità diverse, costituisce comportamento contrario ai
> principi dettati dal D.Lgs. 196/2003.
>
> The information in this message and/or attachments, is intended solely for
> the attention and use of the named addressee(s) and may be confidential or
> proprietary in nature or covered by the provisions of privacy act
> (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
> Code).Any use not in accord with its purpose, any disclosure, reproduction,
> copying, distribution, or either dissemination, either whole or partial, is
> strictly forbidden except previous formal approval of the named
> addressee(s). If you are not the intended recipient, please contact
> immediately the sender by telephone, fax or e-mail and delete the
> information in this message that has been received in error. The sender
> does not give any warranty or accept liability as the content, accuracy or
> completeness of sent messages and accepts no responsibility  for changes
> made after they were sent or for other risks which arise as a result of
> e-mail transmission, viruses, etc.
>
>
> 
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> GeoTools-Devel mailing list
> GeoTools-Devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>
>
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

[Geotools-devel] Big bad reformat done

2018-04-29 Thread Andrea Aime 
Hi,
the full reformat has been done on all 3 branches.

A few updates:

   - I did not try to reformat the maven plugins and the docs before, that
   threw me a few curve balls. See the thread about ":lines." usage for docs,
   plugin wise, I gave up reformatting the xmlcodegen one as it caused build
   failures, hopefully not a big deal, don't think we're going to touch it
   anyways
   - The formatter checkes are really strict, that is, it checks the file
   is exactly identical to how it would format it. So, instead of adding the
   checks, I've enabled the reformatting on build. That helps also those that
   cannot use IDE plugins, just build once before committing and done.
   - Since someone will forget to build before committing, I've also added
   a noLocalChanges profile that checks there are no local changes during the
   build, and enabled it during Travis builds. I'm thinking we should probably
   have it also for build.geoserver.org, do you agree?

Please follow up this mail with any issue/hiccup you encounter. Next
reformat is GeoServer, I'll try to work on it once the pull request queue
is (almost) empty, help to bring it down in that state appreciated :-)

Cheers
Andrea

==

GeoServer Professional Services from the experts! Visit http://goo.gl/it488V
for more information.
==

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054  Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39  339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility  for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel