Re: [Geotools-devel] Update of Graph Module

2019-03-15 Thread Justin Deoliveira
Hey Ian, great stuff!

If you want to step up to take on that module you're more than welcome too.
I unfortunately don't have time these days to remain an active maintainer
on the project, I can only contribute as my project work allows me too. So
it's all yours. Your proposed changes all sound great.

-Justin

On Fri, Mar 15, 2019 at 11:45 AM Ian Turton  wrote:

> I've just put in a PR (https://github.com/geotools/geotools/pull/2321)
> against the GeoTools graph module. Basically, I've moved it to using typed
> collections and java.util collections over hand crafted implementations. I
> don't know how much time you have to look after this module Justin, if you
> would like I could step up and help maintain it, if you'd like?
>
> What I had actually started on was adding  equality and hashcode methods
> to Edge and Node so that I could check if collections of Edges or Nodes
> contained the edge or node I'm currently using. But this breaks a number of
> the tests so I'm now not sure if adding the same edge twice (or more) is a
> useful thing that ought to be allowed or if I can quietly modify the tests
> without anyone noticing?
>
> Cheers
>
> Ian
>
> --
> Ian Turton
>
___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel


[Geotools-devel] Update of Graph Module

2019-03-15 Thread Ian Turton
I've just put in a PR (https://github.com/geotools/geotools/pull/2321)
against the GeoTools graph module. Basically, I've moved it to using typed
collections and java.util collections over hand crafted implementations. I
don't know how much time you have to look after this module Justin, if you
would like I could step up and help maintain it, if you'd like?

What I had actually started on was adding  equality and hashcode methods to
Edge and Node so that I could check if collections of Edges or Nodes
contained the edge or node I'm currently using. But this breaks a number of
the tests so I'm now not sure if adding the same edge twice (or more) is a
useful thing that ought to be allowed or if I can quietly modify the tests
without anyone noticing?

Cheers

Ian

-- 
Ian Turton
___
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel