Jenkins build is back to normal : master-osmo-pcu » master,osmocom-master-debian9,none,False #483

2018-05-19 Thread jenkins 
See

Build failed in Jenkins: master-rtl-sdr » a1=default,a2=default,a3=default,osmocom-master-debian9 #39

2018-05-19 Thread jenkins 
See 


--
[...truncated 92.17 KB...]
make[2]: Nothing to be done for 'dvi'.
make[2]: Leaving directory 
'
Making dvi in src
make[2]: Entering directory 
'
make[2]: Nothing to be done for 'dvi'.
make[2]: Leaving directory 
'
make[2]: Entering directory 
'
make[2]: Nothing to be done for 'dvi-am'.
make[2]: Leaving directory 
'
make[1]: Leaving directory 
'
make[1]: Entering directory 
'
make  check-recursive
make[2]: Entering directory 
'
Making check in include
make[3]: Entering directory 
'
make[3]: Nothing to be done for 'check'.
make[3]: Leaving directory 
'
Making check in src
make[3]: Entering directory 
'
make[3]: Nothing to be done for 'check'.
make[3]: Leaving directory 
'
make[3]: Entering directory 
'
make[3]: Leaving directory 
'
make[2]: Leaving directory 
'
make[1]: Leaving directory 
'
make[1]: Entering directory 
'
make  install-recursive
make[2]: Entering directory 
'
Making install in include
make[3]: Entering directory 
'
make[4]: Entering directory 
'
make[4]: Nothing to be done for 'install-exec-am'.
 /bin/mkdir -p 
'
 /usr/bin/install -c -m 644 ../../../include/rtl-sdr.h 
../../../include/rtl-sdr_export.h 
'
make[4]: Leaving directory

Change in libosmocore[master]: core/timer_compat: define CLOCK_BOOTTIME

2018-05-19 Thread Pau Espin Pedrol 
Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/7906 )

Change subject: core/timer_compat: define CLOCK_BOOTTIME
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/7906/1/include/osmocom/core/timer_compat.h
File include/osmocom/core/timer_compat.h:

https://gerrit.osmocom.org/#/c/7906/1/include/osmocom/core/timer_compat.h@119
PS1, Line 119: #define CLOCK_BOOTTIME 7
> so what does the magic 7 do in pre-2.6. […]
We are actually not using CLOCK_BOOTTIME anywhere in our code afaik, we only 
provide the possibility to use it together with other clocks in the API.

If CLOCK_BOOTTIME is not suported I would still efine it, then I would probably 
return EINVAL, as explained in man clock_gettime:
"EINVAL The clk_id specified is not supported on this system."

If we just pass that to clock_gettime, it's going to return EINVAL anyway most 
probably.



--
To view, visit https://gerrit.osmocom.org/7906
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d3a829700272ec8e5cf67379d8d85368230726
Gerrit-Change-Number: 7906
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Comment-Date: Sat, 19 May 2018 12:12:44 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-mgw[master]: mgcp: mgcp_osmux: use conn_bts when forwarding pkts from bsc_nat

2018-05-19 Thread Pau Espin Pedrol 
Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9215 )

Change subject: mgcp: mgcp_osmux: use conn_bts when forwarding pkts from bsc_nat
..

mgcp: mgcp_osmux: use conn_bts when forwarding pkts from bsc_nat

This commit actually doesn't fix the entire code, since anyway osmux
conns are not supported and mgcp_conn_get_rtp() will return NULL.
However, it makes the code more logical and easier to understand once
somebody refactors the code to make it work again.

Change-Id: Ib57e12e5a36b5842c40673c236907bbcbfc390f3
---
M src/libosmo-mgcp/mgcp_osmux.c
1 file changed, 6 insertions(+), 6 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Neels Hofmeyr: Looks good to me, but someone else must approve
  dexter: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/libosmo-mgcp/mgcp_osmux.c b/src/libosmo-mgcp/mgcp_osmux.c
index 1d3cab3..bdc285b 100644
--- a/src/libosmo-mgcp/mgcp_osmux.c
+++ b/src/libosmo-mgcp/mgcp_osmux.c
@@ -326,7 +326,7 @@
struct sockaddr_in addr;
struct mgcp_config *cfg = ofd->data;
uint32_t rem;
-   struct mgcp_conn_rtp *conn_net = NULL;
+   struct mgcp_conn_rtp *conn_bts = NULL;

msg = osmux_recv(ofd, );
if (!msg)
@@ -345,8 +345,8 @@
   _addr, MGCP_DEST_NET);

/* FIXME: Get rid of CONN_ID_XXX! */
-   conn_net = mgcp_conn_get_rtp(endp, CONN_ID_NET);
-   if (!conn_net)
+   conn_bts = mgcp_conn_get_rtp(endp, CONN_ID_BTS);
+   if (!conn_bts)
goto out;

if (!endp) {
@@ -355,11 +355,11 @@
 osmuxh->circuit_id);
goto out;
}
-   conn_net->osmux.stats.octets += osmux_chunk_length(msg, rem);
-   conn_net->osmux.stats.chunks++;
+   conn_bts->osmux.stats.octets += osmux_chunk_length(msg, rem);
+   conn_bts->osmux.stats.chunks++;
rem = msg->len;

-   osmux_xfrm_output(osmuxh, _net->osmux.out, );
+   osmux_xfrm_output(osmuxh, _bts->osmux.out, );
osmux_tx_sched(, scheduled_tx_bts_cb, endp);
}
 out:

--
To view, visit https://gerrit.osmocom.org/9215
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib57e12e5a36b5842c40673c236907bbcbfc390f3
Gerrit-Change-Number: 9215
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: dexter

Change in osmo-mgw[master]: legacy-mgcp: Add jitter buffer on the uplink receiver

2018-05-19 Thread Pau Espin Pedrol 
Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9212 )

Change subject: legacy-mgcp: Add jitter buffer on the uplink receiver
..

legacy-mgcp: Add jitter buffer on the uplink receiver

Default usage values are defined in mgcp node, and can be per-BSC
overriden on each bsc node

This commit is a forward-port of openbsc.git Change-Id
Ibf3932adc07442fb5e9c7a06404853f9d0a20959.

Change-Id: Ie19a64ac09f9d51f2434ad0d7925610fc919a90e
---
M include/osmocom/legacy_mgcp/mgcp.h
M include/osmocom/legacy_mgcp/mgcp_internal.h
M src/libosmo-legacy-mgcp/mgcp_network.c
M src/libosmo-legacy-mgcp/mgcp_protocol.c
M src/libosmo-legacy-mgcp/mgcp_vty.c
5 files changed, 156 insertions(+), 3 deletions(-)

Approvals:
  Harald Welte: Looks good to me, but someone else must approve
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/include/osmocom/legacy_mgcp/mgcp.h 
b/include/osmocom/legacy_mgcp/mgcp.h
index 147a0d5..7490e37 100644
--- a/include/osmocom/legacy_mgcp/mgcp.h
+++ b/include/osmocom/legacy_mgcp/mgcp.h
@@ -243,6 +243,12 @@
 * message.
 */
uint16_t osmux_dummy;
+
+   /* Use a jitterbuffer on the bts-side receiver */
+   bool bts_use_jibuf;
+   /* Minimum and maximum buffer size for the jitter buffer, in ms */
+   uint32_t bts_jitter_delay_min;
+   uint32_t bts_jitter_delay_max;
 };

 /* config management */
diff --git a/include/osmocom/legacy_mgcp/mgcp_internal.h 
b/include/osmocom/legacy_mgcp/mgcp_internal.h
index dcc75f1..956bee0 100644
--- a/include/osmocom/legacy_mgcp/mgcp_internal.h
+++ b/include/osmocom/legacy_mgcp/mgcp_internal.h
@@ -25,6 +25,7 @@
 #include 

 #include 
+#include 

 #define CI_UNUSED 0

@@ -198,6 +199,14 @@
uint32_t octets;
} stats;
} osmux;
+
+   /* Jitter buffer */
+   struct osmo_jibuf* bts_jb;
+   /* Use a jitterbuffer on the bts-side receiver */
+   bool bts_use_jibuf;
+   /* Minimum and maximum buffer size for the jitter buffer, in ms */
+   uint32_t bts_jitter_delay_min;
+   uint32_t bts_jitter_delay_max;
 };

 #define for_each_line(line, save)  \
@@ -335,3 +344,8 @@
 }

 int mgcp_msg_terminate_nul(struct msgb *msg);
+
+/**
+ * Internal jitter buffer related
+ */
+void mgcp_dejitter_udp_send(struct msgb *msg, void *data);
diff --git a/src/libosmo-legacy-mgcp/mgcp_network.c 
b/src/libosmo-legacy-mgcp/mgcp_network.c
index 8ccfb42..7b161d2 100644
--- a/src/libosmo-legacy-mgcp/mgcp_network.c
+++ b/src/libosmo-legacy-mgcp/mgcp_network.c
@@ -584,6 +584,36 @@
return rc;
 }

+void mgcp_dejitter_udp_send(struct msgb *msg, void *data)
+{
+   struct mgcp_rtp_end *rtp_end = (struct mgcp_rtp_end *) data;
+
+   int rc = mgcp_udp_send(rtp_end->rtp.fd, _end->addr,
+  rtp_end->rtp_port, (char*) msg->data, msg->len);
+   if (rc != msg->len)
+   LOGP(DLMGCP, LOGL_ERROR,
+   "Failed to send data after jitter buffer: %d\n", rc);
+   msgb_free(msg);
+}
+
+static int enqueue_dejitter(struct osmo_jibuf *jb, struct mgcp_rtp_end 
*rtp_end, char *buf, int len)
+{
+   struct msgb *msg;
+   msg = msgb_alloc(len, "mgcp-jibuf");
+   if (!msg)
+   return -1;
+
+   memcpy(msg->data, buf, len);
+   msgb_put(msg, len);
+
+   if (osmo_jibuf_enqueue(jb, msg) < 0) {
+   rtp_end->dropped_packets += 1;
+   msgb_free(msg);
+   }
+
+   return len;
+}
+
 int mgcp_send(struct mgcp_endpoint *endp, int dest, int is_rtp,
  struct sockaddr_in *addr, char *buf, int rc)
 {
@@ -591,6 +621,7 @@
struct mgcp_rtp_end *rtp_end;
struct mgcp_rtp_state *rtp_state;
int tap_idx;
+   struct osmo_jibuf *jb;

LOGP(DLMGCP, LOGL_DEBUG,
 "endpoint %x dest %s tcfg->audio_loop %d endp->conn_mode %d (== 
loopback: %d)\n",
@@ -612,10 +643,12 @@
rtp_end = >net_end;
rtp_state = >bts_state;
tap_idx = MGCP_TAP_NET_OUT;
+   jb = endp->bts_jb;
} else {
rtp_end = >bts_end;
rtp_state = >net_state;
tap_idx = MGCP_TAP_BTS_OUT;
+   jb = NULL;
}
LOGP(DLMGCP, LOGL_DEBUG,
 "endpoint %x dest %s net_end %s %d %d bts_end %s %d %d rtp_end %s 
%d %d\n",
@@ -680,9 +713,12 @@
rtp_state->patched_first_rtp_payload = true;
}

-   rc = mgcp_udp_send(rtp_end->rtp.fd,
-  _end->addr,
-  rtp_end->rtp_port, buf, len);
+   if (jb)
+   rc = enqueue_dejitter(jb, rtp_end, buf, len);
+   else
+   rc =

Change in osmo-mgw[master]: mgcp: switch to new osmux output APIs

2018-05-19 Thread Pau Espin Pedrol 
Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9216 )

Change subject: mgcp: switch to new osmux output APIs
..

mgcp: switch to new osmux output APIs

Older ones are being deprecated as they may generate interleaved
packets.

Change-Id: I0705aa4dc4b02eaff4d6030795243e6720f7fddf
---
M src/libosmo-mgcp/mgcp_osmux.c
1 file changed, 11 insertions(+), 6 deletions(-)

Approvals:
  Neels Hofmeyr: Looks good to me, but someone else must approve
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/libosmo-mgcp/mgcp_osmux.c b/src/libosmo-mgcp/mgcp_osmux.c
index bdc285b..281595c 100644
--- a/src/libosmo-mgcp/mgcp_osmux.c
+++ b/src/libosmo-mgcp/mgcp_osmux.c
@@ -322,7 +322,6 @@
 {
struct msgb *msg;
struct osmux_hdr *osmuxh;
-   struct llist_head list;
struct sockaddr_in addr;
struct mgcp_config *cfg = ofd->data;
uint32_t rem;
@@ -359,8 +358,7 @@
conn_bts->osmux.stats.chunks++;
rem = msg->len;

-   osmux_xfrm_output(osmuxh, _bts->osmux.out, );
-   osmux_tx_sched(, scheduled_tx_bts_cb, endp);
+   osmux_xfrm_output_sched(_bts->osmux.out, osmuxh);
}
 out:
msgb_free(msg);
@@ -426,7 +424,6 @@
 {
struct msgb *msg;
struct osmux_hdr *osmuxh;
-   struct llist_head list;
struct sockaddr_in addr;
struct mgcp_config *cfg = ofd->data;
uint32_t rem;
@@ -463,8 +460,7 @@
conn_net->osmux.stats.chunks++;
rem = msg->len;

-   osmux_xfrm_output(osmuxh, _net->osmux.out, );
-   osmux_tx_sched(, scheduled_tx_net_cb, endp);
+   osmux_xfrm_output_sched(_net->osmux.out, osmuxh);
}
 out:
msgb_free(msg);
@@ -553,9 +549,13 @@
switch (endp->cfg->role) {
case MGCP_BSC_NAT:
conn->type = MGCP_OSMUX_BSC_NAT;
+   osmux_xfrm_output_set_tx_cb(>osmux.out,
+   scheduled_tx_net_cb, 
endp);
break;
case MGCP_BSC:
conn->type = MGCP_OSMUX_BSC;
+   osmux_xfrm_output_set_tx_cb(>osmux.out,
+   scheduled_tx_bts_cb, 
endp);
break;
}

@@ -576,6 +576,11 @@

LOGP(DLMGCP, LOGL_INFO, "Releasing connection %s using Osmux CID %u\n",
 conn->conn->id, conn->osmux.cid);
+
+   /* We are closing, we don't need pending RTP packets to be transmitted 
*/
+   osmux_xfrm_output_set_tx_cb(>osmux.out, NULL, NULL);
+   osmux_xfrm_output_flush(>osmux.out);
+
osmux_xfrm_input_close_circuit(conn->osmux.in, conn->osmux.cid);
conn->osmux.state = OSMUX_STATE_DISABLED;
conn->osmux.cid = -1;

--
To view, visit https://gerrit.osmocom.org/9216
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0705aa4dc4b02eaff4d6030795243e6720f7fddf
Gerrit-Change-Number: 9216
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol

Change in osmo-ci[master]: jobs: osmo-gsm-tester-runner: Add ttcn3 job

2018-05-19 Thread Pau Espin Pedrol 
Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/9225 )

Change subject: jobs: osmo-gsm-tester-runner: Add ttcn3 job
..


Patch Set 2: Verified+1


--
To view, visit https://gerrit.osmocom.org/9225
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ca1c9a3a18138a27232efba7d65d6806e044a6b
Gerrit-Change-Number: 9225
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Comment-Date: Sat, 19 May 2018 12:06:25 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ci[master]: jobs: osmo-gsm-tester-runner: Add ttcn3 job

2018-05-19 Thread Pau Espin Pedrol 
Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9225 )

Change subject: jobs: osmo-gsm-tester-runner: Add ttcn3 job
..

jobs: osmo-gsm-tester-runner: Add ttcn3 job

Change-Id: I8ca1c9a3a18138a27232efba7d65d6806e044a6b
---
M jobs/osmo-gsm-tester-runner.yml
A jobs/osmo-gsm-tester_ttcn3.sh
2 files changed, 41 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Pau Espin Pedrol: Verified



diff --git a/jobs/osmo-gsm-tester-runner.yml b/jobs/osmo-gsm-tester-runner.yml
index 5e1ff92..f6774b7 100644
--- a/jobs/osmo-gsm-tester-runner.yml
+++ b/jobs/osmo-gsm-tester-runner.yml
@@ -7,6 +7,7 @@
 jobs:
   - 'osmo-gsm-tester_run-{stage}'
   - 'osmo-gsm-tester_gerrit'
+  - 'osmo-gsm-tester_ttcn3'

 - scm:
 name: osmo-gsm-tester-gerrit
@@ -166,3 +167,29 @@
   - junit:
   results: 'trial-*/last_run/trial-*.xml'
   allow-empty-results: true
+
+# ttcn3 job
+- job:
+name: 'osmo-gsm-tester_ttcn3'
+defaults: runner
+scm:
+  - 'osmo-gsm-tester-repo'
+triggers:
+  - timed: "H H/2 * * *"
+  - pollscm:
+  cron: "H/5 * * * *"
+builders:
+  - shell: |
+  # make sure no bin artifacts from a previous run remain
+  rm -f *.tgz *.md5
+  - copy_artifact_all
+  - copy_artifact:
+ repo: osmo-gsm-tester_build-osmocom-bb
+  - shell: !include-raw: osmo-gsm-tester_ttcn3.sh
+publishers:
+  - archive:
+  artifacts: '*-run.tgz, *-bin.tgz'
+  default-excludes: false
+  - junit:
+  results: 'trial-*/last_run/trial-*.xml'
+  allow-empty-results: true
diff --git a/jobs/osmo-gsm-tester_ttcn3.sh b/jobs/osmo-gsm-tester_ttcn3.sh
new file mode 100644
index 000..f2b974f
--- /dev/null
+++ b/jobs/osmo-gsm-tester_ttcn3.sh
@@ -0,0 +1,14 @@
+#!/bin/sh
+set -e -x
+
+# On our hardware, we actually use the example configuration as-is.
+export OSMO_GSM_TESTER_CONF="$PWD/osmo-gsm-tester/ttcn3"
+
+# debug: provoke a failure
+#export OSMO_GSM_TESTER_OPTS="-s debug -t fail"
+
+unlink osmo-gsm-tester/ttcn3/resources.conf || true
+ln -s resources.conf.prod osmo-gsm-tester/ttcn3/resources.conf
+
+PATH="$PWD/osmo-gsm-tester/src:$PATH" \
+  ./osmo-gsm-tester/ttcn3/jenkins-run.sh

--
To view, visit https://gerrit.osmocom.org/9225
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8ca1c9a3a18138a27232efba7d65d6806e044a6b
Gerrit-Change-Number: 9225
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: lynxis lazus

Change in osmo-mgw[master]: mgcp: switch to new osmux output APIs

2018-05-19 Thread Pau Espin Pedrol 
Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/9216 )

Change subject: mgcp: switch to new osmux output APIs
..


Patch Set 1: Code-Review+2

It's a forward port and it's been +1 for several days, merging.


--
To view, visit https://gerrit.osmocom.org/9216
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0705aa4dc4b02eaff4d6030795243e6720f7fddf
Gerrit-Change-Number: 9216
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Sat, 19 May 2018 12:06:10 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-mgw[master]: legacy-mgcp: switch to new osmux output APIs

2018-05-19 Thread Pau Espin Pedrol 
Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9213 )

Change subject: legacy-mgcp: switch to new osmux output APIs
..

legacy-mgcp: switch to new osmux output APIs

Older ones are being deprecated as they may generate interleaved
packets.

This commit is a forward-port of openbsc.git Change-Id
I189564fc63139c15314db8975afd423c7153ea32.

Change-Id: I9b8a19e5b8d62deaa9bbb92d49d99e8c33b7e345
---
M src/libosmo-legacy-mgcp/mgcp_osmux.c
1 file changed, 11 insertions(+), 6 deletions(-)

Approvals:
  Harald Welte: Looks good to me, but someone else must approve
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/libosmo-legacy-mgcp/mgcp_osmux.c 
b/src/libosmo-legacy-mgcp/mgcp_osmux.c
index 743d3f9..b53e2b5 100644
--- a/src/libosmo-legacy-mgcp/mgcp_osmux.c
+++ b/src/libosmo-legacy-mgcp/mgcp_osmux.c
@@ -267,7 +267,6 @@
 {
struct msgb *msg;
struct osmux_hdr *osmuxh;
-   struct llist_head list;
struct sockaddr_in addr;
struct mgcp_config *cfg = ofd->data;
uint32_t rem;
@@ -297,8 +296,7 @@
endp->osmux.stats.chunks++;
rem = msg->len;

-   osmux_xfrm_output(osmuxh, >osmux.out, );
-   osmux_tx_sched(, scheduled_tx_bts_cb, endp);
+   osmux_xfrm_output_sched(>osmux.out, osmuxh);
}
 out:
msgb_free(msg);
@@ -359,7 +357,6 @@
 {
struct msgb *msg;
struct osmux_hdr *osmuxh;
-   struct llist_head list;
struct sockaddr_in addr;
struct mgcp_config *cfg = ofd->data;
uint32_t rem;
@@ -389,8 +386,7 @@
endp->osmux.stats.chunks++;
rem = msg->len;

-   osmux_xfrm_output(osmuxh, >osmux.out, );
-   osmux_tx_sched(, scheduled_tx_net_cb, endp);
+   osmux_xfrm_output_sched(>osmux.out, osmuxh);
}
 out:
msgb_free(msg);
@@ -470,9 +466,13 @@
switch (endp->cfg->role) {
case MGCP_BSC_NAT:
endp->type = MGCP_OSMUX_BSC_NAT;
+   osmux_xfrm_output_set_tx_cb(>osmux.out,
+   scheduled_tx_net_cb, 
endp);
break;
case MGCP_BSC:
endp->type = MGCP_OSMUX_BSC;
+   osmux_xfrm_output_set_tx_cb(>osmux.out,
+   scheduled_tx_bts_cb, 
endp);
break;
}
endp->osmux.state = OSMUX_STATE_ENABLED;
@@ -484,6 +484,11 @@
 {
LOGP(DLMGCP, LOGL_INFO, "Releasing endpoint %u using Osmux CID %u\n",
 ENDPOINT_NUMBER(endp), endp->osmux.cid);
+
+   /* We are closing, we don't need pending RTP packets to be transmitted 
*/
+   osmux_xfrm_output_set_tx_cb(>osmux.out, NULL, NULL);
+   osmux_xfrm_output_flush(>osmux.out);
+
osmux_xfrm_input_close_circuit(endp->osmux.in, endp->osmux.cid);
endp->osmux.state = OSMUX_STATE_DISABLED;
endp->osmux.cid = -1;

--
To view, visit https://gerrit.osmocom.org/9213
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9b8a19e5b8d62deaa9bbb92d49d99e8c33b7e345
Gerrit-Change-Number: 9213
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol

Change in osmo-mgw[master]: legacy-mgcp: switch to new osmux output APIs

2018-05-19 Thread Pau Espin Pedrol 
Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/9213 )

Change subject: legacy-mgcp: switch to new osmux output APIs
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9213
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b8a19e5b8d62deaa9bbb92d49d99e8c33b7e345
Gerrit-Change-Number: 9213
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Sat, 19 May 2018 12:05:50 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-mgw[master]: legacy-mgcp: Add jitter buffer on the uplink receiver

2018-05-19 Thread Pau Espin Pedrol 
Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/9212 )

Change subject: legacy-mgcp: Add jitter buffer on the uplink receiver
..


Patch Set 1: Code-Review+2

It's a forward port and it's been +1 for several days, merging.


--
To view, visit https://gerrit.osmocom.org/9212
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie19a64ac09f9d51f2434ad0d7925610fc919a90e
Gerrit-Change-Number: 9212
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Sat, 19 May 2018 12:05:29 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-mgw[master]: legacy-mgcp: switch to new osmux output APIs

2018-05-19 Thread Pau Espin Pedrol 
Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/9213 )

Change subject: legacy-mgcp: switch to new osmux output APIs
..


Patch Set 1:

It's a forward port and it's been +1 for several days, merging.


--
To view, visit https://gerrit.osmocom.org/9213
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b8a19e5b8d62deaa9bbb92d49d99e8c33b7e345
Gerrit-Change-Number: 9213
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Sat, 19 May 2018 12:05:41 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-gsm-tester[master]: contrib: Add jenkins-build-osmocom-bb.sh to build osmocon

2018-05-19 Thread Pau Espin Pedrol 
Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9224 )

Change subject: contrib: Add jenkins-build-osmocom-bb.sh to build osmocon
..

contrib: Add jenkins-build-osmocom-bb.sh to build osmocon

Change-Id: Ic5b29951d3fd143dce5826138c84301a9797b1ef
---
A contrib/jenkins-build-osmocom-bb.sh
1 file changed, 24 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Neels Hofmeyr: Looks good to me, approved



diff --git a/contrib/jenkins-build-osmocom-bb.sh 
b/contrib/jenkins-build-osmocom-bb.sh
new file mode 100755
index 000..f54518a
--- /dev/null
+++ b/contrib/jenkins-build-osmocom-bb.sh
@@ -0,0 +1,24 @@
+#!/bin/sh
+set -e -x
+
+base="$PWD"
+name="osmocom-bb"
+. "$(dirname "$0")/jenkins-build-common.sh"
+
+build_repo libosmocore --disable-doxygen
+
+have_repo osmocom-bb
+cd osmocom-bb/
+
+cd src/host/osmocon/
+set +x; echo; echo; set -x
+autoreconf -fi
+set +x; echo; echo; set -x
+./configure --prefix="$prefix" $CONFIGURE_FLAGS $configure_opts
+set +x; echo; echo; set -x
+make -j4
+set +x; echo; echo; set -x
+make install
+
+
+create_bin_tgz "" "osmocon"

--
To view, visit https://gerrit.osmocom.org/9224
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic5b29951d3fd143dce5826138c84301a9797b1ef
Gerrit-Change-Number: 9224
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol

Change in osmo-gsm-tester[master]: contrib: common: Record repo curr rev in have_repo instead of build_repo

2018-05-19 Thread Pau Espin Pedrol 
Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9222 )

Change subject: contrib: common: Record repo curr rev in have_repo instead of 
build_repo
..

contrib: common: Record repo curr rev in have_repo instead of build_repo

This way scripts making use only of have_repo (to have build specific
insturctions) can still benefit from that code.

Change-Id: I03149942ac1d279a15c71df3eb880c331c8fc155
---
M contrib/jenkins-build-common.sh
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Neels Hofmeyr: Looks good to me, approved
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/contrib/jenkins-build-common.sh b/contrib/jenkins-build-common.sh
index 39046ef..9d85622 100644
--- a/contrib/jenkins-build-common.sh
+++ b/contrib/jenkins-build-common.sh
@@ -91,6 +91,8 @@

   git rev-parse HEAD

+  echo "$(git rev-parse HEAD) $dep" >> "$prefix_real/${name}_git_hashes.txt"
+
   cd "$base"
 }

@@ -122,8 +124,6 @@

   cd "$dep"

-  echo "$(git rev-parse HEAD) $dep" >> "$prefix_real/${name}_git_hashes.txt"
-
   # special shim: we know the openbsc.git needs to be built in the openbsc/ 
subdir.
   if [ "$dep" = "openbsc" ]; then
 cd openbsc

--
To view, visit https://gerrit.osmocom.org/9222
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I03149942ac1d279a15c71df3eb880c331c8fc155
Gerrit-Change-Number: 9222
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol

Change in osmo-gsm-tester[master]: testenv: Provide tests with access to process module

2018-05-19 Thread Pau Espin Pedrol 
Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9235 )

Change subject: testenv: Provide tests with access to process module
..

testenv: Provide tests with access to process module

Some tests may want to start/stop/manages processes themselves. By using
the process module from osmo-gsm-tester, we make that possible easily,
providing with useful features such as requesting a suite to stop it on
cleanup.

Change-Id: I8e018107cbec81299ec2228bfff933fb3b0bb6cd
---
M src/osmo_gsm_tester/test.py
M src/osmo_gsm_tester/testenv.py
2 files changed, 6 insertions(+), 4 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/osmo_gsm_tester/test.py b/src/osmo_gsm_tester/test.py
index 59d503c..b706dac 100644
--- a/src/osmo_gsm_tester/test.py
+++ b/src/osmo_gsm_tester/test.py
@@ -54,9 +54,9 @@
 log.large_separator(self.suite_run.trial.name(), 
self.suite_run.name(), self.name(), sublevel=3)
 self.status = Test.UNKNOWN
 self.start_timestamp = time.time()
-from . import suite, sms
+from . import suite, sms, process
 from .event_loop import MainLoop
-testenv.setup(self.suite_run, self, suite, MainLoop, sms)
+testenv.setup(self.suite_run, self, suite, MainLoop, sms, process)
 with self.redirect_stdout():
 util.run_python_file('%s.%s' % 
(self.suite_run.definition.name(), self.basename),
  self.path)
diff --git a/src/osmo_gsm_tester/testenv.py b/src/osmo_gsm_tester/testenv.py
index 26b492e..ceea028 100644
--- a/src/osmo_gsm_tester/testenv.py
+++ b/src/osmo_gsm_tester/testenv.py
@@ -34,9 +34,10 @@
 prompt = None
 Timeout = None
 Sms = None
+process = None

-def setup(suite_run, _test, suite_module, event_module, sms_module):
-global trial, suite, test, resources, log, dbg, err, wait, wait_no_raise, 
sleep, poll, prompt, Timeout, Sms
+def setup(suite_run, _test, suite_module, event_module, sms_module, 
process_module):
+global trial, suite, test, resources, log, dbg, err, wait, wait_no_raise, 
sleep, poll, prompt, Timeout, Sms, process
 trial = suite_run.trial
 suite = suite_run
 test = _test
@@ -51,5 +52,6 @@
 prompt = suite_run.prompt
 Timeout = suite_module.Timeout
 Sms = sms_module.Sms
+process = process_module

 # vim: expandtab tabstop=4 shiftwidth=4

--
To view, visit https://gerrit.osmocom.org/9235
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8e018107cbec81299ec2228bfff933fb3b0bb6cd
Gerrit-Change-Number: 9235
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol

Change in osmo-gsm-tester[master]: contrib: common: create_bin_tgz supports sbin dir now

2018-05-19 Thread Pau Espin Pedrol 
Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9223 )

Change subject: contrib: common: create_bin_tgz supports sbin dir now
..

contrib: common: create_bin_tgz supports sbin dir now

This is a preparation for inclusion of osmocom-bb build job, which
installs binaries such as osmocon in sbin.

Change-Id: I562721af82e481e926ee65dbcd9dcc5b55057ae8
---
M contrib/jenkins-build-common.sh
M contrib/jenkins-build-osmo-bsc.sh
M contrib/jenkins-build-osmo-bts.sh
M contrib/jenkins-build-osmo-mgw.sh
4 files changed, 31 insertions(+), 21 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Pau Espin Pedrol: Looks good to me, approved



diff --git a/contrib/jenkins-build-common.sh b/contrib/jenkins-build-common.sh
index 9d85622..b8cafcf 100644
--- a/contrib/jenkins-build-common.sh
+++ b/contrib/jenkins-build-common.sh
@@ -139,32 +139,42 @@
   make install
 }

+prune_files() {
+bindir="$1"
+wanted_binaries="$2"
+
+if [ ! -d "$prefix_real/$bindir" ]; then return; fi
+# remove binaries not intended to originate from this build
+cd "$prefix_real/$bindir"
+for f in * ; do
+  if [ -z "$(echo "_ $wanted_binaries _" | grep " $f ")" ]; then
+rm "$f"
+  fi
+done
+
+# ensure requested binaries indeed exist
+for b in $wanted_binaries ; do
+  if [ ! -f "$b" ]; then
+set +x; echo "ERROR: no such binary: $b in $prefix_real/$bindir/"; 
set -x
+ls -1 "$prefix_real/$bindir"
+exit 1
+  fi
+done
+}
+
 create_bin_tgz() {
   # build the archive that is going to be copied to the tester

-  wanted_binaries="$@"
+  wanted_binaries_bin="$1"
+  wanted_binaries_sbin="$2"

-  if [ -z "$wanted_binaries" ]; then
+  if [ -z "$wanted_binaries_bin" ] && [ -z "$wanted_binaries_sbin" ]; then
 set +x; echo "ERROR: create_bin_tgz needs a list of permitted binaries"; 
set -x
 exit 1
   fi

-  # remove binaries not intended to originate from this build
-  cd "$prefix_real"/bin
-  for f in * ; do
-if [ -z "$(echo "_ $wanted_binaries _" | grep " $f ")" ]; then
-  rm "$f"
-fi
-  done
-
-  # ensure requested binaries indeed exist
-  for b in $wanted_binaries ; do
-if [ ! -f "$b" ]; then
-  set +x; echo "ERROR: no such binary: $b in $prefix_real/bin/"; set -x
-  ls -1 "$prefix_real/bin"
-  exit 1
-fi
-  done
+  prune_files bin "$wanted_binaries_bin"
+  prune_files sbin "$wanted_binaries_sbin"

   cd "$prefix_real"
   this="$name.build-${BUILD_NUMBER-$(date +%Y-%m-%d_%H_%M_%S)}"
diff --git a/contrib/jenkins-build-osmo-bsc.sh 
b/contrib/jenkins-build-osmo-bsc.sh
index 73e71e5..4081a00 100755
--- a/contrib/jenkins-build-osmo-bsc.sh
+++ b/contrib/jenkins-build-osmo-bsc.sh
@@ -11,4 +11,4 @@
 build_repo osmo-mgw --enable-sanitize
 build_repo osmo-bsc --enable-sanitize

-create_bin_tgz osmo-bsc abisip-find ipaccess-config
+create_bin_tgz "osmo-bsc abisip-find ipaccess-config"
diff --git a/contrib/jenkins-build-osmo-bts.sh 
b/contrib/jenkins-build-osmo-bts.sh
index b40c613..e5fab5d 100755
--- a/contrib/jenkins-build-osmo-bts.sh
+++ b/contrib/jenkins-build-osmo-bts.sh
@@ -10,4 +10,4 @@
 build_repo libosmo-abis --enable-sanitize
 build_repo osmo-bts --enable-sanitize --enable-trx 
--with-openbsc=$base/openbsc/openbsc/include --enable-octphy 
--with-octsdr-2g=$base/octphy-2g-headers

-create_bin_tgz osmo-bts-trx osmo-bts-octphy
+create_bin_tgz "osmo-bts-trx osmo-bts-octphy"
diff --git a/contrib/jenkins-build-osmo-mgw.sh 
b/contrib/jenkins-build-osmo-mgw.sh
index d4ff0b9..43473c6 100755
--- a/contrib/jenkins-build-osmo-mgw.sh
+++ b/contrib/jenkins-build-osmo-mgw.sh
@@ -9,4 +9,4 @@
 build_repo libosmo-netif --enable-sanitize --disable-doxygen
 build_repo osmo-mgw --enable-sanitize

-create_bin_tgz osmo-bsc_mgcp osmo-mgw
+create_bin_tgz "osmo-bsc_mgcp osmo-mgw"

--
To view, visit https://gerrit.osmocom.org/9223
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I562721af82e481e926ee65dbcd9dcc5b55057ae8
Gerrit-Change-Number: 9223
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol

Change in osmo-gsm-tester[master]: contrib: common: create_bin_tgz supports sbin dir now

2018-05-19 Thread Pau Espin Pedrol 
Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/9223 )

Change subject: contrib: common: create_bin_tgz supports sbin dir now
..


Patch Set 2: Code-Review+2

I +2 it since I addressed the comments from Neels


--
To view, visit https://gerrit.osmocom.org/9223
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I562721af82e481e926ee65dbcd9dcc5b55057ae8
Gerrit-Change-Number: 9223
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Sat, 19 May 2018 12:03:50 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: MSC_ConnectionHandler: check channel mode in f_establish_fully

2018-05-19 Thread Harald Welte 
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9231 )

Change subject: MSC_ConnectionHandler: check channel mode in f_establish_fully
..


Patch Set 2:

A TCH can also be in signaling mode, which your new function doesn't cover. 
Please at least add a fimxe to the code and mention it in the commitlog. Thanks


--
To view, visit https://gerrit.osmocom.org/9231
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9004f299220b01ecea6b2316ba3f913c316947dc
Gerrit-Change-Number: 9231
Gerrit-PatchSet: 2
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Sat, 19 May 2018 08:10:47 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: BSC_Tests: fix TC_ciph_mode_a5_{0, 1, 3}

2018-05-19 Thread Harald Welte 
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9232 )

Change subject: BSC_Tests: fix TC_ciph_mode_a5_{0,1,3}
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9232
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib39d7dd2d1b3665570d7b287e431d10111316437
Gerrit-Change-Number: 9232
Gerrit-PatchSet: 2
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Sat, 19 May 2018 08:07:28 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: add counter for connection attempts from BTS with unknown unit id

2018-05-19 Thread Harald Welte 
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9218 )

Change subject: add counter for connection attempts from BTS with unknown unit 
id
..


Patch Set 3: Code-Review+1

One might think of implementing this somewhere generic in a library, but I 
think we still have three IPA. implementations around. In terms of naming, some 
reference to abis would be good, as other interfaces (A, CTRL, ...) May also 
use IPA


--
To view, visit https://gerrit.osmocom.org/9218
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I58866aff36a1c8463bf84b4392a5124ffeaa32ea
Gerrit-Change-Number: 9218
Gerrit-PatchSet: 3
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Comment-Date: Sat, 19 May 2018 08:05:14 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: add counter for connection attempts from BTS with unknown unit id

2018-05-19 Thread Harald Welte 
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9218 )

Change subject: add counter for connection attempts from BTS with unknown unit 
id
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9218
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I58866aff36a1c8463bf84b4392a5124ffeaa32ea
Gerrit-Change-Number: 9218
Gerrit-PatchSet: 3
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Comment-Date: Sat, 19 May 2018 08:03:33 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: add counter for connection attempts from BTS with unknown unit id

2018-05-19 Thread Harald Welte 
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9218 )

Change subject: add counter for connection attempts from BTS with unknown unit 
id
..


Patch Set 3:

> > (1 comment)
 >
 > What does "IPA CCM" stand for?

We have no idea. We have never seen any specs for that protocol

 > The counter names are scoped to a topic (e.g. "handover:").
 > What would be a suitable topic to use instead of "oml:"? Would
 > "ipa:" be OK, "ipa:unknown_unit_id" ?

Ack


--
To view, visit https://gerrit.osmocom.org/9218
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I58866aff36a1c8463bf84b4392a5124ffeaa32ea
Gerrit-Change-Number: 9218
Gerrit-PatchSet: 3
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Comment-Date: Sat, 19 May 2018 08:02:56 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-mgw[master]: mgcp_sdp: correct apidoc of mgcp_parse_sdp_data

2018-05-19 Thread Harald Welte 
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9233 )

Change subject: mgcp_sdp: correct apidoc of mgcp_parse_sdp_data
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9233
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9906f1dd6811c7092b93d60c9348221fef68cc3e
Gerrit-Change-Number: 9233
Gerrit-PatchSet: 2
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Comment-Date: Sat, 19 May 2018 08:01:31 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-mgw[master]: sdp: remove unused alt_codec field from struct mgcp_rtp_end

2018-05-19 Thread Harald Welte 
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9234 )

Change subject: sdp: remove unused alt_codec field from struct mgcp_rtp_end
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9234
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ff2899e3e61f33eb86f284b50ad8a94a949ed16
Gerrit-Change-Number: 9234
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Comment-Date: Sat, 19 May 2018 08:00:35 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-gsm-tester[master]: testenv: Provide tests with access to process module

2018-05-19 Thread Harald Welte 
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9235 )

Change subject: testenv: Provide tests with access to process module
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9235
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e018107cbec81299ec2228bfff933fb3b0bb6cd
Gerrit-Change-Number: 9235
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Sat, 19 May 2018 07:58:33 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ci[master]: jobs: osmo-gsm-tester-runner: Add ttcn3 job

2018-05-19 Thread Harald Welte 
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9225 )

Change subject: jobs: osmo-gsm-tester-runner: Add ttcn3 job
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9225
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ca1c9a3a18138a27232efba7d65d6806e044a6b
Gerrit-Change-Number: 9225
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Comment-Date: Sat, 19 May 2018 07:57:17 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Build failed in Jenkins: master-osmo-pcu » master,osmocom-master-debian9,none,False #482

2018-05-19 Thread jenkins 
See 


--
[...truncated 115.63 KB...]
  CXX  egprs_rlc_compression.lo
  CXXLDlibgprs.la
ar: `u' modifier ignored since `D' is the default (see `U')
  CXX  pcu_main.o
  CXXLDosmo-pcu
make[2]: Leaving directory 
'
Making all in examples
make[2]: Entering directory 
'
make[2]: Nothing to be done for 'all'.
make[2]: Leaving directory 
'
Making all in tests
make[2]: Entering directory 
'
  CXX  pcu_emu.o
  CXX  test_replay_gprs_attach.o
  CC   openbsc_clone.o
  CXX  test_pdp_activation.o
  CXXLDemu/pcu_emu
make[2]: Leaving directory 
'
make[2]: Entering directory 
'
make[2]: Nothing to be done for 'all-am'.
make[2]: Leaving directory 
'
make[1]: Leaving directory 
'
make[1]: Entering directory 
'
Making dvi in include
make[2]: Entering directory 
'
make[2]: Nothing to be done for 'dvi'.
make[2]: Leaving directory 
'
Making dvi in src
make[2]: Entering directory 
'
make[2]: Nothing to be done for 'dvi'.
make[2]: Leaving directory 
'
Making dvi in examples
make[2]: Entering directory 
'
make[2]: Nothing to be done for 'dvi'.
make[2]: Leaving directory 
'
Making dvi in tests
make[2]: Entering directory 
'
make[2]: Nothing to be done for 'dvi'.
make[2]: Leaving directory 
'
make[2]: Entering directory 
'
make[2]: Nothing to be done for 'dvi-am'.
make[2]: Leaving directory 
'
make[1]: Leaving directory