Change in osmo-bsc[master]: fix / clarify rsl dtap cache

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/9668 )

Change subject: fix / clarify rsl dtap cache
..


Patch Set 3:

(3 comments)

Sorry about not addressing everything yet, as I am resolving other patches' 
issues, I want to re-push to ensure we see small patch sets, but am not through 
with this one yet...

https://gerrit.osmocom.org/#/c/9668/3/include/osmocom/bsc/gsm_data.h
File include/osmocom/bsc/gsm_data.h:

https://gerrit.osmocom.org/#/c/9668/3/include/osmocom/bsc/gsm_data.h@123
PS3, Line 123:  struct llist_head dtap_cache;
> unrelated to this patch: I think "cache" is a misnomer.  It' s simply a 
> queue. […]
I agree, just took this over from other peoples' patches


https://gerrit.osmocom.org/#/c/9668/3/src/osmo-bsc/bsc_subscr_conn_fsm.c
File src/osmo-bsc/bsc_subscr_conn_fsm.c:

https://gerrit.osmocom.org/#/c/9668/3/src/osmo-bsc/bsc_subscr_conn_fsm.c@1125
PS3, Line 1125: 23
> no #define? 23 seems like a lot, btw.
Wasn't my choice; I think this is just an upper sanity limit, could be 
intentional to be essentially "unlimited". Need not be config item, does it?


https://gerrit.osmocom.org/#/c/9668/3/src/osmo-bsc/bsc_subscr_conn_fsm.c@1126
PS3, Line 1126: DHO
> why do we log this in DHO, if it's now a generic functionality?
good point



--
To view, visit https://gerrit.osmocom.org/9668
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ffd7aa641c8905292c769400048c96aa0949585
Gerrit-Change-Number: 9668
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Comment-Date: Fri, 06 Jul 2018 22:18:31 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-bsc[master]: inter-BSC HO: add neighbor_ident API to manage neighbor-BSS-cells

[Neels Hofmeyr]

Hello Pau Espin Pedrol, Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/9666

to look at the new patch set (#7).

Change subject: inter-BSC HO: add neighbor_ident API to manage 
neighbor-BSS-cells
..

inter-BSC HO: add neighbor_ident API to manage neighbor-BSS-cells

Change-Id: I0153d7069817fba9146ddc11214de2757d7d37bf
---
M include/osmocom/bsc/Makefile.am
M include/osmocom/bsc/gsm_data.h
M include/osmocom/bsc/handover.h
A include/osmocom/bsc/neighbor_ident.h
M src/osmo-bsc/Makefile.am
M src/osmo-bsc/bsc_init.c
M src/osmo-bsc/bsc_vty.c
M src/osmo-bsc/gsm_data.c
M src/osmo-bsc/handover_logic.c
A src/osmo-bsc/neighbor_ident.c
A src/osmo-bsc/neighbor_ident_vty.c
M src/osmo-bsc/net_init.c
M src/osmo-bsc/system_information.c
M tests/bsc/Makefile.am
M tests/gsm0408/Makefile.am
M tests/handover/Makefile.am
A tests/handover/neighbor_ident_test.c
A tests/handover/neighbor_ident_test.err
A tests/handover/neighbor_ident_test.ok
A tests/neighbor_ident.vty
M tests/testsuite.at
21 files changed, 1,958 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/66/9666/7
--
To view, visit https://gerrit.osmocom.org/9666
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0153d7069817fba9146ddc11214de2757d7d37bf
Gerrit-Change-Number: 9666
Gerrit-PatchSet: 7
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmo-bsc[master]: inter-BSC HO: add neighbor_ident API to manage neighbor-BSS-cells

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/9666 )

Change subject: inter-BSC HO: add neighbor_ident API to manage 
neighbor-BSS-cells
..


Patch Set 3:

> -1 to the whole branch since osmo-gsm-tester found an assertion
 > failure:
 >
 > 20180627143850497 DRLL <> mgcp_client_fsm.c:430
 > MGCP_CONN(to-BTS)[0x61207120]{ST_DLCX_RESP}: Received Event
 > EV_DLCX_RESP
 > 20180627143850497 DRLL <> mgcp_client_fsm.c:446
 > MGCP_CONN(to-BTS)[0x61207120]{ST_DLCX_RESP}: Terminating (cause
 > = OSMO_FSM_TERM_REGULAR)
 > 20180627143850497 DRLL <> mgcp_client_fsm.c:446
 > MGCP_CONN(to-BTS)[0x61207120]{ST_DLCX_RESP}: Freeing instance
 > 20180627143850497 DRLL <> fsm.c:381 
 > MGCP_CONN(to-BTS)[0x61207120]{ST_DLCX_RESP}:
 > Deallocated
 > 20180627143850498 DRSL <0003> abis_rsl.c:1123 
 > lchan(0-0-2-TCH_F-0)[0x61208aa0]{BORKEN}:
 > (type=NONE) Rx RF_CHAN_REL_ACK
 > 20180627143850499 DRSL <0003> abis_rsl.c:1155 
 > lchan(0-0-2-TCH_F-0)[0x61208aa0]{BORKEN}:
 > Received Event LCHAN_EV_RSL_RF_CHAN_REL_ACK
 > Assert failed false lchan_fsm.c:1119

this is related to the "large refactoring" commit. A fix for that ... problem 
family exists and will be pushed soon.


--
To view, visit https://gerrit.osmocom.org/9666
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0153d7069817fba9146ddc11214de2757d7d37bf
Gerrit-Change-Number: 9666
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Fri, 06 Jul 2018 22:07:22 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-bsc[master]: inter-BSC HO: add neighbor_ident API to manage neighbor-BSS-cells

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/9666 )

Change subject: inter-BSC HO: add neighbor_ident API to manage 
neighbor-BSS-cells
..


Patch Set 3:

(5 comments)

https://gerrit.osmocom.org/#/c/9666/3/include/osmocom/bsc/gsm_data.h
File include/osmocom/bsc/gsm_data.h:

https://gerrit.osmocom.org/#/c/9666/3/include/osmocom/bsc/gsm_data.h@755
PS3, Line 755: struct gsm_bts_ref {
> not a request to change, just a general reminder: We also have the "vector" 
> of libosmovty, which is  […]
ah. I thought the vector was a string parsing specific implementation, now I 
see it's sort of like the C++ vector... with vector the allocation dance is 
slightly more complex to code, though it has a better memory footprint. Though 
if you say not a request to change, then I'll not change it.


https://gerrit.osmocom.org/#/c/9666/3/include/osmocom/bsc/neighbor_ident.h
File include/osmocom/bsc/neighbor_ident.h:

https://gerrit.osmocom.org/#/c/9666/3/include/osmocom/bsc/neighbor_ident.h@18
PS3, Line 18:   BSIC_9BIT,
> huh, where's that 9 bit BSIC coming from? Do you have a spec reference for me?
23.003 "4.3.2 Base Station Identify Code (BSIC)"

says:

"BSIC is a 6 bit code which is structured as shown in Figure 6. Exceptions 
apply to networks supporting
EC-GSM-IoT or PEO and for mobile stations in EC or PEO operation (see 3GPP TS 
43.064 [112]) where the BSIC is a
9 bit code which is structured as shown in Figure 6a."

Let me guess, EC-GSM-IoT or PEO (which i haven't a clue about) doesn't apply 
and we can cut out the entire 9-bit bsic enum? I think I just saw the 
6-or-9-bit BSIC encoding somewhere, like in a message coding chapter, and 
thought it was safer to allow both from the start...


https://gerrit.osmocom.org/#/c/9666/3/src/osmo-bsc/gsm_data.c
File src/osmo-bsc/gsm_data.c:

https://gerrit.osmocom.org/#/c/9666/3/src/osmo-bsc/gsm_data.c@567
PS3, Line 567: bool gsm_bts_matches_cell_id(struct gsm_bts *bts, const struct 
gsm0808_cell_id *ci)
> not important, but I'd expect 'bts' could also be a const pointer, as we're 
> just reading/comparing/m […]
I wonder why I wouldn't have consted that... maybe it was copy-pasted from a 
more potent function. Ah, I see now that I'm actually changing it again in the 
"large refactoring commit", will move that part here.


https://gerrit.osmocom.org/#/c/9666/3/src/osmo-bsc/neighbor_ident_vty.c
File src/osmo-bsc/neighbor_ident_vty.c:

https://gerrit.osmocom.org/#/c/9666/3/src/osmo-bsc/neighbor_ident_vty.c@560
PS3, Line 560:  install_element(BTS_NODE, _neighbor_resolve_cmd);
> the BTS_NODE is a sub-node of the CONFIG NODE. […]
hm, so when I'm in the bts node and entered some neighbor entries, I can't just 
query on the same level but I should prepend 'do bts '? I understand the 
scoping aspect, wasn't aware that it's that strict though. Ok, so how about 
'show bts NR neighbor NEIGHBOR_IDENT_VTY_KEY_PARAMS'.


https://gerrit.osmocom.org/#/c/9666/3/tests/handover/neighbor_ident_test.c
File tests/handover/neighbor_ident_test.c:

https://gerrit.osmocom.org/#/c/9666/3/tests/handover/neighbor_ident_test.c@33
PS3, Line 33: arfcn
> it might be interesting to have test cases for ARFCNs in different bands. […]
In turn I'm not fully understanding yet where the pitfall lies in that. Here, 
I'm simply using arfcn as a 16bit key, and the high bit is simply the high bit 
in that number space. Should it imply some special meaning and/or affect other 
data fields?



--
To view, visit https://gerrit.osmocom.org/9666
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0153d7069817fba9146ddc11214de2757d7d37bf
Gerrit-Change-Number: 9666
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Fri, 06 Jul 2018 22:06:12 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: log / comment tweaks

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/9627 )

Change subject: log / comment tweaks
..


Patch Set 3:

I can see the MGW's MGCP communication easily, but AFAICT wireshark doesn't 
show me the IPACC CRCX/MDCX contents sent to the BTS. Am I missing a config 
item?


--
To view, visit https://gerrit.osmocom.org/9627
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93c2914e766e200d89308cc81dd803e939b9b28c
Gerrit-Change-Number: 9627
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Fri, 06 Jul 2018 21:33:07 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Build failure of network:osmocom:nightly/osmo-mgw in Debian_9.0/armv7l

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-mgw/Debian_9.0/armv7l

Package network:osmocom:nightly/osmo-mgw failed to build in Debian_9.0/armv7l

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-mgw

Last lines of build log:
[  218s] | configure:6324: checking for a working dd
[  218s] | configure:6362: result: /bin/dd
[  218s] | configure:6366: checking how to truncate binary pipes
[  218s] | configure:6381: result: /bin/dd bs=4096 count=1
[  218s] | configure:6710: checking for mt
[  218s] | configure:6740: result: no
[  218s] | configure:6760: checking if : is a manifest tool
[  218s] | configure:6766: : '-?'
[  218s] | configure:6774: result: no
[  218s] | configure:7451: checking how to run the C preprocessor
[  218s] | configure:7482: gcc -E -Wdate-time -D_FORTIFY_SOURCE=2 conftest.c
[  218s] | configure:7482: $? = 0
[  218s] | configure:7496: gcc -E -Wdate-time -D_FORTIFY_SOURCE=2 conftest.c
[  218s] | conftest.c:11:28: fatal error: ac_nonexistent.h: No such file or 
directory
[  218s] |  #include 
[  218s] | ^
[  218s] | compilation terminated.
[  218s] | configure:7496: $? = 1
[  218s] | configure: failed program was:
[  218s] | | /* confdefs.h */
[  218s] | | #define PACKAGE_NAME "osmo-mgw"
[  218s] | | #define PACKAGE_TARNAME "osmo-mgw"
[  218s] | | #define PACKAGE_VERSION "1.3.0.29.cede2"
[  220s] | | #define PACKAGE_STRING "osmo-mgw 1.3.0.[  181.264316] SysRq : 
Power Off
[  220s] [  181.266012] reboot: Power down
[  220s] ### VM INTERACTION END ###
[  220s] 
[  220s] armbuild19 failed "build osmo-mgw_1.3.0.29.cede2.dsc" at Fri Jul  6 
20:46:19 UTC 2018.
[  220s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Change in osmocom-bb[master]: calypso: Print warning about unsupported encryption algorithms

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/9906


Change subject: calypso: Print warning about unsupported encryption algorithms
..

calypso: Print warning about unsupported encryption algorithms

Unfortunately current code architecture doesn't support a return path
with an error so tell the caller of L1CTL on the other side that
something's wrong.

Change-Id: Ib9b622dd5c9770c5e97fa58deee124a409544d3b
---
M src/target/firmware/calypso/dsp.c
1 file changed, 3 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/06/9906/1

diff --git a/src/target/firmware/calypso/dsp.c 
b/src/target/firmware/calypso/dsp.c
index c37ca82..235d359 100644
--- a/src/target/firmware/calypso/dsp.c
+++ b/src/target/firmware/calypso/dsp.c
@@ -568,6 +568,9 @@
 {
dsp_api.ndb->d_a5mode = mode;

+   if (mode >= 3) /* Only A5/0, A5/1, A5/2 are supported by calypso */
+   printd("Algo A5/%u is not supported!!!\n", mode);
+
if (!mode || !key)
return;


--
To view, visit https://gerrit.osmocom.org/9906
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib9b622dd5c9770c5e97fa58deee124a409544d3b
Gerrit-Change-Number: 9906
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in libosmo-sccp[master]: tweak the default point codes used by sccp_demo_user

[Stefan Sperling]

Hello Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/9652

to look at the new patch set (#2).

Change subject: tweak the default point codes used by sccp_demo_user
..

tweak the default point codes used by sccp_demo_user

commit 4dc9088cabedc40cb9072814237ad5926b12bd35 changed
default local point code values from:

Client local point code: 23
Server local point code: 1

to

Local point code: -1 (in either mode)
Remote point code: 23 (in either mode)

Revert to the previous behaviour:

Set the client's default point code to 23, and the server's default point
code to 1 so that sccp_demo_user clients and servers will talk to each
other by default. Show default values for all cases in the help output.
This default behaviour will be assumed by the upcoming SCCP test suite.

While here, remove unused -p option from getopt() argument list.

Change-Id: I7432e6fc2617e0fd77a098fcd7d14abc40db7229
Related: OS#2666
---
M examples/sccp_demo_user.c
1 file changed, 49 insertions(+), 20 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/52/9652/2
--
To view, visit https://gerrit.osmocom.org/9652
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7432e6fc2617e0fd77a098fcd7d14abc40db7229
Gerrit-Change-Number: 9652
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Stefan Sperling 

Change in osmo-ttcn3-hacks[master]: library: Ensure setverdict(fail is followed by mtc.stop

[daniel]

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/9905


Change subject: library: Ensure setverdict(fail is followed by mtc.stop
..

library: Ensure setverdict(fail is followed by mtc.stop

This will prevent subsequent failures from overwriting the verdict so we
can easily see the root cause of the test failure.

Change-Id: Idc6819aaf0b01e70c38fad828dd44dcec6bdd778
---
M library/BSSAP_Adapter.ttcn
M library/BSSGP_Emulation.ttcn
M library/BSSMAP_Emulation.ttcn
M library/GSM_Types.ttcn
M library/GSUP_Emulation.ttcn
M library/GTP_Emulation.ttcn
M library/GTP_Templates.ttcn
M library/IPA_Emulation.ttcnpp
M library/IuUP_Emulation.ttcn
M library/L1CTL_PortType.ttcn
M library/L3_Common.ttcn
M library/LAPDm_RAW_PT.ttcn
M library/MGCP_Emulation.ttcn
M library/MGCP_Templates.ttcn
M library/MNCC_Emulation.ttcn
M library/MNCC_Types.ttcn
M library/NS_Emulation.ttcn
M library/Osmocom_CTRL_Adapter.ttcn
M library/Osmocom_CTRL_Functions.ttcn
M library/Osmocom_Types.ttcn
M library/Osmocom_VTY_Functions.ttcn
M library/PCUIF_CodecPort.ttcn
M library/RSL_Emulation.ttcn
M library/RTP_Emulation.ttcn
M library/SIP_Emulation.ttcn
M library/SMPP_Emulation.ttcn
M library/TRXC_CodecPort.ttcn
27 files changed, 149 insertions(+), 147 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/05/9905/1

diff --git a/library/BSSAP_Adapter.ttcn b/library/BSSAP_Adapter.ttcn
index e50487d..b29d03f 100644
--- a/library/BSSAP_Adapter.ttcn
+++ b/library/BSSAP_Adapter.ttcn
@@ -144,7 +144,7 @@
}
case else {
setverdict(fail, "Unsuppored BSSAP_Transport");
-   self.stop;
+   mtc.stop;
}
}

diff --git a/library/BSSGP_Emulation.ttcn b/library/BSSGP_Emulation.ttcn
index f51d539..8b3b9eb 100644
--- a/library/BSSGP_Emulation.ttcn
+++ b/library/BSSGP_Emulation.ttcn
@@ -288,8 +288,7 @@
return;
}
}
-   setverdict(fail, "Client Table full");
-   self.stop;
+   testcase.stop("Client Table full");
 }

 private function f_tbl_client_del(hexstring imsi, BSSGP_Client_CT vc_conn) 
runs on BSSGP_CT {
@@ -299,7 +298,7 @@
if (ClientTable[i].comp_ref != vc_conn) {
setverdict(fail, "Cannot unregister index=", i, 
" IMSI ", imsi, " registred to ",
   ClientTable[i].comp_ref, " from ", 
vc_conn);
-   self.stop;
+   mtc.stop;
}
log("Removing Client IMSI=", imsi, ", index=", i);
ClientTable[i] := {
@@ -313,7 +312,7 @@
}
}
setverdict(fail, "Could not find client for IMSI ", imsi);
-   self.stop;
+   mtc.stop;
 }

 /* TS 44.064 7.2.1.1 LLGMM-ASSIGN */
@@ -344,7 +343,7 @@
}
}
setverdict(fail, "Couldn't find Component for IMSI ", imsi);
-   self.stop;
+   mtc.stop;
 }
 
 private function f_tbl_comp_by_tlli(OCT4 tlli) runs on BSSGP_CT return 
BSSGP_Client_CT {
@@ -357,7 +356,7 @@
}
}
setverdict(fail, "Couldn't find Component for TLLI ", tlli);
-   self.stop;
+   mtc.stop;
 }

 private function f_tbl_idx_by_comp(BSSGP_Client_CT comp_ref) runs on BSSGP_CT 
return integer {
@@ -368,7 +367,7 @@
}
}
setverdict(fail, "Couldn't find Client for Component ", comp_ref);
-   self.stop;
+   mtc.stop;
 }

 private function f_tbl_tlli_by_comp(BSSGP_Client_CT comp_ref) runs on BSSGP_CT 
return OCT4 {
@@ -380,7 +379,7 @@
}
}
setverdict(fail, "Couldn't find TLLI for Component ", comp_ref);
-   self.stop;
+   mtc.stop;
 }

 altstep as_allstate() runs on BSSGP_CT {
@@ -590,7 +589,7 @@
return c_LLC_SAPI_LLSMS;
}
setverdict(fail, "No LLC SAPI for ", l3_mo);
-   self.stop;
+   mtc.stop;
 }

 private function f_llc_sapi_by_l3_mt(PDU_L3_SGSN_MS l3_mt) return BIT4 {
@@ -602,7 +601,7 @@
return c_LLC_SAPI_LLSMS;
}
setverdict(fail, "No LLC SAPI for ", l3_mt);
-   self.stop;
+   mtc.stop;
 }
 

diff --git a/library/BSSMAP_Emulation.ttcn b/library/BSSMAP_Emulation.ttcn
index e65c550..921ac59 100644
--- a/library/BSSMAP_Emulation.ttcn
+++ b/library/BSSMAP_Emulation.ttcn
@@ -202,9 +202,8 @@
return ConnectionTable[i].comp_ref;
}
}
-   log("BSSMAP Connection table not found by SCCP Connection ID ", 
sccp_conn_id);
-   setverdict(fail);
-   self.stop;
+   setverdict(fail, "BSSMAP Connection table not found by SCCP Connection 
ID ", sccp_conn_id);
+   mtc.stop;
 }

 /* resolve component reference by CIC */
@@ -216,9 +215,8 @@
return ConnectionTable[i].comp_ref;
 

Change in osmo-ttcn3-hacks[master]: BTS_Tests: Ensure mtc.stop is called after setverdict(fail, ...)

[daniel]

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/9904


Change subject: BTS_Tests: Ensure mtc.stop is called after setverdict(fail, ...)
..

BTS_Tests: Ensure mtc.stop is called after setverdict(fail, ...)

This will prevent subsequent failures from overwriting the verdict so we
can easily see the root cause of the test failure.

Change-Id: Iba59a69127e845cadbe9aaa1dabd87ff5ce8b43b
---
M bts/BTS_Tests.ttcn
1 file changed, 74 insertions(+), 40 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/04/9904/1

diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index aee081e..4f0f0ef 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -257,7 +257,7 @@
}
[] pt.receive(t_SD_PCUIF(pcu_conn_id, tr_PCUIF_INFO_IND(?, ?, ?))) -> 
value sd {
setverdict(fail, "Invalid PCU Version/BTS Number received");
-   self.stop;
+   mtc.stop;
}
 }

@@ -276,7 +276,7 @@
[] as_pcu_info_ind(pt, pcu_conn_id, pcu_last_info);
[] T.timeout {
setverdict(fail, "Timeout waiting for PCU INFO_IND");
-   self.stop;
+   mtc.stop;
}
}
 }
@@ -316,7 +316,7 @@
[] RSL_CCHAN.receive(ASP_IPA_Event:{up_down := ASP_IPA_EVENT_UP});
[] T.timeout {
setverdict(fail, "Timeout waiting for ASP_IPA_EVENT_UP");
-   self.stop;
+   mtc.stop;
}
}
f_sleep(0.5);   /* workaround for OS#3000 */
@@ -389,7 +389,7 @@
 private altstep as_Tguard() runs on ConnHdlr {
[] g_Tguard.timeout {
setverdict(fail, "Tguard timeout");
-   self.stop;
+   mtc.stop;
}
 }

@@ -404,7 +404,7 @@
"", -1, -1, {udp:={}}, 
{});
if (not ispresent(res.connId)) {
setverdict(fail, "Could not connect to trx-control interface of 
trxcon, check your configuration");
-   self.stop;
+   mtc.stop;
}
g_bb_trxc_conn_id := res.connId;
 }
@@ -455,14 +455,14 @@
}
[] T.timeout {
setverdict(fail, "Timeout expecting " & id);
-   self.stop;
+   mtc.stop;
}
[not ignore_other] as_l1_sacch();
[not ignore_other] as_meas_res();
[not ignore_other] as_l1_dcch();
[not ignore_other] RSL.receive {
setverdict(fail, "Unexpected RSL message received");
-   self.stop;
+   mtc.stop;
}
[ignore_other] RSL.receive { repeat; }
}
@@ -550,6 +550,7 @@
alt {
[] RSL.receive(tr_RSL_CHAN_ACT_ACK(g_chan_nr)) {
setverdict(fail, "Unexpected CHAN ACT ACK on double 
activation");
+   mtc.stop;
}
[] RSL.receive(tr_RSL_CHAN_ACT_NACK(g_chan_nr)) {
setverdict(pass);
@@ -577,6 +578,7 @@
}
[] T.timeout {
setverdict(fail, "Timeout expecting RF_CHAN_REL_ACK");
+   mtc.stop;
}
}
 }
@@ -594,6 +596,7 @@
alt {
[] RSL.receive(tr_RSL_CHAN_ACT_ACK(g_chan_nr)) {
setverdict(fail, "Unexpected CHAN ACT ACK");
+   mtc.stop;
}
[] RSL.receive(tr_RSL_CHAN_ACT_NACK(g_chan_nr)) {
setverdict(pass);
@@ -667,6 +670,7 @@
alt {
[not exp] L1CTL.receive(tr_L1CTL_DATA_IND(g_chan_nr, 
tr_RslLinkID_SACCH(0))) {
setverdict(fail, "Received SACCH when not expecting it");
+   mtc.stop;
}
[not exp] T_sacch.timeout {
setverdict(pass);
@@ -676,6 +680,7 @@
}
[exp] T_sacch.timeout {
setverdict(fail, "Timeout waiting for SACCH on ", g_chan_nr);
+   mtc.stop;
}
[] L1CTL.receive { repeat; }
[] RSL.receive { repeat; }
@@ -740,7 +745,7 @@
[] L1CTL.receive { repeat; }
[] T_sacch.timeout {
setverdict(fail, "Timeout waiting for SACCH ", l3_exp);
-   self.stop;
+   mtc.stop;
}
}
 }
@@ -986,7 +991,7 @@
var GsmFrameNumber fn := f_L1CTL_RACH(L1CTL, oct2int(ra));
if (fn == fn_last) {
setverdict(fail, "Two RACH in same FN?!?");
-   self.stop;
+   mtc.stop;
}
fn_last := fn;

@@ -998,12 +1003,12 @@
}
[] RSL_CCHAN.receive(tr_RSL_UD(tr_RSL_CHAN_RQD(?, ?, ?))) {
setverdict(fail, "Unexpected CHAN RQD");
-   self.stop;
+   mtc.stop;
}

Change in osmo-ttcn3-hacks[master]: RSL_Emulation: Stop with error verdict if conn table runs out of space

[daniel]

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/9903


Change subject: RSL_Emulation: Stop with error verdict if conn table runs out 
of space
..

RSL_Emulation: Stop with error verdict if conn table runs out of space

Change-Id: If1a002da97cf1b66855f2e7a0fe2a54a6428bc81
---
M library/RSL_Emulation.ttcn
1 file changed, 4 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/03/9903/1

diff --git a/library/RSL_Emulation.ttcn b/library/RSL_Emulation.ttcn
index 119a9be..325f22e 100644
--- a/library/RSL_Emulation.ttcn
+++ b/library/RSL_Emulation.ttcn
@@ -195,7 +195,7 @@
return;
}
}
-   setverdict(fail, "No free entry in conn table for ", ra, fn);
+   testcase.stop("No free entry in conn table for ", ra, fn);
 }

 /* create an ew client with given RA and FN */
@@ -212,7 +212,7 @@
return;
}
}
-   setverdict(fail, "No free entry in conn table for ", trx_nr, chan_nr, 
comp_ref);
+   testcase.stop("No free entry in conn table for ", trx_nr, chan_nr, 
comp_ref);
 }


@@ -263,8 +263,7 @@
return;
}
}
-   setverdict(fail, "No space left in LastActTable to store chan_act for 
", chan_nr);
-   self.stop;
+   testcase.stop("No space left in LastActTable to store chan_act for ", 
chan_nr);
 }

 private function f_lookup_last_act(uint8_t trx_nr, RslChannelNr chan_nr)
@@ -275,8 +274,7 @@
return LastActTable[i].chan_act;
}
}
-   setverdict(fail, "No LastActTable entry found for TRX ", trx_nr, " ", 
chan_nr);
-   self.stop;
+   testcase.stop("No LastActTable entry found for TRX ", trx_nr, " ", 
chan_nr);
 }

 private function f_last_act_table_init() runs on RSL_Emulation_CT {

--
To view, visit https://gerrit.osmocom.org/9903
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If1a002da97cf1b66855f2e7a0fe2a54a6428bc81
Gerrit-Change-Number: 9903
Gerrit-PatchSet: 1
Gerrit-Owner: daniel 

Change in libosmo-sccp[master]: tweak the default point codes used by sccp_demo_user

[Stefan Sperling]

Stefan Sperling has posted comments on this change. ( 
https://gerrit.osmocom.org/9652 )

Change subject: tweak the default point codes used by sccp_demo_user
..


Patch Set 1:

> (1 comment)

Correction: -1 indicates the default protocol port for any of the protocols 
SUA, M3UA, and IPA, respectively.
The -1 is passed the port number to use is obtained from 
osmo_ss7_asp_protocol_port().


--
To view, visit https://gerrit.osmocom.org/9652
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7432e6fc2617e0fd77a098fcd7d14abc40db7229
Gerrit-Change-Number: 9652
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Comment-Date: Fri, 06 Jul 2018 15:42:25 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-bts[master]: rsl: Use value_string to print encryption algo name

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/9902


Change subject: rsl: Use value_string to print encryption algo name
..

rsl: Use value_string to print encryption algo name

Change-Id: I8303364270e73718e57f8efc2f375817b9496ffc
---
M src/common/rsl.c
1 file changed, 5 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/02/9902/1

diff --git a/src/common/rsl.c b/src/common/rsl.c
index 8bbf73c..9295240 100644
--- a/src/common/rsl.c
+++ b/src/common/rsl.c
@@ -865,12 +865,13 @@
 {
int rc;
struct gsm_bts *bts = lchan->ts->trx->bts;
+   const char *ciph_name = get_value_string(gsm0808_chosen_enc_alg_names, 
*val);

/* check if the encryption algorithm sent by BSC is supported! */
rc = bts_supports_cipher(bts, *val);
if (rc != 1) {
-   LOGP(DRSL, LOGL_ERROR, "%s: BTS doesn't support cipher 
0x%02x\n",
-   gsm_lchan_name(lchan), *val);
+   LOGP(DRSL, LOGL_ERROR, "%s: BTS doesn't support cipher %s\n",
+   gsm_lchan_name(lchan), ciph_name);
return -EINVAL;
}

@@ -886,8 +887,8 @@
if (lchan->encr.key_len > sizeof(lchan->encr.key))
lchan->encr.key_len = sizeof(lchan->encr.key);
memcpy(lchan->encr.key, val, lchan->encr.key_len);
-   DEBUGP(DRSL, "%s: Setting lchan cipher algorithm 0x%02x\n",
-   gsm_lchan_name(lchan), lchan->encr.alg_id);
+   DEBUGP(DRSL, "%s: Setting lchan cipher algorithm %s\n",
+   gsm_lchan_name(lchan), ciph_name);

return 0;
 }

--
To view, visit https://gerrit.osmocom.org/9902
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8303364270e73718e57f8efc2f375817b9496ffc
Gerrit-Change-Number: 9902
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in osmo-bts[master]: rsl: Use value_string to print encryption algo name

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/9902 )

Change subject: rsl: Use value_string to print encryption algo name
..


Patch Set 1:

Depends on https://gerrit.osmocom.org/#/c/libosmocore/+/9901/ to build 
correctly.


--
To view, visit https://gerrit.osmocom.org/9902
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8303364270e73718e57f8efc2f375817b9496ffc
Gerrit-Change-Number: 9902
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Fri, 06 Jul 2018 15:25:33 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in libosmo-sccp[master]: tweak the default point codes used by sccp_demo_user

[Stefan Sperling]

Stefan Sperling has posted comments on this change. ( 
https://gerrit.osmocom.org/9652 )

Change subject: tweak the default point codes used by sccp_demo_user
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/9652/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/9652/1//COMMIT_MSG@17
PS1, Line 17: -1
> As far as I can see, the old code was using -1, not the new code? (leaving 
> that aside, I don't even  […]
The old code (before 4dc9088cabedc40cb9072814237ad5926b12bd35)
was passing -1 for port numbers, not point codes.
I believe in this context -1 means "use any port".

The server was using point code 1, and expected the client to use point code 
23. The client was using point code 23.

One mistake in 4dc9088cabedc40cb9072814237ad5926b12bd35 was that I set the 
LOCAL_PC to -1 instead of 1 (got mixed up between ports and point codes).

I understand that having sccp_demo_user client/server talk to each other out of 
the box will be useful. I will try to keep it working that way in the next 
patch set.



--
To view, visit https://gerrit.osmocom.org/9652
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7432e6fc2617e0fd77a098fcd7d14abc40db7229
Gerrit-Change-Number: 9652
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Comment-Date: Fri, 06 Jul 2018 15:21:01 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in libosmocore[master]: gsm0808: Add value_string for encryption algorithms

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/9901


Change subject: gsm0808: Add value_string for encryption algorithms
..

gsm0808: Add value_string for encryption algorithms

Change-Id: Iadf6460c438d02c53c2eaa9e42d51844ad28859a
---
M include/osmocom/gsm/protocol/gsm_08_08.h
M src/gsm/gsm0808.c
M src/gsm/libosmogsm.map
3 files changed, 14 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/01/9901/1

diff --git a/include/osmocom/gsm/protocol/gsm_08_08.h 
b/include/osmocom/gsm/protocol/gsm_08_08.h
index db5f7fa..c007d2b 100644
--- a/include/osmocom/gsm/protocol/gsm_08_08.h
+++ b/include/osmocom/gsm/protocol/gsm_08_08.h
@@ -459,6 +459,7 @@
GSM0808_ALG_ID_A5_6 = 0x07,
GSM0808_ALG_ID_A5_7 = 0x08,
 };
+extern const struct value_string gsm0808_chosen_enc_alg_names[];

 /* GSM 08.08 3.2.2.85 Paging Information */
 enum gsm0808_paging_info {
diff --git a/src/gsm/gsm0808.c b/src/gsm/gsm0808.c
index 625de81..e3f4efe 100644
--- a/src/gsm/gsm0808.c
+++ b/src/gsm/gsm0808.c
@@ -1153,6 +1153,18 @@
{ 0, NULL }
 };

+const struct value_string gsm0808_chosen_enc_alg_names[] = {
+   { GSM0808_ALG_ID_A5_0, "A5/0" },
+   { GSM0808_ALG_ID_A5_1, "A5/1" },
+   { GSM0808_ALG_ID_A5_2, "A5/2" },
+   { GSM0808_ALG_ID_A5_3, "A5/3" },
+   { GSM0808_ALG_ID_A5_4, "A5/4" },
+   { GSM0808_ALG_ID_A5_5, "A5/5" },
+   { GSM0808_ALG_ID_A5_6, "A5/6" },
+   { GSM0808_ALG_ID_A5_7, "A5/7" },
+   { 0, NULL }
+};
+
 static const struct value_string gsm0808_cause_names[] = {
{ GSM0808_CAUSE_RADIO_INTERFACE_MESSAGE_FAILURE, "RADIO INTERFACE 
MESSAGE FAILURE" },
{ GSM0808_CAUSE_RADIO_INTERFACE_FAILURE, "RADIO INTERFACE FAILURE" },
diff --git a/src/gsm/libosmogsm.map b/src/gsm/libosmogsm.map
index 96779d2..e1486b7 100644
--- a/src/gsm/libosmogsm.map
+++ b/src/gsm/libosmogsm.map
@@ -201,6 +201,7 @@
 gsm0808_chan_type_to_speech_codec;
 gsm0808_speech_codec_from_chan_type;
 gsm0808_speech_codec_type_names;
+gsm0808_chosen_enc_alg_names;
 gsm0808_channel_type_name;
 gsm0808_lcls_config_names;
 gsm0808_lcls_control_names;

--
To view, visit https://gerrit.osmocom.org/9901
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iadf6460c438d02c53c2eaa9e42d51844ad28859a
Gerrit-Change-Number: 9901
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Build failed in Jenkins: master-asn1c » a1=default,a2=default,a3=default,osmocom-master-debian9 #176

[jenkins]

See 


--
[...truncated 3.67 KB...]

+ ./configure
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking target system type... x86_64-unknown-linux-gnu
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether to enable maintainer-specific portions of Makefiles... no
checking for style of include used by make... GNU
checking for gcc... gcc
checking for C compiler default output file name... a.out
checking whether the C compiler works... yes
checking whether we are cross compiling... no
checking for suffix of executables... 
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking dependency style of gcc... gcc3
checking for a sed that does not truncate output... /bin/sed
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for /usr/bin/ld option to reload object files... -r
checking for BSD-compatible nm... /usr/bin/nm -B
checking whether ln -s works... yes
checking how to recognise dependent libraries... pass_all
checking how to run the C preprocessor... gcc -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking dlfcn.h usability... yes
checking dlfcn.h presence... yes
checking for dlfcn.h... yes
checking for g++... g++
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking dependency style of g++... gcc3
checking how to run the C++ preprocessor... g++ -E
checking for g77... no
checking for f77... no
checking for xlf... no
checking for frt... no
checking for pgf77... no
checking for cf77... no
checking for fort77... no
checking for fl32... no
checking for af77... no
checking for f90... no
checking for xlf90... no
checking for pgf90... no
checking for pghpf... no
checking for epcf90... no
checking for gfortran... no
checking for g95... no
checking for f95... no
checking for fort... no
checking for xlf95... no
checking for ifort... no
checking for ifc... no
checking for efc... no
checking for pgf95... no
checking for lf95... no
checking for ftn... no
checking whether we are using the GNU Fortran 77 compiler... no
checking whether  accepts -g... no
checking the maximum length of command line arguments... 32768
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for objdir... .libs
checking for ar... ar
checking for ranlib... ranlib
checking for strip... strip
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC
checking if gcc PIC flag -fPIC works... yes
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... yes
configure: creating libtool
appending configuration tag "CXX" to libtool
checking for ld used by g++... /usr/bin/ld -m elf_x86_64
checking if the linker (/usr/bin/ld -m elf_x86_64) is GNU ld... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking for g++ option to produce PIC... -fPIC
checking if g++ PIC flag -fPIC works... yes
checking if g++ static flag -static works... yes
checking if g++ supports -c -o file.o... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
appending configuration tag "F77" to libtool
checking for autoconf... /usr/bin/autoconf
checking for autoheader... /usr/bin/autoheader
checking for gcc... (cached) gcc
checking whether we are using the GNU C compiler... (cached) yes
checking whether gcc accepts -g... (cached) yes
checking for gcc option to accept ISO C89... (cached) none needed
checking 

Change in osmo-ttcn3-hacks[master]: introduce a TTCN3 test suite for SCCP

[Stefan Sperling]

Hello Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/9653

to look at the new patch set (#3).

Change subject: introduce a TTCN3 test suite for SCCP
..

introduce a TTCN3 test suite for SCCP

This test suite acts as an SCCP server on top of M3UA.

SCCP tests are run against the sccp_demo_user program which
can be found in libosmo-sccp/examples. This program must be
started in client mode: sccp_demo_user -c
The SCCP test suite should then work out of the box with
the provided SCCP_Tests.cfg file and this additional change
to sccp_demo_user default point codes:
https://gerrit.osmocom.org/#/c/libosmo-sccp/+/9652/

There is currently only one test, for the libosmo-sccp crash
reported as issue OS#2666. The implementation of this test
is currently using an ugly workaround due to shortcomings of
the M3UA Emulation layer (see source code comments). Whether
a better solution is feasible is still to be determined.

The test requires a patch to the SCCP Protocol Emulation which
has been submitted upstream: https://git.eclipse.org/r/#/c/124552/

Change-Id: I03f5e8b282a7396b45417495c88d8fb81b26cda8
Related: OS#2666
---
M Makefile
M bsc/BSC_Tests.ttcn
M bsc/gen_links.sh
M library/BSSAP_Adapter.ttcn
A library/SCCP_Templates.ttcn
M msc/MSC_Tests.ttcn
M msc/gen_links.sh
A sccp/SCCP_Tests.cfg
A sccp/SCCP_Tests.default
A sccp/SCCP_Tests.ttcn
A sccp/gen_links.sh
A sccp/regen_makefile.sh
12 files changed, 361 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/53/9653/3
--
To view, visit https://gerrit.osmocom.org/9653
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I03f5e8b282a7396b45417495c88d8fb81b26cda8
Gerrit-Change-Number: 9653
Gerrit-PatchSet: 3
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Stefan Sperling 

Change in osmo-ttcn3-hacks[master]: introduce a TTCN3 test suite for SCCP

[Stefan Sperling]

Stefan Sperling has posted comments on this change. ( 
https://gerrit.osmocom.org/9653 )

Change subject: introduce a TTCN3 test suite for SCCP
..


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/9653/2/sccp/gen_links.sh
File sccp/gen_links.sh:

https://gerrit.osmocom.org/#/c/9653/2/sccp/gen_links.sh@56
PS2, Line 56: FILES+="MNCC_Types.ttcn MNCC_EncDec.cc MNCC_CodecPort.ttcn mncc.h 
MNCC_Emulation.ttcn "
> where is MNCC used in this testsuite? I commented on its removal in my 
> previous review. […]
Indeed, it is not needed. Thanks for pointing this out again, I got a bit lost 
in the amount of things to remove :)



--
To view, visit https://gerrit.osmocom.org/9653
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I03f5e8b282a7396b45417495c88d8fb81b26cda8
Gerrit-Change-Number: 9653
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Comment-Date: Fri, 06 Jul 2018 15:07:31 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: BSC_Tests: Also test LCLS with halfrate codecs

[dexter]

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/9900


Change subject: BSC_Tests: Also test LCLS with halfrate codecs
..

BSC_Tests: Also test LCLS with halfrate codecs

At the moment LCLS is only tested using GSM-FR. There are not LCLS
tests that test with GSM-HR yet. Lets make GSM-HR available and see
what happens when we run BSC_Tests_LCLS.TC_lcls_gcr_bway_connect
on HR instead of FR.

- set channelType depending on g_pars.ass_codec_list.codecElements[0]
- add testcase TC_lcls_gcr_bway_connect_hr

Related OS#1602
Change-Id: I2421519a642bdb7453ae4a9058e177845690a489
---
M bsc/BSC_Tests.ttcn
M bsc/BSC_Tests_LCLS.ttcn
M bsc/expected-results.xml
3 files changed, 24 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/00/9900/1

diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index 2a8ad5f..149d5b7 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -1735,7 +1735,7 @@
 }

 /* determine BSSMAP_IE_ChannelType from *first* element of 
BSSMAP_FIELD_CodecElement */
-private function f_BSSMAP_chtype_from_codec(BSSMAP_FIELD_CodecElement a_elem)
+function f_BSSMAP_chtype_from_codec(BSSMAP_FIELD_CodecElement a_elem)
 return BSSMAP_IE_ChannelType {
/* FIXME: actually look at all elements of BSSMAP_IE_SpeechCodecList */
var BSSMAP_IE_ChannelType ret := valueof(ts_BSSMAP_IE_ChannelType);
diff --git a/bsc/BSC_Tests_LCLS.ttcn b/bsc/BSC_Tests_LCLS.ttcn
index b99ba58..da9fe94 100644
--- a/bsc/BSC_Tests_LCLS.ttcn
+++ b/bsc/BSC_Tests_LCLS.ttcn
@@ -128,8 +128,12 @@
 private function f_lcls_connhdlr_main(charstring id) runs on LCLS_MSC_ConnHdlr 
{
/* 1) establish the connection between RSL and BSSAP side */
var PDU_BSSAP ass_req := f_gen_ass_req();
+
var template PDU_BSSAP ass_compl := f_gen_exp_compl();
ass_req.pdu.bssmap.assignmentRequest.codecList := g_pars.ass_codec_list;
+   ass_req.pdu.bssmap.assignmentRequest.channelType :=
+   
f_BSSMAP_chtype_from_codec(g_pars.ass_codec_list.codecElements[0]);
+
f_establish_fully(ass_req, ass_compl);

/* 2) notify master that assignment has completed */
@@ -251,8 +255,7 @@
f_lcls_test_fini();
 }

-/* Send an ASSIGNMENT REQ with LCLS GCR+CFG+CSC; expect connect both-way */
-testcase TC_lcls_gcr_bway_connect() runs on lcls_test_CT {
+private function f_tc_lcls_gcr_bway_connect(boolean hr) runs on lcls_test_CT {
var TestHdlrParams pars_a := valueof(t_def_TestHdlrPars);
var TestHdlrParams pars_b;
var MSC_ConnHdlr vc_conn;
@@ -260,7 +263,11 @@

f_lcls_init();

-   pars_a.ass_codec_list := valueof(ts_BSSMAP_IE_CodecList({ts_CodecFR}));
+   if (hr == true) {
+   pars_a.ass_codec_list := 
valueof(ts_BSSMAP_IE_CodecList({ts_CodecHR}));
+   } else {
+   pars_a.ass_codec_list := 
valueof(ts_BSSMAP_IE_CodecList({ts_CodecFR}));
+   }
pars_a.lcls.gcr := valueof(ts_GCR('010203'O, '0405'O, '060708090a'O));
pars_a.lcls.cfg := LCLS_CFG_both_way;
pars_a.lcls.csc := LCLS_CSC_connect;
@@ -272,6 +279,7 @@
pars_b.lcls.exp_sts := LCLS_STS_locally_switched;

f_lcls_test_init(pars_a, pars_b);
+
CONN_A.receive(LclsCompSync:LCLS_COMP_SYNC_ASS_COMPL);
interleave {
[] CONN_A.receive(tr_BSSMAP_LclsNotificationSts(LCLS_STS_not_yet_ls));
@@ -285,6 +293,16 @@
f_lcls_test_fini();
 }

+/* Send an ASSIGNMENT REQ with LCLS GCR+CFG+CSC; expect connect both-way (full 
rate)*/
+testcase TC_lcls_gcr_bway_connect() runs on lcls_test_CT {
+f_tc_lcls_gcr_bway_connect(false)
+}
+
+/* Send an ASSIGNMENT REQ with LCLS GCR+CFG+CSC; expect connect both-way (half 
rate) */
+testcase TC_lcls_gcr_bway_connect_hr() runs on lcls_test_CT {
+f_tc_lcls_gcr_bway_connect(true)
+}
+
 /* Send an ASSIGNMENT REQ with LCLS CFG+CSC enabling LCLS but GCR doesn't 
match! */
 testcase TC_lcls_gcr_nomatch_bway_connect() runs on lcls_test_CT {
var TestHdlrParams pars_a := valueof(t_def_TestHdlrPars);
@@ -581,6 +599,7 @@

execute( TC_lcls_gcr_only() );
execute( TC_lcls_gcr_bway_connect() );
+   execute( TC_lcls_gcr_bway_connect_hr() );
execute( TC_lcls_gcr_nomatch_bway_connect() );
execute( TC_lcls_gcr_bway_dont_connect() );
execute( TC_lcls_gcr_unsuppported_cfg() );
diff --git a/bsc/expected-results.xml b/bsc/expected-results.xml
index 969660e..dbe3d2c 100644
--- a/bsc/expected-results.xml
+++ b/bsc/expected-results.xml
@@ -87,6 +87,7 @@
   
   
   
+  
   
   
   

--
To view, visit https://gerrit.osmocom.org/9900
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2421519a642bdb7453ae4a9058e177845690a489
Gerrit-Change-Number: 9900

Change in osmo-gsm-manuals[master]: trx: Add Hardware device support section

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9895 )

Change subject: trx: Add Hardware device support section
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9895
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I87fc54cf1751f31a3e92d6503625e984f9a6130f
Gerrit-Change-Number: 9895
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-CC: Vadim Yanitskiy 
Gerrit-Comment-Date: Fri, 06 Jul 2018 14:48:43 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-gsm-manuals[master]: trx: Add Hardware architecture support section

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9894 )

Change subject: trx: Add Hardware architecture support section
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9894
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38388bcb2ea7c0481052d3bca589cb34965ea7fa
Gerrit-Change-Number: 9894
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: Vadim Yanitskiy 
Gerrit-Comment-Date: Fri, 06 Jul 2018 14:48:10 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: introduce a TTCN3 test suite for SCCP

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9653 )

Change subject: introduce a TTCN3 test suite for SCCP
..


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/9653/2/sccp/gen_links.sh
File sccp/gen_links.sh:

https://gerrit.osmocom.org/#/c/9653/2/sccp/gen_links.sh@56
PS2, Line 56: FILES+="MNCC_Types.ttcn MNCC_EncDec.cc MNCC_CodecPort.ttcn mncc.h 
MNCC_Emulation.ttcn "
where is MNCC used in this testsuite? I commented on its removal in my previous 
review.  Maybe thre is some dependency that I'm not aware of? If so, please 
explain. Thanks!



--
To view, visit https://gerrit.osmocom.org/9653
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I03f5e8b282a7396b45417495c88d8fb81b26cda8
Gerrit-Change-Number: 9653
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Comment-Date: Fri, 06 Jul 2018 14:47:15 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: ggsn: Apply GPDU seqnum option to all APNs

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9896 )

Change subject: ggsn: Apply GPDU seqnum option to all APNs
..

ggsn: Apply GPDU seqnum option to all APNs

Change-Id: I6efe926c8bb7a0056d26e15eefa282266e7bc6ca
---
M ggsn_tests/GGSN_Tests.ttcn
M ggsn_tests/expected-results.xml
2 files changed, 20 insertions(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/ggsn_tests/GGSN_Tests.ttcn b/ggsn_tests/GGSN_Tests.ttcn
index 97abc4d..6ae205f 100644
--- a/ggsn_tests/GGSN_Tests.ttcn
+++ b/ggsn_tests/GGSN_Tests.ttcn
@@ -105,12 +105,29 @@
private function f_vty_set_gpdu_txseq(boolean enable) runs on GT_CT {
f_vty_enter_config(GGSNVTY);
f_vty_transceive(GGSNVTY, "ggsn ggsn0");
+
f_vty_transceive(GGSNVTY, "apn internet");
if (enable) {
f_vty_transceive(GGSNVTY, "g-pdu tx-sequence-numbers");
} else {
f_vty_transceive(GGSNVTY, "no g-pdu 
tx-sequence-numbers");
}
+   f_vty_transceive(GGSNVTY, "exit");
+
+   f_vty_transceive(GGSNVTY, "apn inet6");
+   if (enable) {
+   f_vty_transceive(GGSNVTY, "g-pdu tx-sequence-numbers");
+   } else {
+   f_vty_transceive(GGSNVTY, "no g-pdu 
tx-sequence-numbers");
+   }
+   f_vty_transceive(GGSNVTY, "exit");
+
+   f_vty_transceive(GGSNVTY, "apn inet46");
+   if (enable) {
+   f_vty_transceive(GGSNVTY, "g-pdu tx-sequence-numbers");
+   } else {
+   f_vty_transceive(GGSNVTY, "no g-pdu 
tx-sequence-numbers");
+   }
f_vty_transceive(GGSNVTY, "end");
}

diff --git a/ggsn_tests/expected-results.xml b/ggsn_tests/expected-results.xml
index 383ea39..081325e 100644
--- a/ggsn_tests/expected-results.xml
+++ b/ggsn_tests/expected-results.xml
@@ -1,10 +1,11 @@
 
-
+
   
   
   
   
-  
+  
+  
   
   
 Secondary DNS IPv4 PCO option not found

--
To view, visit https://gerrit.osmocom.org/9896
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6efe926c8bb7a0056d26e15eefa282266e7bc6ca
Gerrit-Change-Number: 9896
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

Change in docker-playground[master]: ttcn3-*: Merge logfiles no matter resolution of tests

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9897 )

Change subject: ttcn3-*: Merge logfiles no matter resolution of tests
..


Patch Set 1: Verified+1


--
To view, visit https://gerrit.osmocom.org/9897
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If293fc2d3182ef2a7b997faa8b41129a9dd89c45
Gerrit-Change-Number: 9897
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Comment-Date: Fri, 06 Jul 2018 14:43:20 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in docker-playground[master]: ttcn3-*: Merge logfiles no matter resolution of tests

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9897 )

Change subject: ttcn3-*: Merge logfiles no matter resolution of tests
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9897
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If293fc2d3182ef2a7b997faa8b41129a9dd89c45
Gerrit-Change-Number: 9897
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Comment-Date: Fri, 06 Jul 2018 14:43:18 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: ggsn: Apply GPDU seqnum option to all APNs

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9896 )

Change subject: ggsn: Apply GPDU seqnum option to all APNs
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9896
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6efe926c8bb7a0056d26e15eefa282266e7bc6ca
Gerrit-Change-Number: 9896
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Fri, 06 Jul 2018 14:43:59 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in docker-playground[master]: ttcn3-nitb-sysinfo: Remove input logfiles after merging them

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9898 )

Change subject: ttcn3-nitb-sysinfo: Remove input logfiles after merging them
..

ttcn3-nitb-sysinfo: Remove input logfiles after merging them

All other ttcn3 projects do it.

Change-Id: Iee0e96d3832d88f2ee5958158b372243441750b3
---
M ttcn3-nitb-sysinfo/Dockerfile
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved; Verified



diff --git a/ttcn3-nitb-sysinfo/Dockerfile b/ttcn3-nitb-sysinfo/Dockerfile
index 39860f2..8cd9e58 100644
--- a/ttcn3-nitb-sysinfo/Dockerfile
+++ b/ttcn3-nitb-sysinfo/Dockerfile
@@ -22,5 +22,5 @@
 CMDcd /data && \
/osmo-ttcn3-hacks/start-testsuite.sh /osmo-ttcn3-hacks/sysinfo/Test; \
exit_code=$?; \
-   /osmo-ttcn3-hacks/log_merge.sh Test; \
+   /osmo-ttcn3-hacks/log_merge.sh Test --rm; \
exit $exit_code

--
To view, visit https://gerrit.osmocom.org/9898
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iee0e96d3832d88f2ee5958158b372243441750b3
Gerrit-Change-Number: 9898
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 

Change in docker-playground[master]: ttcn3-nitb-sysinfo: Remove input logfiles after merging them

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9898 )

Change subject: ttcn3-nitb-sysinfo: Remove input logfiles after merging them
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9898
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee0e96d3832d88f2ee5958158b372243441750b3
Gerrit-Change-Number: 9898
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Comment-Date: Fri, 06 Jul 2018 14:43:04 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in docker-playground[master]: ttcn3-nitb-sysinfo: Remove input logfiles after merging them

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9898 )

Change subject: ttcn3-nitb-sysinfo: Remove input logfiles after merging them
..


Patch Set 1: Verified+1


--
To view, visit https://gerrit.osmocom.org/9898
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee0e96d3832d88f2ee5958158b372243441750b3
Gerrit-Change-Number: 9898
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Comment-Date: Fri, 06 Jul 2018 14:43:24 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in docker-playground[master]: ttcn3-*: Merge logfiles no matter resolution of tests

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9897 )

Change subject: ttcn3-*: Merge logfiles no matter resolution of tests
..

ttcn3-*: Merge logfiles no matter resolution of tests

Previous to this commit, log messages were not being merged if tests
were resolved as failed (test-suite.sh ending with exit code != 0),
which can happen if at least one test failed.

Change-Id: If293fc2d3182ef2a7b997faa8b41129a9dd89c45
---
M ttcn3-bsc-test/Dockerfile
M ttcn3-bts-test/Dockerfile
M ttcn3-ggsn-test/Dockerfile
M ttcn3-hlr-test/Dockerfile
M ttcn3-mgw-test/Dockerfile
M ttcn3-msc-test/Dockerfile
M ttcn3-nitb-sysinfo/Dockerfile
M ttcn3-sgsn-test/Dockerfile
M ttcn3-sip-test/Dockerfile
9 files changed, 36 insertions(+), 18 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved; Verified



diff --git a/ttcn3-bsc-test/Dockerfile b/ttcn3-bsc-test/Dockerfile
index 4f0c606..9bdc898 100644
--- a/ttcn3-bsc-test/Dockerfile
+++ b/ttcn3-bsc-test/Dockerfile
@@ -26,5 +26,7 @@
 COPY   BSC_Tests.cfg /data/BSC_Tests.cfg

 CMDcd /data && \
-   /osmo-ttcn3-hacks/start-testsuite.sh /osmo-ttcn3-hacks/bsc/BSC_Tests && 
\
-   /osmo-ttcn3-hacks/log_merge.sh BSC_Tests --rm
+   /osmo-ttcn3-hacks/start-testsuite.sh /osmo-ttcn3-hacks/bsc/BSC_Tests; \
+   exit_code=$?; \
+   /osmo-ttcn3-hacks/log_merge.sh BSC_Tests --rm; \
+   exit $exit_code
diff --git a/ttcn3-bts-test/Dockerfile b/ttcn3-bts-test/Dockerfile
index 43ed4f0..3fec55b 100644
--- a/ttcn3-bts-test/Dockerfile
+++ b/ttcn3-bts-test/Dockerfile
@@ -26,5 +26,7 @@
 COPY   BTS_Tests.cfg /data/BTS_Tests.cfg

 CMDcd /data && \
-   /osmo-ttcn3-hacks/start-testsuite.sh /osmo-ttcn3-hacks/bts/BTS_Tests && 
\
-   /osmo-ttcn3-hacks/log_merge.sh BTS_Tests --rm
+   /osmo-ttcn3-hacks/start-testsuite.sh /osmo-ttcn3-hacks/bts/BTS_Tests; \
+   exit_code=$?; \
+   /osmo-ttcn3-hacks/log_merge.sh BTS_Tests --rm; \
+   exit $exit_code
diff --git a/ttcn3-ggsn-test/Dockerfile b/ttcn3-ggsn-test/Dockerfile
index 3c676cd..4e5e2da 100644
--- a/ttcn3-ggsn-test/Dockerfile
+++ b/ttcn3-ggsn-test/Dockerfile
@@ -22,5 +22,7 @@
 COPY   GGSN_Tests.cfg /data/GGSN_Tests.cfg

 CMDcd /data && \
-   /osmo-ttcn3-hacks/start-testsuite.sh 
/osmo-ttcn3-hacks/ggsn_tests/GGSN_Tests && \
-   /osmo-ttcn3-hacks/log_merge.sh GGSN_Tests --rm
+   /osmo-ttcn3-hacks/start-testsuite.sh 
/osmo-ttcn3-hacks/ggsn_tests/GGSN_Tests; \
+   exit_code=$?; \
+   /osmo-ttcn3-hacks/log_merge.sh GGSN_Tests --rm; \
+   exit $exit_code
diff --git a/ttcn3-hlr-test/Dockerfile b/ttcn3-hlr-test/Dockerfile
index 8a920a6..0dee3d3 100644
--- a/ttcn3-hlr-test/Dockerfile
+++ b/ttcn3-hlr-test/Dockerfile
@@ -26,5 +26,7 @@
 COPY   HLR_Tests.cfg /data/HLR_Tests.cfg

 CMDcd /data && \
-   /osmo-ttcn3-hacks/start-testsuite.sh /osmo-ttcn3-hacks/hlr/HLR_Tests && 
\
-   /osmo-ttcn3-hacks/log_merge.sh HLR_Tests --rm
+   /osmo-ttcn3-hacks/start-testsuite.sh /osmo-ttcn3-hacks/hlr/HLR_Tests; \
+   exit_code=$?; \
+   /osmo-ttcn3-hacks/log_merge.sh HLR_Tests --rm; \
+   exit $exit_code
diff --git a/ttcn3-mgw-test/Dockerfile b/ttcn3-mgw-test/Dockerfile
index 423e9df..6460c0a 100644
--- a/ttcn3-mgw-test/Dockerfile
+++ b/ttcn3-mgw-test/Dockerfile
@@ -23,5 +23,7 @@
 COPY   MGCP_Test.cfg /data/MGCP_Test.cfg

 CMDcd /data && \
-   /osmo-ttcn3-hacks/start-testsuite.sh /osmo-ttcn3-hacks/mgw/MGCP_Test && 
\
-   /osmo-ttcn3-hacks/log_merge.sh MGCP_Test --rm
+   /osmo-ttcn3-hacks/start-testsuite.sh /osmo-ttcn3-hacks/mgw/MGCP_Test; \
+   exit_code=$?; \
+   /osmo-ttcn3-hacks/log_merge.sh MGCP_Test --rm; \
+   exit $exit_code
diff --git a/ttcn3-msc-test/Dockerfile b/ttcn3-msc-test/Dockerfile
index 315638f..bbc60a2 100644
--- a/ttcn3-msc-test/Dockerfile
+++ b/ttcn3-msc-test/Dockerfile
@@ -26,5 +26,7 @@
 COPY   MSC_Tests.cfg /data/MSC_Tests.cfg

 CMDcd /data && \
-   /osmo-ttcn3-hacks/start-testsuite.sh /osmo-ttcn3-hacks/msc/MSC_Tests && 
\
-   /osmo-ttcn3-hacks/log_merge.sh MSC_Tests --rm
+   /osmo-ttcn3-hacks/start-testsuite.sh /osmo-ttcn3-hacks/msc/MSC_Tests; \
+   exit_code=$?; \
+   /osmo-ttcn3-hacks/log_merge.sh MSC_Tests --rm; \
+   exit $exit_code
diff --git a/ttcn3-nitb-sysinfo/Dockerfile b/ttcn3-nitb-sysinfo/Dockerfile
index fb5ceb2..39860f2 100644
--- a/ttcn3-nitb-sysinfo/Dockerfile
+++ b/ttcn3-nitb-sysinfo/Dockerfile
@@ -20,5 +20,7 @@
 COPY   Test.cfg /data/Test.cfg

 CMDcd /data && \
-   /osmo-ttcn3-hacks/start-testsuite.sh /osmo-ttcn3-hacks/sysinfo/Test && \
-   /osmo-ttcn3-hacks/log_merge.sh Test
+   /osmo-ttcn3-hacks/start-testsuite.sh /osmo-ttcn3-hacks/sysinfo/Test; \
+   exit_code=$?; \
+   /osmo-ttcn3-hacks/log_merge.sh Test; \
+   exit $exit_code
diff --git a/ttcn3-sgsn-test/Dockerfile b/ttcn3-sgsn-test/Dockerfile
index dfca1c4..d06195d 100644
--- 

Change in osmo-ttcn3-hacks[master]: BTS_Tests: altstep as_meas_res: Check for meas timer timeout only if ...

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9899 )

Change subject: BTS_Tests: altstep as_meas_res: Check for meas timer timeout 
only if previously set
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9899
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia28c40e8cb338ecc23f72474832307bba2b09503
Gerrit-Change-Number: 9899
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Fri, 06 Jul 2018 14:42:45 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: BTS_Tests: altstep as_meas_res: Check for meas timer timeout only if ...

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9899 )

Change subject: BTS_Tests: altstep as_meas_res: Check for meas timer timeout 
only if previously set
..

BTS_Tests: altstep as_meas_res: Check for meas timer timeout only if previously 
set

Should fix following spotted message in TTCN3 logs:
BTS_Tests.ttcn:1297 Timeout operation on timer g_Tmeas_exp failed: The timer is 
not started.

Change-Id: Ia28c40e8cb338ecc23f72474832307bba2b09503
---
M bts/BTS_Tests.ttcn
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index f66a43f..aee081e 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -1294,7 +1294,7 @@
setverdict(fail, "Received unexpected MEAS RES ", rsl);
self.stop;
}
-   [] g_Tmeas_exp.timeout {
+   [g_Tmeas_exp.running] g_Tmeas_exp.timeout {
setverdict(fail, "Didn't receive expected measurement result")
self.stop;
}

--
To view, visit https://gerrit.osmocom.org/9899
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia28c40e8cb338ecc23f72474832307bba2b09503
Gerrit-Change-Number: 9899
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

Change in osmo-ttcn3-hacks[master]: BTS_Tests: altstep as_meas_res: Check for meas timer timeout only if ...

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/9899


Change subject: BTS_Tests: altstep as_meas_res: Check for meas timer timeout 
only if previously set
..

BTS_Tests: altstep as_meas_res: Check for meas timer timeout only if previously 
set

Should fix following spotted message in TTCN3 logs:
BTS_Tests.ttcn:1297 Timeout operation on timer g_Tmeas_exp failed: The timer is 
not started.

Change-Id: Ia28c40e8cb338ecc23f72474832307bba2b09503
---
M bts/BTS_Tests.ttcn
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/99/9899/1

diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index f66a43f..aee081e 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -1294,7 +1294,7 @@
setverdict(fail, "Received unexpected MEAS RES ", rsl);
self.stop;
}
-   [] g_Tmeas_exp.timeout {
+   [g_Tmeas_exp.running] g_Tmeas_exp.timeout {
setverdict(fail, "Didn't receive expected measurement result")
self.stop;
}

--
To view, visit https://gerrit.osmocom.org/9899
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia28c40e8cb338ecc23f72474832307bba2b09503
Gerrit-Change-Number: 9899
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in docker-playground[master]: ttcn3-nitb-sysinfo: Remove input logfiles after merging them

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/9898


Change subject: ttcn3-nitb-sysinfo: Remove input logfiles after merging them
..

ttcn3-nitb-sysinfo: Remove input logfiles after merging them

All other ttcn3 projects do it.

Change-Id: Iee0e96d3832d88f2ee5958158b372243441750b3
---
M ttcn3-nitb-sysinfo/Dockerfile
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/docker-playground 
refs/changes/98/9898/1

diff --git a/ttcn3-nitb-sysinfo/Dockerfile b/ttcn3-nitb-sysinfo/Dockerfile
index 39860f2..8cd9e58 100644
--- a/ttcn3-nitb-sysinfo/Dockerfile
+++ b/ttcn3-nitb-sysinfo/Dockerfile
@@ -22,5 +22,5 @@
 CMDcd /data && \
/osmo-ttcn3-hacks/start-testsuite.sh /osmo-ttcn3-hacks/sysinfo/Test; \
exit_code=$?; \
-   /osmo-ttcn3-hacks/log_merge.sh Test; \
+   /osmo-ttcn3-hacks/log_merge.sh Test --rm; \
exit $exit_code

--
To view, visit https://gerrit.osmocom.org/9898
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iee0e96d3832d88f2ee5958158b372243441750b3
Gerrit-Change-Number: 9898
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in docker-playground[master]: ttcn3-*: Merge logfiles no matter resolution of tests

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/9897


Change subject: ttcn3-*: Merge logfiles no matter resolution of tests
..

ttcn3-*: Merge logfiles no matter resolution of tests

Previous to this commit, log messages were not being merged if tests
were resolved as failed (test-suite.sh ending with exit code != 0),
which can happen if at least one test failed.

Change-Id: If293fc2d3182ef2a7b997faa8b41129a9dd89c45
---
M ttcn3-bsc-test/Dockerfile
M ttcn3-bts-test/Dockerfile
M ttcn3-ggsn-test/Dockerfile
M ttcn3-hlr-test/Dockerfile
M ttcn3-mgw-test/Dockerfile
M ttcn3-msc-test/Dockerfile
M ttcn3-nitb-sysinfo/Dockerfile
M ttcn3-sgsn-test/Dockerfile
M ttcn3-sip-test/Dockerfile
9 files changed, 36 insertions(+), 18 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/docker-playground 
refs/changes/97/9897/1

diff --git a/ttcn3-bsc-test/Dockerfile b/ttcn3-bsc-test/Dockerfile
index 4f0c606..9bdc898 100644
--- a/ttcn3-bsc-test/Dockerfile
+++ b/ttcn3-bsc-test/Dockerfile
@@ -26,5 +26,7 @@
 COPY   BSC_Tests.cfg /data/BSC_Tests.cfg

 CMDcd /data && \
-   /osmo-ttcn3-hacks/start-testsuite.sh /osmo-ttcn3-hacks/bsc/BSC_Tests && 
\
-   /osmo-ttcn3-hacks/log_merge.sh BSC_Tests --rm
+   /osmo-ttcn3-hacks/start-testsuite.sh /osmo-ttcn3-hacks/bsc/BSC_Tests; \
+   exit_code=$?; \
+   /osmo-ttcn3-hacks/log_merge.sh BSC_Tests --rm; \
+   exit $exit_code
diff --git a/ttcn3-bts-test/Dockerfile b/ttcn3-bts-test/Dockerfile
index 43ed4f0..3fec55b 100644
--- a/ttcn3-bts-test/Dockerfile
+++ b/ttcn3-bts-test/Dockerfile
@@ -26,5 +26,7 @@
 COPY   BTS_Tests.cfg /data/BTS_Tests.cfg

 CMDcd /data && \
-   /osmo-ttcn3-hacks/start-testsuite.sh /osmo-ttcn3-hacks/bts/BTS_Tests && 
\
-   /osmo-ttcn3-hacks/log_merge.sh BTS_Tests --rm
+   /osmo-ttcn3-hacks/start-testsuite.sh /osmo-ttcn3-hacks/bts/BTS_Tests; \
+   exit_code=$?; \
+   /osmo-ttcn3-hacks/log_merge.sh BTS_Tests --rm; \
+   exit $exit_code
diff --git a/ttcn3-ggsn-test/Dockerfile b/ttcn3-ggsn-test/Dockerfile
index 3c676cd..4e5e2da 100644
--- a/ttcn3-ggsn-test/Dockerfile
+++ b/ttcn3-ggsn-test/Dockerfile
@@ -22,5 +22,7 @@
 COPY   GGSN_Tests.cfg /data/GGSN_Tests.cfg

 CMDcd /data && \
-   /osmo-ttcn3-hacks/start-testsuite.sh 
/osmo-ttcn3-hacks/ggsn_tests/GGSN_Tests && \
-   /osmo-ttcn3-hacks/log_merge.sh GGSN_Tests --rm
+   /osmo-ttcn3-hacks/start-testsuite.sh 
/osmo-ttcn3-hacks/ggsn_tests/GGSN_Tests; \
+   exit_code=$?; \
+   /osmo-ttcn3-hacks/log_merge.sh GGSN_Tests --rm; \
+   exit $exit_code
diff --git a/ttcn3-hlr-test/Dockerfile b/ttcn3-hlr-test/Dockerfile
index 8a920a6..0dee3d3 100644
--- a/ttcn3-hlr-test/Dockerfile
+++ b/ttcn3-hlr-test/Dockerfile
@@ -26,5 +26,7 @@
 COPY   HLR_Tests.cfg /data/HLR_Tests.cfg

 CMDcd /data && \
-   /osmo-ttcn3-hacks/start-testsuite.sh /osmo-ttcn3-hacks/hlr/HLR_Tests && 
\
-   /osmo-ttcn3-hacks/log_merge.sh HLR_Tests --rm
+   /osmo-ttcn3-hacks/start-testsuite.sh /osmo-ttcn3-hacks/hlr/HLR_Tests; \
+   exit_code=$?; \
+   /osmo-ttcn3-hacks/log_merge.sh HLR_Tests --rm; \
+   exit $exit_code
diff --git a/ttcn3-mgw-test/Dockerfile b/ttcn3-mgw-test/Dockerfile
index 423e9df..6460c0a 100644
--- a/ttcn3-mgw-test/Dockerfile
+++ b/ttcn3-mgw-test/Dockerfile
@@ -23,5 +23,7 @@
 COPY   MGCP_Test.cfg /data/MGCP_Test.cfg

 CMDcd /data && \
-   /osmo-ttcn3-hacks/start-testsuite.sh /osmo-ttcn3-hacks/mgw/MGCP_Test && 
\
-   /osmo-ttcn3-hacks/log_merge.sh MGCP_Test --rm
+   /osmo-ttcn3-hacks/start-testsuite.sh /osmo-ttcn3-hacks/mgw/MGCP_Test; \
+   exit_code=$?; \
+   /osmo-ttcn3-hacks/log_merge.sh MGCP_Test --rm; \
+   exit $exit_code
diff --git a/ttcn3-msc-test/Dockerfile b/ttcn3-msc-test/Dockerfile
index 315638f..bbc60a2 100644
--- a/ttcn3-msc-test/Dockerfile
+++ b/ttcn3-msc-test/Dockerfile
@@ -26,5 +26,7 @@
 COPY   MSC_Tests.cfg /data/MSC_Tests.cfg

 CMDcd /data && \
-   /osmo-ttcn3-hacks/start-testsuite.sh /osmo-ttcn3-hacks/msc/MSC_Tests && 
\
-   /osmo-ttcn3-hacks/log_merge.sh MSC_Tests --rm
+   /osmo-ttcn3-hacks/start-testsuite.sh /osmo-ttcn3-hacks/msc/MSC_Tests; \
+   exit_code=$?; \
+   /osmo-ttcn3-hacks/log_merge.sh MSC_Tests --rm; \
+   exit $exit_code
diff --git a/ttcn3-nitb-sysinfo/Dockerfile b/ttcn3-nitb-sysinfo/Dockerfile
index fb5ceb2..39860f2 100644
--- a/ttcn3-nitb-sysinfo/Dockerfile
+++ b/ttcn3-nitb-sysinfo/Dockerfile
@@ -20,5 +20,7 @@
 COPY   Test.cfg /data/Test.cfg

 CMDcd /data && \
-   /osmo-ttcn3-hacks/start-testsuite.sh /osmo-ttcn3-hacks/sysinfo/Test && \
-   /osmo-ttcn3-hacks/log_merge.sh Test
+   /osmo-ttcn3-hacks/start-testsuite.sh /osmo-ttcn3-hacks/sysinfo/Test; \
+   exit_code=$?; \
+   /osmo-ttcn3-hacks/log_merge.sh Test; \
+   exit $exit_code
diff --git a/ttcn3-sgsn-test/Dockerfile b/ttcn3-sgsn-test/Dockerfile
index dfca1c4..d06195d 100644
--- 

Build failed in Jenkins: master-gapk » a1=default,a2=default,a3=default,osmocom-master-debian9 #12

[jenkins]

See 


--
[...truncated 127.05 KB...]
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... no
checking whether make supports nested variables... (cached) yes
checking if gcc supports -fvisibility=hidden... yes
checking for gcc... (cached) gcc
checking whether we are using the GNU C compiler... (cached) yes
checking whether gcc accepts -g... (cached) yes
checking for gcc option to accept ISO C89... (cached) none needed
checking whether gcc understands -c and -o together... (cached) yes
checking dependency style of gcc... (cached) gcc3
checking for pkg-config... /usr/bin/pkg-config
checking pkg-config is at least version 0.9.0... yes
checking for LIBOSMOCORE... yes
checking for LIBOSMOCODEC... yes
checking for LIBALSA... yes
checking for OPENCORE_AMRNB... yes
checking gsm/gsm.h usability... yes
checking gsm/gsm.h presence... yes
checking for gsm/gsm.h... yes
checking for gsm_create in -lgsm... yes
checking for stdint.h... (cached) yes
checking for stdlib.h... (cached) yes
checking for string.h... (cached) yes
checking for unistd.h... (cached) yes
checking for inline... inline
checking for int16_t... yes
checking for int32_t... yes
checking for uint16_t... yes
checking for uint32_t... yes
checking for uint64_t... yes
checking for uint8_t... yes
checking for stdlib.h... (cached) yes
checking for GNU libc compatible malloc... yes
checking for memset... yes
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating Makefile
config.status: creating src/Makefile
config.status: creating libgsmhr/Makefile
config.status: creating include/Makefile
config.status: creating include/gsmhr/Makefile
config.status: creating libosmogapk.pc
config.status: creating tests/atlocal
config.status: creating tests/Makefile
config.status: creating config.h
config.status: executing depfiles commands
config.status: executing libtool commands
config.status: executing tests/atconfig commands
make[1]: Entering directory 
'
make  all-recursive
make[2]: Entering directory 
'
Making all in include
make[3]: Entering directory 
'
make[4]: Entering directory 
'
make[4]: Nothing to be done for 'all-am'.
make[4]: Leaving directory 
'
make[3]: Leaving directory 
'
Making all in src
make[3]: Entering directory 
'
  CC   procqueue.lo
  CC   pq_format.lo
  CC   pq_codec.lo
  CC   pq_file.lo
  CC   pq_alsa.lo
  CC   pq_rtp.lo
  CC   pq_ecu.lo
  CC   ecu_fr.lo
  CC   formats.lo
  CC   fmt_ti.lo
  CC   fmt_amr.lo
  CC   fmt_gsm.lo
  CC   fmt_hr_ref.lo
  CC   fmt_racal.lo
  CC   fmt_rawpcm.lo
  CC   fmt_rtp_amr.lo
  CC   fmt_rtp_efr.lo
  CC   fmt_rtp_hr_etsi.lo
  CC   fmt_rtp_hr_ietf.lo
  CC   fmt_amr_opencore.lo
  CC   codecs.lo
  CC   codec_pcm.lo
  CC   codec_hr.lo
  CC   codec_fr.lo
  CC   codec_efr.lo
  CC   codec_amr.lo
  CC   benchmark.lo
  CC   common.lo
  CCLD libosmogapk.la
  CC   app_osmo_gapk.o
  CCLD osmo-gapk
make[3]: Leaving directory 
'
Making all in tests
make[3]: Entering directory 
'
make[3]: Nothing to be 

Change in osmo-ttcn3-hacks[master]: ggsn: Apply GPDU seqnum option to all APNs

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/9896


Change subject: ggsn: Apply GPDU seqnum option to all APNs
..

ggsn: Apply GPDU seqnum option to all APNs

Change-Id: I6efe926c8bb7a0056d26e15eefa282266e7bc6ca
---
M ggsn_tests/GGSN_Tests.ttcn
M ggsn_tests/expected-results.xml
2 files changed, 20 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/96/9896/1

diff --git a/ggsn_tests/GGSN_Tests.ttcn b/ggsn_tests/GGSN_Tests.ttcn
index 97abc4d..6ae205f 100644
--- a/ggsn_tests/GGSN_Tests.ttcn
+++ b/ggsn_tests/GGSN_Tests.ttcn
@@ -105,12 +105,29 @@
private function f_vty_set_gpdu_txseq(boolean enable) runs on GT_CT {
f_vty_enter_config(GGSNVTY);
f_vty_transceive(GGSNVTY, "ggsn ggsn0");
+
f_vty_transceive(GGSNVTY, "apn internet");
if (enable) {
f_vty_transceive(GGSNVTY, "g-pdu tx-sequence-numbers");
} else {
f_vty_transceive(GGSNVTY, "no g-pdu 
tx-sequence-numbers");
}
+   f_vty_transceive(GGSNVTY, "exit");
+
+   f_vty_transceive(GGSNVTY, "apn inet6");
+   if (enable) {
+   f_vty_transceive(GGSNVTY, "g-pdu tx-sequence-numbers");
+   } else {
+   f_vty_transceive(GGSNVTY, "no g-pdu 
tx-sequence-numbers");
+   }
+   f_vty_transceive(GGSNVTY, "exit");
+
+   f_vty_transceive(GGSNVTY, "apn inet46");
+   if (enable) {
+   f_vty_transceive(GGSNVTY, "g-pdu tx-sequence-numbers");
+   } else {
+   f_vty_transceive(GGSNVTY, "no g-pdu 
tx-sequence-numbers");
+   }
f_vty_transceive(GGSNVTY, "end");
}

diff --git a/ggsn_tests/expected-results.xml b/ggsn_tests/expected-results.xml
index 383ea39..081325e 100644
--- a/ggsn_tests/expected-results.xml
+++ b/ggsn_tests/expected-results.xml
@@ -1,10 +1,11 @@
 
-
+
   
   
   
   
-  
+  
+  
   
   
 Secondary DNS IPv4 PCO option not found

--
To view, visit https://gerrit.osmocom.org/9896
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6efe926c8bb7a0056d26e15eefa282266e7bc6ca
Gerrit-Change-Number: 9896
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in osmo-ttcn3-hacks[master]: introduce a TTCN3 test suite for SCCP

[Stefan Sperling]

Stefan Sperling has posted comments on this change. ( 
https://gerrit.osmocom.org/9653 )

Change subject: introduce a TTCN3 test suite for SCCP
..


Patch Set 2:

Dependencies have been reduced in new patch set.
The test no longer depends on BSSAP_Adapter.


--
To view, visit https://gerrit.osmocom.org/9653
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I03f5e8b282a7396b45417495c88d8fb81b26cda8
Gerrit-Change-Number: 9653
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Comment-Date: Fri, 06 Jul 2018 10:44:37 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: introduce a TTCN3 test suite for SCCP

[Stefan Sperling]

Hello Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/9653

to look at the new patch set (#2).

Change subject: introduce a TTCN3 test suite for SCCP
..

introduce a TTCN3 test suite for SCCP

This test suite acts as an SCCP server on top of M3UA.

SCCP tests are run against the sccp_demo_user program which
can be found in libosmo-sccp/examples. This program must be
started in client mode: sccp_demo_user -c
The SCCP test suite should then work out of the box with
the provided SCCP_Tests.cfg file and this additional change
to sccp_demo_user default point codes:
https://gerrit.osmocom.org/#/c/libosmo-sccp/+/9652/

There is currently only one test, for the libosmo-sccp crash
reported as issue OS#2666. The implementation of this test
is currently using an ugly workaround due to shortcomings of
the M3UA Emulation layer (see source code comments). Whether
a better solution is feasible is still to be determined.

The test requires a patch to the SCCP Protocol Emulation which
has been submitted upstream: https://git.eclipse.org/r/#/c/124552/

Change-Id: I03f5e8b282a7396b45417495c88d8fb81b26cda8
Related: OS#2666
---
M Makefile
M bsc/BSC_Tests.ttcn
M bsc/gen_links.sh
M library/BSSAP_Adapter.ttcn
A library/SCCP_Templates.ttcn
M msc/MSC_Tests.ttcn
M msc/gen_links.sh
A sccp/SCCP_Tests.cfg
A sccp/SCCP_Tests.default
A sccp/SCCP_Tests.ttcn
A sccp/gen_links.sh
A sccp/regen_makefile.sh
12 files changed, 362 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/53/9653/2
--
To view, visit https://gerrit.osmocom.org/9653
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I03f5e8b282a7396b45417495c88d8fb81b26cda8
Gerrit-Change-Number: 9653
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

Change in osmo-gsm-manuals[master]: trx: Add Hardware device support section

[Pau Espin Pedrol]

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/9895

to look at the new patch set (#2).

Change subject: trx: Add Hardware device support section
..

trx: Add Hardware device support section

Change-Id: I87fc54cf1751f31a3e92d6503625e984f9a6130f
---
A OsmoTRX/chapters/trx-backends.adoc
M OsmoTRX/osmotrx-usermanual.adoc
2 files changed, 69 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals 
refs/changes/95/9895/2
--
To view, visit https://gerrit.osmocom.org/9895
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I87fc54cf1751f31a3e92d6503625e984f9a6130f
Gerrit-Change-Number: 9895
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-CC: Vadim Yanitskiy 

Change in osmo-gsm-manuals[master]: trx: Add Hardware architecture support section

[Pau Espin Pedrol]

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/9894

to look at the new patch set (#2).

Change subject: trx: Add Hardware architecture support section
..

trx: Add Hardware architecture support section

Change-Id: I38388bcb2ea7c0481052d3bca589cb34965ea7fa
---
A OsmoTRX/chapters/trx-architectures.adoc
M OsmoTRX/osmotrx-usermanual.adoc
2 files changed, 36 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals 
refs/changes/94/9894/2
--
To view, visit https://gerrit.osmocom.org/9894
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I38388bcb2ea7c0481052d3bca589cb34965ea7fa
Gerrit-Change-Number: 9894
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: Vadim Yanitskiy 

Change in osmo-gsm-manuals[master]: trx: Add Hardware device support section

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/9895 )

Change subject: trx: Add Hardware device support section
..


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/#/c/9895/1/OsmoTRX/chapters/trx-backends.adoc
File OsmoTRX/chapters/trx-backends.adoc:

https://gerrit.osmocom.org/#/c/9895/1/OsmoTRX/chapters/trx-backends.adoc@11
PS1, Line 11: socket
> There are at least three sockets, so s/socket/sockets/.
Well in here I basically have a comma separated list of interfaces, so it 
basically should be read as "RX Manager UDP socket interface".


https://gerrit.osmocom.org/#/c/9895/1/OsmoTRX/chapters/trx-backends.adoc@30
PS1, Line 30: to
> reading/writing .. […]
The other way actually :P



--
To view, visit https://gerrit.osmocom.org/9895
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I87fc54cf1751f31a3e92d6503625e984f9a6130f
Gerrit-Change-Number: 9895
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-CC: Vadim Yanitskiy 
Gerrit-Comment-Date: Fri, 06 Jul 2018 10:00:40 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-gsm-manuals[master]: trx: Add reference to project wiki page in overfiew section

[Pau Espin Pedrol]

Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9893 )

Change subject: trx: Add reference to project wiki page in overfiew section
..

trx: Add reference to project wiki page in overfiew section

Change-Id: I83cbd67909c42f4ed4857834e23c07ad4e2e22aa
---
M OsmoTRX/chapters/overview.adoc
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/OsmoTRX/chapters/overview.adoc b/OsmoTRX/chapters/overview.adoc
index b7d9697..785e26b 100644
--- a/OsmoTRX/chapters/overview.adoc
+++ b/OsmoTRX/chapters/overview.adoc
@@ -57,3 +57,6 @@
 OsmoTRX [color=red];
 }
 
+
+For more information see
+https://osmocom.org/projects/osmotrx/wiki/OsmoTRX

--
To view, visit https://gerrit.osmocom.org/9893
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I83cbd67909c42f4ed4857834e23c07ad4e2e22aa
Gerrit-Change-Number: 9893
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmo-gsm-manuals[master]: bts: Fix typo

[Pau Espin Pedrol]

Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9892 )

Change subject: bts: Fix typo
..

bts: Fix typo

Change-Id: I47758acec07a587730552a9c46dc02976c807d9a
---
M OsmoBTS/chapters/bts-models.adoc
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/OsmoBTS/chapters/bts-models.adoc b/OsmoBTS/chapters/bts-models.adoc
index fe06c04..4ae73c0 100644
--- a/OsmoBTS/chapters/bts-models.adoc
+++ b/OsmoBTS/chapters/bts-models.adoc
@@ -6,7 +6,7 @@
 generally referred to as the _bts_model_ code.

 The common part includes the core BTS architecture as well as code for
-implementing the external interfaces such Abis, control, PCU socket and
+implementing the external interfaces such as Abis, control, PCU socket and
 GSMTAP.

 The bts_model parts include support for driving one particular

--
To view, visit https://gerrit.osmocom.org/9892
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I47758acec07a587730552a9c46dc02976c807d9a
Gerrit-Change-Number: 9892
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol