Change in osmo-bts[master]: Add OC-2G systemd service and config

2018-10-23 Thread Omar Ramadan 
Omar Ramadan has uploaded this change for review. ( 
https://gerrit.osmocom.org/11448


Change subject: Add OC-2G systemd service and config
..

Add OC-2G systemd service and config

Change-Id: Ic4b5a97b9677051442f3c3341ba23add35b43715
---
A contrib/systemd/oc2gbts-mgr.service
A contrib/systemd/osmo-bts-oc2g.service
A doc/examples/oc2g/oc2gbts-mgr.cfg
A doc/examples/oc2g/osmo-bts.cfg
4 files changed, 121 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/48/11448/1

diff --git a/contrib/systemd/oc2gbts-mgr.service 
b/contrib/systemd/oc2gbts-mgr.service
new file mode 100644
index 000..ed915b3
--- /dev/null
+++ b/contrib/systemd/oc2gbts-mgr.service
@@ -0,0 +1,29 @@
+[Unit]
+Description=osmo-bts manager for OC-2G
+After=oc2g-sysdev-remap.service
+Wants=oc2g-sysdev-remap.service
+
+[Service]
+Type=simple
+NotifyAccess=all
+WatchdogSec=21780s
+Restart=always
+RestartSec=2
+
+# Make sure directories and symbolic link exist
+ExecStartPre=/bin/sh -c 'test -d /mnt/storage/var/run/oc2gbts-mgr || mkdir -p 
/mnt/storage/var/run/oc2gbts-mgr ; test -d /var/run/oc2gbts-mgr || ln -sf 
/mnt/storage/var/run/oc2gbts-mgr/ /var/run'
+# Make sure BTS operation hour exist
+ExecStartPre=/bin/sh -c 'test -f 
/mnt/storage/var/run/oc2gbts-mgr/hours-running || echo 0 > 
/mnt/storage/var/run/oc2gbts-mgr/hours-running'
+# Shutdown all PA correctly
+ExecStartPre=/bin/sh -c 'echo disabled > /var/oc2g/pa-state/pa0/state;'
+#ExecStartPre=/bin/sh -c 'echo 0 > /var/oc2g/pa-supply/max_microvolts; echo 0 
> /var/oc2g/pa-supply/min_microvolts'
+
+ExecStart=/usr/bin/oc2gbts-mgr -s -c /etc/osmocom/oc2gbts-mgr.cfg
+
+# Shutdown all PA correctly
+ExecStopPost=/bin/sh -c 'echo disabled > /var/oc2g/pa-state/pa0/state;'
+#ExecStopPost=/bin/sh -c 'echo 0 > /var/oc2g/pa-supply/max_microvolts; echo 0 
> /var/oc2g/pa-supply/min_microvolts'
+
+[Install]
+WantedBy=multi-user.target
+Alias=osmo-bts-mgr.service
diff --git a/contrib/systemd/osmo-bts-oc2g.service 
b/contrib/systemd/osmo-bts-oc2g.service
new file mode 100644
index 000..2f2d837
--- /dev/null
+++ b/contrib/systemd/osmo-bts-oc2g.service
@@ -0,0 +1,21 @@
+[Unit]
+Description=osmo-bts for OC-2G
+
+[Service]
+Type=simple
+ExecStartPre=/bin/sh -c 'echo 1 > /sys/class/leds/usr0/brightness'
+ExecStartPre=/bin/sh -c 'echo 1 > /sys/class/leds/usr1/brightness'
+ExecStart=/usr/bin/osmo-bts-oc2g -s -c /etc/osmocom/osmo-bts.cfg -M
+ExecStopPost=/bin/sh -c 'echo 1 > /sys/class/leds/usr0/brightness'
+ExecStopPost=/bin/sh -c 'echo 0 > /sys/class/leds/usr1/brightness'
+Restart=always
+RestartSec=2
+RestartPreventExitStatus=1
+
+# The msg queues must be read fast enough
+CPUSchedulingPolicy=rr
+CPUSchedulingPriority=1
+
+[Install]
+WantedBy=multi-user.target
+Alias=osmo-bts.service
diff --git a/doc/examples/oc2g/oc2gbts-mgr.cfg 
b/doc/examples/oc2g/oc2gbts-mgr.cfg
new file mode 100644
index 000..8248f60
--- /dev/null
+++ b/doc/examples/oc2g/oc2gbts-mgr.cfg
@@ -0,0 +1,33 @@
+!
+! oc2gbts-mgr (0.3.0.284-a7c2-dirty) configuration saved from vty
+!!
+!
+log stderr
+  logging filter all 1
+  logging color 1
+  logging print category 0
+  logging timestamp 0
+  logging level temp info
+  logging level fw info
+  logging level find info
+  logging level calib info
+  logging level lglobal notice
+  logging level llapd notice
+  logging level linp notice
+  logging level lmux notice
+  logging level lmi notice
+  logging level lmib notice
+  logging level lsms notice
+  logging level lctrl notice
+  logging level lgtp notice
+!
+line vty
+ no login
+!
+oc2gbts-mgr
+ limits supply_volt
+   threshold warning min 17500
+   threshold critical min 19000
+ limits supply_pwr
+   threshold warning max 110
+   threshold critical max 120
diff --git a/doc/examples/oc2g/osmo-bts.cfg b/doc/examples/oc2g/osmo-bts.cfg
new file mode 100644
index 000..f985f3b
--- /dev/null
+++ b/doc/examples/oc2g/osmo-bts.cfg
@@ -0,0 +1,38 @@
+!
+! OsmoBTS (0.0.1.100-0455-dirty) configuration saved from vty
+!!
+!
+log stderr
+  logging color 1
+  logging timestamp 0
+  logging level rsl info
+  logging level oml info
+  logging level rll notice
+  logging level rr notice
+  logging level meas notice
+  logging level pag info
+  logging level l1c info
+  logging level l1p info
+  logging level dsp debug
+  logging level abis notice
+  logging level rtp notice
+  logging level lglobal notice
+  logging level llapd notice
+  logging level linp notice
+  logging level lmux notice
+  logging level lmi notice
+  logging level lmib notice
+  logging level lsms notice
+!
+line vty
+ no login
+!
+phy 0
+ instance 0
+  trx-calibration-path /mnt/rom/factory/calib
+bts 0
+ band 900
+ ipa unit-id 1500 0
+ oml remote-ip 10.42.0.1
+ trx 0
+  phy 0 instance 0

--
To view, visit https://gerrit.osmocom.org/11448
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch:

Change in osmo-bts[master]: Add OC-2G to build

2018-10-23 Thread Omar Ramadan 
Omar Ramadan has uploaded this change for review. ( 
https://gerrit.osmocom.org/11449


Change subject: Add OC-2G to build
..

Add OC-2G to build

Change-Id: I4a8dcf759a2818c8e457bcb82775c4e60c94d771
---
M configure.ac
M include/osmo-bts/gsm_data_shared.h
M include/osmo-bts/l1sap.h
M include/osmo-bts/phy_link.h
M src/Makefile.am
M src/common/gsm_data_shared.c
6 files changed, 55 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/49/11449/1

diff --git a/configure.ac b/configure.ac
index f2d4f84..9a8d58f 100644
--- a/configure.ac
+++ b/configure.ac
@@ -279,6 +279,27 @@
CPPFLAGS=$oldCPPFLAGS
 fi

+AC_MSG_CHECKING([whether to enable NuRAN Wireless OC-2G hardware support])
+AC_ARG_ENABLE(oc2g,
+   AC_HELP_STRING([--enable-oc2g],
+   [enable code for NuRAN Wireless OC-2G bts 
[default=no]]),
+   [enable_oc2g="yes"],[enable_oc2g="no"])
+AC_ARG_WITH([oc2g], [AS_HELP_STRING([--with-oc2g=INCLUDE_DIR], [Location of 
the OC-2G API header files])],
+[oc2g_incdir="$withval"],[oc2g_incdir="$incdir"])
+AC_SUBST([OC2G_INCDIR], -I$oc2g_incdir)
+AC_MSG_RESULT([$enable_oc2g])
+AM_CONDITIONAL(ENABLE_OC2GBTS, test "x$enable_oc2g" = "xyes")
+if test "$enable_oc2g" = "yes"; then
+   oldCPPFLAGS=$CPPFLAGS
+   CPPFLAGS="$CPPFLAGS $OC2G_INCDIR -I$srcdir/include"
+   AC_CHECK_HEADER([nrw/oc2g/oc2g.h],[],
+   [AC_MSG_ERROR([nrw/oc2g/oc2g.h can not be found in 
$oc2g_incdir])],
+   [#include ])
+   PKG_CHECK_MODULES(LIBSYSTEMD, libsystemd)
+PKG_CHECK_MODULES(LIBGPS, libgps)
+   CPPFLAGS=$oldCPPFLAGS
+fi
+
 # https://www.freedesktop.org/software/systemd/man/daemon.html
 AC_ARG_WITH([systemdsystemunitdir],
  [AS_HELP_STRING([--with-systemdsystemunitdir=DIR], [Directory for systemd 
service files])],,
@@ -307,6 +328,7 @@
 src/osmo-bts-omldummy/Makefile
 src/osmo-bts-sysmo/Makefile
 src/osmo-bts-litecell15/Makefile
+src/osmo-bts-oc2g/Makefile
 src/osmo-bts-trx/Makefile
 src/osmo-bts-octphy/Makefile
 include/Makefile
diff --git a/include/osmo-bts/gsm_data_shared.h 
b/include/osmo-bts/gsm_data_shared.h
index 794eaea..80784af 100644
--- a/include/osmo-bts/gsm_data_shared.h
+++ b/include/osmo-bts/gsm_data_shared.h
@@ -411,6 +411,9 @@
uint16_t arfcn;
int nominal_power;  /* in dBm */
unsigned int max_power_red; /* in actual dB */
+uint8_t max_power_backoff_8psk; /* in actual dB */
+uint8_t c0_idle_power_red;  /* in actual dB */
+

struct trx_power_params power_params;
int ms_power_control;
@@ -437,6 +440,7 @@
 enum gsm_bts_type_variant {
BTS_UNKNOWN,
BTS_OSMO_LITECELL15,
+BTS_OSMO_OC2G,
BTS_OSMO_OCTPHY,
BTS_OSMO_SYSMO,
BTS_OSMO_TRX,
@@ -746,7 +750,14 @@
struct timeval tv_clock;
struct osmo_timer_list fn_timer;
} vbts;
-
+#ifdef ENABLE_OC2GBTS
+/* specific to Open Cellular 2G BTS */
+struct {
+uint8_t led_ctrl_mode;  /* 0: 
control by BTS, 1: not control by BTS */
+struct llist_head ceased_alarm_list;/* ceased alarm list*/
+unsigned int rtp_drift_thres_ms;/* RTP 
timestamp drift detection threshold */
+} oc2g;
+#endif
 };


diff --git a/include/osmo-bts/l1sap.h b/include/osmo-bts/l1sap.h
index 3cf0ea5..4c30589 100644
--- a/include/osmo-bts/l1sap.h
+++ b/include/osmo-bts/l1sap.h
@@ -50,7 +50,7 @@
 static inline uint8_t l1sap_chan2ss(uint8_t chan_nr)
 {
if (L1SAP_IS_CHAN_BCCH(chan_nr))
-return L1SAP_CHAN2SS_BCCH(chan_nr);
+   return L1SAP_CHAN2SS_BCCH(chan_nr);
if (L1SAP_IS_CHAN_SDCCH8(chan_nr))
return L1SAP_CHAN2SS_SDCCH8(chan_nr);
if (L1SAP_IS_CHAN_SDCCH4(chan_nr))
diff --git a/include/osmo-bts/phy_link.h b/include/osmo-bts/phy_link.h
index 36e34e1..2472c05 100644
--- a/include/osmo-bts/phy_link.h
+++ b/include/osmo-bts/phy_link.h
@@ -135,6 +135,20 @@
uint8_t tx_pwr_adj_mode;/* 0: no auto adjust 
power, 1: auto adjust power using RMS detector */
uint8_t tx_pwr_red_8psk;/* 8-PSK maximum Tx 
power reduction level in dB */
} lc15;
+struct {
+/* configuration */
+uint32_t dsp_trace_f;
+char *calib_path;
+int minTxPower;
+int maxTxPower;
+struct oc2gl1_hdl *hdl;
+uint8_t max_cell_size;  /* 0:166 qbits*/
+uint8_t pedestal_mode;  /* 0: unused TS is 
OFF, 1: unused TS is in minimum Tx power */
+

Change in osmo-bts[master]: Add OC-2G BTS sources

2018-10-23 Thread Omar Ramadan 
Omar Ramadan has uploaded this change for review. ( 
https://gerrit.osmocom.org/11447


Change subject: Add OC-2G BTS sources
..

Add OC-2G BTS sources

Change-Id: I327384fe5ac944dc3996a3f00932d6f1a10d5a35
---
A src/osmo-bts-oc2g/Makefile.am
A src/osmo-bts-oc2g/calib_file.c
A src/osmo-bts-oc2g/hw_info.ver_major
A src/osmo-bts-oc2g/hw_misc.c
A src/osmo-bts-oc2g/hw_misc.h
A src/osmo-bts-oc2g/l1_if.c
A src/osmo-bts-oc2g/l1_if.h
A src/osmo-bts-oc2g/l1_transp.h
A src/osmo-bts-oc2g/l1_transp_hw.c
A src/osmo-bts-oc2g/main.c
A src/osmo-bts-oc2g/misc/.dirstamp
A src/osmo-bts-oc2g/misc/oc2gbts_bid.c
A src/osmo-bts-oc2g/misc/oc2gbts_bid.h
A src/osmo-bts-oc2g/misc/oc2gbts_bts.c
A src/osmo-bts-oc2g/misc/oc2gbts_bts.h
A src/osmo-bts-oc2g/misc/oc2gbts_clock.c
A src/osmo-bts-oc2g/misc/oc2gbts_clock.h
A src/osmo-bts-oc2g/misc/oc2gbts_led.c
A src/osmo-bts-oc2g/misc/oc2gbts_led.h
A src/osmo-bts-oc2g/misc/oc2gbts_mgr.c
A src/osmo-bts-oc2g/misc/oc2gbts_mgr.h
A src/osmo-bts-oc2g/misc/oc2gbts_mgr_calib.c
A src/osmo-bts-oc2g/misc/oc2gbts_mgr_nl.c
A src/osmo-bts-oc2g/misc/oc2gbts_mgr_temp.c
A src/osmo-bts-oc2g/misc/oc2gbts_mgr_vty.c
A src/osmo-bts-oc2g/misc/oc2gbts_misc.c
A src/osmo-bts-oc2g/misc/oc2gbts_misc.h
A src/osmo-bts-oc2g/misc/oc2gbts_nl.c
A src/osmo-bts-oc2g/misc/oc2gbts_nl.h
A src/osmo-bts-oc2g/misc/oc2gbts_par.c
A src/osmo-bts-oc2g/misc/oc2gbts_par.h
A src/osmo-bts-oc2g/misc/oc2gbts_power.c
A src/osmo-bts-oc2g/misc/oc2gbts_power.h
A src/osmo-bts-oc2g/misc/oc2gbts_swd.c
A src/osmo-bts-oc2g/misc/oc2gbts_swd.h
A src/osmo-bts-oc2g/misc/oc2gbts_temp.c
A src/osmo-bts-oc2g/misc/oc2gbts_temp.h
A src/osmo-bts-oc2g/misc/oc2gbts_util.c
A src/osmo-bts-oc2g/oc2gbts.c
A src/osmo-bts-oc2g/oc2gbts.h
A src/osmo-bts-oc2g/oc2gbts_vty.c
A src/osmo-bts-oc2g/oml.c
A src/osmo-bts-oc2g/oml_router.c
A src/osmo-bts-oc2g/oml_router.h
A src/osmo-bts-oc2g/tch.c
A src/osmo-bts-oc2g/utils.c
A src/osmo-bts-oc2g/utils.h
47 files changed, 12,596 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/47/11447/1


--
To view, visit https://gerrit.osmocom.org/11447
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I327384fe5ac944dc3996a3f00932d6f1a10d5a35
Gerrit-Change-Number: 11447
Gerrit-PatchSet: 1
Gerrit-Owner: Omar Ramadan

Change in osmo-dev[master]: gen_makefile.py: detect changes in cpp files

2018-10-23 Thread Harald Welte 
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11434 )

Change subject: gen_makefile.py: detect changes in cpp files
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/11434
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9382d984fa1988eefbb6be3e45d88b2f1f5b598a
Gerrit-Change-Number: 11434
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Comment-Date: Tue, 23 Oct 2018 18:27:34 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in docker-playground[master]: repo-install-test: version test for all programs

2018-10-23 Thread Harald Welte 
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11436 )

Change subject: repo-install-test: version test for all programs
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11436
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I796f1e34d2c026b11dff89511b667fa457856088
Gerrit-Change-Number: 11436
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Comment-Date: Tue, 23 Oct 2018 18:26:40 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: cosmetic: fix spec ref for gsm0808_cipher_mode()

2018-10-23 Thread Harald Welte 
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11437 )

Change subject: cosmetic: fix spec ref for gsm0808_cipher_mode()
..


Patch Set 1: Code-Review-1

I don't really see where the entire function does anything related to GSM TS 
04.08?  It's dealing with BSSAP/BSSMAP which is in 08.08 ?!?


--
To view, visit https://gerrit.osmocom.org/11437
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I359caf1dd30f033c0b606040ccf27aa4c5a9d2c6
Gerrit-Change-Number: 11437
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Tue, 23 Oct 2018 18:26:09 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: codec_pref: also check amr codec rates in check_codec_pref()

2018-10-23 Thread Harald Welte 
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11442 )

Change subject: codec_pref: also check amr codec rates in check_codec_pref()
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11442
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3537d1c89e2520d35cc0e150ba8e6d3693e06710
Gerrit-Change-Number: 11442
Gerrit-PatchSet: 2
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Tue, 23 Oct 2018 18:24:00 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: codec_pref: also check amr codec rates in check_codec_pref()

2018-10-23 Thread Harald Welte 
Harald Welte has uploaded a new patch set (#2) to the change originally created 
by dexter. ( https://gerrit.osmocom.org/11442 )

Change subject: codec_pref: also check amr codec rates in check_codec_pref()
..

codec_pref: also check amr codec rates in check_codec_pref()

The function check_codec_pref() currently only does a basic check over
the general codec configuration of bts and msc. However, it does not yet
check if the amr codec rate settings for the BTSs contradict the
allowed/forbidden amr codec rates of the MSC. When the two settings do
contradict AMR would not work, even when everything else is correctly
configured. We need to check this on startup to spot configuration
problems quickly.

- Add function to calculate intersections of struct
  gsm48_multi_rate_conf variables.
- Calculate the intersection between the multi rate config of
  each BTS with the one of the MSC

Change-Id: I3537d1c89e2520d35cc0e150ba8e6d3693e06710
Related: OS#3529
---
M include/osmocom/bsc/codec_pref.h
M src/osmo-bsc/codec_pref.c
2 files changed, 53 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/42/11442/2
--
To view, visit https://gerrit.osmocom.org/11442
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3537d1c89e2520d35cc0e150ba8e6d3693e06710
Gerrit-Change-Number: 11442
Gerrit-PatchSet: 2
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-bsc[master]: gsm_data: set meaningful default values for amr modes

2018-10-23 Thread Harald Welte 
Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11441 )

Change subject: gsm_data: set meaningful default values for amr modes
..

gsm_data: set meaningful default values for amr modes

The function gsm_bts_alloc() does set default values for the amr rates
for a newly allocated bts, but it does not populate the ms_mode and
bts_mode flags which contain hysteresis and threshold. Those values are
currently set to 0 by default, which does not make much sense. Lets
popluate some appropriate default values.

- Make sure that .mode .hysteresis and .threshold are populated for
  MS and BTS in full and halfrate

Change-Id: If14843fa6584e5991d5c0abb765611dfaa57
Related: OS#3529
---
M src/osmo-bsc/gsm_data.c
1 file changed, 30 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/osmo-bsc/gsm_data.c b/src/osmo-bsc/gsm_data.c
index 8d0b831..08d5bcb 100644
--- a/src/osmo-bsc/gsm_data.c
+++ b/src/osmo-bsc/gsm_data.c
@@ -900,6 +900,21 @@
.m12_2 = 1
};
memcpy(bts->mr_full.gsm48_ie, _cfg, sizeof(bts->mr_full.gsm48_ie));
+   bts->mr_full.ms_mode[0].mode = 1;
+   bts->mr_full.ms_mode[1].mode = 2;
+   bts->mr_full.ms_mode[2].mode = 6;
+   bts->mr_full.ms_mode[3].mode = 7;
+   bts->mr_full.bts_mode[0].mode = 1;
+   bts->mr_full.bts_mode[1].mode = 2;
+   bts->mr_full.bts_mode[2].mode = 6;
+   bts->mr_full.bts_mode[3].mode = 7;
+   for (i = 0; i < 3; i++) {
+   bts->mr_full.ms_mode[i].hysteresis = 8;
+   bts->mr_full.ms_mode[i].threshold = 32;
+   bts->mr_full.bts_mode[i].hysteresis = 8;
+   bts->mr_full.bts_mode[i].threshold = 32;
+   }
+   bts->mr_full.num_modes = 4;

mr_cfg = (struct gsm48_multi_rate_conf) {
.m4_75 = 0,
@@ -912,6 +927,21 @@
.m12_2 = 0
};
memcpy(bts->mr_half.gsm48_ie, _cfg, sizeof(bts->mr_half.gsm48_ie));
+   bts->mr_half.ms_mode[0].mode = 1;
+   bts->mr_half.ms_mode[1].mode = 2;
+   bts->mr_half.ms_mode[2].mode = 4;
+   bts->mr_half.ms_mode[3].mode = 5;
+   bts->mr_half.bts_mode[0].mode = 1;
+   bts->mr_half.bts_mode[1].mode = 2;
+   bts->mr_half.bts_mode[2].mode = 4;
+   bts->mr_half.bts_mode[3].mode = 5;
+   for (i = 0; i < 3; i++) {
+   bts->mr_half.ms_mode[i].hysteresis = 8;
+   bts->mr_half.ms_mode[i].threshold = 32;
+   bts->mr_half.bts_mode[i].hysteresis = 8;
+   bts->mr_half.bts_mode[i].threshold = 32;
+   }
+   bts->mr_half.num_modes = 4;

return bts;
 }

--
To view, visit https://gerrit.osmocom.org/11441
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If14843fa6584e5991d5c0abb765611dfaa57
Gerrit-Change-Number: 11441
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-bsc[master]: lchan_fsm: generate proper multirate configuration IE on RSL

2018-10-23 Thread Harald Welte 
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11445 )

Change subject: lchan_fsm: generate proper multirate configuration IE on RSL
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11445
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f9f8e8d9e2724cbe3ce2f3599bc0e5185fd8453
Gerrit-Change-Number: 11445
Gerrit-PatchSet: 2
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Tue, 23 Oct 2018 18:22:36 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: gsm_04_08: improve gsm48_multirate_config()

2018-10-23 Thread Harald Welte 
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11443 )

Change subject: gsm_04_08: improve gsm48_multirate_config()
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11443
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I06beb7dd7236c81c3a91af4d09c31891f4b910a4
Gerrit-Change-Number: 11443
Gerrit-PatchSet: 2
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Tue, 23 Oct 2018 18:21:30 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: bsc_vty: check amr mode parameters

2018-10-23 Thread Harald Welte 
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11444 )

Change subject: bsc_vty: check amr mode parameters
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11444
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b9f69b89a39bbf4800d9790f7abe43ce66aeb71
Gerrit-Change-Number: 11444
Gerrit-PatchSet: 2
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Tue, 23 Oct 2018 18:19:48 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bts[master]: bts-trx: Try decoding received UL bursts when SACCH frame detected as...

2018-10-23 Thread Harald Welte 
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11446 )

Change subject: bts-trx: Try decoding received UL bursts when SACCH frame 
detected as lost
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/11446
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I910277df181df5082b234c1c97a75eebdffc2cb5
Gerrit-Change-Number: 11446
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Tue, 23 Oct 2018 18:01:45 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bts[master]: bts-trx: Try decoding received UL bursts when SACCH frame detected as...

2018-10-23 Thread Pau Espin Pedrol 
Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/11446


Change subject: bts-trx: Try decoding received UL bursts when SACCH frame 
detected as lost
..

bts-trx: Try decoding received UL bursts when SACCH frame detected as lost

This way if for instance only 1 out of 3 bursts was lost, reported ul
mesuarement is more similar to expected values.

Related: OS#3665
Change-Id: I910277df181df5082b234c1c97a75eebdffc2cb5
---
M src/osmo-bts-trx/scheduler_trx.c
1 file changed, 61 insertions(+), 41 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/46/11446/1

diff --git a/src/osmo-bts-trx/scheduler_trx.c b/src/osmo-bts-trx/scheduler_trx.c
index fa3aed2..332a41d 100644
--- a/src/osmo-bts-trx/scheduler_trx.c
+++ b/src/osmo-bts-trx/scheduler_trx.c
@@ -65,6 +65,61 @@
return 1 * n_errors / n_bits_total;
 }

+static void reset_ul_bursts(struct l1sched_chan_state *chan_state, uint32_t 
first_fn)
+{
+   if (chan_state->ul_bursts)
+   memset(chan_state->ul_bursts, 0, 464);
+   chan_state->ul_mask = 0x0;
+   chan_state->ul_first_fn = first_fn;
+   chan_state->rssi_sum = 0;
+   chan_state->rssi_num = 0;
+   chan_state->toa256_sum = 0;
+   chan_state->toa_num = 0;
+}
+
+static int _submit_ph_data_ind_with_ul_meas_res(struct l1sched_trx *l1t, 
uint8_t tn,
+   uint32_t fn, enum trx_chan_type chan,
+   struct l1sched_chan_state *chan_state)
+{
+   uint8_t l2[GSM_MACBLOCK_LEN], l2_len;
+   int n_errors, n_bits_total;
+   uint16_t ber10k;
+   float rssi;
+   int16_t toa256;
+   int rc;
+   struct l1sched_ts *l1ts = l1sched_trx_get_ts(l1t, tn);
+
+   /* empty mask -> empty buffer, no need to decode buffer (buffer may not 
even be allocated) */
+   if (chan_state->ul_mask == 0x0) {
+   l1if_process_meas_res(l1t->trx, tn, fn, 
trx_chan_desc[chan].chan_nr | tn,
+ 456, 456, -110, 0);
+   ber10k = compute_ber10k(0, 456);
+   return _sched_compose_ph_data_ind(l1t, tn, 0, chan, NULL, 0,
+  -110, 0, 0, ber10k,
+  PRES_INFO_INVALID);
+   }
+
+   /* Once processed, erase mask so they are not used again, also 
invalidating ul_first_fn */
+   chan_state->ul_mask = 0x0;
+   rssi = chan_state->rssi_sum / chan_state->rssi_num;
+   toa256 = chan_state->toa256_sum / chan_state->toa_num;
+   /* decode */
+   rc = gsm0503_xcch_decode(l2, chan_state->ul_bursts, _errors, 
_bits_total);
+   if (rc) {
+   LOGL1S(DL1P, LOGL_NOTICE, l1t, tn, chan, fn, "Received bad data 
(%u/%u)\n",
+   chan_state->ul_first_fn, chan_state->ul_first_fn % 
l1ts->mf_period);
+   l2_len = 0;
+   } else
+   l2_len = GSM_MACBLOCK_LEN;
+
+   /* Send uplink measurement information to L2 */
+   l1if_process_meas_res(l1t->trx, tn, chan_state->ul_first_fn, 
trx_chan_desc[chan].chan_nr | tn,
+   n_errors, n_bits_total, rssi, toa256);
+   ber10k = compute_ber10k(n_bits_total, n_errors);
+   return _sched_compose_ph_data_ind(l1t, tn, chan_state->ul_first_fn, 
chan, l2, l2_len,
+ rssi,  4 * toa256, 0, ber10k, 
PRES_INFO_UNKNOWN);
+}
+
 /*
  * TX on downlink
  */
@@ -194,16 +249,9 @@
if (L1SAP_IS_LINK_SACCH(trx_chan_desc[chan].link_id)) {
/* count and send BFI */
if (++(l1ts->chan_state[chan].lost_frames) > 1) {
-   /* TODO: Should we pass old TOA here? Otherwise we risk
-* unnecessary decreasing TA */
-
-   /* Send uplink measurement information to L2 */
-   l1if_process_meas_res(l1t->trx, tn, fn, 
trx_chan_desc[chan].chan_nr | tn,
-   456, 456, -110, 0);
-   /* FIXME: use actual values for BER etc */
-   _sched_compose_ph_data_ind(l1t, tn, 0, chan, NULL, 0,
-  -110, 0, 0, 1,
-  PRES_INFO_INVALID);
+   _submit_ph_data_ind_with_ul_meas_res(l1t, tn, fn, chan, 
>chan_state[chan]);
+   /* Don't keep re-sending same meas result cached over 
and over */
+   reset_ul_bursts(>chan_state[chan], fn);
}
}

@@ -767,10 +815,6 @@
uint8_t *rssi_num = _state->rssi_num;
int32_t *toa256_sum = _state->toa256_sum;
uint8_t *toa_num = _state->toa_num;
-   uint8_t l2[GSM_MACBLOCK_LEN], l2_len;
-   int n_errors, n_bits_total;
-   uint16_t ber10k;
-   int rc;

/* handle RACH, if handover RACH detection is turned on */
if

Change in osmo-ttcn3-hacks[master]: RSL_Emulation: handle ASP_IPA_EVENT_DOWN

2018-10-23 Thread daniel 
daniel has posted comments on this change. ( https://gerrit.osmocom.org/11429 )

Change subject: RSL_Emulation: handle ASP_IPA_EVENT_DOWN
..


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/11429/2//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/11429/2//COMMIT_MSG@9
PS2, Line 9: Otherwise RSL layer fails this way when this event is received:
> Why are we expecting the RSL layer to ever receive an ASP_IPA_EVENT_DOWN?  I 
> agree the message is a  […]
I spoke with pespin and we basically concluded, that this seems to be another 
issue due to high load. The BTS
did not receive the clock from osmo-trx (or what's driving osmo-bts in the 
test).

‎[19:21:15] ‎pespin‎: Wed Oct 17 07:22:32 2018 DOML <0001> bts.c:239 Shutting 
down BTS 0, Reason No clock from osmo-trx

So failing explicitly in these cases seems the better idea.

For an explicit failure you should call "all component.stop" after the 
setverdict(fail) so that we don't run into any dynamic testcase errors due to 
unconnected ports that get messages.
‎
BTS_Tests has an f_shutdown function which does that exactly and should 
probably be moved to a common place since this should just be callable from 
about anywhere.



--
To view, visit https://gerrit.osmocom.org/11429
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc6565c9de72d98015d56a41e5616c46051c8a8d
Gerrit-Change-Number: 11429
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: daniel 
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Tue, 23 Oct 2018 17:29:47 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: codec_pref: also check amr codec rates in check_codec_pref()

2018-10-23 Thread Harald Welte 
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11442 )

Change subject: codec_pref: also check amr codec rates in check_codec_pref()
..


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/11442/1/src/osmo-bsc/codec_pref.c
File src/osmo-bsc/codec_pref.c:

https://gerrit.osmocom.org/#/c/11442/1/src/osmo-bsc/codec_pref.c@462
PS1, Line 462: tch-f
tch-h?



--
To view, visit https://gerrit.osmocom.org/11442
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3537d1c89e2520d35cc0e150ba8e6d3693e06710
Gerrit-Change-Number: 11442
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Tue, 23 Oct 2018 16:54:07 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: gsm_data: set meaningful default values for amr modes

2018-10-23 Thread Harald Welte 
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11441 )

Change subject: gsm_data: set meaningful default values for amr modes
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11441
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If14843fa6584e5991d5c0abb765611dfaa57
Gerrit-Change-Number: 11441
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Tue, 23 Oct 2018 16:52:43 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmocom-bb[master]: mobile: display MS IMSI in vty

2018-10-23 Thread Harald Welte 
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11440 )

Change subject: mobile: display MS IMSI in vty
..


Patch Set 1: Code-Review-1

also, why only print the IMSI if it's an emulaed SIM, but not with a real 
hardware SIM?  That's just wrong.


--
To view, visit https://gerrit.osmocom.org/11440
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id05f4f5f3416dcdb9ce2fd24f9360f5e6faaf654
Gerrit-Change-Number: 11440
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: fixeria 
Gerrit-Comment-Date: Tue, 23 Oct 2018 16:33:24 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmocom-bb[master]: mobile: display MS IMSI in vty

2018-10-23 Thread Vadim Yanitskiy 
Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/11440 )

Change subject: mobile: display MS IMSI in vty
..


Patch Set 1: Code-Review-1

I think it can be obtained using 'subscriber' command,
why do we need to duplicate?


--
To view, visit https://gerrit.osmocom.org/11440
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id05f4f5f3416dcdb9ce2fd24f9360f5e6faaf654
Gerrit-Change-Number: 11440
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: fixeria 
Gerrit-Comment-Date: Tue, 23 Oct 2018 16:31:55 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: gsm_04_08: improve gsm48_multirate_config()

2018-10-23 Thread dexter 
Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11443

to look at the new patch set (#2).

Change subject: gsm_04_08: improve gsm48_multirate_config()
..

gsm_04_08: improve gsm48_multirate_config()

The function gsm48_multirate_config() generates the multirate
configuration IE, that is sent via RSL to configure the active set of
AMR codecs inside the BTS. The function already works, but it does not
check the input data for consistancy. Lets add some consistancy check to
make sure that inconsistant parameters are rejected. Also allow the
output pointer to be NULL, so that the function can be used to perform
a dry run to be able to verify parameters.

- Check for invalid / inconsistant configuration parameters
- Perform a dry-run when lv pointer is set to NULL

Change-Id: I06beb7dd7236c81c3a91af4d09c31891f4b910a4
Related: OS#3529
---
M include/osmocom/bsc/gsm_04_08_rr.h
M src/osmo-bsc/bsc_vty.c
M src/osmo-bsc/gsm_04_08_rr.c
M tests/gsm0408/Makefile.am
M tests/gsm0408/gsm0408_test.c
M tests/gsm0408/gsm0408_test.ok
6 files changed, 237 insertions(+), 26 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/43/11443/2
--
To view, visit https://gerrit.osmocom.org/11443
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I06beb7dd7236c81c3a91af4d09c31891f4b910a4
Gerrit-Change-Number: 11443
Gerrit-PatchSet: 2
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-bsc[master]: lchan_fsm: generate proper multirate configuration IE on RSL

2018-10-23 Thread dexter 
Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11445

to look at the new patch set (#2).

Change subject: lchan_fsm: generate proper multirate configuration IE on RSL
..

lchan_fsm: generate proper multirate configuration IE on RSL

During the generation of the multirate configuration IE in the channel
activation message that is sent over RSL, all AMR rates except the
highest one are trimmed. This was to ensure that the multirate
configuration IE only contains one codec rate per active set. Lets fix
that and generate a proper IE with threshold and hysteresis values.

- extend lchan_mr_config so that it can generate a full multirate
  configuration IE

Change-Id: I7f9f8e8d9e2724cbe3ce2f3599bc0e5185fd8453
Related: OS#3529
---
M src/osmo-bsc/lchan_fsm.c
M tests/handover/handover_test.c
2 files changed, 72 insertions(+), 58 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/45/11445/2
--
To view, visit https://gerrit.osmocom.org/11445
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7f9f8e8d9e2724cbe3ce2f3599bc0e5185fd8453
Gerrit-Change-Number: 11445
Gerrit-PatchSet: 2
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-mgw[master]: use a dynamic name for rtp connection rate counters

2018-10-23 Thread dexter 
dexter has posted comments on this change. ( https://gerrit.osmocom.org/11439 )

Change subject: use a dynamic name for rtp connection rate counters
..


Patch Set 1: Code-Review+1

> Build Successful
 >
 > https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-mgw/462/ :
 > SUCCESS'  --verified 1 --code-review 0


--
To view, visit https://gerrit.osmocom.org/11439
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I027644f4b913e1f966c11b081e9027e61591a224
Gerrit-Change-Number: 11439
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Reviewer: dexter 
Gerrit-Comment-Date: Tue, 23 Oct 2018 16:09:35 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: lchan_fsm: generate proper multirate configuration IE on RSL

2018-10-23 Thread dexter 
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/11445


Change subject: lchan_fsm: generate proper multirate configuration IE on RSL
..

lchan_fsm: generate proper multirate configuration IE on RSL

During the generation of the multirate configuration IE in the channel
activation message that is sent over RSL, all AMR rates except the
highest one are trimmed. This was to ensure that the multirate
configuration IE only contains one codec rate per active set. Lets fix
that and generate a proper IE with threshold and hysteresis values.

- extend lchan_mr_config so that it can generate a full multirate
  configuration IE

Change-Id: I7f9f8e8d9e2724cbe3ce2f3599bc0e5185fd8453
Related: OS#3529
---
M src/osmo-bsc/lchan_fsm.c
M tests/handover/handover_test.c
2 files changed, 72 insertions(+), 58 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/45/11445/1

diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c
index 39edaff..915b62a 100644
--- a/src/osmo-bsc/lchan_fsm.c
+++ b/src/osmo-bsc/lchan_fsm.c
@@ -36,6 +36,8 @@
 #include 
 #include 
 #include 
+#include 
+

 static struct osmo_fsm lchan_fsm;

@@ -402,66 +404,71 @@
osmo_fsm_inst_dispatch(lchan->ts->fi, TS_EV_LCHAN_UNUSED, lchan);
 }

-/*! Configure the multirate setting on this channel. */
-void lchan_mr_config(struct gsm_lchan *lchan, struct gsm48_multi_rate_conf 
*mr_conf)
+/* Configure the multirate setting on this channel. */
+static int lchan_mr_config(struct gsm_lchan *lchan, const struct 
gsm48_multi_rate_conf *mr_conf)
 {
-   struct gsm48_multi_rate_conf *ms_conf, *bts_conf;
bool full_rate = (lchan->type == GSM_LCHAN_TCH_F);
+   struct gsm_bts *bts = lchan->ts->trx->bts;
+   struct bsc_msc_data *msc = lchan->conn->sccp.msc;
+   struct amr_multirate_conf *mr;
+   int rc;
+   int rc_rate;
+   struct gsm48_multi_rate_conf mr_conf_filtered;
+   const struct gsm48_multi_rate_conf *mr_conf_bts;

-   /* initialize the data structure */
-   lchan->mr_ms_lv[0] = sizeof(*ms_conf);
-   lchan->mr_bts_lv[0] = sizeof(*bts_conf);
-   ms_conf = (struct gsm48_multi_rate_conf *) >mr_ms_lv[1];
-   bts_conf = (struct gsm48_multi_rate_conf *) >mr_bts_lv[1];
+   /* There are two different active sets, depending on the channel rate,
+* make sure the appropate one is selected. */
+   if (full_rate)
+   mr = >mr_full;
+   else
+   mr = >mr_half;

-   *ms_conf = *bts_conf = (struct gsm48_multi_rate_conf){
-   .ver = 1,
-   .icmi = 1,
-   .m4_75 = mr_conf->m4_75,
-   .m5_15 = mr_conf->m5_15,
-   .m5_90 = mr_conf->m5_90,
-   .m6_70 = mr_conf->m6_70,
-   .m7_40 = mr_conf->m7_40,
-   .m7_95 = mr_conf->m7_95,
-   .m10_2 = full_rate? mr_conf->m10_2 : 0,
-   .m12_2 = full_rate? mr_conf->m12_2 : 0,
-   };
-}
-
-/* Mask all rates instead of the highest possible */
-static void lchan_mr_config_mask(struct gsm48_multi_rate_conf *mr_conf)
-{
-   unsigned int i;
-   bool highest_seen = false;
-   uint8_t *_mr_conf = (uint8_t *) mr_conf;
-
-   /* FIXME: At the moment we can not support multiple codec rates in one
-* struct gsm48_multi_rate_conf, because the struct lacks the fields
-* for Threshold and Hysteresis. Those fields are not needed when only
-* a single codec rate is in place, but as soon as multiple codec
-* rates are used the parameters are mandatory. The layout for the
-* struct would then also be different because each rate needs its
-* own Threshold and Hysteresis value. (See also 3GPP TS 04.08,
-* chapter 10.5.2.21aa MultiRate configuration).
-*
-* Since we are unable to signal multiple codec rates properly, we just
-* remove all codec rates from the active set, except the highest
-* possible. Doing so we lack the functionality to switch towards the
-* other, lower codec rates that were offered by the MSC, but it is
-* still guaranteed that a rate is selected that is supported by all
-* entities.
-*
-* To fix this problem, we should implement a proper encoder for
-* struct gsm48_multi_rate_conf, in libosmocore and use it here.
-* struct amr_mode already seems to have members for threshold and
-* hysteresis we can use. */
-
-   for (i = 7; i > 0; i--) {
-   if (_mr_conf[1] & (1 << i) && highest_seen == false) {
-   highest_seen = true;
-   } else if (highest_seen)
-   _mr_conf[1] &= ~(1 << i);
+   /* The VTY allows to forbid certain codec rates. Unfortunately we can
+* not articulate all of the prohibitions on through S0-S15 on the A
+* interface. To ensure

Change in osmo-bsc[master]: bsc_vty: check amr mode parameters

2018-10-23 Thread dexter 
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/11444


Change subject: bsc_vty: check amr mode parameters
..

bsc_vty: check amr mode parameters

The vty already has a well working interface to configure the AMR
mode, threshold and hysteresis parameters. However there are no checks
yet to prevent against misconfiguration.

- Use gsm48_multirate_config() to perform a global check of the overall
  configuration

- Add check AMR modes during input (order, duplicates)

Change-Id: I8b9f69b89a39bbf4800d9790f7abe43ce66aeb71
Related: OS#3529
---
M src/osmo-bsc/bsc_vty.c
1 file changed, 107 insertions(+), 23 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/44/11444/1

diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c
index f156cc8..dd540c1 100644
--- a/src/osmo-bsc/bsc_vty.c
+++ b/src/osmo-bsc/bsc_vty.c
@@ -3511,11 +3511,45 @@
struct gsm48_multi_rate_conf *mr_conf =
(struct gsm48_multi_rate_conf *) mr->gsm48_ie;
int i;
+   int mode;
+   int mode_prev = -1;

+   /* Check if mode parameters are in order */
+   for (i = 0; i < argc; i++) {
+   mode = atoi(argv[i]);
+   if (mode_prev > mode) {
+   vty_out(vty, "Modes must be listed in order%s",
+   VTY_NEWLINE);
+   return;
+   }
+
+   if (mode_prev == mode) {
+   vty_out(vty, "Modes must be unique %s", VTY_NEWLINE);
+   return;
+   }
+   mode_prev = mode;
+   }
+
+   /* Prepare the multirate configuration IE */
mr->gsm48_ie[1] = 0;
for (i = 0; i < argc; i++)
mr->gsm48_ie[1] |= 1 << atoi(argv[i]);
mr_conf->icmi = 0;
+
+   /* Store actual mode identifier values */
+   for (i = 0; i < argc; i++) {
+   mr->ms_mode[i].mode = atoi(argv[i]);
+   mr->bts_mode[i].mode = atoi(argv[i]);
+   }
+   mr->num_modes = argc;
+
+   /* Trim excess threshold and hysteresis values from previous config */
+   for (i = argc - 1; i < 4; i++) {
+   mr->ms_mode[i].threshold = 0;
+   mr->bts_mode[i].threshold = 0;
+   mr->ms_mode[i].hysteresis = 0;
+   mr->bts_mode[i].hysteresis = 0;
+   }
 }

 static void get_amr_th_from_arg(struct vty *vty, int argc, const char *argv[], 
int full)
@@ -3567,6 +3601,55 @@
}
 }

+/* Give the current amr configuration a final consistency chack by feeding the
+ * the configuration into the gsm48 multirate IE generator function */
+static int check_amr_config(struct vty *vty)
+{
+   int rc = 0;
+   struct amr_multirate_conf *mr;
+   const struct gsm48_multi_rate_conf *mr_conf;
+   struct gsm_bts *bts = vty->index;
+   int vty_rc = CMD_SUCCESS;
+
+   mr = >mr_full;
+   mr_conf = (struct gsm48_multi_rate_conf*) mr->gsm48_ie;
+   rc = gsm48_multirate_config(NULL, mr_conf, mr->ms_mode, mr->num_modes);
+   if (rc != 0) {
+   vty_out(vty,
+   "Invalid AMR multirate configuration (tch-f, ms) - 
check parameters%s",
+   VTY_NEWLINE);
+   vty_rc = CMD_WARNING;
+   }
+
+   rc = gsm48_multirate_config(NULL, mr_conf, mr->bts_mode, mr->num_modes);
+   if (rc != 0) {
+   vty_out(vty,
+   "Invalid AMR multirate configuration (tch-f, bts) - 
check parameters%s",
+   VTY_NEWLINE);
+   vty_rc = CMD_WARNING;
+   }
+
+   mr = >mr_half;
+   mr_conf = (struct gsm48_multi_rate_conf*) mr->gsm48_ie;
+   rc = gsm48_multirate_config(NULL, mr_conf, mr->ms_mode, mr->num_modes);
+   if (rc != 0) {
+   vty_out(vty,
+   "Invalid AMR multirate configuration (tch-h, ms) - 
check parameters%s",
+   VTY_NEWLINE);
+   vty_rc = CMD_WARNING;
+   }
+
+   rc = gsm48_multirate_config(NULL, mr_conf, mr->bts_mode, mr->num_modes);
+   if (rc != 0) {
+   vty_out(vty,
+   "Invalid AMR multirate configuration (tch-h, bts) - 
check parameters%s",
+   VTY_NEWLINE);
+   vty_rc = CMD_WARNING;
+   }
+
+   return vty_rc;
+}
+
 #define AMR_TCHF_PAR_STR " (0|1|2|3|4|5|6|7)"
 #define AMR_TCHF_HELP_STR "4,75k\n5,15k\n5,90k\n6,70k\n7,40k\n7,95k\n" \
"10,2k\n12,2k\n"
@@ -3583,7 +3666,7 @@
AMR_TCHF_HELP_STR)
 {
get_amr_from_arg(vty, 1, argv, 1);
-   return CMD_SUCCESS;
+   return check_amr_config(vty);
 }

 DEFUN(cfg_bts_amr_fr_modes2, cfg_bts_amr_fr_modes2_cmd,
@@ -3592,7 +3675,7 @@
AMR_TCHF_HELP_STR AMR_TCHF_HELP_STR)
 {
get_amr_from_arg(vty, 2, argv, 1);
-   return CMD_SUCCESS;
+   return

Change in osmo-bsc[master]: codec_pref: also check amr codec rates in check_codec_pref()

2018-10-23 Thread dexter 
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/11442


Change subject: codec_pref: also check amr codec rates in check_codec_pref()
..

codec_pref: also check amr codec rates in check_codec_pref()

The function check_codec_pref() currently only does a basic check over
the general codec configuration of bts and msc. However, it does not yet
check if the amr codec rate settings for the BTSs contradict the
allowed/forbidden amr codec rates of the MSC. When the two settings do
contradict AMR would not work, even when everything else is correctly
configured. We need to check this on startup to spot configuration
problems quickly.

- Add function to calculate intersections of struct
  gsm48_multi_rate_conf variables.
- Calculate the intersection between the multi rate config of
  each BTS with the one of the MSC

Change-Id: I3537d1c89e2520d35cc0e150ba8e6d3693e06710
Related: OS#3529
---
M include/osmocom/bsc/codec_pref.h
M src/osmo-bsc/codec_pref.c
2 files changed, 53 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/42/11442/1

diff --git a/include/osmocom/bsc/codec_pref.h b/include/osmocom/bsc/codec_pref.h
index d62d29f..51340c1 100644
--- a/include/osmocom/bsc/codec_pref.h
+++ b/include/osmocom/bsc/codec_pref.h
@@ -22,4 +22,8 @@
  const struct bsc_msc_data *msc,
  const struct gsm_bts *bts);

+int calc_amr_rate_intersection(struct gsm48_multi_rate_conf *c,
+  const struct gsm48_multi_rate_conf *b,
+  const struct gsm48_multi_rate_conf *a);
+
 int check_codec_pref(struct llist_head *mscs);
diff --git a/src/osmo-bsc/codec_pref.c b/src/osmo-bsc/codec_pref.c
index 9f30c7b..b031220 100644
--- a/src/osmo-bsc/codec_pref.c
+++ b/src/osmo-bsc/codec_pref.c
@@ -393,6 +393,35 @@
}
 }

+/*! Calculate the intersection of the rate configuration of two multirate 
configuration
+ *  IE structures. The result c will be a copy of a, but the rate 
configuration bits
+ *  will be the intersection of the rate configuration bits in a and b.
+ *  \param[out] c user provided memory to store the result.
+ *  \param[in] a multi rate configuration a.
+ *  \param[in] b multi rate configuration b.
+ *  \returns 0 on success, -1 when the result contains an empty set of modes. 
*/
+int calc_amr_rate_intersection(struct gsm48_multi_rate_conf *c,
+  const struct gsm48_multi_rate_conf *b,
+  const struct gsm48_multi_rate_conf *a)
+{
+   struct gsm48_multi_rate_conf res;
+   uint8_t *_a = (uint8_t *) a;
+   uint8_t *_b = (uint8_t *) b;
+   uint8_t *_res = (uint8_t *) & res;
+
+   memcpy(, a, sizeof(res));
+
+   _res[1] = _a[1] & _b[1];
+
+   if (_res[1] == 0x00)
+   return -1;
+
+   if (c)
+   memcpy(c, , sizeof(*c));
+
+   return 0;
+}
+
 /*! Visit the codec settings for the MSC and for each BTS in order to make sure
  *  that the configuration does not contain any combinations that lead into a
  *  mutually exclusive codec configuration (empty intersection).
@@ -404,6 +433,8 @@
struct gsm_bts *bts;
struct gsm0808_speech_codec_list scl;
int rc = 0;
+   int rc_rate;
+   const struct gsm48_multi_rate_conf *bts_gsm48_ie;

llist_for_each_entry(msc, mscs, entry) {
llist_for_each_entry(bts, >network->bts_list, list) {
@@ -414,6 +445,24 @@
 bts->nr, msc->nr);
rc = -1;
}
+
+   bts_gsm48_ie = (struct gsm48_multi_rate_conf 
*)>mr_full.gsm48_ie;
+   rc_rate = calc_amr_rate_intersection(NULL, 
>amr_conf, bts_gsm48_ie);
+   if (rc_rate < 0) {
+   LOGP(DMSC, LOGL_FATAL,
+"network amr tch-f mode config of BTS %u 
does not intersect with amr-config of MSC %u\n",
+bts->nr, msc->nr);
+   rc = -1;
+   }
+
+   bts_gsm48_ie = (struct gsm48_multi_rate_conf 
*)>mr_half.gsm48_ie;
+   rc_rate = calc_amr_rate_intersection(NULL, 
>amr_conf, bts_gsm48_ie);
+   if (rc_rate < 0) {
+   LOGP(DMSC, LOGL_FATAL,
+"network amr tch-f mode config of BTS %u 
does not intersect with amr-config of MSC %u\n",
+bts->nr, msc->nr);
+   rc = -1;
+   }
}
}


-- 
To view, visit https://gerrit.osmocom.org/11442
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc

Change in osmo-bsc[master]: gsm_04_08: improve gsm48_multirate_config()

2018-10-23 Thread dexter 
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/11443


Change subject: gsm_04_08: improve gsm48_multirate_config()
..

gsm_04_08: improve gsm48_multirate_config()

The function gsm48_multirate_config() generates the multirate
configuration IE, that is sent via RSL to configure the active set of
AMR codecs inside the BTS. The function already works, but it does not
check the input data for consistancy. Lets add some consistancy check to
make sure that inconsistant parameters are rejected. Also allow the
output pointer to be NULL, so that the function can be used to perform
a dry run to be able to verify parameters.

- Check for invalid / inconsistant configuration parameters
- Perform a dry-run when lv pointer is set to NULL

Change-Id: I06beb7dd7236c81c3a91af4d09c31891f4b910a4
Related: OS#3529
---
M include/osmocom/bsc/gsm_04_08_rr.h
M src/osmo-bsc/gsm_04_08_rr.c
M tests/gsm0408/Makefile.am
M tests/gsm0408/gsm0408_test.c
M tests/gsm0408/gsm0408_test.ok
5 files changed, 234 insertions(+), 24 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/43/11443/1

diff --git a/include/osmocom/bsc/gsm_04_08_rr.h 
b/include/osmocom/bsc/gsm_04_08_rr.h
index e2e861d..8e4f787 100644
--- a/include/osmocom/bsc/gsm_04_08_rr.h
+++ b/include/osmocom/bsc/gsm_04_08_rr.h
@@ -23,7 +23,8 @@
 struct msgb *msg, struct bsc_subscr *bsub);
 int gsm48_send_rr_classmark_enquiry(struct gsm_lchan *lchan);
 int gsm48_send_rr_ciph_mode(struct gsm_lchan *lchan, int want_imeisv);
-int gsm48_multirate_config(uint8_t *lv, const struct amr_multirate_conf *mr, 
const struct amr_mode *modes);
+int gsm48_multirate_config(uint8_t *lv, const struct gsm48_multi_rate_conf 
*mr_conf,
+  const struct amr_mode *modes, unsigned int 
num_modes);
 struct msgb *gsm48_make_ho_cmd(struct gsm_lchan *new_lchan, uint8_t 
power_command, uint8_t ho_ref);
 int gsm48_send_ho_cmd(struct gsm_lchan *old_lchan, struct gsm_lchan *new_lchan,
  uint8_t power_command, uint8_t ho_ref);
diff --git a/src/osmo-bsc/gsm_04_08_rr.c b/src/osmo-bsc/gsm_04_08_rr.c
index 35044a3..4659c1a 100644
--- a/src/osmo-bsc/gsm_04_08_rr.c
+++ b/src/osmo-bsc/gsm_04_08_rr.c
@@ -321,47 +321,113 @@
cd->arfcn_lo = bts->c0->arfcn & 0xff;
 }

-/*! \brief Encode a TS 04.08 multirate config LV according to 10.5.2.21aa
- *  \param[out] lv caller-allocated buffer of 7 bytes. First octet is IS length
- *  \param[in] mr multi-rate configuration to encode
- *  \param[in] modes array describing the AMR modes
- *  \returns 0 on success */
-int gsm48_multirate_config(uint8_t *lv, const struct amr_multirate_conf *mr, 
const struct amr_mode *modes)
+/*! \brief Encode a TS 04.08 multirate config LV according to 10.5.2.21aa.
+ *  \param[out] lv caller-allocated buffer of 7 bytes. First octet is is 
length.
+ *  \param[in] mr_conf multi-rate configuration to encode (selected modes).
+ *  \param[in] modes array describing the AMR modes.
+ *  \param[in] num_modes length of the modes array.
+ *  \returns 0 on success, -EINVAL on failure. */
+int gsm48_multirate_config(uint8_t *lv,
+  const struct gsm48_multi_rate_conf *mr_conf,
+  const struct amr_mode *modes, unsigned int num_modes)
 {
-   int num = 0, i;
+   int num = 0;
+   unsigned int i;
+   unsigned int k;
+   unsigned int m = 0;
+   bool mode_valid;
+   uint8_t *gsm48_ie = (uint8_t *) mr_conf;
+   const struct amr_mode *modes_selected[4];

+   /* Check if modes for consistency (order and duplicates) */
+   for (i = 0; i < num_modes; i++) {
+   if (i > 0 && modes[i - 1].mode > modes[i].mode) {
+   LOGP(DRR, LOGL_ERROR,
+"BUG: Multirate codec with inconsistant config 
(mode order).\n");
+   return -EINVAL;
+   }
+   if (i > 0 && modes[i - 1].mode == modes[i].mode) {
+   LOGP(DRR, LOGL_ERROR,
+"BUG: Multirate codec with inconsistant config 
(duplicate modes).\n");
+   return -EINVAL;
+   }
+   }
+
+   /* Check if the active set that is defined in mr_conf has at least one
+* mode but not more than 4 modes set */
for (i = 0; i < 8; i++) {
-   if (((mr->gsm48_ie[1] >> i) & 1))
+   if (((gsm48_ie[1] >> i) & 1))
num++;
}
if (num > 4) {
-   LOGP(DRR, LOGL_ERROR, "BUG: Using multirate codec with too "
-   "many modes in config.\n");
-   num = 4;
+   LOGP(DRR, LOGL_ERROR,
+"BUG: Multirate codec with too many modes in config.\n");
+   return -EINVAL;
}
if (num < 1) {
-   LOGP(DRR, LOGL_ERROR, "BUG: Using

Change in osmo-bsc[master]: gsm_data: set meaningful default values for amr modes

2018-10-23 Thread dexter 
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/11441


Change subject: gsm_data: set meaningful default values for amr modes
..

gsm_data: set meaningful default values for amr modes

The function gsm_bts_alloc() does set default values for the amr rates
for a newly allocated bts, but it does not populate the ms_mode and
bts_mode flags which contain hysteresis and threshold. Those values are
currently set to 0 by default, which does not make much sense. Lets
popluate some appropriate default values.

- Make sure that .mode .hysteresis and .threshold are populated for
  MS and BTS in full and halfrate

Change-Id: If14843fa6584e5991d5c0abb765611dfaa57
Related: OS#3529
---
M src/osmo-bsc/gsm_data.c
1 file changed, 30 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/41/11441/1

diff --git a/src/osmo-bsc/gsm_data.c b/src/osmo-bsc/gsm_data.c
index 8d0b831..08d5bcb 100644
--- a/src/osmo-bsc/gsm_data.c
+++ b/src/osmo-bsc/gsm_data.c
@@ -900,6 +900,21 @@
.m12_2 = 1
};
memcpy(bts->mr_full.gsm48_ie, _cfg, sizeof(bts->mr_full.gsm48_ie));
+   bts->mr_full.ms_mode[0].mode = 1;
+   bts->mr_full.ms_mode[1].mode = 2;
+   bts->mr_full.ms_mode[2].mode = 6;
+   bts->mr_full.ms_mode[3].mode = 7;
+   bts->mr_full.bts_mode[0].mode = 1;
+   bts->mr_full.bts_mode[1].mode = 2;
+   bts->mr_full.bts_mode[2].mode = 6;
+   bts->mr_full.bts_mode[3].mode = 7;
+   for (i = 0; i < 3; i++) {
+   bts->mr_full.ms_mode[i].hysteresis = 8;
+   bts->mr_full.ms_mode[i].threshold = 32;
+   bts->mr_full.bts_mode[i].hysteresis = 8;
+   bts->mr_full.bts_mode[i].threshold = 32;
+   }
+   bts->mr_full.num_modes = 4;

mr_cfg = (struct gsm48_multi_rate_conf) {
.m4_75 = 0,
@@ -912,6 +927,21 @@
.m12_2 = 0
};
memcpy(bts->mr_half.gsm48_ie, _cfg, sizeof(bts->mr_half.gsm48_ie));
+   bts->mr_half.ms_mode[0].mode = 1;
+   bts->mr_half.ms_mode[1].mode = 2;
+   bts->mr_half.ms_mode[2].mode = 4;
+   bts->mr_half.ms_mode[3].mode = 5;
+   bts->mr_half.bts_mode[0].mode = 1;
+   bts->mr_half.bts_mode[1].mode = 2;
+   bts->mr_half.bts_mode[2].mode = 4;
+   bts->mr_half.bts_mode[3].mode = 5;
+   for (i = 0; i < 3; i++) {
+   bts->mr_half.ms_mode[i].hysteresis = 8;
+   bts->mr_half.ms_mode[i].threshold = 32;
+   bts->mr_half.bts_mode[i].hysteresis = 8;
+   bts->mr_half.bts_mode[i].threshold = 32;
+   }
+   bts->mr_half.num_modes = 4;

return bts;
 }

--
To view, visit https://gerrit.osmocom.org/11441
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If14843fa6584e5991d5c0abb765611dfaa57
Gerrit-Change-Number: 11441
Gerrit-PatchSet: 1
Gerrit-Owner: dexter

Build failed in Jenkins: master-asn1c » a1=default,a2=default,a3=default,osmocom-master-debian9 #285

2018-10-23 Thread jenkins 
See 


--
[...truncated 3.67 KB...]

+ ./configure
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking target system type... x86_64-unknown-linux-gnu
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether to enable maintainer-specific portions of Makefiles... no
checking for style of include used by make... GNU
checking for gcc... gcc
checking for C compiler default output file name... a.out
checking whether the C compiler works... yes
checking whether we are cross compiling... no
checking for suffix of executables... 
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking dependency style of gcc... gcc3
checking for a sed that does not truncate output... /bin/sed
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for /usr/bin/ld option to reload object files... -r
checking for BSD-compatible nm... /usr/bin/nm -B
checking whether ln -s works... yes
checking how to recognise dependent libraries... pass_all
checking how to run the C preprocessor... gcc -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking dlfcn.h usability... yes
checking dlfcn.h presence... yes
checking for dlfcn.h... yes
checking for g++... g++
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking dependency style of g++... gcc3
checking how to run the C++ preprocessor... g++ -E
checking for g77... no
checking for f77... no
checking for xlf... no
checking for frt... no
checking for pgf77... no
checking for cf77... no
checking for fort77... no
checking for fl32... no
checking for af77... no
checking for f90... no
checking for xlf90... no
checking for pgf90... no
checking for pghpf... no
checking for epcf90... no
checking for gfortran... no
checking for g95... no
checking for f95... no
checking for fort... no
checking for xlf95... no
checking for ifort... no
checking for ifc... no
checking for efc... no
checking for pgf95... no
checking for lf95... no
checking for ftn... no
checking whether we are using the GNU Fortran 77 compiler... no
checking whether  accepts -g... no
checking the maximum length of command line arguments... 32768
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for objdir... .libs
checking for ar... ar
checking for ranlib... ranlib
checking for strip... strip
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC
checking if gcc PIC flag -fPIC works... yes
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... yes
configure: creating libtool
appending configuration tag "CXX" to libtool
checking for ld used by g++... /usr/bin/ld -m elf_x86_64
checking if the linker (/usr/bin/ld -m elf_x86_64) is GNU ld... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking for g++ option to produce PIC... -fPIC
checking if g++ PIC flag -fPIC works... yes
checking if g++ static flag -static works... yes
checking if g++ supports -c -o file.o... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
appending configuration tag "F77" to libtool
checking for autoconf... /usr/bin/autoconf
checking for autoheader... /usr/bin/autoheader
checking for gcc... (cached) gcc
checking whether we are using the GNU C compiler... (cached) yes
checking whether gcc accepts -g... (cached) yes
checking for gcc option to accept ISO C89... (cached) none needed
checking

Change in osmocom-bb[master]: mobile: display MS IMSI in vty

2018-10-23 Thread Max 
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11440


Change subject: mobile: display MS IMSI in vty
..

mobile: display MS IMSI in vty

Show IMSI in addition to IMEI when using 'show ms 1' command.

Change-Id: Id05f4f5f3416dcdb9ce2fd24f9360f5e6faaf654
---
M src/host/layer23/src/mobile/vty_interface.c
1 file changed, 3 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/40/11440/1

diff --git a/src/host/layer23/src/mobile/vty_interface.c 
b/src/host/layer23/src/mobile/vty_interface.c
index 12c32a5..1fb6e15 100644
--- a/src/host/layer23/src/mobile/vty_interface.c
+++ b/src/host/layer23/src/mobile/vty_interface.c
@@ -201,6 +201,9 @@
else
vty_out(vty, " IMEI generation: fixed%s", VTY_NEWLINE);

+   if (ms->settings.test_imsi)
+   vty_out(vty, "  IMSI: %s%s", ms->settings.test_imsi, 
VTY_NEWLINE);
+
if (ms->shutdown != MS_SHUTDOWN_NONE)
return;


--
To view, visit https://gerrit.osmocom.org/11440
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id05f4f5f3416dcdb9ce2fd24f9360f5e6faaf654
Gerrit-Change-Number: 11440
Gerrit-PatchSet: 1
Gerrit-Owner: Max

Change in osmo-mgw[master]: use a dynamic name for rtp connection rate counters

2018-10-23 Thread Stefan Sperling 
Stefan Sperling has uploaded this change for review. ( 
https://gerrit.osmocom.org/11439


Change subject: use a dynamic name for rtp connection rate counters
..

use a dynamic name for rtp connection rate counters

Before this change, when running 'show rate-counters' on the VTY,
rate counters groups for all RTP connections shared the same static
name "rtp connection statistics". This made it impossible to discern
which connection an RTP counter group applied to.

Instead, allocate a fresh copy of rate counter descriptions for each
RTP connection and use a connection-specific label for the rate counter
group which includes the internal connection ID, the endpoint number,
and the callid.

Example of the new rate counter group naming scheme:
"rtp statistics for connection 5E7B20AF, endpoint:0x2, callid '1226'"

With input from Philipp Maier.

Change-Id: I027644f4b913e1f966c11b081e9027e61591a224
Related: OS#2660
---
M src/libosmo-mgcp/mgcp_conn.c
1 file changed, 12 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/39/11439/1

diff --git a/src/libosmo-mgcp/mgcp_conn.c b/src/libosmo-mgcp/mgcp_conn.c
index 820c63a..dd3c64c 100644
--- a/src/libosmo-mgcp/mgcp_conn.c
+++ b/src/libosmo-mgcp/mgcp_conn.c
@@ -43,7 +43,7 @@

 const static struct rate_ctr_group_desc rate_ctr_group_desc = {
.group_name_prefix = "conn_rtp",
-   .group_description = "rtp connection statistics",
+   .group_description = "rtp statistics",
.class_id = 1,
.num_ctr = ARRAY_SIZE(rate_ctr_desc),
.ctr_desc = rate_ctr_desc
@@ -94,6 +94,8 @@
 static void mgcp_rtp_conn_init(struct mgcp_conn_rtp *conn_rtp, struct 
mgcp_conn *conn)
 {
struct mgcp_rtp_end *end = _rtp->end;
+   struct rate_ctr_group_desc *rate_ctrs;
+
/* FIXME: Each new rate counter group requires an unique index. At the
 * moment we generate this index using this counter, but perhaps there
 * is a more concious way to assign the indexes. */
@@ -117,7 +119,15 @@
end->output_enabled = 0;
end->maximum_packet_time = -1;

-   conn_rtp->rate_ctr_group = rate_ctr_group_alloc(conn, 
_ctr_group_desc, rate_ctr_index);
+   rate_ctrs = talloc(conn, struct rate_ctr_group_desc);
+   OSMO_ASSERT(rate_ctrs);
+   memcpy(rate_ctrs, _ctr_group_desc, sizeof(*rate_ctrs));
+   rate_ctrs->group_description = talloc_asprintf(conn, "%s for connection 
%s, endpoint:0x%x, callid '%s'",
+  
rate_ctr_group_desc.group_description, conn->id,
+  
ENDPOINT_NUMBER(conn->endp), conn->endp->callid);
+   OSMO_ASSERT(rate_ctrs->group_description);
+   conn_rtp->rate_ctr_group = rate_ctr_group_alloc(conn, rate_ctrs, 
rate_ctr_index);
+   OSMO_ASSERT(conn_rtp->rate_ctr_group);
conn_rtp->state.in_stream.err_ts_ctr = 
_rtp->rate_ctr_group->ctr[IN_STREAM_ERR_TSTMP_CTR];
conn_rtp->state.out_stream.err_ts_ctr = 
_rtp->rate_ctr_group->ctr[OUT_STREAM_ERR_TSTMP_CTR];
rate_ctr_index++;

--
To view, visit https://gerrit.osmocom.org/11439
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I027644f4b913e1f966c11b081e9027e61591a224
Gerrit-Change-Number: 11439
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling

Change in osmo-bsc[master]: cipher mode reject: send proper cause codes

2018-10-23 Thread osmith 
osmith has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/11438 )

Change subject: cipher mode reject: send proper cause codes
..

cipher mode reject: send proper cause codes

bssmap_handle_cipher_mode() had code paths doing "goto reject" without
setting a meaningful cause value.

Related: OS#3186
Change-Id: Ia608fa34a6a2d3035a66d05fbc38553ac5186804
---
M src/osmo-bsc/osmo_bsc_bssap.c
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/38/11438/2
--
To view, visit https://gerrit.osmocom.org/11438
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia608fa34a6a2d3035a66d05fbc38553ac5186804
Gerrit-Change-Number: 11438
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-CC: Jenkins Builder (102)

Change in osmo-bsc[master]: cosmetic: fix spec ref for gsm0808_cipher_mode()

2018-10-23 Thread osmith 
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11437


Change subject: cosmetic: fix spec ref for gsm0808_cipher_mode()
..

cosmetic: fix spec ref for gsm0808_cipher_mode()

Change-Id: I359caf1dd30f033c0b606040ccf27aa4c5a9d2c6
---
M src/osmo-bsc/osmo_bsc_bssap.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/37/11437/1

diff --git a/src/osmo-bsc/osmo_bsc_bssap.c b/src/osmo-bsc/osmo_bsc_bssap.c
index a20d5d0..1e97f33 100644
--- a/src/osmo-bsc/osmo_bsc_bssap.c
+++ b/src/osmo-bsc/osmo_bsc_bssap.c
@@ -415,7 +415,7 @@
 }

 /*
- * GSM 08.08 § 3.4.7 cipher mode handling. We will have to pick
+ * GSM 04.08 § 3.4.7 cipher mode handling. We will have to pick
  * the cipher to be used for this. In case we are already using
  * a cipher we will have to send cipher mode reject to the MSC,
  * otherwise we will have to pick something that we and the MS

--
To view, visit https://gerrit.osmocom.org/11437
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I359caf1dd30f033c0b606040ccf27aa4c5a9d2c6
Gerrit-Change-Number: 11437
Gerrit-PatchSet: 1
Gerrit-Owner: osmith

Change in osmo-bsc[master]: cipher mode reject: send proper cause codes

2018-10-23 Thread osmith 
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11438


Change subject: cipher mode reject: send proper cause codes
..

cipher mode reject: send proper cause codes

bssmap_handle_cipher_mode() had code paths doing "goto reject" without setting
a meaningful cause value.

Related: OS#3186
Change-Id: Ia608fa34a6a2d3035a66d05fbc38553ac5186804
---
M src/osmo-bsc/osmo_bsc_bssap.c
1 file changed, 3 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/38/11438/1

diff --git a/src/osmo-bsc/osmo_bsc_bssap.c b/src/osmo-bsc/osmo_bsc_bssap.c
index 1e97f33..9419f56 100644
--- a/src/osmo-bsc/osmo_bsc_bssap.c
+++ b/src/osmo-bsc/osmo_bsc_bssap.c
@@ -444,6 +444,7 @@

if (conn->ciphering_handled) {
LOGP(DMSC, LOGL_ERROR, "Already seen ciphering command. 
Protocol Error.\n");
+   reject_cause = GSM0808_CAUSE_PROTOCOL_ERROR_BETWEEN_BSS_AND_MSC;
goto reject;
}

@@ -452,6 +453,7 @@
tlv_parse(, gsm0808_att_tlvdef(), msg->l4h + 1, payload_length - 1, 
0, 0);
if (!TLVP_PRESENT(, GSM0808_IE_ENCRYPTION_INFORMATION)) {
LOGP(DMSC, LOGL_ERROR, "IE Encryption Information missing.\n");
+   reject_cause = 
GSM0808_CAUSE_INFORMATION_ELEMENT_OR_FIELD_MISSING;
goto reject;
}

@@ -464,6 +466,7 @@
len = TLVP_LEN(, GSM0808_IE_ENCRYPTION_INFORMATION);
if (len < 1) {
LOGP(DMSC, LOGL_ERROR, "IE Encryption Information is too 
short.\n");
+   reject_cause = GSM0808_CAUSE_INCORRECT_VALUE;
goto reject;
}


--
To view, visit https://gerrit.osmocom.org/11438
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia608fa34a6a2d3035a66d05fbc38553ac5186804
Gerrit-Change-Number: 11438
Gerrit-PatchSet: 1
Gerrit-Owner: osmith

Change in docker-playground[master]: repo-install-test: version test for all programs

2018-10-23 Thread osmith 
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11436


Change subject: repo-install-test: version test for all programs
..

repo-install-test: version test for all programs

We did not test all programs before, because they did not have
--version implemented. Now they do.

Related: OS#3555
Change-Id: I796f1e34d2c026b11dff89511b667fa457856088
---
M debian-repo-install-test/testdata/repo-install-test.sh
1 file changed, 6 insertions(+), 7 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/docker-playground 
refs/changes/36/11436/1

diff --git a/debian-repo-install-test/testdata/repo-install-test.sh 
b/debian-repo-install-test/testdata/repo-install-test.sh
index 3ef88e8..f45908b 100755
--- a/debian-repo-install-test/testdata/repo-install-test.sh
+++ b/debian-repo-install-test/testdata/repo-install-test.sh
@@ -66,17 +66,13 @@
 }

 test_binaries() {
-   # Make sure the binaries are not broken (run -h or --version)
-   osmo-gtphub -h
-   osmo-sip-connector -h
-   osmo-trx-uhd -h
-   osmo-trx-usrp1 -h
-
+   # Make sure that binares run at all and output a proper version
test_binaries_version \
osmo-bsc \
osmo-bts-trx \
osmo-bts-virtual \
osmo-gbproxy \
+   osmo-gtphub \
osmo-ggsn \
osmo-hlr \
osmo-hlr-db-tool \
@@ -85,7 +81,10 @@
osmo-msc \
osmo-pcu \
osmo-sgsn \
-   osmo-stp
+   osmo-sip-connector \
+   osmo-stp \
+   osmo-trx-uhd \
+   osmo-trx-usrp1
 }

 finish() {

--
To view, visit https://gerrit.osmocom.org/11436
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I796f1e34d2c026b11dff89511b667fa457856088
Gerrit-Change-Number: 11436
Gerrit-PatchSet: 1
Gerrit-Owner: osmith

Change in osmo-trx[master]: Add long parameters (--help, --version, ...)

2018-10-23 Thread osmith 
osmith has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11435 )

Change subject: Add long parameters (--help, --version, ...)
..

Add long parameters (--help, --version, ...)

Makes osmo-trx-* more consistent with other Osmocom programs, and
allows an unified test for not having "UNKNOWN" in --version.

Related: OS#3578
Change-Id: I90cf01d972aa10b48c59b67a1e7f82a4255ef526
---
M Transceiver52M/osmo-trx.cpp
1 file changed, 12 insertions(+), 4 deletions(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, approved
  osmith: Verified



diff --git a/Transceiver52M/osmo-trx.cpp b/Transceiver52M/osmo-trx.cpp
index 7f72c47..b6b676e 100644
--- a/Transceiver52M/osmo-trx.cpp
+++ b/Transceiver52M/osmo-trx.cpp
@@ -27,6 +27,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -211,9 +212,9 @@
 static void print_help()
 {
fprintf(stdout, "Options:\n"
-   "  -hThis text\n"
-   "  -CFilename The config file to use\n"
-   "  -VPrint the version of OsmoTRX\n"
+   "  -h, --help  This text\n"
+   "  -C, --configFilename The config file to use\n"
+   "  -V, --version   Print the version of OsmoTRX\n"
);
 }

@@ -230,8 +231,15 @@
unsigned int i;
std::vector rx_paths, tx_paths;
bool rx_paths_set = false, tx_paths_set = false;
+   static struct option long_options[] = {
+   {"help", 0, 0, 'h'},
+   {"config", 1, 0, 'C'},
+   {"version", 0, 0, 'V'},
+   {NULL, 0, 0, 0}
+   };

-   while ((option = getopt(argc, argv, 
"ha:l:i:j:p:c:dmxgfo:s:b:r:A:R:Set:y:z:C:V")) != -1) {
+   while ((option = getopt_long(argc, argv, 
"ha:l:i:j:p:c:dmxgfo:s:b:r:A:R:Set:y:z:C:V", long_options,
+   NULL)) != -1) {
switch (option) {
case 'h':
print_help();

--
To view, visit https://gerrit.osmocom.org/11435
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I90cf01d972aa10b48c59b67a1e7f82a4255ef526
Gerrit-Change-Number: 11435
Gerrit-PatchSet: 3
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: osmith

Change in osmo-trx[master]: Add long parameters (--help, --version, ...)

2018-10-23 Thread osmith 
osmith has posted comments on this change. ( https://gerrit.osmocom.org/11435 )

Change subject: Add long parameters (--help, --version, ...)
..


Patch Set 2: Verified+1


--
To view, visit https://gerrit.osmocom.org/11435
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I90cf01d972aa10b48c59b67a1e7f82a4255ef526
Gerrit-Change-Number: 11435
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Tue, 23 Oct 2018 11:34:41 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-trx[master]: Add long parameters (--help, --version, ...)

2018-10-23 Thread Pau Espin Pedrol 
Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11435 )

Change subject: Add long parameters (--help, --version, ...)
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11435
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I90cf01d972aa10b48c59b67a1e7f82a4255ef526
Gerrit-Change-Number: 11435
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Tue, 23 Oct 2018 11:34:29 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-trx[master]: Add long parameters (--help, --version, ...)

2018-10-23 Thread osmith 
osmith has posted comments on this change. ( https://gerrit.osmocom.org/11435 )

Change subject: Add long parameters (--help, --version, ...)
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/11435/1/Transceiver52M/osmo-trx.cpp
File Transceiver52M/osmo-trx.cpp:

https://gerrit.osmocom.org/#/c/11435/1/Transceiver52M/osmo-trx.cpp@236
PS1, Line 236:  {"config-file", 1, 0, 'C'},
> why config above and config-file here?
Copy paste mistake from osmo-sip-connector. Fixed now, thanks!



--
To view, visit https://gerrit.osmocom.org/11435
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I90cf01d972aa10b48c59b67a1e7f82a4255ef526
Gerrit-Change-Number: 11435
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Tue, 23 Oct 2018 11:33:25 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-trx[master]: Add long parameters (--help, --version, ...)

2018-10-23 Thread osmith 
Hello Pau Espin Pedrol, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11435

to look at the new patch set (#2).

Change subject: Add long parameters (--help, --version, ...)
..

Add long parameters (--help, --version, ...)

Makes osmo-trx-* more consistent with other Osmocom programs, and
allows an unified test for not having "UNKNOWN" in --version.

Related: OS#3578
Change-Id: I90cf01d972aa10b48c59b67a1e7f82a4255ef526
---
M Transceiver52M/osmo-trx.cpp
1 file changed, 12 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/35/11435/2
--
To view, visit https://gerrit.osmocom.org/11435
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I90cf01d972aa10b48c59b67a1e7f82a4255ef526
Gerrit-Change-Number: 11435
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol

Change in osmo-trx[master]: Add long parameters (--help, --version, ...)

2018-10-23 Thread Pau Espin Pedrol 
Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11435 )

Change subject: Add long parameters (--help, --version, ...)
..


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/11435/1/Transceiver52M/osmo-trx.cpp
File Transceiver52M/osmo-trx.cpp:

https://gerrit.osmocom.org/#/c/11435/1/Transceiver52M/osmo-trx.cpp@236
PS1, Line 236:  {"config-file", 1, 0, 'C'},
why config above and config-file here?



--
To view, visit https://gerrit.osmocom.org/11435
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I90cf01d972aa10b48c59b67a1e7f82a4255ef526
Gerrit-Change-Number: 11435
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Tue, 23 Oct 2018 11:28:35 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in osmo-trx[master]: Add long parameters (--help, --version, ...)

2018-10-23 Thread Pau Espin Pedrol 
Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11435 )

Change subject: Add long parameters (--help, --version, ...)
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11435
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I90cf01d972aa10b48c59b67a1e7f82a4255ef526
Gerrit-Change-Number: 11435
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Tue, 23 Oct 2018 11:27:59 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-trx[master]: Add long parameters (--help, --version, ...)

2018-10-23 Thread osmith 
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11435


Change subject: Add long parameters (--help, --version, ...)
..

Add long parameters (--help, --version, ...)

Makes osmo-trx-* more consistent with other Osmocom programs, and
allows an unified test for not having "UNKNOWN" in --version.

Related: OS#3578
Change-Id: I90cf01d972aa10b48c59b67a1e7f82a4255ef526
---
M Transceiver52M/osmo-trx.cpp
1 file changed, 12 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/35/11435/1

diff --git a/Transceiver52M/osmo-trx.cpp b/Transceiver52M/osmo-trx.cpp
index d01a4cf..1caa225 100644
--- a/Transceiver52M/osmo-trx.cpp
+++ b/Transceiver52M/osmo-trx.cpp
@@ -27,6 +27,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -211,9 +212,9 @@
 static void print_help()
 {
fprintf(stdout, "Options:\n"
-   "  -hThis text\n"
-   "  -CFilename The config file to use\n"
-   "  -VPrint the version of OsmoTRX\n"
+   "  -h, --help  This text\n"
+   "  -C, --configFilename The config file to use\n"
+   "  -V, --version   Print the version of OsmoTRX\n"
);
 }

@@ -230,8 +231,15 @@
unsigned int i;
std::vector rx_paths, tx_paths;
bool rx_paths_set = false, tx_paths_set = false;
+   static struct option long_options[] = {
+   {"help", 0, 0, 'h'},
+   {"config-file", 1, 0, 'C'},
+   {"version", 0, 0, 'V' },
+   {NULL, 0, 0, 0}
+   };

-   while ((option = getopt(argc, argv, 
"ha:l:i:j:p:c:dmxgfo:s:b:r:A:R:Set:y:z:C:V")) != -1) {
+   while ((option = getopt_long(argc, argv, 
"ha:l:i:j:p:c:dmxgfo:s:b:r:A:R:Set:y:z:C:V", long_options,
+   NULL)) != -1) {
switch (option) {
case 'h':
print_help();

--
To view, visit https://gerrit.osmocom.org/11435
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I90cf01d972aa10b48c59b67a1e7f82a4255ef526
Gerrit-Change-Number: 11435
Gerrit-PatchSet: 1
Gerrit-Owner: osmith

Change in osmo-dev[master]: gen_makefile.py: detect changes in cpp files

2018-10-23 Thread osmith 
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11434


Change subject: gen_makefile.py: detect changes in cpp files
..

gen_makefile.py: detect changes in cpp files

Properly rebuild when cpp files (e.g. from osmo-trx) have been changed.

Change-Id: I9382d984fa1988eefbb6be3e45d88b2f1f5b598a
---
M gen_makefile.py
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/34/11434/1

diff --git a/gen_makefile.py b/gen_makefile.py
index c2b6128..1ae29f5 100755
--- a/gen_makefile.py
+++ b/gen_makefile.py
@@ -168,7 +168,7 @@
 ### {proj} ###

 {proj}_configure_files := $(shell find {src_proj} -name "Makefile.am" -or 
-name "*.in" )
-{proj}_files := $(shell find {src_proj} -name "*.[hc]" -or -name "*.py" )
+{proj}_files := $(shell find {src_proj} -name "*.[hc]" -or -name "*.py" -or 
-name "*.cpp" )

 .make.{proj}.clone:
@echo "\n\n\n= $@\n"

--
To view, visit https://gerrit.osmocom.org/11434
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9382d984fa1988eefbb6be3e45d88b2f1f5b598a
Gerrit-Change-Number: 11434
Gerrit-PatchSet: 1
Gerrit-Owner: osmith

Change in osmo-ttcn3-hacks[master]: library/TRXC_Types.ttcn: correct FAKE_RSSI command template

2018-10-23 Thread Pau Espin Pedrol 
Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11433 )

Change subject: library/TRXC_Types.ttcn: correct FAKE_RSSI command template
..

library/TRXC_Types.ttcn: correct FAKE_RSSI command template

Absolute form of FAKE_RSSI command shall contain an optional
threshold value. Otherwise it's interpreted as relative form.

Change-Id: Ief89b2601277488bb1782b981aff1061ddaa6637
---
M library/TRXC_Types.ttcn
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/library/TRXC_Types.ttcn b/library/TRXC_Types.ttcn
index 1a37a8c..77666d9 100644
--- a/library/TRXC_Types.ttcn
+++ b/library/TRXC_Types.ttcn
@@ -58,10 +58,10 @@
 external function dec_TrxcMessage(in charstring id) return TrxcMessage
with { extension "prototype(convert) decode(TEXT)" };

-template (value) TrxcMessage ts_TRXC_FAKE_RSSI(uint8_t rssi) := {
+template (value) TrxcMessage ts_TRXC_FAKE_RSSI(uint8_t rssi, int16_t thresh := 
0) := {
cmd := {
verb := "FAKE_RSSI",
-   params := { int2str(rssi) }
+   params := { int2str(rssi), int2str(thresh) }
}
 }


--
To view, visit https://gerrit.osmocom.org/11433
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ief89b2601277488bb1782b981aff1061ddaa6637
Gerrit-Change-Number: 11433
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol

Change in osmocom-bb[master]: fake_trx: introduce CTRL commands for RSSI simulation

2018-10-23 Thread Pau Espin Pedrol 
Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11432 )

Change subject: fake_trx: introduce CTRL commands for RSSI simulation
..

fake_trx: introduce CTRL commands for RSSI simulation

Since FakeTRX is a proxy, it basically emulates transceiver for
both osmo-bts-trx and trxcon, hence there are two separate and
independent control interfaces (usually, ports 6701 and 5701).

All simulation commands (see 'FAKE_*') are usually implemented
on both interfaces separately:

  - ctrl_if_bb.py - simulation commands affecting Uplink,
  - ctrl_if_bts.py - simulation commands affecting Downlink.

This change introduces the 'FAKE_RSSI' command for both CTRL
interfaces in two variations:

  - absolute: CMD FAKE_RSSI  
  - relative: CMD FAKE_RSSI <+-BASE_DELTA>

where 'THRESH' affects optional value randomization.

Change-Id: Ic01c31fb0304345dd7337c3ee1c7ee3c2d3e8460
---
M src/target/trx_toolkit/ctrl_if_bb.py
M src/target/trx_toolkit/ctrl_if_bts.py
2 files changed, 42 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Pau Espin Pedrol: Looks good to me, approved



diff --git a/src/target/trx_toolkit/ctrl_if_bb.py 
b/src/target/trx_toolkit/ctrl_if_bb.py
index 808c880..3528c98 100644
--- a/src/target/trx_toolkit/ctrl_if_bb.py
+++ b/src/target/trx_toolkit/ctrl_if_bb.py
@@ -144,6 +144,27 @@

return 0

+   # RSSI simulation for Uplink
+   # Absolute form: CMD FAKE_RSSI  
+   elif self.verify_cmd(request, "FAKE_RSSI", 2):
+   print("[i] Recv FAKE_RSSI cmd")
+
+   # Parse and apply both base and threshold
+   self.burst_fwd.rssi_ul_base = int(request[1])
+   self.burst_fwd.rssi_ul_threshold = int(request[2])
+
+   return 0
+
+   # RSSI simulation for Uplink
+   # Relative form: CMD FAKE_RSSI <+-BASE_DELTA>
+   elif self.verify_cmd(request, "FAKE_RSSI", 1):
+   print("[i] Recv FAKE_RSSI cmd")
+
+   # Parse and apply delta
+   self.burst_fwd.rssi_ul_base += int(request[1])
+
+   return 0
+
# Path loss simulation for UL: burst dropping
# Syntax: CMD FAKE_DROP 
# Dropping pattern: fn % 1 == 0
diff --git a/src/target/trx_toolkit/ctrl_if_bts.py 
b/src/target/trx_toolkit/ctrl_if_bts.py
index 72a0371..6ac8ffb 100644
--- a/src/target/trx_toolkit/ctrl_if_bts.py
+++ b/src/target/trx_toolkit/ctrl_if_bts.py
@@ -118,6 +118,27 @@

return 0

+   # RSSI simulation for Downlink
+   # Absolute form: CMD FAKE_RSSI  
+   elif self.verify_cmd(request, "FAKE_RSSI", 2):
+   print("[i] Recv FAKE_RSSI cmd")
+
+   # Parse and apply both base and threshold
+   self.burst_fwd.rssi_dl_base = int(request[1])
+   self.burst_fwd.rssi_dl_threshold = int(request[2])
+
+   return 0
+
+   # RSSI simulation for Downlink
+   # Relative form: CMD FAKE_RSSI <+-BASE_DELTA>
+   elif self.verify_cmd(request, "FAKE_RSSI", 1):
+   print("[i] Recv FAKE_RSSI cmd")
+
+   # Parse and apply delta
+   self.burst_fwd.rssi_dl_base += int(request[1])
+
+   return 0
+
# Path loss simulation for DL: burst dropping
# Syntax: CMD FAKE_DROP 
# Dropping pattern: fn % 1 == 0

--
To view, visit https://gerrit.osmocom.org/11432
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic01c31fb0304345dd7337c3ee1c7ee3c2d3e8460
Gerrit-Change-Number: 11432
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Vadim Yanitskiy

Change in docker-playground[master]: ttcn3-bts-test: Log fake_trx output to file

2018-10-23 Thread Pau Espin Pedrol 
Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11431 )

Change subject: ttcn3-bts-test: Log fake_trx output to file
..


Patch Set 1: Verified+1


--
To view, visit https://gerrit.osmocom.org/11431
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I82a80b045e6f298e5254f42f51dbf8c84013f45c
Gerrit-Change-Number: 11431
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-CC: Vadim Yanitskiy 
Gerrit-Comment-Date: Tue, 23 Oct 2018 10:41:15 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: bts: Introduce mp_ul_rxlev_exp and use mp_rxlev_exp to craft meas rep

2018-10-23 Thread Pau Espin Pedrol 
Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11430 )

Change subject: bts: Introduce mp_ul_rxlev_exp and use mp_rxlev_exp to craft 
meas rep
..

bts: Introduce mp_ul_rxlev_exp and use mp_rxlev_exp to craft meas rep

Change-Id: I1c8f05bde6f9dc8e8a649e877209192d829dd923
---
M bts/BTS_Tests.ttcn
1 file changed, 5 insertions(+), 6 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index 2f48b0f..a2d4ca4 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -58,6 +58,7 @@
integer mp_tolerance_rxlev := 3;
integer mp_tolerance_timing_offset_256syms := 0;
integer mp_rxlev_exp := 57;
+   integer mp_ul_rxlev_exp := 10;
integer mp_ms_power_level_exp := 7;
integer mp_ms_actual_ta_exp := 0;
integer mp_timing_offset_256syms_exp := 512;
@@ -518,11 +519,11 @@
toa256_enabled := false,
meas_ul := {
full := {
-   rxlev := dbm2rxlev(-53),
+   rxlev := mp_ul_rxlev_exp,
rxqual := 0
},
sub := {
-   rxlev := dbm2rxlev(-53),
+   rxlev := mp_ul_rxlev_exp,
rxqual := 0
}
},
@@ -1162,7 +1163,7 @@
var L1ctlDlMessage l1_dl;
[] L1CTL.receive(tr_L1CTL_DATA_IND(g_chan_nr, tr_RslLinkID_SACCH(?))) 
-> value l1_dl {
log("SACCH received: ", l1_dl.payload.data_ind.payload);
-   var GsmRrL3Message meas_rep := valueof(ts_MEAS_REP(true, 23, 
23, 0, 0, omit));
+   var GsmRrL3Message meas_rep := valueof(ts_MEAS_REP(true, 
mp_rxlev_exp, mp_rxlev_exp, 0, 0, omit));
var LapdmFrameAB lb := valueof(ts_LAPDm_AB(0, false, false, 
enc_GsmRrL3Message(meas_rep)));
log("LAPDm: ", lb);

@@ -1405,10 +1406,8 @@
f_l1_tune(L1CTL);
RSL.clear;

-   g_pars.l1_pars.meas_ul.full.rxlev := dbm2rxlev(-100);
-   g_pars.l1_pars.meas_ul.sub.rxlev := g_pars.l1_pars.meas_ul.full.rxlev;
if (mp_bb_trxc_port != -1) {
-   f_trxc_fake_rssi(100);
+   f_trxc_fake_rssi(rxlev2dbm(mp_ul_rxlev_exp));
f_trx_fake_toffs256(g_pars.l1_pars.timing_offset_256syms);
}


--
To view, visit https://gerrit.osmocom.org/11430
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1c8f05bde6f9dc8e8a649e877209192d829dd923
Gerrit-Change-Number: 11430
Gerrit-PatchSet: 4
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Reviewer: fixeria

Change in osmo-ttcn3-hacks[master]: bts: Disable testing FACCH/H with real HW

2018-10-23 Thread Pau Espin Pedrol 
Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11428 )

Change subject: bts: Disable testing FACCH/H with real HW
..

bts: Disable testing FACCH/H with real HW

Temporary disable testing on FACCH/H because Calypso PHY is not stable.
Otherwise some tests fail half of the time due to this unstability.

Related: OS#3653
Change-Id: I078cdfbf8d27e543a723eab90f66b2fcda016b5d
---
M bts/BTS_Tests.ttcn
1 file changed, 22 insertions(+), 10 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index a2d4ca4..fe0a933 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -313,17 +313,29 @@
valueof(ts_RslChanNr_SDCCH8(6,4)), 
valueof(ts_RslChanNr_SDCCH8(6,5)),
valueof(ts_RslChanNr_SDCCH8(6,6)), 
valueof(ts_RslChanNr_SDCCH8(6,7))
};
-   g_AllChanTypes := {
-   /* TS 1..4: TCH/F */
-   valueof(ts_RslChanNr_Bm(1)),
-   /* TS 5: TCH/H */
-   valueof(ts_RslChanNr_Lm(5,1)),
-   /* TS 0: SDCCH/4 */
-   valueof(ts_RslChanNr_SDCCH4(0,2)),
-   /* TS 6: SDCCH/8 */
-   valueof(ts_RslChanNr_SDCCH8(6,4))
-   };

+   /* FIXME: FACCH/H is unreliable with calypso firmware, see OS#3653 */
+   if (mp_bb_trxc_port != -1) {
+   g_AllChanTypes := {
+   /* TS 1..4: TCH/F */
+   valueof(ts_RslChanNr_Bm(1)),
+   /* TS 5: TCH/H */
+   valueof(ts_RslChanNr_Lm(5,1)),
+   /* TS 0: SDCCH/4 */
+   valueof(ts_RslChanNr_SDCCH4(0,2)),
+   /* TS 6: SDCCH/8 */
+   valueof(ts_RslChanNr_SDCCH8(6,4))
+   };
+   } else {
+   g_AllChanTypes := {
+   /* TS 1..4: TCH/F */
+   valueof(ts_RslChanNr_Bm(1)),
+   /* TS 0: SDCCH/4 */
+   valueof(ts_RslChanNr_SDCCH4(0,2)),
+   /* TS 6: SDCCH/8 */
+   valueof(ts_RslChanNr_SDCCH8(6,4))
+   };
+   }
f_init_rsl(id);
T.start;
alt {

--
To view, visit https://gerrit.osmocom.org/11428
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I078cdfbf8d27e543a723eab90f66b2fcda016b5d
Gerrit-Change-Number: 11428
Gerrit-PatchSet: 3
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Vadim Yanitskiy

Change in docker-playground[master]: ttcn3-bts-test: Log fake_trx output to file

2018-10-23 Thread Pau Espin Pedrol 
Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11431 )

Change subject: ttcn3-bts-test: Log fake_trx output to file
..


Patch Set 1:

> Just wondering, why do we need that?

You could extend that to why do we need logging in general in any software 
component ;)

I used it to see log from fake_trx to understand how it behaved and was useful 
to add some prints during development of the FAKE_RSSI command. This way I 
don't need to do that next time, or if fake_trx starts failing for whatever 
reason we can check quickly why it fails.


--
To view, visit https://gerrit.osmocom.org/11431
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I82a80b045e6f298e5254f42f51dbf8c84013f45c
Gerrit-Change-Number: 11431
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-CC: Vadim Yanitskiy 
Gerrit-Comment-Date: Tue, 23 Oct 2018 10:29:47 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: library/TRXC_Types.ttcn: correct FAKE_RSSI command template

2018-10-23 Thread Pau Espin Pedrol 
Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11433 )

Change subject: library/TRXC_Types.ttcn: correct FAKE_RSSI command template
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11433
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief89b2601277488bb1782b981aff1061ddaa6637
Gerrit-Change-Number: 11433
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Tue, 23 Oct 2018 10:27:52 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in docker-playground[master]: ttcn3-bts-test: Log fake_trx output to file

2018-10-23 Thread Vadim Yanitskiy 
Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/11431 )

Change subject: ttcn3-bts-test: Log fake_trx output to file
..


Patch Set 1:

Just wondering, why do we need that?


--
To view, visit https://gerrit.osmocom.org/11431
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I82a80b045e6f298e5254f42f51dbf8c84013f45c
Gerrit-Change-Number: 11431
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-CC: Vadim Yanitskiy 
Gerrit-Comment-Date: Tue, 23 Oct 2018 09:14:39 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmocom-bb[master]: fake_trx: introduce CTRL commands for RSSI simulation

2018-10-23 Thread Pau Espin Pedrol 
Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11432 )

Change subject: fake_trx: introduce CTRL commands for RSSI simulation
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11432
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic01c31fb0304345dd7337c3ee1c7ee3c2d3e8460
Gerrit-Change-Number: 11432
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Tue, 23 Oct 2018 07:59:06 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmocom-bb[master]: fake_trx: introduce CTRL commands for RSSI simulation

2018-10-23 Thread Pau Espin Pedrol 
Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11432 )

Change subject: fake_trx: introduce CTRL commands for RSSI simulation
..


Patch Set 2: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/11432
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic01c31fb0304345dd7337c3ee1c7ee3c2d3e8460
Gerrit-Change-Number: 11432
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Tue, 23 Oct 2018 07:58:39 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes