Build failed in Jenkins: master-asn1c » a1=default,a2=default,a3=default,osmocom-master-debian9 #311

[jenkins]

See 


--
[...truncated 3.74 KB...]
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking target system type... x86_64-unknown-linux-gnu
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether to enable maintainer-specific portions of Makefiles... no
checking for style of include used by make... GNU
checking for gcc... gcc
checking for C compiler default output file name... a.out
checking whether the C compiler works... yes
checking whether we are cross compiling... no
checking for suffix of executables... 
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking dependency style of gcc... gcc3
checking for a sed that does not truncate output... /bin/sed
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for /usr/bin/ld option to reload object files... -r
checking for BSD-compatible nm... /usr/bin/nm -B
checking whether ln -s works... yes
checking how to recognise dependent libraries... pass_all
checking how to run the C preprocessor... gcc -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking dlfcn.h usability... yes
checking dlfcn.h presence... yes
checking for dlfcn.h... yes
checking for g++... g++
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking dependency style of g++... gcc3
checking how to run the C++ preprocessor... g++ -E
checking for g77... no
checking for f77... no
checking for xlf... no
checking for frt... no
checking for pgf77... no
checking for cf77... no
checking for fort77... no
checking for fl32... no
checking for af77... no
checking for f90... no
checking for xlf90... no
checking for pgf90... no
checking for pghpf... no
checking for epcf90... no
checking for gfortran... no
checking for g95... no
checking for f95... no
checking for fort... no
checking for xlf95... no
checking for ifort... no
checking for ifc... no
checking for efc... no
checking for pgf95... no
checking for lf95... no
checking for ftn... no
checking whether we are using the GNU Fortran 77 compiler... no
checking whether  accepts -g... no
checking the maximum length of command line arguments... 32768
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for objdir... .libs
checking for ar... ar
checking for ranlib... ranlib
checking for strip... strip
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC
checking if gcc PIC flag -fPIC works... yes
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... yes
configure: creating libtool
appending configuration tag "CXX" to libtool
checking for ld used by g++... /usr/bin/ld -m elf_x86_64
checking if the linker (/usr/bin/ld -m elf_x86_64) is GNU ld... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking for g++ option to produce PIC... -fPIC
checking if g++ PIC flag -fPIC works... yes
checking if g++ static flag -static works... yes
checking if g++ supports -c -o file.o... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
appending configuration tag "F77" to libtool
checking for autoconf... /usr/bin/autoconf
checking for autoheader... /usr/bin/autoheader
checking for gcc... (cached) gcc
checking whether we are using the GNU C compiler... (cached) yes
checking whether gcc accepts -g... (cached) yes
checking for gcc option to accept ISO C89... (cached) none needed
checking dependency style o

Change in osmocom-bb[master]: mobile: use proper type for boolean flags

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11817 )

Change subject: mobile: use proper type for boolean flags
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11817
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7eff2a61495ff167dc19fc9a41882a7a11fbf32d
Gerrit-Change-Number: 11817
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Sun, 18 Nov 2018 19:56:51 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: examples: Remove neighbor-list invalid for default setup

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11774 )

Change subject: examples: Remove neighbor-list invalid for default setup
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11774
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebe972da3a8442b6ded6d7f9e61a03b9144a843c
Gerrit-Change-Number: 11774
Gerrit-PatchSet: 3
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Sun, 18 Nov 2018 19:57:41 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmocom-bb[master]: mobile: add header for MS' MNCC functions

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11816 )

Change subject: mobile: add header for MS' MNCC functions
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11816
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibad400a99afe052f011f54fc706836b6bf89f4b9
Gerrit-Change-Number: 11816
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Sun, 18 Nov 2018 19:57:07 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: bsc: bts_alloc: Use enum value during neigh_list_manual_mode initiali...

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11775 )

Change subject: bsc: bts_alloc: Use enum value during neigh_list_manual_mode 
initialization
..

bsc: bts_alloc: Use enum value during neigh_list_manual_mode initialization

Change-Id: I6a4325d45de143d32db55df8e84282cc64800c9f
---
M src/osmo-bsc/gsm_data.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved



diff --git a/src/osmo-bsc/gsm_data.c b/src/osmo-bsc/gsm_data.c
index 15853fb..774238b 100644
--- a/src/osmo-bsc/gsm_data.c
+++ b/src/osmo-bsc/gsm_data.c
@@ -852,7 +852,7 @@
bts->dtxu = GSM48_DTX_SHALL_NOT_BE_USED;
bts->dtxd = false;
bts->gprs.ctrl_ack_type_use_block = true; /* use RLC/MAC control block 
*/
-   bts->neigh_list_manual_mode = 0;
+   bts->neigh_list_manual_mode = NL_MODE_AUTOMATIC;
bts->early_classmark_allowed_3g = true; /* 3g Early Classmark Sending 
controlled by bts->early_classmark_allowed param */
bts->si_common.cell_sel_par.cell_resel_hyst = 2; /* 4 dB */
bts->si_common.cell_sel_par.rxlev_acc_min = 0;

--
To view, visit https://gerrit.osmocom.org/11775
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6a4325d45de143d32db55df8e84282cc64800c9f
Gerrit-Change-Number: 11775
Gerrit-PatchSet: 3
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 

Change in osmo-bsc[master]: examples: Remove neighbor-list invalid for default setup

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11774 )

Change subject: examples: Remove neighbor-list invalid for default setup
..

examples: Remove neighbor-list invalid for default setup

In default example network, there's no cells with those arfcn.
Furthermore, having those seem to prevent some MS to register against
nanoBTS configured by a BSC using those lines.

Related: OS#3063
Change-Id: Iebe972da3a8442b6ded6d7f9e61a03b9144a843c
---
M doc/examples/osmo-bsc/osmo-bsc.cfg
M doc/examples/osmo-bsc/osmo-bsc_custom-sccp.cfg
2 files changed, 0 insertions(+), 10 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved



diff --git a/doc/examples/osmo-bsc/osmo-bsc.cfg 
b/doc/examples/osmo-bsc/osmo-bsc.cfg
index a1bc7e3..750b089 100644
--- a/doc/examples/osmo-bsc/osmo-bsc.cfg
+++ b/doc/examples/osmo-bsc/osmo-bsc.cfg
@@ -38,11 +38,6 @@
   early-classmark-sending forbidden
   ip.access unit_id 0 0
   oml ip.access stream_id 255 line 0
-  neighbor-list mode manual-si5
-  neighbor-list add arfcn 100
-  neighbor-list add arfcn 200
-  si5 neighbor-list add arfcn 10
-  si5 neighbor-list add arfcn 20
   codec-support fr
   gprs mode none
   no force-combined-si
diff --git a/doc/examples/osmo-bsc/osmo-bsc_custom-sccp.cfg 
b/doc/examples/osmo-bsc/osmo-bsc_custom-sccp.cfg
index 0666be3..d1b3678 100644
--- a/doc/examples/osmo-bsc/osmo-bsc_custom-sccp.cfg
+++ b/doc/examples/osmo-bsc/osmo-bsc_custom-sccp.cfg
@@ -37,11 +37,6 @@
   early-classmark-sending forbidden
   ip.access unit_id 0 0
   oml ip.access stream_id 255 line 0
-  neighbor-list mode manual-si5
-  neighbor-list add arfcn 100
-  neighbor-list add arfcn 200
-  si5 neighbor-list add arfcn 10
-  si5 neighbor-list add arfcn 20
   codec-support fr
   gprs mode none
   no force-combined-si

--
To view, visit https://gerrit.osmocom.org/11774
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iebe972da3a8442b6ded6d7f9e61a03b9144a843c
Gerrit-Change-Number: 11774
Gerrit-PatchSet: 3
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 

Change in osmo-bsc[master]: bsc: bts_alloc: Use enum value during neigh_list_manual_mode initiali...

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11775 )

Change subject: bsc: bts_alloc: Use enum value during neigh_list_manual_mode 
initialization
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11775
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a4325d45de143d32db55df8e84282cc64800c9f
Gerrit-Change-Number: 11775
Gerrit-PatchSet: 3
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Sun, 18 Nov 2018 19:57:53 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: bsc: vty: Use enum value in neighbor-list check

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11778 )

Change subject: bsc: vty: Use enum value in neighbor-list check
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11778
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c0b42bfed749f18b8ab2331475f3da35b02f456
Gerrit-Change-Number: 11778
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Sun, 18 Nov 2018 19:58:04 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: bsc: vty: Use enum value in neighbor-list check

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11778 )

Change subject: bsc: vty: Use enum value in neighbor-list check
..

bsc: vty: Use enum value in neighbor-list check

Change-Id: I7c0b42bfed749f18b8ab2331475f3da35b02f456
---
M src/osmo-bsc/bsc_vty.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved



diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c
index 9115c01..b9a5268 100644
--- a/src/osmo-bsc/bsc_vty.c
+++ b/src/osmo-bsc/bsc_vty.c
@@ -3112,7 +3112,7 @@
struct bitvec *bv = &bts->si_common.neigh_list;
uint16_t arfcn = atoi(argv[1]);

-   if (!bts->neigh_list_manual_mode) {
+   if (bts->neigh_list_manual_mode == NL_MODE_AUTOMATIC) {
vty_out(vty, "%% Cannot configure neighbor list in "
"automatic mode%s", VTY_NEWLINE);
return CMD_WARNING;

--
To view, visit https://gerrit.osmocom.org/11778
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7c0b42bfed749f18b8ab2331475f3da35b02f456
Gerrit-Change-Number: 11778
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 

Change in osmo-bsc[master]: bsc: band_compatible: Return band non-compatible for invalid arfcn

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11790 )

Change subject: bsc: band_compatible: Return band non-compatible for invalid 
arfcn
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11790
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf5d5ab50b6fc6597244eeedcd27d2ce245278a3
Gerrit-Change-Number: 11790
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-CC: Keith Whyte 
Gerrit-CC: Vadim Yanitskiy 
Gerrit-Comment-Date: Sun, 18 Nov 2018 19:58:35 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: bsc: vty: Verify and warn on invalid arfcn passed

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11791 )

Change subject: bsc: vty: Verify and warn on invalid arfcn passed
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11791
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib001501bf37289e824a1f72b62afde23892e88d2
Gerrit-Change-Number: 11791
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Sun, 18 Nov 2018 19:59:17 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: Update GSM0808_LCLS enums

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11678 )

Change subject: Update GSM0808_LCLS enums
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11678
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52dc6a52f5ee043ed2c1625ffecfd495e3c746b1
Gerrit-Change-Number: 11678
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sun, 18 Nov 2018 20:00:14 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: LCLS: move mode check into separate function

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11551 )

Change subject: LCLS: move mode check into separate function
..


Patch Set 6: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11551
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I32ba232ad802625d97a0ad9d0511edc6ac7f251c
Gerrit-Change-Number: 11551
Gerrit-PatchSet: 6
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Sun, 18 Nov 2018 20:01:27 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: LCLS: explicitly check for mode before closing the loop

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11565 )

Change subject: LCLS: explicitly check for mode before closing the loop
..


Patch Set 4: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11565
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie91cc70de20ade2bfa3a1a108c731341f5e739bb
Gerrit-Change-Number: 11565
Gerrit-PatchSet: 4
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-CC: Pau Espin Pedrol 
Gerrit-Comment-Date: Sun, 18 Nov 2018 20:02:23 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: BSC: log number of expected/seen *CX messages on failure

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11645 )

Change subject: BSC: log number of expected/seen *CX messages on failure
..


Patch Set 4: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11645
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b743aaf9d68f2f332660d819d38ad8212484e00
Gerrit-Change-Number: 11645
Gerrit-PatchSet: 4
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Sun, 18 Nov 2018 20:02:46 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: BSC: log number of expected/seen *CX messages on failure

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11645 )

Change subject: BSC: log number of expected/seen *CX messages on failure
..

BSC: log number of expected/seen *CX messages on failure

Change-Id: I3b743aaf9d68f2f332660d819d38ad8212484e00
---
M bsc/MSC_ConnectionHandler.ttcn
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/bsc/MSC_ConnectionHandler.ttcn b/bsc/MSC_ConnectionHandler.ttcn
index 116d7af..f96e74a 100644
--- a/bsc/MSC_ConnectionHandler.ttcn
+++ b/bsc/MSC_ConnectionHandler.ttcn
@@ -826,10 +826,10 @@
", mdcx_seen=", g_media.mgcp_conn[i].mdcx_seen, ", 
mdcx_seen_exp=", g_media.mgcp_conn[i].mdcx_seen_exp);

if(g_media.mgcp_conn[i].crcx_seen != 
g_media.mgcp_conn[i].crcx_seen_exp) {
-   Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, 
"unexpected number of MGW-CRCX transactions");
+   Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, 
"unexpected number of MGW-CRCX transactions on g_media.mgcp_conn[" & int2str(i) 
& "]");
}
if(g_media.mgcp_conn[i].mdcx_seen != 
g_media.mgcp_conn[i].mdcx_seen_exp) {
-   Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, 
"unexpected number of MGW-MDCX transactions");
+   Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, 
"unexpected number of MGW-MDCX transactions on g_media.mgcp_conn[" & int2str(i) 
& "]");
}
}
 }

--
To view, visit https://gerrit.osmocom.org/11645
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3b743aaf9d68f2f332660d819d38ad8212484e00
Gerrit-Change-Number: 11645
Gerrit-PatchSet: 5
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmo-ttcn3-hacks[master]: BSC LCLS: restructure tests

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11555 )

Change subject: BSC LCLS: restructure tests
..

BSC LCLS: restructure tests

Move duplicated code into separate functions to simplify adding test
cases which do not use MGW MDCX methods for closing the loop.

Change-Id: Idf9fc8e639b0ece662ab26c481899ef39fb7edfe
Related: OS#3659
---
M bsc/BSC_Tests_LCLS.ttcn
1 file changed, 52 insertions(+), 60 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/bsc/BSC_Tests_LCLS.ttcn b/bsc/BSC_Tests_LCLS.ttcn
index 0151329..585059e 100644
--- a/bsc/BSC_Tests_LCLS.ttcn
+++ b/bsc/BSC_Tests_LCLS.ttcn
@@ -255,11 +255,28 @@
f_lcls_test_fini();
 }

+private function f_tc_lcls_recv_ls_exp_mgcp() runs on lcls_test_CT {
+   var MgcpCommand mgcp_cmd;
+
+   interleave {
+   [] CONN_A.receive(tr_BSSMAP_LclsNotificationSts(LCLS_STS_not_yet_ls));
+   [] 
CONN_A.receive(tr_BSSMAP_LclsNotificationSts(LCLS_STS_locally_switched));
+   [] CONN_B.receive(LclsCompSync:LCLS_COMP_SYNC_ASS_COMPL);
+   [] CONN_A.receive(tr_MDCX) -> value mgcp_cmd {
+   CONN_A.send(f_build_mdcx_rsp(mgcp_cmd));
+   }
+   /* not needed, as this MDCX is still handled within 
MSC_ConnectionHandler
+   [] CONN_B.receive(tr_MDCX) -> value mgcp_cmd {
+   CONN_B.send(f_build_mdcx_rsp(mgcp_cmd));
+   }
+   */
+   }
+}
+
 private function f_tc_lcls_gcr_bway_connect(boolean hr) runs on lcls_test_CT {
var TestHdlrParams pars_a := valueof(t_def_TestHdlrPars);
var TestHdlrParams pars_b;
var MSC_ConnHdlr vc_conn;
-   var MgcpCommand mgcp_cmd;

f_lcls_init();

@@ -281,14 +298,8 @@
f_lcls_test_init(pars_a, pars_b);

CONN_A.receive(LclsCompSync:LCLS_COMP_SYNC_ASS_COMPL);
-   interleave {
-   [] CONN_A.receive(tr_BSSMAP_LclsNotificationSts(LCLS_STS_not_yet_ls));
-   [] 
CONN_A.receive(tr_BSSMAP_LclsNotificationSts(LCLS_STS_locally_switched));
-   [] CONN_B.receive(LclsCompSync:LCLS_COMP_SYNC_ASS_COMPL);
-   [] CONN_A.receive(tr_MDCX) -> value mgcp_cmd {
-   CONN_A.send(f_build_mdcx_rsp(mgcp_cmd));
-   }
-   }
+
+   f_tc_lcls_recv_ls_exp_mgcp();

f_lcls_test_fini();
 }
@@ -366,6 +377,12 @@
f_lcls_test_fini();
 }

+/* check for the cases where LCLS is not possible due to some reason */
+private function f_lcls_not_yet_ls() runs on lcls_test_CT {
+   CONN_A.receive(LclsCompSync:LCLS_COMP_SYNC_ASS_COMPL);
+   CONN_B.receive(LclsCompSync:LCLS_COMP_SYNC_ASS_COMPL);
+   CONN_A.receive(tr_BSSMAP_LclsNotificationSts(LCLS_STS_not_yet_ls));
+}

 /* Send an ASSIGNMENT REQ with LCLS GCR+CFG+CSC; expect no connect */
 testcase TC_lcls_gcr_bway_dont_connect() runs on lcls_test_CT {
@@ -387,9 +404,7 @@
pars_b.lcls.exp_sts := LCLS_STS_not_yet_ls;

f_lcls_test_init(pars_a, pars_b);
-   CONN_A.receive(LclsCompSync:LCLS_COMP_SYNC_ASS_COMPL);
-   CONN_B.receive(LclsCompSync:LCLS_COMP_SYNC_ASS_COMPL);
-   CONN_A.receive(tr_BSSMAP_LclsNotificationSts(LCLS_STS_not_yet_ls));
+   f_lcls_not_yet_ls();
f_wait_fail_notify();
f_lcls_test_fini();
 }
@@ -435,12 +450,26 @@
pars_b.lcls.exp_sts := LCLS_STS_not_yet_ls;

f_lcls_test_init(pars_a, pars_b);
-   CONN_A.receive(LclsCompSync:LCLS_COMP_SYNC_ASS_COMPL);
-   CONN_B.receive(LclsCompSync:LCLS_COMP_SYNC_ASS_COMPL);
-   CONN_A.receive(tr_BSSMAP_LclsNotificationSts(LCLS_STS_not_yet_ls));
+   f_lcls_not_yet_ls();
f_lcls_test_fini();
 }

+/* Expect given LCLS status alongside with corresponding MDCX commands */
+private function f_lcls_sts_mgcp(BIT4 expected_status) runs on lcls_test_CT {
+   var MgcpCommand mgcp_cmd;
+
+   interleave {
+   [] 
CONN_B.receive(tr_BSSMAP_LclsConnCtrlAck(tr_BSSMAP_IE_LclsSts(expected_status)));
+   [] CONN_A.receive(tr_BSSMAP_LclsNotificationSts(expected_status));
+   [] CONN_A.receive(tr_MDCX) -> value mgcp_cmd {
+   CONN_A.send(f_build_mdcx_rsp(mgcp_cmd));
+   }
+   [] CONN_B.receive(tr_MDCX) -> value mgcp_cmd {
+   CONN_B.send(f_build_mdcx_rsp(mgcp_cmd));
+   }
+   }
+}
+
 /* Send an ASSIGNMENT REQ with "do not connect" and enable later using LCLS 
CTRL */
 testcase TC_lcls_gcr_bway_dont_connect_csc() runs on lcls_test_CT {
var TestHdlrParams pars_a := valueof(t_def_TestHdlrPars);
@@ -463,9 +492,7 @@

/* start call and expect it to be "not yet" LS */
f_lcls_test_init(pars_a, pars_b);
-   CONN_A.receive(LclsCompSync:LCLS_COMP_SYNC_ASS_COMPL);
-   CONN_B.receive(LclsCompSync:LCLS_COMP_SYNC_ASS_COMPL);
-   CONN_A.receive(tr_BSSMAP_LclsNotificationSts(LCLS_STS_not_yet_ls));
+   f_lcls_not_yet_ls();
f_sleep(2.0);

/* send "connec

Change in osmo-ttcn3-hacks[master]: BSC LCLS: restructure tests

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11555 )

Change subject: BSC LCLS: restructure tests
..


Patch Set 5: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11555
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf9fc8e639b0ece662ab26c481899ef39fb7edfe
Gerrit-Change-Number: 11555
Gerrit-PatchSet: 5
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: daniel 
Gerrit-Comment-Date: Sun, 18 Nov 2018 20:03:23 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: LCLS: explicitly check for *CX adjustment

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11558 )

Change subject: LCLS: explicitly check for *CX adjustment
..

LCLS: explicitly check for *CX adjustment

Previously the expectations for number of CRCX and MDCX messages from
MGW was adjusted unconditionally for LCLS tests. However this is only
necessary for MGW-loop type of LCLS. Use explicit variable (with default
value preserving current behavior) to decide whether to apply this
adjustment or not. This simplifies support for other kinds of LCLS
loops.

Change-Id: I07b2c56991977b5e80c372a5b8338f348f14c076
Related: OS#3659
---
M bsc/MSC_ConnectionHandler.ttcn
1 file changed, 6 insertions(+), 3 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/bsc/MSC_ConnectionHandler.ttcn b/bsc/MSC_ConnectionHandler.ttcn
index f96e74a..0ea73a0 100644
--- a/bsc/MSC_ConnectionHandler.ttcn
+++ b/bsc/MSC_ConnectionHandler.ttcn
@@ -408,7 +408,9 @@
BIT4 cfg optional,
/* LCLS Connection Status Control */
BIT4 csc optional,
-   BIT4 exp_sts optional
+   BIT4 exp_sts optional,
+   /* Whether to adjust *cx_seen_exp for LCLS tests */
+   boolean adjust_cx_exp
 }

 type record TestHdlrParamsHandover {
@@ -446,7 +448,8 @@
gcr := omit,
cfg := omit,
csc := omit,
-   exp_sts := omit
+   exp_sts := omit,
+   adjust_cx_exp := true
},
handover := omit,
aoip := true
@@ -992,7 +995,7 @@
 * is mgcp_conn[1]. The BSC performs this operation already before the
 * assignment complete is generated. This means we expect another MDCX
 * at mgcp_conn[1] when LCLS is expected. */
-   if 
(ispresent(exp_ass_cpl.pdu.bssmap.assignmentComplete.lCLS_BSS_Status.lCLS_BSS_StatusValue))
 {
+   if (g_pars.lcls.adjust_cx_exp and 
ispresent(exp_ass_cpl.pdu.bssmap.assignmentComplete.lCLS_BSS_Status.lCLS_BSS_StatusValue))
 {
if 
(valueof(exp_ass_cpl.pdu.bssmap.assignmentComplete.lCLS_BSS_Status.lCLS_BSS_StatusValue)
 == LCLS_STS_locally_switched) {
g_media.mgcp_conn[1].mdcx_seen_exp := 
g_media.mgcp_conn[1].mdcx_seen_exp + 1;


--
To view, visit https://gerrit.osmocom.org/11558
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I07b2c56991977b5e80c372a5b8338f348f14c076
Gerrit-Change-Number: 11558
Gerrit-PatchSet: 6
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-CC: Neels Hofmeyr 

Change in osmo-ttcn3-hacks[master]: LCLS: explicitly check for *CX adjustment

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11558 )

Change subject: LCLS: explicitly check for *CX adjustment
..


Patch Set 5: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11558
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I07b2c56991977b5e80c372a5b8338f348f14c076
Gerrit-Change-Number: 11558
Gerrit-PatchSet: 5
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-CC: Neels Hofmeyr 
Gerrit-Comment-Date: Sun, 18 Nov 2018 20:03:55 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-gsm-manuals[master]: Abis: Change abisip-find/ipaccess-config path to osmo-bsc repo

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11611 )

Change subject: Abis: Change abisip-find/ipaccess-config path to osmo-bsc repo
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11611
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b92a611abd6e92ad69f77f8ec81a6501224afe5
Gerrit-Change-Number: 11611
Gerrit-PatchSet: 2
Gerrit-Owner: daniel 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: daniel 
Gerrit-Comment-Date: Sun, 18 Nov 2018 20:04:41 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-gsm-manuals[master]: Abis: Change abisip-find/ipaccess-config path to osmo-bsc repo

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11611 )

Change subject: Abis: Change abisip-find/ipaccess-config path to osmo-bsc repo
..

Abis: Change abisip-find/ipaccess-config path to osmo-bsc repo

Change-Id: I4b92a611abd6e92ad69f77f8ec81a6501224afe5
---
M common/chapters/abis.adoc
1 file changed, 7 insertions(+), 4 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/common/chapters/abis.adoc b/common/chapters/abis.adoc
index a53d6f3..7524661 100644
--- a/common/chapters/abis.adoc
+++ b/common/chapters/abis.adoc
@@ -29,8 +29,11 @@
 === Locate Abis/IP based BTS

 We can use a tool called abisip-find to be able to find BTS which is
-connected in the network. This tool is located under:
-'./openbsc/openbsc/src/ipaccess'
+connected in the network. This tool is located in the OsmoBSC project
+repository under:
+'./src/ipaccess'
+
+

  abisip-find

@@ -79,8 +82,8 @@
  ipaccess-config

 This program is very helpful tool which is used to configure Unit ID and
-Primarly OML IP. You can find this tool under:
-'./openbsc/openbsc/src/ipaccess'
+Primarly OML IP. You can find this tool in the OsmoBSC repository under:
+'./src/ipaccess'


 .Example: using ipaccess-config to configure Unit ID and Primarly OML IP of

--
To view, visit https://gerrit.osmocom.org/11611
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4b92a611abd6e92ad69f77f8ec81a6501224afe5
Gerrit-Change-Number: 11611
Gerrit-PatchSet: 3
Gerrit-Owner: daniel 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: daniel 

Change in osmo-gsm-manuals[master]: OsmoBTS: Print VTY command in fixed-width font

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11612 )

Change subject: OsmoBTS: Print VTY command in fixed-width font
..

OsmoBTS: Print VTY command in fixed-width font

Surrounding with '@' didn't seem to yield the intended result, the
charactars appeared in the compiled document.

Change-Id: I66e7949fa4a6c2164bf9572a2beaf8ace169fa1c
---
M OsmoBTS/chapters/interfaces.adoc
M common/chapters/bts.adoc
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/OsmoBTS/chapters/interfaces.adoc b/OsmoBTS/chapters/interfaces.adoc
index 127d4dc..9fefa72 100644
--- a/OsmoBTS/chapters/interfaces.adoc
+++ b/OsmoBTS/chapters/interfaces.adoc
@@ -152,5 +152,5 @@
 with the PHY.

 The default PCU socket interface name is `/tmp/pcu_sock`, but this can
-be overridden by the @pcu-socket@ VTY command in the BTS configuration
+be overridden by the `pcu-socket` VTY command in the BTS configuration
 VTY node.
diff --git a/common/chapters/bts.adoc b/common/chapters/bts.adoc
index 81ca1a2..2e11db1 100644
--- a/common/chapters/bts.adoc
+++ b/common/chapters/bts.adoc
@@ -349,7 +349,7 @@

  Dynamic Timeslot Configuration Examples

-This is an extract of an @osmo-bsc@ or @osmo-nitb@ config file. A timeslot
+This is an extract of an `osmo-bsc` or `osmo-nitb` config file. A timeslot
 configuration with five Osmocom style dynamic timeslots and one dedicated PDCH
 may look like this:


--
To view, visit https://gerrit.osmocom.org/11612
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I66e7949fa4a6c2164bf9572a2beaf8ace169fa1c
Gerrit-Change-Number: 11612
Gerrit-PatchSet: 3
Gerrit-Owner: daniel 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmo-gsm-manuals[master]: VTY: Remove osmo-nitb VTY port number example

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11613 )

Change subject: VTY: Remove osmo-nitb VTY port number example
..

VTY: Remove osmo-nitb VTY port number example

We reference the port list appendix where all the ports used by various
Osmocom projects are listed and it's unlikely that pointing out the
osmo-nitb port would significantly help the reader, so just remove the
reference.

Change-Id: I354d50314ba248835191fa3da122032201618a0e
---
M common/chapters/vty.adoc
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/common/chapters/vty.adoc b/common/chapters/vty.adoc
index 3f72718..c9e3d59 100644
--- a/common/chapters/vty.adoc
+++ b/common/chapters/vty.adoc
@@ -66,7 +66,7 @@
 === Accessing the telnet VTY

 The VTY of a given Osmocom program is implemented as a telnet server,
-listening to a specific TCP port.  For `osmo-nitb`, this port is `4242`.
+listening to a specific TCP port.

 Please see <> to check for the default TCP port number of
 the VTY interface of the specific Osmocom software you would like to

--
To view, visit https://gerrit.osmocom.org/11613
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I354d50314ba248835191fa3da122032201618a0e
Gerrit-Change-Number: 11613
Gerrit-PatchSet: 3
Gerrit-Owner: daniel 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmo-gsm-manuals[master]: Change OpenBSC mentions to OsmoBSC where applicable

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11616 )

Change subject: Change OpenBSC mentions to OsmoBSC where applicable
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11616
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4cc6874302b6089a54d44b09f08660a25e46d4dc
Gerrit-Change-Number: 11616
Gerrit-PatchSet: 2
Gerrit-Owner: daniel 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: daniel 
Gerrit-CC: Pau Espin Pedrol 
Gerrit-Comment-Date: Sun, 18 Nov 2018 20:05:31 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-gsm-manuals[master]: OsmoBTS: Fix typo

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11614 )

Change subject: OsmoBTS: Fix typo
..

OsmoBTS: Fix typo

Change-Id: I0a4c9f052f14816e88ed0a4a5fff9b3854da195a
---
M OsmoBTS/chapters/configuration.adoc
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/OsmoBTS/chapters/configuration.adoc 
b/OsmoBTS/chapters/configuration.adoc
index dbc7a29..558bd4b 100644
--- a/OsmoBTS/chapters/configuration.adoc
+++ b/OsmoBTS/chapters/configuration.adoc
@@ -4,7 +4,7 @@
 application is starting, the A-bis OML connection is established towards
 the BSC.  Almost all BTS configuration (such as ARFCN, channel
 configuration, transmit power, etc.) will be sent from the BSC to the
-BTS via OML messages.  After OML start-up has competed, the BSC will
+BTS via OML messages.  After OML start-up has completed, the BSC will
 instruct the BTS to establish the RSL connections.

 Given that most configuration is downloaded from the BSC into the BTS at

--
To view, visit https://gerrit.osmocom.org/11614
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0a4c9f052f14816e88ed0a4a5fff9b3854da195a
Gerrit-Change-Number: 11614
Gerrit-PatchSet: 3
Gerrit-Owner: daniel 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmo-gsm-manuals[master]: common/chapters/bts: Remove duplicate spaces in text

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11639 )

Change subject: common/chapters/bts: Remove duplicate spaces in text
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11639
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38f3e94342461f494ef547bcdccd2594c30e679d
Gerrit-Change-Number: 11639
Gerrit-PatchSet: 1
Gerrit-Owner: daniel 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sun, 18 Nov 2018 20:05:46 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-gsm-manuals[master]: OsmoBSC/HLR/MSC: Fix default config file name

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11615 )

Change subject: OsmoBSC/HLR/MSC: Fix default config file name
..

OsmoBSC/HLR/MSC: Fix default config file name

Mention that the default is not openbsc.cfg, but osmo-*.cfg

Change-Id: I139e6004e28d6f918f31792e634214a6153edd0e
---
M OsmoBSC/chapters/running.adoc
M OsmoHLR/chapters/running.adoc
M OsmoMSC/chapters/running.adoc
3 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/OsmoBSC/chapters/running.adoc b/OsmoBSC/chapters/running.adoc
index 6747a29..f62ba6e 100644
--- a/OsmoBSC/chapters/running.adoc
+++ b/OsmoBSC/chapters/running.adoc
@@ -21,7 +21,7 @@
Fork the process as a daemon into background.
 *-c, --config-file 'CONFIGFILE'*::
Specify the file and path name of the configuration file to be
-   used. If none is specified, use `openbsc.cfg` in the current
+   used. If none is specified, use `osmo-bsc.cfg` in the current
working directory.
 *-s, --disable-color*::
Disable colors for logging to stderr. This has mostly been
diff --git a/OsmoHLR/chapters/running.adoc b/OsmoHLR/chapters/running.adoc
index 44b66f2..5f24746 100644
--- a/OsmoHLR/chapters/running.adoc
+++ b/OsmoHLR/chapters/running.adoc
@@ -21,7 +21,7 @@
Fork the process as a daemon into background.
 *-c, --config-file 'CONFIGFILE'*::
Specify the file and path name of the configuration file to be
-   used. If none is specified, use `openbsc.cfg` in the current
+   used. If none is specified, use `osmo-hlr.cfg` in the current
working directory.
 *-s, --disable-color*::
Disable colors for logging to stderr. This has mostly been
diff --git a/OsmoMSC/chapters/running.adoc b/OsmoMSC/chapters/running.adoc
index 8656a58..cb68157 100644
--- a/OsmoMSC/chapters/running.adoc
+++ b/OsmoMSC/chapters/running.adoc
@@ -21,7 +21,7 @@
Fork the process as a daemon into background.
 *-c, --config-file 'CONFIGFILE'*::
Specify the file and path name of the configuration file to be
-   used. If none is specified, use `openbsc.cfg` in the current
+   used. If none is specified, use `osmo-msc.cfg` in the current
working directory.
 *-s, --disable-color*::
Disable colors for logging to stderr. This has mostly been

--
To view, visit https://gerrit.osmocom.org/11615
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I139e6004e28d6f918f31792e634214a6153edd0e
Gerrit-Change-Number: 11615
Gerrit-PatchSet: 3
Gerrit-Owner: daniel 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmo-gsm-manuals[master]: common/chapters/bts: Remove duplicate spaces in text

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11639 )

Change subject: common/chapters/bts: Remove duplicate spaces in text
..

common/chapters/bts: Remove duplicate spaces in text

Change-Id: I38f3e94342461f494ef547bcdccd2594c30e679d
---
M common/chapters/bts.adoc
1 file changed, 21 insertions(+), 21 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/common/chapters/bts.adoc b/common/chapters/bts.adoc
index eb28497..30a33cc 100644
--- a/common/chapters/bts.adoc
+++ b/common/chapters/bts.adoc
@@ -1,20 +1,20 @@
 [[bts]]
 == Reviewing and Provisioning BTS configuration

-The main functionality of the BSC component is to manage BTSs.  As such,
+The main functionality of the BSC component is to manage BTSs. As such,
 provisioning BTSs within the BSC is one of the most common tasks during
-BSC operation.   Just like about anything else in OsmoBSC, they are
+BSC operation. Just like about anything else in OsmoBSC, they are
 configured using the VTY.

 BTSs are internally numbered with integer numbers starting from "0" for
-the first BTS.  BTS numbers have to be contiguous, so you cannot
+the first BTS. BTS numbers have to be contiguous, so you cannot
 configure 0,1,2 and then 5.


 === Reviewing current BTS status and configuration

 In order to view the status and properties of a BTS, you can issue the
-`show bts` command.  If used without any BTS number, it will display
+`show bts` command. If used without any BTS number, it will display
 information about all provisioned BTS numbers.

 
@@ -55,9 +55,9 @@
 specified BTS (`show trx 0 0`).

 Furthermore, information on the individual timeslots can be shown by
-means of `show timeslot`.  The output can be restricted to the
+means of `show timeslot`. The output can be restricted to the
 timeslots of a single BTS (`show timeslot 0`) or that of a single
-TRX (`show timeslot 0 0`).  Finally, you can restrict the output to
+TRX (`show timeslot 0 0`). Finally, you can restrict the output to
 a single timeslot by specifying the BTS, TRX and TS numbers (`show
 timeslot 0 0 4`).

@@ -74,7 +74,7 @@
 === Provisioning a new BTS

 In order to provision BTSs, you have to enter the BTS config node of the
-VTY.  In order to configure BTS 0, you can issue the following sequence
+VTY. In order to configure BTS 0, you can issue the following sequence
 of commands:

 
@@ -87,12 +87,12 @@

 At this point, you have a plethora of commands, in fact an entire
 hierarchy of commands to configure all aspects of the BTS, as well as
-each of its TRX and each timeslot within each TRX.  For a full
+each of its TRX and each timeslot within each TRX. For a full
 reference, please consult the telnet VTY integrated help or the respective
 chapter in the VTY reference.

 BTS configuration depends quite a bit on the specific BTS vendor and
-model.  The section below provides just one possible example for the
+model. The section below provides just one possible example for the
 case of a sysmoBTS.

 Note that from the `configure terminal` command onwards, the telnet VTY
@@ -140,7 +140,7 @@

 A GSM BTS periodically transmits a series of 'SYSTEM INFORMATION'
 messages to mobile stations, both via the BCCH in idle mode, was well as
-via the SACCH in dedicated mode.  There are many different types of such
+via the SACCH in dedicated mode. There are many different types of such
 messages. For their detailed contents and encoding, please see _3GPP TS
 24.008_ <<3gpp-ts-24-008>>.

@@ -161,7 +161,7 @@
 === Neighbor List configuration

 Every BTS sends a list of ARFCNs of neighbor cells
-. within its 'SYSTEM INFORMATION 2' (and 2bis/2ter)  messages on the BCCH
+. within its 'SYSTEM INFORMATION 2' (and 2bis/2ter) messages on the BCCH
 . within its 'SYSTEM INFORMATION 5' messages on SACCH in dedicated mode

 For every BTS config node in the VTY, you can specify the behavior of
@@ -184,17 +184,17 @@
 === Configuring GPRS PCU parameters of a BTS

 In the case of BTS models using Abis/IP (IPA), the GPRS PCU is located
-inside the BTS.  The BTS then establishes a Gb connection to the SGSN.
+inside the BTS. The BTS then establishes a Gb connection to the SGSN.

 All the BTS-internal PCU configuration is performed via A-bis OML by
 means of configuring the 'CELL', 'NSVC' (NS Virtual Connection and 'NSE'
 (NS Entity).

 There is one 'CELL' node and one 'NSE' node, but there are two 'NSVC'
-nodes.  At the time of this writing, only the NSVC 0 is supported by
+nodes. At the time of this writing, only the NSVC 0 is supported by
 OsmoBTS, while both NSVC are supported by the ip.access nanoBTS.

-The respective VTY configuration parameters are described below.  They
+The respective VTY configuration parameters are described below. They
 all exist beneath each BTS VTY config node.

 But let's first start with a small example
@@ -224,29 +224,29 @@

Change in osmo-gsm-manuals[master]: Change OpenBSC mentions to OsmoBSC where applicable

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11616 )

Change subject: Change OpenBSC mentions to OsmoBSC where applicable
..

Change OpenBSC mentions to OsmoBSC where applicable

Change-Id: I4cc6874302b6089a54d44b09f08660a25e46d4dc
---
M OsmoPCU/gb/bssgp.adoc
M common/chapters/bts.adoc
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/OsmoPCU/gb/bssgp.adoc b/OsmoPCU/gb/bssgp.adoc
index fe30d84..18f1842 100644
--- a/OsmoPCU/gb/bssgp.adoc
+++ b/OsmoPCU/gb/bssgp.adoc
@@ -490,7 +490,7 @@
 described in <>.

 OsmoPCU allocates a BVC context for the BVCI given by OsmoBTS, which
-in turn receives it from OpenBSC via OML procedures.
+in turn receives it from OsmoBSC or OsmoNITB via OML procedures.

 In addition to the BVCI identifying the OsmoPCU side of BSSGP
 connection, there is also special BVCI which is accepted by OsmoPCU in
diff --git a/common/chapters/bts.adoc b/common/chapters/bts.adoc
index 2e11db1..eb28497 100644
--- a/common/chapters/bts.adoc
+++ b/common/chapters/bts.adoc
@@ -3,7 +3,7 @@

 The main functionality of the BSC component is to manage BTSs.  As such,
 provisioning BTSs within the BSC is one of the most common tasks during
-BSC operation.   Just like about anything else in OpenBSC, they are
+BSC operation.   Just like about anything else in OsmoBSC, they are
 configured using the VTY.

 BTSs are internally numbered with integer numbers starting from "0" for

--
To view, visit https://gerrit.osmocom.org/11616
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4cc6874302b6089a54d44b09f08660a25e46d4dc
Gerrit-Change-Number: 11616
Gerrit-PatchSet: 3
Gerrit-Owner: daniel 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: daniel 
Gerrit-CC: Pau Espin Pedrol 

Change in libosmo-sccp[master]: osmo-stp: add SCCP related VTY commands

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11583 )

Change subject: osmo-stp: add SCCP related VTY commands
..

osmo-stp: add SCCP related VTY commands

Call osmo_sccp_vty_init(), so far forgotten.

This adds the various 'show cs7 instance N sccp *' commands, as well as making
the SCCP timers configurable.

See Id941b8e31d3b4cfdb3f912beedc1e7af321a0113 for a diff of the VTY reference,
showing what commands are enabled by this patch.

Change-Id: I66e97706de0c546db3c6ff77fb5e6ac6e32bff55
---
M stp/stp_main.c
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/stp/stp_main.c b/stp/stp_main.c
index aa2304c..0efe4ed 100644
--- a/stp/stp_main.c
+++ b/stp/stp_main.c
@@ -174,6 +174,7 @@
osmo_fsm_log_addr(false);
logging_vty_add_cmds(&log_info);
osmo_ss7_vty_init_sg(tall_stp_ctx);
+   osmo_sccp_vty_init();
osmo_fsm_vty_add_cmds();

rc = vty_read_config_file(cmdline_config.config_file, NULL);

--
To view, visit https://gerrit.osmocom.org/11583
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I66e97706de0c546db3c6ff77fb5e6ac6e32bff55
Gerrit-Change-Number: 11583
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-gsm-manuals[master]: Logging: Describe all log options, including set-all and force-all

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11617 )

Change subject: Logging: Describe all log options, including set-all and 
force-all
..

Logging: Describe all log options, including set-all and force-all

Change-Id: Ica03c3ea08289314819448a22ae7ed38a7bd4f83
---
M common/chapters/logging.adoc
1 file changed, 47 insertions(+), 0 deletions(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/common/chapters/logging.adoc b/common/chapters/logging.adoc
index db6afdb..a89526c 100644
--- a/common/chapters/logging.adoc
+++ b/common/chapters/logging.adoc
@@ -70,6 +70,53 @@
 Management category to info, you can use the following command:
`log level mm info`.

+There is also a special command to set all categories as a one-off to a desired
+log level. For example, to silence all messages but those logged as notice and
+above issue the command: `log level set-all notice`
+
+Afterwards you can adjust specific categories as usual.
+
+A similar command is `log level force-all ` which causes all categories
+to behave as if set to log level  until the command is reverted with
+`no log level force-all` after which the individually-configured log levels 
will
+again take effect. The difference between `set-all` and `force-all` is that
+`set-all` actually changes the individual category settings while `force-all`
+is a (temporary) override of those settings and does not change them.
+
+[[log_options]]
+=== Log printing options
+
+The logging system has various options to change the information
+displayed in the log message.
+
+log color 1::
+   With this option each log message will log with the color of its
+   category. The color is hard-coded and can not be changed. As with
+   other options a '0' disables this functionality.
+
+log timestamp 1::
+   Includes the current time in the log message. When logging to syslog
+   this option should not be needed, but may come in handy when debugging
+   an issue while logging to file.
+
+log print extended-timestamp 1::
+   In order to debug time-critical issues this option will print a
+   timestamp with millisecond granularity.
+
+log print category 1::
+   Prefix each log message with the category name.
+
+log print category-hex 1::
+   Prefix each log message with the category number in hex ('<000b>').
+
+log print level 1::
+   Prefix each log message with the name of the log level.
+
+log print file 1::
+   Prefix each log message with the source file and line number. Append
+   the keyword `last` to append the file information instead of prefixing
+   it.
+
 [[log_filters]]
 === Log filters


--
To view, visit https://gerrit.osmocom.org/11617
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ica03c3ea08289314819448a22ae7ed38a7bd4f83
Gerrit-Change-Number: 11617
Gerrit-PatchSet: 3
Gerrit-Owner: daniel 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 

Change in libosmo-sccp[master]: osmo-stp: add SCCP related VTY commands

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11583 )

Change subject: osmo-stp: add SCCP related VTY commands
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11583
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I66e97706de0c546db3c6ff77fb5e6ac6e32bff55
Gerrit-Change-Number: 11583
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sun, 18 Nov 2018 20:06:35 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: bsc: gsm0808: Fix return code in bsc_compl_l3

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11605 )

Change subject: bsc: gsm0808: Fix return code in bsc_compl_l3
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11605
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I722696c3f6402288b51d6fcf51f478b3b0c9f0f0
Gerrit-Change-Number: 11605
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-CC: Max 
Gerrit-Comment-Date: Sun, 18 Nov 2018 20:09:01 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: bsc: gsm0808: Fix return code in bsc_compl_l3

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11605 )

Change subject: bsc: gsm0808: Fix return code in bsc_compl_l3
..

bsc: gsm0808: Fix return code in bsc_compl_l3

complete_layer3 returns true if everything succeeded, false otherwise.
However, its caller bsc_compl_l3 returns unix style (0 sucess,
negative error).

This commit has no real effect since only caller of bsc_compl_l3 never
checks return code, but will check it in the future.

Change-Id: I722696c3f6402288b51d6fcf51f478b3b0c9f0f0
---
M src/osmo-bsc/gsm_08_08.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/gsm_08_08.c b/src/osmo-bsc/gsm_08_08.c
index 062c878..a3e8b30 100644
--- a/src/osmo-bsc/gsm_08_08.c
+++ b/src/osmo-bsc/gsm_08_08.c
@@ -366,7 +366,7 @@
return -1;
}

-   return complete_layer3(conn, msg, msc);
+   return complete_layer3(conn, msg, msc) ? 0 : -2;
 }

 static int handle_page_resp(struct gsm_subscriber_connection *conn, struct 
msgb *msg)

--
To view, visit https://gerrit.osmocom.org/11605
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I722696c3f6402288b51d6fcf51f478b3b0c9f0f0
Gerrit-Change-Number: 11605
Gerrit-PatchSet: 3
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-CC: Max 

Change in osmo-bsc[master]: gsm0408_rcvmsg: Release lchan if L3 fails to complete

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11606 )

Change subject: gsm0408_rcvmsg: Release lchan if L3 fails to complete
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11606
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1743f9d5cd0fdbc0fb9afe7bcc0271c897915210
Gerrit-Change-Number: 11606
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Sun, 18 Nov 2018 20:10:05 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libasn1c[master]: remove a redundant assertion

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11625 )

Change subject: remove a redundant assertion
..


Patch Set 1: Code-Review-1

I don't think we should diverge more from upstream asn1c than needed.  If at 
all, fixes should be made upstream.


--
To view, visit https://gerrit.osmocom.org/11625
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libasn1c
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib81e76cfb339838f5e8981d175176557f1a8a63f
Gerrit-Change-Number: 11625
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Sun, 18 Nov 2018 20:11:26 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: msc_vlr_tests: tweak conn_exists()

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11458 )

Change subject: msc_vlr_tests: tweak conn_exists()
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11458
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf507d094319123c6667ba963db1d385df4d4f92
Gerrit-Change-Number: 11458
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Comment-Date: Sun, 18 Nov 2018 20:12:39 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: msc_vlr_tests: tweak conn_exists()

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11458 )

Change subject: msc_vlr_tests: tweak conn_exists()
..

msc_vlr_tests: tweak conn_exists()

* constify function parameter
* internalize parameter check

Change-Id: Icf507d094319123c6667ba963db1d385df4d4f92
---
M tests/msc_vlr/msc_vlr_tests.c
M tests/msc_vlr/msc_vlr_tests.h
2 files changed, 10 insertions(+), 5 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/tests/msc_vlr/msc_vlr_tests.c b/tests/msc_vlr/msc_vlr_tests.c
index 1192cf2..fd196c8 100644
--- a/tests/msc_vlr/msc_vlr_tests.c
+++ b/tests/msc_vlr/msc_vlr_tests.c
@@ -161,13 +161,18 @@
OSMO_ASSERT(gsup_tx_confirmed);
 }

-bool conn_exists(struct gsm_subscriber_connection *conn)
+bool conn_exists(const struct gsm_subscriber_connection *conn)
 {
struct gsm_subscriber_connection *c;
+
+   if (!conn)
+   return false;
+
llist_for_each_entry(c, &net->subscr_conns, entry) {
if (c == conn)
return true;
}
+
return false;
 }

@@ -212,7 +217,7 @@
ran_type_name(rx_from_ran),
gh_type_name(gh));

-   if (g_conn && !conn_exists(g_conn))
+   if (!conn_exists(g_conn))
g_conn = NULL;

if (!g_conn) {
@@ -230,7 +235,7 @@
msc_dtap(g_conn, 23, msg);
}

-   if (g_conn && !conn_exists(g_conn))
+   if (!conn_exists(g_conn))
g_conn = NULL;
 }

@@ -258,7 +263,7 @@
bh->type = BSSAP_MSG_BSS_MANAGEMENT;
bh->length = msgb_l3len(msg);

-   if (g_conn && !conn_exists(g_conn))
+   if (!conn_exists(g_conn))
g_conn = NULL;

OSMO_ASSERT(g_conn);
diff --git a/tests/msc_vlr/msc_vlr_tests.h b/tests/msc_vlr/msc_vlr_tests.h
index cc200bd..40377c1 100644
--- a/tests/msc_vlr/msc_vlr_tests.h
+++ b/tests/msc_vlr/msc_vlr_tests.h
@@ -152,7 +152,7 @@
 struct msgb *msgb_from_hex(const char *label, uint16_t size, const char *hex);

 void clear_vlr();
-bool conn_exists(struct gsm_subscriber_connection *conn);
+bool conn_exists(const struct gsm_subscriber_connection *conn);
 void conn_conclude_cm_service_req(struct gsm_subscriber_connection *conn,
  enum ran_type via_ran);


--
To view, visit https://gerrit.osmocom.org/11458
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Icf507d094319123c6667ba963db1d385df4d4f92
Gerrit-Change-Number: 11458
Gerrit-PatchSet: 3
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 

Change in libosmocore[master]: Add helper wrapper for BSSAP TLV parsing

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11655 )

Change subject: Add helper wrapper for BSSAP TLV parsing
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11655
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib228368901ce90a02a5664f2510593371c7d29cd
Gerrit-Change-Number: 11655
Gerrit-PatchSet: 3
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sun, 18 Nov 2018 20:13:13 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: Add helper wrapper for BSSAP TLV parsing

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11655 )

Change subject: Add helper wrapper for BSSAP TLV parsing
..

Add helper wrapper for BSSAP TLV parsing

Change-Id: Ib228368901ce90a02a5664f2510593371c7d29cd
---
M include/osmocom/gsm/gsm0808.h
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/include/osmocom/gsm/gsm0808.h b/include/osmocom/gsm/gsm0808.h
index cdbb273..652aae9 100644
--- a/include/osmocom/gsm/gsm0808.h
+++ b/include/osmocom/gsm/gsm0808.h
@@ -173,6 +173,9 @@

 const struct tlv_definition *gsm0808_att_tlvdef(void);

+/*! Parse BSSAP TLV structure using \ref tlv_parse */
+#define osmo_bssap_tlv_parse(dec, buf, len) tlv_parse(dec, 
gsm0808_att_tlvdef(), buf, len, 0, 0)
+
 const char *gsm0808_bssmap_name(uint8_t msg_type);
 const char *gsm0808_bssap_name(uint8_t msg_type);
 const char *gsm0808_cause_name(uint8_t cause);

--
To view, visit https://gerrit.osmocom.org/11655
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib228368901ce90a02a5664f2510593371c7d29cd
Gerrit-Change-Number: 11655
Gerrit-PatchSet: 4
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in libosmocore[master]: Update 3GPP TS 08.08 Cause handling

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11577 )

Change subject: Update 3GPP TS 08.08 Cause handling
..


Patch Set 8: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11577
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I31b31dfc22eb4b6b07089e1255246ac458125340
Gerrit-Change-Number: 11577
Gerrit-PatchSet: 8
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Comment-Date: Sun, 18 Nov 2018 20:14:04 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: Update 3GPP TS 08.08 Cause handling

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11577 )

Change subject: Update 3GPP TS 08.08 Cause handling
..

Update 3GPP TS 08.08 Cause handling

* add Class definitions
* add helper to check for extended bit
* add helper to get Cause's Class
* use enum in gsm0808_cause_name() and gsm0808_create_cipher_reject() to
  avoid confusion between class and cause
* update gsm0808_create_cipher_reject() comments

Change-Id: I31b31dfc22eb4b6b07089e1255246ac458125340
Related: OS#3187
---
M TODO-RELEASE
M include/osmocom/gsm/gsm0808.h
M include/osmocom/gsm/gsm0808_utils.h
M include/osmocom/gsm/protocol/gsm_08_08.h
M src/gsm/gsm0808.c
M src/gsm/libosmogsm.map
6 files changed, 59 insertions(+), 9 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/TODO-RELEASE b/TODO-RELEASE
index 5222ec9..00720f6 100644
--- a/TODO-RELEASE
+++ b/TODO-RELEASE
@@ -11,3 +11,8 @@
 libosmogsm gsm48_push_l3hdr()  (re)introduced in gsm/gsm48.h (GSM 
04.08 API)
 libosmogsm gsm48_push_l3hdr_tid()  a wrapper around gsm48_push_l3hdr()
 libosmocoremsgb_l4len  new symbol (exposed as 'static inline' 
in msgb.h)
+libosmogsm gsm0808_cause_class_name()  getter for class description
+libosmogsm gsm0808_cause_class()   getter for cause class
+libosmogsm gsm0808_cause_ext() check for cause extended bit
+libosmogsm gsm0808_cause_name()use enum as parameter
+libosmogsm gsm0808_create_cipher_reject()  use enum as parameter
diff --git a/include/osmocom/gsm/gsm0808.h b/include/osmocom/gsm/gsm0808.h
index 652aae9..66f7c27 100644
--- a/include/osmocom/gsm/gsm0808.h
+++ b/include/osmocom/gsm/gsm0808.h
@@ -50,7 +50,7 @@
 struct msgb *gsm0808_create_cipher(const struct gsm0808_encrypt_info *ei,
   const uint8_t *cipher_response_mode);
 struct msgb *gsm0808_create_cipher_complete(struct msgb *layer3, uint8_t 
alg_id);
-struct msgb *gsm0808_create_cipher_reject(uint8_t cause);
+struct msgb *gsm0808_create_cipher_reject(enum gsm0808_cause cause);
 struct msgb *gsm0808_create_classmark_request();
 struct msgb *gsm0808_create_classmark_update(const uint8_t *cm2, uint8_t 
cm2_len,
 const uint8_t *cm3, uint8_t 
cm3_len);
@@ -178,7 +178,8 @@

 const char *gsm0808_bssmap_name(uint8_t msg_type);
 const char *gsm0808_bssap_name(uint8_t msg_type);
-const char *gsm0808_cause_name(uint8_t cause);
+const char *gsm0808_cause_name(enum gsm0808_cause cause);
+const char *gsm0808_cause_class_name(enum gsm0808_cause_class class);

 extern const struct value_string gsm0808_lcls_config_names[];
 extern const struct value_string gsm0808_lcls_control_names[];
diff --git a/include/osmocom/gsm/gsm0808_utils.h 
b/include/osmocom/gsm/gsm0808_utils.h
index f70dbdb..b56e263 100644
--- a/include/osmocom/gsm/gsm0808_utils.h
+++ b/include/osmocom/gsm/gsm0808_utils.h
@@ -107,7 +107,20 @@
 uint16_t gsm0808_sc_cfg_from_gsm48_mr_cfg(const struct gsm48_multi_rate_conf 
*cfg, bool fr);
 void gsm48_mr_cfg_from_gsm0808_sc_cfg(struct gsm48_multi_rate_conf *cfg, 
uint16_t s15_s0);

-/*! Return 3GPP TS 48.008 3.2.2.49 Current Channel Type 1 from enum 
gsm_chan_t. */
+/*! \returns 3GPP TS 08.08 §3.2.2.5 Class of a given Cause */
+static inline enum gsm0808_cause_class gsm0808_cause_class(enum gsm0808_cause 
cause)
+{
+   return (cause << 1) >> 4;
+}
+
+/*! \returns true if 3GPP TS 08.08 §3.2.2.5 Class has extended bit set */
+static inline bool gsm0808_cause_ext(enum gsm0808_cause cause)
+{
+   /* check that cause looks like 1XXX where XXX represent class */
+   return (cause & 0x80) && !(cause & 0x0F);
+}
+
+/*! \returns 3GPP TS 48.008 3.2.2.49 Current Channel Type 1 from enum 
gsm_chan_t. */
 static inline uint8_t gsm0808_current_channel_type_1(enum gsm_chan_t type)
 {
switch (type) {
diff --git a/include/osmocom/gsm/protocol/gsm_08_08.h 
b/include/osmocom/gsm/protocol/gsm_08_08.h
index 8431ace..2317e78 100644
--- a/include/osmocom/gsm/protocol/gsm_08_08.h
+++ b/include/osmocom/gsm/protocol/gsm_08_08.h
@@ -384,6 +384,18 @@
GSM0808_CAUSE_DTM_HO_TIMER_EXPIRY   = 0x62,
 };

+/* 3GPP TS 08.08 §3.2.2.5 Cause Class */
+enum gsm0808_cause_class {
+   GSM0808_CAUSE_CLASS_NORM0   = 0,
+   GSM0808_CAUSE_CLASS_NORM1   = 1,
+   GSM0808_CAUSE_CLASS_RES_UNAVAIL = 2,
+   GSM0808_CAUSE_CLASS_SRV_OPT_NA  = 3,
+   GSM0808_CAUSE_CLASS_SRV_OPT_NIMPL   = 4,
+   GSM0808_CAUSE_CLASS_INVAL   = 5,
+   GSM0808_CAUSE_CLASS_PERR= 6,
+   GSM0808_CAUSE_CLASS_INTW= 7,
+};
+
 /* GSM 08.08 3.2.2.11 Channel Type */
 enum gsm0808_chan_indicator {
GSM0808_CHAN_SPEECH = 1,
diff --git a/src/gsm/gsm0808.c b/src/gsm/gsm0808.c
index e5c3e30..791ebc2 1006

Change in libosmocore[master]: Support cipher mode reject with extended cause

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11601 )

Change subject: Support cipher mode reject with extended cause
..


Patch Set 6: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11601
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5509b94a18180a44f45300caaa02b843c166fa3
Gerrit-Change-Number: 11601
Gerrit-PatchSet: 6
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-CC: Vadim Yanitskiy 
Gerrit-Comment-Date: Sun, 18 Nov 2018 20:15:08 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-pcu[master]: deb: add missing copyright file

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11653 )

Change subject: deb: add missing copyright file
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11653
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib05480c0eea91bfb55bfc7ab446ea60932096d3d
Gerrit-Change-Number: 11653
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Comment-Date: Sun, 18 Nov 2018 20:15:31 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-pcu[master]: deb: add missing copyright file

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11653 )

Change subject: deb: add missing copyright file
..

deb: add missing copyright file

File is imported as-is from current .deb package

Change-Id: Ib05480c0eea91bfb55bfc7ab446ea60932096d3d
---
A debian/copyright
1 file changed, 132 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/debian/copyright b/debian/copyright
new file mode 100644
index 000..853cd6e
--- /dev/null
+++ b/debian/copyright
@@ -0,0 +1,132 @@
+Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
+Upstream-Name: osmo-pcu
+Source: git://git.osmocom.org/osmo-pcu
+Files-Excluded: debian
+
+Files: *
+Copyright: 2009-2015 Holger Hans Peter Freyther 
+   2013 Jacob Erlbeck 
+   2016-2017 sysmocom s.m.f.c. GmbH 
+   2015 by Yves Godin 
+License:   AGPL-3.0+
+
+Files: src/gprs_ms_storage.h
+   src/gprs_ms_storage.cpp
+   src/gprs_ms.h
+   src/gprs_coding_scheme.cpp
+   src/gprs_coding_scheme.h
+   src/cxx_linuxlist.h
+   src/pcu_vty_functions.cpp
+   src/pcu_vty_functions.h
+   src/pcu_utils.h
+   src/gprs_codel.c
+   src/gprs_codel.h
+Copyright: 2016-2017 sysmocom s.m.f.c. GmbH 
+License:   GPL-2.0+
+
+Files: osmoappdesc.py
+Copyright: 2013 by Katerina Barone-Adesi 
+License:   GPL-3.0+
+
+Files: src/gprs_debug.cpp
+   src/gprs_debug.h
+   src/pcu_main.cpp
+   src/pcu_l1_if.h
+   src/gsm_timer.cpp
+   src/gsm_timer.h
+Copyright: 2012 Ivan Klyuchnikov
+License:   GPL-2.0+
+
+Files: src/tbf.cpp
+   src/tbf_ul.cpp
+   src/tbf_dl.cpp
+   src/sba.cpp
+   src/sba.h
+   src/llc.cpp
+   src/encoding.cpp
+   src/encoding.h
+   src/gprs_rlcmac.cpp
+   src/gprs_rlcmac_ts_alloc.cpp
+Copyright: 2012 Ivan Klyuchnikov
+   2012 Andreas Eversberg 
+   2013 by Holger Hans Peter Freyther
+License:   GPL-2.0+
+
+Files: src/gprs_rlcmac.h
+   src/gprs_bssgp_pcu.cpp
+   src/gprs_bssgp_pcu.h
+   src/bts.h
+Copyright: 2012 Ivan Klyuchnikov
+   2013 by Holger Hans Peter Freyther
+License:   GPL-2.0+
+
+Files: src/rlc.h
+   src/decoding.cpp
+   src/decoding.h
+Copyright: 2012 Ivan Klyuchnikov
+   2012 Andreas Eversberg 
+License:   GPL-2.0+
+
+Files: src/rlc.cpp
+   src/llc.h
+   src/tbf.h
+Copyright: 2013 by Holger Hans Peter Freyther
+License:   GPL-2.0+
+
+Files: src/pcu_l1_if.cpp
+   src/gprs_rlcmac_meas.cpp
+   src/gprs_rlcmac_sched.cpp
+   src/osmobts_sock.cpp
+Copyright: 2012 Andreas Eversberg 
+License:   GPL-2.0+
+
+Files: src/csn1.h
+   src/csn1.cpp
+   src/gsm_rlcmac.cpp
+   src/gsm_rlcmac.h
+Copyright: 2011 Vincent Helfre
+   2011 ST-Ericsson (Jari Sassi)
+License:   GPL-2.0+
+
+License:   AGPL-3.0+
+ All rights not specifically granted under this license are reserved.
+ .
+ This program is free software; you can redistribute it and/or modify it
+ under the terms of the GNU Affero General Public License as published by the
+ Free Software Foundation; either version 3 of the License, or (at your
+ option) any later version.
+
+License:   GPL-3.0+
+ This program is free software: you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation, either version 3 of the License, or
+ (at your option) any later version.
+ .
+ This program is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ GNU General Public License for more details.
+ .
+ You should have received a copy of the GNU General Public License
+ along with this program.  If not, see .
+ .
+ On Debian systems, the complete text of the GNU General Public License
+ Version 3 can be found in `/usr/share/common-licenses/GPL-3'.
+
+License:   GPL-2.0+
+ This program is free software: you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation, either version 2 of the License, or
+ (at your option) any later version.
+ .
+ This program is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ GNU General Public License for more details.
+ .
+ You should have received a copy of the GNU General Public License
+ along with this program.  If not, see .
+ .
+ On Debian systems, the complete text of the

Change in libosmocore[master]: Move msgb_push helpers to public header

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11679 )

Change subject: Move msgb_push helpers to public header
..


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/11679/1/include/osmocom/core/msgb.h
File include/osmocom/core/msgb.h:

https://gerrit.osmocom.org/#/c/11679/1/include/osmocom/core/msgb.h@378
PS1, Line 378: static inline unsigned char *msgb_push_TLV1(struct msgb *msgb, 
uint8_t tag,
this is just a wrapper around msgb_tlv_push() with addressof-value and length 
1.  Please use a inline function or #define rather than re-implementing this 
from gsm/tlv.h



--
To view, visit https://gerrit.osmocom.org/11679
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37e91d031fba28cf1c6735b8069b0265746f55e6
Gerrit-Change-Number: 11679
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sun, 18 Nov 2018 20:19:04 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: LCLS: tighten GCR check

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11689 )

Change subject: LCLS: tighten GCR check
..

LCLS: tighten GCR check

Use stricter checks for received Global Call Reference.

Change-Id: I9690e1b2d14e41471413bb35eb22fa6c4c4d67fd
Related: OS#2487
---
M src/osmo-bsc/osmo_bsc_bssap.c
1 file changed, 13 insertions(+), 12 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/osmo_bsc_bssap.c b/src/osmo-bsc/osmo_bsc_bssap.c
index 6b7a682..f03fb6e 100644
--- a/src/osmo-bsc/osmo_bsc_bssap.c
+++ b/src/osmo-bsc/osmo_bsc_bssap.c
@@ -520,19 +520,20 @@
 static void bssmap_handle_ass_req_lcls(struct gsm_subscriber_connection *conn,
const struct tlv_parsed *tp)
 {
-   const struct tlv_p_entry *tlv;
-   const uint8_t *config, *control;
+   const uint8_t *config, *control, *gcr, gcr_len = TLVP_LEN(tp, 
GSM0808_IE_GLOBAL_CALL_REF);

-   tlv = TLVP_GET(tp, GSM0808_IE_GLOBAL_CALL_REF);
-   if (tlv) {
-   if (tlv->len > sizeof(conn->lcls.global_call_ref))
-   LOGPFSML(conn->fi, LOGL_ERROR, "Global Call Ref IE of 
%u bytes is too long\n",
-   tlv->len);
-   else {
-   LOGPFSM(conn->fi, "Setting GCR to %s\n", 
osmo_hexdump_nospc(tlv->val, tlv->len));
-   memcpy(&conn->lcls.global_call_ref, tlv->val, tlv->len);
-   conn->lcls.global_call_ref_len = tlv->len;
-   }
+   if (gcr_len > sizeof(conn->lcls.global_call_ref))
+   LOGPFSML(conn->fi, LOGL_ERROR, "Global Call Ref IE of %u bytes 
is too long\n",
+gcr_len);
+   else {
+   gcr = TLVP_VAL_MINLEN(tp, GSM0808_IE_GLOBAL_CALL_REF, 13);
+   if (gcr) {
+   LOGPFSM(conn->fi, "Setting GCR to %s\n", 
osmo_hexdump_nospc(gcr, gcr_len));
+   memcpy(&conn->lcls.global_call_ref, gcr, gcr_len);
+   conn->lcls.global_call_ref_len = gcr_len;
+   } else
+   LOGPFSML(conn->fi, LOGL_ERROR, "Global Call Ref IE of 
%u bytes is too short\n",
+gcr_len);
}

config = TLVP_VAL_MINLEN(tp, GSM0808_IE_LCLS_CONFIG, 1);

--
To view, visit https://gerrit.osmocom.org/11689
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9690e1b2d14e41471413bb35eb22fa6c4c4d67fd
Gerrit-Change-Number: 11689
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Build failed in Jenkins: master-osmo-sip-connector » a1=default,a2=default,a3=default,osmocom-master-debian9 #880

[jenkins]

See 


--
[...truncated 38.66 KB...]
more information, such as the ld(1) and ld.so(8) manual pages.
--
make[3]: Leaving directory 
'
make[2]: Leaving directory 
'
Making install in src/gsm
make[2]: Entering directory 
'
  GEN  gsm0503_conv.c
Generating convolutional codes...
Generate 'xcch' definition
Generate 'rach' definition
Generate 'rach_ext' definition
Generate 'sch' definition
Generate 'cs2' definition
Generate 'cs3' definition
Generate 'cs2_np' definition
Generate 'cs3_np' definition
Generate 'tch_afs_12_2' definition
Generate 'tch_afs_10_2' definition
Generate 'tch_afs_7_95' definition
Generate 'tch_afs_7_4' definition
Generate 'tch_afs_6_7' definition
Generate 'tch_afs_5_9' definition
Generate 'tch_afs_5_15' definition
Generate 'tch_afs_4_75' definition
Generate 'tch_fr' definition
Generate 'tch_hr' definition
Generate 'tch_ahs_7_95' definition
Generate 'tch_ahs_7_4' definition
Generate 'tch_ahs_6_7' definition
Generate 'tch_ahs_5_9' definition
Generate 'tch_ahs_5_15' definition
Generate 'tch_ahs_4_75' definition
Generate 'mcs1_dl_hdr' definition
Generate 'mcs1_ul_hdr' definition
Generate 'mcs1' definition
Generate 'mcs2' definition
Generate 'mcs3' definition
Generate 'mcs4' definition
Generate 'mcs5_dl_hdr' definition
Generate 'mcs5_ul_hdr' definition
Generate 'mcs5' definition
Generate 'mcs6' definition
Generate 'mcs7_dl_hdr' definition
Generate 'mcs7_ul_hdr' definition
Generate 'mcs7' definition
Generate 'mcs8' definition
Generate 'mcs9' definition
Generation complete.
make  install-am
make[3]: Entering directory 
'
  CC   a5.lo
  CC   rxlev_stat.lo
  CC   tlv_parser.lo
  CC   comp128.lo
  CC   comp128v23.lo
  CC   gsm_utils.lo
  CC   rsl.lo
  CC   gsm48.lo
gsm_utils.c:112:9: note: #pragma message: including GnuTLS for getrandom 
fallback.
 #pragma message ("including GnuTLS for getrandom fallback.")
 ^~~
gsm_utils.c: In function ‘osmo_get_rand_id’:
gsm_utils.c:448:9: note: #pragma message: Using direct syscall access for 
getrandom(): consider upgrading to glibc >= 2.25
 #pragma message ("Using direct syscall access for getrandom(): consider 
upgrading to glibc >= 2.25")
 ^~~
gsm_utils.c:456:9: note: #pragma message: Secure random failed: using GnuTLS 
fallback.
 #pragma message ("Secure random failed: using GnuTLS fallback.")
 ^~~
  CC   gsm48_ie.lo
  CC   gsm0808.lo
  CC   sysinfo.lo
  CC   gprs_cipher_core.lo
  CC   gprs_rlc.lo
  CC   gsm0480.lo
  CC   abis_nm.lo
  CC   gsm0502.lo
  CC   gsm0411_utils.lo
  CC   gsm0411_smc.lo
  CC   gsm0411_smr.lo
  CC   gsm0414.lo
  CC   lapd_core.lo
  CC   lapdm.lo
  CC   kasumi.lo
  CC   gsm_04_08_gprs.lo
  CC   auth_core.lo
  CC   auth_comp128v1.lo
  CC   auth_comp128v23.lo
  CC   auth_milenage.lo
  CC   gea.lo
  CC   gan.lo
  CC   ipa.lo
  CC   gsm0341.lo
  CC   apn.lo
  CC   gsup.lo
ipa.c: In function ‘ipa_ccm_idtag_parse’:
ipa.c:103:2: warning: ‘ipa_ccm_idtag_parse_off’ is deprecated: Use 
ipa_ccm_id_{get,resp}_parse instead [-Wdeprecated-declarations]
  return ipa_ccm_idtag_parse_off(dec, buf, len, 0);
  ^~
In file included from ipa.c:45:0:
../../include/osmocom/gsm/ipa.h:31:5: note: declared here
 int ipa_ccm_idtag_parse_off(struct tlv_parsed *dec, unsigned char *buf, int 
len, const int len_offset)
 ^~~
  CC   gprs_gea.lo
  CC   gsm0503_conv.lo
  CC   oap.lo
  CC   gsm0808_utils.lo
  CC   gsm23003.lo
  CC   mncc.lo
  CC   bts_features.lo
  CC   oap_client.lo
  CC   gsm29118.lo
  CC   milenage/aes-encblock.lo
  CC   milenage/aes-internal.lo
  CC   milenage/aes-internal-enc.lo
  CC   milenage/milenage.lo
  CCLD libgsmint.la
ar: `u' modifier ignored since `D' is the default (see `U')
  CCLD libosmogsm.la
make[4]: Entering directory 
'
make[4]: Nothing to be d

Change in osmo-bsc[master]: LCLS: tighten GCR check

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11689 )

Change subject: LCLS: tighten GCR check
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11689
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9690e1b2d14e41471413bb35eb22fa6c4c4d67fd
Gerrit-Change-Number: 11689
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sun, 18 Nov 2018 20:19:43 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bts[master]: prevent potential NULL dereference in virtbts's tx_tchh_fn

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11632 )

Change subject: prevent potential NULL dereference in virtbts's tx_tchh_fn
..

prevent potential NULL dereference in virtbts's tx_tchh_fn

If chan_state->ongoing_facch is set, this code's logic
suggests that both msg_facch and msg_tch could be NULL.
Don't dereference msg_tch unconditionally.

Change-Id: Icf5584396c5b925d55ca9380dd4f869ae5d72da3
Related: CID#172047
---
M src/osmo-bts-virtual/scheduler_virtbts.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Neels Hofmeyr: Looks good to me, approved



diff --git a/src/osmo-bts-virtual/scheduler_virtbts.c 
b/src/osmo-bts-virtual/scheduler_virtbts.c
index 2248afc..25f6583 100644
--- a/src/osmo-bts-virtual/scheduler_virtbts.c
+++ b/src/osmo-bts-virtual/scheduler_virtbts.c
@@ -463,7 +463,7 @@
if (msg_facch) {
tx_to_virt_um(l1t, tn, fn, chan, msg_facch);
msgb_free(msg_tch);
-   } else
+   } else if (msg_tch)
tx_to_virt_um(l1t, tn, fn, chan, msg_tch);

 send_burst:

--
To view, visit https://gerrit.osmocom.org/11632
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Icf5584396c5b925d55ca9380dd4f869ae5d72da3
Gerrit-Change-Number: 11632
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-CC: Pau Espin Pedrol 

Change in osmocom-bb[master]: mobile: add header for MS' MNCC functions

[Max]

Max has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11816 )

Change subject: mobile: add header for MS' MNCC functions
..

mobile: add header for MS' MNCC functions

This simplifies adding new functions and re-using them from other parts
of the code.

Change-Id: Ibad400a99afe052f011f54fc706836b6bf89f4b9
---
M src/host/layer23/include/osmocom/bb/mobile/Makefile.am
A src/host/layer23/include/osmocom/bb/mobile/mncc_ms.h
M src/host/layer23/src/mobile/mnccms.c
M src/host/layer23/src/mobile/vty_interface.c
4 files changed, 12 insertions(+), 10 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved



diff --git a/src/host/layer23/include/osmocom/bb/mobile/Makefile.am 
b/src/host/layer23/include/osmocom/bb/mobile/Makefile.am
index 12cf24b..8e4be1a 100644
--- a/src/host/layer23/include/osmocom/bb/mobile/Makefile.am
+++ b/src/host/layer23/include/osmocom/bb/mobile/Makefile.am
@@ -1,3 +1,3 @@
 noinst_HEADERS = gsm322.h gsm480_ss.h gsm411_sms.h gsm48_cc.h gsm48_mm.h \
 gsm48_rr.h mncc.h settings.h subscriber.h support.h \
-transaction.h vty.h mncc_sock.h primitives.h
+transaction.h vty.h mncc_sock.h mncc_ms.h primitives.h
diff --git a/src/host/layer23/include/osmocom/bb/mobile/mncc_ms.h 
b/src/host/layer23/include/osmocom/bb/mobile/mncc_ms.h
new file mode 100644
index 000..49ce1a4
--- /dev/null
+++ b/src/host/layer23/include/osmocom/bb/mobile/mncc_ms.h
@@ -0,0 +1,9 @@
+#pragma once
+
+int mncc_call(struct osmocom_ms *ms, char *number);
+int mncc_hangup(struct osmocom_ms *ms);
+int mncc_answer(struct osmocom_ms *ms);
+int mncc_hold(struct osmocom_ms *ms);
+int mncc_retrieve(struct osmocom_ms *ms, int number);
+int mncc_dtmf(struct osmocom_ms *ms, char *dtmf);
+
diff --git a/src/host/layer23/src/mobile/mnccms.c 
b/src/host/layer23/src/mobile/mnccms.c
index 9be9c8f..9f58112 100644
--- a/src/host/layer23/src/mobile/mnccms.c
+++ b/src/host/layer23/src/mobile/mnccms.c
@@ -30,15 +30,14 @@
 #include 
 #include 
 #include 
+#include 
 #include 

 static uint32_t new_callref = 1;
 static LLIST_HEAD(call_list);

-void mncc_set_cause(struct gsm_mncc *data, int loc, int val);
 static int dtmf_statemachine(struct gsm_call *call, struct gsm_mncc *mncc);
 static void timeout_dtmf(void *arg);
-int mncc_answer(struct osmocom_ms *ms);

 /*
  * support functions
diff --git a/src/host/layer23/src/mobile/vty_interface.c 
b/src/host/layer23/src/mobile/vty_interface.c
index 12c32a5..a0ad993 100644
--- a/src/host/layer23/src/mobile/vty_interface.c
+++ b/src/host/layer23/src/mobile/vty_interface.c
@@ -35,6 +35,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -43,13 +44,6 @@
 #include 
 #include 

-int mncc_call(struct osmocom_ms *ms, char *number);
-int mncc_hangup(struct osmocom_ms *ms);
-int mncc_answer(struct osmocom_ms *ms);
-int mncc_hold(struct osmocom_ms *ms);
-int mncc_retrieve(struct osmocom_ms *ms, int number);
-int mncc_dtmf(struct osmocom_ms *ms, char *dtmf);
-
 extern struct llist_head ms_list;
 extern struct llist_head active_connections;


--
To view, visit https://gerrit.osmocom.org/11816
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibad400a99afe052f011f54fc706836b6bf89f4b9
Gerrit-Change-Number: 11816
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Vadim Yanitskiy 

Change in osmocom-bb[master]: mobile: use proper type for boolean flags

[Max]

Max has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11817 )

Change subject: mobile: use proper type for boolean flags
..

mobile: use proper type for boolean flags

This makes reading code easier and simplifies further modifications.

Change-Id: I7eff2a61495ff167dc19fc9a41882a7a11fbf32d
---
M src/host/layer23/include/osmocom/bb/mobile/mncc.h
M src/host/layer23/src/mobile/mnccms.c
2 files changed, 11 insertions(+), 11 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved



diff --git a/src/host/layer23/include/osmocom/bb/mobile/mncc.h 
b/src/host/layer23/include/osmocom/bb/mobile/mncc.h
index cad1883..8ec9358 100644
--- a/src/host/layer23/include/osmocom/bb/mobile/mncc.h
+++ b/src/host/layer23/include/osmocom/bb/mobile/mncc.h
@@ -36,9 +36,9 @@

uint32_tcallref;

-   uint8_t init; /* call initiated, no response yet */
-   uint8_t hold; /* call on hold */
-   uint8_t ring; /* call ringing/knocking */
+   boolinit; /* call initiated, no response yet */
+   boolhold; /* call on hold */
+   boolring; /* call ringing/knocking */

struct osmo_timer_list  dtmf_timer;
uint8_t dtmf_state;
diff --git a/src/host/layer23/src/mobile/mnccms.c 
b/src/host/layer23/src/mobile/mnccms.c
index 9f58112..2243291 100644
--- a/src/host/layer23/src/mobile/mnccms.c
+++ b/src/host/layer23/src/mobile/mnccms.c
@@ -294,7 +294,7 @@
}

/* not in initiated state anymore */
-   call->init = 0;
+   call->init = false;

switch (msg_type) {
case MNCC_DISC_IND:
@@ -478,9 +478,9 @@
LOGP(DMNCC, LOGL_INFO, "Ring!\n");
else {
LOGP(DMNCC, LOGL_INFO, "Knock!\n");
-   call->hold = 1;
+   call->hold = true;
}
-   call->ring = 1;
+   call->ring = true;
memset(&mncc, 0, sizeof(struct gsm_mncc));
mncc.callref = call->callref;
mncc_tx_to_cc(ms, MNCC_ALERT_REQ, &mncc);
@@ -498,7 +498,7 @@
vty_notify(ms, NULL);
vty_notify(ms, "Call is on hold\n");
LOGP(DMNCC, LOGL_INFO, "Call is on hold\n");
-   call->hold = 1;
+   call->hold = true;
break;
case MNCC_HOLD_REJ:
vty_notify(ms, NULL);
@@ -509,7 +509,7 @@
vty_notify(ms, NULL);
vty_notify(ms, "Call is retrieved\n");
LOGP(DMNCC, LOGL_INFO, "Call is retrieved\n");
-   call->hold = 0;
+   call->hold = false;
break;
case MNCC_RETRIEVE_REJ:
vty_notify(ms, NULL);
@@ -554,7 +554,7 @@
return -ENOMEM;
call->ms = ms;
call->callref = new_callref++;
-   call->init = 1;
+   call->init = true;
llist_add_tail(&call->entry, &call_list);

memset(&setup, 0, sizeof(struct gsm_mncc));
@@ -646,8 +646,8 @@
vty_notify(ms, "Please put active call on hold first!\n");
return -EBUSY;
}
-   alerting->ring = 0;
-   alerting->hold = 0;
+   alerting->ring = false;
+   alerting->hold = false;

memset(&rsp, 0, sizeof(struct gsm_mncc));
rsp.callref = alerting->callref;

--
To view, visit https://gerrit.osmocom.org/11817
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7eff2a61495ff167dc19fc9a41882a7a11fbf32d
Gerrit-Change-Number: 11817
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Vadim Yanitskiy 

Change in libosmocore[master]: Update GSM0808_LCLS enums

[Max]

Max has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11678 )

Change subject: Update GSM0808_LCLS enums
..

Update GSM0808_LCLS enums

Add values indicating that LCLS control/config/status value has not been
received yet.

Change-Id: I52dc6a52f5ee043ed2c1625ffecfd495e3c746b1
Related: OS#2487
---
M include/osmocom/gsm/protocol/gsm_08_08.h
M src/gsm/gsm0808.c
2 files changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/include/osmocom/gsm/protocol/gsm_08_08.h 
b/include/osmocom/gsm/protocol/gsm_08_08.h
index 2317e78..cb9fe01 100644
--- a/include/osmocom/gsm/protocol/gsm_08_08.h
+++ b/include/osmocom/gsm/protocol/gsm_08_08.h
@@ -576,6 +576,7 @@
GSM0808_LCLS_CFG_BOTH_WAY_AND_SEND_DL_BLOCK_LOCAL_DL= 0x03,
GSM0808_LCLS_CFG_BOTH_WAY_AND_BICAST_UL_SEND_DL = 0x04,
GSM0808_LCLS_CFG_BOTH_WAY_AND_BICAST_UL_SEND_DL_BLOCK_LOCAL_DL  = 0x05,
+   GSM0808_LCLS_CFG_NA = 0xFF
 };

 /* TS 48.008 3.2.2.117 */
@@ -585,6 +586,7 @@
GSM0808_LCLS_CSC_RELEASE_LCLS   = 0x02,
GSM0808_LCLS_CSC_BICAST_UL_AT_HANDOVER  = 0x03,
GSM0808_LCLS_CSC_BICAST_UL_AND_RECV_DL_AT_HANDOVER  = 0x04,
+   GSM0808_LCLS_CSC_NA = 0xFF
 };

 /* TS 48.008 3.2.2.119 */
@@ -594,4 +596,5 @@
GSM0808_LCLS_STS_NO_LONGER_LS   = 0x02,
GSM0808_LCLS_STS_REQ_LCLS_NOT_SUPP  = 0x03,
GSM0808_LCLS_STS_LOCALLY_SWITCHED   = 0x04,
+   GSM0808_LCLS_STS_NA = 0xFF
 };
diff --git a/src/gsm/gsm0808.c b/src/gsm/gsm0808.c
index 791ebc2..c413688 100644
--- a/src/gsm/gsm0808.c
+++ b/src/gsm/gsm0808.c
@@ -1307,6 +1307,7 @@
  "Connect both-way, bi-cast UL to CN, send access DL from CN" },
{ GSM0808_LCLS_CFG_BOTH_WAY_AND_BICAST_UL_SEND_DL_BLOCK_LOCAL_DL,
  "Connect both-way, bi-cast UL to CN, send access DL from CN, block 
local DL" },
+   { GSM0808_LCLS_CFG_NA, "Not available" },
{ 0, NULL }
 };
 
@@ -1316,6 +1317,7 @@
{ GSM0808_LCLS_CSC_RELEASE_LCLS,"Release LCLS" 
},
{ GSM0808_LCLS_CSC_BICAST_UL_AT_HANDOVER,   "Bi-cast UL at 
Handover" },
{ GSM0808_LCLS_CSC_BICAST_UL_AND_RECV_DL_AT_HANDOVER,   "Bi-cast UL and 
receive DL at Handover" },
+   { GSM0808_LCLS_CSC_NA,  "Not available" 
},
{ 0, NULL }
 };

@@ -1325,6 +1327,7 @@
{ GSM0808_LCLS_STS_NO_LONGER_LS,"Call is no longer locally 
switched" },
{ GSM0808_LCLS_STS_REQ_LCLS_NOT_SUPP,   "Requested LCLS configuration 
is not supported" },
{ GSM0808_LCLS_STS_LOCALLY_SWITCHED,"Call is locally switched with 
requested LCLS config" },
+   { GSM0808_LCLS_STS_NA,  "Not available" },
{ 0, NULL }
 };


--
To view, visit https://gerrit.osmocom.org/11678
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I52dc6a52f5ee043ed2c1625ffecfd495e3c746b1
Gerrit-Change-Number: 11678
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 

Change in osmo-bsc[master]: check return value of gsm48_multirate_config()

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11629 )

Change subject: check return value of gsm48_multirate_config()
..

check return value of gsm48_multirate_config()

Check the return value of gsm48_multirate_config() in function
lchan_set_single_amr_mode(). This prevents an invalid AMR mode
from being configured for a logical channel.

Because the VTY parsier limits the AMR mode range to 0-7 this
is just a theoretical issue. However, this fact is beyond the
understanding of a static code analyzer, and the absence of
error handling was indeed setting a bad example.

Change-Id: I61153a44e8b7a38332bf38718397be9b339d5f25
Related: CID#188940
---
M src/osmo-bsc/bsc_vty.c
1 file changed, 21 insertions(+), 6 deletions(-)

Approvals:
  Neels Hofmeyr: Looks good to me, approved
  Pau Espin Pedrol: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c
index b9a5268..f4f5838 100644
--- a/src/osmo-bsc/bsc_vty.c
+++ b/src/osmo-bsc/bsc_vty.c
@@ -4493,10 +4493,11 @@
 }

 /* configure the lchan for a single AMR mode (as specified) */
-static int lchan_set_single_amr_mode(struct gsm_lchan *lchan, uint8_t amr_mode)
+static int lchan_set_single_amr_mode(struct vty *vty, struct gsm_lchan *lchan, 
uint8_t amr_mode)
 {
struct amr_multirate_conf mr;
struct gsm48_multi_rate_conf *mr_conf;
+   int rc, vty_rc = CMD_SUCCESS;
mr_conf = (struct gsm48_multi_rate_conf *) &mr.gsm48_ie;

if (amr_mode > 7)
@@ -4515,10 +4516,22 @@
 
/* encode this configuration into the lchan for both uplink and
 * downlink direction */
-   gsm48_multirate_config(lchan->mr_ms_lv, mr_conf, mr.ms_mode, 
mr.num_modes);
-   gsm48_multirate_config(lchan->mr_bts_lv, mr_conf, mr.bts_mode, 
mr.num_modes);
+   rc = gsm48_multirate_config(lchan->mr_ms_lv, mr_conf, mr.ms_mode, 
mr.num_modes);
+   if (rc != 0) {
+   vty_out(vty,
+   "Invalid AMR multirate configuration (%s, amr mode %d, 
ms) - check parameters%s",
+   gsm_lchant_name(lchan->type), amr_mode, VTY_NEWLINE);
+   vty_rc = CMD_WARNING;
+   }
+   rc = gsm48_multirate_config(lchan->mr_bts_lv, mr_conf, mr.bts_mode, 
mr.num_modes);
+   if (rc != 0) {
+   vty_out(vty,
+   "Invalid AMR multirate configuration (%s, amr mode %d, 
bts) - check parameters%s",
+   gsm_lchant_name(lchan->type), amr_mode, VTY_NEWLINE);
+   vty_rc = CMD_WARNING;
+   }

-   return 0;
+   return vty_rc;
 }

 /* Debug/Measurement command to activate a given logical channel
@@ -4574,14 +4587,16 @@
else if (!strcmp(codec_str, "efr"))
lchan->tch_mode = GSM48_CMODE_SPEECH_EFR;
else if (!strcmp(codec_str, "amr")) {
-   int amr_mode;
+   int amr_mode, vty_rc;
if (argc < 7) {
vty_out(vty, "%% AMR requires specification of 
AMR mode%s", VTY_NEWLINE);
return CMD_WARNING;
}
amr_mode = atoi(argv[6]);
lchan->tch_mode = GSM48_CMODE_SPEECH_AMR;
-   lchan_set_single_amr_mode(lchan, amr_mode);
+   vty_rc = lchan_set_single_amr_mode(vty, lchan, 
amr_mode);
+   if (vty_rc != CMD_SUCCESS)
+   return vty_rc;
}
vty_out(vty, "%% activating lchan %s%s", gsm_lchan_name(lchan), 
VTY_NEWLINE);
rsl_tx_chan_activ(lchan, RSL_ACT_TYPE_INITIAL, 0);

--
To view, visit https://gerrit.osmocom.org/11629
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I61153a44e8b7a38332bf38718397be9b339d5f25
Gerrit-Change-Number: 11629
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmo-ttcn3-hacks[master]: start implementing the TC_paging() PCU test

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9374 )

Change subject: start implementing the TC_paging() PCU test
..


Patch Set 6: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9374
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id0384e0742ab91983615e4f1c883bb044c1c8b18
Gerrit-Change-Number: 9374
Gerrit-PatchSet: 6
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-CC: Neels Hofmeyr 
Gerrit-Comment-Date: Sun, 18 Nov 2018 20:21:21 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: osmo-bsc: gsm_timers_vty: Set global T_defs during vty_init

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11710 )

Change subject: osmo-bsc: gsm_timers_vty: Set global T_defs during vty_init
..

osmo-bsc: gsm_timers_vty: Set global T_defs during vty_init

Otherwise any use of functions in gsm_timers_vty.c will fail because
g_vty_T_defs is never set (so it is NULL).

Change-Id: Ieeb27fdb06c965fa6b70aeb0f3b3f5169b1f2012
---
M src/osmo-bsc/gsm_timers_vty.c
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/gsm_timers_vty.c b/src/osmo-bsc/gsm_timers_vty.c
index 8a13259..de61e24 100644
--- a/src/osmo-bsc/gsm_timers_vty.c
+++ b/src/osmo-bsc/gsm_timers_vty.c
@@ -102,6 +102,7 @@
 /* Install GSM timer configuration commands in the VTY. */
 void T_defs_vty_init(struct T_def *T_defs, int cfg_parent_node)
 {
+   g_vty_T_defs = T_defs;
install_element_ve(&show_timer_cmd);
install_element(cfg_parent_node, &cfg_timer_cmd);
 }

--
To view, visit https://gerrit.osmocom.org/11710
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieeb27fdb06c965fa6b70aeb0f3b3f5169b1f2012
Gerrit-Change-Number: 11710
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-bsc[master]: osmo-bsc: gsm_timers_vty: Set global T_defs during vty_init

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11710 )

Change subject: osmo-bsc: gsm_timers_vty: Set global T_defs during vty_init
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11710
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieeb27fdb06c965fa6b70aeb0f3b3f5169b1f2012
Gerrit-Change-Number: 11710
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sun, 18 Nov 2018 20:22:40 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: ipaccess-config: Use stderr for debug type messages when using -G

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11687 )

Change subject: ipaccess-config: Use stderr for debug type messages when using 
-G
..


Patch Set 6: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/11687
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I257bfc8d82b49a3641be6b6777e472ecf561a21e
Gerrit-Change-Number: 11687
Gerrit-PatchSet: 6
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Sun, 18 Nov 2018 20:23:23 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: LCLS: add bts-loop variant

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11552 )

Change subject: LCLS: add bts-loop variant
..


Patch Set 6: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11552
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e8379f31037f2c48da69a01919701919a3066a2
Gerrit-Change-Number: 11552
Gerrit-PatchSet: 6
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Sun, 18 Nov 2018 20:25:07 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: always directly send BSSMAP Clear Request

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11700 )

Change subject: always directly send BSSMAP Clear Request
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11700
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39fae24260a4bb7a6af704ebe760f93fff566536
Gerrit-Change-Number: 11700
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Sun, 18 Nov 2018 20:25:59 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: bsc: add inter-bsc ho incoming failure tests

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11699 )

Change subject: bsc: add inter-bsc ho incoming failure tests
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11699
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I849e4c0a14cc091195d948adb8df7a0b7414ecfe
Gerrit-Change-Number: 11699
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: osmith 
Gerrit-Comment-Date: Sun, 18 Nov 2018 20:26:23 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: always directly send BSSMAP Clear Request

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11700 )

Change subject: always directly send BSSMAP Clear Request
..

always directly send BSSMAP Clear Request

When a gscon wants to send a BSSMAP Clear Request, it makes no sense to do it
conditionally depending on the current conn state. Just send it: don't call
gscon_sigtran_send(), directly go for osmo_bsc_sigtran_send().

In particular, if an incoming inter-BSC handover ends in failure, the gscon
state is still ST_INIT, but if the MSC fails to give us a Clear Command, we may
want to ask with a BSSMAP Clear Request.

Change-Id: I39fae24260a4bb7a6af704ebe760f93fff566536
---
M src/osmo-bsc/bsc_subscr_conn_fsm.c
1 file changed, 8 insertions(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  osmith: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/bsc_subscr_conn_fsm.c 
b/src/osmo-bsc/bsc_subscr_conn_fsm.c
index d2ca03e..074c238 100644
--- a/src/osmo-bsc/bsc_subscr_conn_fsm.c
+++ b/src/osmo-bsc/bsc_subscr_conn_fsm.c
@@ -134,7 +134,14 @@
   enum gsm0808_cause cause)
 {
struct msgb *resp = gsm0808_create_clear_rqst(cause);
-   gscon_sigtran_send(conn, resp);
+   int rc;
+   if (!resp) {
+   LOGPFSML(conn->fi, LOGL_ERROR, "Unable to compose BSSMAP Clear 
Request message\n");
+   return;
+   }
+   rc = osmo_bsc_sigtran_send(conn, resp);
+   if (rc < 0)
+   LOGPFSML(conn->fi, LOGL_ERROR, "Unable to deliver BSSMAP Clear 
Request message\n");
 }

 /* forward MO DTAP from RSL side to BSSAP side */

--
To view, visit https://gerrit.osmocom.org/11700
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I39fae24260a4bb7a6af704ebe760f93fff566536
Gerrit-Change-Number: 11700
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: osmith 

Change in osmo-ttcn3-hacks[master]: bsc: add inter-bsc ho incoming failure tests

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11699 )

Change subject: bsc: add inter-bsc ho incoming failure tests
..


Patch Set 1:

great, but indeed the whitespaces could be removed before merge. up to you!


--
To view, visit https://gerrit.osmocom.org/11699
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I849e4c0a14cc091195d948adb8df7a0b7414ecfe
Gerrit-Change-Number: 11699
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: osmith 
Gerrit-Comment-Date: Sun, 18 Nov 2018 20:26:37 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: support odd-length calling MSISDN in MSC tests

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11743 )

Change subject: support odd-length calling MSISDN in MSC tests
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11743
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I34439c8750f588802a5403375e2a3d6e74dae70c
Gerrit-Change-Number: 11743
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Sun, 18 Nov 2018 20:27:51 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: support odd-length calling MSISDN in MSC tests

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11743 )

Change subject: support odd-length calling MSISDN in MSC tests
..

support odd-length calling MSISDN in MSC tests

MSC tests were unable to match odd-length digit strings in
a CallingPartyBCD_Number template created by tr_Calling().
This happens because the raw encoder for CallingPartyBCD_Number
pads odd-length digits with 1-bits ('F'H). Do the same when
constructing such a template in our own code to ensure that
we'll match the actual data received.

Change-Id: I34439c8750f588802a5403375e2a3d6e74dae70c
Related: OS#2930
---
M library/L3_Templates.ttcn
M msc/MSC_Tests.ttcn
2 files changed, 12 insertions(+), 5 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/library/L3_Templates.ttcn b/library/L3_Templates.ttcn
index 52d4a2a..e109fde 100644
--- a/library/L3_Templates.ttcn
+++ b/library/L3_Templates.ttcn
@@ -838,11 +838,20 @@
digits := digits
 }

+private function f_pad_digits(hexstring digits) return hexstring {
+   if (lengthof(digits) mod 2 != 0) {
+   /* Add trailing nibble of 1-bit padding, like the 
CallingPartyBCD_Number encoder would do.
+* Otherwise our template won't match the data received (see 
OS#2930). */
+   return digits & 'F'H;
+   }
+   return digits;
+}
+
 template CallingPartyBCD_Number tr_Calling(template hexstring digits) := {
elementIdentifier := '5C'O,
lengthIndicator := ?,
oct3 := ?,
-   digits := digits
+   digits := f_pad_digits(valueof(digits))
 }

 type integer SpeechVer;
diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn
index c0cd9d3..2a6c034 100644
--- a/msc/MSC_Tests.ttcn
+++ b/msc/MSC_Tests.ttcn
@@ -1722,8 +1722,7 @@
 /* LU followed by MT call (including paging) */
 private function f_tc_lu_and_mt_call(charstring id, BSC_ConnHdlrPars pars) 
runs on BSC_ConnHdlr {
f_init_handler(pars);
-   //FIXME: odd digits var CallParameters cpars := 
valueof(t_CallParams('12345'H, 0));
-   var CallParameters cpars := valueof(t_CallParams('123456'H, 0));
+   var CallParameters cpars := valueof(t_CallParams('12345'H, 0));
cpars.bss_rtp_port := 1110;
cpars.mgcp_connection_id_bss := '10004'H;
cpars.mgcp_connection_id_mss := '10005'H;
@@ -1845,8 +1844,7 @@
 /* LU followed by MT call (including paging) */
 private function f_tc_lu_and_mt_call_no_dlcx_resp(charstring id, 
BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr {
f_init_handler(pars);
-   //FIXME: odd digits var CallParameters cpars := 
valueof(t_CallParams('12345'H, 0));
-   var CallParameters cpars := valueof(t_CallParams('123456'H, 0));
+   var CallParameters cpars := valueof(t_CallParams('12345'H, 0));
cpars.bss_rtp_port := 1110;
cpars.mgcp_connection_id_bss := '10004'H;
cpars.mgcp_connection_id_mss := '10005'H;

--
To view, visit https://gerrit.osmocom.org/11743
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I34439c8750f588802a5403375e2a3d6e74dae70c
Gerrit-Change-Number: 11743
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Reviewer: Vadim Yanitskiy 

Change in osmo-bts[master]: bts: Allocate TRX for BTS dynamically, deprecate -t

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11735 )

Change subject: bts: Allocate TRX for BTS dynamically, deprecate -t
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11735
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab1a754ab12a626759f9f90aa66f87bdce65ac9c
Gerrit-Change-Number: 11735
Gerrit-PatchSet: 3
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Sun, 18 Nov 2018 20:29:38 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bts[master]: bts: Allocate TRX for BTS dynamically, deprecate -t

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11735 )

Change subject: bts: Allocate TRX for BTS dynamically, deprecate -t
..

bts: Allocate TRX for BTS dynamically, deprecate -t

No need to pass -t num_trx anymore to specify number of TRX to use. It
is calculated based on dynamic allocation from VTY config.
Using parameter -t is flagged as deprecated and is transformed into a
NOOP por backward compatibility.

As a result, TRX now are allocated after the BTS is allocated and
initial config (pre-VTY) is applied.
A new function bts_trx_init() is added, to set default config on each
TRX during allocation and before setting VTY config on it.
A new per BTS model function bts_model_trx_init() is added, to allow
per model specific default configuration of each TRX.

Change-Id: Iab1a754ab12a626759f9f90aa66f87bdce65ac9c
---
M include/osmo-bts/bts.h
M include/osmo-bts/bts_model.h
M src/common/bts.c
M src/common/main.c
M src/common/vty.c
M src/osmo-bts-litecell15/main.c
M src/osmo-bts-oc2g/main.c
M src/osmo-bts-octphy/l1_if.c
M src/osmo-bts-omldummy/bts_model.c
M src/osmo-bts-sysmo/main.c
M src/osmo-bts-trx/main.c
M src/osmo-bts-virtual/main.c
M tests/handover/handover_test.c
M tests/meas/meas_test.c
M tests/stubs.c
M tests/sysmobts/sysmobts_test.c
16 files changed, 119 insertions(+), 61 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/include/osmo-bts/bts.h b/include/osmo-bts/bts.h
index 34ba956..d7c4bbf 100644
--- a/include/osmo-bts/bts.h
+++ b/include/osmo-bts/bts.h
@@ -27,6 +27,7 @@
 extern void *tall_bts_ctx;

 int bts_init(struct gsm_bts *bts);
+int bts_trx_init(struct gsm_bts_trx *trx);
 void bts_shutdown(struct gsm_bts *bts, const char *reason);

 struct gsm_bts *create_bts(uint8_t num_trx, char *id);
diff --git a/include/osmo-bts/bts_model.h b/include/osmo-bts/bts_model.h
index 7a87d78..f1f6830 100644
--- a/include/osmo-bts/bts_model.h
+++ b/include/osmo-bts/bts_model.h
@@ -14,6 +14,7 @@
 /* BTS model specific functions needed by the common code */

 int bts_model_init(struct gsm_bts *bts);
+int bts_model_trx_init(struct gsm_bts_trx *trx);

 int bts_model_check_oml(struct gsm_bts *bts, uint8_t msg_type,
struct tlv_parsed *old_attr, struct tlv_parsed 
*new_attr,
diff --git a/src/common/bts.c b/src/common/bts.c
index c251fdd..68cb167 100644
--- a/src/common/bts.c
+++ b/src/common/bts.c
@@ -105,11 +105,10 @@
bts_ctr_desc
 };

-/* Initialize the BTS (and TRX) data structures, called before config
+/* Initialize the BTS data structures, called before config
  * file reading */
 int bts_init(struct gsm_bts *bts)
 {
-   struct gsm_bts_trx *trx;
int rc, i;
static int initialized = 0;
void *tall_rtp_ctx;
@@ -167,26 +166,6 @@
oml_mo_state_init(&bts->gprs.nsvc[0].mo, -1, NM_AVSTATE_DEPENDENCY);
oml_mo_state_init(&bts->gprs.nsvc[1].mo, NM_OPSTATE_DISABLED, 
NM_AVSTATE_OFF_LINE);

-   /* initialize bts data structure */
-   llist_for_each_entry(trx, &bts->trx_list, list) {
-   struct trx_power_params *tpp = &trx->power_params;
-   int i;
-
-   for (i = 0; i < ARRAY_SIZE(trx->ts); i++) {
-   struct gsm_bts_trx_ts *ts = &trx->ts[i];
-   int k;
-
-   for (k = 0; k < ARRAY_SIZE(ts->lchan); k++) {
-   struct gsm_lchan *lchan = &ts->lchan[k];
-   INIT_LLIST_HEAD(&lchan->dl_tch_queue);
-   }
-   }
-   /* Default values for the power adjustments */
-   tpp->ramp.max_initial_pout_mdBm = to_mdB(0);
-   tpp->ramp.step_size_mdB = to_mdB(2);
-   tpp->ramp.step_interval_sec = 1;
-   }
-
/* allocate a talloc pool for ORTP to ensure it doesn't have to go back
 * to the libc malloc all the time */
tall_rtp_ctx = talloc_pool(tall_bts_ctx, 262144);
@@ -215,6 +194,36 @@
return rc;
 }

+/* Initialize the TRX data structures, called before config
+ * file reading */
+int bts_trx_init(struct gsm_bts_trx *trx)
+{
+   /* initialize bts data structure */
+   struct trx_power_params *tpp = &trx->power_params;
+   int rc, i;
+
+   for (i = 0; i < ARRAY_SIZE(trx->ts); i++) {
+   struct gsm_bts_trx_ts *ts = &trx->ts[i];
+   int k;
+
+   for (k = 0; k < ARRAY_SIZE(ts->lchan); k++) {
+   struct gsm_lchan *lchan = &ts->lchan[k];
+   INIT_LLIST_HEAD(&lchan->dl_tch_queue);
+   }
+   }
+   /* Default values for the power adjustments */
+   tpp->ramp.max_initial_pout_mdBm = to_mdB(0);
+   tpp->ramp.step_size_mdB = to_mdB(2);
+   tpp->ramp.step_interval_se

Change in libosmocore[master]: Support cipher mode reject with extended cause

[Max]

Hello Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11601

to look at the new patch set (#7).

Change subject: Support cipher mode reject with extended cause
..

Support cipher mode reject with extended cause

* add function to generate cipher mode reject with extended (2-byte)
  Cause IE
* add function to get (extended) Cause value
* add corresponding (extended cause) test
* update existing (non-extended cause) test
* use enum as a parameter for existing non-extended version to make
  interface more unified

Change-Id: Id5509b94a18180a44f45300caaa02b843c166fa3
Related: OS#3187
---
M include/osmocom/gsm/gsm0808.h
M include/osmocom/gsm/gsm0808_utils.h
M src/gsm/gsm0808.c
M src/gsm/gsm0808_utils.c
M src/gsm/libosmogsm.map
M tests/gsm0808/gsm0808_test.c
M tests/gsm0808/gsm0808_test.ok
7 files changed, 89 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/01/11601/7
--
To view, visit https://gerrit.osmocom.org/11601
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id5509b94a18180a44f45300caaa02b843c166fa3
Gerrit-Change-Number: 11601
Gerrit-PatchSet: 7
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-CC: Vadim Yanitskiy 

Change in osmo-gsm-tester[master]: default-suites: Enable tests for LimeSDR-USB

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11745 )

Change subject: default-suites: Enable tests for LimeSDR-USB
..

default-suites: Enable tests for LimeSDR-USB

Change-Id: I896ea76f1d2847ec014a62c87220d184b95d1dd2
---
M example/default-suites.conf
1 file changed, 20 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/example/default-suites.conf b/example/default-suites.conf
index df79232..07b8a5f 100644
--- a/example/default-suites.conf
+++ b/example/default-suites.conf
@@ -74,6 +74,26 @@
 - dynts:trx-umtrx+mod-bts0-dynts67-ipa+cfg-codec-fr-any
 - dynts:trx-umtrx+mod-bts0-dynts67-osmo

+- nitb_sms:trx-lms
+- sms:trx-lms
+- nitb_ussd:trx-lms
+- ussd:trx-lms
+- voice:trx-lms+mod-bts0-ts-tchf+cfg-codec-fr1
+- voice:trx-lms+mod-bts0-ts-tchf+cfg-codec-fr2
+- voice:trx-lms+mod-bts0-ts-tchf+cfg-codec-fr3
+- voice:trx-lms+mod-bts0-ts-tchh+cfg-codec-hr1
+- voice:trx-lms+mod-bts0-ts-tchh+cfg-codec-hr3
+- voice:trx-lms+mod-bts0-dynts-ipa+cfg-codec-fr-any
+- voice:trx-lms+mod-bts0-dynts-osmo
+- voice:trx-lms+mod-bts0-numtrx2+mod-bts0-chanallocdescend
+- gprs:trx-lms
+- gprs:trx-lms+mod-bts0-egprs
+- gprs:trx-lms+mod-bts0-dynts-ipa
+- gprs:trx-lms+mod-bts0-dynts-osmo
+- gprs:trx-lms+mod-bts0-numtrx2+mod-bts0-chanallocdescend
+- dynts:trx-lms+mod-bts0-dynts67-ipa+cfg-codec-fr-any
+- dynts:trx-lms+mod-bts0-dynts67-osmo
+
 - nitb_sms:nanobts
 - sms:nanobts+band-1900
 - nitb_ussd:nanobts+band-1900

--
To view, visit https://gerrit.osmocom.org/11745
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I896ea76f1d2847ec014a62c87220d184b95d1dd2
Gerrit-Change-Number: 11745
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-gsm-tester[master]: default-suites: Enable tests for LimeSDR-USB

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11745 )

Change subject: default-suites: Enable tests for LimeSDR-USB
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11745
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I896ea76f1d2847ec014a62c87220d184b95d1dd2
Gerrit-Change-Number: 11745
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sun, 18 Nov 2018 20:30:00 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: Store subscriber's cell identity

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11746 )

Change subject: Store subscriber's cell identity
..


Patch Set 1:

can you please point me to the spec reference that states the CI is part of the 
GCR?


--
To view, visit https://gerrit.osmocom.org/11746
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8544c30ea800ce8356a227b03a8b21bf3252be7e
Gerrit-Change-Number: 11746
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Sun, 18 Nov 2018 20:32:37 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-remsim[master]: minor: show USB error message instead of number

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11754 )

Change subject: minor: show USB error message instead of number
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11754
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I272ac1be82b7432934969ea4d204dd20067d9428
Gerrit-Change-Number: 11754
Gerrit-PatchSet: 1
Gerrit-Owner: Kévin Redon 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sun, 18 Nov 2018 20:33:15 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-remsim[master]: minor: show USB error message instead of number

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11754 )

Change subject: minor: show USB error message instead of number
..

minor: show USB error message instead of number

Change-Id: I272ac1be82b7432934969ea4d204dd20067d9428
---
M src/simtrace2-remsim_client.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/simtrace2-remsim_client.c b/src/simtrace2-remsim_client.c
index f033e7d..1cf09a6 100644
--- a/src/simtrace2-remsim_client.c
+++ b/src/simtrace2-remsim_client.c
@@ -465,7 +465,7 @@
if (rc < 0 && rc != LIBUSB_ERROR_TIMEOUT &&
rc != LIBUSB_ERROR_INTERRUPTED &&
rc != LIBUSB_ERROR_IO) {
-   fprintf(stderr, "BULK IN transfer error; rc=%d\n", rc);
+   fprintf(stderr, "BULK IN transfer error: %s\n", 
libusb_error_name(rc));
return;
}
/* dispatch any incoming data */

--
To view, visit https://gerrit.osmocom.org/11754
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I272ac1be82b7432934969ea4d204dd20067d9428
Gerrit-Change-Number: 11754
Gerrit-PatchSet: 1
Gerrit-Owner: Kévin Redon 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-remsim[master]: add ATR as command line argument

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11753 )

Change subject: add ATR as command line argument
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11753
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1084abdf2318e96c22f8e69cc1ef161b12ef5ea
Gerrit-Change-Number: 11753
Gerrit-PatchSet: 1
Gerrit-Owner: Kévin Redon 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sun, 18 Nov 2018 20:33:05 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-remsim[master]: add ATR as command line argument

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11753 )

Change subject: add ATR as command line argument
..

add ATR as command line argument

we could add a function checking the ATR validity
also before updating the (conditional) checksum we should check if
it is actually present in the ATR

Change-Id: Id1084abdf2318e96c22f8e69cc1ef161b12ef5ea
---
M src/simtrace2-remsim_client.c
1 file changed, 16 insertions(+), 4 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/simtrace2-remsim_client.c b/src/simtrace2-remsim_client.c
index 365acb4..f033e7d 100644
--- a/src/simtrace2-remsim_client.c
+++ b/src/simtrace2-remsim_client.c
@@ -245,6 +245,7 @@
return st_slot_tx_msg(ci->slot, msg, SIMTRACE_MSGC_CARDEM, 
SIMTRACE_MSGT_DT_CEMU_TX_DATA);
 }

+// FIXME check if the ATR actually includes a checksum
 static void atr_update_csum(uint8_t *atr, unsigned int atr_len)
 {
uint8_t csum = 0;
@@ -617,6 +618,7 @@
"\t-S\t--usb-altsetting ALTSETTING_ID\n"
"\t-A\t--usb-address\tADDRESS\n"
"\t-H\t--usb-path\tPATH\n"
+   "\t-a\t--atr\tATR\n"
"\n"
);
 }
@@ -636,6 +638,7 @@
{ "usb-altsetting", 1, 0, 'S' },
{ "usb-address", 1, 0, 'A' },
{ "usb-path", 1, 0, 'H' },
+   { "atr", 1, 0, 'a' },
{ NULL, 0, 0, 0 }
 };

@@ -652,13 +655,15 @@
int config_id = -1, altsetting = 0, addr = -1;
char *bankd_host = "127.0.0.1";
char *path = NULL;
+   uint8_t atr_data[33] = { 0x3B, 0x00 }; // the shortest simplest ATR 
possible
+   uint8_t atr_len = 2;

print_welcome();

while (1) {
int option_index = 0;

-   c = getopt_long(argc, argv, "b:p:c:s:hi:V:P:C:I:S:A:H:k", opts, 
&option_index);
+   c = getopt_long(argc, argv, "b:p:c:s:hi:V:P:C:I:S:A:H:a:k", 
opts, &option_index);
if (c == -1)
break;
switch (c) {
@@ -705,6 +710,14 @@
case 'H':
path = optarg;
break;
+   case 'a':
+   rc = osmo_hexparse(optarg, atr_data, 
ARRAY_SIZE(atr_data));
+   if (rc < 2 || rc > ARRAY_SIZE(atr_data)) {
+   fprintf(stderr, "ATR matlformed\n");
+   goto do_exit;
+   }
+   atr_len = rc;
+   break;
}
}
 
@@ -839,9 +852,8 @@
st_modem_sim_select_remote(ci->slot);

/* set the ATR */
-   uint8_t real_atr[] = { 0x3B, 0x00 }; // the shortest simplest 
ATR possible
-   atr_update_csum(real_atr, sizeof(real_atr));
-   cardem_request_set_atr(ci, real_atr, sizeof(real_atr));
+   //atr_update_csum(real_atr, sizeof(real_atr));
+   cardem_request_set_atr(ci, atr_data, atr_len);

/* select remote (forwarded) SIM */
st_modem_reset_pulse(ci->slot, 300);

--
To view, visit https://gerrit.osmocom.org/11753
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id1084abdf2318e96c22f8e69cc1ef161b12ef5ea
Gerrit-Change-Number: 11753
Gerrit-PatchSet: 1
Gerrit-Owner: Kévin Redon 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-ttcn3-hacks[master]: BSC_Tests: expect a HANDOVER PERFORMED message on internal handover

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11733 )

Change subject: BSC_Tests: expect a HANDOVER PERFORMED message on internal 
handover
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11733
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10f4e578c96a90317939ba49b61b14a3c7e488a7
Gerrit-Change-Number: 11733
Gerrit-PatchSet: 2
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: dexter 
Gerrit-Comment-Date: Sun, 18 Nov 2018 20:34:40 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: BSSMAP_Templates: Add missing field in tr_BSSMAP_HandoverPerformed te...

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11731 )

Change subject: BSSMAP_Templates: Add missing field in 
tr_BSSMAP_HandoverPerformed template
..

BSSMAP_Templates: Add missing field in tr_BSSMAP_HandoverPerformed template

tr_BSSMAP_HandoverPerformed lacks the field speechVersion, lets add it
to make the template complete.

Change-Id: Id73c0aef5caa0936aa44308faf2aae1c20c7446c
Related OS#3645
---
M library/BSSMAP_Templates.ttcn
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/library/BSSMAP_Templates.ttcn b/library/BSSMAP_Templates.ttcn
index d00a5ab..5b943e9 100644
--- a/library/BSSMAP_Templates.ttcn
+++ b/library/BSSMAP_Templates.ttcn
@@ -833,6 +833,7 @@
cellIdentifier := ?,
chosenChannel := omit,
chosenEncryptionAlgorithm := omit,
+   speechVersion := omit,
lSAIdentifier := omit,
talkerPriority := omit,
codecList := omit,

--
To view, visit https://gerrit.osmocom.org/11731
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id73c0aef5caa0936aa44308faf2aae1c20c7446c
Gerrit-Change-Number: 11731
Gerrit-PatchSet: 3
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmo-ttcn3-hacks[master]: MSC_Tests: remove unused control interface

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11690 )

Change subject: MSC_Tests: remove unused control interface
..


Patch Set 3: Code-Review-1

where does that restriction come from?  I'm not aware that we can only accept a 
single CTRL client from the libosmocore.git implementation ?!?


--
To view, visit https://gerrit.osmocom.org/11690
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I204b2e96057d13342f4bd4fdaf08fb7b88b6b11d
Gerrit-Change-Number: 11690
Gerrit-PatchSet: 3
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: dexter 
Gerrit-Comment-Date: Sun, 18 Nov 2018 20:36:36 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bts[master]: bts-trx: Allow re-try without exit if POWERON fails in osmo-trx

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11768 )

Change subject: bts-trx: Allow re-try without exit if POWERON fails in osmo-trx
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11768
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa8f497381038fd7f9f779a8211ebc6453837c65
Gerrit-Change-Number: 11768
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sun, 18 Nov 2018 20:37:32 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bts[master]: common: Implement OML for trx_set_available(1)

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11767 )

Change subject: common: Implement OML for trx_set_available(1)
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11767
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ba32c162a8a98ed0fdd4190227de66270679e5a
Gerrit-Change-Number: 11767
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sun, 18 Nov 2018 20:37:16 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Jenkins build is back to normal : master-osmo-sip-connector » a1=default,a2=default,a3=default,osmocom-master-debian9 #881

[jenkins]

See 

Change in osmo-bts[master]: bts-trx: setup timer once at creation time

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11766 )

Change subject: bts-trx: setup timer once at creation time
..


Patch Set 1:

commit log could be more verbose.  It describes the *what* but not the *why*


--
To view, visit https://gerrit.osmocom.org/11766
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b6461d0130d25284e673c5efce0b3832c48bbb5
Gerrit-Change-Number: 11766
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Sun, 18 Nov 2018 20:39:21 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-gsm-manuals[master]: hlr: update vty reference

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11585 )

Change subject: hlr: update vty reference
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11585
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a2322c0488cb36b089303bbfec5d4db18c41099
Gerrit-Change-Number: 11585
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sun, 18 Nov 2018 20:41:05 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-gsm-manuals[master]: mgw: update vty reference

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11586 )

Change subject: mgw: update vty reference
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11586
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib30ea8b02f8a950648b85e7ebc96a40ba5a36b34
Gerrit-Change-Number: 11586
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sun, 18 Nov 2018 20:41:08 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bts[master]: bts-trx: trx_if: Use struct to store CTRL msg parsed responses

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11765 )

Change subject: bts-trx: trx_if: Use struct to store CTRL msg parsed responses
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11765
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb84bce0621042afa4301678ba1cc58d8e3662bb
Gerrit-Change-Number: 11765
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-CC: Vadim Yanitskiy 
Gerrit-Comment-Date: Sun, 18 Nov 2018 20:40:16 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-gsm-manuals[master]: sgsn: update vty reference

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11588 )

Change subject: sgsn: update vty reference
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11588
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I64d775efa6791aca025d116905e951e10ffa5d04
Gerrit-Change-Number: 11588
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sun, 18 Nov 2018 20:41:16 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-gsm-manuals[master]: ggsn: update vty reference

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11584 )

Change subject: ggsn: update vty reference
..

ggsn: update vty reference

Change-Id: I8a5c37505c0180d5c04c7792d6d0afdb0dffb282
---
M OsmoGGSN/vty/ggsn_vty_reference.xml
1 file changed, 118 insertions(+), 44 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/OsmoGGSN/vty/ggsn_vty_reference.xml 
b/OsmoGGSN/vty/ggsn_vty_reference.xml
index 7a43263..7460026 100644
--- a/OsmoGGSN/vty/ggsn_vty_reference.xml
+++ b/OsmoGGSN/vty/ggsn_vty_reference.xml
@@ -85,12 +85,6 @@
 
   
 
-
-  
-
-
-  
-
 
   
 
@@ -175,7 +169,7 @@
 
   
 
-
+
   
 
 
@@ -183,6 +177,7 @@
 
 
 
+
   
 
 
@@ -192,20 +187,10 @@
 
   
 
-
-  
-
-
-
-
-
-  
-
-
+
   
 
 
-
 
 
 
@@ -229,7 +214,6 @@
 
 
 
-
 
 
 
@@ -237,6 +221,38 @@
 
   
 
+
+  
+
+
+
+
+
+
+
+
+  
+
+
+  
+
+
+
+
+
+
+
+
+  
+
+
+  
+
+
+
+
+  
+
 
   
 
@@ -310,6 +326,12 @@
 
   
 
+
+  
+
+
+  
+
 
   
 
@@ -389,12 +411,6 @@
 
   
 
-
-  
-
-
-  
-
 
   
 
@@ -492,7 +508,7 @@
 
   
 
-
+
   
 
 
@@ -500,6 +516,7 @@
 
 
 
+
   
 
 
@@ -509,20 +526,10 @@
 
   
 
-
-  
-
-
-
-
-
-  
-
-
+
   
 
 
-
 
 
 
@@ -546,7 +553,6 @@
 
 
 
-
 
 
 
@@ -554,6 +560,38 @@
 
   
 
+
+  
+
+
+
+
+
+
+
+
+  
+
+
+  
+
+
+
+
+
+
+
+
+  
+
+
+  
+
+
+
+
+  
+
 
   
 
@@ -627,6 +665,12 @@
 
   
 
+
+  
+
+
+  
+
 
   
 
@@ -777,8 +821,7 @@
 
   
 
-
-
+
   
 
 
@@ -966,7 +1009,7 @@
 
   
 
-
+
   
 
 
@@ -974,13 +1017,13 @@
 
 
 
+
   
 
-
+
   
 
 
-
 
 
 
@@ -1004,7 +1047,6 @@
 
 
 
-
 
 
 
@@ -1012,6 +1054,38 @@
 
   
 
+
+  
+
+
+
+
+
+
+
+
+  
+
+
+  
+
+
+
+
+
+
+
+
+  
+
+
+  
+
+
+
+
+  
+
   
   
 config-stats

--
To view, visit https://gerrit.osmocom.org/11584
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8a5c37505c0180d5c04c7792d6d0afdb0dffb282
Gerrit-Change-Number: 11584
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-gsm-manuals[master]: mgw: update vty reference

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11586 )

Change subject: mgw: update vty reference
..

mgw: update vty reference

Change-Id: Ib30ea8b02f8a950648b85e7ebc96a40ba5a36b34
---
M OsmoMGW/vty/mgw_vty_reference.xml
1 file changed, 146 insertions(+), 14 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/OsmoMGW/vty/mgw_vty_reference.xml 
b/OsmoMGW/vty/mgw_vty_reference.xml
index f11f484..834db04 100644
--- a/OsmoMGW/vty/mgw_vty_reference.xml
+++ b/OsmoMGW/vty/mgw_vty_reference.xml
@@ -169,7 +169,7 @@
 
   
 
-
+
   
 
 
@@ -177,6 +177,7 @@
 
 
 
+
   
 
 
@@ -186,12 +187,12 @@
 
   
 
-
+
   
 
 
-
 
+
 
 
 
@@ -210,7 +211,6 @@
 
 
 
-
 
 
 
@@ -218,6 +218,38 @@
 
   
 
+
+  
+
+
+
+
+
+
+
+
+  
+
+
+  
+
+
+
+
+
+
+
+
+  
+
+
+  
+
+
+
+
+  
+
 
   
 
@@ -304,6 +336,24 @@
 
   
 
+
+  
+
+
+
+
+  
+
+
+  
+
+
+
+
+
+
+  
+
   
   
 enable
@@ -454,7 +504,7 @@
 
   
 
-
+
   
 
 
@@ -462,6 +512,7 @@
 
 
 
+
   
 
 
@@ -471,12 +522,12 @@
 
   
 
-
+
   
 
 
-
 
+
 
 
 
@@ -495,7 +546,6 @@
 
 
 
-
 
 
 
@@ -503,6 +553,38 @@
 
   
 
+
+  
+
+
+
+
+
+
+
+
+  
+
+
+  
+
+
+
+
+
+
+
+
+  
+
+
+  
+
+
+
+
+  
+
 
   
 
@@ -589,6 +671,24 @@
 
   
 
+
+  
+
+
+
+
+  
+
+
+  
+
+
+
+
+
+
+  
+
 
   
 
@@ -929,7 +1029,7 @@
 
   
 
-
+
   
 
 
@@ -937,14 +1037,15 @@
 
 
 
+
   
 
-
+
   
 
 
-
 
+
 
 
 
@@ -963,7 +1064,6 @@
 
 
 
-
 
 
 
@@ -971,6 +1071,38 @@
 
   
 
+
+  
+
+
+
+
+
+
+
+
+  
+
+
+  
+
+
+
+
+
+
+
+
+  
+
+
+  
+
+
+
+
+  
+
   
   
 config-stats
@@ -1360,8 +1492,8 @@
 
 
   
-
-
+
+
   
 
 

--
To view, visit https://gerrit.osmocom.org/11586
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib30ea8b02f8a950648b85e7ebc96a40ba5a36b34
Gerrit-Change-Number: 11586
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-gsm-manuals[master]: sgsn: update vty reference

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11588 )

Change subject: sgsn: update vty reference
..

sgsn: update vty reference

Change-Id: I64d775efa6791aca025d116905e951e10ffa5d04
---
M OsmoSGSN/vty/sgsn_vty_reference.xml
1 file changed, 252 insertions(+), 55 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/OsmoSGSN/vty/sgsn_vty_reference.xml 
b/OsmoSGSN/vty/sgsn_vty_reference.xml
index f6e4016..52d4213 100644
--- a/OsmoSGSN/vty/sgsn_vty_reference.xml
+++ b/OsmoSGSN/vty/sgsn_vty_reference.xml
@@ -85,12 +85,6 @@
 
   
 
-
-  
-
-
-  
-
 
   
 
@@ -175,7 +169,7 @@
 
   
 
-
+
   
 
 
@@ -183,6 +177,7 @@
 
 
 
+
   
 
 
@@ -192,20 +187,10 @@
 
   
 
-
-  
-
-
-
-
-
-  
-
-
+
   
 
 
-
 
 
 
@@ -237,7 +222,6 @@
 
 
 
-
 
 
 
@@ -245,6 +229,38 @@
 
   
 
+
+  
+
+
+
+
+
+
+
+
+  
+
+
+  
+
+
+
+
+
+
+
+
+  
+
+
+  
+
+
+
+
+  
+
 
   
 
@@ -318,6 +334,12 @@
 
   
 
+
+  
+
+
+  
+
 
   
 
@@ -396,6 +418,57 @@
 
   
 
+
+  
+
+
+
+
+
+
+  
+
+
+  
+
+
+
+
+
+
+  
+
+
+  
+
+
+
+
+
+
+
+  
+
+
+  
+
+
+
+
+
+
+  
+
+
+  
+
+
+
+
+
+
+  
+
 
   
 
@@ -545,12 +618,6 @@
 
   
 
-
-  
-
-
-  
-
 
   
 
@@ -648,7 +715,7 @@
 
   
 
-
+
   
 
 
@@ -656,6 +723,7 @@
 
 
 
+
   
 
 
@@ -665,20 +733,10 @@
 
   
 
-
-  
-
-
-
-
-
-  
-
-
+
   
 
 
-
 
 
 
@@ -710,7 +768,6 @@
 
 
 
-
 
 
 
@@ -718,6 +775,38 @@
 
   
 
+
+  
+
+
+
+
+
+
+
+
+  
+
+
+  
+
+
+
+
+
+
+
+
+  
+
+
+  
+
+
+
+
+  
+
 
   
 
@@ -791,6 +880,12 @@
 
   
 
+
+  
+
+
+  
+
 
   
 
@@ -933,6 +1028,57 @@
 
   
 
+
+  
+
+
+
+
+
+
+  
+
+
+  
+
+
+
+
+
+
+  
+
+
+  
+
+
+
+
+
+
+
+  
+
+
+  
+
+
+
+
+
+
+  
+
+
+  
+
+
+
+
+
+
+  
+
 
   
 
@@ -1342,8 +1488,7 @@
 
 
 
-  
-
+  
 
   
 
@@ -1362,7 +1507,7 @@
 
   
 
-
+
   
 
 
@@ -1370,13 +1515,13 @@
 
 
 
+
   
 
-
+
   
 
 
-
 
 
 
@@ -1408,7 +1553,6 @@
 
 
 
-
 
 
 
@@ -1416,6 +1560,38 @@
 
   
 
+
+  
+
+
+
+
+
+
+
+
+  
+
+
+  
+
+
+
+
+
+
+
+
+  
+
+
+  
+
+
+
+
+  
+
 
   
 
@@ -1743,15 +1919,6 @@
 
   
 
-
-  
-
-
-
-
-
-  
-
 
   
 
@@ -1765,6 +1932,21 @@
 
   
 
+
+  
+
+
+
+
+
+
+
+
+
+
+
+  
+
   
   
 config-cs7-as
@@ -2009,6 +2191,22 @@
 
   
   

Change in osmo-gsm-manuals[master]: ggsn: update vty reference

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11584 )

Change subject: ggsn: update vty reference
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11584
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a5c37505c0180d5c04c7792d6d0afdb0dffb282
Gerrit-Change-Number: 11584
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sun, 18 Nov 2018 20:40:55 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-gsm-manuals[master]: OsmoBSC: update VTY reference

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11582 )

Change subject: OsmoBSC: update VTY reference
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11582
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9ba8d5eba531b1156de57573ab42517e0c1ca15
Gerrit-Change-Number: 11582
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sun, 18 Nov 2018 20:41:01 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-gsm-manuals[master]: stp: update vty reference with added SCCP commands

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11591 )

Change subject: stp: update vty reference with added SCCP commands
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11591
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id941b8e31d3b4cfdb3f912beedc1e7af321a0113
Gerrit-Change-Number: 11591
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sun, 18 Nov 2018 20:41:27 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-gsm-manuals[master]: sip-connector: update vty reference

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11589 )

Change subject: sip-connector: update vty reference
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11589
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I79b91847337b6022f8f750533301b3bf0eb086df
Gerrit-Change-Number: 11589
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sun, 18 Nov 2018 20:41:20 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-gsm-manuals[master]: msc: update vty reference

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11587 )

Change subject: msc: update vty reference
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11587
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I31f1d388b5323af8ece8a71a82c1b91f80d404e1
Gerrit-Change-Number: 11587
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-CC: Vadim Yanitskiy 
Gerrit-Comment-Date: Sun, 18 Nov 2018 20:41:12 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-gsm-manuals[master]: stp: update vty reference

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11590 )

Change subject: stp: update vty reference
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11590
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5f1067760db7a11ec380a541bfe7357a21a3bb3
Gerrit-Change-Number: 11590
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sun, 18 Nov 2018 20:41:23 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-gsm-tester[master]: resources.conf.rnd: gobi2k changed by ec20

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11770 )

Change subject: resources.conf.rnd: gobi2k changed by ec20
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11770
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2df38547978c7d2b1a1309f6e73b5a59413e08ff
Gerrit-Change-Number: 11770
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sun, 18 Nov 2018 20:41:46 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-gsm-manuals[master]: hlr: update vty reference

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11585 )

Change subject: hlr: update vty reference
..

hlr: update vty reference

Change-Id: I5a2322c0488cb36b089303bbfec5d4db18c41099
---
M OsmoHLR/vty/hlr_vty_reference.xml
1 file changed, 184 insertions(+), 46 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/OsmoHLR/vty/hlr_vty_reference.xml 
b/OsmoHLR/vty/hlr_vty_reference.xml
index 8d161d4..cc97dc4 100644
--- a/OsmoHLR/vty/hlr_vty_reference.xml
+++ b/OsmoHLR/vty/hlr_vty_reference.xml
@@ -85,12 +85,6 @@
 
   
 
-
-  
-
-
-  
-
 
   
 
@@ -175,7 +169,7 @@
 
   
 
-
+
   
 
 
@@ -183,6 +177,7 @@
 
 
 
+
   
 
 
@@ -192,23 +187,14 @@
 
   
 
-
-  
-
-
-
-
-
-  
-
-
+
   
 
 
-
 
 
 
+
 
 
 
@@ -227,7 +213,6 @@
 
 
 
-
 
 
 
@@ -235,6 +220,38 @@
 
   
 
+
+  
+
+
+
+
+
+
+
+
+  
+
+
+  
+
+
+
+
+
+
+
+
+  
+
+
+  
+
+
+
+
+  
+
 
   
 
@@ -285,6 +302,12 @@
 
   
 
+
+  
+
+
+  
+
 
   
 
@@ -348,12 +371,6 @@
 
   
 
-
-  
-
-
-  
-
 
   
 
@@ -451,7 +468,7 @@
 
   
 
-
+
   
 
 
@@ -459,6 +476,7 @@
 
 
 
+
   
 
 
@@ -468,23 +486,14 @@
 
   
 
-
-  
-
-
-
-
-
-  
-
-
+
   
 
 
-
 
 
 
+
 
 
 
@@ -503,7 +512,6 @@
 
 
 
-
 
 
 
@@ -511,6 +519,38 @@
 
   
 
+
+  
+
+
+
+
+
+
+
+
+  
+
+
+  
+
+
+
+
+
+
+
+
+  
+
+
+  
+
+
+
+
+  
+
 
   
 
@@ -561,6 +601,12 @@
 
   
 
+
+  
+
+
+  
+
 
   
 
@@ -574,9 +620,9 @@
 
   
 
-
+
 
-
+
   
 
 
@@ -837,8 +883,7 @@
 
 
   
-
-
+
   
 
 
@@ -929,7 +974,7 @@
 
   
 
-
+
   
 
 
@@ -937,16 +982,17 @@
 
 
 
+
   
 
-
+
   
 
 
-
 
 
 
+
 
 
 
@@ -965,7 +1011,6 @@
 
 
 
-
 
 
 
@@ -973,6 +1018,38 @@
 
   
 
+
+  
+
+
+
+
+
+
+
+
+  
+
+
+  
+
+
+
+
+
+
+
+
+  
+
+
+  
+
+
+
+
+  
+
   
   
 config-line
@@ -1010,6 +1087,64 @@
 
   
 
+
+  
+
+
+  
+
+
+  
+
+
+
+  
+
+
+  
+
+
+
+
+
+
+
+  
+
+
+  
+
+
+
+
+
+
+  
+
+
+  
+
+
+
+
+
+  
+
+
+  
+
+
+
+
+  
+
+
+  
+
+
+
+  
+
   
   
 config-hlr-gsup
@@ -1021,4 +1156,7 @@
   
 
   
+  
+config-hlr-euse
+  
 

--
To view, visit https://gerrit.osmocom.org/11585
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5a2322c0488cb36b089303bbfec5d4db18c41099
Gerrit-Change-Number: 11585
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-gsm-manuals[master]: sip-connector: update vty reference

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11589 )

Change subject: sip-connector: update vty reference
..

sip-connector: update vty reference

Change-Id: I79b91847337b6022f8f750533301b3bf0eb086df
---
M OsmoSIPConnector/vty/sipconn_vty_reference.xml
1 file changed, 106 insertions(+), 14 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/OsmoSIPConnector/vty/sipconn_vty_reference.xml 
b/OsmoSIPConnector/vty/sipconn_vty_reference.xml
index 35aad6b..dee42e6 100644
--- a/OsmoSIPConnector/vty/sipconn_vty_reference.xml
+++ b/OsmoSIPConnector/vty/sipconn_vty_reference.xml
@@ -188,7 +188,7 @@
 
   
 
-
+
   
 
 
@@ -196,6 +196,7 @@
 
 
 
+
   
 
 
@@ -205,11 +206,10 @@
 
   
 
-
+
   
 
 
-
 
 
 
@@ -232,7 +232,6 @@
 
 
 
-
 
 
 
@@ -240,6 +239,38 @@
 
   
 
+
+  
+
+
+
+
+
+
+
+
+  
+
+
+  
+
+
+
+
+
+
+
+
+  
+
+
+  
+
+
+
+
+  
+
 
   
 
@@ -308,8 +339,7 @@
 
 
   
-
-
+
   
 
 
@@ -451,7 +481,7 @@
 
   
 
-
+
   
 
 
@@ -459,6 +489,7 @@
 
 
 
+
   
 
 
@@ -468,11 +499,10 @@
 
   
 
-
+
   
 
 
-
 
 
 
@@ -495,7 +525,6 @@
 
 
 
-
 
 
 
@@ -503,6 +532,38 @@
 
   
 
+
+  
+
+
+
+
+
+
+
+
+  
+
+
+  
+
+
+
+
+
+
+
+
+  
+
+
+  
+
+
+
+
+  
+
 
   
 
@@ -855,7 +916,7 @@
 
   
 
-
+
   
 
 
@@ -863,13 +924,13 @@
 
 
 
+
   
 
-
+
   
 
 
-
 
 
 
@@ -892,7 +953,6 @@
 
 
 
-
 
 
 
@@ -900,6 +960,38 @@
 
   
 
+
+  
+
+
+
+
+
+
+
+
+  
+
+
+  
+
+
+
+
+
+
+
+
+  
+
+
+  
+
+
+
+
+  
+
   
   
 config-stats

--
To view, visit https://gerrit.osmocom.org/11589
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I79b91847337b6022f8f750533301b3bf0eb086df
Gerrit-Change-Number: 11589
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-gsm-manuals[master]: stp: update vty reference with added SCCP commands

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11591 )

Change subject: stp: update vty reference with added SCCP commands
..

stp: update vty reference with added SCCP commands

After I66e97706de0c546db3c6ff77fb5e6ac6e32bff55 which adds the missing
sccp_vty_init(), update VTY reference with the new SCCP show / config commands.

Depends: I66e97706de0c546db3c6ff77fb5e6ac6e32bff55
Change-Id: Id941b8e31d3b4cfdb3f912beedc1e7af321a0113
---
M OsmoSTP/vty/osmo-stp_vty_reference.xml
1 file changed, 99 insertions(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/OsmoSTP/vty/osmo-stp_vty_reference.xml 
b/OsmoSTP/vty/osmo-stp_vty_reference.xml
index cbda3fc..308c369 100644
--- a/OsmoSTP/vty/osmo-stp_vty_reference.xml
+++ b/OsmoSTP/vty/osmo-stp_vty_reference.xml
@@ -321,6 +321,47 @@
 
   
 
+
+  
+
+
+
+
+
+
+  
+
+
+  
+
+
+
+
+
+
+
+  
+
+
+  
+
+
+
+
+
+
+  
+
+
+  
+
+
+
+
+
+
+  
+
 
   
 
@@ -651,6 +692,47 @@
 
   
 
+
+  
+
+
+
+
+
+
+  
+
+
+  
+
+
+
+
+
+
+
+  
+
+
+  
+
+
+
+
+
+
+  
+
+
+  
+
+
+
+
+
+
+  
+
 
   
 
@@ -1067,7 +1149,8 @@
 
 
 
-  
+  
+
 
   
 
@@ -1164,6 +1247,21 @@
 
   
 
+
+  
+
+
+
+
+
+
+
+
+
+
+
+  
+
   
   
 config-cs7-as

--
To view, visit https://gerrit.osmocom.org/11591
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id941b8e31d3b4cfdb3f912beedc1e7af321a0113
Gerrit-Change-Number: 11591
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)