Change in osmo-hlr[master]: gsupclient: add osmo_gsup_msg_enc_send()

[Vadim Yanitskiy]

Hello Neels Hofmeyr, Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11989

to look at the new patch set (#3).

Change subject: gsupclient: add osmo_gsup_msg_enc_send()
..

gsupclient: add osmo_gsup_msg_enc_send()

Several parts of OsmoMSC (e.g. GSM 04.11, 09.11, etc.) are dealing
with GSUP message encoding and sending towards OsmoHLR. In order
to avoid code duplication, let's have a shared function here.

Change-Id: I0589ff27933e9bca2bcf93b8259004935778db8f
---
M include/osmocom/gsupclient/gsup_client.h
M src/gsupclient/gsup_client.c
2 files changed, 39 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/89/11989/3
--
To view, visit https://gerrit.osmocom.org/11989
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0589ff27933e9bca2bcf93b8259004935778db8f
Gerrit-Change-Number: 11989
Gerrit-PatchSet: 3
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 

Change in osmo-gsm-manuals[master]: chapters/gsup.adoc: document MO-/MT-forwardSM messages

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/11836 )

Change subject: chapters/gsup.adoc: document MO-/MT-forwardSM messages
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/11836
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0150756c33c1352bc4eb49421824542c711175c
Gerrit-Change-Number: 11836
Gerrit-PatchSet: 5
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Fri, 14 Dec 2018 00:56:22 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-gsm-manuals[master]: chapters/gsup.adoc: document READY-FOR-SM message

[Vadim Yanitskiy]

Hello Neels Hofmeyr, Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11837

to look at the new patch set (#5).

Change subject: chapters/gsup.adoc: document READY-FOR-SM message
..

chapters/gsup.adoc: document READY-FOR-SM message

Change-Id: I549b6c8840a1e86caac09e77fb8bc5042d939e62
Related Change-Id: (core) Ic37f3b2114b8095cfce22977e67133b9103942e3
Related Change-Id: (TTCN) If2256607527ecfcb10285583332fb8b0515d7c78
Related: OS#3587
---
M common/chapters/gsup.adoc
1 file changed, 75 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals 
refs/changes/37/11837/5
--
To view, visit https://gerrit.osmocom.org/11837
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I549b6c8840a1e86caac09e77fb8bc5042d939e62
Gerrit-Change-Number: 11837
Gerrit-PatchSet: 5
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 

Change in libosmocore[master]: gsm0480: fix copy-pasted note for gsm0480_gen_return_error()

[Vadim Yanitskiy]

Vadim Yanitskiy has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11988 )

Change subject: gsm0480: fix copy-pasted note for gsm0480_gen_return_error()
..

gsm0480: fix copy-pasted note for gsm0480_gen_return_error()

InvokeID is mandatory for ReturnError component.

Change-Id: Ie1c7116d368c2029b9f524cb74ffa316e282ec83
---
M src/gsm/gsm0480.c
1 file changed, 0 insertions(+), 3 deletions(-)

Approvals:
  Vadim Yanitskiy: Looks good to me, approved
  Pau Espin Pedrol: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/gsm/gsm0480.c b/src/gsm/gsm0480.c
index 021db62..fab2087 100644
--- a/src/gsm/gsm0480.c
+++ b/src/gsm/gsm0480.c
@@ -847,9 +847,6 @@
  * \param[in] invoke_idInvokeID of the request
  * \param[in] error_code   Error code (section 4.5)
  * \return message buffer containing the Reject component
- *
- * Note: if InvokeID is not available, e.g. when message parsing failed, any 
incorrect vlue
- * can be passed (0x00 > x > 0xff), so the universal NULL-tag (see table 3.6) 
will be used instead.
  */
 struct msgb *gsm0480_gen_return_error(uint8_t invoke_id, uint8_t error_code)
 {

--
To view, visit https://gerrit.osmocom.org/11988
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie1c7116d368c2029b9f524cb74ffa316e282ec83
Gerrit-Change-Number: 11988
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Vadim Yanitskiy 

Change in libosmocore[master]: gsm0480: fix copy-pasted note for gsm0480_gen_return_error()

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/11988 )

Change subject: gsm0480: fix copy-pasted note for gsm0480_gen_return_error()
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11988
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1c7116d368c2029b9f524cb74ffa316e282ec83
Gerrit-Change-Number: 11988
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Fri, 14 Dec 2018 00:30:44 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: GSUP/SMS: introduce MO-/MT-FORWARD-SM messages

[Vadim Yanitskiy]

Hello Neels Hofmeyr, Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11069

to look at the new patch set (#11).

Change subject: GSUP/SMS: introduce MO-/MT-FORWARD-SM messages
..

GSUP/SMS: introduce MO-/MT-FORWARD-SM messages

According to 3GPP TS 29.002, there are two services:

  - MAP-MO-FORWARD-SHORT-MESSAGE (see 12.2),
  - MAP-MT-FORWARD-SHORT-MESSAGE (see 12.9),

which are used to forward MO/MT short messages.

This change replicates both services as GSUP messages:

  - OSMO_GSUP_MSGT_MO_FORWARD_SM_*,
  - OSMO_GSUP_MSGT_MT_FORWARD_SM_*.

Please note, that only the 'must-have' IEs are introduced
by this change, in particular the following:

  - OSMO_GSUP_SM_RP_MR_IE (see note below),
  - OSMO_GSUP_SM_RP_DA_IE (see 7.6.8.1),
  - OSMO_GSUP_SM_RP_OA_IE (see 7.6.8.2),
  - OSMO_GSUP_SM_RP_UI_IE (see 7.6.8.4),
  - OSMO_GSUP_SM_RP_MMS_IE (see 7.6.8.7),
  - OSMO_GSUP_SM_RP_CAUSE_IE (see GSM TS 04.11, 8.2.5.4),

where both SM_RP_DA and SM_RP_OA IEs basically contain
a single nested TV of the following format:

  - T: identity type (see 'osmo_gsup_sms_sm_rp_oda_t'),
  - V: encoded identity itself (optional).

According to GSM TS 04.11, every single message on the SM-RL has
an unique message reference (see 8.2.3), that is used to link
an RP-ACK or RP-ERROR message to the associated (preceding)
RP-DATA or RP-SMMA message transfer attempt.

In case of TCAP/MAP, this message reference is being mapped to the
Invoke ID. But since GSUP has no 'Invoke ID' IE, and it is not
required for other applications (other than SMS), this change
introduces a special 'SM_RP_MR' IE that doesn't exist in MAP.

Change-Id: Ibe325c64ae2d6c626b232533bb4cbc65fc2b5d71
Related Change-Id: (docs) Ie0150756c33c1352bc4eb49421824542c711175c
Related Change-Id: (TTCN) Ibf49474a81235096c032ea21f217170f523bd94e
Related: OS#3587
---
M TODO-RELEASE
M include/Makefile.am
M include/osmocom/gsm/gsup.h
A include/osmocom/gsm/gsup_sms.h
M src/gsm/Makefile.am
M src/gsm/gsup.c
A src/gsm/gsup_sms.c
M src/gsm/libosmogsm.map
M tests/gsup/gsup_test.c
M tests/gsup/gsup_test.err
M tests/gsup/gsup_test.ok
11 files changed, 527 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/69/11069/11
--
To view, visit https://gerrit.osmocom.org/11069
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibe325c64ae2d6c626b232533bb4cbc65fc2b5d71
Gerrit-Change-Number: 11069
Gerrit-PatchSet: 11
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Vadim Yanitskiy 

Change in libosmocore[master]: GSUP/SMS: introduce MO-/MT-FORWARD-SM messages

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/11069 )

Change subject: GSUP/SMS: introduce MO-/MT-FORWARD-SM messages
..


Patch Set 10:

(23 comments)

https://gerrit.osmocom.org/#/c/11069/10/include/osmocom/gsm/gsup.h
File include/osmocom/gsm/gsup.h:

https://gerrit.osmocom.org/#/c/11069/10/include/osmocom/gsm/gsup.h@235
PS10, Line 235:  * Please note that there is no SM-RP-MR in TCAP/MAP! 
SM-RP-MR
> in doxygen this becomes […]
Done


https://gerrit.osmocom.org/#/c/11069/10/include/osmocom/gsm/gsup.h@237
PS10, Line 237: const uint8_t   *sm_rp_mr;
> oh wow, so we don't inline uint8_t[] then? hmm. ok. ok then... […]
Sorry, what is this comment / question about? Alignment?
How is this comment related to this change?


https://gerrit.osmocom.org/#/c/11069/10/include/osmocom/gsm/gsup_sms.h
File include/osmocom/gsm/gsup_sms.h:

https://gerrit.osmocom.org/#/c/11069/10/include/osmocom/gsm/gsup_sms.h@17
PS10, Line 17:  OSMO_GSUP_SMS_SM_RP_ODA_NONE= 0x00,
> OSMO_GSUP_SMS is the gsup-sub-type SMS […]
Harald is correct here, so ignored.


https://gerrit.osmocom.org/#/c/11069/10/include/osmocom/gsm/gsup_sms.h@25
PS10, Line 25: /* Forward declarations (to avoid mutual include) */
> yes, that's what they are, and I think all C programmers should be aware of 
> that concept?
Done


https://gerrit.osmocom.org/#/c/11069/10/include/osmocom/gsm/gsup_sms.h@29
PS10, Line 29: /* SM-RP-DA IE coding functions */
> a) I see that in the function name; unless you also explain "SM", "RP" or 
> "DA", you might as well dr […]
Removed


https://gerrit.osmocom.org/#/c/11069/10/src/gsm/gsup.c
File src/gsm/gsup.c:

https://gerrit.osmocom.org/#/c/11069/10/src/gsm/gsup.c@569
PS10, Line 569: int idx, rc;
> (rather place each var on its own line)
Ignored. Why not?


https://gerrit.osmocom.org/#/c/11069/10/src/gsm/gsup.c@668
PS10, Line 668: sizeof(u8), gsup_msg->sm_rp_mr);
> (either line up with '(' or use a single tab as indent)
I actually followed the style of msgb_tlv_put() statements
above. We can unify the alignment in a separate path.


https://gerrit.osmocom.org/#/c/11069/10/src/gsm/gsup_sms.c
File src/gsm/gsup_sms.c:

https://gerrit.osmocom.org/#/c/11069/10/src/gsm/gsup_sms.c@33
PS10, Line 33:  *  SMS (Short Message Service) extensions for Osmocom GSUP
> please please use punctuation to end the summary line.
Done


https://gerrit.osmocom.org/#/c/11069/10/src/gsm/gsup_sms.c@35
PS10, Line 35:
> (I think we usually write in one line […]
Agree, fixed.


https://gerrit.osmocom.org/#/c/11069/10/src/gsm/gsup_sms.c@37
PS10, Line 37:  * Encode SM-RP-DA IE (see 7.6.8.1), Destination Address
> please please use punctuation to end the summary line.
Done


https://gerrit.osmocom.org/#/c/11069/10/src/gsm/gsup_sms.c@43
PS10, Line 43:  const struct osmo_gsup_message *gsup_msg)
> (I guess this fits on a 120 wide line?)
Not critical, ignored.


https://gerrit.osmocom.org/#/c/11069/10/src/gsm/gsup_sms.c@53
PS10, Line 53:  /*! Special case for noSM-RP-DA and noSM-RP-OA */
> i doubt code inline doxygen makes sense. […]
Copy-pasted comment. Fixed, thanks!


https://gerrit.osmocom.org/#/c/11069/10/src/gsm/gsup_sms.c@55
PS10, Line 55: msgb_tv_put
> I don't think we should introduce anything but TLV in GSUP. […]
I was actually abusing this function in order to put TL of the final TLTLV.
Anyway, this doesn't make sense anymore, please see the new patch.


https://gerrit.osmocom.org/#/c/11069/10/src/gsm/gsup_sms.c@62
PS10, Line 62:  "(type=0x%02x)!\n", gsup_msg->sm_rp_da_type);
> (also looks like comfortable fit for 120 width, at least for the char 
> constant)
Not critical, ignored.


https://gerrit.osmocom.org/#/c/11069/10/src/gsm/gsup_sms.c@74
PS10, Line 74:  ie_len = msg->tail + 1; /* To be calculated later */
> max recently added API for this, see msgb_tl_put()
Good to know, thanks!


https://gerrit.osmocom.org/#/c/11069/10/src/gsm/gsup_sms.c@82
PS10, Line 82:  *ie_len = msg->tail - (ie_len + 1);
> I'm sure we have examples of nested IEs in other cases / protocol layers 
> (like TS 12. […]
Done


https://gerrit.osmocom.org/#/c/11069/10/src/gsm/gsup_sms.c@88
PS10, Line 88:  * Decode SM-RP-DA IE (see 7.6.8.1), Destination Address
> .
Done


https://gerrit.osmocom.org/#/c/11069/10/src/gsm/gsup_sms.c@125
PS10, Line 125: /*! Special case for noSM-RP-DA and noSM-RP-OA */
> .
Copy pasted comment. Thanks, fixed!


https://gerrit.osmocom.org/#/c/11069/10/src/gsm/gsup_sms.c@142
PS10, Line 142: gsup_msg->sm_rp_da_len = id_len;
> you are failing to check that the inner len does not surpass the outer TLV. 
> […]
Done


https://gerrit.osmocom.org/#/c/11069/10/src/gsm/gsup_sms.c@147
PS10, Line 147: /*!
  :  * Encode SM-RP-OA IE (see 7.6.8.2), Originating Address
Fixed too.


https://gerrit.osmocom.org/#/c/11069/10/src/gsm/gsup_sms.c@163
PS10, 

Change in libosmocore[master]: GSUP/SMS: introduce READY-FOR-SM message

[Vadim Yanitskiy]

Hello Stefan Sperling, Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11751

to look at the new patch set (#6).

Change subject: GSUP/SMS: introduce READY-FOR-SM message
..

GSUP/SMS: introduce READY-FOR-SM message

According to 3GPP TS 29.002, section 12.4, MAP-READY-FOR-SM is
used between the MSC and VLR as well as between the VLR and the
HLR to indicate that a subscriber has memory available for SMS.

This change replicates this service in GSUP as READY_FOR_SM_*.
The only mandatory IE for this service (excluding Invoke ID) is
'Alert Reason' that is replicated by OSMO_GSUP_SM_ALERT_RSN_IE.

Change-Id: Ic37f3b2114b8095cfce22977e67133b9103942e3
Related Change-Id: (docs) I549b6c8840a1e86caac09e77fb8bc5042d939e62
Related Change-Id: (TTCN) If2256607527ecfcb10285583332fb8b0515d7c78
Related: OS#3587
---
M include/osmocom/gsm/gsup.h
M include/osmocom/gsm/gsup_sms.h
M src/gsm/gsup.c
M tests/gsup/gsup_test.c
M tests/gsup/gsup_test.err
M tests/gsup/gsup_test.ok
6 files changed, 46 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/51/11751/6
--
To view, visit https://gerrit.osmocom.org/11751
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic37f3b2114b8095cfce22977e67133b9103942e3
Gerrit-Change-Number: 11751
Gerrit-PatchSet: 6
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Reviewer: Vadim Yanitskiy 

Change in sandbox[master]: z

[neels_test_user]

neels_test_user has posted comments on this change. ( 
https://gerrit.osmocom.org/12301 )

Change subject: z
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12301
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: sandbox
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf086ec487d8731f776739fd3c7c2d1cb83b6ce7
Gerrit-Change-Number: 12301
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: neels_test_user 
Gerrit-Comment-Date: Thu, 13 Dec 2018 21:42:45 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in sandbox[master]: z

[neels_test_user]

neels_test_user has posted comments on this change. ( 
https://gerrit.osmocom.org/12301 )

Change subject: z
..


Patch Set 1: Verified+1


--
To view, visit https://gerrit.osmocom.org/12301
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: sandbox
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf086ec487d8731f776739fd3c7c2d1cb83b6ce7
Gerrit-Change-Number: 12301
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: neels_test_user 
Gerrit-Comment-Date: Thu, 13 Dec 2018 21:42:50 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in sandbox[master]: z

[Neels Hofmeyr]

Neels Hofmeyr has uploaded this change for review. ( 
https://gerrit.osmocom.org/12301


Change subject: z
..

z

Change-Id: Ibf086ec487d8731f776739fd3c7c2d1cb83b6ce7
---
A z
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/sandbox refs/changes/01/12301/1

diff --git a/z b/z
new file mode 100644
index 000..b680253
--- /dev/null
+++ b/z
@@ -0,0 +1 @@
+z

--
To view, visit https://gerrit.osmocom.org/12301
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: sandbox
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibf086ec487d8731f776739fd3c7c2d1cb83b6ce7
Gerrit-Change-Number: 12301
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 

Build failure of network:osmocom:nightly/osmo-trx in xUbuntu_18.04/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/xUbuntu_18.04/i586

Package network:osmocom:nightly/osmo-trx failed to build in xUbuntu_18.04/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-trx

Last lines of build log:
[  276s] ./Transceiver52M/device/lms/LMSDevice.cpp:198: undefined reference to 
`LMS_VCTCXORead'
[  276s] ./Transceiver52M/device/lms/LMSDevice.cpp:201: undefined reference to 
`LMS_VCTCXOWrite'
[  276s] collect2: error: ld returned 1 exit status
[  276s] Makefile:461: recipe for target 'LMSDeviceTest' failed
[  276s] make[4]: *** [LMSDeviceTest] Error 1
[  276s] make[4]: Leaving directory 
'/usr/src/packages/BUILD/tests/Transceiver52M'
[  276s] Makefile:401: recipe for target 'all-recursive' failed
[  276s] make[3]: *** [all-recursive] Error 1
[  276s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  276s] Makefile:516: recipe for target 'all-recursive' failed
[  276s] make[2]: *** [all-recursive] Error 1
[  276s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  276s] Makefile:447: recipe for target 'all' failed
[  276s] make[1]: *** [all] Error 2
[  276s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  276s] dh_auto_build: make -j1 returned exit code 2
[  276s] debian/rules:6: recipe for target 'build' failed
[  276s] make: *** [build] Error 2
[  276s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  276s] 
[  276s] cloud117 failed "build osmo-trx_0.4.0.121.25185.dsc" at Thu Dec 13 
20:10:09 UTC 2018.
[  276s] 
[  276s] ### VM INTERACTION START ###
[  279s] [  254.875855] sysrq: SysRq : Power Off
[  279s] [  254.881053] reboot: Power down
[  281s] ### VM INTERACTION END ###
[  281s] 
[  281s] cloud117 failed "build osmo-trx_0.4.0.121.25185.dsc" at Thu Dec 13 
20:10:14 UTC 2018.
[  281s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-trx in xUbuntu_16.04/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/xUbuntu_16.04/i586

Package network:osmocom:nightly/osmo-trx failed to build in xUbuntu_16.04/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-trx

Last lines of build log:
[  165s] /usr/src/packages/BUILD/Transceiver52M/device/lms/LMSDevice.cpp:234: 
undefined reference to `LMS_SetLPFBW'
[  165s] collect2: error: ld returned 1 exit status
[  165s] Makefile:461: recipe for target 'LMSDeviceTest' failed
[  165s] make[4]: *** [LMSDeviceTest] Error 1
[  165s] make[4]: Leaving directory 
'/usr/src/packages/BUILD/tests/Transceiver52M'
[  165s] Makefile:401: recipe for target 'all-recursive' failed
[  165s] make[3]: *** [all-recursive] Error 1
[  165s] make[3]: Leaving directory '/usr/src/packages/BUILD/t[  154.764350] 
serial8250: too much work for irq4
[  165s] ests'
[  165s] Makefile:516: recipe for target 'all-recursive' failed
[  165s] make[2]: *** [all-recursive] Error 1
[  165s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  165s] Makefile:447: recipe for target 'all' failed
[  165s] make[1]: *** [all] Error 2
[  165s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  165s] dh_auto_build: make -j1 returned exit code 2
[  165s] debian/rules:6: recipe for target 'build' failed
[  165s] make: *** [build] Error 2
[  165s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  165s] 
[  165s] lamb15 failed "build osmo-trx_0.4.0.121.25185.dsc" at Thu Dec 13 
20:05:56 UTC 2018.
[  165s] 
[  165s] ### VM INTERACTION START ###
[  168s] [  157.926765] sysrq: SysRq : Power Off
[  168s] [  157.933875] reboot: Power down
[  168s] ### VM INTERACTION END ###
[  168s] 
[  168s] lamb15 failed "build osmo-trx_0.4.0.121.25185.dsc" at Thu Dec 13 
20:05:59 UTC 2018.
[  168s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-trx in xUbuntu_18.04/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/xUbuntu_18.04/x86_64

Package network:osmocom:nightly/osmo-trx failed to build in xUbuntu_18.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-trx

Last lines of build log:
[  211s] ./Transceiver52M/device/lms/LMSDevice.cpp:198: undefined reference to 
`LMS_VCTCXORead'
[  211s] ./Transceiver52M/device/lms/LMSDevice.cpp:201: undefined reference to 
`LMS_VCTCXOWrite'
[  211s] collect2: error: ld returned 1 exit status
[  211s] Makefile:461: recipe for target 'LMSDeviceTest' failed
[  211s] make[4]: *** [LMSDeviceTest] Error 1
[  211s] make[4]: Leaving directory 
'/usr/src/packages/BUILD/tests/Transceiver52M'
[  211s] Makefile:401: recipe for target 'all-recursive' failed
[  211s] make[3]: *** [all-recursive] Error 1
[  211s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  211s] Makefile:516: recipe for target 'all-recursive' failed
[  211s] make[2]: *** [all-recursive] Error 1
[  211s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  211s] Makefile:447: recipe for target 'all' failed
[  211s] make[1]: *** [all] Error 2
[  211s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  211s] dh_auto_build: make -j1 returned exit code 2
[  211s] debian/rules:6: recipe for target 'build' failed
[  211s] make: *** [build] Error 2
[  211s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  211s] 
[  211s] lamb04 failed "build osmo-trx_0.4.0.121.25185.dsc" at Thu Dec 13 
20:03:15 UTC 2018.
[  211s] 
[  211s] ### VM INTERACTION START ###
[  214s] [  201.141939] sysrq: SysRq : Power Off
[  214s] [  201.147366] reboot: Power down
[  214s] ### VM INTERACTION END ###
[  214s] 
[  214s] lamb04 failed "build osmo-trx_0.4.0.121.25185.dsc" at Thu Dec 13 
20:03:19 UTC 2018.
[  214s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-trx in xUbuntu_16.04/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/xUbuntu_16.04/x86_64

Package network:osmocom:nightly/osmo-trx failed to build in xUbuntu_16.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-trx

Last lines of build log:
[  163s] /usr/src/packages/BUILD/Transceiver52M/device/lms/LMSDevice.cpp:241: 
undefined reference to `LMS_Calibrate'
[  163s] /usr/src/packages/BUILD/Transceiver52M/device/lms/LMSDevice.cpp:234: 
undefined reference to `LMS_SetLPFBW'
[  163s] collect2: error: ld returned 1 exit status
[  163s] Makefile:461: recipe for target 'LMSDeviceTest' failed
[  163s] make[4]: *** [LMSDeviceTest] Error 1
[  163s] make[4]: Leaving directory 
'/usr/src/packages/BUILD/tests/Transceiver52M'
[  163s] Makefile:401: recipe for target 'all-recursive' failed
[  163s] make[3]: *** [all-recursive] Error 1
[  163s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  163s] Makefile:516: recipe for target 'all-recursive' failed
[  163s] make[2]: *** [all-recursive] Error 1
[  163s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  163s] Makefile:447: recipe for target 'all' failed
[  163s] make[1]: *** [all] Error 2
[  163s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  163s] dh_auto_build: make -j1 returned exit code 2
[  163s] debian/rules:6: recipe for target 'build' failed
[  163s] make: *** [build] Error 2
[  163s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  163s] 
[  163s] lamb17 failed "build osmo-trx_0.4.0.121.25185.dsc" at Thu Dec 13 
20:01:25 UTC 2018.
[  163s] 
[  163s] ### VM INTERACTION START ###
[  166s] [  155.398854] sysrq: SysRq : Power Off
[  166s] [  155.405392] reboot: Power down
[  166s] ### VM INTERACTION END ###
[  166s] 
[  166s] lamb17 failed "build osmo-trx_0.4.0.121.25185.dsc" at Thu Dec 13 
20:01:29 UTC 2018.
[  166s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-trx in xUbuntu_17.10/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/xUbuntu_17.10/x86_64

Package network:osmocom:nightly/osmo-trx failed to build in xUbuntu_17.10/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-trx

Last lines of build log:
[  181s] ./Transceiver52M/device/lms/LMSDevice.cpp:198: undefined reference to 
`LMS_VCTCXORead'
[  181s] ./Transceiver52M/device/lms/LMSDevice.cpp:201: undefined reference to 
`LMS_VCTCXOWrite'
[  181s] collect2: error: ld returned 1 exit status
[  181s] Makefile:461: recipe for target 'LMSDeviceTest' failed
[  181s] make[4]: *** [LMSDeviceTest] Error 1
[  181s] make[4]: Leaving directory 
'/usr/src/packages/BUILD/tests/Transceiver52M'
[  181s] Makefile:401: recipe for target 'all-recursive' failed
[  181s] make[3]: *** [all-recursive] Error 1
[  181s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  181s] Makefile:516: recipe for target 'all-recursive' failed
[  181s] make[2]: *** [all-recursive] Error 1
[  181s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  181s] Makefile:447: recipe for target 'all' failed
[  181s] make[1]: *** [all] Error 2
[  181s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  181s] dh_auto_build: make -j1 returned exit code 2
[  181s] debian/rules:6: recipe for target 'build' failed
[  181s] make: *** [build] Error 2
[  181s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  181s] 
[  181s] lamb06 failed "build osmo-trx_0.4.0.121.25185.dsc" at Thu Dec 13 
20:01:35 UTC 2018.
[  181s] 
[  181s] ### VM INTERACTION START ###
[  184s] [  171.817348] sysrq: SysRq : Power Off
[  184s] [  171.825260] reboot: Power down
[  184s] ### VM INTERACTION END ###
[  184s] 
[  184s] lamb06 failed "build osmo-trx_0.4.0.121.25185.dsc" at Thu Dec 13 
20:01:38 UTC 2018.
[  184s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-trx in xUbuntu_17.10/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/xUbuntu_17.10/i586

Package network:osmocom:nightly/osmo-trx failed to build in xUbuntu_17.10/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-trx

Last lines of build log:
[  253s] ./Transceiver52M/device/lms/LMSDevice.cpp:198: undefined reference to 
`LMS_VCTCXORead'
[  253s] ./Transceiver52M/device/lms/LMSDevice.cpp:201: undefined reference to 
`LMS_VCTCXOWrite'
[  253s] collect2: error: ld returned 1 exit status
[  253s] Makefile:461: recipe for target 'LMSDeviceTest' failed
[  253s] make[4]: *** [LMSDeviceTest] Error 1
[  253s] make[4]: Leaving directory 
'/usr/src/packages/BUILD/tests/Transceiver52M'
[  253s] Makefile:401: recipe for target 'all-recursive' failed
[  253s] make[3]: *** [all-recursive] Error 1
[  253s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  253s] Makefile:516: recipe for target 'all-recursive' failed
[  253s] make[2]: *** [all-recursive] Error 1
[  253s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  253s] Makefile:447: recipe for target 'all' failed
[  253s] make[1]: *** [all] Error 2
[  253s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  253s] dh_auto_build: make -j1 returned exit code 2
[  253s] debian/rules:6: recipe for target 'build' failed
[  253s] make: *** [build] Error 2
[  253s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  254s] 
[  254s] morla3 failed "build osmo-trx_0.4.0.121.25185.dsc" at Thu Dec 13 
20:01:31 UTC 2018.
[  254s] 
[  254s] ### VM INTERACTION START ###
[  257s] [  242.503287] sysrq: SysRq : Power Off
[  257s] [  242.555927] reboot: Power down
[  257s] ### VM INTERACTION END ###
[  257s] 
[  257s] morla3 failed "build osmo-trx_0.4.0.121.25185.dsc" at Thu Dec 13 
20:01:35 UTC 2018.
[  257s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Change in meta-telephony[201705]: Introduce recipe for osmo-sysmon

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12300 )

Change subject: Introduce recipe for osmo-sysmon
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12300
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e1da3a930e04d17ba0461874d60e6f204bc5b45
Gerrit-Change-Number: 12300
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Thu, 13 Dec 2018 16:53:52 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in meta-telephony[201705]: Introduce recipe liboping 1.10.0

[Pau Espin Pedrol]

Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12299 )

Change subject: Introduce recipe liboping 1.10.0
..

Introduce recipe liboping 1.10.0

It is a requirement for osmo-sysmon (to be added in follow-up patches).

Change-Id: I98ffbf39870b309da0ccdde81047d4c124633ad4
---
A recipes-support/liboping/liboping_1.10.0.bb
1 file changed, 14 insertions(+), 0 deletions(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, approved; Verified
  Max: Looks good to me, but someone else must approve



diff --git a/recipes-support/liboping/liboping_1.10.0.bb 
b/recipes-support/liboping/liboping_1.10.0.bb
new file mode 100644
index 000..4c4dc90
--- /dev/null
+++ b/recipes-support/liboping/liboping_1.10.0.bb
@@ -0,0 +1,14 @@
+SUMMARY = "C library to generate ICMP echo requests, better known as 'ping 
packets'"
+HOMEPAGE = "https://noping.cc/";
+SECTION = "libs"
+LICENSE = "LGPLv2.1+"
+
+SRC_URI = "https://noping.cc/files/liboping-${PV}.tar.gz";
+LIC_FILES_CHKSUM = "file://COPYING;md5=4fbd65380cdd255951079008b364516c"
+
+SRC_URI[md5sum] = "3a11b18a92b651225da10108242f71a4"
+SRC_URI[sha256sum] = 
"c206b05743d0730814be3115b48abd0b00016677525153c78730da307aba0846"
+
+EXTRA_OECONF += "--without-ncurses --without-perl-bindings"
+
+inherit autotools pkgconfig

--
To view, visit https://gerrit.osmocom.org/12299
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Gerrit-MessageType: merged
Gerrit-Change-Id: I98ffbf39870b309da0ccdde81047d4c124633ad4
Gerrit-Change-Number: 12299
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 

Change in meta-telephony[201705]: Introduce recipe for osmo-sysmon

[Pau Espin Pedrol]

Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12300 )

Change subject: Introduce recipe for osmo-sysmon
..

Introduce recipe for osmo-sysmon

Change-Id: I6e1da3a930e04d17ba0461874d60e6f204bc5b45
---
A recipes-osmocom/osmo-sysmon/osmo-sysmon.inc
A recipes-osmocom/osmo-sysmon/osmo-sysmon_git.bb
2 files changed, 27 insertions(+), 0 deletions(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, approved; Verified
  Max: Looks good to me, but someone else must approve



diff --git a/recipes-osmocom/osmo-sysmon/osmo-sysmon.inc 
b/recipes-osmocom/osmo-sysmon/osmo-sysmon.inc
new file mode 100644
index 000..1469438
--- /dev/null
+++ b/recipes-osmocom/osmo-sysmon/osmo-sysmon.inc
@@ -0,0 +1,20 @@
+DESCRIPTION = "Osmocom System Monitoring daemon"
+HOMEPAGE = "https://osmocom.org/projects/osmo-sysmon";
+LICENSE = "GPLv2+"
+LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
+
+DEPENDS = "libtalloc libosmocore libmnl liboping"
+
+INC_PR="r0.${META_TELEPHONY_OSMO_INC}"
+
+inherit autotools pkgconfig
+
+PACKAGES =+ "osmo-ctrl-client"
+
+FILES_osmo-ctrl-client = " \
+${bindir}/osmo-ctrl-client \
+"
+
+CONFFILES_osmo-sysmon = "\
+   ${sysconfdir}/osmocom/osmo-sysmon.cfg \
+   "
diff --git a/recipes-osmocom/osmo-sysmon/osmo-sysmon_git.bb 
b/recipes-osmocom/osmo-sysmon/osmo-sysmon_git.bb
new file mode 100644
index 000..a9cd8d3
--- /dev/null
+++ b/recipes-osmocom/osmo-sysmon/osmo-sysmon_git.bb
@@ -0,0 +1,7 @@
+require ${PN}.inc
+
+S = "${WORKDIR}/git"
+SRCREV = "3b25774db5b584e926dab2534d93314f910f62b6"
+SRC_URI = "git://git.osmocom.org/osmo-sysmon.git;protocol=git"
+PV = "0.0.1+gitr${SRCPV}"
+PR = "${INC_PR}.0"

--
To view, visit https://gerrit.osmocom.org/12300
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Gerrit-MessageType: merged
Gerrit-Change-Id: I6e1da3a930e04d17ba0461874d60e6f204bc5b45
Gerrit-Change-Number: 12300
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 

Change in meta-telephony[201705]: Introduce recipe liboping 1.10.0

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12299 )

Change subject: Introduce recipe liboping 1.10.0
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12299
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Gerrit-MessageType: comment
Gerrit-Change-Id: I98ffbf39870b309da0ccdde81047d4c124633ad4
Gerrit-Change-Number: 12299
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Thu, 13 Dec 2018 16:53:49 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in meta-telephony[201705]: Introduce recipe for osmo-sysmon

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/12300 )

Change subject: Introduce recipe for osmo-sysmon
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12300
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e1da3a930e04d17ba0461874d60e6f204bc5b45
Gerrit-Change-Number: 12300
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Thu, 13 Dec 2018 16:51:42 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in meta-telephony[201705]: Introduce recipe liboping 1.10.0

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/12299 )

Change subject: Introduce recipe liboping 1.10.0
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12299
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Gerrit-MessageType: comment
Gerrit-Change-Id: I98ffbf39870b309da0ccdde81047d4c124633ad4
Gerrit-Change-Number: 12299
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Thu, 13 Dec 2018 16:47:49 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in meta-telephony[201705]: Introduce recipe for osmo-sysmon

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12300 )

Change subject: Introduce recipe for osmo-sysmon
..


Patch Set 1:

TODO after merge -> rebase laforge/nightly on top of 201705


--
To view, visit https://gerrit.osmocom.org/12300
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e1da3a930e04d17ba0461874d60e6f204bc5b45
Gerrit-Change-Number: 12300
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Thu, 13 Dec 2018 16:40:49 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in meta-telephony[201705]: Introduce recipe for osmo-sysmon

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12300 )

Change subject: Introduce recipe for osmo-sysmon
..


Patch Set 1: Verified+1


--
To view, visit https://gerrit.osmocom.org/12300
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e1da3a930e04d17ba0461874d60e6f204bc5b45
Gerrit-Change-Number: 12300
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Thu, 13 Dec 2018 16:40:27 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in meta-telephony[201705]: Introduce recipe liboping 1.10.0

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12299 )

Change subject: Introduce recipe liboping 1.10.0
..


Patch Set 1: Verified+1


--
To view, visit https://gerrit.osmocom.org/12299
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Gerrit-MessageType: comment
Gerrit-Change-Id: I98ffbf39870b309da0ccdde81047d4c124633ad4
Gerrit-Change-Number: 12299
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Thu, 13 Dec 2018 16:40:23 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in meta-telephony[201705]: Introduce recipe for osmo-sysmon

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12300 )

Change subject: Introduce recipe for osmo-sysmon
..


Patch Set 1:

I made osmo-sysmon already depend on liboping hoping its use will be introduced 
soon (it still doesn't use it) and this way we don't need to create all this 
later.


--
To view, visit https://gerrit.osmocom.org/12300
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e1da3a930e04d17ba0461874d60e6f204bc5b45
Gerrit-Change-Number: 12300
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Thu, 13 Dec 2018 16:38:09 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in meta-telephony[201705]: Introduce recipe liboping 1.10.0

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/12299


Change subject: Introduce recipe liboping 1.10.0
..

Introduce recipe liboping 1.10.0

It is a requirement for osmo-sysmon (to be added in follow-up patches).

Change-Id: I98ffbf39870b309da0ccdde81047d4c124633ad4
---
A recipes-support/liboping/liboping_1.10.0.bb
1 file changed, 14 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/99/12299/1

diff --git a/recipes-support/liboping/liboping_1.10.0.bb 
b/recipes-support/liboping/liboping_1.10.0.bb
new file mode 100644
index 000..4c4dc90
--- /dev/null
+++ b/recipes-support/liboping/liboping_1.10.0.bb
@@ -0,0 +1,14 @@
+SUMMARY = "C library to generate ICMP echo requests, better known as 'ping 
packets'"
+HOMEPAGE = "https://noping.cc/";
+SECTION = "libs"
+LICENSE = "LGPLv2.1+"
+
+SRC_URI = "https://noping.cc/files/liboping-${PV}.tar.gz";
+LIC_FILES_CHKSUM = "file://COPYING;md5=4fbd65380cdd255951079008b364516c"
+
+SRC_URI[md5sum] = "3a11b18a92b651225da10108242f71a4"
+SRC_URI[sha256sum] = 
"c206b05743d0730814be3115b48abd0b00016677525153c78730da307aba0846"
+
+EXTRA_OECONF += "--without-ncurses --without-perl-bindings"
+
+inherit autotools pkgconfig

--
To view, visit https://gerrit.osmocom.org/12299
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Gerrit-MessageType: newchange
Gerrit-Change-Id: I98ffbf39870b309da0ccdde81047d4c124633ad4
Gerrit-Change-Number: 12299
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in meta-telephony[201705]: Introduce recipe for osmo-sysmon

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/12300


Change subject: Introduce recipe for osmo-sysmon
..

Introduce recipe for osmo-sysmon

Change-Id: I6e1da3a930e04d17ba0461874d60e6f204bc5b45
---
A recipes-osmocom/osmo-sysmon/osmo-sysmon.inc
A recipes-osmocom/osmo-sysmon/osmo-sysmon_git.bb
2 files changed, 27 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/00/12300/1

diff --git a/recipes-osmocom/osmo-sysmon/osmo-sysmon.inc 
b/recipes-osmocom/osmo-sysmon/osmo-sysmon.inc
new file mode 100644
index 000..1469438
--- /dev/null
+++ b/recipes-osmocom/osmo-sysmon/osmo-sysmon.inc
@@ -0,0 +1,20 @@
+DESCRIPTION = "Osmocom System Monitoring daemon"
+HOMEPAGE = "https://osmocom.org/projects/osmo-sysmon";
+LICENSE = "GPLv2+"
+LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
+
+DEPENDS = "libtalloc libosmocore libmnl liboping"
+
+INC_PR="r0.${META_TELEPHONY_OSMO_INC}"
+
+inherit autotools pkgconfig
+
+PACKAGES =+ "osmo-ctrl-client"
+
+FILES_osmo-ctrl-client = " \
+${bindir}/osmo-ctrl-client \
+"
+
+CONFFILES_osmo-sysmon = "\
+   ${sysconfdir}/osmocom/osmo-sysmon.cfg \
+   "
diff --git a/recipes-osmocom/osmo-sysmon/osmo-sysmon_git.bb 
b/recipes-osmocom/osmo-sysmon/osmo-sysmon_git.bb
new file mode 100644
index 000..a9cd8d3
--- /dev/null
+++ b/recipes-osmocom/osmo-sysmon/osmo-sysmon_git.bb
@@ -0,0 +1,7 @@
+require ${PN}.inc
+
+S = "${WORKDIR}/git"
+SRCREV = "3b25774db5b584e926dab2534d93314f910f62b6"
+SRC_URI = "git://git.osmocom.org/osmo-sysmon.git;protocol=git"
+PV = "0.0.1+gitr${SRCPV}"
+PR = "${INC_PR}.0"

--
To view, visit https://gerrit.osmocom.org/12300
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6e1da3a930e04d17ba0461874d60e6f204bc5b45
Gerrit-Change-Number: 12300
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in libosmocore[master]: LCLS, TS 29.205: add GCR routines

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/11827 )

Change subject: LCLS, TS 29.205: add GCR routines
..


Patch Set 24:

(1 comment)

https://gerrit.osmocom.org/#/c/11827/23/tests/gsm29205/gsm29205_test.c
File tests/gsm29205/gsm29205_test.c:

https://gerrit.osmocom.org/#/c/11827/23/tests/gsm29205/gsm29205_test.c@69
PS23, Line 69:  abort();
> Same problem as pointed out by Pau in 
> https://gerrit.osmocom.org/c/libosmocore/+/12020 […]
Done



--
To view, visit https://gerrit.osmocom.org/11827
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee95aa4e5c056645b6cb5667e4a067097d52dfbf
Gerrit-Change-Number: 11827
Gerrit-PatchSet: 24
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Comment-Date: Thu, 13 Dec 2018 16:22:06 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: MSC: match default expectation with config

[dexter]

dexter has posted comments on this change. ( https://gerrit.osmocom.org/12296 )

Change subject: MSC: match default expectation with config
..


Patch Set 1: Code-Review+1

> Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12296
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I540645ef4b1e08d05b89251f074af84a516e7a88
Gerrit-Change-Number: 12296
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Thu, 13 Dec 2018 16:17:59 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: MSC: adjust gsup log level to error

[Max]

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12298


Change subject: MSC: adjust gsup log level to error
..

MSC: adjust gsup log level to error

The HLR emulation is active only for short time during each test so we
got lots of useless "gsup_client.c:73 GSUP connecting to 127.0.0.1:4222"
messages due to continuous attempts to reconnect to HLR. Let's use error
log level to obtain relevant errors (if any).

Change-Id: If79db99ceb7a9d4e2ec8d8b375aa628c4088c65c
---
M msc/osmo-msc.cfg
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/98/12298/1

diff --git a/msc/osmo-msc.cfg b/msc/osmo-msc.cfg
index ddac4cd..79d509e 100644
--- a/msc/osmo-msc.cfg
+++ b/msc/osmo-msc.cfg
@@ -34,7 +34,7 @@
  logging level lctrl info
  logging level lgtp notice
  logging level lstats notice
- logging level lgsup notice
+ logging level lgsup error
  logging level loap notice
  logging level lss7 notice
  logging level lsccp notice

--
To view, visit https://gerrit.osmocom.org/12298
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If79db99ceb7a9d4e2ec8d8b375aa628c4088c65c
Gerrit-Change-Number: 12298
Gerrit-PatchSet: 1
Gerrit-Owner: Max 

Change in osmo-sysmon[master]: Introduce systemd service file and install with autotools

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12286 )

Change subject: Introduce systemd service file and install with autotools
..


Patch Set 2:

> Is it enabled by default in OE? If so than it might interfere with
 > normal testing/use so I propose to abandon this altogether or move
 > to WIP until we actually have the hypothetical use case described
 > by Pau.

It's easy to configur the recipe to not enable the systemd file in OE, but 
fine, let's keep it out for now.


--
To view, visit https://gerrit.osmocom.org/12286
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4875b74bcf2b6232d915070b77fc202a03ef997
Gerrit-Change-Number: 12286
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Thu, 13 Dec 2018 16:02:45 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: mgw: Tear down all RTP flows to avoid race condition on tear down

[daniel]

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/12297


Change subject: mgw: Tear down all RTP flows to avoid race condition on tear 
down
..

mgw: Tear down all RTP flows to avoid race condition on tear down

When stopping the test TC_two_crcx_and_unsolicited_rtp the unsolicited
RTP stream is not stopped. As a result it could happen that between
tearing down the other flows and stopping the test an unsolicited RTP
packet is sent to a closed socket.
The resulting ICMP destination unreachable packet translates to a
"Connection refused" error on the sending socket and fails the test.

Avoid this by making sure the unsolicited RTP sender is stopped before
stopping the test.

Change-Id: Ied839596589609e75fa487046a85db48991e4c73
---
M mgw/MGCP_Test.ttcn
1 file changed, 2 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/97/12297/1

diff --git a/mgw/MGCP_Test.ttcn b/mgw/MGCP_Test.ttcn
index e1ebc26..9adeb2a 100644
--- a/mgw/MGCP_Test.ttcn
+++ b/mgw/MGCP_Test.ttcn
@@ -1211,6 +1211,8 @@

f_sleep(0.5);

+   /* Stop transmitting packets and tear down the flows */
+   f_rtpem_mode(RTPEM[2], RTPEM_MODE_NONE);
f_flow_delete(RTPEM[0]);
f_flow_delete(RTPEM[1], ep, call_id);


--
To view, visit https://gerrit.osmocom.org/12297
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ied839596589609e75fa487046a85db48991e4c73
Gerrit-Change-Number: 12297
Gerrit-PatchSet: 1
Gerrit-Owner: daniel 

Change in osmo-ttcn3-hacks[master]: MSC: match default expectation with config

[osmith]

osmith has posted comments on this change. ( https://gerrit.osmocom.org/12296 )

Change subject: MSC: match default expectation with config
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12296
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I540645ef4b1e08d05b89251f074af84a516e7a88
Gerrit-Change-Number: 12296
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Thu, 13 Dec 2018 15:39:31 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-sgsn[master]: make gsup ipa name configurable in osmo-sgsn.cfg

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/12243 )

Change subject: make gsup ipa name configurable in osmo-sgsn.cfg
..


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/#/c/12243/3/src/gprs/sgsn_vty.c
File src/gprs/sgsn_vty.c:

https://gerrit.osmocom.org/#/c/12243/3/src/gprs/sgsn_vty.c@1454
PS3, Line 1454: parsing_config_file = true;
Why initializing it here instead of where it's declared?



--
To view, visit https://gerrit.osmocom.org/12243
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f65fed9f56b9718e8a9647e3f01dce69870c1f
Gerrit-Change-Number: 12243
Gerrit-PatchSet: 3
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Comment-Date: Thu, 13 Dec 2018 15:39:38 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in sandbox[master]: What about -1 vote counting?

[osmith]

osmith has abandoned this change. ( https://gerrit.osmocom.org/12218 )

Change subject: What about -1 vote counting?
..


Abandoned

+3 voting was reverted, social contract it is.
--
To view, visit https://gerrit.osmocom.org/12218
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: sandbox
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Ieab13e41e5a8c438653cfb5d058da3e588bc5603
Gerrit-Change-Number: 12218
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: osmith 

Change in osmo-ggsn[master]: contrib: fix makedistcheck with disabled systemd

[osmith]

osmith has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12160 )

Change subject: contrib: fix makedistcheck with disabled systemd
..

contrib: fix makedistcheck with disabled systemd

EXTRA_DIST files need to be distributed, no matter if the systemd option
is configured or not.

Change-Id: Ibd348eac3adca88663bd510172efbe4ec0bf3599
---
M contrib/systemd/Makefile.am
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Pau Espin Pedrol: Looks good to me, approved



diff --git a/contrib/systemd/Makefile.am b/contrib/systemd/Makefile.am
index e6ad299..fbb553f 100644
--- a/contrib/systemd/Makefile.am
+++ b/contrib/systemd/Makefile.am
@@ -1,5 +1,6 @@
-if HAVE_SYSTEMD
 EXTRA_DIST = osmo-ggsn.service
+
+if HAVE_SYSTEMD
 systemdsystemunit_DATA = \
   osmo-ggsn.service
 endif

--
To view, visit https://gerrit.osmocom.org/12160
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibd348eac3adca88663bd510172efbe4ec0bf3599
Gerrit-Change-Number: 12160
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: osmith 

Change in libosmo-sccp[master]: contrib: fix makedistcheck with disabled systemd

[osmith]

osmith has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12163 )

Change subject: contrib: fix makedistcheck with disabled systemd
..

contrib: fix makedistcheck with disabled systemd

EXTRA_DIST files need to be distributed, no matter if the systemd option
is configured or not.

Change-Id: Ib848aa5ce03f45d4f8182a4e77b0130ccb261635
---
M contrib/systemd/Makefile.am
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/contrib/systemd/Makefile.am b/contrib/systemd/Makefile.am
index e7d846f..38c1ea3 100644
--- a/contrib/systemd/Makefile.am
+++ b/contrib/systemd/Makefile.am
@@ -1,5 +1,6 @@
-if HAVE_SYSTEMD
 EXTRA_DIST = osmo-stp.service
+
+if HAVE_SYSTEMD
 systemdsystemunit_DATA = \
   osmo-stp.service
 endif

--
To view, visit https://gerrit.osmocom.org/12163
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib848aa5ce03f45d4f8182a4e77b0130ccb261635
Gerrit-Change-Number: 12163
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: osmith 

Change in osmo-mgw[master]: contrib: fix makedistcheck with disabled systemd

[osmith]

osmith has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12166 )

Change subject: contrib: fix makedistcheck with disabled systemd
..

contrib: fix makedistcheck with disabled systemd

EXTRA_DIST files need to be distributed, no matter if the systemd option
is configured or not.

Change-Id: I5014d98e06e033d04be45585b34458c90b1ced00
---
M contrib/systemd/Makefile.am
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/contrib/systemd/Makefile.am b/contrib/systemd/Makefile.am
index c0d95ff..340cd90 100644
--- a/contrib/systemd/Makefile.am
+++ b/contrib/systemd/Makefile.am
@@ -1,5 +1,6 @@
-if HAVE_SYSTEMD
 EXTRA_DIST = osmo-mgw.service
+
+if HAVE_SYSTEMD
 systemdsystemunit_DATA = \
   osmo-mgw.service
 endif

--
To view, visit https://gerrit.osmocom.org/12166
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5014d98e06e033d04be45585b34458c90b1ced00
Gerrit-Change-Number: 12166
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: osmith 

Change in osmo-pcap[master]: contrib: fix makedistcheck with disabled systemd

[osmith]

osmith has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12171 )

Change subject: contrib: fix makedistcheck with disabled systemd
..

contrib: fix makedistcheck with disabled systemd

EXTRA_DIST files need to be distributed, no matter if the systemd option
is configured or not.

Change-Id: I2fed90915f57bbb054a26bacecf8417d6f3ba5ce
---
M contrib/systemd/Makefile.am
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/contrib/systemd/Makefile.am b/contrib/systemd/Makefile.am
index 5b41c52..2966a63 100644
--- a/contrib/systemd/Makefile.am
+++ b/contrib/systemd/Makefile.am
@@ -1,8 +1,11 @@
+EXTRA_DIST = \
+   osmo-pcap-client.service \
+   osmo-pcap-server.service
+
 if HAVE_SYSTEMD
 SYSTEMD_SERVICES = \
osmo-pcap-client.service \
osmo-pcap-server.service

-EXTRA_DIST = $(SYSTEMD_SERVICES)
 systemdsystemunit_DATA = $(SYSTEMD_SERVICES)
 endif

--
To view, visit https://gerrit.osmocom.org/12171
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2fed90915f57bbb054a26bacecf8417d6f3ba5ce
Gerrit-Change-Number: 12171
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: osmith 

Change in osmo-sip-connector[master]: contrib: fix makedistcheck with disabled systemd

[osmith]

osmith has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12159 )

Change subject: contrib: fix makedistcheck with disabled systemd
..

contrib: fix makedistcheck with disabled systemd

EXTRA_DIST files need to be distributed, no matter if the systemd option
is configured or not.

Change-Id: I1169c1c6d99628d2cbed67cac3ed675d778597b0
---
M contrib/systemd/Makefile.am
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Pau Espin Pedrol: Looks good to me, approved



diff --git a/contrib/systemd/Makefile.am b/contrib/systemd/Makefile.am
index 213cc7a..4e70535 100644
--- a/contrib/systemd/Makefile.am
+++ b/contrib/systemd/Makefile.am
@@ -1,5 +1,6 @@
-if HAVE_SYSTEMD
 EXTRA_DIST = osmo-sip-connector.service
+
+if HAVE_SYSTEMD
 systemdsystemunit_DATA = \
   osmo-sip-connector.service
 endif

--
To view, visit https://gerrit.osmocom.org/12159
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1169c1c6d99628d2cbed67cac3ed675d778597b0
Gerrit-Change-Number: 12159
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: osmith 

Change in osmo-hlr[master]: contrib: fix makedistcheck with disabled systemd

[osmith]

osmith has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12168 )

Change subject: contrib: fix makedistcheck with disabled systemd
..

contrib: fix makedistcheck with disabled systemd

EXTRA_DIST files need to be distributed, no matter if the systemd option
is configured or not.

Change-Id: Ic164403189510f3b20ff7906df09c78550735591
---
M contrib/systemd/Makefile.am
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/contrib/systemd/Makefile.am b/contrib/systemd/Makefile.am
index 520e720..eb33b4a 100644
--- a/contrib/systemd/Makefile.am
+++ b/contrib/systemd/Makefile.am
@@ -1,5 +1,6 @@
-if HAVE_SYSTEMD
 EXTRA_DIST = osmo-hlr.service
+
+if HAVE_SYSTEMD
 systemdsystemunit_DATA = \
   osmo-hlr.service
 endif

--
To view, visit https://gerrit.osmocom.org/12168
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic164403189510f3b20ff7906df09c78550735591
Gerrit-Change-Number: 12168
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: osmith 

Change in osmo-ttcn3-hacks[master]: MSC: match default expectation with config

[Max]

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12296


Change subject: MSC: match default expectation with config
..

MSC: match default expectation with config

In MSC_Tests.default we expect /tmp/mncc.sock as MNCC socket path -
let's match this expectation with osmo-msc.cfg to make sure that tests
work out of the box without the need to use specific command-line
option.

Change-Id: I540645ef4b1e08d05b89251f074af84a516e7a88
---
M msc/osmo-msc.cfg
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/96/12296/1

diff --git a/msc/osmo-msc.cfg b/msc/osmo-msc.cfg
index 3f9e192..ddac4cd 100644
--- a/msc/osmo-msc.cfg
+++ b/msc/osmo-msc.cfg
@@ -73,6 +73,7 @@
  cs7-instance-iu 0
  mgw remote-ip 127.0.0.1
  emergency-call route-to-msisdn 112
+ mncc external /tmp/mncc.sock
 mncc-int
  default-codec tch-f fr
  default-codec tch-h hr

--
To view, visit https://gerrit.osmocom.org/12296
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I540645ef4b1e08d05b89251f074af84a516e7a88
Gerrit-Change-Number: 12296
Gerrit-PatchSet: 1
Gerrit-Owner: Max 

Change in docker-playground[master]: MSC: use config file for mncc path

[osmith]

osmith has posted comments on this change. ( https://gerrit.osmocom.org/12277 )

Change subject: MSC: use config file for mncc path
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12277
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I689cfb3bad09b76859ef7e42c1312c636eebe637
Gerrit-Change-Number: 12277
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Max 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Thu, 13 Dec 2018 15:26:37 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-sysmon[master]: Introduce systemd service file and install with autotools

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/12286 )

Change subject: Introduce systemd service file and install with autotools
..


Patch Set 2: Code-Review-1

Is it enabled by default in OE? If so than it might interfere with normal 
testing/use so I propose to abandon this altogether or move to WIP until we 
actually have the hypothetical use case described by Pau.


--
To view, visit https://gerrit.osmocom.org/12286
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4875b74bcf2b6232d915070b77fc202a03ef997
Gerrit-Change-Number: 12286
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Thu, 13 Dec 2018 15:12:54 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: Use msgb helper instead of local #define for debug print

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/12271 )

Change subject: Use msgb helper instead of local #define for debug print
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/12271/1/tests/gsm0808/gsm0808_test.c
File tests/gsm0808/gsm0808_test.c:

https://gerrit.osmocom.org/#/c/12271/1/tests/gsm0808/gsm0808_test.c@40
PS1, Line 40: #define VERIFY(msg, data, len)
\
> I would rather change this to: […]
Unfortunately I haven't found a way to do this with spatch. Feel free to add 
corrected variant of .spatch if you know how.



--
To view, visit https://gerrit.osmocom.org/12271
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6be778236eff8f2153f3113f9379ecfbec9052b
Gerrit-Change-Number: 12271
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Stefan Sperling 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Thu, 13 Dec 2018 15:05:46 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-sysmon[master]: Add cmdline option parsing support

[Pau Espin Pedrol]

Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12285 )

Change subject: Add cmdline option parsing support
..

Add cmdline option parsing support

Change-Id: I742974bd1440b09b49d26703c13361dd1c41008b
---
M src/osysmon_main.c
1 file changed, 95 insertions(+), 4 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved

Objections:
  Max: I would prefer this is not merged as is



diff --git a/src/osysmon_main.c b/src/osysmon_main.c
index 5983212..486ee8f 100644
--- a/src/osysmon_main.c
+++ b/src/osysmon_main.c
@@ -26,6 +26,7 @@
 #include 
 #include 
 #include 
+#include 

 #include "config.h"
 #include "osysmon.h"
@@ -69,8 +70,6 @@
.is_config_node = osysmon_is_config_node,
 };

-
-static const char *config_file = "osmo-sysmon.cfg";
 struct osysmon_state *g_oss;


@@ -110,6 +109,88 @@
}
 }

+static void print_usage()
+{
+   printf("Usage: osmo-sysmon\n");
+}
+
+static void print_help()
+{
+   printf("  -h --help  This text.\n");
+   printf("  -c --config-file filename  The config file to use.\n");
+   printf("  -d option --debug=DRLL:DCC:DMM:DRR:DRSL:DNM  Enable 
debugging.\n");
+   printf("  -D --daemonize Fork the process into a background 
daemon.\n");
+   printf("  -s --disable-color Do not print ANSI colors in the 
log\n");
+   printf("  -T --timestamp Prefix every log line with a 
timestamp.\n");
+   printf("  -e --log-level number  Set a global loglevel.\n");
+   printf("  -V --version   Print the version of OsmoHLR.\n");
+}
+
+static struct {
+   const char *config_file;
+   bool daemonize;
+} cmdline_opts = {
+   .config_file = "osmo-sysmon.cfg",
+   .daemonize = false,
+};
+
+static void handle_options(int argc, char **argv)
+{
+   while (1) {
+   int option_index = 0, c;
+   static struct option long_options[] = {
+   {"help", 0, 0, 'h'},
+   {"config-file", 1, 0, 'c'},
+   {"debug", 1, 0, 'd'},
+   {"daemonize", 0, 0, 'D'},
+   {"disable-color", 0, 0, 's'},
+   {"log-level", 1, 0, 'e'},
+   {"timestamp", 0, 0, 'T'},
+   {"version", 0, 0, 'V' },
+   {0, 0, 0, 0}
+   };
+
+   c = getopt_long(argc, argv, "hc:d:Dse:TV",
+   long_options, &option_index);
+   if (c == -1)
+   break;
+
+   switch (c) {
+   case 'h':
+   print_usage();
+   print_help();
+   exit(0);
+   case 'c':
+   cmdline_opts.config_file = optarg;
+   break;
+   case 'd':
+   log_parse_category_mask(osmo_stderr_target, optarg);
+   break;
+   case 'D':
+   cmdline_opts.daemonize = 1;
+   break;
+   case 's':
+   log_set_use_color(osmo_stderr_target, 0);
+   break;
+   case 'e':
+   log_set_log_level(osmo_stderr_target, atoi(optarg));
+   break;
+   case 'T':
+   log_set_print_timestamp(osmo_stderr_target, 1);
+   break;
+   case 'V':
+   print_version(1);
+   exit(0);
+   break;
+   default:
+   /* catch unknown options *as well as* missing 
arguments. */
+   fprintf(stderr, "Error in command line options. 
Exiting.\n");
+   exit(-1);
+   break;
+   }
+   }
+}
+
 int main(int argc, char **argv)
 {
int rc;
@@ -122,14 +203,16 @@
INIT_LLIST_HEAD(&g_oss->files);

vty_init(&vty_info);
+   handle_options(argc, argv);
osysmon_sysinfo_init();
osysmon_ctrl_init();
osysmon_rtnl_init();
osysmon_file_init();

-   rc = vty_read_config_file(config_file, NULL);
+   rc = vty_read_config_file(cmdline_opts.config_file, NULL);
if (rc < 0) {
-   fprintf(stderr, "Failed to parse the config file %s\n", 
config_file);
+   fprintf(stderr, "Failed to parse the config file %s\n",
+   cmdline_opts.config_file);
exit(2);
}

@@ -137,6 +220,14 @@
signal(SIGUSR2, &signal_handler);
osmo_init_ignore_signals();

+   if (cmdline_opts.daemonize) {
+   rc = osmo_daemonize();
+   if (rc < 0) {
+   perror("Error during daemonize");
+  

Change in osmo-ttcn3-hacks[master]: MSC_Tests: add test to try two LU from different BSCs

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9204 )

Change subject: MSC_Tests: add test to try two LU from different BSCs
..


Patch Set 5:

(2 comments)

https://gerrit.osmocom.org/#/c/9204/5/library/BSSMAP_Emulation.ttcn
File library/BSSMAP_Emulation.ttcn:

https://gerrit.osmocom.org/#/c/9204/5/library/BSSMAP_Emulation.ttcn@54
PS5, Line 54:   port BSSMAPEM_PROC_PT BSSAP_PROC_1;
> I think with BTS we have an array of them? Is that possible with component 
> ports? (arrays potentiall […]
unfortunately ports are separate concepts/objects in TTCN-3 from data types.  
Only variables can form lists or arrays, but not ports :(

In terms of naming I would personally request to use BSSAP1/BSSAP_PROC1 without 
underscore as this resembles how we handle it in other situations, like e.g. 
RSL_Emulation.ttcn with RSL/RSL1 and RSL_PROC/RSL_PROC1.


https://gerrit.osmocom.org/#/c/9204/5/msc/BSC_ConnectionHandler.ttcn
File msc/BSC_ConnectionHandler.ttcn:

https://gerrit.osmocom.org/#/c/9204/5/msc/BSC_ConnectionHandler.ttcn@53
PS5, Line 53: type record of BSC_ConnHdlrBscPars BSC_ConnHdlrBscParsTable;
> ah, there's an array of BSCs here
yes, because the BSC_ConnHdlrBscPars is a data type, of which you can form 
records/sets/lists/arrays.  Ports however are separate objects that are 
declared in the component.



--
To view, visit https://gerrit.osmocom.org/9204
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3eabf8537066f43faed8fb983d9e1f4092ec515
Gerrit-Change-Number: 9204
Gerrit-PatchSet: 5
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Thu, 13 Dec 2018 14:07:21 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-bts[master]: osmo-bts-trx/loops.c: Use lchan name based logging

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12289 )

Change subject: osmo-bts-trx/loops.c: Use lchan name based logging
..


Patch Set 2: Code-Review+2

re-adding +2 from Pau after rebase


--
To view, visit https://gerrit.osmocom.org/12289
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6976dd7444c26b1f52741bc367b0311ebbef1718
Gerrit-Change-Number: 12289
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Thu, 13 Dec 2018 14:03:05 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bts[master]: osmo-bts-trx/loops.c: Add comments documenting TA + MS power control ...

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12287 )

Change subject: osmo-bts-trx/loops.c: Add comments documenting TA + MS power 
control loop
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/12287/1/src/osmo-bts-trx/loops.c
File src/osmo-bts-trx/loops.c:

https://gerrit.osmocom.org/#/c/12287/1/src/osmo-bts-trx/loops.c@64
PS1, Line 64:   if (arfcn >= 512 && arfcn <= 885) {
> Not directly related, but: this code looks like a good candidate to be a 
> separate function and perha […]
this entire file looks like it needs to be rewritten, and probably moved to 
common.



--
To view, visit https://gerrit.osmocom.org/12287
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iafea07eb751ed85d29b214576bb0d31ea919cd72
Gerrit-Change-Number: 12287
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Thu, 13 Dec 2018 14:02:28 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-bts[master]: osmo-bts-trx/loops.c: Use lchan name based logging

[Harald Welte]

Hello Pau Espin Pedrol, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/12289

to look at the new patch set (#2).

Change subject: osmo-bts-trx/loops.c: Use lchan name based logging
..

osmo-bts-trx/loops.c: Use lchan name based logging

The loops.c code dates back to ancient times when we printed the TRX
number and the raw channel number to identify a logical channel.  We
meanwhile have gsm_lchan_name() and should use it to log messages
related to this lchan in a common format.

This commit introduces the LOGPLCHAN() helper macro [similar to
osmo-bsc], and uses it from loops.c.

As a result, some functions don't need a chan_nr argument anymore,
while some need to add a new lchan argument.

Change-Id: I6976dd7444c26b1f52741bc367b0311ebbef1718
Related: OS#1622, OS#1851
---
M include/osmo-bts/gsm_data.h
M src/osmo-bts-trx/loops.c
2 files changed, 38 insertions(+), 56 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/89/12289/2
--
To view, visit https://gerrit.osmocom.org/12289
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6976dd7444c26b1f52741bc367b0311ebbef1718
Gerrit-Change-Number: 12289
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmo-bts[master]: osmo-bts-trx/loops.c: Add comments documenting TA + MS power control ...

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12287 )

Change subject: osmo-bts-trx/loops.c: Add comments documenting TA + MS power 
control loop
..


Patch Set 2: Code-Review+2

paus comments are adressed.


--
To view, visit https://gerrit.osmocom.org/12287
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iafea07eb751ed85d29b214576bb0d31ea919cd72
Gerrit-Change-Number: 12287
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Thu, 13 Dec 2018 14:02:50 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bts[master]: osmo-bts-trx/loops.c: Add comments documenting TA + MS power control ...

[Harald Welte]

Hello Pau Espin Pedrol, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/12287

to look at the new patch set (#2).

Change subject: osmo-bts-trx/loops.c: Add comments documenting TA + MS power 
control loop
..

osmo-bts-trx/loops.c: Add comments documenting TA + MS power control loop

The loops.c code is not very easily understood, so let's add some
comments to it.

As can be seen, there are functions of integer type which always return
0, and whose callers don't check for the return value.  This will be
adressed in subsequent patches.

Change-Id: Iafea07eb751ed85d29b214576bb0d31ea919cd72
Related: OS#1622, OS#1851
---
M src/osmo-bts-trx/loops.c
1 file changed, 30 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/87/12287/2
--
To view, visit https://gerrit.osmocom.org/12287
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iafea07eb751ed85d29b214576bb0d31ea919cd72
Gerrit-Change-Number: 12287
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmo-trx[master]: TimevalTest: Make test deterministic with fake time

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12282 )

Change subject: TimevalTest: Make test deterministic with fake time
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12282
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I74e577a0142fb6d1ef3630e02aff9910b191bff9
Gerrit-Change-Number: 12282
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Thu, 13 Dec 2018 13:58:23 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-trx[master]: Timeval: Move to osmo_clock_gettime

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12281 )

Change subject: Timeval: Move to osmo_clock_gettime
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12281
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I24da3e1136c5396062662be1d10b07b4d97cfc2e
Gerrit-Change-Number: 12281
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Thu, 13 Dec 2018 13:58:04 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-trx[master]: TimevalTest: Make test deterministic with fake time

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12282 )

Change subject: TimevalTest: Make test deterministic with fake time
..

TimevalTest: Make test deterministic with fake time

Change-Id: I74e577a0142fb6d1ef3630e02aff9910b191bff9
---
M tests/CommonLibs/TimevalTest.cpp
1 file changed, 18 insertions(+), 7 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/tests/CommonLibs/TimevalTest.cpp b/tests/CommonLibs/TimevalTest.cpp
index 61a92c9..b822982 100644
--- a/tests/CommonLibs/TimevalTest.cpp
+++ b/tests/CommonLibs/TimevalTest.cpp
@@ -31,34 +31,45 @@
 #include 
 #include 

+extern "C" {
+#include 
+}
+
 using namespace std;

 int main(int argc, char *argv[])
 {
-   long last_remaining = 1;
+
+   osmo_clock_override_enable(CLOCK_REALTIME, true);
+
+   struct timespec *clk = osmo_clock_override_gettimespec(CLOCK_REALTIME);
+   clk->tv_sec = 0;
+   clk->tv_nsec = 1000;
+
+   long last_remaining = 1; /*10 sec */
Timeval then(last_remaining);
assert(then.elapsed() == -last_remaining);
cerr << then << " elapsed: " << then.elapsed() << endl;

/* Check that last_remaining parameter affects setting time in the 
future */
-   usleep(1);
+   osmo_clock_override_add(CLOCK_REALTIME, 0, 10*1000*1000);
double increased_time_secs = Timeval().seconds();
-   assert(increased_time_secs <= then.seconds());
+   assert(increased_time_secs < then.seconds());

struct timespec invariant_time  = then.timespec();
int loops = 0;

while (!then.passed()) {
struct timespec tspecnow = then.timespec();
-   cerr << "now: " << Timeval().seconds() << " then: " << then << 
" remaining: " << then.remaining() << endl;
+   cerr << "["<< loops << "] now: " << Timeval().seconds() << " 
then: " << then << " remaining: " << then.remaining() << endl;
assert(last_remaining >= then.remaining());
assert(tspecnow.tv_sec == invariant_time.tv_sec && 
tspecnow.tv_nsec == invariant_time.tv_nsec);
-   usleep(50);
+   osmo_clock_override_add(CLOCK_REALTIME, 0, 50*1000);
loops++;
}
cerr << "now: " << Timeval() << " then: " << then << " remaining: " << 
then.remaining() << endl;
-   assert(then.remaining() <= 0);
-   assert(loops >= 18);
+   assert(then.remaining() == -10);
+   assert(loops == 20);

printf("Done\n");
 }

--
To view, visit https://gerrit.osmocom.org/12282
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I74e577a0142fb6d1ef3630e02aff9910b191bff9
Gerrit-Change-Number: 12282
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-trx[master]: Timeval: Move to osmo_clock_gettime

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12281 )

Change subject: Timeval: Move to osmo_clock_gettime
..

Timeval: Move to osmo_clock_gettime

Change-Id: I24da3e1136c5396062662be1d10b07b4d97cfc2e
---
M CommonLibs/Timeval.cpp
M CommonLibs/Timeval.h
2 files changed, 10 insertions(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/CommonLibs/Timeval.cpp b/CommonLibs/Timeval.cpp
index 21072fc..fd1bcda 100644
--- a/CommonLibs/Timeval.cpp
+++ b/CommonLibs/Timeval.cpp
@@ -27,8 +27,17 @@

 #include "Timeval.h"

+extern "C" {
+#include 
+}
+
 using namespace std;

+void Timeval::now()
+{
+   osmo_clock_gettime(CLOCK_REALTIME, &mTimespec);
+}
+
 void Timeval::future(unsigned offset)
 {
now();
diff --git a/CommonLibs/Timeval.h b/CommonLibs/Timeval.h
index b780af1..7c6a6f6 100644
--- a/CommonLibs/Timeval.h
+++ b/CommonLibs/Timeval.h
@@ -47,7 +47,7 @@
public:

/** Set the value to current time. */
-   void now() { clock_gettime(CLOCK_REALTIME, &mTimespec); }
+   void now();

/** Set the value to gettimeofday plus an offset. */
void future(unsigned ms);

--
To view, visit https://gerrit.osmocom.org/12281
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I24da3e1136c5396062662be1d10b07b4d97cfc2e
Gerrit-Change-Number: 12281
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-trx[master]: Timeval: passed() returns true if time is equal

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12279 )

Change subject: Timeval: passed() returns true if time is equal
..

Timeval: passed() returns true if time is equal

Change-Id: I96a9d26657f85447609693bc6932d218d354b84a
---
M CommonLibs/Timeval.cpp
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/CommonLibs/Timeval.cpp b/CommonLibs/Timeval.cpp
index 50ce05d..991e241 100644
--- a/CommonLibs/Timeval.cpp
+++ b/CommonLibs/Timeval.cpp
@@ -57,7 +57,7 @@
Timeval nowTime;
if (nowTime.mTimeval.tv_sec < mTimeval.tv_sec) return false;
if (nowTime.mTimeval.tv_sec > mTimeval.tv_sec) return true;
-   if (nowTime.mTimeval.tv_usec > mTimeval.tv_usec) return true;
+   if (nowTime.mTimeval.tv_usec >= mTimeval.tv_usec) return true;
return false;
 }


--
To view, visit https://gerrit.osmocom.org/12279
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I96a9d26657f85447609693bc6932d218d354b84a
Gerrit-Change-Number: 12279
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-trx[master]: Timeval: Move implementation to use clock_gettime and timespec

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12280 )

Change subject: Timeval: Move implementation to use clock_gettime and timespec
..

Timeval: Move implementation to use clock_gettime and timespec

According to gettimeofday manual:
"Applications should use the clock_gettime() function instead of the
obsolescent gettimeofday() function."

Furthermore, it may be desirable in the future to use other clocks such
as monotonic.

Change-Id: I2286998c5eefbf3c3dfb105c223daec7a1083803
---
M CommonLibs/Timeval.cpp
M CommonLibs/Timeval.h
2 files changed, 28 insertions(+), 28 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/CommonLibs/Timeval.cpp b/CommonLibs/Timeval.cpp
index 991e241..21072fc 100644
--- a/CommonLibs/Timeval.cpp
+++ b/CommonLibs/Timeval.cpp
@@ -34,36 +34,33 @@
now();
unsigned sec = offset/1000;
unsigned msec = offset%1000;
-   mTimeval.tv_usec += msec*1000;
-   mTimeval.tv_sec += sec;
-   if (mTimeval.tv_usec>100) {
-   mTimeval.tv_usec -= 100;
-   mTimeval.tv_sec += 1;
+   mTimespec.tv_nsec += msec*1000*1000;
+   mTimespec.tv_sec += sec;
+   if (mTimespec.tv_nsec > 1000*1000*1000) {
+   mTimespec.tv_nsec -= 1000*1000*1000;
+   mTimespec.tv_sec += 1;
}
 }


 struct timespec Timeval::timespec() const
 {
-   struct timespec retVal;
-   retVal.tv_sec = mTimeval.tv_sec;
-   retVal.tv_nsec = 1000 * (long)mTimeval.tv_usec;
-   return retVal;
+   return mTimespec;
 }


 bool Timeval::passed() const
 {
Timeval nowTime;
-   if (nowTime.mTimeval.tv_sec < mTimeval.tv_sec) return false;
-   if (nowTime.mTimeval.tv_sec > mTimeval.tv_sec) return true;
-   if (nowTime.mTimeval.tv_usec >= mTimeval.tv_usec) return true;
+   if (nowTime.mTimespec.tv_sec < mTimespec.tv_sec) return false;
+   if (nowTime.mTimespec.tv_sec > mTimespec.tv_sec) return true;
+   if (nowTime.mTimespec.tv_nsec >= mTimespec.tv_nsec) return true;
return false;
 }

 double Timeval::seconds() const
 {
-   return ((double)mTimeval.tv_sec) + 1e-6*((double)mTimeval.tv_usec);
+   return ((double)mTimespec.tv_sec) + 1e-9*((double)mTimespec.tv_nsec);
 }


@@ -72,8 +69,8 @@
 {
// 2^31 milliseconds is just over 4 years.
int32_t deltaS = other.sec() - sec();
-   int32_t deltaUs = other.usec() - usec();
-   return 1000*deltaS + deltaUs/1000;
+   int32_t deltaNs = other.nsec() - nsec();
+   return 1000*deltaS + deltaNs/100;
 }


@@ -89,7 +86,7 @@

 ostream& operator<<(ostream& os, const struct timespec& ts)
 {
-   os << ts.tv_sec << "," << ts.tv_nsec;
+   os << ts.tv_sec << "," << ts.tv_nsec/1000;
return os;
 }

diff --git a/CommonLibs/Timeval.h b/CommonLibs/Timeval.h
index c497864..b780af1 100644
--- a/CommonLibs/Timeval.h
+++ b/CommonLibs/Timeval.h
@@ -42,12 +42,12 @@

private:

-   struct timeval mTimeval;
+   struct timespec mTimespec;

public:

-   /** Set the value to gettimeofday. */
-   void now() { gettimeofday(&mTimeval,NULL); }
+   /** Set the value to current time. */
+   void now() { clock_gettime(CLOCK_REALTIME, &mTimespec); }

/** Set the value to gettimeofday plus an offset. */
void future(unsigned ms);
@@ -55,16 +55,18 @@
//@{
Timeval(unsigned sec, unsigned usec)
{
-   mTimeval.tv_sec = sec;
-   mTimeval.tv_usec = usec;
+   mTimespec.tv_sec = sec;
+   mTimespec.tv_nsec = usec*1000;
}

Timeval(const struct timeval& wTimeval)
-   :mTimeval(wTimeval)
-   {}
+   {
+   mTimespec.tv_sec = wTimeval.tv_sec;
+   mTimespec.tv_nsec = wTimeval.tv_sec*1000;
+   }

/**
-   Create a Timeval offset into the future.
+   Create a Timespec offset into the future.
@param offset milliseconds
*/
Timeval(unsigned offset=0) { future(offset); }
@@ -76,8 +78,9 @@
/** Return total seconds. */
double seconds() const;

-   uint32_t sec() const { return mTimeval.tv_sec; }
-   uint32_t usec() const { return mTimeval.tv_usec; }
+   uint32_t sec() const { return mTimespec.tv_sec; }
+   uint32_t usec() const { return mTimespec.tv_nsec / 1000; }
+   uint32_t nsec() const { return mTimespec.tv_nsec; }

/** Return differnce from other (other-self), in ms. */
long delta(const Timeval& other) const;
@@ -88,11 +91,11 @@
/** Remaining time in ms. */
long remaining() const { return -elapsed(); }

-   /** Return true if the time has passed, as per gettimeofday. */
+   /** Return true if the time has passed, as per 
clock_gettime(CLOCK_REALTIME). */
bo

Change in osmo-trx[master]: Timeval: Move implementation to use clock_gettime and timespec

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12280 )

Change subject: Timeval: Move implementation to use clock_gettime and timespec
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12280
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2286998c5eefbf3c3dfb105c223daec7a1083803
Gerrit-Change-Number: 12280
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Thu, 13 Dec 2018 13:57:37 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-trx[master]: Timeval: passed() returns true if time is equal

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12279 )

Change subject: Timeval: passed() returns true if time is equal
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12279
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I96a9d26657f85447609693bc6932d218d354b84a
Gerrit-Change-Number: 12279
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Thu, 13 Dec 2018 13:55:52 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: require 'ipa-name' option to be set via config file

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12293 )

Change subject: require 'ipa-name' option to be set via config file
..

require 'ipa-name' option to be set via config file

The 'ipa-name' option can now only be set via the configuration file
because changing the IPA name at run-time conflicts with active
GSUP connections and routes configured in the HLR. The osmo-msc
program must be restarted if its IPA name needs to change.

Change-Id: I6cff91793e646e0396e8f1bc87d0f52709e5f12a
Related: OS#3355
---
M include/osmocom/msc/vty.h
M src/libmsc/msc_vty.c
M src/osmo-msc/msc_main.c
3 files changed, 13 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/include/osmocom/msc/vty.h b/include/osmocom/msc/vty.h
index 6a55df7..60a36d7 100644
--- a/include/osmocom/msc/vty.h
+++ b/include/osmocom/msc/vty.h
@@ -31,4 +31,6 @@

 struct gsm_network *gsmnet_from_vty(struct vty *vty);

+extern bool msc_parsing_config_file;
+
 #endif
diff --git a/src/libmsc/msc_vty.c b/src/libmsc/msc_vty.c
index 06e1139..87adc82 100644
--- a/src/libmsc/msc_vty.c
+++ b/src/libmsc/msc_vty.c
@@ -466,6 +466,12 @@
   "This name is used for GSUP routing and must be set if more than one MSC 
is connected to the HLR. "
   "The default is 'MSC-00-00-00-00-00-00'.\n")
 {
+   if (!msc_parsing_config_file) {
+   vty_out(vty, "The IPA name cannot be changed at run-time; "
+   "It can only be set in the configuraton file.%s", 
VTY_NEWLINE);
+   return CMD_WARNING;
+   }
+
gsmnet->msc_ipa_name = talloc_strdup(gsmnet, argv[0]);
return CMD_SUCCESS;
 }
diff --git a/src/osmo-msc/msc_main.c b/src/osmo-msc/msc_main.c
index 8500b97..ce6ae38 100644
--- a/src/osmo-msc/msc_main.c
+++ b/src/osmo-msc/msc_main.c
@@ -24,6 +24,7 @@
  *
  */

+#include 
 #include 
 #include 
 #include 
@@ -514,6 +515,8 @@
 extern void *tall_call_ctx;
 extern void *tall_trans_ctx;

+bool msc_parsing_config_file = false;
+
 int main(int argc, char **argv)
 {
int rc;
@@ -566,7 +569,9 @@
return -1;
 #endif

+   msc_parsing_config_file = true;
rc = vty_read_config_file(msc_cmdline_config.config_file, NULL);
+   msc_parsing_config_file = false;
if (rc < 0) {
LOGP(DMSC, LOGL_FATAL, "Failed to parse the config file: 
'%s'\n",
 msc_cmdline_config.config_file);

--
To view, visit https://gerrit.osmocom.org/12293
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6cff91793e646e0396e8f1bc87d0f52709e5f12a
Gerrit-Change-Number: 12293
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Max 

Change in osmo-msc[master]: require 'ipa-name' option to be set via config file

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12293 )

Change subject: require 'ipa-name' option to be set via config file
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12293
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6cff91793e646e0396e8f1bc87d0f52709e5f12a
Gerrit-Change-Number: 12293
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Max 
Gerrit-Comment-Date: Thu, 13 Dec 2018 13:51:30 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in docker-playground[master]: MSC: use config file for mncc path

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12277 )

Change subject: MSC: use config file for mncc path
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12277
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I689cfb3bad09b76859ef7e42c1312c636eebe637
Gerrit-Change-Number: 12277
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Max 
Gerrit-Reviewer: daniel 
Gerrit-Comment-Date: Thu, 13 Dec 2018 13:47:22 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in python/osmo-python-tests[master]: scripts/*.py: mark as executable

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12294 )

Change subject: scripts/*.py: mark as executable
..

scripts/*.py: mark as executable

osmo-mgw's configure.ac won't find osmotestvty.py, unless it is
executable. This allows passing its ./configure with placing the scripts
dir of osmo-python-tests in PATH, instead of installing it.

Change-Id: If6cefd32d0dc544093db08efc114db86b9bb18b0
---
M scripts/osmo_rate_ctr2csv.py
M scripts/osmodumpdoc.py
M scripts/osmotestconfig.py
M scripts/osmotestvty.py
4 files changed, 0 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/scripts/osmo_rate_ctr2csv.py b/scripts/osmo_rate_ctr2csv.py
old mode 100644
new mode 100755
diff --git a/scripts/osmodumpdoc.py b/scripts/osmodumpdoc.py
old mode 100644
new mode 100755
diff --git a/scripts/osmotestconfig.py b/scripts/osmotestconfig.py
old mode 100644
new mode 100755
diff --git a/scripts/osmotestvty.py b/scripts/osmotestvty.py
old mode 100644
new mode 100755

--
To view, visit https://gerrit.osmocom.org/12294
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: python/osmo-python-tests
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If6cefd32d0dc544093db08efc114db86b9bb18b0
Gerrit-Change-Number: 12294
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in python/osmo-python-tests[master]: scripts/*.py: mark as executable

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12294 )

Change subject: scripts/*.py: mark as executable
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12294
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: python/osmo-python-tests
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If6cefd32d0dc544093db08efc114db86b9bb18b0
Gerrit-Change-Number: 12294
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Thu, 13 Dec 2018 13:46:29 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-dev[master]: run.sh: run osmo-hlr with --db-upgrade

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12295 )

Change subject: run.sh: run osmo-hlr with --db-upgrade
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12295
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I74dd09698dd508fce047ce086a22a369ad9ee6a4
Gerrit-Change-Number: 12295
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Thu, 13 Dec 2018 13:46:07 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-sysmon[master]: Add m4 missing files to fix build

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12283 )

Change subject: Add m4 missing files to fix build
..

Add m4 missing files to fix build

Same files are available in other osmocom projects, otherwise configure
fails with "Please install autoconf-archive; re-run 'autoreconf -fi' for
it to take effect.".

Change-Id: Iabe3207fff8f076a3f4ddc81720bb7fdc671a46c
---
M Makefile.am
A m4/README
A m4/ax_check_compile_flag.m4
3 files changed, 79 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/Makefile.am b/Makefile.am
index 5eb1cfb..cdf67bf 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -1,5 +1,7 @@
 SUBDIRS = doc
 
+ACLOCAL_AMFLAGS = -I m4
+
 AM_CPPFLAGS = \
$(all_includes) \
-I$(top_srcdir) \
diff --git a/m4/README b/m4/README
new file mode 100644
index 000..92eb30b
--- /dev/null
+++ b/m4/README
@@ -0,0 +1,3 @@
+We want to avoid creating too many external build-time dependencies
+like this one to autoconf-archive.  This directory provides a local
+copy of required m4 rules.
diff --git a/m4/ax_check_compile_flag.m4 b/m4/ax_check_compile_flag.m4
new file mode 100644
index 000..ca36397
--- /dev/null
+++ b/m4/ax_check_compile_flag.m4
@@ -0,0 +1,74 @@
+# ===
+#   http://www.gnu.org/software/autoconf-archive/ax_check_compile_flag.html
+# ===
+#
+# SYNOPSIS
+#
+#   AX_CHECK_COMPILE_FLAG(FLAG, [ACTION-SUCCESS], [ACTION-FAILURE], 
[EXTRA-FLAGS], [INPUT])
+#
+# DESCRIPTION
+#
+#   Check whether the given FLAG works with the current language's compiler
+#   or gives an error.  (Warnings, however, are ignored)
+#
+#   ACTION-SUCCESS/ACTION-FAILURE are shell commands to execute on
+#   success/failure.
+#
+#   If EXTRA-FLAGS is defined, it is added to the current language's default
+#   flags (e.g. CFLAGS) when the check is done.  The check is thus made with
+#   the flags: "CFLAGS EXTRA-FLAGS FLAG".  This can for example be used to
+#   force the compiler to issue an error when a bad flag is given.
+#
+#   INPUT gives an alternative input source to AC_COMPILE_IFELSE.
+#
+#   NOTE: Implementation based on AX_CFLAGS_GCC_OPTION. Please keep this
+#   macro in sync with AX_CHECK_{PREPROC,LINK}_FLAG.
+#
+# LICENSE
+#
+#   Copyright (c) 2008 Guido U. Draheim 
+#   Copyright (c) 2011 Maarten Bosmans 
+#
+#   This program is free software: you can redistribute it and/or modify it
+#   under the terms of the GNU General Public License as published by the
+#   Free Software Foundation, either version 3 of the License, or (at your
+#   option) any later version.
+#
+#   This program is distributed in the hope that it will be useful, but
+#   WITHOUT ANY WARRANTY; without even the implied warranty of
+#   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General
+#   Public License for more details.
+#
+#   You should have received a copy of the GNU General Public License along
+#   with this program. If not, see .
+#
+#   As a special exception, the respective Autoconf Macro's copyright owner
+#   gives unlimited permission to copy, distribute and modify the configure
+#   scripts that are the output of Autoconf when processing the Macro. You
+#   need not follow the terms of the GNU General Public License when using
+#   or distributing such scripts, even though portions of the text of the
+#   Macro appear in them. The GNU General Public License (GPL) does govern
+#   all other use of the material that constitutes the Autoconf Macro.
+#
+#   This special exception to the GPL applies to versions of the Autoconf
+#   Macro released by the Autoconf Archive. When you make and distribute a
+#   modified version of the Autoconf Macro, you may extend this special
+#   exception to the GPL to apply to your modified version as well.
+
+#serial 4
+
+AC_DEFUN([AX_CHECK_COMPILE_FLAG],
+[AC_PREREQ(2.64)dnl for _AC_LANG_PREFIX and AS_VAR_IF
+AS_VAR_PUSHDEF([CACHEVAR],[ax_cv_check_[]_AC_LANG_ABBREV[]flags_$4_$1])dnl
+AC_CACHE_CHECK([whether _AC_LANG compiler accepts $1], CACHEVAR, [
+  ax_check_save_flags=$[]_AC_LANG_PREFIX[]FLAGS
+  _AC_LANG_PREFIX[]FLAGS="$[]_AC_LANG_PREFIX[]FLAGS $4 $1"
+  AC_COMPILE_IFELSE([m4_default([$5],[AC_LANG_PROGRAM()])],
+[AS_VAR_SET(CACHEVAR,[yes])],
+[AS_VAR_SET(CACHEVAR,[no])])
+  _AC_LANG_PREFIX[]FLAGS=$ax_check_save_flags])
+AS_VAR_IF(CACHEVAR,yes,
+  [m4_default([$2], :)],
+  [m4_default([$3], :)])
+AS_VAR_POPDEF([CACHEVAR])dnl
+])dnl AX_CHECK_COMPILE_FLAGS

--
To view, visit https://gerrit.osmocom.org/12283
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iabe3207fff8f0

Change in osmo-sysmon[master]: Move source code to src subdir

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12284 )

Change subject: Move source code to src subdir
..

Move source code to src subdir

Change-Id: I1aa2893e2b274f8d087a0d2f126486cd4afcbdfe
---
M Makefile.am
M configure.ac
A src/Makefile.am
R src/osmo-ctrl-client.c
R src/osysmon.h
R src/osysmon_ctrl.c
R src/osysmon_file.c
R src/osysmon_main.c
R src/osysmon_rtnl.c
R src/osysmon_sysinfo.c
R src/simple_ctrl.c
R src/simple_ctrl.h
R src/value_node.c
R src/value_node.h
14 files changed, 56 insertions(+), 56 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Max: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved



diff --git a/Makefile.am b/Makefile.am
index cdf67bf..a838715 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -1,58 +1,3 @@
-SUBDIRS = doc
+SUBDIRS = doc src

 ACLOCAL_AMFLAGS = -I m4
-
-AM_CPPFLAGS = \
-   $(all_includes) \
-   -I$(top_srcdir) \
-   $(NULL)
-
-AM_CFLAGS = \
-   -Wall \
-   $(LIBOSMOCORE_CFLAGS) \
-   $(LIBOSMOGSM_CFLAGS) \
-   $(LIBOSMOVTY_CFLAGS) \
-   $(LIBMNL_CFLAGS) \
-   $(NULL)
-
-AM_LDFLAGS = \
-   $(COVERAGE_LDFLAGS) \
-   $(NULL)
-
-bin_PROGRAMS = \
-   osmo-sysmon \
-   osmo-ctrl-client \
-   $(NULL)
-
-osmo_sysmon_LDADD = \
-   $(LIBOSMOCORE_LIBS) \
-   $(LIBOSMOGSM_LIBS) \
-   $(LIBOSMOVTY_LIBS) \
-   $(LIBMNL_LIBS) \
-   $(NULL)
-
-osmo_sysmon_SOURCES = \
-   value_node.c \
-   simple_ctrl.c \
-   osysmon_ctrl.c \
-   osysmon_sysinfo.c \
-   osysmon_rtnl.c \
-   osysmon_file.c \
-   osysmon_main.c \
-   $(NULL)
-
-osmo_ctrl_client_LDADD = \
-   $(LIBOSMOCORE_LIBS) \
-   $(LIBOSMOGSM_LIBS) \
-   $(NULL)
-
-osmo_ctrl_client_SOURCES = \
-   simple_ctrl.c \
-   osmo-ctrl-client.c \
-   $(NULL)
-
-noinst_HEADERS = \
-   osysmon.h \
-   simple_ctrl.h \
-   value_node.h \
-   $(NULL)
diff --git a/configure.ac b/configure.ac
index 13082b7..734ac99 100644
--- a/configure.ac
+++ b/configure.ac
@@ -129,4 +129,5 @@
 AC_OUTPUT(
 doc/Makefile
 doc/examples/Makefile
+src/Makefile
 Makefile)
diff --git a/src/Makefile.am b/src/Makefile.am
new file mode 100644
index 000..9ad5947
--- /dev/null
+++ b/src/Makefile.am
@@ -0,0 +1,54 @@
+AM_CPPFLAGS = \
+   $(all_includes) \
+   -I$(top_srcdir) \
+   $(NULL)
+
+AM_CFLAGS = \
+   -Wall \
+   $(LIBOSMOCORE_CFLAGS) \
+   $(LIBOSMOGSM_CFLAGS) \
+   $(LIBOSMOVTY_CFLAGS) \
+   $(LIBMNL_CFLAGS) \
+   $(NULL)
+
+AM_LDFLAGS = \
+   $(COVERAGE_LDFLAGS) \
+   $(NULL)
+
+bin_PROGRAMS = \
+   osmo-sysmon \
+   osmo-ctrl-client \
+   $(NULL)
+
+osmo_sysmon_LDADD = \
+   $(LIBOSMOCORE_LIBS) \
+   $(LIBOSMOGSM_LIBS) \
+   $(LIBOSMOVTY_LIBS) \
+   $(LIBMNL_LIBS) \
+   $(NULL)
+
+osmo_sysmon_SOURCES = \
+   value_node.c \
+   simple_ctrl.c \
+   osysmon_ctrl.c \
+   osysmon_sysinfo.c \
+   osysmon_rtnl.c \
+   osysmon_file.c \
+   osysmon_main.c \
+   $(NULL)
+
+osmo_ctrl_client_LDADD = \
+   $(LIBOSMOCORE_LIBS) \
+   $(LIBOSMOGSM_LIBS) \
+   $(NULL)
+
+osmo_ctrl_client_SOURCES = \
+   simple_ctrl.c \
+   osmo-ctrl-client.c \
+   $(NULL)
+
+noinst_HEADERS = \
+   osysmon.h \
+   simple_ctrl.h \
+   value_node.h \
+   $(NULL)
diff --git a/osmo-ctrl-client.c b/src/osmo-ctrl-client.c
similarity index 100%
rename from osmo-ctrl-client.c
rename to src/osmo-ctrl-client.c
diff --git a/osysmon.h b/src/osysmon.h
similarity index 100%
rename from osysmon.h
rename to src/osysmon.h
diff --git a/osysmon_ctrl.c b/src/osysmon_ctrl.c
similarity index 100%
rename from osysmon_ctrl.c
rename to src/osysmon_ctrl.c
diff --git a/osysmon_file.c b/src/osysmon_file.c
similarity index 100%
rename from osysmon_file.c
rename to src/osysmon_file.c
diff --git a/osysmon_main.c b/src/osysmon_main.c
similarity index 100%
rename from osysmon_main.c
rename to src/osysmon_main.c
diff --git a/osysmon_rtnl.c b/src/osysmon_rtnl.c
similarity index 100%
rename from osysmon_rtnl.c
rename to src/osysmon_rtnl.c
diff --git a/osysmon_sysinfo.c b/src/osysmon_sysinfo.c
similarity index 100%
rename from osysmon_sysinfo.c
rename to src/osysmon_sysinfo.c
diff --git a/simple_ctrl.c b/src/simple_ctrl.c
similarity index 100%
rename from simple_ctrl.c
rename to src/simple_ctrl.c
diff --git a/simple_ctrl.h b/src/simple_ctrl.h
similarity index 100%
rename from simple_ctrl.h
rename to src/simple_ctrl.h
diff --git a/value_node.c b/src/value_node.c
similarity index 100%
rename from value_node.c
rename to src/value_node.c
diff --git a/value_node.h b/src/value_node.h
similarity index 100%
rename from value_node.h
rename to src/value_node.h

--
To view, visit https://gerrit.osmocom.org/12284
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.o

Change in osmo-sysmon[master]: Introduce systemd service file and install with autotools

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12286 )

Change subject: Introduce systemd service file and install with autotools
..


Patch Set 2: Code-Review-1

I don't think a systemd service is going to be useful at this point, it would 
probably just be misleading to the user.


--
To view, visit https://gerrit.osmocom.org/12286
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4875b74bcf2b6232d915070b77fc202a03ef997
Gerrit-Change-Number: 12286
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Thu, 13 Dec 2018 13:44:58 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-sysmon[master]: Add cmdline option parsing support

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12285 )

Change subject: Add cmdline option parsing support
..


Patch Set 1: Code-Review+2

I tend to agree with Max that daemonization doesn't make sense. But then, 
unless somebody explicitly uses that particular option, it doesn't hurt either.


--
To view, visit https://gerrit.osmocom.org/12285
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I742974bd1440b09b49d26703c13361dd1c41008b
Gerrit-Change-Number: 12285
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Thu, 13 Dec 2018 13:44:09 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-sysmon[master]: Add m4 missing files to fix build

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12283 )

Change subject: Add m4 missing files to fix build
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12283
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabe3207fff8f076a3f4ddc81720bb7fdc671a46c
Gerrit-Change-Number: 12283
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Thu, 13 Dec 2018 13:41:22 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-sysmon[master]: Move source code to src subdir

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12284 )

Change subject: Move source code to src subdir
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12284
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1aa2893e2b274f8d087a0d2f126486cd4afcbdfe
Gerrit-Change-Number: 12284
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Comment-Date: Thu, 13 Dec 2018 13:41:42 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: stats.h: Fix build on MacOS

[Pau Espin Pedrol]

Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12212 )

Change subject: stats.h: Fix build on MacOS
..

stats.h: Fix build on MacOS

Otherwise struct osmo_stats_config is not defined and compiler fails.

Related: OS#3722
Change-Id: I037c3ca141ecee2d457e0a881a56e32ee24cec4d
---
M include/osmocom/core/stats.h
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Stefan Sperling: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/include/osmocom/core/stats.h b/include/osmocom/core/stats.h
index e4d46ba..e01016d 100644
--- a/include/osmocom/core/stats.h
+++ b/include/osmocom/core/stats.h
@@ -28,7 +28,7 @@
  * embedded systems.  We cannot use the autoconf-defined HAVE_... macros
  * here, as that only works at library compile time, not at application
  * compile time */
-#ifdef unix
+#if defined(unix) || defined(__APPLE__)

 #include 
 #include 
@@ -141,5 +141,5 @@
 int osmo_stats_reporter_udp_open(struct osmo_stats_reporter *srep);
 int osmo_stats_reporter_udp_close(struct osmo_stats_reporter *srep);

-#endif /* unix */
+#endif /* unix || __APPLE__ */
 /*! @} */

--
To view, visit https://gerrit.osmocom.org/12212
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I037c3ca141ecee2d457e0a881a56e32ee24cec4d
Gerrit-Change-Number: 12212
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Stefan Sperling 

Change in osmo-dev[master]: run.sh: run osmo-hlr with --db-upgrade

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12295 )

Change subject: run.sh: run osmo-hlr with --db-upgrade
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12295
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I74dd09698dd508fce047ce086a22a369ad9ee6a4
Gerrit-Change-Number: 12295
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Thu, 13 Dec 2018 12:33:58 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-dev[master]: run.sh: run osmo-hlr with --db-upgrade

[osmith]

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/12295


Change subject: run.sh: run osmo-hlr with --db-upgrade
..

run.sh: run osmo-hlr with --db-upgrade

Do not stop if the DB needs to be upgraded.

Change-Id: I74dd09698dd508fce047ce086a22a369ad9ee6a4
---
M net/tmpl_std/run.sh
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/95/12295/1

diff --git a/net/tmpl_std/run.sh b/net/tmpl_std/run.sh
index 829c236..f31330b 100755
--- a/net/tmpl_std/run.sh
+++ b/net/tmpl_std/run.sh
@@ -67,7 +67,7 @@
 #mgw4bsc="gdb -ex run --args osmo-mgw -c osmo-mgw-for-bsc.cfg"
 #mgw4bsc="strace osmo-mgw -c osmo-mgw-for-bsc.cfg"
 mgw4bsc="osmo-mgw -c osmo-mgw-for-bsc.cfg"
-hlr="LD_LIBRARY_PATH=/usr/local/lib gdb -ex run --args osmo-hlr"
+hlr="LD_LIBRARY_PATH=/usr/local/lib gdb -ex run --args osmo-hlr --db-upgrade"
 stp="osmo-stp"
 bsc="LD_LIBRARY_PATH=/usr/local/lib gdb -ex run --args osmo-bsc -c 
osmo-bsc.cfg"


--
To view, visit https://gerrit.osmocom.org/12295
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I74dd09698dd508fce047ce086a22a369ad9ee6a4
Gerrit-Change-Number: 12295
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 

Change in python/osmo-python-tests[master]: scripts/*.py: mark as executable

[osmith]

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/12294


Change subject: scripts/*.py: mark as executable
..

scripts/*.py: mark as executable

osmo-mgw's configure.ac won't find osmotestvty.py, unless it is
executable. This allows passing its ./configure with placing the scripts
dir of osmo-python-tests in PATH, instead of installing it.

Change-Id: If6cefd32d0dc544093db08efc114db86b9bb18b0
---
M scripts/osmo_rate_ctr2csv.py
M scripts/osmodumpdoc.py
M scripts/osmotestconfig.py
M scripts/osmotestvty.py
4 files changed, 0 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/python/osmo-python-tests 
refs/changes/94/12294/1

diff --git a/scripts/osmo_rate_ctr2csv.py b/scripts/osmo_rate_ctr2csv.py
old mode 100644
new mode 100755
diff --git a/scripts/osmodumpdoc.py b/scripts/osmodumpdoc.py
old mode 100644
new mode 100755
diff --git a/scripts/osmotestconfig.py b/scripts/osmotestconfig.py
old mode 100644
new mode 100755
diff --git a/scripts/osmotestvty.py b/scripts/osmotestvty.py
old mode 100644
new mode 100755

--
To view, visit https://gerrit.osmocom.org/12294
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: python/osmo-python-tests
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If6cefd32d0dc544093db08efc114db86b9bb18b0
Gerrit-Change-Number: 12294
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 

Change in docker-playground[master]: MSC: use config file for mncc path

[daniel]

daniel has posted comments on this change. ( https://gerrit.osmocom.org/12277 )

Change subject: MSC: use config file for mncc path
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12277
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I689cfb3bad09b76859ef7e42c1312c636eebe637
Gerrit-Change-Number: 12277
Gerrit-PatchSet: 1
Gerrit-Owner: Max 
Gerrit-Reviewer: Max 
Gerrit-Reviewer: daniel 
Gerrit-Comment-Date: Thu, 13 Dec 2018 12:16:02 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-gsm-tester[master]: ms_driver: Add a virtual bts and make use of it

[Pau Espin Pedrol]

Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12209 )

Change subject: ms_driver: Add a virtual bts and make use of it
..

ms_driver: Add a virtual bts and make use of it

It's very close to the osmo-bts-trx but without osmo-trx. Modify
the suite to make use of this BTS.

Change-Id: I9f5a2501eb4473ccf2287c902ee207c6a45a1bc5
---
M example/defaults.conf
M example/resources.conf.prod
A src/osmo_gsm_tester/bts_osmovirtual.py
M src/osmo_gsm_tester/resource.py
A src/osmo_gsm_tester/templates/osmo-bts-virtual.cfg.tmpl
M suites/nitb_netreg_mass/suite.conf
6 files changed, 175 insertions(+), 2 deletions(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/example/defaults.conf b/example/defaults.conf
index eee17b1..3de5e29 100644
--- a/example/defaults.conf
+++ b/example/defaults.conf
@@ -84,3 +84,6 @@
   type: uhd
   launch_trx: true
   clock_reference: internal
+
+osmo_bts_virtual:
+  max_trx: 1
diff --git a/example/resources.conf.prod b/example/resources.conf.prod
index e786836..e6ade3a 100644
--- a/example/resources.conf.prod
+++ b/example/resources.conf.prod
@@ -110,6 +110,12 @@
 device: '01:01:4d:98:24'
 port: '3'

+- label: OsmoBTS Virtual
+  type: osmo-bts-virtual
+  ipa_unit_id: 13
+  addr: 10.42.42.55
+  band: GSM-1800
+
 arfcn:
   - arfcn: 512
 band: GSM-1800
diff --git a/src/osmo_gsm_tester/bts_osmovirtual.py 
b/src/osmo_gsm_tester/bts_osmovirtual.py
new file mode 100644
index 000..516d992
--- /dev/null
+++ b/src/osmo_gsm_tester/bts_osmovirtual.py
@@ -0,0 +1,115 @@
+# osmo_gsm_tester: specifics for running an osmo-bts-virtual
+#
+# Copyright (C) 2016-2017 by sysmocom - s.f.m.c. GmbH
+# Copyright (C) 2018 Holger Hans Peter Freyther
+#
+# Author: Neels Hofmeyr 
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as
+# published by the Free Software Foundation, either version 3 of the
+# License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see .
+
+import os
+import pprint
+from . import config, util, template, process, bts_osmo
+
+class OsmoBtsVirtual(bts_osmo.OsmoBtsMainUnit):
+##
+# PROTECTED
+##
+
+BIN_BTS = 'osmo-bts-virtual'
+BIN_PCU = 'osmo-pcu'
+
+CONF_BTS = 'osmo-bts-virtual.cfg'
+
+def __init__(self, suite_run, conf):
+"""Initializes the OsmoBtsVirtual."""
+super().__init__(suite_run, conf, OsmoBtsVirtual.BIN_BTS, 
'osmo_bts_virtual')
+self.run_dir = None
+self.inst = None
+self.env = {}
+
+def launch_process(self, keepalive, binary_name, *args):
+"""Launches the osmo-bts-virtual process."""
+
+binary = os.path.abspath(self.inst.child('bin', binary_name))
+run_dir = self.run_dir.new_dir(binary_name)
+if not os.path.isfile(binary):
+raise RuntimeError('Binary missing: %r' % binary)
+proc = process.Process(binary_name, run_dir,
+   (binary,) + args,
+   env=self.env)
+self.suite_run.remember_to_stop(proc, keepalive)
+proc.launch()
+return proc
+
+def configure(self):
+"""Builds the configuration for osmo-bts-virtual and writes it to a 
file."""
+
+if self.bsc is None:
+raise RuntimeError('BTS needs to be added to a BSC or NITB before 
it can be configured')
+self.config_file = self.run_dir.new_file(OsmoBtsVirtual.CONF_BTS)
+self.dbg(config_file=self.config_file)
+
+values = dict(osmo_bts_virtual=config.get_defaults('osmo_bts_virtual'))
+config.overlay(values, self.suite_run.config())
+config.overlay(values, {
+'osmo_bts_virtual': {
+'oml_remote_ip': self.bsc.addr(),
+'pcu_socket_path': self.pcu_socket_path(),
+}
+})
+config.overlay(values, { 'osmo_bts_virtual': self.conf })
+
+self.dbg('OSMO-BTS-VIRTUAL CONFIG:\n' + pprint.pformat(values))
+
+with open(self.config_file, 'w') as f:
+r = template.render(OsmoBtsVirtual.CONF_BTS, values)
+self.dbg(r)
+f.write(r)
+
+
+# PUBLIC - INTERNAL API
+
+def conf_for_bsc(self):
+"""Returns the configuration for the BSC (including the BSC/NITB 
IP)."""
+values = self.conf_for_bsc_prepare()
+self.db

Change in osmo-sysmon[master]: Introduce systemd service file and install with autotools

[Pau Espin Pedrol]

Hello Max, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/12286

to look at the new patch set (#2).

Change subject: Introduce systemd service file and install with autotools
..

Introduce systemd service file and install with autotools

Change-Id: Ic4875b74bcf2b6232d915070b77fc202a03ef997
---
M Makefile.am
M configure.ac
A contrib/Makefile.am
A contrib/systemd/Makefile.am
A contrib/systemd/osmo-sysmon.service
5 files changed, 41 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-sysmon refs/changes/86/12286/2
--
To view, visit https://gerrit.osmocom.org/12286
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic4875b74bcf2b6232d915070b77fc202a03ef997
Gerrit-Change-Number: 12286
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmo-sysmon[master]: Install systemd services with autotools

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12286 )

Change subject: Install systemd services with autotools
..


Patch Set 1:

(1 comment)

> (1 comment)
 >
 > In general, see comment on the previous patch: I'm not convinced we
 > would ever run this as daemon because the whole purpose of this is
 > to regularly display stuff on the console. Hence detaching it from
 > the console seems kinda pointless to me.

See my comment in previous patch explaining it may be useful to use it as a 
daemon.

https://gerrit.osmocom.org/#/c/12286/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/12286/1//COMMIT_MSG@7
PS1, Line 7: Install systemd services with autotools
> That's misleading - you're not just installing it, you've also added the 
> service etc. […]
I re-used same commit message I used in most osmocom projects when I added 
systemd bits, so it can be matched to see similar stuff was done here.



--
To view, visit https://gerrit.osmocom.org/12286
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4875b74bcf2b6232d915070b77fc202a03ef997
Gerrit-Change-Number: 12286
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Thu, 13 Dec 2018 11:37:31 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-sysmon[master]: Add cmdline option parsing support

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12285 )

Change subject: Add cmdline option parsing support
..


Patch Set 1:

> (1 comment)
 >
 > This program regularly print stuff on screen based on config file -
 > kinda similar to "watch". Why and when would we want to run it as
 > daemon?

You may still want to run it as a daemon and log to a file or syslog/journald 
to have a log where you can see evolution of the state of the system. For 
instance to see if some link broke during a wile and for how much time.
It's true that the output format is not the best to be used this way, but it 
can be improved later via some cmd line opt to print in a better format for 
this kind of scenario (like printing only relevant changes, or everything in 1 
line).


--
To view, visit https://gerrit.osmocom.org/12285
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I742974bd1440b09b49d26703c13361dd1c41008b
Gerrit-Change-Number: 12285
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Thu, 13 Dec 2018 11:34:47 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-gsm-tester[master]: ms_driver: Add a virtual bts and make use of it

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12209 )

Change subject: ms_driver: Add a virtual bts and make use of it
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12209
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f5a2501eb4473ccf2287c902ee207c6a45a1bc5
Gerrit-Change-Number: 12209
Gerrit-PatchSet: 3
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Holger Freyther 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Thu, 13 Dec 2018 11:19:00 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ci[master]: Reserve an ip address for the osmo-bts-virtual

[Pau Espin Pedrol]

Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12292 )

Change subject: Reserve an ip address for the osmo-bts-virtual
..

Reserve an ip address for the osmo-bts-virtual

Change-Id: Ia3b52d6fc66efc032b7de4769ad603da177e13da
---
M ansible/roles/gsm-tester-network/templates/interface.j2
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, approved; Verified



diff --git a/ansible/roles/gsm-tester-network/templates/interface.j2 
b/ansible/roles/gsm-tester-network/templates/interface.j2
index 30af679..b57aabb 100644
--- a/ansible/roles/gsm-tester-network/templates/interface.j2
+++ b/ansible/roles/gsm-tester-network/templates/interface.j2
@@ -73,3 +73,9 @@
 iface {{ bts_interface }}:13 inet static
 address 10.42.42.54
 netmask 255.255.255.0
+
+
+auto {{ bts_interface }}:14
+iface {{ bts_interface }}:14 inet static
+address 10.42.42.55
+netmask 255.255.255.0

--
To view, visit https://gerrit.osmocom.org/12292
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia3b52d6fc66efc032b7de4769ad603da177e13da
Gerrit-Change-Number: 12292
Gerrit-PatchSet: 1
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmo-trx[master]: LMSDevice: make use of dev-args in osmo-trx.cfg

[Pau Espin Pedrol]

Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12245 )

Change subject: LMSDevice: make use of dev-args in osmo-trx.cfg
..

LMSDevice: make use of dev-args in osmo-trx.cfg

Allow selecting a specific LimeSDR device by setting dev-args in the
config file. Split up the given dev-args address by comma and select
the device where all substrings can be found.

I could not test this with real hardware, but I have added a test case
to make sure this works as expected.

Related: OS#3654
Change-Id: Ib9aaa066a01bf9de3f78234d7ada884d6f28c852
---
M .gitignore
M Transceiver52M/device/lms/LMSDevice.cpp
A tests/Transceiver52M/LMSDeviceTest.cpp
M tests/Transceiver52M/Makefile.am
M tests/testsuite.at
5 files changed, 98 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Pau Espin Pedrol: Looks good to me, approved



diff --git a/.gitignore b/.gitignore
index ad4c4e3..f163fb6 100644
--- a/.gitignore
+++ b/.gitignore
@@ -18,6 +18,7 @@
 tests/CommonLibs/VectorTest
 tests/CommonLibs/PRBSTest
 tests/Transceiver52M/convolve_test
+tests/Transceiver52M/LMSDeviceTest

 # automake/autoconf
 *.in
diff --git a/Transceiver52M/device/lms/LMSDevice.cpp 
b/Transceiver52M/device/lms/LMSDevice.cpp
index 5e21894..270bd4a 100644
--- a/Transceiver52M/device/lms/LMSDevice.cpp
+++ b/Transceiver52M/device/lms/LMSDevice.cpp
@@ -21,6 +21,7 @@
 #include "Logger.h"
 #include "Threads.h"
 #include "LMSDevice.h"
+#include "Utils.h"

 #include 

@@ -95,6 +96,35 @@
   << " Step=" << range->step;
 }

+/*! Find the device string that matches all filters from \a args.
+ *  \param[in] info_list device addresses found by LMS_GetDeviceList()
+ *  \param[in] count length of info_list
+ *  \param[in] args dev-args value from osmo-trx.cfg, containing comma 
separated key=value pairs
+ *  \return index of first matching device or -1 (no match) */
+int info_list_find(lms_info_str_t* info_list, unsigned int count, const 
std::string &args)
+{
+   unsigned int i, j;
+   vector filters;
+
+   filters = comma_delimited_to_vector(args.c_str());
+
+   /* iterate over device addresses */
+   for (i=0; i < count; i++) {
+   /* check if all filters match */
+   bool match = true;
+   for (j=0; j < filters.size(); j++) {
+   if (!strstr(info_list[i], filters[j].c_str())) {
+   match = false;
+   break;
+   }
+   }
+
+   if (match)
+   return i;
+   }
+   return -1;
+}
+
 int LMSDevice::open(const std::string &args, int ref, bool swap_channels)
 {
//lms_info_str_t dev_str;
@@ -103,7 +133,7 @@
float_type sr_host, sr_rf, lpfbw_rx, lpfbw_tx;
uint16_t dac_val;
unsigned int i, n;
-   int rc;
+   int rc, dev_id;

LOGC(DDEV, INFO) << "Opening LMS device..";

@@ -123,7 +153,15 @@
for (i = 0; i < n; i++)
LOGC(DDEV, INFO) << "Device [" << i << "]: " << info_list[i];

-   rc = LMS_Open(&m_lms_dev, info_list[0], NULL);
+   dev_id = info_list_find(info_list, n, args);
+   if (dev_id == -1) {
+   LOGC(DDEV, ERROR) << "No LMS device found with address '" << 
args << "'";
+   delete[] info_list;
+   return -1;
+   }
+
+   LOGC(DDEV, INFO) << "Using device[" << dev_id << "]";
+   rc = LMS_Open(&m_lms_dev, info_list[dev_id], NULL);
if (rc != 0) {
LOGC(DDEV, ERROR) << "LMS_GetDeviceList() failed)";
delete [] info_list;
diff --git a/tests/Transceiver52M/LMSDeviceTest.cpp 
b/tests/Transceiver52M/LMSDeviceTest.cpp
new file mode 100644
index 000..d40a7ec
--- /dev/null
+++ b/tests/Transceiver52M/LMSDeviceTest.cpp
@@ -0,0 +1,41 @@
+#include 
+#include 
+#include 
+
+extern "C"
+{
+size_t osmo_strlcpy(char *dst, const char *src, size_t siz);
+}
+
+int info_list_find(lms_info_str_t* info_list, unsigned int count, const 
std::string &args);
+
+using namespace std;
+
+int main(void)
+{
+   unsigned int count;
+   lms_info_str_t* info_list;
+   std::string args;
+
+   /* two fake entries for info_list */
+   count = 2;
+   info_list = new lms_info_str_t[count];
+   osmo_strlcpy(info_list[0], "LimeSDR Mini, addr=24607:1337, 
serial=FAKESERIAL0001", sizeof(lms_info_str_t));
+   osmo_strlcpy(info_list[1], "LimeSDR Mini, addr=24607:1338, 
serial=FAKESERIAL0002", sizeof(lms_info_str_t));
+
+   /* find second entry by args filter */
+   args = "serial=FAKESERIAL0002,LimeSDR Mini";
+   assert(info_list_find(info_list, count, args) == 1);
+
+   /* empty args -> first entry */
+   args = "";
+   assert(info_list_find(info_list, count, args) == 0);
+
+   /* not matching args -> -1 */
+   args = "serial=NOTMATCHING";
+   assert(

Change in osmo-trx[master]: LMSDevice: make use of dev-args in osmo-trx.cfg

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12245 )

Change subject: LMSDevice: make use of dev-args in osmo-trx.cfg
..


Patch Set 5: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/12245/4/tests/Transceiver52M/Makefile.am
File tests/Transceiver52M/Makefile.am:

https://gerrit.osmocom.org/#/c/12245/4/tests/Transceiver52M/Makefile.am@25
PS4, Line 25:   $(top_builddir)/Transceiver52M/device/lms/libdevice.la \
> Thanks. Applied the changes, but with […]
Yes, correct, you should use top_builddir there :)



--
To view, visit https://gerrit.osmocom.org/12245
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9aaa066a01bf9de3f78234d7ada884d6f28c852
Gerrit-Change-Number: 12245
Gerrit-PatchSet: 5
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Thu, 13 Dec 2018 11:12:31 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in osmo-sysmon[master]: Install systemd services with autotools

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/12286 )

Change subject: Install systemd services with autotools
..


Patch Set 1:

(1 comment)

In general, see comment on the previous patch: I'm not convinced we would ever 
run this as daemon because the whole purpose of this is to regularly display 
stuff on the console. Hence detaching it from the console seems kinda pointless 
to me.

https://gerrit.osmocom.org/#/c/12286/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/12286/1//COMMIT_MSG@7
PS1, Line 7: Install systemd services with autotools
That's misleading - you're not just installing it, you've also added the 
service etc. More elaborate description please in such cases.



--
To view, visit https://gerrit.osmocom.org/12286
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4875b74bcf2b6232d915070b77fc202a03ef997
Gerrit-Change-Number: 12286
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Max 
Gerrit-Comment-Date: Thu, 13 Dec 2018 11:11:12 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-sysmon[master]: Install systemd services with autotools

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/12286 )

Change subject: Install systemd services with autotools
..


Patch Set 1: Code-Review-1


--
To view, visit https://gerrit.osmocom.org/12286
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4875b74bcf2b6232d915070b77fc202a03ef997
Gerrit-Change-Number: 12286
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Comment-Date: Thu, 13 Dec 2018 11:11:17 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ci[master]: Reserve an ip address for the osmo-bts-virtual

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12292 )

Change subject: Reserve an ip address for the osmo-bts-virtual
..


Patch Set 1:

IP addr are not added to prod and RnD setup, you can already use them.


--
To view, visit https://gerrit.osmocom.org/12292
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3b52d6fc66efc032b7de4769ad603da177e13da
Gerrit-Change-Number: 12292
Gerrit-PatchSet: 1
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Thu, 13 Dec 2018 11:09:43 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-ci[master]: Reserve an ip address for the osmo-bts-virtual

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12292 )

Change subject: Reserve an ip address for the osmo-bts-virtual
..


Patch Set 1: Verified+1


--
To view, visit https://gerrit.osmocom.org/12292
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3b52d6fc66efc032b7de4769ad603da177e13da
Gerrit-Change-Number: 12292
Gerrit-PatchSet: 1
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Thu, 13 Dec 2018 11:09:25 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-sysmon[master]: Move source code to src subdir

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/12284 )

Change subject: Move source code to src subdir
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12284
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1aa2893e2b274f8d087a0d2f126486cd4afcbdfe
Gerrit-Change-Number: 12284
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Comment-Date: Thu, 13 Dec 2018 11:07:51 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-sysmon[master]: Add cmdline option parsing support

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/12285 )

Change subject: Add cmdline option parsing support
..


Patch Set 1: Code-Review-1

(1 comment)

This program regularly print stuff on screen based on config file - kinda 
similar to "watch". Why and when would we want to run it as daemon?

https://gerrit.osmocom.org/#/c/12285/1/src/osysmon_main.c
File src/osysmon_main.c:

https://gerrit.osmocom.org/#/c/12285/1/src/osysmon_main.c@224
PS1, Line 224:  rc = osmo_daemonize();
What would be use-case for this?



--
To view, visit https://gerrit.osmocom.org/12285
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I742974bd1440b09b49d26703c13361dd1c41008b
Gerrit-Change-Number: 12285
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Comment-Date: Thu, 13 Dec 2018 11:06:08 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in osmo-ci[master]: Reserve an ip address for the osmo-bts-virtual

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12292 )

Change subject: Reserve an ip address for the osmo-bts-virtual
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12292
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3b52d6fc66efc032b7de4769ad603da177e13da
Gerrit-Change-Number: 12292
Gerrit-PatchSet: 1
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Thu, 13 Dec 2018 11:04:50 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bts[master]: osmo-bts-trx/loops.c: Make code control flow more readable

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12290 )

Change subject: osmo-bts-trx/loops.c: Make code control flow more readable
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12290
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I819f0c80e90855e8b3252795c837f8e3053b6e87
Gerrit-Change-Number: 12290
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Thu, 13 Dec 2018 11:02:57 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: require 'ipa-name' option to be set via config file

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/12293 )

Change subject: require 'ipa-name' option to be set via config file
..


Patch Set 1:

(2 comments)

That's a minor note though - mostly commenting just in case I need the same 
thing for some config option in future :)

https://gerrit.osmocom.org/#/c/12293/1/src/osmo-msc/msc_main.c
File src/osmo-msc/msc_main.c:

https://gerrit.osmocom.org/#/c/12293/1/src/osmo-msc/msc_main.c@518
PS1, Line 518: bool msc_parsing_config_file = false;
Why not initialize it with true to begin with?


https://gerrit.osmocom.org/#/c/12293/1/src/osmo-msc/msc_main.c@572
PS1, Line 572:  msc_parsing_config_file = true;
So, here it's set to true.



--
To view, visit https://gerrit.osmocom.org/12293
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6cff91793e646e0396e8f1bc87d0f52709e5f12a
Gerrit-Change-Number: 12293
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Max 
Gerrit-Comment-Date: Thu, 13 Dec 2018 11:01:01 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-bts[master]: osmo-bts-trx/loops.c: Use lchan name based logging

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12289 )

Change subject: osmo-bts-trx/loops.c: Use lchan name based logging
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12289
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6976dd7444c26b1f52741bc367b0311ebbef1718
Gerrit-Change-Number: 12289
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Thu, 13 Dec 2018 11:00:52 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bts[master]: osmo-bts-trx/loops.[ch]: Make functions "void" if they always return 0

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12288 )

Change subject: osmo-bts-trx/loops.[ch]: Make functions "void" if they always 
return 0
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12288
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3575a2cef75f3fd4c3f95eddb40719d28a055b54
Gerrit-Change-Number: 12288
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Thu, 13 Dec 2018 10:58:50 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bts[master]: osmo-bts-trx/loops.c: Add comments documenting TA + MS power control ...

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12287 )

Change subject: osmo-bts-trx/loops.c: Add comments documenting TA + MS power 
control loop
..


Patch Set 1: Code-Review+1

(3 comments)

https://gerrit.osmocom.org/#/c/12287/1/src/osmo-bts-trx/loops.c
File src/osmo-bts-trx/loops.c:

https://gerrit.osmocom.org/#/c/12287/1/src/osmo-bts-trx/loops.c@41
PS1, Line 41:  *  \param lchan logical channel for which to compute (and in 
whihc to store) new power.
typo: which
"new power value" seems more appropiate.
Probably also add: "new power value from previous value"


https://gerrit.osmocom.org/#/c/12287/1/src/osmo-bts-trx/loops.c@52
PS1, Line 52:   /* compute new target MS output power level based on current 
value subtracted by 'diff/2' */
s/current/previous would be more easy to catch. current may refer to new or old 
one.

Perhaps you want to explain somehow why diff/2. I think it's because we use 
steps of 2dB as granularity?


https://gerrit.osmocom.org/#/c/12287/1/src/osmo-bts-trx/loops.c@64
PS1, Line 64:   if (arfcn >= 512 && arfcn <= 885) {
Not directly related, but: this code looks like a good candidate to be a 
separate function and perhaps in libosmogsm? osmo_max_power_ms_by_band() or 
similar.



--
To view, visit https://gerrit.osmocom.org/12287
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iafea07eb751ed85d29b214576bb0d31ea919cd72
Gerrit-Change-Number: 12287
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Thu, 13 Dec 2018 10:58:16 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in osmo-sgsn[master]: ACL: integrate sanitize check into sgsn_acl_* functions

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/12227 )

Change subject: ACL: integrate sanitize check into sgsn_acl_* functions
..


Patch Set 5:

> Patch Set 5:
> I did, maybe it was not clear enough: "I think sanitizing the imsi should be 
> done by caller of sgsn_acl_* based on where the information come from (from 
> the wire or from known sanitized source)."
> 

Hmm, I was sure I've addressed it already. Anyway, the "where the information 
come from" is not applicable because it only comes from a single source which 
is not trusted so we always sanitize it.

> If you know your data is sane there's no need to re-sanitize it.

That's not our case.

> You should expect the caller of a data struct to provide sane data instead of 
> internally sanitizing it and storing different data from what was provided.

Sorry, you've lost me with "caller of a data struct" - what do you mean by that?

> It's responsibility of the caller (vty code for instance) to make sure parse 
> of human input is correctly parsed and sanitized.

I disagree, and the code I've looked over seems to disagree as well.
For example, in osmo_bsc_vty.c:
* osmo_mcc_from_str() sanitize data internally
* gsm_parse_reg() regexp compiled and result checked outside of vty

In general, I don't see any non-trivial checks done inside vty which I think is 
the right thing. What would be the advantage of having this check in separate 
file instead of static function in the same file? We can also move it to 
libosmocore but I don't see any benefits from keeping it in vty. Do you?

> You can do checks inside the data structure if you want (I wouldn't), but I'd 
> avoid changing content of the data being handled in there.

You mean inside function?

The rest would be addressed in a next revision.


-- 
To view, visit https://gerrit.osmocom.org/12227
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3dff108148683b107e9edac430a0475283580e9
Gerrit-Change-Number: 12227
Gerrit-PatchSet: 5
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-CC: Stefan Sperling 
Gerrit-Comment-Date: Thu, 13 Dec 2018 10:49:18 +
Gerrit-HasComments: No
Gerrit-HasLabels: No