Build failure of network:osmocom:nightly/libosmocore in Raspbian_9.0/armv7l
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Raspbian_9.0/armv7l Package network:osmocom:nightly/libosmocore failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of build log: [ 771s] | This file was extended by libosmocore config.status 1.1.0.80-8f67, which was [ 771s] | generated by GNU Autoconf 2.69. Invocation command line was [ 771s] | [ 771s] | CONFIG_FILES= [ 771s] | CONFIG_HEADERS = [ 771s] | CONFIG_LINKS= [ 771s] | CONFIG_COMMANDS = [ 771s] | $ ./config.status Doxyfile.core [ 771s] | [ 771s] | on obs-arm-5 [ 771s] | [ 771s] | config.status:1200: creating Doxyfile.core [ 771s] [ 771s] debian/rules:26: recipe for target 'override_dh_auto_test' failed [ 771s] make[1]: *** [override_dh_auto_test] Error 1 [ 771s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 771s] debian/rules:15: recipe for target 'build' failed [ 771s] make: *** [build] Error 2 [ 771s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 771s] [ 771s] obs-arm-5 failed "build libosmocore_1.1.0.80.8f67.dsc" at Thu Jul 18 04:44:53 UTC 2019. [ 771s] [ 771s] ### VM INTERACTION START ### [ 773s] [ 739.650671] sysrq: SysRq : Power Off [ 773s] [ 739.652896] reboot: Power down [ 774s] ### VM INTERACTION END ### [ 774s] [ 774s] obs-arm-5 failed "build libosmocore_1.1.0.80.8f67.dsc" at Thu Jul 18 04:44:58 UTC 2019. [ 774s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-python-tests in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-python-tests/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-python-tests failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-python-tests Last lines of build log: [ 112s] rm -rf /usr/src/packages/BUILD/debian/python3-osmopy-utils/usr/lib [ 112s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 112s]dh_installdocs [ 112s]dh_installchangelogs [ 113s]dh_python2 [ 113s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmotestvty.py [ 113s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmotestconfig.py [ 113s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmodumpdoc.py [ 113s]dh_python3 [ 113s]debian/rules override_dh_installinit [ 113s] make[1]: Entering directory '/usr/src/packages/BUILD' [ 113s] # Install service file with different name than package name: [ 113s] # https://unix.stackexchange.com/questions/306234/is-it-possible-to-install-two-services-for-one-package-using-dh-installinit-how [ 113s] dh_installinit --name=osmo-ctrl2cgi [ 113s] dh_installinit: --name=osmo-ctrl2cgi option specified, but init script nor default file not found [ 113s] make[1]: *** [debian/rules:19: override_dh_installinit] Error 255 [ 113s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 113s] make: *** [debian/rules:4: binary] Error 2 [ 113s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 113s] [ 113s] cloud109 failed "build osmo-python-tests_0.0.9.20190718.dsc" at Thu Jul 18 04:23:02 UTC 2019. [ 113s] [ 113s] ### VM INTERACTION START ### [ 116s] [ 99.422146] sysrq: SysRq : Power Off [ 116s] [ 99.426478] reboot: Power down [ 116s] ### VM INTERACTION END ### [ 116s] [ 116s] cloud109 failed "build osmo-python-tests_0.0.9.20190718.dsc" at Thu Jul 18 04:23:06 UTC 2019. [ 116s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Change in ...libosmocore[master]: bitvec/bitval2mask(): cosmetic: get rid of temporary int variable
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14825 ) Change subject: bitvec/bitval2mask(): cosmetic: get rid of temporary int variable .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14825 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9d6f6b66c99c43107d1ad3e80af332e967bb19e8 Gerrit-Change-Number: 14825 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Jul 2019 22:22:33 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...libosmocore[master]: osmo_gsm48_rest_octets_si3_decode(): fix copy-paste error in comment
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14824 ) Change subject: osmo_gsm48_rest_octets_si3_decode(): fix copy-paste error in comment .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14824 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I57a330e16cc2910597672e1b27cf971499cea5bc Gerrit-Change-Number: 14824 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Jul 2019 22:22:03 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-tetra[master]: Fix typos
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/14823 ) Change subject: Fix typos .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/14823 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: I1aae0a52fcf978900fa847a3f813beb2a5ad4a84 Gerrit-Change-Number: 14823 Gerrit-PatchSet: 1 Gerrit-Owner: roox Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Jul 2019 22:21:35 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...gapk[master]: Fix typos
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/gapk/+/14822 ) Change subject: Fix typos .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/gapk/+/14822 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gapk Gerrit-Branch: master Gerrit-Change-Id: Ie8054f3d484fe5d82cc5d91f159906a470fc4511 Gerrit-Change-Number: 14822 Gerrit-PatchSet: 1 Gerrit-Owner: roox Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Jul 2019 22:21:02 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-bts[master]: Fix common misspellings and typos
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14821 ) Change subject: Fix common misspellings and typos .. Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/14821/1/debian/changelog File debian/changelog: https://gerrit.osmocom.org/#/c/14821/1/debian/changelog@136 PS1, Line 136: * rtp-amr: Describe requirement to receive all PH-DATA.ind events Same, not sure we want to fix stuff in changelog comming frm commit logs. https://gerrit.osmocom.org/#/c/14821/1/src/osmo-bts-sysmo/misc/sysmobts_mgr_calib.c File src/osmo-bts-sysmo/misc/sysmobts_mgr_calib.c: https://gerrit.osmocom.org/#/c/14821/1/src/osmo-bts-sysmo/misc/sysmobts_mgr_calib.c@57 PS1, Line 57: CALIB_SUCCESS, Probably this change and related modifications deserve a separate patch (not a simple comment typo). -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14821 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I00ebf013104b55decbdd7f758756a19b220dc7b3 Gerrit-Change-Number: 14821 Gerrit-PatchSet: 1 Gerrit-Owner: roox Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 17 Jul 2019 22:20:24 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in ...osmo-trx[master]: Fix common misspellings and typos
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14819 ) Change subject: Fix common misspellings and typos .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14819/1/debian/changelog File debian/changelog: https://gerrit.osmocom.org/#/c/14819/1/debian/changelog@229 PS1, Line 229: * Move arch specific files to arch subdir I wouldn't change stuff from changelog, since that stuff comes from commit messages. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14819 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I8e0fe9d67d1e1e8dfce319610de63cde170694c5 Gerrit-Change-Number: 14819 Gerrit-PatchSet: 1 Gerrit-Owner: roox Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 17 Jul 2019 22:14:15 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in ...osmocom-bb[master]: Fix common misspellings and typos
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14818 ) Change subject: Fix common misspellings and typos .. Patch Set 1: (1 comment) I'd remove the variable name from this change, looks not the same kind of fix. https://gerrit.osmocom.org/#/c/14818/1/src/target/firmware/apps/simtest/main.c File src/target/firmware/apps/simtest/main.c: https://gerrit.osmocom.org/#/c/14818/1/src/target/firmware/apps/simtest/main.c@217 PS1, Line 217: int receivedChars; this one looks suspicious. Variable name changed but no issue? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14818 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I75df25d3bc2ecb4985bf6fefdde6e44b21bffed9 Gerrit-Change-Number: 14818 Gerrit-PatchSet: 1 Gerrit-Owner: roox Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 17 Jul 2019 22:12:17 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in ...osmo-bts[master]: common/rsl.c: fix: properly handle SI3 Rest Octets
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14817 ) Change subject: common/rsl.c: fix: properly handle SI3 Rest Octets .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14817 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia962cf21903ba674057cf52746996dd3254bc1c6 Gerrit-Change-Number: 14817 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: tnt Gerrit-Comment-Date: Wed, 17 Jul 2019 22:03:22 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-iuh[master]: osmo-hnbgw.cfg: set local-ip to 0.0.0.0
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/14782 ) Change subject: osmo-hnbgw.cfg: set local-ip to 0.0.0.0 .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/14782 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I354140f014854f1755b649e40a65e5d88b99c0ec Gerrit-Change-Number: 14782 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Jul 2019 21:44:51 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...docker-playground[master]: debian-repo-install-test: kill already running
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14780 ) Change subject: debian-repo-install-test: kill already running .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14780 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ide795092b656c9f0eb92a075d8f662944089019f Gerrit-Change-Number: 14780 Gerrit-PatchSet: 4 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Jul 2019 21:43:41 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...libosmocore[master]: bitvec/bitval2mask(): cosmetic: get rid of temporary int variable
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmocore/+/14825
Change subject: bitvec/bitval2mask(): cosmetic: get rid of temporary int
variable
..
bitvec/bitval2mask(): cosmetic: get rid of temporary int variable
Change-Id: I9d6f6b66c99c43107d1ad3e80af332e967bb19e8
---
M src/bitvec.c
1 file changed, 4 insertions(+), 11 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/25/14825/1
diff --git a/src/bitvec.c b/src/bitvec.c
index dac0401..0c263ad 100644
--- a/src/bitvec.c
+++ b/src/bitvec.c
@@ -58,25 +58,18 @@
/* convert ZERO/ONE/L/H to a bitmask at given pos in a byte */
static uint8_t bitval2mask(enum bit_value bit, uint8_t bitnum)
{
- int bitval;
-
switch (bit) {
case ZERO:
- bitval = (0 << bitnum);
- break;
+ return (0 << bitnum);
case ONE:
- bitval = (1 << bitnum);
- break;
+ return (1 << bitnum);
case L:
- bitval = ((0x2b ^ (0 << bitnum)) & (1 << bitnum));
- break;
+ return ((0x2b ^ (0 << bitnum)) & (1 << bitnum));
case H:
- bitval = ((0x2b ^ (1 << bitnum)) & (1 << bitnum));
- break;
+ return ((0x2b ^ (1 << bitnum)) & (1 << bitnum));
default:
return 0;
}
- return bitval;
}
/*! check if the bit is 0 or 1 for a given position inside a bitvec
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14825
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I9d6f6b66c99c43107d1ad3e80af332e967bb19e8
Gerrit-Change-Number: 14825
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
Change in ...libosmocore[master]: osmo_gsm48_rest_octets_si3_decode(): fix copy-paste error in comment
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmocore/+/14824
Change subject: osmo_gsm48_rest_octets_si3_decode(): fix copy-paste error in
comment
..
osmo_gsm48_rest_octets_si3_decode(): fix copy-paste error in comment
Change-Id: I57a330e16cc2910597672e1b27cf971499cea5bc
---
M src/gsm/gsm48_rest_octets.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/24/14824/1
diff --git a/src/gsm/gsm48_rest_octets.c b/src/gsm/gsm48_rest_octets.c
index 84136c6..518572e 100644
--- a/src/gsm/gsm48_rest_octets.c
+++ b/src/gsm/gsm48_rest_octets.c
@@ -966,7 +966,7 @@
memset(si3, 0, sizeof(*si3));
- /* Optional Selection Paraosmo_gsm48_si_ro_infometers */
+ /* Optional Selection Parameters */
if (bitvec_get_bit_high() == H) {
sp->present = 1;
sp->cbq = bitvec_get_uint(, 1);
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14824
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I57a330e16cc2910597672e1b27cf971499cea5bc
Gerrit-Change-Number: 14824
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
Change in ...osmo-tetra[master]: Fix typos
roox has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-tetra/+/14823
Change subject: Fix typos
..
Fix typos
Change-Id: I1aae0a52fcf978900fa847a3f813beb2a5ad4a84
---
M etsi_codec-patches/README
M src/demod/cqpsk.py
2 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-tetra refs/changes/23/14823/1
diff --git a/etsi_codec-patches/README b/etsi_codec-patches/README
index 1c95c83..9b59b74 100644
--- a/etsi_codec-patches/README
+++ b/etsi_codec-patches/README
@@ -33,5 +33,5 @@
Due to the use of uppercase file names in the zip file, you should use the "-L"
flag to the unzip program, which ensures all files are completely lower-case.
-Please apply all of the patches foudn in this directory to the
+Please apply all of the patches found in this directory to the
resulting source code.
diff --git a/src/demod/cqpsk.py b/src/demod/cqpsk.py
index 6be6ee7..c5a8f3d 100644
--- a/src/demod/cqpsk.py
+++ b/src/demod/cqpsk.py
@@ -151,7 +151,7 @@
Adds QPSK modulation-specific options to the standard parser
"""
parser.add_option("", "--excess-bw", type="float",
default=_def_excess_bw,
- help="set RRC excess bandwith factor
[default=%default] (PSK)")
+ help="set RRC excess bandwidth factor
[default=%default] (PSK)")
parser.add_option("", "--no-gray-code", dest="gray_code",
action="store_false", default=_def_gray_code,
help="disable gray coding on modulated bits (PSK)")
@@ -325,7 +325,7 @@
Adds modulation-specific options to the standard parser
"""
parser.add_option("", "--excess-bw", type="float",
default=_def_excess_bw,
- help="set RRC excess bandwith factor
[default=%default] (PSK)")
+ help="set RRC excess bandwidth factor
[default=%default] (PSK)")
parser.add_option("", "--no-gray-code", dest="gray_code",
action="store_false", default=_def_gray_code,
help="disable gray coding on modulated bits (PSK)")
--
To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/14823
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-tetra
Gerrit-Branch: master
Gerrit-Change-Id: I1aae0a52fcf978900fa847a3f813beb2a5ad4a84
Gerrit-Change-Number: 14823
Gerrit-PatchSet: 1
Gerrit-Owner: roox
Gerrit-MessageType: newchange
Change in ...gapk[master]: Fix typos
roox has uploaded this change for review. (
https://gerrit.osmocom.org/c/gapk/+/14822
Change subject: Fix typos
..
Fix typos
Change-Id: Ie8054f3d484fe5d82cc5d91f159906a470fc4511
---
M src/pq_alsa.c
M src/pq_file.c
M src/pq_rtp.c
3 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/gapk refs/changes/22/14822/1
diff --git a/src/pq_alsa.c b/src/pq_alsa.c
index 3550221..50479e6 100644
--- a/src/pq_alsa.c
+++ b/src/pq_alsa.c
@@ -176,7 +176,7 @@
* \param pq Processing Queue to add the ALSA input to
* \param[in] hwdev ALSA hardware device to use
* \param[in] blk_len block length to be read from device
- * \returns 0 on sucess; negative on error */
+ * \returns 0 on success; negative on error */
int
osmo_gapk_pq_queue_alsa_input(struct osmo_gapk_pq *pq, const char *hwdev,
unsigned int blk_len)
{
@@ -190,7 +190,7 @@
* \param pq Processing Queue to add the ALSA output to
* \param[in] hwdev ALSA hardware device to use
* \param[in] blk_len block length to be written to device
- * \returns 0 on sucess; negative on error */
+ * \returns 0 on success; negative on error */
int
osmo_gapk_pq_queue_alsa_output(struct osmo_gapk_pq *pq, const char *hwdev,
unsigned int blk_len)
{
diff --git a/src/pq_file.c b/src/pq_file.c
index 22dc9cd..d496eec 100644
--- a/src/pq_file.c
+++ b/src/pq_file.c
@@ -103,7 +103,7 @@
* \param pq Processing Queue to add the input file to
* \param[in] src caller-fopen()ed input file
* \param[in] blk_len block length to be read from file
- * \returns 0 on sucess; negative on error */
+ * \returns 0 on success; negative on error */
int
osmo_gapk_pq_queue_file_input(struct osmo_gapk_pq *pq, FILE *src, unsigned int
blk_len)
{
@@ -117,7 +117,7 @@
* \param pq Processing Queue to add the output file to
* \param[in] dst caller-fopen()ed output file
* \param[in] blk_len block length to be written to file
- * \returns 0 on sucess; negative on error */
+ * \returns 0 on success; negative on error */
int
osmo_gapk_pq_queue_file_output(struct osmo_gapk_pq *pq, FILE *dst, unsigned
int blk_len)
{
diff --git a/src/pq_rtp.c b/src/pq_rtp.c
index 81eeb19..3a09ba7 100644
--- a/src/pq_rtp.c
+++ b/src/pq_rtp.c
@@ -116,7 +116,7 @@
payload = buf + sizeof(struct rtp_hdr) + (rtph->csrc_count << 2);
payload_len = rv - sizeof(struct rtp_hdr) - (rtph->csrc_count << 2);
if (payload_len < 0) {
- rtp_err("non-existant RTP payload length %d\n", payload_len);
+ rtp_err("non-existent RTP payload length %d\n", payload_len);
return -1;
}
--
To view, visit https://gerrit.osmocom.org/c/gapk/+/14822
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: gapk
Gerrit-Branch: master
Gerrit-Change-Id: Ie8054f3d484fe5d82cc5d91f159906a470fc4511
Gerrit-Change-Number: 14822
Gerrit-PatchSet: 1
Gerrit-Owner: roox
Gerrit-MessageType: newchange
Change in ...osmo-bts[master]: Fix common misspellings and typos
roox has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/14821 Change subject: Fix common misspellings and typos .. Fix common misspellings and typos Change-Id: I00ebf013104b55decbdd7f758756a19b220dc7b3 --- M README.md M debian/changelog M doc/manuals/rtp-amr.adoc M doc/manuals/vty/bts_vty_reference.xml M src/common/l1sap.c M src/osmo-bts-litecell15/misc/lc15bts_mgr_calib.c M src/osmo-bts-litecell15/misc/lc15bts_mgr_vty.c M src/osmo-bts-oc2g/misc/oc2gbts_mgr_calib.c M src/osmo-bts-oc2g/misc/oc2gbts_mgr_vty.c M src/osmo-bts-octphy/l1_oml.c M src/osmo-bts-sysmo/misc/sysmobts-layer1.c M src/osmo-bts-sysmo/misc/sysmobts_mgr_calib.c M src/osmo-bts-sysmo/misc/sysmobts_mgr_vty.c M tests/meas/meas_test.c 14 files changed, 118 insertions(+), 118 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/21/14821/1 diff --git a/README.md b/README.md index 7e26d82..1fca596 100644 --- a/README.md +++ b/README.md @@ -45,7 +45,7 @@ as well as a [VTY Reference Manual](http://ftp.osmocom.org/docs/latest/osmobsc-vty-reference.pdf) and a -[Abis refrence MAnual](http://ftp.osmocom.org/docs/latest/osmobts-abis.pdf) +[Abis reference MAnual](http://ftp.osmocom.org/docs/latest/osmobts-abis.pdf) describing the OsmoBTS specific A-bis dialect. Mailing List diff --git a/debian/changelog b/debian/changelog index a33d21f..0dce96c 100644 --- a/debian/changelog +++ b/debian/changelog @@ -133,7 +133,7 @@ * bts_model: Allow TS connect to be processed asynchronously * OsmoBTS/chapters/configuration.adoc: Add bts index in example * OsmoBTS: Update osmotrx ip to diff between local and remote - * rtp-amr: Describe requirement to recieve all PH-DATA.ind events + * rtp-amr: Describe requirement to receive all PH-DATA.ind events * rtp-amr: Fix typo and trailing whitespace * Allow easily disabling GFDL references * OsmoBTS: bts-models: Add Lime Microsystems devices as supported osmo-trx @@ -341,7 +341,7 @@ * RSL: Implement DELETE INDICATION on AGCH overflow * RSL: Send ERROR REPORT on too short/truncated messages + wrong discriminator * BTS: add rate_ctr about CCCH (paging, agch, pch) - * paging: Drop + Log paging requests for non-existant paging groups + * paging: Drop + Log paging requests for non-existent paging groups * paging.c: Fix encoding of optional Mobile ID RR PAGING TYPE 1 / 2 * rsl: Improve ERROR REPORTing * paging: Fix encoding of PAGING TYPE 3 Rest Octets @@ -601,7 +601,7 @@ * Add Abis OML failure event reporting * Alarm on various errors * Remove obsolete define TLVP_PRES_LEN - * scheduler: log lchan on which prim error occured + * scheduler: log lchan on which prim error occurred * deb: use gsm_data_shared.* from openbsc-dev * OML: internalize failure reporting * Add ctrl command to send OML alert diff --git a/doc/manuals/rtp-amr.adoc b/doc/manuals/rtp-amr.adoc index 5a36aea..0c733d1 100644 --- a/doc/manuals/rtp-amr.adoc +++ b/doc/manuals/rtp-amr.adoc @@ -95,10 +95,10 @@ phy => bts [label="PH-DATA.ind GsmL1_TchPlType_Amr (SID_FIRST)"]; bts => mgw [label="RTP (AMR FT=SID,Q=1)"]; - ms -x phy [label="Supressed L1 burst"]; - ms -x phy [label="Supressed L1 burst"]; - ms -x phy [label="Supressed L1 burst"]; - ms -x phy [label="Supressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; phy => bts [label="PH-DATA.ind with empty payload"]; bts -x mgw [label="Suppressed RTP frame"]; @@ -110,10 +110,10 @@ bts -x mgw [label="Suppressed RTP frame"]; - ms -x phy [label="Supressed L1 burst"]; - ms -x phy [label="Supressed L1 burst"]; - ms -x phy [label="Supressed L1 burst"]; - ms -x phy [label="Supressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; phy => bts [label="PH-DATA.ind GsmL1_TchPlType_Amr (SID_UPDATE)"]; bts => mgw [label="RTP (AMR FT=SID,Q=1)"]; } @@ -123,7 +123,7 @@ the SID_FIRST frame is immediately followed by a speech frame. It has been observed that some phone does not transmit the last 4 bursts even if it is not followed by a speech frame. -ULSU2:: There must be exactly two supressed voice frames between the +ULSU2:: There must be exactly two suppressed voice frames between the SID_FIRST and the SID_UPDATE, i.e. there's 60ms between SID_FIRST and SID_UPDATE. @@ -152,52 +152,52 @@ phy => bts [label="PH-DATA.ind with empty payload"]; bts -x mgw
Change in ...osmo-remsim[master]: Fix common misspellings and typos
roox has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-remsim/+/14820
Change subject: Fix common misspellings and typos
..
Fix common misspellings and typos
Change-Id: I8152acaccd33a4b646d56cba0748aeefa0c16b35
---
M doc/manuals/chapters/remsim-bankd.adoc
M include/osmocom/rspro/INTEGER.h
M include/osmocom/rspro/constr_TYPE.h
M include/osmocom/rspro/per_support.h
M src/rspro/NativeInteger.c
M src/rspro/OCTET_STRING.c
M src/rspro/ber_tlv_tag.c
M src/rspro/constr_CHOICE.c
M src/rspro/constr_SEQUENCE.c
M src/rspro/converter-sample.c
M src/rspro/per_opentype.c
M src/simtrace2/apdu_dispatch.c
12 files changed, 14 insertions(+), 14 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/20/14820/1
diff --git a/doc/manuals/chapters/remsim-bankd.adoc
b/doc/manuals/chapters/remsim-bankd.adoc
index d35056b..a3a1921 100644
--- a/doc/manuals/chapters/remsim-bankd.adoc
+++ b/doc/manuals/chapters/remsim-bankd.adoc
@@ -127,4 +127,4 @@
In this example, there's only a single PC/SC reader available, and it has a
string of
-"Alcor Micro AU9560 00 00" whcih needs to be copy-pasted into the CSV file.
+"Alcor Micro AU9560 00 00" which needs to be copy-pasted into the CSV file.
diff --git a/include/osmocom/rspro/INTEGER.h b/include/osmocom/rspro/INTEGER.h
index e8b36c7..c8edf12 100644
--- a/include/osmocom/rspro/INTEGER.h
+++ b/include/osmocom/rspro/INTEGER.h
@@ -68,8 +68,8 @@
ASN_STRTOL_ERROR_RANGE = -3, /* Input outside of numeric range for long
type */
ASN_STRTOL_ERROR_INVAL = -2, /* Invalid data encountered (e.g., "+-") */
ASN_STRTOL_EXPECT_MORE = -1, /* More data expected (e.g. "+") */
-ASN_STRTOL_OK = 0, /* Conversion succeded, number ends at
(*end) */
-ASN_STRTOL_EXTRA_DATA = 1, /* Conversion succeded, but the string has
extra stuff */
+ASN_STRTOL_OK = 0, /* Conversion succeeded, number ends at
(*end) */
+ASN_STRTOL_EXTRA_DATA = 1, /* Conversion succeeded, but the string has
extra stuff */
};
enum asn_strtol_result_e asn_strtol_lim(const char *str, const char **end,
long *l);
diff --git a/include/osmocom/rspro/constr_TYPE.h
b/include/osmocom/rspro/constr_TYPE.h
index 13c60f3..e244d20 100644
--- a/include/osmocom/rspro/constr_TYPE.h
+++ b/include/osmocom/rspro/constr_TYPE.h
@@ -158,8 +158,8 @@
typedef struct asn_TYPE_tag2member_s {
ber_tlv_tag_t el_tag; /* Outmost tag of the member */
int el_no; /* Index of the associated member, base 0 */
- int toff_first; /* First occurence of the el_tag, relative */
- int toff_last; /* Last occurence of the el_tag, relatvie */
+ int toff_first; /* First occurrence of the el_tag, relative */
+ int toff_last; /* Last occurrence of the el_tag, relatvie */
} asn_TYPE_tag2member_t;
/*
diff --git a/include/osmocom/rspro/per_support.h
b/include/osmocom/rspro/per_support.h
index 181fe24..ed945ce 100644
--- a/include/osmocom/rspro/per_support.h
+++ b/include/osmocom/rspro/per_support.h
@@ -53,7 +53,7 @@
*/
int32_t per_get_few_bits(asn_per_data_t *per_data, int get_nbits);
-/* Undo the immediately preceeding "get_few_bits" operation */
+/* Undo the immediately preceding "get_few_bits" operation */
void per_get_undo(asn_per_data_t *per_data, int get_nbits);
/*
diff --git a/src/rspro/NativeInteger.c b/src/rspro/NativeInteger.c
index ef17bee..17a58ea 100644
--- a/src/rspro/NativeInteger.c
+++ b/src/rspro/NativeInteger.c
@@ -94,7 +94,7 @@
/*
* ASN.1 encoded INTEGER: buf_ptr, length
* Fill the native, at the same time checking for overflow.
-* If overflow occured, return with RC_FAIL.
+* If overflow occurred, return with RC_FAIL.
*/
{
INTEGER_t tmp;
diff --git a/src/rspro/OCTET_STRING.c b/src/rspro/OCTET_STRING.c
index 3e424e7..6df9a0a 100644
--- a/src/rspro/OCTET_STRING.c
+++ b/src/rspro/OCTET_STRING.c
@@ -109,7 +109,7 @@
/*
* The main reason why ASN.1 is still alive is that too much time and effort
* is necessary for learning it more or less adequately, thus creating a gut
- * necessity to demonstrate that aquired skill everywhere afterwards.
+ * necessity to demonstrate that acquired skill everywhere afterwards.
* No, I am not going to explain what the following stuff is.
*/
struct _stack_el {
diff --git a/src/rspro/ber_tlv_tag.c b/src/rspro/ber_tlv_tag.c
index 4270876..adf3a25 100644
--- a/src/rspro/ber_tlv_tag.c
+++ b/src/rspro/ber_tlv_tag.c
@@ -42,7 +42,7 @@
*/
if(val >> ((8 * sizeof(val)) - 9)) {
/*
-* We would not be able to accomodate
+* We would not be able to accommodate
* any more tag bits.
*/
Change in ...osmo-trx[master]: Fix common misspellings and typos
roox has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-trx/+/14819
Change subject: Fix common misspellings and typos
..
Fix common misspellings and typos
Change-Id: I8e0fe9d67d1e1e8dfce319610de63cde170694c5
---
M CommonLibs/Interthread.h
M CommonLibs/Threads.h
M CommonLibs/trx_vty.c
M README
M Transceiver52M/Resampler.h
M Transceiver52M/Transceiver.h
M Transceiver52M/arch/x86/convert.c
M Transceiver52M/arch/x86/convolve.c
M Transceiver52M/device/common/smpl_buf.h
M Transceiver52M/inband-signaling-usb
M autogen.sh
M debian/changelog
M doc/manuals/vty/trx_vty_reference.xml
13 files changed, 17 insertions(+), 17 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/19/14819/1
diff --git a/CommonLibs/Interthread.h b/CommonLibs/Interthread.h
index 42e6f7f..abb11c6 100644
--- a/CommonLibs/Interthread.h
+++ b/CommonLibs/Interthread.h
@@ -45,7 +45,7 @@
// (pat) The elements in the queue are type T*, and
// the Fifo class implements the underlying queue.
// The default is class PointerFIFO, which does not place any restrictions on
the type of T,
-// and is implemented by allocating auxilliary structures for the queue,
+// and is implemented by allocating auxiliary structures for the queue,
// or SingleLinkedList, which implements the queue using an internal pointer
in type T,
// which must implement the functional interface of class SingleLinkListNode,
// namely: functions T*next() and void setNext(T*).
diff --git a/CommonLibs/Threads.h b/CommonLibs/Threads.h
index 8a6ba47..a914d51 100644
--- a/CommonLibs/Threads.h
+++ b/CommonLibs/Threads.h
@@ -182,7 +182,7 @@
}
}
- /** Send cancelation to thread */
+ /** Send cancellation to thread */
void cancel() { pthread_cancel(mThread); }
};
diff --git a/CommonLibs/trx_vty.c b/CommonLibs/trx_vty.c
index e184f49..3f1047e 100644
--- a/CommonLibs/trx_vty.c
+++ b/CommonLibs/trx_vty.c
@@ -222,7 +222,7 @@
DEFUN(cfg_clock_ref, cfg_clock_ref_cmd,
"clock-ref (internal|external|gpsdo)",
"Set the Reference Clock\n"
- "Enable internal referece (default)\n"
+ "Enable internal reference (default)\n"
"Enable external 10 MHz reference\n"
"Enable GPSDO reference\n")
{
diff --git a/README b/README
index 502d661..0d8cdcd 100644
--- a/README
+++ b/README
@@ -22,7 +22,7 @@
Commands on the Per-ARFCN Control Interface
-The per-ARFCN control interface uses a command-reponse protocol.
+The per-ARFCN control interface uses a command-response protocol.
Commands are NULL-terminated ASCII strings, one per UDP socket.
Each command has a corresponding response.
Every command is of the form:
diff --git a/Transceiver52M/Resampler.h b/Transceiver52M/Resampler.h
index caffc08..14870fe 100644
--- a/Transceiver52M/Resampler.h
+++ b/Transceiver52M/Resampler.h
@@ -38,7 +38,7 @@
* @return false on error, zero otherwise
*
* Automatic setting is to compute the filter to prevent aliasing with
-* a Blackman-Harris window. Adjustment is made through a bandwith
+* a Blackman-Harris window. Adjustment is made through a bandwidth
* factor to shift the cutoff and/or the constituent filter lengths.
* Calculation of specific rolloff factors or 3-dB cutoff points is
* left as an excersize for the reader.
diff --git a/Transceiver52M/Transceiver.h b/Transceiver52M/Transceiver.h
index a66c962..1d192d8 100644
--- a/Transceiver52M/Transceiver.h
+++ b/Transceiver52M/Transceiver.h
@@ -236,7 +236,7 @@
bool start();
void stop();
- /** Protect destructor accessable stop call */
+ /** Protect destructor accessible stop call */
Mutex mLock;
protected:
diff --git a/Transceiver52M/arch/x86/convert.c
b/Transceiver52M/arch/x86/convert.c
index 07cdf59..bbcfd67 100644
--- a/Transceiver52M/arch/x86/convert.c
+++ b/Transceiver52M/arch/x86/convert.c
@@ -27,7 +27,7 @@
#include "config.h"
#endif
-/* Architecture dependant function pointers */
+/* Architecture dependent function pointers */
struct convert_cpu_context {
void (*convert_si16_ps_16n) (float *, const short *, int);
void (*convert_si16_ps) (float *, const short *, int);
diff --git a/Transceiver52M/arch/x86/convolve.c
b/Transceiver52M/arch/x86/convolve.c
index 209d377..f25e2a7 100644
--- a/Transceiver52M/arch/x86/convolve.c
+++ b/Transceiver52M/arch/x86/convolve.c
@@ -27,7 +27,7 @@
#include "config.h"
#endif
-/* Architecture dependant function pointers */
+/* Architecture dependent function pointers */
struct convolve_cpu_context {
void (*conv_cmplx_4n) (const float *, int, const float *, int, float *,
int, int, int);
diff --git a/Transceiver52M/device/common/smpl_buf.h
b/Transceiver52M/device/common/smpl_buf.h
index 24d3ce9..36e06b5 100644
--- a/Transceiver52M/device/common/smpl_buf.h
+++
Change in ...osmocom-bb[master]: Fix common misspellings and typos
roox has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmocom-bb/+/14818
Change subject: Fix common misspellings and typos
..
Fix common misspellings and typos
Change-Id: I75df25d3bc2ecb4985bf6fefdde6e44b21bffed9
---
M src/host/layer23/README
M src/host/layer23/include/osmocom/bb/misc/layer3.h
M src/host/layer23/src/common/sap_proto.c
M src/host/layer23/src/common/sim.c
M src/host/layer23/src/misc/app_bcch_scan.c
M src/host/layer23/src/misc/app_cbch_sniff.c
M src/host/layer23/src/misc/cell_log.c
M src/host/layer23/src/mobile/gsm322.c
M src/host/layer23/src/mobile/gsm48_mm.c
M src/host/layer23/src/mobile/gsm48_rr.c
M src/host/layer23/src/mobile/main.c
M src/host/layer23/src/mobile/mnccms.c
M src/host/virt_phy/src/gsmtapl1_if.c
M src/shared/libosmocore/Doxyfile.codec.in
M src/shared/libosmocore/Doxyfile.core.in
M src/shared/libosmocore/Doxyfile.gsm.in
M src/shared/libosmocore/Doxyfile.vty.in
M src/shared/libosmocore/doc/vty/example.xml
M src/shared/libosmocore/include/osmocom/vty/command.h
M src/shared/libosmocore/include/osmocom/vty/vector.h
M src/shared/libosmocore/src/gb/gprs_ns.c
M src/shared/libosmocore/src/gsm/auth_core.c
M src/shared/libosmocore/src/gsm/gsm0411_smr.c
M src/shared/libosmocore/src/gsm/gsm48.c
M src/shared/libosmocore/src/gsm/lapd_core.c
M src/shared/libosmocore/src/gsm/lapdm.c
M src/shared/libosmocore/src/logging.c
M src/shared/libosmocore/src/talloc.c
M src/shared/libosmocore/src/utils.c
M src/shared/libosmocore/src/vty/command.c
M src/target/firmware/apps/rssi/main.c
M src/target/firmware/apps/simtest/main.c
M src/target/firmware/calypso/sim.c
M src/target/firmware/comm/sercomm.c
M src/target/firmware/fb/fb_s6b33b1x.c
M src/target/firmware/include/fb/fb_bw8.h
M src/target/firmware/layer1/prim_fbsb.c
M src/target/firmware/layer1/prim_tch.c
M src/target/firmware/layer1/sync.c
M src/target/firmware/rf/trf6151.c
M src/target/trx_toolkit/data_dump.py
41 files changed, 62 insertions(+), 62 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/18/14818/1
diff --git a/src/host/layer23/README b/src/host/layer23/README
index dd59823..c52e7bc 100644
--- a/src/host/layer23/README
+++ b/src/host/layer23/README
@@ -30,7 +30,7 @@
RSL header (struct abis_rsl_common_hdr).
There are utility functions like rslms_tx_rll_req() and rslms_tx_rsll_req_l3()
-for creating msgb's with the apropriate RSL/RLL headers.
+for creating msgb's with the appropriate RSL/RLL headers.
=== LAPDm ===
diff --git a/src/host/layer23/include/osmocom/bb/misc/layer3.h
b/src/host/layer23/include/osmocom/bb/misc/layer3.h
index bbf242d..ffafe76 100644
--- a/src/host/layer23/include/osmocom/bb/misc/layer3.h
+++ b/src/host/layer23/include/osmocom/bb/misc/layer3.h
@@ -11,7 +11,7 @@
/* Initialize layer3 for the MS, hook it to L2 */
int layer3_init(struct osmocom_ms *ms);
-/* Reset the 'aplication' state */
+/* Reset the 'application' state */
void layer3_app_reset(void);
#endif
diff --git a/src/host/layer23/src/common/sap_proto.c
b/src/host/layer23/src/common/sap_proto.c
index c3d202f..ecacfe0 100644
--- a/src/host/layer23/src/common/sap_proto.c
+++ b/src/host/layer23/src/common/sap_proto.c
@@ -177,7 +177,7 @@
* \param[in] sap_msg pointer to SAP message header
* \param[in] param_type parameter type (see sap_param_type enum)
* \param[out] param_len parameter length (if found)
- * \returns pointer to a given parameter withing the message, NULL otherwise
+ * \returns pointer to a given parameter within the message, NULL otherwise
*/
struct sap_param *sap_get_param(const struct sap_message *sap_msg,
enum sap_param_type param_type, uint16_t *param_len)
diff --git a/src/host/layer23/src/common/sim.c
b/src/host/layer23/src/common/sim.c
index ed7f54a..1e2bc51 100644
--- a/src/host/layer23/src/common/sim.c
+++ b/src/host/layer23/src/common/sim.c
@@ -1132,7 +1132,7 @@
case SIM_JOB_INCREASE:
if (length != 4) {
LOGP(DSIM, LOGL_ERROR, "expecting uint32_t as "
- "value lenght, but got %d bytes\n",
+ "value length, but got %d bytes\n",
length);
goto request_error;
}
diff --git a/src/host/layer23/src/misc/app_bcch_scan.c
b/src/host/layer23/src/misc/app_bcch_scan.c
index 22e6f1b..5818530 100644
--- a/src/host/layer23/src/misc/app_bcch_scan.c
+++ b/src/host/layer23/src/misc/app_bcch_scan.c
@@ -53,7 +53,7 @@
int l23_app_init(struct osmocom_ms *ms)
{
- /* don't do layer3_init() as we don't want an actualy L3 */
+ /* don't do layer3_init() as we don't want an actually L3 */
fps_init();
l1ctl_tx_reset_req(ms, L1CTL_RES_T_FULL);
return osmo_signal_register_handler(SS_L1CTL, _cb, NULL);
diff --git
Build failure of network:osmocom:nightly/osmo-sgsn in Raspbian_9.0/armv7l
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-sgsn failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-sgsn Last lines of build log: [ 501s] bss_ptmsi = bss_ptmsi | GSM23003_TMSI_SGSN_MASK; [ 501s] ^~~ [ 501s] gb_proxy.c:246:28: note: each undeclared identifier is reported only once for each function it appears in [ 501s] Makefile:615: recipe for target 'gb_proxy.o' failed [ 501s] make[4]: *** [gb_proxy.o] Error 1 [ 501s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/gprs' [ 501s] Makefile:391: recipe for target 'all-recursive' failed [ 501s] make[3]: *** [all-recursive] Error 1 [ 501s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 501s] Makefile:453: recipe for target 'all-recursive' failed [ 501s] make[2]: *** [all-recursive] Error 1 [ 501s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 501s] Makefile:385: recipe for target 'all' failed [ 501s] make[1]: *** [all] Error 2 [ 501s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 501s] dh_auto_build: make -j1 returned exit code 2 [ 501s] debian/rules:45: recipe for target 'build' failed [ 501s] make: *** [build] Error 2 [ 501s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 501s] [ 501s] armbuild25 failed "build osmo-sgsn_1.4.0.28.43f16.dsc" at Wed Jul 17 18:07:27 UTC 2019. [ 501s] [ 501s] ### VM INTERACTION START ### [ 504s] [ 458.751946] sysrq: SysRq : Power Off [ 504s] [ 458.778271] reboot: Power down [ 504s] ### VM INTERACTION END ### [ 504s] [ 504s] armbuild25 failed "build osmo-sgsn_1.4.0.28.43f16.dsc" at Wed Jul 17 18:07:30 UTC 2019. [ 504s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-msc in Raspbian_9.0/armv7l
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-msc failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-msc Last lines of build log: [ 669s] tmsi |= GSM23003_TMSI_SGSN_MASK; [ 669s] ^~~ [ 669s] vlr.c:339:12: note: each undeclared identifier is reported only once for each function it appears in [ 669s] Makefile:442: recipe for target 'vlr.o' failed [ 669s] make[4]: *** [vlr.o] Error 1 [ 669s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libvlr' [ 669s] Makefile:422: recipe for target 'all-recursive' failed [ 669s] make[3]: *** [all-recursive] Error 1 [ 669s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 669s] Makefile:462: recipe for target 'all-recursive' failed [ 669s] make[2]: *** [all-recursive] Error 1 [ 669s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 669s] Makefile:394: recipe for target 'all' failed [ 669s] make[1]: *** [all] Error 2 [ 669s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 669s] dh_auto_build: make -j1 returned exit code 2 [ 669s] debian/rules:45: recipe for target 'build' failed [ 669s] make: *** [build] Error 2 [ 669s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 669s] [ 669s] armbuild16 failed "build osmo-msc_1.3.1.178.aa0a.dsc" at Wed Jul 17 17:43:15 UTC 2019. [ 669s] [ 669s] ### VM INTERACTION START ### [ 672s] [ 617.737477] sysrq: SysRq : Power Off [ 672s] [ 617.739848] reboot: Power down [ 672s] ### VM INTERACTION END ### [ 672s] [ 672s] armbuild16 failed "build osmo-msc_1.3.1.178.aa0a.dsc" at Wed Jul 17 17:43:19 UTC 2019. [ 672s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-python-tests in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-python-tests/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-python-tests failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-python-tests Last lines of build log: [ 209s] rm -rf /usr/src/packages/BUILD/debian/python3-osmopy-utils/usr/lib [ 209s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 209s]dh_installdocs [ 209s]dh_installchangelogs [ 209s]dh_python2 [ 209s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmotestvty.py [ 209s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmotestconfig.py [ 209s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmodumpdoc.py [ 209s]dh_python3 [ 209s]debian/rules override_dh_installinit [ 209s] make[1]: Entering directory '/usr/src/packages/BUILD' [ 209s] # Install service file with different name than package name: [ 209s] # https://unix.stackexchange.com/questions/306234/is-it-possible-to-install-two-services-for-one-package-using-dh-installinit-how [ 209s] dh_installinit --name=osmo-ctrl2cgi [ 209s] dh_installinit: --name=osmo-ctrl2cgi option specified, but init script nor default file not found [ 209s] make[1]: *** [debian/rules:19: override_dh_installinit] Error 255 [ 209s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 209s] make: *** [debian/rules:4: binary] Error 2 [ 209s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 209s] [ 209s] lamb56 failed "build osmo-python-tests_0.0.9.20190717.dsc" at Wed Jul 17 14:54:33 UTC 2019. [ 209s] [ 209s] ### VM INTERACTION START ### [ 213s] [ 194.914009] sysrq: SysRq : Power Off [ 213s] [ 194.919603] reboot: Power down [ 213s] ### VM INTERACTION END ### [ 213s] [ 213s] lamb56 failed "build osmo-python-tests_0.0.9.20190717.dsc" at Wed Jul 17 14:54:38 UTC 2019. [ 213s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Change in ...osmo-bts[master]: common/rsl.c: fix: properly handle SI3 Rest Octets
Hello laforge, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/14817 to look at the new patch set (#3). Change subject: common/rsl.c: fix: properly handle SI3 Rest Octets .. common/rsl.c: fix: properly handle SI3 Rest Octets It was noticed with old Sony Ericsson phones (like W595 and K510i) that the service provided by Osmocom network becomes unreliable from time to time. The RSSI indicator on those phones shows that the signal is lost, so neither CS nor PS services are working. As it then turned out, System Information 3 broadcasted on the Um interface is different than the one received from the BSC. In particular, the content of SI3 Rest Octets IE is different. Among with the 'GPRS Indicator', which is actually expected to indicate whether the PCU is connected or not, SI3 Rest Octets on the Um interface contain both 'Optional Power Offset' and 'Scheduling if and where' IEs, which are not present in the original messages from the BSC. Moreover, as soon as the PCU is connected, 'GPRS Indicator' IE contains different 'GPRS RA Colour' value, and informs the MS that System Information 13 is sent on extended BCCH, which is not even supported by OsmoBTS! The culprit is in rsl_rx_bcch_info(), where we pass a pointer to osmo_gsm48_rest_octets_si3_decode(). Instead of passing a pointer to the beginning of SI3 buffer, we actually need to shift it to the beginning of the SI3 Rest Octets IE. This change makes my Sony Ericsson phones happy ;) Change-Id: Ia962cf21903ba674057cf52746996dd3254bc1c6 --- M src/common/rsl.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/17/14817/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14817 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia962cf21903ba674057cf52746996dd3254bc1c6 Gerrit-Change-Number: 14817 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-CC: tnt Gerrit-MessageType: newpatchset
Change in ...osmo-iuh[master]: osmo-hnbgw.cfg: set local-ip to 0.0.0.0
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/14782 ) Change subject: osmo-hnbgw.cfg: set local-ip to 0.0.0.0 .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/14782 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I354140f014854f1755b649e40a65e5d88b99c0ec Gerrit-Change-Number: 14782 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 17 Jul 2019 12:21:02 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-bts[master]: common/rsl.c: fix: properly handle SI3 Rest Octets
Hello laforge, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/14817 to look at the new patch set (#2). Change subject: common/rsl.c: fix: properly handle SI3 Rest Octets .. common/rsl.c: fix: properly handle SI3 Rest Octets It was noticed with old Sony Ericsson phones (like W595 and K510i) that the service provided by Osmocom network becomes unreliable from time to time. The RSSI indicator on those phones shows that the signal is lost, so neither CS nor PS services are working. As it then turned out, System Information 3 broadcasted on the Um interface is different than the one received from the BSC. In particular, the content SI3 Rest Octets IE is different. Among with the 'GPRS Indicator', which is actually expected to indicate whether the PCU is connected or now, SI3 Rest Octets on the Um interface contain both 'Optional Power Offset' and 'Scheduling if and where' IEs, which are not present in the original messages from the BSC. Moreover, as soon as the PCU is connected, 'GPRS Indicator' IE contains different 'GPRS RA Colour' value, and informs the MS that System Information 13 is sent on extended BCCH, which is not even supported by OsmoBTS! The culprit is in rsl_rx_bcch_info(), where we pass a pointer to osmo_gsm48_rest_octets_si3_decode(). Instead of passing a pointer to the beginning of SI3 buffer, we actually need to shift it to the beginning of the SI3 Rest Octets IE. This change makes my Sony Ericsson phones happy ;) Change-Id: Ia962cf21903ba674057cf52746996dd3254bc1c6 --- M src/common/rsl.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/17/14817/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14817 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia962cf21903ba674057cf52746996dd3254bc1c6 Gerrit-Change-Number: 14817 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-CC: tnt Gerrit-MessageType: newpatchset
Change in ...osmo-iuh[master]: osmo-hnbgw.cfg: set local-ip to 0.0.0.0
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/14782 ) Change subject: osmo-hnbgw.cfg: set local-ip to 0.0.0.0 .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/14782/1/doc/examples/osmo-hnbgw.cfg File doc/examples/osmo-hnbgw.cfg: https://gerrit.osmocom.org/#/c/14782/1/doc/examples/osmo-hnbgw.cfg@24 PS1, Line 24: local-ip 127.0.0.1 > ACK. How about 0.0.0. […] Fine with me, changed to 0.0.0.0 (and checked that it works). -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/14782 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I354140f014854f1755b649e40a65e5d88b99c0ec Gerrit-Change-Number: 14782 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 17 Jul 2019 12:06:27 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Comment-In-Reply-To: pespin Gerrit-MessageType: comment
Change in ...osmo-iuh[master]: osmo-hnbgw.cfg: set local-ip to 0.0.0.0
Hello fixeria, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-iuh/+/14782 to look at the new patch set (#2). Change subject: osmo-hnbgw.cfg: set local-ip to 0.0.0.0 .. osmo-hnbgw.cfg: set local-ip to 0.0.0.0 Make the config work out of the box for anyone. Related: OS#3369 Change-Id: I354140f014854f1755b649e40a65e5d88b99c0ec --- M doc/examples/osmo-hnbgw.cfg 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/82/14782/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/14782 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I354140f014854f1755b649e40a65e5d88b99c0ec Gerrit-Change-Number: 14782 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-CC: pespin Gerrit-MessageType: newpatchset
Change in ...osmo-bts[master]: common/rsl.c: fix: properly handle SI3 Rest Octets
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14817 ) Change subject: common/rsl.c: fix: properly handle SI3 Rest Octets .. Patch Set 1: Code-Review+1 rsl.c:371:32: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] const uint8_t *si3_ro_buf = bts->si_buf[osmo_si]; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14817 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia962cf21903ba674057cf52746996dd3254bc1c6 Gerrit-Change-Number: 14817 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: tnt Gerrit-Comment-Date: Wed, 17 Jul 2019 12:01:29 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-bts[master]: common/rsl.c: fix: properly handle SI3 Rest Octets
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/14817 Change subject: common/rsl.c: fix: properly handle SI3 Rest Octets .. common/rsl.c: fix: properly handle SI3 Rest Octets It was noticed with old Sony Ericsson phones (like W595 and K510i) that the service provided by Osmocom network becomes unreliable from time to time. The RSSI indicator on those phones shows that the signal is lost, so neither CS nor PS services are working. As it then turned out, System Information 3 broadcasted on the Um interface is different than the one received from the BSC. In particular, the content SI3 Rest Octets IE is different. Among with the 'GPRS Indicator', which is actually expected to indicate whether the PCU is connected or now, SI3 Rest Octets on the Um interface contain both 'Optional Power Offset' and 'Scheduling if and where' IEs, which are not present in the original messages from the BSC. Moreover, as soon as the PCU is connected, 'GPRS Indicator' IE contains different 'GPRS RA Colour' value, and informs the MS that System Information 13 is sent on extended BCCH, which is not even supported by OsmoBTS! The culprit is in rsl_rx_bcch_info(), where we pass a pointer to osmo_gsm48_rest_octets_si3_decode(). Instead of passing a pointer to the beginning of SI3 buffer, we actually need to shift it to the beginning of the SI3 Rest Octets IE. This change makes my Sony Ericsson phones happy ;) Change-Id: Ia962cf21903ba674057cf52746996dd3254bc1c6 --- M src/common/rsl.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/17/14817/1 diff --git a/src/common/rsl.c b/src/common/rsl.c index 0a613bb..d66fd4e 100644 --- a/src/common/rsl.c +++ b/src/common/rsl.c @@ -368,7 +368,9 @@ LCHAN_REL_ACT_REACT; } /* decode original SI3 Rest Octets as sent by BSC */ - osmo_gsm48_rest_octets_si3_decode(>si3_ro_decoded, GSM_BTS_SI(bts, osmo_si)); + const uint8_t *si3_ro_buf = bts->si_buf[osmo_si]; + si3_ro_buf += offsetof(struct gsm48_system_information_type_3, rest_octets); + osmo_gsm48_rest_octets_si3_decode(>si3_ro_decoded, si3_ro_buf); /* patch out GPRS indicator from binary if PCU is not connected; will be enabled * after PCU connects */ regenerate_si3_restoctets(bts); -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14817 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia962cf21903ba674057cf52746996dd3254bc1c6 Gerrit-Change-Number: 14817 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange
Change in ...docker-playground[master]: debian-repo-install-test: kill already running
Hello pespin, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/14780 to look at the new patch set (#4). Change subject: debian-repo-install-test: kill already running .. debian-repo-install-test: kill already running The container grows heavily in size as the test runs, so make sure to always kill existing ones (from stopped jobs) before starting a new one. In order to do that, do not use $BUILD_TAG as container name, which changes with every new jenkins run. Related: OS#3369 Change-Id: Ide795092b656c9f0eb92a075d8f662944089019f --- M debian-repo-install-test/jenkins.sh 1 file changed, 13 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/80/14780/4 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14780 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ide795092b656c9f0eb92a075d8f662944089019f Gerrit-Change-Number: 14780 Gerrit-PatchSet: 4 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in ...docker-playground[master]: debian-repo-install-test: add docker container
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14779 ) Change subject: debian-repo-install-test: add docker container .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/14779/2/debian-repo-install-test/jenkins.sh File debian-repo-install-test/jenkins.sh: https://gerrit.osmocom.org/#/c/14779/2/debian-repo-install-test/jenkins.sh@24 PS2, Line 24: if ! docker exec "$BUILD_TAG" systemctl status; then > In order to avoid race conditions on busy/slow systems, it would make more > sense to have a 10 time l […] Done -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14779 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I0348f65a2ac184ba6b001e5130dfc8124e657367 Gerrit-Change-Number: 14779 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 17 Jul 2019 11:43:51 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
Change in ...docker-playground[master]: debian-repo-install-test: add docker container
Hello laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/14779 to look at the new patch set (#3). Change subject: debian-repo-install-test: add docker container .. debian-repo-install-test: add docker container Add own container with systemd, so we can (in a follow-up commit) run the Osmocom systemd services in this test job. Rewrite the "interactive shell" logic to support the new systemd docker container, and enable it with an INTERACTIVE environment variable instead of hardcoding 'interactive="true"' in the script. While at it, move the Repository.key install to the Dockerfile so it works more like the other docker containers we have. Related: OS#3369 Change-Id: I0348f65a2ac184ba6b001e5130dfc8124e657367 --- A debian-repo-install-test/Dockerfile A debian-repo-install-test/Makefile R debian-repo-install-test/Release.key M debian-repo-install-test/jenkins.sh M debian-repo-install-test/testdata/repo-install-test.sh 5 files changed, 50 insertions(+), 28 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/79/14779/3 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14779 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I0348f65a2ac184ba6b001e5130dfc8124e657367 Gerrit-Change-Number: 14779 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-CC: pespin Gerrit-MessageType: newpatchset
Change in ...osmocom-bb[master]: target/*.py: shebang: use /usr/bin/env python
lynxis lazus has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14759 ) Change subject: target/*.py: shebang: use /usr/bin/env python .. target/*.py: shebang: use /usr/bin/env python Use the system default python instead of a hardcoded python2 Allow to use python2 and python3. Change-Id: Iab185759b574eff1ca1b189dcbb4e1a3eec52132 --- M src/target/firmware/solve_envs.py M src/target/trx_toolkit/app_common.py M src/target/trx_toolkit/burst_fwd.py M src/target/trx_toolkit/burst_gen.py M src/target/trx_toolkit/burst_send.py M src/target/trx_toolkit/clck_gen.py M src/target/trx_toolkit/ctrl_cmd.py M src/target/trx_toolkit/ctrl_if.py M src/target/trx_toolkit/ctrl_if_trx.py M src/target/trx_toolkit/data_dump.py M src/target/trx_toolkit/data_if.py M src/target/trx_toolkit/data_msg.py M src/target/trx_toolkit/fake_pm.py M src/target/trx_toolkit/fake_trx.py M src/target/trx_toolkit/gsm_shared.py M src/target/trx_toolkit/rand_burst_gen.py M src/target/trx_toolkit/transceiver.py M src/target/trx_toolkit/trx_list.py M src/target/trx_toolkit/trx_sniff.py M src/target/trx_toolkit/udp_link.py 20 files changed, 20 insertions(+), 20 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/src/target/firmware/solve_envs.py b/src/target/firmware/solve_envs.py index d4cee80..b010897 100755 --- a/src/target/firmware/solve_envs.py +++ b/src/target/firmware/solve_envs.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python2 +#!/usr/bin/env python import sys diff --git a/src/target/trx_toolkit/app_common.py b/src/target/trx_toolkit/app_common.py index 9bcd593..f2a47c5 100644 --- a/src/target/trx_toolkit/app_common.py +++ b/src/target/trx_toolkit/app_common.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python2 +#!/usr/bin/env python # -*- coding: utf-8 -*- # TRX Toolkit diff --git a/src/target/trx_toolkit/burst_fwd.py b/src/target/trx_toolkit/burst_fwd.py index 1d5dd7b..b418aef 100644 --- a/src/target/trx_toolkit/burst_fwd.py +++ b/src/target/trx_toolkit/burst_fwd.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python2 +#!/usr/bin/env python # -*- coding: utf-8 -*- # TRX Toolkit diff --git a/src/target/trx_toolkit/burst_gen.py b/src/target/trx_toolkit/burst_gen.py index b62f48c..6db8219 100755 --- a/src/target/trx_toolkit/burst_gen.py +++ b/src/target/trx_toolkit/burst_gen.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python2 +#!/usr/bin/env python # -*- coding: utf-8 -*- # TRX Toolkit diff --git a/src/target/trx_toolkit/burst_send.py b/src/target/trx_toolkit/burst_send.py index 6c19e6f..2565f4a 100755 --- a/src/target/trx_toolkit/burst_send.py +++ b/src/target/trx_toolkit/burst_send.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python2 +#!/usr/bin/env python # -*- coding: utf-8 -*- # TRX Toolkit diff --git a/src/target/trx_toolkit/clck_gen.py b/src/target/trx_toolkit/clck_gen.py index a4b83b5..3e479e3 100755 --- a/src/target/trx_toolkit/clck_gen.py +++ b/src/target/trx_toolkit/clck_gen.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python2 +#!/usr/bin/env python # -*- coding: utf-8 -*- # TRX Toolkit diff --git a/src/target/trx_toolkit/ctrl_cmd.py b/src/target/trx_toolkit/ctrl_cmd.py index bdacb64..7deeeac 100755 --- a/src/target/trx_toolkit/ctrl_cmd.py +++ b/src/target/trx_toolkit/ctrl_cmd.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python2 +#!/usr/bin/env python # -*- coding: utf-8 -*- # TRX Toolkit diff --git a/src/target/trx_toolkit/ctrl_if.py b/src/target/trx_toolkit/ctrl_if.py index 902af18..89dfe46 100644 --- a/src/target/trx_toolkit/ctrl_if.py +++ b/src/target/trx_toolkit/ctrl_if.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python2 +#!/usr/bin/env python # -*- coding: utf-8 -*- # TRX Toolkit diff --git a/src/target/trx_toolkit/ctrl_if_trx.py b/src/target/trx_toolkit/ctrl_if_trx.py index 8cb5c1a..e44f8a9 100644 --- a/src/target/trx_toolkit/ctrl_if_trx.py +++ b/src/target/trx_toolkit/ctrl_if_trx.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python2 +#!/usr/bin/env python # -*- coding: utf-8 -*- # TRX Toolkit diff --git a/src/target/trx_toolkit/data_dump.py b/src/target/trx_toolkit/data_dump.py index 71e1261..97518bd 100644 --- a/src/target/trx_toolkit/data_dump.py +++ b/src/target/trx_toolkit/data_dump.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python2 +#!/usr/bin/env python # -*- coding: utf-8 -*- # TRX Toolkit diff --git a/src/target/trx_toolkit/data_if.py b/src/target/trx_toolkit/data_if.py index 11df756..e43b388 100644 --- a/src/target/trx_toolkit/data_if.py +++ b/src/target/trx_toolkit/data_if.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python2 +#!/usr/bin/env python # -*- coding: utf-8 -*- # TRX Toolkit diff --git a/src/target/trx_toolkit/data_msg.py b/src/target/trx_toolkit/data_msg.py index e946229..ebb7a0f 100644 --- a/src/target/trx_toolkit/data_msg.py +++ b/src/target/trx_toolkit/data_msg.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python2 +#!/usr/bin/env python # -*- coding:
Build failure of network:osmocom:nightly/osmo-bts in Raspbian_9.0/armv7l
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-bts failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 542s] ../../src/common/libbts.a(bts.o): In function `lchan_init_lapdm': [ 542s] ./src/common/bts.c:424: undefined reference to `lapdm_channel_init2' [ 542s] collect2: error: ld returned 1 exit status [ 542s] Makefile:421: recipe for target 'osmo-bts-virtual' failed [ 542s] make[4]: *** [osmo-bts-virtual] Error 1 [ 542s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-bts-virtual' [ 542s] Makefile:385: recipe for target 'all-recursive' failed [ 542s] make[3]: *** [all-recursive] Error 1 [ 542s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 542s] Makefile:434: recipe for target 'all-recursive' failed [ 542s] make[2]: *** [all-recursive] Error 1 [ 542s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 542s] Makefile:366: recipe for target 'all' failed [ 542s] make[1]: *** [all] Error 2 [ 542s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 542s] dh_auto_build: make -j1 returned exit code 2 [ 542s] debian/rules:12: recipe for target 'build' failed [ 542s] make: *** [build] Error 2 [ 542s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 542s] [ 542s] armbuild17 failed "build osmo-bts_0.8.1.344.af6f.dsc" at Wed Jul 17 11:07:49 UTC 2019. [ 542s] [ 542s] ### VM INTERACTION START ### [ 545s] [ 492.243361] sysrq: SysRq : Power Off [ 545s] [ 492.246871] reboot: Power down [ 546s] ### VM INTERACTION END ### [ 546s] [ 546s] armbuild17 failed "build osmo-bts_0.8.1.344.af6f.dsc" at Wed Jul 17 11:07:53 UTC 2019. [ 546s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Change in ...osmo-hlr[master]: fix spelling errors detected by lintian
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14806 ) Change subject: fix spelling errors detected by lintian .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14806 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I2a1a21aceabc20fadc5dd28985a94689d2b873a2 Gerrit-Change-Number: 14806 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Jul 2019 11:03:35 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...libosmocore[master]: Set HTML_TIMESTAMP to NO to make build reproducible
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/14795 ) Change subject: Set HTML_TIMESTAMP to NO to make build reproducible .. Set HTML_TIMESTAMP to NO to make build reproducible Change-Id: I56cce5cda0621f5e9f1c28aaad4646e9e267d17d --- M Doxyfile.codec.in M Doxyfile.core.in M Doxyfile.gsm.in M Doxyfile.vty.in 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/Doxyfile.codec.in b/Doxyfile.codec.in index 307e3e1..88f0d27 100644 --- a/Doxyfile.codec.in +++ b/Doxyfile.codec.in @@ -891,7 +891,7 @@ # page will contain the date and time when the page was generated. Setting # this to NO can help when comparing the output of multiple runs. -HTML_TIMESTAMP = YES +HTML_TIMESTAMP = NO # If the HTML_ALIGN_MEMBERS tag is set to YES, the members of classes, # files or namespaces will be aligned in HTML using tables. If set to diff --git a/Doxyfile.core.in b/Doxyfile.core.in index f83205a..c2bfcd5 100644 --- a/Doxyfile.core.in +++ b/Doxyfile.core.in @@ -891,7 +891,7 @@ # page will contain the date and time when the page was generated. Setting # this to NO can help when comparing the output of multiple runs. -HTML_TIMESTAMP = YES +HTML_TIMESTAMP = NO # If the HTML_ALIGN_MEMBERS tag is set to YES, the members of classes, # files or namespaces will be aligned in HTML using tables. If set to diff --git a/Doxyfile.gsm.in b/Doxyfile.gsm.in index aae0e89..fd89390 100644 --- a/Doxyfile.gsm.in +++ b/Doxyfile.gsm.in @@ -891,7 +891,7 @@ # page will contain the date and time when the page was generated. Setting # this to NO can help when comparing the output of multiple runs. -HTML_TIMESTAMP = YES +HTML_TIMESTAMP = NO # If the HTML_ALIGN_MEMBERS tag is set to YES, the members of classes, # files or namespaces will be aligned in HTML using tables. If set to diff --git a/Doxyfile.vty.in b/Doxyfile.vty.in index fb1cabf..9f56fd7 100644 --- a/Doxyfile.vty.in +++ b/Doxyfile.vty.in @@ -891,7 +891,7 @@ # page will contain the date and time when the page was generated. Setting # this to NO can help when comparing the output of multiple runs. -HTML_TIMESTAMP = YES +HTML_TIMESTAMP = NO # If the HTML_ALIGN_MEMBERS tag is set to YES, the members of classes, # files or namespaces will be aligned in HTML using tables. If set to -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14795 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I56cce5cda0621f5e9f1c28aaad4646e9e267d17d Gerrit-Change-Number: 14795 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Ruben Undheim Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-MessageType: merged
Change in ...osmo-msc[master]: fix spelling detected by lintian
laforge has submitted this change and it was merged. (
https://gerrit.osmocom.org/c/osmo-msc/+/14812 )
Change subject: fix spelling detected by lintian
..
fix spelling detected by lintian
Change-Id: I01e54b5cf111677079a8ad57645d3ceb7834702a
---
M doc/manuals/chapters/counters_generated.adoc
M include/osmocom/msc/gsm_data.h
M include/osmocom/msc/signal.h
M src/libmsc/gsm_04_08.c
4 files changed, 6 insertions(+), 6 deletions(-)
Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, approved
laforge: Looks good to me, approved
diff --git a/doc/manuals/chapters/counters_generated.adoc
b/doc/manuals/chapters/counters_generated.adoc
index 6a3a3d2..1b40d8b 100644
--- a/doc/manuals/chapters/counters_generated.adoc
+++ b/doc/manuals/chapters/counters_generated.adoc
@@ -25,7 +25,7 @@
| sms:delivered | <> | Global SMS Deliver attempts.
| sms:rp_err_mem | <> | CAUSE_MT_MEM_EXCEEDED errors of MS
responses on a sms deliver attempt.
| sms:rp_err_other | <> | Other error of MS responses on
a sms delive attempt.
-| sms:deliver_unknown_error | <> | Unknown
error occured during sms delivery.
+| sms:deliver_unknown_error | <> | Unknown
error occurred during sms delivery.
| call:mo_setup | <> | Received setup requests from a MS to
init a MO call.
| call:mo_connect_ack | <> | Received a connect ack
from MS of a MO call. Call is now succesful connected up.
| call:mt_setup | <> | Sent setup requests to the MS (MT).
diff --git a/include/osmocom/msc/gsm_data.h b/include/osmocom/msc/gsm_data.h
index f6e3ed9..6050113 100644
--- a/include/osmocom/msc/gsm_data.h
+++ b/include/osmocom/msc/gsm_data.h
@@ -79,7 +79,7 @@
[MSC_CTR_SMS_DELIVERED] = {"sms:delivered", "Global SMS
Deliver attempts."},
[MSC_CTR_SMS_RP_ERR_MEM] = {"sms:rp_err_mem",
"CAUSE_MT_MEM_EXCEEDED errors of MS responses on a sms deliver attempt."},
[MSC_CTR_SMS_RP_ERR_OTHER] ={"sms:rp_err_other", "Other
error of MS responses on a sms delive attempt."},
- [MSC_CTR_SMS_DELIVER_UNKNOWN_ERROR] = {"sms:deliver_unknown_error",
"Unknown error occured during sms delivery."},
+ [MSC_CTR_SMS_DELIVER_UNKNOWN_ERROR] = {"sms:deliver_unknown_error",
"Unknown error occurred during sms delivery."},
/* FIXME: count also sms delivered */
[MSC_CTR_CALL_MO_SETUP] = {"call:mo_setup", "Received
setup requests from a MS to init a MO call."},
[MSC_CTR_CALL_MO_CONNECT_ACK] = {"call:mo_connect_ack",
"Received a connect ack from MS of a MO call. Call is now succesful connected
up."},
diff --git a/include/osmocom/msc/signal.h b/include/osmocom/msc/signal.h
index 16b5678..c7f8991 100644
--- a/include/osmocom/msc/signal.h
+++ b/include/osmocom/msc/signal.h
@@ -89,7 +89,7 @@
struct vty *vty;
};
struct sms_signal_data {
- /* The transaction where this occured */
+ /* The transaction where this occurred */
struct gsm_trans *trans;
/* Can be NULL for SMMA */
struct gsm_sms *sms;
diff --git a/src/libmsc/gsm_04_08.c b/src/libmsc/gsm_04_08.c
index 57dff41..ee31747 100644
--- a/src/libmsc/gsm_04_08.c
+++ b/src/libmsc/gsm_04_08.c
@@ -389,7 +389,7 @@
/* From vlr_loc_update() we expect an implicit dispatch of
* VLR_ULA_E_UPDATE_LA, and thus we expect msc_vlr_subscr_assoc() to
-* already have been called and completed. Has an error occured? */
+* already have been called and completed. Has an error occurred? */
vsub = msc_a_vsub(msc_a);
if (!vsub) {
@@ -786,7 +786,7 @@
is_utran);
/* From vlr_proc_acc_req() we expect an implicit dispatch of
PR_ARQ_E_START we expect
-* msc_vlr_subscr_assoc() to already have been called and completed.
Has an error occured? */
+* msc_vlr_subscr_assoc() to already have been called and completed.
Has an error occurred? */
vsub = msc_a_vsub(msc_a);
if (!vsub) {
LOG_MSC_A(msc_a, LOGL_ERROR, "subscriber not allowed to do a CM
Service Request\n");
@@ -1158,7 +1158,7 @@
is_utran);
/* From vlr_proc_acc_req() we expect an implicit dispatch of
PR_ARQ_E_START we expect
-* msc_vlr_subscr_assoc() to already have been called and completed.
Has an error occured? */
+* msc_vlr_subscr_assoc() to already have been called and completed.
Has an error occurred? */
vsub = msc_a_vsub(msc_a);
if (!vsub) {
LOG_MSC_A(msc_a, LOGL_ERROR, "subscriber not allowed to do a
Paging Response\n");
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14812
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I01e54b5cf111677079a8ad57645d3ceb7834702a
Gerrit-Change-Number: 14812
Gerrit-PatchSet: 2
Change in ...osmo-msc[master]: fix spelling detected by lintian
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14812 ) Change subject: fix spelling detected by lintian .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14812 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I01e54b5cf111677079a8ad57645d3ceb7834702a Gerrit-Change-Number: 14812 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 17 Jul 2019 11:02:40 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-bsc[master]: Fix some spelling errors found by lintian
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14810 ) Change subject: Fix some spelling errors found by lintian .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14810 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I63a733f8bea69f355a6686d99c3aa194c8ac9012 Gerrit-Change-Number: 14810 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Ruben Undheim Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Jul 2019 11:01:50 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-bsc[master]: Fix one struct for big-endian archs
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14811 ) Change subject: Fix one struct for big-endian archs .. Patch Set 1: osmo-ci/scripts/libosmocore/contrib/struct_endianess.py preferred -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14811 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic6e654e0d95d662942c6485097f0b96e1fa46ead Gerrit-Change-Number: 14811 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Ruben Undheim Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-CC: laforge Gerrit-Comment-Date: Wed, 17 Jul 2019 11:02:12 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in ...osmo-bsc[master]: Fix some spelling errors found by lintian
laforge has submitted this change and it was merged. (
https://gerrit.osmocom.org/c/osmo-bsc/+/14810 )
Change subject: Fix some spelling errors found by lintian
..
Fix some spelling errors found by lintian
Change-Id: I63a733f8bea69f355a6686d99c3aa194c8ac9012
---
M doc/manuals/vty/bsc_vty_reference.xml
M src/osmo-bsc/a_reset.c
M src/osmo-bsc/abis_om2000_vty.c
M src/osmo-bsc/bsc_vty.c
M src/osmo-bsc/osmo_bsc_main.c
M src/osmo-bsc/osmo_bsc_sigtran.c
M src/osmo-bsc/osmo_bsc_vty.c
M src/osmo-bsc/pcu_sock.c
8 files changed, 10 insertions(+), 10 deletions(-)
Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
pespin: Looks good to me, approved
diff --git a/doc/manuals/vty/bsc_vty_reference.xml
b/doc/manuals/vty/bsc_vty_reference.xml
index 4d25e69..db4f2c1 100644
--- a/doc/manuals/vty/bsc_vty_reference.xml
+++ b/doc/manuals/vty/bsc_vty_reference.xml
@@ -2958,7 +2958,7 @@
-
+
@@ -4830,7 +4830,7 @@
-
+
@@ -4841,7 +4841,7 @@
-
+
diff --git a/src/osmo-bsc/a_reset.c b/src/osmo-bsc/a_reset.c
index 3c21142..fc59ff4 100644
--- a/src/osmo-bsc/a_reset.c
+++ b/src/osmo-bsc/a_reset.c
@@ -71,7 +71,7 @@
{
struct reset_ctx *reset_ctx = (struct reset_ctx *)fi->priv;
OSMO_ASSERT(reset_ctx);
- LOGPFSML(fi, LOGL_NOTICE, "SIGTRAN connection succeded.\n");
+ LOGPFSML(fi, LOGL_NOTICE, "SIGTRAN connection succeeded.\n");
reset_ctx->conn_loss_counter = 0;
osmo_fsm_inst_state_chg(fi, ST_CONN, 0, 0);
diff --git a/src/osmo-bsc/abis_om2000_vty.c b/src/osmo-bsc/abis_om2000_vty.c
index faf39c1..3ae870e 100644
--- a/src/osmo-bsc/abis_om2000_vty.c
+++ b/src/osmo-bsc/abis_om2000_vty.c
@@ -368,7 +368,7 @@
#define CON_PATH_HELP "CON Path (In/Out)\n" \
"Add CON Path to Concentration Group\n" \
"Delete CON Path from Concentration Group\n"\
- "CON Conection Point\n" \
+ "CON Connection Point\n"
\
"Contiguity Index\n"\
DEFUN(cfg_om2k_con_path_dec, cfg_om2k_con_path_dec_cmd,
diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c
index c4e091c..24f8313 100644
--- a/src/osmo-bsc/bsc_vty.c
+++ b/src/osmo-bsc/bsc_vty.c
@@ -2371,7 +2371,7 @@
DEFUN(cfg_bts_challoc, cfg_bts_challoc_cmd,
"channel allocator (ascending|descending)",
- "Channnel Allocator\n" "Channel Allocator\n"
+ "Channel Allocator\n" "Channel Allocator\n"
"Allocate Timeslots and Transceivers in ascending order\n"
"Allocate Timeslots and Transceivers in descending order\n")
{
diff --git a/src/osmo-bsc/osmo_bsc_main.c b/src/osmo-bsc/osmo_bsc_main.c
index 0e0e8ca..aba8c40 100644
--- a/src/osmo-bsc/osmo_bsc_main.c
+++ b/src/osmo-bsc/osmo_bsc_main.c
@@ -906,7 +906,7 @@
}
if (osmo_bsc_sigtran_init(_gsmnet->bsc_data->mscs) != 0) {
- LOGP(DNM, LOGL_ERROR, "Failed to initalize sigtran
backhaul.\n");
+ LOGP(DNM, LOGL_ERROR, "Failed to initialize sigtran
backhaul.\n");
exit(1);
}
diff --git a/src/osmo-bsc/osmo_bsc_sigtran.c b/src/osmo-bsc/osmo_bsc_sigtran.c
index 763e1e1..0bf48a7 100644
--- a/src/osmo-bsc/osmo_bsc_sigtran.c
+++ b/src/osmo-bsc/osmo_bsc_sigtran.c
@@ -564,7 +564,7 @@
/* Start MSC-Reset procedure */
a_reset_alloc(msc, msc_name, osmo_bsc_sigtran_reset_cb);
- /* If we have detected that the SS7 configuration of the MSC we
have just initalized
+ /* If we have detected that the SS7 configuration of the MSC we
have just initialized
* was incomplete or completely missing, we can not tolerate
another incomplete
* configuration. The reson for this is that we do only specify
exactly one default
* pointcode pair. We also specify localhost as default
IP-Address. If we have wanted
diff --git a/src/osmo-bsc/osmo_bsc_vty.c b/src/osmo-bsc/osmo_bsc_vty.c
index 4591ad1..e656d70 100644
--- a/src/osmo-bsc/osmo_bsc_vty.c
+++ b/src/osmo-bsc/osmo_bsc_vty.c
@@ -569,7 +569,7 @@
if (addr->presence & OSMO_SCCP_ADDR_T_SSN) {
if (addr->ssn != OSMO_SCCP_SSN_BSSAP)
vty_out(vty,
- "setting an SSN (%u) different from the
standard (%u) is not allowd, will use standard SSN for address: %s%s",
+ "setting an SSN (%u) different from the
standard (%u) is not allowed, will use standard SSN for address: %s%s",
Change in ...osmo-pcu[master]: Add structs for big-endian
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14802 ) Change subject: Add structs for big-endian .. Patch Set 1: we do have osmo-ci/scripts/libosmocore/contrib/struct_endianess.py to do this in an automatic/programmatic way, which I'd prefer over manual patches. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14802 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I6af6d5ef05a8b240acfd9da747d9657bb6aa0ef8 Gerrit-Change-Number: 14802 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Ruben Undheim Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Wed, 17 Jul 2019 11:01:24 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in ...osmo-sgsn[master]: Compare with -ENOTSUP to fix build on mipsel/mips64el/alpha
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14816 ) Change subject: Compare with -ENOTSUP to fix build on mipsel/mips64el/alpha .. Patch Set 1: Code-Review-1 same here, I'm really not convinced at all this is a valid fix. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14816 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I591d37377495829d2a2bbb350e2c78fe4bddc745 Gerrit-Change-Number: 14816 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Ruben Undheim Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 17 Jul 2019 11:00:05 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-sgsn[master]: Spelling fixes
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14815 ) Change subject: Spelling fixes .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14815 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Id1511c5022a239db5d0b44ec7adf048cca307751 Gerrit-Change-Number: 14815 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Ruben Undheim Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Jul 2019 10:59:22 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-sgsn[master]: Spelling fixes
laforge has submitted this change and it was merged. (
https://gerrit.osmocom.org/c/osmo-sgsn/+/14815 )
Change subject: Spelling fixes
..
Spelling fixes
Change-Id: Id1511c5022a239db5d0b44ec7adf048cca307751
---
M src/gprs/gprs_gmm.c
M src/gprs/gprs_sgsn.c
M src/gprs/gprs_sndcp_dcomp.c
M src/gprs/gprs_sndcp_pcomp.c
M src/gprs/gtphub_main.c
M src/gprs/sgsn_vty.c
6 files changed, 11 insertions(+), 11 deletions(-)
Approvals:
laforge: Looks good to me, approved
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/gprs/gprs_gmm.c b/src/gprs/gprs_gmm.c
index e7f0bfe..3465a52 100644
--- a/src/gprs/gprs_gmm.c
+++ b/src/gprs/gprs_gmm.c
@@ -2213,7 +2213,7 @@
rc = gsm48_tx_gmm_auth_ciph_req(mm, >vec, at->key_seq,
false);
if (rc < 0)
- LOGMMCTXP(LOGL_ERROR, mm, "failed sending Auth. & Ciph.
Reuqest: %s \n", strerror(-rc));
+ LOGMMCTXP(LOGL_ERROR, mm, "failed sending Auth. & Ciph.
Request: %s \n", strerror(-rc));
else
osmo_timer_schedule(>timer, sgsn->cfg.timers.T3360,
0);
break;
diff --git a/src/gprs/gprs_sgsn.c b/src/gprs/gprs_sgsn.c
index 8d3de7b..fae09ae 100644
--- a/src/gprs/gprs_sgsn.c
+++ b/src/gprs/gprs_sgsn.c
@@ -103,9 +103,9 @@
static const struct rate_ctr_desc sgsn_ctr_description[] = {
{ "llc:dl_bytes", "Count sent LLC bytes before giving it to the bssgp
layer" },
- { "llc:ul_bytes", "Count sucessful received LLC bytes (encrypt & fcs
correct)" },
- { "llc:dl_packets", "Count sucessful sent LLC packets before giving it
to the bssgp layer" },
- { "llc:ul_packets", "Count sucessful received LLC packets (encrypt &
fcs correct)" },
+ { "llc:ul_bytes", "Count successful received LLC bytes (encrypt & fcs
correct)" },
+ { "llc:dl_packets", "Count successful sent LLC packets before giving it
to the bssgp layer" },
+ { "llc:ul_packets", "Count successful received LLC packets (encrypt &
fcs correct)" },
{ "gprs:attach_requested", "Received attach requests" },
{ "gprs:attach_accepted", "Sent attach accepts" },
{ "gprs:attach_rejected", "Sent attach rejects" },
diff --git a/src/gprs/gprs_sndcp_dcomp.c b/src/gprs/gprs_sndcp_dcomp.c
index 00e40a7..c0da84d 100644
--- a/src/gprs/gprs_sndcp_dcomp.c
+++ b/src/gprs/gprs_sndcp_dcomp.c
@@ -94,7 +94,7 @@
_v42bis_data_handler, NULL,
V42BIS_MAX_OUTPUT_LENGTH);
LOGP(DSNDCP, LOGL_INFO,
-"V.42bis data compression initalized.\n");
+"V.42bis data compression initialized.\n");
return 0;
}
diff --git a/src/gprs/gprs_sndcp_pcomp.c b/src/gprs/gprs_sndcp_pcomp.c
index 5f7f22a..8c2fc97 100644
--- a/src/gprs/gprs_sndcp_pcomp.c
+++ b/src/gprs/gprs_sndcp_pcomp.c
@@ -59,7 +59,7 @@
slhc_init(ctx, comp_field->rfc1144_params->s01 + 1,
comp_field->rfc1144_params->s01 + 1);
LOGP(DSNDCP, LOGL_INFO,
-"RFC1144 header compression initalized.\n");
+"RFC1144 header compression initialized.\n");
return 0;
}
diff --git a/src/gprs/gtphub_main.c b/src/gprs/gtphub_main.c
index 0369ed7..585a3cb 100644
--- a/src/gprs/gtphub_main.c
+++ b/src/gprs/gtphub_main.c
@@ -243,7 +243,7 @@
static void list_categories(void)
{
- printf("Avaliable debug categories:\n");
+ printf("Available debug categories:\n");
int i;
for (i = 0; i < gtphub_log_info.num_cat; ++i) {
if (!gtphub_log_info.cat[i].name)
diff --git a/src/gprs/sgsn_vty.c b/src/gprs/sgsn_vty.c
index edc5b09..d1d53e6 100644
--- a/src/gprs/sgsn_vty.c
+++ b/src/gprs/sgsn_vty.c
@@ -1309,7 +1309,7 @@
DEFUN(cfg_comp_rfc1144, cfg_comp_rfc1144_cmd,
"compression rfc1144 active slots <1-256>",
COMPRESSION_STR
- "RFC1144 Header compresion scheme\n"
+ "RFC1144 Header compression scheme\n"
"Compression is actively proposed\n"
"Number of compression state slots\n"
"Number of compression state slots\n")
@@ -1323,7 +1323,7 @@
DEFUN(cfg_comp_rfc1144p, cfg_comp_rfc1144p_cmd,
"compression rfc1144 passive",
COMPRESSION_STR
- "RFC1144 Header compresion scheme\n"
+ "RFC1144 Header compression scheme\n"
"Compression is available on request\n")
{
g_cfg->pcomp_rfc1144.active = 0;
@@ -1343,7 +1343,7 @@
DEFUN(cfg_comp_v42bis, cfg_comp_v42bis_cmd,
"compression v42bis active direction (ms|sgsn|both) codewords
<512-65535> strlen <6-250>",
COMPRESSION_STR
- "V.42bis data compresion scheme\n"
+ "V.42bis data compression scheme\n"
"Compression is actively proposed\n"
"Direction in which the compression shall be active (p0)\n"
"Compress
Change in ...osmo-iuh[master]: spelling stuff found by lintian
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/14808 ) Change subject: spelling stuff found by lintian .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/14808 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I8434640701746d5db8707472d1d26c313e0814e9 Gerrit-Change-Number: 14808 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Jul 2019 10:58:37 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-bts[master]: fix spelling stuff mentioned by lintian
laforge has submitted this change and it was merged. (
https://gerrit.osmocom.org/c/osmo-bts/+/14813 )
Change subject: fix spelling stuff mentioned by lintian
..
fix spelling stuff mentioned by lintian
Change-Id: I3d6cb6fc1b182d8520ba60e431ab9b74e71d5e3c
---
M src/common/pcu_sock.c
M src/common/rsl.c
M src/osmo-bts-octphy/l1_if.c
M src/osmo-bts-trx/trx_vty.c
4 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
laforge: Looks good to me, approved
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c
index 39b4568..1d9fa72 100644
--- a/src/common/pcu_sock.c
+++ b/src/common/pcu_sock.c
@@ -677,7 +677,7 @@
rc = pcu_rx_txt_ind(bts, _prim->u.txt_ind);
break;
default:
- LOGP(DPCU, LOGL_ERROR, "Received unknwon PCU msg type %d\n",
+ LOGP(DPCU, LOGL_ERROR, "Received unknown PCU msg type %d\n",
msg_type);
rc = -EINVAL;
}
diff --git a/src/common/rsl.c b/src/common/rsl.c
index 0a613bb..0a6a4e5 100644
--- a/src/common/rsl.c
+++ b/src/common/rsl.c
@@ -3090,7 +3090,7 @@
msg->lchan = lchan_lookup(trx, dch->chan_nr, "RSL rx IPACC: ");
if (!msg->lchan) {
- LOGP(DRSL, LOGL_ERROR, "Rx RSL %s for unknow lchan\n",
+ LOGP(DRSL, LOGL_ERROR, "Rx RSL %s for unknown lchan\n",
rsl_msg_name(dch->c.msg_type));
return rsl_reject_unknown_lchan(msg);
}
diff --git a/src/osmo-bts-octphy/l1_if.c b/src/osmo-bts-octphy/l1_if.c
index 32e738f..612c29a 100644
--- a/src/osmo-bts-octphy/l1_if.c
+++ b/src/osmo-bts-octphy/l1_if.c
@@ -1175,7 +1175,7 @@
if (ra_ind->ulMsgLength != 1) {
LOGPFN(DL1C, LOGL_ERROR, ra_ind->ulFrameNumber,
- "Rx PH-RACH.ind has lenghth %d > 1\n",
ra_ind->ulMsgLength);
+ "Rx PH-RACH.ind has length %d > 1\n",
ra_ind->ulMsgLength);
msgb_free(l1p_msg);
return 0;
}
diff --git a/src/osmo-bts-trx/trx_vty.c b/src/osmo-bts-trx/trx_vty.c
index e9710ac..b9af445 100644
--- a/src/osmo-bts-trx/trx_vty.c
+++ b/src/osmo-bts-trx/trx_vty.c
@@ -237,7 +237,7 @@
OSMOTRX_STR
"Set the maximum acceptable delay of a Normal Burst (in GSM symbols)."
" USE FOR TESTING ONLY, DON'T CHANGE IN PRODUCTION USE!"
- " During normal operation, Normal Bursts delay are controled by a
Timing"
+ " During normal operation, Normal Bursts delay are controlled by a
Timing"
" Advance control loop and thus Normal Bursts arrive to a BTS with no
more"
" than a couple GSM symbols, which is already taken into account in
osmo-trx."
" So changing this setting will have no effect in production
installations"
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14813
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I3d6cb6fc1b182d8520ba60e431ab9b74e71d5e3c
Gerrit-Change-Number: 14813
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in ...osmo-iuh[master]: spelling stuff found by lintian
laforge has submitted this change and it was merged. (
https://gerrit.osmocom.org/c/osmo-iuh/+/14808 )
Change subject: spelling stuff found by lintian
..
spelling stuff found by lintian
Change-Id: I8434640701746d5db8707472d1d26c313e0814e9
---
M src/hnbgw_rua.c
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, approved
laforge: Looks good to me, approved
diff --git a/src/hnbgw_rua.c b/src/hnbgw_rua.c
index 40d1d94..71c3f8e 100644
--- a/src/hnbgw_rua.c
+++ b/src/hnbgw_rua.c
@@ -505,7 +505,7 @@
static int rua_rx_successful_outcome_msg(struct msgb *msg,
RUA_SuccessfulOutcome_t *in)
{
/* FIXME */
- LOGP(DRUA, LOGL_NOTICE, "Unexpected RUA Sucessful Outcome\n");
+ LOGP(DRUA, LOGL_NOTICE, "Unexpected RUA Successful Outcome\n");
return -1;
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/14808
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: I8434640701746d5db8707472d1d26c313e0814e9
Gerrit-Change-Number: 14808
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in ...osmo-bts[master]: fix spelling stuff mentioned by lintian
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14813 ) Change subject: fix spelling stuff mentioned by lintian .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14813 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I3d6cb6fc1b182d8520ba60e431ab9b74e71d5e3c Gerrit-Change-Number: 14813 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Jul 2019 10:58:56 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-trx[master]: Fix spelling discovered by lintian
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14807 ) Change subject: Fix spelling discovered by lintian .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14807 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5ab9b9c7c47d0d6e674c1f5242e2b3a05006293e Gerrit-Change-Number: 14807 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Ruben Undheim Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Jul 2019 10:58:21 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-trx[master]: Fix spelling discovered by lintian
laforge has submitted this change and it was merged. (
https://gerrit.osmocom.org/c/osmo-trx/+/14807 )
Change subject: Fix spelling discovered by lintian
..
Fix spelling discovered by lintian
Change-Id: I5ab9b9c7c47d0d6e674c1f5242e2b3a05006293e
---
M Transceiver52M/osmo-trx.cpp
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
laforge: Looks good to me, approved
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/Transceiver52M/osmo-trx.cpp b/Transceiver52M/osmo-trx.cpp
index 06b1a18..b8cf968 100644
--- a/Transceiver52M/osmo-trx.cpp
+++ b/Transceiver52M/osmo-trx.cpp
@@ -255,7 +255,7 @@
{
LOG(WARNING) << "Cmd line option '" << opt << "' is deprecated and will
be soon removed."
<< " Please use VTY cfg option instead."
- << " All cmd line options are already being overriden by VTY
options if set.";
+ << " All cmd line options are already being overridden by VTY
options if set.";
}
static void handle_options(int argc, char **argv, struct trx_ctx* trx)
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14807
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I5ab9b9c7c47d0d6e674c1f5242e2b3a05006293e
Gerrit-Change-Number: 14807
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Ruben Undheim
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in ...libosmo-sccp[master]: This patch fixes typos on which Lintian complains
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/14803 ) Change subject: This patch fixes typos on which Lintian complains .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/14803 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I657c694a9a7474182a97f90aa8424403ca9c58db Gerrit-Change-Number: 14803 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Jul 2019 10:56:36 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...libosmo-sccp[master]: This patch fixes typos on which Lintian complains
laforge has submitted this change and it was merged. (
https://gerrit.osmocom.org/c/libosmo-sccp/+/14803 )
Change subject: This patch fixes typos on which Lintian complains
..
This patch fixes typos on which Lintian complains
Change-Id: I657c694a9a7474182a97f90aa8424403ca9c58db
---
M src/m3ua.c
M stp/stp_main.c
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
laforge: Looks good to me, approved
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/m3ua.c b/src/m3ua.c
index d7ede40..d733b51 100644
--- a/src/m3ua.c
+++ b/src/m3ua.c
@@ -91,7 +91,7 @@
};
const struct value_string m3ua_ntfy_other_names[] = {
- { M3UA_NOTIFY_I_OT_INS_RES, "Insufficient ASP Resouces active in
AS" },
+ { M3UA_NOTIFY_I_OT_INS_RES, "Insufficient ASP Resources active in
AS" },
{ M3UA_NOTIFY_I_OT_ALT_ASP_ACT, "Alternative ASP Active" },
{ M3UA_NOTIFY_I_OT_ASP_FAILURE, "ASP Failure" },
{ 0, NULL }
diff --git a/stp/stp_main.c b/stp/stp_main.c
index 6a47403..ff33959 100644
--- a/stp/stp_main.c
+++ b/stp/stp_main.c
@@ -85,7 +85,7 @@
static void print_help(void)
{
printf(" -h --help This text.\n");
- printf(" -D --daemonizeFork teh process into a
background daemon\n");
+ printf(" -D --daemonizeFork the process into a
background daemon\n");
printf(" -c --config-file filename The config file to use.
Default: ./osmo-stp.cfg\n");
printf(" -V --version Print the version of
OsmoSTP\n");
}
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/14803
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I657c694a9a7474182a97f90aa8424403ca9c58db
Gerrit-Change-Number: 14803
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in ...osmo-pcu[master]: fix spelling errors detected by lintian
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14801 ) Change subject: fix spelling errors detected by lintian .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14801 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I381618eb55cc513cfa9c2e384c27cead0935c8bf Gerrit-Change-Number: 14801 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Jul 2019 10:56:18 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-pcu[master]: fix spelling errors detected by lintian
laforge has submitted this change and it was merged. (
https://gerrit.osmocom.org/c/osmo-pcu/+/14801 )
Change subject: fix spelling errors detected by lintian
..
fix spelling errors detected by lintian
Change-Id: I381618eb55cc513cfa9c2e384c27cead0935c8bf
---
M src/bts.cpp
M src/decoding.cpp
M src/encoding.cpp
M src/gsm_rlcmac.cpp
M src/gsm_rlcmac.h
M src/pcu_l1_if.cpp
M src/pdch.cpp
M src/tbf.cpp
M src/tbf.h
9 files changed, 14 insertions(+), 14 deletions(-)
Approvals:
laforge: Looks good to me, approved
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/bts.cpp b/src/bts.cpp
index 8799c3d..395fc73 100644
--- a/src/bts.cpp
+++ b/src/bts.cpp
@@ -611,7 +611,7 @@
* we roll back the rounded frame number by one RFN_MODULUS */
if (abs(rfn - m_cur_rfn) > RFN_THRESHOLD) {
LOGP(DRLCMAC, LOGL_DEBUG,
-"Race condition between rfn (%u) and m_cur_fn (%u)
detected: rfn belongs to the previos modulus %u cycle, wrappng...\n",
+"Race condition between rfn (%u) and m_cur_fn (%u)
detected: rfn belongs to the previous modulus %u cycle, wrapping...\n",
rfn, m_cur_fn, RFN_MODULUS);
if (fn_rounded < RFN_MODULUS) {
LOGP(DRLCMAC, LOGL_DEBUG,
diff --git a/src/decoding.cpp b/src/decoding.cpp
index d439e30..99a17dc 100644
--- a/src/decoding.cpp
+++ b/src/decoding.cpp
@@ -77,7 +77,7 @@
/* TS 44.060, table 10.4.14a.1, row 3 & 5 */
/* only filling bytes left */
LOGP(DRLCMACUL, LOGL_DEBUG, "UL DATA LI contains "
- "only filling bytes with extention octet:
LI=%d, E=%d, count=%d\n",
+ "only filling bytes with extension octet:
LI=%d, E=%d, count=%d\n",
li->li, li->e, num_chunks);
break;
} else if (li->li > 0) {
@@ -92,7 +92,7 @@
}
LOGP(DRLCMACUL, LOGL_DEBUG, "UL DATA LI contains "
- "extention octet: LI=%d, E=%d, count=%d\n",
+ "extension octet: LI=%d, E=%d, count=%d\n",
li->li, li->e, num_chunks);
num_chunks += 1;
@@ -168,7 +168,7 @@
chunks[num_chunks].is_complete = li->li || is_last_block;
LOGP(DRLCMACUL, LOGL_DEBUG, "UL DATA LI contains "
- "extention octet: LI=%d, M=%d, E=%d, count=%d\n",
+ "extension octet: LI=%d, M=%d, E=%d, count=%d\n",
li->li, li->m, li->e, num_chunks);
num_chunks += 1;
diff --git a/src/encoding.cpp b/src/encoding.cpp
index ca9e906..3fac75e 100644
--- a/src/encoding.cpp
+++ b/src/encoding.cpp
@@ -532,7 +532,7 @@
if (rc < 0) {
LOGP(DRLCMAC, LOGL_ERROR,
- "Failed to create IMMEDIATE ASSIGMENT (%s) for %s\n",
+ "Failed to create IMMEDIATE ASSIGNMENT (%s) for %s\n",
downlink ? "downlink" : "uplink",
tbf ? tbf->name() : "single block allocation");
return rc;
diff --git a/src/gsm_rlcmac.cpp b/src/gsm_rlcmac.cpp
index 6323b09..ef7abcd 100644
--- a/src/gsm_rlcmac.cpp
+++ b/src/gsm_rlcmac.cpp
@@ -1363,8 +1363,8 @@
static const
CSN_DESCR_BEGIN(PCCF_AdditionsR5_t)
- M_NEXT_EXIST (PCCF_AdditionsR5_t, Exist_G_RNTI_extention, 1),
- M_UINT (PCCF_AdditionsR5_t, G_RNTI_extention, 4),
+ M_NEXT_EXIST (PCCF_AdditionsR5_t, Exist_G_RNTI_extension, 1),
+ M_UINT (PCCF_AdditionsR5_t, G_RNTI_extension, 4),
M_NEXT_EXIST_OR_NULL(PCCF_AdditionsR5_t, Exist_AdditionsR8, 1),
M_TYPE (PCCF_AdditionsR5_t, AdditionsR8, PCCF_AdditionsR8_t),
CSN_DESCR_END (PCCF_AdditionsR5_t)
diff --git a/src/gsm_rlcmac.h b/src/gsm_rlcmac.h
index 2ad1937..a4750e8 100644
--- a/src/gsm_rlcmac.h
+++ b/src/gsm_rlcmac.h
@@ -1602,8 +1602,8 @@
typedef struct
{
- guint8 Exist_G_RNTI_extention;
- guint8 G_RNTI_extention;
+ guint8 Exist_G_RNTI_extension;
+ guint8 G_RNTI_extension;
guint8 Exist_AdditionsR8;
PCCF_AdditionsR8_t AdditionsR8;
} PCCF_AdditionsR5_t;
diff --git a/src/pcu_l1_if.cpp b/src/pcu_l1_if.cpp
index bc712fd..da85df4 100644
--- a/src/pcu_l1_if.cpp
+++ b/src/pcu_l1_if.cpp
@@ -650,7 +650,7 @@
rc = pcu_rx_susp_req(_prim->u.susp_req);
break;
default:
- LOGP(DL1IF, LOGL_ERROR, "Received unknwon PCU msg type %d\n",
+ LOGP(DL1IF, LOGL_ERROR, "Received unknown PCU msg type %d\n",
msg_type);
rc = -EINVAL;
}
diff --git a/src/pdch.cpp b/src/pdch.cpp
index 8003105..7488b96 100644
--- a/src/pdch.cpp
+++ b/src/pdch.cpp
@@ -632,7 +632,7 @@
int8_t tfi = request->ID.u.Global_TFI.u.DOWNLINK_TFI;
Change in ...libosmo-abis[master]: spelling
laforge has submitted this change and it was merged. (
https://gerrit.osmocom.org/c/libosmo-abis/+/14800 )
Change subject: spelling
..
spelling
===
Change-Id: I22c98915648760a83abd5f0004af26d426a5e518
---
M src/input/ipa.c
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
laforge: Looks good to me, approved
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/input/ipa.c b/src/input/ipa.c
index 25eeb4a..8aed7b3 100644
--- a/src/input/ipa.c
+++ b/src/input/ipa.c
@@ -272,7 +272,7 @@
ret = link->accept_cb(link, fd);
if (ret < 0) {
LOGP(DLINP, LOGL_ERROR,
-"failed to processs accept()ed new link, "
+"failed to process accept()ed new link, "
"reason=`%s'\n", strerror(-ret));
close(fd);
return ret;
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/14800
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I22c98915648760a83abd5f0004af26d426a5e518
Gerrit-Change-Number: 14800
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in ...libosmo-abis[master]: spelling
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/14800 ) Change subject: spelling .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/14800 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I22c98915648760a83abd5f0004af26d426a5e518 Gerrit-Change-Number: 14800 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Jul 2019 10:55:42 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...libosmocore[master]: MAXPATHLEN set if not defined
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14797 ) Change subject: MAXPATHLEN set if not defined .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14797 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1dce8ace228814b5a7246a00b31309ab9461d266 Gerrit-Change-Number: 14797 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Ruben Undheim Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 17 Jul 2019 10:54:52 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...libosmocore[master]: TIMER constants not on some architectures
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14796 ) Change subject: TIMER constants not on some architectures .. Patch Set 1: Code-Review-1 Historically, we once supported (in form of build-test verification integrated into gerrit) FreeBSD. However, it was causing significant effort to maintain FreeBSD compatibility, while nobody in the active Osmocom developer community is using FreeBSD for their development. Also, we never ever received report from even a single user of Osmocom on FreeBSD. As a result, we decided to drop FreeBSD compatibility and stated we'd re-introduce it if somebody from the user/developer community was willing to actively maintain it and provide related patches. This hasn't happened so far, so I'm against merging the occasional one-off patch which creates the impression of supporting non-Linux platforms while in reality nobody is testing/maintaining it. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14796 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If24616c3dbf9f1eb6053caed90a63b590d3f5833 Gerrit-Change-Number: 14796 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Ruben Undheim Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Jul 2019 10:54:42 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...libosmocore[master]: Set HTML_TIMESTAMP to NO to make build reproducible
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14795 ) Change subject: Set HTML_TIMESTAMP to NO to make build reproducible .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14795 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I56cce5cda0621f5e9f1c28aaad4646e9e267d17d Gerrit-Change-Number: 14795 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Ruben Undheim Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 17 Jul 2019 10:51:21 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-msc[master]: replace osmo_counter with stat_items
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/13802 ) Change subject: replace osmo_counter with stat_items .. Patch Set 11: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/13802 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I6a20123b263f4f808153794ee8a735092deb399e Gerrit-Change-Number: 13802 Gerrit-PatchSet: 11 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Jul 2019 10:50:28 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmocom-bb[master]: target/*.py: shebang: use /usr/bin/env python
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14759 ) Change subject: target/*.py: shebang: use /usr/bin/env python .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14759 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iab185759b574eff1ca1b189dcbb4e1a3eec52132 Gerrit-Change-Number: 14759 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 17 Jul 2019 10:49:45 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-msc[master]: replace osmo_counter with stat_items
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/13802 ) Change subject: replace osmo_counter with stat_items .. Patch Set 11: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/13802 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I6a20123b263f4f808153794ee8a735092deb399e Gerrit-Change-Number: 13802 Gerrit-PatchSet: 11 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Jul 2019 07:02:53 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmocom-bb[master]: target/*.py: shebang: use /usr/bin/env python
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14759 ) Change subject: target/*.py: shebang: use /usr/bin/env python .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14759 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iab185759b574eff1ca1b189dcbb4e1a3eec52132 Gerrit-Change-Number: 14759 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: lynxis lazus Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 17 Jul 2019 06:59:12 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
