Change in ...osmo-bsc[master]: add vty 'no neighbors' to remove all HO targets
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14768 ) Change subject: add vty 'no neighbors' to remove all HO targets .. Patch Set 3: > I am tempted to merge this myself soon, being a low-risk patch, > comments addressed sufficiently (IMHO) and this patch blocking the > neighbor config and ttcn test patches... I did not add any further comments as my original comments remain unmodified. If you merge it like this I will likely send a follow-up patch to use llist iteration helpers. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14768 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I8623ab581639e9f8af6a9ff1eca990518d1b1211 Gerrit-Change-Number: 14768 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Fri, 09 Aug 2019 07:55:30 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in ...osmo-sip-connector[master]: avoid bogus error logs when no cmd_timer is set
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15142 ) Change subject: avoid bogus error logs when no cmd_timer is set .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/15142 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I70f85a71df55ab8618ed78864cefb6fe5b26f581 Gerrit-Change-Number: 15142 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 09 Aug 2019 08:14:55 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-msc[master]: Implement a global switch on the network to disable call waiting.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15120 ) Change subject: Implement a global switch on the network to disable call waiting. .. Patch Set 10: (2 comments) https://gerrit.osmocom.org/#/c/15120/10/src/libmsc/gsm_04_08_cc.c File src/libmsc/gsm_04_08_cc.c: https://gerrit.osmocom.org/#/c/15120/10/src/libmsc/gsm_04_08_cc.c@1893 PS10, Line 1893: = NULL; explicit NULL assignment not needed, as you unconditionally set it to the return value of another function one line below. https://gerrit.osmocom.org/#/c/15120/10/src/libmsc/msc_vty.c File src/libmsc/msc_vty.c: https://gerrit.osmocom.org/#/c/15120/10/src/libmsc/msc_vty.c@296 PS10, Line 296: callwaiting I would suggest 'call-waiting' for better readability -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15120 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3eb6f23f7103e3002874fb5d3a30c9de952202ae Gerrit-Change-Number: 15120 Gerrit-PatchSet: 10 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: neels Gerrit-CC: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Fri, 09 Aug 2019 08:17:44 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in ...simtrace2[master]: Fix builds on Ubuntu 16.04
laforge has submitted this change and it was merged. (
https://gerrit.osmocom.org/c/simtrace2/+/15112 )
Change subject: Fix builds on Ubuntu 16.04
..
Fix builds on Ubuntu 16.04
The most recent commits introduced 'C99' syntax by declaring variables
inside the 'for' statement itself, rather than before.
This resulted in compile failures in the Ubuntu 16.04 builds on
build.opensuse.org:
[ 105s] libcommon/source/usb.c: In function 'SIMtrace_USB_Initialize':
[ 105s] libcommon/source/usb.c:679:2: error: 'for' loop initial declarations
are only allowed in C99 or C11 mode
[ 105s] for (uint8_t i = 0; i < ARRAY_SIZE(device_id_string) - 1; i++) {
[ 105s] ^
[ 105s] libcommon/source/usb.c:679:2: note: use option -std=c99, -std=gnu99,
-std=c11 or -std=gnu11 to compile your code
[ 105s] libcommon/source/usb.c:686:15: error: redefinition of 'i'
[ 105s] for (uint8_t i = 0; i < ARRAY_SIZE(git_version) - 1; i++) {
[ 105s]^
[ 105s] libcommon/source/usb.c:679:15: note: previous definition of 'i' was
here
[ 105s] for (uint8_t i = 0; i < ARRAY_SIZE(device_id_string) - 1; i++) {
[ 105s]^
[ 105s] libcommon/source/usb.c:686:2: error: 'for' loop initial declarations
are only allowed in C99 or C11 mode
[ 105s] for (uint8_t i = 0; i < ARRAY_SIZE(git_version) - 1; i++) {
[ 105s] ^
[ 105s] libcommon/source/usb.c:692:15: error: redefinition of 'i'
[ 105s] for (uint8_t i = 0; i < ARRAY_SIZE(usb_strings) && i <
ARRAY_SIZE(usb_strings_extended); i++) {
[ 105s]^
[ 105s] libcommon/source/usb.c:686:15: note: previous definition of 'i' was
here
[ 105s] for (uint8_t i = 0; i < ARRAY_SIZE(git_version) - 1; i++) {
[ 105s]^
[ 105s] libcommon/source/usb.c:692:2: error: 'for' loop initial declarations
are only allowed in C99 or C11 mode
[ 105s] for (uint8_t i = 0; i < ARRAY_SIZE(usb_strings) && i <
ARRAY_SIZE(usb_strings_extended); i++) {
[ 105s] ^
[ 105s] Makefile:227: recipe for target 'obj/simtrace/flash_usb.o' faile
Change-Id: Ibdb837ac105664484b10873c2c0d9561051b1c2a
---
M firmware/libcommon/source/usb.c
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, approved
diff --git a/firmware/libcommon/source/usb.c b/firmware/libcommon/source/usb.c
index 3efb9fc..9d3072f 100644
--- a/firmware/libcommon/source/usb.c
+++ b/firmware/libcommon/source/usb.c
@@ -653,7 +653,7 @@
void SIMtrace_USB_Initialize(void)
{
-
+ unsigned int i;
/* Signal USB reset by disabling the pull-up on USB D+ for at least 10
ms */
#ifdef PIN_USB_PULLUP
const Pin usb_dp_pullup = PIN_USB_PULLUP;
@@ -676,20 +676,20 @@
char device_id_string[32 + 1];
snprintf(device_id_string, ARRAY_SIZE(device_id_string),
"%08x%08x%08x%08x",
device_id[0], device_id[1], device_id[2], device_id[3]);
- for (uint8_t i = 0; i < ARRAY_SIZE(device_id_string) - 1; i++) {
+ for (i = 0; i < ARRAY_SIZE(device_id_string) - 1; i++) {
usb_string_serial[2 + 2 * i] = device_id_string[i];
}
// put version into USB string
usb_string_version[0] =
USBStringDescriptor_LENGTH(ARRAY_SIZE(git_version) - 1);
usb_string_version[1] = USBGenericDescriptor_STRING;
- for (uint8_t i = 0; i < ARRAY_SIZE(git_version) - 1; i++) {
+ for (i = 0; i < ARRAY_SIZE(git_version) - 1; i++) {
usb_string_version[2 + i * 2 + 0] = git_version[i];
usb_string_version[2 + i * 2 + 1] = 0;
}
// fill extended USB strings
- for (uint8_t i = 0; i < ARRAY_SIZE(usb_strings) && i <
ARRAY_SIZE(usb_strings_extended); i++) {
+ for (i = 0; i < ARRAY_SIZE(usb_strings) && i <
ARRAY_SIZE(usb_strings_extended); i++) {
usb_strings_extended[i] = usb_strings[i];
}
usb_strings_extended[SERIAL_STR] = usb_string_serial;
--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/15112
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: Ibdb837ac105664484b10873c2c0d9561051b1c2a
Gerrit-Change-Number: 15112
Gerrit-PatchSet: 1
Gerrit-Owner: laforge
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in ...libosmocore[master]: osmo-release.sh: Support releasing openbsc.git
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15127 ) Change subject: osmo-release.sh: Support releasing openbsc.git .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15127 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I407cf47d8339d99c74a976460ea84fffe679dfd8 Gerrit-Change-Number: 15127 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: neels Gerrit-Comment-Date: Fri, 09 Aug 2019 08:18:25 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-mgw[master]: mgcp_codec: constify 'param' arg
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15131 ) Change subject: mgcp_codec: constify 'param' arg .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/15131 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I3ec6b57298f78604d5cd453f1db6d90ddfd6a2ba Gerrit-Change-Number: 15131 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 09 Aug 2019 08:19:01 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-mgw[master]: rename codecs_cmp() to codecs_same()
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15130 ) Change subject: rename codecs_cmp() to codecs_same() .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/15130 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I2d41b1a32300e295551e85d3f9ab82dd2b0e86b8 Gerrit-Change-Number: 15130 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 09 Aug 2019 08:20:02 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-mgw[master]: mgcp_codec: split codec_free() off of codec_init()
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15132 ) Change subject: mgcp_codec: split codec_free() off of codec_init() .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/15132 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I120cab0a352a1e7b31c8f9c720c47b2c291311d7 Gerrit-Change-Number: 15132 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 09 Aug 2019 08:19:32 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-mgw[master]: fix memleak: actually free strings in mgcp_codec_reset_all()
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15133 ) Change subject: fix memleak: actually free strings in mgcp_codec_reset_all() .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/15133 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I07f207dcb7ce66bbf3445a30af41e696677b384f Gerrit-Change-Number: 15133 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 09 Aug 2019 08:20:34 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-mgw[master]: differentiate AMR octet-aligned=0 vs =1
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15136 ) Change subject: differentiate AMR octet-aligned=0 vs =1 .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/15136 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ib8be73a7ca1b95ce794d130e8eb206dcee700124 Gerrit-Change-Number: 15136 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 09 Aug 2019 08:20:58 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-mgw[master]: SDP: store all ptmap entries
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15141 ) Change subject: SDP: store all ptmap entries .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/15141 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I2a69c21e68c602daf804744212d335ab1eafd81b Gerrit-Change-Number: 15141 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 09 Aug 2019 08:21:31 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-mgw[master]: ptmap: implicitly match '/8000' and '/8000/1'
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15137 ) Change subject: ptmap: implicitly match '/8000' and '/8000/1' .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/15137 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Iab00bf9a55b1847f85999077114b37e70fb677c2 Gerrit-Change-Number: 15137 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 09 Aug 2019 08:22:20 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-sip-connector[master]: coverity: Address issue found by coverity
keith has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-sip-connector/+/15143
Change subject: coverity: Address issue found by coverity
..
coverity: Address issue found by coverity
Add NULL checks on the return value of call_leg_other() in
update_rtp()
If the remote side has requested media change and we cannot
find the other leg, then release call. This should not
happen.
Also, Add an assert to show that we cannot be here
without call type of SIP or MNCC (not related to coverity)
Change-Id: I6f1f26533a25c93f243090bc02f1bc83b9108d42
---
M src/mncc.c
1 file changed, 13 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector
refs/changes/43/15143/1
diff --git a/src/mncc.c b/src/mncc.c
index f5a44d5..7919c9b 100644
--- a/src/mncc.c
+++ b/src/mncc.c
@@ -211,10 +211,22 @@
if (_leg->type == CALL_TYPE_MNCC) {
leg = (struct mncc_call_leg *) _leg;
struct call_leg *other = call_leg_other(&leg->base);
+ if (!other) {
+ LOGP(DMNCC, LOGL_ERROR, "Failed to find other leg.");
+ _leg->release_call(_leg);
+ return;
+ }
send_rtp_connect(leg, other);
- } else {
+ } else if (_leg->type == CALL_TYPE_SIP) {
leg = (struct mncc_call_leg *) call_leg_other(_leg);
+ if (!leg) {
+ LOGP(DMNCC, LOGL_ERROR, "Failed to find other leg.");
+ _leg->release_call(_leg);
+ return;
+ }
send_rtp_connect(leg, _leg);
+ } else {
+ OSMO_ASSERT(false);
}
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/15143
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: I6f1f26533a25c93f243090bc02f1bc83b9108d42
Gerrit-Change-Number: 15143
Gerrit-PatchSet: 1
Gerrit-Owner: keith
Gerrit-MessageType: newchange
Change in ...osmo-mgw[master]: rename codecs_cmp() to codecs_same()
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15130 ) Change subject: rename codecs_cmp() to codecs_same() .. Patch Set 1: Code-Review+2 (1 comment) https://gerrit.osmocom.org/#/c/15130/1/src/libosmo-mgcp/mgcp_codec.c File src/libosmo-mgcp/mgcp_codec.c: https://gerrit.osmocom.org/#/c/15130/1/src/libosmo-mgcp/mgcp_codec.c@355 PS1, Line 355: static bool codecs_same(struct mgcp_rtp_codec *codec_a, struct mgcp_rtp_codec *codec_b) Probably a better term here would be "codecs_equal", but it's fine this way too. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/15130 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I2d41b1a32300e295551e85d3f9ab82dd2b0e86b8 Gerrit-Change-Number: 15130 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 09 Aug 2019 10:17:27 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-mgw[master]: mgcp_codec: constify 'param' arg
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15131 ) Change subject: mgcp_codec: constify 'param' arg .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/15131 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I3ec6b57298f78604d5cd453f1db6d90ddfd6a2ba Gerrit-Change-Number: 15131 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 09 Aug 2019 10:17:42 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-mgw[master]: mgcp_codec: split codec_free() off of codec_init()
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-mgw/+/15132 )
Change subject: mgcp_codec: split codec_free() off of codec_init()
..
Patch Set 1: Code-Review-1
(2 comments)
https://gerrit.osmocom.org/#/c/15132/1/src/libosmo-mgcp/mgcp_codec.c
File src/libosmo-mgcp/mgcp_codec.c:
https://gerrit.osmocom.org/#/c/15132/1/src/libosmo-mgcp/mgcp_codec.c@117
PS1, Line 117: codec_init(codec);
So in here you are not longer freeing codec->subtype_name and
codec->audio_name. Are you sure that's fine?
https://gerrit.osmocom.org/#/c/15132/1/src/libosmo-mgcp/mgcp_codec.c@239
PS1, Line 239: memset(codec, 0, sizeof(*codec));
You can either drop this memset or line 96: "*codec = (struct
mgcp_rtp_codec){};"
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/15132
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I120cab0a352a1e7b31c8f9c720c47b2c291311d7
Gerrit-Change-Number: 15132
Gerrit-PatchSet: 1
Gerrit-Owner: neels
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-Comment-Date: Fri, 09 Aug 2019 10:22:09 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Change in ...osmo-mgw[master]: mgcp_test: extend / rewrite test_mgcp_codec_pt_translate()
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15134 ) Change subject: mgcp_test: extend / rewrite test_mgcp_codec_pt_translate() .. Patch Set 1: Test output need update. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/15134 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I888000d77512cfecb0f199b86ef6003e7fc0e6cb Gerrit-Change-Number: 15134 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Fri, 09 Aug 2019 10:25:05 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in ...osmo-mgw[master]: fix memleak: actually free strings in mgcp_codec_reset_all()
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15133 ) Change subject: fix memleak: actually free strings in mgcp_codec_reset_all() .. Patch Set 1: Code-Review+1 Comment from previous commit. Since you use codec_free() here, then remove the memset(0) from the previous commit. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/15133 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I07f207dcb7ce66bbf3445a30af41e696677b384f Gerrit-Change-Number: 15133 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 09 Aug 2019 10:24:38 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-sip-connector[master]: coverity: Address issue found by coverity
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15143 ) Change subject: coverity: Address issue found by coverity .. Patch Set 1: Code-Review-1 (3 comments) https://gerrit.osmocom.org/#/c/15143/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/15143/1//COMMIT_MSG@19 PS1, Line 19: Change-Id: I6f1f26533a25c93f243090bc02f1bc83b9108d42 Please add "Fixes: CID#202863" after this line (or before, as you like), so we can see which issue to be fixed by this commit. https://gerrit.osmocom.org/#/c/15143/1/src/mncc.c File src/mncc.c: https://gerrit.osmocom.org/#/c/15143/1/src/mncc.c@215 PS1, Line 215: ." New line is missing. https://gerrit.osmocom.org/#/c/15143/1/src/mncc.c@223 PS1, Line 223: ." New line is missing. -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/15143 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I6f1f26533a25c93f243090bc02f1bc83b9108d42 Gerrit-Change-Number: 15143 Gerrit-PatchSet: 1 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Fri, 09 Aug 2019 10:24:48 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-msc[master]: Implement a global switch on the network to disable call waiting.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15120 ) Change subject: Implement a global switch on the network to disable call waiting. .. Patch Set 10: (1 comment) https://gerrit.osmocom.org/#/c/15120/10/src/libmsc/msc_vty.c File src/libmsc/msc_vty.c: https://gerrit.osmocom.org/#/c/15120/10/src/libmsc/msc_vty.c@296 PS10, Line 296: callwaiting > I would suggest 'call-waiting' for better readability Agree -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15120 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3eb6f23f7103e3002874fb5d3a30c9de952202ae Gerrit-Change-Number: 15120 Gerrit-PatchSet: 10 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: neels Gerrit-CC: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Fri, 09 Aug 2019 10:25:51 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Gerrit-MessageType: comment
Change in ...osmocom-bb[master]: fb_tools/bdf_to_c.py: make it compatible with python3
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14758 ) Change subject: fb_tools/bdf_to_c.py: make it compatible with python3 .. Patch Set 4: BTW: true Pythonic way would be to use the logging module ;) Anyway, feel free to merge. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14758 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iaa20dd0aafa20e36186cf8dfe4d0ac9ab638f235 Gerrit-Change-Number: 14758 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 09 Aug 2019 10:26:36 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in ...meta-telephony[201705]: Update Osmocom recipes to latest tags (release 201908)
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/meta-telephony/+/15144
Change subject: Update Osmocom recipes to latest tags (release 201908)
..
Update Osmocom recipes to latest tags (release 201908)
Change-Id: I1b06cbd9998660951d33a011726d86ae288fc7b9
---
M recipes-misc/libsmpp/libsmpp34_git.bb
M recipes-osmocom/libasn1c/libasn1c_git.bb
M recipes-osmocom/libosmo-abis/libosmo-abis_git.bb
M recipes-osmocom/libosmo-netif/libosmo-netif_git.bb
M recipes-osmocom/libosmo-sccp/libosmo-sccp_git.bb
M recipes-osmocom/libosmocore/libosmocore_git.bb
M recipes-osmocom/openbsc/openbsc_git.bb
M recipes-osmocom/osmo-bsc/osmo-bsc_git.bb
M recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb
M recipes-osmocom/osmo-hlr/osmo-hlr_git.bb
M recipes-osmocom/osmo-iuh/osmo-iuh_git.bb
M recipes-osmocom/osmo-mgw/osmo-mgw_git.bb
M recipes-osmocom/osmo-msc/osmo-msc_git.bb
M recipes-osmocom/osmo-pcap/osmo-pcap_git.bb
M recipes-osmocom/osmo-sgsn/osmo-sgsn_git.bb
M recipes-osmocom/osmo-sip-connector/osmo-sip-connector_git.bb
M recipes-osmocom/osmo-sysmon/osmo-sysmon_git.bb
17 files changed, 34 insertions(+), 34 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/44/15144/1
diff --git a/recipes-misc/libsmpp/libsmpp34_git.bb
b/recipes-misc/libsmpp/libsmpp34_git.bb
index e04e525..9da4f54 100644
--- a/recipes-misc/libsmpp/libsmpp34_git.bb
+++ b/recipes-misc/libsmpp/libsmpp34_git.bb
@@ -6,9 +6,9 @@
DEPENDS = "libxml2"
S = "${WORKDIR}/git"
-SRCREV = "6996e5dba9603208609f4604a3b3d59f88c85d90"
+SRCREV = "d2704da4cb3efdf241d2cde037688badaef53f9a"
SRC_URI = "git://git.osmocom.org/libsmpp34.git;protocol=git"
-PV = "1.13.0+gitr${SRCPV}"
+PV = "1.14.0+gitr${SRCPV}"
PR = "r0"
PARALLEL_MAKE = ""
diff --git a/recipes-osmocom/libasn1c/libasn1c_git.bb
b/recipes-osmocom/libasn1c/libasn1c_git.bb
index 9d4fa87..879a22f 100644
--- a/recipes-osmocom/libasn1c/libasn1c_git.bb
+++ b/recipes-osmocom/libasn1c/libasn1c_git.bb
@@ -1,7 +1,7 @@
require ${PN}.inc
S = "${WORKDIR}/git"
-SRCREV = "d36012fb029fd9914b4e8125c9c3186785940258"
+SRCREV = "19205a38c34175f4fb4d1d06e77f1d3e4a39c651"
SRC_URI = "git://git.osmocom.org/libasn1c.git;protocol=git"
-PV = "0.9.31+gitr${SRCPV}"
+PV = "0.9.32+gitr${SRCPV}"
PR = "${INC_PR}.0"
diff --git a/recipes-osmocom/libosmo-abis/libosmo-abis_git.bb
b/recipes-osmocom/libosmo-abis/libosmo-abis_git.bb
index 3032d28..e64ace2 100644
--- a/recipes-osmocom/libosmo-abis/libosmo-abis_git.bb
+++ b/recipes-osmocom/libosmo-abis/libosmo-abis_git.bb
@@ -1,7 +1,7 @@
require ${PN}.inc
S = "${WORKDIR}/git"
-SRCREV = "176a1fbab6ae45eb1c60e3d8b263b0765759e1da"
+SRCREV = "30249a15d51a15b498e87b78bd3fc8d684ffcf46"
SRC_URI = "git://git.osmocom.org/libosmo-abis.git;protocol=git"
-PV = "0.6.0+gitr${SRCPV}"
+PV = "0.7.0+gitr${SRCPV}"
PR = "${INC_PR}.0"
diff --git a/recipes-osmocom/libosmo-netif/libosmo-netif_git.bb
b/recipes-osmocom/libosmo-netif/libosmo-netif_git.bb
index 73c6314..23a0148 100644
--- a/recipes-osmocom/libosmo-netif/libosmo-netif_git.bb
+++ b/recipes-osmocom/libosmo-netif/libosmo-netif_git.bb
@@ -1,7 +1,7 @@
require ${PN}.inc
S = "${WORKDIR}/git"
-SRCREV = "c775ffe1cc6cfd842566d30c96d287502d9d6218"
+SRCREV = "592057bb33dc0c336a63003cd7a3a67944d92757"
SRC_URI = "git://git.osmocom.org/libosmo-netif.git;protocol=git"
-PV = "0.4.0+gitr${SRCPV}"
+PV = "0.6.0+gitr${SRCPV}"
PR = "${INC_PR}.0"
diff --git a/recipes-osmocom/libosmo-sccp/libosmo-sccp_git.bb
b/recipes-osmocom/libosmo-sccp/libosmo-sccp_git.bb
index 6bdea27..6204aab 100644
--- a/recipes-osmocom/libosmo-sccp/libosmo-sccp_git.bb
+++ b/recipes-osmocom/libosmo-sccp/libosmo-sccp_git.bb
@@ -1,7 +1,7 @@
require ${PN}.inc
S = "${WORKDIR}/git"
-SRCREV = "81c6a0a97980f9da76ef0e698ca6ab526b98c7c2"
+SRCREV = "0b7ad1a72fae2a4547bf0d1d6430918a74ea577b"
SRC_URI = "git://git.osmocom.org/libosmo-sccp.git;protocol=git"
-PV = "1.0.0+gitr${SRCPV}"
+PV = "1.1.0+gitr${SRCPV}"
PR = "${INC_PR}.0"
diff --git a/recipes-osmocom/libosmocore/libosmocore_git.bb
b/recipes-osmocom/libosmocore/libosmocore_git.bb
index 8eca57f..06e9796 100644
--- a/recipes-osmocom/libosmocore/libosmocore_git.bb
+++ b/recipes-osmocom/libosmocore/libosmocore_git.bb
@@ -1,9 +1,9 @@
require ${PN}.inc
S = "${WORKDIR}/git"
-SRCREV = "d4c406a04eae0071da4fb7aecd3cb47acd0fdab6"
+SRCREV = "c996d652f974f803653ce66d27d60675c1f77c2e"
SRC_URI = "git://git.osmocom.org/libosmocore.git;protocol=git;nobranch=1"
-PV = "1.0.1+gitr${SRCPV}"
+PV = "1.2.0+gitr${SRCPV}"
PR = "${INC_PR}.0"
PACKAGES =+ "libosmoctrl libosmocodec libosmogb libosmogsm libosmovty
osmo-arfcn osmo-auc-gen"
diff --git a/recipes-osmocom/openbsc/openbsc_git.bb
b/recipes-osmocom/openbsc/openbsc_git.bb
index 7dbb07a..c9b75e8 100644
--- a/recipes-osmocom/openbsc/openbsc_git.bb
+++ b/recipes-osmocom/openbsc/openbsc_git.bb
@@ -1,10 +1,10 @@
require ${PN}.inc
-PV = "1.2.0+gitr${SRCPV}"
+PV = "1.3.1+gitr${SRCPV}"
PRINC = "0"
PR = "${I
Change in ...osmo-sip-connector[master]: coverity: Address issue found by coverity
Hello fixeria, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/15143 to look at the new patch set (#2). Change subject: coverity: Address issue found by coverity .. coverity: Address issue found by coverity Add NULL checks on the return value of call_leg_other() in update_rtp() If the remote side has requested media change and we cannot find the other leg, then release call. This should not happen. Also, Add an assert to show that we cannot be here without call type of SIP or MNCC (not related to coverity) Fixes: CID#202863 Change-Id: I6f1f26533a25c93f243090bc02f1bc83b9108d42 --- M src/mncc.c 1 file changed, 13 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector refs/changes/43/15143/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/15143 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I6f1f26533a25c93f243090bc02f1bc83b9108d42 Gerrit-Change-Number: 15143 Gerrit-PatchSet: 2 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-MessageType: newpatchset
Change in ...osmo-msc[master]: Implement a global switch on the network to disable call waiting.
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15120 ) Change subject: Implement a global switch on the network to disable call waiting. .. Patch Set 10: (1 comment) https://gerrit.osmocom.org/#/c/15120/10/src/libmsc/gsm_04_08_cc.c File src/libmsc/gsm_04_08_cc.c: https://gerrit.osmocom.org/#/c/15120/10/src/libmsc/gsm_04_08_cc.c@1893 PS10, Line 1893: = NULL; > explicit NULL assignment not needed, as you unconditionally set it to the > return value of another fu […] I wondered...s hould it just be one line then? declare and assign at the same time: struct gsm_trans *existing_cc_trans = trans_find_by_type(msc_a, TRANS_CC); -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15120 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3eb6f23f7103e3002874fb5d3a30c9de952202ae Gerrit-Change-Number: 15120 Gerrit-PatchSet: 10 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: neels Gerrit-CC: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Fri, 09 Aug 2019 10:35:23 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Gerrit-MessageType: comment
Change in ...osmo-msc[master]: Implement a global switch on the network to disable call waiting.
Hello neels, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/15120 to look at the new patch set (#11). Change subject: Implement a global switch on the network to disable call waiting. .. Implement a global switch on the network to disable call waiting. Add a network -> callwaiting VTY command as boolean. When this is enabled (default) there is no change to operation previous to this commit. When this switch is disabled with "no callwaiting" in vty then when a call arrives, we will check if we have an active call transaction for this subscriber, no matter if it is establishing, established, or alerting, in any of these cases we will return USER BUSY to the calling party. Change-Id: I3eb6f23f7103e3002874fb5d3a30c9de952202ae --- M include/osmocom/msc/gsm_data.h M src/libmsc/gsm_04_08_cc.c M src/libmsc/msc_vty.c M src/osmo-msc/msc_main.c M tests/test_nodes.vty 5 files changed, 53 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/20/15120/11 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15120 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3eb6f23f7103e3002874fb5d3a30c9de952202ae Gerrit-Change-Number: 15120 Gerrit-PatchSet: 11 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: neels Gerrit-CC: laforge Gerrit-CC: pespin Gerrit-MessageType: newpatchset
Change in ...meta-telephony[201705]: libosmocore: Disable TLS workaround to avoid ld crash
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/meta-telephony/+/15146 Change subject: libosmocore: Disable TLS workaround to avoid ld crash .. libosmocore: Disable TLS workaround to avoid ld crash Change-Id: I8d2bfa7ed44d1d2a7fb024ac49bc81cdbf38675d --- M recipes-osmocom/libosmocore/libosmocore_git.bb 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/46/15146/1 diff --git a/recipes-osmocom/libosmocore/libosmocore_git.bb b/recipes-osmocom/libosmocore/libosmocore_git.bb index 06e9796..3a417f0 100644 --- a/recipes-osmocom/libosmocore/libosmocore_git.bb +++ b/recipes-osmocom/libosmocore/libosmocore_git.bb @@ -24,3 +24,15 @@ RREPLACES_libosmovty = "DONOTREPLACElibosmocore" EXTRA_OECONF += "--disable-pcsc" + +# OS#4062: Some gcc version (< 7.3.0) on ARM generate wrong code for __thread +# variables that crash at runtime. It seems, due to some unknown reason, that we +# are not affected by this bug with toolchain from poky pyro (6.4.0). However, +# libosmocore as of e188b8cd98f599468fbb200c7d590de955daf761 applies some +# CFLAGS="-mtls-dialect=gnu2" to workaround the issue automatically. But same +# toolchain contains an "ld" that crashes when those flags are applied. +# Fortunately, libosmocore provides a way to disable the workaround, and since +# we are not affected by the bug, we are fine with that. If the toolchain had +# the TLS runtime bug, then we'd had to build with -O0. Can be probably dropped +# once we move to newer toolchain. +EXTRA_OECONF += "--disable-detect-tls-gcc-arm-bug" -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/15146 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: 201705 Gerrit-Change-Id: I8d2bfa7ed44d1d2a7fb024ac49bc81cdbf38675d Gerrit-Change-Number: 15146 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange
Change in ...meta-telephony[201705]: Add libosmo-netif to osmo-sysmon dependencies
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/meta-telephony/+/15145
Change subject: Add libosmo-netif to osmo-sysmon dependencies
..
Add libosmo-netif to osmo-sysmon dependencies
This is in preparation for upcoming patch related to OpenVPN probe [1].
[1] change-id I4493e19b9a09dcebd289457eacd1719f7f8cc31c (osmo-sysmon)
Change-Id: I8532e9b0391bc3489cd9b53caced9f5bf0d3581f
---
M recipes-osmocom/osmo-sysmon/osmo-sysmon.inc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/45/15145/1
diff --git a/recipes-osmocom/osmo-sysmon/osmo-sysmon.inc
b/recipes-osmocom/osmo-sysmon/osmo-sysmon.inc
index 1469438..aab52bc 100644
--- a/recipes-osmocom/osmo-sysmon/osmo-sysmon.inc
+++ b/recipes-osmocom/osmo-sysmon/osmo-sysmon.inc
@@ -3,7 +3,7 @@
LICENSE = "GPLv2+"
LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
-DEPENDS = "libtalloc libosmocore libmnl liboping"
+DEPENDS = "libtalloc libosmocore libosmo-netif libmnl liboping"
INC_PR="r0.${META_TELEPHONY_OSMO_INC}"
--
To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/15145
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Gerrit-Change-Id: I8532e9b0391bc3489cd9b53caced9f5bf0d3581f
Gerrit-Change-Number: 15145
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
Gerrit-MessageType: newchange
Change in ...osmo-msc[master]: Implement a global switch on the network to disable call waiting.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15120 ) Change subject: Implement a global switch on the network to disable call waiting. .. Patch Set 11: (1 comment) https://gerrit.osmocom.org/#/c/15120/10/src/libmsc/gsm_04_08_cc.c File src/libmsc/gsm_04_08_cc.c: https://gerrit.osmocom.org/#/c/15120/10/src/libmsc/gsm_04_08_cc.c@1893 PS10, Line 1893: = NULL; > I wondered...s hould it just be one line then? […] That's fine. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15120 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3eb6f23f7103e3002874fb5d3a30c9de952202ae Gerrit-Change-Number: 15120 Gerrit-PatchSet: 11 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: neels Gerrit-CC: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Fri, 09 Aug 2019 10:44:07 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: keith Comment-In-Reply-To: laforge Gerrit-MessageType: comment
Change in ...osmo-msc[master]: Implement a global switch on the network to disable call waiting.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15120 ) Change subject: Implement a global switch on the network to disable call waiting. .. Patch Set 11: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/15120/11//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/15120/11//COMMIT_MSG@14 PS11, Line 14: When this switch is disabled with "no callwaiting" in vty You forgot to update the description: "no call-waiting" -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15120 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3eb6f23f7103e3002874fb5d3a30c9de952202ae Gerrit-Change-Number: 15120 Gerrit-PatchSet: 11 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Fri, 09 Aug 2019 10:46:34 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-sip-connector[master]: coverity: Address issue found by coverity
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-sip-connector/+/15143 )
Change subject: coverity: Address issue found by coverity
..
Patch Set 2:
(3 comments)
https://gerrit.osmocom.org/#/c/15143/2/src/mncc.c
File src/mncc.c:
https://gerrit.osmocom.org/#/c/15143/2/src/mncc.c@214
PS2, Line 214: if (!other) {
if (!other)
goto ret_release;
https://gerrit.osmocom.org/#/c/15143/2/src/mncc.c@222
PS2, Line 222: if (!leg) {
if (!leg)
goto ret_release;
https://gerrit.osmocom.org/#/c/15143/2/src/mncc.c@230
PS2, Line 230: }
return;
ret_release:
LOGP(DMNCC, LOGL_ERROR, "Failed to find other leg.\n");
_leg->release_call(_leg);
--
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/15143
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: I6f1f26533a25c93f243090bc02f1bc83b9108d42
Gerrit-Change-Number: 15143
Gerrit-PatchSet: 2
Gerrit-Owner: keith
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-CC: pespin
Gerrit-Comment-Date: Fri, 09 Aug 2019 10:51:12 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Change in ...meta-telephony[201705]: Update Osmocom recipes to latest tags (release 201908)
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/15144 ) Change subject: Update Osmocom recipes to latest tags (release 201908) .. Patch Set 1: The 3 commit shsould be merged together. I have branch laforge/nightly rebase prepared locally, I'll push it once these are merged. -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/15144 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: 201705 Gerrit-Change-Id: I1b06cbd9998660951d33a011726d86ae288fc7b9 Gerrit-Change-Number: 15144 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: daniel Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 09 Aug 2019 10:52:21 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in ...osmo-msc[master]: Implement a global switch on the network to disable call waiting.
Hello pespin, neels, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/15120 to look at the new patch set (#12). Change subject: Implement a global switch on the network to disable call waiting. .. Implement a global switch on the network to disable call waiting. Add a network -> callwaiting VTY command as boolean. When this is enabled (default) there is no change to operation previous to this commit. When this switch is disabled with "no call-waiting" in vty then when a call arrives, we will check if we have an active call transaction for this subscriber, no matter if it is establishing, established, or alerting, in any of these cases we will return USER BUSY to the calling party. Change-Id: I3eb6f23f7103e3002874fb5d3a30c9de952202ae --- M include/osmocom/msc/gsm_data.h M src/libmsc/gsm_04_08_cc.c M src/libmsc/msc_vty.c M src/osmo-msc/msc_main.c M tests/test_nodes.vty 5 files changed, 53 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/20/15120/12 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15120 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3eb6f23f7103e3002874fb5d3a30c9de952202ae Gerrit-Change-Number: 15120 Gerrit-PatchSet: 12 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-MessageType: newpatchset
Change in ...meta-telephony[201705]: Update Osmocom recipes to latest tags (release 201908)
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/15144 ) Change subject: Update Osmocom recipes to latest tags (release 201908) .. Patch Set 1: I'll push patches for meta-sysmocom-bsp once the patches are merged, otherwise I may break latest build (due to dependencies fro mmeta-telephony missing). -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/15144 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: 201705 Gerrit-Change-Id: I1b06cbd9998660951d33a011726d86ae288fc7b9 Gerrit-Change-Number: 15144 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: daniel Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 09 Aug 2019 10:53:18 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in ...osmo-sip-connector[master]: coverity: Address issue found by coverity
Hello fixeria, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/15143 to look at the new patch set (#3). Change subject: coverity: Address issue found by coverity .. coverity: Address issue found by coverity Add NULL checks on the return value of call_leg_other() in update_rtp() If the remote side has requested media change and we cannot find the other leg, then release call. This should not happen. Also, Add an assert to show that we cannot be here without call type of SIP or MNCC (not related to coverity) Fixes: CID#202863 Change-Id: I6f1f26533a25c93f243090bc02f1bc83b9108d42 --- M src/mncc.c 1 file changed, 12 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector refs/changes/43/15143/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/15143 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I6f1f26533a25c93f243090bc02f1bc83b9108d42 Gerrit-Change-Number: 15143 Gerrit-PatchSet: 3 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-CC: pespin Gerrit-MessageType: newpatchset
Change in ...osmo-sip-connector[master]: coverity: Address issue found by coverity
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15143 ) Change subject: coverity: Address issue found by coverity .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/15143/3/src/mncc.c File src/mncc.c: https://gerrit.osmocom.org/#/c/15143/3/src/mncc.c@227 PS3, Line 227: ret_release: i see this usually at COL 0, correct? -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/15143 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I6f1f26533a25c93f243090bc02f1bc83b9108d42 Gerrit-Change-Number: 15143 Gerrit-PatchSet: 3 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: keith Gerrit-CC: pespin Gerrit-Comment-Date: Fri, 09 Aug 2019 10:58:56 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in ...osmo-sip-connector[master]: coverity: Address issue found by coverity
keith has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-sip-connector/+/15143 )
Change subject: coverity: Address issue found by coverity
..
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/#/c/15143/3/src/mncc.c
File src/mncc.c:
https://gerrit.osmocom.org/#/c/15143/3/src/mncc.c@219
PS3, Line 219: if (!leg) {
gah..
--
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/15143
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: I6f1f26533a25c93f243090bc02f1bc83b9108d42
Gerrit-Change-Number: 15143
Gerrit-PatchSet: 3
Gerrit-Owner: keith
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: keith
Gerrit-CC: pespin
Gerrit-Comment-Date: Fri, 09 Aug 2019 10:59:37 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Change in ...osmo-sip-connector[master]: coverity: Address issue found by coverity
Hello fixeria, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/15143 to look at the new patch set (#4). Change subject: coverity: Address issue found by coverity .. coverity: Address issue found by coverity Add NULL checks on the return value of call_leg_other() in update_rtp() If the remote side has requested media change and we cannot find the other leg, then release call. This should not happen. Also, Add an assert to show that we cannot be here without call type of SIP or MNCC (not related to coverity) Fixes: CID#202863 Change-Id: I6f1f26533a25c93f243090bc02f1bc83b9108d42 --- M src/mncc.c 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector refs/changes/43/15143/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/15143 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I6f1f26533a25c93f243090bc02f1bc83b9108d42 Gerrit-Change-Number: 15143 Gerrit-PatchSet: 4 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: keith Gerrit-CC: pespin Gerrit-MessageType: newpatchset
Change in ...osmo-msc[master]: Implement a global switch on the network to disable call waiting.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15120 ) Change subject: Implement a global switch on the network to disable call waiting. .. Patch Set 12: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15120 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3eb6f23f7103e3002874fb5d3a30c9de952202ae Gerrit-Change-Number: 15120 Gerrit-PatchSet: 12 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Fri, 09 Aug 2019 11:00:52 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-sip-connector[master]: coverity: Address issue found by coverity
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15143 ) Change subject: coverity: Address issue found by coverity .. Patch Set 4: (1 comment) https://gerrit.osmocom.org/#/c/15143/3/src/mncc.c File src/mncc.c: https://gerrit.osmocom.org/#/c/15143/3/src/mncc.c@227 PS3, Line 227: ret_release: > i see this usually at COL 0, correct? Yes -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/15143 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I6f1f26533a25c93f243090bc02f1bc83b9108d42 Gerrit-Change-Number: 15143 Gerrit-PatchSet: 4 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: keith Gerrit-CC: pespin Gerrit-Comment-Date: Fri, 09 Aug 2019 11:01:35 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: keith Gerrit-MessageType: comment
Change in ...osmo-mgw[master]: differentiate AMR octet-aligned=0 vs =1
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15136 ) Change subject: differentiate AMR octet-aligned=0 vs =1 .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/15136 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ib8be73a7ca1b95ce794d130e8eb206dcee700124 Gerrit-Change-Number: 15136 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 09 Aug 2019 11:05:30 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-sip-connector[master]: coverity: Address issue found by coverity
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-sip-connector/+/15143 )
Change subject: coverity: Address issue found by coverity
..
Patch Set 4:
(2 comments)
https://gerrit.osmocom.org/#/c/15143/4/src/mncc.c
File src/mncc.c:
https://gerrit.osmocom.org/#/c/15143/4/src/mncc.c@205
PS4, Line 205: static void update_rtp(struct call_leg *_leg) {
No need to change it now, but this function would be a lot simpler by using a
switch:
static void update_rtp(struct call_leg *_leg) {
struct mncc_call_leg *leg;
LOGP(DMNCC, LOGL_DEBUG, "UPDATE RTP for LEG Type (%u)\n", _leg->type);
switch (_leg->type) {
case: CALL_TYPE_MNCC:
leg = (struct mncc_call_leg *) _leg;
struct call_leg *other = call_leg_other(&leg->base);
if (!other)
goto ret_release;
break;
case CALL_TYPE_SIP:
leg = (struct mncc_call_leg *) call_leg_other(_leg);
if (!leg)
goto ret_release;
break;
default:
OSMO_ASSERT(false);
}
send_rtp_connect(leg, other);
return;
ret_release:
LOGP(DMNCC, LOGL_ERROR, "Failed to find other leg.\n");
_leg->release_call(_leg);
}
https://gerrit.osmocom.org/#/c/15143/4/src/mncc.c@228
PS4, Line 228: _leg->release_call(_leg);
Wrong indentation here.
--
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/15143
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: I6f1f26533a25c93f243090bc02f1bc83b9108d42
Gerrit-Change-Number: 15143
Gerrit-PatchSet: 4
Gerrit-Owner: keith
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: keith
Gerrit-CC: pespin
Gerrit-Comment-Date: Fri, 09 Aug 2019 11:11:09 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Change in ...osmo-mgw[master]: differentiate AMR octet-aligned=0 vs =1
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15136 ) Change subject: differentiate AMR octet-aligned=0 vs =1 .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/15136/1/src/libosmo-mgcp/mgcp_codec.c File src/libosmo-mgcp/mgcp_codec.c: https://gerrit.osmocom.org/#/c/15136/1/src/libosmo-mgcp/mgcp_codec.c@361 PS1, Line 361: /* Default to octet-aligned=0, i.e. bandwidth-efficient mode */ Just to make sure, did you check in the specs if bandwidth-efficient is the default? -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/15136 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ib8be73a7ca1b95ce794d130e8eb206dcee700124 Gerrit-Change-Number: 15136 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Fri, 09 Aug 2019 11:13:19 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in ...osmo-mgw[master]: ptmap: implicitly match '/8000' and '/8000/1'
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15137 ) Change subject: ptmap: implicitly match '/8000' and '/8000/1' .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/15137 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Iab00bf9a55b1847f85999077114b37e70fb677c2 Gerrit-Change-Number: 15137 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 09 Aug 2019 11:14:49 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-mgw[master]: mgcp_codec: codec_set(): log about all possible errors
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15138 ) Change subject: mgcp_codec: codec_set(): log about all possible errors .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/15138 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I0b44b574c814882b6f8ae7cd738a6f481cd721fd Gerrit-Change-Number: 15138 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 09 Aug 2019 11:16:46 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-mgw[master]: explicitly free codecs in mgcp_rtp_conn_cleanup()
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15139 ) Change subject: explicitly free codecs in mgcp_rtp_conn_cleanup() .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/15139 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ic471107ce6e94d9ce582d887429c744ff93e3053 Gerrit-Change-Number: 15139 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 09 Aug 2019 11:17:40 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-mgw[master]: tweak mgcp_parse_audio_ptime_rtpmap()
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-mgw/+/15140 )
Change subject: tweak mgcp_parse_audio_ptime_rtpmap()
..
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/15140/1//COMMIT_MSG
Commit Message:
https://gerrit.osmocom.org/#/c/15140/1//COMMIT_MSG@12
PS1, Line 12: - instead of strstr("rtpmap"), use
osmo_str_startswith("a=rtpmap:") to more
Does spec state there shall be no whitespace at the start of the line?
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/15140
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I730111e245da8485c1b5e8811f75d140e379cec6
Gerrit-Change-Number: 15140
Gerrit-PatchSet: 1
Gerrit-Owner: neels
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin
Gerrit-Comment-Date: Fri, 09 Aug 2019 11:20:00 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Change in ...osmo-mgw[master]: SDP: store all ptmap entries
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15141 ) Change subject: SDP: store all ptmap entries .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/15141 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I2a69c21e68c602daf804744212d335ab1eafd81b Gerrit-Change-Number: 15141 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 09 Aug 2019 11:21:40 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-mgw[master]: differentiate AMR octet-aligned=0 vs =1
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15136 ) Change subject: differentiate AMR octet-aligned=0 vs =1 .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/15136/1/src/libosmo-mgcp/mgcp_codec.c File src/libosmo-mgcp/mgcp_codec.c: https://gerrit.osmocom.org/#/c/15136/1/src/libosmo-mgcp/mgcp_codec.c@361 PS1, Line 361: /* Default to octet-aligned=0, i.e. bandwidth-efficient mode */ > Just to make sure, did you check in the specs if bandwidth-efficient is the > default? it is -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/15136 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ib8be73a7ca1b95ce794d130e8eb206dcee700124 Gerrit-Change-Number: 15136 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Fri, 09 Aug 2019 12:04:24 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
Change in ...osmo-mgw[master]: differentiate AMR octet-aligned=0 vs =1
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15136 ) Change subject: differentiate AMR octet-aligned=0 vs =1 .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/15136/1/src/libosmo-mgcp/mgcp_codec.c File src/libosmo-mgcp/mgcp_codec.c: https://gerrit.osmocom.org/#/c/15136/1/src/libosmo-mgcp/mgcp_codec.c@361 PS1, Line 361: /* Default to octet-aligned=0, i.e. bandwidth-efficient mode */ > it is http://git.osmocom.org/osmo-sip-connector/commit/?id=b6032727870ab2b98372b697d91f7256da4f32b3 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/15136 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ib8be73a7ca1b95ce794d130e8eb206dcee700124 Gerrit-Change-Number: 15136 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Fri, 09 Aug 2019 12:06:43 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Comment-In-Reply-To: keith Gerrit-MessageType: comment
Change in ...osmo-sip-connector[master]: coverity: Address issue found by coverity
Hello fixeria, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/15143 to look at the new patch set (#5). Change subject: coverity: Address issue found by coverity .. coverity: Address issue found by coverity Add NULL checks on the return value of call_leg_other() in update_rtp() If the remote side has requested media change and we cannot find the other leg, then release call. This should not happen. Also, Add an assert to show that we cannot be here without call type of SIP or MNCC (not related to coverity) Fixes: CID#202863 Change-Id: I6f1f26533a25c93f243090bc02f1bc83b9108d42 --- M src/mncc.c 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector refs/changes/43/15143/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/15143 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I6f1f26533a25c93f243090bc02f1bc83b9108d42 Gerrit-Change-Number: 15143 Gerrit-PatchSet: 5 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: keith Gerrit-CC: pespin Gerrit-MessageType: newpatchset
Change in ...osmo-mgw[master]: differentiate AMR octet-aligned=0 vs =1
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15136 ) Change subject: differentiate AMR octet-aligned=0 vs =1 .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/15136 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ib8be73a7ca1b95ce794d130e8eb206dcee700124 Gerrit-Change-Number: 15136 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 09 Aug 2019 12:13:57 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-sip-connector[master]: coverity: Address issue found by coverity
keith has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-sip-connector/+/15143 )
Change subject: coverity: Address issue found by coverity
..
Patch Set 4:
(1 comment)
https://gerrit.osmocom.org/#/c/15143/4/src/mncc.c
File src/mncc.c:
https://gerrit.osmocom.org/#/c/15143/4/src/mncc.c@205
PS4, Line 205: static void update_rtp(struct call_leg *_leg) {
> No need to change it now, but this function would be a lot simpler by using a
> switch: […]
ok, i will take note for a planned general refactoring
--
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/15143
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: I6f1f26533a25c93f243090bc02f1bc83b9108d42
Gerrit-Change-Number: 15143
Gerrit-PatchSet: 4
Gerrit-Owner: keith
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: keith
Gerrit-CC: pespin
Gerrit-Comment-Date: Fri, 09 Aug 2019 12:14:09 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin
Gerrit-MessageType: comment
Change in ...osmo-sip-connector[master]: coverity: Address issue found by coverity
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15143 ) Change subject: coverity: Address issue found by coverity .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/15143 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I6f1f26533a25c93f243090bc02f1bc83b9108d42 Gerrit-Change-Number: 15143 Gerrit-PatchSet: 5 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: keith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 09 Aug 2019 12:15:18 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...meta-telephony[201705]: libosmocore: Disable TLS workaround to avoid ld crash
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/15146 ) Change subject: libosmocore: Disable TLS workaround to avoid ld crash .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/15146 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: 201705 Gerrit-Change-Id: I8d2bfa7ed44d1d2a7fb024ac49bc81cdbf38675d Gerrit-Change-Number: 15146 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 09 Aug 2019 12:15:51 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...meta-telephony[201705]: Add libosmo-netif to osmo-sysmon dependencies
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/15145 ) Change subject: Add libosmo-netif to osmo-sysmon dependencies .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/15145 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: 201705 Gerrit-Change-Id: I8532e9b0391bc3489cd9b53caced9f5bf0d3581f Gerrit-Change-Number: 15145 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 09 Aug 2019 12:15:47 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...meta-telephony[201705]: Update Osmocom recipes to latest tags (release 201908)
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/15144 ) Change subject: Update Osmocom recipes to latest tags (release 201908) .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/15144 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: 201705 Gerrit-Change-Id: I1b06cbd9998660951d33a011726d86ae288fc7b9 Gerrit-Change-Number: 15144 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: daniel Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 09 Aug 2019 12:15:44 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...libusrp[master]: jenkins.sh: Workaround race conditon in make
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libusrp/+/15147 Change subject: jenkins.sh: Workaround race conditon in make .. jenkins.sh: Workaround race conditon in make Sometimes the jenkins job fails to build. I never have this issue on my workstation. Disabling PARALLEL_MAKE is osmo-trx jenkins.sh (which requires libusrp build) made libusrp stop failing there, so let's do the same here. OS#3970 Change-Id: Iab8eab6d21365e3ee8d018428a707c56cc1b72e5 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libusrp refs/changes/47/15147/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index d75beda..7a7e782 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -4,6 +4,6 @@ autoreconf --install --force ./configure -$MAKE $PARALLEL_MAKE +$MAKE # Parallel make fails ocsasionally, see OS#3970. $MAKE distcheck $MAKE maintainer-clean -- To view, visit https://gerrit.osmocom.org/c/libusrp/+/15147 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libusrp Gerrit-Branch: master Gerrit-Change-Id: Iab8eab6d21365e3ee8d018428a707c56cc1b72e5 Gerrit-Change-Number: 15147 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange
Change in ...osmo-sip-connector[master]: coverity: Address issue found by coverity
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15143 ) Change subject: coverity: Address issue found by coverity .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/15143 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I6f1f26533a25c93f243090bc02f1bc83b9108d42 Gerrit-Change-Number: 15143 Gerrit-PatchSet: 5 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: keith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 09 Aug 2019 13:24:09 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmocom-bb[master]: fb_tools/bdf_to_c.py: make it compatible with python3
lynxis lazus has submitted this change and it was merged. (
https://gerrit.osmocom.org/c/osmocom-bb/+/14758 )
Change subject: fb_tools/bdf_to_c.py: make it compatible with python3
..
fb_tools/bdf_to_c.py: make it compatible with python3
This would break python2 compatibility.
Change-Id: Iaa20dd0aafa20e36186cf8dfe4d0ac9ab638f235
---
M src/host/fb_tools/bdf_to_c.py
1 file changed, 33 insertions(+), 33 deletions(-)
Approvals:
fixeria: Looks good to me, approved
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/host/fb_tools/bdf_to_c.py b/src/host/fb_tools/bdf_to_c.py
index 86be6a6..ebeb7f9 100755
--- a/src/host/fb_tools/bdf_to_c.py
+++ b/src/host/fb_tools/bdf_to_c.py
@@ -1,4 +1,4 @@
-#!/usr/bin/python
+#!/usr/bin/env python3
# -*- coding: utf-8 -*-
'''
@@ -133,7 +133,7 @@
arr = l.split(None,1)
if len(arr) < 2 and \
arr[0].lower() != 'STARTCHAR' :
- print >>sys.stderr,'Not start of glyph:
%s'%(l)
+ print('Not start of glyph: %s'%(l),
file=sys.stderr)
continue
inchar = unique_name(arr[1],self.glyphs)
continue
@@ -159,7 +159,7 @@
continue
if len(arr) < 2 :
- print >>sys.stderr,'Bad line in font: %s'%(l)
+ print('Bad line in font: %s'%(l),
file=sys.stderr)
continue
data[arr[0].lower()] = arr[1]
@@ -183,40 +183,40 @@
if opts.firstchar == None :
opts.firstchar = min(font.enc)
- print 'First character in font: %d, %s'%(opts.firstchar,
- font.enc[opts.firstchar])
+ print('First character in font: %d, %s'%(opts.firstchar,
+ font.enc[opts.firstchar]))
if opts.lastchar == None :
opts.lastchar = max(font.enc)
- print 'Last character in font: %d, %s'%(opts.lastchar,
- font.enc[opts.lastchar])
+ print('Last character in font: %d, %s'%(opts.lastchar,
+ font.enc[opts.lastchar]))
if opts.base == None :
opts.base = 'font_'+os.path.basename(args[0])
if opts.base[-4:] == '.bdf' :
opts.base = opts.base[:-4]
- print >>sys.stderr,'Guessing symbol prefix to be
%s.'%(opts.base)
+ print('Guessing symbol prefix to be %s.'%(opts.base),
file=sys.stderr)
if opts.out == None :
opts.out = os.path.basename(args[0])
if opts.out[-4:] == '.bdf' :
opts.out = opts.out[:-4]
opts.out = opts.out + '.c'
- print >>sys.stderr,'Guessing output filename to be
%s.'%(opts.out)
+ print('Guessing output filename to be %s.'%(opts.out),
file=sys.stderr)
if os.path.exists(opts.out) :
- print >>sys.stderr,'Will *NOT* overwrite existing file
when guessing output!'
+ print('Will *NOT* overwrite existing file when guessing
output!', file=sys.stderr)
sys.exit(1)
of = file(opts.out,'w')
- print >>of,'#include '
- print >>of,'/* file autogenerated by %s */'%(sys.argv[0])
+ print('#include ', file=of)
+ print('/* file autogenerated by %s */' %(sys.argv[0]), file=of)
offsets = list()
glyphnames = list()
- print >>of,'static const uint8_t %s_data[] = {'%(opts.base)
+ print('static const uint8_t %s_data[] = {'%(opts.base), file=of)
pos = 0
@@ -236,8 +236,8 @@
bitmap = glyph['bitmap']
if bbx[1] != len(bitmap) :
- print >>sys.stderr,'ERROR: glyph',charname,'has wrong
number of lines of data!'
- print >>sys.stderr,' want: ',bbx[1],'but
have',len(bitmap)
+ print('ERROR: glyph',charname,'has wrong number of
lines of data!', file=sys.stderr)
+ print(' want: ',bbx[1],'but have',len(bitmap),
file=sys.stderr)
sys.exit(1)
removedrows = 0
@@ -254,40 +254,40 @@
bitmap = bitmap[:-1]
if removedrows > 0 :
- print "Glyph %s: removed %d
rows."%(charname,removedrows)
+ print("Glyph %s: removed %d
rows."%(charname,removedrows))
w = int(glyph['dwidth'].split(None,1)[0])
- print >>of,'/* --- new character %s %s starting at offset
0x%04x --- */'%(
- charname,ascii_charnum(i
Build failure of network:osmocom:nightly/ulfius in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/ulfius/Debian_Unstable/x86_64 Package network:osmocom:nightly/ulfius failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly ulfius Last lines of build log: can't create /var/cache/obs/worker/cache/content.new: Input/output error at ./bs_worker line 1209. (worker was cloud134:2) -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
