Build failure of network:osmocom:nightly/osmo-trx in Debian_Unstable/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_Unstable/x86_64

Package network:osmocom:nightly/osmo-trx failed to build in 
Debian_Unstable/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-trx

Last lines of build log:
[  522s] ar: `u' modifier ignored since `D' is the default (see `U')
[  522s] libtool: link: ranlib .libs/libtransceiver_common.a
[  522s] libtool: link: ( cd ".libs" && rm -f "libtransceiver_common.la" && ln 
-s "../libtransceiver_common.la" "libtransceiver_common.la" )
[  522s] /bin/bash ../libtool  --tag=CXX   --mode=link g++ -lpthread 
-I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 
-fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat 
-Werror=format-security  -Wl,-z,relro -Wl,-z,now -o osmo-trx-uhd 
osmo_trx_uhd-osmo-trx.o ./device/uhd/libdevice.la libtransceiver_common.la 
../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la 
../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl 
-losmogsm -losmocore -ltalloc -losmovty -losmocore -luhd 
[  522s] libtool: link: g++ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g 
-O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong 
-Wformat -Werror=format-security -Wl,-z -Wl,relro -Wl,-z -Wl,now -o 
osmo-trx-uhd osmo_trx_uhd-osmo-trx.o  ./device/uhd/.libs/libdevice.a 
./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a 
../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f 
/usr/lib/x86_64-linux-gnu/libosmoctrl.so 
/usr/lib/x86_64-linux-gnu/libosmogsm.so -ltalloc 
/usr/lib/x86_64-linux-gnu/libosmovty.so 
/usr/lib/x86_64-linux-gnu/libosmocore.so -luhd
[  522s] /usr/bin/ld: ./device/uhd/.libs/libdevice.a(UHDDevice.o): undefined 
reference to symbol '_ZN5boost6system16generic_categoryEv'
[  522s] /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libboost_system.so.1.67.0: 
error adding symbols: DSO missing from command line
[  522s] collect2: error: ld returned 1 exit status
[  522s] make[4]: *** [Makefile:681: osmo-trx-uhd] Error 1
[  522s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M'
[  522s] make[3]: *** [Makefile:820: all-recursive] Error 1
[  522s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M'
[  522s] make[2]: *** [Makefile:513: all-recursive] Error 1
[  522s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  522s] make[1]: *** [Makefile:444: all] Error 2
[  522s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  522s] dh_auto_build: make -j1 returned exit code 2
[  522s] make: *** [debian/rules:6: build] Error 255
[  522s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  522s] 
[  522s] cloud119 failed "build osmo-trx_1.1.1.15.923b.dsc" at Tue Sep 17 
01:47:43 UTC 2019.
[  522s] 
[  522s] ### VM INTERACTION START ###
[  526s] [  483.219419] sysrq: SysRq : Power Off
[  526s] [  483.223890] reboot: Power down
[  528s] ### VM INTERACTION END ###
[  528s] 
[  528s] cloud119 failed "build osmo-trx_1.1.1.15.923b.dsc" at Tue Sep 17 
01:47:49 UTC 2019.
[  528s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Jenkins build is back to normal : master-osmo-sip-connector » a1=default,a2=default,a3=default,a4=default,osmocom-master-debian9 #1745

[jenkins]

See 

Build failed in Jenkins: master-osmo-sip-connector » a1=default,a2=default,a3=default,a4=default,osmocom-master-debian9 #1744

[jenkins]

See 


Changes:

[lynxis] .service: require to ran after network-online.target

--
[...truncated 28.28 KB...]
  CC   backtrace.lo
  CC   conv.lo
  CC   application.lo
  CC   rbtree.lo
  CC   strrb.lo
  CC   loggingrb.lo
  CC   crc8gen.lo
  CC   crc16gen.lo
  CC   crc32gen.lo
  CC   crc64gen.lo
  CC   macaddr.lo
  CC   stat_item.lo
  CC   stats.lo
  CC   stats_statsd.lo
  CC   prim.lo
  CC   conv_acc.lo
  CC   conv_acc_generic.lo
  CC   sercomm.lo
  CC   prbs.lo
  CC   isdnhdlc.lo
  CC   tdef.lo
  CC   sockaddr_str.lo
  CC   use_count.lo
  CC   conv_acc_sse.lo
  CC   conv_acc_sse_avx.lo
  CC   plugin.lo
  CC   msgfile.lo
  CC   serial.lo
  CCLD libosmocore.la
make[4]: Entering directory 
'
make[4]: Nothing to be done for 'install-data-am'.
 /bin/mkdir -p 
'
 /bin/bash ../libtool   --mode=install /usr/bin/install -c   libosmocore.la 
'
libtool: install: /usr/bin/install -c .libs/libosmocore.so.12.2.0 

libtool: install: (cd 

 && { ln -s -f libosmocore.so.12.2.0 libosmocore.so.12 || { rm -f 
libosmocore.so.12 && ln -s libosmocore.so.12.2.0 libosmocore.so.12; }; })
libtool: install: (cd 

 && { ln -s -f libosmocore.so.12.2.0 libosmocore.so || { rm -f libosmocore.so 
&& ln -s libosmocore.so.12.2.0 libosmocore.so; }; })
libtool: install: /usr/bin/install -c .libs/libosmocore.lai 

libtool: finish: 
PATH="/usr/local/bin:/usr/bin:/bin:/usr/games:/home/osmocom-build/bin:/sbin" 
ldconfig -n 

--
Libraries have been installed in:
   


If you ever happen to want to link against installed libraries
in a given directory, LIBDIR, you must either use libtool, and
specify the full pathname of the library, or use the '-LLIBDIR'
flag during linking and do at least one of the following:
   - add LIBDIR to the 'LD_LIBRARY_PATH' environment variable
 during execution
   - add LIBDIR to the 'LD_RUN_PATH' environment variable
 during linking
   - use the '-Wl,-rpath -Wl,LIBDIR' linker flag
   - have your system administrator add LIBDIR to '/etc/ld.so.conf'

See any operating system documentation about shared libraries for
more information, such as the ld(1) and ld.so(8) manual pages.
--
make[4]: Leaving directory 
'
make[3]: Leaving directory 
'
make[2]: Leaving directory 
'
Making install in src/vty
make[2]: Entering directory 

Change in ...osmo-msc[master]: vlr: gmm_cause_to_fsm_and_mm_cause() drop fsm_cause_p argument

[lynxis lazus]

lynxis lazus has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/15490 )

Change subject: vlr: gmm_cause_to_fsm_and_mm_cause() drop fsm_cause_p argument
..

vlr: gmm_cause_to_fsm_and_mm_cause() drop fsm_cause_p argument

It's always set to OSMO_TERM_ERROR. Move the assignment to the caller.
In prepartion to use gmm_cause_to_fsm_and_mm_cause() in vlr_auth_fsm.

Change-Id: Ie4720ad40ef7bcfc528d8d63bfc606c9c0545fb2
---
M src/libvlr/vlr.c
1 file changed, 6 insertions(+), 16 deletions(-)

Approvals:
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/libvlr/vlr.c b/src/libvlr/vlr.c
index ea160b1..a227240 100644
--- a/src/libvlr/vlr.c
+++ b/src/libvlr/vlr.c
@@ -917,11 +917,9 @@
return 0;
 }

-static void gmm_cause_to_fsm_and_mm_cause(enum gsm48_gmm_cause gmm_cause,
- enum osmo_fsm_term_cause *fsm_cause_p,
- enum gsm48_reject_value *gsm48_rej_p)
+static void gmm_cause_to_mm_cause(enum gsm48_gmm_cause gmm_cause,
+ enum gsm48_reject_value *gsm48_rej_p)
 {
-   enum osmo_fsm_term_cause fsm_cause = OSMO_FSM_TERM_ERROR;
enum gsm48_reject_value gsm48_rej = GSM48_REJECT_NETWORK_FAILURE;
switch (gmm_cause) {
case GMM_CAUSE_IMSI_UNKNOWN:
@@ -1004,16 +1002,8 @@
gsm48_rej = GSM48_REJECT_NETWORK_FAILURE;
break;
}
-   switch (gmm_cause) {
-   /* refine any error causes here? */
-   default:
-   fsm_cause = OSMO_FSM_TERM_ERROR;
-   break;
-   }
-   if (fsm_cause_p)
-   *fsm_cause_p = fsm_cause;
-   if (gsm48_rej_p)
-   *gsm48_rej_p = gsm48_rej;
+
+   *gsm48_rej_p = gsm48_rej;
 }

 /* Handle LOCATION CANCEL request from HLR */
@@ -1021,7 +1011,7 @@
const struct osmo_gsup_message 
*gsup_msg)
 {
enum gsm48_reject_value gsm48_rej;
-   enum osmo_fsm_term_cause fsm_cause;
+   enum osmo_fsm_term_cause fsm_cause = OSMO_FSM_TERM_ERROR;
struct osmo_gsup_message gsup_reply = {0};
int rc, is_update_procedure = !gsup_msg->cancel_type ||
gsup_msg->cancel_type == OSMO_GSUP_CANCEL_TYPE_UPDATE;
@@ -1033,7 +1023,7 @@
gsup_reply.message_type = OSMO_GSUP_MSGT_LOCATION_CANCEL_RESULT;
rc = vlr_subscr_tx_gsup_message(vsub, _reply);

-   gmm_cause_to_fsm_and_mm_cause(gsup_msg->cause, _cause, _rej);
+   gmm_cause_to_mm_cause(gsup_msg->cause, _rej);
vlr_subscr_cancel_attach_fsm(vsub, fsm_cause, gsm48_rej);

vlr_subscr_rx_imsi_detach(vsub);

--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15490
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ie4720ad40ef7bcfc528d8d63bfc606c9c0545fb2
Gerrit-Change-Number: 15490
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in ...osmo-ttcn3-hacks[master]: Require to receive RANAP_CommonId after RANAP_SecurityModeComplete

[lynxis lazus]

lynxis lazus has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15530 )

Change subject: Require to receive RANAP_CommonId after 
RANAP_SecurityModeComplete
..

Require to receive RANAP_CommonId after RANAP_SecurityModeComplete

The SGSN will send a CommonId after it has sent SecurityModeComplete
to support paging coordination in the RNC.

Change-Id: I82a05cab2aeea25eec699f726b2f5c4b3eef7560
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn
index d96767a..281dcc9 100644
--- a/sgsn/SGSN_Tests.ttcn
+++ b/sgsn/SGSN_Tests.ttcn
@@ -661,6 +661,7 @@
key_sts := ?)) {
var IntegrityProtectionAlgorithm uia_chosen := 
0; /* 0 = standard_UMTS_integrity_algorithm_UIA1 */

BSSAP.send(ts_RANAP_SecurityModeComplete(uia_chosen));
+   
BSSAP.receive(tr_RANAP_CommonId(imsi_hex2oct(g_pars.imsi)))
}
}
} else {
@@ -2397,6 +2398,7 @@
key_sts := ?)) {
var IntegrityProtectionAlgorithm uia_chosen := 0; /* 0 
= standard_UMTS_integrity_algorithm_UIA1 */
BSSAP.send(ts_RANAP_SecurityModeComplete(uia_chosen));
+   
BSSAP.receive(tr_RANAP_CommonId(imsi_hex2oct(g_pars.imsi)))
}
[is_gb(ran_index)] BSSGP[ran_index].receive { repeat; }
[is_iu(ran_index)] BSSAP.receive { repeat; }

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15530
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I82a05cab2aeea25eec699f726b2f5c4b3eef7560
Gerrit-Change-Number: 15530
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in ...osmo-sip-connector[master]: .service: require to ran after network-online.target

[lynxis lazus]

lynxis lazus has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/c/osmo-sip-connector/+/15533 )

Change subject: .service: require to ran after network-online.target
..

.service: require to ran after network-online.target

Relates: OS#4197
Change-Id: I09bf8139582ef198fdbe664be32b14d8c9c99f1a
---
M contrib/systemd/osmo-sip-connector.service
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved
  keith: Looks good to me, but someone else must approve



diff --git a/contrib/systemd/osmo-sip-connector.service 
b/contrib/systemd/osmo-sip-connector.service
index a08f167..673aa53 100644
--- a/contrib/systemd/osmo-sip-connector.service
+++ b/contrib/systemd/osmo-sip-connector.service
@@ -1,5 +1,7 @@
 [Unit]
 Description=Osmo SIP Connector
+After=network-online.target
+Wants=network-online.target

 [Service]
 Type=simple

--
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/15533
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: I09bf8139582ef198fdbe664be32b14d8c9c99f1a
Gerrit-Change-Number: 15533
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: keith 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: pespin 
Gerrit-Reviewer: zecke 
Gerrit-MessageType: merged

Change in ...osmo-iuh[master]: iu_client: introduce UE field free_on_release

[lynxis lazus]

lynxis lazus has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/c/osmo-iuh/+/15474 )

Change subject: iu_client: introduce UE field free_on_release
..

iu_client: introduce UE field free_on_release

Allow to free UE ctx when receiving a Iu Release Complete.
In preparation of ranap_iu_tx_release_free() it requires
a field to free the Iu ctx on it's own without depending
on the upstream user.

Change-Id: Iac41cd3cce3232d01b2f7ede0cc46226c2cfb6c0
---
M TODO-RELEASE
M include/osmocom/ranap/iu_client.h
M src/iu_client.c
3 files changed, 12 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/TODO-RELEASE b/TODO-RELEASE
index bcbf5de..b967e56 100644
--- a/TODO-RELEASE
+++ b/TODO-RELEASE
@@ -9,3 +9,4 @@
 #library   whatdescription / commit summary line
 libranapiu_client.h struct ranap_ue_conn_ctx: add field notification
 libranapiu_client.h struct ranap_ue_conn_ctx: add field release_timeout
+libranapiu_client.h struct ranap_ue_conn_ctx: add field free_on_release
diff --git a/include/osmocom/ranap/iu_client.h 
b/include/osmocom/ranap/iu_client.h
index a93fff3..24a5af9 100644
--- a/include/osmocom/ranap/iu_client.h
+++ b/include/osmocom/ranap/iu_client.h
@@ -31,6 +31,8 @@
struct gprs_ra_id ra_id;
enum ranap_nsap_addr_enc rab_assign_addr_enc;
bool notification; /* send notification to the upstream user */
+   /* if true the ue_ctx will be free on Iu release complete */
+   bool free_on_release;
/* Will be set when the Iu Release Command has been sent */
struct osmo_timer_list release_timeout;
 };
diff --git a/src/iu_client.c b/src/iu_client.c
index e4eb83e..c309ce4 100644
--- a/src/iu_client.c
+++ b/src/iu_client.c
@@ -129,6 +129,7 @@
ctx->rnc = rnc;
ctx->conn_id = conn_id;
ctx->notification = true;
+   ctx->free_on_release = false;
osmo_timer_setup(>release_timeout,
 (void *)(void *) ranap_iu_free_ue,
 ctx);
@@ -500,6 +501,7 @@
 int timeout)
 {
ctx->notification = false;
+   ctx->free_on_release = true;
int ret = ranap_iu_tx_release(ctx, cause);
if (ret) {
ranap_iu_free_ue(ctx);
@@ -851,6 +853,13 @@
break;

global_iu_event(ue, RANAP_IU_EVENT_LINK_INVALIDATED, NULL);
+
+   /* A RANAP_IU_EVENT_LINK_INVALIDATED, can lead to a free */
+   ue = ue_conn_ctx_find(prim->u.disconnect.conn_id);
+   if (!ue)
+   break;
+   if (ue->free_on_release)
+   ranap_iu_free_ue(ue);
break;
case OSMO_PRIM(OSMO_SCU_PRIM_N_DATA, PRIM_OP_INDICATION):
/* connection-oriented data received */

--
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/15474
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: Iac41cd3cce3232d01b2f7ede0cc46226c2cfb6c0
Gerrit-Change-Number: 15474
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: pespin 
Gerrit-CC: fixeria 
Gerrit-MessageType: merged

Change in ...osmo-msc[master]: vty: fix access to wrong argv in paging response-timer

[neels]

neels has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/15545 )

Change subject: vty: fix access to wrong argv in paging response-timer
..

vty: fix access to wrong argv in paging response-timer

Fixes: 2ff5bcdc387a7eb5135e5a54d55027502952c86b
Change-Id: I667cf4c8e3e7b6e77ea6ed8ae603727ad22a2ee2
---
M src/libmsc/msc_vty.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  neels: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/libmsc/msc_vty.c b/src/libmsc/msc_vty.c
index 09aef91..51504ef 100644
--- a/src/libmsc/msc_vty.c
+++ b/src/libmsc/msc_vty.c
@@ -557,7 +557,7 @@
   "Set to default timeout (" 
OSMO_STRINGIFY_VAL(MSC_PAGING_RESPONSE_TIMER_DEFAULT) " seconds)\n"
   "Set paging timeout in seconds\n")
 {
-   if (!strcmp(argv[1], "default"))
+   if (!strcmp(argv[0], "default"))
gsmnet->paging_response_timer = 
MSC_PAGING_RESPONSE_TIMER_DEFAULT;
else
gsmnet->paging_response_timer = atoi(argv[0]);

--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15545
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I667cf4c8e3e7b6e77ea6ed8ae603727ad22a2ee2
Gerrit-Change-Number: 15545
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels 
Gerrit-MessageType: merged

Change in ...osmo-msc[master]: vty: fix access to wrong argv in paging response-timer

[neels]

neels has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/15545 )

Change subject: vty: fix access to wrong argv in paging response-timer
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15545
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I667cf4c8e3e7b6e77ea6ed8ae603727ad22a2ee2
Gerrit-Change-Number: 15545
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: neels 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Mon, 16 Sep 2019 17:03:47 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in ...osmo-msc[master]: vty: fix access to wrong argv in paging response-timer

[pespin]

pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/15545


Change subject: vty: fix access to wrong argv in paging response-timer
..

vty: fix access to wrong argv in paging response-timer

Fixes: 2ff5bcdc387a7eb5135e5a54d55027502952c86b
Change-Id: I667cf4c8e3e7b6e77ea6ed8ae603727ad22a2ee2
---
M src/libmsc/msc_vty.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/45/15545/1

diff --git a/src/libmsc/msc_vty.c b/src/libmsc/msc_vty.c
index 09aef91..51504ef 100644
--- a/src/libmsc/msc_vty.c
+++ b/src/libmsc/msc_vty.c
@@ -557,7 +557,7 @@
   "Set to default timeout (" 
OSMO_STRINGIFY_VAL(MSC_PAGING_RESPONSE_TIMER_DEFAULT) " seconds)\n"
   "Set paging timeout in seconds\n")
 {
-   if (!strcmp(argv[1], "default"))
+   if (!strcmp(argv[0], "default"))
gsmnet->paging_response_timer = 
MSC_PAGING_RESPONSE_TIMER_DEFAULT;
else
gsmnet->paging_response_timer = atoi(argv[0]);

--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15545
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I667cf4c8e3e7b6e77ea6ed8ae603727ad22a2ee2
Gerrit-Change-Number: 15545
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange

Change in ...osmo-bsc[master]: bsc_subscr_conn_fsm: Cleanly clear BSSAP conn if associated channel c...

[pespin]

Hello fixeria, neels, laforge, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bsc/+/15408

to look at the new patch set (#3).

Change subject: bsc_subscr_conn_fsm: Cleanly clear BSSAP conn if associated 
channel closed during WAIT_CC
..

bsc_subscr_conn_fsm: Cleanly clear BSSAP conn if associated channel closed 
during WAIT_CC

TTCN3 BSC_Tests.TC_ms_rel_ind_does_not_cause_bssmap_reset seems to
sometimes run into a race condition on the order of messages received by
osmo-bsc comming from MSC and BTS.

Usual (expected) scenario):
BTS->BSC  EST IND
 BSC->MSC CL3 Info
 BSC<-MSC CC
BTS->BSC  REL IND
BTS<-BSC  DEACT SACCH
 BSC->MSC ClearRequest
 BSC<-MSC ClearCommand
 BSC->MSC ClearComplete
BTS<-BSC  RF Chan Release
BTS->BSC  RF Chan Release ACK

Sometimes CC message and REL IND message are received swapped (because they
are sent by different components asynchronously in TTCN3).

As a result, osmo-bsc was failing to go into CLEARING state and was
unable to send the ClearRequest because CC was still not received.
So the idea is to stay in WAIT_CC until CC is received, then check if
the lchan was dropped and in that case go into clearing state.

Change-Id: Id1abf5ee44c60925b478123409f26bd29006202b
---
M src/osmo-bsc/bsc_subscr_conn_fsm.c
1 file changed, 28 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/08/15408/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/15408
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Id1abf5ee44c60925b478123409f26bd29006202b
Gerrit-Change-Number: 15408
Gerrit-PatchSet: 3
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: newpatchset

Change in ...osmo-msc[master]: catch GSUP auth result without auth_fsm

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/15544 )

Change subject: catch GSUP auth result without auth_fsm
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/15544/1/src/libvlr/vlr.c
File src/libvlr/vlr.c:

https://gerrit.osmocom.org/#/c/15544/1/src/libvlr/vlr.c@760
PS1, Line 760:  if (!auth_fi) {
Is it clear how can this happen? How it comes the subscriber has no fi? or it 
is fixing an unknown source problem?



--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15544
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I1995d8f68cfde1140968fb9a97bd054de950de2e
Gerrit-Change-Number: 15544
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-CC: Jenkins Builder
Gerrit-CC: pespin 
Gerrit-Comment-Date: Mon, 16 Sep 2019 16:21:52 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in ...osmo-msc[master]: catch GSUP auth result without auth_fsm

[neels]

neels has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/15544


Change subject: catch GSUP auth result without auth_fsm
..

catch GSUP auth result without auth_fsm

When a vlr_subscr receives an Send Auth Info result, properly check whether the
subscriber has an auth_fsm.

Before, a missing auth_fsm would crash osmo-msc with:

vlr.c:762 Trying to dispatch event 1 to non-existent FSM instance!

Related: OS#4191
Change-Id: I1995d8f68cfde1140968fb9a97bd054de950de2e
---
M src/libvlr/vlr.c
1 file changed, 6 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/44/15544/1

diff --git a/src/libvlr/vlr.c b/src/libvlr/vlr.c
index ea160b1..4ea3caa 100644
--- a/src/libvlr/vlr.c
+++ b/src/libvlr/vlr.c
@@ -757,6 +757,12 @@
struct osmo_fsm_inst *auth_fi = vsub->auth_fsm;
void *data = (void *) gsup;

+   if (!auth_fi) {
+   LOGVSUBP(LOGL_ERROR, vsub, "Received GSUP %s, but there is no 
auth_fsm\n",
+osmo_gsup_message_type_name(gsup->message_type));
+   return -1;
+   }
+
switch (gsup->message_type) {
case OSMO_GSUP_MSGT_SEND_AUTH_INFO_RESULT:
osmo_fsm_inst_dispatch(auth_fi, VLR_AUTH_E_HLR_SAI_ACK, data);

--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15544
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I1995d8f68cfde1140968fb9a97bd054de950de2e
Gerrit-Change-Number: 15544
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-MessageType: newchange

Change in ...osmo-sgsn[master]: sgsn: when receiving data PDU notify the Gb GMM fsm

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/15535 )

Change subject: sgsn: when receiving data PDU notify the Gb GMM fsm
..


Patch Set 2: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15535
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I78f40762fb17bbd4a6f35608a793f8e5271e9b86
Gerrit-Change-Number: 15535
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Mon, 16 Sep 2019 16:07:02 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in ...osmo-sgsn[master]: sgsn: when receiving data PDU notify the Gb GMM fsm

[lynxis lazus]

lynxis lazus has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/15535 )

Change subject: sgsn: when receiving data PDU notify the Gb GMM fsm
..


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/15535/2/src/sgsn/gprs_sndcp.c
File src/sgsn/gprs_sndcp.c:

https://gerrit.osmocom.org/#/c/15535/2/src/sgsn/gprs_sndcp.c@785
PS2, Line 785:  OSMO_ASSERT(mmctx);
> Don't assert here, better log error and drop the packet!
It should never happen! Otherwise it should exit much earlier before calling 
this function when looking up the lle.



--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15535
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I78f40762fb17bbd4a6f35608a793f8e5271e9b86
Gerrit-Change-Number: 15535
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Mon, 16 Sep 2019 15:58:44 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Gerrit-MessageType: comment

Change in ...osmo-bsc[master]: bsc_subscr_conn_fsm: Cleanly clear BSSAP conn if associated channel c...

[neels]

neels has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/15408 )

Change subject: bsc_subscr_conn_fsm: Cleanly clear BSSAP conn if associated 
channel closed during WAIT_CC
..


Patch Set 1: Code-Review-1

(2 comments)

Found one side effect functional change, and got some style nitpicks

https://gerrit.osmocom.org/#/c/15408/1/src/osmo-bsc/bsc_subscr_conn_fsm.c
File src/osmo-bsc/bsc_subscr_conn_fsm.c:

https://gerrit.osmocom.org/#/c/15408/1/src/osmo-bsc/bsc_subscr_conn_fsm.c@343
PS1, Line 343:  if (conn->lchan) {
(would prefer the early-exit style; main flow remains undiffed)

if (!conn->lchan) {
 log...
 state_chg...
 clear...
 break;
}

conn_fsm_state_chg(ST_ACTIVE);


https://gerrit.osmocom.org/#/c/15408/1/src/osmo-bsc/bsc_subscr_conn_fsm.c@671
PS1, Line 671:  if (!conn->lchan && gscon_is_active(conn)) {
Before, when we already were in the ST_CLEARING, we would still re-send the 
BSSMAP Clear Request again. I am not sure if that is desired, but if that needs 
to change, that should be a separate patch.
It is fine for the BSC to send repeated Clear Requests, they are only polite 
hints for the MSC.

Code design wise, it's not such a good idea to have gscon_is_active() listing 
all *other* states. If a new state gets added in the future, the author is 
almost guaranteed to forget to also change that function.

Instead I would prefer to more explicitly except only this situation, e.g.:

/* If the conn has no lchan anymore, it was released by the BTS and needs 
to Clear towards MSC. */
if (!conn->lchan) {
switch (conn->fi_state) {
case ST_INIT:
case ST_WAIT_CC:
/* The SCCP connection was not yet confirmed by a CC, the 
BSSAP is not fully established
 * yet. First wait for the CC, and release in 
gscon_fsm_wait_cc(). */
break;

default:
/* Ensure that the FSM is in ST_CLEARING. */
osmo_fsm_inst_state_chg(...ST_CLEARING...)
/* fall thru, omit an error log if already in ST_CLEARING */
case ST_CLEARING:
/* Request a Clear Command from the MSC.
gscon_bssmap_clear([no diff]
break;
}
}

Are you sure that ST_INIT should also be in that condition?



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/15408
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Id1abf5ee44c60925b478123409f26bd29006202b
Gerrit-Change-Number: 15408
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Mon, 16 Sep 2019 15:51:35 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in ...osmo-bts[master]: doc: bts-models.adoc: Fix typos in rts-advance section

[pespin]

pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/15543


Change subject: doc: bts-models.adoc: Fix typos in rts-advance section
..

doc: bts-models.adoc: Fix typos in rts-advance section

Change-Id: I37ba104ec0538f8eb9345ff880660aefbdaa44ca
---
M doc/manuals/chapters/bts-models.adoc
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/43/15543/1

diff --git a/doc/manuals/chapters/bts-models.adoc 
b/doc/manuals/chapters/bts-models.adoc
index e1f8d9a..31c5147 100644
--- a/doc/manuals/chapters/bts-models.adoc
+++ b/doc/manuals/chapters/bts-models.adoc
@@ -282,11 +282,11 @@
 number as reported by OsmoTRX *and* the `osmotrx fn-advance` in order
 to generate the PH-RTS.ind (ready to send indications) across the L1SAP
 interface inside osmo-bts.  This will trigger the Layer 2 (LAPDm for
-the ocntrol plane, RTP for the voice plane, and OsmoPCU for GPRS) to
+the control plane, RTP for the voice plane, and OsmoPCU for GPRS) to
 generate a MAC block and input it into the osmo-bts-trx TDMA scheduler.

 If OsmoTRX reported N as the current frame number, the actual frame number
-reported on L1SAP to higher layes will be computed as follows:
+reported on L1SAP to higher layers will be computed as follows:

   N + fn-advance + rts-advance


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15543
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I37ba104ec0538f8eb9345ff880660aefbdaa44ca
Gerrit-Change-Number: 15543
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange

Change in ...osmo-trx[master]: radioInterface: Mark setRxGain as virtual

[pespin]

pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-trx/+/15541


Change subject: radioInterface: Mark setRxGain as virtual
..

radioInterface: Mark setRxGain as virtual

Otherwise the parent function is always called even if the iface is
radioInterfaceMult.

Change-Id: Ie41efab1e60b88677bbd1ec333ea656794503a5a
---
M Transceiver52M/radioInterface.h
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/41/15541/1

diff --git a/Transceiver52M/radioInterface.h b/Transceiver52M/radioInterface.h
index 6f4deaa..d72fb69 100644
--- a/Transceiver52M/radioInterface.h
+++ b/Transceiver52M/radioInterface.h
@@ -107,7 +107,7 @@
   virtual bool tuneRx(double freq, size_t chan = 0);

   /** set receive gain */
-  double setRxGain(double dB, size_t chan = 0);
+  virtual double setRxGain(double dB, size_t chan = 0);

   /** drive transmission of GSM bursts */
   void driveTransmitRadio(std::vector ,
@@ -182,5 +182,5 @@

   bool tuneTx(double freq, size_t chan);
   bool tuneRx(double freq, size_t chan);
-  double setRxGain(double dB, size_t chan);
+  virtual double setRxGain(double dB, size_t chan);
 };

--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/15541
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Ie41efab1e60b88677bbd1ec333ea656794503a5a
Gerrit-Change-Number: 15541
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange

Change in ...osmo-trx[master]: Move multi-ARFCN chan amount modification from UHDDevice to parent class

[pespin]

pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-trx/+/15542


Change subject: Move multi-ARFCN chan amount modification from UHDDevice to 
parent class
..

Move multi-ARFCN chan amount modification from UHDDevice to parent class

This way switch is applied correctly to parent structures and features
can be used later by other children classes (other devices).

Change-Id: I24d6c66bb3195ba2513b4a67daa14cdfbacdce6d
---
M Transceiver52M/device/common/radioDevice.h
M Transceiver52M/device/uhd/UHDDevice.cpp
2 files changed, 7 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/42/15542/1

diff --git a/Transceiver52M/device/common/radioDevice.h 
b/Transceiver52M/device/common/radioDevice.h
index 1d85204..d27a52c 100644
--- a/Transceiver52M/device/common/radioDevice.h
+++ b/Transceiver52M/device/common/radioDevice.h
@@ -171,12 +171,17 @@
   std::vector tx_paths, rx_paths;
   std::vector m_ctr;

-  RadioDevice(size_t tx_sps, size_t rx_sps, InterfaceType type, size_t chans, 
double offset,
+  RadioDevice(size_t tx_sps, size_t rx_sps, InterfaceType type, size_t 
chan_num, double offset,
   const std::vector& tx_paths,
   const std::vector& rx_paths):
-   tx_sps(tx_sps), rx_sps(rx_sps), iface(type), chans(chans), 
lo_offset(offset),
+   tx_sps(tx_sps), rx_sps(rx_sps), iface(type), chans(chan_num), 
lo_offset(offset),
tx_paths(tx_paths), rx_paths(rx_paths)
{
+   if (iface == MULTI_ARFCN) {
+   LOGC(DDEV, INFO) << "Multi-ARFCN: "<< chan_num << " 
logical chans -> 1 physical chans";
+   chans = 1;
+   }
+
m_ctr.resize(chans);
for (size_t i = 0; i < chans; i++) {
memset(_ctr[i], 0, sizeof(m_ctr[i]));
diff --git a/Transceiver52M/device/uhd/UHDDevice.cpp 
b/Transceiver52M/device/uhd/UHDDevice.cpp
index 809bade..604bb44 100644
--- a/Transceiver52M/device/uhd/UHDDevice.cpp
+++ b/Transceiver52M/device/uhd/UHDDevice.cpp
@@ -382,7 +382,6 @@
if (dev_type != B200 && dev_type != B210)
throw std::invalid_argument("Device does not support 
MCBTS");
dev_type = B2XX_MCBTS;
-   chans = 1;
}

if (chans > dev_param_map.at(dev_key(dev_type, tx_sps, 
rx_sps)).channels)

--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/15542
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I24d6c66bb3195ba2513b4a67daa14cdfbacdce6d
Gerrit-Change-Number: 15542
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange

Change in ...osmo-trx[master]: Log RACH burst detection

[pespin]

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-trx/+/15536

to look at the new patch set (#2).

Change subject: Log RACH burst detection
..

Log RACH burst detection

Change-Id: I4a8adea88ac6f1d9e712352cf1ac374d5bb68e12
---
M Transceiver52M/sigProcLib.cpp
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/36/15536/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/15536
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I4a8adea88ac6f1d9e712352cf1ac374d5bb68e12
Gerrit-Change-Number: 15536
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset

Change in ...osmo-bts[master]: vty: add "logging filter sapi" command

[laforge]

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/15539 )

Change subject: vty: add "logging filter sapi" command
..


Patch Set 2:

why is this "PCU" related?  I really don't get how the PCU plays into all of 
this.  The L1 SAPI is a property of the L1.


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15539
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I6b7bb2e1d61502b61214f854a4ec5cbb7267545b
Gerrit-Change-Number: 15539
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-CC: laforge 
Gerrit-Comment-Date: Mon, 16 Sep 2019 15:18:41 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in ...libosmocore[master]: logging.h: add SAPI related context and filter

[laforge]

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/15538 )

Change subject: logging.h: add SAPI related context and filter
..


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/15538/1/include/osmocom/core/logging.h
File include/osmocom/core/logging.h:

https://gerrit.osmocom.org/#/c/15538/1/include/osmocom/core/logging.h@157
PS1, Line 157: LOG_CTX_PCU_IF_DATA
this doesn't really explain what it is about.  The above elements in the enum 
are self-explanatory, as it's quite clear what a NSVC, BVC or subscriber is.  
But what's PCU_IF_DATA?

Also if this is about filtering by L1 SAPI, then make sure that L1 SAPI is 
mentioned.  SAPIs exist potentially at any SAP, and there are plenty of SAPs in 
the protocol stacks: one at every layer boundary.

Furthermore, if we introduce something to libosmocore which is about L1 SAPI 
filtering, and we do have a L1 SAP (and hence L1 SAPI) in multiple programs, 
why is something called "PCU" here?



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15538
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I814cb3328d99faca9220adb5a80ffb934f219d7d
Gerrit-Change-Number: 15538
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Mon, 16 Sep 2019 15:17:16 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in ...osmo-sip-connector[master]: exit if the sip agent failed to start

[laforge]

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-sip-connector/+/15532 )

Change subject: exit if the sip agent failed to start
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/15532
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: I22ed16c77391b4f270df498dda587ed657279390
Gerrit-Change-Number: 15532
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: keith 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: pespin 
Gerrit-Reviewer: zecke 
Gerrit-Comment-Date: Mon, 16 Sep 2019 15:14:15 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in ...osmo-sip-connector[master]: exit if the sip agent failed to start

[keith]

keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-sip-connector/+/15532 )

Change subject: exit if the sip agent failed to start
..


Patch Set 1:

> Assume osmo-sip-connector is only managed through the VTY. By
 > exiting one loses the ability to ever fix that.

If it were only managed by the VTY, one could access the VTY and change the 
config, but as far as I am aware, there's no way to trigger a rebind or force 
app restart from the vty, is that correct?


--
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/15532
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: I22ed16c77391b4f270df498dda587ed657279390
Gerrit-Change-Number: 15532
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: keith 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: pespin 
Gerrit-Reviewer: zecke 
Gerrit-Comment-Date: Mon, 16 Sep 2019 15:04:10 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in ...osmo-sip-connector[master]: exit if the sip agent failed to start

[keith]

keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-sip-connector/+/15532 )

Change subject: exit if the sip agent failed to start
..


Patch Set 1:

> Assume osmo-sip-connector is only managed through the VTY. By
 > exiting one loses the ability to ever fix that.

Hi zecke!

https://osmocom.org/issues/4197
In the bug report, I suggested we might also retry the bind.
Is it something you feel strongly enough about to send a patch to do that?


--
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/15532
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: I22ed16c77391b4f270df498dda587ed657279390
Gerrit-Change-Number: 15532
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: keith 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: pespin 
Gerrit-Reviewer: zecke 
Gerrit-Comment-Date: Mon, 16 Sep 2019 14:57:11 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in ...osmo-sip-connector[master]: .service: require to ran after network-online.target

[keith]

keith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-sip-connector/+/15533 )

Change subject: .service: require to ran after network-online.target
..


Patch Set 1: Code-Review+1

I've verified this in production.


--
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/15533
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: I09bf8139582ef198fdbe664be32b14d8c9c99f1a
Gerrit-Change-Number: 15533
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: keith 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: pespin 
Gerrit-Reviewer: zecke 
Gerrit-Comment-Date: Mon, 16 Sep 2019 14:54:20 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in ...osmo-pcu[master]: Use osmo_tdef for BSSGP T1 and T2

[pespin]

pespin has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/15427 )

Change subject: Use osmo_tdef for BSSGP T1 and T2
..

Use osmo_tdef for BSSGP T1 and T2

Change-Id: I477e5b702c8b956136d93fc1cee01991233e381f
---
M src/bts.cpp
M src/gprs_bssgp_pcu.cpp
2 files changed, 9 insertions(+), 6 deletions(-)

Approvals:
  laforge: Looks good to me, but someone else must approve
  osmith: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/bts.cpp b/src/bts.cpp
index 1b2ab2f..2600d72 100644
--- a/src/bts.cpp
+++ b/src/bts.cpp
@@ -77,6 +77,8 @@
{ .T=0, .default_val=0, .unit=OSMO_TDEF_S, .desc=NULL, .val=0 } /* 
empty item at the end */
 };
 static struct osmo_tdef T_defs_pcu[] = {
+   { .T=1, .default_val=30,  .unit=OSMO_TDEF_S,  .desc="BSSGP 
(un)blocking procedures timer (s)",  .val=0 },
+   { .T=2, .default_val=30,  .unit=OSMO_TDEF_S,  .desc="BSSGP reset 
procedure timer (s)",  .val=0 },
{ .T=-2000, .default_val=2,   .unit=OSMO_TDEF_MS, .desc="Tbf reject for 
PRR timer (ms)",.val=0 },
{ .T=-2001, .default_val=2,   .unit=OSMO_TDEF_S,  .desc="PACCH 
assignment timer (s)",   .val=0 },
{ .T=-2002, .default_val=200, .unit=OSMO_TDEF_MS, .desc="Waiting after 
IMM.ASS confirm timer (ms)", .val=0 },
diff --git a/src/gprs_bssgp_pcu.cpp b/src/gprs_bssgp_pcu.cpp
index ce56154..abcb106 100644
--- a/src/gprs_bssgp_pcu.cpp
+++ b/src/gprs_bssgp_pcu.cpp
@@ -33,9 +33,6 @@
#include "coding_scheme.h"
 }

-#define BSSGP_TIMER_T1 30  /* Guards the (un)blocking procedures */
-#define BSSGP_TIMER_T2 30  /* Guards the reset procedure */
-
 /* Tuning parameters for BSSGP flow control */
 #define FC_DEFAULT_LIFE_TIME_SECS 10   /* experimental value, 10s */
 #define FC_MS_BUCKET_SIZE_BY_BMAX(bmax) ((bmax) / 2 + 500) /* experimental */
@@ -830,10 +827,12 @@

 static void bvc_timeout(void *_priv)
 {
+   unsigned long secs;
if (!the_pcu.bvc_sig_reset) {
LOGP(DBSSGP, LOGL_INFO, "Sending reset on BVCI 0\n");
bssgp_tx_bvc_reset(the_pcu.bctx, 0, BSSGP_CAUSE_OML_INTERV);
-   osmo_timer_schedule(_pcu.bvc_timer, BSSGP_TIMER_T2, 0);
+   secs = osmo_tdef_get(the_pcu.bts->T_defs_pcu, 2, OSMO_TDEF_S, 
-1);
+   osmo_timer_schedule(_pcu.bvc_timer, secs, 0);
return;
}

@@ -841,7 +840,8 @@
LOGP(DBSSGP, LOGL_INFO, "Sending reset on BVCI %d\n",
the_pcu.bctx->bvci);
bssgp_tx_bvc_reset(the_pcu.bctx, the_pcu.bctx->bvci, 
BSSGP_CAUSE_OML_INTERV);
-   osmo_timer_schedule(_pcu.bvc_timer, BSSGP_TIMER_T2, 0);
+   secs = osmo_tdef_get(the_pcu.bts->T_defs_pcu, 2, OSMO_TDEF_S, 
-1);
+   osmo_timer_schedule(_pcu.bvc_timer, secs, 0);
return;
}

@@ -849,7 +849,8 @@
LOGP(DBSSGP, LOGL_INFO, "Sending unblock on BVCI %d\n",
the_pcu.bctx->bvci);
bssgp_tx_bvc_unblock(the_pcu.bctx);
-   osmo_timer_schedule(_pcu.bvc_timer, BSSGP_TIMER_T1, 0);
+   secs = osmo_tdef_get(the_pcu.bts->T_defs_pcu, 1, OSMO_TDEF_S, 
-1);
+   osmo_timer_schedule(_pcu.bvc_timer, secs, 0);
return;
}


--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/15427
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I477e5b702c8b956136d93fc1cee01991233e381f
Gerrit-Change-Number: 15427
Gerrit-PatchSet: 8
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in ...osmo-pcu[master]: tests: TbfTest: Unify stderr and stdout to ease debugging

[pespin]

pespin has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/15452 )

Change subject: tests: TbfTest: Unify stderr and stdout to ease debugging
..

tests: TbfTest: Unify stderr and stdout to ease debugging

osmo-pcu code is really verbose, and since log lines printing start and
end of tests are sent to a different file, it's really difficult to
understand which test outputs what.

Change-Id: I3e887158e2c9585c360d44f12f995f55861170f2
---
M tests/Makefile.am
M tests/tbf/TbfTest.cpp
M tests/tbf/TbfTest.err
D tests/tbf/TbfTest.ok
M tests/testsuite.at
5 files changed, 153 insertions(+), 154 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  lynxis lazus: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/tests/Makefile.am b/tests/Makefile.am
index 42dade9..c599636 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -138,7 +138,7 @@
testsuite.at $(srcdir)/package.m4 $(TESTSUITE)  \
rlcmac/RLCMACTest.ok rlcmac/RLCMACTest.err \
alloc/AllocTest.ok alloc/AllocTest.err \
-   tbf/TbfTest.ok tbf/TbfTest.err \
+   tbf/TbfTest.err \
bitcomp/BitcompTest.ok bitcomp/BitcompTest.err \
types/TypesTest.ok types/TypesTest.err \
ms/MsTest.ok ms/MsTest.err alloc/MslotTest.ok \
diff --git a/tests/tbf/TbfTest.cpp b/tests/tbf/TbfTest.cpp
index 8d1b344..5bf94b5 100644
--- a/tests/tbf/TbfTest.cpp
+++ b/tests/tbf/TbfTest.cpp
@@ -61,12 +61,12 @@
 static void test_tbf_base()
 {

-   printf("=== start %s ===\n", __func__);
+   fprintf(stderr, "=== start %s ===\n", __func__);

OSMO_ASSERT(GPRS_RLCMAC_DL_TBF == reverse(GPRS_RLCMAC_UL_TBF));
OSMO_ASSERT(GPRS_RLCMAC_UL_TBF == reverse(GPRS_RLCMAC_DL_TBF));

-   printf("=== end %s ===\n", __func__);
+   fprintf(stderr, "=== end %s ===\n", __func__);
 }

 static void test_tbf_tlli_update()
@@ -74,7 +74,7 @@
BTS the_bts;
GprsMs *ms, *ms_new;

-   printf("=== start %s ===\n", __func__);
+   fprintf(stderr, "=== start %s ===\n", __func__);

the_bts.bts_data()->alloc_algorithm = alloc_algorithm_a;
the_bts.bts_data()->trx[0].pdch[2].enable();
@@ -134,7 +134,7 @@
OSMO_ASSERT(ul_tbf->ta() == 6);
OSMO_ASSERT(dl_tbf->ta() == 6);

-   printf("=== end %s ===\n", __func__);
+   fprintf(stderr, "=== end %s ===\n", __func__);
 }

 static uint8_t llc_data[200];
@@ -241,7 +241,7 @@

uint8_t rbb[64/8];

-   printf("=== start %s ===\n", __func__);
+   fprintf(stderr, "=== start %s ===\n", __func__);

gprs_rlcmac_dl_tbf *dl_tbf;
gprs_rlcmac_tbf *new_tbf;
@@ -297,7 +297,7 @@
OSMO_ASSERT(ms->dl_tbf() == NULL);
}

-   printf("=== end %s ===\n", __func__);
+   fprintf(stderr, "=== end %s ===\n", __func__);
 }

 /* Receive an ACK */
@@ -322,7 +322,7 @@

gprs_rlcmac_dl_tbf *dl_tbf;

-   printf("=== start %s ===\n", __func__);
+   fprintf(stderr, "=== start %s ===\n", __func__);

bts = the_bts.bts_data();

@@ -373,7 +373,7 @@
TBF_SET_ASS_STATE_DL(dl_tbf, GPRS_RLCMAC_DL_ASS_NONE);
check_tbf(dl_tbf);
tbf_free(dl_tbf);
-   printf("=== end %s ===\n", __func__);
+   fprintf(stderr, "=== end %s ===\n", __func__);
 }

 static void test_tbf_imsi()
@@ -386,7 +386,7 @@

gprs_rlcmac_dl_tbf *dl_tbf[2];

-   printf("=== start %s ===\n", __func__);
+   fprintf(stderr, "=== start %s ===\n", __func__);

setup_bts(_bts, ts_no);

@@ -431,7 +431,7 @@
ms1 = the_bts.ms_store().get_ms(0, 0, "0010012");
OSMO_ASSERT(ms1 == NULL);

-   printf("=== end %s ===\n", __func__);
+   fprintf(stderr, "=== end %s ===\n", __func__);
 }

 static void test_tbf_exhaustion()
@@ -445,7 +445,7 @@

uint8_t buf[256] = {0};

-   printf("=== start %s ===\n", __func__);
+   fprintf(stderr, "=== start %s ===\n", __func__);

bssgp_nsi = gprs_ns_instantiate(_bssgp_ns_cb, tall_pcu_ctx);
if (!bssgp_nsi) {
@@ -472,7 +472,7 @@
}

OSMO_ASSERT(rc == -EBUSY);
-   printf("=== end %s ===\n", __func__);
+   fprintf(stderr, "=== end %s ===\n", __func__);

gprs_bssgp_destroy();
 }
@@ -497,7 +497,7 @@
abort();
}

-   printf("=== start %s ===\n", __func__);
+   fprintf(stderr, "=== start %s ===\n", __func__);

bts = the_bts.bts_data();
setup_bts(_bts, ts_no);
@@ -550,13 +550,13 @@
msg = ms->dl_tbf()->create_dl_acked_block(fn += 4, 7);
fprintf(stderr, "MSG = %s\n", msgb_hexdump(msg));
if (!msgb_eq_data_print(msg, exp[expected_data - 1], 
GSM_MACBLOCK_LEN))
-   printf("%s failed at %u\n", __func__, expected_data);
+   fprintf(stderr, "%s failed at %u\n", __func__, 
expected_data);
 
expected_data += 1;

Change in ...osmo-pcu[master]: Use osmo_tdef to implement T3190

[pespin]

pespin has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/15451 )

Change subject: Use osmo_tdef to implement T3190
..

Use osmo_tdef to implement T3190

Change-Id: I0c767c526398d98ca47ef98fdaccfc23af11fb0d
---
M src/bts.cpp
M src/bts.h
M src/gprs_rlcmac_sched.cpp
3 files changed, 4 insertions(+), 6 deletions(-)

Approvals:
  laforge: Looks good to me, but someone else must approve
  lynxis lazus: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/bts.cpp b/src/bts.cpp
index 2600d72..ae6117e 100644
--- a/src/bts.cpp
+++ b/src/bts.cpp
@@ -79,6 +79,7 @@
 static struct osmo_tdef T_defs_pcu[] = {
{ .T=1, .default_val=30,  .unit=OSMO_TDEF_S,  .desc="BSSGP 
(un)blocking procedures timer (s)",  .val=0 },
{ .T=2, .default_val=30,  .unit=OSMO_TDEF_S,  .desc="BSSGP reset 
procedure timer (s)",  .val=0 },
+   { .T=3190,  .default_val=5,   .unit=OSMO_TDEF_S,  .desc="Return to 
packet idle mode after Packet DL Assignment on CCCH (s)", .val=0},
{ .T=-2000, .default_val=2,   .unit=OSMO_TDEF_MS, .desc="Tbf reject for 
PRR timer (ms)",.val=0 },
{ .T=-2001, .default_val=2,   .unit=OSMO_TDEF_S,  .desc="PACCH 
assignment timer (s)",   .val=0 },
{ .T=-2002, .default_val=200, .unit=OSMO_TDEF_MS, .desc="Waiting after 
IMM.ASS confirm timer (ms)", .val=0 },
diff --git a/src/bts.h b/src/bts.h
index 6af6d52..5e7eeae 100644
--- a/src/bts.h
+++ b/src/bts.h
@@ -271,10 +271,6 @@
STAT_MS_PRESENT,
};

-   enum {
-   TIMER_T3190_MSEC = 5000,
-   };
-
BTS();
~BTS();
void cleanup();
diff --git a/src/gprs_rlcmac_sched.cpp b/src/gprs_rlcmac_sched.cpp
index 7356523..da54d9f 100644
--- a/src/gprs_rlcmac_sched.cpp
+++ b/src/gprs_rlcmac_sched.cpp
@@ -247,8 +247,9 @@
uint8_t ts, uint32_t fn, 
int age)
 {
const gprs_rlc_dl_window *w = tbf->window();
-   int age_thresh1 = msecs_to_frames(200),
-   age_thresh2 = msecs_to_frames(OSMO_MIN(BTS::TIMER_T3190_MSEC/2, 
bts->dl_tbf_idle_msec));
+   unsigned long msecs = osmo_tdef_get(bts->T_defs_pcu, 3190, 
OSMO_TDEF_MS, -1);
+   int age_thresh1 = msecs_to_frames(200);
+   int age_thresh2 = msecs_to_frames(OSMO_MIN(msecs/2, 
bts->dl_tbf_idle_msec));

if (tbf->is_control_ts(ts) && tbf->need_control_ts())
return DL_PRIO_CONTROL;

--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/15451
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I0c767c526398d98ca47ef98fdaccfc23af11fb0d
Gerrit-Change-Number: 15451
Gerrit-PatchSet: 5
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in ...osmo-ttcn3-hacks[master]: bts: test for "logging filter sapi"

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15540 )

Change subject: bts: test for "logging filter sapi"
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/15540/1/bts/BTS_Tests.ttcn
File bts/BTS_Tests.ttcn:

https://gerrit.osmocom.org/#/c/15540/1/bts/BTS_Tests.ttcn@298
PS1, Line 298:  f_vty_transceive(BTSVTY, "logging disable");
I think logging is always disabled by default, no need for this?



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15540
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I8c7f113eae7a93c6d4943cac9e3f49f153b323b1
Gerrit-Change-Number: 15540
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Mon, 16 Sep 2019 14:20:31 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in ...libosmocore[master]: logging.h: add SAPI related context and filter

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/15538 )

Change subject: logging.h: add SAPI related context and filter
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15538
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I814cb3328d99faca9220adb5a80ffb934f219d7d
Gerrit-Change-Number: 15538
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Mon, 16 Sep 2019 14:16:09 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in ...osmo-bts[master]: vty: add "logging filter sapi" command

[fixeria]

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/15539 )

Change subject: vty: add "logging filter sapi" command
..


Patch Set 2:

It's a bit confusing to see that you're adding VTY commands and the related 
logic, and starting to use the logging context for PCU related code in the same 
change. Maybe rather split them up?


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15539
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I6b7bb2e1d61502b61214f854a4ec5cbb7267545b
Gerrit-Change-Number: 15539
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Mon, 16 Sep 2019 14:10:46 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in ...osmo-iuh[master]: iu_client: introduce ranap_iu_tx_release_free()

[lynxis lazus]

lynxis lazus has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/c/osmo-iuh/+/15473 )

Change subject: iu_client: introduce ranap_iu_tx_release_free()
..

iu_client: introduce ranap_iu_tx_release_free()

ranap_iu_tx_release_free is a fire and forget function to release
gracefully if possible. It first sends a Iu Release Command. After
a certain timeout the connection will be released.

Change-Id: I349e2c61ba0131e233b7ab927dfced0bd461dd8f
---
M TODO-RELEASE
M include/osmocom/ranap/iu_client.h
M src/iu_client.c
3 files changed, 28 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, approved



diff --git a/TODO-RELEASE b/TODO-RELEASE
index 41d04bc..bcbf5de 100644
--- a/TODO-RELEASE
+++ b/TODO-RELEASE
@@ -8,3 +8,4 @@
 # If any interfaces have been removed or changed since the last public 
release: c:r:0.
 #library   whatdescription / commit summary line
 libranapiu_client.h struct ranap_ue_conn_ctx: add field notification
+libranapiu_client.h struct ranap_ue_conn_ctx: add field release_timeout
diff --git a/include/osmocom/ranap/iu_client.h 
b/include/osmocom/ranap/iu_client.h
index b388529..a93fff3 100644
--- a/include/osmocom/ranap/iu_client.h
+++ b/include/osmocom/ranap/iu_client.h
@@ -31,6 +31,8 @@
struct gprs_ra_id ra_id;
enum ranap_nsap_addr_enc rab_assign_addr_enc;
bool notification; /* send notification to the upstream user */
+   /* Will be set when the Iu Release Command has been sent */
+   struct osmo_timer_list release_timeout;
 };

 enum ranap_iu_event_type {
@@ -71,6 +73,13 @@
 int ranap_iu_tx_common_id(struct ranap_ue_conn_ctx *ue_ctx, const char *imsi);
 int ranap_iu_tx_release(struct ranap_ue_conn_ctx *ctx, const struct 
RANAP_Cause *cause);

+/* transmit a Iu Release Command and free the ctx afterwards.
+ * If a Release Complete is not received within timeout s,
+ * release the SCCP connection. */
+void ranap_iu_tx_release_free(struct ranap_ue_conn_ctx *ctx,
+ const struct RANAP_Cause *cause,
+ int timeout);
+
 /* freeing the UE will release all resources
  * This will close the SCCP connection connected to the UE */
 void ranap_iu_free_ue(struct ranap_ue_conn_ctx *ue_ctx);
diff --git a/src/iu_client.c b/src/iu_client.c
index 38c8a1d..e4eb83e 100644
--- a/src/iu_client.c
+++ b/src/iu_client.c
@@ -129,6 +129,9 @@
ctx->rnc = rnc;
ctx->conn_id = conn_id;
ctx->notification = true;
+   osmo_timer_setup(>release_timeout,
+(void *)(void *) ranap_iu_free_ue,
+ctx);
llist_add(>list, _conn_ctx_list);

return ctx;
@@ -150,6 +153,7 @@
if (!ue_ctx)
return;

+   osmo_timer_del(_ctx->release_timeout);
osmo_sccp_tx_disconn(g_scu, ue_ctx->conn_id, NULL, 0);
llist_del(_ctx->list);
talloc_free(ue_ctx);
@@ -491,6 +495,20 @@
return osmo_sccp_user_sap_down(g_scu, >oph);
 }

+void ranap_iu_tx_release_free(struct ranap_ue_conn_ctx *ctx,
+const struct RANAP_Cause *cause,
+int timeout)
+{
+   ctx->notification = false;
+   int ret = ranap_iu_tx_release(ctx, cause);
+   if (ret) {
+   ranap_iu_free_ue(ctx);
+   return;
+   }
+
+   osmo_timer_schedule(>release_timeout, timeout, 0);
+}
+
 static int ranap_handle_co_iu_rel_req(struct ranap_ue_conn_ctx *ctx, 
RANAP_Iu_ReleaseRequestIEs_t *ies)
 {
LOGPIU(LOGL_INFO, "Received Iu Release Request, Sending Release 
Command\n");

--
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/15473
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: I349e2c61ba0131e233b7ab927dfced0bd461dd8f
Gerrit-Change-Number: 15473
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in ...osmo-ttcn3-hacks[master]: sgsn: replace variable gb_idx with ran_index

[lynxis lazus]

lynxis lazus has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15529 )

Change subject: sgsn: replace variable gb_idx with ran_index
..

sgsn: replace variable gb_idx with ran_index

Since gb_idx also been used for Iu connection,
rename the variable to ran_index.
Be consistent and use the same variable name everywhere.

Change-Id: Ia119feee6a442c76dc337e75c07f4a385cd5e1df
---
M sgsn/SGSN_Tests.ttcn
M sgsn/SGSN_Tests_Iu.ttcn
2 files changed, 55 insertions(+), 55 deletions(-)

Approvals:
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn
index 084f167..10e98a8 100644
--- a/sgsn/SGSN_Tests.ttcn
+++ b/sgsn/SGSN_Tests.ttcn
@@ -486,11 +486,11 @@
f_cleanup();
 }

-friend function is_gb(integer gb_idx) return boolean {
-   return gb_idx < NUM_GB;
+friend function is_gb(integer ran_index) return boolean {
+   return ran_index < NUM_GB;
 }
-friend function is_iu(integer gb_idx) return boolean {
-   return gb_idx >= NUM_GB;
+friend function is_iu(integer ran_index) return boolean {
+   return ran_index >= NUM_GB;
 }

 function f_send_llc(template (value) PDU_LLC llc_pdu, integer ran_index := 0) 
runs on BSSGP_ConnHdlr {
@@ -552,38 +552,38 @@
}
 }

-altstep as_mm_identity(integer gb_idx := 0) runs on BSSGP_ConnHdlr {
+altstep as_mm_identity(integer ran_index := 0) runs on BSSGP_ConnHdlr {
var MobileL3_CommonIE_Types.MobileIdentityLV mi;
-   [is_gb(gb_idx)] BSSGP[gb_idx].receive(tr_GMM_ID_REQ('001'B)) {
+   [is_gb(ran_index)] BSSGP[ran_index].receive(tr_GMM_ID_REQ('001'B)) {
mi := valueof(ts_MI_IMSI_LV(g_pars.imsi));
-   f_send_l3(ts_GMM_ID_RESP(mi), gb_idx);
+   f_send_l3(ts_GMM_ID_RESP(mi), ran_index);
repeat;
}
-   [is_iu(gb_idx)] BSSAP.receive(tr_PDU_DTAP_PS_MT(tr_GMM_ID_REQ('001'B))) 
{
+   [is_iu(ran_index)] 
BSSAP.receive(tr_PDU_DTAP_PS_MT(tr_GMM_ID_REQ('001'B))) {
mi := valueof(ts_MI_IMSI_LV(g_pars.imsi));
-   f_send_l3(ts_GMM_ID_RESP(mi), gb_idx);
+   f_send_l3(ts_GMM_ID_RESP(mi), ran_index);
repeat;
}
-   [is_gb(gb_idx)] BSSGP[gb_idx].receive(tr_GMM_ID_REQ('010'B)) {
+   [is_gb(ran_index)] BSSGP[ran_index].receive(tr_GMM_ID_REQ('010'B)) {
mi := valueof(ts_MI_IMEI_LV(g_pars.imei));
-   f_send_l3(ts_GMM_ID_RESP(mi), gb_idx);
+   f_send_l3(ts_GMM_ID_RESP(mi), ran_index);
repeat;
}
-   [is_iu(gb_idx)] BSSAP.receive(tr_PDU_DTAP_PS_MT(tr_GMM_ID_REQ('010'B))) 
{
+   [is_iu(ran_index)] 
BSSAP.receive(tr_PDU_DTAP_PS_MT(tr_GMM_ID_REQ('010'B))) {
mi := valueof(ts_MI_IMEI_LV(g_pars.imei));
-   f_send_l3(ts_GMM_ID_RESP(mi), gb_idx);
+   f_send_l3(ts_GMM_ID_RESP(mi), ran_index);
repeat;
}
 }

 /* receive a L3 (GMM/SM) message over whatever is the appropriate lower-layer 
bearer */
-function f_receive_l3(template PDU_L3_SGSN_MS rx_tpl := ?, integer gb_idx := 0)
+function f_receive_l3(template PDU_L3_SGSN_MS rx_tpl := ?, integer ran_index 
:= 0)
 runs on BSSGP_ConnHdlr return PDU_L3_SGSN_MS {
var PDU_DTAP_PS_MT mt;
var PDU_L3_SGSN_MS l3_mt;
alt {
-   [is_gb(gb_idx)] BSSGP[gb_idx].receive(rx_tpl) -> value l3_mt { }
-   [is_iu(gb_idx)] BSSAP.receive(tr_PDU_DTAP_PS_MT(rx_tpl)) -> value mt {
+   [is_gb(ran_index)] BSSGP[ran_index].receive(rx_tpl) -> value l3_mt { }
+   [is_iu(ran_index)] BSSAP.receive(tr_PDU_DTAP_PS_MT(rx_tpl)) -> value mt 
{
l3_mt := mt.dtap;
}
}
@@ -593,10 +593,10 @@
 /* perform GMM authentication (if expected).
  * Note, for umts_aka_challenge to work, the revisionLevelIndicatior needs to
  * be 1 to mark R99 capability, in the GMM Attach Request, see f_gmm_attach(). 
*/
-function f_gmm_auth (boolean umts_aka_challenge := false, boolean 
force_gsm_sres := false, integer gb_idx := 0) runs on BSSGP_ConnHdlr {
+function f_gmm_auth (boolean umts_aka_challenge := false, boolean 
force_gsm_sres := false, integer ran_index := 0) runs on BSSGP_ConnHdlr {
var PDU_L3_MS_SGSN l3_mo;
var PDU_L3_SGSN_MS l3_mt;
-   var default di := activate(as_mm_identity(gb_idx));
+   var default di := activate(as_mm_identity(ran_index));
if (g_pars.net.expect_auth) {
var GSUP_IE auth_tuple;
var template AuthenticationParameterAUTNTLV autn;
@@ -631,7 +631,7 @@

var template PDU_L3_SGSN_MS auth_ciph_req := 
tr_GMM_AUTH_REQ(g_pars.vec.rand);

auth_ciph_req.msgs.gprs_mm.authenticationAndCipheringRequest.authenticationParameterAUTN
 := autn;
-   l3_mt := f_receive_l3(auth_ciph_req, gb_idx);
+   l3_mt := f_receive_l3(auth_ciph_req, 

Change in ...osmo-ttcn3-hacks[master]: sgsn: replace variable gb_index with ran_index

[lynxis lazus]

lynxis lazus has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15528 )

Change subject: sgsn: replace variable gb_index with ran_index
..

sgsn: replace variable gb_index with ran_index

Since gb_index also been used for Iu connection,
rename the variable to ran_index.
Be consistent and use the same variable name everywhere.

Change-Id: I06b0c6184daeb886e8bd28d50bf18909d9244dc6
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 7 insertions(+), 7 deletions(-)

Approvals:
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn
index be4283e..084f167 100644
--- a/sgsn/SGSN_Tests.ttcn
+++ b/sgsn/SGSN_Tests.ttcn
@@ -493,16 +493,16 @@
return gb_idx >= NUM_GB;
 }

-function f_send_llc(template (value) PDU_LLC llc_pdu, integer gb_index := 0) 
runs on BSSGP_ConnHdlr {
+function f_send_llc(template (value) PDU_LLC llc_pdu, integer ran_index := 0) 
runs on BSSGP_ConnHdlr {
var octetstring llc_enc := enc_PDU_LLC(valueof(llc_pdu));
-   BSSGP[gb_index].send(ts_BSSGP_UL_UD(g_pars.tlli, 
g_pars.bssgp_cell_id[gb_index], llc_enc));
+   BSSGP[ran_index].send(ts_BSSGP_UL_UD(g_pars.tlli, 
g_pars.bssgp_cell_id[ran_index], llc_enc));
 }

-private function f_send_l3_gmm_llc(template (value) PDU_L3_MS_SGSN l3_mo, 
integer gb_index := 0) runs on BSSGP_ConnHdlr {
+private function f_send_l3_gmm_llc(template (value) PDU_L3_MS_SGSN l3_mo, 
integer ran_index := 0) runs on BSSGP_ConnHdlr {
var octetstring l3_enc := enc_PDU_L3_MS_SGSN(valueof(l3_mo));
var BIT4 sapi := f_llc_sapi_by_l3_mo(valueof(l3_mo));
var integer n_u := f_llc_get_n_u_tx(llc[bit2int(sapi)]);
-   f_send_llc(ts_LLC_UI(l3_enc, sapi, '0'B, n_u), gb_index);
+   f_send_llc(ts_LLC_UI(l3_enc, sapi, '0'B, n_u), ran_index);
 }

 /* trigger sending of a RANAP InitialUE and wait for SCCP connection 
confirmation */
@@ -539,8 +539,8 @@
 }

 /* send a L3 (GMM/SM) message over whatever is the appropriate lower-layer 
bearer */
-function f_send_l3(template (value) PDU_L3_MS_SGSN l3_mo, integer gb_index := 
0) runs on BSSGP_ConnHdlr {
-   if (is_iu(gb_index)) {
+function f_send_l3(template (value) PDU_L3_MS_SGSN l3_mo, integer ran_index := 
0) runs on BSSGP_ConnHdlr {
+   if (is_iu(ran_index)) {
if (g_pars.rnc_send_initial_ue) {
g_pars.rnc_send_initial_ue := false;
f_send_l3_initial_ue(l3_mo);
@@ -548,7 +548,7 @@
BSSAP.send(ts_PDU_DTAP_PS_MO(l3_mo));
}
} else {
-   f_send_l3_gmm_llc(l3_mo, gb_index);
+   f_send_l3_gmm_llc(l3_mo, ran_index);
}
 }


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15528
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I06b0c6184daeb886e8bd28d50bf18909d9244dc6
Gerrit-Change-Number: 15528
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in ...osmo-ttcn3-hacks[master]: sgsn: replace variable bssgp with ran_index

[lynxis lazus]

lynxis lazus has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15399 )

Change subject: sgsn: replace variable bssgp with ran_index
..

sgsn: replace variable bssgp with ran_index

Since bssgp also been used for Iu connection,
rename the variable to ran_index.
Be consistent and use the same variable name everywhere.

Change-Id: Ib278410bc49f07387873740ed8b411a815d940a8
---
M sgsn/SGSN_Tests.ttcn
M sgsn/SGSN_Tests_Iu.ttcn
2 files changed, 15 insertions(+), 15 deletions(-)

Approvals:
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn
index 10e98a8..d96767a 100644
--- a/sgsn/SGSN_Tests.ttcn
+++ b/sgsn/SGSN_Tests.ttcn
@@ -2362,44 +2362,44 @@
f_cleanup();
 }

-friend function f_routing_area_update(RoutingAreaIdentificationV ra, integer 
bssgp := 0) runs on BSSGP_ConnHdlr {
+friend function f_routing_area_update(RoutingAreaIdentificationV ra, integer 
ran_index := 0) runs on BSSGP_ConnHdlr {
var PDU_L3_SGSN_MS l3_mt;
var PDU_DTAP_PS_MT mt;
var template OCT4 p_tmsi := omit;
 
-   if (is_iu(bssgp)) {
+   if (is_iu(ran_index)) {
p_tmsi := g_pars.p_tmsi;
}
/* then send RAU */
-   f_send_l3(ts_GMM_RAU_REQ(f_mi_get_lv(), GPRS_UPD_T_RA, g_pars.ra, 
false, omit, omit, p_tmsi), bssgp);
+   f_send_l3(ts_GMM_RAU_REQ(f_mi_get_lv(), GPRS_UPD_T_RA, g_pars.ra, 
false, omit, omit, p_tmsi), ran_index);
alt {
-   [is_gb(bssgp)] BSSGP[bssgp].receive(tr_GMM_RAU_ACCEPT) -> value l3_mt {
-   
f_process_rau_accept(l3_mt.msgs.gprs_mm.routingAreaUpdateAccept, bssgp);
-   f_send_l3(ts_GMM_RAU_COMPL, bssgp);
+   [is_gb(ran_index)] BSSGP[ran_index].receive(tr_GMM_RAU_ACCEPT) -> value 
l3_mt {
+   
f_process_rau_accept(l3_mt.msgs.gprs_mm.routingAreaUpdateAccept, ran_index);
+   f_send_l3(ts_GMM_RAU_COMPL, ran_index);
setverdict(pass);
}
-   [is_iu(bssgp)] BSSAP.receive(tr_PDU_DTAP_PS_MT(tr_GMM_RAU_ACCEPT)) -> 
value mt {
-   
f_process_rau_accept(mt.dtap.msgs.gprs_mm.routingAreaUpdateAccept, bssgp);
-   f_send_l3(ts_GMM_RAU_COMPL, bssgp);
+   [is_iu(ran_index)] BSSAP.receive(tr_PDU_DTAP_PS_MT(tr_GMM_RAU_ACCEPT)) 
-> value mt {
+   
f_process_rau_accept(mt.dtap.msgs.gprs_mm.routingAreaUpdateAccept, ran_index);
+   f_send_l3(ts_GMM_RAU_COMPL, ran_index);
setverdict(pass);
}

-   [is_gb(bssgp)] BSSGP[bssgp].receive(tr_GMM_RAU_REJECT) {
+   [is_gb(ran_index)] BSSGP[ran_index].receive(tr_GMM_RAU_REJECT) {
setverdict(fail, "Unexpected RAU Reject");
mtc.stop;
}
-   [is_iu(bssgp)] BSSAP.receive(tr_PDU_DTAP_PS_MT(tr_GMM_RAU_REJECT)) {
+   [is_iu(ran_index)] BSSAP.receive(tr_PDU_DTAP_PS_MT(tr_GMM_RAU_REJECT)) {
setverdict(fail, "Unexpected RAU Reject");
mtc.stop;
}

-   [is_iu(bssgp)] BSSAP.receive(tr_RANAP_SecurityModeCmd(uia_algs := ?, 
uia_key := oct2bit(g_pars.vec.ik),
+   [is_iu(ran_index)] BSSAP.receive(tr_RANAP_SecurityModeCmd(uia_algs := 
?, uia_key := oct2bit(g_pars.vec.ik),
key_sts := ?)) {
var IntegrityProtectionAlgorithm uia_chosen := 0; /* 0 
= standard_UMTS_integrity_algorithm_UIA1 */
BSSAP.send(ts_RANAP_SecurityModeComplete(uia_chosen));
}
-   [is_gb(bssgp)] BSSGP[bssgp].receive { repeat; }
-   [is_iu(bssgp)] BSSAP.receive { repeat; }
+   [is_gb(ran_index)] BSSGP[ran_index].receive { repeat; }
+   [is_iu(ran_index)] BSSAP.receive { repeat; }
}
 }

diff --git a/sgsn/SGSN_Tests_Iu.ttcn b/sgsn/SGSN_Tests_Iu.ttcn
index 472774e..786961f 100644
--- a/sgsn/SGSN_Tests_Iu.ttcn
+++ b/sgsn/SGSN_Tests_Iu.ttcn
@@ -66,7 +66,7 @@
f_gmm_attach(umts_aka_challenge := true, force_gsm_sres := false, 
ran_index := 0);

/* do a routing area update */
-   f_routing_area_update(g_pars.ra, bssgp := 3);
+   f_routing_area_update(g_pars.ra, ran_index := 3);
setverdict(pass);
 }


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15399
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib278410bc49f07387873740ed8b411a815d940a8
Gerrit-Change-Number: 15399
Gerrit-PatchSet: 6
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in ...osmo-ttcn3-hacks[master]: sgsn: replace variable bssgp_index with ran_index

[lynxis lazus]

lynxis lazus has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15400 )

Change subject: sgsn: replace variable bssgp_index with ran_index
..

sgsn: replace variable bssgp_index with ran_index

Since bssgp_index also been used for Iu connection,
rename the variable to ran_index.

Change-Id: Iec2e8510b749602f0ebb9b4976957c9c5ce3f307
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 10 insertions(+), 10 deletions(-)

Approvals:
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn
index 182cbd2..be4283e 100644
--- a/sgsn/SGSN_Tests.ttcn
+++ b/sgsn/SGSN_Tests.ttcn
@@ -671,12 +671,12 @@
deactivate(di);
 }

-function f_upd_ptmsi_and_tlli(OCT4 p_tmsi, integer bssgp_index := 0) runs on 
BSSGP_ConnHdlr {
+function f_upd_ptmsi_and_tlli(OCT4 p_tmsi, integer ran_index := 0) runs on 
BSSGP_ConnHdlr {
g_pars.p_tmsi := p_tmsi;
/* update TLLI */
g_pars.tlli_old := g_pars.tlli;
g_pars.tlli := g_pars.p_tmsi or4b 'c000'O;
-   f_bssgp_client_llgmm_assign(g_pars.tlli_old, g_pars.tlli, 
BSSGP_PROC[bssgp_index]);
+   f_bssgp_client_llgmm_assign(g_pars.tlli_old, g_pars.tlli, 
BSSGP_PROC[ran_index]);
 }

 function f_process_attach_accept(PDU_GMM_AttachAccept aa) runs on 
BSSGP_ConnHdlr {
@@ -708,7 +708,7 @@
/* T3302, T3319, T3323, T3312_ext, T3324 */
 }

-function f_process_rau_accept(PDU_GMM_RoutingAreaUpdateAccept ra, integer 
bssgp_index := 0) runs on BSSGP_ConnHdlr {
+function f_process_rau_accept(PDU_GMM_RoutingAreaUpdateAccept ra, integer 
ran_index := 0) runs on BSSGP_ConnHdlr {
/* mandatory IE */
g_pars.ra := ra.routingAreaId;
if (ispresent(ra.allocatedPTMSI)) {
@@ -716,7 +716,7 @@
setverdict(fail, "unexpected P-TMSI allocation");
mtc.stop;
}
-   
f_upd_ptmsi_and_tlli(ra.allocatedPTMSI.mobileIdentityLV.mobileIdentityV.oddEvenInd_identity.tmsi_ptmsi.octets,
 bssgp_index);
+   
f_upd_ptmsi_and_tlli(ra.allocatedPTMSI.mobileIdentityLV.mobileIdentityV.oddEvenInd_identity.tmsi_ptmsi.octets,
 ran_index);
}
if (ispresent(ra.msIdentity)) {
setverdict(fail, "unexpected TMSI allocation in non-combined 
attach");
@@ -1094,10 +1094,10 @@
 }

 /* general GPRS DETACH helper */
-function f_detach_mo(BIT3 detach_type, boolean power_off, boolean 
expect_purge, integer bssgp_index := 0) runs on BSSGP_ConnHdlr {
+function f_detach_mo(BIT3 detach_type, boolean power_off, boolean 
expect_purge, integer ran_index := 0) runs on BSSGP_ConnHdlr {
var PDU_L3_SGSN_MS l3_mt;
timer T := 5.0;
-   f_send_l3(ts_GMM_DET_REQ_MO(detach_type, power_off), bssgp_index);
+   f_send_l3(ts_GMM_DET_REQ_MO(detach_type, power_off), ran_index);
if (expect_purge) {
GSUP.receive(tr_GSUP_PURGE_MS_REQ(g_pars.imsi, 
OSMO_GSUP_CN_DOMAIN_PS));
GSUP.send(ts_GSUP_PURGE_MS_RES(g_pars.imsi));
@@ -1108,7 +1108,7 @@
setverdict(fail, "Unexpected GSUP PURGE MS for unregistered 
TLLI");
mtc.stop;
}
-   [power_off] BSSGP[bssgp_index].receive(tr_GMM_DET_ACCEPT_MT) -> value 
l3_mt {
+   [power_off] BSSGP[ran_index].receive(tr_GMM_DET_ACCEPT_MT) -> value 
l3_mt {
g_pars.ra := omit;
setverdict(fail, "Unexpected DETACH ACCEPT in power-off 
DETACH");
mtc.stop;
@@ -1117,12 +1117,12 @@
[power_off] T.timeout {
setverdict(pass);
}
-   [not power_off] BSSGP[bssgp_index].receive(tr_GMM_DET_ACCEPT_MT) -> 
value l3_mt {
+   [not power_off] BSSGP[ran_index].receive(tr_GMM_DET_ACCEPT_MT) -> value 
l3_mt {
g_pars.ra := omit;
setverdict(pass);
/* TODO: check if any PDP contexts are deactivated on network 
side? */
}
-   [] BSSGP[bssgp_index].receive(PDU_L3_SGSN_MS:?) -> value l3_mt {
+   [] BSSGP[ran_index].receive(PDU_L3_SGSN_MS:?) -> value l3_mt {
if (power_off) {
setverdict(fail, "Unexpected Layer 3 package received 
in power-off DETACH");
} else {
@@ -1130,7 +1130,7 @@
}
mtc.stop;
}
-   [] BSSGP[bssgp_index].receive { repeat; }
+   [] BSSGP[ran_index].receive { repeat; }
}
 }


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15400
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iec2e8510b749602f0ebb9b4976957c9c5ce3f307
Gerrit-Change-Number: 15400
Gerrit-PatchSet: 5
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: pespin 

Change in ...osmo-bts[master]: vty: add "logging filter sapi" command

[osmith]

Hello pespin, fixeria,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bts/+/15539

to look at the new patch set (#2).

Change subject: vty: add "logging filter sapi" command
..

vty: add "logging filter sapi" command

Set the PCU interface data as log context, and add VTY commands to
filter by SAPI. Allow to filter by multiple SAPIs by running the filter
command multiple times:

OsmoBTS> logging filter sapi agch
OsmoBTS> logging filter sapi pch

Related: OS#2356
Test: (osmo-ttcn3-hacks) I8c7f113eae7a93c6d4943cac9e3f49f153b323b1
Depends: (libosmocore) I814cb3328d99faca9220adb5a80ffb934f219d7d
Change-Id: I6b7bb2e1d61502b61214f854a4ec5cbb7267545b
---
M src/common/logging.c
M src/common/pcu_sock.c
M src/common/vty.c
3 files changed, 86 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/39/15539/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15539
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I6b7bb2e1d61502b61214f854a4ec5cbb7267545b
Gerrit-Change-Number: 15539
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-CC: Jenkins Builder
Gerrit-MessageType: newpatchset

Change in ...osmo-ttcn3-hacks[master]: bts: test for "logging filter sapi"

[osmith]

osmith has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15540


Change subject: bts: test for "logging filter sapi"
..

bts: test for "logging filter sapi"

Related: OS#2356
Change-Id: I8c7f113eae7a93c6d4943cac9e3f49f153b323b1
---
M bts/BTS_Tests.ttcn
1 file changed, 48 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/40/15540/1

diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index 2c11ca2..72dde30 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -295,6 +295,7 @@
 friend function f_init_vty(charstring id) runs on test_CT {
map(self:BTSVTY, system:BTSVTY);
f_vty_set_prompts(BTSVTY);
+   f_vty_transceive(BTSVTY, "logging disable");
f_vty_transceive(BTSVTY, "enable");
 }

@@ -6153,6 +6154,51 @@
IPA_Testing.f_run_TC_chopped_ipa_payload(mp_rsl_ip, mp_rsl_port, 
LISTEN_FOR_CLIENT);
 }

+
+private function f_vty_log_fltr_sapi_pcu_data_req(TELNETasp_PT pt, PCUIF_Sapi 
sapi, charstring sapi_str,
+   boolean visible := true) 
runs on test_CT {
+   var charstring buffer;
+   template charstring exp := pattern "*sapi=" & sapi_str & "*";
+
+   f_vty_transceive(pt, ""); /* clear buffer */
+   f_pcu_data_req(0, 0, 7, 0, 0, sapi, c_PCU_DATA);
+   f_sleep(0.1);
+
+   buffer := f_vty_transceive_ret(pt, "");
+   if (visible and not match(buffer, exp)) {
+   setverdict(fail, "Could not find ", exp, " in buffer: ", 
buffer);
+   mtc.stop;
+   } else if (not visible and match(buffer, exp)) {
+   setverdict(fail, "Found ", exp, " in buffer, although it should 
not have matched: ", buffer);
+   mtc.stop;
+   }
+}
+
+private function f_vty_log_fltr_sapi_test_log(TELNETasp_PT pt, charstring cmd, 
boolean agch_exp, boolean pch_exp)
+runs on test_CT {
+   log("Testing log output after VTY command: ", cmd);
+   f_vty_transceive(pt, cmd);
+   f_vty_log_fltr_sapi_pcu_data_req(pt, PCU_IF_SAPI_AGCH, "AGCH", 
agch_exp);
+   f_vty_log_fltr_sapi_pcu_data_req(pt, PCU_IF_SAPI_PCH, "PCH", pch_exp);
+}
+
+testcase TC_vty_log_fltr_sapi() runs on test_CT {
+   f_init();
+   f_vty_transceive(BTSVTY, "logging enable");
+   f_vty_transceive(BTSVTY, "logging color 0");
+
+   /* self test */
+   f_vty_log_fltr_sapi_test_log(BTSVTY, "logging level set-all fatal", 
false, false);
+   f_vty_log_fltr_sapi_test_log(BTSVTY, "logging level pcu debug", true, 
true);
+
+   f_vty_log_fltr_sapi_test_log(BTSVTY, "logging filter sapi agch", true, 
false);
+   f_vty_log_fltr_sapi_test_log(BTSVTY, "logging filter sapi pch", true, 
true);
+   f_vty_log_fltr_sapi_test_log(BTSVTY, "no logging filter sapi agch", 
false, true);
+
+   f_vty_transceive(BTSVTY, "logging disable");
+   setverdict(pass);
+}
+
 /* test generation of RLL ERR IND based on Um errors (TS 48.058 3.9) */
 /* protocol error as per 44.006 */
 /* link layer failure (repetition of I-frame N200 times without ACK */
@@ -6320,6 +6366,8 @@

execute( TC_chopped_ipa_ping() );
execute( TC_chopped_ipa_payload() );
+
+   execute( TC_vty_log_fltr_sapi() );
 }



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15540
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I8c7f113eae7a93c6d4943cac9e3f49f153b323b1
Gerrit-Change-Number: 15540
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-MessageType: newchange

Change in ...osmo-bts[master]: vty: add "logging filter sapi" command

[osmith]

osmith has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/15539


Change subject: vty: add "logging filter sapi" command
..

vty: add "logging filter sapi" command

Set the PCU interface data as log context, and add VTY commands to
filter by SAPI. Allow to filter by multiple SAPIs by running the filter
command multiple times:

OsmoBTS> logging filter sapi agch
OsmoBTS> logging filter sapi pch

Related: OS#2356
Test: (osmo-ttcn3-hacks) I8c7f113eae7a93c6d4943cac9e3f49f153b323b1
Depends: (libosmocore) I814cb3328d99faca9220adb5a80ffb934f219d7d
Change-Id: I6b7bb2e1d61502b61214f854a4ec5cbb7267545b
---
M src/common/logging.c
M src/common/pcu_sock.c
M src/common/vty.c
3 files changed, 87 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/39/15539/1

diff --git a/src/common/logging.c b/src/common/logging.c
index 3315a01..ace0341 100644
--- a/src/common/logging.c
+++ b/src/common/logging.c
@@ -29,6 +29,7 @@

 #include 
 #include 
+#include 

 static struct log_info_cat bts_log_info_cat[] = {
[DRSL] = {
@@ -144,7 +145,21 @@
},
 };

+static int filter_fn(const struct log_context *ctx, struct log_target *tgt)
+{
+   const struct gsm_pcu_if_data *pcu_if_data = 
ctx->ctx[LOG_CTX_PCU_IF_DATA];
+   uint16_t *sapi_mask = tgt->filter_data[LOG_FLT_SAPI];
+
+   if ((tgt->filter_map & (1 << LOG_FLT_SAPI)) != 0
+   && sapi_mask && pcu_if_data
+   && (*sapi_mask & (1 << pcu_if_data->sapi)) == 0)
+   return 0;
+
+   return 1;
+}
+
 const struct log_info bts_log_info = {
+   .filter_fn = filter_fn,
.cat = bts_log_info_cat,
.num_cat = ARRAY_SIZE(bts_log_info_cat),
 };
diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c
index ba9e172..7125b01 100644
--- a/src/common/pcu_sock.c
+++ b/src/common/pcu_sock.c
@@ -336,6 +336,7 @@
rts_req->ts_nr = ts->nr;
rts_req->block_nr = block_nr;

+   log_set_context(LOG_CTX_PCU_IF_DATA, (void *)rts_req);
return pcu_sock_send(_gsmnet, msg);
 }

@@ -376,6 +377,7 @@
memcpy(data_ind->data, data, len);
data_ind->len = len;

+   log_set_context(LOG_CTX_PCU_IF_DATA, (void *)data_ind);
return pcu_sock_send(_gsmnet, msg);
 }

@@ -402,6 +404,7 @@
rach_ind->is_11bit = is_11bit;
rach_ind->burst_type = burst_type;

+   log_set_context(LOG_CTX_PCU_IF_DATA, (void *)rach_ind);
return pcu_sock_send(_gsmnet, msg);
 }

@@ -484,6 +487,7 @@
memcpy(data_cnf->data, data, len);
data_cnf->len = len;

+   log_set_context(LOG_CTX_PCU_IF_DATA, (void *)data_cnf);
return pcu_sock_send(_gsmnet, msg);
 }

@@ -513,6 +517,7 @@
struct msgb *msg;
int rc = 0;

+   log_set_context(LOG_CTX_PCU_IF_DATA, (void *)data_req);
LOGP(DPCU, LOGL_DEBUG, "Data request received: sapi=%s arfcn=%d "
"block=%d data=%s\n", sapi_string[data_req->sapi],
data_req->arfcn, data_req->block_nr,
diff --git a/src/common/vty.c b/src/common/vty.c
index 801f34c..e99c889 100644
--- a/src/common/vty.c
+++ b/src/common/vty.c
@@ -1600,6 +1600,71 @@
return CMD_SUCCESS;
 }
 
+
+#define SAPI_STR "Filter log messages by SAPI\n"
+#define SAPI_ARG_STR "SAPI to be used as filter\n"
+#define SAPI_CMD_STR "logging filter sapi 
(rach|agch|pch|bcch|pdtch|prach|ptcch|agch_dt)"
+
+uint16_t parse_sapi_str(const char *sapi) {
+   if (!strcmp(sapi, "rach"))
+   return PCU_IF_SAPI_RACH;
+   else if (!strcmp(sapi, "agch"))
+   return PCU_IF_SAPI_AGCH;
+   else if (!strcmp(sapi, "pch"))
+   return PCU_IF_SAPI_PCH;
+   else if (!strcmp(sapi, "bcch"))
+   return PCU_IF_SAPI_BCCH;
+   else if (!strcmp(sapi, "pdtch"))
+   return PCU_IF_SAPI_PDTCH;
+   else if (!strcmp(sapi, "prach"))
+   return PCU_IF_SAPI_PRACH;
+   else if (!strcmp(sapi, "ptcch"))
+   return PCU_IF_SAPI_PTCCH;
+   else if (!strcmp(sapi, "agch_dt"))
+   return PCU_IF_SAPI_AGCH_DT;
+   return 0;
+}
+
+DEFUN(logging_fltr_sapi,
+  logging_fltr_sapi_cmd,
+  SAPI_CMD_STR,
+  LOGGING_STR FILTER_STR SAPI_STR SAPI_ARG_STR)
+{
+   struct log_target *tgt = osmo_log_vty2tgt(vty);
+   uint16_t **sapi_mask;
+
+   if (!tgt)
+   return CMD_WARNING;
+
+   sapi_mask = (uint16_t **)>filter_data[LOG_FLT_SAPI];
+   if (!*sapi_mask)
+   *sapi_mask = talloc(tgt, uint16_t);
+
+   **sapi_mask |= (1 << parse_sapi_str(argv[0]));
+   tgt->filter_map |= (1 << LOG_FLT_SAPI);
+
+   return CMD_SUCCESS;
+}
+
+DEFUN(no_logging_fltr_sapi,
+  no_logging_fltr_sapi_cmd,
+  "no " SAPI_CMD_STR,
+  NO_STR LOGGING_STR FILTER_STR SAPI_STR SAPI_ARG_STR)
+{
+   struct log_target *tgt = osmo_log_vty2tgt(vty);
+   uint16_t *sapi_mask;
+
+   if 

Change in ...libosmocore[master]: logging.h: add SAPI related context and filter

[osmith]

osmith has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/libosmocore/+/15538


Change subject: logging.h: add SAPI related context and filter
..

logging.h: add SAPI related context and filter

Related: OS#2356
Change-Id: I814cb3328d99faca9220adb5a80ffb934f219d7d
---
M include/osmocom/core/logging.h
1 file changed, 2 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/38/15538/1

diff --git a/include/osmocom/core/logging.h b/include/osmocom/core/logging.h
index 803b4a9..9d06080 100644
--- a/include/osmocom/core/logging.h
+++ b/include/osmocom/core/logging.h
@@ -154,6 +154,7 @@
LOG_CTX_GB_BVC,
LOG_CTX_BSC_SUBSCR,
LOG_CTX_VLR_SUBSCR,
+   LOG_CTX_PCU_IF_DATA, /* contains SAPI */
_LOG_CTX_COUNT
 };

@@ -166,6 +167,7 @@
LOG_FLT_GB_BVC,
LOG_FLT_BSC_SUBSCR,
LOG_FLT_VLR_SUBSCR,
+   LOG_FLT_SAPI,
_LOG_FLT_COUNT
 };


--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15538
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I814cb3328d99faca9220adb5a80ffb934f219d7d
Gerrit-Change-Number: 15538
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-MessageType: newchange

Change in ...docker-playground[master]: sgsn: enable Iu tests

[lynxis lazus]

lynxis lazus has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/c/docker-playground/+/15534 )

Change subject: sgsn: enable Iu tests
..

sgsn: enable Iu tests

All related Iu patches has been merged.
Change-Id: Ic26bcabb8b5192c401ab0bcc6a88b29fa0d3d8da
---
M ttcn3-sgsn-test/SGSN_Tests.cfg
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  pespin: Looks good to me, approved
  lynxis lazus: Verified



diff --git a/ttcn3-sgsn-test/SGSN_Tests.cfg b/ttcn3-sgsn-test/SGSN_Tests.cfg
index 55ea817..f7d6d9a 100644
--- a/ttcn3-sgsn-test/SGSN_Tests.cfg
+++ b/ttcn3-sgsn-test/SGSN_Tests.cfg
@@ -39,4 +39,4 @@

 [EXECUTE]
 SGSN_Tests.control
-#SGSN_Tests_Iu.control
+SGSN_Tests_Iu.control

--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/15534
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: Ic26bcabb8b5192c401ab0bcc6a88b29fa0d3d8da
Gerrit-Change-Number: 15534
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in ...docker-playground[master]: sgsn: enable Iu tests

[lynxis lazus]

lynxis lazus has posted comments on this change. ( 
https://gerrit.osmocom.org/c/docker-playground/+/15534 )

Change subject: sgsn: enable Iu tests
..


Patch Set 1: Verified+1


--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/15534
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: Ic26bcabb8b5192c401ab0bcc6a88b29fa0d3d8da
Gerrit-Change-Number: 15534
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Mon, 16 Sep 2019 13:19:25 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in ...libosmo-abis[master]: ipa: ipa_server_link_close() add checks of link state

[lynxis lazus]

lynxis lazus has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/c/libosmo-abis/+/15387 )

Change subject: ipa: ipa_server_link_close() add checks of link state
..

ipa: ipa_server_link_close() add checks of link state

When closing a link which failed on open,
ipa_server_link_close() would crash it when calling osmo_fd_unregister.

Change-Id: I672d4de25464c3829b08aff26b1a6d4ad92e7684
---
M src/input/ipa.c
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, approved



diff --git a/src/input/ipa.c b/src/input/ipa.c
index 8aed7b3..b4dbcb0 100644
--- a/src/input/ipa.c
+++ b/src/input/ipa.c
@@ -297,6 +297,7 @@

ipa_link->ofd.when |= BSC_FD_READ | BSC_FD_WRITE;
ipa_link->ofd.cb = ipa_server_fd_cb;
+   ipa_link->ofd.fd = -1;
ipa_link->ofd.data = ipa_link;
if (addr)
ipa_link->addr = talloc_strdup(ipa_link, addr);
@@ -326,6 +327,7 @@
link->ofd.fd = ret;
if (osmo_fd_register(>ofd) < 0) {
close(ret);
+   link->ofd.fd = -1;
return -EIO;
}
return 0;
@@ -333,8 +335,12 @@

 void ipa_server_link_close(struct ipa_server_link *link)
 {
+   if (link->ofd.fd == -1)
+   return;
+
osmo_fd_unregister(>ofd);
close(link->ofd.fd);
+   link->ofd.fd = -1;
 }

 static int ipa_server_conn_read(struct ipa_server_conn *conn)

--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/15387
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I672d4de25464c3829b08aff26b1a6d4ad92e7684
Gerrit-Change-Number: 15387
Gerrit-PatchSet: 6
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in ...osmo-trx[master]: Transceiver: Fixed copying of history into and from channelizer buffer.

[timojacobus]

timojacobus has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-trx/+/15413 )

Change subject: Transceiver: Fixed copying of history into and from channelizer 
buffer.
..


Patch Set 2:

> Patch Set 2:
>
> Re-working the patch myself since I asked the author here and over email a 
> few days ago on whether he was planning to work on new versions of the patch 
> and got no answer so far. And since the fix is important I think it makes 
> sense to have it merged asap.

Sorry for late answer, feel free to rework it if it is needed asap.


--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/15413
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I93e43f6868cd67e69fc59d2980a03550d2505bf8
Gerrit-Change-Number: 15413
Gerrit-PatchSet: 2
Gerrit-Owner: timojacobus 
Gerrit-Assignee: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Reviewer: timojacobus 
Gerrit-Reviewer: tnt 
Gerrit-Comment-Date: Mon, 16 Sep 2019 12:32:24 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in ...osmo-bts[master]: bts-trx: Change super verbose IDLE ind not-supported line to DEBUG

[pespin]

pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/15537


Change subject: bts-trx: Change super verbose IDLE ind not-supported line to 
DEBUG
..

bts-trx: Change super verbose IDLE ind not-supported line to DEBUG

It's impossible to see other logging otherwise.

Change-Id: I64ee83b734ecff593ff2a1cf97b192db93228e22
---
M src/osmo-bts-trx/trx_if.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/37/15537/1

diff --git a/src/osmo-bts-trx/trx_if.c b/src/osmo-bts-trx/trx_if.c
index 6c6d5ad..166cfe6 100644
--- a/src/osmo-bts-trx/trx_if.c
+++ b/src/osmo-bts-trx/trx_if.c
@@ -1007,7 +1007,7 @@
 * TDMA frames, and properly drive scheduler if nothing has been
 * detected on non-IDLE channels. */
if (bi.flags & TRX_BI_F_NOPE_IND) {
-   LOGPPHI(l1h->phy_inst, DTRX, LOGL_NOTICE,
+   LOGPPHI(l1h->phy_inst, DTRX, LOGL_DEBUG,
"IDLE / NOPE indications are not (yet) supported\n");
return -ENOTSUP;
}

--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15537
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I64ee83b734ecff593ff2a1cf97b192db93228e22
Gerrit-Change-Number: 15537
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange

Change in ...osmo-pcu[master]: Use osmo_tdef for BSSGP T1 and T2

[osmith]

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/15427 )

Change subject: Use osmo_tdef for BSSGP T1 and T2
..


Patch Set 7: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/15427
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I477e5b702c8b956136d93fc1cee01991233e381f
Gerrit-Change-Number: 15427
Gerrit-PatchSet: 7
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Mon, 16 Sep 2019 11:39:37 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in ...osmo-trx[master]: Transceiver: Fixed copying of history into and from channelizer buffer.

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-trx/+/15413 )

Change subject: Transceiver: Fixed copying of history into and from channelizer 
buffer.
..


Patch Set 2:

Re-working the patch myself since I asked the author here and over email a few 
days ago on whether he was planning to work on new versions of the patch and 
got no answer so far. And since the fix is important I think it makes sense to 
have it merged asap.


--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/15413
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I93e43f6868cd67e69fc59d2980a03550d2505bf8
Gerrit-Change-Number: 15413
Gerrit-PatchSet: 2
Gerrit-Owner: timojacobus 
Gerrit-Assignee: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Reviewer: tnt 
Gerrit-Comment-Date: Mon, 16 Sep 2019 11:35:38 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in ...osmo-trx[master]: Transceiver: Fixed copying of history into and from channelizer buffer.

[pespin]

pespin has uploaded a new patch set (#2) to the change originally created by 
timojacobus. ( https://gerrit.osmocom.org/c/osmo-trx/+/15413 )

Change subject: Transceiver: Fixed copying of history into and from channelizer 
buffer.
..

Transceiver: Fixed copying of history into and from channelizer buffer.

In multi arfcn mode, osmo-trx would drop some bursts because it couldn't detect 
it
and would emit idle burst instead. Specificaly detection of peak in correlation
vector failed. Correcting copying of history in pullBuffer method fixes this 
issue.

[Re-worked by Pau Espin Pedrol ]

Fixes: 57df2362f0eca0a330aad3e18906046dfadb9c8b
Change-Id: I93e43f6868cd67e69fc59d2980a03550d2505bf8
---
M Transceiver52M/radioInterfaceMulti.cpp
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/13/15413/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/15413
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I93e43f6868cd67e69fc59d2980a03550d2505bf8
Gerrit-Change-Number: 15413
Gerrit-PatchSet: 2
Gerrit-Owner: timojacobus 
Gerrit-Assignee: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Reviewer: tnt 
Gerrit-MessageType: newpatchset

Change in ...libosmocore[master]: vty: osmo_stats_vty_add_cmds: Enforce no parameters

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/15055 )

Change subject: vty: osmo_stats_vty_add_cmds: Enforce no parameters
..


Patch Set 1:

This change is ready for review.


--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15055
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I29b27824b83c2caad901cc910d77e634ed5562d6
Gerrit-Change-Number: 15055
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-CC: fixeria 
Gerrit-Comment-Date: Mon, 16 Sep 2019 11:13:09 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in ...libosmocore[master]: vty: logging_vty_add_cmds: Enforce no parameters

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/15056 )

Change subject: vty: logging_vty_add_cmds: Enforce no parameters
..


Patch Set 1:

This change is ready for review.


--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15056
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I2fa8a9e2fdf3d55d0dcdb3d933ac5ceb48db3da9
Gerrit-Change-Number: 15056
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Mon, 16 Sep 2019 11:13:13 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in ...osmo-trx[master]: Log RACH burst detection

[pespin]

pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-trx/+/15536


Change subject: Log RACH burst detection
..

Log RACH burst detection

Change-Id: I4a8adea88ac6f1d9e712352cf1ac374d5bb68e12
---
M Transceiver52M/sigProcLib.cpp
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/36/15536/1

diff --git a/Transceiver52M/sigProcLib.cpp b/Transceiver52M/sigProcLib.cpp
index 011ddff..9ce3646 100644
--- a/Transceiver52M/sigProcLib.cpp
+++ b/Transceiver52M/sigProcLib.cpp
@@ -1636,6 +1636,7 @@
 gRACHSequences[i], ebp);
 if (rc > 0) {
   ebp->tsc = i;
+  LOG(DEBUG) << "Detected " << (ext ? "extended " : "") << "RACH Burst: 
TSC=" << ebp->tsc;
   break;
 }
   }

--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/15536
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I4a8adea88ac6f1d9e712352cf1ac374d5bb68e12
Gerrit-Change-Number: 15536
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange

Change in ...osmo-sip-connector[master]: exit if the sip agent failed to start

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-sip-connector/+/15532 )

Change subject: exit if the sip agent failed to start
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/15532
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: I22ed16c77391b4f270df498dda587ed657279390
Gerrit-Change-Number: 15532
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: keith 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: pespin 
Gerrit-Reviewer: zecke 
Gerrit-Comment-Date: Mon, 16 Sep 2019 08:45:05 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in ...osmo-sgsn[master]: sgsn: when receiving data PDU notify the Gb GMM fsm

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/15535 )

Change subject: sgsn: when receiving data PDU notify the Gb GMM fsm
..


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/15535/2/src/sgsn/gprs_sndcp.c
File src/sgsn/gprs_sndcp.c:

https://gerrit.osmocom.org/#/c/15535/2/src/sgsn/gprs_sndcp.c@785
PS2, Line 785:  OSMO_ASSERT(mmctx);
Don't assert here, better log error and drop the packet!



--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15535
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I78f40762fb17bbd4a6f35608a793f8e5271e9b86
Gerrit-Change-Number: 15535
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Mon, 16 Sep 2019 08:44:05 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in ...docker-playground[master]: sgsn: enable Iu tests

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/docker-playground/+/15534 )

Change subject: sgsn: enable Iu tests
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/15534
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: Ic26bcabb8b5192c401ab0bcc6a88b29fa0d3d8da
Gerrit-Change-Number: 15534
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Mon, 16 Sep 2019 08:41:00 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in ...libosmo-sccp[master]: sccp_user: correct comment for osmo_sccp_simple_client

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-sccp/+/15531 )

Change subject: sccp_user: correct comment for osmo_sccp_simple_client
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/15531
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: Iaac59222df84eacf813825c2ef660281381e6b14
Gerrit-Change-Number: 15531
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Mon, 16 Sep 2019 08:40:30 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in ...osmo-sip-connector[master]: .service: require to ran after network-online.target

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-sip-connector/+/15533 )

Change subject: .service: require to ran after network-online.target
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/15533
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: I09bf8139582ef198fdbe664be32b14d8c9c99f1a
Gerrit-Change-Number: 15533
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: keith 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: pespin 
Gerrit-Reviewer: zecke 
Gerrit-Comment-Date: Mon, 16 Sep 2019 08:41:22 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in ...libosmo-sccp[master]: sccp_user: correct comment for osmo_sccp_simple_client

[pespin]

pespin has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/c/libosmo-sccp/+/15531 )

Change subject: sccp_user: correct comment for osmo_sccp_simple_client
..

sccp_user: correct comment for osmo_sccp_simple_client

Fixes: 3884eb68d932 ("osmo_sccp_simple_client(): use sccp instance index 0 
instead of 1")
Change-Id: Iaac59222df84eacf813825c2ef660281381e6b14
---
M src/sccp_user.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, approved



diff --git a/src/sccp_user.c b/src/sccp_user.c
index ff5eb08..a1302d9 100644
--- a/src/sccp_user.c
+++ b/src/sccp_user.c
@@ -633,7 +633,7 @@
 {
/*! This is simplified version of osmo_sccp_simple_client_on_ss7_id().
 *  the only difference is that the ID of the CS7 instance will be
-*  set to 1 statically */
+*  set to 0 statically */

return osmo_sccp_simple_client_on_ss7_id(ctx, 0, name, default_pc, prot,
 default_local_port,

--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/15531
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: Iaac59222df84eacf813825c2ef660281381e6b14
Gerrit-Change-Number: 15531
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in ...osmo-ttcn3-hacks[master]: Require to receive RANAP_CommonId after RANAP_SecurityModeComplete

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15530 )

Change subject: Require to receive RANAP_CommonId after 
RANAP_SecurityModeComplete
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15530
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I82a05cab2aeea25eec699f726b2f5c4b3eef7560
Gerrit-Change-Number: 15530
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Mon, 16 Sep 2019 08:39:48 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in ...libosmo-abis[master]: ipa: ipa_server_link_close() add checks of link state

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-abis/+/15387 )

Change subject: ipa: ipa_server_link_close() add checks of link state
..


Patch Set 6: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/15387
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I672d4de25464c3829b08aff26b1a6d4ad92e7684
Gerrit-Change-Number: 15387
Gerrit-PatchSet: 6
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Mon, 16 Sep 2019 08:38:44 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in ...osmo-ttcn3-hacks[master]: sgsn: replace variable gb_index with ran_index

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15528 )

Change subject: sgsn: replace variable gb_index with ran_index
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15528
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I06b0c6184daeb886e8bd28d50bf18909d9244dc6
Gerrit-Change-Number: 15528
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Mon, 16 Sep 2019 08:36:39 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in ...osmo-ttcn3-hacks[master]: sgsn: replace variable gb_idx with ran_index

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15529 )

Change subject: sgsn: replace variable gb_idx with ran_index
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15529
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia119feee6a442c76dc337e75c07f4a385cd5e1df
Gerrit-Change-Number: 15529
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Mon, 16 Sep 2019 08:37:03 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in ...osmo-ttcn3-hacks[master]: sgsn: replace variable bssgp with ran_index

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15399 )

Change subject: sgsn: replace variable bssgp with ran_index
..


Patch Set 5: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15399
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib278410bc49f07387873740ed8b411a815d940a8
Gerrit-Change-Number: 15399
Gerrit-PatchSet: 5
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Mon, 16 Sep 2019 08:37:18 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in ...osmo-ttcn3-hacks[master]: sgsn: replace variable bssgp_index with ran_index

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15400 )

Change subject: sgsn: replace variable bssgp_index with ran_index
..


Patch Set 4: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15400
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iec2e8510b749602f0ebb9b4976957c9c5ce3f307
Gerrit-Change-Number: 15400
Gerrit-PatchSet: 4
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Mon, 16 Sep 2019 08:36:23 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in ...osmo-msc[master]: vlr_auth_fsm: on SAI use the GSUP provided GMM cause code

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/15492 )

Change subject: vlr_auth_fsm: on SAI use the GSUP provided GMM cause code
..


Patch Set 2: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15492
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I9af515dc52834b7c57c42fc3a76ee2c682734e2a
Gerrit-Change-Number: 15492
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Mon, 16 Sep 2019 08:35:06 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in ...osmo-msc[master]: vlr: gmm_cause_to_fsm_and_mm_cause() drop fsm_cause_p argument

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/15490 )

Change subject: vlr: gmm_cause_to_fsm_and_mm_cause() drop fsm_cause_p argument
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15490
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ie4720ad40ef7bcfc528d8d63bfc606c9c0545fb2
Gerrit-Change-Number: 15490
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Mon, 16 Sep 2019 08:32:13 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in ...osmo-iuh[master]: iu_client: introduce ranap_iu_tx_release_free()

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-iuh/+/15473 )

Change subject: iu_client: introduce ranap_iu_tx_release_free()
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/15473
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: I349e2c61ba0131e233b7ab927dfced0bd461dd8f
Gerrit-Change-Number: 15473
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Mon, 16 Sep 2019 08:31:06 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in ...osmo-ttcn3-hacks[master]: sgsn: TC_attach_check_complete_resend: Expect LU sent to HLR

[pespin]

pespin has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15475 )

Change subject: sgsn: TC_attach_check_complete_resend: Expect LU sent to HLR
..

sgsn: TC_attach_check_complete_resend: Expect LU sent to HLR

SGSN is expected to submit an LU after initial GMM Auth

Change-Id: Ie2e8f5b9740c7429f5f0bf28e35707a61f23b565
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  fixeria: Looks good to me, but someone else must approve
  lynxis lazus: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn
index 6de9987..182cbd2 100644
--- a/sgsn/SGSN_Tests.ttcn
+++ b/sgsn/SGSN_Tests.ttcn
@@ -2325,6 +2325,8 @@

f_send_l3(ts_GMM_ATTACH_REQ(f_mi_get_lv(), f_random_RAI(), true, false, 
omit, omit));
f_gmm_auth();
+   /* Expect SGSN to perform LU with HLR */
+   f_gmm_gsup_lu_isd();

timer T := 10.0;
T.start;

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15475
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie2e8f5b9740c7429f5f0bf28e35707a61f23b565
Gerrit-Change-Number: 15475
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in ...osmo-msc[master]: paging: reduce paging response timer to 3 sec

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/15527 )

Change subject: paging: reduce paging response timer to 3 sec
..


Patch Set 4: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15527
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ie695aa67458753794d70ed5154df51bfe6696da3
Gerrit-Change-Number: 15527
Gerrit-PatchSet: 4
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Mon, 16 Sep 2019 08:26:13 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in ...osmo-ttcn3-hacks[master]: library/RLCMAC_CSN1_Types.ttcn: add UL Packet Resource Request

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15525 )

Change subject: library/RLCMAC_CSN1_Types.ttcn: add UL Packet Resource Request
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15525
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I0d688beb4112d6db10ac89e2966b555e74887a6e
Gerrit-Change-Number: 15525
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Mon, 16 Sep 2019 08:11:48 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in ...osmo-ttcn3-hacks[master]: Introduce PCUIF, BTS and ClckGen components for RAW PCU test cases

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15430 )

Change subject: Introduce PCUIF, BTS and ClckGen components for RAW PCU test 
cases
..


Patch Set 7:

(1 comment)

https://gerrit.osmocom.org/#/c/15430/6/pcu/PCU_Tests_RAW.ttcn
File pcu/PCU_Tests_RAW.ttcn:

https://gerrit.osmocom.org/#/c/15430/6/pcu/PCU_Tests_RAW.ttcn@460
PS6, Line 460: private function f_init_raw(charstring id)
> Isn't that exactly what the code states?
Oops sorry I didn't see it in next line, I was expecting it immediatelly 
afterwards in the same line ;)



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15430
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I63a23abebab88fd5318eb4d907d6028e7c38e9a3
Gerrit-Change-Number: 15430
Gerrit-PatchSet: 7
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Mon, 16 Sep 2019 08:10:18 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Comment-In-Reply-To: laforge 
Gerrit-MessageType: comment