Change in osmo-ttcn3-hacks[master]: hlr: stop on various failures
neels has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16020 )
Change subject: hlr: stop on various failures
..
hlr: stop on various failures
I found some of the tests hard to analyse when geting failures, because they
don't stop the test on failure. Spread some 'mtc.stop' so that the test stops
at the failed message instead of carrying on.
Change-Id: I804aca84d0ccf4767a5c097cf6c882ccbd87c4e1
---
M hlr/HLR_Tests.ttcn
1 file changed, 15 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/20/16020/1
diff --git a/hlr/HLR_Tests.ttcn b/hlr/HLR_Tests.ttcn
index f309575..f8d7483 100644
--- a/hlr/HLR_Tests.ttcn
+++ b/hlr/HLR_Tests.ttcn
@@ -425,15 +425,19 @@
}
[exp_fail] GSUP.receive(tr_GSUP_UL_ERR(imsi, ?)) -> value ret {
setverdict(fail, "Unexpected UL ERROR Cause");
+ mtc.stop;
}
[exp_fail] GSUP.receive(tr_GSUP_UL_RES(imsi)) -> value ret {
setverdict(fail, "Unexpected UL.res for unknown IMSI");
+ mtc.stop;
}
[exp_fail] GSUP.receive(tr_GSUP_ISD_REQ(imsi)) -> value ret {
setverdict(fail, "Unexpected ISD.req in error case");
+ mtc.stop;
}
[not exp_fail] GSUP.receive(tr_GSUP_UL_ERR(imsi, ?)) -> value ret {
setverdict(fail, "Unexpected UL ERROR");
+ mtc.stop;
}
[not exp_fail and not isd_done] GSUP.receive(tr_GSUP_ISD_REQ(imsi,
msisdn)) -> value ret {
GSUP.send(ts_GSUP_ISD_RES(imsi));
@@ -540,12 +544,14 @@
alt {
[] GSUP.receive(tr_GSUP_PROC_SS_ERR(imsi, sid, ?, ?)) -> value ret {
setverdict(fail, "Unexpected PROC_SS ERROR Cause");
+ mtc.stop;
}
[not exp_ss] GSUP.receive(tr_GSUP_PROC_SS_RES(imsi, sid, state, omit))
-> value ret {
setverdict(pass);
}
[exp_ss] GSUP.receive(tr_GSUP_PROC_SS_RES(imsi, sid, state, omit)) ->
value ret {
setverdict(fail, "Unexpected PROC_SS.res without SS IE");
+ mtc.stop;
}
/*
[exp_ss] GSUP.receive(tr_GSUP_PROC_SS_RES(imsi, sid, state, decmatch
facility)) -> value ret {
@@ -562,9 +568,13 @@
setverdict(pass);
} else {
setverdict(fail, "Unexpected PROC_SS.res with
non-matching facility IE");
+ mtc.stop;
}
}
- [] GSUP.receive { repeat; }
+ [] GSUP.receive {
+ setverdict(fail, "Unexpected GSUP");
+ mtc.stop;
+ }
[] T.timeout {
setverdict(fail, "Timeout waiting for PROC_SS response");
self.stop;
@@ -593,18 +603,22 @@
}
[exp_fail] GSUP.receive(tr_GSUP_CHECK_IMEI_ERR(imsi, ?)) -> value pdu {
setverdict(fail, "Unexpected CHECK IMEI ERROR Cause: ", pdu);
+ mtc.stop;
}
[exp_fail] GSUP.receive(tr_GSUP_CHECK_IMEI_RES(imsi, ?)) -> value pdu {
setverdict(fail, "Unexpected CHECK IMEI RES instead of ERR");
+ mtc.stop;
}
[not exp_fail] GSUP.receive(tr_GSUP_CHECK_IMEI_ERR(imsi, ?)) -> value
pdu {
setverdict(fail, "Unexpected CHECK IMEI ERROR");
+ mtc.stop;
}
[not exp_fail] GSUP.receive(tr_GSUP_CHECK_IMEI_RES(imsi, result)) ->
value pdu {
setverdict(pass);
}
[not exp_fail] GSUP.receive(tr_GSUP_CHECK_IMEI_RES(imsi, ?)) -> value
pdu {
setverdict(fail, "Unexpected CHECK IMEI RES");
+ mtc.stop;
}
[] GSUP.receive { repeat; }
[] T.timeout {
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16020
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I804aca84d0ccf4767a5c097cf6c882ccbd87c4e1
Gerrit-Change-Number: 16020
Gerrit-PatchSet: 1
Gerrit-Owner: neels
Gerrit-MessageType: newchange
Change in osmo-ttcn3-hacks[master]: hlr: add tests for GSUP proxy routing
neels has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16021 )
Change subject: hlr: add tests for GSUP proxy routing
..
hlr: add tests for GSUP proxy routing
GSUP proxy routing, as it is implemented in an upcoming osmo-hlr patch,
requires that osmo-hlr returns a received Source Name IE back as Destination
Name IE. Add tests for these, for various situations.
At the time of writing, these tests still fail on master, and will pass as soon
as GSUP request handling with request->response association is introduced to
osmo-hlr in an upcoming patch (I179ebb0385b5b355f4740e14d43be97bf93622e3).
Implement this by adding a source_name to the g_pars, which should be sent out
in ts_GSUP_* to osmo-hlr, and expected back as destination_name in returned
messages.
Add source_name and destination_name to various templates, with default :=
omit.
Add f_gen_ts_ies() and f_gen_tr_ies() to compose expected IEs more generically.
Change-Id: I3728776d862c5e5fa7628ca28d74c1ef247459fa
---
M hlr/HLR_Tests.ttcn
M library/GSUP_Types.ttcn
2 files changed, 233 insertions(+), 65 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/21/16021/1
diff --git a/hlr/HLR_Tests.ttcn b/hlr/HLR_Tests.ttcn
index f8d7483..c3bddab 100644
--- a/hlr/HLR_Tests.ttcn
+++ b/hlr/HLR_Tests.ttcn
@@ -81,26 +81,38 @@
type record HLR_ConnHdlrPars {
HlrSubscriber sub,
- HLR_ConnHdlrParsUssd ussd optional
+ HLR_ConnHdlrParsUssd ussd optional,
+ octetstring source_name optional
}
type record HLR_ConnHdlrParsUssd {
OCT4 sid
}
-template (value) HLR_ConnHdlrPars t_Pars(hexstring imsi, hexstring msisdn :=
''H) := {
+template (value) HLR_ConnHdlrPars t_Pars(hexstring imsi, hexstring msisdn :=
''H,
+template (omit) octetstring
source_name := omit) := {
sub := {
imsi := imsi,
msisdn := msisdn,
aud2g := omit,
aud3g := omit
},
- ussd := omit
+ ussd := omit,
+ source_name := source_name
}
+template (value) HLR_ConnHdlrPars t_Pars_via_proxy(hexstring imsi, hexstring
msisdn := ''H) :=
+ t_Pars(imsi, msisdn, source_name := '7468652d736f757263650a'O); //
"the-source"
template (value) HLR_ConnHdlrPars t_Pars_sub(HlrSubscriber sub) := {
sub := sub,
- ussd := omit
+ ussd := omit,
+ source_name := omit
+}
+
+template (value) HLR_ConnHdlrPars t_Pars_sub_via_proxy(HlrSubscriber sub) := {
+ sub := sub,
+ ussd := omit,
+ source_name := '7468652d736f757263650a'O // "the-source"
}
type function void_fn() runs on HLR_ConnHdlr;
@@ -407,7 +419,8 @@
}
function f_perform_UL(hexstring imsi, template hexstring msisdn,
- template (omit) integer exp_err_cause := omit)
+ template (omit) integer exp_err_cause := omit,
+ template (omit) octetstring source_name := omit)
runs on HLR_ConnHdlr return GSUP_PDU {
var GSUP_PDU ret;
timer T := 3.0;
@@ -417,34 +430,34 @@
exp_fail := true;
}
- GSUP.send(valueof(ts_GSUP_UL_REQ(imsi)));
+ GSUP.send(valueof(ts_GSUP_UL_REQ(imsi, source_name := source_name)));
T.start;
alt {
- [exp_fail] GSUP.receive(tr_GSUP_UL_ERR(imsi, exp_err_cause)) -> value
ret {
+ [exp_fail] GSUP.receive(tr_GSUP_UL_ERR(imsi, exp_err_cause,
destination_name := source_name)) -> value ret {
setverdict(pass);
}
- [exp_fail] GSUP.receive(tr_GSUP_UL_ERR(imsi, ?)) -> value ret {
+ [exp_fail] GSUP.receive(tr_GSUP_UL_ERR(imsi, ?, destination_name :=
source_name)) -> value ret {
setverdict(fail, "Unexpected UL ERROR Cause");
mtc.stop;
}
- [exp_fail] GSUP.receive(tr_GSUP_UL_RES(imsi)) -> value ret {
+ [exp_fail] GSUP.receive(tr_GSUP_UL_RES(imsi, destination_name :=
source_name)) -> value ret {
setverdict(fail, "Unexpected UL.res for unknown IMSI");
mtc.stop;
}
- [exp_fail] GSUP.receive(tr_GSUP_ISD_REQ(imsi)) -> value ret {
+ [exp_fail] GSUP.receive(tr_GSUP_ISD_REQ(imsi, destination_name :=
source_name)) -> value ret {
setverdict(fail, "Unexpected ISD.req in error case");
mtc.stop;
}
- [not exp_fail] GSUP.receive(tr_GSUP_UL_ERR(imsi, ?)) -> value ret {
+ [not exp_fail] GSUP.receive(tr_GSUP_UL_ERR(imsi, ?, destination_name :=
source_name)) -> value ret {
setverdict(fail, "Unexpected UL ERROR");
mtc.stop;
}
- [not exp_fail and not isd_done] GSUP.receive(tr_GSUP_ISD_REQ(imsi,
msisdn)) -> value ret {
- GSUP.send(ts_GSUP_ISD_RES(imsi));
+ [not exp_fail and not isd_done] GSUP.recei
Change in osmo-hlr[master]: fix upgrade test in presence of ~/.sqliterc
neels has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-hlr/+/16019 )
Change subject: fix upgrade test in presence of ~/.sqliterc
..
fix upgrade test in presence of ~/.sqliterc
db_upgrade_test.sh:
- If an ~/.sqliterc file exists, it causes output of '-- Loading resources from
~/.sqliterc'. Use -batch option to omit that.
- To make sure that column headers are off when required, add -noheaders in
some places.
Change-Id: I279a39984563594a4a3914b2ce3d803ad9468fe8
---
M tests/db_upgrade/db_upgrade_test.sh
1 file changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/19/16019/1
diff --git a/tests/db_upgrade/db_upgrade_test.sh
b/tests/db_upgrade/db_upgrade_test.sh
index bf56c56..8e2b498 100755
--- a/tests/db_upgrade/db_upgrade_test.sh
+++ b/tests/db_upgrade/db_upgrade_test.sh
@@ -11,21 +11,21 @@
dump_sorted_schema(){
db_file="$1"
- tables="$(sqlite3 "$db_file" "SELECT name FROM sqlite_master WHERE type
= 'table' order by name")"
+ tables="$(sqlite3 -batch -noheader "$db_file" "SELECT name FROM
sqlite_master WHERE type = 'table' order by name")"
for table in $tables; do
echo
echo "Table: $table"
- sqlite3 -header "$db_file" "SELECT
name,type,\"notnull\",dflt_value,pk FROM PRAGMA_TABLE_INFO('$table') order by
name;"
+ sqlite3 -batch -header "$db_file" "SELECT
name,type,\"notnull\",dflt_value,pk FROM PRAGMA_TABLE_INFO('$table') order by
name;"
echo
echo "Table $table contents:"
- columns="$(sqlite3 "$db_file" "SELECT name FROM
PRAGMA_TABLE_INFO('$table') order by name;")"
- sqlite3 -header "$db_file" "SELECT $(echo $columns | sed 's/
/,/g') from $table;"
+ columns="$(sqlite3 -batch -noheader "$db_file" "SELECT name
FROM PRAGMA_TABLE_INFO('$table') order by name;")"
+ sqlite3 -batch -header "$db_file" "SELECT $(echo $columns | sed
's/ /,/g') from $table;"
done
}
rm -f "$db"
echo "Creating db in schema version 0"
-sqlite3 "$db" < "$srcdir/hlr_db_v0.sql"
+sqlite3 -batch "$db" < "$srcdir/hlr_db_v0.sql"
echo
echo "Version 0 db:"
@@ -61,7 +61,7 @@
-n OsmoHLR -p 4258 \
-r "$osmo_hlr -c $cfg -l $mint_db" \
"$srcdir/create_subscribers.vty"
- sqlite3 "$mint_db" < "$srcdir/create_subscribers_step2.sql"
+ sqlite3 -batch "$mint_db" < "$srcdir/create_subscribers_step2.sql"
set +x
test_dump="$builddir/test.dump"
--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16019
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I279a39984563594a4a3914b2ce3d803ad9468fe8
Gerrit-Change-Number: 16019
Gerrit-PatchSet: 1
Gerrit-Owner: neels
Gerrit-MessageType: newchange
Build failure of network:osmocom:nightly/osmo-iuh in Debian_10/i586
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-iuh/Debian_10/i586 Package network:osmocom:nightly/osmo-iuh failed to build in Debian_10/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-iuh Last lines of build log: [ 520s] make[5]: Nothing to be done for 'check'. [ 520s] make[5]: Leaving directory '/usr/src/packages/BUILD/contrib/systemd' [ 520s] make[5]: Entering directory '/usr/src/packages/BUILD/contrib' [ 520s] make[5]: Nothing to be done for 'check-am'. [ 520s] make[5]: Leaving directory '/usr/src/packages/BUILD/contrib' [ 520s] make[4]: Leaving directory '/usr/src/packages/BUILD/contrib' [ 520s] make[4]: Entering directory '/usr/src/packages/BUILD' [ 520s] make[4]: Nothing to be done for 'check-am'. [ 520s] make[4]: Leaving directory '/usr/src/packages/BUILD' [ 520s] make[3]: Leaving directory '/usr/src/packages/BUILD' [ 520s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 520s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 520s] fakeroot debian/rules binary [ 520s] dh binary --with autoreconf [ 520s] Unrecognized character \x01; marked by <-- HERE after package De<-- HERE near column 11 at /usr/share/perl5/Debian/Debhelper/SequencerUtil.pm line 5. [ 520s] Compilation failed in require at /usr/bin/dh line 15. [ 520s] BEGIN failed--compilation aborted at /usr/bin/dh line 15. [ 520s] make: *** [debian/rules:9: binary] Error 255 [ 520s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 520s] [ 520s] lamb57 failed "build osmo-iuh_0.5.0.18.9fb8.dsc" at Mon Nov 11 02:14:29 UTC 2019. [ 520s] [ 520s] ### VM INTERACTION START ### [ 524s] [ 508.977293] sysrq: SysRq : Power Off [ 524s] [ 508.982710] reboot: Power down [ 524s] ### VM INTERACTION END ### [ 524s] [ 524s] lamb57 failed "build osmo-iuh_0.5.0.18.9fb8.dsc" at Mon Nov 11 02:14:33 UTC 2019. [ 524s] -- Configure notifications at https://build.opensuse.org/my/notifications openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-hlr in xUbuntu_16.04/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hlr/xUbuntu_16.04/x86_64 Package network:osmocom:nightly/osmo-hlr failed to build in xUbuntu_16.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hlr Last lines of build log: [ 206s] -subscriber_id|INTEGER|0||0 [ 206s] - [ 206s] -Table subscriber_multi_msisdn contents: [ 206s] - [ 206s] -Verify that osmo-hlr can open it: [ 206s] -osmo-hlr --database $db --db-check --config-file $srcdir/osmo-hlr.cfg [ 206s] -rc = 0 [ 206s] -DMAIN hlr starting [ 206s] -DDB using database: test.db [ 206s] -DDB Database test.db' has HLR DB schema version 2 [ 206s] -DMAIN Cmdline option --db-check: Database was opened successfully, quitting. [ 206s] ./testsuite.at:44: exit code was 1, expected 0 [ 206s] 6. testsuite.at:40: 6. db_upgrade (testsuite.at:40): FAILED (testsuite.at:44) [ 206s] debian/rules:17: recipe for target 'override_dh_auto_test' failed [ 206s] make[1]: *** [override_dh_auto_test] Error 1 [ 206s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 206s] debian/rules:7: recipe for target 'build' failed [ 206s] make: *** [build] Error 2 [ 206s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 206s] [ 206s] lamb14 failed "build osmo-hlr_1.1.0.10.5b65.dsc" at Mon Nov 11 02:09:34 UTC 2019. [ 206s] [ 206s] ### VM INTERACTION START ### [ 210s] [ 197.193187] sysrq: SysRq : Power Off [ 210s] [ 197.199401] reboot: Power down [ 210s] ### VM INTERACTION END ### [ 210s] [ 210s] lamb14 failed "build osmo-hlr_1.1.0.10.5b65.dsc" at Mon Nov 11 02:09:38 UTC 2019. [ 210s] -- Configure notifications at https://build.opensuse.org/my/notifications openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-hlr in Debian_8.0/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hlr/Debian_8.0/x86_64 Package network:osmocom:nightly/osmo-hlr failed to build in Debian_8.0/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hlr Last lines of build log: [ 223s] -subscriber_id|INTEGER|0||0 [ 223s] - [ 223s] -Table subscriber_multi_msisdn contents: [ 223s] - [ 223s] -Verify that osmo-hlr can open it: [ 223s] -osmo-hlr --database $db --db-check --config-file $srcdir/osmo-hlr.cfg [ 223s] -rc = 0 [ 223s] -DMAIN hlr starting [ 223s] -DDB using database: test.db [ 223s] -DDB Database test.db' has HLR DB schema version 2 [ 223s] -DMAIN Cmdline option --db-check: Database was opened successfully, quitting. [ 223s] ./testsuite.at:44: exit code was 1, expected 0 [ 223s] 6. testsuite.at:40: 6. db_upgrade (testsuite.at:40): FAILED (testsuite.at:44) [ 223s] debian/rules:17: recipe for target 'override_dh_auto_test' failed [ 223s] make[1]: *** [override_dh_auto_test] Error 1 [ 223s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 223s] debian/rules:7: recipe for target 'build' failed [ 223s] make: *** [build] Error 2 [ 223s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 223s] [ 223s] lamb51 failed "build osmo-hlr_1.1.0.10.5b65.dsc" at Mon Nov 11 02:05:21 UTC 2019. [ 223s] [ 223s] ### VM INTERACTION START ### [ 224s] Powering off. [ 224s] [ 207.960318] reboot: Power down [ 224s] ### VM INTERACTION END ### [ 224s] [ 224s] lamb51 failed "build osmo-hlr_1.1.0.10.5b65.dsc" at Mon Nov 11 02:05:23 UTC 2019. [ 224s] -- Configure notifications at https://build.opensuse.org/my/notifications openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-hlr in xUbuntu_16.04/i586
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hlr/xUbuntu_16.04/i586 Package network:osmocom:nightly/osmo-hlr failed to build in xUbuntu_16.04/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hlr Last lines of build log: [ 479s] -subscriber_id|INTEGER|0||0 [ 479s] - [ 479s] -Table subscriber_multi_msisdn contents: [ 479s] - [ 479s] -Verify that osmo-hlr can open it: [ 479s] -osmo-hlr --database $db --db-check --config-file $srcdir/osmo-hlr.cfg [ 479s] -rc = 0 [ 479s] -DMAIN hlr starting [ 479s] -DDB using database: test.db [ 479s] -DDB Database test.db' has HLR DB schema version 2 [ 479s] -DMAIN Cmdline option --db-check: Database was opened successfully, quitting. [ 479s] ./testsuite.at:44: exit code was 1, expected 0 [ 479s] 6. testsuite.at:40: 6. db_upgrade (testsuite.at:40): FAILED (testsuite.at:44) [ 479s] debian/rules:17: recipe for target 'override_dh_auto_test' failed [ 479s] make[1]: *** [override_dh_auto_test] Error 1 [ 479s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 479s] debian/rules:7: recipe for target 'build' failed [ 479s] make: *** [build] Error 2 [ 479s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 479s] [ 479s] cloud101 failed "build osmo-hlr_1.1.0.10.5b65.dsc" at Mon Nov 11 02:03:04 UTC 2019. [ 479s] [ 479s] ### VM INTERACTION START ### [ 482s] [ 464.683711] sysrq: SysRq : Power Off [ 482s] [ 464.702521] reboot: Power down [ 483s] ### VM INTERACTION END ### [ 483s] [ 483s] cloud101 failed "build osmo-hlr_1.1.0.10.5b65.dsc" at Mon Nov 11 02:03:09 UTC 2019. [ 483s] -- Configure notifications at https://build.opensuse.org/my/notifications openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-hlr in Debian_8.0/i586
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hlr/Debian_8.0/i586 Package network:osmocom:nightly/osmo-hlr failed to build in Debian_8.0/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hlr Last lines of build log: [ 188s] | #define HAVE_MEMORY_H 1 [ 188s] | #define HAVE_STRINGS_H 1 [ 188s] | #define HAVE_INTTYPES_H 1 [ 188s] | #define HAVE_STDINT_H 1 [ 188s] | #define HAVE_UNISTD_H 1 [ 188s] | #define HAVE_DLFCN_H 1 [ 188s] | #define LT_OBJDIR ".libs/" [ 188s] | #define PACKAGE "osmo-hlr" [ 188s] | #define VERSION "1.1.0.10-5b65" [ 188s] | #define STDC_HEADERS 1 [ 188s] | [ 188s] | configure: exit 0 [ 188s] [ 188s] debian/rules:17: recipe for target 'override_dh_auto_test' failed [ 188s] make[1]: *** [override_dh_auto_test] Error 1 [ 188s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 188s] debian/rules:7: recipe for target 'build' failed [ 188s] make: *** [build] Error 2 [ 188s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 188s] [ 188s] lamb70 failed "build osmo-hlr_1.1.0.10.5b65.dsc" at Mon Nov 11 02:01:47 UTC 2019. [ 188s] [ 188s] ### VM INTERACTION START ### [ 189s] Powering off. [ 189s] [ 177.454437] reboot: Power down [ 189s] ### VM INTERACTION END ### [ 189s] [ 189s] lamb70 failed "build osmo-hlr_1.1.0.10.5b65.dsc" at Mon Nov 11 02:01:48 UTC 2019. [ 189s] -- Configure notifications at https://build.opensuse.org/my/notifications openSUSE Build Service (https://build.opensuse.org/)
Change in osmocom-bb[master]: trxcon/l1ctl_link.h: get rid of pointer to a trx_instance
fixeria has abandoned this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/12614 ) Change subject: trxcon/l1ctl_link.h: get rid of pointer to a trx_instance .. Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/12614 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ie154a9d25dd0e8828fa2c278c98f9d8ba8c037e3 Gerrit-Change-Number: 12614 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: abandon
Change in osmocom-bb[master]: trxcon/l1ctl_link.c: use TRXCON_EV_L1CTL_REQ event
fixeria has abandoned this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/12611 ) Change subject: trxcon/l1ctl_link.c: use TRXCON_EV_L1CTL_REQ event .. Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/12611 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I9ad19c158397f73ab1b6639a34ce20fc7a7431b3 Gerrit-Change-Number: 12611 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: abandon
Change in osmocom-bb[master]: trxcon/trxcon.h: introduce and use struct 'trxcon_inst'
fixeria has abandoned this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/12610 ) Change subject: trxcon/trxcon.h: introduce and use struct 'trxcon_inst' .. Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/12610 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id868dac54693be9a67527dba06a2b80c0ecb7bd4 Gerrit-Change-Number: 12610 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: abandon
Change in osmocom-bb[master]: trxcon/l1ctl.c: pass trxcon_inst pointer to RX handlers
fixeria has abandoned this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/12612 ) Change subject: trxcon/l1ctl.c: pass trxcon_inst pointer to RX handlers .. Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/12612 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I4e59f547a165b30aa9538ae8f9d6bd822067315b Gerrit-Change-Number: 12612 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: abandon
Change in osmocom-bb[master]: trxcon/trxcon.h: do not expose pointer to trxcon_fsm instance
fixeria has abandoned this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/12590 ) Change subject: trxcon/trxcon.h: do not expose pointer to trxcon_fsm instance .. Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/12590 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I37812573a33e090e6edb45713d3132cb43bd4ffb Gerrit-Change-Number: 12590 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: abandon
Change in osmocom-bb[master]: trxcon: refactor trxcon_fsm finite state machine
fixeria has abandoned this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/12585 ) Change subject: trxcon: refactor trxcon_fsm finite state machine .. Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/12585 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I035b2cb701e2d0b3fedec4d569507b79d400df5b Gerrit-Change-Number: 12585 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-CC: laforge Gerrit-MessageType: abandon
Change in osmocom-bb[master]: trxcon: make trxcon_fsm parent for both l1ctl_fsm and trx_fsm
fixeria has abandoned this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/12589 ) Change subject: trxcon: make trxcon_fsm parent for both l1ctl_fsm and trx_fsm .. Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/12589 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I6262726f2b6e23abe543d6d67edfd634eece1b71 Gerrit-Change-Number: 12589 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: abandon
Change in osmo-pcu[master]: gprs_bssgp_destroy(): fix memleak and NULL-pointer dereference
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/16018 ) Change subject: gprs_bssgp_destroy(): fix memleak and NULL-pointer dereference .. gprs_bssgp_destroy(): fix memleak and NULL-pointer dereference So far there was a memory leak, because free()ing 'the_pcu.bctx' would cause ASAN to complain. And that's reasonable, because it needs to be freed properly. Moreover, 'the_pcu.bctx' may simply be uninitialized in some cases, e.g. when OsmoPCU is terminated before connecting to the SGSN. Let's use the new bssgp_bvc_ctx_free() from libosmogb. Change-Id: I274e79e1746c7678b81720ec11e8a564befe38ba Depends: Ia78979379dbdccd6e4628c16f00d0c06d9212172 --- M src/gprs_bssgp_pcu.cpp 1 file changed, 1 insertion(+), 6 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/gprs_bssgp_pcu.cpp b/src/gprs_bssgp_pcu.cpp index dd9eb68..914afc0 100644 --- a/src/gprs_bssgp_pcu.cpp +++ b/src/gprs_bssgp_pcu.cpp @@ -971,12 +971,7 @@ gprs_ns_destroy(nsi); - /* FIXME: move this to libgb: btsctx_free() */ - llist_del(&the_pcu.bctx->list); -#warning "This causes ASAN to complain. It is not critical for normal operation but should be fixed nevertheless" -#if 0 - talloc_free(the_pcu.bctx); -#endif + bssgp_bvc_ctx_free(the_pcu.bctx); the_pcu.bctx = NULL; } -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/16018 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I274e79e1746c7678b81720ec11e8a564befe38ba Gerrit-Change-Number: 16018 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged
Change in osmo-pcu[master]: gprs_bssgp_destroy(): fix memleak and NULL-pointer dereference
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/16018 ) Change subject: gprs_bssgp_destroy(): fix memleak and NULL-pointer dereference .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/16018 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I274e79e1746c7678b81720ec11e8a564befe38ba Gerrit-Change-Number: 16018 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sun, 10 Nov 2019 09:04:15 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
