date:20200429

Change in osmo-msc[master]: SMS-over-GSUP: notify sender in case of RPL delivery failure

2020-04-29 Thread fixeria

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/17875 )

Change subject: SMS-over-GSUP: notify sender in case of RPL delivery failure
..


Patch Set 1:

(1 comment)

This change is ready for review.

https://gerrit.osmocom.org/c/osmo-msc/+/17875/1/src/libmsc/gsm_04_11_gsup.c
File src/libmsc/gsm_04_11_gsup.c:

https://gerrit.osmocom.org/c/osmo-msc/+/17875/1/src/libmsc/gsm_04_11_gsup.c@264
PS1, Line 264: GMM_CAUSE_NET_FAIL
> is it a network failure if the MT-SMS could not be delivered? It could also 
> be a MS/UE failure, a ra […]
Actually at this point we initiate MT message delivery, i.e. creating SMR/SMC 
state machines and starting paging if needed. Thus if anything goes wrong, it's 
definitely on our side.



--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/17875
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I8436601c4314395e28829960dc753778c37b1125
Gerrit-Change-Number: 17875
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-CC: laforge 
Gerrit-Comment-Date: Thu, 30 Apr 2020 06:47:47 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge 
Gerrit-MessageType: comment

Change in pysim[master]: utils.py: Add helper method to parse ePDG Identifier from hex string

2020-04-29 Thread herlesupreeth

herlesupreeth has posted comments on this change. ( 
https://gerrit.osmocom.org/c/pysim/+/17883 )

Change subject: utils.py: Add helper method to parse ePDG Identifier from hex 
string
..


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/pysim/+/17883/1/pySim/utils.py
File pySim/utils.py:

https://gerrit.osmocom.org/c/pysim/+/17883/1/pySim/utils.py@365
PS1, Line 365:  if o
> In that commit you linked you still hand-coded the TLV parsing instead of 
> using an existing parser. […]
sure, i can have a look into such python libraries and get back on this



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/17883
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I96fb129d178cfd7ec037989526da77899ae8d344
Gerrit-Change-Number: 17883
Gerrit-PatchSet: 2
Gerrit-Owner: herlesupreeth 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: herlesupreeth 
Gerrit-CC: laforge 
Gerrit-Comment-Date: Thu, 30 Apr 2020 06:29:31 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: herlesupreeth 
Comment-In-Reply-To: laforge 
Gerrit-MessageType: comment

Build failure of network:osmocom:nightly/osmo-gsm-manuals in Debian_10/x86_64

2020-04-29 Thread OBS Notification

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-gsm-manuals/Debian_10/x86_64

Package network:osmocom:nightly/osmo-gsm-manuals failed to build in 
Debian_10/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-gsm-manuals

Last lines of build log:
rpc timeout
(worker was lamb02:7)

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/libosmocore in Debian_9.0/armv7l

2020-04-29 Thread OBS Notification

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Debian_9.0/armv7l

Package network:osmocom:nightly/libosmocore failed to build in Debian_9.0/armv7l

Check out the package for editing:
  osc checkout network:osmocom:nightly libosmocore

Last lines of build log:
[  626s] | ## Running config.status. ##
[  626s] | ## -- ##
[  626s] | 
[  626s] | This file was extended by libosmocore config.status 1.3.0.72-d87d, 
which was
[  626s] | generated by GNU Autoconf 2.69.  Invocation command line was
[  626s] | 
[  626s] |   CONFIG_FILES= 
[  626s] |   CONFIG_HEADERS  = 
[  626s] |   CONFIG_LINKS= 
[  626s] |   CONFIG_COMMANDS = 
[  626s] |   $ ./config.status Doxyfile.core
[  626s] | 
[  626s] | on obs-arm-5
[  626s] | 
[  626s] | config.status:1341: creating Doxyfile.core
[  626s] 
[  626s] debian/rules:26: recipe for target 'override_dh_auto_test' failed
[  626s] make[1]: *** [override_dh_auto_test] Error 1
[  626s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  626s] debian/rules:15: recipe for target 'build' failed
[  626s] make: *** [build] Error 2
[  626s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  626s] ### VM INTERACTION START ###
[  629s] [  611.002353] sysrq: SysRq : Power Off
[  629s] [  611.006180] reboot: Power down
[  629s] ### VM INTERACTION END ###
[  629s] 
[  629s] obs-arm-5 failed "build libosmocore_1.3.0.72.d87d.dsc" at Thu Apr 30 
01:43:07 UTC 2020.
[  629s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)

Change in osmo-hlr[master]: 2/2: fixup: add osmo_gsup_peer_id with type enum and union

2020-04-29 Thread neels

neels has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-hlr/+/16459 )

Change subject: 2/2: fixup: add osmo_gsup_peer_id with type enum and union
..


Patch Set 9:

An opaque data structure indeed sounds like a good solution ABI wise.

A drawback is that we can't embed such an opaque struct directly in other 
structs: we would need dynamic allocation again, which I'd rather avoid.

I skimmed this and the previous patch for usage:
- It is used in a few structs that are talloc'd, so it would be ok to allocate 
as talloc child.
- Also used as local variables in a handful of locations, where it would 
rapidly allocate/deallocate. (Some of those could be replaced by API skipping 
an allocation?)

Anyway, it's a tradeoff. Maybe rather have a future proof data structure that 
is transparent.

My biggest problem here is the open question how that future might look. I 
imagine that such a future would anyway be completely separate / orthogonal to 
the GSUP API and that we would do plain API bloat here for no good reason.


--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16459
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Ide9dcdca283ab989240cfc6e53e9211862a199c5
Gerrit-Change-Number: 16459
Gerrit-PatchSet: 9
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Wed, 29 Apr 2020 22:22:05 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in osmo-pcu[master]: pdch: Avoid sending GSMTAP_CHANNEL_UNKOWN for rejected UL EGPRS data ...

2020-04-29 Thread fixeria

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/17983 )

Change subject: pdch: Avoid sending GSMTAP_CHANNEL_UNKOWN for rejected UL EGPRS 
data block
..


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/17983/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/c/osmo-pcu/+/17983/1//COMMIT_MSG@10
PS1, Line 10: otherwise the generic
: UNKNOWN gsmtap message will be sent.
See my comment to your previous change. Return code should not redefine the 
GSMTAP channel type.



--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17983
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I853679ce8907d46fcb84ae4127335c10623f09c9
Gerrit-Change-Number: 17983
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Comment-Date: Wed, 29 Apr 2020 20:31:52 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-pcu[master]: pcu_l1_if: Don't use GSMTAP_CHANNEL_PACCH when sending unknown gsmtap...

2020-04-29 Thread fixeria

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/17982 )

Change subject: pcu_l1_if: Don't use GSMTAP_CHANNEL_PACCH when sending unknown 
gsmtap blocks
..


Patch Set 1: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/17982/1/src/pcu_l1_if.cpp
File src/pcu_l1_if.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/17982/1/src/pcu_l1_if.cpp@348
PS1, Line 348: rc < 0
It's not good that we basically depend on rc here. If either 
pcu_rx_data_ind_pdtch() or pcu_rx_data_ind_pdtch() fails for some reason, it 
does not mean that GSMTAP channel type is unknown...



--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17982
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I7a96148f1ca1ebfa88a3ff714ea3bb8798866046
Gerrit-Change-Number: 17982
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Comment-Date: Wed, 29 Apr 2020 20:29:02 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-pcu[master]: pdch: Avoid sending GSMTAP_CHANNEL_UNKOWN for rejected UL EGPRS data ...

2020-04-29 Thread pespin

pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/17983 )


Change subject: pdch: Avoid sending GSMTAP_CHANNEL_UNKOWN for rejected UL EGPRS 
data block
..

pdch: Avoid sending GSMTAP_CHANNEL_UNKOWN for rejected UL EGPRS data block

Even if we don't accept it, let's submit GSMTAP with correct channel.
We don't return error like in code below, because otherwise the generic
UNKNOWN gsmtap message will be sent.

Change-Id: I853679ce8907d46fcb84ae4127335c10623f09c9
---
M src/pdch.cpp
1 file changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/83/17983/1

diff --git a/src/pdch.cpp b/src/pdch.cpp
index f46acc8..77be1b5 100644
--- a/src/pdch.cpp
+++ b/src/pdch.cpp
@@ -793,14 +793,14 @@
 * control blocks (see 44.060, section 10.3, 1st par.)
 */
if (mcs_is_edge(cs)) {
+   bts()->send_gsmtap(PCU_GSMTAP_C_UL_DATA_EGPRS, true, trx_no(), 
ts_no, GSMTAP_CHANNEL_PDTCH, fn,
+  data, data_len);
if (!bts()->bts_data()->egprs_enabled) {
LOGP(DRLCMACUL, LOGL_ERROR,
"Got %s RLC block but EGPRS is not enabled\n",
mcs_name(cs));
-   return -EINVAL;
+   return 0;
}
-   bts()->send_gsmtap(PCU_GSMTAP_C_UL_DATA_EGPRS, true, trx_no(), 
ts_no, GSMTAP_CHANNEL_PDTCH, fn,
-  data, data_len);
} else {
bts()->send_gsmtap(PCU_GSMTAP_C_UL_DATA_GPRS, true, trx_no(), 
ts_no, GSMTAP_CHANNEL_PDTCH, fn,
   data, data_len);

--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17983
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I853679ce8907d46fcb84ae4127335c10623f09c9
Gerrit-Change-Number: 17983
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange

Change in osmo-pcu[master]: pcu_l1_if: Don't use GSMTAP_CHANNEL_PACCH when sending unknown gsmtap...

2020-04-29 Thread pespin

pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/17982 )


Change subject: pcu_l1_if: Don't use GSMTAP_CHANNEL_PACCH when sending unknown 
gsmtap blocks
..

pcu_l1_if: Don't use GSMTAP_CHANNEL_PACCH when sending unknown gsmtap blocks

It's actually counter-productive when analyzing wireshark traces, since
one may not spot a decoding issue and assume PACCH is sent on the wrong
TS.

Change-Id: I7a96148f1ca1ebfa88a3ff714ea3bb8798866046
---
M src/pcu_l1_if.cpp
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/82/17982/1

diff --git a/src/pcu_l1_if.cpp b/src/pcu_l1_if.cpp
index 37a0705..30d22bd 100644
--- a/src/pcu_l1_if.cpp
+++ b/src/pcu_l1_if.cpp
@@ -347,7 +347,7 @@

if (rc < 0 && (bts->gsmtap_categ_mask & (1 arfcn | 
GSMTAP_ARFCN_F_UPLINK, data_ind->ts_nr,
-   GSMTAP_CHANNEL_PACCH, 0, data_ind->fn, 0, 0, 
data_ind->data, data_ind->len);
+   GSMTAP_CHANNEL_UNKNOWN, 0, data_ind->fn, 0, 0, 
data_ind->data, data_ind->len);
}

return rc;

--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17982
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I7a96148f1ca1ebfa88a3ff714ea3bb8798866046
Gerrit-Change-Number: 17982
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange

Change in osmo-ttcn3-hacks[master]: pcu: Get rid of PCU_Tests.ttcn tests

2020-04-29 Thread pespin

Hello fixeria, laforge, osmith, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16321

to look at the new patch set (#4).

Change subject: pcu: Get rid of PCU_Tests.ttcn tests
..

pcu: Get rid of PCU_Tests.ttcn tests

Delete PCU_Tests.ttcn along with the configs, since they are broken and
we are only adding new tests to PCU_Tests_RAW.ttcn. They are broken
because it's not possible to run multiple tests after another.

Some components which used to be in PCU_Tests.ttcn and which were used
by other PCU_Tests*.ttcn files have been moved to SGSN_Components.ttcn

Selftests have been moved to PCU_selftest.ttcn.

Small placeholder for module PCU_Tests is left in PCU_Tests.ttcn to
still be able to compile the binary as "PCU_Tests" and avoid changing
that part of docker setup. We'll eventually rename RAW tests soon
anyway.

Change-Id: Ie862a1525e9f4f9a3f2427ac3898810e3d044d2f
---
M pcu/PCU_Tests.cfg
M pcu/PCU_Tests.default
M pcu/PCU_Tests.ttcn
M pcu/PCU_Tests_RAW.ttcn
M pcu/PCU_Tests_RAW_NS.ttcn
M pcu/PCU_Tests_RAW_SNS.ttcn
M pcu/PCU_Tests_SNS.cfg
A pcu/PCU_selftest.ttcn
M pcu/README.md
A pcu/SGSN_Components.ttcn
M pcu/gen_links.sh
D pcu/osmo-bsc.cfg
D pcu/osmo-bts.cfg
M pcu/regen_makefile.sh
14 files changed, 380 insertions(+), 990 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/21/16321/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16321
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie862a1525e9f4f9a3f2427ac3898810e3d044d2f
Gerrit-Change-Number: 16321
Gerrit-PatchSet: 4
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: newpatchset

Change in mncc-python[master]: GsmCallFsm: permit MNCC_REL_CNF in any state

2020-04-29 Thread laforge

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/mncc-python/+/17410 )

Change subject: GsmCallFsm: permit MNCC_REL_CNF in any state
..


Patch Set 4: Verified+1


--
To view, visit https://gerrit.osmocom.org/c/mncc-python/+/17410
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: mncc-python
Gerrit-Branch: master
Gerrit-Change-Id: I0d65da82fbcc48c8967a65b917ea14121bd941f3
Gerrit-Change-Number: 17410
Gerrit-PatchSet: 4
Gerrit-Owner: laforge 
Gerrit-Assignee: osmith 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Wed, 29 Apr 2020 16:26:56 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in mncc-python[master]: GsmCallFsm: permit MNCC_REL_CNF in any state

2020-04-29 Thread laforge

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/mncc-python/+/17410 )

Change subject: GsmCallFsm: permit MNCC_REL_CNF in any state
..


Patch Set 4: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/mncc-python/+/17410
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: mncc-python
Gerrit-Branch: master
Gerrit-Change-Id: I0d65da82fbcc48c8967a65b917ea14121bd941f3
Gerrit-Change-Number: 17410
Gerrit-PatchSet: 4
Gerrit-Owner: laforge 
Gerrit-Assignee: osmith 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Wed, 29 Apr 2020 16:26:50 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in mncc-python[master]: GsmCallFsm: permit MNCC_REL_CNF in any state

2020-04-29 Thread laforge

laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/mncc-python/+/17410 )

Change subject: GsmCallFsm: permit MNCC_REL_CNF in any state
..

GsmCallFsm: permit MNCC_REL_CNF in any state

Depending on the type of failure in the MSC, MGW or BSC, we may expect
MNCC_REL_CNF in any state.

Closes: SYS#4832
Change-Id: I0d65da82fbcc48c8967a65b917ea14121bd941f3
---
M gsm_call_fsm.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  laforge: Looks good to me, approved; Verified
  fixeria: Looks good to me, but someone else must approve
  pespin: Looks good to me, but someone else must approve



diff --git a/gsm_call_fsm.py b/gsm_call_fsm.py
index 5f846e1..9e2b633 100644
--- a/gsm_call_fsm.py
+++ b/gsm_call_fsm.py
@@ -180,7 +180,7 @@
 ('mncc_rel_ind', '*', 'NULL'),
 ('mncc_disc_ind', 'DISCONNECT_INDICATION', 
'RELEASE_REQUEST'),

-('mncc_rel_cnf', 'RELEASE_REQUEST', 'NULL'),
+('mncc_rel_cnf', '*', 'NULL'),
 ],
 callbacks = [('onmncc_setup_req', self._onmncc_setup_req),
  ('onmncc_call_conf_ind', self._onmncc_call_conf_ind),

--
To view, visit https://gerrit.osmocom.org/c/mncc-python/+/17410
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: mncc-python
Gerrit-Branch: master
Gerrit-Change-Id: I0d65da82fbcc48c8967a65b917ea14121bd941f3
Gerrit-Change-Number: 17410
Gerrit-PatchSet: 5
Gerrit-Owner: laforge 
Gerrit-Assignee: osmith 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in mncc-python[master]: update .gitignore with rtpsource object code file names

2020-04-29 Thread laforge

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/mncc-python/+/17977 )

Change subject: update .gitignore with rtpsource object code file names
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/mncc-python/+/17977
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: mncc-python
Gerrit-Branch: master
Gerrit-Change-Id: I085d50bb60e4eebda5d92c6e5fbc5a1d56c0badb
Gerrit-Change-Number: 17977
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Wed, 29 Apr 2020 16:24:42 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in mncc-python[master]: rtpsource: Modularize generation of RTP frames

2020-04-29 Thread laforge

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/mncc-python/+/17978 )

Change subject: rtpsource: Modularize generation of RTP frames
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/mncc-python/+/17978
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: mncc-python
Gerrit-Branch: master
Gerrit-Change-Id: Iad98e1753fef1927c0e8a7493372141372a38224
Gerrit-Change-Number: 17978
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Wed, 29 Apr 2020 16:23:33 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in mncc-python[master]: rtpsource: CTRL call rtp_create: add codec arg

2020-04-29 Thread laforge

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/mncc-python/+/17979 )

Change subject: rtpsource: CTRL call rtp_create: add codec arg
..


Patch Set 1:

why use some magic integer number that requires python and C code to agre on 
numbering and whihc will be difficult to understand/debug?  CTRL uses strings, 
so you could juts as well send strings like fr/efr/...


--
To view, visit https://gerrit.osmocom.org/c/mncc-python/+/17979
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: mncc-python
Gerrit-Branch: master
Gerrit-Change-Id: If75e902b451d7e202a03e93afcd55bd24f517813
Gerrit-Change-Number: 17979
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-CC: laforge 
Gerrit-Comment-Date: Wed, 29 Apr 2020 16:22:56 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in mncc-python[master]: mncc_mt_loadgen.py: add codec arg

2020-04-29 Thread laforge

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/mncc-python/+/17980 )

Change subject: mncc_mt_loadgen.py: add codec arg
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/mncc-python/+/17980
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: mncc-python
Gerrit-Branch: master
Gerrit-Change-Id: I5879b8b9ccc63908b9f6629487e66eff1e4a1ab4
Gerrit-Change-Number: 17980
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Wed, 29 Apr 2020 16:21:22 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-ttcn3-hacks[master]: pcu: Get rid of PCU_Tests.ttcn tests

2020-04-29 Thread laforge

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16321 )

Change subject: pcu: Get rid of PCU_Tests.ttcn tests
..


Patch Set 3: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16321
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie862a1525e9f4f9a3f2427ac3898810e3d044d2f
Gerrit-Change-Number: 16321
Gerrit-PatchSet: 3
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Wed, 29 Apr 2020 16:19:34 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-ttcn3-hacks[master]: pcu: Rename PCURAW content to PCU

2020-04-29 Thread laforge

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17975 )

Change subject: pcu: Rename PCU*RAW* content to PCU
..


Patch Set 2: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17975
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iacaddb56e41012ba58ef6d1b9e79d2c012259bed
Gerrit-Change-Number: 17975
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Wed, 29 Apr 2020 16:19:28 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-ttcn3-hacks[master]: pcu: Get rid of PCU_Tests.ttcn tests

2020-04-29 Thread pespin

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16321 )

Change subject: pcu: Get rid of PCU_Tests.ttcn tests
..


Patch Set 3:

Just noticed there's some selftests in PCU_Tests.ttcn which may be worth 
keeping. I'll move those to a new file in another commit to keep them.


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16321
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie862a1525e9f4f9a3f2427ac3898810e3d044d2f
Gerrit-Change-Number: 16321
Gerrit-PatchSet: 3
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Wed, 29 Apr 2020 15:14:08 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in osmo-ttcn3-hacks[master]: pcu: Get rid of PCU_Tests.ttcn tests

2020-04-29 Thread pespin

Hello fixeria, laforge, osmith, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16321

to look at the new patch set (#3).

Change subject: pcu: Get rid of PCU_Tests.ttcn tests
..

pcu: Get rid of PCU_Tests.ttcn tests

Delete PCU_Tests.ttcn along with the configs, since they are broken and
we are only adding new tests to PCU_Tests_RAW.ttcn. They are broken
because it's not possible to run multiple tests after another.

Some components which used to be in PCU_Tests.ttcn and which were used
by other PCU_Tests*.ttcn files have been moved to SGSN_Components.ttcn

Small placeholder for module PCU_Tests is left in PCU_Tests.ttcn to
still be able to compile the binary as "PCU_Tests" and avoid changing
that part of docker setup. We'll eventually rename RAW tests soon
anyway.

Change-Id: Ie862a1525e9f4f9a3f2427ac3898810e3d044d2f
---
M pcu/PCU_Tests.cfg
M pcu/PCU_Tests.default
M pcu/PCU_Tests.ttcn
M pcu/PCU_Tests_RAW.ttcn
M pcu/PCU_Tests_RAW_NS.ttcn
M pcu/PCU_Tests_RAW_SNS.ttcn
M pcu/PCU_Tests_SNS.cfg
M pcu/README.md
A pcu/SGSN_Components.ttcn
M pcu/gen_links.sh
D pcu/osmo-bsc.cfg
D pcu/osmo-bts.cfg
M pcu/regen_makefile.sh
13 files changed, 114 insertions(+), 990 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/21/16321/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16321
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie862a1525e9f4f9a3f2427ac3898810e3d044d2f
Gerrit-Change-Number: 16321
Gerrit-PatchSet: 3
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: newpatchset

Change in mncc-python[master]: rtpsource: Modularize generation of RTP frames

2020-04-29 Thread osmith

Hello laforge,

I'd like you to do a code review. Please visit

https://gerrit.osmocom.org/c/mncc-python/+/17978

to review the following change.


Change subject: rtpsource: Modularize generation of RTP frames
..

rtpsource: Modularize generation of RTP frames

Change-Id: Iad98e1753fef1927c0e8a7493372141372a38224
---
M rtpsource/Makefile
M rtpsource/internal.h
A rtpsource/rtp_provider.c
A rtpsource/rtp_provider.h
A rtpsource/rtp_provider_static.c
M rtpsource/rtpsource.c
6 files changed, 230 insertions(+), 7 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/mncc-python refs/changes/78/17978/1

diff --git a/rtpsource/Makefile b/rtpsource/Makefile
index 9972325..2ede792 100644
--- a/rtpsource/Makefile
+++ b/rtpsource/Makefile
@@ -4,7 +4,7 @@
 CFLAGS:= -g -Wall $(OSMO_CFLAGS)
 LIBS:= $(OSMO_LIBS)

-rtpsource: rtpsource.o ctrl_if.o
+rtpsource: rtpsource.o ctrl_if.o rtp_provider.o rtp_provider_static.o
$(CC) $(LDFLAGS) -o $@ $^ $(LIBS)


diff --git a/rtpsource/internal.h b/rtpsource/internal.h
index 13d07aa..a4501a2 100644
--- a/rtpsource/internal.h
+++ b/rtpsource/internal.h
@@ -8,6 +8,8 @@
DMAIN,
 };

+struct rtp_provider_instance;
+
 struct rtp_connection {
struct llist_head list;

@@ -21,6 +23,7 @@
uint16_t remote_port;

uint8_t rtp_pt;
+   struct rtp_provider_instance *rtp_prov_inst;
 };

 struct rtpsource_state {
diff --git a/rtpsource/rtp_provider.c b/rtpsource/rtp_provider.c
new file mode 100644
index 000..0d2b9c6
--- /dev/null
+++ b/rtpsource/rtp_provider.c
@@ -0,0 +1,54 @@
+#include 
+#include 
+#include 
+
+#include "rtp_provider.h"
+#include "internal.h"
+
+
+static LLIST_HEAD(g_providers);
+static LLIST_HEAD(g_prov_instances);
+
+void rtp_provider_register(struct rtp_provider *prov)
+{
+   llist_add_tail(&prov->list, &g_providers);
+}
+
+const struct rtp_provider *rtp_provider_find(const char *name)
+{
+   struct rtp_provider *p;
+   llist_for_each_entry(p, &g_providers, list) {
+   if (!strcmp(name, p->name))
+   return p;
+   }
+   LOGP(DMAIN, LOGL_ERROR, "Couldn't find RTP provider '%s'\n", name);
+   return NULL;
+}
+
+struct rtp_provider_instance *
+rtp_provider_instance_alloc(void *ctx, const struct rtp_provider *provider, 
enum codec_type codec)
+{
+   struct rtp_provider_instance *pi;
+
+   pi = talloc_zero(ctx, struct rtp_provider_instance);
+   if (!pi)
+   return NULL;
+
+   pi->provider = provider;
+   pi->codec = codec;
+   llist_add_tail(&pi->list, &g_prov_instances);
+
+   return pi;
+}
+
+void rtp_provider_instance_free(struct rtp_provider_instance *pi)
+{
+   llist_del(&pi->list);
+   talloc_free(pi);
+}
+
+int rtp_provider_instance_gen_frame(struct rtp_provider_instance *pi, uint8_t 
*out, size_t out_size)
+{
+   OSMO_ASSERT(pi->provider);
+   return pi->provider->rtp_gen(pi, out, out_size);
+}
diff --git a/rtpsource/rtp_provider.h b/rtpsource/rtp_provider.h
new file mode 100644
index 000..7048a3e
--- /dev/null
+++ b/rtpsource/rtp_provider.h
@@ -0,0 +1,51 @@
+#pragma once
+#include 
+#include 
+
+enum codec_type {
+   CODEC_ULAW,
+   CODEC_ALAW,
+   CODEC_GSM_FR,
+   CODEC_GSM_EFR,
+   CODEC_GSM_HR,
+   CODEC_AMR_4_75,
+   CODEC_AMR_5_15,
+   CODEC_AMR_5_90,
+   CODEC_AMR_6_70,
+   CODEC_AMR_7_40,
+   CODEC_AMR_7_95,
+   CODEC_AMR_10_2,
+   CODEC_AMR_12_2,
+   CODEC_AMR_SID,
+   _NUM_CODECS
+};
+
+struct rtp_provider_instance;
+
+struct rtp_provider {
+   /* global list of RTP providers */
+   struct llist_head list;
+   const char *name;
+
+   /* generate the next RTP packet; return length in octests or negative 
on error */
+   int (*rtp_gen)(struct rtp_provider_instance *inst, uint8_t *out, size_t 
out_size);
+};
+
+struct rtp_provider_instance {
+   /* entry in global list of RTP provider instances */
+   struct llist_head list;
+   /* pointer to provider of which we are an instance */
+   const struct rtp_provider *provider;
+   /* codec payload we are to generate */
+   enum codec_type codec;
+
+   /* private user data */
+   void *priv;
+};
+
+void rtp_provider_register(struct rtp_provider *prov);
+const struct rtp_provider *rtp_provider_find(const char *name);
+
+struct rtp_provider_instance *rtp_provider_instance_alloc(void *ctx, const 
struct rtp_provider *provider, enum codec_type codec);
+void rtp_provider_instance_free(struct rtp_provider_instance *pi);
+int rtp_provider_instance_gen_frame(struct rtp_provider_instance *pi, uint8_t 
*out, size_t out_size);
diff --git a/rtpsource/rtp_provider_static.c b/rtpsource/rtp_provider_static.c
new file mode 100644
index 000..323e686
--- /dev/null
+++ b/rtpsource/rtp_provider_static.c
@@ -0,0 +1,107 @@
+
+#include 
+#include 
+#include 
+
+#include "rtp_provider.h"
+#include "

Change in mncc-python[master]: rtpsource: CTRL call rtp_create: add codec arg

2020-04-29 Thread osmith

osmith has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/mncc-python/+/17979 )


Change subject: rtpsource: CTRL call rtp_create: add codec arg
..

rtpsource: CTRL call rtp_create: add codec arg

Instead of hardcoding FR in rtpsource, add an argument to set the codec
from mncc_mt_loadgen.py via CTRL call rtp_create. Hardcode FR in
mncc_mt_loadgen.py for now, a follow up patch will make it configurable
there, too.

Related: SYS#4924
Change-Id: If75e902b451d7e202a03e93afcd55bd24f517813
---
M mncc_mt_loadgen.py
M rtpsource/ctrl_if.c
M rtpsource/internal.h
M rtpsource/rtpsource.c
4 files changed, 39 insertions(+), 11 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/mncc-python refs/changes/79/17979/1

diff --git a/mncc_mt_loadgen.py b/mncc_mt_loadgen.py
index 021d619..fcae13f 100755
--- a/mncc_mt_loadgen.py
+++ b/mncc_mt_loadgen.py
@@ -80,7 +80,8 @@

 def on_receive(self, message):
 if message['type'] == 'rtp_create':
-(res, var, val) = self._set_var('rtp_create', message['cname'])
+val = '%s,%u' % (message['cname'], message['codec'])
+(res, var, val) = self._set_var('rtp_create', val)
 v = val.split(',') # input looks like '1,127.23.23.23,37723'
 return {'cname': v[0], 'remote_host': v[1], 'remote_port': 
int(v[2])}
 elif message['type'] == 'rtp_connect':
@@ -113,7 +114,8 @@
 self.msisdn_called = msisdn_called
 self.msisdn_calling = msisdn_calling
 # allocate a RTP connection @ rtpsource
-r = self.ctrl_act.ask({'type':'rtp_create', 'cname':self.callref})
+codec = 2 # FR, FIXME: make configurable
+r = self.ctrl_act.ask({'type':'rtp_create', 'cname':self.callref, 
'codec':codec})
 self.ext_rtp_host = r['remote_host']
 self.ext_rtp_port = r['remote_port']
 # start the MNCC call FSM
diff --git a/rtpsource/ctrl_if.c b/rtpsource/ctrl_if.c
index 708fb02..520ff4a 100644
--- a/rtpsource/ctrl_if.c
+++ b/rtpsource/ctrl_if.c
@@ -21,27 +21,52 @@
 #include 

 #include "internal.h"
+#include "rtp_provider.h"

 CTRL_CMD_DEFINE_WO_NOVRF(rtp_create, "rtp_create");
 static int set_rtp_create(struct ctrl_cmd *cmd, void *data)
 {
struct rtp_connection *conn;
-   const char *cname = cmd->value;
+   const char *cname, *codec_str;
+   char *tmp, *saveptr;
+   enum codec_type codec;
+
+   tmp = talloc_strdup(cmd, cmd->value);
+   OSMO_ASSERT(tmp);
+
+   cname = strtok_r(tmp, ",", &saveptr);
+   codec_str = strtok_r(NULL, ",", &saveptr);
+
+   if (!cname || !codec_str) {
+   cmd->reply = "Format is cname,codec";
+   goto error;
+   }

if (find_connection_by_cname(g_rss, cname)) {
cmd->reply = "Connection already exists for cname";
-   return CTRL_CMD_ERROR;
+   goto error;
}

-   conn = create_connection(g_rss, cname);
+   codec = atoi(codec_str);
+   if (codec < 0 || codec >= _NUM_CODECS) {
+   cmd->reply = "Invalid codec";
+   goto error;
+   }
+
+   conn = create_connection(g_rss, cname, codec);
if (!conn) {
cmd->reply = "Error creating RTP connection";
-   return CTRL_CMD_ERROR;
+   goto error;
}

/* Respond */
cmd->reply = talloc_asprintf(cmd, "%s,%s,%d", conn->cname, 
conn->local_host, conn->local_port);
+   talloc_free(tmp);
return CTRL_CMD_REPLY;
+
+error:
+   talloc_free(tmp);
+   return CTRL_CMD_ERROR;
 }

 CTRL_CMD_DEFINE_WO_NOVRF(rtp_connect, "rtp_connect");
diff --git a/rtpsource/internal.h b/rtpsource/internal.h
index a4501a2..35f12d0 100644
--- a/rtpsource/internal.h
+++ b/rtpsource/internal.h
@@ -4,6 +4,8 @@
 #include 
 #include 

+enum codec_type;
+
 enum {
DMAIN,
 };
@@ -36,7 +38,7 @@

 struct rtp_connection *find_connection_by_cname(struct rtpsource_state *rss, 
const char *cname);

-struct rtp_connection *create_connection(struct rtpsource_state *rss, const 
char *cname);
+struct rtp_connection *create_connection(struct rtpsource_state *rss, const 
char *cname, enum codec_type codec);

 int connect_connection(struct rtp_connection *conn, const char *remote_host,
uint16_t remote_port, uint8_t pt);
diff --git a/rtpsource/rtpsource.c b/rtpsource/rtpsource.c
index 3087262..4af8899 100644
--- a/rtpsource/rtpsource.c
+++ b/rtpsource/rtpsource.c
@@ -63,11 +63,10 @@
 }

 /* create a new RTP connection for given CNAME; includes binding of local RTP 
port */
-struct rtp_connection *create_connection(struct rtpsource_state *rss, const 
char *cname)
+struct rtp_connection *create_connection(struct rtpsource_state *rss, const 
char *cname, enum codec_type codec)
 {
const struct rtp_provider *rtp_prov;
struct rtp_connection *conn;
-   enum codec_type codec = CODEC_GSM_FR; //

Change in mncc-python[master]: mncc_mt_loadgen.py: add codec arg

2020-04-29 Thread osmith

osmith has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/mncc-python/+/17980 )


Change subject: mncc_mt_loadgen.py: add codec arg
..

mncc_mt_loadgen.py: add codec arg

Add codec parameter to start_call() and convenience functions mt_call()
and calls() with FR as default. While at it, update the help text.

Duplicate enum codec_type into mncc_mt_loadgen.py, because the enum
values are different from the existing enum values in the python code
(GSM48_BCAP_SV_EFR etc.).

Related: SYS#4924
Change-Id: I5879b8b9ccc63908b9f6629487e66eff1e4a1ab4
---
M mncc_mt_loadgen.py
M rtpsource/rtp_provider.h
2 files changed, 27 insertions(+), 7 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/mncc-python refs/changes/80/17980/1

diff --git a/mncc_mt_loadgen.py b/mncc_mt_loadgen.py
index fcae13f..da0e7fc 100755
--- a/mncc_mt_loadgen.py
+++ b/mncc_mt_loadgen.py
@@ -95,6 +95,22 @@
 else:
 raise Exception('ctrl', 'RtpSourceCtrlActor Received unhandled %s' 
% message)

+# Keep in sync with enum codec_type in rtpsource/rtp_provider.h
+CODEC_ULAW = 0
+CODEC_ALAW = 1
+CODEC_GSM_FR = 2
+CODEC_GSM_EFR = 3
+CODEC_GSM_HR = 4
+CODEC_AMR_4_75 = 5
+CODEC_AMR_5_15 = 6
+CODEC_AMR_5_90 = 7
+CODEC_AMR_6_70 = 8
+CODEC_AMR_7_40 = 9
+CODEC_AMR_7_95 = 10
+CODEC_AMR_10_2 = 11
+CODEC_AMR_12_2 = 12
+CODEC_AMR_SID = 13
+

 class MTCallRtpsource(pykka.ThreadingActor):
 '''Actor to start a network-initiated MT (mobile terminated) call to a 
given MSISDN,
@@ -109,12 +125,11 @@
 self.state = 'NULL'
 self.rtp_msc = None

-def start_call(self, msisdn_called, msisdn_calling):
+def start_call(self, msisdn_called, msisdn_calling, codec):
 '''Start a MT call from given [external] calling party to given mobile 
party MSISDN'''
 self.msisdn_called = msisdn_called
 self.msisdn_calling = msisdn_calling
 # allocate a RTP connection @ rtpsource
-codec = 2 # FR, FIXME: make configurable
 r = self.ctrl_act.ask({'type':'rtp_create', 'cname':self.callref, 
'codec':codec})
 self.ext_rtp_host = r['remote_host']
 self.ext_rtp_port = r['remote_port']
@@ -173,23 +188,27 @@
 rtpctrl_act = RtpSourceCtrlActor.start(RTPSOURCE_CTRL_IP, RTPSOURCE_CTRL_PORT)

 # convenience wrapper
-def mt_call(msisdn_called, msisdn_calling = '123456789', codecs = 
GSM48.AllCodecs):
+def mt_call(msisdn_called, msisdn_calling='123456789', codecs=GSM48.AllCodecs, 
codec=CODEC_GSM_FR):
 call_conn = MTCallRtpsource.start(mncc_act, rtpctrl_act, codecs).proxy()
-call_conn.start_call(msisdn_called, msisdn_calling)
+call_conn.start_call(msisdn_called, msisdn_calling, codec)
 return call_conn

-def calls(nr, ramp=1.0):
+def calls(nr, ramp=1.0, codec=CODEC_GSM_FR):
 for i in range(nr):
 a = 90001 + i
 a = str(a)
 print("%d: mt_call(%r)" % (i, a))
-mt_call(a)
+mt_call(a, codec=codec)
 time.sleep(ramp)

 log.info("")
 log.info("")
-log.info("Start calls by typing:")
+log.info("Start a single call by typing:")
 log.info("mt_call('90001')")
+log.info("With a specific codec (default is FR):")
+log.info("mt_call('90001', codec=CODEC_GSM_EFR)")
+log.info("Start multiple calls with (e.g. 4 calls with EFR):")
+log.info("calls(4, codec=CODEC_GSM_EFR)")
 log.info("")
 log.info("")

diff --git a/rtpsource/rtp_provider.h b/rtpsource/rtp_provider.h
index 7048a3e..3dd9fa8 100644
--- a/rtpsource/rtp_provider.h
+++ b/rtpsource/rtp_provider.h
@@ -2,6 +2,7 @@
 #include 
 #include 

+/* Keep in sync with CODEC_* in mncc_mt_loadgen.py */
 enum codec_type {
CODEC_ULAW,
CODEC_ALAW,

--
To view, visit https://gerrit.osmocom.org/c/mncc-python/+/17980
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: mncc-python
Gerrit-Branch: master
Gerrit-Change-Id: I5879b8b9ccc63908b9f6629487e66eff1e4a1ab4
Gerrit-Change-Number: 17980
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-MessageType: newchange

Change in mncc-python[master]: update .gitignore with rtpsource object code file names

2020-04-29 Thread osmith

Hello laforge,

I'd like you to do a code review. Please visit

https://gerrit.osmocom.org/c/mncc-python/+/17977

to review the following change.


Change subject: update .gitignore with rtpsource object code file names
..

update .gitignore with rtpsource object code file names

Change-Id: I085d50bb60e4eebda5d92c6e5fbc5a1d56c0badb
---
M .gitignore
1 file changed, 3 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/mncc-python refs/changes/77/17977/1

diff --git a/.gitignore b/.gitignore
index b948985..77e974f 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,2 +1,5 @@
 *.swp
 *.pyc
+
+*.o
+rtpsource/rtpsource

--
To view, visit https://gerrit.osmocom.org/c/mncc-python/+/17977
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: mncc-python
Gerrit-Branch: master
Gerrit-Change-Id: I085d50bb60e4eebda5d92c6e5fbc5a1d56c0badb
Gerrit-Change-Number: 17977
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: laforge 
Gerrit-MessageType: newchange

Change in osmo-ttcn3-hacks[master]: pcu: Rename PCURAW content to PCU

2020-04-29 Thread pespin

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17975 )

Change subject: pcu: Rename PCU*RAW* content to PCU
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17975/1/pcu/PCUIF_Components.ttcn
File pcu/PCUIF_Components.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17975/1/pcu/PCUIF_Components.ttcn@51
PS1, Line 51: RAW_
> Shouldn't we get rid of this prefix / suffix / postfix in all symbols?
Yes, but that would make the commit a lot more complex, since there's lots of 
those. I can do that in a next commit.



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17975
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iacaddb56e41012ba58ef6d1b9e79d2c012259bed
Gerrit-Change-Number: 17975
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Wed, 29 Apr 2020 14:05:37 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria 
Gerrit-MessageType: comment

Change in osmo-ttcn3-hacks[master]: pcu: Get rid of PCU_Tests.ttcn tests

2020-04-29 Thread pespin

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16321 )

Change subject: pcu: Get rid of PCU_Tests.ttcn tests
..


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16321/2/pcu/PCU_Tests.ttcn
File pcu/PCU_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16321/2/pcu/PCU_Tests.ttcn@a308
PS2, Line 308: f_rrbp_fn
> I like this function. We will need it some day.
It's already ijmplemented in RLCMAC_Types.ttcn:
function f_rrbp_fn_delay(MacRrbp rrbp) return uint32_t {
select (rrbp) {
case (RRBP_Nplus13_mod_2715648) { return 13; }
case (RRBP_Nplus17_or_18_mod_2715648) { return 17; }
case (RRBP_Nplus21_or_22_mod_2715648) { return 21;  }
case (RRBP_Nplus26_mod_2715648) { return 26; }
}
return 0;
}



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16321
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie862a1525e9f4f9a3f2427ac3898810e3d044d2f
Gerrit-Change-Number: 16321
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Wed, 29 Apr 2020 14:04:38 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria 
Gerrit-MessageType: comment

Change in osmo-ttcn3-hacks[master]: pcu: Rename PCURAW content to PCU

2020-04-29 Thread fixeria

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17975 )

Change subject: pcu: Rename PCU*RAW* content to PCU
..


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17975/1/pcu/PCUIF_Components.ttcn
File pcu/PCUIF_Components.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17975/1/pcu/PCUIF_Components.ttcn@51
PS1, Line 51: RAW_
Shouldn't we get rid of this prefix / suffix / postfix in all symbols?



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17975
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iacaddb56e41012ba58ef6d1b9e79d2c012259bed
Gerrit-Change-Number: 17975
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Comment-Date: Wed, 29 Apr 2020 14:02:10 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in docker-playground[master]: ttcn3-pcu: Fix cfgn content after ttcn3 module renaming

2020-04-29 Thread pespin

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/docker-playground/+/17976 )

Change subject: ttcn3-pcu: Fix cfgn content after ttcn3 module renaming
..


Patch Set 1: Verified+1


--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/17976
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I0710f52ddab8da8638970d28dc88f6882cc5f637
Gerrit-Change-Number: 17976
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Wed, 29 Apr 2020 13:55:42 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-ttcn3-hacks[master]: pcu: Get rid of PCU_Tests.ttcn tests

2020-04-29 Thread fixeria

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16321 )

Change subject: pcu: Get rid of PCU_Tests.ttcn tests
..


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16321/2/pcu/PCU_Tests.ttcn
File pcu/PCU_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16321/2/pcu/PCU_Tests.ttcn@a308
PS2, Line 308: f_rrbp_fn
I like this function. We will need it some day.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16321/2/pcu/gen_links.sh
File pcu/gen_links.sh:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16321/2/pcu/gen_links.sh@52
PS2, Line 52: L1CTL_Types.ttcn L1CTL_PortType.ttcn 
L1CTL_PortType_CtrlFunct.ttcn L1CTL_PortType_CtrlFunctDef.cc
All L1CTL related modules should be removed too, they're not used anymore.



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16321
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie862a1525e9f4f9a3f2427ac3898810e3d044d2f
Gerrit-Change-Number: 16321
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Wed, 29 Apr 2020 13:52:59 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in docker-playground[master]: ttcn3-pcu: Fix cfgn content after ttcn3 module renaming

2020-04-29 Thread pespin

pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/docker-playground/+/17976 )


Change subject: ttcn3-pcu: Fix cfgn content after ttcn3 module renaming
..

ttcn3-pcu: Fix cfgn content after ttcn3 module renaming

Required after osmo-ttcn3-hacks.git:
Ie862a1525e9f4f9a3f2427ac3898810e3d044d2f
Iacaddb56e41012ba58ef6d1b9e79d2c012259bed

Change-Id: I0710f52ddab8da8638970d28dc88f6882cc5f637
---
M ttcn3-pcu-test/PCU_Tests.cfg
M ttcn3-pcu-test/sns/PCU_Tests.cfg
2 files changed, 7 insertions(+), 7 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/docker-playground 
refs/changes/76/17976/1

diff --git a/ttcn3-pcu-test/PCU_Tests.cfg b/ttcn3-pcu-test/PCU_Tests.cfg
index 8c75ca9..17ab6c6 100644
--- a/ttcn3-pcu-test/PCU_Tests.cfg
+++ b/ttcn3-pcu-test/PCU_Tests.cfg
@@ -9,8 +9,8 @@
 *.PCUVTY.PROMPT1 := "OsmoPCU> "

 [MODULE_PARAMETERS]
-PCU_Tests_RAW.mp_pcu_sock_path := "/data/unix/pcu_bts"
-PCU_Tests.mp_nsconfig := {
+PCU_Tests.mp_pcu_sock_path := "/data/unix/pcu_bts"
+SGSN_Components.mp_nsconfig := {
local_ip := "172.18.13.10",
local_udp_port := 23000,
remote_ip := "172.18.13.101",
@@ -23,5 +23,5 @@
 [MAIN_CONTROLLER]

 [EXECUTE]
-PCU_Tests_RAW.control
-PCU_Tests_RAW_NS.control
+PCU_Tests.control
+PCU_Tests_NS.control
diff --git a/ttcn3-pcu-test/sns/PCU_Tests.cfg b/ttcn3-pcu-test/sns/PCU_Tests.cfg
index 07db9b3..60f375b 100644
--- a/ttcn3-pcu-test/sns/PCU_Tests.cfg
+++ b/ttcn3-pcu-test/sns/PCU_Tests.cfg
@@ -7,8 +7,8 @@
 [TESTPORT_PARAMETERS]

 [MODULE_PARAMETERS]
-PCU_Tests_RAW.mp_pcu_sock_path := "/data/unix/pcu_bts"
-PCU_Tests.mp_nsconfig := {
+PCU_Tests.mp_pcu_sock_path := "/data/unix/pcu_bts"
+SGSN_Components.mp_nsconfig := {
local_ip := "172.18.14.10",
local_udp_port := 23000,
remote_ip := "172.18.14.101",
@@ -20,4 +20,4 @@
 [MAIN_CONTROLLER]

 [EXECUTE]
-PCU_Tests_RAW_SNS.control
+PCU_Tests_SNS.control

--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/17976
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I0710f52ddab8da8638970d28dc88f6882cc5f637
Gerrit-Change-Number: 17976
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange

Change in osmo-ttcn3-hacks[master]: pcu: Get rid of PCU_Tests.ttcn tests

2020-04-29 Thread pespin

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16321 )

Change subject: pcu: Get rid of PCU_Tests.ttcn tests
..


Patch Set 2:

This change is ready for review.


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16321
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie862a1525e9f4f9a3f2427ac3898810e3d044d2f
Gerrit-Change-Number: 16321
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Wed, 29 Apr 2020 13:22:41 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in osmo-bts[master]: osmo-bts-trx: Change default for clock_advance to 3

2020-04-29 Thread pespin

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/17766 )

Change subject: osmo-bts-trx: Change default for clock_advance to 3
..


Patch Set 1: Code-Review-1

YOu are missing to update the documentation (and probably vty config).

doc/manuals/chapters/bts-models.adoc:
"The default value for `fn-advance` is 20 (corresponding to 92
milliseconds)."


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/17766
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I7da3d0948f38e12342fb714b29f8edc5e9d0933d
Gerrit-Change-Number: 17766
Gerrit-PatchSet: 1
Gerrit-Owner: daniel 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Wed, 29 Apr 2020 12:58:32 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: VTY: make configurable: T23002, T23005, T23006

2020-04-29 Thread pespin

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/17973 )

Change subject: VTY: make configurable: T23002, T23005, T23006
..


Patch Set 3:

> Patch Set 3:
>
> Maybe we should make those timer numbers negative before exposing them to the 
> user? So there will be no confusion whether they're Osmocom-specific or 
> defined by 3GPP.

Indeed if they are not defined in specs then they should be negative. I took 
that for granted but maybe it's not the case.


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/17973
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I637fcdde93c11158de46157d494c060bb36bdcfb
Gerrit-Change-Number: 17973
Gerrit-PatchSet: 3
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-CC: fixeria 
Gerrit-CC: laforge 
Gerrit-Comment-Date: Wed, 29 Apr 2020 12:40:02 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Build failure of network:osmocom:nightly/osmo-uecups in Debian_9.0/armv7l

2020-04-29 Thread OBS Notification

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-uecups/Debian_9.0/armv7l

Package network:osmocom:nightly/osmo-uecups failed to build in Debian_9.0/armv7l

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-uecups

Last lines of build log:
[  567s]^~~
[  567s] main.c: In function 'main':
[  567s] main.c:776:23: error: implicit declaration of function 
'osmo_signalfd_setup' [-Werror=implicit-function-declaration]
[  567s]   g_daemon->signalfd = osmo_signalfd_setup(g_daemon, sigset, 
signal_cb, g_daemon);
[  567s]^~~
[  567s] main.c:776:21: warning: assignment makes pointer from integer without 
a cast [-Wint-conversion]
[  567s]   g_daemon->signalfd = osmo_signalfd_setup(g_daemon, sigset, 
signal_cb, g_daemon);
[  567s]  ^
[  567s] cc1: some warnings being treated as errors
[  567s] Makefile:469: recipe for target 'main.o' failed
[  567s] make[3]: *** [main.o] Error 1
[  567s] make[3]: Leaving directory '/usr/src/packages/BUILD/daemon'
[  567s] Makefile:402: recipe for target 'all-recursive' failed
[  567s] make[2]: *** [all-recursive] Error 1
[  567s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  567s] Makefile:349: recipe for target 'all' failed
[  567s] make[1]: *** [all] Error 2
[  567s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  567s] dh_auto_build: make -j1 returned exit code 2
[  567s] debian/rules:45: recipe for target 'build' failed
[  567s] make: *** [build] Error 2
[  567s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  567s] ### VM INTERACTION START ###
[  570s] [  515.002558] sysrq: SysRq : Power Off
[  570s] [  515.005016] reboot: Power down
[  570s] ### VM INTERACTION END ###
[  570s] 
[  570s] armbuild14 failed "build osmo-uecups_0.1.3.1.8362.dsc" at Wed Apr 29 
12:20:24 UTC 2020.
[  570s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)

Change in osmo-bsc[master]: VTY: make configurable: T23002, T23005, T23006

2020-04-29 Thread fixeria

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/17973 )

Change subject: VTY: make configurable: T23002, T23005, T23006
..


Patch Set 3:

Maybe we should make those timer numbers negative before exposing them to the 
user? So there will be no confusion whether they're Osmocom-specific or defined 
by 3GPP.


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/17973
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I637fcdde93c11158de46157d494c060bb36bdcfb
Gerrit-Change-Number: 17973
Gerrit-PatchSet: 3
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-CC: fixeria 
Gerrit-CC: laforge 
Gerrit-Comment-Date: Wed, 29 Apr 2020 12:03:50 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in mncc-python[master]: GsmCallFsm: permit MNCC_REL_CNF in any state

2020-04-29 Thread fixeria

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/mncc-python/+/17410 )

Change subject: GsmCallFsm: permit MNCC_REL_CNF in any state
..


Patch Set 4: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/mncc-python/+/17410
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: mncc-python
Gerrit-Branch: master
Gerrit-Change-Id: I0d65da82fbcc48c8967a65b917ea14121bd941f3
Gerrit-Change-Number: 17410
Gerrit-PatchSet: 4
Gerrit-Owner: laforge 
Gerrit-Assignee: osmith 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Wed, 29 Apr 2020 12:00:15 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in mncc-python[master]: GsmCallFsm: permit MNCC_REL_CNF in any state

2020-04-29 Thread pespin

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/mncc-python/+/17410 )

Change subject: GsmCallFsm: permit MNCC_REL_CNF in any state
..


Patch Set 4: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/mncc-python/+/17410
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: mncc-python
Gerrit-Branch: master
Gerrit-Change-Id: I0d65da82fbcc48c8967a65b917ea14121bd941f3
Gerrit-Change-Number: 17410
Gerrit-PatchSet: 4
Gerrit-Owner: laforge 
Gerrit-Assignee: osmith 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Wed, 29 Apr 2020 11:34:18 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: VTY: make configurable: T23002, T23005, T23006

2020-04-29 Thread pespin

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/17973 )

Change subject: VTY: make configurable: T23002, T23005, T23006
..


Patch Set 3: Code-Review+1

where is that default value of 5 taken from? (the one for non defined timers).


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/17973
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I637fcdde93c11158de46157d494c060bb36bdcfb
Gerrit-Change-Number: 17973
Gerrit-PatchSet: 3
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-CC: laforge 
Gerrit-Comment-Date: Wed, 29 Apr 2020 11:33:26 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmo-abis[master]: src/input/ipaccess.c: set TCP_NODELAY

2020-04-29 Thread pespin

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-abis/+/17972 )

Change subject: src/input/ipaccess.c: set TCP_NODELAY
..


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/c/libosmo-abis/+/17972/1/src/input/ipaccess.c
File src/input/ipaccess.c:

https://gerrit.osmocom.org/c/libosmo-abis/+/17972/1/src/input/ipaccess.c@314
PS1, Line 314: FIXME: just call update_fd_settings() here instead?
> Can somebody more familiar with libosmo-abis advise me, if it would be better 
> to call update_fd_sett […]
Why is the setsockopt call needed here anyway? I don't see any new socket being 
created, only an osmo_fd wrapper for an already existing socket.
I think we need to drop this call or move it near to where the socket is 
created if required.


https://gerrit.osmocom.org/c/libosmo-abis/+/17972/1/src/input/ipaccess.c@600
PS1, Line 600:  ret = setsockopt(fd, IPPROTO_TCP, TCP_NODELAY, &val, 
sizeof(val));
update_fd_settings() is called to set line specific params to an already 
existing socket (I have my doubts current use and places wher eit is used makes 
sense, but anyway).

In this case, we want to set TCP_NODEL on OML and RSL sockets ALWAYS. So simply 
move the call nexto where the socket fds are created.



--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/17972
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: Ia3d4c41bf0659e682f0b7ae5f3d58ed0f28edb58
Gerrit-Change-Number: 17972
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Wed, 29 Apr 2020 11:26:37 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: osmith 
Gerrit-MessageType: comment

Change in mncc-python[master]: GsmCallFsm: permit MNCC_REL_CNF in any state

2020-04-29 Thread osmith

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/mncc-python/+/17410 )

Change subject: GsmCallFsm: permit MNCC_REL_CNF in any state
..


Patch Set 4:

This change is ready for review.


--
To view, visit https://gerrit.osmocom.org/c/mncc-python/+/17410
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: mncc-python
Gerrit-Branch: master
Gerrit-Change-Id: I0d65da82fbcc48c8967a65b917ea14121bd941f3
Gerrit-Change-Number: 17410
Gerrit-PatchSet: 4
Gerrit-Owner: laforge 
Gerrit-Assignee: osmith 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Wed, 29 Apr 2020 10:13:22 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in mncc-python[master]: GsmCallFsm: permit MNCC_REL_CNF in any state

2020-04-29 Thread osmith

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/mncc-python/+/17410 )

Change subject: GsmCallFsm: permit MNCC_REL_CNF in any state
..


Patch Set 3:

I just realized... there is also '*'. I'll update the patch to use that instead.


--
To view, visit https://gerrit.osmocom.org/c/mncc-python/+/17410
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: mncc-python
Gerrit-Branch: master
Gerrit-Change-Id: I0d65da82fbcc48c8967a65b917ea14121bd941f3
Gerrit-Change-Number: 17410
Gerrit-PatchSet: 3
Gerrit-Owner: laforge 
Gerrit-Assignee: osmith 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Wed, 29 Apr 2020 10:10:23 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in mncc-python[master]: GsmCallFsm: permit MNCC_REL_CNF in any state

2020-04-29 Thread osmith

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/mncc-python/+/17410 )

Change subject: GsmCallFsm: permit MNCC_REL_CNF in any state
..


Patch Set 3:

(1 comment)

This change is ready for review.

https://gerrit.osmocom.org/c/mncc-python/+/17410/2/gsm_call_fsm.py
File gsm_call_fsm.py:

https://gerrit.osmocom.org/c/mncc-python/+/17410/2/gsm_call_fsm.py@183
PS2, Line 183: ('mncc_rel_cnf', 
['RELEASE_REQUEST','ACTIVE'], 'NULL'),
> actually, it seesm depending on the type of failure in the MSC, MGW or BSC, 
> we may expect MNCC_REL_C […]
Done



--
To view, visit https://gerrit.osmocom.org/c/mncc-python/+/17410
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: mncc-python
Gerrit-Branch: master
Gerrit-Change-Id: I0d65da82fbcc48c8967a65b917ea14121bd941f3
Gerrit-Change-Number: 17410
Gerrit-PatchSet: 3
Gerrit-Owner: laforge 
Gerrit-Assignee: osmith 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Wed, 29 Apr 2020 10:09:19 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge 
Gerrit-MessageType: comment

Change in osmo-bsc[master]: VTY: make configurable: T23002, T23005, T23006

2020-04-29 Thread osmith

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/17973 )

Change subject: VTY: make configurable: T23002, T23005, T23006
..


Patch Set 3:

This change is ready for review.


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/17973
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I637fcdde93c11158de46157d494c060bb36bdcfb
Gerrit-Change-Number: 17973
Gerrit-PatchSet: 3
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-CC: laforge 
Gerrit-Comment-Date: Wed, 29 Apr 2020 09:17:08 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in docker-playground[master]: open5gs: Add pgw.sh

2020-04-29 Thread laforge

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/docker-playground/+/17955 )

Change subject: open5gs: Add pgw.sh
..


Patch Set 1: Verified+1 Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/17955
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I4527b5e328fb248552e69961b80b9f791ec74293
Gerrit-Change-Number: 17955
Gerrit-PatchSet: 1
Gerrit-Owner: laforge 
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Wed, 29 Apr 2020 09:11:20 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in docker-playground[master]: open5gs: Add pgw.sh

2020-04-29 Thread laforge

laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/docker-playground/+/17955 )

Change subject: open5gs: Add pgw.sh
..

open5gs: Add pgw.sh

This can serve as an entrypoint for running open5gs-pgw inside
the open5gs-master container.  It will run setup.sh to create the ogstun
device, followed by running open5gs-pgwd as 'osmocom' user.

Change-Id: I4527b5e328fb248552e69961b80b9f791ec74293
---
M open5gs-master/Dockerfile
A open5gs-master/pgw.sh
M open5gs-master/setup.sh
3 files changed, 6 insertions(+), 0 deletions(-)

Approvals:
  laforge: Looks good to me, approved; Verified



diff --git a/open5gs-master/Dockerfile b/open5gs-master/Dockerfile
index 1bfc7cb..37344cf 100644
--- a/open5gs-master/Dockerfile
+++ b/open5gs-master/Dockerfile
@@ -44,6 +44,7 @@
 apt-get clean

 COPY setup.sh /root
+COPY pgw.sh /root

 # crate user
 ARG username=osmocom
diff --git a/open5gs-master/pgw.sh b/open5gs-master/pgw.sh
new file mode 100755
index 000..3286256
--- /dev/null
+++ b/open5gs-master/pgw.sh
@@ -0,0 +1,5 @@
+#!/bin/sh
+set -e
+set -x
+/root/setup.sh
+su - osmocom -c "open5gs-pgwd $*"
diff --git a/open5gs-master/setup.sh b/open5gs-master/setup.sh
old mode 100644
new mode 100755

--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/17955
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I4527b5e328fb248552e69961b80b9f791ec74293
Gerrit-Change-Number: 17955
Gerrit-PatchSet: 1
Gerrit-Owner: laforge 
Gerrit-Reviewer: laforge 
Gerrit-MessageType: merged

Change in pysim[master]: Extend parsing and printing of Service table to ISIM

2020-04-29 Thread laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/17899 
)

Change subject: Extend parsing and printing of Service table to ISIM
..

Extend parsing and printing of Service table to ISIM

Change-Id: I7657432df76e9de5e4e5fdecfd717d8363de8270
---
M pySim/utils.py
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/pySim/utils.py b/pySim/utils.py
index 56f9706..1980685 100644
--- a/pySim/utils.py
+++ b/pySim/utils.py
@@ -331,7 +331,10 @@
Parses the EF S/U/IST and prints the list of available services in EF 
S/U/IST
"""

-   if table == "usim":
+   if table == "isim":
+   from pySim.ts_31_103 import EF_IST_map
+   lookup_map = EF_IST_map
+   elif table == "usim":
from pySim.ts_31_102 import EF_UST_map
lookup_map = EF_UST_map
else:

--
To view, visit https://gerrit.osmocom.org/c/pysim/+/17899
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I7657432df76e9de5e4e5fdecfd717d8363de8270
Gerrit-Change-Number: 17899
Gerrit-PatchSet: 2
Gerrit-Owner: herlesupreeth 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-MessageType: merged

Change in pysim[master]: Use helper method to print available service in EF.SST

2020-04-29 Thread laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/17897 
)

Change subject: Use helper method to print available service in EF.SST
..

Use helper method to print available service in EF.SST

Change-Id: I375475e9f7210dae4e8da7258d6824dc2d54cf4c
---
M pySim-read.py
M pysim-testdata/Fairwaves-SIM.ok
M pysim-testdata/Wavemobile-SIM.ok
M pysim-testdata/fakemagicsim.ok
M pysim-testdata/sysmoISIM-SJA2.ok
M pysim-testdata/sysmoUSIM-SJS1.ok
M pysim-testdata/sysmosim-gr1.ok
7 files changed, 244 insertions(+), 243 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/pySim-read.py b/pySim-read.py
index 8f81443..7557201 100755
--- a/pySim-read.py
+++ b/pySim-read.py
@@ -32,7 +32,7 @@

 from pySim.commands import SimCardCommands
 from pySim.cards import card_detect, Card
-from pySim.utils import h2b, swap_nibbles, rpad, dec_imsi, dec_iccid, 
dec_msisdn, format_xplmn_w_act, dec_spn
+from pySim.utils import h2b, swap_nibbles, rpad, dec_imsi, dec_iccid, 
dec_msisdn, format_xplmn_w_act, dec_spn, dec_st


 def parse_options():
@@ -234,16 +234,11 @@
print("AD: Can't read, response code = %s" % (sw,))

# EF.SST
-   (res, sw) = card.read_sst()
+   (res, sw) = card.read_binary('SST')
if sw == '9000':
-   # (st_hex, avail_src_list) = res
-   # st_hex - Service Table in hex format
-   # avail_src_list - List of services available
-   print("SIM Service Table: %s" % res[0])
+   print("SIM Service Table: %s" % res)
# Print those which are available
-   for s in res[1]:
-   if s in EF_SST_map:
-   print('\tService %d - %s: %s' % (s, 
EF_SST_map[s], s in res[1]))
+   print("%s" % dec_st(res))
else:
print("SIM Service Table: Can't read, response code = %s" % 
(sw,))

diff --git a/pysim-testdata/Fairwaves-SIM.ok b/pysim-testdata/Fairwaves-SIM.ok
index 1dbaab6..9df44fd 100644
--- a/pysim-testdata/Fairwaves-SIM.ok
+++ b/pysim-testdata/Fairwaves-SIM.ok
@@ -44,46 +44,47 @@
 MSISDN: Not available
 AD: 0002
 SIM Service Table: ff3cc3ff030fff0f000fff03f0c0
-   Service 1 - CHV1 disable function: True
-   Service 2 - Abbreviated Dialling Numbers (ADN): True
-   Service 3 - Fixed Dialling Numbers (FDN): True
-   Service 4 - Short Message Storage (SMS): True
-   Service 5 - Advice of Charge (AoC): True
-   Service 6 - Capability Configuration Parameters (CCP): True
-   Service 7 - PLMN selector: True
-   Service 8 - RFU: True
-   Service 11 - Extension2: True
-   Service 12 - SMS Parameters: True
-   Service 13 - Last Number Dialled (LND): True
-   Service 14 - Cell Broadcast Message Identifier: True
-   Service 17 - Service Provider Name: True
-   Service 18 - Service Dialling Numbers (SDN): True
-   Service 23 - enhanced Multi-Level Precedence and Pre-emption Service: 
True
-   Service 24 - Automatic Answer for eMLPP: True
-   Service 25 - Data download via SMS-CB: True
-   Service 26 - Data download via SMS-PP: True
-   Service 27 - Menu selection: True
-   Service 28 - Call control: True
-   Service 29 - Proactive SIM: True
-   Service 30 - Cell Broadcast Message Identifier Ranges: True
-   Service 31 - Barred Dialling Numbers (BDN): True
-   Service 32 - Extension4: True
-   Service 33 - De-personalization Control Keys: True
-   Service 34 - Co-operative Network List: True
-   Service 41 - USSD string data object supported in Call Control: True
-   Service 42 - RUN AT COMMAND command: True
-   Service 43 - User controlled PLMN Selector with Access Technology: True
-   Service 44 - Operator controlled PLMN Selector with Access Technology: 
True
-   Service 49 - MExE: True
-   Service 50 - Reserved and shall be ignored: True
-   Service 51 - PLMN Network Name: True
-   Service 52 - Operator PLMN List: True
-   Service 53 - Mailbox Dialling Numbers: True
-   Service 54 - Message Waiting Indication Status: True
-   Service 55 - Call Forwarding Indication Status: True
-   Service 56 - Service Provider Display Information: True
-   Service 57 - Multimedia Messaging Service (MMS): True
-   Service 58 - Extension 8: True
-   Service 59 - MMS User Connectivity Parameters: True
+   Service 1 - CHV1 disable function
+   Service 2 - Abbreviated Dialling Numbers (ADN)
+   Service 3 - Fixed Dialling Numbers (FDN)
+   Service 4 - Short Message Storage (SMS)
+   Service 5 - Advice of Charge (AoC)
+   Service 6 - Capability Configuration Parameters (CCP)
+   Service 7 - PLMN selector
+   Service 8 - RFU
+   Service 11 - Extension2
+   Service 12 - SMS Parameters
+   Service 13 - Last Number Dialled (

Change in pysim[master]: Remove redundant functions

2020-04-29 Thread laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/17898 
)

Change subject: Remove redundant functions
..

Remove redundant functions

Change-Id: I2dfb5b662b8a4f351e4a629040b405c182e58e8d
---
M pySim/cards.py
M pySim/utils.py
2 files changed, 0 insertions(+), 30 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/pySim/cards.py b/pySim/cards.py
index c0462fb..d2f1057 100644
--- a/pySim/cards.py
+++ b/pySim/cards.py
@@ -188,14 +188,6 @@
else:
return (None, sw)

-   # Read SIM Service table
-   def read_sst(self):
-   (res, sw) = self._scc.read_binary(EF['SST'])
-   if sw == '9000':
-   return ((res, parse_st(res)), sw)
-   else:
-   return (None, sw)
-
# Read the (full) AID for either ISIM or USIM or ISIM application
def read_aid(self, isim = False):

diff --git a/pySim/utils.py b/pySim/utils.py
index be670e9..56f9706 100644
--- a/pySim/utils.py
+++ b/pySim/utils.py
@@ -326,28 +326,6 @@

return ('%02x' % bcd_len) + ('%02x' % npi_ton) + bcd

-def parse_st(st):
-   """
-   Parses the EF S/U/IST and returns available/supported services
-   """
-   st_bytes = [st[i:i+2] for i in range(0, len(st), 2) ]
-   avail_srvc = []
-   # Get each byte and check for available services
-   for i in range(0, len(st_bytes)):
-   # Byte i contains info about Services num (8i+1) to num (8i+8)
-   byte = int(st_bytes[i], 16)
-   # Services in each byte are in order MSB to LSB
-   # MSB - Service (8i+8)
-   # LSB - Service (8i+1)
-   for j in range(1, 9):
-   if byte&0x01 == 0x01:
-   # Byte X contains info about Services num 
(8X-7) to num (8X)
-   # bit = 1: service available
-   # bit = 0: service not available
-   avail_srvc.append((8*i) + j)
-   byte = byte >> 1
-   return avail_srvc
-
 def dec_st(st, table="sim"):
"""
Parses the EF S/U/IST and prints the list of available services in EF 
S/U/IST

--
To view, visit https://gerrit.osmocom.org/c/pysim/+/17898
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I2dfb5b662b8a4f351e4a629040b405c182e58e8d
Gerrit-Change-Number: 17898
Gerrit-PatchSet: 2
Gerrit-Owner: herlesupreeth 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-MessageType: merged

Change in pysim[master]: utils.py: Add helper method to parse ePDG Identifier from hex string

2020-04-29 Thread laforge

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/pysim/+/17883 )

Change subject: utils.py: Add helper method to parse ePDG Identifier from hex 
string
..


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/pysim/+/17883/1/pySim/utils.py
File pySim/utils.py:

https://gerrit.osmocom.org/c/pysim/+/17883/1/pySim/utils.py@365
PS1, Line 365:  if o
> this is addressed in future commits which I will be submitting - 
> https://github. […]
In that commit you linked you still hand-coded the TLV parsing instead of using 
an existing parser.  I'm sure there must be existing python libraries for smart 
cards that deal with this.



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/17883
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I96fb129d178cfd7ec037989526da77899ae8d344
Gerrit-Change-Number: 17883
Gerrit-PatchSet: 2
Gerrit-Owner: herlesupreeth 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: herlesupreeth 
Gerrit-CC: laforge 
Gerrit-Comment-Date: Wed, 29 Apr 2020 09:10:51 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: herlesupreeth 
Comment-In-Reply-To: laforge 
Gerrit-MessageType: comment

Change in pysim[master]: Enable parsing of ISIM Service table (IST)

2020-04-29 Thread laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/17882 
)

Change subject: Enable parsing of ISIM Service table (IST)
..

Enable parsing of ISIM Service table (IST)

As per TS 31.103, This EF indicates which ISIM services are available.
If a service is not indicated as available in the ISIM, the ME shall not select 
this service.

Parsing of IST is achieved by first selecting the ISIM application using its 
AID.
This is followed by selecting EF.IST with File ID - 6f07 in ADF.ISIM

Change-Id: I3f0a7227360b72a707dc1bcc4cc9c8a4ec7ad2b2
---
M pySim-read.py
M pysim-testdata/sysmoISIM-SJA2.ok
2 files changed, 19 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/pySim-read.py b/pySim-read.py
index 4551e82..33e93a7 100755
--- a/pySim-read.py
+++ b/pySim-read.py
@@ -30,6 +30,7 @@
 import sys
 from pySim.ts_51_011 import EF, DF, EF_SST_map
 from pySim.ts_31_102 import EF_UST_map
+from pySim.ts_31_103 import EF_IST_map

 from pySim.commands import SimCardCommands
 from pySim.cards import card_detect, Card
@@ -255,5 +256,17 @@
else:
print("USIM Service Table: Can't read, response code = 
%s" % (sw,))

+   # Check whether we have th AID of ISIM, if so select it by its AID
+   # EF.IST - File Id in ADF ISIM : 6f07
+   if '9000' == card.select_adf_by_aid(adf="isim"):
+   # EF.IST
+   (res, sw) = card.read_binary('6f07')
+   if sw == '9000':
+   print("ISIM Service Table: %s" % res)
+   # Print those which are available
+   print("%s" % dec_st(res, table="isim"))
+   else:
+   print("ISIM Service Table: Can't read, response code = 
%s" % (sw,))
+
# Done for this card and maybe for everything ?
print("Done !\n")
diff --git a/pysim-testdata/sysmoISIM-SJA2.ok b/pysim-testdata/sysmoISIM-SJA2.ok
index 80045cf..afc4491 100644
--- a/pysim-testdata/sysmoISIM-SJA2.ok
+++ b/pysim-testdata/sysmoISIM-SJA2.ok
@@ -150,5 +150,11 @@
Service 94 - Extended Terminal Applications
Service 95 - Support of UICC access to IMS

+ISIM Service Table: 190200
+   Service 1 - P-CSCF address
+   Service 4 - GBA-based Local Key Establishment Mechanism
+   Service 5 - Support of P-CSCF discovery for IMS Local Break Out
+   Service 10 - Support of UICC access to IMS
+
 Done !


--
To view, visit https://gerrit.osmocom.org/c/pysim/+/17882
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I3f0a7227360b72a707dc1bcc4cc9c8a4ec7ad2b2
Gerrit-Change-Number: 17882
Gerrit-PatchSet: 5
Gerrit-Owner: herlesupreeth 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-CC: fixeria 
Gerrit-MessageType: merged

Change in pysim[master]: Enable parsing of USIM Service table (UST)

2020-04-29 Thread laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/17879 
)

Change subject: Enable parsing of USIM Service table (UST)
..

Enable parsing of USIM Service table (UST)

As per TS.31.102, This EF indicates which USIM services are available.
If a service is not indicated as available in the USIM, the ME shall not select 
this service.

Parsing of UST is achieved by first selecting the USIM application using its 
AID.
This is followed by selecting EF.UST with File ID - 6f38 in ADF.USIM

Change-Id: I54dbbd40bd3d22cee81f7c32e58cd946f8564257
---
M pySim-read.py
M pysim-testdata/Fairwaves-SIM.ok
M pysim-testdata/Wavemobile-SIM.ok
M pysim-testdata/sysmoISIM-SJA2.ok
M pysim-testdata/sysmoUSIM-SJS1.ok
5 files changed, 166 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/pySim-read.py b/pySim-read.py
index 7557201..4551e82 100755
--- a/pySim-read.py
+++ b/pySim-read.py
@@ -29,6 +29,7 @@
 import re
 import sys
 from pySim.ts_51_011 import EF, DF, EF_SST_map
+from pySim.ts_31_102 import EF_UST_map

 from pySim.commands import SimCardCommands
 from pySim.cards import card_detect, Card
@@ -242,5 +243,17 @@
else:
print("SIM Service Table: Can't read, response code = %s" % 
(sw,))

+   # Check whether we have th AID of USIM, if so select it by its AID
+   # EF.UST - File Id in ADF USIM : 6f38
+   if '9000' == card.select_adf_by_aid():
+   # EF.UST
+   (res, sw) = card.read_binary('6f38')
+   if sw == '9000':
+   print("USIM Service Table: %s" % res)
+   # Print those which are available
+   print("%s" % dec_st(res, table="usim"))
+   else:
+   print("USIM Service Table: Can't read, response code = 
%s" % (sw,))
+
# Done for this card and maybe for everything ?
print("Done !\n")
diff --git a/pysim-testdata/Fairwaves-SIM.ok b/pysim-testdata/Fairwaves-SIM.ok
index 9df44fd..0dbd89f 100644
--- a/pysim-testdata/Fairwaves-SIM.ok
+++ b/pysim-testdata/Fairwaves-SIM.ok
@@ -86,5 +86,33 @@
Service 58 - Extension 8
Service 59 - MMS User Connectivity Parameters

+USIM Service Table: 01ea1ffc2136048001
+   Service 1 - Local Phone Book
+   Service 10 - Short Message Storage (SMS)
+   Service 12 - Short Message Service Parameters (SMSP)
+   Service 14 - Capability Configuration Parameters 2 (CCP2)
+   Service 15 - Cell Broadcast Message Identifier
+   Service 16 - Cell Broadcast Message Identifier Ranges
+   Service 17 - Group Identifier Level 1
+   Service 18 - Group Identifier Level 2
+   Service 19 - Service Provider Name
+   Service 20 - User controlled PLMN selector with Access Technology
+   Service 21 - MSISDN
+   Service 27 - GSM Access
+   Service 28 - Data download via SMS-PP
+   Service 29 - Data download via SMS-CB
+   Service 30 - Call Control by USIM
+   Service 31 - MO-SMS Control by USIM
+   Service 32 - RUN AT COMMAND command
+   Service 33 - shall be set to 1
+   Service 38 - GSM security context
+   Service 42 - Operator controlled PLMN selector with Access Technology
+   Service 43 - HPLMN selector with Access Technology
+   Service 45 - PLMN Network Name
+   Service 46 - Operator PLMN List
+   Service 51 - Service Provider Display Information
+   Service 64 - VGCS security
+   Service 65 - VBS security
+
 Done !

diff --git a/pysim-testdata/Wavemobile-SIM.ok b/pysim-testdata/Wavemobile-SIM.ok
index 01ba6b7..2de0892 100644
--- a/pysim-testdata/Wavemobile-SIM.ok
+++ b/pysim-testdata/Wavemobile-SIM.ok
@@ -91,5 +91,44 @@
Service 58 - Extension 8
Service 59 - MMS User Connectivity Parameters

+USIM Service Table: 9eff1b3c37fe59
+   Service 2 - Fixed Dialling Numbers (FDN)
+   Service 3 - Extension 2
+   Service 4 - Service Dialling Numbers (SDN)
+   Service 5 - Extension3
+   Service 8 - Outgoing Call Information (OCI and OCT)
+   Service 9 - Incoming Call Information (ICI and ICT)
+   Service 10 - Short Message Storage (SMS)
+   Service 11 - Short Message Status Reports (SMSR)
+   Service 12 - Short Message Service Parameters (SMSP)
+   Service 13 - Advice of Charge (AoC)
+   Service 14 - Capability Configuration Parameters 2 (CCP2)
+   Service 15 - Cell Broadcast Message Identifier
+   Service 16 - Cell Broadcast Message Identifier Ranges
+   Service 17 - Group Identifier Level 1
+   Service 18 - Group Identifier Level 2
+   Service 20 - User controlled PLMN selector with Access Technology
+   Service 21 - MSISDN
+   Service 27 - GSM Access
+   Service 28 - Data download via SMS-PP
+   Service 29 - Data download via SMS-CB
+   Service 30 - Call Control by

Change in pysim[master]: Define mapping between ISIM Service Number and its description

2020-04-29 Thread laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/17881 
)

Change subject: Define mapping between ISIM Service Number and its description
..

Define mapping between ISIM Service Number and its description

This commit introduces a lookup table which maps ISIM Service Number to its 
description.
The mapping is defined in 3GPP TS 31.103 version 14.2.0 Release 14, 4.2.7 
EF.IST (ISIM Service Table)

Change-Id: Iad51d0804259df47729308b461062f794b135e66
---
A pySim/ts_31_103.py
1 file changed, 46 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/pySim/ts_31_103.py b/pySim/ts_31_103.py
new file mode 100644
index 000..7fb984d
--- /dev/null
+++ b/pySim/ts_31_103.py
@@ -0,0 +1,46 @@
+#!/usr/bin/env python
+# -*- coding: utf-8 -*-
+
+"""
+Various constants from ETSI TS 131 103 V14.2.0
+"""
+
+#
+# Copyright (C) 2020 Supreeth Herle 
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see .
+#
+
+# Mapping between ISIM Service Number and its description
+EF_IST_map = {
+   1: 'P-CSCF address',
+   2: 'Generic Bootstrapping Architecture (GBA)',
+   3: 'HTTP Digest',
+   4: 'GBA-based Local Key Establishment Mechanism',
+   5: 'Support of P-CSCF discovery for IMS Local Break Out',
+   6: 'Short Message Storage (SMS)',
+   7: 'Short Message Status Reports (SMSR)',
+   8: 'Support for SM-over-IP including data download via SMS-PP as 
defined in TS 31.111 [31]',
+   9: 'Communication Control for IMS by ISIM',
+   10: 'Support of UICC access to IMS',
+   11: 'URI support by UICC',
+   12: 'Media Type support',
+   13: 'IMS call disconnection cause',
+   14: 'URI support for MO SHORT MESSAGE CONTROL',
+   15: 'MCPTT',
+   16: 'URI support for SMS-PP DOWNLOAD as defined in 3GPP TS 31.111 [31]',
+   17: 'From Preferred',
+   18: 'IMS configuration data',
+   19: 'XCAP Configuration Data'
+}

--
To view, visit https://gerrit.osmocom.org/c/pysim/+/17881
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Iad51d0804259df47729308b461062f794b135e66
Gerrit-Change-Number: 17881
Gerrit-PatchSet: 4
Gerrit-Owner: herlesupreeth 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-CC: fixeria 
Gerrit-MessageType: merged

Change in pysim[master]: utils.py: Add helper method to parse and print Service Table

2020-04-29 Thread laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/17896 
)

Change subject: utils.py: Add helper method to parse and print Service Table
..

utils.py: Add helper method to parse and print Service Table

This method helps in printing Service Tables in EF.SST, EF.UST, EF.IST.
Takes hex string of Service table, parses it and prints available service along 
with its description.

Change-Id: Ie1e82e07ead2e28314a5794661e6b2ced0acd72a
---
M pySim/utils.py
1 file changed, 31 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/pySim/utils.py b/pySim/utils.py
index 51f2954..be670e9 100644
--- a/pySim/utils.py
+++ b/pySim/utils.py
@@ -347,3 +347,34 @@
avail_srvc.append((8*i) + j)
byte = byte >> 1
return avail_srvc
+
+def dec_st(st, table="sim"):
+   """
+   Parses the EF S/U/IST and prints the list of available services in EF 
S/U/IST
+   """
+
+   if table == "usim":
+   from pySim.ts_31_102 import EF_UST_map
+   lookup_map = EF_UST_map
+   else:
+   from pySim.ts_51_011 import EF_SST_map
+   lookup_map = EF_SST_map
+
+   st_bytes = [st[i:i+2] for i in range(0, len(st), 2) ]
+
+   avail_st = ""
+   # Get each byte and check for available services
+   for i in range(0, len(st_bytes)):
+   # Byte i contains info about Services num (8i+1) to num (8i+8)
+   byte = int(st_bytes[i], 16)
+   # Services in each byte are in order MSB to LSB
+   # MSB - Service (8i+8)
+   # LSB - Service (8i+1)
+   for j in range(1, 9):
+   if byte&0x01 == 0x01 and ((8*i) + j in lookup_map):
+   # Byte X contains info about Services num 
(8X-7) to num (8X)
+   # bit = 1: service available
+   # bit = 0: service not available
+   avail_st += '\tService %d - %s\n' % ((8*i) + j, 
lookup_map[(8*i) + j])
+   byte = byte >> 1
+   return avail_st

--
To view, visit https://gerrit.osmocom.org/c/pysim/+/17896
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ie1e82e07ead2e28314a5794661e6b2ced0acd72a
Gerrit-Change-Number: 17896
Gerrit-PatchSet: 2
Gerrit-Owner: herlesupreeth 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-MessageType: merged

Change in pysim[master]: Enable parsing of USIM Service table (UST)

2020-04-29 Thread laforge

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/pysim/+/17879 )

Change subject: Enable parsing of USIM Service table (UST)
..


Patch Set 8: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/pysim/+/17879
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I54dbbd40bd3d22cee81f7c32e58cd946f8564257
Gerrit-Change-Number: 17879
Gerrit-PatchSet: 8
Gerrit-Owner: herlesupreeth 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: herlesupreeth 
Gerrit-Reviewer: laforge 
Gerrit-CC: fixeria 
Gerrit-Comment-Date: Wed, 29 Apr 2020 09:09:01 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in pysim[master]: Define mapping between ISIM Service Number and its description

2020-04-29 Thread laforge

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/pysim/+/17881 )

Change subject: Define mapping between ISIM Service Number and its description
..


Patch Set 4: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/pysim/+/17881
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Iad51d0804259df47729308b461062f794b135e66
Gerrit-Change-Number: 17881
Gerrit-PatchSet: 4
Gerrit-Owner: herlesupreeth 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-CC: fixeria 
Gerrit-Comment-Date: Wed, 29 Apr 2020 09:09:06 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in pysim[master]: Use helper method to print available service in EF.SST

2020-04-29 Thread laforge

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/pysim/+/17897 )

Change subject: Use helper method to print available service in EF.SST
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/pysim/+/17897
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I375475e9f7210dae4e8da7258d6824dc2d54cf4c
Gerrit-Change-Number: 17897
Gerrit-PatchSet: 2
Gerrit-Owner: herlesupreeth 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Wed, 29 Apr 2020 09:07:54 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmocore[master]: gsm_04_06.h: Remove repeated egprs header struct definitions

2020-04-29 Thread laforge

laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/17964 )

Change subject: gsm_04_06.h: Remove repeated egprs header struct definitions
..

gsm_04_06.h: Remove repeated egprs header struct definitions

Each struct already contains different definition based on endianess, so
there's no reason to re-define all of them again based on endianess.
Probably at some point somebody run the script
./contrib/struct_endianess.py on those structures but forgot to remove
the old way of supporting differnet endianess.

Change-Id: Ibd002e52979950e09013767fa643b2a3c52dfea9
---
M include/osmocom/gprs/protocol/gsm_04_60.h
1 file changed, 0 insertions(+), 153 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/include/osmocom/gprs/protocol/gsm_04_60.h 
b/include/osmocom/gprs/protocol/gsm_04_60.h
index f592b14..05728f4 100644
--- a/include/osmocom/gprs/protocol/gsm_04_60.h
+++ b/include/osmocom/gprs/protocol/gsm_04_60.h
@@ -9,7 +9,6 @@
 #include 
 #include 

-#if OSMO_IS_LITTLE_ENDIAN == 1
 /* TS 04.60  10.3a.4.1.1 */
 struct gprs_rlc_ul_header_egprs_1 {
 #if OSMO_IS_LITTLE_ENDIAN
@@ -160,158 +159,6 @@
uint8_t dummy:1, spb:2, cps:4, bsn1_lo:1;
 #endif
 } __attribute__ ((packed));
-#else
-/* TS 04.60  10.3a.4.1.1 */
-struct gprs_rlc_ul_header_egprs_1 {
-#if OSMO_IS_LITTLE_ENDIAN
-   uint8_t tfi_hi:2,
-cv:4,
-si:1,
-r:1;
-   uint8_t bsn1_hi:5,
-   tfi_lo:3;
-   uint8_t bsn2_hi:2,
-   bsn1_lo:6;
-   uint8_t bsn2_lo:8;
-   uint8_t spare_hi:1,
-   pi:1,
-   rsb:1,
-   cps:5;
-   uint8_t dummy:2,
-   spare_lo:6;
-#elif OSMO_IS_BIG_ENDIAN
-/* auto-generated from the little endian part above 
(libosmocore/contrib/struct_endianess.py) */
-   uint8_t r:1, si:1, cv:4, tfi_hi:2;
-   uint8_t tfi_lo:3, bsn1_hi:5;
-   uint8_t bsn1_lo:6, bsn2_hi:2;
-   uint8_t bsn2_lo:8;
-   uint8_t cps:5, rsb:1, pi:1, spare_hi:1;
-   uint8_t spare_lo:6, dummy:2;
-#endif
-} __attribute__ ((packed));
-
-/* TS 04.60  10.3a.4.2.1 */
-struct gprs_rlc_ul_header_egprs_2 {
-#if OSMO_IS_LITTLE_ENDIAN
-   uint8_t tfi_hi:2,
-cv:4,
-si:1,
-r:1;
-   uint8_t bsn1_hi:5,
-tfi_lo:3;
-   uint8_t cps_hi:2,
-bsn1_lo:6;
-   uint8_t spare_hi:5,
-pi:1,
-rsb:1,
-cps_lo:1;
-   uint8_t dummy:3,
-spare_lo:5;
-#elif OSMO_IS_BIG_ENDIAN
-/* auto-generated from the little endian part above 
(libosmocore/contrib/struct_endianess.py) */
-   uint8_t r:1, si:1, cv:4, tfi_hi:2;
-   uint8_t tfi_lo:3, bsn1_hi:5;
-   uint8_t bsn1_lo:6, cps_hi:2;
-   uint8_t cps_lo:1, rsb:1, pi:1, spare_hi:5;
-   uint8_t spare_lo:5, dummy:3;
-#endif
-} __attribute__ ((packed));
-
-/* TS 04.60  10.3a.4.3.1 */
-struct gprs_rlc_ul_header_egprs_3 {
-#if OSMO_IS_LITTLE_ENDIAN
-   uint8_t tfi_hi:2,
-cv:4,
-si:1,
-r:1;
-   uint8_t bsn1_hi:5,
-tfi_lo:3;
-   uint8_t cps_hi:2,
-bsn1_lo:6;
-   uint8_t dummy:1,
-spare:1,
-pi:1,
-rsb:1,
-spb:2,
-cps_lo:2;
-#elif OSMO_IS_BIG_ENDIAN
-/* auto-generated from the little endian part above 
(libosmocore/contrib/struct_endianess.py) */
-   uint8_t r:1, si:1, cv:4, tfi_hi:2;
-   uint8_t tfi_lo:3, bsn1_hi:5;
-   uint8_t bsn1_lo:6, cps_hi:2;
-   uint8_t cps_lo:2, spb:2, rsb:1, pi:1, spare:1, dummy:1;
-#endif
-} __attribute__ ((packed));
-
-struct gprs_rlc_dl_header_egprs_1 {
-#if OSMO_IS_LITTLE_ENDIAN
-   uint8_t tfi_hi:1,
-rrbp:2,
-es_p:2,
-usf:3;
-   uint8_t bsn1_hi:2,
-pr:2,
-tfi_lo:4;
-   uint8_t bsn1_mid:8;
-   uint8_t bsn2_hi:7,
-bsn1_lo:1;
-   uint8_t cps:5,
-bsn2_lo:3;
-#elif OSMO_IS_BIG_ENDIAN
-/* auto-generated from the little endian part above 
(libosmocore/contrib/struct_endianess.py) */
-   uint8_t usf:3, es_p:2, rrbp:2, tfi_hi:1;
-   uint8_t tfi_lo:4, pr:2, bsn1_hi:2;
-   uint8_t bsn1_mid:8;
-   uint8_t bsn1_lo:1, bsn2_hi:7;
-   uint8_t bsn2_lo:3, cps:5;
-#endif
-} __attribute__ ((packed));
-
-struct gprs_rlc_dl_header_egprs_2 {
-#if OSMO_IS_LITTLE_ENDIAN
-   uint8_t tfi_hi:1,
-rrbp:2,
-es_p:2,
-usf:3;
-   uint8_t bsn1_hi:2,
-pr:2,
-tfi_lo:4;
-   uint8_t bsn1_mid:8;
-   uint8_t dummy:4,
-cps:3,
-bsn1_lo:1;
-#elif OSMO_IS_BIG_ENDIAN
-/* auto-generated from the little endian part above 
(libosmocore/contrib/s

Change in libosmocore[master]: gsm_04_06.h: Remove repeated egprs header struct definitions

2020-04-29 Thread laforge

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/17964 )

Change subject: gsm_04_06.h: Remove repeated egprs header struct definitions
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/17964
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibd002e52979950e09013767fa643b2a3c52dfea9
Gerrit-Change-Number: 17964
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Wed, 29 Apr 2020 09:07:19 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-ttcn3-hacks[master]: pcu: Support retrieving BSN and TFI in tests from data_egprs blocks

2020-04-29 Thread laforge

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17970 )

Change subject: pcu: Support retrieving BSN and TFI in tests from data_egprs 
blocks
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17970
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I570fb7346519b2a161515e0ec40bd1870a89d673
Gerrit-Change-Number: 17970
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Wed, 29 Apr 2020 09:06:33 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-ttcn3-hacks[master]: cosmetic: RLCMAC_Types.ttcn: Make different PTCCH types section more ...

2020-04-29 Thread laforge

laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17969 )

Change subject: cosmetic: RLCMAC_Types.ttcn: Make different PTCCH types section 
more visible
..

cosmetic: RLCMAC_Types.ttcn: Make different PTCCH types section more visible

On top there's a lot of types related to data blocks. Having more
stylish section header helps orientating one self while looking through
the data blocks.

Change-Id: I87d4694031ea6874b233626818824cdc4f3505c6
---
M library/RLCMAC_Types.ttcn
1 file changed, 4 insertions(+), 2 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/library/RLCMAC_Types.ttcn b/library/RLCMAC_Types.ttcn
index 97b89da..8688d36 100644
--- a/library/RLCMAC_Types.ttcn
+++ b/library/RLCMAC_Types.ttcn
@@ -576,8 +576,10 @@
payload := data
}

-   /* PTCCH/D (Packet Timing Advance Control Channel) message.
-* TODO: add a spec. reference to the message format definition. */
+/
+ * PTCCH/D (Packet Timing Advance Control Channel) message.
+ * TODO: add a spec. reference to the message format definition.
+ */
type record PTCCHTimingAdvanceIE {
BIT1spare ('0'B),
uint7_t ta_val

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17969
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I87d4694031ea6874b233626818824cdc4f3505c6
Gerrit-Change-Number: 17969
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-MessageType: merged

Change in osmo-ttcn3-hacks[master]: pcu: Support retrieving BSN and TFI in tests from data_egprs blocks

2020-04-29 Thread laforge

laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17970 )

Change subject: pcu: Support retrieving BSN and TFI in tests from data_egprs 
blocks
..

pcu: Support retrieving BSN and TFI in tests from data_egprs blocks

function helpers are slightly modified or added to accomodate for fields
in egprs data blocks being in different places.

Change-Id: I570fb7346519b2a161515e0ec40bd1870a89d673
---
M pcu/PCU_Tests_RAW.ttcn
1 file changed, 97 insertions(+), 24 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/pcu/PCU_Tests_RAW.ttcn b/pcu/PCU_Tests_RAW.ttcn
index b79b365..524dfb7 100644
--- a/pcu/PCU_Tests_RAW.ttcn
+++ b/pcu/PCU_Tests_RAW.ttcn
@@ -219,11 +219,28 @@
receive_block_bitmap := 
''B
 }

+private function f_rlcmac_dl_block_get_tfi(RlcmacDlBlock dl_block) return 
uint5_t {
+   if (ischosen(dl_block.data)) {
+   return dl_block.data.mac_hdr.hdr_ext.tfi;
+   } else {
+   return dl_block.data_egprs.mac_hdr.tfi;
+   }
+}
+
 /* TS 44.060 sec 12.3 Ack/Nack Description */
-private function f_acknackdesc_ack_block(inout AckNackDescription desc, 
uint7_t bsn, BIT1 final_ack := '0'B)
+private function f_acknackdesc_ack_block(inout AckNackDescription desc, 
RlcmacDlBlock dl_block, BIT1 final_ack := '0'B)
 {
+   var uint7_t bsn;
var integer i;
-   var integer inc := bsn - desc.starting_seq_nr + 1;
+   var integer inc;
+
+   if (ischosen(dl_block.data)) {
+   bsn := dl_block.data.mac_hdr.hdr_ext.bsn;
+   } else {
+   bsn := dl_block.data_egprs.mac_hdr.bsn1;
+   }
+
+   inc := bsn - desc.starting_seq_nr + 1;
/* Filling hole? */
if (bsn < desc.starting_seq_nr) {
desc.receive_block_bitmap[lengthof(desc.receive_block_bitmap) - 
(desc.starting_seq_nr - bsn)] := int2bit(1, 1);
@@ -558,18 +575,9 @@
}
 }

-private function f_rx_rlcmac_dl_block_exp_data(out RlcmacDlBlock dl_block, out 
uint32_t ack_fn, octetstring data, template (present) uint7_t exp_bsn := ?, 
template (present) CodingScheme exp_cs := ?)
-runs on RAW_PCU_Test_CT {
-   var PCUIF_Message pcu_msg;
-   var uint32_t dl_fn;
-   var template RlcmacDlBlock dl_template := tr_RLCMAC_DATA_RRBP;
-   dl_template.data.blocks := ?;
-
-   f_rx_rlcmac_dl_block(dl_block, dl_fn);
-   if (not match(dl_block, dl_template)) {
-   setverdict(fail, "Failed to match Packet data: ", dl_block, " 
vs ", dl_template);
-   mtc.stop;
-   }
+private function f_rlcmac_dl_block_verify_data_gprs(RlcmacDlBlock dl_block, 
uint32_t dl_fn, out uint32_t ack_fn, octetstring data, template (present) 
uint7_t exp_bsn := ?, template (present) CodingScheme exp_cs := ?)
+{
+   log("verifying dl data block (gprs): ", dl_block);

ack_fn := dl_fn + f_rrbp_fn_delay(dl_block.data.mac_hdr.mac_hdr.rrbp);

@@ -599,6 +607,71 @@
setverdict(fail, "Second data payload is not a dummy frame: ", 
dl_block.data.blocks[1].payload);
mtc.stop;
}
+
+   /* TODO: check exp_cs */
+}
+
+private function f_rlcmac_dl_block_verify_data_egprs(RlcmacDlBlock dl_block, 
uint32_t dl_fn, out uint32_t ack_fn, octetstring data, template (present) 
uint14_t exp_bsn := ?, template (present) CodingScheme exp_cs := ?)
+{
+   log("verifying dl data block (egprs): ", dl_block);
+
+   ack_fn := dl_fn + f_rrbp_fn_delay(dl_block.data_egprs.mac_hdr.rrbp);
+
+   if (not match(dl_block.data_egprs.mac_hdr.bsn1, exp_bsn)) {
+   setverdict(fail, "DL block BSN doesn't match: ",
+  dl_block.data_egprs.blocks[0].hdr.length_ind, " vs 
exp ", exp_bsn);
+   }
+
+   if (lengthof(dl_block.data_egprs.blocks) < 1) {
+   setverdict(fail, "DL block has no LLC payload: ", dl_block);
+   mtc.stop;
+   }
+
+   if (ispresent(dl_block.data_egprs.blocks[0].hdr) and 
dl_block.data_egprs.blocks[0].hdr.length_ind != lengthof(data)) {
+   setverdict(fail, "DL block has LLC header with wrong expected 
size: ",
+  dl_block.data_egprs.blocks[0].hdr.length_ind, " vs 
", lengthof(data));
+   mtc.stop;
+   }
+
+   if (dl_block.data_egprs.blocks[0].payload != data) {
+   setverdict(fail, "Failed to match content of LLC payload in DL 
Block: ", dl_block, " vs ", data);
+   mtc.stop;
+   }
+
+   /* Check next data blocks contain dummy frames */
+   if (lengthof(dl_block.data_egprs.blocks) > 1 and 
substr(dl_block.data_egprs.blocks[1].payload, 0, 3) != '43C001'O) {
+   setverdict(fail, "Second data payload is not a dummy frame: ", 
dl_block.data.blocks[1].payload);
+   mtc.stop;
+   }
+
+   /* TODO: Check exp

Change in osmo-ttcn3-hacks[master]: pcu: Support retrieving BSN and TFI in tests from data_egprs blocks

2020-04-29 Thread laforge

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17970 )

Change subject: pcu: Support retrieving BSN and TFI in tests from data_egprs 
blocks
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17970
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I570fb7346519b2a161515e0ec40bd1870a89d673
Gerrit-Change-Number: 17970
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Wed, 29 Apr 2020 09:06:29 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-ttcn3-hacks[master]: library/RLCMAC: Add partial support for EGPRS data block encoding/dec...

2020-04-29 Thread laforge

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17965 )

Change subject: library/RLCMAC: Add partial support for EGPRS data block 
encoding/decoding
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17965
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I2bc4f877a5e17c57ffa8cf05565dc8593b45aae8
Gerrit-Change-Number: 17965
Gerrit-PatchSet: 3
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-CC: fixeria 
Gerrit-Comment-Date: Wed, 29 Apr 2020 09:05:38 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-ttcn3-hacks[master]: library/GSM_RR_Types.ttcn: use 'CSN.1 L/H' attribute where needed

2020-04-29 Thread laforge

laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17957 )

Change subject: library/GSM_RR_Types.ttcn: use 'CSN.1 L/H' attribute where 
needed
..

library/GSM_RR_Types.ttcn: use 'CSN.1 L/H' attribute where needed

Thanks to Harald, TITAN's RAW codec now supports the L/H syntax.

Change-Id: I279901aeffd09de071d274944cd0f1a93d711f85
---
M library/GSM_RR_Types.ttcn
1 file changed, 7 insertions(+), 6 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/library/GSM_RR_Types.ttcn b/library/GSM_RR_Types.ttcn
index 4dc0894..6e359ab 100644
--- a/library/GSM_RR_Types.ttcn
+++ b/library/GSM_RR_Types.ttcn
@@ -405,11 +405,11 @@
 */
};
type record SecondPartAssign {
-   BIT1r99, /* H / L */
+   BIT1r99, /* L / H */
BIT1presence optional,
BIT5ext_ra optional
} with {
-   /* TODO: use 'CSN.1 L/H' attribute here */
+   variant (r99) "CSN.1 L/H"
variant (presence) "PRESENCE(r99 = '1'B)" /* H */
variant (ext_ra) "PRESENCE(presence = '1'B)"
};
@@ -510,7 +510,9 @@
};
type record IaRestOctLL {
BIT1compressed_irat_ho_info_ind
-   } with { variant "" };
+   } with {
+   variant (compressed_irat_ho_info_ind) "CSN.1 L/H"
+   };


type record of AccessTechnologiesRequest
@@ -650,6 +652,7 @@
IaRestOctHL hl optional,
IaRestOctHH hh optional
} with {
+   variant (presence) "CSN.1 L/H"
variant (ll) "PRESENCE(presence = '00'B)"
variant (lh) "PRESENCE(presence = '01'B)"
variant (hl) "PRESENCE(presence = '10'B)"
@@ -962,9 +965,7 @@
rest_octets := {
presence := '00'B, /* LL */
ll := {
-   /* Compressed INTER RAT HO 
INFO: shall not be used (L)
-* TODO: use variant "CSN.1 
L/H" to avoid confusion. */
-   compressed_irat_ho_info_ind := 
'1'B
+   compressed_irat_ho_info_ind := 
'0'B /* L */
},
lh := omit, hl := omit, hh := omit
}

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17957
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I279901aeffd09de071d274944cd0f1a93d711f85
Gerrit-Change-Number: 17957
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in osmo-ttcn3-hacks[master]: library/GSM_RR_Types.ttcn: use 'CSN.1 L/H' attribute where needed

2020-04-29 Thread laforge

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17957 )

Change subject: library/GSM_RR_Types.ttcn: use 'CSN.1 L/H' attribute where 
needed
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17957
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I279901aeffd09de071d274944cd0f1a93d711f85
Gerrit-Change-Number: 17957
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Wed, 29 Apr 2020 09:04:31 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: VTY: make configurable: T23002, T23005, T23006

2020-04-29 Thread laforge

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/17973 )

Change subject: VTY: make configurable: T23002, T23005, T23006
..


Patch Set 1:

(1 comment)

This change is ready for review.

https://gerrit.osmocom.org/c/osmo-bsc/+/17973/1/src/osmo-bsc/net_init.c
File src/osmo-bsc/net_init.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/17973/1/src/osmo-bsc/net_init.c@48
PS1, Line 48: { .T=23002, .default_val=5, .desc="LCHAN_ST_WAIT_ACTIV_ACK" },
:   { .T=23005, .default_val=5, 
.desc="LCHAN_RTP_ST_WAIT_IPACC_CRCX_ACK" },
:   { .T=23006, .default_val=5, 
.desc="LCHAN_RTP_ST_WAIT_IPACC_MDCX_ACK" },
the other timers have  descriptions are more human-readable strings. I suggest 
something like "Time to wait for RSL Channel Activate ACK after sending RSL 
Channel Activate" o r"Tme to wait for RSL IPA CRCX ACK after sending RSL IPA 
CRCX", ...



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/17973
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I637fcdde93c11158de46157d494c060bb36bdcfb
Gerrit-Change-Number: 17973
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge 
Gerrit-Comment-Date: Wed, 29 Apr 2020 09:03:34 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in osmo-ttcn3-hacks[master]: library/GSM_RR_Types.ttcn: fix BYTEORDER of MCC/MNC in RAI

2020-04-29 Thread laforge

laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17974 )

Change subject: library/GSM_RR_Types.ttcn: fix BYTEORDER of MCC/MNC in RAI
..

library/GSM_RR_Types.ttcn: fix BYTEORDER of MCC/MNC in RAI

Change [1] introduced a regression: PCU_Tests_RAW.TC_pcuif_suspend
fails since build #443. I have no idea why the BYTEORDER should be
set to 'first' (and not 'last'), but this is the only way I could
make TITAN's RAW encoder generate a valid MCC/MNC pair again.

[1] I481a40daef3eed4a3daa687ad87c4128a13181b4

Change-Id: I70a5b2eed3788be10d62fa421e3ba7444d66c655
---
M library/GSM_RR_Types.ttcn
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/library/GSM_RR_Types.ttcn b/library/GSM_RR_Types.ttcn
index d8bf595..4dc0894 100644
--- a/library/GSM_RR_Types.ttcn
+++ b/library/GSM_RR_Types.ttcn
@@ -194,7 +194,10 @@
type record LocationAreaIdentification {
BcdMccMnc   mcc_mnc,
uint16_tlac
-   } with { variant "" };
+   } with {
+   /* Otherwise '262F45'H is encoded as '24F262'H */
+   variant (mcc_mnc) "BYTEORDER(first)"
+   };

/* TS 24.008 10.5.1.4 */
type enumerated MobileIdentityType {

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17974
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I70a5b2eed3788be10d62fa421e3ba7444d66c655
Gerrit-Change-Number: 17974
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-MessageType: merged

Change in osmo-ttcn3-hacks[master]: library/GSM_RR_Types.ttcn: fix BYTEORDER of MCC/MNC in RAI

2020-04-29 Thread laforge

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17974 )

Change subject: library/GSM_RR_Types.ttcn: fix BYTEORDER of MCC/MNC in RAI
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17974
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I70a5b2eed3788be10d62fa421e3ba7444d66c655
Gerrit-Change-Number: 17974
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Wed, 29 Apr 2020 09:01:12 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-ttcn3-hacks[master]: library/GSM_RR_Types.ttcn: fix BYTEORDER of MCC/MNC in RAI

2020-04-29 Thread fixeria

fixeria has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17974 )


Change subject: library/GSM_RR_Types.ttcn: fix BYTEORDER of MCC/MNC in RAI
..

library/GSM_RR_Types.ttcn: fix BYTEORDER of MCC/MNC in RAI

Change [1] introduced a regression: PCU_Tests_RAW.TC_pcuif_suspend
fails since build #443. I have no idea why the BYTEORDER should be
set to 'first' (and not 'last'), but this is the only way I could
make TITAN's RAW encoder generate a valid MCC/MNC pair again.

[1] I481a40daef3eed4a3daa687ad87c4128a13181b4

Change-Id: I70a5b2eed3788be10d62fa421e3ba7444d66c655
---
M library/GSM_RR_Types.ttcn
1 file changed, 4 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/74/17974/1

diff --git a/library/GSM_RR_Types.ttcn b/library/GSM_RR_Types.ttcn
index d8bf595..4dc0894 100644
--- a/library/GSM_RR_Types.ttcn
+++ b/library/GSM_RR_Types.ttcn
@@ -194,7 +194,10 @@
type record LocationAreaIdentification {
BcdMccMnc   mcc_mnc,
uint16_tlac
-   } with { variant "" };
+   } with {
+   /* Otherwise '262F45'H is encoded as '24F262'H */
+   variant (mcc_mnc) "BYTEORDER(first)"
+   };

/* TS 24.008 10.5.1.4 */
type enumerated MobileIdentityType {

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17974
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I70a5b2eed3788be10d62fa421e3ba7444d66c655
Gerrit-Change-Number: 17974
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-MessageType: newchange

Change in osmo-bsc[master]: VTY: make configurable: T23002, T23005, T23006

2020-04-29 Thread osmith

osmith has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/17973 )


Change subject: VTY: make configurable: T23002, T23005, T23006
..

VTY: make configurable: T23002, T23005, T23006

Default value is the current default of 5s for all timers that are not
specified.

Related: SYS#4897
Change-Id: I637fcdde93c11158de46157d494c060bb36bdcfb
---
M src/osmo-bsc/net_init.c
1 file changed, 3 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/73/17973/1

diff --git a/src/osmo-bsc/net_init.c b/src/osmo-bsc/net_init.c
index 34403fa..5cdf467 100644
--- a/src/osmo-bsc/net_init.c
+++ b/src/osmo-bsc/net_init.c
@@ -45,6 +45,9 @@
{ .T=3141, .default_val=10, .desc="(unused)" },
{ .T=3212, .default_val=5, .unit=OSMO_TDEF_CUSTOM,
.desc="Periodic Location Update timer, sent to MS (1 = 6 
minutes)" },
+   { .T=23002, .default_val=5, .desc="LCHAN_ST_WAIT_ACTIV_ACK" },
+   { .T=23005, .default_val=5, .desc="LCHAN_RTP_ST_WAIT_IPACC_CRCX_ACK" },
+   { .T=23006, .default_val=5, .desc="LCHAN_RTP_ST_WAIT_IPACC_MDCX_ACK" },
{ .T=993210, .default_val=20, .desc="After L3 Complete, wait for MSC to 
confirm" },
{ .T=999, .default_val=60, .desc="After Clear Request, wait for MSC to 
Clear Command (sanity)" },
{ .T=992427, .default_val=4, .desc="MGCP timeout (2427 is the default 
MGCP port number)" },

--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/17973
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I637fcdde93c11158de46157d494c060bb36bdcfb
Gerrit-Change-Number: 17973
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-MessageType: newchange

Change in libosmo-abis[master]: src/input/ipaccess.c: set TCP_NODELAY

2020-04-29 Thread osmith

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-abis/+/17972 )

Change subject: src/input/ipaccess.c: set TCP_NODELAY
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/libosmo-abis/+/17972/1/src/input/ipaccess.c
File src/input/ipaccess.c:

https://gerrit.osmocom.org/c/libosmo-abis/+/17972/1/src/input/ipaccess.c@314
PS1, Line 314: FIXME: just call update_fd_settings() here instead?
Can somebody more familiar with libosmo-abis advise me, if it would be better 
to call update_fd_settings here, or leave as-is and remove the FIXME?



--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/17972
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: Ia3d4c41bf0659e682f0b7ae5f3d58ed0f28edb58
Gerrit-Change-Number: 17972
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Wed, 29 Apr 2020 07:20:10 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in libosmo-abis[master]: src/input/ipaccess.c: set TCP_NODELAY

2020-04-29 Thread osmith

osmith has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/libosmo-abis/+/17972 )


Change subject: src/input/ipaccess.c: set TCP_NODELAY
..

src/input/ipaccess.c: set TCP_NODELAY

Set TCP_NODELAY for all RSL/OML sockets.

Related: SYS#4906
Change-Id: Ia3d4c41bf0659e682f0b7ae5f3d58ed0f28edb58
---
M src/input/ipaccess.c
1 file changed, 13 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/72/17972/1

diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c
index e1936af..4d21416 100644
--- a/src/input/ipaccess.c
+++ b/src/input/ipaccess.c
@@ -271,6 +271,7 @@
struct e1inp_ts *ts;
struct osmo_fd *newbfd;
struct e1inp_line *new_line;
+   int on = 1;

sign_link =
line->ops->sign_link_up(&unit_data, line,
@@ -309,6 +310,13 @@
 "could not register FD\n");
goto err;
}
+
+   /* set TCP_NODELAY (FIXME: just call 
update_fd_settings() here instead?) */
+   ret = setsockopt(newbfd->fd, IPPROTO_TCP, TCP_NODELAY, 
&on, sizeof(on));
+   if (ret < 0)
+   LOGP(DLINP, LOGL_ERROR, "Failed to set 
TCP_NODELAY: %s\n", strerror(errno));
+
+
/* now we can release the dummy RSL line. */
e1inp_line_put(line);

@@ -587,6 +595,11 @@
 #endif
 #endif
}
+
+   val = 1;
+   ret = setsockopt(fd, IPPROTO_TCP, TCP_NODELAY, &val, sizeof(val));
+   if (ret < 0)
+   LOGP(DLINP, LOGL_ERROR, "Failed to set TCP_NODELAY: %s\n", 
strerror(errno));
 }

 /* callback of the OML listening filedescriptor */

--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/17972
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: Ia3d4c41bf0659e682f0b7ae5f3d58ed0f28edb58
Gerrit-Change-Number: 17972
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-MessageType: newchange

73 matches

Mail list logo