Change in osmo-bts[master]: osmo-bts-trx/trx_if: fix memleak in trx_ctrl_cmd_cb()
ipse has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18704 ) Change subject: osmo-bts-trx/trx_if: fix memleak in trx_ctrl_cmd_cb() .. Patch Set 1: Code-Review+1 The patch works in our case and indeed fixes the memory leak. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18704 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ie2cdf547befbc0fafdb82b10b45ad85a9b188b88 Gerrit-Change-Number: 18704 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: ipse Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sun, 07 Jun 2020 02:56:05 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Build failure of network:osmocom:nightly/libusrp in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libusrp/Debian_Unstable/x86_64 Package network:osmocom:nightly/libusrp failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libusrp Last lines of build log: [ 271s] touch libfx2.lib [ 271s] for obj in delay.rel fx2utils.rel i2c.rel isr.rel timer.rel usb_common.rel; do basename $obj .rel >> libfx2.lib ; done [ 271s] make[4]: Leaving directory '/usr/src/packages/BUILD/firmware/lib' [ 271s] Making all in src [ 271s] make[4]: Entering directory '/usr/src/packages/BUILD/firmware/src' [ 271s] Making all in common [ 271s] make[5]: Entering directory '/usr/src/packages/BUILD/firmware/src/common' [ 271s] srcdir=. ./edit-gpif ./gpif.c usrp_gpif.c usrp_gpif_inline.h [ 271s] /usr/bin/env: 'python': No such file or directory [ 271s] make[5]: *** [Makefile:523: usrp_gpif.c] Error 127 [ 271s] make[5]: Leaving directory '/usr/src/packages/BUILD/firmware/src/common' [ 271s] make[4]: *** [Makefile:405: all-recursive] Error 1 [ 271s] make[4]: Leaving directory '/usr/src/packages/BUILD/firmware/src' [ 271s] make[3]: *** [Makefile:405: all-recursive] Error 1 [ 271s] make[3]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 271s] make[2]: *** [Makefile:635: all-recursive] Error 1 [ 271s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 271s] make[1]: *** [Makefile:554: all] Error 2 [ 271s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 271s] dh_auto_build: error: make -j1 returned exit code 2 [ 271s] make: *** [debian/rules:13: build] Error 25 [ 271s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 271s] ### VM INTERACTION START ### [ 275s] [ 259.584851] sysrq: SysRq : Power Off [ 275s] [ 259.590215] reboot: Power down [ 275s] ### VM INTERACTION END ### [ 275s] [ 275s] lamb04 failed "build libusrp_3.4.4.7.50ce.dsc" at Sun Jun 7 01:41:08 UTC 2020. [ 275s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/open5gs in Debian_10/i586
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/open5gs/Debian_10/i586 Package network:osmocom:nightly/open5gs failed to build in Debian_10/i586 Check out the package for editing: osc checkout network:osmocom:nightly open5gs Last lines of build log: rror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes -Werror=missing-declarations -Werror=implicit-function-declaration -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow -Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation -Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option -fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections -fdata-sections -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -MD -MQ 'src/udr/e340f29@@udr@sta/sbi-path.c.o' -MF 'src/udr/e340f29@@udr@sta/sbi-path.c.o.d' -o 'src/udr/e340f29@@udr@sta/sbi-path.c.o' -c ../src/udr/sbi-path.c [ 278s] [1927/2112] cc -Isrc/udr/e340f29@@udr@sta -Isrc/udr -I../src/udr -Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/dbi -I../lib/dbi -Ilib/crypt -I../lib/crypt -Ilib/sbi -I../lib/sbi -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/libmongoc-1.0 -I/usr/include/libbson-1.0 -I/usr/include/p11-kit-1 -I/usr/include/i386-linux-gnu -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes -Werror=missing-declarations -Werror=implicit-function-declaration -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow -Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation -Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option -fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections -fdata-sections -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -MD -MQ 'src/udr/e340f29@@udr@sta/nf-sm.c.o' -MF 'src/udr/e340f29@@udr@sta/nf-sm.c.o.d' -o 'src/udr/e340f29@@udr@sta/nf-sm.c.o' -c ../src/udr/nf-sm.c [ 278s] [1928/2112] cc -Isrc/udr/e340f29@@open5gs-udrd@exe -Isrc/udr -I../src/udr -Isrc -I../src -Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/dbi -I../lib/dbi -Ilib/crypt -I../lib/crypt -Ilib/sbi -I../lib/sbi -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/libmongoc-1.0 -I/usr/include/libbson-1.0 -I/usr/include/p11-kit-1 -I/usr/include/i386-linux-gnu -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes -Werror=missing-declarations -Werror=implicit-function-declaration -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow -Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation -Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option -fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections -fdata-sections -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -pthread '-DDEFAULT_CONFIG_FILENAME="/etc/open5gs/udr.yaml"' -MD -MQ 'src/udr/e340f29@@open5gs-udrd@exe/app.c.o' -MF 'src/udr/e340f29@@open5gs-udrd@exe/app.c.o.d' -o 'src/udr/e340f29@@open5gs-udrd@exe/app.c.o' -c ../src/udr/app.c [ 278s] [1929/2112] cc -Isrc/udm/3eca12a@@udm@sta -Isrc/udm -I../src/udm -Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/crypt -I../lib/crypt -Ilib/sbi -I../lib/sbi -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/p11-kit-1 -I/usr/include/i386-linux-gnu -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes -Werror=missing-declarations -Werror=implicit-function-declaration
Build failure of network:osmocom:nightly/open5gs in xUbuntu_18.04/i586
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/open5gs/xUbuntu_18.04/i586 Package network:osmocom:nightly/open5gs failed to build in xUbuntu_18.04/i586 Check out the package for editing: osc checkout network:osmocom:nightly open5gs Last lines of build log: [ 175s] [1933/2112] cc -Isrc/udr/udr@sta -Isrc/udr -I../src/udr -Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/dbi -I../lib/dbi -Ilib/crypt -I../lib/crypt -Ilib/sbi -I../lib/sbi -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/libmongoc-1.0 -I/usr/include/libbson-1.0 -I/usr/include/p11-kit-1 -I/usr/include/i386-linux-gnu -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes -Werror=missing-declarations -Werror=implicit-function-declaration -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow -Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation -Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option -fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections -fdata-sections -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -MD -MQ 'src/udr/udr@sta/init.c.o' -MF 'src/udr/udr@sta/init.c.o.d' -o 'src/udr/udr@sta/init.c.o' -c ../src/udr/init.c [ 175s] [1934/2112] cc -Isrc/udr/open5gs-udrd@exe -Isrc/udr -I../src/udr -Isrc -I../src -Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/dbi -I../lib/dbi -Ilib/crypt -I../lib/crypt -Ilib/sbi -I../lib/sbi -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/libmongoc-1.0 -I/usr/include/libbson-1.0 -I/usr/include/p11-kit-1 -I/usr/include/i386-linux-gnu -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes -Werror=missing-declarations -Werror=implicit-function-declaration -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow -Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation -Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option -fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections -fdata-sections -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -pthread '-DDEFAULT_CONFIG_FILENAME="/etc/open5gs/udr.yaml"' -MD -MQ 'src/udr/open5gs-udrd@exe/.._main.c.o' -MF 'src/udr/open5gs-udrd@exe/.._main.c.o.d' -o 'src/udr/open5gs-udrd@exe/.._main.c.o' -c ../src/main.c [ 175s] [1935/2112] cc -Isrc/udm/udm@sta -Isrc/udm -I../src/udm -Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/crypt -I../lib/crypt -Ilib/sbi -I../lib/sbi -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/p11-kit-1 -I/usr/include/i386-linux-gnu -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes -Werror=missing-declarations -Werror=implicit-function-declaration -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow -Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation -Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option -fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections -fdata-sections -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -MD -MQ 'src/udm/udm@sta/timer.c.o' -MF 'src/udm/udm@sta/timer.c.o.d' -o 'src/udm/udm@sta/timer.c.o' -c ../src/udm/timer.c [ 175s] [1936/2112] cc -Isrc/udr/udr@sta -Isrc/udr -I../src/udr -Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/dbi -I../lib/dbi -Ilib/crypt -I../lib/crypt -Ilib/sbi -I../lib/sbi -Ilib/sbi/openapi -I../lib/sbi/openapi
Build failure of network:osmocom:nightly/open5gs in xUbuntu_18.10/i586
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/open5gs/xUbuntu_18.10/i586 Package network:osmocom:nightly/open5gs failed to build in xUbuntu_18.10/i586 Check out the package for editing: osc checkout network:osmocom:nightly open5gs Last lines of build log: nction-declaration -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow -Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation -Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option -fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections -fdata-sections -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -MD -MQ 'src/udr/src@udr@@udr@sta/nudr-handler.c.o' -MF 'src/udr/src@udr@@udr@sta/nudr-handler.c.o.d' -o 'src/udr/src@udr@@udr@sta/nudr-handler.c.o' -c ../src/udr/nudr-handler.c [ 156s] [1926/2112] cc -Isrc/udm/src@udm@@udm@sta -Isrc/udm -I../src/udm -Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/crypt -I../lib/crypt -Ilib/sbi -I../lib/sbi -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/p11-kit-1 -I/usr/include/i386-linux-gnu -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes -Werror=missing-declarations -Werror=implicit-function-declaration -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow -Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation -Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option -fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections -fdata-sections -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -MD -MQ 'src/udm/src@udm@@udm@sta/event.c.o' -MF 'src/udm/src@udm@@udm@sta/event.c.o.d' -o 'src/udm/src@udm@@udm@sta/event.c.o' -c ../src/udm/event.c [ 156s] [1927/2112] cc -Isrc/udr/src@udr@@open5gs-udrd@exe -Isrc/udr -I../src/udr -Isrc -I../src -Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/dbi -I../lib/dbi -Ilib/crypt -I../lib/crypt -Ilib/sbi -I../lib/sbi -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/libmongoc-1.0 -I/usr/include/libbson-1.0 -I/usr/include/p11-kit-1 -I/usr/include/i386-linux-gnu -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes -Werror=missing-declarations -Werror=implicit-function-declaration -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow -Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation -Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option -fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections -fdata-sections -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -pthread '-DDEFAULT_CONFIG_FILENAME="/etc/open5gs/udr.yaml"' -MD -MQ 'src/udr/src@udr@@open5gs-udrd@exe/.._main.c.o' -MF 'src/udr/src@udr@@open5gs-udrd@exe/.._main.c.o.d' -o 'src/udr/src@udr@@open5gs-udrd@exe/.._main.c.o' -c ../src/main.c [ 156s] [1928/2112] cc -Isrc/udm/src@udm@@udm@sta -Isrc/udm -I../src/udm -Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/crypt -I../lib/crypt -Ilib/sbi -I../lib/sbi -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/p11-kit-1 -I/usr/include/i386-linux-gnu -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes -Werror=missing-declarations -Werror=implicit-function-declaration -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3 -Wwrite-strings
Build failure of network:osmocom:latest/libusrp in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libusrp/Debian_Unstable/x86_64 Package network:osmocom:latest/libusrp failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libusrp Last lines of build log: [ 286s] touch libfx2.lib [ 286s] for obj in delay.rel fx2utils.rel i2c.rel isr.rel timer.rel usb_common.rel; do basename $obj .rel >> libfx2.lib ; done [ 286s] make[4]: Leaving directory '/usr/src/packages/BUILD/firmware/lib' [ 286s] Making all in src [ 286s] make[4]: Entering directory '/usr/src/packages/BUILD/firmware/src' [ 286s] Making all in common [ 286s] make[5]: Entering directory '/usr/src/packages/BUILD/firmware/src/common' [ 286s] srcdir=. ./edit-gpif ./gpif.c usrp_gpif.c usrp_gpif_inline.h [ 286s] /usr/bin/env: 'python': No such file or directory [ 286s] make[5]: *** [Makefile:523: usrp_gpif.c] Error 127 [ 286s] make[5]: Leaving directory '/usr/src/packages/BUILD/firmware/src/common' [ 286s] make[4]: *** [Makefile:405: all-recursive] Error 1 [ 286s] make[4]: Leaving directory '/usr/src/packages/BUILD/firmware/src' [ 286s] make[3]: *** [Makefile:405: all-recursive] Error 1 [ 286s] make[3]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 286s] make[2]: *** [Makefile:626: all-recursive] Error 1 [ 286s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 286s] make[1]: *** [Makefile:547: all] Error 2 [ 286s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 286s] dh_auto_build: error: make -j1 returned exit code 2 [ 286s] make: *** [debian/rules:13: build] Error 25 [ 286s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 286s] ### VM INTERACTION START ### [ 289s] [ 274.031720] sysrq: SysRq : Power Off [ 289s] [ 274.054918] reboot: Power down [ 289s] ### VM INTERACTION END ### [ 289s] [ 289s] lamb24 failed "build libusrp_3.4.4.dsc" at Sat Jun 6 22:09:35 UTC 2020. [ 289s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/libusrp in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libusrp/Debian_Unstable/x86_64 Package network:osmocom:nightly/libusrp failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libusrp Last lines of build log: [ 220s] touch libfx2.lib [ 220s] for obj in delay.rel fx2utils.rel i2c.rel isr.rel timer.rel usb_common.rel; do basename $obj .rel >> libfx2.lib ; done [ 220s] make[4]: Leaving directory '/usr/src/packages/BUILD/firmware/lib' [ 220s] Making all in src [ 220s] make[4]: Entering directory '/usr/src/packages/BUILD/firmware/src' [ 220s] Making all in common [ 220s] make[5]: Entering directory '/usr/src/packages/BUILD/firmware/src/common' [ 220s] srcdir=. ./edit-gpif ./gpif.c usrp_gpif.c usrp_gpif_inline.h [ 220s] /usr/bin/env: 'python': No such file or directory [ 220s] make[5]: *** [Makefile:523: usrp_gpif.c] Error 127 [ 220s] make[5]: Leaving directory '/usr/src/packages/BUILD/firmware/src/common' [ 221s] make[4]: *** [Makefile:405: all-recursive] Error 1 [ 221s] make[4]: Leaving directory '/usr/src/packages/BUILD/firmware/src' [ 221s] make[3]: *** [Makefile:405: all-recursive] Error 1 [ 221s] make[3]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 221s] make[2]: *** [Makefile:635: all-recursive] Error 1 [ 221s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 221s] make[1]: *** [Makefile:554: all] Error 2 [ 221s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 221s] dh_auto_build: error: make -j1 returned exit code 2 [ 221s] make: *** [debian/rules:13: build] Error 25 [ 221s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 221s] ### VM INTERACTION START ### [ 224s] [ 208.793213] sysrq: SysRq : Power Off [ 224s] [ 208.799128] reboot: Power down [ 224s] ### VM INTERACTION END ### [ 224s] [ 224s] lamb61 failed "build libusrp_3.4.4.7.50ce.dsc" at Sat Jun 6 22:06:59 UTC 2020. [ 224s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Change in libosmocore[master]: WIP: Optionally disable NS-{RESET, BLOCK, UNBLOCK} when using UDP/IP
laforge has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmocore/+/18706 )
Change subject: WIP: Optionally disable NS-{RESET,BLOCK,UNBLOCK} when using
UDP/IP
..
WIP: Optionally disable NS-{RESET,BLOCK,UNBLOCK} when using UDP/IP
3GPP TS 48.016 is quite clear in that no NS-{RESET,BLOCK,UNBLOCK}
procedures shalle be used over an IP based transport. They are only
for use in Frame Relay based transport.
However, as libosmogb was first developed against ip.access nanoBTS,
and their Gb implementation mandates those procedures, we
unconditionally implemented those procedures back then. Let's
give the user the option of disabling this behavior to become
more spec compliant (and interoperate with more other vendors out
there).
Change-Id: Ic4eba1b4dcbeac00f5879db295e0a9f1a50f71d8
---
M include/osmocom/gprs/gprs_ns.h
M src/gb/gprs_ns.c
M src/gb/gprs_ns_vty.c
3 files changed, 57 insertions(+), 24 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/06/18706/1
diff --git a/include/osmocom/gprs/gprs_ns.h b/include/osmocom/gprs/gprs_ns.h
index 02faa50..94d3036 100644
--- a/include/osmocom/gprs/gprs_ns.h
+++ b/include/osmocom/gprs/gprs_ns.h
@@ -97,6 +97,8 @@
uint32_t remote_ip;
uint16_t remote_port;
int dscp;
+ /*! IPA compatibility: NS-RESET/BLOCK/UNBLOCK even on IP-SNS */
+ bool use_reset_block_unblock;
} nsip;
/*! NS-over-FR-over-GRE-over-IP specific bits */
struct {
diff --git a/src/gb/gprs_ns.c b/src/gb/gprs_ns.c
index 4e584ad..f1b36f4 100644
--- a/src/gb/gprs_ns.c
+++ b/src/gb/gprs_ns.c
@@ -327,7 +327,7 @@
nsvc->nsvci = nsvci;
nsvc->nsvci_is_valid = 1;
/* before RESET procedure: BLOCKED and DEAD */
- if (nsi->bss_sns_fi)
+ if (nsi->bss_sns_fi || !nsi->nsip.use_reset_block_unblock)
ns_set_state(nsvc, 0);
else
ns_set_state(nsvc, NSE_S_BLOCKED);
@@ -793,7 +793,7 @@
nsvc->nsi->timeout[NS_TOUT_TNS_ALIVE_RETRIES]) {
/* mark as dead (and blocked unless IP-SNS) */
rate_ctr_inc(>ctrg->ctr[NS_CTR_DEAD]);
- if (!nsvc->nsi->bss_sns_fi) {
+ if (!nsvc->nsi->bss_sns_fi &&
nsvc->nsi->nsip.use_reset_block_unblock) {
ns_set_state(nsvc, NSE_S_BLOCKED);
rate_ctr_inc(>ctrg->ctr[NS_CTR_BLOCKED]);
} else
@@ -804,7 +804,7 @@
nsvc->nsi->timeout[NS_TOUT_TNS_ALIVE_RETRIES]);
ns_osmo_signal_dispatch(nsvc, S_NS_ALIVE_EXP, 0);
/* FIXME: should we send this signal in case of SNS? */
- if (!nsvc->nsi->bss_sns_fi)
+ if (!nsvc->nsi->bss_sns_fi &&
nsvc->nsi->nsip.use_reset_block_unblock)
ns_osmo_signal_dispatch(nsvc, S_NS_BLOCK,
NS_CAUSE_NSVC_BLOCKED);
return;
}
@@ -1758,8 +1758,12 @@
* fine. */
if ((*nsvc)->state == NSE_S_BLOCKED)
rc = gprs_nsvc_reset((*nsvc),
NS_CAUSE_PDU_INCOMP_PSTATE);
- else if (!((*nsvc)->state & NSE_S_RESET))
+ else if (!((*nsvc)->state & NSE_S_RESET)) {
+ /* if we're not alive, we cannot transmit the ACK; set
ALIVE */
+ if (!((*nsvc)->state & NSE_S_ALIVE))
+ ns_mark_alive(*nsvc);
rc = gprs_ns_tx_alive_ack(*nsvc);
+ }
break;
case NS_PDUT_ALIVE_ACK:
ns_mark_alive(*nsvc);
@@ -1915,6 +1919,11 @@
llist_del(>unknown_nsvc->list);
INIT_LLIST_HEAD(>unknown_nsvc->list);
+ /* By default we are in IPA compatible mode, that is we use NS-RESET,
NS-BLOCK
+* and NS-UNBLOCK procedures even for an IP/UDP based Gb interface, in
violation
+* of 3GPP TS 48.016. */
+ nsi->nsip.use_reset_block_unblock = true;
+
return nsi;
}
diff --git a/src/gb/gprs_ns_vty.c b/src/gb/gprs_ns_vty.c
index 9cffb71..bd53f2f 100644
--- a/src/gb/gprs_ns_vty.c
+++ b/src/gb/gprs_ns_vty.c
@@ -90,6 +90,32 @@
vty_out(vty, "ns%s", VTY_NEWLINE);
+ /* global configuration must be written first, as some of it may be
+* relevant when creating the NSE/NSVC later below */
+
+ if (vty_nsi->nsip.local_ip) {
+ ia.s_addr = osmo_htonl(vty_nsi->nsip.local_ip);
+ vty_out(vty, " encapsulation udp local-ip %s%s",
+ inet_ntoa(ia), VTY_NEWLINE);
+ }
+ if (vty_nsi->nsip.local_port)
+ vty_out(vty, " encapsulation udp local-port %u%s",
+ vty_nsi->nsip.local_port, VTY_NEWLINE);
+
Change in pysim[master]: Add support for ADF_USIM/EF_EHPLMN
gui...@gmail.com has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/18649 ) Change subject: Add support for ADF_USIM/EF_EHPLMN .. Patch Set 1: (1 comment) out of curiosity, the comment about the standard is interesting - so the EHPLMN list actually has priority to "void" the PLMN extracted from the IMSI in the PLMN search? I have seen MVNO SIMs, with the EHPLMN service enabled, but the list empty, what would be the HPLMN then? https://gerrit.osmocom.org/c/pysim/+/18649/1/pySim/cards.py File pySim/cards.py: https://gerrit.osmocom.org/c/pysim/+/18649/1/pySim/cards.py@82 PS1, Line 82: (res, sw) = self._scc.read_binary(EF_USIM_ADF_map['EHPLMN']) is it ok to put this USIM specific things in the generic Card class? I was thinking in adding a "genericUSIM" card type, at the end of the card specific type list, to pack all the USIM specific things, wouldn't that be a tidier approach? Also, are you OK by adding functions to read other fields, despite not being used in pySim-read? At the moment, I am using another script to read things like LOCI, PSLOCI, and others, not sure if submitting the change or not -- To view, visit https://gerrit.osmocom.org/c/pysim/+/18649 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I22d96ab4a424ec5bc1fb02f5e80165c646a748d3 Gerrit-Change-Number: 18649 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-CC: gui...@gmail.com Gerrit-Comment-Date: Sat, 06 Jun 2020 20:26:56 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-bts[master]: common/scheduler: use boolean for channel activation state
laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/18700 )
Change subject: common/scheduler: use boolean for channel activation state
..
common/scheduler: use boolean for channel activation state
Change-Id: I0cb1d915db8787050cdec1802894f66e885a9bf3
---
M include/osmo-bts/scheduler.h
M src/common/scheduler.c
M src/osmo-bts-trx/l1_if.c
M src/osmo-bts-virtual/l1_if.c
4 files changed, 12 insertions(+), 16 deletions(-)
Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/include/osmo-bts/scheduler.h b/include/osmo-bts/scheduler.h
index 7a9da8f..74102f3 100644
--- a/include/osmo-bts/scheduler.h
+++ b/include/osmo-bts/scheduler.h
@@ -72,7 +72,7 @@
/* States each channel on a multiframe */
struct l1sched_chan_state {
/* scheduler */
- uint8_t active; /* Channel is active */
+ boolactive; /* Channel is active */
ubit_t *dl_bursts; /* burst buffer for TX */
enum trx_burst_type dl_burst_type; /* GMSK or 8PSK burst type */
sbit_t *ul_bursts; /* burst buffer for RX */
@@ -175,8 +175,7 @@
enum gsm_phys_chan_config pchan);
/*! \brief set all matching logical channels active/inactive */
-int trx_sched_set_lchan(struct l1sched_trx *l1t, uint8_t chan_nr, uint8_t
link_id,
- int active);
+int trx_sched_set_lchan(struct l1sched_trx *l1t, uint8_t chan_nr, uint8_t
link_id, bool active);
/*! \brief set mode of all matching logical channels to given mode(s) */
int trx_sched_set_mode(struct l1sched_trx *l1t, uint8_t chan_nr, uint8_t
rsl_cmode,
diff --git a/src/common/scheduler.c b/src/common/scheduler.c
index 276f3fd..5b398d1 100644
--- a/src/common/scheduler.c
+++ b/src/common/scheduler.c
@@ -586,7 +586,7 @@
for (i = 0; i < ARRAY_SIZE(l1ts->chan_state); i++) {
struct l1sched_chan_state *chan_state;
chan_state = >chan_state[i];
- chan_state->active = 0;
+ chan_state->active = false;
}
}
@@ -960,8 +960,7 @@
}
/* setting all logical channels given attributes to active/inactive */
-int trx_sched_set_lchan(struct l1sched_trx *l1t, uint8_t chan_nr, uint8_t
link_id,
- int active)
+int trx_sched_set_lchan(struct l1sched_trx *l1t, uint8_t chan_nr, uint8_t
link_id, bool active)
{
uint8_t tn = L1SAP_CHAN2TS(chan_nr);
struct l1sched_ts *l1ts = l1sched_trx_get_ts(l1t, tn);
diff --git a/src/osmo-bts-trx/l1_if.c b/src/osmo-bts-trx/l1_if.c
index b28c894..b67d8fa 100644
--- a/src/osmo-bts-trx/l1_if.c
+++ b/src/osmo-bts-trx/l1_if.c
@@ -128,16 +128,14 @@
/* set lchan inactive */
lchan_set_state(lchan, LCHAN_S_NONE);
- return trx_sched_set_lchan(>l1s, gsm_lchan2chan_nr(lchan),
- LID_DEDIC, 0);
+ return trx_sched_set_lchan(>l1s, gsm_lchan2chan_nr(lchan),
LID_DEDIC, false);
}
int bts_model_lchan_deactivate_sacch(struct gsm_lchan *lchan)
{
struct phy_instance *pinst = trx_phy_instance(lchan->ts->trx);
struct trx_l1h *l1h = pinst->u.osmotrx.hdl;
- return trx_sched_set_lchan(>l1s, gsm_lchan2chan_nr(lchan),
- LID_SACCH, 0);
+ return trx_sched_set_lchan(>l1s, gsm_lchan2chan_nr(lchan),
LID_SACCH, false);
}
static void l1if_setslot_cb(struct trx_l1h *l1h, uint8_t tn, uint8_t type, int
rc)
@@ -632,9 +630,9 @@
chan_nr = RSL_CHAN_OSMO_PDCH | (chan_nr
& ~RSL_CHAN_NR_MASK);
/* activate dedicated channel */
- trx_sched_set_lchan(>l1s, chan_nr,
LID_DEDIC, 1);
+ trx_sched_set_lchan(>l1s, chan_nr,
LID_DEDIC, true);
/* activate associated channel */
- trx_sched_set_lchan(>l1s, chan_nr,
LID_SACCH, 1);
+ trx_sched_set_lchan(>l1s, chan_nr,
LID_SACCH, true);
/* set mode */
trx_sched_set_mode(>l1s, chan_nr,
lchan->rsl_cmode, lchan->tch_mode,
diff --git a/src/osmo-bts-virtual/l1_if.c b/src/osmo-bts-virtual/l1_if.c
index 289ef40..8e84579 100644
--- a/src/osmo-bts-virtual/l1_if.c
+++ b/src/osmo-bts-virtual/l1_if.c
@@ -388,9 +388,9 @@
break;
}
/* activate dedicated channel */
- trx_sched_set_lchan(sched, chan_nr, LID_DEDIC,
1);
+ trx_sched_set_lchan(sched, chan_nr, LID_DEDIC,
true);
/* activate associated channel */
-
Change in osmo-bts[master]: common/scheduler: fix unreachable code in trx_sched_set_lchan()
laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/18699 )
Change subject: common/scheduler: fix unreachable code in trx_sched_set_lchan()
..
common/scheduler: fix unreachable code in trx_sched_set_lchan()
Change-Id: Ie9d8f8ca86195be4408db717cd3194a7d2ddc918
---
M src/common/scheduler.c
1 file changed, 5 insertions(+), 4 deletions(-)
Approvals:
laforge: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/src/common/scheduler.c b/src/common/scheduler.c
index be3ae42..276f3fd 100644
--- a/src/common/scheduler.c
+++ b/src/common/scheduler.c
@@ -986,9 +986,6 @@
LOGP(DL1C, LOGL_NOTICE, "%s %s on trx=%d ts=%d\n",
(active) ? "Activating" : "Deactivating",
trx_chan_desc[i].name, l1t->trx->nr, tn);
- if (active)
- memset(chan_state, 0, sizeof(*chan_state));
- chan_state->active = active;
/* free burst memory, to cleanly start with burst 0 */
if (chan_state->dl_bursts) {
talloc_free(chan_state->dl_bursts);
@@ -998,8 +995,12 @@
talloc_free(chan_state->ul_bursts);
chan_state->ul_bursts = NULL;
}
- if (!active)
+
+ if (active)
+ memset(chan_state, 0, sizeof(*chan_state));
+ else
chan_state->ho_rach_detect = 0;
+ chan_state->active = active;
}
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18699
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ie9d8f8ca86195be4408db717cd3194a7d2ddc918
Gerrit-Change-Number: 18699
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-bts[master]: common/scheduler: fix unreachable code in trx_sched_set_lchan()
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18699 ) Change subject: common/scheduler: fix unreachable code in trx_sched_set_lchan() .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18699 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ie9d8f8ca86195be4408db717cd3194a7d2ddc918 Gerrit-Change-Number: 18699 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sat, 06 Jun 2020 19:41:09 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: osmo-bts-trx/trx_if: cosmetic: s/ocommand/command/
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18705 ) Change subject: osmo-bts-trx/trx_if: cosmetic: s/ocommand/command/ .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18705 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I06db72deb78cbab588de2103657b0722b67887a0 Gerrit-Change-Number: 18705 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sat, 06 Jun 2020 19:40:12 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: stats: Count transitions from BORKEN state due to LCHAN_EV_TS_ERROR s...
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18703 ) Change subject: stats: Count transitions from BORKEN state due to LCHAN_EV_TS_ERROR signal. .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18703 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ice3379020039dc3634aa3887939740729d720dee Gerrit-Change-Number: 18703 Gerrit-PatchSet: 1 Gerrit-Owner: ipse Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sat, 06 Jun 2020 19:39:19 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: stats: Add a BTS counter for paging requests responded elsewhere.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18426 ) Change subject: stats: Add a BTS counter for paging requests responded elsewhere. .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18426 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4b27a0559ef2762e62bc3ac3f17b89b0ed48 Gerrit-Change-Number: 18426 Gerrit-PatchSet: 3 Gerrit-Owner: ipse Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: ipse Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sat, 06 Jun 2020 19:40:02 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: timeslot_fsm: Name TS FSM instances on allocation.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18702 ) Change subject: timeslot_fsm: Name TS FSM instances on allocation. .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18702 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Idc74ea142b96323b48826f8a52e13e45d535512a Gerrit-Change-Number: 18702 Gerrit-PatchSet: 1 Gerrit-Owner: ipse Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sat, 06 Jun 2020 19:38:57 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: osmo-bts-trx/trx_if: fix memleak in trx_ctrl_cmd_cb()
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18704 ) Change subject: osmo-bts-trx/trx_if: fix memleak in trx_ctrl_cmd_cb() .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18704 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ie2cdf547befbc0fafdb82b10b45ad85a9b188b88 Gerrit-Change-Number: 18704 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: ipse Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sat, 06 Jun 2020 19:38:05 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: chan_alloc: Fix typo in a comment.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18701 ) Change subject: chan_alloc: Fix typo in a comment. .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18701 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iaed3fcd99ec8c08faa75e23af5b50a1d0e0905eb Gerrit-Change-Number: 18701 Gerrit-PatchSet: 1 Gerrit-Owner: ipse Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sat, 06 Jun 2020 19:38:22 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Build failure of network:osmocom:nightly/open5gs in Raspbian_10/armv7l
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/open5gs/Raspbian_10/armv7l Package network:osmocom:nightly/open5gs failed to build in Raspbian_10/armv7l Check out the package for editing: osc checkout network:osmocom:nightly open5gs Last lines of build log: [ 471s] [1932/2112] rm -f src/udr/libudr.a && gcc-ar csrD src/udr/libudr.a 'src/udr/e340f29@@udr@sta/context.c.o' 'src/udr/e340f29@@udr@sta/event.c.o' 'src/udr/e340f29@@udr@sta/timer.c.o' 'src/udr/e340f29@@udr@sta/nnrf-handler.c.o' 'src/udr/e340f29@@udr@sta/nf-sm.c.o' 'src/udr/e340f29@@udr@sta/nudr-handler.c.o' 'src/udr/e340f29@@udr@sta/sbi-path.c.o' 'src/udr/e340f29@@udr@sta/udr-sm.c.o' 'src/udr/e340f29@@udr@sta/init.c.o' [ 471s] [1933/2112] cc -Isrc/udm/3eca12a@@udm@sta -Isrc/udm -I../src/udm -Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/crypt -I../lib/crypt -Ilib/sbi -I../lib/sbi -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/p11-kit-1 -I/usr/include/arm-linux-gnueabihf -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes -Werror=missing-declarations -Werror=implicit-function-declaration -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow -Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation -Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option -fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections -fdata-sections -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -MD -MQ 'src/udm/3eca12a@@udm@sta/event.c.o' -MF 'src/udm/3eca12a@@udm@sta/event.c.o.d' -o 'src/udm/3eca12a@@udm@sta/event.c.o' -c ../src/udm/event.c [ 471s] [1934/2112] cc -o src/pcrf/open5gs-pcrfd 'src/pcrf/9bf4e44@@open5gs-pcrfd@exe/app-init.c.o' 'src/pcrf/9bf4e44@@open5gs-pcrfd@exe/.._main.c.o' -Wl,--no-undefined -Wl,--as-needed -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z,relro -Wl,-z,now -Wl,--start-group src/pcrf/libpcrf.a lib/app/libogsapp.so.1.2.5 lib/core/libogscore.so.1.2.5 lib/dbi/libogsdbi.so.1.2.5 lib/crypt/libogscrypt.so.1.2.5 lib/diameter/rx/libogsdiameter-rx.so.1.2.5 lib/diameter/common/libogsdiameter-common.so.1.2.5 subprojects/freeDiameter/libfdcore/libfdcore.so.1.3.2 subprojects/freeDiameter/libfdproto/libfdproto.so.1.3.2 lib/diameter/gx/libogsdiameter-gx.so.1.2.5 /usr/lib/arm-linux-gnueabihf/libyaml.so /usr/lib/gcc/arm-linux-gnueabihf/8/../../../arm-linux-gnueabihf/libmongoc-1.0.so /usr/lib/gcc/arm-linux-gnueabihf/8/../../../arm-linux-gnueabihf/libbson-1.0.so -lidn -ldl -lsctp -lgcrypt -lgnutls -lidn -ldl -lsctp -lgcrypt -lgnutls -lidn -ldl -lsctp -lgcrypt -lgnutls -lidn -ldl -lsctp -lgcrypt -lgnutls -Wl,--end-group -pthread '-Wl,-rpath,$ORIGIN/:$ORIGIN/../../lib/app:$ORIGIN/../../lib/core:$ORIGIN/../../lib/dbi:$ORIGIN/../../lib/crypt:$ORIGIN/../../lib/diameter/rx:$ORIGIN/../../lib/diameter/common:$ORIGIN/../../subprojects/freeDiameter/libfdcore:$ORIGIN/../../subprojects/freeDiameter/libfdproto:$ORIGIN/../../lib/diameter/gx' -Wl,-rpath-link,/usr/src/packages/BUILD/obj-arm-linux-gnueabihf/src/pcrf:/usr/src/packages/BUILD/obj-arm-linux-gnueabihf/lib/app:/usr/src/packages/BUILD/obj-arm-linux-gnueabihf/lib/core:/usr/src/packages/BUILD/obj-arm-linux-gnueabihf/lib/dbi:/usr/src/packages/BUILD/obj-arm-linux-gnueabihf/lib/crypt:/usr/src/packages/BUILD/obj-arm-linux-gnueabihf/lib/diameter/rx:/usr/src/packages/BUILD/obj-arm-linux-gnueabihf/lib/diameter/common:/usr/src/packages/BUILD/obj-arm-linux-gnueabihf/subprojects/freeDiameter/libfdcore:/usr/src/packages/BUILD/obj-arm-linux-gnueabihf/subprojects/freeDiameter/libfdproto:/usr/src/packages/BUILD/obj-arm-linux-gnueabihf/lib/diameter/gx [ 472s] [1935/2112] cc -Isrc/udm/3eca12a@@udm@sta -Isrc/udm -I../src/udm -Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/crypt -I../lib/crypt -Ilib/sbi -I../lib/sbi -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/p11-kit-1 -I/usr/include/arm-linux-gnueabihf -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes -Werror=missing-declarations -Werror=implicit-function-declaration -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels
Build failure of network:osmocom:nightly/open5gs in Debian_10/armv7l
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/open5gs/Debian_10/armv7l Package network:osmocom:nightly/open5gs failed to build in Debian_10/armv7l Check out the package for editing: osc checkout network:osmocom:nightly open5gs Last lines of build log: [ 1208s] [1927/2112] cc -Isrc/udr/e340f29@@udr@sta -Isrc/udr -I../src/udr -Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/dbi -I../lib/dbi -Ilib/crypt -I../lib/crypt -Ilib/sbi -I../lib/sbi -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/libmongoc-1.0 -I/usr/include/libbson-1.0 -I/usr/include/p11-kit-1 -I/usr/include/arm-linux-gnueabihf -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes -Werror=missing-declarations -Werror=implicit-function-declaration -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow -Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation -Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option -fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections -fdata-sections -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -MD -MQ 'src/udr/e340f29@@udr@sta/nudr-handler.c.o' -MF 'src/udr/e340f29@@udr@sta/nudr-handler.c.o.d' -o 'src/udr/e340f29@@udr@sta/nudr-handler.c.o' -c ../src/udr/nudr-handler.c [ 1209s] [1928/2112] cc -Isrc/udr/e340f29@@udr@sta -Isrc/udr -I../src/udr -Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/dbi -I../lib/dbi -Ilib/crypt -I../lib/crypt -Ilib/sbi -I../lib/sbi -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/libmongoc-1.0 -I/usr/include/libbson-1.0 -I/usr/include/p11-kit-1 -I/usr/include/arm-linux-gnueabihf -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes -Werror=missing-declarations -Werror=implicit-function-declaration -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow -Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation -Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option -fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections -fdata-sections -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -MD -MQ 'src/udr/e340f29@@udr@sta/sbi-path.c.o' -MF 'src/udr/e340f29@@udr@sta/sbi-path.c.o.d' -o 'src/udr/e340f29@@udr@sta/sbi-path.c.o' -c ../src/udr/sbi-path.c [ 1210s] [1929/2112] cc -Isrc/udr/e340f29@@udr@sta -Isrc/udr -I../src/udr -Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/dbi -I../lib/dbi -Ilib/crypt -I../lib/crypt -Ilib/sbi -I../lib/sbi -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/libmongoc-1.0 -I/usr/include/libbson-1.0 -I/usr/include/p11-kit-1 -I/usr/include/arm-linux-gnueabihf -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes -Werror=missing-declarations -Werror=implicit-function-declaration -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow -Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation -Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option -fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections -fdata-sections -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -MD -MQ 'src/udr/e340f29@@udr@sta/udr-sm.c.o' -MF 'src/udr/e340f29@@udr@sta/udr-sm.c.o.d' -o 'src/udr/e340f29@@udr@sta/udr-sm.c.o' -c ../src/udr/udr-sm.c [ 1210s] [1930/2112] cc -Isrc/udr/e340f29@@udr@sta -Isrc/udr -I../src/udr -Ilib/app -I../lib/app -Ilib -I../lib
Build failure of network:osmocom:nightly/libusrp in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libusrp/Debian_Unstable/x86_64 Package network:osmocom:nightly/libusrp failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libusrp Last lines of build log: [ 295s] touch libfx2.lib [ 295s] for obj in delay.rel fx2utils.rel i2c.rel isr.rel timer.rel usb_common.rel; do basename $obj .rel >> libfx2.lib ; done [ 295s] make[4]: Leaving directory '/usr/src/packages/BUILD/firmware/lib' [ 295s] Making all in src [ 295s] make[4]: Entering directory '/usr/src/packages/BUILD/firmware/src' [ 295s] Making all in common [ 295s] make[5]: Entering directory '/usr/src/packages/BUILD/firmware/src/common' [ 295s] srcdir=. ./edit-gpif ./gpif.c usrp_gpif.c usrp_gpif_inline.h [ 295s] /usr/bin/env: 'python': No such file or directory [ 295s] make[5]: *** [Makefile:523: usrp_gpif.c] Error 127 [ 295s] make[5]: Leaving directory '/usr/src/packages/BUILD/firmware/src/common' [ 295s] make[4]: *** [Makefile:405: all-recursive] Error 1 [ 295s] make[4]: Leaving directory '/usr/src/packages/BUILD/firmware/src' [ 295s] make[3]: *** [Makefile:405: all-recursive] Error 1 [ 295s] make[3]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 295s] make[2]: *** [Makefile:635: all-recursive] Error 1 [ 295s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 295s] make[1]: *** [Makefile:554: all] Error 2 [ 295s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 295s] dh_auto_build: error: make -j1 returned exit code 2 [ 295s] make: *** [debian/rules:13: build] Error 25 [ 295s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 295s] ### VM INTERACTION START ### [ 298s] [ 270.859708] sysrq: SysRq : Power Off [ 298s] [ 270.863451] reboot: Power down [ 298s] ### VM INTERACTION END ### [ 298s] [ 298s] cloud108 failed "build libusrp_3.4.4.7.50ce.dsc" at Sat Jun 6 15:26:58 UTC 2020. [ 298s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Change in osmo-bts[master]: osmo-bts-trx/trx_if: cosmetic: s/ocommand/command/
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/18705 ) Change subject: osmo-bts-trx/trx_if: cosmetic: s/ocommand/command/ .. osmo-bts-trx/trx_if: cosmetic: s/ocommand/command/ Change-Id: I06db72deb78cbab588de2103657b0722b67887a0 --- M src/osmo-bts-trx/trx_if.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/05/18705/1 diff --git a/src/osmo-bts-trx/trx_if.c b/src/osmo-bts-trx/trx_if.c index 488aff6..24d6b9b 100644 --- a/src/osmo-bts-trx/trx_if.c +++ b/src/osmo-bts-trx/trx_if.c @@ -202,7 +202,7 @@ * \param[in] fmt Format string (+ variable list of arguments) * \returns 0 on success; negative on error * - * The new ocommand will be added to the end of the control command + * The new command will be added to the end of the control command * queue. */ static int trx_ctrl_cmd_cb(struct trx_l1h *l1h, int critical, void *cb, const char *cmd, -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18705 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I06db72deb78cbab588de2103657b0722b67887a0 Gerrit-Change-Number: 18705 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange
Change in osmo-bts[master]: osmo-bts-trx/trx_if: fix memleak in trx_ctrl_cmd_cb()
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18704 ) Change subject: osmo-bts-trx/trx_if: fix memleak in trx_ctrl_cmd_cb() .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-bts/+/18704/1/src/osmo-bts-trx/trx_if.c File src/osmo-bts-trx/trx_if.c: https://gerrit.osmocom.org/c/osmo-bts/+/18704/1/src/osmo-bts-trx/trx_if.c@205 PS1, Line 205: * The new ocommand will be added to the end of the control command > Minor suggestion - fix a typo in the comment here in a separate commit? I'll submit a separate change, thanks! -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18704 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ie2cdf547befbc0fafdb82b10b45ad85a9b188b88 Gerrit-Change-Number: 18704 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: ipse Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sat, 06 Jun 2020 12:44:30 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: ipse Gerrit-MessageType: comment
Change in osmo-bts[master]: osmo-bts-trx/trx_if: fix memleak in trx_ctrl_cmd_cb()
ipse has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18704 ) Change subject: osmo-bts-trx/trx_if: fix memleak in trx_ctrl_cmd_cb() .. Patch Set 1: (1 comment) The patch looks valid to me but I'm no specialist in this part of the code. I'm not sure whether this could fix the original issue with the leaking NOHANDOVER messages but happy to give it a try and see if this resolves the issue. https://gerrit.osmocom.org/c/osmo-bts/+/18704/1/src/osmo-bts-trx/trx_if.c File src/osmo-bts-trx/trx_if.c: https://gerrit.osmocom.org/c/osmo-bts/+/18704/1/src/osmo-bts-trx/trx_if.c@205 PS1, Line 205: * The new ocommand will be added to the end of the control command Minor suggestion - fix a typo in the comment here in a separate commit? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18704 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ie2cdf547befbc0fafdb82b10b45ad85a9b188b88 Gerrit-Change-Number: 18704 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: ipse Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sat, 06 Jun 2020 12:41:50 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-bsc[master]: stats: Add a BTS counter for paging requests responded elsewhere.
Hello laforge, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-bsc/+/18426
to look at the new patch set (#3).
Change subject: stats: Add a BTS counter for paging requests responded
elsewhere.
..
stats: Add a BTS counter for paging requests responded elsewhere.
If we have several BTS in a single LAC, only one of them will respond
to the paging. Without this counter this situation will lead to
"lost" paging requests, i.e. in disparity between attempted pagings
and expired/responded/etc pagings.
That siad, even after this counter we're still observing some
unaccounted ("lost") paging requests, so the saga for correctly
counting paging is to continue...
Change-Id: I4b27a0559ef2762e62bc3ac3f17b89b0ed48
---
M include/osmocom/bsc/gsm_data.h
M src/osmo-bsc/paging.c
2 files changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/26/18426/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18426
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I4b27a0559ef2762e62bc3ac3f17b89b0ed48
Gerrit-Change-Number: 18426
Gerrit-PatchSet: 3
Gerrit-Owner: ipse
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: ipse
Gerrit-Reviewer: laforge
Gerrit-MessageType: newpatchset
Change in osmo-bsc[master]: stats: Add a BTS counter for paging requests responded elsewhere.
ipse has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18426 ) Change subject: stats: Add a BTS counter for paging requests responded elsewhere. .. Patch Set 2: This is now working as expected. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18426 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4b27a0559ef2762e62bc3ac3f17b89b0ed48 Gerrit-Change-Number: 18426 Gerrit-PatchSet: 2 Gerrit-Owner: ipse Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: ipse Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sat, 06 Jun 2020 11:03:13 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Build failure of network:osmocom:nightly/libusrp in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libusrp/Debian_Unstable/x86_64 Package network:osmocom:nightly/libusrp failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libusrp Last lines of build log: [ 360s] touch libfx2.lib [ 360s] for obj in delay.rel fx2utils.rel i2c.rel isr.rel timer.rel usb_common.rel; do basename $obj .rel >> libfx2.lib ; done [ 360s] make[4]: Leaving directory '/usr/src/packages/BUILD/firmware/lib' [ 360s] Making all in src [ 360s] make[4]: Entering directory '/usr/src/packages/BUILD/firmware/src' [ 360s] Making all in common [ 360s] make[5]: Entering directory '/usr/src/packages/BUILD/firmware/src/common' [ 360s] srcdir=. ./edit-gpif ./gpif.c usrp_gpif.c usrp_gpif_inline.h [ 360s] /usr/bin/env: 'python': No such file or directory [ 360s] make[5]: *** [Makefile:523: usrp_gpif.c] Error 127 [ 360s] make[5]: Leaving directory '/usr/src/packages/BUILD/firmware/src/common' [ 360s] make[4]: *** [Makefile:405: all-recursive] Error 1 [ 360s] make[4]: Leaving directory '/usr/src/packages/BUILD/firmware/src' [ 360s] make[3]: *** [Makefile:405: all-recursive] Error 1 [ 360s] make[3]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 360s] make[2]: *** [Makefile:635: all-recursive] Error 1 [ 360s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 360s] make[1]: *** [Makefile:554: all] Error 2 [ 360s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 360s] dh_auto_build: error: make -j1 returned exit code 2 [ 360s] make: *** [debian/rules:13: build] Error 25 [ 360s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 360s] ### VM INTERACTION START ### [ 363s] [ 348.052578] sysrq: SysRq : Power Off [ 363s] [ 348.058810] reboot: Power down [ 363s] ### VM INTERACTION END ### [ 363s] [ 363s] lamb06 failed "build libusrp_3.4.4.7.50ce.dsc" at Sat Jun 6 11:02:28 UTC 2020. [ 363s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Change in osmo-bsc[master]: paging: Remove obsolete comment.
ipse has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18428 ) Change subject: paging: Remove obsolete comment. .. Patch Set 2: @neels Ping -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18428 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If2a0b15e360c44abc92fdeb9004be7ccc0537cdd Gerrit-Change-Number: 18428 Gerrit-PatchSet: 2 Gerrit-Owner: ipse Gerrit-Assignee: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: ipse Gerrit-Reviewer: neels Gerrit-CC: pespin Gerrit-Comment-Date: Sat, 06 Jun 2020 10:59:33 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-bts[master]: osmo-bts-trx/trx_if: fix memleak in trx_ctrl_cmd_cb()
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-bts/+/18704 )
Change subject: osmo-bts-trx/trx_if: fix memleak in trx_ctrl_cmd_cb()
..
osmo-bts-trx/trx_if: fix memleak in trx_ctrl_cmd_cb()
If we do not enqueue a TRXC message, we should release memory.
Change-Id: Ie2cdf547befbc0fafdb82b10b45ad85a9b188b88
---
M src/osmo-bts-trx/trx_if.c
1 file changed, 12 insertions(+), 11 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/04/18704/1
diff --git a/src/osmo-bts-trx/trx_if.c b/src/osmo-bts-trx/trx_if.c
index f717a0c..488aff6 100644
--- a/src/osmo-bts-trx/trx_if.c
+++ b/src/osmo-bts-trx/trx_if.c
@@ -211,9 +211,6 @@
struct trx_ctrl_msg *tcm;
struct trx_ctrl_msg *prev = NULL;
va_list ap;
- int pending;
-
- pending = !llist_empty(>trx_ctrl_list);
/* create message */
tcm = talloc_zero(tall_bts_ctx, struct trx_ctrl_msg);
@@ -236,18 +233,22 @@
tcm->cb = cb;
/* Avoid adding consecutive duplicate messages, eg: two consecutive
POWEROFF */
- if(pending)
+ if (!llist_empty(>trx_ctrl_list))
prev = llist_entry(l1h->trx_ctrl_list.prev, struct
trx_ctrl_msg, list);
-
- if (!pending ||
- !(strcmp(tcm->cmd, prev->cmd) == 0 && strcmp(tcm->params,
prev->params) == 0)) {
- LOGPPHI(l1h->phy_inst, DTRX, LOGL_INFO, "Enqueuing TRX control
command 'CMD %s%s%s'\n",
- tcm->cmd, tcm->params_len ? " ":"", tcm->params);
- llist_add_tail(>list, >trx_ctrl_list);
+ if (prev != NULL && !strcmp(tcm->cmd, prev->cmd)
+&& !strcmp(tcm->params, prev->params)) {
+ LOGPPHI(l1h->phy_inst, DTRX, LOGL_DEBUG,
+ "Not sending duplicate command '%s'\n", tcm->cmd);
+ talloc_free(tcm);
+ return 0;
}
+ LOGPPHI(l1h->phy_inst, DTRX, LOGL_INFO, "Enqueuing TRX control command
'CMD %s%s%s'\n",
+ tcm->cmd, tcm->params_len ? " " : "", tcm->params);
+ llist_add_tail(>list, >trx_ctrl_list);
+
/* send message, if we didn't already have pending messages */
- if (!pending)
+ if (prev == NULL)
trx_ctrl_send(l1h);
return 0;
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18704
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ie2cdf547befbc0fafdb82b10b45ad85a9b188b88
Gerrit-Change-Number: 18704
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
Change in osmo-bsc[master]: chan_alloc: Fix typo in a comment.
ipse has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-bsc/+/18701 )
Change subject: chan_alloc: Fix typo in a comment.
..
chan_alloc: Fix typo in a comment.
Change-Id: Iaed3fcd99ec8c08faa75e23af5b50a1d0e0905eb
---
M src/osmo-bsc/chan_alloc.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/01/18701/1
diff --git a/src/osmo-bsc/chan_alloc.c b/src/osmo-bsc/chan_alloc.c
index f23a982..8b6e28c 100644
--- a/src/osmo-bsc/chan_alloc.c
+++ b/src/osmo-bsc/chan_alloc.c
@@ -45,7 +45,7 @@
llist_for_each_entry(trx, >trx_list, list) {
int i;
- /* skip administratively deactivated tranxsceivers */
+ /* skip administratively deactivated transceivers */
if (!trx_is_usable(trx))
continue;
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18701
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Iaed3fcd99ec8c08faa75e23af5b50a1d0e0905eb
Gerrit-Change-Number: 18701
Gerrit-PatchSet: 1
Gerrit-Owner: ipse
Gerrit-MessageType: newchange
Change in osmo-bsc[master]: timeslot_fsm: Name TS FSM instances on allocation.
ipse has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-bsc/+/18702 )
Change subject: timeslot_fsm: Name TS FSM instances on allocation.
..
timeslot_fsm: Name TS FSM instances on allocation.
Before this patch FSM instances of configured but not connected BTS's
look like this:
FSM Instance Name: 'timeslot[0x61204a20]', ID: '(null)'
Log-Level: 'DEBUG', State: 'NOT_INITIALIZED'
Now they look like this:
FSM Instance Name: 'timeslot(0-0-7-NONE)[0x61204a20]', ID: '0-0-7-NONE'
Log-Level: 'DEBUG', State: 'NOT_INITIALIZED'
which makes it possible to attribute them to where they belong.
Otherwise, they look like lingering or leaking unattributed FSM
instances.
Change-Id: Idc74ea142b96323b48826f8a52e13e45d535512a
---
M src/osmo-bsc/timeslot_fsm.c
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/02/18702/1
diff --git a/src/osmo-bsc/timeslot_fsm.c b/src/osmo-bsc/timeslot_fsm.c
index 4816daf..b33e53e 100644
--- a/src/osmo-bsc/timeslot_fsm.c
+++ b/src/osmo-bsc/timeslot_fsm.c
@@ -62,6 +62,7 @@
OSMO_ASSERT(ts->trx);
ts->fi = osmo_fsm_inst_alloc(_fsm, ts->trx, ts, LOGL_DEBUG, NULL);
OSMO_ASSERT(ts->fi);
+ ts_fsm_update_id(ts);
}
enum lchan_sanity {
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18702
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Idc74ea142b96323b48826f8a52e13e45d535512a
Gerrit-Change-Number: 18702
Gerrit-PatchSet: 1
Gerrit-Owner: ipse
Gerrit-MessageType: newchange
Change in osmo-bsc[master]: stats: Count transitions from BORKEN state due to LCHAN_EV_TS_ERROR s...
ipse has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-bsc/+/18703 )
Change subject: stats: Count transitions from BORKEN state due to
LCHAN_EV_TS_ERROR signal.
..
stats: Count transitions from BORKEN state due to LCHAN_EV_TS_ERROR signal.
Change-Id: Ice3379020039dc3634aa3887939740729d720dee
---
M include/osmocom/bsc/gsm_data.h
M src/osmo-bsc/lchan_fsm.c
2 files changed, 9 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/03/18703/1
diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h
index d2f6c09..e184adc 100644
--- a/include/osmocom/bsc/gsm_data.h
+++ b/include/osmocom/bsc/gsm_data.h
@@ -1416,6 +1416,7 @@
BTS_CTR_LCHAN_BORKEN_EV_RF_CHAN_REL_ACK,
BTS_CTR_LCHAN_BORKEN_EV_VTY,
BTS_CTR_LCHAN_BORKEN_EV_TEARDOWN,
+ BTS_CTR_LCHAN_BORKEN_EV_TS_ERROR,
BTS_CTR_TS_BORKEN_FROM_NOT_INITIALIZED,
BTS_CTR_TS_BORKEN_FROM_UNUSED,
BTS_CTR_TS_BORKEN_FROM_WAIT_PDCH_ACT,
@@ -1466,6 +1467,7 @@
[BTS_CTR_LCHAN_BORKEN_EV_RF_CHAN_REL_ACK] =
{"lchan_borken:event:rf_chan_rel_ack", "RF_CHAN_REL_ACK received in the lchan
BORKEN state"},
[BTS_CTR_LCHAN_BORKEN_EV_VTY] =
{"lchan_borken:event:vty", "VTY commands received in the lchan BORKEN state"},
[BTS_CTR_LCHAN_BORKEN_EV_TEARDOWN] =
{"lchan_borken:event:teardown", "lchan in a BORKEN state is shutting down (BTS
disconnected?)"},
+ [BTS_CTR_LCHAN_BORKEN_EV_TS_ERROR] =
{"lchan_borken:event:ts_error", "LCHAN_EV_TS_ERROR received in a BORKEN state"},
[BTS_CTR_TS_BORKEN_FROM_NOT_INITIALIZED] =
{"ts_borken:from_state:not_initialized", "Transitions from TS NOT_INITIALIZED
state to BORKEN state"},
[BTS_CTR_TS_BORKEN_FROM_UNUSED] =
{"ts_borken:from_state:unused", "Transitions from TS UNUSED state to BORKEN
state"},
[BTS_CTR_TS_BORKEN_FROM_WAIT_PDCH_ACT] =
{"ts_borken:from_state:wait_pdch_act", "Transitions from TS WAIT_PDCH_ACT state
to BORKEN state"},
diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c
index a1bf857..1550ffb 100644
--- a/src/osmo-bsc/lchan_fsm.c
+++ b/src/osmo-bsc/lchan_fsm.c
@@ -1327,8 +1327,15 @@
switch (event) {
case LCHAN_EV_TS_ERROR:
+ {
+ struct gsm_lchan *lchan = lchan_fi_lchan(fi);
+ if (fi->state == LCHAN_ST_BORKEN) {
+
rate_ctr_inc(>ts->trx->bts->bts_ctrs->ctr[BTS_CTR_LCHAN_BORKEN_EV_TS_ERROR]);
+
osmo_stat_item_dec(lchan->ts->trx->bts->bts_statg->items[BTS_STAT_LCHAN_BORKEN],
1);
+ }
lchan_fail_to(LCHAN_ST_UNUSED, "LCHAN_EV_TS_ERROR");
return;
+ }
default:
return;
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18703
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ice3379020039dc3634aa3887939740729d720dee
Gerrit-Change-Number: 18703
Gerrit-PatchSet: 1
Gerrit-Owner: ipse
Gerrit-MessageType: newchange
Change in osmo-bsc[master]: stats: Add a BTS counter for paging requests responded elsewhere.
Hello laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/18426 to look at the new patch set (#2). Change subject: stats: Add a BTS counter for paging requests responded elsewhere. .. stats: Add a BTS counter for paging requests responded elsewhere. If we have several BTS in a single LAC, only one of them will respond to the paging. Without this counter this situation will lead to "lost" paging requests, i.e. in disparity between attempted pagings and expired/responded/etc pagings. Now the sum of all paging response counters should actually match the attempted counter. Change-Id: I4b27a0559ef2762e62bc3ac3f17b89b0ed48 --- M include/osmocom/bsc/gsm_data.h M src/osmo-bsc/paging.c 2 files changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/26/18426/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18426 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4b27a0559ef2762e62bc3ac3f17b89b0ed48 Gerrit-Change-Number: 18426 Gerrit-PatchSet: 2 Gerrit-Owner: ipse Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: ipse Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset
Change in osmo-bts[master]: common/scheduler: fix unreachable code in trx_sched_set_lchan()
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18699 ) Change subject: common/scheduler: fix unreachable code in trx_sched_set_lchan() .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-bts/+/18699/2/src/common/scheduler.c File src/common/scheduler.c: https://gerrit.osmocom.org/c/osmo-bts/+/18699/2/src/common/scheduler.c@a990 PS2, Line 990: memset Interesting that Coverity did not warn us about that. We basically memset() the whole structure, including both 'dl_bursts' and 'ul_bursts' pointers. And after that check if they're not NULL. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18699 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ie9d8f8ca86195be4408db717cd3194a7d2ddc918 Gerrit-Change-Number: 18699 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sat, 06 Jun 2020 08:58:42 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in docker-playground[master]: ttcn3-bts-test/jenkins.sh: stop container with BSC in the end
fixeria has abandoned this change. ( https://gerrit.osmocom.org/c/docker-playground/+/18695 ) Change subject: ttcn3-bts-test/jenkins.sh: stop container with BSC in the end .. Abandoned -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/18695 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ia383febb3ca7ae6263853c68dc7b6d8700612b01 Gerrit-Change-Number: 18695 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: fixeria Gerrit-CC: laforge Gerrit-MessageType: abandon
Change in docker-playground[master]: ttcn3-bts-test/jenkins.sh: stop container with BSC in the end
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/docker-playground/+/18695 )
Change subject: ttcn3-bts-test/jenkins.sh: stop container with BSC in the end
..
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/c/docker-playground/+/18695/1/ttcn3-bts-test/jenkins.sh
File ttcn3-bts-test/jenkins.sh:
https://gerrit.osmocom.org/c/docker-playground/+/18695/1/ttcn3-bts-test/jenkins.sh@151
PS1, Line 151: docker container kill ${BUILD_TAG}-bsc
> actually, the container is killed above in line #139 when we set-up the OML
> tests which already run […]
Oh, right. I intentionally skipped (just removed) that segment with OML tests
in my setup, so that's why it wasn't killed. I'll abandon this change.
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/18695
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: Ia383febb3ca7ae6263853c68dc7b6d8700612b01
Gerrit-Change-Number: 18695
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-Reviewer: fixeria
Gerrit-CC: laforge
Gerrit-Comment-Date: Sat, 06 Jun 2020 06:50:10 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge
Gerrit-MessageType: comment
