Change in osmo-bts[master]: osmo-bts-trx/scheduler: properly handle NOPE.ind during handover
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18734 ) Change subject: osmo-bts-trx/scheduler: properly handle NOPE.ind during handover .. osmo-bts-trx/scheduler: properly handle NOPE.ind during handover Looking at GSMTAP during handover, I've noticed many packets on RACH looking pretty much like false positives, all with RA=0x00. I correlated GSMTAP traces with TRXD traces, and figured out that they all are triggered by NOPE indications from osmo-trx. Since a NOPE.ind carries no valid burst, all its bits are set to zero. Funny enough, this sequence is still decoded just fine as a valid RACH, so that's why we see it on GSMTAP. Later on it gets rejected by L1SAP due to bad RSSI, ToA, and/or C/I ratio. The is a side effect of [1]. In order to ensure proper Uplink measurement reporting during handover, including the time before the handover RACH is received, let's treat and handle NOPE indications as Normal Bursts. [1] Ice45d5986610d9bcef2a7e41f0a395ec779e3928 Change-Id: Ic69f3bc2b776a23374c28a6884080a54bc16ef5f Related: OS#4592 --- M src/osmo-bts-trx/scheduler_trx.c 1 file changed, 9 insertions(+), 6 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bts-trx/scheduler_trx.c b/src/osmo-bts-trx/scheduler_trx.c index 8a2bb12..97b590d 100644 --- a/src/osmo-bts-trx/scheduler_trx.c +++ b/src/osmo-bts-trx/scheduler_trx.c @@ -917,8 +917,9 @@ uint16_t ber10k; int rc; - /* handle RACH, if handover RACH detection is turned on */ - if (chan_state->ho_rach_detect == 1) + /* If handover RACH detection is turned on, treat this burst as an Access Burst. +* Handle NOPE.ind as usually to ensure proper Uplink measurement reporting. */ + if (chan_state->ho_rach_detect == 1 && ~bi->flags & TRX_BI_F_NOPE_IND) return rx_rach_fn(l1t, chan, bid, bi); LOGL1S(DL1P, LOGL_DEBUG, l1t, bi->tn, chan, bi->fn, @@ -1142,8 +1143,9 @@ uint8_t is_sub = 0; uint8_t ft; - /* handle rach, if handover rach detection is turned on */ - if (chan_state->ho_rach_detect == 1) + /* If handover RACH detection is turned on, treat this burst as an Access Burst. +* Handle NOPE.ind as usually to ensure proper Uplink measurement reporting. */ + if (chan_state->ho_rach_detect == 1 && ~bi->flags & TRX_BI_F_NOPE_IND) return rx_rach_fn(l1t, chan, bid, bi); LOGL1S(DL1P, LOGL_DEBUG, l1t, bi->tn, chan, bi->fn, @@ -1384,8 +1386,9 @@ uint8_t is_sub = 0; uint8_t ft; - /* handle RACH, if handover RACH detection is turned on */ - if (chan_state->ho_rach_detect == 1) + /* If handover RACH detection is turned on, treat this burst as an Access Burst. +* Handle NOPE.ind as usually to ensure proper Uplink measurement reporting. */ + if (chan_state->ho_rach_detect == 1 && ~bi->flags & TRX_BI_F_NOPE_IND) return rx_rach_fn(l1t, chan, bid, bi); LOGL1S(DL1P, LOGL_DEBUG, l1t, bi->tn, chan, bi->fn, -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18734 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ic69f3bc2b776a23374c28a6884080a54bc16ef5f Gerrit-Change-Number: 18734 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: merged
Build failure of network:osmocom:nightly/open5gs in Debian_10/i586
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/open5gs/Debian_10/i586
Package network:osmocom:nightly/open5gs failed to build in Debian_10/i586
Check out the package for editing:
osc checkout network:osmocom:nightly open5gs
Last lines of build log:
[ 193s] [1926/2112] cc -Isrc/udr/e340f29@@udr@sta -Isrc/udr -I../src/udr
-Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/dbi
-I../lib/dbi -Ilib/crypt -I../lib/crypt -Ilib/sbi -I../lib/sbi
-Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/libmongoc-1.0
-I/usr/include/libbson-1.0 -I/usr/include/p11-kit-1
-I/usr/include/i386-linux-gnu -fdiagnostics-color=always -pipe
-D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op
-Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self
-Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes
-Werror=missing-declarations -Werror=implicit-function-declaration
-Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2
-Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels
-Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow
-Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time
-Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation
-Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option
-fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4
-ffunction-sections -fdata-sections -g -O2
-fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -MD -MQ
'src/udr/e340f29@@udr@sta/sbi-path.c.o' -MF
'src/udr/e340f29@@udr@sta/sbi-path.c.o.d' -o
'src/udr/e340f29@@udr@sta/sbi-path.c.o' -c ../src/udr/sbi-path.c
[ 193s] [1927/2112] cc -Isrc/udm/3eca12a@@udm@sta -Isrc/udm -I../src/udm
-Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/crypt
-I../lib/crypt -Ilib/sbi -I../lib/sbi -Ilib/sbi/openapi -I../lib/sbi/openapi
-I/usr/include/p11-kit-1 -I/usr/include/i386-linux-gnu
-fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra
-Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith
-Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn
-Werror=missing-prototypes -Werror=missing-declarations
-Werror=implicit-function-declaration -Werror=return-type
-Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes
-Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3
-Wwrite-strings -Werror=overflow -Werror=shift-count-overflow
-Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wunused
-Wduplicated-branches -Wmisleading-indentation -Wno-sign-compare
-Wno-unused-parameter -ffast-math -fdiagnostics-show-option -fstack-protector
-fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections
-fdata-sections -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=.
-fstack-protector-strong -Wformat -Werror=format-security -Wdate-time
-D_FORTIFY_SOURCE=2 -fPIC -pthread -MD -MQ
'src/udm/3eca12a@@udm@sta/context.c.o' -MF
'src/udm/3eca12a@@udm@sta/context.c.o.d' -o
'src/udm/3eca12a@@udm@sta/context.c.o' -c ../src/udm/context.c
[ 193s] FAILED: src/udm/3eca12a@@udm@sta/context.c.o
[ 193s] cc -Isrc/udm/3eca12a@@udm@sta -Isrc/udm -I../src/udm -Ilib/app
-I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/crypt -I../lib/crypt
-Ilib/sbi -I../lib/sbi -Ilib/sbi/openapi -I../lib/sbi/openapi
-I/usr/include/p11-kit-1 -I/usr/include/i386-linux-gnu
-fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra
-Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith
-Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn
-Werror=missing-prototypes -Werror=missing-declarations
-Werror=implicit-function-declaration -Werror=return-type
-Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes
-Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3
-Wwrite-strings -Werror=overflow -Werror=shift-count-overflow
-Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wunused
-Wduplicated-branches -Wmisleading-indentation -Wno-sign-compare
-Wno-unused-parameter -ffast-math -fdiagnostics-show-option -fstack-protector
-fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections
-fdata-sections -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=.
-fstack-protector-strong -Wformat -Werror=format-security -Wdate-time
-D_FORTIFY_SOURCE=2 -fPIC -pthread -MD -MQ
'src/udm/3eca12a@@udm@sta/context.c.o' -MF
'src/udm/3eca12a@@udm@sta/context.c.o.d' -o
'src/udm/3eca12a@@udm@sta/context.c.o' -c ../src/udm/context.c
[ 193s] ../src/udm/context.c: In function ‘udm_ue_add’:
[ 193s] ../src/udm/context.c:129:38: error: format ‘%ld’ expects argument of
type ‘long int’, but argument 2 has type ‘int’ [-Werror=format=]
[ 193s] udm_ue->ctx_id = ogs_msprintf("%ld", ogs_pool_index(&udm_u
Build failure of network:osmocom:nightly/open5gs in xUbuntu_18.04/i586
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/open5gs/xUbuntu_18.04/i586 Package network:osmocom:nightly/open5gs failed to build in xUbuntu_18.04/i586 Check out the package for editing: osc checkout network:osmocom:nightly open5gs Last lines of build log: [ 194s] [1931/2112] cc -Isrc/udr/open5gs-udrd@exe -Isrc/udr -I../src/udr -Isrc -I../src -Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/dbi -I../lib/dbi -Ilib/crypt -I../lib/crypt -Ilib/sbi -I../lib/sbi -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/libmongoc-1.0 -I/usr/include/libbson-1.0 -I/usr/include/p11-kit-1 -I/usr/include/i386-linux-gnu -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes -Werror=missing-declarations -Werror=implicit-function-declaration -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow -Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation -Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option -fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections -fdata-sections -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -pthread '-DDEFAULT_CONFIG_FILENAME="/etc/open5gs/udr.yaml"' -MD -MQ 'src/udr/open5gs-udrd@exe/app.c.o' -MF 'src/udr/open5gs-udrd@exe/app.c.o.d' -o 'src/udr/open5gs-udrd@exe/app.c.o' -c ../src/udr/app.c [ 194s] [1932/2112] cc -Isrc/udr/udr@sta -Isrc/udr -I../src/udr -Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/dbi -I../lib/dbi -Ilib/crypt -I../lib/crypt -Ilib/sbi -I../lib/sbi -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/libmongoc-1.0 -I/usr/include/libbson-1.0 -I/usr/include/p11-kit-1 -I/usr/include/i386-linux-gnu -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes -Werror=missing-declarations -Werror=implicit-function-declaration -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow -Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation -Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option -fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections -fdata-sections -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -MD -MQ 'src/udr/udr@sta/init.c.o' -MF 'src/udr/udr@sta/init.c.o.d' -o 'src/udr/udr@sta/init.c.o' -c ../src/udr/init.c [ 194s] [1933/2112] cc -Isrc/udr/udr@sta -Isrc/udr -I../src/udr -Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/dbi -I../lib/dbi -Ilib/crypt -I../lib/crypt -Ilib/sbi -I../lib/sbi -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/libmongoc-1.0 -I/usr/include/libbson-1.0 -I/usr/include/p11-kit-1 -I/usr/include/i386-linux-gnu -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes -Werror=missing-declarations -Werror=implicit-function-declaration -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow -Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation -Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option -fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections -fdata-sections -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -MD -MQ 'src/udr/udr@sta/udr-sm.c.o' -MF 'src/udr/udr@sta/udr-sm.c.o.d' -o 'src/udr/udr@sta/udr-sm.c.o' -c ../src/udr/udr-sm.c [ 194s] [1934/2112] rm -f src/udr/libudr.a && gcc-ar csrD src/udr/libudr.a 'src/udr/udr@sta/context.c.o' 'src/udr/udr@sta/event.c.o' 'src/udr/udr@sta/timer.c.o' 'src/udr/udr@sta/nnrf-handler.c.o'
Build failure of network:osmocom:nightly/open5gs in xUbuntu_18.10/i586
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/open5gs/xUbuntu_18.10/i586 Package network:osmocom:nightly/open5gs failed to build in xUbuntu_18.10/i586 Check out the package for editing: osc checkout network:osmocom:nightly open5gs Last lines of build log: [ 408s] [1921/2112] rm -f src/pcrf/libpcrf.a && gcc-ar csrD src/pcrf/libpcrf.a 'src/pcrf/src@pcrf@@pcrf@sta/pcrf-init.c.o' 'src/pcrf/src@pcrf@@pcrf@sta/pcrf-context.c.o' 'src/pcrf/src@pcrf@@pcrf@sta/pcrf-fd-path.c.o' 'src/pcrf/src@pcrf@@pcrf@sta/pcrf-gx-path.c.o' 'src/pcrf/src@pcrf@@pcrf@sta/pcrf-rx-path.c.o' [ 408s] [1922/2112] cc -Isrc/nrf/src@nrf@@nrf@sta -Isrc/nrf -I../src/nrf -Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/dbi -I../lib/dbi -Ilib/crypt -I../lib/crypt -Ilib/sbi -I../lib/sbi -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/libmongoc-1.0 -I/usr/include/libbson-1.0 -I/usr/include/p11-kit-1 -I/usr/include/i386-linux-gnu -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes -Werror=missing-declarations -Werror=implicit-function-declaration -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow -Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation -Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option -fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections -fdata-sections -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -MD -MQ 'src/nrf/src@nrf@@nrf@sta/nrf-sm.c.o' -MF 'src/nrf/src@nrf@@nrf@sta/nrf-sm.c.o.d' -o 'src/nrf/src@nrf@@nrf@sta/nrf-sm.c.o' -c ../src/nrf/nrf-sm.c [ 409s] [1923/2112] rm -f src/nrf/libnrf.a && gcc-ar csrD src/nrf/libnrf.a 'src/nrf/src@nrf@@nrf@sta/context.c.o' 'src/nrf/src@nrf@@nrf@sta/event.c.o' 'src/nrf/src@nrf@@nrf@sta/timer.c.o' 'src/nrf/src@nrf@@nrf@sta/nnrf-handler.c.o' 'src/nrf/src@nrf@@nrf@sta/nnrf-build.c.o' 'src/nrf/src@nrf@@nrf@sta/sbi-path.c.o' 'src/nrf/src@nrf@@nrf@sta/nf-sm.c.o' 'src/nrf/src@nrf@@nrf@sta/nrf-sm.c.o' 'src/nrf/src@nrf@@nrf@sta/init.c.o' [ 409s] [1924/2112] cc -Isrc/udm/src@udm@@udm@sta -Isrc/udm -I../src/udm -Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/crypt -I../lib/crypt -Ilib/sbi -I../lib/sbi -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/p11-kit-1 -I/usr/include/i386-linux-gnu -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes -Werror=missing-declarations -Werror=implicit-function-declaration -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow -Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation -Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option -fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections -fdata-sections -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -MD -MQ 'src/udm/src@udm@@udm@sta/nnrf-handler.c.o' -MF 'src/udm/src@udm@@udm@sta/nnrf-handler.c.o.d' -o 'src/udm/src@udm@@udm@sta/nnrf-handler.c.o' -c ../src/udm/nnrf-handler.c [ 409s] [1925/2112] cc -o src/pcrf/open5gs-pcrfd 'src/pcrf/src@pcrf@@open5gs-pcrfd@exe/app-init.c.o' 'src/pcrf/src@pcrf@@open5gs-pcrfd@exe/.._main.c.o' -Wl,--no-undefined -Wl,--as-needed -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-Bsymbolic-functions -Wl,-z,relro -Wl,-z,now -Wl,--start-group src/pcrf/libpcrf.a lib/app/libogsapp.so.1.2.5 lib/core/libogscore.so.1.2.5 lib/dbi/libogsdbi.so.1.2.5 lib/crypt/libogscrypt.so.1.2.5 lib/diameter/rx/libogsdiameter-rx.so.1.2.5 lib/diameter/common/libogsdiameter-common.so.1.2.5 subprojects/freeDiameter/libfdcore/libfdcore.so.1.3.2 subprojects/freeDiameter/libfdproto/libfdproto.so.1.3.2 lib/diameter/gx/libogsdiameter-gx.so.1.2.5 /usr/lib/i386-linux-gnu/libyaml.so /usr/lib/i386-linux-gnu/libmongoc-1.0.so /usr/lib/i386-linux-gnu/libssl.so /usr/lib/i386-linux-gnu/libcrypto.so -lrt /usr/lib/i386-linux-gnu/libresolv.so /usr/lib/i386-linux-gnu/libz.so /u
Change in osmo-bts[master]: osmo-bts-trx/scheduler: properly handle NOPE.ind during handover
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18734 ) Change subject: osmo-bts-trx/scheduler: properly handle NOPE.ind during handover .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18734 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ic69f3bc2b776a23374c28a6884080a54bc16ef5f Gerrit-Change-Number: 18734 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 11 Jun 2020 20:47:55 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-trx[master]: Transceiver: Implement TRXC cmd NOMTXPOWER
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/18586 ) Change subject: Transceiver: Implement TRXC cmd NOMTXPOWER .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/18586 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I1d7efe56e008d8d60e23f9a85aa40809f7f84d9c Gerrit-Change-Number: 18586 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Reviewer: roh Gerrit-Comment-Date: Thu, 11 Jun 2020 20:46:36 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in docker-playground[master]: MSC_Tests.cfg: tweak comments
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/18776 ) Change subject: MSC_Tests.cfg: tweak comments .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/18776 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If5f9cff03f078987c5b9051f8d63c239bf92ddb7 Gerrit-Change-Number: 18776 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 11 Jun 2020 20:46:10 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in docker-playground[master]: bsc: adjust osmo-bsc.cfg for MSC pooling tests
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/18775 ) Change subject: bsc: adjust osmo-bsc.cfg for MSC pooling tests .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/docker-playground/+/18775/1/ttcn3-bsc-test/osmo-bsc.cfg File ttcn3-bsc-test/osmo-bsc.cfg: https://gerrit.osmocom.org/c/docker-playground/+/18775/1/ttcn3-bsc-test/osmo-bsc.cfg@405 PS1, Line 405: # a Wow, I wasn't even aware that any other character than '!' can be used for comments in our config files. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/18775 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I353a2023d41d9f083acdd61da11109cb5a002f9b Gerrit-Change-Number: 18775 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 11 Jun 2020 20:45:53 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in docker-playground[master]: BSC_Tests.cfg: adjust cfg for multiple MSCs
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/18774 ) Change subject: BSC_Tests.cfg: adjust cfg for multiple MSCs .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/18774 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I1986e4ef43beee161c82193694421b56136c1afe Gerrit-Change-Number: 18774 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 11 Jun 2020 20:44:58 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-gsm-manuals[master]: vty reference: allow reference XML generated at build time
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/18362 ) Change subject: vty reference: allow reference XML generated at build time .. Patch Set 3: I honestly don't have the slightest idea what this patch does, even after reading the commitlog and the patc twice. Not sure if it's just me, sorry. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/18362 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I613d692328050a036d05b49a436ab495fc2087ba Gerrit-Change-Number: 18362 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 11 Jun 2020 20:44:17 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-bsc[master]: tweak log category for Compl L3 error
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18764 ) Change subject: tweak log category for Compl L3 error .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18764 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I9c6373e5f28c9c69a0609889188ef28ade11da3d Gerrit-Change-Number: 18764 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 11 Jun 2020 20:41:26 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: use osmo_mobile_identity API everywhere
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18713 ) Change subject: use osmo_mobile_identity API everywhere .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18713 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I71c3b4c65dbfdfa51409e09d4868aea83225338a Gerrit-Change-Number: 18713 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 11 Jun 2020 20:40:42 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: add gsm23236: MSC pooling: TMSI and NRI utility functions
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18506 ) Change subject: add gsm23236: MSC pooling: TMSI and NRI utility functions .. Patch Set 10: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18506 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icb57a2dd9323c7ea11b34003eccc7e68a0247bf5 Gerrit-Change-Number: 18506 Gerrit-PatchSet: 10 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 11 Jun 2020 20:35:24 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: fix f_enc_IMEI_L3() oddevenIndicator
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18758 ) Change subject: fix f_enc_IMEI_L3() oddevenIndicator .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18758 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iaa9ba1214c4c15fd9620e68fe2e842fdf52912c0 Gerrit-Change-Number: 18758 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Thu, 11 Jun 2020 20:33:48 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: refactor bsc_find_msc()'s round-robin
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18505 ) Change subject: refactor bsc_find_msc()'s round-robin .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18505 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Idf71f07ba5a17d5b870dc1a5a2875b6fedb61291 Gerrit-Change-Number: 18505 Gerrit-PatchSet: 6 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Thu, 11 Jun 2020 20:32:30 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-sgsn[master]: gbproxy_test.c: fix mobile identity test data
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/18585 ) Change subject: gbproxy_test.c: fix mobile identity test data .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/18585 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ia006a3da6779ad1984f642e8ea29790a4daeb8b9 Gerrit-Change-Number: 18585 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 11 Jun 2020 20:32:52 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-gsm-manuals[master]: bibliography, glossary: add MSC pooling related bits
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/18780 ) Change subject: bibliography, glossary: add MSC pooling related bits .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/18780 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I0640db26dc85ab7723c7160e405fc73f412fd706 Gerrit-Change-Number: 18780 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 11 Jun 2020 20:31:12 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: RAN_Emulation: allow sending UnitData from MSC_ConnHdlr
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18762 ) Change subject: RAN_Emulation: allow sending UnitData from MSC_ConnHdlr .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18762 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I36d486db05169b0fc3f19112b5a9008248d62930 Gerrit-Change-Number: 18762 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 11 Jun 2020 20:30:20 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: RSL_Emulation: fix rx of tr_RSL_PAGING_CMD()
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18761 ) Change subject: RSL_Emulation: fix rx of tr_RSL_PAGING_CMD() .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18761 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iaf7730153a3a19e448a33298c3e12212a55929d5 Gerrit-Change-Number: 18761 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 11 Jun 2020 20:28:08 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: bsc: allow multiple MSCs
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18760 ) Change subject: bsc: allow multiple MSCs .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18760 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibb36695b7c31f7b04eec6c5d59522fc0779b3c2f Gerrit-Change-Number: 18760 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 11 Jun 2020 20:26:46 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: move type RAN_Configurations to RAN_Adapter.ttcnpp
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18759 ) Change subject: move type RAN_Configurations to RAN_Adapter.ttcnpp .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18759 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If8f7fd50a88302af645ab337a907d8f0ad79a306 Gerrit-Change-Number: 18759 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 11 Jun 2020 20:24:34 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-gsm-tester[master]: srsenb_sib.conf.tmpl: add default SIB3
srs_andre has submitted this change. (
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18788 )
Change subject: srsenb_sib.conf.tmpl: add default SIB3
..
srsenb_sib.conf.tmpl: add default SIB3
if SIB3 isn't transmitted, the UE won't do HO and cell reselection
Change-Id: I329a59d9d0fa3b25bc00b760a455eadbe0b7220f
---
M src/osmo_gsm_tester/templates/srsenb_sib.conf.tmpl
1 file changed, 21 insertions(+), 1 deletion(-)
Approvals:
srs_andre: Verified
pespin: Looks good to me, approved
diff --git a/src/osmo_gsm_tester/templates/srsenb_sib.conf.tmpl
b/src/osmo_gsm_tester/templates/srsenb_sib.conf.tmpl
index ecd49e9..6d178c6 100644
--- a/src/osmo_gsm_tester/templates/srsenb_sib.conf.tmpl
+++ b/src/osmo_gsm_tester/templates/srsenb_sib.conf.tmpl
@@ -9,7 +9,7 @@
(
{
si_periodicity = 16;
-si_mapping_info = []; // comma-separated array of SIB-indexes
(from 3 to 13).
+si_mapping_info = [ 3 ]; // comma-separated array of SIB-indexes
(from 3 to 13).
// Leave empty or commented to just scheduler sib2
}
);
@@ -119,3 +119,23 @@
time_alignment_timer = "INFINITY"; // use "sf500", "sf750", etc.
};
+
+sib3 =
+{
+cell_reselection_common = {
+q_hyst = 2; // in dB
+},
+cell_reselection_serving = {
+s_non_intra_search = 3,
+thresh_serving_low = 2,
+cell_resel_prio = 6
+},
+intra_freq_reselection = {
+q_rx_lev_min = -61,
+p_max = 23,
+s_intra_search = 5,
+presence_ant_port_1 = true,
+neigh_cell_cnfg = 1,
+t_resel_eutra = 1
+}
+};
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18788
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I329a59d9d0fa3b25bc00b760a455eadbe0b7220f
Gerrit-Change-Number: 18788
Gerrit-PatchSet: 2
Gerrit-Owner: srs_andre
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin
Gerrit-Reviewer: srs_andre
Gerrit-MessageType: merged
Change in osmo-gsm-tester[master]: srsenb_sib.conf.tmpl: add default SIB3
srs_andre has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18788 ) Change subject: srsenb_sib.conf.tmpl: add default SIB3 .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18788 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I329a59d9d0fa3b25bc00b760a455eadbe0b7220f Gerrit-Change-Number: 18788 Gerrit-PatchSet: 2 Gerrit-Owner: srs_andre Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Reviewer: srs_andre Gerrit-Comment-Date: Thu, 11 Jun 2020 18:38:03 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ci[master]: jobs: osmo-gsm-tester: Run mass LU and ttcn3 BTS tests nightly
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/18739 ) Change subject: jobs: osmo-gsm-tester: Run mass LU and ttcn3 BTS tests nightly .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/18739 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ie42fc1e686d29740e14aaacd69659fe09e66801a Gerrit-Change-Number: 18739 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 11 Jun 2020 16:34:25 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ci[master]: jobs: osmo-gsm-tester: Run mass LU and ttcn3 BTS tests nightly
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/18739 ) Change subject: jobs: osmo-gsm-tester: Run mass LU and ttcn3 BTS tests nightly .. jobs: osmo-gsm-tester: Run mass LU and ttcn3 BTS tests nightly Before they were executed almost in a loop, so let's simply run them once per day. Change-Id: Ie42fc1e686d29740e14aaacd69659fe09e66801a --- M jobs/osmo-gsm-tester-runner.yml 1 file changed, 2 insertions(+), 6 deletions(-) Approvals: pespin: Looks good to me, approved; Verified diff --git a/jobs/osmo-gsm-tester-runner.yml b/jobs/osmo-gsm-tester-runner.yml index 041ef93..4cdd383 100644 --- a/jobs/osmo-gsm-tester-runner.yml +++ b/jobs/osmo-gsm-tester-runner.yml @@ -187,9 +187,7 @@ scm: - 'osmo-gsm-tester-repo' triggers: - - timed: "H H/2 * * *" - - pollscm: - cron: "H/5 * * * *" + - timed: "H 23 * * *" builders: - shell: | # make sure no bin artifacts from a previous run remain @@ -214,9 +212,7 @@ scm: - 'osmo-gsm-tester-repo' triggers: - - timed: "H H/2 * * *" - - pollscm: - cron: "H/5 * * * *" + - timed: "H 22 * * *" builders: - shell: | # make sure no bin artifacts from a previous run remain -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/18739 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ie42fc1e686d29740e14aaacd69659fe09e66801a Gerrit-Change-Number: 18739 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: pespin Gerrit-MessageType: merged
Change in osmo-gsm-tester[master]: srsenb_sib.conf.tmpl: add default SIB3
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18788 ) Change subject: srsenb_sib.conf.tmpl: add default SIB3 .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18788 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I329a59d9d0fa3b25bc00b760a455eadbe0b7220f Gerrit-Change-Number: 18788 Gerrit-PatchSet: 1 Gerrit-Owner: srs_andre Gerrit-Reviewer: pespin Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 11 Jun 2020 16:33:00 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-gsm-tester[master]: test: Store brief log per test and use as default report_stdout
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18787 ) Change subject: test: Store brief log per test and use as default report_stdout .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18787 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I0972ba56a42c24f3d3b1bc94bcbdaca86026046a Gerrit-Change-Number: 18787 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 11 Jun 2020 16:30:48 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-gsm-tester[master]: test: Store brief log per test and use as default report_stdout
pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18787 )
Change subject: test: Store brief log per test and use as default report_stdout
..
test: Store brief log per test and use as default report_stdout
Change-Id: I0972ba56a42c24f3d3b1bc94bcbdaca86026046a
---
M src/osmo_gsm_tester/core/log.py
M src/osmo_gsm_tester/core/test.py
M src/osmo_gsm_tester/core/trial.py
3 files changed, 13 insertions(+), 11 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, approved
diff --git a/src/osmo_gsm_tester/core/log.py b/src/osmo_gsm_tester/core/log.py
index f1954d1..b8182f5 100644
--- a/src/osmo_gsm_tester/core/log.py
+++ b/src/osmo_gsm_tester/core/log.py
@@ -46,6 +46,9 @@
C_BUS = 'bus'
C_DEFAULT = '---'
+FILE_LOG = 'log'
+FILE_LOG_BRIEF = 'log_brief'
+
LOG_CTX_VAR = '_log_ctx_'
def dbg(*messages, _origin=None, _category=None, _src=None, **named_items):
diff --git a/src/osmo_gsm_tester/core/test.py b/src/osmo_gsm_tester/core/test.py
index 7e03b6c..47e1f42 100644
--- a/src/osmo_gsm_tester/core/test.py
+++ b/src/osmo_gsm_tester/core/test.py
@@ -46,7 +46,7 @@
self.duration = 0
self.fail_type = None
self.fail_message = None
-self.log_target = None
+self.log_targets = []
self._report_stdout = None
def module_name(self):
@@ -62,7 +62,8 @@
def run(self):
testenv_obj = None
try:
-self.log_target =
log.FileLogTarget(self.get_run_dir().new_child('log')).set_all_levels(log.L_DBG).style_change(trace=True)
+self.log_targets =
[log.FileLogTarget(self.get_run_dir().new_child(log.FILE_LOG)).set_all_levels(log.L_DBG).style_change(trace=True),
+
log.FileLogTarget(self.get_run_dir().new_child(log.FILE_LOG_BRIEF)).style_change(src=False,
all_origins_on_levels=(log.L_ERR, log.L_TRACEBACK))]
log.large_separator(self.suite_run.trial().name(),
self.suite_run.name(), self.name(), sublevel=3)
self.status = Test.UNKNOWN
self.start_timestamp = time.time()
@@ -95,8 +96,8 @@
finally:
if testenv_obj:
testenv_obj.stop()
-if self.log_target:
-self.log_target.remove()
+for log_tgt in self.log_targets:
+log_tgt.remove()
def name(self):
l = log.get_line_for_src(self.path)
@@ -137,9 +138,9 @@
# If test overwrote the text, provide it:
if self._report_stdout is not None:
return self._report_stdout
-# Otherwise vy default provide the entire test log:
-if self.log_target is not None and self.log_target.log_file_path() is
not None:
-with open(self.log_target.log_file_path(), 'r') as myfile:
+# Otherwise vy default provide the entire test brief log:
+if len(self.log_targets) == 2 and self.log_targets[1].log_file_path()
is not None:
+with open(self.log_targets[1].log_file_path(), 'r') as myfile:
return myfile.read()
else:
return 'test log file not available'
diff --git a/src/osmo_gsm_tester/core/trial.py
b/src/osmo_gsm_tester/core/trial.py
index 001421f..3787726 100644
--- a/src/osmo_gsm_tester/core/trial.py
+++ b/src/osmo_gsm_tester/core/trial.py
@@ -32,8 +32,6 @@
FILE_CHECKSUMS = 'checksums.md5'
TIMESTAMP_FMT = '%Y-%m-%d_%H-%M-%S'
FILE_LAST_RUN = 'last_run'
-FILE_LOG = 'log'
-FILE_LOG_BRIEF = 'log_brief'
class Trial(log.Origin):
UNKNOWN = 'UNKNOWN'
@@ -71,12 +69,12 @@
'''add a log target to log to the run dir, write taken marker, log a
starting separator.'''
run_dir = self.get_run_dir()
-detailed_log = run_dir.new_child(FILE_LOG)
+detailed_log = run_dir.new_child(log.FILE_LOG)
self.log_targets = [
log.FileLogTarget(detailed_log)
.set_all_levels(log.L_DBG)
.style_change(trace=True),
-log.FileLogTarget(run_dir.new_child(FILE_LOG_BRIEF))
+log.FileLogTarget(run_dir.new_child(log.FILE_LOG_BRIEF))
.style_change(src=False, all_origins_on_levels=(log.L_ERR,
log.L_TRACEBACK))
]
log.large_separator(self.name(), sublevel=1)
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18787
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I0972ba56a42c24f3d3b1bc94bcbdaca86026046a
Gerrit-Change-Number: 18787
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-gsm-tester[master]: srsenb_sib.conf.tmpl: add default SIB3
srs_andre has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18788 )
Change subject: srsenb_sib.conf.tmpl: add default SIB3
..
srsenb_sib.conf.tmpl: add default SIB3
if SIB3 isn't transmitted, the UE won't do HO and cell reselection
Change-Id: I329a59d9d0fa3b25bc00b760a455eadbe0b7220f
---
M src/osmo_gsm_tester/templates/srsenb_sib.conf.tmpl
1 file changed, 21 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester
refs/changes/88/18788/1
diff --git a/src/osmo_gsm_tester/templates/srsenb_sib.conf.tmpl
b/src/osmo_gsm_tester/templates/srsenb_sib.conf.tmpl
index ecd49e9..6d178c6 100644
--- a/src/osmo_gsm_tester/templates/srsenb_sib.conf.tmpl
+++ b/src/osmo_gsm_tester/templates/srsenb_sib.conf.tmpl
@@ -9,7 +9,7 @@
(
{
si_periodicity = 16;
-si_mapping_info = []; // comma-separated array of SIB-indexes
(from 3 to 13).
+si_mapping_info = [ 3 ]; // comma-separated array of SIB-indexes
(from 3 to 13).
// Leave empty or commented to just scheduler sib2
}
);
@@ -119,3 +119,23 @@
time_alignment_timer = "INFINITY"; // use "sf500", "sf750", etc.
};
+
+sib3 =
+{
+cell_reselection_common = {
+q_hyst = 2; // in dB
+},
+cell_reselection_serving = {
+s_non_intra_search = 3,
+thresh_serving_low = 2,
+cell_resel_prio = 6
+},
+intra_freq_reselection = {
+q_rx_lev_min = -61,
+p_max = 23,
+s_intra_search = 5,
+presence_ant_port_1 = true,
+neigh_cell_cnfg = 1,
+t_resel_eutra = 1
+}
+};
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18788
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I329a59d9d0fa3b25bc00b760a455eadbe0b7220f
Gerrit-Change-Number: 18788
Gerrit-PatchSet: 1
Gerrit-Owner: srs_andre
Gerrit-MessageType: newchange
Change in osmo-gsm-tester[master]: test: Store brief log per test and use as default report_stdout
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18787 )
Change subject: test: Store brief log per test and use as default report_stdout
..
test: Store brief log per test and use as default report_stdout
Change-Id: I0972ba56a42c24f3d3b1bc94bcbdaca86026046a
---
M src/osmo_gsm_tester/core/log.py
M src/osmo_gsm_tester/core/test.py
M src/osmo_gsm_tester/core/trial.py
3 files changed, 13 insertions(+), 11 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester
refs/changes/87/18787/1
diff --git a/src/osmo_gsm_tester/core/log.py b/src/osmo_gsm_tester/core/log.py
index f1954d1..b8182f5 100644
--- a/src/osmo_gsm_tester/core/log.py
+++ b/src/osmo_gsm_tester/core/log.py
@@ -46,6 +46,9 @@
C_BUS = 'bus'
C_DEFAULT = '---'
+FILE_LOG = 'log'
+FILE_LOG_BRIEF = 'log_brief'
+
LOG_CTX_VAR = '_log_ctx_'
def dbg(*messages, _origin=None, _category=None, _src=None, **named_items):
diff --git a/src/osmo_gsm_tester/core/test.py b/src/osmo_gsm_tester/core/test.py
index 7e03b6c..47e1f42 100644
--- a/src/osmo_gsm_tester/core/test.py
+++ b/src/osmo_gsm_tester/core/test.py
@@ -46,7 +46,7 @@
self.duration = 0
self.fail_type = None
self.fail_message = None
-self.log_target = None
+self.log_targets = []
self._report_stdout = None
def module_name(self):
@@ -62,7 +62,8 @@
def run(self):
testenv_obj = None
try:
-self.log_target =
log.FileLogTarget(self.get_run_dir().new_child('log')).set_all_levels(log.L_DBG).style_change(trace=True)
+self.log_targets =
[log.FileLogTarget(self.get_run_dir().new_child(log.FILE_LOG)).set_all_levels(log.L_DBG).style_change(trace=True),
+
log.FileLogTarget(self.get_run_dir().new_child(log.FILE_LOG_BRIEF)).style_change(src=False,
all_origins_on_levels=(log.L_ERR, log.L_TRACEBACK))]
log.large_separator(self.suite_run.trial().name(),
self.suite_run.name(), self.name(), sublevel=3)
self.status = Test.UNKNOWN
self.start_timestamp = time.time()
@@ -95,8 +96,8 @@
finally:
if testenv_obj:
testenv_obj.stop()
-if self.log_target:
-self.log_target.remove()
+for log_tgt in self.log_targets:
+log_tgt.remove()
def name(self):
l = log.get_line_for_src(self.path)
@@ -137,9 +138,9 @@
# If test overwrote the text, provide it:
if self._report_stdout is not None:
return self._report_stdout
-# Otherwise vy default provide the entire test log:
-if self.log_target is not None and self.log_target.log_file_path() is
not None:
-with open(self.log_target.log_file_path(), 'r') as myfile:
+# Otherwise vy default provide the entire test brief log:
+if len(self.log_targets) == 2 and self.log_targets[1].log_file_path()
is not None:
+with open(self.log_targets[1].log_file_path(), 'r') as myfile:
return myfile.read()
else:
return 'test log file not available'
diff --git a/src/osmo_gsm_tester/core/trial.py
b/src/osmo_gsm_tester/core/trial.py
index 001421f..3787726 100644
--- a/src/osmo_gsm_tester/core/trial.py
+++ b/src/osmo_gsm_tester/core/trial.py
@@ -32,8 +32,6 @@
FILE_CHECKSUMS = 'checksums.md5'
TIMESTAMP_FMT = '%Y-%m-%d_%H-%M-%S'
FILE_LAST_RUN = 'last_run'
-FILE_LOG = 'log'
-FILE_LOG_BRIEF = 'log_brief'
class Trial(log.Origin):
UNKNOWN = 'UNKNOWN'
@@ -71,12 +69,12 @@
'''add a log target to log to the run dir, write taken marker, log a
starting separator.'''
run_dir = self.get_run_dir()
-detailed_log = run_dir.new_child(FILE_LOG)
+detailed_log = run_dir.new_child(log.FILE_LOG)
self.log_targets = [
log.FileLogTarget(detailed_log)
.set_all_levels(log.L_DBG)
.style_change(trace=True),
-log.FileLogTarget(run_dir.new_child(FILE_LOG_BRIEF))
+log.FileLogTarget(run_dir.new_child(log.FILE_LOG_BRIEF))
.style_change(src=False, all_origins_on_levels=(log.L_ERR,
log.L_TRACEBACK))
]
log.large_separator(self.name(), sublevel=1)
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18787
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I0972ba56a42c24f3d3b1bc94bcbdaca86026046a
Gerrit-Change-Number: 18787
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
Gerrit-MessageType: newchange
Change in osmo-gsm-tester[master]: suites/4g: Wait for IP addr received before trying to use the link
pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18785 )
Change subject: suites/4g: Wait for IP addr received before trying to use the
link
..
suites/4g: Wait for IP addr received before trying to use the link
Otherwise processes using the link like "ping" or "iperf3" may fail
because there's still no IP address assigned.
Change-Id: I28137f10a19db01fe90b24830a60342a448d1e92
---
M sysmocom/suites/4g/handover.py
M sysmocom/suites/4g/iperf3_dl.py
M sysmocom/suites/4g/iperf3_ul.py
M sysmocom/suites/4g/ping.py
M sysmocom/suites/4g/rrc_idle_mo_ping.py
M sysmocom/suites/4g/rrc_idle_mt_ping.py
6 files changed, 6 insertions(+), 6 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, approved
diff --git a/sysmocom/suites/4g/handover.py b/sysmocom/suites/4g/handover.py
index bc49266..8bfb585 100755
--- a/sysmocom/suites/4g/handover.py
+++ b/sysmocom/suites/4g/handover.py
@@ -46,7 +46,7 @@
proc = iperf3cli.prepare_test_proc(iperf3cli.DIR_UL, ue.netns(), duration + 30)
print('waiting for UE to attach...')
-wait(ue.is_rrc_connected)
+wait(ue.is_registered)
print('UE is attached')
rfemu_cell1 = enb.get_rfemu(0)
diff --git a/sysmocom/suites/4g/iperf3_dl.py b/sysmocom/suites/4g/iperf3_dl.py
index 055ce97..26df79b 100755
--- a/sysmocom/suites/4g/iperf3_dl.py
+++ b/sysmocom/suites/4g/iperf3_dl.py
@@ -26,7 +26,7 @@
proc = iperf3cli.prepare_test_proc(iperf3cli.DIR_DL, ue.netns(),
bitrate=max_rate)
print('waiting for UE to attach...')
-wait(ue.is_rrc_connected)
+wait(ue.is_registered)
print('UE is attached')
print("Running iperf3 client to %s through %s" % (str(iperf3cli), ue.netns()))
diff --git a/sysmocom/suites/4g/iperf3_ul.py b/sysmocom/suites/4g/iperf3_ul.py
index 6e24070..15cde95 100755
--- a/sysmocom/suites/4g/iperf3_ul.py
+++ b/sysmocom/suites/4g/iperf3_ul.py
@@ -26,7 +26,7 @@
proc = iperf3cli.prepare_test_proc(iperf3cli.DIR_UL, ue.netns(),
bitrate=max_rate)
print('waiting for UE to attach...')
-wait(ue.is_rrc_connected)
+wait(ue.is_registered)
print('UE is attached')
print("Running iperf3 client to %s through %s" % (str(iperf3cli), ue.netns()))
diff --git a/sysmocom/suites/4g/ping.py b/sysmocom/suites/4g/ping.py
index 0fb2edb..0297317 100755
--- a/sysmocom/suites/4g/ping.py
+++ b/sysmocom/suites/4g/ping.py
@@ -16,7 +16,7 @@
ue.connect(enb)
print('waiting for UE to attach...')
-wait(ue.is_rrc_connected)
+wait(ue.is_registered)
print('UE is attached')
proc = ue.run_netns_wait('ping', ('ping', '-c', '10', epc.tun_addr()))
diff --git a/sysmocom/suites/4g/rrc_idle_mo_ping.py
b/sysmocom/suites/4g/rrc_idle_mo_ping.py
index de643df..ced798d 100755
--- a/sysmocom/suites/4g/rrc_idle_mo_ping.py
+++ b/sysmocom/suites/4g/rrc_idle_mo_ping.py
@@ -16,7 +16,7 @@
ue.connect(enb)
print('waiting for UE to attach...')
-wait(ue.is_rrc_connected)
+wait(ue.is_registered)
print('UE is RRC connected')
print('waiting until RRC connection gets released...')
diff --git a/sysmocom/suites/4g/rrc_idle_mt_ping.py
b/sysmocom/suites/4g/rrc_idle_mt_ping.py
index 7caba32..fb3c32c 100755
--- a/sysmocom/suites/4g/rrc_idle_mt_ping.py
+++ b/sysmocom/suites/4g/rrc_idle_mt_ping.py
@@ -16,7 +16,7 @@
ue.connect(enb)
print('waiting for UE to attach...')
-wait(ue.is_rrc_connected)
+wait(ue.is_registered)
print('UE is RRC connected')
print('waiting until RRC connection gets released...')
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18785
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I28137f10a19db01fe90b24830a60342a448d1e92
Gerrit-Change-Number: 18785
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-gsm-tester[master]: suites/4g: Wait for IP addr received before trying to use the link
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18785 ) Change subject: suites/4g: Wait for IP addr received before trying to use the link .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18785 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I28137f10a19db01fe90b24830a60342a448d1e92 Gerrit-Change-Number: 18785 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 11 Jun 2020 15:31:11 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in docker-playground[master]: osmo-gsm-tester: Update resources.conf syntax changes
pespin has submitted this change. (
https://gerrit.osmocom.org/c/docker-playground/+/18786 )
Change subject: osmo-gsm-tester: Update resources.conf syntax changes
..
osmo-gsm-tester: Update resources.conf syntax changes
Change-Id: Iaa3e43d6878933b1f01026d58b01b1009fe4cd78
---
M osmo-gsm-tester/jenkins.sh
M osmo-gsm-tester/resources.conf
2 files changed, 11 insertions(+), 5 deletions(-)
Approvals:
pespin: Looks good to me, approved; Verified
diff --git a/osmo-gsm-tester/jenkins.sh b/osmo-gsm-tester/jenkins.sh
index 64de38f..a198608 100755
--- a/osmo-gsm-tester/jenkins.sh
+++ b/osmo-gsm-tester/jenkins.sh
@@ -81,7 +81,7 @@
echo Starting container with osmo-gsm-tester main unit
OSMO_GSM_TESTER_CONF=${OSMO_GSM_TESTER_CONF:-/tmp/osmo-gsm-tester/sysmocom/main.conf}
-OSMO_GSM_TESTER_OPTS=${OSMO_GSM_TESTER_OPTS:--T -l dbg -s
4g:srsenb-rftype@zmq+srsue-rftype@zmq -t ping}
+OSMO_GSM_TESTER_OPTS=${OSMO_GSM_TESTER_OPTS:--T -l dbg -s
4g:srsue-rftype@zmq+srsenb-rftype@zmq+mod-enb-nprb@6 -t =ping.py}
docker run --rm \
--cap-add=NET_ADMIN \
--cap-add=SYS_ADMIN \
diff --git a/osmo-gsm-tester/resources.conf b/osmo-gsm-tester/resources.conf
index a687edb..22ff85e 100644
--- a/osmo-gsm-tester/resources.conf
+++ b/osmo-gsm-tester/resources.conf
@@ -37,8 +37,11 @@
- label: srsENB-zmq
type: srsenb
rf_dev_type: zmq
- remote_user: jenkins
- addr: 172.18.50.101
+ run_node:
+run_type: ssh
+run_addr: 172.18.50.101
+ssh_user: jenkins
+ssh_addr: 172.18.50.101
arfcn:
- arfcn: 512
@@ -55,9 +58,12 @@
- label: srsUE-zmq_1
type: srsue
rf_dev_type: zmq
- remote_user: jenkins
- addr: 172.18.50.100
imsi: '001010123456789'
ki: '00112233445566778899aabbccddeeff'
auth_algo: 'xor'
features: ['4g']
+ run_node:
+run_type: ssh
+run_addr: 172.18.50.100
+ssh_user: jenkins
+ssh_addr: 172.18.50.100
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/18786
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: Iaa3e43d6878933b1f01026d58b01b1009fe4cd78
Gerrit-Change-Number: 18786
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in docker-playground[master]: osmo-gsm-tester: Update resources.conf syntax changes
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/18786 ) Change subject: osmo-gsm-tester: Update resources.conf syntax changes .. Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/18786 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Iaa3e43d6878933b1f01026d58b01b1009fe4cd78 Gerrit-Change-Number: 18786 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 11 Jun 2020 15:17:40 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in docker-playground[master]: osmo-gsm-tester: Update resources.conf syntax changes
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/docker-playground/+/18786 )
Change subject: osmo-gsm-tester: Update resources.conf syntax changes
..
osmo-gsm-tester: Update resources.conf syntax changes
Change-Id: Iaa3e43d6878933b1f01026d58b01b1009fe4cd78
---
M osmo-gsm-tester/jenkins.sh
M osmo-gsm-tester/resources.conf
2 files changed, 11 insertions(+), 5 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/docker-playground
refs/changes/86/18786/1
diff --git a/osmo-gsm-tester/jenkins.sh b/osmo-gsm-tester/jenkins.sh
index 64de38f..a198608 100755
--- a/osmo-gsm-tester/jenkins.sh
+++ b/osmo-gsm-tester/jenkins.sh
@@ -81,7 +81,7 @@
echo Starting container with osmo-gsm-tester main unit
OSMO_GSM_TESTER_CONF=${OSMO_GSM_TESTER_CONF:-/tmp/osmo-gsm-tester/sysmocom/main.conf}
-OSMO_GSM_TESTER_OPTS=${OSMO_GSM_TESTER_OPTS:--T -l dbg -s
4g:srsenb-rftype@zmq+srsue-rftype@zmq -t ping}
+OSMO_GSM_TESTER_OPTS=${OSMO_GSM_TESTER_OPTS:--T -l dbg -s
4g:srsue-rftype@zmq+srsenb-rftype@zmq+mod-enb-nprb@6 -t =ping.py}
docker run --rm \
--cap-add=NET_ADMIN \
--cap-add=SYS_ADMIN \
diff --git a/osmo-gsm-tester/resources.conf b/osmo-gsm-tester/resources.conf
index a687edb..22ff85e 100644
--- a/osmo-gsm-tester/resources.conf
+++ b/osmo-gsm-tester/resources.conf
@@ -37,8 +37,11 @@
- label: srsENB-zmq
type: srsenb
rf_dev_type: zmq
- remote_user: jenkins
- addr: 172.18.50.101
+ run_node:
+run_type: ssh
+run_addr: 172.18.50.101
+ssh_user: jenkins
+ssh_addr: 172.18.50.101
arfcn:
- arfcn: 512
@@ -55,9 +58,12 @@
- label: srsUE-zmq_1
type: srsue
rf_dev_type: zmq
- remote_user: jenkins
- addr: 172.18.50.100
imsi: '001010123456789'
ki: '00112233445566778899aabbccddeeff'
auth_algo: 'xor'
features: ['4g']
+ run_node:
+run_type: ssh
+run_addr: 172.18.50.100
+ssh_user: jenkins
+ssh_addr: 172.18.50.100
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/18786
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: Iaa3e43d6878933b1f01026d58b01b1009fe4cd78
Gerrit-Change-Number: 18786
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
Gerrit-MessageType: newchange
Change in osmo-gsm-tester[master]: suites/4g: Wait for IP addr received before trying to use the link
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18785 )
Change subject: suites/4g: Wait for IP addr received before trying to use the
link
..
suites/4g: Wait for IP addr received before trying to use the link
Otherwise processes using the link like "ping" or "iperf3" may fail
because there's still no IP address assigned.
Change-Id: I28137f10a19db01fe90b24830a60342a448d1e92
---
M sysmocom/suites/4g/handover.py
M sysmocom/suites/4g/iperf3_dl.py
M sysmocom/suites/4g/iperf3_ul.py
M sysmocom/suites/4g/ping.py
M sysmocom/suites/4g/rrc_idle_mo_ping.py
M sysmocom/suites/4g/rrc_idle_mt_ping.py
6 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester
refs/changes/85/18785/1
diff --git a/sysmocom/suites/4g/handover.py b/sysmocom/suites/4g/handover.py
index bc49266..8bfb585 100755
--- a/sysmocom/suites/4g/handover.py
+++ b/sysmocom/suites/4g/handover.py
@@ -46,7 +46,7 @@
proc = iperf3cli.prepare_test_proc(iperf3cli.DIR_UL, ue.netns(), duration + 30)
print('waiting for UE to attach...')
-wait(ue.is_rrc_connected)
+wait(ue.is_registered)
print('UE is attached')
rfemu_cell1 = enb.get_rfemu(0)
diff --git a/sysmocom/suites/4g/iperf3_dl.py b/sysmocom/suites/4g/iperf3_dl.py
index 055ce97..26df79b 100755
--- a/sysmocom/suites/4g/iperf3_dl.py
+++ b/sysmocom/suites/4g/iperf3_dl.py
@@ -26,7 +26,7 @@
proc = iperf3cli.prepare_test_proc(iperf3cli.DIR_DL, ue.netns(),
bitrate=max_rate)
print('waiting for UE to attach...')
-wait(ue.is_rrc_connected)
+wait(ue.is_registered)
print('UE is attached')
print("Running iperf3 client to %s through %s" % (str(iperf3cli), ue.netns()))
diff --git a/sysmocom/suites/4g/iperf3_ul.py b/sysmocom/suites/4g/iperf3_ul.py
index 6e24070..15cde95 100755
--- a/sysmocom/suites/4g/iperf3_ul.py
+++ b/sysmocom/suites/4g/iperf3_ul.py
@@ -26,7 +26,7 @@
proc = iperf3cli.prepare_test_proc(iperf3cli.DIR_UL, ue.netns(),
bitrate=max_rate)
print('waiting for UE to attach...')
-wait(ue.is_rrc_connected)
+wait(ue.is_registered)
print('UE is attached')
print("Running iperf3 client to %s through %s" % (str(iperf3cli), ue.netns()))
diff --git a/sysmocom/suites/4g/ping.py b/sysmocom/suites/4g/ping.py
index 0fb2edb..0297317 100755
--- a/sysmocom/suites/4g/ping.py
+++ b/sysmocom/suites/4g/ping.py
@@ -16,7 +16,7 @@
ue.connect(enb)
print('waiting for UE to attach...')
-wait(ue.is_rrc_connected)
+wait(ue.is_registered)
print('UE is attached')
proc = ue.run_netns_wait('ping', ('ping', '-c', '10', epc.tun_addr()))
diff --git a/sysmocom/suites/4g/rrc_idle_mo_ping.py
b/sysmocom/suites/4g/rrc_idle_mo_ping.py
index de643df..ced798d 100755
--- a/sysmocom/suites/4g/rrc_idle_mo_ping.py
+++ b/sysmocom/suites/4g/rrc_idle_mo_ping.py
@@ -16,7 +16,7 @@
ue.connect(enb)
print('waiting for UE to attach...')
-wait(ue.is_rrc_connected)
+wait(ue.is_registered)
print('UE is RRC connected')
print('waiting until RRC connection gets released...')
diff --git a/sysmocom/suites/4g/rrc_idle_mt_ping.py
b/sysmocom/suites/4g/rrc_idle_mt_ping.py
index 7caba32..fb3c32c 100755
--- a/sysmocom/suites/4g/rrc_idle_mt_ping.py
+++ b/sysmocom/suites/4g/rrc_idle_mt_ping.py
@@ -16,7 +16,7 @@
ue.connect(enb)
print('waiting for UE to attach...')
-wait(ue.is_rrc_connected)
+wait(ue.is_registered)
print('UE is RRC connected')
print('waiting until RRC connection gets released...')
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18785
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I28137f10a19db01fe90b24830a60342a448d1e92
Gerrit-Change-Number: 18785
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
Gerrit-MessageType: newchange
Change in osmo-gsm-tester[master]: testenv: Add debug log when overlaying templates dir
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18784 ) Change subject: testenv: Add debug log when overlaying templates dir .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18784 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I10fdfc5b2e3bf4c96941a3fae53230131f384de9 Gerrit-Change-Number: 18784 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 11 Jun 2020 15:08:26 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-gsm-tester[master]: testenv: Add debug log when overlaying templates dir
pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18784 )
Change subject: testenv: Add debug log when overlaying templates dir
..
testenv: Add debug log when overlaying templates dir
Change-Id: I10fdfc5b2e3bf4c96941a3fae53230131f384de9
---
M selftest/suite_test/suite_test.ok
M src/osmo_gsm_tester/testenv.py
2 files changed, 4 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, approved
diff --git a/selftest/suite_test/suite_test.ok
b/selftest/suite_test/suite_test.ok
index a7c6422..9c9f5cc 100644
--- a/selftest/suite_test/suite_test.ok
+++ b/selftest/suite_test/suite_test.ok
@@ -639,8 +639,10 @@
trial suiteC test_template_overlay.py
--
tst test_template_overlay.py:[LINENR]: - Testing: expect to fail on invalid
templates overlay dir [suiteC↪test_template_overlay.py:[LINENR]]
[test_template_overlay.py:[LINENR]]
+tst test_template_overlay.py:[LINENR] DBG: template dir overlay set:
[PATH]/selftest/suite_test/suitedirB/suiteC/nonexistent-templatedir
[suiteC↪test_template_overlay.py:[LINENR]↪test_template_overlay.py]
[testenv.py:[LINENR]]
tst test_template_overlay.py:[LINENR]: sucess: setting non-existing templates
dir raised RuntimeError [suiteC↪test_template_overlay.py:[LINENR]]
[test_template_overlay.py:[LINENR]]
tst test_template_overlay.py:[LINENR]:
[suiteC↪test_template_overlay.py:[LINENR]] [test_template_overlay.py:[LINENR]]
+tst test_template_overlay.py:[LINENR] DBG: template dir overlay set:
[PATH]/selftest/suite_test/suitedirB/suiteC/mytemplatedir
[suiteC↪test_template_overlay.py:[LINENR]↪test_template_overlay.py]
[testenv.py:[LINENR]]
--- ReservedResources: DBG: requesting use of ip_address {specifics={}}
[resource.py:[LINENR]]
tst suiteC: Using 1 x ip_address (candidates: 1) [resource.py:[LINENR]]
tst suiteC: DBG: Picked - _hash: fd103b22c7cf2480d609150e06f4bbd92ac78d8c
@@ -705,6 +707,7 @@
local-ip 10.42.42.2
[suiteC↪test_template_overlay.py:[LINENR]↪test_template_overlay.py↪osmo-stp_10.42.42.2]
[stp_osmo.py:[LINENR]]
tst test_template_overlay.py:[LINENR]: - New template is used after
re-generating cache with set_overlay_template_dir:
[suiteC↪test_template_overlay.py:[LINENR]] [test_template_overlay.py:[LINENR]]
+tst test_template_overlay.py:[LINENR] DBG: template dir overlay set:
[PATH]/selftest/suite_test/suitedirB/suiteC/mytemplatedir
[suiteC↪test_template_overlay.py:[LINENR]↪test_template_overlay.py]
[testenv.py:[LINENR]]
run osmo-stp_10.42.42.2: DBG:
{config_file='test_trial_tmp/test_run_6/suiteC/test_template_overlay.py/osmo-stp_10.42.42_3.2/osmo-stp.cfg'}
[suiteC↪test_template_overlay.py:[LINENR]↪test_template_overlay.py↪osmo-stp_10.42.42.2]
[stp_osmo.py:[LINENR]]
run osmo-stp_10.42.42.2: DBG: STP CONFIG:
{'stp': {'ip_address': {'_hash': 'fd103b22c7cf2480d609150e06f4bbd92ac78d8c',
diff --git a/src/osmo_gsm_tester/testenv.py b/src/osmo_gsm_tester/testenv.py
index 4709b4c..d6c18ee 100644
--- a/src/osmo_gsm_tester/testenv.py
+++ b/src/osmo_gsm_tester/testenv.py
@@ -154,6 +154,7 @@
if template_dir is None:
template.set_templates_dir(template.default_templates_dir())
else:
+self.dbg('template dir overlay set: %s' % template_dir)
template.set_templates_dir(template_dir,
template.default_templates_dir())
def prompt(self, *msgs, **msg_details):
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18784
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I10fdfc5b2e3bf4c96941a3fae53230131f384de9
Gerrit-Change-Number: 18784
Gerrit-PatchSet: 2
Gerrit-Owner: pespin
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-trx[master]: Transceiver: Implement TRXC cmd NOMTXPOWER
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/18586 ) Change subject: Transceiver: Implement TRXC cmd NOMTXPOWER .. Patch Set 2: Code-Review+1 (2 comments) https://gerrit.osmocom.org/c/osmo-trx/+/18586/2/Transceiver52M/Transceiver.cpp File Transceiver52M/Transceiver.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/18586/2/Transceiver52M/Transceiver.cpp@910 PS2, Line 910: %d", -power Rather return it the same as was received. https://gerrit.osmocom.org/c/osmo-trx/+/18586/2/Transceiver52M/device/lms/LMSDevice.cpp File Transceiver52M/device/lms/LMSDevice.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/18586/2/Transceiver52M/device/lms/LMSDevice.cpp@535 PS2, Line 535: TODO It's more like FIXME... -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/18586 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I1d7efe56e008d8d60e23f9a85aa40809f7f84d9c Gerrit-Change-Number: 18586 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Reviewer: roh Gerrit-Comment-Date: Thu, 11 Jun 2020 15:04:28 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: RAN_Emulation: allow sending UnitData from MSC_ConnHdlr
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18762 ) Change subject: RAN_Emulation: allow sending UnitData from MSC_ConnHdlr .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18762 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I36d486db05169b0fc3f19112b5a9008248d62930 Gerrit-Change-Number: 18762 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 11 Jun 2020 14:53:58 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: RSL_Emulation: fix rx of tr_RSL_PAGING_CMD()
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18761 ) Change subject: RSL_Emulation: fix rx of tr_RSL_PAGING_CMD() .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18761 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iaf7730153a3a19e448a33298c3e12212a55929d5 Gerrit-Change-Number: 18761 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 11 Jun 2020 14:52:34 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: bsc: allow multiple MSCs
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18760 ) Change subject: bsc: allow multiple MSCs .. Patch Set 2: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18760/2/bsc/BSC_Tests.ttcn File bsc/BSC_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18760/2/bsc/BSC_Tests.ttcn@374 PS2, Line 374: * \param Would be good to have description for the new parameter too, like "Number of MSCs we should start/bring up" or so. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18760 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibb36695b7c31f7b04eec6c5d59522fc0779b3c2f Gerrit-Change-Number: 18760 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 11 Jun 2020 14:50:33 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-gsm-tester[master]: testenv: Add debug log when overlaying templates dir
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18784 to look at the new patch set (#2). Change subject: testenv: Add debug log when overlaying templates dir .. testenv: Add debug log when overlaying templates dir Change-Id: I10fdfc5b2e3bf4c96941a3fae53230131f384de9 --- M selftest/suite_test/suite_test.ok M src/osmo_gsm_tester/testenv.py 2 files changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/84/18784/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18784 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I10fdfc5b2e3bf4c96941a3fae53230131f384de9 Gerrit-Change-Number: 18784 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset
Change in osmo-gsm-tester[master]: testenv: Add debug log when overlaying templates dir
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18784 )
Change subject: testenv: Add debug log when overlaying templates dir
..
testenv: Add debug log when overlaying templates dir
Change-Id: I10fdfc5b2e3bf4c96941a3fae53230131f384de9
---
M src/osmo_gsm_tester/testenv.py
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester
refs/changes/84/18784/1
diff --git a/src/osmo_gsm_tester/testenv.py b/src/osmo_gsm_tester/testenv.py
index 4709b4c..d6c18ee 100644
--- a/src/osmo_gsm_tester/testenv.py
+++ b/src/osmo_gsm_tester/testenv.py
@@ -154,6 +154,7 @@
if template_dir is None:
template.set_templates_dir(template.default_templates_dir())
else:
+self.dbg('template dir overlay set: %s' % template_dir)
template.set_templates_dir(template_dir,
template.default_templates_dir())
def prompt(self, *msgs, **msg_details):
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18784
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I10fdfc5b2e3bf4c96941a3fae53230131f384de9
Gerrit-Change-Number: 18784
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
Gerrit-MessageType: newchange
Change in osmo-mgw[master]: trunk: parse E1 trunk number
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18752 ) Change subject: trunk: parse E1 trunk number .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-mgw/+/18752/2/src/libosmo-mgcp/mgcp_trunk.c File src/libosmo-mgcp/mgcp_trunk.c: https://gerrit.osmocom.org/c/osmo-mgw/+/18752/2/src/libosmo-mgcp/mgcp_trunk.c@138 PS2, Line 138: prefix_len = sizeof(MGCP_ENDPOINT_PREFIX_E1_TRUNK) - 1; > wait, what, sizeof() works on compile time char constants? wow. […] I guess that's perfectly fine, since a string constant is simply a array of chars with length known at compile time. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/18752 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ifdaab953544151e73b58cc3e95d21afdb40765f4 Gerrit-Change-Number: 18752 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 11 Jun 2020 13:52:11 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels Gerrit-MessageType: comment
Change in osmo-gsm-manuals[master]: bibliography, glossary: add MSC pooling related bits
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/18780 ) Change subject: bibliography, glossary: add MSC pooling related bits .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/18780 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I0640db26dc85ab7723c7160e405fc73f412fd706 Gerrit-Change-Number: 18780 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 11 Jun 2020 13:53:03 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: add gsm23236: MSC pooling: TMSI and NRI utility functions
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18506 ) Change subject: add gsm23236: MSC pooling: TMSI and NRI utility functions .. Patch Set 10: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18506 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icb57a2dd9323c7ea11b34003eccc7e68a0247bf5 Gerrit-Change-Number: 18506 Gerrit-PatchSet: 10 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 11 Jun 2020 13:48:24 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in docker-playground[master]: MSC_Tests.cfg: tweak comments
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/18776 ) Change subject: MSC_Tests.cfg: tweak comments .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/18776 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If5f9cff03f078987c5b9051f8d63c239bf92ddb7 Gerrit-Change-Number: 18776 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 11 Jun 2020 13:43:25 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in docker-playground[master]: bsc: adjust osmo-bsc.cfg for MSC pooling tests
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/18775 ) Change subject: bsc: adjust osmo-bsc.cfg for MSC pooling tests .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/18775 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I353a2023d41d9f083acdd61da11109cb5a002f9b Gerrit-Change-Number: 18775 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 11 Jun 2020 13:43:12 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in docker-playground[master]: BSC_Tests.cfg: adjust cfg for multiple MSCs
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/18774 ) Change subject: BSC_Tests.cfg: adjust cfg for multiple MSCs .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/18774 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I1986e4ef43beee161c82193694421b56136c1afe Gerrit-Change-Number: 18774 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 11 Jun 2020 13:42:43 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-sgsn[master]: use new osmo_mobile_identity API everywhere
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/18716 ) Change subject: use new osmo_mobile_identity API everywhere .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/18716 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I4cacb10bac419633ca0c14f244f9903f7f517b49 Gerrit-Change-Number: 18716 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 11 Jun 2020 13:41:57 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-msc[master]: add rudimentary NRI support for MSC pooling
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/18770 ) Change subject: add rudimentary NRI support for MSC pooling .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/18770 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Iafe0878a0a2c8669080d757b34a398ea75fced36 Gerrit-Change-Number: 18770 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 11 Jun 2020 13:40:08 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-msc[master]: use new osmo_mobile_identity API everywhere
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/18715 ) Change subject: use new osmo_mobile_identity API everywhere .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-msc/+/18715/2/include/osmocom/msc/msub.h File include/osmocom/msc/msub.h: https://gerrit.osmocom.org/c/osmo-msc/+/18715/2/include/osmocom/msc/msub.h@11 PS2, Line 11: struct osmo_mobile_identity; Will we end up with a list of 100 types here, not knowing even where are they really defined? -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/18715 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Idfc8e576e10756aeaacf5569f6178068313eb7ea Gerrit-Change-Number: 18715 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 11 Jun 2020 13:35:38 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-msc[master]: msc_vlr_test_gsm_ciph.c: fix IMEISV MI: even number of digits, clear ...
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/18714 ) Change subject: msc_vlr_test_gsm_ciph.c: fix IMEISV MI: even number of digits, clear odd bit .. Patch Set 1: There's context lacking here. How can it be that a test was failing before and needs to be changed? -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/18714 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ib1d54c59acc8b716de471ca275f54f9d22da3574 Gerrit-Change-Number: 18714 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 11 Jun 2020 13:34:16 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-bsc[master]: log: add MSC number to bsc_subscr_conn_fsm id
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18768 ) Change subject: log: add MSC number to bsc_subscr_conn_fsm id .. Patch Set 4: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/18768/4/src/osmo-bsc/bsc_subscr_conn_fsm.c File src/osmo-bsc/bsc_subscr_conn_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/18768/4/src/osmo-bsc/bsc_subscr_conn_fsm.c@1071 PS4, Line 1071: conn->sccp.msc->nr, Are we sure msc is always non NULL here? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18768 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iae232d0616d6c0009e3abe2dcfcb9c51ddfc761e Gerrit-Change-Number: 18768 Gerrit-PatchSet: 4 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 11 Jun 2020 13:32:10 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: debug: log about matching Paging Response to earlier Paging
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18769 ) Change subject: debug: log about matching Paging Response to earlier Paging .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18769 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I277d3236686dd5a5a21113ef2ddfd29341190086 Gerrit-Change-Number: 18769 Gerrit-PatchSet: 4 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 11 Jun 2020 13:32:40 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: vty: add 'mscpool roundrobin next' for ttcn3 tests
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18767 ) Change subject: vty: add 'mscpool roundrobin next' for ttcn3 tests .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18767 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2155d906505a26744966f442ffb1e87a6a9b494c Gerrit-Change-Number: 18767 Gerrit-PatchSet: 4 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 11 Jun 2020 13:31:23 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: mscpool: add user manual chapter
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18779 ) Change subject: mscpool: add user manual chapter .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18779 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia60afc8a91189c9de0d8e8065781ed463bf18d7e Gerrit-Change-Number: 18779 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 11 Jun 2020 13:30:32 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: move type RAN_Configurations to RAN_Adapter.ttcnpp
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18759 ) Change subject: move type RAN_Configurations to RAN_Adapter.ttcnpp .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18759 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If8f7fd50a88302af645ab337a907d8f0ad79a306 Gerrit-Change-Number: 18759 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 11 Jun 2020 12:33:41 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: MSC pooling: add 'no allow-attach' for MSC off-loading
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18778 ) Change subject: MSC pooling: add 'no allow-attach' for MSC off-loading .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/18778/2/src/osmo-bsc/gsm_08_08.c File src/osmo-bsc/gsm_08_08.c: https://gerrit.osmocom.org/c/osmo-bsc/+/18778/2/src/osmo-bsc/gsm_08_08.c@286 PS2, Line 286: if (!msc->allow_attach) Should you check this above? Otherwise if NRI matches it will still use it even if administratively disabled. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18778 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6249201c15d0f6565aca643c21d2375c9ca58584 Gerrit-Change-Number: 18778 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 11 Jun 2020 12:15:38 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-bsc[master]: MSC pooling: LU: ignore TMSI NRI from a different PLMN
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18783 ) Change subject: MSC pooling: LU: ignore TMSI NRI from a different PLMN .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18783 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iac1158cff022b6365ce22bb70feaaff93e39172a Gerrit-Change-Number: 18783 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 11 Jun 2020 12:13:34 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: MSC pooling: implement NAS node selection by NRI from TMSI
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18766 ) Change subject: MSC pooling: implement NAS node selection by NRI from TMSI .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18766 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ifbdea197b26e88751a391c8a80c41f04e7d5e047 Gerrit-Change-Number: 18766 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 11 Jun 2020 12:10:32 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: MSC pooling: make NRI mappings VTY configurable
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18765 ) Change subject: MSC pooling: make NRI mappings VTY configurable .. Patch Set 2: Code-Review-1 (2 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/18765/2/include/osmocom/bsc/bsc_msc_data.h File include/osmocom/bsc/bsc_msc_data.h: https://gerrit.osmocom.org/c/osmo-bsc/+/18765/2/include/osmocom/bsc/bsc_msc_data.h@195 PS2, Line 195: extra whitespace not needed. https://gerrit.osmocom.org/c/osmo-bsc/+/18765/2/src/osmo-bsc/bsc_vty.c File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/18765/2/src/osmo-bsc/bsc_vty.c@1166 PS2, Line 1166: vty_out(vty, " %% INVALID:"); This place doesn't look like the correct one to do this kind of checks and print this kind of warnings. I would expect this invalid setup should be checked during input parsing. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18765 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6c251f2744d7be26fc4ad74adefc96a6a3fe08b0 Gerrit-Change-Number: 18765 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 11 Jun 2020 12:05:10 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: tweak log category for Compl L3 error
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18764 ) Change subject: tweak log category for Compl L3 error .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18764 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I9c6373e5f28c9c69a0609889188ef28ade11da3d Gerrit-Change-Number: 18764 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 11 Jun 2020 11:58:34 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: use osmo_mobile_identity API everywhere
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18713 ) Change subject: use osmo_mobile_identity API everywhere .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18713 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I71c3b4c65dbfdfa51409e09d4868aea83225338a Gerrit-Change-Number: 18713 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 11 Jun 2020 11:57:09 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: bsc: add MSC pooling tests
Hello pespin, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18763
to look at the new patch set (#2).
Change subject: bsc: add MSC pooling tests
..
bsc: add MSC pooling tests
The MSC pooling feature is implemented in osmo-bsc
Ifbdea197b26e88751a391c8a80c41f04e7d5e047.
A VTY command ('mscpool roundrobin next') that allows deterministic testing is
added in I2155d906505a26744966f442ffb1e87a6a9b494c.
osmo-bsc.cfg changes needed for these tests to succeed are in docker-playground
I1986e4ef43beee161c82193694421b56136c1afe
The new tests will fail until the above have been merged.
Change-Id: I21cbab193cd0de2e5692665442eae113d5f61904
---
M bsc/BSC_Tests.ttcn
M bsc/MSC_ConnectionHandler.ttcn
M library/L3_Templates.ttcn
3 files changed, 917 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/63/18763/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18763
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I21cbab193cd0de2e5692665442eae113d5f61904
Gerrit-Change-Number: 18763
Gerrit-PatchSet: 2
Gerrit-Owner: neels
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin
Gerrit-MessageType: newpatchset
Change in osmo-bsc[master]: MSC pooling: LU: ignore TMSI NRI from a different PLMN
neels has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-bsc/+/18783 )
Change subject: MSC pooling: LU: ignore TMSI NRI from a different PLMN
..
MSC pooling: LU: ignore TMSI NRI from a different PLMN
Change-Id: Iac1158cff022b6365ce22bb70feaaff93e39172a
---
M src/osmo-bsc/gsm_08_08.c
1 file changed, 49 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/83/18783/1
diff --git a/src/osmo-bsc/gsm_08_08.c b/src/osmo-bsc/gsm_08_08.c
index 0707c65..46ef9af 100644
--- a/src/osmo-bsc/gsm_08_08.c
+++ b/src/osmo-bsc/gsm_08_08.c
@@ -123,6 +123,48 @@
return cm->cm_service_type == GSM48_CMSERV_EMERGENCY;
}
+static bool is_lu_from_other_plmn(struct msgb *msg)
+{
+ const struct gsm48_hdr *gh;
+ int8_t pdisc;
+ uint8_t mtype;
+ const struct gsm48_loc_upd_req *lu;
+ struct osmo_location_area_id old_lai;
+
+ if (msgb_l3len(msg) < sizeof(*gh))
+ return false;
+
+ gh = msgb_l3(msg);
+ pdisc = gsm48_hdr_pdisc(gh);
+ mtype = gsm48_hdr_msg_type(gh);
+
+ switch (pdisc) {
+ case GSM48_PDISC_MM:
+
+ switch (mtype) {
+ case GSM48_MT_MM_LOC_UPD_REQUEST:
+ /* First make sure that lu-> can be dereferenced */
+ if (msgb_l3len(msg) < sizeof(*gh) + sizeof(*lu))
+ return false;
+
+ lu = (struct gsm48_loc_upd_req*)gh->data;
+ gsm48_decode_lai2(&lu->lai, &old_lai);
+
+ if (osmo_plmn_cmp(&old_lai.plmn, &bsc_gsmnet->plmn) !=
0)
+ return true;
+ break;
+
+ default:
+ break;
+ }
+ break;
+ default:
+ break;
+ }
+
+ return false;
+}
+
static bool is_msc_usable(struct bsc_msc_data *msc, bool is_emerg)
{
if (is_emerg && !msc->allow_emerg)
@@ -198,6 +240,13 @@
if (osmo_tmsi_nri_v_get(&nri_v, mi.tmsi, net->nri_bitlen)) {
LOGP(DMSC, LOGL_ERROR, "Unable to retrieve NRI from
TMSI, nri_bitlen == %u\n", net->nri_bitlen);
nri_v = -1;
+ } else if (is_lu_from_other_plmn(msg)) {
+ /* If a subscriber was previously attached to a
different PLMN, it might still send the other
+* PLMN's TMSI identity in an IMSI Attach. The LU sends
a LAI indicating the previous PLMN. If
+* it mismatches our PLMN, ignore the NRI. */
+ LOG_NRI(LOGL_DEBUG,
+ "This LU Request indicates a switch from
another PLMN. Ignoring the TMSI's NRI.\n");
+ nri_v = -1;
} else {
is_null_nri = osmo_nri_v_matches_ranges(nri_v,
net->null_nri_ranges);
if (is_null_nri)
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18783
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Iac1158cff022b6365ce22bb70feaaff93e39172a
Gerrit-Change-Number: 18783
Gerrit-PatchSet: 1
Gerrit-Owner: neels
Gerrit-MessageType: newchange
Change in osmo-bsc[master]: remove extract_sub(), add bsc_subscr_find_or_create_by_mi()
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18712 ) Change subject: remove extract_sub(), add bsc_subscr_find_or_create_by_mi() .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/18712/2/include/osmocom/bsc/bsc_subscriber.h File include/osmocom/bsc/bsc_subscriber.h: https://gerrit.osmocom.org/c/osmo-bsc/+/18712/2/include/osmocom/bsc/bsc_subscriber.h@11 PS2, Line 11: struct osmo_mobile_identity; Can we please include structs from header files instead of leaving potentially dangling definitions and avoiding possible redefinitions in all places? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18712 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id6cccaac64392b737b3bba8f3a22a88009adb23b Gerrit-Change-Number: 18712 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 11 Jun 2020 11:53:08 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: bsc: add MSC pooling tests
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18763 )
Change subject: bsc: add MSC pooling tests
..
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18763/1/bsc/BSC_Tests.ttcn
File bsc/BSC_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18763/1/bsc/BSC_Tests.ttcn@4490
PS1, Line 4490: private function f_perform_clear_on_RSL1() runs on MSC_ConnHdlr
{
Merge RSL1 and RSL2 functions, simply pass the port as a parameter.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18763
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I21cbab193cd0de2e5692665442eae113d5f61904
Gerrit-Change-Number: 18763
Gerrit-PatchSet: 1
Gerrit-Owner: neels
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin
Gerrit-Comment-Date: Thu, 11 Jun 2020 11:50:34 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: bsc: add MSC pooling tests
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18763 )
Change subject: bsc: add MSC pooling tests
..
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18763/1/bsc/BSC_Tests.ttcn
File bsc/BSC_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18763/1/bsc/BSC_Tests.ttcn@4461
PS1, Line 4461: return int2oct( oct2int('4223'O) + bit2int(
(int2bit(nri_v, 32) << ( 24 - nri_bitlen)) ),
You are missing using base_tmsi instead of hardcoded value here.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18763
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I21cbab193cd0de2e5692665442eae113d5f61904
Gerrit-Change-Number: 18763
Gerrit-PatchSet: 1
Gerrit-Owner: neels
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin
Gerrit-Comment-Date: Thu, 11 Jun 2020 11:49:18 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: RAN_Emulation: allow sending UnitData from MSC_ConnHdlr
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18762 ) Change subject: RAN_Emulation: allow sending UnitData from MSC_ConnHdlr .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18762 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I36d486db05169b0fc3f19112b5a9008248d62930 Gerrit-Change-Number: 18762 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 11 Jun 2020 11:47:05 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: RSL_Emulation: fix rx of tr_RSL_PAGING_CMD()
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18761 )
Change subject: RSL_Emulation: fix rx of tr_RSL_PAGING_CMD()
..
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18761/1/library/RSL_Emulation.ttcn
File library/RSL_Emulation.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18761/1/library/RSL_Emulation.ttcn@551
PS1, Line 551: if
(ispresent(ConnectionTable[i].comp_ref) and ConnectionTable[i].comp_ref !=
null) {
Is this ispresent() really needed? I think they may have been an error here and
the same thing you are checking was aimed to be checked before. So you can
probably drop the ispresent ? (or otherwise assign := omit to it where needed).
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18761
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iaf7730153a3a19e448a33298c3e12212a55929d5
Gerrit-Change-Number: 18761
Gerrit-PatchSet: 1
Gerrit-Owner: neels
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin
Gerrit-Comment-Date: Thu, 11 Jun 2020 11:44:50 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: bsc: allow multiple MSCs
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18760 ) Change subject: bsc: allow multiple MSCs .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18760/1/bsc/MSC_ConnectionHandler.ttcn File bsc/MSC_ConnectionHandler.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18760/1/bsc/MSC_ConnectionHandler.ttcn@519 PS1, Line 519: integer rsl_idx, AFAICT rsl_idx and l3_info are not used in this patch? so not related? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18760 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibb36695b7c31f7b04eec6c5d59522fc0779b3c2f Gerrit-Change-Number: 18760 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 11 Jun 2020 11:42:24 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: fix f_enc_IMEI_L3() oddevenIndicator
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18758 ) Change subject: fix f_enc_IMEI_L3() oddevenIndicator .. Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18758/1/library/L3_Templates.ttcn File library/L3_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18758/1/library/L3_Templates.ttcn@184 PS1, Line 184: f_enc_IMEI_L3 I would expect that this function (like other f_enc_* ones) actually does some encoding and returns an octetstring. This is confusing. Maybe we should rather introduce a template, if it does not exist yet? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18758/1/library/L3_Templates.ttcn@186 PS1, Line 186: var integer len := lengthof(digits); This variable becomes unused. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18758 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iaa9ba1214c4c15fd9620e68fe2e842fdf52912c0 Gerrit-Change-Number: 18758 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Thu, 11 Jun 2020 11:41:31 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: move type RAN_Configurations to RAN_Adapter.ttcnpp
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18759 ) Change subject: move type RAN_Configurations to RAN_Adapter.ttcnpp .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18759/1/library/RAN_Adapter.ttcnpp File library/RAN_Adapter.ttcnpp: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18759/1/library/RAN_Adapter.ttcnpp@68 PS1, Line 68: type record of RAN_Configuration RAN_Configurations; I think we usually don't leave a space between the type defintion and the "record of" definition after it. At least for me it's then clear it's just on top of it. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18759 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If8f7fd50a88302af645ab337a907d8f0ad79a306 Gerrit-Change-Number: 18759 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 11 Jun 2020 11:36:53 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-gsm-tester[master]: amarisoft_enb: Properly set S1AP SCTP bind ip addr
pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18782 )
Change subject: amarisoft_enb: Properly set S1AP SCTP bind ip addr
..
amarisoft_enb: Properly set S1AP SCTP bind ip addr
Change-Id: I8e2b8609cb198c6d5e293cffaa0a9de99600f06d
---
M src/osmo_gsm_tester/templates/amarisoft_enb.cfg.tmpl
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, approved
diff --git a/src/osmo_gsm_tester/templates/amarisoft_enb.cfg.tmpl
b/src/osmo_gsm_tester/templates/amarisoft_enb.cfg.tmpl
index 8bb55d3..5690da9 100644
--- a/src/osmo_gsm_tester/templates/amarisoft_enb.cfg.tmpl
+++ b/src/osmo_gsm_tester/templates/amarisoft_enb.cfg.tmpl
@@ -41,6 +41,7 @@
mme_list: [
{
+ s1ap_bind_addr: "${enb.addr}",
/* address of MME for S1AP connection. Must be modified if the MME
runs on a different host. */
mme_addr: "${enb.mme_addr}",
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18782
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I8e2b8609cb198c6d5e293cffaa0a9de99600f06d
Gerrit-Change-Number: 18782
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-gsm-tester[master]: amarisoft_enb: Properly set S1AP SCTP bind ip addr
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18782 ) Change subject: amarisoft_enb: Properly set S1AP SCTP bind ip addr .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18782 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I8e2b8609cb198c6d5e293cffaa0a9de99600f06d Gerrit-Change-Number: 18782 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 11 Jun 2020 11:28:15 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-gsm-tester[master]: srsenb.conf.tmpl: use gtp_bind_addr also s1c bind
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18583 ) Change subject: srsenb.conf.tmpl: use gtp_bind_addr also s1c bind .. Patch Set 4: It was not working with AmarisoftENB due to missing setting in its config file. Fixed by: https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18782 Now both SRS and Amarisoft ENB work against SRS and Amarisoft EPC, both running on same host, setting run_addr= and setting gtp_bind_addr=127.0.0.2 in ENB. So this patch can be abandoned. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18583 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: Ibf5b0017c781d17c7f20b859c1cda297e2a9cca2 Gerrit-Change-Number: 18583 Gerrit-PatchSet: 4 Gerrit-Owner: srs_andre Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Reviewer: srs_andre Gerrit-Comment-Date: Thu, 11 Jun 2020 11:25:15 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-gsm-tester[master]: amarisoft_enb: Properly set S1AP SCTP bind ip addr
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18782 )
Change subject: amarisoft_enb: Properly set S1AP SCTP bind ip addr
..
amarisoft_enb: Properly set S1AP SCTP bind ip addr
Change-Id: I8e2b8609cb198c6d5e293cffaa0a9de99600f06d
---
M src/osmo_gsm_tester/templates/amarisoft_enb.cfg.tmpl
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester
refs/changes/82/18782/1
diff --git a/src/osmo_gsm_tester/templates/amarisoft_enb.cfg.tmpl
b/src/osmo_gsm_tester/templates/amarisoft_enb.cfg.tmpl
index 8bb55d3..5690da9 100644
--- a/src/osmo_gsm_tester/templates/amarisoft_enb.cfg.tmpl
+++ b/src/osmo_gsm_tester/templates/amarisoft_enb.cfg.tmpl
@@ -41,6 +41,7 @@
mme_list: [
{
+ s1ap_bind_addr: "${enb.addr}",
/* address of MME for S1AP connection. Must be modified if the MME
runs on a different host. */
mme_addr: "${enb.mme_addr}",
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18782
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I8e2b8609cb198c6d5e293cffaa0a9de99600f06d
Gerrit-Change-Number: 18782
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
Gerrit-MessageType: newchange
Change in osmo-gsm-tester[master]: log: Fix OriginLoopError generated in log.Error from testenv.poll()
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18781 ) Change subject: log: Fix OriginLoopError generated in log.Error from testenv.poll() .. log: Fix OriginLoopError generated in log.Error from testenv.poll() Change-Id: Iea80d06a30346533e4ecec338b03c72d1f1067ae --- M src/osmo_gsm_tester/core/log.py 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/osmo_gsm_tester/core/log.py b/src/osmo_gsm_tester/core/log.py index 2cf1af0..f1954d1 100644 --- a/src/osmo_gsm_tester/core/log.py +++ b/src/osmo_gsm_tester/core/log.py @@ -386,7 +386,12 @@ f = f.f_back if (origin is not None) and (log_ctx_obj is not None): -log_ctx_obj.highest_ancestor()._set_parent(origin) +log_ctx_highest_ancestor = log_ctx_obj.highest_ancestor() +# If Both end up in same ancestor it means they are connected to the +# same tree, so no need to connect them, we'll use log_ctx_obj +# specific path in that case. +if log_ctx_highest_ancestor != origin.highest_ancestor(): +log_ctx_highest_ancestor._set_parent(origin) p = log_ctx_obj while p: p._set_log_category(origin._log_category) -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18781 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: Iea80d06a30346533e4ecec338b03c72d1f1067ae Gerrit-Change-Number: 18781 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: merged
Change in osmo-gsm-tester[master]: log: Fix OriginLoopError generated in log.Error from testenv.poll()
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18781 ) Change subject: log: Fix OriginLoopError generated in log.Error from testenv.poll() .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18781 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: Iea80d06a30346533e4ecec338b03c72d1f1067ae Gerrit-Change-Number: 18781 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 11 Jun 2020 10:54:18 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-gsm-tester[master]: log: Fix OriginLoopError generated in log.Error from testenv.poll()
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18781 to look at the new patch set (#2). Change subject: log: Fix OriginLoopError generated in log.Error from testenv.poll() .. log: Fix OriginLoopError generated in log.Error from testenv.poll() Change-Id: Iea80d06a30346533e4ecec338b03c72d1f1067ae --- M src/osmo_gsm_tester/core/log.py 1 file changed, 6 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/81/18781/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18781 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: Iea80d06a30346533e4ecec338b03c72d1f1067ae Gerrit-Change-Number: 18781 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset
Change in osmo-gsm-tester[master]: log: Fix OriginLoopError generated in log.Error from testenv.poll()
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18781 ) Change subject: log: Fix OriginLoopError generated in log.Error from testenv.poll() .. log: Fix OriginLoopError generated in log.Error from testenv.poll() Change-Id: Iea80d06a30346533e4ecec338b03c72d1f1067ae --- M src/osmo_gsm_tester/core/log.py 1 file changed, 6 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/81/18781/1 diff --git a/src/osmo_gsm_tester/core/log.py b/src/osmo_gsm_tester/core/log.py index 2cf1af0..184294c 100644 --- a/src/osmo_gsm_tester/core/log.py +++ b/src/osmo_gsm_tester/core/log.py @@ -386,11 +386,12 @@ f = f.f_back if (origin is not None) and (log_ctx_obj is not None): -log_ctx_obj.highest_ancestor()._set_parent(origin) -p = log_ctx_obj -while p: -p._set_log_category(origin._log_category) -p = p._parent +log_ctx_highest_ancestor = log_ctx_obj.highest_ancestor() +# If Both end up in same ancestor it means they are connected to the +# same tree, so no need to connect them, we'll use log_ctx_obj +# specific path in that case. +if log_ctx_highest_ancestor != origin.highest_ancestor(): +log_ctx_highest_ancestor._set_parent(origin) if log_ctx_obj is not None: return log_ctx_obj # may return None -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18781 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: Iea80d06a30346533e4ecec338b03c72d1f1067ae Gerrit-Change-Number: 18781 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange
Build failure of network:osmocom:nightly/open5gs in Debian_10/armv7l
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/open5gs/Debian_10/armv7l Package network:osmocom:nightly/open5gs failed to build in Debian_10/armv7l Check out the package for editing: osc checkout network:osmocom:nightly open5gs Last lines of build log: [ 339s] [1932/2112] rm -f src/udr/libudr.a && gcc-ar csrD src/udr/libudr.a 'src/udr/e340f29@@udr@sta/context.c.o' 'src/udr/e340f29@@udr@sta/event.c.o' 'src/udr/e340f29@@udr@sta/timer.c.o' 'src/udr/e340f29@@udr@sta/nnrf-handler.c.o' 'src/udr/e340f29@@udr@sta/nf-sm.c.o' 'src/udr/e340f29@@udr@sta/nudr-handler.c.o' 'src/udr/e340f29@@udr@sta/sbi-path.c.o' 'src/udr/e340f29@@udr@sta/udr-sm.c.o' 'src/udr/e340f29@@udr@sta/init.c.o' [ 339s] [1933/2112] cc -Isrc/udm/3eca12a@@udm@sta -Isrc/udm -I../src/udm -Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/crypt -I../lib/crypt -Ilib/sbi -I../lib/sbi -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/p11-kit-1 -I/usr/include/arm-linux-gnueabihf -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes -Werror=missing-declarations -Werror=implicit-function-declaration -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow -Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation -Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option -fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections -fdata-sections -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -MD -MQ 'src/udm/3eca12a@@udm@sta/event.c.o' -MF 'src/udm/3eca12a@@udm@sta/event.c.o.d' -o 'src/udm/3eca12a@@udm@sta/event.c.o' -c ../src/udm/event.c [ 340s] [1934/2112] cc -Isrc/udm/3eca12a@@udm@sta -Isrc/udm -I../src/udm -Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/crypt -I../lib/crypt -Ilib/sbi -I../lib/sbi -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/p11-kit-1 -I/usr/include/arm-linux-gnueabihf -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes -Werror=missing-declarations -Werror=implicit-function-declaration -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow -Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation -Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option -fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections -fdata-sections -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -MD -MQ 'src/udm/3eca12a@@udm@sta/nudm-handler.c.o' -MF 'src/udm/3eca12a@@udm@sta/nudm-handler.c.o.d' -o 'src/udm/3eca12a@@udm@sta/nudm-handler.c.o' -c ../src/udm/nudm-handler.c [ 340s] [1935/2112] cc -Isrc/udm/3eca12a@@udm@sta -Isrc/udm -I../src/udm -Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/crypt -I../lib/crypt -Ilib/sbi -I../lib/sbi -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/p11-kit-1 -I/usr/include/arm-linux-gnueabihf -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes -Werror=missing-declarations -Werror=implicit-function-declaration -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow -Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation -Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option -fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections -fdata-sections -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -MD -MQ 'src/udm/3eca12a@@udm@sta/nudr-build.c.o' -MF 'src/udm/3eca12a@@udm@sta/nudr-build.c.o
Change in osmo-gsm-tester[master]: ttcn3: Don't overwrite output junit file on multiple testsuites
pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18772 )
Change subject: ttcn3: Don't overwrite output junit file on multiple testsuites
..
ttcn3: Don't overwrite output junit file on multiple testsuites
Change-Id: I803fa8766acb4e90c4a735a420b24ef18ef6b0c9
---
M sysmocom/ttcn3/suites/ttcn3_bts_tests/lib/testlib.py
M sysmocom/ttcn3/suites/ttcn3_bts_tests/scripts/run_ttcn3_docker.sh
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/sysmocom/ttcn3/suites/ttcn3_bts_tests/lib/testlib.py
b/sysmocom/ttcn3/suites/ttcn3_bts_tests/lib/testlib.py
index f0e8667..394e76e 100644
--- a/sysmocom/ttcn3/suites/ttcn3_bts_tests/lib/testlib.py
+++ b/sysmocom/ttcn3/suites/ttcn3_bts_tests/lib/testlib.py
@@ -10,7 +10,7 @@
bts_tmpl_file = os.path.join(testdir, 'scripts', 'BTS_Tests.cfg.tmpl')
script_run_dir = tenv.test().get_run_dir().new_dir('ttcn3')
bts_cfg_file = os.path.join(str(script_run_dir), 'BTS_Tests.cfg')
-junit_ttcn3_dst_file =
os.path.join(str(tenv.suite().trial().get_run_dir()), 'trial-') +
tenv.test().basename + '.xml'
+junit_ttcn3_dst_file =
os.path.join(str(tenv.suite().trial().get_run_dir()), 'trial-' +
tenv.suite().name() + '.' + tenv.test().module_name() + '.xml')
if bts.bts_type() == 'osmo-bts-trx':
pcu_available = True
pcu_sk = bts.pcu_socket_path()
diff --git a/sysmocom/ttcn3/suites/ttcn3_bts_tests/scripts/run_ttcn3_docker.sh
b/sysmocom/ttcn3/suites/ttcn3_bts_tests/scripts/run_ttcn3_docker.sh
index daac3e0..535268a 100755
--- a/sysmocom/ttcn3/suites/ttcn3_bts_tests/scripts/run_ttcn3_docker.sh
+++ b/sysmocom/ttcn3/suites/ttcn3_bts_tests/scripts/run_ttcn3_docker.sh
@@ -88,6 +88,6 @@
echo "Copying TTCN3 junit file to $JUNIT_TTCN3_DST_FILE"
cp $VOL_BASE_DIR/bts-tester/junit-xml-*.log $JUNIT_TTCN3_DST_FILE
-sed -i "s#classname='BTS_Tests'#classname='$(basename
$JUNIT_TTCN3_DST_FILE)'#g" $JUNIT_TTCN3_DST_FILE
+sed -i "s#classname='BTS_Tests'#classname='$(basename $JUNIT_TTCN3_DST_FILE
'.xml')'#g" $JUNIT_TTCN3_DST_FILE
exit $child_exit_code
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18772
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I803fa8766acb4e90c4a735a420b24ef18ef6b0c9
Gerrit-Change-Number: 18772
Gerrit-PatchSet: 2
Gerrit-Owner: pespin
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-gsm-tester[master]: ttcn3: Don't overwrite output junit file on multiple testsuites
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18772 ) Change subject: ttcn3: Don't overwrite output junit file on multiple testsuites .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18772 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I803fa8766acb4e90c4a735a420b24ef18ef6b0c9 Gerrit-Change-Number: 18772 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 11 Jun 2020 09:01:39 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Build failure of network:osmocom:nightly/open5gs in Raspbian_10/armv7l
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/open5gs/Raspbian_10/armv7l Package network:osmocom:nightly/open5gs failed to build in Raspbian_10/armv7l Check out the package for editing: osc checkout network:osmocom:nightly open5gs Last lines of build log: [ 1351s] [1927/2112] cc -Isrc/udr/e340f29@@udr@sta -Isrc/udr -I../src/udr -Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/dbi -I../lib/dbi -Ilib/crypt -I../lib/crypt -Ilib/sbi -I../lib/sbi -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/libmongoc-1.0 -I/usr/include/libbson-1.0 -I/usr/include/p11-kit-1 -I/usr/include/arm-linux-gnueabihf -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes -Werror=missing-declarations -Werror=implicit-function-declaration -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow -Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation -Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option -fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections -fdata-sections -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -MD -MQ 'src/udr/e340f29@@udr@sta/nudr-handler.c.o' -MF 'src/udr/e340f29@@udr@sta/nudr-handler.c.o.d' -o 'src/udr/e340f29@@udr@sta/nudr-handler.c.o' -c ../src/udr/nudr-handler.c [ 1352s] [1928/2112] cc -Isrc/udr/e340f29@@udr@sta -Isrc/udr -I../src/udr -Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/dbi -I../lib/dbi -Ilib/crypt -I../lib/crypt -Ilib/sbi -I../lib/sbi -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/libmongoc-1.0 -I/usr/include/libbson-1.0 -I/usr/include/p11-kit-1 -I/usr/include/arm-linux-gnueabihf -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes -Werror=missing-declarations -Werror=implicit-function-declaration -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow -Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation -Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option -fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections -fdata-sections -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -MD -MQ 'src/udr/e340f29@@udr@sta/sbi-path.c.o' -MF 'src/udr/e340f29@@udr@sta/sbi-path.c.o.d' -o 'src/udr/e340f29@@udr@sta/sbi-path.c.o' -c ../src/udr/sbi-path.c [ 1353s] [1929/2112] cc -Isrc/udr/e340f29@@udr@sta -Isrc/udr -I../src/udr -Ilib/app -I../lib/app -Ilib -I../lib -Ilib/core -I../lib/core -Ilib/dbi -I../lib/dbi -Ilib/crypt -I../lib/crypt -Ilib/sbi -I../lib/sbi -Ilib/sbi/openapi -I../lib/sbi/openapi -I/usr/include/libmongoc-1.0 -I/usr/include/libbson-1.0 -I/usr/include/p11-kit-1 -I/usr/include/arm-linux-gnueabihf -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu89 -Wextra -Wlogical-op -Werror=missing-include-dirs -Werror=pointer-arith -Werror=init-self -Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes -Werror=missing-declarations -Werror=implicit-function-declaration -Werror=return-type -Werror=incompatible-pointer-types -Werror=format=2 -Wstrict-prototypes -Wredundant-decls -Wimplicit-fallthrough=5 -Wendif-labels -Wstrict-aliasing=3 -Wwrite-strings -Werror=overflow -Werror=shift-count-overflow -Werror=shift-overflow=2 -Wdate-time -Wnested-externs -Wunused -Wduplicated-branches -Wmisleading-indentation -Wno-sign-compare -Wno-unused-parameter -ffast-math -fdiagnostics-show-option -fstack-protector -fstack-protector-strong --param=ssp-buffer-size=4 -ffunction-sections -fdata-sections -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -pthread -MD -MQ 'src/udr/e340f29@@udr@sta/udr-sm.c.o' -MF 'src/udr/e340f29@@udr@sta/udr-sm.c.o.d' -o 'src/udr/e340f29@@udr@sta/udr-sm.c.o' -c ../src/udr/udr-sm.c [ 1354s] [1930/2112] cc -Isrc/udr/e340f29@@udr@sta -Isrc/udr -I../src/udr -Ilib/app -I../lib/app -Ilib -I../lib -Ili
Change in osmo-ttcn3-hacks[master]: fix f_enc_IMEI_L3() oddevenIndicator
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18758 ) Change subject: fix f_enc_IMEI_L3() oddevenIndicator .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18758 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iaa9ba1214c4c15fd9620e68fe2e842fdf52912c0 Gerrit-Change-Number: 18758 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 11 Jun 2020 08:28:47 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-gsm-tester[master]: srsenb.conf.tmpl: use gtp_bind_addr also s1c bind
srs_andre has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18583 )
Change subject: srsenb.conf.tmpl: use gtp_bind_addr also s1c bind
..
Patch Set 4:
> Patch Set 4:
>
> So If I understand correctly, let's say you have:
> * machineA=10.42.42.10
> * machineB=10.42.42.20
> with srsUE running on machineA and srsENB and srsEPC on machineB.
>
> What would be wrong with using this setup?
>
> """
> run_node: #epc
> - run_type: ssh
> run_addr: 10.42.42.20
> ssh_user: jenkins
> ssh_addr: 10.42.42.20
>
> enb:
> - label: srsENB-zmq
> type: srsenb
> rf_dev_type: zmq
> rf_dev_args: auto
> gtp_bind_addr: 127.0.1.1
> run_node:
> run_type: ssh
> run_addr: 10.42.42.20
> ssh_user: jenkins
> ssh_addr: 10.42.42.20
>
> - label: srsUE-zmq_1
> type: srsue
> rf_dev_type: zmq
> rf_dev_args: auto
> imsi: '001010123456789'
> ki: '00112233445566778899aabbccddeeff'
> auth_algo: 'xor'
> features: ['4g']
> run_node:
> run_type: ssh
> run_addr: 10.42.42.10
> ssh_user: jenkins
> ssh_addr: 10.42.42.10
> """
>
> UE<->ENB over zmq: 10.42.42.10 <-> 10.42.42.20 (not same port, anyway we use
> different IP)
> ENB<->EPC over S1: 10.42.42.20 <-> 10.42.42.20 (not same port, fine with
> reusing IP)
> ENB<->EPC over GTP: 127.0.1.1 <-> 10.42.42.20 (different IP, gtp port must be
> same in both)
It worked with srsENB/srsEPC. But Amarisoft eNB refuses to connect to to the
EPC with this config.
```
/* Enable remote API and Web interface */
com_addr: "10.12.1.195:9001",
mme_list: [
{
/* address of MME for S1AP connection. Must be modified if the MME
runs on a different host. */
mme_addr: "10.12.1.195",
},
],
/* GTP bind address (=address of the ethernet interface connected to
the MME). Must be modified if the MME runs on a different host. */
gtp_addr: "127.0.1.1",
```
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18583
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: Ibf5b0017c781d17c7f20b859c1cda297e2a9cca2
Gerrit-Change-Number: 18583
Gerrit-PatchSet: 4
Gerrit-Owner: srs_andre
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin
Gerrit-Reviewer: srs_andre
Gerrit-Comment-Date: Thu, 11 Jun 2020 07:59:55 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
