Build failure of network:osmocom:nightly/osmo-trx in openSUSE_Leap_15.1_ARM/armv7l
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/openSUSE_Leap_15.1_ARM/armv7l Package network:osmocom:nightly/osmo-trx failed to build in openSUSE_Leap_15.1_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [ 266s] libtool: link: g++ -pthread -I/usr/include/libosmocore/ -I/usr/include/libosmocore/ -I/usr/include/libosmocore/ -fmessage-length=0 -grecord-gcc-switches -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -o osmo-trx-lms osmo_trx_lms-osmo-trx.o ./device/lms/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f -losmoctrl -losmogsm -ltalloc -losmovty -losmocore -lLimeSuite -pthread [ 266s] libtool: link: g++ -pthread -I/usr/include/libosmocore/ -I/usr/include/libosmocore/ -I/usr/include/libosmocore/ -fmessage-length=0 -grecord-gcc-switches -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -o osmo-trx-usrp1 osmo_trx_usrp1-osmo-trx.o ./device/usrp1/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f -losmoctrl -losmogsm -ltalloc -losmovty -losmocore -lusrp -lusb-1.0 -pthread [ 266s] libtool: link: g++ -pthread -I/usr/include/libosmocore/ -I/usr/include/libosmocore/ -I/usr/include/libosmocore/ -fmessage-length=0 -grecord-gcc-switches -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f -losmoctrl -losmogsm -ltalloc -losmovty -losmocore -luhd -pthread [ 266s] /usr/lib/gcc/armv7hl-suse-linux-gnueabi/7/../../../../armv7hl-suse-linux-gnueabi/bin/ld: ./device/lms/.libs/libdevice.a(LMSDevice.o): in function `LMSDevice::do_clock_src_freq(ReferenceType, double)': [ 266s] LMSDevice.cpp:(.text+0x462c): undefined reference to `get_value_string(value_string const*, unsigned int)' [ 266s] /usr/lib/gcc/armv7hl-suse-linux-gnueabi/7/../../../../armv7hl-suse-linux-gnueabi/bin/ld: ./device/lms/.libs/libdevice.a(LMSDevice.o): in function `LMSDevice::assign_band_desc(gsm_band)': [ 266s] LMSDevice.cpp:(.text+0xb978): undefined reference to `osmo_panic(char const*, ...)' [ 266s] collect2: error: ld returned 1 exit status [ 266s] make[3]: *** [Makefile:688: osmo-trx-lms] Error 1 [ 266s] make[3]: *** Waiting for unfinished jobs [ 267s] libtool: link: g++ -pthread -I/usr/include/libosmocore/ -I/usr/include/libosmocore/ -I/usr/include/libosmocore/ -fmessage-length=0 -grecord-gcc-switches -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -o osmo-trx-ipc osmo_trx_ipc-osmo-trx.o ./device/ipc/.libs/libdevice.a -lrt ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f -losmoctrl -losmogsm -ltalloc -losmovty -losmocore -pthread [ 267s] make[3]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-trx-1.2.0.94.c598/Transceiver52M' [ 267s] make[2]: *** [Makefile:840: all-recursive] Error 1 [ 267s] make[2]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-trx-1.2.0.94.c598/Transceiver52M' [ 267s] make[1]: *** [Makefile:518: all-recursive] Error 1 [ 267s] make[1]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-trx-1.2.0.94.c598' [ 267s] make: *** [Makefile:449: all] Error 2 [ 267s] error: Bad exit status from /var/tmp/rpm-tmp.yQgDHr (%build) [ 267s] [ 267s] [ 267s] RPM build errors: [ 267s] Bad exit status from /var/tmp/rpm-tmp.yQgDHr (%build) [ 267s] ### VM INTERACTION START ### [ 270s] [ 248.227536] sysrq: SysRq : Power Off [ 270s] [ 248.239824] reboot: Power down [ 272s] ### VM INTERACTION END ### [ 272s] [ 272s] obs-arm-6 failed "build osmo-trx.spec" at Sat Oct 24 05:42:34 UTC 2020. [ 272s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-trx in Debian_Testing/x86_64
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_Testing/x86_64
Package network:osmocom:nightly/osmo-trx failed to build in
Debian_Testing/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-trx
Last lines of build log:
[ 826s] In file included from osmo-trx.cpp:57:
[ 826s] /usr/include/osmocom/vty/command.h:476:5: note: declared here
[ 826s] 476 | int vty_dump_xml_ref(FILE *stream) OSMO_DEPRECATED("Use
vty_dump_xml_ref_mode() instead");
[ 826s] | ^~~~
[ 828s] /bin/bash ../libtool --tag=CXX --mode=link g++ -lpthread -pthread
-I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2
-fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat
-Werror=format-security -Wl,-z,relro -Wl,-z,now -o osmo-trx-lms
osmo_trx_lms-osmo-trx.o ./device/lms/libdevice.la libtransceiver_common.la
../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la
../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl
-losmogsm -losmocore -ltalloc -losmovty -losmocore -lLimeSuite
[ 829s] libtool: link: g++ -pthread -I/usr/include/ -I/usr/include/
-I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=.
-fstack-protector-strong -Wformat -Werror=format-security -Wl,-z -Wl,relro
-Wl,-z -Wl,now -o osmo-trx-lms osmo_trx_lms-osmo-trx.o
./device/lms/.libs/libdevice.a ./.libs/libtransceiver_common.a
../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a
../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f
/usr/lib/x86_64-linux-gnu/libosmoctrl.so
/usr/lib/x86_64-linux-gnu/libosmogsm.so -ltalloc
/usr/lib/x86_64-linux-gnu/libosmovty.so
/usr/lib/x86_64-linux-gnu/libosmocore.so -lLimeSuite -pthread
[ 830s] /usr/bin/ld: ./device/lms/.libs/libdevice.a(LMSDevice.o): in function
`LMSDevice::do_clock_src_freq(ReferenceType, double)':
[ 830s] ./Transceiver52M/device/lms/LMSDevice.cpp:495: undefined reference to
`get_value_string(value_string const*, unsigned int)'
[ 830s] /usr/bin/ld: ./device/lms/.libs/libdevice.a(LMSDevice.o): in function
`LMSDevice::assign_band_desc(gsm_band)':
[ 830s] ./Transceiver52M/device/lms/LMSDevice.cpp:239: undefined reference to
`osmo_panic(char const*, ...)'
[ 830s] collect2: error: ld returned 1 exit status
[ 830s] make[4]: *** [Makefile:702: osmo-trx-lms] Error 1
[ 830s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M'
[ 830s] make[3]: *** [Makefile:860: all-recursive] Error 1
[ 830s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M'
[ 830s] make[2]: *** [Makefile:519: all-recursive] Error 1
[ 830s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[ 830s] make[1]: *** [Makefile:450: all] Error 2
[ 830s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[ 830s] dh_auto_build: error: make -j1 returned exit code 2
[ 830s] make: *** [debian/rules:6: build] Error 25
[ 830s] dpkg-buildpackage: error: debian/rules build subprocess returned exit
status 2
[ 830s] ### VM INTERACTION START ###
[ 831s] Powering off.
[ 831s] [ 802.653582] reboot: Power down
[ 831s] ### VM INTERACTION END ###
[ 831s]
[ 831s] old-atreju1 failed "build osmo-trx_1.2.0.94.c598.dsc" at Sat Oct 24
03:07:41 UTC 2020.
[ 831s]
--
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-trx in Debian_Testing/x86_64
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_Testing/x86_64
Package network:osmocom:nightly/osmo-trx failed to build in
Debian_Testing/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-trx
Last lines of build log:
[ 615s] In file included from osmo-trx.cpp:57:
[ 615s] /usr/include/osmocom/vty/command.h:476:5: note: declared here
[ 615s] 476 | int vty_dump_xml_ref(FILE *stream) OSMO_DEPRECATED("Use
vty_dump_xml_ref_mode() instead");
[ 615s] | ^~~~
[ 617s] /bin/bash ../libtool --tag=CXX --mode=link g++ -lpthread -pthread
-I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2
-fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat
-Werror=format-security -Wl,-z,relro -Wl,-z,now -o osmo-trx-lms
osmo_trx_lms-osmo-trx.o ./device/lms/libdevice.la libtransceiver_common.la
../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la
../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl
-losmogsm -losmocore -ltalloc -losmovty -losmocore -lLimeSuite
[ 617s] libtool: link: g++ -pthread -I/usr/include/ -I/usr/include/
-I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=.
-fstack-protector-strong -Wformat -Werror=format-security -Wl,-z -Wl,relro
-Wl,-z -Wl,now -o osmo-trx-lms osmo_trx_lms-osmo-trx.o
./device/lms/.libs/libdevice.a ./.libs/libtransceiver_common.a
../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a
../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f
/usr/lib/x86_64-linux-gnu/libosmoctrl.so
/usr/lib/x86_64-linux-gnu/libosmogsm.so -ltalloc
/usr/lib/x86_64-linux-gnu/libosmovty.so
/usr/lib/x86_64-linux-gnu/libosmocore.so -lLimeSuite -pthread
[ 617s] /usr/bin/ld: ./device/lms/.libs/libdevice.a(LMSDevice.o): in function
`LMSDevice::do_clock_src_freq(ReferenceType, double)':
[ 617s] ./Transceiver52M/device/lms/LMSDevice.cpp:495: undefined reference to
`get_value_string(value_string const*, unsigned int)'
[ 617s] /usr/bin/ld: ./device/lms/.libs/libdevice.a(LMSDevice.o): in function
`LMSDevice::assign_band_desc(gsm_band)':
[ 617s] ./Transceiver52M/device/lms/LMSDevice.cpp:239: undefined reference to
`osmo_panic(char const*, ...)'
[ 617s] collect2: error: ld returned 1 exit status
[ 617s] make[4]: *** [Makefile:702: osmo-trx-lms] Error 1
[ 617s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M'
[ 617s] make[3]: *** [Makefile:860: all-recursive] Error 1
[ 617s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M'
[ 617s] make[2]: *** [Makefile:519: all-recursive] Error 1
[ 617s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[ 617s] make[1]: *** [Makefile:450: all] Error 2
[ 617s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[ 617s] dh_auto_build: error: make -j1 returned exit code 2
[ 617s] make: *** [debian/rules:6: build] Error 25
[ 617s] dpkg-buildpackage: error: debian/rules build subprocess returned exit
status 2
[ 617s] ### VM INTERACTION START ###
[ 618s] Powering off.
[ 618s] [ 597.611049] reboot: Power down
[ 619s] ### VM INTERACTION END ###
[ 619s]
[ 619s] lamb53 failed "build osmo-trx_1.2.0.94.c598.dsc" at Sat Oct 24
02:17:14 UTC 2020.
[ 619s]
--
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-trx in Debian_10/x86_64
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_10/x86_64
Package network:osmocom:nightly/osmo-trx failed to build in Debian_10/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-trx
Last lines of build log:
[ 508s] In file included from osmo-trx.cpp:57:
[ 508s] /usr/include/osmocom/vty/command.h:476:5: note: declared here
[ 508s] int vty_dump_xml_ref(FILE *stream) OSMO_DEPRECATED("Use
vty_dump_xml_ref_mode() instead");
[ 508s] ^~~~
[ 510s] /bin/bash ../libtool --tag=CXX --mode=link g++ -lpthread -pthread
-I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2
-fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat
-Werror=format-security -Wl,-z,relro -Wl,-z,now -o osmo-trx-lms
osmo_trx_lms-osmo-trx.o ./device/lms/libdevice.la libtransceiver_common.la
../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la
../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl
-losmogsm -losmocore -ltalloc -losmovty -losmocore -lLimeSuite
[ 510s] libtool: link: g++ -pthread -I/usr/include/ -I/usr/include/
-I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=.
-fstack-protector-strong -Wformat -Werror=format-security -Wl,-z -Wl,relro
-Wl,-z -Wl,now -o osmo-trx-lms osmo_trx_lms-osmo-trx.o
./device/lms/.libs/libdevice.a ./.libs/libtransceiver_common.a
../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a
../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f
/usr/lib/x86_64-linux-gnu/libosmoctrl.so
/usr/lib/x86_64-linux-gnu/libosmogsm.so -ltalloc
/usr/lib/x86_64-linux-gnu/libosmovty.so
/usr/lib/x86_64-linux-gnu/libosmocore.so -lLimeSuite -pthread
[ 510s] /usr/bin/ld: ./device/lms/.libs/libdevice.a(LMSDevice.o): in function
`LMSDevice::do_clock_src_freq(ReferenceType, double)':
[ 510s] ./Transceiver52M/device/lms/LMSDevice.cpp:495: undefined reference to
`get_value_string(value_string const*, unsigned int)'
[ 510s] /usr/bin/ld: ./device/lms/.libs/libdevice.a(LMSDevice.o): in function
`LMSDevice::assign_band_desc(gsm_band)':
[ 510s] ./Transceiver52M/device/lms/LMSDevice.cpp:239: undefined reference to
`osmo_panic(char const*, ...)'
[ 510s] collect2: error: ld returned 1 exit status
[ 510s] make[4]: *** [Makefile:702: osmo-trx-lms] Error 1
[ 510s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M'
[ 510s] make[3]: *** [Makefile:860: all-recursive] Error 1
[ 510s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M'
[ 510s] make[2]: *** [Makefile:519: all-recursive] Error 1
[ 510s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[ 510s] make[1]: *** [Makefile:450: all] Error 2
[ 511s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[ 511s] dh_auto_build: make -j1 returned exit code 2
[ 511s] make: *** [debian/rules:6: build] Error 2
[ 511s] dpkg-buildpackage: error: debian/rules build subprocess returned exit
status 2
[ 511s] ### VM INTERACTION START ###
[ 514s] [ 497.011999] sysrq: Power Off
[ 514s] [ 497.018544] reboot: Power down
[ 514s] ### VM INTERACTION END ###
[ 514s]
[ 514s] lamb51 failed "build osmo-trx_1.2.0.94.c598.dsc" at Sat Oct 24
02:12:43 UTC 2020.
[ 514s]
--
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-trx in Debian_9.0/aarch64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_9.0/aarch64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_9.0/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [ 1327s] libtool: link: g++ -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z -Wl,relro -Wl,-z -Wl,now -o osmo-trx-lms osmo_trx_lms-osmo-trx.o ./device/lms/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f /usr/lib/aarch64-linux-gnu/libosmoctrl.so /usr/lib/aarch64-linux-gnu/libosmogsm.so -ltalloc /usr/lib/aarch64-linux-gnu/libosmovty.so /usr/lib/aarch64-linux-gnu/libosmocore.so -lLimeSuite -pthread [ 1327s] ./device/lms/.libs/libdevice.a(LMSDevice.o): In function `LMSDevice::do_clock_src_freq(ReferenceType, double)': [ 1327s] ./Transceiver52M/device/lms/LMSDevice.cpp:495: undefined reference to `get_value_string(value_string const*, unsigned int)' [ 1327s] ./device/lms/.libs/libdevice.a(LMSDevice.o): In function `LMSDevice::assign_band_desc(gsm_band)': [ 1327s] ./Transceiver52M/device/lms/LMSDevice.cpp:239: undefined reference to `osmo_panic(char const*, ...)' [ 1327s] collect2: error: ld returned 1 exit status [ 1327s] Makefile:688: recipe for target 'osmo-trx-lms' failed [ 1327s] make[4]: *** [osmo-trx-lms] Error 1 [ 1327s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 1327s] Makefile:841: recipe for target 'all-recursive' failed [ 1327s] make[3]: *** [all-recursive] Error 1 [ 1327s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 1327s] Makefile:519: recipe for target 'all-recursive' failed [ 1327s] make[2]: *** [all-recursive] Error 1 [ 1327s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 1327s] Makefile:450: recipe for target 'all' failed [ 1327s] make[1]: *** [all] Error 2 [ 1327s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 1327s] dh_auto_build: make -j1 returned exit code 2 [ 1327s] debian/rules:6: recipe for target 'build' failed [ 1327s] make: *** [build] Error 2 [ 1327s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 1327s] ### VM INTERACTION START ### [ 1331s] [ 1296.862812] sysrq: Power Off [ 1331s] [ 1296.885282] reboot: Power down [ 1331s] ### VM INTERACTION END ### [ 1331s] [ 1331s] obs-arm-2 failed "build osmo-trx_1.2.0.94.c598.dsc" at Sat Oct 24 02:10:28 UTC 2020. [ 1331s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-trx in xUbuntu_18.04/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/xUbuntu_18.04/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in xUbuntu_18.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [ 672s] libtool: link: g++ -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-Bsymbolic-functions -Wl,-z -Wl,relro -Wl,-z -Wl,now -o osmo-trx-lms osmo_trx_lms-osmo-trx.o ./device/lms/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f /usr/lib/x86_64-linux-gnu/libosmoctrl.so /usr/lib/x86_64-linux-gnu/libosmogsm.so -ltalloc /usr/lib/x86_64-linux-gnu/libosmovty.so /usr/lib/x86_64-linux-gnu/libosmocore.so -lLimeSuite -pthread [ 672s] ./device/lms/.libs/libdevice.a(LMSDevice.o): In function `LMSDevice::do_clock_src_freq(ReferenceType, double)': [ 672s] ./Transceiver52M/device/lms/LMSDevice.cpp:495: undefined reference to `get_value_string(value_string const*, unsigned int)' [ 672s] ./device/lms/.libs/libdevice.a(LMSDevice.o): In function `LMSDevice::assign_band_desc(gsm_band)': [ 672s] ./Transceiver52M/device/lms/LMSDevice.cpp:239: undefined reference to `osmo_panic(char const*, ...)' [ 672s] collect2: error: ld returned 1 exit status [ 673s] Makefile:688: recipe for target 'osmo-trx-lms' failed [ 673s] make[4]: *** [osmo-trx-lms] Error 1 [ 673s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 673s] Makefile:841: recipe for target 'all-recursive' failed [ 673s] make[3]: *** [all-recursive] Error 1 [ 673s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 673s] Makefile:519: recipe for target 'all-recursive' failed [ 673s] make[2]: *** [all-recursive] Error 1 [ 673s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 673s] Makefile:450: recipe for target 'all' failed [ 673s] make[1]: *** [all] Error 2 [ 673s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 673s] dh_auto_build: make -j1 returned exit code 2 [ 673s] debian/rules:6: recipe for target 'build' failed [ 673s] make: *** [build] Error 2 [ 673s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 673s] ### VM INTERACTION START ### [ 676s] [ 658.522175] sysrq: Power Off [ 676s] [ 658.541314] reboot: Power down [ 676s] ### VM INTERACTION END ### [ 676s] [ 676s] lamb21 failed "build osmo-trx_1.2.0.94.c598.dsc" at Sat Oct 24 02:04:10 UTC 2020. [ 676s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-trx in Debian_10/aarch64
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_10/aarch64
Package network:osmocom:nightly/osmo-trx failed to build in Debian_10/aarch64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-trx
Last lines of build log:
[ 693s] In file included from osmo-trx.cpp:57:
[ 693s] /usr/include/osmocom/vty/command.h:476:5: note: declared here
[ 693s] int vty_dump_xml_ref(FILE *stream) OSMO_DEPRECATED("Use
vty_dump_xml_ref_mode() instead");
[ 693s] ^~~~
[ 696s] /bin/bash ../libtool --tag=CXX --mode=link g++ -lpthread -pthread
-I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2
-fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat
-Werror=format-security -Wl,-z,relro -Wl,-z,now -o osmo-trx-lms
osmo_trx_lms-osmo-trx.o ./device/lms/libdevice.la libtransceiver_common.la
../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la
../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl
-losmogsm -losmocore -ltalloc -losmovty -losmocore -lLimeSuite
[ 696s] libtool: link: g++ -pthread -I/usr/include/ -I/usr/include/
-I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=.
-fstack-protector-strong -Wformat -Werror=format-security -Wl,-z -Wl,relro
-Wl,-z -Wl,now -o osmo-trx-lms osmo_trx_lms-osmo-trx.o
./device/lms/.libs/libdevice.a ./.libs/libtransceiver_common.a
../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a
../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f
/usr/lib/aarch64-linux-gnu/libosmoctrl.so
/usr/lib/aarch64-linux-gnu/libosmogsm.so -ltalloc
/usr/lib/aarch64-linux-gnu/libosmovty.so
/usr/lib/aarch64-linux-gnu/libosmocore.so -lLimeSuite -pthread
[ 697s] /usr/bin/ld: ./device/lms/.libs/libdevice.a(LMSDevice.o): in function
`LMSDevice::do_clock_src_freq(ReferenceType, double)':
[ 697s] ./Transceiver52M/device/lms/LMSDevice.cpp:495: undefined reference to
`get_value_string(value_string const*, unsigned int)'
[ 697s] /usr/bin/ld: ./device/lms/.libs/libdevice.a(LMSDevice.o): in function
`LMSDevice::assign_band_desc(gsm_band)':
[ 697s] ./Transceiver52M/device/lms/LMSDevice.cpp:239: undefined reference to
`osmo_panic(char const*, ...)'
[ 697s] collect2: error: ld returned 1 exit status
[ 697s] make[4]: *** [Makefile:702: osmo-trx-lms] Error 1
[ 697s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M'
[ 697s] make[3]: *** [Makefile:860: all-recursive] Error 1
[ 697s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M'
[ 697s] make[2]: *** [Makefile:519: all-recursive] Error 1
[ 697s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[ 697s] make[1]: *** [Makefile:450: all] Error 2
[ 697s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[ 697s] dh_auto_build: make -j1 returned exit code 2
[ 697s] make: *** [debian/rules:6: build] Error 2
[ 697s] dpkg-buildpackage: error: debian/rules build subprocess returned exit
status 2
[ 697s] ### VM INTERACTION START ###
[ 700s] [ 674.510325] sysrq: Power Off
[ 700s] [ 674.557855] reboot: Power down
[ 701s] ### VM INTERACTION END ###
[ 701s]
[ 701s] obs-arm-9 failed "build osmo-trx_1.2.0.94.c598.dsc" at Sat Oct 24
02:03:59 UTC 2020.
[ 701s]
--
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-trx in xUbuntu_18.10/x86_64
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/xUbuntu_18.10/x86_64
Package network:osmocom:nightly/osmo-trx failed to build in xUbuntu_18.10/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-trx
Last lines of build log:
[ 533s] In file included from osmo-trx.cpp:57:
[ 533s] /usr/include/osmocom/vty/command.h:476:5: note: declared here
[ 533s] int vty_dump_xml_ref(FILE *stream) OSMO_DEPRECATED("Use
vty_dump_xml_ref_mode() instead");
[ 533s] ^~~~
[ 535s] /bin/bash ../libtool --tag=CXX --mode=link g++ -lpthread -pthread
-I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2
-fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat
-Werror=format-security -Wl,-Bsymbolic-functions -Wl,-z,relro -Wl,-z,now -o
osmo-trx-lms osmo_trx_lms-osmo-trx.o ./device/lms/libdevice.la
libtransceiver_common.la ../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la
../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl
-losmogsm -losmocore -ltalloc -losmovty -losmocore -lLimeSuite
[ 535s] libtool: link: g++ -pthread -I/usr/include/ -I/usr/include/
-I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=.
-fstack-protector-strong -Wformat -Werror=format-security
-Wl,-Bsymbolic-functions -Wl,-z -Wl,relro -Wl,-z -Wl,now -o osmo-trx-lms
osmo_trx_lms-osmo-trx.o ./device/lms/.libs/libdevice.a
./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a
../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f
/usr/lib/x86_64-linux-gnu/libosmoctrl.so
/usr/lib/x86_64-linux-gnu/libosmogsm.so -ltalloc
/usr/lib/x86_64-linux-gnu/libosmovty.so
/usr/lib/x86_64-linux-gnu/libosmocore.so -lLimeSuite -pthread
[ 536s] /usr/bin/ld: ./device/lms/.libs/libdevice.a(LMSDevice.o): in function
`LMSDevice::do_clock_src_freq(ReferenceType, double)':
[ 536s] ./Transceiver52M/device/lms/LMSDevice.cpp:495: undefined reference to
`get_value_string(value_string const*, unsigned int)'
[ 536s] /usr/bin/ld: ./device/lms/.libs/libdevice.a(LMSDevice.o): in function
`LMSDevice::assign_band_desc(gsm_band)':
[ 536s] ./Transceiver52M/device/lms/LMSDevice.cpp:239: undefined reference to
`osmo_panic(char const*, ...)'
[ 536s] collect2: error: ld returned 1 exit status
[ 536s] make[4]: *** [Makefile:702: osmo-trx-lms] Error 1
[ 536s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M'
[ 536s] make[3]: *** [Makefile:860: all-recursive] Error 1
[ 536s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M'
[ 536s] make[2]: *** [Makefile:519: all-recursive] Error 1
[ 536s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[ 536s] make[1]: *** [Makefile:450: all] Error 2
[ 536s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[ 536s] dh_auto_build: make -j1 returned exit code 2
[ 536s] make: *** [debian/rules:6: build] Error 2
[ 536s] dpkg-buildpackage: error: debian/rules build subprocess returned exit
status 2
[ 536s] ### VM INTERACTION START ###
[ 539s] [ 521.277834] sysrq: Power Off
[ 539s] [ 521.285391] reboot: Power down
[ 539s] ### VM INTERACTION END ###
[ 539s]
[ 539s] lamb61 failed "build osmo-trx_1.2.0.94.c598.dsc" at Sat Oct 24
02:02:41 UTC 2020.
[ 539s]
--
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-trx in xUbuntu_19.10/x86_64
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/xUbuntu_19.10/x86_64
Package network:osmocom:nightly/osmo-trx failed to build in xUbuntu_19.10/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-trx
Last lines of build log:
[ 825s] In file included from osmo-trx.cpp:57:
[ 825s] /usr/include/osmocom/vty/command.h:476:5: note: declared here
[ 825s] 476 | int vty_dump_xml_ref(FILE *stream) OSMO_DEPRECATED("Use
vty_dump_xml_ref_mode() instead");
[ 825s] | ^~~~
[ 827s] /bin/bash ../libtool --tag=CXX --mode=link g++ -lpthread -pthread
-I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2
-fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat
-Werror=format-security -Wl,-Bsymbolic-functions -Wl,-z,relro -Wl,-z,now -o
osmo-trx-lms osmo_trx_lms-osmo-trx.o ./device/lms/libdevice.la
libtransceiver_common.la ../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la
../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl
-losmogsm -losmocore -ltalloc -losmovty -losmocore -lLimeSuite
[ 828s] libtool: link: g++ -pthread -I/usr/include/ -I/usr/include/
-I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=.
-fstack-protector-strong -Wformat -Werror=format-security
-Wl,-Bsymbolic-functions -Wl,-z -Wl,relro -Wl,-z -Wl,now -o osmo-trx-lms
osmo_trx_lms-osmo-trx.o ./device/lms/.libs/libdevice.a
./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a
../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f
/usr/lib/x86_64-linux-gnu/libosmoctrl.so
/usr/lib/x86_64-linux-gnu/libosmogsm.so -ltalloc
/usr/lib/x86_64-linux-gnu/libosmovty.so
/usr/lib/x86_64-linux-gnu/libosmocore.so -lLimeSuite -pthread
[ 828s] /usr/bin/ld: ./device/lms/.libs/libdevice.a(LMSDevice.o): in function
`LMSDevice::do_clock_src_freq(ReferenceType, double)':
[ 828s] ./Transceiver52M/device/lms/LMSDevice.cpp:495: undefined reference to
`get_value_string(value_string const*, unsigned int)'
[ 828s] /usr/bin/ld: ./device/lms/.libs/libdevice.a(LMSDevice.o): in function
`LMSDevice::assign_band_desc(gsm_band)':
[ 828s] ./Transceiver52M/device/lms/LMSDevice.cpp:239: undefined reference to
`osmo_panic(char const*, ...)'
[ 828s] collect2: error: ld returned 1 exit status
[ 828s] make[4]: *** [Makefile:702: osmo-trx-lms] Error 1
[ 828s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M'
[ 828s] make[3]: *** [Makefile:860: all-recursive] Error 1
[ 828s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M'
[ 828s] make[2]: *** [Makefile:519: all-recursive] Error 1
[ 828s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[ 828s] make[1]: *** [Makefile:450: all] Error 2
[ 828s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[ 828s] dh_auto_build: make -j1 returned exit code 2
[ 828s] make: *** [debian/rules:6: build] Error 255
[ 828s] dpkg-buildpackage: error: debian/rules build subprocess returned exit
status 2
[ 828s] ### VM INTERACTION START ###
[ 831s] [ 748.913154] sysrq: Power Off
[ 832s] [ 748.918141] reboot: Power down
[ 832s] ### VM INTERACTION END ###
[ 832s]
[ 832s] old-atreju3 failed "build osmo-trx_1.2.0.94.c598.dsc" at Sat Oct 24
02:02:52 UTC 2020.
[ 832s]
--
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_20.04/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_20.04/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_20.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 277s] [COMPILING libboard/qmod/source/wwan_perst.c] [ 277s] [COMPILING libboard/qmod/source/card_pres.c] [ 277s] [COMPILING libboard/qmod/source/wwan_led.c] [ 277s] [COMPILING libboard/qmod/source/i2c.c] [ 278s] [COMPILING libboard/qmod/source/board_qmod.c] [ 278s] [COMPILING apps/dfu/main.c] [ 278s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu.c] [ 278s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_desc.c] [ 278s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_driver.c] [ 279s] Memory region Used Size Region Size %age Used [ 279s] rom: 16588 B16 KB101.25% [ 279s] ram: 11672 B48 KB 23.75/usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: bin/qmod-dfu-flash.elf section `.text' will not fit in region `rom' [ 279s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: region `rom' overflowed by 204 bytes [ 279s] collect2: error: ld returned 1 exit status [ 279s] % [ 279s] make[2]: *** [Makefile:234: flash] Error 1 [ 279s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 279s] make[1]: *** [Makefile:13: fw-qmod-dfu] Error 2 [ 279s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 279s] dh_auto_build: error: make -j1 returned exit code 2 [ 279s] make: *** [debian/rules:16: build] Error 25 [ 279s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 279s] ### VM INTERACTION START ### [ 282s] [ 270.086973] sysrq: Power Off [ 282s] [ 270.110381] reboot: Power down [ 282s] ### VM INTERACTION END ### [ 282s] [ 282s] lamb55 failed "build simtrace2_0.7.0.64.a124.dsc" at Sat Oct 24 02:03:22 UTC 2020. [ 282s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-trx in xUbuntu_20.04/x86_64
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/xUbuntu_20.04/x86_64
Package network:osmocom:nightly/osmo-trx failed to build in xUbuntu_20.04/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-trx
Last lines of build log:
[ 378s] In file included from osmo-trx.cpp:57:
[ 378s] /usr/include/osmocom/vty/command.h:476:5: note: declared here
[ 378s] 476 | int vty_dump_xml_ref(FILE *stream) OSMO_DEPRECATED("Use
vty_dump_xml_ref_mode() instead");
[ 378s] | ^~~~
[ 378s] /bin/bash ../libtool --tag=CXX --mode=link g++ -lpthread -pthread
-I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2
-fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat
-Werror=format-security -Wl,-Bsymbolic-functions -Wl,-z,relro -Wl,-z,now -o
osmo-trx-lms osmo_trx_lms-osmo-trx.o ./device/lms/libdevice.la
libtransceiver_common.la ../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la
../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl
-losmogsm -losmocore -ltalloc -losmovty -losmocore -lLimeSuite
[ 379s] libtool: link: g++ -pthread -I/usr/include/ -I/usr/include/
-I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=.
-fstack-protector-strong -Wformat -Werror=format-security
-Wl,-Bsymbolic-functions -Wl,-z -Wl,relro -Wl,-z -Wl,now -o osmo-trx-lms
osmo_trx_lms-osmo-trx.o ./device/lms/.libs/libdevice.a
./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a
../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f
/usr/lib/x86_64-linux-gnu/libosmoctrl.so
/usr/lib/x86_64-linux-gnu/libosmogsm.so -ltalloc
/usr/lib/x86_64-linux-gnu/libosmovty.so
/usr/lib/x86_64-linux-gnu/libosmocore.so -lLimeSuite -pthread
[ 379s] /usr/bin/ld: ./device/lms/.libs/libdevice.a(LMSDevice.o): in function
`LMSDevice::do_clock_src_freq(ReferenceType, double)':
[ 379s] ./Transceiver52M/device/lms/LMSDevice.cpp:495: undefined reference to
`get_value_string(value_string const*, unsigned int)'
[ 379s] /usr/bin/ld: ./device/lms/.libs/libdevice.a(LMSDevice.o): in function
`LMSDevice::assign_band_desc(gsm_band)':
[ 379s] ./Transceiver52M/device/lms/LMSDevice.cpp:239: undefined reference to
`osmo_panic(char const*, ...)'
[ 379s] collect2: error: ld returned 1 exit status
[ 379s] make[4]: *** [Makefile:702: osmo-trx-lms] Error 1
[ 379s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M'
[ 379s] make[3]: *** [Makefile:860: all-recursive] Error 1
[ 379s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M'
[ 379s] make[2]: *** [Makefile:519: all-recursive] Error 1
[ 379s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[ 379s] make[1]: *** [Makefile:450: all] Error 2
[ 379s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[ 379s] dh_auto_build: error: make -j1 returned exit code 2
[ 379s] make: *** [debian/rules:6: build] Error 25
[ 379s] dpkg-buildpackage: error: debian/rules build subprocess returned exit
status 2
[ 379s] ### VM INTERACTION START ###
[ 382s] [ 368.545335] sysrq: Power Off
[ 382s] [ 368.549152] reboot: Power down
[ 382s] ### VM INTERACTION END ###
[ 382s]
[ 382s] sheep87 failed "build osmo-trx_1.2.0.94.c598.dsc" at Sat Oct 24
02:02:43 UTC 2020.
[ 382s]
--
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-trx in Debian_10/i586
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_10/i586
Package network:osmocom:nightly/osmo-trx failed to build in Debian_10/i586
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-trx
Last lines of build log:
[ 855s] In file included from osmo-trx.cpp:57:
[ 855s] /usr/include/osmocom/vty/command.h:476:5: note: declared here
[ 855s] int vty_dump_xml_ref(FILE *stream) OSMO_DEPRECATED("Use
vty_dump_xml_ref_mode() instead");
[ 855s] ^~~~
[ 857s] /bin/bash ../libtool --tag=CXX --mode=link g++ -lpthread -pthread
-I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2
-fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat
-Werror=format-security -Wl,-z,relro -Wl,-z,now -o osmo-trx-lms
osmo_trx_lms-osmo-trx.o ./device/lms/libdevice.la libtransceiver_common.la
../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la
../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl
-losmogsm -losmocore -ltalloc -losmovty -losmocore -lLimeSuite
[ 858s] libtool: link: g++ -pthread -I/usr/include/ -I/usr/include/
-I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=.
-fstack-protector-strong -Wformat -Werror=format-security -Wl,-z -Wl,relro
-Wl,-z -Wl,now -o osmo-trx-lms osmo_trx_lms-osmo-trx.o
./device/lms/.libs/libdevice.a ./.libs/libtransceiver_common.a
../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a
../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f
/usr/lib/i386-linux-gnu/libosmoctrl.so /usr/lib/i386-linux-gnu/libosmogsm.so
-ltalloc /usr/lib/i386-linux-gnu/libosmovty.so
/usr/lib/i386-linux-gnu/libosmocore.so -lLimeSuite -pthread
[ 858s] /usr/bin/ld: ./device/lms/.libs/libdevice.a(LMSDevice.o): in function
`LMSDevice::do_clock_src_freq(ReferenceType, double)':
[ 858s] ./Transceiver52M/device/lms/LMSDevice.cpp:495: undefined reference to
`get_value_string(value_string const*, unsigned int)'
[ 858s] /usr/bin/ld: ./device/lms/.libs/libdevice.a(LMSDevice.o): in function
`LMSDevice::assign_band_desc(gsm_band)':
[ 858s] ./Transceiver52M/device/lms/LMSDevice.cpp:239: undefined reference to
`osmo_panic(char const*, ...)'
[ 858s] collect2: error: ld returned 1 exit status
[ 858s] make[4]: *** [Makefile:702: osmo-trx-lms] Error 1
[ 858s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M'
[ 858s] make[3]: *** [Makefile:860: all-recursive] Error 1
[ 858s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M'
[ 858s] make[2]: *** [Makefile:519: all-recursive] Error 1
[ 858s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[ 858s] make[1]: *** [Makefile:450: all] Error 2
[ 858s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[ 858s] dh_auto_build: make -j1 returned exit code 2
[ 858s] make: *** [debian/rules:6: build] Error 2
[ 858s] dpkg-buildpackage: error: debian/rules build subprocess returned exit
status 2
[ 858s] ### VM INTERACTION START ###
[ 861s] [ 843.103365] sysrq: Power Off
[ 861s] [ 843.158951] reboot: Power down
[ 861s] ### VM INTERACTION END ###
[ 861s]
[ 861s] lamb02 failed "build osmo-trx_1.2.0.94.c598.dsc" at Sat Oct 24
02:00:54 UTC 2020.
[ 861s]
--
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-trx in xUbuntu_16.04/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/xUbuntu_16.04/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in xUbuntu_16.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [ 259s] libtool: link: g++ -std=gnu++11 -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fPIE -fstack-protector-strong -Wformat -Werror=format-security -Wl,-Bsymbolic-functions -fPIE -pie -Wl,-z -Wl,relro -Wl,-z -Wl,now -o osmo-trx-lms osmo_trx_lms-osmo-trx.o ./device/lms/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f /usr/lib/x86_64-linux-gnu/libosmoctrl.so /usr/lib/x86_64-linux-gnu/libosmogsm.so -ltalloc /usr/lib/x86_64-linux-gnu/libosmovty.so /usr/lib/x86_64-linux-gnu/libosmocore.so -lLimeSuite -pthread [ 259s] ./device/lms/.libs/libdevice.a(LMSDevice.o): In function `LMSDevice::do_clock_src_freq(ReferenceType, double)': [ 259s] /usr/src/packages/BUILD/Transceiver52M/device/lms/LMSDevice.cpp:495: undefined reference to `get_value_string(value_string const*, unsigned int)' [ 259s] ./device/lms/.libs/libdevice.a(LMSDevice.o): In function `LMSDevice::assign_band_desc(gsm_band)': [ 259s] /usr/src/packages/BUILD/Transceiver52M/device/lms/LMSDevice.cpp:239: undefined reference to `osmo_panic(char const*, ...)' [ 259s] collect2: error: ld returned 1 exit status [ 259s] Makefile:688: recipe for target 'osmo-trx-lms' failed [ 259s] make[4]: *** [osmo-trx-lms] Error 1 [ 259s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 259s] Makefile:841: recipe for target 'all-recursive' failed [ 259s] make[3]: *** [all-recursive] Error 1 [ 259s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 259s] Makefile:519: recipe for target 'all-recursive' failed [ 259s] make[2]: *** [all-recursive] Error 1 [ 259s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 259s] Makefile:450: recipe for target 'all' failed [ 259s] make[1]: *** [all] Error 2 [ 259s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 259s] dh_auto_build: make -j1 returned exit code 2 [ 259s] debian/rules:6: recipe for target 'build' failed [ 259s] make: *** [build] Error 2 [ 259s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 259s] ### VM INTERACTION START ### [ 262s] [ 253.621603] sysrq: Power Off [ 262s] [ 253.624993] reboot: Power down [ 262s] ### VM INTERACTION END ### [ 262s] [ 262s] sheep88 failed "build osmo-trx_1.2.0.94.c598.dsc" at Sat Oct 24 02:00:45 UTC 2020. [ 262s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-trx in Debian_Unstable/x86_64
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_Unstable/x86_64
Package network:osmocom:nightly/osmo-trx failed to build in
Debian_Unstable/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-trx
Last lines of build log:
[ 412s] In file included from osmo-trx.cpp:57:
[ 412s] /usr/include/osmocom/vty/command.h:476:5: note: declared here
[ 412s] 476 | int vty_dump_xml_ref(FILE *stream) OSMO_DEPRECATED("Use
vty_dump_xml_ref_mode() instead");
[ 412s] | ^~~~
[ 413s] /bin/bash ../libtool --tag=CXX --mode=link g++ -lpthread -pthread
-I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2
-fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat
-Werror=format-security -Wl,-z,relro -Wl,-z,now -o osmo-trx-lms
osmo_trx_lms-osmo-trx.o ./device/lms/libdevice.la libtransceiver_common.la
../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la
../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl
-losmogsm -losmocore -ltalloc -losmovty -losmocore -lLimeSuite
[ 414s] libtool: link: g++ -pthread -I/usr/include/ -I/usr/include/
-I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=.
-fstack-protector-strong -Wformat -Werror=format-security -Wl,-z -Wl,relro
-Wl,-z -Wl,now -o osmo-trx-lms osmo_trx_lms-osmo-trx.o
./device/lms/.libs/libdevice.a ./.libs/libtransceiver_common.a
../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a
../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f
/usr/lib/x86_64-linux-gnu/libosmoctrl.so
/usr/lib/x86_64-linux-gnu/libosmogsm.so -ltalloc
/usr/lib/x86_64-linux-gnu/libosmovty.so
/usr/lib/x86_64-linux-gnu/libosmocore.so -lLimeSuite -pthread
[ 414s] /usr/bin/ld: ./device/lms/.libs/libdevice.a(LMSDevice.o): in function
`LMSDevice::do_clock_src_freq(ReferenceType, double)':
[ 414s] ./Transceiver52M/device/lms/LMSDevice.cpp:495: undefined reference to
`get_value_string(value_string const*, unsigned int)'
[ 414s] /usr/bin/ld: ./device/lms/.libs/libdevice.a(LMSDevice.o): in function
`LMSDevice::assign_band_desc(gsm_band)':
[ 414s] ./Transceiver52M/device/lms/LMSDevice.cpp:239: undefined reference to
`osmo_panic(char const*, ...)'
[ 414s] collect2: error: ld returned 1 exit status
[ 414s] make[4]: *** [Makefile:702: osmo-trx-lms] Error 1
[ 414s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M'
[ 414s] make[3]: *** [Makefile:860: all-recursive] Error 1
[ 414s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M'
[ 414s] make[2]: *** [Makefile:519: all-recursive] Error 1
[ 414s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[ 414s] make[1]: *** [Makefile:450: all] Error 2
[ 414s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[ 414s] dh_auto_build: error: make -j1 returned exit code 2
[ 414s] make: *** [debian/rules:6: build] Error 25
[ 414s] dpkg-buildpackage: error: debian/rules build subprocess returned exit
status 2
[ 414s] ### VM INTERACTION START ###
[ 415s] Powering off.
[ 415s] [ 398.388847] reboot: Power down
[ 415s] ### VM INTERACTION END ###
[ 415s]
[ 415s] sheep85 failed "build osmo-trx_1.2.0.94.c598.dsc" at Sat Oct 24
01:59:34 UTC 2020.
[ 415s]
--
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-trx in Debian_9.0/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_9.0/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_9.0/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [ 373s] libtool: link: g++ -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z -Wl,relro -Wl,-z -Wl,now -o osmo-trx-lms osmo_trx_lms-osmo-trx.o ./device/lms/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f /usr/lib/x86_64-linux-gnu/libosmoctrl.so /usr/lib/x86_64-linux-gnu/libosmogsm.so -ltalloc /usr/lib/x86_64-linux-gnu/libosmovty.so /usr/lib/x86_64-linux-gnu/libosmocore.so -lLimeSuite -pthread [ 373s] ./device/lms/.libs/libdevice.a(LMSDevice.o): In function `LMSDevice::do_clock_src_freq(ReferenceType, double)': [ 373s] ./Transceiver52M/device/lms/LMSDevice.cpp:495: undefined reference to `get_value_string(value_string const*, unsigned int)' [ 373s] ./device/lms/.libs/libdevice.a(LMSDevice.o): In function `LMSDevice::assign_band_desc(gsm_band)': [ 373s] ./Transceiver52M/device/lms/LMSDevice.cpp:239: undefined reference to `osmo_panic(char const*, ...)' [ 373s] collect2: error: ld returned 1 exit status [ 373s] Makefile:688: recipe for target 'osmo-trx-lms' failed [ 373s] make[4]: *** [osmo-trx-lms] Error 1 [ 373s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 373s] Makefile:841: recipe for target 'all-recursive' failed [ 373s] make[3]: *** [all-recursive] Error 1 [ 373s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 373s] Makefile:519: recipe for target 'all-recursive' failed [ 373s] make[2]: *** [all-recursive] Error 1 [ 373s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 373s] Makefile:450: recipe for target 'all' failed [ 373s] make[1]: *** [all] Error 2 [ 373s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 373s] dh_auto_build: make -j1 returned exit code 2 [ 373s] debian/rules:6: recipe for target 'build' failed [ 373s] make: *** [build] Error 2 [ 373s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 373s] ### VM INTERACTION START ### [ 376s] [ 363.200868] sysrq: Power Off [ 376s] [ 363.206552] reboot: Power down [ 376s] ### VM INTERACTION END ### [ 376s] [ 376s] lamb11 failed "build osmo-trx_1.2.0.94.c598.dsc" at Sat Oct 24 01:58:56 UTC 2020. [ 376s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-trx in xUbuntu_18.10/i586
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/xUbuntu_18.10/i586
Package network:osmocom:nightly/osmo-trx failed to build in xUbuntu_18.10/i586
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-trx
Last lines of build log:
[ 482s] In file included from osmo-trx.cpp:57:
[ 482s] /usr/include/osmocom/vty/command.h:476:5: note: declared here
[ 482s] int vty_dump_xml_ref(FILE *stream) OSMO_DEPRECATED("Use
vty_dump_xml_ref_mode() instead");
[ 482s] ^~~~
[ 483s] /bin/bash ../libtool --tag=CXX --mode=link g++ -lpthread -pthread
-I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2
-fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat
-Werror=format-security -Wl,-Bsymbolic-functions -Wl,-z,relro -Wl,-z,now -o
osmo-trx-lms osmo_trx_lms-osmo-trx.o ./device/lms/libdevice.la
libtransceiver_common.la ../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la
../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl
-losmogsm -losmocore -ltalloc -losmovty -losmocore -lLimeSuite
[ 484s] libtool: link: g++ -pthread -I/usr/include/ -I/usr/include/
-I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=.
-fstack-protector-strong -Wformat -Werror=format-security
-Wl,-Bsymbolic-functions -Wl,-z -Wl,relro -Wl,-z -Wl,now -o osmo-trx-lms
osmo_trx_lms-osmo-trx.o ./device/lms/.libs/libdevice.a
./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a
../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f
/usr/lib/i386-linux-gnu/libosmoctrl.so /usr/lib/i386-linux-gnu/libosmogsm.so
-ltalloc /usr/lib/i386-linux-gnu/libosmovty.so
/usr/lib/i386-linux-gnu/libosmocore.so -lLimeSuite -pthread
[ 484s] /usr/bin/ld: ./device/lms/.libs/libdevice.a(LMSDevice.o): in function
`LMSDevice::do_clock_src_freq(ReferenceType, double)':
[ 484s] ./Transceiver52M/device/lms/LMSDevice.cpp:495: undefined reference to
`get_value_string(value_string const*, unsigned int)'
[ 484s] /usr/bin/ld: ./device/lms/.libs/libdevice.a(LMSDevice.o): in function
`LMSDevice::assign_band_desc(gsm_band)':
[ 484s] ./Transceiver52M/device/lms/LMSDevice.cpp:239: undefined reference to
`osmo_panic(char const*, ...)'
[ 484s] collect2: error: ld returned 1 exit status
[ 484s] make[4]: *** [Makefile:702: osmo-trx-lms] Error 1
[ 484s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M'
[ 484s] make[3]: *** [Makefile:860: all-recursive] Error 1
[ 484s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M'
[ 484s] make[2]: *** [Makefile:519: all-recursive] Error 1
[ 484s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[ 484s] make[1]: *** [Makefile:450: all] Error 2
[ 484s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[ 484s] dh_auto_build: make -j1 returned exit code 2
[ 484s] make: *** [debian/rules:6: build] Error 2
[ 484s] dpkg-buildpackage: error: debian/rules build subprocess returned exit
status 2
[ 484s] ### VM INTERACTION START ###
[ 487s] [ 471.580215] sysrq: Power Off
[ 487s] [ 471.586042] reboot: Power down
[ 487s] ### VM INTERACTION END ###
[ 487s]
[ 487s] lamb59 failed "build osmo-trx_1.2.0.94.c598.dsc" at Sat Oct 24
01:56:11 UTC 2020.
[ 487s]
--
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-trx in xUbuntu_19.04/x86_64
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/xUbuntu_19.04/x86_64
Package network:osmocom:nightly/osmo-trx failed to build in xUbuntu_19.04/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-trx
Last lines of build log:
[ 425s] In file included from osmo-trx.cpp:57:
[ 425s] /usr/include/osmocom/vty/command.h:476:5: note: declared here
[ 425s] int vty_dump_xml_ref(FILE *stream) OSMO_DEPRECATED("Use
vty_dump_xml_ref_mode() instead");
[ 425s] ^~~~
[ 426s] /bin/bash ../libtool --tag=CXX --mode=link g++ -lpthread -pthread
-I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2
-fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat
-Werror=format-security -Wl,-Bsymbolic-functions -Wl,-z,relro -Wl,-z,now -o
osmo-trx-lms osmo_trx_lms-osmo-trx.o ./device/lms/libdevice.la
libtransceiver_common.la ../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la
../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl
-losmogsm -losmocore -ltalloc -losmovty -losmocore -lLimeSuite
[ 427s] libtool: link: g++ -pthread -I/usr/include/ -I/usr/include/
-I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=.
-fstack-protector-strong -Wformat -Werror=format-security
-Wl,-Bsymbolic-functions -Wl,-z -Wl,relro -Wl,-z -Wl,now -o osmo-trx-lms
osmo_trx_lms-osmo-trx.o ./device/lms/.libs/libdevice.a
./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a
../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f
/usr/lib/x86_64-linux-gnu/libosmoctrl.so
/usr/lib/x86_64-linux-gnu/libosmogsm.so -ltalloc
/usr/lib/x86_64-linux-gnu/libosmovty.so
/usr/lib/x86_64-linux-gnu/libosmocore.so -lLimeSuite -pthread
[ 427s] /usr/bin/ld: ./device/lms/.libs/libdevice.a(LMSDevice.o): in function
`LMSDevice::do_clock_src_freq(ReferenceType, double)':
[ 427s] ./Transceiver52M/device/lms/LMSDevice.cpp:495: undefined reference to
`get_value_string(value_string const*, unsigned int)'
[ 427s] /usr/bin/ld: ./device/lms/.libs/libdevice.a(LMSDevice.o): in function
`LMSDevice::assign_band_desc(gsm_band)':
[ 427s] ./Transceiver52M/device/lms/LMSDevice.cpp:239: undefined reference to
`osmo_panic(char const*, ...)'
[ 427s] collect2: error: ld returned 1 exit status
[ 427s] make[4]: *** [Makefile:702: osmo-trx-lms] Error 1
[ 427s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M'
[ 427s] make[3]: *** [Makefile:860: all-recursive] Error 1
[ 427s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M'
[ 427s] make[2]: *** [Makefile:519: all-recursive] Error 1
[ 427s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[ 427s] make[1]: *** [Makefile:450: all] Error 2
[ 427s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[ 427s] dh_auto_build: make -j1 returned exit code 2
[ 427s] make: *** [debian/rules:6: build] Error 2
[ 427s] dpkg-buildpackage: error: debian/rules build subprocess returned exit
status 2
[ 427s] ### VM INTERACTION START ###
[ 430s] [ 415.920720] sysrq: Power Off
[ 430s] [ 415.924429] reboot: Power down
[ 430s] ### VM INTERACTION END ###
[ 430s]
[ 430s] old-atreju1 failed "build osmo-trx_1.2.0.94.c598.dsc" at Sat Oct 24
01:56:05 UTC 2020.
[ 430s]
--
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-trx in openSUSE_Leap_15.1/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/openSUSE_Leap_15.1/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in openSUSE_Leap_15.1/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [ 120s] /bin/sh ../libtool --tag=CXX --mode=link g++ -lpthread -pthread -I/usr/include/libosmocore/ -I/usr/include/libosmocore/ -I/usr/include/libosmocore/ -fmessage-length=0 -grecord-gcc-switches -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -o osmo-trx-lms osmo_trx_lms-osmo-trx.o ./device/lms/libdevice.la libtransceiver_common.la ../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la ../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -ltalloc -losmovty -losmocore -lLimeSuite [ 120s] /bin/sh ../libtool --tag=CXX --mode=link g++ -lpthread -pthread -I/usr/include/libosmocore/ -I/usr/include/libosmocore/ -I/usr/include/libosmocore/ -fmessage-length=0 -grecord-gcc-switches -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -o osmo-trx-ipc osmo_trx_ipc-osmo-trx.o ./device/ipc/libdevice.la libtransceiver_common.la ../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la ../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -ltalloc -losmovty -losmocore [ 121s] libtool: link: g++ -pthread -I/usr/include/libosmocore/ -I/usr/include/libosmocore/ -I/usr/include/libosmocore/ -fmessage-length=0 -grecord-gcc-switches -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -o osmo-trx-lms osmo_trx_lms-osmo-trx.o ./device/lms/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f -losmoctrl -losmogsm -ltalloc -losmovty -losmocore -lLimeSuite -pthread [ 121s] libtool: link: g++ -pthread -I/usr/include/libosmocore/ -I/usr/include/libosmocore/ -I/usr/include/libosmocore/ -fmessage-length=0 -grecord-gcc-switches -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -o osmo-trx-ipc osmo_trx_ipc-osmo-trx.o ./device/ipc/.libs/libdevice.a -lrt ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f -losmoctrl -losmogsm -ltalloc -losmovty -losmocore -pthread [ 121s] /usr/lib64/gcc/x86_64-suse-linux/7/../../../../x86_64-suse-linux/bin/ld: ./device/lms/.libs/libdevice.a(LMSDevice.o): in function `LMSDevice::do_clock_src_freq(ReferenceType, double)': [ 121s] LMSDevice.cpp:(.text+0x4dae): undefined reference to `get_value_string(value_string const*, unsigned int)' [ 121s] /usr/lib64/gcc/x86_64-suse-linux/7/../../../../x86_64-suse-linux/bin/ld: ./device/lms/.libs/libdevice.a(LMSDevice.o): in function `LMSDevice::assign_band_desc(gsm_band)': [ 121s] LMSDevice.cpp:(.text+0xdcdf): undefined reference to `osmo_panic(char const*, ...)' [ 121s] collect2: error: ld returned 1 exit status [ 121s] make[3]: *** [Makefile:688: osmo-trx-lms] Error 1 [ 121s] make[3]: *** Waiting for unfinished jobs [ 121s] make[3]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-trx-1.2.0.94.c598/Transceiver52M' [ 121s] make[2]: *** [Makefile:840: all-recursive] Error 1 [ 121s] make[2]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-trx-1.2.0.94.c598/Transceiver52M' [ 121s] make[1]: *** [Makefile:518: all-recursive] Error 1 [ 121s] make[1]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-trx-1.2.0.94.c598' [ 121s] make: *** [Makefile:449: all] Error 2 [ 121s] error: Bad exit status from /var/tmp/rpm-tmp.lyIrki (%build) [ 121s] [ 121s] [ 121s] RPM build errors: [ 121s] Bad exit status from /var/tmp/rpm-tmp.lyIrki (%build) [ 121s] ### VM INTERACTION START ### [ 124s] [ 109.324398] sysrq: SysRq : Power Off [ 124s] [ 109.327185] reboot: Power down [ 124s] ### VM INTERACTION END ### [ 124s] [ 124s] cloud103 failed "build osmo-trx.spec" at Sat Oct 24 01:52:24 UTC 2020. [ 124s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-trx in openSUSE_Leap_15.2/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/openSUSE_Leap_15.2/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in openSUSE_Leap_15.2/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [ 85s] libtool: link: g++ -pthread -I/usr/include/libosmocore/ -I/usr/include/libosmocore/ -I/usr/include/libosmocore/ -fmessage-length=0 -grecord-gcc-switches -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -o osmo-trx-usrp1 osmo_trx_usrp1-osmo-trx.o ./device/usrp1/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f -losmoctrl -losmogsm -ltalloc -losmovty -losmocore -lusrp -lusb-1.0 -pthread [ 85s] /bin/sh ../libtool --tag=CXX --mode=link g++ -lpthread -pthread -I/usr/include/libosmocore/ -I/usr/include/libosmocore/ -I/usr/include/libosmocore/ -fmessage-length=0 -grecord-gcc-switches -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -o osmo-trx-lms osmo_trx_lms-osmo-trx.o ./device/lms/libdevice.la libtransceiver_common.la ../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la ../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -ltalloc -losmovty -losmocore -lLimeSuite [ 85s] /bin/sh ../libtool --tag=CXX --mode=link g++ -lpthread -pthread -I/usr/include/libosmocore/ -I/usr/include/libosmocore/ -I/usr/include/libosmocore/ -fmessage-length=0 -grecord-gcc-switches -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -o osmo-trx-ipc osmo_trx_ipc-osmo-trx.o ./device/ipc/libdevice.la libtransceiver_common.la ../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la ../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -ltalloc -losmovty -losmocore [ 85s] libtool: link: g++ -pthread -I/usr/include/libosmocore/ -I/usr/include/libosmocore/ -I/usr/include/libosmocore/ -fmessage-length=0 -grecord-gcc-switches -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -o osmo-trx-ipc osmo_trx_ipc-osmo-trx.o ./device/ipc/.libs/libdevice.a -lrt ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f -losmoctrl -losmogsm -ltalloc -losmovty -losmocore -pthread [ 86s] libtool: link: g++ -pthread -I/usr/include/libosmocore/ -I/usr/include/libosmocore/ -I/usr/include/libosmocore/ -fmessage-length=0 -grecord-gcc-switches -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -o osmo-trx-lms osmo_trx_lms-osmo-trx.o ./device/lms/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f -losmoctrl -losmogsm -ltalloc -losmovty -losmocore -lLimeSuite -pthread [ 86s] /usr/lib64/gcc/x86_64-suse-linux/7/../../../../x86_64-suse-linux/bin/ld: ./device/lms/.libs/libdevice.a(LMSDevice.o): in function `LMSDevice::do_clock_src_freq(ReferenceType, double)': [ 86s] LMSDevice.cpp:(.text+0x4dae): undefined reference to `get_value_string(value_string const*, unsigned int)' [ 86s] /usr/lib64/gcc/x86_64-suse-linux/7/../../../../x86_64-suse-linux/bin/ld: ./device/lms/.libs/libdevice.a(LMSDevice.o): in function `LMSDevice::assign_band_desc(gsm_band)': [ 86s] LMSDevice.cpp:(.text+0xdcdf): undefined reference to `osmo_panic(char const*, ...)' [ 86s] collect2: error: ld returned 1 exit status [ 86s] make[3]: *** [Makefile:688: osmo-trx-lms] Error 1 [ 86s] make[3]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-trx-1.2.0.94.c598/Transceiver52M' [ 86s] make[2]: *** [Makefile:840: all-recursive] Error 1 [ 86s] make[2]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-trx-1.2.0.94.c598/Transceiver52M' [ 86s] make[1]: *** [Makefile:518: all-recursive] Error 1 [ 86s] make[1]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-trx-1.2.0.94.c598' [ 86s] make: *** [Makefile:449: all] Error 2 [ 86s] error: Bad exit status from /var/tmp/rpm-tmp.Clekd6 (%build) [ 86s] [ 86s] [ 86s] RPM build errors: [ 86s] Bad exit status from /var/tmp/rpm-tmp.Clekd6 (%build) [ 86s] ### VM INTERACTION START ### [ 89s] [ 81.371841] sysrq: Power Off [ 89s] [ 81.374772] reboot: Power down [ 89s] ### VM INTERACTION END ### [ 89s] [ 89s] build77 failed "build osmo-trx.spec" at Sat Oct 24 01:51:46 UTC 2020. [ 89s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openS
Build failure of network:osmocom:nightly/osmo-trx in Debian_9.0/i586
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_9.0/i586 Package network:osmocom:nightly/osmo-trx failed to build in Debian_9.0/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [ 427s] libtool: link: g++ -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z -Wl,relro -Wl,-z -Wl,now -o osmo-trx-lms osmo_trx_lms-osmo-trx.o ./device/lms/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f /usr/lib/i386-linux-gnu/libosmoctrl.so /usr/lib/i386-linux-gnu/libosmogsm.so -ltalloc /usr/lib/i386-linux-gnu/libosmovty.so /usr/lib/i386-linux-gnu/libosmocore.so -lLimeSuite -pthread [ 428s] ./device/lms/.libs/libdevice.a(LMSDevice.o): In function `LMSDevice::do_clock_src_freq(ReferenceType, double)': [ 428s] ./Transceiver52M/device/lms/LMSDevice.cpp:495: undefined reference to `get_value_string(value_string const*, unsigned int)' [ 428s] ./device/lms/.libs/libdevice.a(LMSDevice.o): In function `LMSDevice::assign_band_desc(gsm_band)': [ 428s] ./Transceiver52M/device/lms/LMSDevice.cpp:239: undefined reference to `osmo_panic(char const*, ...)' [ 428s] collect2: error: ld returned 1 exit status [ 428s] Makefile:688: recipe for target 'osmo-trx-lms' failed [ 428s] make[4]: *** [osmo-trx-lms] Error 1 [ 428s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 428s] Makefile:841: recipe for target 'all-recursive' failed [ 428s] make[3]: *** [all-recursive] Error 1 [ 428s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 428s] Makefile:519: recipe for target 'all-recursive' failed [ 428s] make[2]: *** [all-recursive] Error 1 [ 428s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 428s] Makefile:450: recipe for target 'all' failed [ 428s] make[1]: *** [all] Error 2 [ 428s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 428s] dh_auto_build: make -j1 returned exit code 2 [ 428s] debian/rules:6: recipe for target 'build' failed [ 428s] make: *** [build] Error 2 [ 428s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 428s] ### VM INTERACTION START ### [ 431s] [ 418.321647] sysrq: Power Off [ 431s] [ 418.327815] reboot: Power down [ 431s] ### VM INTERACTION END ### [ 431s] [ 431s] lamb06 failed "build osmo-trx_1.2.0.94.c598.dsc" at Sat Oct 24 01:49:47 UTC 2020. [ 431s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-trx in openSUSE_Tumbleweed/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/openSUSE_Tumbleweed/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in openSUSE_Tumbleweed/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [ 121s] /bin/sh ../libtool --tag=CXX --mode=link g++ -lpthread -I/usr/include/libosmocore/ -pthread -I/usr/include/libosmocore/ -I/usr/include/libosmocore/ -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -flto=auto -o osmo-trx-usrp1 osmo_trx_usrp1-osmo-trx.o ./device/usrp1/libdevice.la libtransceiver_common.la ../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la ../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -ltalloc -losmovty -losmocore -lusrp -lusb-1.0 [ 121s] /bin/sh ../libtool --tag=CXX --mode=link g++ -lpthread -I/usr/include/libosmocore/ -pthread -I/usr/include/libosmocore/ -I/usr/include/libosmocore/ -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -flto=auto -o osmo-trx-lms osmo_trx_lms-osmo-trx.o ./device/lms/libdevice.la libtransceiver_common.la ../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la ../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -ltalloc -losmovty -losmocore -lLimeSuite [ 121s] /bin/sh ../libtool --tag=CXX --mode=link g++ -lpthread -I/usr/include/libosmocore/ -pthread -I/usr/include/libosmocore/ -I/usr/include/libosmocore/ -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -flto=auto -o osmo-trx-ipc osmo_trx_ipc-osmo-trx.o ./device/ipc/libdevice.la libtransceiver_common.la ../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la ../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -ltalloc -losmovty -losmocore [ 121s] libtool: link: g++ -I/usr/include/libosmocore/ -pthread -I/usr/include/libosmocore/ -I/usr/include/libosmocore/ -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -flto=auto -o osmo-trx-usrp1 osmo_trx_usrp1-osmo-trx.o ./device/usrp1/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f -losmoctrl -losmogsm -ltalloc -losmovty -losmocore -lusrp -lusb-1.0 -pthread [ 121s] libtool: link: g++ -I/usr/include/libosmocore/ -pthread -I/usr/include/libosmocore/ -I/usr/include/libosmocore/ -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -flto=auto -o osmo-trx-ipc osmo_trx_ipc-osmo-trx.o ./device/ipc/.libs/libdevice.a -lrt ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f -losmoctrl -losmogsm -ltalloc -losmovty -losmocore -pthread [ 121s] libtool: link: g++ -I/usr/include/libosmocore/ -pthread -I/usr/include/libosmocore/ -I/usr/include/libosmocore/ -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -flto=auto -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f -losmoctrl -losmogsm -ltalloc -losmovty -losmocore -luhd -lboost_system -pthread [ 121s] libtool: link: g++ -I/usr/include/libosmocore/ -pthread -I/usr/include/libosmocore/ -I/usr/include/libosmocore/ -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -flto=auto -o osmo-trx-lms osmo_trx_lms-osmo-trx.o ./device/lms/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f -losmoctrl -losmogsm -ltalloc -losmovty -losmocore -lLimeSuite -pthread [ 128s] /usr/lib64/gcc/x86_64-suse-linux/10/../../../../x86_64-suse-linux/bin/ld: /tmp/osmo-trx-lms.J9cGRD.ltrans0.ltrans.o: in function `LMSDevice::get_dev_band_desc(dev_band_desc&)': [ 128s] /home/abuild/rpmbuild/BUILD/osmo-trx-1.2.0.94.c598/Transceiver52M/LMSDevice.cpp:239: undefined reference to `osmo_panic(char const*, ...)' [ 128s] collect2: error: ld returned 1 exit status [ 128s] make[3]: *** [Makefile:701: os
Build failure of network:osmocom:nightly/osmo-trx in xUbuntu_16.04/i586
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/xUbuntu_16.04/i586 Package network:osmocom:nightly/osmo-trx failed to build in xUbuntu_16.04/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [ 386s] libtool: link: g++ -std=gnu++11 -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fPIE -fstack-protector-strong -Wformat -Werror=format-security -Wl,-Bsymbolic-functions -fPIE -pie -Wl,-z -Wl,relro -Wl,-z -Wl,now -o osmo-trx-lms osmo_trx_lms-osmo-trx.o ./device/lms/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f /usr/lib/i386-linux-gnu/libosmoctrl.so /usr/lib/i386-linux-gnu/libosmogsm.so -ltalloc /usr/lib/i386-linux-gnu/libosmovty.so /usr/lib/i386-linux-gnu/libosmocore.so -lLimeSuite -pthread [ 387s] ./device/lms/.libs/libdevice.a(LMSDevice.o): In function `LMSDevice::do_clock_src_freq(ReferenceType, double)': [ 387s] /usr/src/packages/BUILD/Transceiver52M/device/lms/LMSDevice.cpp:495: undefined reference to `get_value_string(value_string const*, unsigned int)' [ 387s] ./device/lms/.libs/libdevice.a(LMSDevice.o): In function `LMSDevice::assign_band_desc(gsm_band)': [ 387s] /usr/src/packages/BUILD/Transceiver52M/device/lms/LMSDevice.cpp:239: undefined reference to `osmo_panic(char const*, ...)' [ 387s] collect2: error: ld returned 1 exit status [ 387s] Makefile:688: recipe for target 'osmo-trx-lms' failed [ 387s] make[4]: *** [osmo-trx-lms] Error 1 [ 387s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 387s] Makefile:841: recipe for target 'all-recursive' failed [ 387s] make[3]: *** [all-recursive] Error 1 [ 387s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 387s] Makefile:519: recipe for target 'all-recursive' failed [ 387s] make[2]: *** [all-recursive] Error 1 [ 387s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 387s] Makefile:450: recipe for target 'all' failed [ 387s] make[1]: *** [all] Error 2 [ 387s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 387s] dh_auto_build: make -j1 returned exit code 2 [ 387s] debian/rules:6: recipe for target 'build' failed [ 387s] make: *** [build] Error 2 [ 387s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 387s] ### VM INTERACTION START ### [ 390s] [ 376.233358] sysrq: Power Off [ 390s] [ 376.236149] reboot: Power down [ 390s] ### VM INTERACTION END ### [ 390s] [ 390s] cloud114 failed "build osmo-trx_1.2.0.94.c598.dsc" at Sat Oct 24 01:47:16 UTC 2020. [ 390s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-trx in xUbuntu_18.04/i586
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/xUbuntu_18.04/i586 Package network:osmocom:nightly/osmo-trx failed to build in xUbuntu_18.04/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [ 351s] libtool: link: g++ -pthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-Bsymbolic-functions -Wl,-z -Wl,relro -Wl,-z -Wl,now -o osmo-trx-lms osmo_trx_lms-osmo-trx.o ./device/lms/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f /usr/lib/i386-linux-gnu/libosmoctrl.so /usr/lib/i386-linux-gnu/libosmogsm.so -ltalloc /usr/lib/i386-linux-gnu/libosmovty.so /usr/lib/i386-linux-gnu/libosmocore.so -lLimeSuite -pthread [ 351s] ./device/lms/.libs/libdevice.a(LMSDevice.o): In function `LMSDevice::do_clock_src_freq(ReferenceType, double)': [ 351s] ./Transceiver52M/device/lms/LMSDevice.cpp:495: undefined reference to `get_value_string(value_string const*, unsigned int)' [ 351s] ./device/lms/.libs/libdevice.a(LMSDevice.o): In function `LMSDevice::assign_band_desc(gsm_band)': [ 351s] ./Transceiver52M/device/lms/LMSDevice.cpp:239: undefined reference to `osmo_panic(char const*, ...)' [ 351s] collect2: error: ld returned 1 exit status [ 351s] Makefile:688: recipe for target 'osmo-trx-lms' failed [ 351s] make[4]: *** [osmo-trx-lms] Error 1 [ 351s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 351s] Makefile:841: recipe for target 'all-recursive' failed [ 351s] make[3]: *** [all-recursive] Error 1 [ 351s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 351s] Makefile:519: recipe for target 'all-recursive' failed [ 351s] make[2]: *** [all-recursive] Error 1 [ 351s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 351s] Makefile:450: recipe for target 'all' failed [ 351s] make[1]: *** [all] Error 2 [ 351s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 351s] dh_auto_build: make -j1 returned exit code 2 [ 351s] debian/rules:6: recipe for target 'build' failed [ 351s] make: *** [build] Error 2 [ 351s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 351s] ### VM INTERACTION START ### [ 354s] [ 346.382980] sysrq: Power Off [ 354s] [ 346.386005] reboot: Power down [ 354s] ### VM INTERACTION END ### [ 354s] [ 354s] build77 failed "build osmo-trx_1.2.0.94.c598.dsc" at Sat Oct 24 01:44:29 UTC 2020. [ 354s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-trx in openSUSE_Leap_15.1_ARM/aarch64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/openSUSE_Leap_15.1_ARM/aarch64 Package network:osmocom:nightly/osmo-trx failed to build in openSUSE_Leap_15.1_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [ 160s] /bin/sh ../libtool --tag=CXX --mode=link g++ -lpthread -pthread -I/usr/include/libosmocore/ -I/usr/include/libosmocore/ -I/usr/include/libosmocore/ -fmessage-length=0 -grecord-gcc-switches -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -o osmo-trx-lms osmo_trx_lms-osmo-trx.o ./device/lms/libdevice.la libtransceiver_common.la ../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la ../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -ltalloc -losmovty -losmocore -lLimeSuite [ 161s] libtool: link: g++ -pthread -I/usr/include/libosmocore/ -I/usr/include/libosmocore/ -I/usr/include/libosmocore/ -fmessage-length=0 -grecord-gcc-switches -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -o osmo-trx-usrp1 osmo_trx_usrp1-osmo-trx.o ./device/usrp1/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f -losmoctrl -losmogsm -ltalloc -losmovty -losmocore -lusrp -lusb-1.0 -pthread [ 161s] libtool: link: g++ -pthread -I/usr/include/libosmocore/ -I/usr/include/libosmocore/ -I/usr/include/libosmocore/ -fmessage-length=0 -grecord-gcc-switches -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f -losmoctrl -losmogsm -ltalloc -losmovty -losmocore -luhd -pthread [ 161s] libtool: link: g++ -pthread -I/usr/include/libosmocore/ -I/usr/include/libosmocore/ -I/usr/include/libosmocore/ -fmessage-length=0 -grecord-gcc-switches -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -o osmo-trx-ipc osmo_trx_ipc-osmo-trx.o ./device/ipc/.libs/libdevice.a -lrt ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f -losmoctrl -losmogsm -ltalloc -losmovty -losmocore -pthread [ 161s] libtool: link: g++ -pthread -I/usr/include/libosmocore/ -I/usr/include/libosmocore/ -I/usr/include/libosmocore/ -fmessage-length=0 -grecord-gcc-switches -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -o osmo-trx-lms osmo_trx_lms-osmo-trx.o ./device/lms/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f -losmoctrl -losmogsm -ltalloc -losmovty -losmocore -lLimeSuite -pthread [ 161s] /usr/lib64/gcc/aarch64-suse-linux/7/../../../../aarch64-suse-linux/bin/ld: ./device/lms/.libs/libdevice.a(LMSDevice.o): in function `LMSDevice::do_clock_src_freq(ReferenceType, double)': [ 161s] LMSDevice.cpp:(.text+0x3c10): undefined reference to `get_value_string(value_string const*, unsigned int)' [ 161s] /usr/lib64/gcc/aarch64-suse-linux/7/../../../../aarch64-suse-linux/bin/ld: ./device/lms/.libs/libdevice.a(LMSDevice.o): in function `LMSDevice::assign_band_desc(gsm_band)': [ 161s] LMSDevice.cpp:(.text+0xa3dc): undefined reference to `osmo_panic(char const*, ...)' [ 161s] collect2: error: ld returned 1 exit status [ 161s] make[3]: *** [Makefile:688: osmo-trx-lms] Error 1 [ 161s] make[3]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-trx-1.2.0.94.c598/Transceiver52M' [ 161s] make[2]: *** [Makefile:840: all-recursive] Error 1 [ 161s] make[2]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-trx-1.2.0.94.c598/Transceiver52M' [ 161s] make[1]: *** [Makefile:518: all-recursive] Error 1 [ 161s] make[1]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-trx-1.2.0.94.c598' [ 161s] make: *** [Makefile:449: all] Error 2 [ 161s] error: Bad exit status from /var/tmp/rpm-tmp.Cvj49F (%build) [ 161s] [ 161s] [ 161s] RPM build errors: [ 161s] Bad exit status from /var/tmp/rpm-tmp.Cvj49F (%build) [ 162s] ### VM INTERACTION START ### [ 165s] [ 149.221492] sysrq: SysRq : Power Off [ 165s] [ 149.223202] reboot: Power down [ 165s] ### VM INTERACTION END ### [ 165s] [ 165s] obs-arm-9 failed "build osmo-trx.spec" at Sat Oct 24 01:43:44 UTC 2020. [ 165s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Bu
Build failure of network:osmocom:nightly/osmo-trx in openSUSE_Factory_ARM/aarch64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/openSUSE_Factory_ARM/aarch64 Package network:osmocom:nightly/osmo-trx failed to build in openSUSE_Factory_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [ 123s] | ^~~~ [ 123s] libtool: link: g++ -I/usr/include/libosmocore/ -pthread -I/usr/include/libosmocore/ -I/usr/include/libosmocore/ -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -flto=auto -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f -losmoctrl -losmogsm -ltalloc -losmovty -losmocore -luhd -lboost_system -pthread [ 123s] libtool: link: g++ -I/usr/include/libosmocore/ -pthread -I/usr/include/libosmocore/ -I/usr/include/libosmocore/ -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -flto=auto -o osmo-trx-usrp1 osmo_trx_usrp1-osmo-trx.o ./device/usrp1/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f -losmoctrl -losmogsm -ltalloc -losmovty -losmocore -lusrp -lusb-1.0 -pthread [ 123s] libtool: link: g++ -I/usr/include/libosmocore/ -pthread -I/usr/include/libosmocore/ -I/usr/include/libosmocore/ -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -flto=auto -o osmo-trx-lms osmo_trx_lms-osmo-trx.o ./device/lms/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f -losmoctrl -losmogsm -ltalloc -losmovty -losmocore -lLimeSuite -pthread [ 123s] /bin/sh ../libtool --tag=CXX --mode=link g++ -lpthread -I/usr/include/libosmocore/ -pthread -I/usr/include/libosmocore/ -I/usr/include/libosmocore/ -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -flto=auto -o osmo-trx-ipc osmo_trx_ipc-osmo-trx.o ./device/ipc/libdevice.la libtransceiver_common.la ../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la ../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -ltalloc -losmovty -losmocore [ 124s] libtool: link: g++ -I/usr/include/libosmocore/ -pthread -I/usr/include/libosmocore/ -I/usr/include/libosmocore/ -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -flto=auto -o osmo-trx-ipc osmo_trx_ipc-osmo-trx.o ./device/ipc/.libs/libdevice.a -lrt ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f -losmoctrl -losmogsm -ltalloc -losmovty -losmocore -pthread [ 137s] /usr/lib64/gcc/aarch64-suse-linux/10/../../../../aarch64-suse-linux/bin/ld: /tmp/osmo-trx-lms.mo9uGb.ltrans0.ltrans.o: in function `LMSDevice::get_dev_band_desc(dev_band_desc&)': [ 137s] /home/abuild/rpmbuild/BUILD/osmo-trx-1.2.0.94.c598/Transceiver52M/LMSDevice.cpp:239: undefined reference to `osmo_panic(char const*, ...)' [ 137s] collect2: error: ld returned 1 exit status [ 137s] make[3]: *** [Makefile:701: osmo-trx-lms] Error 1 [ 137s] make[3]: *** Waiting for unfinished jobs [ 140s] make[3]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-trx-1.2.0.94.c598/Transceiver52M' [ 140s] make[2]: *** [Makefile:859: all-recursive] Error 1 [ 140s] make[2]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-trx-1.2.0.94.c598/Transceiver52M' [ 140s] make[1]: *** [Makefile:518: all-recursive] Error 1 [ 140s] make[1]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-trx-1.2.0.94.c598' [ 140s] make: *** [Makefile:449: all] Error 2 [ 140s] error: Bad exit status from /var/tmp/rpm-tmp.dGIlJr (%build) [ 140s] [ 140s] [ 140s] RPM build errors: [ 140s] Bad exit status from /var/tmp/rpm-tmp.dGIlJr (%build) [ 140s] ### VM INTERACTION START ### [ 143s] [ 126.788688] sysrq: Power Off [ 143s] [ 126.817635] reboot: Power down [ 143s] ### VM INTERACTION END ### [ 143s] [ 143s] obs-arm-8 failed "build osmo-trx.spec" at Sat Oct 24 01:37:19 UTC 2020. [ 143s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-trx in openSUSE_Tumbleweed/i586
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/openSUSE_Tumbleweed/i586 Package network:osmocom:nightly/osmo-trx failed to build in openSUSE_Tumbleweed/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [ 75s] /bin/sh ../libtool --tag=CXX --mode=link g++ -lpthread -I/usr/include/libosmocore/ -pthread -I/usr/include/libosmocore/ -I/usr/include/libosmocore/ -fomit-frame-pointer -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -flto=auto -o osmo-trx-usrp1 osmo_trx_usrp1-osmo-trx.o ./device/usrp1/libdevice.la libtransceiver_common.la ../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la ../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -ltalloc -losmovty -losmocore -lusrp -lusb-1.0 [ 75s] /bin/sh ../libtool --tag=CXX --mode=link g++ -lpthread -I/usr/include/libosmocore/ -pthread -I/usr/include/libosmocore/ -I/usr/include/libosmocore/ -fomit-frame-pointer -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -flto=auto -o osmo-trx-lms osmo_trx_lms-osmo-trx.o ./device/lms/libdevice.la libtransceiver_common.la ../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la ../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -ltalloc -losmovty -losmocore -lLimeSuite [ 75s] /bin/sh ../libtool --tag=CXX --mode=link g++ -lpthread -I/usr/include/libosmocore/ -pthread -I/usr/include/libosmocore/ -I/usr/include/libosmocore/ -fomit-frame-pointer -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -flto=auto -o osmo-trx-ipc osmo_trx_ipc-osmo-trx.o ./device/ipc/libdevice.la libtransceiver_common.la ../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la ../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -ltalloc -losmovty -losmocore [ 75s] libtool: link: g++ -I/usr/include/libosmocore/ -pthread -I/usr/include/libosmocore/ -I/usr/include/libosmocore/ -fomit-frame-pointer -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -flto=auto -o osmo-trx-usrp1 osmo_trx_usrp1-osmo-trx.o ./device/usrp1/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f -losmoctrl -losmogsm -ltalloc -losmovty -losmocore -lusrp -lusb-1.0 -pthread [ 75s] libtool: link: g++ -I/usr/include/libosmocore/ -pthread -I/usr/include/libosmocore/ -I/usr/include/libosmocore/ -fomit-frame-pointer -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -flto=auto -o osmo-trx-lms osmo_trx_lms-osmo-trx.o ./device/lms/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f -losmoctrl -losmogsm -ltalloc -losmovty -losmocore -lLimeSuite -pthread [ 75s] libtool: link: g++ -I/usr/include/libosmocore/ -pthread -I/usr/include/libosmocore/ -I/usr/include/libosmocore/ -fomit-frame-pointer -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -flto=auto -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f -losmoctrl -losmogsm -ltalloc -losmovty -losmocore -luhd -lboost_system -pthread [ 75s] libtool: link: g++ -I/usr/include/libosmocore/ -pthread -I/usr/include/libosmocore/ -I/usr/include/libosmocore/ -fomit-frame-pointer -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -flto=auto -o osmo-trx-ipc osmo_trx_ipc-osmo-trx.o ./device/ipc/.libs/libdevice.a -lrt ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f -losmoctrl -losmogsm -ltalloc -losmovty -losmocore -pthread [ 82s] /usr/lib/gcc/i586-suse-linux/10/../../../../i586-suse-linux/bin/ld: /tmp/osmo-trx-lms.Vasghe.ltrans0.ltrans.o: in function `LMSDevice::get_dev_band_desc(dev_band_desc&)': [ 82s] /home/abuild/rpmbuild/BUILD/osmo-trx-1.2.0.94.c598/Transceiver52M/LMSDevice.cpp:239: undefined
Change in osmo-gsm-manuals[master]: chapters/vty: add IPv4/mask and IPv6/mask examples
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/20877 ) Change subject: chapters/vty: add IPv4/mask and IPv6/mask examples .. chapters/vty: add IPv4/mask and IPv6/mask examples Change-Id: I0946cf8629c4a77dfa8e9be90da85c2988ecef38 --- M common/chapters/vty.adoc 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/77/20877/1 diff --git a/common/chapters/vty.adoc b/common/chapters/vty.adoc index dec3be2..6fe31a8 100644 --- a/common/chapters/vty.adoc +++ b/common/chapters/vty.adoc @@ -57,6 +57,9 @@ |=== |Pattern|Example|Explanation |`A.B.C.D`|`127.0.0.1`|An IPv4 address +|`A.B.C.D/M`|`192.168.1.0/24`|An IPv4 address and mask +|`X:X::X:X`|`::1`|An IPv6 address +|`X:X::X:X/M`|`::1/128`|An IPv6 address and mask |`TEXT`|`example01`|A single string without any spaces, tabs |`.TEXT`|`Some information`|A line of text |`(OptionA\|OptionB\|OptionC)`|`OptionA`|A choice between a list of available options -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/20877 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I0946cf8629c4a77dfa8e9be90da85c2988ecef38 Gerrit-Change-Number: 20877 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange
Change in osmo-trx[master]: device: drop unreasonable LIBOSMO{CTRL, VTY}_{CFLAGS, LIBS}
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-trx/+/20875 )
Change subject: device: drop unreasonable LIBOSMO{CTRL,VTY}_{CFLAGS,LIBS}
..
device: drop unreasonable LIBOSMO{CTRL,VTY}_{CFLAGS,LIBS}
Neither VTY nor CTRL API is used in device specific code, excluding
the 'uhd' where osmo_cpu_sched_vty_apply_localthread() is called.
Change-Id: I568b443da4b96c005734d749faa22b9c7440f951
---
M Transceiver52M/device/common/Makefile.am
M Transceiver52M/device/ipc/Makefile.am
M Transceiver52M/device/ipc/uhdwrap.cpp
M Transceiver52M/device/lms/Makefile.am
M Transceiver52M/device/uhd/Makefile.am
M Transceiver52M/device/usrp1/Makefile.am
6 files changed, 7 insertions(+), 9 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/75/20875/1
diff --git a/Transceiver52M/device/common/Makefile.am
b/Transceiver52M/device/common/Makefile.am
index 3c9324e..4d29e98 100644
--- a/Transceiver52M/device/common/Makefile.am
+++ b/Transceiver52M/device/common/Makefile.am
@@ -1,7 +1,7 @@
include $(top_srcdir)/Makefile.common
AM_CPPFLAGS = -Wall $(STD_DEFINES_AND_INCLUDES)
-AM_CXXFLAGS = -lpthread $(LIBOSMOCORE_CFLAGS) $(LIBOSMOCTRL_CFLAGS)
$(LIBOSMOVTY_CFLAGS)
+AM_CXXFLAGS = -lpthread $(LIBOSMOCORE_CFLAGS)
noinst_HEADERS = radioDevice.h smpl_buf.h
diff --git a/Transceiver52M/device/ipc/Makefile.am
b/Transceiver52M/device/ipc/Makefile.am
index e4dc51a..4fe0090 100644
--- a/Transceiver52M/device/ipc/Makefile.am
+++ b/Transceiver52M/device/ipc/Makefile.am
@@ -1,8 +1,8 @@
include $(top_srcdir)/Makefile.common
AM_CPPFLAGS = -Wall $(STD_DEFINES_AND_INCLUDES) -I${srcdir}/../common
-AM_CFLAGS = -lpthread $(LIBOSMOCORE_CFLAGS) $(LIBOSMOCTRL_CFLAGS)
$(LIBOSMOVTY_CFLAGS)
-AM_CXXFLAGS = -lpthread $(LIBOSMOCORE_CFLAGS) $(LIBOSMOCTRL_CFLAGS)
$(LIBOSMOVTY_CFLAGS)
+AM_CFLAGS = -lpthread $(LIBOSMOCORE_CFLAGS)
+AM_CXXFLAGS = -lpthread $(LIBOSMOCORE_CFLAGS)
AM_LDFLAGS = -lpthread -lrt
noinst_HEADERS = IPCDevice.h shm.h ipc_shm.h ipc_chan.h ipc_sock.h
@@ -32,8 +32,7 @@
ipc_driver_test_LDADD = \
shm.lo \
$(LIBOSMOCORE_LIBS) \
- $(LIBOSMOCTRL_LIBS) \
- $(LIBOSMOVTY_LIBS)
+ $(NULL)
ipc_driver_test_CXXFLAGS = $(AM_CXXFLAGS) $(UHD_CFLAGS)
ipc_driver_test_CPPFLAGS = $(AM_CPPFLAGS) $(UHD_CFLAGS)
ipc_driver_test_CFLAGS = $(AM_CFLAGS) $(UHD_CFLAGS)
diff --git a/Transceiver52M/device/ipc/uhdwrap.cpp
b/Transceiver52M/device/ipc/uhdwrap.cpp
index 130f80a..d7114da 100644
--- a/Transceiver52M/device/ipc/uhdwrap.cpp
+++ b/Transceiver52M/device/ipc/uhdwrap.cpp
@@ -31,7 +31,6 @@
#include "../uhd/UHDDevice.h"
#include "uhdwrap.h"
-#include "trx_vty.h"
#include "Logger.h"
#include "Threads.h"
#include "Utils.h"
diff --git a/Transceiver52M/device/lms/Makefile.am
b/Transceiver52M/device/lms/Makefile.am
index 77fd0e9..6665077 100644
--- a/Transceiver52M/device/lms/Makefile.am
+++ b/Transceiver52M/device/lms/Makefile.am
@@ -1,7 +1,7 @@
include $(top_srcdir)/Makefile.common
AM_CPPFLAGS = -Wall $(STD_DEFINES_AND_INCLUDES) -I${srcdir}/../common
-AM_CXXFLAGS = -lpthread $(LIBOSMOCORE_CFLAGS) $(LIBOSMOCTRL_CFLAGS)
$(LIBOSMOVTY_CFLAGS) $(LMS_CFLAGS)
+AM_CXXFLAGS = -lpthread $(LIBOSMOCORE_CFLAGS) $(LMS_CFLAGS)
noinst_HEADERS = LMSDevice.h
diff --git a/Transceiver52M/device/uhd/Makefile.am
b/Transceiver52M/device/uhd/Makefile.am
index ab63a4a..21df631 100644
--- a/Transceiver52M/device/uhd/Makefile.am
+++ b/Transceiver52M/device/uhd/Makefile.am
@@ -1,7 +1,7 @@
include $(top_srcdir)/Makefile.common
AM_CPPFLAGS = -Wall $(STD_DEFINES_AND_INCLUDES) -I${srcdir}/../common
-AM_CXXFLAGS = -lpthread $(LIBOSMOCORE_CFLAGS) $(LIBOSMOCTRL_CFLAGS)
$(LIBOSMOVTY_CFLAGS) $(UHD_CFLAGS)
+AM_CXXFLAGS = -lpthread $(LIBOSMOCORE_CFLAGS) $(LIBOSMOVTY_CFLAGS)
$(UHD_CFLAGS)
noinst_HEADERS = UHDDevice.h
diff --git a/Transceiver52M/device/usrp1/Makefile.am
b/Transceiver52M/device/usrp1/Makefile.am
index 24760f7..ba93c7e 100644
--- a/Transceiver52M/device/usrp1/Makefile.am
+++ b/Transceiver52M/device/usrp1/Makefile.am
@@ -1,7 +1,7 @@
include $(top_srcdir)/Makefile.common
AM_CPPFLAGS = -Wall $(STD_DEFINES_AND_INCLUDES) -I${srcdir}/../common
-AM_CXXFLAGS = -lpthread $(LIBOSMOCORE_CFLAGS) $(LIBOSMOCTRL_CFLAGS)
$(LIBOSMOVTY_CFLAGS) $(USRP_CFLAGS)
+AM_CXXFLAGS = -lpthread $(LIBOSMOCORE_CFLAGS) $(USRP_CFLAGS)
rev2dir = $(datadir)/usrp/rev2
rev4dir = $(datadir)/usrp/rev4
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/20875
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I568b443da4b96c005734d749faa22b9c7440f951
Gerrit-Change-Number: 20875
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
Change in osmo-trx[master]: device/uhd: re-introduce OSMO_ASSERT() in async_event_loop()
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-trx/+/20874 )
Change subject: device/uhd: re-introduce OSMO_ASSERT() in async_event_loop()
..
device/uhd: re-introduce OSMO_ASSERT() in async_event_loop()
It was removed in change [1] without any explanation...
[1] Change-Id: Ice63d3499026293ade8aad675ff7a883bcdd5756
[1] Git hash: 1e17c4fb0a77dcee49a7cd566dca7e8f48f6d8e7
Change-Id: I424233074cad42ae1520c92d6e627eb983303478
---
M Transceiver52M/device/uhd/UHDDevice.cpp
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/74/20874/1
diff --git a/Transceiver52M/device/uhd/UHDDevice.cpp
b/Transceiver52M/device/uhd/UHDDevice.cpp
index 010fa8c..332e14e 100644
--- a/Transceiver52M/device/uhd/UHDDevice.cpp
+++ b/Transceiver52M/device/uhd/UHDDevice.cpp
@@ -145,7 +145,7 @@
void *async_event_loop(uhd_device *dev)
{
set_selfthread_name("UHDAsyncEvent");
- osmo_cpu_sched_vty_apply_localthread();
+ OSMO_ASSERT(osmo_cpu_sched_vty_apply_localthread() == 0);
while (1) {
dev->recv_async_msg();
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/20874
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I424233074cad42ae1520c92d6e627eb983303478
Gerrit-Change-Number: 20874
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
Change in osmo-trx[master]: device/common/Makefile.am: remove $(LMS_CFLAGS) from AM_CXXFLAGS
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/20873 ) Change subject: device/common/Makefile.am: remove $(LMS_CFLAGS) from AM_CXXFLAGS .. device/common/Makefile.am: remove $(LMS_CFLAGS) from AM_CXXFLAGS This is device-independent code, so it should not be here. Change-Id: I1ffc3431a9a1a46c74c354b3f8a256684bfcbe73 --- M Transceiver52M/device/common/Makefile.am 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/73/20873/1 diff --git a/Transceiver52M/device/common/Makefile.am b/Transceiver52M/device/common/Makefile.am index e14cc38..3c9324e 100644 --- a/Transceiver52M/device/common/Makefile.am +++ b/Transceiver52M/device/common/Makefile.am @@ -1,7 +1,7 @@ include $(top_srcdir)/Makefile.common AM_CPPFLAGS = -Wall $(STD_DEFINES_AND_INCLUDES) -AM_CXXFLAGS = -lpthread $(LIBOSMOCORE_CFLAGS) $(LIBOSMOCTRL_CFLAGS) $(LIBOSMOVTY_CFLAGS) $(LMS_CFLAGS) +AM_CXXFLAGS = -lpthread $(LIBOSMOCORE_CFLAGS) $(LIBOSMOCTRL_CFLAGS) $(LIBOSMOVTY_CFLAGS) noinst_HEADERS = radioDevice.h smpl_buf.h -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/20873 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I1ffc3431a9a1a46c74c354b3f8a256684bfcbe73 Gerrit-Change-Number: 20873 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange
Change in osmo-trx[master]: device/lms: get rid of 'using namespace std'
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-trx/+/20876 )
Change subject: device/lms: get rid of 'using namespace std'
..
device/lms: get rid of 'using namespace std'
Change-Id: I4329801c502db73efa946f15c103b2c081cee5a7
---
M Transceiver52M/device/lms/LMSDevice.cpp
1 file changed, 1 insertion(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/76/20876/1
diff --git a/Transceiver52M/device/lms/LMSDevice.cpp
b/Transceiver52M/device/lms/LMSDevice.cpp
index ac7323e..14c5777 100644
--- a/Transceiver52M/device/lms/LMSDevice.cpp
+++ b/Transceiver52M/device/lms/LMSDevice.cpp
@@ -40,8 +40,6 @@
#include "config.h"
#endif
-using namespace std;
-
#define MAX_ANTENNA_LIST_SIZE 10
#define GSM_CARRIER_BW 27.0 /* 270kHz */
#define LMS_MIN_BW_SUPPORTED 2.5e6 /* 2.5mHz, minimum supported by LMS */
@@ -203,7 +201,7 @@
int info_list_find(lms_info_str_t* info_list, unsigned int count, const
std::string &args)
{
unsigned int i, j;
- std::vector filters;
+ std::vector filters;
filters = comma_delimited_to_vector(args.c_str());
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/20876
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I4329801c502db73efa946f15c103b2c081cee5a7
Gerrit-Change-Number: 20876
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
Change in osmo-pcu[master]: Move constructor gprs_rlcmac_dl_tbf::BandWidth to correct file
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/20855 ) Change subject: Move constructor gprs_rlcmac_dl_tbf::BandWidth to correct file .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/20855 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I7587fd2ee97424020a099a8513f95544d6635f3d Gerrit-Change-Number: 20855 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Fri, 23 Oct 2020 22:38:39 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: Move gprs_rlcmac_ul_tbf::window to correct file
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/20854 ) Change subject: Move gprs_rlcmac_ul_tbf::window to correct file .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/20854 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I6f8c2d568ffdea3826ec1e11358d24eea6c9335b Gerrit-Change-Number: 20854 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Fri, 23 Oct 2020 22:36:26 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-trx[master]: main: add --vty-ref-mode, use vty_dump_xml_ref_mode()
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-trx/+/20872 )
Change subject: main: add --vty-ref-mode, use vty_dump_xml_ref_mode()
..
main: add --vty-ref-mode, use vty_dump_xml_ref_mode()
Change-Id: Ie54c45fdcc8660f37f8db2367b53404b189b3ffc
Depends: Ie2022a7f9e167e5ceacf15350c037dd43768ff40
Related: SYS#4910
---
M Transceiver52M/osmo-trx.cpp
1 file changed, 36 insertions(+), 14 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/72/20872/1
diff --git a/Transceiver52M/osmo-trx.cpp b/Transceiver52M/osmo-trx.cpp
index ec1d660..ba1c740 100644
--- a/Transceiver52M/osmo-trx.cpp
+++ b/Transceiver52M/osmo-trx.cpp
@@ -242,11 +242,13 @@
static void print_help()
{
- fprintf(stdout, "Options:\n"
- " -h, --helpThis text\n"
- " -C, --config Filename The config file to use\n"
- " -V, --version Print the version of OsmoTRX\n"
- " --vty-ref-xml Generate the VTY reference XML output and
exit.\n"
+ printf( "Some useful options:\n"
+ " -h, --help This text\n"
+ " -C, --config Filename The config file to
use\n"
+ " -V, --versionPrint the version of OsmoTRX\n"
+ "\nVTY reference generation:\n"
+ " --vty-ref-mode MODE VTY reference generation mode
(e.g. 'expert').\n"
+ " --vty-ref-xmlGenerate the VTY reference XML
output and exit.\n"
);
}
@@ -257,6 +259,31 @@
<< " All cmd line options are already being overridden by VTY
options if set.";
}
+static void handle_long_options(const char *prog_name, const int long_option)
+{
+ static int vty_ref_mode = VTY_REF_GEN_MODE_DEFAULT;
+
+ switch (long_option) {
+ case 1:
+ vty_ref_mode = get_string_value(vty_ref_gen_mode_names, optarg);
+ if (vty_ref_mode < 0) {
+ fprintf(stderr, "%s: Unknown VTY reference generation "
+ "mode '%s'\n", prog_name, optarg);
+ exit(2);
+ }
+ break;
+ case 2:
+ fprintf(stderr, "Generating the VTY reference in mode '%s'
(%s)\n",
+ get_value_string(vty_ref_gen_mode_names, vty_ref_mode),
+ get_value_string(vty_ref_gen_mode_desc, vty_ref_mode));
+ vty_dump_xml_ref_mode(stdout, (enum vty_ref_gen_mode)
vty_ref_mode);
+ exit(0);
+ default:
+ fprintf(stderr, "%s: error parsing cmdline options\n",
prog_name);
+ exit(2);
+ }
+}
+
static void handle_options(int argc, char **argv, struct trx_ctx* trx)
{
int option;
@@ -268,7 +295,8 @@
{"help", 0, 0, 'h'},
{"config", 1, 0, 'C'},
{"version", 0, 0, 'V'},
- {"vty-ref-xml", 0, &long_option, 1},
+ {"vty-ref-mode", 1, &long_option, 1},
+ {"vty-ref-xml", 0, &long_option, 2},
{NULL, 0, 0, 0}
};
@@ -280,14 +308,8 @@
exit(0);
break;
case 0:
- switch (long_option) {
- case 1:
- vty_dump_xml_ref(stdout);
- exit(0);
- default:
- fprintf(stderr, "error parsing cmdline
options\n");
- exit(2);
- }
+ handle_long_options(argv[0], long_option);
+ break;
case 'a':
print_deprecated(option);
osmo_talloc_replace_string(trx, &trx->cfg.dev_args,
optarg);
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/20872
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Ie54c45fdcc8660f37f8db2367b53404b189b3ffc
Gerrit-Change-Number: 20872
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
Change in osmo-msc[master]: main: add --vty-ref-mode, use vty_dump_xml_ref_mode()
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-msc/+/20871 )
Change subject: main: add --vty-ref-mode, use vty_dump_xml_ref_mode()
..
main: add --vty-ref-mode, use vty_dump_xml_ref_mode()
Change-Id: I66c3521895dd0b9a35e9b75f7766ec8014116246
Depends: Ie2022a7f9e167e5ceacf15350c037dd43768ff40
Related: SYS#4910
---
M src/osmo-msc/msc_main.c
1 file changed, 34 insertions(+), 11 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/71/20871/1
diff --git a/src/osmo-msc/msc_main.c b/src/osmo-msc/msc_main.c
index 4f614db..aefdcbf 100644
--- a/src/osmo-msc/msc_main.c
+++ b/src/osmo-msc/msc_main.c
@@ -121,7 +121,7 @@
static void print_help()
{
- printf(" Some useful help...\n");
+ printf("Some useful options:\n");
printf(" -h --help This text.\n");
printf(" -d option --debug=DCC:DMM:DRR: Enable debugging.\n");
printf(" -D --daemonize Fork the process into a background
daemon.\n");
@@ -132,7 +132,35 @@
printf(" -V --version Print the version of OsmoMSC.\n");
printf(" -e --log-level number Set a global loglevel.\n");
printf(" -M --mncc-sock-path PATH Disable built-in MNCC handler and
offer socket.\n");
- printf(" --vty-ref-xml Generate the VTY reference XML
output and exit.\n");
+
+ printf("\nVTY reference generation:\n");
+ printf(" --vty-ref-mode MODE VTY reference generation mode
(e.g. 'expert').\n");
+ printf(" --vty-ref-xml Generate the VTY reference XML
output and exit.\n");
+}
+
+static void handle_long_options(const char *prog_name, const int long_option)
+{
+ static int vty_ref_mode = VTY_REF_GEN_MODE_DEFAULT;
+
+ switch (long_option) {
+ case 1:
+ vty_ref_mode = get_string_value(vty_ref_gen_mode_names, optarg);
+ if (vty_ref_mode < 0) {
+ fprintf(stderr, "%s: Unknown VTY reference generation "
+ "mode '%s'\n", prog_name, optarg);
+ exit(2);
+ }
+ break;
+ case 2:
+ fprintf(stderr, "Generating the VTY reference in mode '%s'
(%s)\n",
+ get_value_string(vty_ref_gen_mode_names, vty_ref_mode),
+ get_value_string(vty_ref_gen_mode_desc, vty_ref_mode));
+ vty_dump_xml_ref_mode(stdout, (enum vty_ref_gen_mode)
vty_ref_mode);
+ exit(0);
+ default:
+ fprintf(stderr, "%s: error parsing cmdline options\n",
prog_name);
+ exit(2);
+ }
}
static void handle_options(int argc, char **argv)
@@ -152,7 +180,8 @@
{"log-level", 1, 0, 'e'},
{"mncc-sock-path", 1, 0, 'M'},
{"no-dbcounter", 0, 0, 'C'}, /* deprecated */
- {"vty-ref-xml", 0, &long_option, 1},
+ {"vty-ref-mode", 1, &long_option, 1},
+ {"vty-ref-xml", 0, &long_option, 2},
{0, 0, 0, 0}
};
@@ -167,14 +196,8 @@
print_help();
exit(0);
case 0:
- switch (long_option) {
- case 1:
- vty_dump_xml_ref(stdout);
- exit(0);
- default:
- fprintf(stderr, "error parsing cmdline
options\n");
- exit(2);
- }
+ handle_long_options(argv[0], long_option);
+ break;
case 's':
log_set_use_color(osmo_stderr_target, 0);
break;
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/20871
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I66c3521895dd0b9a35e9b75f7766ec8014116246
Gerrit-Change-Number: 20871
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
Change in osmo-mgw[master]: main: add --vty-ref-mode, use vty_dump_xml_ref_mode()
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-mgw/+/20870 )
Change subject: main: add --vty-ref-mode, use vty_dump_xml_ref_mode()
..
main: add --vty-ref-mode, use vty_dump_xml_ref_mode()
Change-Id: Icb19a635fb7526058d3c47e24ed7d72584dffb0f
Depends: Ie2022a7f9e167e5ceacf15350c037dd43768ff40
Related: SYS#4910
---
M src/osmo-mgw/mgw_main.c
1 file changed, 34 insertions(+), 11 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/70/20870/1
diff --git a/src/osmo-mgw/mgw_main.c b/src/osmo-mgw/mgw_main.c
index 4139172..d30378d 100644
--- a/src/osmo-mgw/mgw_main.c
+++ b/src/osmo-mgw/mgw_main.c
@@ -97,13 +97,41 @@
static void print_help()
{
- printf("Some useful help...\n");
+ printf("Some useful options:\n");
printf(" -h --help is printing this text.\n");
printf(" -c --config-file filename The config file to use.\n");
printf(" -s --disable-color\n");
printf(" -D --daemonize Fork the process into a background daemon\n");
printf(" -V --version Print the version number\n");
- printf(" --vty-ref-xml Generate the VTY reference XML output and
exit.\n");
+
+ printf("\nVTY reference generation:\n");
+ printf("--vty-ref-mode MODE VTY reference generation mode
(e.g. 'expert').\n");
+ printf("--vty-ref-xml Generate the VTY reference XML
output and exit.\n");
+}
+
+static void handle_long_options(const char *prog_name, const int long_option)
+{
+ static int vty_ref_mode = VTY_REF_GEN_MODE_DEFAULT;
+
+ switch (long_option) {
+ case 1:
+ vty_ref_mode = get_string_value(vty_ref_gen_mode_names, optarg);
+ if (vty_ref_mode < 0) {
+ fprintf(stderr, "%s: Unknown VTY reference generation "
+ "mode '%s'\n", prog_name, optarg);
+ exit(2);
+ }
+ break;
+ case 2:
+ fprintf(stderr, "Generating the VTY reference in mode '%s'
(%s)\n",
+ get_value_string(vty_ref_gen_mode_names, vty_ref_mode),
+ get_value_string(vty_ref_gen_mode_desc, vty_ref_mode));
+ vty_dump_xml_ref_mode(stdout, (enum vty_ref_gen_mode)
vty_ref_mode);
+ exit(0);
+ default:
+ fprintf(stderr, "%s: error parsing cmdline options\n",
prog_name);
+ exit(2);
+ }
}
static void handle_options(int argc, char **argv)
@@ -117,7 +145,8 @@
{"daemonize", 0, 0, 'D'},
{"version", 0, 0, 'V'},
{"disable-color", 0, 0, 's'},
- {"vty-ref-xml", 0, &long_option, 1},
+ {"vty-ref-mode", 1, &long_option, 1},
+ {"vty-ref-xml", 0, &long_option, 2},
{0, 0, 0, 0},
};
@@ -132,14 +161,8 @@
exit(0);
break;
case 0:
- switch (long_option) {
- case 1:
- vty_dump_xml_ref(stdout);
- exit(0);
- default:
- fprintf(stderr, "error parsing cmdline
options\n");
- exit(2);
- }
+ handle_long_options(argv[0], long_option);
+ break;
case 'c':
config_file = talloc_strdup(tall_mgw_ctx, optarg);
break;
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/20870
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Icb19a635fb7526058d3c47e24ed7d72584dffb0f
Gerrit-Change-Number: 20870
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
Change in osmo-pcu[master]: main: add --vty-ref-mode, use vty_dump_xml_ref_mode()
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-pcu/+/20869 )
Change subject: main: add --vty-ref-mode, use vty_dump_xml_ref_mode()
..
main: add --vty-ref-mode, use vty_dump_xml_ref_mode()
Change-Id: If82208ecb931a6024f1a83c8648c5855b15dcc96
Depends: Ie2022a7f9e167e5ceacf15350c037dd43768ff40
Related: SYS#4910
---
M src/pcu_main.cpp
1 file changed, 32 insertions(+), 10 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/69/20869/1
diff --git a/src/pcu_main.cpp b/src/pcu_main.cpp
index 723f101..cda10e7 100644
--- a/src/pcu_main.cpp
+++ b/src/pcu_main.cpp
@@ -77,10 +77,37 @@
" -r --realtime PRIO Use SCHED_RR with the specified
priority\n"
" -D --daemonize Fork the process into a
background daemon\n"
" -i --gsmtap-ip The destination IP used for
GSMTAP\n"
- " --vty-ref-xml Generate the VTY reference XML
output and exit.\n"
+ "\nVTY reference generation:\n"
+ " --vty-ref-mode MODE VTY reference generation mode
(e.g. 'expert').\n"
+ " --vty-ref-xml Generate the VTY reference XML
output and exit.\n"
);
}
+static void handle_long_options(const char *prog_name, const int long_option)
+{
+ static int vty_ref_mode = VTY_REF_GEN_MODE_DEFAULT;
+
+ switch (long_option) {
+ case 1:
+ vty_ref_mode = get_string_value(vty_ref_gen_mode_names, optarg);
+ if (vty_ref_mode < 0) {
+ fprintf(stderr, "%s: Unknown VTY reference generation "
+ "mode '%s'\n", prog_name, optarg);
+ exit(2);
+ }
+ break;
+ case 2:
+ fprintf(stderr, "Generating the VTY reference in mode '%s'
(%s)\n",
+ get_value_string(vty_ref_gen_mode_names, vty_ref_mode),
+ get_value_string(vty_ref_gen_mode_desc, vty_ref_mode));
+ vty_dump_xml_ref_mode(stdout, (enum vty_ref_gen_mode)
vty_ref_mode);
+ exit(0);
+ default:
+ fprintf(stderr, "%s: error parsing cmdline options\n",
prog_name);
+ exit(2);
+ }
+}
+
/* FIXME: finally get some option parsing code into libosmocore */
static void handle_options(int argc, char **argv)
{
@@ -97,7 +124,8 @@
{ "daemonize", 0, 0, 'D' },
{ "exit", 0, 0, 'e' },
{ "gsmtap-ip", 1, 0, 'i' },
- { "vty-ref-xml", 0, &long_option, 1 },
+ { "vty-ref-mode", 1, &long_option, 1 },
+ { "vty-ref-xml", 0, &long_option, 2 },
{ 0, 0, 0, 0 }
};
@@ -112,14 +140,8 @@
exit(0);
break;
case 0:
- switch (long_option) {
- case 1:
- vty_dump_xml_ref(stdout);
- exit(0);
- default:
- fprintf(stderr, "error parsing cmdline
options\n");
- exit(2);
- }
+ handle_long_options(argv[0], long_option);
+ break;
case 'c':
free(config_file);
config_file = strdup(optarg);
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/20869
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: If82208ecb931a6024f1a83c8648c5855b15dcc96
Gerrit-Change-Number: 20869
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
Change in osmo-pcu[master]: main: remove line breaks in print_help(), increase spacing
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-pcu/+/20868 )
Change subject: main: remove line breaks in print_help(), increase spacing
..
main: remove line breaks in print_help(), increase spacing
Change-Id: I07010afec3bb85d875926813772a6504f3bdb7b5
Related: SYS#4910
---
M src/pcu_main.cpp
1 file changed, 10 insertions(+), 15 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/68/20868/1
diff --git a/src/pcu_main.cpp b/src/pcu_main.cpp
index 77c46dd..723f101 100644
--- a/src/pcu_main.cpp
+++ b/src/pcu_main.cpp
@@ -68,21 +68,16 @@
static void print_help()
{
- printf( "Options:\n"
- " -h --help This text\n"
- " -c --config-file Specify the filename of the config "
- "file\n"
- " -m --mcc MCC Use given MCC instead of value "
- "provided by BTS\n"
- " -n --mnc MNC Use given MNC instead of value "
- "provided by BTS\n"
- " -V --version Print version\n"
- " -r --realtime PRIO Use SCHED_RR with the specified "
- "priority\n"
- " -D --daemonize Fork the process into a background "
- "daemon\n"
- " -i --gsmtap-ip The destination IP used for GSMTAP\n"
- " --vty-ref-xml Generate the VTY reference XML output
and exit.\n"
+ printf( "Some useful options:\n"
+ " -h --help This text\n"
+ " -c --config-file Specify the filename of the
config file\n"
+ " -m --mcc MCC Use given MCC instead of value
provided by BTS\n"
+ " -n --mnc MNC Use given MNC instead of value
provided by BTS\n"
+ " -V --version Print version\n"
+ " -r --realtime PRIO Use SCHED_RR with the specified
priority\n"
+ " -D --daemonize Fork the process into a
background daemon\n"
+ " -i --gsmtap-ip The destination IP used for
GSMTAP\n"
+ " --vty-ref-xml Generate the VTY reference XML
output and exit.\n"
);
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/20868
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I07010afec3bb85d875926813772a6504f3bdb7b5
Gerrit-Change-Number: 20868
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
Change in osmo-bts[master]: main: separate model-specific arguments in help
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-bts/+/20867 )
Change subject: main: separate model-specific arguments in help
..
main: separate model-specific arguments in help
Change-Id: I9646a45d61153499ad3d580a03d930ed20e23cda
---
M src/osmo-bts-litecell15/main.c
M src/osmo-bts-oc2g/main.c
M src/osmo-bts-octphy/main.c
M src/osmo-bts-sysmo/main.c
4 files changed, 6 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/67/20867/1
diff --git a/src/osmo-bts-litecell15/main.c b/src/osmo-bts-litecell15/main.c
index 649557b..e29efd5 100644
--- a/src/osmo-bts-litecell15/main.c
+++ b/src/osmo-bts-litecell15/main.c
@@ -158,7 +158,8 @@
void bts_model_print_help()
{
- printf( " -w --hw-versionPrint the targeted HW Version\n"
+ printf( "\nModel specific options:\n"
+ " -w --hw-versionPrint the targeted HW Version\n"
" -M --pcu-directForce PCU to access message
queue for "
"PDCH dchannel directly\n"
" -p --dsp-trace Set DSP trace flags\n"
diff --git a/src/osmo-bts-oc2g/main.c b/src/osmo-bts-oc2g/main.c
index d074ed3..9b0ebec 100644
--- a/src/osmo-bts-oc2g/main.c
+++ b/src/osmo-bts-oc2g/main.c
@@ -159,7 +159,8 @@
void bts_model_print_help()
{
- printf( " -w --hw-versionPrint the targeted HW Version\n"
+ printf( "\nModel specific options:\n"
+ " -w --hw-versionPrint the targeted HW Version\n"
" -M --pcu-directForce PCU to access message
queue for "
"PDCH dchannel directly\n"
" -p --dsp-trace Set DSP trace flags\n"
diff --git a/src/osmo-bts-octphy/main.c b/src/osmo-bts-octphy/main.c
index caf0f8d..56849b5 100644
--- a/src/osmo-bts-octphy/main.c
+++ b/src/osmo-bts-octphy/main.c
@@ -55,6 +55,7 @@
int bts_model_print_help()
{
+ printf("\nModel specific options:\n");
printf(" -I--no-fw-check Override firmware version
check\n");
return 0;
}
diff --git a/src/osmo-bts-sysmo/main.c b/src/osmo-bts-sysmo/main.c
index 306e557..9befcda 100644
--- a/src/osmo-bts-sysmo/main.c
+++ b/src/osmo-bts-sysmo/main.c
@@ -121,7 +121,7 @@
void bts_model_print_help()
{
- printf(
+ printf( "\nModel specific options:\n"
" -w --hw-versionPrint the targeted HW Version\n"
" -M --pcu-directForce PCU to access message
queue for "
"PDCH dchannel directly\n"
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20867
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I9646a45d61153499ad3d580a03d930ed20e23cda
Gerrit-Change-Number: 20867
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
Change in osmo-bts[master]: main: increase spacing between commands and description
fixeria has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-bts/+/20866 ) Change subject: main: increase spacing between commands and description .. main: increase spacing between commands and description Otherwise it's hard to fit new options with long names. Change-Id: If9a418545abff6d22602ba07cfd4447f5ace7742 Related: SYS#4910 --- M src/common/main.c M src/osmo-bts-litecell15/main.c M src/osmo-bts-oc2g/main.c M src/osmo-bts-octphy/main.c M src/osmo-bts-sysmo/main.c 5 files changed, 22 insertions(+), 20 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/66/20866/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20866 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If9a418545abff6d22602ba07cfd4447f5ace7742 Gerrit-Change-Number: 20866 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-MessageType: newpatchset
Change in osmo-bts[master]: main: add --vty-ref-mode, use vty_dump_xml_ref_mode()
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/20863 to look at the new patch set (#3). Change subject: main: add --vty-ref-mode, use vty_dump_xml_ref_mode() .. main: add --vty-ref-mode, use vty_dump_xml_ref_mode() Change-Id: I744520199ef448ff095d0fe703d79ac08f08f7fe Depends: Ie2022a7f9e167e5ceacf15350c037dd43768ff40 Related: SYS#4910 --- M src/common/main.c 1 file changed, 32 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/63/20863/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20863 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I744520199ef448ff095d0fe703d79ac08f08f7fe Gerrit-Change-Number: 20863 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset
Change in osmo-bts[master]: main: increase spacing between commands and description
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-bts/+/20866 )
Change subject: main: increase spacing between commands and description
..
main: increase spacing between commands and description
Otherwise it's hard to fit new options with long names.
Change-Id: If9a418545abff6d22602ba07cfd4447f5ace7742
Related: SYS#4910
---
M src/common/main.c
1 file changed, 10 insertions(+), 10 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/66/20866/1
diff --git a/src/common/main.c b/src/common/main.c
index c7b821e..b1b1766 100644
--- a/src/common/main.c
+++ b/src/common/main.c
@@ -67,16 +67,16 @@
static void print_help()
{
printf( "Some useful options:\n"
- " -h --help this text\n"
- " -d --debug MASKEnable debugging (e.g. -d
DRSL:DOML:DLAPDM)\n"
- " -D --daemonize For the process into a background
daemon\n"
- " -c --config-file Specify the filename of the config
file\n"
- " -s --disable-color Don't use colors in stderr log output\n"
- " -T --timestamp Prefix every log line with a
timestamp\n"
- " -V --version Print version information and exit\n"
- " -e --log-level Set a global log-level\n"
- " -i --gsmtap-ip The destination IP used for GSMTAP.\n"
- " --vty-ref-xml Generate the VTY reference XML output
and exit.\n"
+ " -h --help this text\n"
+ " -d --debug MASKEnable debugging (e.g. -d
DRSL:DOML:DLAPDM)\n"
+ " -D --daemonize For the process into a
background daemon\n"
+ " -c --config-file Specify the filename of the
config file\n"
+ " -s --disable-color Don't use colors in stderr log
output\n"
+ " -T --timestamp Prefix every log line with a
timestamp\n"
+ " -V --version Print version information and
exit\n"
+ " -e --log-level Set a global log-level\n"
+ " -i --gsmtap-ip The destination IP used for
GSMTAP.\n"
+ " --vty-ref-xml Generate the VTY reference XML
output and exit.\n"
);
bts_model_print_help();
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20866
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: If9a418545abff6d22602ba07cfd4447f5ace7742
Gerrit-Change-Number: 20866
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
Change in osmo-bts[master]: main: add --vty-ref-mode, use vty_dump_xml_ref_mode()
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/20863 to look at the new patch set (#2). Change subject: main: add --vty-ref-mode, use vty_dump_xml_ref_mode() .. main: add --vty-ref-mode, use vty_dump_xml_ref_mode() Change-Id: I744520199ef448ff095d0fe703d79ac08f08f7fe Depends: Ie2022a7f9e167e5ceacf15350c037dd43768ff40 Related: SYS#4910 --- M src/common/main.c 1 file changed, 32 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/63/20863/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20863 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I744520199ef448ff095d0fe703d79ac08f08f7fe Gerrit-Change-Number: 20863 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset
Change in osmo-bts[master]: main: do not print deprecated '-r' / '--realtime' in help
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/20865 ) Change subject: main: do not print deprecated '-r' / '--realtime' in help .. main: do not print deprecated '-r' / '--realtime' in help Change-Id: I516a71124a49f6d6adb6db939a91da07576e63e7 --- M src/common/main.c 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/65/20865/1 diff --git a/src/common/main.c b/src/common/main.c index 9f09d31..c7b821e 100644 --- a/src/common/main.c +++ b/src/common/main.c @@ -75,7 +75,6 @@ " -T --timestamp Prefix every log line with a timestamp\n" " -V --version Print version information and exit\n" " -e --log-level Set a global log-level\n" - " -r --realtime PRIO Use SCHED_RR with the specified priority (deprecated, use VTY instead)\n" " -i --gsmtap-ip The destination IP used for GSMTAP.\n" " --vty-ref-xml Generate the VTY reference XML output and exit.\n" ); -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20865 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I516a71124a49f6d6adb6db939a91da07576e63e7 Gerrit-Change-Number: 20865 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange
Change in osmocom-bb[master]: gsm48_rr: Don't swap ber with snr in "MON:" log line
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/20864 ) Change subject: gsm48_rr: Don't swap ber with snr in "MON:" log line .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/20864 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I09bb6c606a8437b213bb444949c78a7c8a10542c Gerrit-Change-Number: 20864 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Fri, 23 Oct 2020 21:40:04 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmocom-bb[master]: gsm48_rr: Don't swap ber with snr in "MON:" log line
laforge has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmocom-bb/+/20864 )
Change subject: gsm48_rr: Don't swap ber with snr in "MON:" log line
..
gsm48_rr: Don't swap ber with snr in "MON:" log line
I was quite confused why I constantly see a bit error rate reported
by gsm48_rr, while at the same time the actual L1CTL_DATA_IND did
all state num_biterr == 0.
So the log statement was broken ...
Change-Id: I09bb6c606a8437b213bb444949c78a7c8a10542c
---
M src/host/layer23/src/mobile/gsm48_rr.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/64/20864/1
diff --git a/src/host/layer23/src/mobile/gsm48_rr.c
b/src/host/layer23/src/mobile/gsm48_rr.c
index 64d64f1..e115d15 100644
--- a/src/host/layer23/src/mobile/gsm48_rr.c
+++ b/src/host/layer23/src/mobile/gsm48_rr.c
@@ -648,7 +648,7 @@
snr = (meas->snr + meas->frames / 2) / meas->frames;
sprintf(text, "MON: f=%d lev=%s snr=%2d ber=%3d "
"LAI=%s %s %04x ID=%04x", cs->sel_arfcn,
- gsm_print_rxlev(rxlev), berr, snr,
+ gsm_print_rxlev(rxlev), snr, berr,
gsm_print_mcc(cs->sel_mcc),
gsm_print_mnc(cs->sel_mnc), cs->sel_lac, cs->sel_id);
if (rr->state == GSM48_RR_ST_DEDICATED) {
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/20864
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I09bb6c606a8437b213bb444949c78a7c8a10542c
Gerrit-Change-Number: 20864
Gerrit-PatchSet: 1
Gerrit-Owner: laforge
Gerrit-MessageType: newchange
Change in osmo-bsc[master]: main: add --vty-ref-mode, use vty_dump_xml_ref_mode()
fixeria has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-bsc/+/20862 ) Change subject: main: add --vty-ref-mode, use vty_dump_xml_ref_mode() .. main: add --vty-ref-mode, use vty_dump_xml_ref_mode() Change-Id: I1a89829a29dd38fe69002c898503d76a3376a874 Depends: Ie2022a7f9e167e5ceacf15350c037dd43768ff40 Related: SYS#4910 --- M src/osmo-bsc/osmo_bsc_main.c 1 file changed, 34 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/62/20862/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20862 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1a89829a29dd38fe69002c898503d76a3376a874 Gerrit-Change-Number: 20862 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset
Change in osmo-bts[master]: main: add --vty-ref-mode, use vty_dump_xml_ref_mode()
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-bts/+/20863 )
Change subject: main: add --vty-ref-mode, use vty_dump_xml_ref_mode()
..
main: add --vty-ref-mode, use vty_dump_xml_ref_mode()
Change-Id: I744520199ef448ff095d0fe703d79ac08f08f7fe
Depends: Ie2022a7f9e167e5ceacf15350c037dd43768ff40
Related: SYS#4910
---
M src/common/main.c
1 file changed, 32 insertions(+), 10 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/63/20863/1
diff --git a/src/common/main.c b/src/common/main.c
index 9f09d31..109a004 100644
--- a/src/common/main.c
+++ b/src/common/main.c
@@ -77,11 +77,38 @@
" -e --log-level Set a global log-level\n"
" -r --realtime PRIO Use SCHED_RR with the specified
priority (deprecated, use VTY instead)\n"
" -i --gsmtap-ip The destination IP used for GSMTAP.\n"
- " --vty-ref-xml Generate the VTY reference XML output
and exit.\n"
+ "\nVTY reference generation:\n"
+ " --vty-ref-mode MODE VTY reference generation mode (e.g.
'expert').\n"
+ " --vty-ref-xmlGenerate the VTY reference XML output
and exit.\n"
);
bts_model_print_help();
}
+static void handle_long_options(const char *prog_name, const int long_option)
+{
+ static int vty_ref_mode = VTY_REF_GEN_MODE_DEFAULT;
+
+ switch (long_option) {
+ case 1:
+ vty_ref_mode = get_string_value(vty_ref_gen_mode_names, optarg);
+ if (vty_ref_mode < 0) {
+ fprintf(stderr, "%s: Unknown VTY reference generation "
+ "mode '%s'\n", prog_name, optarg);
+ exit(2);
+ }
+ break;
+ case 2:
+ fprintf(stderr, "Generating the VTY reference in mode '%s'
(%s)\n",
+ get_value_string(vty_ref_gen_mode_names, vty_ref_mode),
+ get_value_string(vty_ref_gen_mode_desc, vty_ref_mode));
+ vty_dump_xml_ref_mode(stdout, (enum vty_ref_gen_mode)
vty_ref_mode);
+ exit(0);
+ default:
+ fprintf(stderr, "%s: error parsing cmdline options\n",
prog_name);
+ exit(2);
+ }
+}
+
/* FIXME: finally get some option parsing code into libosmocore */
static void handle_options(int argc, char **argv)
{
@@ -111,7 +138,8 @@
{ "gsmtap-ip", 1, 0, 'i' },
{ "trx-num", 1, 0, 't' },
{ "realtime", 1, 0, 'r' },
- {"vty-ref-xml", 0, &long_option, 1},
+ { "vty-ref-mode", 1, &long_option, 1 },
+ { "vty-ref-xml", 0, &long_option, 2 },
{ 0, 0, 0, 0 }
};
@@ -126,14 +154,8 @@
exit(0);
break;
case 0:
- switch (long_option) {
- case 1:
- vty_dump_xml_ref(stdout);
- exit(0);
- default:
- fprintf(stderr, "error parsing cmdline
options\n");
- exit(2);
- }
+ handle_long_options(argv[0], long_option);
+ break;
case 's':
log_set_use_color(osmo_stderr_target, 0);
break;
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20863
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I744520199ef448ff095d0fe703d79ac08f08f7fe
Gerrit-Change-Number: 20863
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
Change in osmo-bsc[master]: main: add --vty-ref-mode, use vty_dump_xml_ref_mode()
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-bsc/+/20862 )
Change subject: main: add --vty-ref-mode, use vty_dump_xml_ref_mode()
..
main: add --vty-ref-mode, use vty_dump_xml_ref_mode()
Change-Id: I1a89829a29dd38fe69002c898503d76a3376a874
Depends: Ie2022a7f9e167e5ceacf15350c037dd43768ff40
Related: SYS#4910
---
M src/osmo-bsc/osmo_bsc_main.c
1 file changed, 33 insertions(+), 10 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/62/20862/1
diff --git a/src/osmo-bsc/osmo_bsc_main.c b/src/osmo-bsc/osmo_bsc_main.c
index 7eaa18f..2981ed9 100644
--- a/src/osmo-bsc/osmo_bsc_main.c
+++ b/src/osmo-bsc/osmo_bsc_main.c
@@ -96,7 +96,7 @@
static void print_help()
{
- printf(" Some useful help...\n");
+ printf("Some useful options:\n");
printf(" -h --help This text.\n");
printf(" -D --daemonizeFork the process into a
background daemon.\n");
printf(" -d --debug option--debug=DRLL:DMM:DRR:DRSL:DNM
enable debugging.\n");
@@ -108,9 +108,37 @@
printf(" -e --log-level number Set a global loglevel.\n");
printf(" -r --rf-ctl NAME A unix domain socket to listen
for cmds.\n");
printf(" -t --testmode A special mode to provoke
failures at the MSC.\n");
+
+ printf("\nVTY reference generation:\n");
+ printf(" --vty-ref-mode MODE VTY reference generation mode
(e.g. 'expert').\n");
printf(" --vty-ref-xml Generate the VTY reference XML
output and exit.\n");
}
+static void handle_long_options(const char *prog_name, const int long_option)
+{
+ static int vty_ref_mode = VTY_REF_GEN_MODE_DEFAULT;
+
+ switch (long_option) {
+ case 1:
+ vty_ref_mode = get_string_value(vty_ref_gen_mode_names, optarg);
+ if (vty_ref_mode < 0) {
+ fprintf(stderr, "%s: Unknown VTY reference generation "
+ "mode '%s'\n", prog_name, optarg);
+ exit(2);
+ }
+ break;
+ case 2:
+ fprintf(stderr, "Generating the VTY reference in mode '%s'
(%s)\n",
+ get_value_string(vty_ref_gen_mode_names, vty_ref_mode),
+ get_value_string(vty_ref_gen_mode_desc, vty_ref_mode));
+ vty_dump_xml_ref_mode(stdout, (enum vty_ref_gen_mode)
vty_ref_mode);
+ exit(0);
+ default:
+ fprintf(stderr, "%s: error parsing cmdline options\n",
prog_name);
+ exit(2);
+ }
+}
+
static void handle_options(int argc, char **argv)
{
while (1) {
@@ -128,7 +156,8 @@
{"log-level", 1, 0, 'e'},
{"rf-ctl", 1, 0, 'r'},
{"testmode", 0, 0, 't'},
- {"vty-ref-xml", 0, &long_option, 1},
+ {"vty-ref-mode", 1, &long_option, 1},
+ {"vty-ref-xml", 0, &long_option, 2},
{0, 0, 0, 0}
};
@@ -143,14 +172,8 @@
print_help();
exit(0);
case 0:
- switch (long_option) {
- case 1:
- vty_dump_xml_ref(stdout);
- exit(0);
- default:
- fprintf(stderr, "error parsing cmdline
options\n");
- exit(2);
- }
+ handle_long_options(argv[0], long_option);
+ break;
case 's':
log_set_use_color(osmo_stderr_target, 0);
break;
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20862
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I1a89829a29dd38fe69002c898503d76a3376a874
Gerrit-Change-Number: 20862
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
Change in libosmocore[master]: application: do not document unrelated forward-declarations
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/20861 ) Change subject: application: do not document unrelated forward-declarations .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20861 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic04caab15abbd0c0d3a01f6e128935a3ceed903e Gerrit-Change-Number: 20861 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 23 Oct 2020 21:12:10 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: application: do not document unrelated forward-declarations
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/20861 ) Change subject: application: do not document unrelated forward-declarations .. application: do not document unrelated forward-declarations Change-Id: Ic04caab15abbd0c0d3a01f6e128935a3ceed903e --- M include/osmocom/core/application.h 1 file changed, 3 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/61/20861/1 diff --git a/include/osmocom/core/application.h b/include/osmocom/core/application.h index edf59ed..67a5908 100644 --- a/include/osmocom/core/application.h +++ b/include/osmocom/core/application.h @@ -2,17 +2,14 @@ #include +struct log_info; +struct log_target; + /*! * \file application.h * Routines for helping with the osmocom application setup. */ -/*! information containing the available logging subsystems */ -struct log_info; - -/*! one instance of a logging target (file, stderr, ...) */ -struct log_target; - /*! the default logging target, logging to stderr */ extern struct log_target *osmo_stderr_target; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20861 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic04caab15abbd0c0d3a01f6e128935a3ceed903e Gerrit-Change-Number: 20861 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange
Change in osmo-pcu[master]: tbf: Implement enable_egprs() once
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-pcu/+/20857 )
Change subject: tbf: Implement enable_egprs() once
..
tbf: Implement enable_egprs() once
There's no real need for having different copies of this method in each
children. Furthermore, having the method implemented in the base class
made me shoot my foot while trying to move this to the tbf constructor
(see next commit), so let's simplify this and avoid other people
following into the same issue.
enable_egprs() in tbf.h is moved to be public since it needed (as it was
for the duplicated children mehtods with same name), but anyway it will
be moved to private in next commit.
Change-Id: Id7de060318201a42e51f277f898463f4b9a84eba
---
M src/tbf.h
M src/tbf_dl.h
M src/tbf_ul.h
3 files changed, 2 insertions(+), 15 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/57/20857/1
diff --git a/src/tbf.h b/src/tbf.h
index bf51a8d..ac6c63c 100644
--- a/src/tbf.h
+++ b/src/tbf.h
@@ -263,6 +263,7 @@
/* EGPRS */
bool is_egprs_enabled() const;
void disable_egprs();
+ void enable_egprs();
/* attempt to make things a bit more fair */
void rotate_in_list();
@@ -322,7 +323,6 @@
protected:
gprs_rlcmac_bts *bts_data() const;
- void enable_egprs();
void merge_and_clear_ms(GprsMs *old_ms);
gprs_llc_queue *llc_queue();
@@ -581,6 +581,7 @@
inline void gprs_rlcmac_tbf::enable_egprs()
{
m_egprs_enabled = true;
+ window()->set_sns(RLC_EGPRS_SNS);
}
inline void gprs_rlcmac_tbf::disable_egprs()
diff --git a/src/tbf_dl.h b/src/tbf_dl.h
index 51e170a..55306fd 100644
--- a/src/tbf_dl.h
+++ b/src/tbf_dl.h
@@ -42,7 +42,6 @@
gprs_rlcmac_dl_tbf(BTS *bts);
gprs_rlc_window *window();
void cleanup();
- void enable_egprs();
/* dispatch Unitdata.DL messages */
static int handle(struct gprs_rlcmac_bts *bts,
const uint32_t tlli, const uint32_t old_tlli,
@@ -143,12 +142,6 @@
return m_window.ws();
}
-inline void gprs_rlcmac_dl_tbf::enable_egprs()
-{
- m_window.set_sns(RLC_EGPRS_SNS);
- gprs_rlcmac_tbf::enable_egprs();
-}
-
inline gprs_rlcmac_dl_tbf *as_dl_tbf(gprs_rlcmac_tbf *tbf)
{
if (tbf && tbf->direction == GPRS_RLCMAC_DL_TBF)
diff --git a/src/tbf_ul.h b/src/tbf_ul.h
index cbaffa5..a581f27 100644
--- a/src/tbf_ul.h
+++ b/src/tbf_ul.h
@@ -55,7 +55,6 @@
struct msgb *create_ul_ack(uint32_t fn, uint8_t ts);
bool ctrl_ack_to_toggle();
bool handle_ctrl_ack();
- void enable_egprs();
/* blocks were acked */
int rcv_data_block_acknowledged(
const struct gprs_rlc_data_info *rlc,
@@ -123,12 +122,6 @@
return m_window.ws();
}
-inline void gprs_rlcmac_ul_tbf::enable_egprs()
-{
- m_window.set_sns(RLC_EGPRS_SNS);
- gprs_rlcmac_tbf::enable_egprs();
-}
-
inline gprs_rlcmac_ul_tbf *as_ul_tbf(gprs_rlcmac_tbf *tbf)
{
if (tbf && tbf->direction == GPRS_RLCMAC_UL_TBF)
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/20857
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Id7de060318201a42e51f277f898463f4b9a84eba
Gerrit-Change-Number: 20857
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
Gerrit-MessageType: newchange
Change in osmo-pcu[master]: tbf: Make window() available to tbf base class
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-pcu/+/20856 )
Change subject: tbf: Make window() available to tbf base class
..
tbf: Make window() available to tbf base class
Return an interface to the window base class so that the tbf base class
can access the common window methods, such as set_ws(). It will be used
in next commit to get rid of duplicated function enable_egprs in both
dl_tbf and ul_tbf subclasses.
The user of the function can then decide to access more specific
functionaltiites of the window class by static casting it to the
specific direction (which is known by the caller since it operates on a
ul_tbf or a dl_tbf).
Change-Id: Ia2e1decf91be1184668e28297c2126affb9c7ae4
---
M src/encoding.cpp
M src/gprs_rlcmac_sched.cpp
M src/pcu_vty_functions.cpp
M src/pdch.cpp
M src/tbf.h
M src/tbf_dl.cpp
M src/tbf_dl.h
M src/tbf_ul.cpp
M src/tbf_ul.h
M tests/tbf/TbfTest.cpp
M tests/types/TypesTest.cpp
11 files changed, 38 insertions(+), 27 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/56/20856/1
diff --git a/src/encoding.cpp b/src/encoding.cpp
index d581fe9..ecfca51 100644
--- a/src/encoding.cpp
+++ b/src/encoding.cpp
@@ -886,9 +886,10 @@
bitvec * dest, unsigned& wp,
struct gprs_rlcmac_ul_tbf *tbf, bool is_final)
{
+ gprs_rlc_ul_window *window = static_cast(tbf->window());
bitvec_write_field(dest, &wp, mcs_chan_code(tbf->current_cs()), 2); //
CHANNEL_CODING_COMMAND
- write_packet_ack_nack_desc_gprs(dest, wp, tbf->window(), is_final);
+ write_packet_ack_nack_desc_gprs(dest, wp, window, is_final);
bitvec_write_field(dest, &wp, 1, 1); // 1: have
CONTENTION_RESOLUTION_TLLI
bitvec_write_field(dest, &wp, tbf->tlli(), 32); //
CONTENTION_RESOLUTION_TLLI
@@ -1061,6 +1062,8 @@
bitvec * dest, unsigned& wp,
struct gprs_rlcmac_ul_tbf *tbf, bool is_final)
{
+ gprs_rlc_ul_window *window = static_cast(tbf->window());
+
bitvec_write_field(dest, &wp, 0, 2); // fixed 00
/* CHANNEL_CODING_COMMAND */
bitvec_write_field(dest, &wp,
@@ -1080,7 +1083,7 @@
/* -2 for last bit 0 mandatory and REL5 not supported */
unsigned bits_ack_nack = dest->data_len * 8 - wp - 2;
- write_packet_ack_nack_desc_egprs(dest, wp, tbf->window(), is_final,
bits_ack_nack);
+ write_packet_ack_nack_desc_egprs(dest, wp, window, is_final,
bits_ack_nack);
bitvec_write_field(dest, &wp, 0, 1); // fixed 0
bitvec_write_field(dest, &wp, 0, 1); // 0: don't have REL 5
diff --git a/src/gprs_rlcmac_sched.cpp b/src/gprs_rlcmac_sched.cpp
index 3db3365..40b2f91 100644
--- a/src/gprs_rlcmac_sched.cpp
+++ b/src/gprs_rlcmac_sched.cpp
@@ -247,7 +247,7 @@
static inline enum tbf_dl_prio tbf_compute_priority(const struct
gprs_rlcmac_bts *bts, struct gprs_rlcmac_dl_tbf *tbf,
uint8_t ts, uint32_t fn,
int age)
{
- const gprs_rlc_dl_window *w = tbf->window();
+ const gprs_rlc_dl_window *w = static_cast(tbf->window());
unsigned long msecs_t3190 = osmo_tdef_get(bts->T_defs_pcu, 3190,
OSMO_TDEF_MS, -1);
unsigned long dl_tbf_idle_msec = osmo_tdef_get(bts->T_defs_pcu, -2031,
OSMO_TDEF_MS, -1);
int age_thresh1 = msecs_to_frames(200);
diff --git a/src/pcu_vty_functions.cpp b/src/pcu_vty_functions.cpp
index 33a4637..28a1559 100644
--- a/src/pcu_vty_functions.cpp
+++ b/src/pcu_vty_functions.cpp
@@ -74,7 +74,7 @@
vty_out(vty, " CS=%s", mcs_name(tbf->current_cs()));
if (ul_tbf) {
- gprs_rlc_ul_window *win = ul_tbf->window();
+ gprs_rlc_ul_window *win = static_cast(ul_tbf->window());
vty_out(vty, " WS=%u V(Q)=%d V(R)=%d",
ul_tbf->window_size(), win->v_q(), win->v_r());
vty_out(vty, "%s", VTY_NEWLINE);
@@ -86,7 +86,7 @@
}
}
if (dl_tbf) {
- gprs_rlc_dl_window *win = dl_tbf->window();
+ gprs_rlc_dl_window *win = static_cast(dl_tbf->window());
vty_out(vty, " WS=%u V(A)=%d V(S)=%d nBSN=%d%s",
dl_tbf->window_size(), win->v_a(), win->v_s(),
win->resend_needed(),
win->window_stalled() ? " STALLED" : "");
diff --git a/src/pdch.cpp b/src/pdch.cpp
index 7986373..26604bc 100644
--- a/src/pdch.cpp
+++ b/src/pdch.cpp
@@ -436,7 +436,7 @@
num_blocks = Decoding::decode_gprs_acknack_bits(
&ack_nack->Ack_Nack_Description, &bits,
- &bsn_begin, &bsn_end, tbf->window());
+ &bsn_begin, &bsn_end, static_cast(tbf->window()));
LOGP(DRLCMAC, LOGL_DEBUG,
"Got GPRS DL ACK bitmap: SSN: %d, BSN %d to %d - 1 (%d blocks),
"
@@ -467,6 +467,7 @@
{
int8_t tfi = 0; /* must be signed */
struct gprs_rlcmac_dl_tbf *tbf;
+
Change in osmo-pcu[master]: Move gprs_rlcmac_ul_tbf::window to correct file
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-pcu/+/20854 )
Change subject: Move gprs_rlcmac_ul_tbf::window to correct file
..
Move gprs_rlcmac_ul_tbf::window to correct file
It wasn't move when all the UL specific code was moved to a separate
file.
Change-Id: I6f8c2d568ffdea3826ec1e11358d24eea6c9335b
---
M src/tbf.cpp
M src/tbf_ul.cpp
2 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/54/20854/1
diff --git a/src/tbf.cpp b/src/tbf.cpp
index 9545511..ac84de2 100644
--- a/src/tbf.cpp
+++ b/src/tbf.cpp
@@ -1516,11 +1516,6 @@
return ts == control_ts;
}
-gprs_rlc_ul_window *gprs_rlcmac_ul_tbf::window()
-{
- return &m_window;
-}
-
struct gprs_rlcmac_ul_tbf *handle_tbf_reject(struct gprs_rlcmac_bts *bts,
GprsMs *ms, uint32_t tlli, uint8_t trx_no, uint8_t ts)
{
diff --git a/src/tbf_ul.cpp b/src/tbf_ul.cpp
index 489fc87..39e4e95 100644
--- a/src/tbf_ul.cpp
+++ b/src/tbf_ul.cpp
@@ -614,3 +614,8 @@
ws, b->ws_base, pcu_bitcount(ul_slots()), b->ws_pdch);
m_window.set_ws(ws);
}
+
+gprs_rlc_ul_window *gprs_rlcmac_ul_tbf::window()
+{
+ return &m_window;
+}
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/20854
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I6f8c2d568ffdea3826ec1e11358d24eea6c9335b
Gerrit-Change-Number: 20854
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
Gerrit-MessageType: newchange
Change in osmo-pcu[master]: Move constructor gprs_rlcmac_dl_tbf::BandWidth to correct file
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-pcu/+/20855 )
Change subject: Move constructor gprs_rlcmac_dl_tbf::BandWidth to correct file
..
Move constructor gprs_rlcmac_dl_tbf::BandWidth to correct file
Change-Id: I7587fd2ee97424020a099a8513f95544d6635f3d
---
M src/tbf.cpp
M src/tbf_dl.cpp
2 files changed, 10 insertions(+), 10 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/55/20855/1
diff --git a/src/tbf.cpp b/src/tbf.cpp
index ac84de2..90ee4cf 100644
--- a/src/tbf.cpp
+++ b/src/tbf.cpp
@@ -1036,16 +1036,6 @@
return tbf;
}
-gprs_rlcmac_dl_tbf::BandWidth::BandWidth() :
- dl_bw_octets(0),
- dl_throughput(0),
- dl_loss_lost(0),
- dl_loss_received(0)
-{
- timespecclear(&dl_bw_tv);
- timespecclear(&dl_loss_tv);
-}
-
static int dl_tbf_dtor(struct gprs_rlcmac_dl_tbf *tbf)
{
tbf->~gprs_rlcmac_dl_tbf();
diff --git a/src/tbf_dl.cpp b/src/tbf_dl.cpp
index e6be3c3..fc03c0b 100644
--- a/src/tbf_dl.cpp
+++ b/src/tbf_dl.cpp
@@ -75,6 +75,16 @@
tbf->request_dl_ack();
}
+gprs_rlcmac_dl_tbf::BandWidth::BandWidth() :
+ dl_bw_octets(0),
+ dl_throughput(0),
+ dl_loss_lost(0),
+ dl_loss_received(0)
+{
+ timespecclear(&dl_bw_tv);
+ timespecclear(&dl_loss_tv);
+}
+
gprs_rlcmac_dl_tbf::gprs_rlcmac_dl_tbf(BTS *bts_) :
gprs_rlcmac_tbf(bts_, GPRS_RLCMAC_DL_TBF),
m_tx_counter(0),
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/20855
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I7587fd2ee97424020a099a8513f95544d6635f3d
Gerrit-Change-Number: 20855
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
Gerrit-MessageType: newchange
Change in osmo-pcu[master]: tbf: Set MS during constructor time
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/20858 ) Change subject: tbf: Set MS during constructor time .. tbf: Set MS during constructor time This is another step forward towards a more clear data model where a TBF always has a MS object (which may be lacking some information, and at a later point when more information is found, it may actually be a duplicated MS object and hence one duplicate removed and the TBF moved to the object being kept). This helps for instance in removing duplicated information stored in the TBF which is really per MS, like ms_class, ta, etc. Since there's always a MS object there's no need to keep a duplicate in both classes in case there's no MS object. It can already be seen looking at unit test logging that this kind of data model already provides better information. Some unit test parts were needed to adapt to the new model too. Change-Id: I3cdf4d53e222777d5a2bf4c5aad3a7414105f14c --- M src/tbf.cpp M src/tbf.h M src/tbf_dl.cpp M src/tbf_dl.h M src/tbf_ul.cpp M src/tbf_ul.h M tests/alloc/AllocTest.err M tests/ms/MsTest.cpp M tests/ms/MsTest.err M tests/tbf/TbfTest.err 10 files changed, 13,050 insertions(+), 13,083 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/58/20858/1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/20858 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I3cdf4d53e222777d5a2bf4c5aad3a7414105f14c Gerrit-Change-Number: 20858 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange
Change in osmo-pcu[master]: Move dl_tbf allocation code to correct file
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-pcu/+/20860 )
Change subject: Move dl_tbf allocation code to correct file
..
Move dl_tbf allocation code to correct file
Change-Id: I50d41b1c6f244edcfb78646d0fac4e47c2e3e561
---
M src/tbf.cpp
M src/tbf.h
M src/tbf_dl.cpp
M src/tbf_dl.h
4 files changed, 116 insertions(+), 111 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/60/20860/1
diff --git a/src/tbf.cpp b/src/tbf.cpp
index b2aad0c..2fbf5bf 100644
--- a/src/tbf.cpp
+++ b/src/tbf.cpp
@@ -109,25 +109,6 @@
{ "rlc:nacked", "RLC Nacked " },
};
-static const struct rate_ctr_desc tbf_dl_gprs_ctr_description[] = {
-{ "gprs:downlink:cs1", "CS1" },
-{ "gprs:downlink:cs2", "CS2" },
-{ "gprs:downlink:cs3", "CS3" },
-{ "gprs:downlink:cs4", "CS4" },
-};
-
-static const struct rate_ctr_desc tbf_dl_egprs_ctr_description[] = {
-{ "egprs:downlink:mcs1","MCS1" },
-{ "egprs:downlink:mcs2","MCS2" },
-{ "egprs:downlink:mcs3","MCS3" },
-{ "egprs:downlink:mcs4","MCS4" },
-{ "egprs:downlink:mcs5","MCS5" },
-{ "egprs:downlink:mcs6","MCS6" },
-{ "egprs:downlink:mcs7","MCS7" },
-{ "egprs:downlink:mcs8","MCS8" },
-{ "egprs:downlink:mcs9","MCS9" },
-};
-
const struct rate_ctr_group_desc tbf_ctrg_desc = {
"pcu:tbf",
"TBF Statistics",
@@ -136,22 +117,6 @@
tbf_ctr_description,
};
-static const struct rate_ctr_group_desc tbf_dl_gprs_ctrg_desc = {
-"tbf:gprs",
-"Data Blocks",
-OSMO_STATS_CLASS_SUBSCRIBER,
-ARRAY_SIZE(tbf_dl_gprs_ctr_description),
-tbf_dl_gprs_ctr_description,
-};
-
-static const struct rate_ctr_group_desc tbf_dl_egprs_ctrg_desc = {
-"tbf:egprs",
-"Data Blocks",
-OSMO_STATS_CLASS_SUBSCRIBER,
-ARRAY_SIZE(tbf_dl_egprs_ctr_description),
-tbf_dl_egprs_ctr_description,
-};
-
static void setup_egprs_mode(gprs_rlcmac_bts *bts, GprsMs *ms)
{
if (mcs_is_edge_gmsk(mcs_get_egprs_by_num(bts->max_mcs_ul)) &&
@@ -894,80 +859,6 @@
return 0;
}
-static int dl_tbf_dtor(struct gprs_rlcmac_dl_tbf *tbf)
-{
- tbf->~gprs_rlcmac_dl_tbf();
- return 0;
-}
-
-struct gprs_rlcmac_dl_tbf *tbf_alloc_dl_tbf(struct gprs_rlcmac_bts *bts,
GprsMs *ms, int8_t use_trx, bool single_slot)
-{
- struct gprs_rlcmac_dl_tbf *tbf;
- int rc;
-
- OSMO_ASSERT(ms != NULL);
-
- if (ms->egprs_ms_class() == 0 && bts->egprs_enabled) {
- if (ms->ms_class() > 0) {
- LOGP(DTBF, LOGL_NOTICE, "Not accepting non-EGPRS phone
in EGPRS-only mode\n");
- bts->bts->do_rate_ctr_inc(CTR_TBF_FAILED_EGPRS_ONLY);
- return NULL;
- }
- ms->set_egprs_ms_class(1);
- }
-
- LOGP(DTBF, LOGL_DEBUG, "** DL-TBF starts here **\n");
- LOGP(DTBF, LOGL_INFO, "Allocating DL TBF: MS_CLASS=%d/%d\n",
-ms->ms_class(), ms->egprs_ms_class());
-
- tbf = talloc(tall_pcu_ctx, struct gprs_rlcmac_dl_tbf);
-
- if (!tbf)
- return NULL;
-
- talloc_set_destructor(tbf, dl_tbf_dtor);
- new (tbf) gprs_rlcmac_dl_tbf(bts->bts, ms);
-
- rc = tbf->setup(use_trx, single_slot);
- /* if no resource */
- if (rc < 0) {
- talloc_free(tbf);
- return NULL;
- }
-
- if (tbf->is_egprs_enabled()) {
- tbf->set_window_size();
- tbf->m_dl_egprs_ctrs = rate_ctr_group_alloc(tbf,
- &tbf_dl_egprs_ctrg_desc,
- tbf->m_ctrs->idx);
- if (!tbf->m_dl_egprs_ctrs) {
- LOGPTBF(tbf, LOGL_ERROR, "Couldn't allocate EGPRS DL
counters\n");
- talloc_free(tbf);
- return NULL;
- }
- } else {
- tbf->m_dl_gprs_ctrs = rate_ctr_group_alloc(tbf,
- &tbf_dl_gprs_ctrg_desc,
- tbf->m_ctrs->idx);
- if (!tbf->m_dl_gprs_ctrs) {
- LOGPTBF(tbf, LOGL_ERROR, "Couldn't allocate GPRS DL
counters\n");
- talloc_free(tbf);
- return NULL;
- }
- }
-
- llist_add(&tbf->list(), &bts->bts->dl_tbfs());
- tbf->bts->do_rate_ctr_inc(CTR_TBF_DL_ALLOCATED);
-
- tbf->m_last_dl_poll_fn = -1;
-
Change in osmo-pcu[master]: Move ul_tbf allocation code to correct file
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-pcu/+/20859 )
Change subject: Move ul_tbf allocation code to correct file
..
Move ul_tbf allocation code to correct file
Change-Id: Ifd98abbcce49e4605c764267965903fbf9f35867
---
M src/gprs_ms.h
M src/tbf.cpp
M src/tbf.h
M src/tbf_ul.cpp
M src/tbf_ul.h
5 files changed, 170 insertions(+), 167 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/59/20859/1
diff --git a/src/gprs_ms.h b/src/gprs_ms.h
index 0a1dda7..412a400 100644
--- a/src/gprs_ms.h
+++ b/src/gprs_ms.h
@@ -25,6 +25,7 @@
#include "cxx_linuxlist.h"
#include "llc.h"
#include "tbf.h"
+#include "tbf_ul.h"
#include "tbf_dl.h"
#include "pcu_l1_if.h"
diff --git a/src/tbf.cpp b/src/tbf.cpp
index 305a549..b2aad0c 100644
--- a/src/tbf.cpp
+++ b/src/tbf.cpp
@@ -57,7 +57,7 @@
extern void *tall_pcu_ctx;
-static unsigned int next_tbf_ctr_group_id = 0; /* Incrementing group id */
+unsigned int next_tbf_ctr_group_id = 0; /* Incrementing group id */
static void tbf_timer_cb(void *_tbf);
@@ -128,26 +128,7 @@
{ "egprs:downlink:mcs9","MCS9" },
};
-static const struct rate_ctr_desc tbf_ul_gprs_ctr_description[] = {
-{ "gprs:uplink:cs1", "CS1" },
-{ "gprs:uplink:cs2", "CS2" },
-{ "gprs:uplink:cs3", "CS3" },
-{ "gprs:uplink:cs4", "CS4" },
-};
-
-static const struct rate_ctr_desc tbf_ul_egprs_ctr_description[] = {
-{ "egprs:uplink:mcs1","MCS1" },
-{ "egprs:uplink:mcs2","MCS2" },
-{ "egprs:uplink:mcs3","MCS3" },
-{ "egprs:uplink:mcs4","MCS4" },
-{ "egprs:uplink:mcs5","MCS5" },
-{ "egprs:uplink:mcs6","MCS6" },
-{ "egprs:uplink:mcs7","MCS7" },
-{ "egprs:uplink:mcs8","MCS8" },
-{ "egprs:uplink:mcs9","MCS9" },
-};
-
-static const struct rate_ctr_group_desc tbf_ctrg_desc = {
+const struct rate_ctr_group_desc tbf_ctrg_desc = {
"pcu:tbf",
"TBF Statistics",
OSMO_STATS_CLASS_SUBSCRIBER,
@@ -171,22 +152,6 @@
tbf_dl_egprs_ctr_description,
};
-static const struct rate_ctr_group_desc tbf_ul_gprs_ctrg_desc = {
-"tbf:gprs",
-"Data Blocks",
-OSMO_STATS_CLASS_SUBSCRIBER,
-ARRAY_SIZE(tbf_ul_gprs_ctr_description),
-tbf_ul_gprs_ctr_description,
-};
-
-static const struct rate_ctr_group_desc tbf_ul_egprs_ctrg_desc = {
-"tbf:egprs",
-"Data Blocks",
-OSMO_STATS_CLASS_SUBSCRIBER,
-ARRAY_SIZE(tbf_ul_egprs_ctr_description),
-tbf_ul_egprs_ctr_description,
-};
-
static void setup_egprs_mode(gprs_rlcmac_bts *bts, GprsMs *ms)
{
if (mcs_is_edge_gmsk(mcs_get_egprs_by_num(bts->max_mcs_ul)) &&
@@ -407,29 +372,6 @@
ms()->confirm_tlli(tlli);
}
-gprs_rlcmac_ul_tbf *tbf_alloc_ul(struct gprs_rlcmac_bts *bts, GprsMs *ms,
int8_t use_trx,
-uint32_t tlli)
-{
- struct gprs_rlcmac_ul_tbf *tbf;
-
-/* FIXME: Copy and paste with tbf_new_dl_assignment */
- /* create new TBF, use same TRX as DL TBF */
- /* use multislot class of downlink TBF */
- tbf = tbf_alloc_ul_tbf(bts, ms, use_trx, false);
- if (!tbf) {
- LOGP(DTBF, LOGL_NOTICE, "No PDCH resource\n");
- /* FIXME: send reject */
- return NULL;
- }
- tbf->m_contention_resolution_done = 1;
- TBF_SET_ASS_ON(tbf, GPRS_RLCMAC_FLAG_PACCH, false);
- T_START(tbf, T3169, 3169, "allocation (UL-TBF)", true);
- tbf->update_ms(tlli, GPRS_RLCMAC_UL_TBF);
- OSMO_ASSERT(tbf->ms());
-
- return tbf;
-}
-
static void tbf_unlink_pdch(struct gprs_rlcmac_tbf *tbf)
{
int ts;
@@ -952,62 +894,6 @@
return 0;
}
-static int ul_tbf_dtor(struct gprs_rlcmac_ul_tbf *tbf)
-{
- tbf->~gprs_rlcmac_ul_tbf();
- return 0;
-}
-
-struct gprs_rlcmac_ul_tbf *tbf_alloc_ul_tbf(struct gprs_rlcmac_bts *bts,
GprsMs *ms, int8_t use_trx, bool single_slot)
-{
- struct gprs_rlcmac_ul_tbf *tbf;
- int rc;
-
- OSMO_ASSERT(ms != NULL);
-
- if (ms->egprs_ms_class() == 0 && bts->egprs_enabled) {
- LOGP(DTBF, LOGL_NOTICE, "Not accepting non-EGPRS phone in
EGPRS-only mode\n");
- bts->bts->do_rate_ctr_inc(CTR_TBF_FAILED_EGPRS_ONLY);
- return NULL;
- }
-
- LOGP(DTBF, LOGL_DEBUG, "** UL-TBF starts here **\n");
- LOGP(DTBF, LOGL_INFO, "Allocating UL TBF: MS_CLASS=%d/%d\n",
-ms->ms_class(), ms->egprs_ms_class());
-
- tbf = talloc(tall_pcu_ctx, struct gprs_rlcmac_ul_tbf);
- if (!tbf)
- return
Change in osmo-bts[master]: measurement: count all blocks as SUB for TCH/F in signalling mode
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/20852 ) Change subject: measurement: count all blocks as SUB for TCH/F in signalling mode .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20852 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I04be21200afa1d03afa0d7e476c66fa79cf42249 Gerrit-Change-Number: 20852 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Fri, 23 Oct 2020 20:36:43 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: sched_lchan_tchf: count measurements for FACCH/F only once
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/20841 ) Change subject: sched_lchan_tchf: count measurements for FACCH/F only once .. Patch Set 3: -Code-Review (1 comment) https://gerrit.osmocom.org/c/osmo-bts/+/20841/3/src/osmo-bts-trx/sched_lchan_tchf.c File src/osmo-bts-trx/sched_lchan_tchf.c: https://gerrit.osmocom.org/c/osmo-bts/+/20841/3/src/osmo-bts-trx/sched_lchan_tchf.c@311 PS3, Line 311: bfi_flag ? bi->toa256 : meas_avg.toa256 Oh, I guess this patch would not work because we do not set 'bfi_flag' in case of FACCH. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20841 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ie3f2e620ba2a2ab2fecdbae627ef01c6128fce0b Gerrit-Change-Number: 20841 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 23 Oct 2020 20:35:53 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: sched_lchan_tchf: count measurements for FACCH/F only once
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/20841 ) Change subject: sched_lchan_tchf: count measurements for FACCH/F only once .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/osmo-bts/+/20841/3/src/osmo-bts-trx/sched_lchan_tchf.c File src/osmo-bts-trx/sched_lchan_tchf.c: https://gerrit.osmocom.org/c/osmo-bts/+/20841/3/src/osmo-bts-trx/sched_lchan_tchf.c@245 PS3, Line 245: If we are in SPEECH mode > So let's then make this memset() a part of the condition below ;) Otherwise > we always call it, even […] Or maybe we should avoid memset() here by adding a boolean flag 'dummy' to 'struct l1sched_meas_set' and setting it to true here? This way we keep potentially useful information and eliminate the need to memset() the whole structure. What do you think? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20841 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ie3f2e620ba2a2ab2fecdbae627ef01c6128fce0b Gerrit-Change-Number: 20841 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 23 Oct 2020 20:26:37 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment
Change in osmo-bts[master]: sched_lchan_tchf: count measurements for FACCH/F only once
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/20841 ) Change subject: sched_lchan_tchf: count measurements for FACCH/F only once .. Patch Set 3: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-bts/+/20841/3/src/osmo-bts-trx/sched_lchan_tchf.c File src/osmo-bts-trx/sched_lchan_tchf.c: https://gerrit.osmocom.org/c/osmo-bts/+/20841/3/src/osmo-bts-trx/sched_lchan_tchf.c@245 PS3, Line 245: If we are in SPEECH mode So let's then make this memset() a part of the condition below ;) Otherwise we always call it, even if we're in signalling mode (if the compiler is not smart enough to optimize this). -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20841 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ie3f2e620ba2a2ab2fecdbae627ef01c6128fce0b Gerrit-Change-Number: 20841 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 23 Oct 2020 20:20:46 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: cosmetic: add missing semicolon after OSMO_ASSERT()
dexter has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/20851 )
Change subject: cosmetic: add missing semicolon after OSMO_ASSERT()
..
cosmetic: add missing semicolon after OSMO_ASSERT()
Change-Id: Ib886115418939990ecfb6ecc1a4528f7a015b913
---
M src/common/measurement.c
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, approved
diff --git a/src/common/measurement.c b/src/common/measurement.c
index 22f783d..8a6da75 100644
--- a/src/common/measurement.c
+++ b/src/common/measurement.c
@@ -421,7 +421,7 @@
/* AMR is using a more elaborated model with a dymanic amount of
* DTX blocks so this function is not applicable to determine the
* amount of expected SUB Measurements when AMR is used */
- OSMO_ASSERT(lchan->tch_mode != GSM48_CMODE_SPEECH_AMR)
+ OSMO_ASSERT(lchan->tch_mode != GSM48_CMODE_SPEECH_AMR);
switch (pchan) {
case GSM_PCHAN_TCH_F:
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20851
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ib886115418939990ecfb6ecc1a4528f7a015b913
Gerrit-Change-Number: 20851
Gerrit-PatchSet: 1
Gerrit-Owner: dexter
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter
Gerrit-Reviewer: fixeria
Gerrit-MessageType: merged
Change in osmo-bts[master]: cosmetic: add missing semicolon after OSMO_ASSERT()
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/20851 ) Change subject: cosmetic: add missing semicolon after OSMO_ASSERT() .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20851 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ib886115418939990ecfb6ecc1a4528f7a015b913 Gerrit-Change-Number: 20851 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Fri, 23 Oct 2020 20:12:40 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: measurement: count measurements for FACCH/H twice.
dexter has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/20840 ) Change subject: measurement: count measurements for FACCH/H twice. .. Abandoned (there is a better way to do this) -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20840 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id533bb3207bac40d00d77b484619f66ea5c0774d Gerrit-Change-Number: 20840 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: abandon
Change in osmo-bts[master]: measurement: fix expected number of measurements
dexter has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-bts/+/20853 )
Change subject: measurement: fix expected number of measurements
..
measurement: fix expected number of measurements
The logic in measurement.c checks the amount of collected measurement
values. This is done for the total amount of measurements and the amount
of SUB blocks measurements.
The functions that return the expected number of measurement values
currently do not take into account that the mode of a TCH/F or TCH/H has
an effect on the number of expected SUB blocks. (In signalling channels
all blocks count as SUB). Also a TCH/H in signalling mode generates only
half the amount of measurements because the blocks in signalling mode
are sepreded over 6 bursts instead of 4. This also needs to be taken
into account.
Change-Id: I01c7b6cc908c647263ab88f6b6281c4732f88779
Related: OS#4799
---
M src/common/measurement.c
1 file changed, 24 insertions(+), 7 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/53/20853/1
diff --git a/src/common/measurement.c b/src/common/measurement.c
index 1805553..f1e252e 100644
--- a/src/common/measurement.c
+++ b/src/common/measurement.c
@@ -397,11 +397,16 @@
switch (pchan) {
case GSM_PCHAN_TCH_F:
- /* 24 for TCH + 1 for SACCH */
+ /* 24 blocks for TCH + 1 for SACCH */
return 25;
case GSM_PCHAN_TCH_H:
- /* 24 half-blocks for TCH + 1 for SACCH */
- return 25;
+ if (lchan->tch_mode == GSM48_CMODE_SIGN) {
+ /* 12 blocks for TCH + 1 for SACCH */
+ return 13;
+ } else {
+ /* 24 blocks for TCH + 1 for SACCH */
+ return 25;
+ }
case GSM_PCHAN_SDCCH8_SACCH8C:
case GSM_PCHAN_SDCCH8_SACCH8C_CBCH:
/* 2 for SDCCH + 1 for SACCH */
@@ -428,11 +433,21 @@
switch (pchan) {
case GSM_PCHAN_TCH_F:
- /* 1 block SDCCH, 2 blocks TCH */
- return 3;
+ if (lchan->tch_mode == GSM48_CMODE_SIGN) {
+ /* 1 block SACCH, 24 blocks TCH (see note 1) */
+ return 25;
+ } else {
+ /* 1 block SACCH, 4 blocks TCH */
+ return 3;
+ }
case GSM_PCHAN_TCH_H:
- /* 1 block SDCCH, 4 half-blocks TCH */
- return 5;
+ if (lchan->tch_mode == GSM48_CMODE_SIGN) {
+ /* 1 block SACCH, 12 blocks TCH (see ynote 1) */
+ return 13;
+ } else {
+ /* 1 block SACCH, 4 blocks TCH */
+ return 5;
+ }
case GSM_PCHAN_SDCCH8_SACCH8C:
case GSM_PCHAN_SDCCH8_SACCH8C_CBCH:
/* no DTX here, all blocks must be present! */
@@ -444,6 +459,8 @@
default:
return 0;
}
+
+ /* Note 1: In signalling mode all blocks count as SUB blocks. */
}
/* if we clip the TOA value to 12 bits, i.e. toa256=3200,
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20853
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I01c7b6cc908c647263ab88f6b6281c4732f88779
Gerrit-Change-Number: 20853
Gerrit-PatchSet: 1
Gerrit-Owner: dexter
Gerrit-MessageType: newchange
Change in osmo-bts[master]: cosmetic: add missing semicolon after OSMO_ASSERT()
dexter has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-bts/+/20851 )
Change subject: cosmetic: add missing semicolon after OSMO_ASSERT()
..
cosmetic: add missing semicolon after OSMO_ASSERT()
Change-Id: Ib886115418939990ecfb6ecc1a4528f7a015b913
---
M src/common/measurement.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/51/20851/1
diff --git a/src/common/measurement.c b/src/common/measurement.c
index 22f783d..8a6da75 100644
--- a/src/common/measurement.c
+++ b/src/common/measurement.c
@@ -421,7 +421,7 @@
/* AMR is using a more elaborated model with a dymanic amount of
* DTX blocks so this function is not applicable to determine the
* amount of expected SUB Measurements when AMR is used */
- OSMO_ASSERT(lchan->tch_mode != GSM48_CMODE_SPEECH_AMR)
+ OSMO_ASSERT(lchan->tch_mode != GSM48_CMODE_SPEECH_AMR);
switch (pchan) {
case GSM_PCHAN_TCH_F:
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20851
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ib886115418939990ecfb6ecc1a4528f7a015b913
Gerrit-Change-Number: 20851
Gerrit-PatchSet: 1
Gerrit-Owner: dexter
Gerrit-MessageType: newchange
Change in osmo-bts[master]: measurement: count all blocks as SUB for TCH/F in signalling mode
dexter has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-bts/+/20852 )
Change subject: measurement: count all blocks as SUB for TCH/F in signalling
mode
..
measurement: count all blocks as SUB for TCH/F in signalling mode
SUB frames exist only in voice (or CSD) channels. When a TCH/F is in
signalling mode, all blocks must be counted as SUB blocks. (for TCH/H
the current implementation is correct.)
Change-Id: I04be21200afa1d03afa0d7e476c66fa79cf42249
Related: OS#4799
---
M src/common/measurement.c
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/52/20852/1
diff --git a/src/common/measurement.c b/src/common/measurement.c
index 8a6da75..1805553 100644
--- a/src/common/measurement.c
+++ b/src/common/measurement.c
@@ -55,7 +55,6 @@
switch (lchan->type) {
case GSM_LCHAN_TCH_F:
switch (lchan->tch_mode) {
- case GSM48_CMODE_SIGN:
case GSM48_CMODE_SPEECH_V1:
case GSM48_CMODE_SPEECH_EFR:
if (trx_sched_is_sacch_fn(lchan->ts, fn, true))
@@ -67,6 +66,10 @@
if (trx_sched_is_sacch_fn(lchan->ts, fn, true))
return true;
break;
+ case GSM48_CMODE_SIGN:
+ /* No DTX allowed; SUB=FULL, therefore measurements at
all frame numbers are
+* SUB */
+ return true;
default:
LOGPFN(DMEAS, LOGL_ERROR, fn, "%s: Unsupported
lchan->tch_mode %u\n",
gsm_lchan_name(lchan), lchan->tch_mode);
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20852
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I04be21200afa1d03afa0d7e476c66fa79cf42249
Gerrit-Change-Number: 20852
Gerrit-PatchSet: 1
Gerrit-Owner: dexter
Gerrit-MessageType: newchange
Change in osmo-pcu[master]: Fix several calls to LOGPAL
laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-pcu/+/20850 )
Change subject: Fix several calls to LOGPAL
..
Fix several calls to LOGPAL
In those cases since a string pointer was passed, it always printed
"single" instead of whatever really was being used, since the string
pointer was not NULL.
Change-Id: Idab7d18e8f519e10fc3df4007634661c46f9256d
---
M src/gprs_rlcmac_ts_alloc.cpp
M tests/alloc/AllocTest.err
M tests/tbf/TbfTest.err
3 files changed, 28 insertions(+), 28 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/src/gprs_rlcmac_ts_alloc.cpp b/src/gprs_rlcmac_ts_alloc.cpp
index a1c0838..9551c59 100644
--- a/src/gprs_rlcmac_ts_alloc.cpp
+++ b/src/gprs_rlcmac_ts_alloc.cpp
@@ -363,7 +363,7 @@
trx_no = find_trx(bts, ms, use_trx);
if (trx_no < 0) {
- LOGPAL(tbf, "A", single ? "single" : "multi", use_trx,
LOGL_NOTICE,
+ LOGPAL(tbf, "A", single, use_trx, LOGL_NOTICE,
"failed to find a usable TRX (TFI exhausted)\n");
return trx_no;
}
@@ -392,13 +392,13 @@
&tfi, &usf);
if (tbf->direction == GPRS_RLCMAC_UL_TBF && usf < 0) {
- LOGPAL(tbf, "A", single ? "single" : "multi", use_trx,
LOGL_NOTICE,
+ LOGPAL(tbf, "A", single, use_trx, LOGL_NOTICE,
"failed to allocate a TS, no USF available\n");
return -EBUSY;
}
if (ts < 0) {
- LOGPAL(tbf, "A", single ? "single" : "multi", use_trx,
LOGL_NOTICE,
+ LOGPAL(tbf, "A", single, use_trx, LOGL_NOTICE,
"failed to allocate a TS, no TFI available\n");
return -EBUSY;
}
diff --git a/tests/alloc/AllocTest.err b/tests/alloc/AllocTest.err
index 3549793..395e38f 100644
--- a/tests/alloc/AllocTest.err
+++ b/tests/alloc/AllocTest.err
@@ -193,7 +193,7 @@
TBF(TFI=31 TLLI=0x DIR=DL STATE=NULL) Allocated: trx = 0, ul_slots =
08, dl_slots = 08
No TFI available (suggested TRX: 0).
Allocating DL TBF: MS_CLASS=0/0
-[DL] algo A (suggested TRX: -1): failed to find a usable TRX (TFI
exhausted)
+[DL] algo A (suggested TRX: -1): failed to find a usable TRX (TFI
exhausted)
TBF(TFI=0 TLLI=0x DIR=DL STATE=RELEASING) free
TBF(TFI=0 TLLI=0x DIR=DL STATE=RELEASING) free
TBF(TFI=1 TLLI=0x DIR=DL STATE=RELEASING) free
@@ -305,7 +305,7 @@
TBF(TFI=6 TLLI=0x DIR=UL STATE=NULL) Setting Control TS 3
TBF(TFI=6 TLLI=0x DIR=UL STATE=NULL) Allocated: trx = 0, ul_slots =
08, dl_slots = 00
Allocating UL TBF: MS_CLASS=0/0
-[UL] algo A (suggested TRX: -1): failed to allocate a TS, no USF
available
+[UL] algo A (suggested TRX: -1): failed to allocate a TS, no USF
available
TBF(TFI=0 TLLI=0x DIR=UL STATE=NULL) free
TBF(TFI=0 TLLI=0x DIR=UL STATE=NULL) free
TBF(TFI=1 TLLI=0x DIR=UL STATE=NULL) free
@@ -713,7 +713,7 @@
TBF(TFI=31 TLLI=0x DIR=DL STATE=NULL) Allocated: trx = 0, ul_slots =
10, dl_slots = 10
No TFI available (suggested TRX: 0).
Allocating DL TBF: MS_CLASS=0/0
-[DL] algo A (suggested TRX: -1): failed to find a usable TRX (TFI
exhausted)
+[DL] algo A (suggested TRX: -1): failed to find a usable TRX (TFI
exhausted)
TBF(TFI=0 TLLI=0x DIR=DL STATE=RELEASING) free
TBF(TFI=0 TLLI=0x DIR=DL STATE=RELEASING) free
TBF(TFI=0 TLLI=0x DIR=DL STATE=RELEASING) free
@@ -931,7 +931,7 @@
TBF(TFI=6 TLLI=0x DIR=UL STATE=NULL) Setting Control TS 4
TBF(TFI=6 TLLI=0x DIR=UL STATE=NULL) Allocated: trx = 0, ul_slots =
10, dl_slots = 00
Allocating UL TBF: MS_CLASS=0/0
-[UL] algo A (suggested TRX: -1): failed to allocate a TS, no USF
available
+[UL] algo A (suggested TRX: -1): failed to allocate a TS, no USF
available
TBF(TFI=0 TLLI=0x DIR=UL STATE=NULL) free
TBF(TFI=0 TLLI=0x DIR=UL STATE=NULL) free
TBF(TFI=0 TLLI=0x DIR=UL STATE=NULL) free
@@ -189959,7 +189959,7 @@
TBF(TFI=6 TLLI=0x DIR=DL STATE=NULL) Setting Control TS 7
TBF(TFI=6 TLLI=0x DIR=DL STATE=NULL) Allocated: trx = 0, ul_slots =
80, dl_slots = 80
Allocating UL TBF: MS_CLASS=1/0
-[UL] algo A (suggested TRX: -1): failed to allocate a TS, no USF
available
+[UL] algo A (suggested TRX: -1): failed to allocate a TS, no USF
available
Allocating UL TBF: MS_CLASS=10/0
TBF(TFI=0 TLLI=0x DIR=UL STATE=NULL) Setting Control TS 5
TBF(TFI=0 TLLI=0x DIR=UL STATE=NULL) Allocated: trx = 0, ul_slots =
20, dl_slots = 00
@@ -190961,7 +190961,7 @@
TBF(TFI=4 TLLI=0x DIR=DL STATE=NULL) Allocated: trx = 0, ul_slots =
08, dl_slots = 08
No TFI available (suggested TRX: 0).
Allocating UL TBF: MS_CLASS=36/0
-[UL] algo A (suggested TRX: -1): failed to allocate a TS, no USF
available
+[UL] algo A (suggested TRX: -1): failed to allocate a TS,
Change in osmo-pcu[master]: Improve debug logging for alloc algos
laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-pcu/+/20849 )
Change subject: Improve debug logging for alloc algos
..
Improve debug logging for alloc algos
In general we want to see explicitly the kind of requested allocation at
the start. The MS class is not needed since it's printed in the previous
log line in any case.
Change-Id: I9eb0a592c15be96da9d140ff373c1afead76b18c
---
M src/gprs_rlcmac_ts_alloc.cpp
M tests/tbf/TbfTest.err
2 files changed, 115 insertions(+), 109 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/src/gprs_rlcmac_ts_alloc.cpp b/src/gprs_rlcmac_ts_alloc.cpp
index 16498ce..a1c0838 100644
--- a/src/gprs_rlcmac_ts_alloc.cpp
+++ b/src/gprs_rlcmac_ts_alloc.cpp
@@ -359,7 +359,7 @@
const gprs_rlcmac_tbf *tbf = tbf_;
gprs_rlcmac_trx *trx = ms->current_trx();
- LOGPSL(tbf, LOGL_DEBUG, "Slot Allocation (Algorithm A) for class %d\n",
tbf->ms_class());
+ LOGPAL(tbf, "A", single, use_trx, LOGL_DEBUG, "Alloc start\n");
trx_no = find_trx(bts, ms, use_trx);
if (trx_no < 0) {
@@ -858,6 +858,8 @@
const gprs_rlcmac_tbf *tbf = tbf_;
gprs_rlcmac_trx *trx;
+ LOGPAL(tbf, "B", single, use_trx, LOGL_DEBUG, "Alloc start\n");
+
/* Step 1: Get current state from the MS object */
if (!ms) {
diff --git a/tests/tbf/TbfTest.err b/tests/tbf/TbfTest.err
index ce23802..fa53925 100644
--- a/tests/tbf/TbfTest.err
+++ b/tests/tbf/TbfTest.err
@@ -4,7 +4,7 @@
Creating MS object, TLLI = 0x
** DL-TBF starts here **
Allocating DL TBF: MS_CLASS=0/0
-[DL] Slot Allocation (Algorithm A) for class 0
+[DL] algo A (suggested TRX: 0): Alloc start
- Skipping TS 0, because not enabled
- Skipping TS 1, because not enabled
- Skipping TS 4, because not enabled
@@ -21,7 +21,7 @@
Modifying MS object, TLLI = 0x2342, TA 220 -> 4
** UL-TBF starts here **
Allocating UL TBF: MS_CLASS=0/0
-[UL] Slot Allocation (Algorithm A) for class 0
+[UL] algo A (suggested TRX: 0): Alloc start
- Skipping TS 0, because not enabled
- Skipping TS 1, because not enabled
- Skipping TS 3, because need to reuse TS
@@ -46,7 +46,7 @@
Found TFI=0.
** DL-TBF starts here **
Allocating DL TBF: MS_CLASS=45/0
-[DL] Slot Allocation (Algorithm A) for class 45
+[DL] algo A (suggested TRX: 0): Alloc start
- Skipping TS 0, because not enabled
- Skipping TS 1, because not enabled
- Skipping TS 2, because not enabled
@@ -95,7 +95,7 @@
TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT RELEASE) starting timer T3193
[release (DL-TBF)] with 0 sec. 10 microsec, cur_fn=0
** DL-TBF starts here **
Allocating DL TBF: MS_CLASS=45/0
-[DL] Slot Allocation (Algorithm A) for class 45
+[DL] algo A (suggested TRX: 0): Alloc start
- Skipping TS 0, because not enabled
- Skipping TS 1, because not enabled
- Skipping TS 2, because not enabled
@@ -136,7 +136,7 @@
Found TFI=0.
** DL-TBF starts here **
Allocating DL TBF: MS_CLASS=45/0
-[DL] Slot Allocation (Algorithm A) for class 45
+[DL] algo A (suggested TRX: 0): Alloc start
- Skipping TS 0, because not enabled
- Skipping TS 1, because not enabled
- Skipping TS 2, because not enabled
@@ -185,7 +185,7 @@
TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT RELEASE) starting timer T3193
[release (DL-TBF)] with 0 sec. 10 microsec, cur_fn=0
** DL-TBF starts here **
Allocating DL TBF: MS_CLASS=45/0
-[DL] Slot Allocation (Algorithm A) for class 45
+[DL] algo A (suggested TRX: 0): Alloc start
- Skipping TS 0, because not enabled
- Skipping TS 1, because not enabled
- Skipping TS 2, because not enabled
@@ -226,7 +226,7 @@
Found TFI=0.
** DL-TBF starts here **
Allocating DL TBF: MS_CLASS=45/0
-[DL] Slot Allocation (Algorithm A) for class 45
+[DL] algo A (suggested TRX: 0): Alloc start
- Skipping TS 0, because not enabled
- Skipping TS 1, because not enabled
- Skipping TS 2, because not enabled
@@ -481,7 +481,7 @@
Found TFI=0.
** DL-TBF starts here **
Allocating DL TBF: MS_CLASS=45/0
-[DL] Slot Allocation (Algorithm A) for class 45
+[DL] algo A (suggested TRX: 0): Alloc start
- Skipping TS 0, because not enabled
- Skipping TS 1, because not enabled
- Skipping TS 2, because not enabled
@@ -503,7 +503,7 @@
Found TFI=1.
** DL-TBF starts here **
Allocating DL TBF: MS_CLASS=45/0
-[DL] Slot Allocation (Algorithm A) for class 45
+[DL] algo A (suggested TRX: 0): Alloc start
- Skipping TS 0, because not enabled
- Skipping TS 1, because not enabled
- Skipping TS 2, because not enabled
@@ -546,7 +546,7 @@
Modifying MS object, TLLI = 0x, MS class 0 -> 45
** DL-TBF starts here **
Allocating DL TBF: MS_CLASS=45/0
-[DL] Slot Allocation (Algorithm A) for class 45
+[DL] algo A (suggested TRX: -1): All
Change in osmo-pcu[master]: Fix several calls to LOGPAL
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/20850 ) Change subject: Fix several calls to LOGPAL .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/20850 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Idab7d18e8f519e10fc3df4007634661c46f9256d Gerrit-Change-Number: 20850 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 23 Oct 2020 19:17:39 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: Improve debug logging for alloc algos
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/20849 ) Change subject: Improve debug logging for alloc algos .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/20849 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I9eb0a592c15be96da9d140ff373c1afead76b18c Gerrit-Change-Number: 20849 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 23 Oct 2020 19:18:11 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: Improve debug logging for alloc algos
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-pcu/+/20849 )
Change subject: Improve debug logging for alloc algos
..
Improve debug logging for alloc algos
In general we want to see explicitly the kind of requested allocation at
the start. The MS class is not needed since it's printed in the previous
log line in any case.
Change-Id: I9eb0a592c15be96da9d140ff373c1afead76b18c
---
M src/gprs_rlcmac_ts_alloc.cpp
M tests/tbf/TbfTest.err
2 files changed, 115 insertions(+), 109 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/49/20849/1
diff --git a/src/gprs_rlcmac_ts_alloc.cpp b/src/gprs_rlcmac_ts_alloc.cpp
index 16498ce..a1c0838 100644
--- a/src/gprs_rlcmac_ts_alloc.cpp
+++ b/src/gprs_rlcmac_ts_alloc.cpp
@@ -359,7 +359,7 @@
const gprs_rlcmac_tbf *tbf = tbf_;
gprs_rlcmac_trx *trx = ms->current_trx();
- LOGPSL(tbf, LOGL_DEBUG, "Slot Allocation (Algorithm A) for class %d\n",
tbf->ms_class());
+ LOGPAL(tbf, "A", single, use_trx, LOGL_DEBUG, "Alloc start\n");
trx_no = find_trx(bts, ms, use_trx);
if (trx_no < 0) {
@@ -858,6 +858,8 @@
const gprs_rlcmac_tbf *tbf = tbf_;
gprs_rlcmac_trx *trx;
+ LOGPAL(tbf, "B", single, use_trx, LOGL_DEBUG, "Alloc start\n");
+
/* Step 1: Get current state from the MS object */
if (!ms) {
diff --git a/tests/tbf/TbfTest.err b/tests/tbf/TbfTest.err
index ce23802..fa53925 100644
--- a/tests/tbf/TbfTest.err
+++ b/tests/tbf/TbfTest.err
@@ -4,7 +4,7 @@
Creating MS object, TLLI = 0x
** DL-TBF starts here **
Allocating DL TBF: MS_CLASS=0/0
-[DL] Slot Allocation (Algorithm A) for class 0
+[DL] algo A (suggested TRX: 0): Alloc start
- Skipping TS 0, because not enabled
- Skipping TS 1, because not enabled
- Skipping TS 4, because not enabled
@@ -21,7 +21,7 @@
Modifying MS object, TLLI = 0x2342, TA 220 -> 4
** UL-TBF starts here **
Allocating UL TBF: MS_CLASS=0/0
-[UL] Slot Allocation (Algorithm A) for class 0
+[UL] algo A (suggested TRX: 0): Alloc start
- Skipping TS 0, because not enabled
- Skipping TS 1, because not enabled
- Skipping TS 3, because need to reuse TS
@@ -46,7 +46,7 @@
Found TFI=0.
** DL-TBF starts here **
Allocating DL TBF: MS_CLASS=45/0
-[DL] Slot Allocation (Algorithm A) for class 45
+[DL] algo A (suggested TRX: 0): Alloc start
- Skipping TS 0, because not enabled
- Skipping TS 1, because not enabled
- Skipping TS 2, because not enabled
@@ -95,7 +95,7 @@
TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT RELEASE) starting timer T3193
[release (DL-TBF)] with 0 sec. 10 microsec, cur_fn=0
** DL-TBF starts here **
Allocating DL TBF: MS_CLASS=45/0
-[DL] Slot Allocation (Algorithm A) for class 45
+[DL] algo A (suggested TRX: 0): Alloc start
- Skipping TS 0, because not enabled
- Skipping TS 1, because not enabled
- Skipping TS 2, because not enabled
@@ -136,7 +136,7 @@
Found TFI=0.
** DL-TBF starts here **
Allocating DL TBF: MS_CLASS=45/0
-[DL] Slot Allocation (Algorithm A) for class 45
+[DL] algo A (suggested TRX: 0): Alloc start
- Skipping TS 0, because not enabled
- Skipping TS 1, because not enabled
- Skipping TS 2, because not enabled
@@ -185,7 +185,7 @@
TBF(TFI=0 TLLI=0xffeeddcc DIR=DL STATE=WAIT RELEASE) starting timer T3193
[release (DL-TBF)] with 0 sec. 10 microsec, cur_fn=0
** DL-TBF starts here **
Allocating DL TBF: MS_CLASS=45/0
-[DL] Slot Allocation (Algorithm A) for class 45
+[DL] algo A (suggested TRX: 0): Alloc start
- Skipping TS 0, because not enabled
- Skipping TS 1, because not enabled
- Skipping TS 2, because not enabled
@@ -226,7 +226,7 @@
Found TFI=0.
** DL-TBF starts here **
Allocating DL TBF: MS_CLASS=45/0
-[DL] Slot Allocation (Algorithm A) for class 45
+[DL] algo A (suggested TRX: 0): Alloc start
- Skipping TS 0, because not enabled
- Skipping TS 1, because not enabled
- Skipping TS 2, because not enabled
@@ -481,7 +481,7 @@
Found TFI=0.
** DL-TBF starts here **
Allocating DL TBF: MS_CLASS=45/0
-[DL] Slot Allocation (Algorithm A) for class 45
+[DL] algo A (suggested TRX: 0): Alloc start
- Skipping TS 0, because not enabled
- Skipping TS 1, because not enabled
- Skipping TS 2, because not enabled
@@ -503,7 +503,7 @@
Found TFI=1.
** DL-TBF starts here **
Allocating DL TBF: MS_CLASS=45/0
-[DL] Slot Allocation (Algorithm A) for class 45
+[DL] algo A (suggested TRX: 0): Alloc start
- Skipping TS 0, because not enabled
- Skipping TS 1, because not enabled
- Skipping TS 2, because not enabled
@@ -546,7 +546,7 @@
Modifying MS object, TLLI = 0x, MS class 0 -> 45
** DL-TBF starts here **
Allocating DL TBF: MS_CLASS=45/0
-[DL] Slot Allocation (Algorithm A) for class 45
+[DL] algo A (suggested TRX:
Change in osmo-pcu[master]: Fix several calls to LOGPAL
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-pcu/+/20850 )
Change subject: Fix several calls to LOGPAL
..
Fix several calls to LOGPAL
In those cases since a string pointer was passed, it always printed
"single" instead of whatever really was being used, since the string
pointer was not NULL.
Change-Id: Idab7d18e8f519e10fc3df4007634661c46f9256d
---
M src/gprs_rlcmac_ts_alloc.cpp
M tests/alloc/AllocTest.err
M tests/tbf/TbfTest.err
3 files changed, 28 insertions(+), 28 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/50/20850/1
diff --git a/src/gprs_rlcmac_ts_alloc.cpp b/src/gprs_rlcmac_ts_alloc.cpp
index a1c0838..9551c59 100644
--- a/src/gprs_rlcmac_ts_alloc.cpp
+++ b/src/gprs_rlcmac_ts_alloc.cpp
@@ -363,7 +363,7 @@
trx_no = find_trx(bts, ms, use_trx);
if (trx_no < 0) {
- LOGPAL(tbf, "A", single ? "single" : "multi", use_trx,
LOGL_NOTICE,
+ LOGPAL(tbf, "A", single, use_trx, LOGL_NOTICE,
"failed to find a usable TRX (TFI exhausted)\n");
return trx_no;
}
@@ -392,13 +392,13 @@
&tfi, &usf);
if (tbf->direction == GPRS_RLCMAC_UL_TBF && usf < 0) {
- LOGPAL(tbf, "A", single ? "single" : "multi", use_trx,
LOGL_NOTICE,
+ LOGPAL(tbf, "A", single, use_trx, LOGL_NOTICE,
"failed to allocate a TS, no USF available\n");
return -EBUSY;
}
if (ts < 0) {
- LOGPAL(tbf, "A", single ? "single" : "multi", use_trx,
LOGL_NOTICE,
+ LOGPAL(tbf, "A", single, use_trx, LOGL_NOTICE,
"failed to allocate a TS, no TFI available\n");
return -EBUSY;
}
diff --git a/tests/alloc/AllocTest.err b/tests/alloc/AllocTest.err
index 3549793..395e38f 100644
--- a/tests/alloc/AllocTest.err
+++ b/tests/alloc/AllocTest.err
@@ -193,7 +193,7 @@
TBF(TFI=31 TLLI=0x DIR=DL STATE=NULL) Allocated: trx = 0, ul_slots =
08, dl_slots = 08
No TFI available (suggested TRX: 0).
Allocating DL TBF: MS_CLASS=0/0
-[DL] algo A (suggested TRX: -1): failed to find a usable TRX (TFI
exhausted)
+[DL] algo A (suggested TRX: -1): failed to find a usable TRX (TFI
exhausted)
TBF(TFI=0 TLLI=0x DIR=DL STATE=RELEASING) free
TBF(TFI=0 TLLI=0x DIR=DL STATE=RELEASING) free
TBF(TFI=1 TLLI=0x DIR=DL STATE=RELEASING) free
@@ -305,7 +305,7 @@
TBF(TFI=6 TLLI=0x DIR=UL STATE=NULL) Setting Control TS 3
TBF(TFI=6 TLLI=0x DIR=UL STATE=NULL) Allocated: trx = 0, ul_slots =
08, dl_slots = 00
Allocating UL TBF: MS_CLASS=0/0
-[UL] algo A (suggested TRX: -1): failed to allocate a TS, no USF
available
+[UL] algo A (suggested TRX: -1): failed to allocate a TS, no USF
available
TBF(TFI=0 TLLI=0x DIR=UL STATE=NULL) free
TBF(TFI=0 TLLI=0x DIR=UL STATE=NULL) free
TBF(TFI=1 TLLI=0x DIR=UL STATE=NULL) free
@@ -713,7 +713,7 @@
TBF(TFI=31 TLLI=0x DIR=DL STATE=NULL) Allocated: trx = 0, ul_slots =
10, dl_slots = 10
No TFI available (suggested TRX: 0).
Allocating DL TBF: MS_CLASS=0/0
-[DL] algo A (suggested TRX: -1): failed to find a usable TRX (TFI
exhausted)
+[DL] algo A (suggested TRX: -1): failed to find a usable TRX (TFI
exhausted)
TBF(TFI=0 TLLI=0x DIR=DL STATE=RELEASING) free
TBF(TFI=0 TLLI=0x DIR=DL STATE=RELEASING) free
TBF(TFI=0 TLLI=0x DIR=DL STATE=RELEASING) free
@@ -931,7 +931,7 @@
TBF(TFI=6 TLLI=0x DIR=UL STATE=NULL) Setting Control TS 4
TBF(TFI=6 TLLI=0x DIR=UL STATE=NULL) Allocated: trx = 0, ul_slots =
10, dl_slots = 00
Allocating UL TBF: MS_CLASS=0/0
-[UL] algo A (suggested TRX: -1): failed to allocate a TS, no USF
available
+[UL] algo A (suggested TRX: -1): failed to allocate a TS, no USF
available
TBF(TFI=0 TLLI=0x DIR=UL STATE=NULL) free
TBF(TFI=0 TLLI=0x DIR=UL STATE=NULL) free
TBF(TFI=0 TLLI=0x DIR=UL STATE=NULL) free
@@ -189959,7 +189959,7 @@
TBF(TFI=6 TLLI=0x DIR=DL STATE=NULL) Setting Control TS 7
TBF(TFI=6 TLLI=0x DIR=DL STATE=NULL) Allocated: trx = 0, ul_slots =
80, dl_slots = 80
Allocating UL TBF: MS_CLASS=1/0
-[UL] algo A (suggested TRX: -1): failed to allocate a TS, no USF
available
+[UL] algo A (suggested TRX: -1): failed to allocate a TS, no USF
available
Allocating UL TBF: MS_CLASS=10/0
TBF(TFI=0 TLLI=0x DIR=UL STATE=NULL) Setting Control TS 5
TBF(TFI=0 TLLI=0x DIR=UL STATE=NULL) Allocated: trx = 0, ul_slots =
20, dl_slots = 00
@@ -190961,7 +190961,7 @@
TBF(TFI=4 TLLI=0x DIR=DL STATE=NULL) Allocated: trx = 0, ul_slots =
08, dl_slots = 08
No TFI available (suggested TRX: 0).
Allocating UL TBF: MS_CLASS=36/0
-[UL] algo A (suggested TRX: -1): failed to allocate a TS, no USF
available
+[UL] algo A (suggested TRX: -1): failed to allocat
Change in osmo-sgsn[master]: process_ms_ctx_status: refactor to avoid code duplication
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/20843 ) Change subject: process_ms_ctx_status: refactor to avoid code duplication .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/20843 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I1d1a1284c1563b3a5598e79d8ffd544288de4d62 Gerrit-Change-Number: 20843 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 23 Oct 2020 15:11:15 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-sgsn[master]: process_ms_ctx_status: refactor to avoid code duplication
laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-sgsn/+/20843 )
Change subject: process_ms_ctx_status: refactor to avoid code duplication
..
process_ms_ctx_status: refactor to avoid code duplication
Change-Id: I1d1a1284c1563b3a5598e79d8ffd544288de4d62
---
M src/sgsn/gprs_gmm.c
1 file changed, 10 insertions(+), 15 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/src/sgsn/gprs_gmm.c b/src/sgsn/gprs_gmm.c
index bf72cd6..0ad6003 100644
--- a/src/sgsn/gprs_gmm.c
+++ b/src/sgsn/gprs_gmm.c
@@ -1524,21 +1524,16 @@
* being in state PDP-INACTIVE. */
llist_for_each_entry_safe(pdp, pdp2, &mmctx->pdp_list, list) {
- if (pdp->nsapi < 8) {
- if (!(pdp_status[0] & (1 << pdp->nsapi))) {
- LOGMMCTXP(LOGL_NOTICE, mmctx, "Dropping PDP
context for NSAPI=%u "
- "due to PDP CTX STATUS IE=
0x%02x%02x\n",
- pdp->nsapi, pdp_status[1],
pdp_status[0]);
- sgsn_delete_pdp_ctx(pdp);
- }
- } else {
- if (!(pdp_status[1] & (1 << (pdp->nsapi - 8 {
- LOGMMCTXP(LOGL_NOTICE, mmctx, "Dropping PDP
context for NSAPI=%u "
- "due to PDP CTX STATUS IE=
0x%02x%02x\n",
- pdp->nsapi, pdp_status[1],
pdp_status[0]);
- sgsn_delete_pdp_ctx(pdp);
- }
- }
+ bool inactive = (pdp->nsapi < 8) ?
+ !(pdp_status[0] & (1 << pdp->nsapi)) :
+ !(pdp_status[1] & (1 << (pdp->nsapi -
8)));
+ if (!inactive)
+ continue;
+
+ LOGMMCTXP(LOGL_NOTICE, mmctx, "Dropping PDP context for
NSAPI=%u "
+ "due to PDP CTX STATUS IE=0x%02x%02x\n",
+ pdp->nsapi, pdp_status[1], pdp_status[0]);
+ sgsn_delete_pdp_ctx(pdp);
}
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/20843
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I1d1a1284c1563b3a5598e79d8ffd544288de4d62
Gerrit-Change-Number: 20843
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-MessageType: merged
Change in osmo-sgsn[master]: process_ms_ctx_status: Fix crash deleting PDP Ctx if GTP side was alr...
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/20844 ) Change subject: process_ms_ctx_status: Fix crash deleting PDP Ctx if GTP side was already released .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/20844 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ie618874545172ec98355174a2ee041fc4a8bec16 Gerrit-Change-Number: 20844 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 23 Oct 2020 15:11:12 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-sgsn[master]: process_ms_ctx_status: refactor to avoid code duplication
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/20843 ) Change subject: process_ms_ctx_status: refactor to avoid code duplication .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/20843 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I1d1a1284c1563b3a5598e79d8ffd544288de4d62 Gerrit-Change-Number: 20843 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 23 Oct 2020 15:11:02 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-sgsn[master]: process_ms_ctx_status: Fix crash deleting PDP Ctx if GTP side was alr...
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/20844 ) Change subject: process_ms_ctx_status: Fix crash deleting PDP Ctx if GTP side was already released .. process_ms_ctx_status: Fix crash deleting PDP Ctx if GTP side was already released sgsn_delete_pdp_ctx() should never be called without checking if the GTP side is available, since it may happen that it has already been released by the time the mmctx tells us the pdp ctx is gone on the MS side. Fixes: OS#4817 Change-Id: Ie618874545172ec98355174a2ee041fc4a8bec16 --- M src/sgsn/gprs_gmm.c 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/sgsn/gprs_gmm.c b/src/sgsn/gprs_gmm.c index 0ad6003..3f7c8ab 100644 --- a/src/sgsn/gprs_gmm.c +++ b/src/sgsn/gprs_gmm.c @@ -1533,7 +1533,10 @@ LOGMMCTXP(LOGL_NOTICE, mmctx, "Dropping PDP context for NSAPI=%u " "due to PDP CTX STATUS IE=0x%02x%02x\n", pdp->nsapi, pdp_status[1], pdp_status[0]); - sgsn_delete_pdp_ctx(pdp); + if (pdp->ggsn) + sgsn_delete_pdp_ctx(pdp); + else /* GTP side already detached, freeing */ + sgsn_pdp_ctx_free(pdp); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/20844 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ie618874545172ec98355174a2ee041fc4a8bec16 Gerrit-Change-Number: 20844 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged
Change in osmo-sgsn[master]: sgsn_delete_pdp_ctx: Add documentation and assert assumptions
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/20842 ) Change subject: sgsn_delete_pdp_ctx: Add documentation and assert assumptions .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/20842 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I4248e2e9846fec5ae2c8557384da2deb86668c50 Gerrit-Change-Number: 20842 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 23 Oct 2020 15:10:03 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-sgsn[master]: sgsn_delete_pdp_ctx: Add documentation and assert assumptions
laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-sgsn/+/20842 )
Change subject: sgsn_delete_pdp_ctx: Add documentation and assert assumptions
..
sgsn_delete_pdp_ctx: Add documentation and assert assumptions
This function is only expected to be called if the GTP side of the PDP
ctx is still alive, since it will tear down the GTP side and then finish
the pending MS side if needed.
The asserts are added to ease debugging since it was noted that a few
callers were using this function without properly checking the status of
the pdp ctx.
Related: OS#4817
Change-Id: I4248e2e9846fec5ae2c8557384da2deb86668c50
---
M src/sgsn/sgsn_libgtp.c
1 file changed, 6 insertions(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/src/sgsn/sgsn_libgtp.c b/src/sgsn/sgsn_libgtp.c
index 8081492..367570d 100644
--- a/src/sgsn/sgsn_libgtp.c
+++ b/src/sgsn/sgsn_libgtp.c
@@ -312,11 +312,16 @@
return pctx;
}
-/* SGSN wants to delete a PDP context */
+/* SGSN wants to delete a PDP context, send first DeleteCtxReq on the GTP side,
+ then upon DeleteCtx ACK it will send DeactPdpAcc to the MS if still
+ connected. */
int sgsn_delete_pdp_ctx(struct sgsn_pdp_ctx *pctx)
{
LOGPDPCTXP(LOGL_INFO, pctx, "Delete PDP Context\n");
+ OSMO_ASSERT(pctx->ggsn);
+ OSMO_ASSERT(pctx->lib);
+
/* FIXME: decide if we need teardown or not ! */
return gtp_delete_context_req2(pctx->ggsn->gsn, pctx->lib, pctx, 1);
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/20842
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I4248e2e9846fec5ae2c8557384da2deb86668c50
Gerrit-Change-Number: 20842
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-MessageType: merged
Change in libosmocore[master]: vty/command: add CMD_ATTR_HIDDEN to CMD_ATTR_PUBLIC_MASK
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/20848 ) Change subject: vty/command: add CMD_ATTR_HIDDEN to CMD_ATTR_PUBLIC_MASK .. vty/command: add CMD_ATTR_HIDDEN to CMD_ATTR_PUBLIC_MASK Otherwise in the expert mode, hidden commands do not get the associated attribute printed to the XML VTY reference. Change-Id: I8ded973031beb6d8c7ad55f06641c9651b1d9e71 Related: OS#4910 --- M src/vty/command.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/vty/command.c b/src/vty/command.c index b83522f..7ea1971 100644 --- a/src/vty/command.c +++ b/src/vty/command.c @@ -633,7 +633,7 @@ /* Public attributes (to be printed in the VTY / XML reference) */ #define CMD_ATTR_PUBLIC_MASK \ - (CMD_ATTR_IMMEDIATE | CMD_ATTR_NODE_EXIT) + (CMD_ATTR_HIDDEN | CMD_ATTR_IMMEDIATE | CMD_ATTR_NODE_EXIT) /* Get a flag character for a global VTY command attribute */ static char cmd_attr_get_flag(unsigned int attr) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20848 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8ded973031beb6d8c7ad55f06641c9651b1d9e71 Gerrit-Change-Number: 20848 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged
Change in libosmocore[master]: vty/command: add CMD_ATTR_HIDDEN to CMD_ATTR_PUBLIC_MASK
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/20848 ) Change subject: vty/command: add CMD_ATTR_HIDDEN to CMD_ATTR_PUBLIC_MASK .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20848 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8ded973031beb6d8c7ad55f06641c9651b1d9e71 Gerrit-Change-Number: 20848 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 23 Oct 2020 15:08:47 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: vty/command: introduce vty_dump_xml_ref_mode()
laforge has submitted this change. (
https://gerrit.osmocom.org/c/libosmocore/+/20847 )
Change subject: vty/command: introduce vty_dump_xml_ref_mode()
..
vty/command: introduce vty_dump_xml_ref_mode()
This change introduces an enumerated type 'vty_ref_gen_mode' that
(as the name suggests) defines the VTY reference generation mode:
- DEFAULT - all commands except deprecated and hidden,
- EXPERT - all commands including hidden, excluding deprecated;
and a new function vty_dump_xml_ref_mode(), that allows to specify
that mode. The old vty_dump_xml_ref() is now deprecated.
Change-Id: Ie2022a7f9e167e5ceacf15350c037dd43768ff40
Related: SYS#4910
---
M include/osmocom/vty/command.h
M src/vty/command.c
2 files changed, 53 insertions(+), 2 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
diff --git a/include/osmocom/vty/command.h b/include/osmocom/vty/command.h
index 92701fc..eb7ee35 100644
--- a/include/osmocom/vty/command.h
+++ b/include/osmocom/vty/command.h
@@ -29,6 +29,7 @@
#include "vector.h"
#include
+#include
/*! \defgroup command VTY Command
* @{
@@ -460,6 +461,18 @@
extern void *tall_vty_cmd_ctx;
-int vty_dump_xml_ref(FILE *stream);
+/*! VTY reference generation mode. */
+enum vty_ref_gen_mode {
+ /*! Default mode: all commands except deprecated and hidden. */
+ VTY_REF_GEN_MODE_DEFAULT = 0,
+ /*! Expert mode: all commands including hidden, excluding deprecated. */
+ VTY_REF_GEN_MODE_EXPERT,
+};
+
+extern const struct value_string vty_ref_gen_mode_names[];
+extern const struct value_string vty_ref_gen_mode_desc[];
+
+int vty_dump_xml_ref_mode(FILE *stream, enum vty_ref_gen_mode mode);
+int vty_dump_xml_ref(FILE *stream) OSMO_DEPRECATED("Use
vty_dump_xml_ref_mode() instead");
/*! @} */
diff --git a/src/vty/command.c b/src/vty/command.c
index 53ebcd8..b83522f 100644
--- a/src/vty/command.c
+++ b/src/vty/command.c
@@ -876,11 +876,49 @@
return rc;
}
+const struct value_string vty_ref_gen_mode_names[] = {
+ { VTY_REF_GEN_MODE_DEFAULT, "default" },
+ { VTY_REF_GEN_MODE_EXPERT, "expert" },
+ { 0, NULL }
+};
+
+const struct value_string vty_ref_gen_mode_desc[] = {
+ { VTY_REF_GEN_MODE_DEFAULT, "all commands except deprecated and
hidden" },
+ { VTY_REF_GEN_MODE_EXPERT, "all commands including hidden,
excluding deprecated" },
+ { 0, NULL }
+};
+
/*! Print the XML reference of all VTY nodes to the given stream.
+ * \param[out] stream Output stream to print the XML reference to.
+ * \param[in] modeThe XML reference generation mode.
+ * \returns always 0 for now, no errors possible.
+ */
+int vty_dump_xml_ref_mode(FILE *stream, enum vty_ref_gen_mode mode)
+{
+ switch (mode) {
+ case VTY_REF_GEN_MODE_EXPERT:
+ host.expert_mode = true;
+ break;
+ case VTY_REF_GEN_MODE_DEFAULT:
+ default:
+ host.expert_mode = false;
+ break;
+ }
+
+ return vty_dump_nodes(print_func_stream, stream, "\n");
+}
+
+/*! Print the XML reference of all VTY nodes to the given stream.
+ * \param[out] stream Output stream to print the XML reference to.
+ * \returns always 0 for now, no errors possible.
+ *
+ * NOTE: this function is deprecated because it does not allow to
+ * specify the XML reference generation mode (default mode
+ * is hard-coded). Use vty_dump_xml_ref_mode() instead.
*/
int vty_dump_xml_ref(FILE *stream)
{
- return vty_dump_nodes(print_func_stream, stream, "\n");
+ return vty_dump_xml_ref_mode(stream, VTY_REF_GEN_MODE_DEFAULT);
}
/* Check if a command with given string exists at given node */
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20847
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ie2022a7f9e167e5ceacf15350c037dd43768ff40
Gerrit-Change-Number: 20847
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in libosmocore[master]: select: Migrate over to poll()
laforge has submitted this change. (
https://gerrit.osmocom.org/c/libosmocore/+/20732 )
Change subject: select: Migrate over to poll()
..
select: Migrate over to poll()
select is an ancient interface with weird restrictions, such as
the fact that it cannot be used for file descriptor values > 1024.
This may have been sufficient 40 years ago, but certainly is not in
2020. I wanted to migrate to epoll(), but unfortunately it doesn't
work well with the fact that existing programs simply set osmo_fd.flags
without making any API calls at the time they change those flags.
So let's do the migration to poll() as a first step, and then consider
epoll() as a second step further down the road, after introducing new
APIs and porting applications over.
The poll() code introduced in this patch is not extremely efficient,
as it needs to do extensive linked list iterations after poll() returns
in order to find the osmo_fd from the fd. Optimization is possible,
but let's postpone that to a follow-up patch.
At compile time, a new --enable-force-io-select argument can be given
to configure, forcing the use of the old select() backend instead of the
new poll() based backend.
Change-Id: I9e80da68a144b36926066610d0d3df06abe09bca
---
M configure.ac
M include/osmocom/core/timer.h
M src/select.c
M src/timer.c
4 files changed, 164 insertions(+), 3 deletions(-)
Approvals:
laforge: Looks good to me, approved
fixeria: Looks good to me, but someone else must approve
pespin: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/configure.ac b/configure.ac
index e867197..7de495b 100644
--- a/configure.ac
+++ b/configure.ac
@@ -62,7 +62,7 @@
dnl checks for header files
AC_HEADER_STDC
-AC_CHECK_HEADERS(execinfo.h sys/select.h sys/socket.h sys/signalfd.h
sys/timerfd.h syslog.h ctype.h netinet/tcp.h netinet/in.h)
+AC_CHECK_HEADERS(execinfo.h poll.h sys/select.h sys/socket.h sys/signalfd.h
sys/timerfd.h syslog.h ctype.h netinet/tcp.h netinet/in.h)
# for src/conv.c
AC_FUNC_ALLOCA
AC_SEARCH_LIBS([dlopen], [dl dld], [LIBRARY_DLOPEN="$LIBS";LIBS=""])
@@ -252,6 +252,16 @@
AC_DEFINE([OSMO_FD_CHECK],[1],[Instrument the osmo_fd_register])
fi
+AC_ARG_ENABLE([force_io_select],
+ [AS_HELP_STRING(
+ [--enable-force-io-select],
+ [Build with old select I/O instead of poll]
+ )],
+ [force_io_select=$enableval], [force_io_select="no"])
+AS_IF([test "x$force_io_select" = "xyes"], [
+ AC_DEFINE([FORCE_IO_SELECT], [1], [Force the use of select() instaed of
poll()])
+])
+
AC_ARG_ENABLE(msgfile,
[AS_HELP_STRING(
[--disable-msgfile],
diff --git a/include/osmocom/core/timer.h b/include/osmocom/core/timer.h
index 1979766..6ffc3b1 100644
--- a/include/osmocom/core/timer.h
+++ b/include/osmocom/core/timer.h
@@ -84,6 +84,7 @@
* internal timer list management
*/
struct timeval *osmo_timers_nearest(void);
+int osmo_timers_nearest_ms(void);
void osmo_timers_prepare(void);
int osmo_timers_update(void);
int osmo_timers_check(void);
diff --git a/src/select.c b/src/select.c
index 1bb354b..71ee7f6 100644
--- a/src/select.c
+++ b/src/select.c
@@ -4,7 +4,7 @@
* userspace logging daemon for the iptables ULOG target
* of the linux 2.4 netfilter subsystem. */
/*
- * (C) 2000-2009 by Harald Welte
+ * (C) 2000-2020 by Harald Welte
* All Rights Reserverd.
*
* SPDX-License-Identifier: GPL-2.0+
@@ -41,8 +41,9 @@
#include "../config.h"
-#ifdef HAVE_SYS_SELECT_H
+#if defined(HAVE_SYS_SELECT_H) && defined(HAVE_POLL_H)
#include
+#include
/*! \addtogroup select
* @{
@@ -56,6 +57,18 @@
static __thread struct llist_head osmo_fds; /* TLS cannot use LLIST_HEAD() */
static __thread int unregistered_count;
+#ifndef FORCE_IO_SELECT
+struct poll_state {
+ /* array of pollfd */
+ struct pollfd *poll;
+ /* number of entries in pollfd allocated */
+ unsigned int poll_size;
+ /* number of osmo_fd registered */
+ unsigned int num_registered;
+};
+static __thread struct poll_state g_poll;
+#endif /* FORCE_IO_SELECT */
+
/*! Set up an osmo-fd. Will not register it.
* \param[inout] ofd Osmo FD to be set-up
* \param[in] fd OS-level file descriptor number
@@ -136,6 +149,19 @@
return 0;
}
#endif
+#ifndef FORCE_IO_SELECT
+ if (g_poll.num_registered + 1 > g_poll.poll_size) {
+ struct pollfd *p;
+ unsigned int new_size = g_poll.poll_size ? g_poll.poll_size * 2
: 1024;
+ p = talloc_realloc(OTC_GLOBAL, g_poll.poll, struct pollfd,
new_size);
+ if (!p)
+ return -ENOMEM;
+ memset(p + g_poll.poll_size, 0, new_size - g_poll.poll_size);
+ g_poll.poll = p;
+ g_poll.poll_size = new_size;
+ }
+ g_poll.num_registered++;
+#endif /* FORCE_IO_SELECT */
llist_add_t
Change in libosmocore[master]: vty/command: make some 'struct cmd_element' pointers const
laforge has submitted this change. (
https://gerrit.osmocom.org/c/libosmocore/+/20846 )
Change subject: vty/command: make some 'struct cmd_element' pointers const
..
vty/command: make some 'struct cmd_element' pointers const
Change-Id: I4a8b3bada44538a5e5711bbc4dccf8b2cf3e2e08
---
M src/vty/command.c
1 file changed, 9 insertions(+), 13 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
diff --git a/src/vty/command.c b/src/vty/command.c
index 0edfce5..53ebcd8 100644
--- a/src/vty/command.c
+++ b/src/vty/command.c
@@ -674,7 +674,8 @@
/*
* Write one cmd_element as XML via a print_func_t.
*/
-static int vty_dump_element(struct cmd_element *cmd, print_func_t print_func,
void *data, const char *newline)
+static int vty_dump_element(const struct cmd_element *cmd, print_func_t
print_func,
+ void *data, const char *newline)
{
char *xml_string = xml_escape(cmd->string);
unsigned int i;
@@ -768,7 +769,7 @@
return 0;
}
-static bool vty_command_is_common(struct cmd_element *cmd);
+static bool vty_command_is_common(const struct cmd_element *cmd);
/*
* Dump all nodes and commands associated with a given node as XML via a
print_func_t.
@@ -786,16 +787,14 @@
print_func(data, "These commands are available on all
VTY nodes. They are listed"
" here only once, to unclutter the VTY
reference.%s", newline);
for (i = 0; i < vector_active(cmdvec); ++i) {
- struct cmd_node *cnode;
- cnode = vector_slot(cmdvec, i);
+ const struct cmd_node *cnode = vector_slot(cmdvec, i);
if (!cnode)
continue;
if (cnode->node != CONFIG_NODE)
continue;
for (j = 0; j < vector_active(cnode->cmd_vector); ++j) {
- struct cmd_element *elem;
- elem = vector_slot(cnode->cmd_vector, j);
+ const struct cmd_element *elem =
vector_slot(cnode->cmd_vector, j);
if (!vty_command_is_common(elem))
continue;
if (elem->attr & CMD_ATTR_DEPRECATED)
@@ -808,8 +807,7 @@
print_func(data, " %s", newline);
for (i = 0; i < vector_active(cmdvec); ++i) {
- struct cmd_node *cnode;
- cnode = vector_slot(cmdvec, i);
+ const struct cmd_node *cnode = vector_slot(cmdvec, i);
if (!cnode)
continue;
if (vector_active(cnode->cmd_vector) < 1)
@@ -820,8 +818,7 @@
* 'name', the second becomes 'name_2', then 'name_3', ... */
same_name_count = 1;
for (j = 0; j < i; ++j) {
- struct cmd_node *cnode2;
- cnode2 = vector_slot(cmdvec, j);
+ const struct cmd_node *cnode2 = vector_slot(cmdvec, j);
if (!cnode2)
continue;
if (strcmp(cnode->name, cnode2->name) == 0)
@@ -835,8 +832,7 @@
print_func(data, "%s%s", cnode->name, newline);
for (j = 0; j < vector_active(cnode->cmd_vector); ++j) {
- struct cmd_element *elem;
- elem = vector_slot(cnode->cmd_vector, j);
+ const struct cmd_element *elem =
vector_slot(cnode->cmd_vector, j);
if (vty_command_is_common(elem))
continue;
if (elem->attr & CMD_ATTR_DEPRECATED)
@@ -4195,7 +4191,7 @@
/*! Return true if a node is installed by install_basic_node_commands(), so
* that we can avoid repeating them for each and every node during 'show
* running-config' */
-static bool vty_command_is_common(struct cmd_element *cmd)
+static bool vty_command_is_common(const struct cmd_element *cmd)
{
if (cmd == &config_help_cmd
|| cmd == &show_vty_attr_all_cmd
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20846
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I4a8b3bada44538a5e5711bbc4dccf8b2cf3e2e08
Gerrit-Change-Number: 20846
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in libosmocore[master]: select: Migrate over to poll()
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/20732 ) Change subject: select: Migrate over to poll() .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20732 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9e80da68a144b36926066610d0d3df06abe09bca Gerrit-Change-Number: 20732 Gerrit-PatchSet: 6 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 23 Oct 2020 15:09:00 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: vty/command: introduce vty_dump_xml_ref_mode()
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/20847 ) Change subject: vty/command: introduce vty_dump_xml_ref_mode() .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20847 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie2022a7f9e167e5ceacf15350c037dd43768ff40 Gerrit-Change-Number: 20847 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 23 Oct 2020 15:08:35 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in pysim[master]: pySim-read.py: Enable parsing of EF.ePDGSelection in USIM
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/20817 ) Change subject: pySim-read.py: Enable parsing of EF.ePDGSelection in USIM .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/20817 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I98916e6f5c9791aff63c18a3b16bdfb8ae9b2d36 Gerrit-Change-Number: 20817 Gerrit-PatchSet: 3 Gerrit-Owner: herlesupreeth Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 23 Oct 2020 15:07:56 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in pysim[master]: utils.py: Add helper method to encode ePDGSelection info TLV
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/20818 ) Change subject: utils.py: Add helper method to encode ePDGSelection info TLV .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/20818 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia7292d33783c770a3bb91b081c671af36bbb907f Gerrit-Change-Number: 20818 Gerrit-PatchSet: 1 Gerrit-Owner: herlesupreeth Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 23 Oct 2020 15:07:58 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in pysim[master]: utils.py: Add helper method to parse ePDG Selection info TLV
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/20816 ) Change subject: utils.py: Add helper method to parse ePDG Selection info TLV .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/20816 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0f9f38961a589e3f9a53d2288a3dc6fa71a4b1b0 Gerrit-Change-Number: 20816 Gerrit-PatchSet: 2 Gerrit-Owner: herlesupreeth Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 23 Oct 2020 15:07:53 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in pysim[master]: pySim-read.py: Enable parsing of EF.ePDGSelection in USIM
laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/20817
)
Change subject: pySim-read.py: Enable parsing of EF.ePDGSelection in USIM
..
pySim-read.py: Enable parsing of EF.ePDGSelection in USIM
As per TS 31.102, this EF can found under ADF.USIM at File Id 6ff4.
Also, if service n°106 and service n°107 are available, this file shall be
present.
Change-Id: I98916e6f5c9791aff63c18a3b16bdfb8ae9b2d36
---
M pySim-read.py
M pySim/cards.py
M pysim-testdata/sysmoISIM-SJA2.ok
3 files changed, 25 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
dexter: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
diff --git a/pySim-read.py b/pySim-read.py
index 6608556..2be34bd 100755
--- a/pySim-read.py
+++ b/pySim-read.py
@@ -36,6 +36,7 @@
from pySim.cards import card_detect, Card
from pySim.utils import h2b, swap_nibbles, rpad, dec_imsi, dec_iccid,
dec_msisdn
from pySim.utils import format_xplmn_w_act, dec_spn, dec_st, init_reader,
dec_epdgid
+from pySim.utils import h2s, format_ePDGSelection
def parse_options():
@@ -282,6 +283,17 @@
except Exception as e:
print("ePDGId: Can't read file -- " + str(e))
+ #EF.ePDGSelection - ePDG Selection Information
+ try:
+ if card.file_exists(EF_USIM_ADF_map['ePDGSelection']):
+ (res, sw) = card.read_ePDGSelection()
+ if sw == '9000':
+ print("ePDGSelection:\n%s" % (res,))
+ else:
+ print("ePDGSelection: Can't read,
response code = %s" % (sw,))
+ except Exception as e:
+ print("ePDGSelection: Can't read file -- " + str(e))
+
# Check whether we have th AID of ISIM, if so select it by its AID
# EF.IST - File Id in ADF ISIM : 6f07
if '9000' == card.select_adf_by_aid(adf="isim"):
diff --git a/pySim/cards.py b/pySim/cards.py
index 1d5f5c6..6243d4a 100644
--- a/pySim/cards.py
+++ b/pySim/cards.py
@@ -277,6 +277,13 @@
EF_USIM_ADF_map['ePDGId'],
epdgid_tlv)
return sw
+ def read_ePDGSelection(self):
+ (res, sw) =
self._scc.read_binary(EF_USIM_ADF_map['ePDGSelection'])
+ if sw == '9000':
+ return (format_ePDGSelection(res), sw)
+ else:
+ return (None, sw)
+
def read_ust(self):
(res, sw) = self._scc.read_binary(EF_USIM_ADF_map['UST'])
if sw == '9000':
diff --git a/pysim-testdata/sysmoISIM-SJA2.ok b/pysim-testdata/sysmoISIM-SJA2.ok
index 947cff6..b6836e7 100644
--- a/pysim-testdata/sysmoISIM-SJA2.ok
+++ b/pysim-testdata/sysmoISIM-SJA2.ok
@@ -165,6 +165,12 @@
ePDGId:
Not available
+ePDGSelection:
+ # unused
+ # unused
+ # unused
+ # unused
+
ISIM Service Table: 190200
Service 1 - P-CSCF address
Service 4 - GBA-based Local Key Establishment Mechanism
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/20817
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I98916e6f5c9791aff63c18a3b16bdfb8ae9b2d36
Gerrit-Change-Number: 20817
Gerrit-PatchSet: 3
Gerrit-Owner: herlesupreeth
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter
Gerrit-Reviewer: laforge
Gerrit-MessageType: merged
Change in pysim[master]: utils.py: Add helper method to encode ePDGSelection info TLV
laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/20818
)
Change subject: utils.py: Add helper method to encode ePDGSelection info TLV
..
utils.py: Add helper method to encode ePDGSelection info TLV
Encodes ePDGSelection info TLV so it can be stored at EF.ePDGSelection or
EF.ePDGSelectionEm.
See 3GPP TS 31.102 version 15.2.0 Release 15, section 4.2.104 and 4.2.106.
Take original hex string of EF.ePDGSelection or EF.ePDGSelectionEm, MCC,
MNC, ePDG priority for PLMN and ePDG FQDN Format to use for PLMNas input
and outputs the encoded hex string.
Change-Id: Ia7292d33783c770a3bb91b081c671af36bbb907f
---
M pySim/utils.py
1 file changed, 16 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
dexter: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
diff --git a/pySim/utils.py b/pySim/utils.py
index a3e4cb1..ebc2a95 100644
--- a/pySim/utils.py
+++ b/pySim/utils.py
@@ -610,6 +610,22 @@
return sl
+def enc_ePDGSelection(hexstr, mcc, mnc, epdg_priority='0001',
epdg_fqdn_format='00'):
+ """
+ Encode ePDGSelection so it can be stored at EF.ePDGSelection or
EF.ePDGSelectionEm.
+ See 3GPP TS 31.102 version 15.2.0 Release 15, section 4.2.104 and
4.2.106.
+
+ Default values:
+ - epdg_priority: '0001' - 1st Priority
+ - epdg_fqdn_format: '00' - Operator Identifier FQDN
+ """
+
+ plmn1 = enc_plmn(mcc, mnc) + epdg_priority + epdg_fqdn_format
+ # TODO: Handle encoding of Length field for length more than 127 Bytes
+ content = '80' + ('%02x' % (len(plmn1)//2)) + plmn1
+ content = rpad(content, len(hexstr))
+ return content
+
def dec_ePDGSelection(sixhexbytes):
"""
Decode ePDGSelection to get EF.ePDGSelection or EF.ePDGSelectionEm.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/20818
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ia7292d33783c770a3bb91b081c671af36bbb907f
Gerrit-Change-Number: 20818
Gerrit-PatchSet: 1
Gerrit-Owner: herlesupreeth
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter
Gerrit-Reviewer: laforge
Gerrit-MessageType: merged
Change in pysim[master]: utils.py: Add helper method to parse ePDG Selection info TLV
laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/20816
)
Change subject: utils.py: Add helper method to parse ePDG Selection info TLV
..
utils.py: Add helper method to parse ePDG Selection info TLV
ePDG selection information TLV data object is made of following elements:
ePDG Selection Information Tag '80' (1 Byte)
Length 5n Note
PLMN 1 (3 Bytes)
ePDG Priority (2 Bytes)
ePDG FQDN format '00' or '01' (1 Byte)
...
PLMN n
...
Note: The length is coded according to ISO/IEC 8825-1 [35]
Note 2: Inconsistency in spec: 3GPP TS 31.102 version 15.2.0 Release 15, 4.2.104
As per spec, Length field value is 5n, where n is number of PLMNs
But, each PLMN entry is made of PLMN (3 Bytes) + ePDG Priority (2 Bytes) + ePDG
FQDN format (1 Byte)
Totalling to 6 Bytes, maybe Length should be 6n and not 5n
Change-Id: I0f9f38961a589e3f9a53d2288a3dc6fa71a4b1b0
---
M pySim/utils.py
1 file changed, 54 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
dexter: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
diff --git a/pySim/utils.py b/pySim/utils.py
index f7d099b..a3e4cb1 100644
--- a/pySim/utils.py
+++ b/pySim/utils.py
@@ -609,3 +609,57 @@
sl = SerialSimLink(device=opts.device, baudrate=opts.baudrate)
return sl
+
+def dec_ePDGSelection(sixhexbytes):
+ """
+ Decode ePDGSelection to get EF.ePDGSelection or EF.ePDGSelectionEm.
+ See 3GPP TS 31.102 version 15.2.0 Release 15, section 4.2.104 and
4.2.106.
+ """
+
+ res = {'mcc': 0, 'mnc': 0, 'epdg_priority': 0, 'epdg_fqdn_format': ''}
+ plmn_chars = 6
+ epdg_priority_chars = 4
+ epdg_fqdn_format_chars = 2
+ # first three bytes (six ascii hex chars)
+ plmn_str = sixhexbytes[:plmn_chars]
+ # two bytes after first three bytes
+ epdg_priority_str = sixhexbytes[plmn_chars:plmn_chars +
epdg_priority_chars]
+ # one byte after first five bytes
+ epdg_fqdn_format_str = sixhexbytes[plmn_chars +
epdg_priority_chars:plmn_chars + epdg_priority_chars + epdg_fqdn_format_chars]
+ res['mcc'] = dec_mcc_from_plmn(plmn_str)
+ res['mnc'] = dec_mnc_from_plmn(plmn_str)
+ res['epdg_priority'] = epdg_priority_str
+ res['epdg_fqdn_format'] = epdg_fqdn_format_str == '00' and 'Operator
Identifier FQDN' or 'Location based FQDN'
+ return res
+
+def format_ePDGSelection(hexstr):
+ ePDGSelection_info_tag_chars = 2
+ ePDGSelection_info_tag_str = hexstr[:2]
+ # Minimum length
+ len_chars = 2
+ # TODO: Need to determine length properly - definite length support only
+ # Inconsistency in spec: 3GPP TS 31.102 version 15.2.0 Release 15,
4.2.104
+ # As per spec, length is 5n, n - number of PLMNs
+ # But, each PLMN entry is made of PLMN (3 Bytes) + ePDG Priority (2
Bytes) + ePDG FQDN format (1 Byte)
+ # Totalling to 6 Bytes, maybe length should be 6n
+ len_str =
hexstr[ePDGSelection_info_tag_chars:ePDGSelection_info_tag_chars+len_chars]
+ if len_str[0] == '8':
+ # The bits 7 to 1 denotes the number of length octets if length
> 127
+ if int(len_str[1]) > 0:
+ # Update number of length octets
+ len_chars = len_chars * int(len_str[1])
+ len_str = hexstr[ePDGSelection_info_tag_chars:len_chars]
+
+ content_str = hexstr[ePDGSelection_info_tag_chars+len_chars:]
+ # Right pad to prevent index out of range - multiple of 6 bytes
+ content_str = rpad(content_str, len(content_str) + (12 -
(len(content_str) % 12)))
+ s = ""
+ for rec_data in hexstr_to_Nbytearr(content_str, 6):
+ rec_info = dec_ePDGSelection(rec_data)
+ if rec_info['mcc'] == 0xFFF and rec_info['mnc'] == 0xFFF:
+ rec_str = "unused"
+ else:
+ rec_str = "MCC: %03d MNC: %03d ePDG Priority: %s ePDG
FQDN format: %s" % \
+ (rec_info['mcc'], rec_info['mnc'],
rec_info['epdg_priority'], rec_info['epdg_fqdn_format'])
+ s += "\t%s # %s\n" % (rec_data, rec_str)
+ return s
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/20816
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I0f9f38961a589e3f9a53d2288a3dc6fa71a4b1b0
Gerrit-Change-Number: 20816
Gerrit-PatchSet: 2
Gerrit-Owner: herlesupreeth
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter
Gerrit-Reviewer: laforge
Gerrit-MessageType: merged
Change in libosmocore[master]: vty/command: make some 'struct cmd_element' pointers const
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/20846 ) Change subject: vty/command: make some 'struct cmd_element' pointers const .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20846 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4a8b3bada44538a5e5711bbc4dccf8b2cf3e2e08 Gerrit-Change-Number: 20846 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 23 Oct 2020 15:08:20 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: sched_lchan_tchf: count measurements for FACCH/F only once
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/20841 ) Change subject: sched_lchan_tchf: count measurements for FACCH/F only once .. Patch Set 1: > Patch Set 1: > > This approach looks wrong to me, see my comments to > https://gerrit.osmocom.org/c/osmo-bts/+/20840. Even if it makes the test > cases pass, let's better discuss everything first. In this case I think the approach is correct. For #20840 I am also not sure either. For this my Idea is that the FACCH replaces one TCH frame, with the data indication also the measurement is passed up. The BFI that is passed up at the same time should not contain a copy of the current measurement value. It should just not count. The problem is that the excess amount of measurement values generates incorrect measurement results, especially for SUB frames. (TC_meas_res_speech_tchf currently passes but that I think is because the measurements contain all the same results because the fake RSSI is constant throught the test, but in the log you will see that it looks ugly, measurement.c complains.) -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20841 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ie3f2e620ba2a2ab2fecdbae627ef01c6128fce0b Gerrit-Change-Number: 20841 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 23 Oct 2020 14:31:53 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in pysim[master]: utils.py: Add helper method to parse ePDG Selection info TLV
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/20816 ) Change subject: utils.py: Add helper method to parse ePDG Selection info TLV .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/20816 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0f9f38961a589e3f9a53d2288a3dc6fa71a4b1b0 Gerrit-Change-Number: 20816 Gerrit-PatchSet: 2 Gerrit-Owner: herlesupreeth Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 23 Oct 2020 14:21:56 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in pysim[master]: utils.py: Add helper method to encode ePDGSelection info TLV
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/20818 ) Change subject: utils.py: Add helper method to encode ePDGSelection info TLV .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/20818 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia7292d33783c770a3bb91b081c671af36bbb907f Gerrit-Change-Number: 20818 Gerrit-PatchSet: 1 Gerrit-Owner: herlesupreeth Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 23 Oct 2020 14:21:05 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: vty/command: add CMD_ATTR_HIDDEN to CMD_ATTR_PUBLIC_MASK
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/20848 ) Change subject: vty/command: add CMD_ATTR_HIDDEN to CMD_ATTR_PUBLIC_MASK .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20848 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8ded973031beb6d8c7ad55f06641c9651b1d9e71 Gerrit-Change-Number: 20848 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 23 Oct 2020 14:21:42 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: vty/command: introduce vty_dump_xml_ref_mode()
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/20847 ) Change subject: vty/command: introduce vty_dump_xml_ref_mode() .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20847 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie2022a7f9e167e5ceacf15350c037dd43768ff40 Gerrit-Change-Number: 20847 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 23 Oct 2020 14:21:00 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
