Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_20.10/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_20.10/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_20.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 90s] [COMPILING apps/dfu/main.c] [ 90s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu.c] [ 90s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_desc.c] [ 90s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_driver.c] [ 90s] Memory region Used Size Region Size %age Used [ 90s] rom: 16580 B16 KB101.20% [ 90s] ram: 11672 B48 KB 23.75/usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 90s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 90s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: bin/qmod-dfu-flash.elf section `.text' will not fit in region `rom' [ 90s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 90s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 90s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 90s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: region `rom' overflowed by 196 bytes [ 90s] collect2: error: ld returned 1 exit status [ 90s] % [ 90s] make[2]: *** [Makefile:234: flash] Error 1 [ 90s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 90s] make[1]: *** [Makefile:13: fw-qmod-dfu] Error 2 [ 90s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 90s] dh_auto_build: error: make -j1 returned exit code 2 [ 90s] make: *** [debian/rules:16: build] Error 25 [ 90s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 90s] ### VM INTERACTION START ### [ 93s] [ 84.499921] sysrq: Power Off [ 93s] [ 84.506827] reboot: Power down [ 93s] ### VM INTERACTION END ### [ 93s] [ 93s] goat17 failed "build simtrace2_0.7.0.69.aadd.dsc" at Sun Nov 1 01:59:51 UTC 2020. [ 93s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_20.04/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_20.04/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_20.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 163s] [COMPILING libboard/qmod/source/wwan_perst.c] [ 163s] [COMPILING libboard/qmod/source/card_pres.c] [ 163s] [COMPILING libboard/qmod/source/wwan_led.c] [ 163s] [COMPILING libboard/qmod/source/i2c.c] [ 164s] [COMPILING libboard/qmod/source/board_qmod.c] [ 164s] [COMPILING apps/dfu/main.c] [ 164s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu.c] [ 164s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_desc.c] [ 164s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_driver.c] [ 164s] Memory region Used Size Region Size %age Used [ 164s] rom: 16588 B16 KB101.25% [ 164s] ram: 11672 B48 KB 23.75/usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: bin/qmod-dfu-flash.elf section `.text' will not fit in region `rom' [ 164s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: region `rom' overflowed by 204 bytes [ 164s] collect2: error: ld returned 1 exit status [ 164s] % [ 164s] make[2]: *** [Makefile:234: flash] Error 1 [ 164s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 164s] make[1]: *** [Makefile:13: fw-qmod-dfu] Error 2 [ 164s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 164s] dh_auto_build: error: make -j1 returned exit code 2 [ 164s] make: *** [debian/rules:16: build] Error 25 [ 164s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 164s] ### VM INTERACTION START ### [ 167s] [ 155.788262] sysrq: Power Off [ 167s] [ 155.795874] reboot: Power down [ 168s] ### VM INTERACTION END ### [ 168s] [ 168s] lamb01 failed "build simtrace2_0.7.0.69.aadd.dsc" at Sun Nov 1 01:43:41 UTC 2020. [ 168s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Change in osmo-bts[master]: main: register VTY commands before handle_options()
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/20954 ) Change subject: main: register VTY commands before handle_options() .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20954 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ic356a950da85de02c82e9882a5fbadaaa6929680 Gerrit-Change-Number: 20954 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sat, 31 Oct 2020 22:13:24 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-bts[master]: doc/manuals: generate XML VTY reference at build-time
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/20956 ) Change subject: doc/manuals: generate XML VTY reference at build-time .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20956 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Idba84164b90e3d183a20b5eb69cbfe15745e447c Gerrit-Change-Number: 20956 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Sat, 31 Oct 2020 22:13:31 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-bts[master]: doc/manuals: move osmobts-vty-reference.xml to vty/
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/21009 ) Change subject: doc/manuals: move osmobts-vty-reference.xml to vty/ .. doc/manuals: move osmobts-vty-reference.xml to vty/ This way we have everything VTY specific in a single directory. Change-Id: Iaba5c42b39fa764cd38c903486617c3d9f9cdebb Related: SYS#4937, OS#3036 --- M doc/manuals/Makefile.am M doc/manuals/vty/Makefile.vty-reference.inc R doc/manuals/vty/osmobts-vty-reference.xml 3 files changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/09/21009/1 diff --git a/doc/manuals/Makefile.am b/doc/manuals/Makefile.am index 2fd21e6..70c5a58 100644 --- a/doc/manuals/Makefile.am +++ b/doc/manuals/Makefile.am @@ -3,7 +3,6 @@ osmobts-abis-docinfo.xml \ osmobts-usermanual.adoc \ osmobts-usermanual-docinfo.xml \ -osmobts-vty-reference.xml \ rtp-amr.adoc \ rtp-amr-docinfo.xml \ regen_doc.sh \ diff --git a/doc/manuals/vty/Makefile.vty-reference.inc b/doc/manuals/vty/Makefile.vty-reference.inc index f27506b..4598aa5 100644 --- a/doc/manuals/vty/Makefile.vty-reference.inc +++ b/doc/manuals/vty/Makefile.vty-reference.inc @@ -17,7 +17,7 @@ -e "s|@@REV_NUMBER@@|$(VERSION)|" \ -e "s|@@REV_DATE@@|$(shell date +"%dth %B %Y")|" \ -e "s|@@CR_YEAR@@|$(shell date +"%Y")|" \ - $(srcdir)/osmobts-vty-reference.xml > $@ + $(srcdir)/vty/osmobts-vty-reference.xml > $@ vty/osmobts-%-vty-reference.xml.inc: $(top_builddir)/src/osmo-bts-*/osmo-bts-% \ $(OSMO_GSM_MANUALS_DIR)/common/vty_additions.xml \ diff --git a/doc/manuals/osmobts-vty-reference.xml b/doc/manuals/vty/osmobts-vty-reference.xml similarity index 100% rename from doc/manuals/osmobts-vty-reference.xml rename to doc/manuals/vty/osmobts-vty-reference.xml -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21009 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iaba5c42b39fa764cd38c903486617c3d9f9cdebb Gerrit-Change-Number: 21009 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange
Change in osmo-gsm-manuals[master]: vty_reference_combine.sh: print the final result to stdout
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/20952 ) Change subject: vty_reference_combine.sh: print the final result to stdout .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/20952 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I6aac73d998c5937894233631e654a160d5623198 Gerrit-Change-Number: 20952 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Sat, 31 Oct 2020 22:12:01 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-trx[master]: doc/manuals: generate XML VTY reference at build-time
Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/20966 to look at the new patch set (#6). Change subject: doc/manuals: generate XML VTY reference at build-time .. doc/manuals: generate XML VTY reference at build-time Unfortunately, we cannot re-use the existing Makefile rules from: $(OSMO_GSM_MANUALS_DIR)/build/Makefile.vty-reference.inc because they do not allow to generate the list of $(DOCBOOKS) from a template, and require the project to store everything in separate folders with specific names. Also, those rules expect that the target PDFs contain only a single word in their names (for example, 'osmoapp-vty-reference', not 'osmo-app-vty-reference'), while in a project with multiple similarly named targets this would reduce readability (imagine 'osmotrxuhd-vty-reference'). Change-Id: I798ea3b7417b8ca3e9c7d50911158c5413526237 Depends: I6aac73d998c5937894233631e654a160d5623198 Related: SYS#4937, SYS#4910 --- M .gitignore M Makefile.am M doc/manuals/Makefile.am A doc/manuals/vty/Makefile.vty-reference.inc R doc/manuals/vty/osmotrx-vty-reference.xml D doc/manuals/vty/trx_vty_reference.xml 6 files changed, 70 insertions(+), 1,413 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/66/20966/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/20966 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I798ea3b7417b8ca3e9c7d50911158c5413526237 Gerrit-Change-Number: 20966 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmo-ttcn3-hacks[master]: PCU_Tests: verify CS paging of multiple subscribers
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20998 ) Change subject: PCU_Tests: verify CS paging of multiple subscribers .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20998 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie8b4006f969598c9b0c452002d559f985d108a66 Gerrit-Change-Number: 20998 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Sat, 31 Oct 2020 21:21:41 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: library/PCUIF_Types: f_PCUIF_ver_INFO_PDCHMask_get() returns BIT8
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21000 )
Change subject: library/PCUIF_Types: f_PCUIF_ver_INFO_PDCHMask_get() returns
BIT8
..
library/PCUIF_Types: f_PCUIF_ver_INFO_PDCHMask_get() returns BIT8
Change-Id: Ib8e497b596370d0b48e76e6e86c01f0c1d9c5df5
---
M bts/BTS_Tests.ttcn
M library/PCUIF_Types.ttcn
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/00/21000/1
diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index b1a6dac..533f65d 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -5662,7 +5662,7 @@
var PCUIF_send_data sd;
[] PCU.receive(t_SD_PCUIF(pcu_conn_id, tr_PCUIF_INFO_IND(bts_nr, ?)))
-> value sd {
- var bitstring pdch_mask :=
f_PCUIF_ver_INFO_PDCHMask_get(sd.data.u.info_ind, trx_nr);
+ var BIT8 pdch_mask :=
f_PCUIF_ver_INFO_PDCHMask_get(sd.data.u.info_ind, trx_nr);
if (substr(pdch_mask, g_chan_nr.tn, 1) != exp) {
repeat;
}
diff --git a/library/PCUIF_Types.ttcn b/library/PCUIF_Types.ttcn
index 86c6c2a..0e112dc 100644
--- a/library/PCUIF_Types.ttcn
+++ b/library/PCUIF_Types.ttcn
@@ -982,7 +982,7 @@
}
function f_PCUIF_ver_INFO_PDCHMask_get(in PCUIF_info_ind info, uint8_t trx_nr)
-return bitstring {
+return BIT8 {
if (PCUIF_Types.mp_pcuif_version >= 10) {
return info.trx.v10[trx_nr].pdch_mask;
} else {
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21000
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib8e497b596370d0b48e76e6e86c01f0c1d9c5df5
Gerrit-Change-Number: 21000
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
Change in osmo-ttcn3-hacks[master]: GPRS_Components: rename 'GprsMSArray' to 'GprsMSList'
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21003 )
Change subject: GPRS_Components: rename 'GprsMSArray' to 'GprsMSList'
..
GPRS_Components: rename 'GprsMSArray' to 'GprsMSList'
In TTCN-3, array assumes a fixed number of elements. A 'record of'
type is more like a 'list' in Python, so let's call it this way.
Change-Id: Ib7df7efaa28a53a45d981d1c99f9eb1ac26fd91c
---
M pcu/GPRS_Components.ttcn
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/03/21003/1
diff --git a/pcu/GPRS_Components.ttcn b/pcu/GPRS_Components.ttcn
index c860af5..4b4e2a0 100644
--- a/pcu/GPRS_Components.ttcn
+++ b/pcu/GPRS_Components.ttcn
@@ -113,7 +113,7 @@
UlTbf ul_tbf optional, /* TODO: Only 1 UL tbf supported for
now */
DlTbf dl_tbf optional /* TODO: Only 1 DL tbf supported for
now */
};
-type record of GprsMS GprsMSArray;
+type record of GprsMS GprsMSList;
template AckNackDescription t_AckNackDescription_init := {
final_ack := '0'B,
@@ -163,7 +163,7 @@
port RAW_PCU_MSG_PT BTS;
/* Mobile station(s) involved in a testing scenario */
- var GprsMSArray g_ms := { };
+ var GprsMSList g_ms := { };
/* Value at which Countdown Procedure starts. Announced by network
(GPRS Cell Options as per TS 04.60 Chapter 12.24) */
var uint4_t g_bs_cv_max := 4;
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21003
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib7df7efaa28a53a45d981d1c99f9eb1ac26fd91c
Gerrit-Change-Number: 21003
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
Change in osmo-ttcn3-hacks[master]: GPRS_Components: allow arbitrary number of GprsMS instances
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21002 )
Change subject: GPRS_Components: allow arbitrary number of GprsMS instances
..
GPRS_Components: allow arbitrary number of GprsMS instances
Change-Id: Ia118d58fafa50547f109c68829aa869785e0dc9c
---
M pcu/GPRS_Components.ttcn
1 file changed, 9 insertions(+), 5 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/02/21002/1
diff --git a/pcu/GPRS_Components.ttcn b/pcu/GPRS_Components.ttcn
index 3778b2f..c860af5 100644
--- a/pcu/GPRS_Components.ttcn
+++ b/pcu/GPRS_Components.ttcn
@@ -162,17 +162,21 @@
/* Connection to the BTS component (one for now) */
port RAW_PCU_MSG_PT BTS;
- /* Support only 8 ms for now */
- var GprsMS g_ms[8];
+ /* Mobile station(s) involved in a testing scenario */
+ var GprsMSArray g_ms := { };
/* Value at which Countdown Procedure starts. Announced by network
(GPRS Cell Options as per TS 04.60 Chapter 12.24) */
var uint4_t g_bs_cv_max := 4;
}
-function f_init_gprs_ms(integer num_ms := 1, template (value) GprsMS ms_params
:= t_GprsMS_def) runs on MS_BTS_IFACE_CT
-{
+/* Generate a list of GprsMS of the given size */
+function f_init_gprs_ms(integer num_ms := 1, template (value) GprsMS t_ms :=
t_GprsMS_def)
+runs on MS_BTS_IFACE_CT {
for (var integer i := 0; i < num_ms; i := i + 1 ) {
- g_ms[i] := valueof(ms_params);
+ var GprsMS ms := valueof(t_ms);
+
+ /* Append to the global list */
+ g_ms := g_ms & { ms };
}
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21002
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia118d58fafa50547f109c68829aa869785e0dc9c
Gerrit-Change-Number: 21002
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
Change in osmo-ttcn3-hacks[master]: GPRS_Components: ensure unique IMSI/TLLI in f_init_gprs_ms()
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21004 )
Change subject: GPRS_Components: ensure unique IMSI/TLLI in f_init_gprs_ms()
..
GPRS_Components: ensure unique IMSI/TLLI in f_init_gprs_ms()
Change-Id: I4beeeac600515458c2aeaf9e0be1cf2546ff0584
---
M pcu/GPRS_Components.ttcn
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/04/21004/1
diff --git a/pcu/GPRS_Components.ttcn b/pcu/GPRS_Components.ttcn
index 4b4e2a0..2a8726f 100644
--- a/pcu/GPRS_Components.ttcn
+++ b/pcu/GPRS_Components.ttcn
@@ -169,12 +169,16 @@
var uint4_t g_bs_cv_max := 4;
}
-/* Generate a list of GprsMS of the given size */
+/* Generate a list of GprsMS (unique IMSI/TLLI) of the given size */
function f_init_gprs_ms(integer num_ms := 1, template (value) GprsMS t_ms :=
t_GprsMS_def)
runs on MS_BTS_IFACE_CT {
for (var integer i := 0; i < num_ms; i := i + 1 ) {
var GprsMS ms := valueof(t_ms);
+ /* We assume that num_ms is not a large number */
+ ms.imsi := f_gen_imsi(i + 1);
+ ms.tlli := int2oct(i + 1, 4);
+
/* Append to the global list */
g_ms := g_ms & { ms };
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21004
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I4beeeac600515458c2aeaf9e0be1cf2546ff0584
Gerrit-Change-Number: 21004
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
Change in osmo-ttcn3-hacks[master]: GPRS_Components: generalize both f_pkt_paging_match_{imsi, tmsi}()
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21007 )
Change subject: GPRS_Components: generalize both
f_pkt_paging_match_{imsi,tmsi}()
..
GPRS_Components: generalize both f_pkt_paging_match_{imsi,tmsi}()
Change-Id: Ie0578fa299cdac18e942350b2e879839c9bd9dba
---
M pcu/GPRS_Components.ttcn
M pcu/PCU_Tests.ttcn
2 files changed, 62 insertions(+), 37 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/07/21007/1
diff --git a/pcu/GPRS_Components.ttcn b/pcu/GPRS_Components.ttcn
index d6abf6d..7364476 100644
--- a/pcu/GPRS_Components.ttcn
+++ b/pcu/GPRS_Components.ttcn
@@ -934,8 +934,10 @@
return f_rrbp_ack_fn(dl_fn, rrbp);
}
-function f_pkt_paging_match_tmsi(in PacketPagingReq req, template GsmTmsi tmsi)
-runs on MS_BTS_IFACE_CT {
+/* Return true if a given Packet Paging Request contains the given IMSI, false
otherwise */
+function f_pkt_paging_match_imsi(in PacketPagingReq req, template hexstring
imsi,
+boolean cs_domain := true, boolean ps_domain
:= true)
+runs on MS_BTS_IFACE_CT return boolean {
if (not ispresent(req.repeated_pageinfo)) {
setverdict(fail, "Packet Paging Request without MIs?!?");
f_shutdown(__BFILE__, __LINE__);
@@ -943,18 +945,57 @@
for (var integer i := 0; i < lengthof(req.repeated_pageinfo); i := i +
1) {
var PageInfo info := req.repeated_pageinfo[i].item;
- if (not ischosen(info.cs))
- { continue; }
+ var MobileIdentityLV_Paging mi_lv;
- if (match(info.cs.tmsi, tmsi)) {
- setverdict(pass);
- return;
+ if (ischosen(info.cs)) { /* CS domain */
+ if (not ispresent(info.cs.mobile_identity))
+ { continue; }
+ if (not cs_domain)
+ { continue; }
+ mi_lv := info.cs.mobile_identity;
+ } else { /* PS domain */
+ if (not ispresent(info.ps.mobile_identity))
+ { continue; }
+ if (not ps_domain)
+ { continue; }
+ mi_lv := info.ps.mobile_identity;
+ }
+
+ /* Make sure MI contains IMSI before referencing it */
+ if (match(mi_lv.mobile_id, decmatch tr_MI_IMSI(imsi))) {
+ return true;
}
}
- setverdict(fail, "Mobile Identity (TMSI/P-TMSI) ", tmsi,
- " is not present in ", req.repeated_pageinfo);
- f_shutdown(__BFILE__, __LINE__);
+ return false;
+}
+
+/* Return true if a given Packet Paging Request contains the given P-TMSI,
false otherwise */
+function f_pkt_paging_match_tmsi(in PacketPagingReq req, template GsmTmsi tmsi,
+boolean cs_domain := true, boolean ps_domain
:= true)
+runs on MS_BTS_IFACE_CT return boolean {
+ if (not ispresent(req.repeated_pageinfo)) {
+ setverdict(fail, "Packet Paging Request without MIs?!?");
+ f_shutdown(__BFILE__, __LINE__);
+ }
+
+ for (var integer i := 0; i < lengthof(req.repeated_pageinfo); i := i +
1) {
+ var PageInfo info := req.repeated_pageinfo[i].item;
+
+ if (cs_domain and ischosen(info.cs)) {
+ if (not ispresent(info.cs.tmsi))
+ { continue; }
+ if (match(info.cs.tmsi, tmsi))
+ { return true; }
+ } else if (ps_domain) {
+ if (not ispresent(info.ps.ptmsi))
+ { continue; }
+ if (match(info.ps.ptmsi, tmsi))
+ { return true; }
+ }
+ }
+
+ return false;
}
}
diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn
index dffbc4d..5e61d85 100644
--- a/pcu/PCU_Tests.ttcn
+++ b/pcu/PCU_Tests.ttcn
@@ -1700,30 +1700,6 @@
f_shutdown(__BFILE__, __LINE__, final := true);
}
-private function f_pkt_paging_match_imsi(in PacketPagingReq req, hexstring
imsi)
-runs on RAW_PCU_Test_CT {
- var PageInfo info := req.repeated_pageinfo[0].item;
- var MobileIdentityLV_Paging mi_lv := info.cs.mobile_identity;
- var MobileIdentityV mi := dec_MobileIdentityV(mi_lv.mobile_id);
-
- if (mi_lv.len != 8) { /* 8 octets: type of ID (3 bits) + even/odd flag
(1 bit) + 15 BCD-encoded digits (60 bits) */
- setverdict(fail, "Mobile Identity length mismatch: ",
- "expected: 8, got: ", mi_lv.len);
- f_shutdown(__BFILE__, __LINE__);
- }
-
- /* Make sure MI contains IMSI before referencing it */
-
Change in osmo-ttcn3-hacks[master]: GPRS_Components: add RA definition for single block packet access
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21005 )
Change subject: GPRS_Components: add RA definition for single block packet
access
..
GPRS_Components: add RA definition for single block packet access
Change-Id: I8997121f1b1207d4236f5911befc3c29278f37d8
---
M pcu/GPRS_Components.ttcn
M pcu/PCU_Tests.ttcn
2 files changed, 5 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/05/21005/1
diff --git a/pcu/GPRS_Components.ttcn b/pcu/GPRS_Components.ttcn
index 2a8726f..f48eae1 100644
--- a/pcu/GPRS_Components.ttcn
+++ b/pcu/GPRS_Components.ttcn
@@ -651,7 +651,9 @@
}
/* One phase packet access (see 3GPP TS 44.018, table 9.1.8.1) */
-const BIT8 chan_req_def := '0000'B;
+const BIT8 chan_req_def := '0000'B; /* 0 { 0xx | x0x | xx0 } */
+/* Single block (two phase or RR signalling) packet access */
+const BIT8 chan_req_sb := '0111'B; /* 01110xxx */
/* Establish an Uplink TBF by sending RACH.ind towards the PCU */
function f_pcuif_tx_rach_rx_imm_ass(uint16_t ra := bit2int(chan_req_def),
diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn
index 8facde7..dffbc4d 100644
--- a/pcu/PCU_Tests.ttcn
+++ b/pcu/PCU_Tests.ttcn
@@ -1132,8 +1132,8 @@
var uint32_t unused_fn;
var GprsMS ms;
- /* 0111 0xxx: Single block packet access; one block period on a PDCH is
needed for two phase packet access or other RR signalling purpose. */
- var uint16_t ra := oct2int('70'O);
+ /* Single block (two phase) packet access */
+ var uint16_t ra := bit2int(chan_req_sb);
if (g_force_two_phase_access) {
/* If 2phase access is enforced by the network, then let's
request a One phase packet access, we'll receive a single
block
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21005
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I8997121f1b1207d4236f5911befc3c29278f37d8
Gerrit-Change-Number: 21005
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
Change in osmo-ttcn3-hacks[master]: PCU_Tests: add 'f_multi_ms_' API for multi-MS test cases
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21008 )
Change subject: PCU_Tests: add 'f_multi_ms_' API for multi-MS test cases
..
PCU_Tests: add 'f_multi_ms_' API for multi-MS test cases
Change-Id: Ie2cc717f9f50db16748fe4e4a0ad80d549981e61
---
M pcu/PCU_Tests.ttcn
1 file changed, 34 insertions(+), 6 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/08/21008/1
diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn
index 5e61d85..f9cd1c5 100644
--- a/pcu/PCU_Tests.ttcn
+++ b/pcu/PCU_Tests.ttcn
@@ -238,6 +238,35 @@
BTS.receive(tr_RAW_PCU_EV(BTS_EV_SI13_NEGO));
}
+/* Register TLLI of each allocated GprsMS instance */
+private function f_multi_ms_bssgp_register()
+runs on RAW_PCU_Test_CT {
+ for (var integer i := 0; i < lengthof(g_ms); i := i + 1) {
+ f_bssgp_client_llgmm_assign(''O, g_ms[i].tlli);
+ }
+}
+
+/* Allocate [and activate] an Uplink TBF for each allocated GprsMS instance */
+private function f_multi_ms_establish_tbf(boolean do_activate := false)
+runs on RAW_PCU_Test_CT {
+ for (var integer i := 0; i < lengthof(g_ms); i := i + 1) {
+ /* Establish an Uplink TBF */
+ f_ms_establish_ul_tbf(g_ms[i]);
+
+ /* Send a random block, so this TBF becomes "active" */
+ if (do_activate) {
+ /* FIXME: use the new APU by Pau to get correct TRX/TS
here */
+ var template TsTrxBtsNum nr := ts_TsTrxBtsNum(7, i mod
8);
+ var octetstring dummy := f_rnd_octstring(12);
+ var RlcmacDlBlock dl_block;
+ var uint32_t poll_fn;
+
+ f_ms_tx_ul_data_block(g_ms[i], dummy, with_tlli :=
true, nr := nr);
+ f_rx_rlcmac_dl_block_exp_ack_nack(dl_block, poll_fn, nr
:= nr);
+ }
+ }
+}
+
testcase TC_pcuif_suspend() runs on RAW_PCU_Test_CT {
var octetstring ra_id :=
enc_RoutingAreaIdentification(mp_gb_cfg.bvc[0].cell_id.ra_id);
var GprsTlli tlli := ''O;
@@ -2489,14 +2518,13 @@
/* Establish BSSGP connection to the PCU */
f_bssgp_establish();
- for (i := 0; i < num_ms; i := i + 1) {
- f_bssgp_client_llgmm_assign(TLLI_UNUSED, g_ms[i].tlli);
- }
+ f_multi_ms_bssgp_register();
- /* Establish an Uplink TBF for each MS. They should be allocated on
- different TRX in an uniform way. */
+ /* Establish an Uplink TBF for each GprsMS instance */
+ f_multi_ms_establish_tbf(do_activate := false);
+
+ /* Check if all TBFs are allocated on different TRX in an uniform way */
for (i := 0; i < num_ms; i := i + 1) {
- f_ms_establish_ul_tbf(g_ms[i]);
if (g_ms[i].ul_tbf.arfcn != info_ind.trx.v10[i mod 3].arfcn) {
setverdict(fail, "Got assigned ARFCN ",
g_ms[i].ul_tbf.arfcn,
" vs exp ", info_ind.trx.v10[i mod 3].arfcn);
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21008
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie2cc717f9f50db16748fe4e4a0ad80d549981e61
Gerrit-Change-Number: 21008
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
Change in osmo-ttcn3-hacks[master]: library/PCUIF_Types: add '_get' prefix to f_PCUIF_ver_INFO_PDCHMask()
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20999 )
Change subject: library/PCUIF_Types: add '_get' prefix to
f_PCUIF_ver_INFO_PDCHMask()
..
library/PCUIF_Types: add '_get' prefix to f_PCUIF_ver_INFO_PDCHMask()
Change-Id: I0ce8f3fe8cfd47c61199fbbdf0d80d19e6f105e9
---
M bts/BTS_Tests.ttcn
M library/PCUIF_Types.ttcn
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/99/20999/1
diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index fa6ca0c..b1a6dac 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -5662,7 +5662,7 @@
var PCUIF_send_data sd;
[] PCU.receive(t_SD_PCUIF(pcu_conn_id, tr_PCUIF_INFO_IND(bts_nr, ?)))
-> value sd {
- var bitstring pdch_mask :=
f_PCUIF_ver_INFO_PDCHMask(sd.data.u.info_ind, trx_nr);
+ var bitstring pdch_mask :=
f_PCUIF_ver_INFO_PDCHMask_get(sd.data.u.info_ind, trx_nr);
if (substr(pdch_mask, g_chan_nr.tn, 1) != exp) {
repeat;
}
diff --git a/library/PCUIF_Types.ttcn b/library/PCUIF_Types.ttcn
index b50e4c5..86c6c2a 100644
--- a/library/PCUIF_Types.ttcn
+++ b/library/PCUIF_Types.ttcn
@@ -981,7 +981,7 @@
}
}
-function f_PCUIF_ver_INFO_PDCHMask(in PCUIF_info_ind info, uint8_t trx_nr)
+function f_PCUIF_ver_INFO_PDCHMask_get(in PCUIF_info_ind info, uint8_t trx_nr)
return bitstring {
if (PCUIF_Types.mp_pcuif_version >= 10) {
return info.trx.v10[trx_nr].pdch_mask;
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20999
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I0ce8f3fe8cfd47c61199fbbdf0d80d19e6f105e9
Gerrit-Change-Number: 20999
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
Change in osmo-ttcn3-hacks[master]: library/PCUIF_Types: add f_PCUIF_ver_INFO_PDCHMask_set()
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21001 )
Change subject: library/PCUIF_Types: add f_PCUIF_ver_INFO_PDCHMask_set()
..
library/PCUIF_Types: add f_PCUIF_ver_INFO_PDCHMask_set()
Change-Id: I443bc99d35994dda14cdf9c41609d528368c401f
---
M library/PCUIF_Types.ttcn
M pcu/PCU_Tests.ttcn
2 files changed, 27 insertions(+), 19 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/01/21001/1
diff --git a/library/PCUIF_Types.ttcn b/library/PCUIF_Types.ttcn
index 0e112dc..8af3757 100644
--- a/library/PCUIF_Types.ttcn
+++ b/library/PCUIF_Types.ttcn
@@ -990,6 +990,24 @@
}
}
+function f_PCUIF_ver_INFO_PDCHMask_set(inout PCUIF_info_ind info, BIT8
pdch_mask,
+ template (present) uint8_t trx_nr := ?)
+{
+ if (PCUIF_Types.mp_pcuif_version >= 10) {
+ for (var integer nr := 0; nr < lengthof(info.trx.v10); nr := nr
+ 1) {
+ if (match(nr, trx_nr)) {
+ info.trx.v10[nr].pdch_mask := pdch_mask;
+ }
+ }
+ } else {
+ for (var integer nr := 0; nr < lengthof(info.trx.v09); nr := nr
+ 1) {
+ if (match(nr, trx_nr)) {
+ info.trx.v09[nr].pdch_mask := pdch_mask;
+ }
+ }
+ }
+}
+
function f_PCUIF_AF2addr_type(AddressFamily address_family)
return PCUIF_AddrType {
if (address_family == AF_INET) {
diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn
index 411890c..8facde7 100644
--- a/pcu/PCU_Tests.ttcn
+++ b/pcu/PCU_Tests.ttcn
@@ -2192,19 +2192,10 @@
var BIT11 ra11;
info_ind := valueof(ts_PCUIF_INFO_default);
- if (PCUIF_Types.mp_pcuif_version >= 10) {
- /* Only the first TRX is enabled. */
- for (var integer i := 0; i < lengthof(info_ind.trx.v10); i := i
+ 1) {
- info_ind.trx.v10[i].pdch_mask := ''B;
- }
- info_ind.trx.v10[0].pdch_mask := '0001'B;
- } else {
- /* Only the first TRX is enabled. */
- for (var integer i := 0; i < lengthof(info_ind.trx.v09); i := i
+ 1) {
- info_ind.trx.v09[i].pdch_mask := ''B;
- }
- info_ind.trx.v09[0].pdch_mask := '0001'B;
- }
+
+ /* Only the first TRX is enabled. */
+ f_PCUIF_ver_INFO_PDCHMask_set(info_ind, ''B, (1 .. 7));
+ f_PCUIF_ver_INFO_PDCHMask_set(info_ind, '0001'B, 0);
/* Initialize the PCU interface abstraction */
f_init_raw(testcasename(), info_ind);
@@ -2501,14 +2492,13 @@
f_init_gprs_ms(num_ms);
info_ind := valueof(ts_PCUIF_INFO_default);
+
/* Only the 3 first TRX are enabled. The enabled ones all have same
amount of resources, hence same amount of initial resources. */
- for (i := 0; i < lengthof(info_ind.trx.v10); i := i + 1) {
- info_ind.trx.v10[i].pdch_mask := ''B;
- }
- info_ind.trx.v10[0].pdch_mask := '0011'B;
- info_ind.trx.v10[1].pdch_mask := '1100'B;
- info_ind.trx.v10[2].pdch_mask := '1100'B;
+ f_PCUIF_ver_INFO_PDCHMask_set(info_ind, ''B, (3 .. 7));
+ f_PCUIF_ver_INFO_PDCHMask_set(info_ind, '0011'B, 0);
+ f_PCUIF_ver_INFO_PDCHMask_set(info_ind, '1100'B, 1);
+ f_PCUIF_ver_INFO_PDCHMask_set(info_ind, '1100'B, 2);
/* Initialize the PCU interface abstraction */
f_init_raw(testcasename(), info_ind);
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21001
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I443bc99d35994dda14cdf9c41609d528368c401f
Gerrit-Change-Number: 21001
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
Change in osmo-ttcn3-hacks[master]: GPRS_Components: ensure cyclic RA in f_init_gprs_ms()
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21006 )
Change subject: GPRS_Components: ensure cyclic RA in f_init_gprs_ms()
..
GPRS_Components: ensure cyclic RA in f_init_gprs_ms()
Change-Id: I9896bb6bf1ceb592bae22139bf48c6aa7c0265bd
---
M pcu/GPRS_Components.ttcn
1 file changed, 10 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/06/21006/1
diff --git a/pcu/GPRS_Components.ttcn b/pcu/GPRS_Components.ttcn
index f48eae1..d6abf6d 100644
--- a/pcu/GPRS_Components.ttcn
+++ b/pcu/GPRS_Components.ttcn
@@ -169,7 +169,7 @@
var uint4_t g_bs_cv_max := 4;
}
-/* Generate a list of GprsMS (unique IMSI/TLLI) of the given size */
+/* Generate a list of GprsMS (unique IMSI/TLLI, cyclic RA) of the given size */
function f_init_gprs_ms(integer num_ms := 1, template (value) GprsMS t_ms :=
t_GprsMS_def)
runs on MS_BTS_IFACE_CT {
for (var integer i := 0; i < num_ms; i := i + 1 ) {
@@ -179,6 +179,15 @@
ms.imsi := f_gen_imsi(i + 1);
ms.tlli := int2oct(i + 1, 4);
+ /* Ensure different RA for siblings */
+ if (ms.ra == bit2int(chan_req_def)) {
+ /* 0 { 0xx | x0x | xx0 } */
+ f_ms_use_ra(ms, ms.ra + (i mod 7));
+ } else if (ms.ra == bit2int(chan_req_sb)) {
+ /* 01110xxx */
+ f_ms_use_ra(ms, ms.ra + (i mod 8));
+ }
+
/* Append to the global list */
g_ms := g_ms & { ms };
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21006
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9896bb6bf1ceb592bae22139bf48c6aa7c0265bd
Gerrit-Change-Number: 21006
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
Change in osmo-pcu[master]: BSSGP: use tlvp_val8() in gprs_bssgp_pcu_rx_paging_cs()
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/20986 ) Change subject: BSSGP: use tlvp_val8() in gprs_bssgp_pcu_rx_paging_cs() .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/20986/1/src/gprs_bssgp_pcu.cpp File src/gprs_bssgp_pcu.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/20986/1/src/gprs_bssgp_pcu.cpp@212 PS1, Line 212: return BTS::main_bts()->add_paging(tlvp_val8(tp, BSSGP_IE_CHAN_NEEDED, 0), &mi); > Shouldn't we check whether the IE is there and otherwise print log or reject > somehow? According to 3GPP TS 48.018, table 10.3.2, this is an optional IE, so no. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/20986 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ic1e37cb9938323c9b9f0466be5cf7251a6db1008 Gerrit-Change-Number: 20986 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Sat, 31 Oct 2020 12:58:08 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
Change in osmo-pcu[master]: Get rid of bts->egprs_enabled
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/20994 ) Change subject: Get rid of bts->egprs_enabled .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/20994 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ifcf23771bd23afc64ca6fea38948f98f2d134ecb Gerrit-Change-Number: 20994 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Sat, 31 Oct 2020 12:54:47 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: tbf_ul: Allow non-egprs phones if EGPRS is enabled
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/20993 ) Change subject: tbf_ul: Allow non-egprs phones if EGPRS is enabled .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/20993 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I2e01b9d0de7506e0c0960342d73dba29187fe61f Gerrit-Change-Number: 20993 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Sat, 31 Oct 2020 12:53:22 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: tbf_dl: Don't fake EGPRS MS class when no related info is available
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/20936 ) Change subject: tbf_dl: Don't fake EGPRS MS class when no related info is available .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/20936 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Icce66cadb51af25ae0c3b3719940eccb548fe33b Gerrit-Change-Number: 20936 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Sat, 31 Oct 2020 12:53:01 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: pdch: Drop error log line about egprs not enabled
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/20929 ) Change subject: pdch: Drop error log line about egprs not enabled .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/20929 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ie70ec8e4a2d688762d7d320d6ad58d5a0cc52ea1 Gerrit-Change-Number: 20929 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: lynxis lazus Gerrit-Comment-Date: Sat, 31 Oct 2020 12:52:30 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: Enable egprs support through PCUIF from BTS/BSC
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/20928 ) Change subject: Enable egprs support through PCUIF from BTS/BSC .. Patch Set 5: > Patch Set 2: > > > Patch Set 2: > > > > At least for now, pure GPRS service (without EDGE) works more reliably for > > me. I am fine with enabling it automatically, but would still be nice to > > have a kill-switch. > > Well then do so from BTS/BSC, because imho it makes no sense setting "mode > egprs" in BTS/BSC and then setting the opposite in PCU. ACK. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/20928 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ic80970a136361584da9c912252a07e7c3c9d85d0 Gerrit-Change-Number: 20928 Gerrit-PatchSet: 5 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Sat, 31 Oct 2020 12:51:28 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-pcu[master]: Enable egprs support through PCUIF from BTS/BSC
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/20928 ) Change subject: Enable egprs support through PCUIF from BTS/BSC .. Patch Set 5: Code-Review+1 (2 comments) https://gerrit.osmocom.org/c/osmo-pcu/+/20928/5/src/pcu_vty.c File src/pcu_vty.c: https://gerrit.osmocom.org/c/osmo-pcu/+/20928/5/src/pcu_vty.c@278 PS5, Line 278: vty_out (vty, "'egprs only' is deprecated, egprs support is controled from BTS/BSC config, this is now a no-op%s", VTY_NEWLINE); Please prefix the message with '%%' like we usually do. https://gerrit.osmocom.org/c/osmo-pcu/+/20928/5/src/pcu_vty.c@287 PS5, Line 287: vty_out (vty, "'no egprs only' is deprecated, egprs support is controled from BTS/BSC config, this is now a no-op%s", VTY_NEWLINE); Please prefix the message with '%%' like we usually do. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/20928 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ic80970a136361584da9c912252a07e7c3c9d85d0 Gerrit-Change-Number: 20928 Gerrit-PatchSet: 5 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Sat, 31 Oct 2020 12:51:05 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: pcuif: Improve BTS-supported CS/MCS handling
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/20990 ) Change subject: pcuif: Improve BTS-supported CS/MCS handling .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/20990/1/src/pcu_l1_if.cpp File src/pcu_l1_if.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/20990/1/src/pcu_l1_if.cpp@620 PS1, Line 620: 0 Also, shouldn't this be 'i' like below? -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/20990 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ie8f0215ba17da1e545e98bec9325c02f1e8efaea Gerrit-Change-Number: 20990 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Sat, 31 Oct 2020 12:49:39 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-pcu[master]: Take into account BTS supported (M)CS values when retrieving the maximum
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/20992 ) Change subject: Take into account BTS supported (M)CS values when retrieving the maximum .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/20992 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I2d3a8bbae2f9887400ce56d2f8303ea30abaecfa Gerrit-Change-Number: 20992 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Sat, 31 Oct 2020 12:48:28 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: Move EGPRS MS mode set to gprs_ms.cpp
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/20991 ) Change subject: Move EGPRS MS mode set to gprs_ms.cpp .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/20991/1/src/gprs_ms.cpp File src/gprs_ms.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/20991/1/src/gprs_ms.cpp@544 PS1, Line 544: struct const -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/20991 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I9d3ee21c765054a36bd22352e48bde5ffca9225a Gerrit-Change-Number: 20991 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Sat, 31 Oct 2020 12:46:29 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: pcuif: Improve BTS-supported CS/MCS handling
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/20990 ) Change subject: pcuif: Improve BTS-supported CS/MCS handling .. Patch Set 1: Code-Review-1 (7 comments) https://gerrit.osmocom.org/c/osmo-pcu/+/20990/1/src/bts.h File src/bts.h: https://gerrit.osmocom.org/c/osmo-pcu/+/20990/1/src/bts.h@113 PS1, Line 113: bool cs_supported[4]; Why not bit-masks? https://gerrit.osmocom.org/c/osmo-pcu/+/20990/1/src/gprs_bssgp_pcu.cpp File src/gprs_bssgp_pcu.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/20990/1/src/gprs_bssgp_pcu.cpp@746 PS1, Line 746: sizeof I would not make such assumptions that sizeof(bool) is always 1; it's safer to ARRAY_SIZE here. But using a bit-mask is even better, as I already pointed in another comment. https://gerrit.osmocom.org/c/osmo-pcu/+/20990/1/src/gprs_bssgp_pcu.cpp@749 PS1, Line 749: break Also, what if none of the MCS variants is supported? Would we leave 'num' uninitialized? https://gerrit.osmocom.org/c/osmo-pcu/+/20990/1/src/gprs_bssgp_pcu.cpp@769 PS1, Line 769: break Same here, but in this case it's less likely given that CS-1 is mandatory AFAIR. https://gerrit.osmocom.org/c/osmo-pcu/+/20990/1/src/pcu_l1_if.cpp File src/pcu_l1_if.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/20990/1/src/pcu_l1_if.cpp@619 PS1, Line 619: two tabs? why? https://gerrit.osmocom.org/c/osmo-pcu/+/20990/1/src/pcu_l1_if.cpp@621 PS1, Line 621: any_cs_supported What is the motivation here? If the BTS indicates that none is supported, then it's a bug. https://gerrit.osmocom.org/c/osmo-pcu/+/20990/1/src/pcu_l1_if.cpp@625 PS1, Line 625: if (!any_cs_supported) /* We need at least 1 CS, let's enable CS1 */ What is the motivation here? If the BTS indicates that none is supported, then it's a bug. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/20990 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ie8f0215ba17da1e545e98bec9325c02f1e8efaea Gerrit-Change-Number: 20990 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Sat, 31 Oct 2020 12:42:52 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: gprs_ms: Use proper function to get CS
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/20989 ) Change subject: gprs_ms: Use proper function to get CS .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/20989 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I161e733991ac4fa7bd25a0f12b20e5701c76fc52 Gerrit-Change-Number: 20989 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Sat, 31 Oct 2020 12:28:54 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: cosmetic: tests: pcu_emu: fix trailing whitespace
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/20988 ) Change subject: cosmetic: tests: pcu_emu: fix trailing whitespace .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/20988 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I889498c75a78fd8aa406cff5600e4773785782de Gerrit-Change-Number: 20988 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Sat, 31 Oct 2020 12:28:17 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: pcu: prepare tests for new GPRS/EGPRS multiplex support
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20984 ) Change subject: pcu: prepare tests for new GPRS/EGPRS multiplex support .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20984/1/pcu/PCU_Tests.ttcn File pcu/PCU_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20984/1/pcu/PCU_Tests.ttcn@70 PS1, Line 70: c_PCUIF_Flags_default Most of the existing test cases are for GPRS, not EGPRS at the moment. Let's rather keep it disabled by default (i.e. use c_PCUIF_Flags_noMCS), and enable only for those test cases that actually need it. Otherwise the optional argument of f_init_raw() becomes required, and I don't like this to be fair. Alternative solution would be adding a wrapper like f_init_raw_egprs(), that would set the corresponding flags. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20984 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib95aae155b0712313a30f0c5404a8cb1f28b98f5 Gerrit-Change-Number: 20984 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Sat, 31 Oct 2020 12:27:45 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: pcu: Introduce test TC_ul_multislot_tbf_ms_class_from_2phase
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20983 ) Change subject: pcu: Introduce test TC_ul_multislot_tbf_ms_class_from_2phase .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20983/1/pcu/PCU_Tests.ttcn File pcu/PCU_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20983/1/pcu/PCU_Tests.ttcn@1800 PS1, Line 1800: notify 'indicate'? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20983 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I26a3cc0f2bd7bab176aa52df3e40aca7300de216 Gerrit-Change-Number: 20983 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Sat, 31 Oct 2020 12:14:32 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: pcu: Introduce test TC_dl_multislot_tbf_ms_class_from_2phase
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20967 ) Change subject: pcu: Introduce test TC_dl_multislot_tbf_ms_class_from_2phase .. Patch Set 3: Code-Review+1 (5 comments) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20967/3/pcu/PCU_Tests.ttcn File pcu/PCU_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20967/3/pcu/PCU_Tests.ttcn@252 PS3, Line 252: ra := bit2int(chan_req_def); This is why I don't like this comment formatting style: sometimes it's hard to see where the comment ends and where the code starts... (Especially without the syntax highlighting in Gerrit). https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20967/3/pcu/PCU_Tests.ttcn@274 PS3, Line 274: /* So you mix three different comment formatting styles to make everyone happy? ;) I know it may sound like bike-shedding, but still, code consistency matters. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20967/3/pcu/PCU_Tests.ttcn@1169 PS3, Line 1169: var PollFnCtx pollctx; Idea: I think it would be really nice to make this part of GprsMs, so there would be no need to mess up with (sometimes unused, but required) 'poll_fn' argument. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20967/3/pcu/PCU_Tests.ttcn@1201 PS3, Line 1201: nr := pollctx.tstrxbts unrelated? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20967/3/pcu/PCU_Tests.ttcn@1736 PS3, Line 1736: /* Only 1 TRX with 8 PDCH */ Looks like we need some API for this kind of stuff. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20967 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie0035bab79c286a968394d7b724d975f43d187ce Gerrit-Change-Number: 20967 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sat, 31 Oct 2020 12:13:11 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: pcu: Introduce test TC_dl_multislot_tbf_ms_class_from_sgsn
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20947 ) Change subject: pcu: Introduce test TC_dl_multislot_tbf_ms_class_from_sgsn .. Patch Set 5: Code-Review+1 (3 comments) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20947/5/pcu/PCU_Tests.ttcn File pcu/PCU_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20947/5/pcu/PCU_Tests.ttcn@1639 PS5, Line 1639: SYS#5131 Better add this reference to the commit message(s). https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20947/5/pcu/PCU_Tests.ttcn@1679 PS5, Line 1679: PCU will page on CCCH (PCH) This is not true. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20947/5/pcu/PCU_Tests.ttcn@1688 PS5, Line 1688: slot slots -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20947 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I417953a4c89dec82500b3b66f08ed648d266d813 Gerrit-Change-Number: 20947 Gerrit-PatchSet: 5 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-CC: laforge Gerrit-Comment-Date: Sat, 31 Oct 2020 11:58:13 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: pcu: Add infra to handle multitrx and multits envs
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20968 ) Change subject: pcu: Add infra to handle multitrx and multits envs .. Patch Set 2: Code-Review-1 (10 comments) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20968/2/pcu/GPRS_Components.ttcn File pcu/GPRS_Components.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20968/2/pcu/GPRS_Components.ttcn@205 PS2, Line 205: uint10_t GsmArfcn https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20968/2/pcu/GPRS_Components.ttcn@213 PS2, Line 213: uint10_t GsmArfcn https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20968/2/pcu/GPRS_Components.ttcn@370 PS2, Line 370: inout in (a.k.a. the 'const') https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20968/2/pcu/GPRS_Components.ttcn@375 PS2, Line 375: arfcn != 0 ARFCN 0 is a valid ARFCN. Maybe rather make it 'optional' and call ispresent() here? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20968/2/pcu/GPRS_Components.ttcn@379 PS2, Line 379: trx_nr := 7; I am afraid it would be hard to debug this if some day we decide to add some new hopping test cases, so I would setverdict(fail, ...) and call f_shutdown() here. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20968/2/pcu/GPRS_Components.ttcn@384 PS2, Line 384: inout in (a.k.a. the 'const') https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20968/2/pcu/GPRS_Components.ttcn@386 PS2, Line 386: uint3_t You're using restricted types without the need... Maximum number of slots would be 8, while the UINT8_MAX is 7. Let's better use integer. It's not a protocol definition after all. P.S. I am now wondering how TITAN handles integer overflows. Would it throw a DTE? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20968/2/pcu/GPRS_Components.ttcn@401 PS2, Line 401: inout in (a.k.a. the 'const') https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20968/2/pcu/GPRS_Components.ttcn@415 PS2, Line 415: inout in (a.k.a. the 'const') https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20968/2/pcu/GPRS_Components.ttcn@417 PS2, Line 417: uint3_t Again, integer overflow if pdch_mask == ''B. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20968 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I28430e6d8c77d2b7dc630d186d425a5d82587b82 Gerrit-Change-Number: 20968 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sat, 31 Oct 2020 11:42:40 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
