Build failure of network:osmocom:nightly/osmo-pcu in Debian_9.0/armv7l
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/Debian_9.0/armv7l Package network:osmocom:nightly/osmo-pcu failed to build in Debian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build log: [ 739s] ^ [ 739s] gprs_bssgp_pcu.cpp:987:28: error: too few arguments to function 'gprs_ns2_nse* gprs_ns2_create_nse(gprs_ns2_inst*, uint16_t, gprs_ns2_ll, gprs_ns2_dialect)' [ 739s] GPRS_NS2_LL_UDP); [ 739s] ^ [ 739s] In file included from ./gprs_bssgp_pcu.h:31:0, [ 739s] from gprs_bssgp_pcu.cpp:22: [ 739s] /usr/include/osmocom/gprs/gprs_ns2.h:155:22: note: declared here [ 739s] struct gprs_ns2_nse *gprs_ns2_create_nse(struct gprs_ns2_inst *nsi, uint16_t nsei, [ 739s] ^~~ [ 739s] gprs_bssgp_pcu.cpp:1001:58: error: 'gprs_ns2_ip_connect_sns' was not declared in this scope [ 739s] rc = gprs_ns2_ip_connect_sns(bind[i], &remote[i], nsei); [ 739s] ^ [ 739s] Makefile:802: recipe for target 'gprs_bssgp_pcu.lo' failed [ 739s] make[2]: *** [gprs_bssgp_pcu.lo] Error 1 [ 739s] make[2]: Leaving directory '/usr/src/packages/BUILD/src' [ 739s] Makefile:417: recipe for target 'all-recursive' failed [ 739s] make[1]: *** [all-recursive] Error 1 [ 739s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 739s] dh_auto_build: make -j1 returned exit code 2 [ 739s] debian/rules:12: recipe for target 'build' failed [ 739s] make: *** [build] Error 2 [ 739s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 739s] ### VM INTERACTION START ### [ 742s] [ 716.895675] sysrq: SysRq : Power Off [ 742s] [ 716.911553] reboot: Power down [ 743s] ### VM INTERACTION END ### [ 743s] [ 743s] obs-arm-6 failed "build osmo-pcu_0.8.0.289.398f.dsc" at Wed Dec 16 07:03:25 UTC 2020. [ 743s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-pcu in Debian_10/armv7l
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/Debian_10/armv7l Package network:osmocom:nightly/osmo-pcu failed to build in Debian_10/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build log: [ 957s] gprs_bssgp_pcu.cpp:987:28: error: too few arguments to function 'gprs_ns2_nse* gprs_ns2_create_nse(gprs_ns2_inst*, uint16_t, gprs_ns2_ll, gprs_ns2_dialect)' [ 957s] GPRS_NS2_LL_UDP); [ 957s] ^ [ 957s] In file included from ./gprs_bssgp_pcu.h:31, [ 957s] from gprs_bssgp_pcu.cpp:22: [ 957s] /usr/include/osmocom/gprs/gprs_ns2.h:155:22: note: declared here [ 957s] struct gprs_ns2_nse *gprs_ns2_create_nse(struct gprs_ns2_inst *nsi, uint16_t nsei, [ 957s] ^~~ [ 957s] gprs_bssgp_pcu.cpp:1001:9: error: 'gprs_ns2_ip_connect_sns' was not declared in this scope [ 957s] rc = gprs_ns2_ip_connect_sns(bind[i], &remote[i], nsei); [ 957s] ^~~ [ 957s] gprs_bssgp_pcu.cpp:1001:9: note: suggested alternative: 'gprs_ns2_ip_connect2' [ 957s] rc = gprs_ns2_ip_connect_sns(bind[i], &remote[i], nsei); [ 957s] ^~~ [ 957s] gprs_ns2_ip_connect2 [ 957s] make[2]: *** [Makefile:835: gprs_bssgp_pcu.lo] Error 1 [ 957s] make[2]: Leaving directory '/usr/src/packages/BUILD/src' [ 957s] make[1]: *** [Makefile:417: all-recursive] Error 1 [ 957s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 957s] dh_auto_build: make -j1 returned exit code 2 [ 957s] make: *** [debian/rules:12: build] Error 2 [ 957s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 957s] ### VM INTERACTION START ### [ 960s] [ 898.954596] sysrq: SysRq : Power Off [ 960s] [ 898.963641] reboot: Power down [ 962s] ### VM INTERACTION END ### [ 962s] [ 962s] obs-arm-6 failed "build osmo-pcu_0.8.0.289.398f.dsc" at Wed Dec 16 06:21:40 UTC 2020. [ 962s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-pcu in Raspbian_10/armv7l
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/Raspbian_10/armv7l Package network:osmocom:nightly/osmo-pcu failed to build in Raspbian_10/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build log: [ 662s] gprs_bssgp_pcu.cpp:987:28: error: too few arguments to function 'gprs_ns2_nse* gprs_ns2_create_nse(gprs_ns2_inst*, uint16_t, gprs_ns2_ll, gprs_ns2_dialect)' [ 662s] GPRS_NS2_LL_UDP); [ 662s] ^ [ 662s] In file included from ./gprs_bssgp_pcu.h:31, [ 662s] from gprs_bssgp_pcu.cpp:22: [ 662s] /usr/include/osmocom/gprs/gprs_ns2.h:155:22: note: declared here [ 662s] struct gprs_ns2_nse *gprs_ns2_create_nse(struct gprs_ns2_inst *nsi, uint16_t nsei, [ 662s] ^~~ [ 662s] gprs_bssgp_pcu.cpp:1001:9: error: 'gprs_ns2_ip_connect_sns' was not declared in this scope [ 662s] rc = gprs_ns2_ip_connect_sns(bind[i], &remote[i], nsei); [ 662s] ^~~ [ 662s] gprs_bssgp_pcu.cpp:1001:9: note: suggested alternative: 'gprs_ns2_ip_connect2' [ 662s] rc = gprs_ns2_ip_connect_sns(bind[i], &remote[i], nsei); [ 662s] ^~~ [ 662s] gprs_ns2_ip_connect2 [ 662s] make[2]: *** [Makefile:835: gprs_bssgp_pcu.lo] Error 1 [ 662s] make[2]: Leaving directory '/usr/src/packages/BUILD/src' [ 662s] make[1]: *** [Makefile:417: all-recursive] Error 1 [ 662s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 662s] dh_auto_build: make -j1 returned exit code 2 [ 662s] make: *** [debian/rules:12: build] Error 2 [ 662s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 662s] ### VM INTERACTION START ### [ 666s] [ 621.846182] sysrq: SysRq : Power Off [ 666s] [ 621.851947] reboot: Power down [ 667s] ### VM INTERACTION END ### [ 667s] [ 667s] obs-arm-5 failed "build osmo-pcu_0.8.0.289.398f.dsc" at Wed Dec 16 06:21:28 UTC 2020. [ 667s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-pcu in openSUSE_Leap_15.1_ARM/armv7l
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/openSUSE_Leap_15.1_ARM/armv7l Package network:osmocom:nightly/osmo-pcu failed to build in openSUSE_Leap_15.1_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build log: [ 123s] ^ [ 123s] In file included from ./gprs_bssgp_pcu.h:31:0, [ 123s] from gprs_bssgp_pcu.cpp:22: [ 123s] /usr/include/libosmocore/osmocom/gprs/gprs_ns2.h:155:22: note: declared here [ 123s] struct gprs_ns2_nse *gprs_ns2_create_nse(struct gprs_ns2_inst *nsi, uint16_t nsei, [ 123s] ^~~ [ 123s] gprs_bssgp_pcu.cpp:1001:9: error: 'gprs_ns2_ip_connect_sns' was not declared in this scope [ 123s] rc = gprs_ns2_ip_connect_sns(bind[i], &remote[i], nsei); [ 123s] ^~~ [ 123s] gprs_bssgp_pcu.cpp:1001:9: note: suggested alternative: 'gprs_ns2_ip_connect2' [ 123s] rc = gprs_ns2_ip_connect_sns(bind[i], &remote[i], nsei); [ 123s] ^~~ [ 123s] gprs_ns2_ip_connect2 [ 123s] make[1]: *** [Makefile:801: gprs_bssgp_pcu.lo] Error 1 [ 123s] make[1]: *** Waiting for unfinished jobs [ 123s] make[1]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-pcu-0.8.0.289.398f/src' [ 123s] make: *** [Makefile:416: all-recursive] Error 1 [ 123s] error: Bad exit status from /var/tmp/rpm-tmp.H77bOD (%build) [ 123s] [ 123s] [ 123s] RPM build errors: [ 123s] Bad exit status from /var/tmp/rpm-tmp.H77bOD (%build) [ 123s] ### VM INTERACTION START ### [ 126s] [ 108.278207] sysrq: SysRq : Power Off [ 126s] [ 108.291707] reboot: Power down [ 127s] ### VM INTERACTION END ### [ 127s] [ 127s] armbuild02 failed "build osmo-pcu.spec" at Wed Dec 16 03:05:49 UTC 2020. [ 127s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-pcu in openSUSE_Factory_ARM/armv7l
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/openSUSE_Factory_ARM/armv7l Package network:osmocom:nightly/osmo-pcu failed to build in openSUSE_Factory_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build log: [ 126s] gprs_bssgp_pcu.cpp:987:28: error: too few arguments to function 'gprs_ns2_nse* gprs_ns2_create_nse(gprs_ns2_inst*, uint16_t, gprs_ns2_ll, gprs_ns2_dialect)' [ 126s] 987 | GPRS_NS2_LL_UDP); [ 126s] |^ [ 126s] In file included from ./gprs_bssgp_pcu.h:31, [ 126s] from gprs_bssgp_pcu.cpp:22: [ 126s] /usr/include/libosmocore/osmocom/gprs/gprs_ns2.h:155:22: note: declared here [ 126s] 155 | struct gprs_ns2_nse *gprs_ns2_create_nse(struct gprs_ns2_inst *nsi, uint16_t nsei, [ 126s] | ^~~ [ 126s] CXX gprs_ms.lo [ 126s] gprs_bssgp_pcu.cpp:1001:9: error: 'gprs_ns2_ip_connect_sns' was not declared in this scope; did you mean 'gprs_ns2_ip_connect2'? [ 126s] 1001 |rc = gprs_ns2_ip_connect_sns(bind[i], &remote[i], nsei); [ 126s] | ^~~ [ 126s] | gprs_ns2_ip_connect2 [ 126s] make[1]: *** [Makefile:834: gprs_bssgp_pcu.lo] Error 1 [ 126s] make[1]: *** Waiting for unfinished jobs [ 131s] make[1]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-pcu-0.8.0.289.398f/src' [ 131s] make: *** [Makefile:416: all-recursive] Error 1 [ 131s] error: Bad exit status from /var/tmp/rpm-tmp.weHYdT (%build) [ 131s] [ 131s] [ 131s] RPM build errors: [ 131s] Bad exit status from /var/tmp/rpm-tmp.weHYdT (%build) [ 131s] ### VM INTERACTION START ### [ 134s] [ 104.674354] sysrq: Power Off [ 134s] [ 104.690511] reboot: Power down [ 135s] ### VM INTERACTION END ### [ 135s] [ 135s] obs-arm-5 failed "build osmo-pcu.spec" at Wed Dec 16 02:38:02 UTC 2020. [ 135s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-pcu in Debian_10/aarch64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/Debian_10/aarch64 Package network:osmocom:nightly/osmo-pcu failed to build in Debian_10/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build log: [ 821s] gprs_bssgp_pcu.cpp:987:28: error: too few arguments to function 'gprs_ns2_nse* gprs_ns2_create_nse(gprs_ns2_inst*, uint16_t, gprs_ns2_ll, gprs_ns2_dialect)' [ 821s] GPRS_NS2_LL_UDP); [ 821s] ^ [ 821s] In file included from ./gprs_bssgp_pcu.h:31, [ 821s] from gprs_bssgp_pcu.cpp:22: [ 821s] /usr/include/osmocom/gprs/gprs_ns2.h:155:22: note: declared here [ 821s] struct gprs_ns2_nse *gprs_ns2_create_nse(struct gprs_ns2_inst *nsi, uint16_t nsei, [ 821s] ^~~ [ 821s] gprs_bssgp_pcu.cpp:1001:9: error: 'gprs_ns2_ip_connect_sns' was not declared in this scope [ 821s] rc = gprs_ns2_ip_connect_sns(bind[i], &remote[i], nsei); [ 821s] ^~~ [ 821s] gprs_bssgp_pcu.cpp:1001:9: note: suggested alternative: 'gprs_ns2_ip_connect2' [ 821s] rc = gprs_ns2_ip_connect_sns(bind[i], &remote[i], nsei); [ 821s] ^~~ [ 821s] gprs_ns2_ip_connect2 [ 821s] make[2]: *** [Makefile:835: gprs_bssgp_pcu.lo] Error 1 [ 821s] make[2]: Leaving directory '/usr/src/packages/BUILD/src' [ 821s] make[1]: *** [Makefile:417: all-recursive] Error 1 [ 821s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 821s] dh_auto_build: make -j1 returned exit code 2 [ 821s] make: *** [debian/rules:12: build] Error 2 [ 821s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 821s] ### VM INTERACTION START ### [ 824s] [ 739.156999] sysrq: Power Off [ 824s] [ 739.180386] reboot: Power down [ 824s] ### VM INTERACTION END ### [ 824s] [ 824s] obs-arm-2 failed "build osmo-pcu_0.8.0.289.398f.dsc" at Wed Dec 16 02:11:12 UTC 2020. [ 824s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-pcu in Debian_9.0/aarch64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/Debian_9.0/aarch64 Package network:osmocom:nightly/osmo-pcu failed to build in Debian_9.0/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build log: [ 741s] ^ [ 741s] gprs_bssgp_pcu.cpp:987:28: error: too few arguments to function 'gprs_ns2_nse* gprs_ns2_create_nse(gprs_ns2_inst*, uint16_t, gprs_ns2_ll, gprs_ns2_dialect)' [ 741s] GPRS_NS2_LL_UDP); [ 741s] ^ [ 741s] In file included from ./gprs_bssgp_pcu.h:31:0, [ 741s] from gprs_bssgp_pcu.cpp:22: [ 741s] /usr/include/osmocom/gprs/gprs_ns2.h:155:22: note: declared here [ 741s] struct gprs_ns2_nse *gprs_ns2_create_nse(struct gprs_ns2_inst *nsi, uint16_t nsei, [ 741s] ^~~ [ 741s] gprs_bssgp_pcu.cpp:1001:58: error: 'gprs_ns2_ip_connect_sns' was not declared in this scope [ 741s] rc = gprs_ns2_ip_connect_sns(bind[i], &remote[i], nsei); [ 741s] ^ [ 741s] Makefile:802: recipe for target 'gprs_bssgp_pcu.lo' failed [ 741s] make[2]: *** [gprs_bssgp_pcu.lo] Error 1 [ 741s] make[2]: Leaving directory '/usr/src/packages/BUILD/src' [ 741s] Makefile:417: recipe for target 'all-recursive' failed [ 741s] make[1]: *** [all-recursive] Error 1 [ 741s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 741s] dh_auto_build: make -j1 returned exit code 2 [ 741s] debian/rules:12: recipe for target 'build' failed [ 741s] make: *** [build] Error 2 [ 741s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 741s] ### VM INTERACTION START ### [ 744s] [ 675.512912] sysrq: Power Off [ 744s] [ 675.525054] reboot: Power down [ 744s] ### VM INTERACTION END ### [ 744s] [ 744s] obs-arm-2 failed "build osmo-pcu_0.8.0.289.398f.dsc" at Wed Dec 16 02:04:31 UTC 2020. [ 744s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-pcu in Debian_10/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/Debian_10/x86_64 Package network:osmocom:nightly/osmo-pcu failed to build in Debian_10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build log: [ 270s] gprs_bssgp_pcu.cpp:987:28: error: too few arguments to function 'gprs_ns2_nse* gprs_ns2_create_nse(gprs_ns2_inst*, uint16_t, gprs_ns2_ll, gprs_ns2_dialect)' [ 270s] GPRS_NS2_LL_UDP); [ 270s] ^ [ 270s] In file included from ./gprs_bssgp_pcu.h:31, [ 270s] from gprs_bssgp_pcu.cpp:22: [ 270s] /usr/include/osmocom/gprs/gprs_ns2.h:155:22: note: declared here [ 270s] struct gprs_ns2_nse *gprs_ns2_create_nse(struct gprs_ns2_inst *nsi, uint16_t nsei, [ 270s] ^~~ [ 270s] gprs_bssgp_pcu.cpp:1001:9: error: 'gprs_ns2_ip_connect_sns' was not declared in this scope [ 270s] rc = gprs_ns2_ip_connect_sns(bind[i], &remote[i], nsei); [ 270s] ^~~ [ 270s] gprs_bssgp_pcu.cpp:1001:9: note: suggested alternative: 'gprs_ns2_ip_connect2' [ 270s] rc = gprs_ns2_ip_connect_sns(bind[i], &remote[i], nsei); [ 270s] ^~~ [ 270s] gprs_ns2_ip_connect2 [ 270s] make[2]: *** [Makefile:835: gprs_bssgp_pcu.lo] Error 1 [ 270s] make[2]: Leaving directory '/usr/src/packages/BUILD/src' [ 270s] make[1]: *** [Makefile:417: all-recursive] Error 1 [ 270s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 270s] dh_auto_build: make -j1 returned exit code 2 [ 270s] make: *** [debian/rules:12: build] Error 2 [ 270s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 270s] ### VM INTERACTION START ### [ 273s] [ 258.913461] sysrq: Power Off [ 273s] [ 258.920245] reboot: Power down [ 273s] ### VM INTERACTION END ### [ 273s] [ 273s] lamb02 failed "build osmo-pcu_0.8.0.289.398f.dsc" at Wed Dec 16 01:57:31 UTC 2020. [ 273s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-pcu in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-pcu failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build log: [ 534s] /usr/include/osmocom/gprs/gprs_ns2.h:173:20: note: initializing argument 2 of 'int gprs_ns2_ip_bind(gprs_ns2_inst*, const char*, const osmo_sockaddr*, int, gprs_ns2_vc_bind**)' [ 534s] 173 |const char *name, [ 534s] |^~~~ [ 534s] gprs_bssgp_pcu.cpp:987:28: error: too few arguments to function 'gprs_ns2_nse* gprs_ns2_create_nse(gprs_ns2_inst*, uint16_t, gprs_ns2_ll, gprs_ns2_dialect)' [ 534s] 987 | GPRS_NS2_LL_UDP); [ 534s] |^ [ 534s] In file included from ./gprs_bssgp_pcu.h:31, [ 534s] from gprs_bssgp_pcu.cpp:22: [ 534s] /usr/include/osmocom/gprs/gprs_ns2.h:155:22: note: declared here [ 534s] 155 | struct gprs_ns2_nse *gprs_ns2_create_nse(struct gprs_ns2_inst *nsi, uint16_t nsei, [ 534s] | ^~~ [ 534s] gprs_bssgp_pcu.cpp:1001:9: error: 'gprs_ns2_ip_connect_sns' was not declared in this scope; did you mean 'gprs_ns2_ip_connect2'? [ 534s] 1001 |rc = gprs_ns2_ip_connect_sns(bind[i], &remote[i], nsei); [ 534s] | ^~~ [ 534s] | gprs_ns2_ip_connect2 [ 534s] make[2]: *** [Makefile:835: gprs_bssgp_pcu.lo] Error 1 [ 534s] make[2]: Leaving directory '/usr/src/packages/BUILD/src' [ 534s] make[1]: *** [Makefile:419: all-recursive] Error 1 [ 534s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 534s] dh_auto_build: error: make -j1 returned exit code 2 [ 534s] make: *** [debian/rules:12: build] Error 25 [ 534s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 534s] ### VM INTERACTION START ### [ 535s] Powering off. [ 535s] [ 499.650972] reboot: Power down [ 535s] ### VM INTERACTION END ### [ 535s] [ 535s] cloud125 failed "build osmo-pcu_0.8.0.289.398f.dsc" at Wed Dec 16 01:55:34 UTC 2020. [ 535s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-pcu in CentOS_8/aarch64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/CentOS_8/aarch64 Package network:osmocom:nightly/osmo-pcu failed to build in CentOS_8/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build log: [ 99s] ^ [ 99s] In file included from ./gprs_bssgp_pcu.h:31, [ 99s] from gprs_bssgp_pcu.cpp:22: [ 99s] /usr/include/libosmocore/osmocom/gprs/gprs_ns2.h:155:22: note: declared here [ 99s] struct gprs_ns2_nse *gprs_ns2_create_nse(struct gprs_ns2_inst *nsi, uint16_t nsei, [ 99s] ^~~ [ 99s] gprs_bssgp_pcu.cpp:1001:9: error: 'gprs_ns2_ip_connect_sns' was not declared in this scope [ 99s] rc = gprs_ns2_ip_connect_sns(bind[i], &remote[i], nsei); [ 99s] ^~~ [ 99s] gprs_bssgp_pcu.cpp:1001:9: note: suggested alternative: 'gprs_ns2_ip_connect2' [ 99s] rc = gprs_ns2_ip_connect_sns(bind[i], &remote[i], nsei); [ 99s] ^~~ [ 99s] gprs_ns2_ip_connect2 [ 99s] make[1]: *** [Makefile:834: gprs_bssgp_pcu.lo] Error 1 [ 99s] make[1]: *** Waiting for unfinished jobs [ 100s] make[1]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-pcu-0.8.0.289.398f/src' [ 100s] make: *** [Makefile:416: all-recursive] Error 1 [ 100s] error: Bad exit status from /var/tmp/rpm-tmp.iYtO1v (%build) [ 100s] [ 100s] [ 100s] RPM build errors: [ 100s] Bad exit status from /var/tmp/rpm-tmp.iYtO1v (%build) [ 100s] ### VM INTERACTION START ### [ 101s] Powering off. [ 101s] [ 84.305766] reboot: Power down [ 101s] ### VM INTERACTION END ### [ 101s] [ 101s] obs-arm-8 failed "build osmo-pcu.spec" at Wed Dec 16 01:48:22 UTC 2020. [ 101s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-pcu in Debian_9.0/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/Debian_9.0/x86_64 Package network:osmocom:nightly/osmo-pcu failed to build in Debian_9.0/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build log: [ 196s] ^ [ 196s] gprs_bssgp_pcu.cpp:987:28: error: too few arguments to function 'gprs_ns2_nse* gprs_ns2_create_nse(gprs_ns2_inst*, uint16_t, gprs_ns2_ll, gprs_ns2_dialect)' [ 196s] GPRS_NS2_LL_UDP); [ 196s] ^ [ 196s] In file included from ./gprs_bssgp_pcu.h:31:0, [ 196s] from gprs_bssgp_pcu.cpp:22: [ 196s] /usr/include/osmocom/gprs/gprs_ns2.h:155:22: note: declared here [ 196s] struct gprs_ns2_nse *gprs_ns2_create_nse(struct gprs_ns2_inst *nsi, uint16_t nsei, [ 196s] ^~~ [ 196s] gprs_bssgp_pcu.cpp:1001:58: error: 'gprs_ns2_ip_connect_sns' was not declared in this scope [ 196s] rc = gprs_ns2_ip_connect_sns(bind[i], &remote[i], nsei); [ 196s] ^ [ 196s] Makefile:802: recipe for target 'gprs_bssgp_pcu.lo' failed [ 196s] make[2]: *** [gprs_bssgp_pcu.lo] Error 1 [ 196s] make[2]: Leaving directory '/usr/src/packages/BUILD/src' [ 196s] Makefile:417: recipe for target 'all-recursive' failed [ 196s] make[1]: *** [all-recursive] Error 1 [ 196s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 196s] dh_auto_build: make -j1 returned exit code 2 [ 196s] debian/rules:12: recipe for target 'build' failed [ 196s] make: *** [build] Error 2 [ 196s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 196s] ### VM INTERACTION START ### [ 200s] [ 187.855503] sysrq: Power Off [ 200s] [ 187.862587] reboot: Power down [ 200s] ### VM INTERACTION END ### [ 200s] [ 200s] lamb28 failed "build osmo-pcu_0.8.0.289.398f.dsc" at Wed Dec 16 01:48:01 UTC 2020. [ 200s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-pcu in xUbuntu_19.04/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/xUbuntu_19.04/x86_64 Package network:osmocom:nightly/osmo-pcu failed to build in xUbuntu_19.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build log: [ 264s] gprs_bssgp_pcu.cpp:987:28: error: too few arguments to function 'gprs_ns2_nse* gprs_ns2_create_nse(gprs_ns2_inst*, uint16_t, gprs_ns2_ll, gprs_ns2_dialect)' [ 264s] GPRS_NS2_LL_UDP); [ 264s] ^ [ 264s] In file included from ./gprs_bssgp_pcu.h:31, [ 264s] from gprs_bssgp_pcu.cpp:22: [ 264s] /usr/include/osmocom/gprs/gprs_ns2.h:155:22: note: declared here [ 264s] struct gprs_ns2_nse *gprs_ns2_create_nse(struct gprs_ns2_inst *nsi, uint16_t nsei, [ 264s] ^~~ [ 264s] gprs_bssgp_pcu.cpp:1001:9: error: 'gprs_ns2_ip_connect_sns' was not declared in this scope [ 264s] rc = gprs_ns2_ip_connect_sns(bind[i], &remote[i], nsei); [ 264s] ^~~ [ 264s] gprs_bssgp_pcu.cpp:1001:9: note: suggested alternative: 'gprs_ns2_ip_connect2' [ 264s] rc = gprs_ns2_ip_connect_sns(bind[i], &remote[i], nsei); [ 264s] ^~~ [ 264s] gprs_ns2_ip_connect2 [ 264s] make[2]: *** [Makefile:835: gprs_bssgp_pcu.lo] Error 1 [ 264s] make[2]: Leaving directory '/usr/src/packages/BUILD/src' [ 264s] make[1]: *** [Makefile:417: all-recursive] Error 1 [ 264s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 264s] dh_auto_build: make -j1 returned exit code 2 [ 265s] make: *** [debian/rules:12: build] Error 2 [ 265s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 265s] ### VM INTERACTION START ### [ 268s] [ 255.895574] sysrq: Power Off [ 268s] [ 255.902683] reboot: Power down [ 268s] ### VM INTERACTION END ### [ 268s] [ 268s] lamb12 failed "build osmo-pcu_0.8.0.289.398f.dsc" at Wed Dec 16 01:46:52 UTC 2020. [ 268s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-pcu in xUbuntu_20.04/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/xUbuntu_20.04/x86_64 Package network:osmocom:nightly/osmo-pcu failed to build in xUbuntu_20.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build log: [ 344s] /usr/include/osmocom/gprs/gprs_ns2.h:173:20: note: initializing argument 2 of 'int gprs_ns2_ip_bind(gprs_ns2_inst*, const char*, const osmo_sockaddr*, int, gprs_ns2_vc_bind**)' [ 344s] 173 |const char *name, [ 344s] |^~~~ [ 344s] gprs_bssgp_pcu.cpp:987:28: error: too few arguments to function 'gprs_ns2_nse* gprs_ns2_create_nse(gprs_ns2_inst*, uint16_t, gprs_ns2_ll, gprs_ns2_dialect)' [ 344s] 987 | GPRS_NS2_LL_UDP); [ 344s] |^ [ 344s] In file included from ./gprs_bssgp_pcu.h:31, [ 344s] from gprs_bssgp_pcu.cpp:22: [ 344s] /usr/include/osmocom/gprs/gprs_ns2.h:155:22: note: declared here [ 344s] 155 | struct gprs_ns2_nse *gprs_ns2_create_nse(struct gprs_ns2_inst *nsi, uint16_t nsei, [ 344s] | ^~~ [ 344s] gprs_bssgp_pcu.cpp:1001:9: error: 'gprs_ns2_ip_connect_sns' was not declared in this scope; did you mean 'gprs_ns2_ip_connect2'? [ 344s] 1001 |rc = gprs_ns2_ip_connect_sns(bind[i], &remote[i], nsei); [ 344s] | ^~~ [ 344s] | gprs_ns2_ip_connect2 [ 344s] make[2]: *** [Makefile:835: gprs_bssgp_pcu.lo] Error 1 [ 344s] make[2]: Leaving directory '/usr/src/packages/BUILD/src' [ 344s] make[1]: *** [Makefile:417: all-recursive] Error 1 [ 344s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 344s] dh_auto_build: error: make -j1 returned exit code 2 [ 344s] make: *** [debian/rules:12: build] Error 25 [ 344s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 344s] ### VM INTERACTION START ### [ 347s] [ 333.371447] sysrq: Power Off [ 347s] [ 333.378052] reboot: Power down [ 347s] ### VM INTERACTION END ### [ 347s] [ 347s] lamb19 failed "build osmo-pcu_0.8.0.289.398f.dsc" at Wed Dec 16 01:46:14 UTC 2020. [ 347s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-pcu in openSUSE_Leap_15.1_ARM/aarch64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/openSUSE_Leap_15.1_ARM/aarch64 Package network:osmocom:nightly/osmo-pcu failed to build in openSUSE_Leap_15.1_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build log: [ 56s] ^ [ 56s] In file included from ./gprs_bssgp_pcu.h:31:0, [ 56s] from gprs_bssgp_pcu.cpp:22: [ 56s] /usr/include/libosmocore/osmocom/gprs/gprs_ns2.h:155:22: note: declared here [ 56s] struct gprs_ns2_nse *gprs_ns2_create_nse(struct gprs_ns2_inst *nsi, uint16_t nsei, [ 56s] ^~~ [ 56s] gprs_bssgp_pcu.cpp:1001:9: error: 'gprs_ns2_ip_connect_sns' was not declared in this scope [ 56s] rc = gprs_ns2_ip_connect_sns(bind[i], &remote[i], nsei); [ 56s] ^~~ [ 56s] gprs_bssgp_pcu.cpp:1001:9: note: suggested alternative: 'gprs_ns2_ip_connect2' [ 56s] rc = gprs_ns2_ip_connect_sns(bind[i], &remote[i], nsei); [ 56s] ^~~ [ 56s] gprs_ns2_ip_connect2 [ 56s] make[1]: *** [Makefile:801: gprs_bssgp_pcu.lo] Error 1 [ 56s] make[1]: *** Waiting for unfinished jobs [ 57s] make[1]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-pcu-0.8.0.289.398f/src' [ 57s] make: *** [Makefile:416: all-recursive] Error 1 [ 57s] error: Bad exit status from /var/tmp/rpm-tmp.UklqQS (%build) [ 57s] [ 57s] [ 57s] RPM build errors: [ 57s] Bad exit status from /var/tmp/rpm-tmp.UklqQS (%build) [ 57s] ### VM INTERACTION START ### [ 60s] [ 49.706517] sysrq: SysRq : Power Off [ 60s] [ 49.707986] reboot: Power down [ 60s] ### VM INTERACTION END ### [ 60s] [ 60s] obs-arm-9 failed "build osmo-pcu.spec" at Wed Dec 16 01:46:16 UTC 2020. [ 60s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-pcu in xUbuntu_18.04/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/xUbuntu_18.04/x86_64 Package network:osmocom:nightly/osmo-pcu failed to build in xUbuntu_18.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build log: [ 247s] In file included from ./gprs_bssgp_pcu.h:31:0, [ 247s] from gprs_bssgp_pcu.cpp:22: [ 247s] /usr/include/osmocom/gprs/gprs_ns2.h:155:22: note: declared here [ 247s] struct gprs_ns2_nse *gprs_ns2_create_nse(struct gprs_ns2_inst *nsi, uint16_t nsei, [ 247s] ^~~ [ 247s] gprs_bssgp_pcu.cpp:1001:9: error: 'gprs_ns2_ip_connect_sns' was not declared in this scope [ 247s] rc = gprs_ns2_ip_connect_sns(bind[i], &remote[i], nsei); [ 247s] ^~~ [ 247s] gprs_bssgp_pcu.cpp:1001:9: note: suggested alternative: 'gprs_ns2_ip_connect2' [ 247s] rc = gprs_ns2_ip_connect_sns(bind[i], &remote[i], nsei); [ 247s] ^~~ [ 247s] gprs_ns2_ip_connect2 [ 247s] Makefile:802: recipe for target 'gprs_bssgp_pcu.lo' failed [ 247s] make[2]: *** [gprs_bssgp_pcu.lo] Error 1 [ 247s] make[2]: Leaving directory '/usr/src/packages/BUILD/src' [ 247s] Makefile:417: recipe for target 'all-recursive' failed [ 247s] make[1]: *** [all-recursive] Error 1 [ 247s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 247s] dh_auto_build: make -j1 returned exit code 2 [ 247s] debian/rules:12: recipe for target 'build' failed [ 247s] make: *** [build] Error 2 [ 247s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 247s] ### VM INTERACTION START ### [ 251s] [ 239.382116] sysrq: Power Off [ 251s] [ 239.389618] reboot: Power down [ 251s] ### VM INTERACTION END ### [ 251s] [ 251s] lamb64 failed "build osmo-pcu_0.8.0.289.398f.dsc" at Wed Dec 16 01:45:55 UTC 2020. [ 251s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-pcu in Debian_8.0/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/Debian_8.0/x86_64 Package network:osmocom:nightly/osmo-pcu failed to build in Debian_8.0/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build log: [ 164s] ^ [ 164s] gprs_bssgp_pcu.cpp:987:28: error: too few arguments to function 'gprs_ns2_nse* gprs_ns2_create_nse(gprs_ns2_inst*, uint16_t, gprs_ns2_ll, gprs_ns2_dialect)' [ 164s] GPRS_NS2_LL_UDP); [ 164s] ^ [ 164s] In file included from ./gprs_bssgp_pcu.h:31:0, [ 164s] from gprs_bssgp_pcu.cpp:22: [ 164s] /usr/include/osmocom/gprs/gprs_ns2.h:155:22: note: declared here [ 164s] struct gprs_ns2_nse *gprs_ns2_create_nse(struct gprs_ns2_inst *nsi, uint16_t nsei, [ 164s] ^ [ 164s] gprs_bssgp_pcu.cpp:1001:58: error: 'gprs_ns2_ip_connect_sns' was not declared in this scope [ 164s] rc = gprs_ns2_ip_connect_sns(bind[i], &remote[i], nsei); [ 164s] ^ [ 164s] Makefile:790: recipe for target 'gprs_bssgp_pcu.lo' failed [ 164s] make[2]: *** [gprs_bssgp_pcu.lo] Error 1 [ 164s] make[2]: Leaving directory '/usr/src/packages/BUILD/src' [ 164s] Makefile:405: recipe for target 'all-recursive' failed [ 164s] make[1]: *** [all-recursive] Error 1 [ 164s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 164s] dh_auto_build: make -j1 returned exit code 2 [ 164s] debian/rules:12: recipe for target 'build' failed [ 164s] make: *** [build] Error 2 [ 164s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 164s] ### VM INTERACTION START ### [ 165s] Powering off. [ 165s] [ 156.163893] reboot: Power down [ 166s] ### VM INTERACTION END ### [ 166s] [ 166s] lamb07 failed "build osmo-pcu_0.8.0.289.398f.dsc" at Wed Dec 16 01:45:39 UTC 2020. [ 166s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-pcu in xUbuntu_19.10/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/xUbuntu_19.10/x86_64 Package network:osmocom:nightly/osmo-pcu failed to build in xUbuntu_19.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build log: [ 201s] /usr/include/osmocom/gprs/gprs_ns2.h:173:20: note: initializing argument 2 of 'int gprs_ns2_ip_bind(gprs_ns2_inst*, const char*, const osmo_sockaddr*, int, gprs_ns2_vc_bind**)' [ 201s] 173 |const char *name, [ 201s] |^~~~ [ 201s] gprs_bssgp_pcu.cpp:987:28: error: too few arguments to function 'gprs_ns2_nse* gprs_ns2_create_nse(gprs_ns2_inst*, uint16_t, gprs_ns2_ll, gprs_ns2_dialect)' [ 201s] 987 | GPRS_NS2_LL_UDP); [ 201s] |^ [ 201s] In file included from ./gprs_bssgp_pcu.h:31, [ 201s] from gprs_bssgp_pcu.cpp:22: [ 201s] /usr/include/osmocom/gprs/gprs_ns2.h:155:22: note: declared here [ 201s] 155 | struct gprs_ns2_nse *gprs_ns2_create_nse(struct gprs_ns2_inst *nsi, uint16_t nsei, [ 201s] | ^~~ [ 201s] gprs_bssgp_pcu.cpp:1001:9: error: 'gprs_ns2_ip_connect_sns' was not declared in this scope; did you mean 'gprs_ns2_ip_connect2'? [ 201s] 1001 |rc = gprs_ns2_ip_connect_sns(bind[i], &remote[i], nsei); [ 201s] | ^~~ [ 201s] | gprs_ns2_ip_connect2 [ 201s] make[2]: *** [Makefile:835: gprs_bssgp_pcu.lo] Error 1 [ 201s] make[2]: Leaving directory '/usr/src/packages/BUILD/src' [ 201s] make[1]: *** [Makefile:417: all-recursive] Error 1 [ 201s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 201s] dh_auto_build: make -j1 returned exit code 2 [ 201s] make: *** [debian/rules:12: build] Error 255 [ 201s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 201s] ### VM INTERACTION START ### [ 204s] [ 194.217754] sysrq: Power Off [ 204s] [ 194.221980] reboot: Power down [ 204s] ### VM INTERACTION END ### [ 204s] [ 204s] sheep85 failed "build osmo-pcu_0.8.0.289.398f.dsc" at Wed Dec 16 01:45:30 UTC 2020. [ 204s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-pcu in CentOS_8/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/CentOS_8/x86_64 Package network:osmocom:nightly/osmo-pcu failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build log: [ 106s] from gprs_bssgp_pcu.cpp:22: [ 106s] /usr/include/libosmocore/osmocom/gprs/gprs_ns2.h:155:22: note: declared here [ 106s] struct gprs_ns2_nse *gprs_ns2_create_nse(struct gprs_ns2_inst *nsi, uint16_t nsei, [ 106s] ^~~ [ 106s] gprs_bssgp_pcu.cpp:1001:9: error: 'gprs_ns2_ip_connect_sns' was not declared in this scope [ 106s] rc = gprs_ns2_ip_connect_sns(bind[i], &remote[i], nsei); [ 106s] ^~~ [ 106s] CXX gprs_ms_storage.lo [ 106s] gprs_bssgp_pcu.cpp:1001:9: note: suggested alternative: 'gprs_ns2_ip_connect2' [ 106s] rc = gprs_ns2_ip_connect_sns(bind[i], &remote[i], nsei); [ 106s] ^~~ [ 106s] gprs_ns2_ip_connect2 [ 106s] CXX gsm_timer.lo [ 106s] make[1]: *** [Makefile:834: gprs_bssgp_pcu.lo] Error 1 [ 106s] make[1]: *** Waiting for unfinished jobs [ 108s] make[1]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-pcu-0.8.0.289.398f/src' [ 108s] make: *** [Makefile:416: all-recursive] Error 1 [ 108s] error: Bad exit status from /var/tmp/rpm-tmp.ls7zfW (%build) [ 108s] [ 108s] [ 108s] RPM build errors: [ 108s] Bad exit status from /var/tmp/rpm-tmp.ls7zfW (%build) [ 108s] ### VM INTERACTION START ### [ 109s] Powering off. [ 109s] [ 95.677718] reboot: Power down [ 109s] ### VM INTERACTION END ### [ 109s] [ 109s] lamb55 failed "build osmo-pcu.spec" at Wed Dec 16 01:45:19 UTC 2020. [ 109s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-pcu in xUbuntu_20.10/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/xUbuntu_20.10/x86_64 Package network:osmocom:nightly/osmo-pcu failed to build in xUbuntu_20.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build log: [ 267s] /usr/include/osmocom/gprs/gprs_ns2.h:173:20: note: initializing argument 2 of 'int gprs_ns2_ip_bind(gprs_ns2_inst*, const char*, const osmo_sockaddr*, int, gprs_ns2_vc_bind**)' [ 267s] 173 |const char *name, [ 267s] |^~~~ [ 267s] gprs_bssgp_pcu.cpp:987:28: error: too few arguments to function 'gprs_ns2_nse* gprs_ns2_create_nse(gprs_ns2_inst*, uint16_t, gprs_ns2_ll, gprs_ns2_dialect)' [ 267s] 987 | GPRS_NS2_LL_UDP); [ 267s] |^ [ 267s] In file included from ./gprs_bssgp_pcu.h:31, [ 267s] from gprs_bssgp_pcu.cpp:22: [ 267s] /usr/include/osmocom/gprs/gprs_ns2.h:155:22: note: declared here [ 267s] 155 | struct gprs_ns2_nse *gprs_ns2_create_nse(struct gprs_ns2_inst *nsi, uint16_t nsei, [ 267s] | ^~~ [ 267s] gprs_bssgp_pcu.cpp:1001:9: error: 'gprs_ns2_ip_connect_sns' was not declared in this scope; did you mean 'gprs_ns2_ip_connect2'? [ 267s] 1001 |rc = gprs_ns2_ip_connect_sns(bind[i], &remote[i], nsei); [ 267s] | ^~~ [ 267s] | gprs_ns2_ip_connect2 [ 267s] make[2]: *** [Makefile:835: gprs_bssgp_pcu.lo] Error 1 [ 267s] make[2]: Leaving directory '/usr/src/packages/BUILD/src' [ 267s] make[1]: *** [Makefile:417: all-recursive] Error 1 [ 267s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 267s] dh_auto_build: error: make -j1 returned exit code 2 [ 267s] make: *** [debian/rules:12: build] Error 25 [ 267s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 267s] ### VM INTERACTION START ### [ 268s] Powering off. [ 268s] [ 260.306810] reboot: Power down [ 268s] ### VM INTERACTION END ### [ 268s] [ 268s] goat03 failed "build osmo-pcu_0.8.0.289.398f.dsc" at Wed Dec 16 01:44:40 UTC 2020. [ 268s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-pcu in openSUSE_Factory_ARM/aarch64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/openSUSE_Factory_ARM/aarch64 Package network:osmocom:nightly/osmo-pcu failed to build in openSUSE_Factory_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build log: [ 54s] |^~~~ [ 54s] gprs_bssgp_pcu.cpp:987:28: error: too few arguments to function 'gprs_ns2_nse* gprs_ns2_create_nse(gprs_ns2_inst*, uint16_t, gprs_ns2_ll, gprs_ns2_dialect)' [ 54s] 987 | GPRS_NS2_LL_UDP); [ 54s] |^ [ 54s] In file included from ./gprs_bssgp_pcu.h:31, [ 54s] from gprs_bssgp_pcu.cpp:22: [ 54s] /usr/include/libosmocore/osmocom/gprs/gprs_ns2.h:155:22: note: declared here [ 54s] 155 | struct gprs_ns2_nse *gprs_ns2_create_nse(struct gprs_ns2_inst *nsi, uint16_t nsei, [ 54s] | ^~~ [ 54s] gprs_bssgp_pcu.cpp:1001:9: error: 'gprs_ns2_ip_connect_sns' was not declared in this scope; did you mean 'gprs_ns2_ip_connect2'? [ 54s] 1001 |rc = gprs_ns2_ip_connect_sns(bind[i], &remote[i], nsei); [ 54s] | ^~~ [ 54s] | gprs_ns2_ip_connect2 [ 54s] make[1]: *** [Makefile:834: gprs_bssgp_pcu.lo] Error 1 [ 54s] make[1]: *** Waiting for unfinished jobs [ 54s] make[1]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-pcu-0.8.0.289.398f/src' [ 54s] make: *** [Makefile:416: all-recursive] Error 1 [ 54s] error: Bad exit status from /var/tmp/rpm-tmp.VecZkN (%build) [ 54s] [ 54s] [ 54s] RPM build errors: [ 54s] Bad exit status from /var/tmp/rpm-tmp.VecZkN (%build) [ 55s] ### VM INTERACTION START ### [ 58s] [ 44.064523] sysrq: Power Off [ 58s] [ 44.066454] reboot: Power down [ 58s] ### VM INTERACTION END ### [ 58s] [ 58s] obs-arm-8 failed "build osmo-pcu.spec" at Wed Dec 16 01:42:35 UTC 2020. [ 58s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_20.04/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_20.04/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_20.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 230s] [COMPILING libboard/qmod/source/wwan_perst.c] [ 230s] [COMPILING libboard/qmod/source/card_pres.c] [ 230s] [COMPILING libboard/qmod/source/wwan_led.c] [ 230s] [COMPILING libboard/qmod/source/i2c.c] [ 230s] [COMPILING libboard/qmod/source/board_qmod.c] [ 230s] [COMPILING apps/dfu/main.c] [ 231s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu.c] [ 231s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_desc.c] [ 231s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_driver.c] [ 231s] Memory region Used Size Region Size %age Used [ 231s] rom: 16588 B16 KB101.25% [ 231s] ram: 11672 B48 KB 23.75/usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: bin/qmod-dfu-flash.elf section `.text' will not fit in region `rom' [ 231s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: region `rom' overflowed by 204 bytes [ 231s] collect2: error: ld returned 1 exit status [ 231s] % [ 231s] make[2]: *** [Makefile:234: flash] Error 1 [ 231s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 231s] make[1]: *** [Makefile:13: fw-qmod-dfu] Error 2 [ 231s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 231s] dh_auto_build: error: make -j1 returned exit code 2 [ 231s] make: *** [debian/rules:16: build] Error 25 [ 231s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 231s] ### VM INTERACTION START ### [ 234s] [ 188.257103] sysrq: Power Off [ 234s] [ 188.264081] reboot: Power down [ 234s] ### VM INTERACTION END ### [ 234s] [ 234s] cloud105 failed "build simtrace2_0.7.0.69.aadd.dsc" at Wed Dec 16 01:42:13 UTC 2020. [ 234s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-pcu in openSUSE_Leap_15.1/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/openSUSE_Leap_15.1/x86_64 Package network:osmocom:nightly/osmo-pcu failed to build in openSUSE_Leap_15.1/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build log: [ 35s] ^ [ 35s] In file included from ./gprs_bssgp_pcu.h:31:0, [ 35s] from gprs_bssgp_pcu.cpp:22: [ 35s] /usr/include/libosmocore/osmocom/gprs/gprs_ns2.h:155:22: note: declared here [ 35s] struct gprs_ns2_nse *gprs_ns2_create_nse(struct gprs_ns2_inst *nsi, uint16_t nsei, [ 35s] ^~~ [ 35s] gprs_bssgp_pcu.cpp:1001:9: error: 'gprs_ns2_ip_connect_sns' was not declared in this scope [ 35s] rc = gprs_ns2_ip_connect_sns(bind[i], &remote[i], nsei); [ 35s] ^~~ [ 35s] gprs_bssgp_pcu.cpp:1001:9: note: suggested alternative: 'gprs_ns2_ip_connect2' [ 35s] rc = gprs_ns2_ip_connect_sns(bind[i], &remote[i], nsei); [ 35s] ^~~ [ 35s] gprs_ns2_ip_connect2 [ 35s] make[1]: *** [Makefile:801: gprs_bssgp_pcu.lo] Error 1 [ 35s] make[1]: *** Waiting for unfinished jobs [ 36s] make[1]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-pcu-0.8.0.289.398f/src' [ 36s] make: *** [Makefile:416: all-recursive] Error 1 [ 36s] error: Bad exit status from /var/tmp/rpm-tmp.gjwXvz (%build) [ 36s] [ 36s] [ 36s] RPM build errors: [ 36s] Bad exit status from /var/tmp/rpm-tmp.gjwXvz (%build) [ 36s] ### VM INTERACTION START ### [ 39s] [ 33.003658] sysrq: SysRq : Power Off [ 39s] [ 33.010139] reboot: Power down [ 39s] ### VM INTERACTION END ### [ 39s] [ 39s] goat15 failed "build osmo-pcu.spec" at Wed Dec 16 01:42:01 UTC 2020. [ 39s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-pcu in Debian_10/i586
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/Debian_10/i586 Package network:osmocom:nightly/osmo-pcu failed to build in Debian_10/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build log: [ 290s] gprs_bssgp_pcu.cpp:987:28: error: too few arguments to function 'gprs_ns2_nse* gprs_ns2_create_nse(gprs_ns2_inst*, uint16_t, gprs_ns2_ll, gprs_ns2_dialect)' [ 290s] GPRS_NS2_LL_UDP); [ 290s] ^ [ 290s] In file included from ./gprs_bssgp_pcu.h:31, [ 290s] from gprs_bssgp_pcu.cpp:22: [ 290s] /usr/include/osmocom/gprs/gprs_ns2.h:155:22: note: declared here [ 290s] struct gprs_ns2_nse *gprs_ns2_create_nse(struct gprs_ns2_inst *nsi, uint16_t nsei, [ 290s] ^~~ [ 290s] gprs_bssgp_pcu.cpp:1001:9: error: 'gprs_ns2_ip_connect_sns' was not declared in this scope [ 290s] rc = gprs_ns2_ip_connect_sns(bind[i], &remote[i], nsei); [ 290s] ^~~ [ 290s] gprs_bssgp_pcu.cpp:1001:9: note: suggested alternative: 'gprs_ns2_ip_connect2' [ 290s] rc = gprs_ns2_ip_connect_sns(bind[i], &remote[i], nsei); [ 290s] ^~~ [ 290s] gprs_ns2_ip_connect2 [ 290s] make[2]: *** [Makefile:835: gprs_bssgp_pcu.lo] Error 1 [ 290s] make[2]: Leaving directory '/usr/src/packages/BUILD/src' [ 290s] make[1]: *** [Makefile:417: all-recursive] Error 1 [ 290s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 290s] dh_auto_build: make -j1 returned exit code 2 [ 290s] make: *** [debian/rules:12: build] Error 2 [ 290s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 290s] ### VM INTERACTION START ### [ 293s] [ 279.398531] sysrq: Power Off [ 293s] [ 279.405320] reboot: Power down [ 293s] ### VM INTERACTION END ### [ 293s] [ 293s] lamb03 failed "build osmo-pcu_0.8.0.289.398f.dsc" at Wed Dec 16 01:42:02 UTC 2020. [ 293s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-pcu in openSUSE_Leap_15.2/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/openSUSE_Leap_15.2/x86_64 Package network:osmocom:nightly/osmo-pcu failed to build in openSUSE_Leap_15.2/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build log: [ 42s] In file included from ./gprs_bssgp_pcu.h:31:0, [ 42s] from gprs_bssgp_pcu.cpp:22: [ 42s] /usr/include/libosmocore/osmocom/gprs/gprs_ns2.h:155:22: note: declared here [ 42s] struct gprs_ns2_nse *gprs_ns2_create_nse(struct gprs_ns2_inst *nsi, uint16_t nsei, [ 42s] ^~~ [ 42s] gprs_bssgp_pcu.cpp:1001:9: error: 'gprs_ns2_ip_connect_sns' was not declared in this scope [ 42s] rc = gprs_ns2_ip_connect_sns(bind[i], &remote[i], nsei); [ 42s] ^~~ [ 42s] CXX gprs_rlcmac_ts_alloc.lo [ 42s] gprs_bssgp_pcu.cpp:1001:9: note: suggested alternative: 'gprs_ns2_ip_connect2' [ 42s] rc = gprs_ns2_ip_connect_sns(bind[i], &remote[i], nsei); [ 42s] ^~~ [ 42s] gprs_ns2_ip_connect2 [ 42s] make[1]: *** [Makefile:801: gprs_bssgp_pcu.lo] Error 1 [ 42s] make[1]: *** Waiting for unfinished jobs [ 43s] make[1]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-pcu-0.8.0.289.398f/src' [ 43s] make: *** [Makefile:416: all-recursive] Error 1 [ 43s] error: Bad exit status from /var/tmp/rpm-tmp.6rp3pI (%build) [ 43s] [ 43s] [ 43s] RPM build errors: [ 43s] Bad exit status from /var/tmp/rpm-tmp.6rp3pI (%build) [ 43s] ### VM INTERACTION START ### [ 46s] [ 39.333720] sysrq: Power Off [ 46s] [ 39.338118] reboot: Power down [ 46s] ### VM INTERACTION END ### [ 46s] [ 46s] sheep88 failed "build osmo-pcu.spec" at Wed Dec 16 01:41:23 UTC 2020. [ 46s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-pcu in openSUSE_Tumbleweed/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/openSUSE_Tumbleweed/x86_64 Package network:osmocom:nightly/osmo-pcu failed to build in openSUSE_Tumbleweed/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build log: [ 44s] gprs_bssgp_pcu.cpp:987:28: error: too few arguments to function 'gprs_ns2_nse* gprs_ns2_create_nse(gprs_ns2_inst*, uint16_t, gprs_ns2_ll, gprs_ns2_dialect)' [ 44s] 987 | GPRS_NS2_LL_UDP); [ 44s] |^ [ 44s] In file included from ./gprs_bssgp_pcu.h:31, [ 44s] from gprs_bssgp_pcu.cpp:22: [ 44s] /usr/include/libosmocore/osmocom/gprs/gprs_ns2.h:155:22: note: declared here [ 44s] 155 | struct gprs_ns2_nse *gprs_ns2_create_nse(struct gprs_ns2_inst *nsi, uint16_t nsei, [ 44s] | ^~~ [ 44s] gprs_bssgp_pcu.cpp:1001:9: error: 'gprs_ns2_ip_connect_sns' was not declared in this scope; did you mean 'gprs_ns2_ip_connect2'? [ 44s] 1001 |rc = gprs_ns2_ip_connect_sns(bind[i], &remote[i], nsei); [ 44s] | ^~~ [ 44s] | gprs_ns2_ip_connect2 [ 44s] CXX gsm_timer.lo [ 44s] make[1]: *** [Makefile:834: gprs_bssgp_pcu.lo] Error 1 [ 44s] make[1]: *** Waiting for unfinished jobs [ 45s] make[1]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-pcu-0.8.0.289.398f/src' [ 45s] make: *** [Makefile:416: all-recursive] Error 1 [ 45s] error: Bad exit status from /var/tmp/rpm-tmp.C02Lp0 (%build) [ 45s] [ 45s] [ 45s] RPM build errors: [ 45s] Bad exit status from /var/tmp/rpm-tmp.C02Lp0 (%build) [ 45s] ### VM INTERACTION START ### [ 48s] [ 41.540194] sysrq: Power Off [ 48s] [ 41.546870] reboot: Power down [ 49s] ### VM INTERACTION END ### [ 49s] [ 49s] lamb51 failed "build osmo-pcu.spec" at Wed Dec 16 01:40:53 UTC 2020. [ 49s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_20.10/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_20.10/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_20.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 155s] [COMPILING apps/dfu/main.c] [ 155s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu.c] [ 155s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_desc.c] [ 156s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_driver.c] [ 156s] Memory region Used Size Region Size %age Used [ 156s] rom: 16580 B16 KB101.20% [ 156s] ram: 11672 B48 KB 23.75/usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 156s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 156s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: bin/qmod-dfu-flash.elf section `.text' will not fit in region `rom' [ 156s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 156s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 156s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: warning: changing start of section .stack by 4 bytes [ 156s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: region `rom' overflowed by 196 bytes [ 156s] collect2: error: ld returned 1 exit status [ 156s] % [ 156s] make[2]: *** [Makefile:234: flash] Error 1 [ 156s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware' [ 156s] make[1]: *** [Makefile:13: fw-qmod-dfu] Error 2 [ 156s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 156s] dh_auto_build: error: make -j1 returned exit code 2 [ 156s] make: *** [debian/rules:16: build] Error 25 [ 156s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 156s] ### VM INTERACTION START ### [ 159s] [ 144.939329] sysrq: Power Off [ 159s] [ 144.943455] reboot: Power down [ 159s] ### VM INTERACTION END ### [ 159s] [ 159s] cloud116 failed "build simtrace2_0.7.0.69.aadd.dsc" at Wed Dec 16 01:40:39 UTC 2020. [ 159s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-pcu in Debian_8.0/i586
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/Debian_8.0/i586 Package network:osmocom:nightly/osmo-pcu failed to build in Debian_8.0/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build log: [ 166s] ^ [ 166s] gprs_bssgp_pcu.cpp:987:28: error: too few arguments to function 'gprs_ns2_nse* gprs_ns2_create_nse(gprs_ns2_inst*, uint16_t, gprs_ns2_ll, gprs_ns2_dialect)' [ 166s] GPRS_NS2_LL_UDP); [ 166s] ^ [ 166s] In file included from ./gprs_bssgp_pcu.h:31:0, [ 166s] from gprs_bssgp_pcu.cpp:22: [ 166s] /usr/include/osmocom/gprs/gprs_ns2.h:155:22: note: declared here [ 166s] struct gprs_ns2_nse *gprs_ns2_create_nse(struct gprs_ns2_inst *nsi, uint16_t nsei, [ 166s] ^ [ 166s] gprs_bssgp_pcu.cpp:1001:58: error: 'gprs_ns2_ip_connect_sns' was not declared in this scope [ 166s] rc = gprs_ns2_ip_connect_sns(bind[i], &remote[i], nsei); [ 166s] ^ [ 166s] Makefile:790: recipe for target 'gprs_bssgp_pcu.lo' failed [ 166s] make[2]: *** [gprs_bssgp_pcu.lo] Error 1 [ 166s] make[2]: Leaving directory '/usr/src/packages/BUILD/src' [ 166s] Makefile:405: recipe for target 'all-recursive' failed [ 166s] make[1]: *** [all-recursive] Error 1 [ 166s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 166s] dh_auto_build: make -j1 returned exit code 2 [ 166s] debian/rules:12: recipe for target 'build' failed [ 166s] make: *** [build] Error 2 [ 166s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 166s] ### VM INTERACTION START ### [ 168s] Powering off. [ 168s] [ 157.833186] reboot: Power down [ 168s] ### VM INTERACTION END ### [ 168s] [ 168s] lamb27 failed "build osmo-pcu_0.8.0.289.398f.dsc" at Wed Dec 16 01:39:41 UTC 2020. [ 168s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-pcu in Debian_9.0/i586
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/Debian_9.0/i586 Package network:osmocom:nightly/osmo-pcu failed to build in Debian_9.0/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build log: [ 187s] ^ [ 187s] gprs_bssgp_pcu.cpp:987:28: error: too few arguments to function 'gprs_ns2_nse* gprs_ns2_create_nse(gprs_ns2_inst*, uint16_t, gprs_ns2_ll, gprs_ns2_dialect)' [ 187s] GPRS_NS2_LL_UDP); [ 187s] ^ [ 187s] In file included from ./gprs_bssgp_pcu.h:31:0, [ 187s] from gprs_bssgp_pcu.cpp:22: [ 187s] /usr/include/osmocom/gprs/gprs_ns2.h:155:22: note: declared here [ 187s] struct gprs_ns2_nse *gprs_ns2_create_nse(struct gprs_ns2_inst *nsi, uint16_t nsei, [ 187s] ^~~ [ 187s] gprs_bssgp_pcu.cpp:1001:58: error: 'gprs_ns2_ip_connect_sns' was not declared in this scope [ 187s] rc = gprs_ns2_ip_connect_sns(bind[i], &remote[i], nsei); [ 187s] ^ [ 187s] Makefile:802: recipe for target 'gprs_bssgp_pcu.lo' failed [ 187s] make[2]: *** [gprs_bssgp_pcu.lo] Error 1 [ 187s] make[2]: Leaving directory '/usr/src/packages/BUILD/src' [ 187s] Makefile:417: recipe for target 'all-recursive' failed [ 187s] make[1]: *** [all-recursive] Error 1 [ 187s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 187s] dh_auto_build: make -j1 returned exit code 2 [ 187s] debian/rules:12: recipe for target 'build' failed [ 187s] make: *** [build] Error 2 [ 187s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 187s] ### VM INTERACTION START ### [ 190s] [ 179.881375] sysrq: Power Off [ 190s] [ 179.883774] reboot: Power down [ 190s] ### VM INTERACTION END ### [ 190s] [ 190s] old-atreju2 failed "build osmo-pcu_0.8.0.289.398f.dsc" at Wed Dec 16 01:39:37 UTC 2020. [ 190s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-pcu in openSUSE_Tumbleweed/i586
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/openSUSE_Tumbleweed/i586 Package network:osmocom:nightly/osmo-pcu failed to build in openSUSE_Tumbleweed/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build log: [ 55s] 987 | GPRS_NS2_LL_UDP); [ 55s] |^ [ 55s] In file included from ./gprs_bssgp_pcu.h:31, [ 55s] from gprs_bssgp_pcu.cpp:22: [ 55s] /usr/include/libosmocore/osmocom/gprs/gprs_ns2.h:155:22: note: declared here [ 55s] 155 | struct gprs_ns2_nse *gprs_ns2_create_nse(struct gprs_ns2_inst *nsi, uint16_t nsei, [ 55s] | ^~~ [ 55s] CXX gsm_timer.lo [ 55s] gprs_bssgp_pcu.cpp:1001:9: error: 'gprs_ns2_ip_connect_sns' was not declared in this scope; did you mean 'gprs_ns2_ip_connect2'? [ 55s] 1001 |rc = gprs_ns2_ip_connect_sns(bind[i], &remote[i], nsei); [ 55s] | ^~~ [ 55s] | gprs_ns2_ip_connect2 [ 55s] CXX pcu_l1_if.lo [ 55s] make[1]: *** [Makefile:834: gprs_bssgp_pcu.lo] Error 1 [ 55s] make[1]: *** Waiting for unfinished jobs [ 57s] make[1]: Leaving directory '/home/abuild/rpmbuild/BUILD/osmo-pcu-0.8.0.289.398f/src' [ 57s] make: *** [Makefile:416: all-recursive] Error 1 [ 57s] error: Bad exit status from /var/tmp/rpm-tmp.pdmHWZ (%build) [ 57s] [ 57s] [ 57s] RPM build errors: [ 57s] Bad exit status from /var/tmp/rpm-tmp.pdmHWZ (%build) [ 57s] ### VM INTERACTION START ### [ 60s] [ 51.349028] sysrq: Power Off [ 60s] [ 51.429958] reboot: Power down [ 60s] ### VM INTERACTION END ### [ 60s] [ 60s] lamb09 failed "build osmo-pcu.spec" at Wed Dec 16 01:36:11 UTC 2020. [ 60s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Change in osmo-pcu[master]: ns2: follow ns2 dialect changes
Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/21728 to look at the new patch set (#3). Change subject: ns2: follow ns2 dialect changes .. ns2: follow ns2 dialect changes NS2 introduce a ns dialect to differentiate between the 4 possible dialects. Change-Id: I16dc82c38eb75c2b9d1197640a955fec7df84efc --- M src/bts.h M src/gprs_bssgp_pcu.cpp M src/pcu_vty.c 3 files changed, 13 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/28/21728/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/21728 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I16dc82c38eb75c2b9d1197640a955fec7df84efc Gerrit-Change-Number: 21728 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmo-ttcn3-hacks[master]: SGSN_Tests: test RIM message passing
dexter has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21735 )
Change subject: SGSN_Tests: test RIM message passing
..
SGSN_Tests: test RIM message passing
Add a testcase to test if RIM messages can be passed on the SGSN back
and forth.
Related: SYS#5103
Change-Id: If0ab08dcdc28819740cc07fd4dc1fea47ba10843
Related: SYS#5103
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 86 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/35/21735/1
diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn
index 8e7d6e4..9d54c2e 100644
--- a/sgsn/SGSN_Tests.ttcn
+++ b/sgsn/SGSN_Tests.ttcn
@@ -171,6 +171,9 @@
/* only needed at start to get the per-BVC references */
port BSSGP_CT_PROC_PT PROC;
+ /* used by RIM related test */
+ port BSSGP_PT RIM[NUM_GB];
+
var GTP_Emulation_CT vc_GTP;
port TELNETasp_PT SGSNVTY;
@@ -247,6 +250,8 @@
gb.vc_BSSGP_BVC[i] := f_bssgp_get_bvci_ct(gb.cfg.bvc[i].bvci,
PROC);
disconnect(self:PROC, gb.vc_BSSGP:PROC);
}
+ /* connect RIM related port */
+ connect(gb.vc_BSSGP:RIM, self:RIM[offset]);
}
private function f_init_gsup(charstring id) runs on test_CT {
@@ -3130,9 +3135,88 @@
f_cleanup();
}
+private function f_TC_bssgp_rim_dummy(charstring id) runs on BSSGP_ConnHdlr {
+}
+
+/* Run a RIM single report procedure over the sgsn. Since the SGSN will only
do a transparent routing of the
+ * RIM messages this basically tests if the message is correctly transfered
from one GB interface to the
+ * other and vice versa. */
+testcase TC_bssgp_rim_single_report() runs on test_CT {
+ var BSSGP_ConnHdlr vc_conn;
+ f_init();
+ vc_conn := f_start_handler(refers(f_TC_bssgp_rim_dummy),
testcasename(), g_gb, 17);
+ vc_conn.done;
+
+ timer T := 2.0;
+
+ var template RIM_Routing_Address dst_addr;
+ var template RIM_Routing_Address src_addr;
+ var template RAN_Information_Request_RIM_Container req_cont;
+ var template RAN_Information_RIM_Container res_cont;
+ var template PDU_BSSGP bssgp_rim_pdu;
+ var template PDU_BSSGP bssgp_rim_pdu_expect;
+
+ dst_addr := t_RIM_Routing_Address_cid(g_gb[1].cfg.bvc[0].cell_id);
+ src_addr := t_RIM_Routing_Address_cid(g_gb[0].cfg.bvc[0].cell_id);
+ /* Send NACC Ran information request to SGSN at GB interface #0. We
epect the SGSN to forward this request
+* based on the cell id in dst_addr to GB interface #1. */
+ req_cont :=
ts_RAN_Information_Request_RIM_Container(ts_RIM_Application_Identity(RIM_APP_ID_NACC),
+
ts_RIM_Sequence_Number(1),
+
ts_RIM_PDU_Indications(false, RIM_PDU_TYPE_SING_REP),
+
ts_RIM_Protocol_Version_Number(1),
+
tsu_RAN_Information_Request_Application_Container_NACC(g_gb[1].cfg.bvc[0].cell_id),
+omit);
+ bssgp_rim_pdu :=
ts_RAN_INFORMATION_REQUEST(ts_RIM_Routing_Information(RIM_ADDR_GERAN_CELL_ID,
dst_addr),
+
ts_RIM_Routing_Information(RIM_ADDR_GERAN_CELL_ID, src_addr),
+ req_cont);
+ bssgp_rim_pdu_expect :=
tr_RAN_INFORMATION_REQUEST(tr_RIM_Routing_Information(RIM_ADDR_GERAN_CELL_ID,
dst_addr),
+
tr_RIM_Routing_Information(RIM_ADDR_GERAN_CELL_ID, src_addr),
+
tr_RAN_Information_Request_RIM_Container);
+ RIM[0].send(bssgp_rim_pdu);
+ T.start;
+ alt {
+ [] RIM[1].receive(bssgp_rim_pdu_expect) { }
+ [] RIM[1].receive {
+ setverdict(fail, "Unexpected BSSGP RIM PDU received");
+ }
+ [] T.timeout {
+ setverdict(fail, "No BSSGP RIM PDU received");
+ mtc.stop;
+ }
+ }
+ /* Now also emulate also the response as well and send it back on GB
interface #1. Expect the result on
+* GB interface #0 */
+ var octetstring si3 := '1b753000f110236ec9033c274740793c0b2b2b'O
+ res_cont :=
ts_RAN_Information_RIM_Container(ts_RIM_Application_Identity(RIM_APP_ID_NACC),
+ts_RIM_Sequence_Number(2),
+
ts_RIM_PDU_Indications(false, RIM_PDU_TYPE_SING_REP),
+
ts_RIM_Protocol_Version_Number(1),
+
tsu_ApplC
Change in osmo-ttcn3-hacks[master]: deps/Makefile: temporarily use own repo for ProtocolModules.BSSGP
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21734 ) Change subject: deps/Makefile: temporarily use own repo for ProtocolModules.BSSGP .. deps/Makefile: temporarily use own repo for ProtocolModules.BSSGP Temporarily use titan.ProtocolModules.BSSGP_v13.0.0 from https://github.com/osmocom/ Change-Id: I5d7261a5ac33a0231c1a3d73bdff7fb099568687 --- M deps/Makefile 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/34/21734/1 diff --git a/deps/Makefile b/deps/Makefile index 61bab99..73b3283 100644 --- a/deps/Makefile +++ b/deps/Makefile @@ -51,7 +51,6 @@ titan.ProtocolModules.SUA \ titan.ProtocolModules.SDP \ titan.ProtocolModules.BSSAPP_v7.3.0 \ - titan.ProtocolModules.BSSGP_v13.0.0 \ titan.ProtocolModules.GTP_v13.5.0 \ titan.ProtocolModules.GTPv2_v13.7.0 \ titan.ProtocolModules.ISUP_Q.762 \ @@ -65,7 +64,8 @@ OSMOGITHUB_REPOS= titan.TestPorts.SCTPasp \ titan.TestPorts.MTP3asp \ titan.TestPorts.UDPasp \ - titan.ProtocolEmulations.SCCP + titan.ProtocolEmulations.SCCP \ + titan.ProtocolModules.BSSGP_v13.0.0 OSMOGIT_REPOS= titan.ProtocolModules.MAP \ titan.ProtocolModules.BSSMAP \ @@ -82,7 +82,7 @@ titan.ProtocolEmulations.M3UA_commit= f086e78d74defa044d864f17adaad9433fedc961 titan.ProtocolEmulations.SCCP_commit= R.7.A-9-g9e70fba titan.ProtocolModules.BSSAPP_v7.3.0_commit=R.2.A-4-g20cfaf8 -titan.ProtocolModules.BSSGP_v13.0.0_commit=R.2.A-6-gc447f28 +titan.ProtocolModules.BSSGP_v13.0.0_commit=master titan.ProtocolModules.BSSMAP_commit= master titan.ProtocolModules.DNS_commit= R.7.B titan.ProtocolModules.GRE_commit= R.2.A-5-g654c446 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21734 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5d7261a5ac33a0231c1a3d73bdff7fb099568687 Gerrit-Change-Number: 21734 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange
Change in osmo-ttcn3-hacks[master]: Osmocom_Gb_types: add RIM templates
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21587 to look at the new patch set (#3). Change subject: Osmocom_Gb_types: add RIM templates .. Osmocom_Gb_types: add RIM templates The template set we use for testing the GB (BSSGB) interface on osmo-sgsn and osmo-pcu lacks templates to generate RIM (ran information management) messages. The records and unions are already specified in BSSGP_Types.ttcn, we just need to form templates in order to be able to use them. Change-Id: Ic495e0bb6ceb2b65cbc7c3da7ee519a013aede55 Related: SYS#5103 --- M library/Osmocom_Gb_Types.ttcn 1 file changed, 806 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/87/21587/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21587 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic495e0bb6ceb2b65cbc7c3da7ee519a013aede55 Gerrit-Change-Number: 21587 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset
Change in docker-playground[master]: ttcn3-bts-test: fix: sleep 1 second before respawning the IUT
Hello laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/docker-playground/+/21640
to look at the new patch set (#3).
Change subject: ttcn3-bts-test: fix: sleep 1 second before respawning the IUT
..
ttcn3-bts-test: fix: sleep 1 second before respawning the IUT
There has been a lot of changes merged to both osmo-{bsc,bts}, so
now the later seems to be respawning faster then before. Because
of that, osmo-bts-trx is now reaching the limit of 500 runs on
Jenkins right in the middle of ttcn3-bts-test execution:
respawn.sh: exiting after 500 runs
causing the remaining test cases to fail due to:
"BTS_Tests.ttcn:253 : Timeout waiting for RSL bring up"
Most likely, the IUT respawns several times in the windows between
the test cases, i.e. after TITAN finishes one test case and before
it starts another. Let's instruct respawn.sh to sleep 1 second
before starting the process again.
Change-Id: I09e5a8e7c4d28424cd0d004a8bae3cf0ade2d838
---
M ttcn3-bts-test/jenkins.sh
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/docker-playground
refs/changes/40/21640/3
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/21640
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I09e5a8e7c4d28424cd0d004a8bae3cf0ade2d838
Gerrit-Change-Number: 21640
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-CC: daniel
Gerrit-MessageType: newpatchset
Build failure of network:osmocom:nightly/uhd in CentOS_8/aarch64
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/uhd/CentOS_8/aarch64
Package network:osmocom:nightly/uhd failed to build in CentOS_8/aarch64
Check out the package for editing:
osc checkout network:osmocom:nightly uhd
Last lines of build log:
[ 1864s] cd /home/abuild/rpmbuild/BUILD/uhd-3.15.0.0-rc2/host/build/lib &&
/usr/bin/c++ -DBOOST_ASIO_DISABLE_STD_EXPERIMENTAL_STRING_VIEW
-DBOOST_ASIO_DISABLE_STD_STRING_VIEW -DHAVE_CONFIG_H -DUHD_DLL_EXPORTS
-DUHD_LOG_CONSOLE_COLOR -DUHD_LOG_CONSOLE_LEVEL=2 -DUHD_LOG_FILE_LEVEL=2
-DUHD_LOG_MIN_LEVEL=1 -DUHD_RFNOC_ENABLED
-I/home/abuild/rpmbuild/BUILD/uhd-3.15.0.0-rc2/host/build/include
-I/home/abuild/rpmbuild/BUILD/uhd-3.15.0.0-rc2/host/include
-I/home/abuild/rpmbuild/BUILD/uhd-3.15.0.0-rc2/host/lib/include
-I/home/abuild/rpmbuild/BUILD/uhd-3.15.0.0-rc2/host/build/lib/ic_reg_maps
-I/home/abuild/rpmbuild/BUILD/uhd-3.15.0.0-rc2/host/lib/convert
-I/home/abuild/rpmbuild/BUILD/uhd-3.15.0.0-rc2/host/build/lib/convert
-I/home/abuild/rpmbuild/BUILD/uhd-3.15.0.0-rc2/host/lib/rfnoc/nocscript
-I/home/abuild/rpmbuild/BUILD/uhd-3.15.0.0-rc2/host/build/lib/rfnoc/nocscript
-I/home/abuild/rpmbuild/BUILD/uhd-3.15.0.0-rc2/host/lib/usrp
-I/home/abuild/rpmbuild/BUILD/uhd-3.15.0.0-rc2/host/lib/usrp/common/ad9361_driver
-I/home/abuild/rpmbuild/BUILD/uhd-3.15.0.0-rc2/host/lib/usrp/common
-I/home/abuild/rpmbuild/BUILD/uhd-3.15.0.0-rc2/host/build/lib/transport/nirio/lvbitx
-I/usr/include/libusb-1.0
-I/home/abuild/rpmbuild/BUILD/uhd-3.15.0.0-rc2/host/lib/deps/rpclib/include
-O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2
-Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong
-grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1
-specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fasynchronous-unwind-tables
-fstack-clash-protection -fvisibility=hidden -fvisibility-inlines-hidden
-DNDEBUG -fPIC -Wall -Wextra -Wsign-compare -std=gnu++14 -o
CMakeFiles/uhd.dir/usrp/x300/x300_eth_mgr.cpp.o -c
/home/abuild/rpmbuild/BUILD/uhd-3.15.0.0-rc2/host/lib/usrp/x300/x300_eth_mgr.cpp
[ 1880s] [ 60%] Building CXX object
lib/CMakeFiles/uhd.dir/usrp/x300/x300_io_impl.cpp.o
[ 1880s] cd /home/abuild/rpmbuild/BUILD/uhd-3.15.0.0-rc2/host/build/lib &&
/usr/bin/c++ -DBOOST_ASIO_DISABLE_STD_EXPERIMENTAL_STRING_VIEW
-DBOOST_ASIO_DISABLE_STD_STRING_VIEW -DHAVE_CONFIG_H -DUHD_DLL_EXPORTS
-DUHD_LOG_CONSOLE_COLOR -DUHD_LOG_CONSOLE_LEVEL=2 -DUHD_LOG_FILE_LEVEL=2
-DUHD_LOG_MIN_LEVEL=1 -DUHD_RFNOC_ENABLED
-I/home/abuild/rpmbuild/BUILD/uhd-3.15.0.0-rc2/host/build/include
-I/home/abuild/rpmbuild/BUILD/uhd-3.15.0.0-rc2/host/include
-I/home/abuild/rpmbuild/BUILD/uhd-3.15.0.0-rc2/host/lib/include
-I/home/abuild/rpmbuild/BUILD/uhd-3.15.0.0-rc2/host/build/lib/ic_reg_maps
-I/home/abuild/rpmbuild/BUILD/uhd-3.15.0.0-rc2/host/lib/convert
-I/home/abuild/rpmbuild/BUILD/uhd-3.15.0.0-rc2/host/build/lib/convert
-I/home/abuild/rpmbuild/BUILD/uhd-3.15.0.0-rc2/host/lib/rfnoc/nocscript
-I/home/abuild/rpmbuild/BUILD/uhd-3.15.0.0-rc2/host/build/lib/rfnoc/nocscript
-I/home/abuild/rpmbuild/BUILD/uhd-3.15.0.0-rc2/host/lib/usrp
-I/home/abuild/rpmbuild/BUILD/uhd-3.15.0.0-rc2/host/lib/usrp/common/ad9361_driver
-I/home/abuild/rpmbuild/BUILD/uhd-3.15.0.0-rc2/host/lib/usrp/common
-I/home/abuild/rpmbuild/BUILD/uhd-3.15.0.0-rc2/host/build/lib/transport/nirio/lvbitx
-I/usr/include/libusb-1.0
-I/home/abuild/rpmbuild/BUILD/uhd-3.15.0.0-rc2/host/lib/deps/rpclib/include
-O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2
-Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong
-grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1
-specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fasynchronous-unwind-tables
-fstack-clash-protection -fvisibility=hidden -fvisibility-inlines-hidden
-DNDEBUG -fPIC -Wall -Wextra -Wsign-compare -std=gnu++14 -o
CMakeFiles/uhd.dir/usrp/x300/x300_io_impl.cpp.o -c
/home/abuild/rpmbuild/BUILD/uhd-3.15.0.0-rc2/host/lib/usrp/x300/x300_io_impl.cpp
[ 1964s] [ 1919.740516] Out of memory: Killed process 7738 (cc1plus)
total-vm:1127580kB, anon-rss:488600kB, file-rss:0kB, shmem-rss:0kB
[ 1964s] {standard input}: Assembler messages:
[ 1964s] {standard input}:3309371: Warning: end of file not at end of a line;
newline inserted
[ 1964s] {standard input}:3310774: Error: unknown pseudo-op: `.8'
[ 1968s] [ 60%] Building CXX object
lib/CMakeFiles/uhd.dir/usrp/x300/x300_dboard_iface.cpp.o
[ 1968s] cd /home/abuild/rpmbuild/BUILD/uhd-3.15.0.0-rc2/host/build/lib &&
/usr/bin/c++ -DBOOST_ASIO_DISABLE_STD_EXPERIMENTAL_STRING_VIEW
-DBOOST_ASIO_DISABLE_STD_STRING_VIEW -DHAVE_CONFIG_H -DUHD_DLL_EXPORTS
-DUHD_LOG_CONSOLE_COLOR -DUHD_LOG_CONSOLE_LEVEL=2 -DUHD_LOG_FILE_LEVEL=2
-DUHD_LOG_MIN_LEVEL=1 -DUHD_RFNOC_ENABLED
-I/home/abuild/rpmbuild/BUILD/uhd-3.15.0.0-rc2/host/build/include
-I/home/abuild/rpmbuild/BUILD/uhd-3.15.0.0-rc2/host/include
-I/home/abuild/rpmbuild/BUILD/uhd-3.15.0.0-rc2/host/
Change in osmo-bsc[master]: Use rest_octets functionalities from libosmocore
pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/21711 )
Change subject: Use rest_octets functionalities from libosmocore
..
Use rest_octets functionalities from libosmocore
libosmocore > 1.4.0 is required (master, not yet released) since some
fixes done in osmo-bsc code where not cherry-picked to libosmocore APIs.
Depends: libosmocore.git I2bf5635b8536b11d69774d17ac1908019633e3af
Change-Id: I7d5e5ddd174463c2a3d957c8245d2911ce013681
---
M TODO-RELEASE
M include/osmocom/bsc/Makefile.am
M include/osmocom/bsc/bts.h
M include/osmocom/bsc/gsm_data.h
D include/osmocom/bsc/rest_octets.h
M src/osmo-bsc/Makefile.am
M src/osmo-bsc/bsc_vty.c
D src/osmo-bsc/rest_octets.c
M src/osmo-bsc/system_information.c
M tests/gsm0408/Makefile.am
M tests/handover/Makefile.am
11 files changed, 54 insertions(+), 1,038 deletions(-)
Approvals:
laforge: Looks good to me, approved
fixeria: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/TODO-RELEASE b/TODO-RELEASE
index 6a39a21..4760012 100644
--- a/TODO-RELEASE
+++ b/TODO-RELEASE
@@ -9,4 +9,4 @@
#library whatdescription / commit summary line
manual needs common chapter cs7-config.adoc,
vty_cpu_sched.adoc from osmo-gsm-manuals > 0.3.0
osmo-bsc Mobile Identity Coding OsmoBSC is stricter in rejecting
invalid coding of Mobile Identity IEs
-libosmocore>1.4.0 (1.4.1?) need BSSMAP-LE, BSSLAP, GAD coding
+libosmocore>1.4.0 (1.4.1?) need BSSMAP-LE, BSSLAP, GAD coding,
osmo_gsm48_si*
diff --git a/include/osmocom/bsc/Makefile.am b/include/osmocom/bsc/Makefile.am
index e2d5db8..7ca99fa 100644
--- a/include/osmocom/bsc/Makefile.am
+++ b/include/osmocom/bsc/Makefile.am
@@ -51,7 +51,6 @@
pcu_if.h \
pcuif_proto.h \
bssmap_reset.h \
- rest_octets.h \
rs232.h \
signal.h \
system_information.h \
diff --git a/include/osmocom/bsc/bts.h b/include/osmocom/bsc/bts.h
index 2b05418..d2f1307 100644
--- a/include/osmocom/bsc/bts.h
+++ b/include/osmocom/bsc/bts.h
@@ -390,7 +390,7 @@
struct gsm48_rach_control rach_control;
uint8_t ncc_permitted;
struct gsm48_cell_sel_par cell_sel_par;
- struct gsm48_si_selection_params cell_ro_sel_par; /* rest octet
*/
+ struct osmo_gsm48_si_selection_params cell_ro_sel_par; /* rest
octet */
struct gsm48_cell_options cell_options;
struct gsm48_control_channel_descr chan_desc;
struct bitvec neigh_list;
diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h
index 584c0e6..3472f39 100644
--- a/include/osmocom/bsc/gsm_data.h
+++ b/include/osmocom/bsc/gsm_data.h
@@ -21,7 +21,7 @@
#include
-#include
+#include
#include
#include
diff --git a/include/osmocom/bsc/rest_octets.h
b/include/osmocom/bsc/rest_octets.h
deleted file mode 100644
index 7df66f7..000
--- a/include/osmocom/bsc/rest_octets.h
+++ /dev/null
@@ -1,121 +0,0 @@
-#ifndef _REST_OCTETS_H
-#define _REST_OCTETS_H
-
-#include
-#include
-
-struct gsm_bts;
-
-/* generate SI1 rest octets */
-int rest_octets_si1(uint8_t *data, uint8_t *nch_pos, int is1800_net);
-int rest_octets_si2quater(uint8_t *data, struct gsm_bts *bts);
-int rest_octets_si2ter(uint8_t *data);
-int rest_octets_si2bis(uint8_t *data);
-int rest_octets_si6(uint8_t *data, bool is1800_net);
-
-struct gsm48_si_selection_params {
- uint16_t penalty_time:5,
- temp_offs:3,
- cell_resel_off:6,
- cbq:1,
- present:1;
-};
-
-struct gsm48_si_power_offset {
- uint8_t power_offset:2,
-present:1;
-};
-
-struct gsm48_si3_gprs_ind {
- uint8_t si13_position:1,
-ra_colour:3,
-present:1;
-};
-
-struct gsm48_lsa_params {
- uint32_t prio_thr:3,
-lsa_offset:3,
-mcc:12,
-mnc:12;
- unsigned int present;
-};
-
-struct gsm48_si_ro_info {
- struct gsm48_si_selection_params selection_params;
- struct gsm48_si_power_offset power_offset;
- bool si2ter_indicator;
- bool early_cm_ctrl;
- struct {
- uint8_t where:3,
-present:1;
- } scheduling;
- struct gsm48_si3_gprs_ind gprs_ind;
- /* SI 3 specific */
- bool early_cm_restrict_3g;
- bool si2quater_indicator;
- /* SI 4 specific */
- struct gsm48_lsa_params lsa_params;
- uint16_t cell_id;
- uint8_t break_ind; /* do we have SI7 + SI8 ? */
-};
-
-
-/* Generate SI3 Rest Octests (Chapter 10.5.2.34 / Table 10.4.72) */
-int rest_octets_si3(uint8_t *data, const struct gsm48_si_ro_info *si3);
-
-/* Generate SI4 Rest Octets (Chapter 10.5.2.35) */
-int rest_octets_si4(uint8_t *data, const struct gsm48_si_ro_info *si4, int
len);
Change in osmo-sgsn[master]: sgsn: Use the new NS2 api
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/20397 ) Change subject: sgsn: Use the new NS2 api .. Patch Set 11: Code-Review+1 (3 comments) https://gerrit.osmocom.org/c/osmo-sgsn/+/20397/11/src/sgsn/gprs_gb.c File src/sgsn/gprs_gb.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/20397/11/src/sgsn/gprs_gb.c@117 PS11, Line 117: osmo_prim_init(&nsp.oph, SAP_NS, PRIM_NS_UNIT_DATA, no line break needed, here and in many other occasions, at least that's my feeling https://gerrit.osmocom.org/c/osmo-sgsn/+/20397/11/src/sgsn/gprs_gb.c@143 PS11, Line 143: LOGP(DGPRS, LOGL_NOTICE, no line break needed (at leat not for four lines), here and in many other occasions, at least that's my feeling https://gerrit.osmocom.org/c/osmo-sgsn/+/20397/11/src/sgsn/gprs_gb.c@184 PS11, Line 184: get_value_string(osmo_prim_op_names, oph->operation), likewise -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/20397 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I92a3bcaf166b091a22d74c7c1586964d33d7cc9d Gerrit-Change-Number: 20397 Gerrit-PatchSet: 11 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 15 Dec 2020 18:49:31 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: Use rest_octets functionalities from libosmocore
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21711 ) Change subject: Use rest_octets functionalities from libosmocore .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21711 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7d5e5ddd174463c2a3d957c8245d2911ce013681 Gerrit-Change-Number: 21711 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 15 Dec 2020 18:44:52 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-e1-hardware[master]: icE1usb fw: Use green per-port LED to indicate alignment status
laforge has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21731 )
Change subject: icE1usb fw: Use green per-port LED to indicate alignment status
..
icE1usb fw: Use green per-port LED to indicate alignment status
Whenever Rx is aligned, the green LED is permanently on.
Whenever Rx is not aligned, the green LED is blinking.
What's missing is to check for E1 clock ticks and turn the LED off
completely if there are no clock ticks.
Change-Id: I42d53544858dbbbae5206d9a62b08672966c9ebf
---
M doc/manuals/chapters/firmware.adoc
M firmware/ice40-riscv/icE1usb/e1.c
M firmware/ice40-riscv/icE1usb/e1.h
M firmware/ice40-riscv/icE1usb/misc.c
4 files changed, 51 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-e1-hardware
refs/changes/31/21731/1
diff --git a/doc/manuals/chapters/firmware.adoc
b/doc/manuals/chapters/firmware.adoc
index d0542bd..254e235 100644
--- a/doc/manuals/chapters/firmware.adoc
+++ b/doc/manuals/chapters/firmware.adoc
@@ -128,9 +128,17 @@
=== Use of the E1 Interface LEDs
-Each E1 interface has two LEDs integrated into the RJ45 connector.
+Each E1 interface has two LEDs integrated into the RJ45 connector. They
+are (starting to get) used by the firmware to indicate status
+information to the user.
-FIXME: describe how they are used.
+[options="header"]
+|===
+|Color | Pattern | Meaning
+|Green | Blinking (slow) | E1 Receiver attempting to align
+|Green | On | E1 Receiver fully aligned
+|===
+
=== Use of the Multi-Color RGB LED
diff --git a/firmware/ice40-riscv/icE1usb/e1.c
b/firmware/ice40-riscv/icE1usb/e1.c
index b89b7c7..9ad2798 100644
--- a/firmware/ice40-riscv/icE1usb/e1.c
+++ b/firmware/ice40-riscv/icE1usb/e1.c
@@ -422,10 +422,14 @@
return;
/* HACK: LED link status */
- if (e1_regs->rx.csr & E1_RX_SR_ALIGNED)
+ if (e1_regs->rx.csr & E1_RX_SR_ALIGNED) {
+ e1_platform_led_set(0, E1P_LED_GREEN, E1P_LED_ST_ON);
led_color(0, 48, 0);
- else
+ } else {
+ e1_platform_led_set(0, E1P_LED_GREEN, E1P_LED_ST_BLINK);
+ /* TODO: completely off if rx tick counter not incrementing */
led_color(48, 0, 0);
+ }
/* Recover any done TX BD */
while ( (bd = e1_regs->tx.bd) & E1_BD_VALID ) {
diff --git a/firmware/ice40-riscv/icE1usb/e1.h
b/firmware/ice40-riscv/icE1usb/e1.h
index c56cf0c..c6b6fea 100644
--- a/firmware/ice40-riscv/icE1usb/e1.h
+++ b/firmware/ice40-riscv/icE1usb/e1.h
@@ -19,3 +19,19 @@
volatile uint8_t *e1_data_ptr(int mf, int frame, int ts);
unsigned int e1_data_ofs(int mf, int frame, int ts);
+
+enum e1_platform_led {
+ E1P_LED_GREEN = 0,
+ E1P_LED_YELLOW = 1,
+};
+
+enum e1_platform_led_state {
+ E1P_LED_ST_OFF = 0,
+ E1P_LED_ST_ON = 1,
+ E1P_LED_ST_BLINK= 2,
+ E1P_LED_ST_BLINK_FAST = 3
+};
+
+/* external function provided by the platform; used by E1 driver to control
LEDs */
+extern void e1_platform_led_set(uint8_t port, enum e1_platform_led led,
+ enum e1_platform_led_state state);
diff --git a/firmware/ice40-riscv/icE1usb/misc.c
b/firmware/ice40-riscv/icE1usb/misc.c
index dca126a..3117be9 100644
--- a/firmware/ice40-riscv/icE1usb/misc.c
+++ b/firmware/ice40-riscv/icE1usb/misc.c
@@ -10,6 +10,7 @@
#include "config.h"
#include "misc.h"
+#include "e1.h"
struct misc {
@@ -51,6 +52,24 @@
misc_regs->e1_led = (enable ? 0x100 : 0x000) | cfg;
}
+void
+e1_platform_led_set(uint8_t port, enum e1_platform_led led,
+ enum e1_platform_led_state state)
+{
+ uint32_t tmp;
+ unsigned int shift;
+
+ if (port >= 2)
+ return;
+
+ shift = 4*port + 2*led;
+
+ tmp = misc_regs->e1_led;
+ tmp &= ~(3 << shift);
+ tmp |= 0x100 | ((state & 3) << shift);
+ misc_regs->e1_led = tmp;
+}
+
uint16_t
e1_tick_read(void)
{
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21731
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1-hardware
Gerrit-Branch: master
Gerrit-Change-Id: I42d53544858dbbbae5206d9a62b08672966c9ebf
Gerrit-Change-Number: 21731
Gerrit-PatchSet: 1
Gerrit-Owner: laforge
Gerrit-MessageType: newchange
Change in osmo-e1-hardware[master]: icE1usb fw: Turn green LED off completely if no E1 signal is received
laforge has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21733 )
Change subject: icE1usb fw: Turn green LED off completely if no E1 signal is
received
..
icE1usb fw: Turn green LED off completely if no E1 signal is received
We don't really have an idea of the analog signal level and hence
no true LOS detection. However, we can check the Rx clock tick counter
to detect if there is at least still any kind of signal at all or not.
Change-Id: Ibd23cbf1d044b46d8fed48fb97622e6ef980b99f
---
M doc/manuals/chapters/firmware.adoc
M firmware/ice40-riscv/icE1usb/e1.c
2 files changed, 10 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-e1-hardware
refs/changes/33/21733/1
diff --git a/doc/manuals/chapters/firmware.adoc
b/doc/manuals/chapters/firmware.adoc
index 254e235..798f5f4 100644
--- a/doc/manuals/chapters/firmware.adoc
+++ b/doc/manuals/chapters/firmware.adoc
@@ -135,6 +135,7 @@
[options="header"]
|===
|Color | Pattern | Meaning
+|Green | Off | E1 Receiver detects no signal
|Green | Blinking (slow) | E1 Receiver attempting to align
|Green | On | E1 Receiver fully aligned
|===
diff --git a/firmware/ice40-riscv/icE1usb/e1.c
b/firmware/ice40-riscv/icE1usb/e1.c
index 9ad2798..6f85d19 100644
--- a/firmware/ice40-riscv/icE1usb/e1.c
+++ b/firmware/ice40-riscv/icE1usb/e1.c
@@ -16,6 +16,8 @@
#include "dma.h"
#include "led.h" // FIXME
+#include "misc.h" // needed to get the E1 tick for "LOS" detection
+
// Hardware
//
@@ -283,6 +285,7 @@
struct e1_fifo fifo;
int in_flight;
enum e1_pipe_state state;
+ uint16_t last_tick;
} rx;
struct {
@@ -426,8 +429,12 @@
e1_platform_led_set(0, E1P_LED_GREEN, E1P_LED_ST_ON);
led_color(0, 48, 0);
} else {
- e1_platform_led_set(0, E1P_LED_GREEN, E1P_LED_ST_BLINK);
- /* TODO: completely off if rx tick counter not incrementing */
+ uint16_t cur_tick = e1_tick_read(0);
+ if (g_e1.rx.last_tick == cur_tick)
+ e1_platform_led_set(0, E1P_LED_GREEN, E1P_LED_ST_OFF);
+ else
+ e1_platform_led_set(0, E1P_LED_GREEN, E1P_LED_ST_BLINK);
+ g_e1.rx.last_tick = cur_tick;
led_color(48, 0, 0);
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21733
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1-hardware
Gerrit-Branch: master
Gerrit-Change-Id: Ibd23cbf1d044b46d8fed48fb97622e6ef980b99f
Gerrit-Change-Number: 21733
Gerrit-PatchSet: 1
Gerrit-Owner: laforge
Gerrit-MessageType: newchange
Change in osmo-e1-hardware[master]: icE1usb: add port number argument to e1_tick_read()
laforge has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21732 )
Change subject: icE1usb: add port number argument to e1_tick_read()
..
icE1usb: add port number argument to e1_tick_read()
Change-Id: I0f4548b5623a7eaf74af3076c301e029bb3933da
---
M firmware/ice40-riscv/icE1usb/misc.c
M firmware/ice40-riscv/icE1usb/misc.h
M firmware/ice40-riscv/icE1usb/usb_e1.c
3 files changed, 6 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-e1-hardware
refs/changes/32/21732/1
diff --git a/firmware/ice40-riscv/icE1usb/misc.c
b/firmware/ice40-riscv/icE1usb/misc.c
index 3117be9..25fb7f4 100644
--- a/firmware/ice40-riscv/icE1usb/misc.c
+++ b/firmware/ice40-riscv/icE1usb/misc.c
@@ -71,9 +71,11 @@
}
uint16_t
-e1_tick_read(void)
+e1_tick_read(uint8_t port)
{
- return misc_regs->e1_tick[0].tx;
+ if (port >= 2)
+ return 0x;
+ return misc_regs->e1_tick[port].tx;
}
void
diff --git a/firmware/ice40-riscv/icE1usb/misc.h
b/firmware/ice40-riscv/icE1usb/misc.h
index 69c0da7..b405b02 100644
--- a/firmware/ice40-riscv/icE1usb/misc.h
+++ b/firmware/ice40-riscv/icE1usb/misc.h
@@ -27,6 +27,6 @@
void pdm_set(int chan, bool enable, unsigned value, bool normalize);
void e1_led_set(bool enable, uint8_t cfg);
-uint16_t e1_tick_read(void);
+uint16_t e1_tick_read(uint8_t port);
void reboot(int fw);
diff --git a/firmware/ice40-riscv/icE1usb/usb_e1.c
b/firmware/ice40-riscv/icE1usb/usb_e1.c
index 151d902..b4d4f81 100644
--- a/firmware/ice40-riscv/icE1usb/usb_e1.c
+++ b/firmware/ice40-riscv/icE1usb/usb_e1.c
@@ -42,7 +42,7 @@
unsigned int level;
/* Compute real E1 tick count (with safety against bad values) */
- ticks = e1_tick_read();
+ ticks = e1_tick_read(0);
val = (ticks - ticks_prev) & 0x;
ticks_prev = ticks;
if ((val < 7168) | (val > 9216))
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21732
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1-hardware
Gerrit-Branch: master
Gerrit-Change-Id: I0f4548b5623a7eaf74af3076c301e029bb3933da
Gerrit-Change-Number: 21732
Gerrit-PatchSet: 1
Gerrit-Owner: laforge
Gerrit-MessageType: newchange
Change in osmo-bsc[master]: Use rest_octets functionalities from libosmocore
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21711 ) Change subject: Use rest_octets functionalities from libosmocore .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21711 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7d5e5ddd174463c2a3d957c8245d2911ce013681 Gerrit-Change-Number: 21711 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Tue, 15 Dec 2020 17:01:07 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: ns2: follow ns2 sns api changes
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/21730 ) Change subject: ns2: follow ns2 sns api changes .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/21730 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Id530e5497c17885817493f8a8a9436bc187c88aa Gerrit-Change-Number: 21730 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 15 Dec 2020 16:29:14 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: ns2: follow ns2 dialect changes
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/21728 ) Change subject: ns2: follow ns2 dialect changes .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/21728 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I16dc82c38eb75c2b9d1197640a955fec7df84efc Gerrit-Change-Number: 21728 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 15 Dec 2020 16:28:39 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: ns2: follow ns2 sns api changes
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/21730 ) Change subject: ns2: follow ns2 sns api changes .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/21730 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Id530e5497c17885817493f8a8a9436bc187c88aa Gerrit-Change-Number: 21730 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: pespin Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 15 Dec 2020 16:09:30 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: ns2: follow changes to add a unique name to all binds
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/21729 ) Change subject: ns2: follow changes to add a unique name to all binds .. Patch Set 2: Code-Review-1 (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/21729/2/src/gprs_bssgp_pcu.cpp File src/gprs_bssgp_pcu.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/21729/2/src/gprs_bssgp_pcu.cpp@960 PS2, Line 960: char name[5]; so on tenth byte we run out of space? I think we can afford setting it to 32 or alike :) -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/21729 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I3638c7204db576116ba2e20dae27539ce6143bd7 Gerrit-Change-Number: 21729 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: pespin Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 15 Dec 2020 16:09:02 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: ns2: follow ns2 dialect changes
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/21728 ) Change subject: ns2: follow ns2 dialect changes .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/21728 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I16dc82c38eb75c2b9d1197640a955fec7df84efc Gerrit-Change-Number: 21728 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: pespin Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 15 Dec 2020 16:07:48 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: ns2: follow ns2 sns api changes
lynxis lazus has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-pcu/+/21730 ) Change subject: ns2: follow ns2 sns api changes .. ns2: follow ns2 sns api changes Change-Id: Id530e5497c17885817493f8a8a9436bc187c88aa --- M src/gprs_bssgp_pcu.cpp 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/30/21730/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/21730 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Id530e5497c17885817493f8a8a9436bc187c88aa Gerrit-Change-Number: 21730 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset
Change in osmo-pcu[master]: ns2: follow changes to add a unique name to all binds
lynxis lazus has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-pcu/+/21729 ) Change subject: ns2: follow changes to add a unique name to all binds .. ns2: follow changes to add a unique name to all binds Change-Id: I3638c7204db576116ba2e20dae27539ce6143bd7 --- M src/gprs_bssgp_pcu.cpp 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/29/21729/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/21729 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I3638c7204db576116ba2e20dae27539ce6143bd7 Gerrit-Change-Number: 21729 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset
Change in osmo-pcu[master]: ns2: follow ns2 dialect changes
lynxis lazus has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-pcu/+/21728 ) Change subject: ns2: follow ns2 dialect changes .. ns2: follow ns2 dialect changes NS2 introduce a ns dialect to differentiate between the 4 possible dialects. Change-Id: I16dc82c38eb75c2b9d1197640a955fec7df84efc --- M src/bts.h M src/gprs_bssgp_pcu.cpp M src/pcu_vty.c 3 files changed, 8 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/28/21728/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/21728 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I16dc82c38eb75c2b9d1197640a955fec7df84efc Gerrit-Change-Number: 21728 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset
Change in osmo-pcu[master]: ns2: follow ns2 sns api changes
lynxis lazus has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-pcu/+/21730 )
Change subject: ns2: follow ns2 sns api changes
..
ns2: follow ns2 sns api changes
Change-Id: Id530e5497c17885817493f8a8a9436bc187c88aa
---
M src/gprs_bssgp_pcu.cpp
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/30/21730/1
diff --git a/src/gprs_bssgp_pcu.cpp b/src/gprs_bssgp_pcu.cpp
index b29413d..f966a79 100644
--- a/src/gprs_bssgp_pcu.cpp
+++ b/src/gprs_bssgp_pcu.cpp
@@ -1000,7 +1000,7 @@
/* FIXME: for SNS we just use the first successful NS-VC
instead of all for the initial connect */
if (bts->ns_dialect == NS2_DIALECT_SNS) {
- rc = gprs_ns2_ip_connect_sns(bind[i], &remote[i], nsei);
+ rc = gprs_ns2_sns_add_endpoint(bts->nse, &remote[i]);
if (!rc)
return rc;
else
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/21730
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Id530e5497c17885817493f8a8a9436bc187c88aa
Gerrit-Change-Number: 21730
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus
Gerrit-MessageType: newchange
Change in osmo-pcu[master]: ns2: follow changes to add a unique name to all binds
lynxis lazus has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-pcu/+/21729 )
Change subject: ns2: follow changes to add a unique name to all binds
..
ns2: follow changes to add a unique name to all binds
Change-Id: I3638c7204db576116ba2e20dae27539ce6143bd7
---
M src/gprs_bssgp_pcu.cpp
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/29/21729/1
diff --git a/src/gprs_bssgp_pcu.cpp b/src/gprs_bssgp_pcu.cpp
index 4d24d2e..b29413d 100644
--- a/src/gprs_bssgp_pcu.cpp
+++ b/src/gprs_bssgp_pcu.cpp
@@ -957,6 +957,7 @@
bool nsvcs = false;
struct gprs_ns2_vc *nsvc;
struct gprs_ns2_vc_bind *bind[PCU_IF_NUM_NSVC] = { };
+ char name[5];
if (!valid)
return -1;
@@ -966,7 +967,8 @@
continue;
if (!gprs_ns2_ip_bind_by_sockaddr(bts->nsi, &local[i])) {
- rc = gprs_ns2_ip_bind(bts->nsi, &local[i], 0, &bind[i]);
+ snprintf(name, sizeof(name), "pcu%d", i);
+ rc = gprs_ns2_ip_bind(bts->nsi, name, &local[i], 0,
&bind[i]);
if (rc < 0) {
LOGP(DBSSGP, LOGL_ERROR, "Failed to bind to
%s\n", osmo_sockaddr_to_str(&local[i]));
continue;
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/21729
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I3638c7204db576116ba2e20dae27539ce6143bd7
Gerrit-Change-Number: 21729
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus
Gerrit-MessageType: newchange
Change in osmo-pcu[master]: ns: follow ns2 dialect changes
lynxis lazus has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-pcu/+/21728 )
Change subject: ns: follow ns2 dialect changes
..
ns: follow ns2 dialect changes
NS2 introduce a ns dialect to differentiate
between the 4 possible dialects.
Change-Id: I16dc82c38eb75c2b9d1197640a955fec7df84efc
---
M src/bts.h
M src/gprs_bssgp_pcu.cpp
M src/pcu_vty.c
3 files changed, 8 insertions(+), 9 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/28/21728/1
diff --git a/src/bts.h b/src/bts.h
index fd52067..c3880f4 100644
--- a/src/bts.h
+++ b/src/bts.h
@@ -27,6 +27,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -170,7 +171,7 @@
char *pcu_sock_path;
/* Are we talking Gb with IP-SNS (true) or classic Gb? */
- bool gb_dialect_sns;
+ enum gprs_ns2_dialect ns_dialect;
/* Packet Application Information (3GPP TS 44.060 11.2.47, usually ETWS
primary message). We don't need to store
* more than one message, because they get sent so rarely. */
diff --git a/src/gprs_bssgp_pcu.cpp b/src/gprs_bssgp_pcu.cpp
index 934d8fc..4d24d2e 100644
--- a/src/gprs_bssgp_pcu.cpp
+++ b/src/gprs_bssgp_pcu.cpp
@@ -984,7 +984,7 @@
bts->nse = gprs_ns2_nse_by_nsei(bts->nsi, nsei);
if (!bts->nse)
bts->nse = gprs_ns2_create_nse(bts->nsi, nsei,
- GPRS_NS2_LL_UDP);
+ GPRS_NS2_LL_UDP,
bts->ns_dialect);
if (!bts->nse) {
LOGP(DBSSGP, LOGL_ERROR, "Failed to create NSE\n");
@@ -997,7 +997,7 @@
continue;
/* FIXME: for SNS we just use the first successful NS-VC
instead of all for the initial connect */
- if (bts->gb_dialect_sns) {
+ if (bts->ns_dialect == NS2_DIALECT_SNS) {
rc = gprs_ns2_ip_connect_sns(bind[i], &remote[i], nsei);
if (!rc)
return rc;
@@ -1066,7 +1066,7 @@
gprs_ns2_free_nses(bts->nsi);
gprs_ns2_free_binds(bts->nsi);
rc = ns_create_nsvc(bts, nsei, local, remote, nsvci, valid);
- } else if (bts->gb_dialect_sns) {
+ } else if (bts->ns_dialect == NS2_DIALECT_SNS) {
/* SNS: check if the initial nsvc is the same, if not recreate
it */
const struct osmo_sockaddr *initial =
gprs_ns2_nse_sns_remote(bts->nse);
for (unsigned int i = 0; i < PCU_IF_NUM_NSVC; i++) {
diff --git a/src/pcu_vty.c b/src/pcu_vty.c
index bf45686..800079c 100644
--- a/src/pcu_vty.c
+++ b/src/pcu_vty.c
@@ -246,7 +246,7 @@
}
}
- if (bts->gb_dialect_sns)
+ if (bts->ns_dialect == NS2_DIALECT_SNS)
vty_out(vty, " gb-dialect ip-sns%s", VTY_NEWLINE);
else
vty_out(vty, " gb-dialect classic%s", VTY_NEWLINE);
@@ -1131,11 +1131,9 @@
struct gprs_rlcmac_bts *bts = bts_main_data();
if (!strcmp(argv[0], "ip-sns")) {
- bts->gb_dialect_sns = true;
- gprs_ns2_vty_force_vc_mode(true, NS2_VC_MODE_ALIVE, "gb-dialect
is ip-sns");
+ bts->ns_dialect = NS2_DIALECT_SNS;
} else {
- bts->gb_dialect_sns = false;
- gprs_ns2_vty_force_vc_mode(false, 0, NULL);
+ bts->ns_dialect = NS2_DIALECT_IPACCESS;
}
return CMD_SUCCESS;
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/21728
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I16dc82c38eb75c2b9d1197640a955fec7df84efc
Gerrit-Change-Number: 21728
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus
Gerrit-MessageType: newchange
Change in osmo-sgsn[master]: gbproxy: Add SGSN NRI configuration
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/21705 ) Change subject: gbproxy: Add SGSN NRI configuration .. Patch Set 4: (1 comment) https://gerrit.osmocom.org/c/osmo-sgsn/+/21705/4/src/gbproxy/gb_proxy_vty.c File src/gbproxy/gb_proxy_vty.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/21705/4/src/gbproxy/gb_proxy_vty.c@50 PS4, Line 50: #define NRI_STR "Mapping of Network Resource Indicators to this MSC, for MSC pooling\n" s/MSC/SGSN here and below -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21705 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Id67592aa7712e5e04e7264b2fb8f26d57eb7e69e Gerrit-Change-Number: 21705 Gerrit-PatchSet: 4 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Comment-Date: Tue, 15 Dec 2020 13:00:36 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-sgsn[master]: sgsn: Use the new NS2 api
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/20397 ) Change subject: sgsn: Use the new NS2 api .. Patch Set 11: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/20397 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I92a3bcaf166b091a22d74c7c1586964d33d7cc9d Gerrit-Change-Number: 20397 Gerrit-PatchSet: 11 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 15 Dec 2020 12:13:14 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-sgsn[master]: sgsn: Use the new NS2 api
Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/20397 to look at the new patch set (#10). Change subject: sgsn: Use the new NS2 api .. sgsn: Use the new NS2 api The new NS2 api supports NSE with multiple NS-VC and contains a NS-VC fsm. FR/GRE support is not working. The configuration is compatible except for FR/GRE. Relates: OS#4629 Depends-on: Iaad7b53d44338e5dd81dc2202f23bdcb715af804 (libosmocore) Depends-on: I6cef42749555e577d5573f2ed8b8bce4cf842a98 (libosmocore) Change-Id: I92a3bcaf166b091a22d74c7c1586964d33d7cc9d --- M include/osmocom/sgsn/gprs_gb.h M include/osmocom/sgsn/sgsn.h M src/gprs/gprs_utils.c M src/sgsn/gprs_gb.c M src/sgsn/gprs_ranap.c M src/sgsn/gprs_sgsn.c M src/sgsn/sgsn_main.c M src/sgsn/sgsn_vty.c M tests/vty_test_runner.py 9 files changed, 119 insertions(+), 61 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/97/20397/10 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/20397 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I92a3bcaf166b091a22d74c7c1586964d33d7cc9d Gerrit-Change-Number: 20397 Gerrit-PatchSet: 10 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmo-sgsn[master]: sgsn: Use the new NS2 api
Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/20397 to look at the new patch set (#9). Change subject: sgsn: Use the new NS2 api .. sgsn: Use the new NS2 api The new NS2 api supports NSE with multiple NS-VC and contains a NS-VC fsm. FR/GRE support is not working. The configuration is compatible except for FR/GRE. Relates: OS#4629 Depends-on: Iaad7b53d44338e5dd81dc2202f23bdcb715af804 (libosmocore) Depends-on: I6cef42749555e577d5573f2ed8b8bce4cf842a98 (libosmocore) Change-Id: I92a3bcaf166b091a22d74c7c1586964d33d7cc9d --- M include/osmocom/sgsn/gprs_gb.h M include/osmocom/sgsn/sgsn.h M src/gprs/gprs_utils.c M src/sgsn/gprs_gb.c M src/sgsn/gprs_ranap.c M src/sgsn/gprs_sgsn.c M src/sgsn/sgsn_main.c M src/sgsn/sgsn_vty.c M tests/vty_test_runner.py 9 files changed, 117 insertions(+), 61 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/97/20397/9 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/20397 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I92a3bcaf166b091a22d74c7c1586964d33d7cc9d Gerrit-Change-Number: 20397 Gerrit-PatchSet: 9 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in libosmocore[master]: gprs_ns2: on ns2_create_vc parse the tlv before using it
lynxis lazus has submitted this change. (
https://gerrit.osmocom.org/c/libosmocore/+/21723 )
Change subject: gprs_ns2: on ns2_create_vc parse the tlv before using it
..
gprs_ns2: on ns2_create_vc parse the tlv before using it
reject_status_msg require a parsed tlv. Otherwise an
uninitialized tlv is passed.
Change-Id: I82cab518966b8b49c3522ff5f7b6f82d1027a526
---
M src/gb/gprs_ns2.c
1 file changed, 9 insertions(+), 9 deletions(-)
Approvals:
laforge: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/gb/gprs_ns2.c b/src/gb/gprs_ns2.c
index fd016e6..9d5a97c 100644
--- a/src/gb/gprs_ns2.c
+++ b/src/gb/gprs_ns2.c
@@ -798,6 +798,15 @@
if (msg->len < sizeof(struct gprs_ns_hdr))
return GPRS_NS2_CS_ERROR;
+ rc = ns2_tlv_parse(&tp, nsh->data,
+ msgb_l2len(msg) - sizeof(*nsh), 0, 0);
+ if (rc < 0) {
+ LOGP(DLNS, LOGL_ERROR, "Rx NS RESET Error %d during "
+"TLV Parse\n", rc);
+ /* TODO: send invalid message back */
+ return GPRS_NS2_CS_REJECTED;
+ }
+
switch (nsh->pdu_type) {
case NS_PDUT_STATUS:
/* Do not respond, see 3GPP TS 08.16, 7.5.1 */
@@ -840,15 +849,6 @@
return GPRS_NS2_CS_REJECTED;
}
- rc = ns2_tlv_parse(&tp, nsh->data,
- msgb_l2len(msg) - sizeof(*nsh), 0, 0);
- if (rc < 0) {
- LOGP(DLNS, LOGL_ERROR, "Rx NS RESET Error %d during "
-"TLV Parse\n", rc);
- /* TODO: send invalid message back */
- return GPRS_NS2_CS_REJECTED;
- }
-
if (!TLVP_PRES_LEN(&tp, NS_IE_CAUSE, 1) ||
!TLVP_PRES_LEN(&tp, NS_IE_VCI, 2) || !TLVP_PRES_LEN(&tp,
NS_IE_NSEI, 2)) {
LOGP(DLNS, LOGL_ERROR, "NS RESET Missing mandatory IE\n");
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21723
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I82cab518966b8b49c3522ff5f7b6f82d1027a526
Gerrit-Change-Number: 21723
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel
Gerrit-Reviewer: laforge
Gerrit-Reviewer: lynxis lazus
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in libosmocore[master]: gprs_ns2: don't pass the return code of reject_status_msg
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21725 ) Change subject: gprs_ns2: don't pass the return code of reject_status_msg .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21725 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I105363957e59c41a68835b7a9830c048dba73e93 Gerrit-Change-Number: 21725 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 15 Dec 2020 11:55:49 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: gprs_ns2: improve handling of TLV errors on new nsvcs
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21724 ) Change subject: gprs_ns2: improve handling of TLV errors on new nsvcs .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21724 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2992d06b37ed122b7ff315d4852e86acc936800b Gerrit-Change-Number: 21724 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 15 Dec 2020 11:52:52 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: gprs_ns2: improve handling of TLV errors on new nsvcs
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21724 ) Change subject: gprs_ns2: improve handling of TLV errors on new nsvcs .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/21724/2/src/gb/gprs_ns2.c File src/gb/gprs_ns2.c: https://gerrit.osmocom.org/c/libosmocore/+/21724/2/src/gb/gprs_ns2.c@807 PS2, Line 807: rc = reject_status_msg(msg, &tp, reject, NS_CAUSE_PDU_INCOMP_PSTATE); > so you may end up passing &tp in an incorrect/unknwon state here? no, because tp get's always initialized. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21724 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2992d06b37ed122b7ff315d4852e86acc936800b Gerrit-Change-Number: 21724 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 15 Dec 2020 11:52:12 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
Change in libosmocore[master]: gprs_ns2: add gprs_ns2_fr_bind_role() to retrieve the fr role
lynxis lazus has submitted this change. (
https://gerrit.osmocom.org/c/libosmocore/+/21653 )
Change subject: gprs_ns2: add gprs_ns2_fr_bind_role() to retrieve the fr role
..
gprs_ns2: add gprs_ns2_fr_bind_role() to retrieve the fr role
Change-Id: I277b805e588ba68536789b4a64a428ea0b31728a
---
M include/osmocom/gprs/gprs_ns2.h
M src/gb/gprs_ns2_fr.c
2 files changed, 16 insertions(+), 0 deletions(-)
Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/include/osmocom/gprs/gprs_ns2.h b/include/osmocom/gprs/gprs_ns2.h
index ef9a56a..0b3ea1f 100644
--- a/include/osmocom/gprs/gprs_ns2.h
+++ b/include/osmocom/gprs/gprs_ns2.h
@@ -182,6 +182,7 @@
struct gprs_ns2_inst *nsi,
const char *netif);
const char *gprs_ns2_fr_bind_netif(struct gprs_ns2_vc_bind *bind);
+enum osmo_fr_role gprs_ns2_fr_bind_role(struct gprs_ns2_vc_bind *bind);
int gprs_ns2_fr_bind(struct gprs_ns2_inst *nsi,
const char *name,
const char *netif,
diff --git a/src/gb/gprs_ns2_fr.c b/src/gb/gprs_ns2_fr.c
index 925d5ed..8147f66 100644
--- a/src/gb/gprs_ns2_fr.c
+++ b/src/gb/gprs_ns2_fr.c
@@ -558,6 +558,21 @@
return rc;
}
+/*! Return the frame relay role of a bind
+ * \param[in] bind The bind
+ * \return the frame relay role or -EINVAL if bind is not frame relay
+ */
+enum osmo_fr_role gprs_ns2_fr_bind_role(struct gprs_ns2_vc_bind *bind)
+{
+ struct priv_bind *priv;
+
+ if (bind->driver != &vc_driver_fr)
+ return -EINVAL;
+
+ priv = bind->priv;
+ return priv->link->role;
+}
+
/*! Return the network interface of the bind
* \param[in] bind The bind
* \return the network interface
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21653
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I277b805e588ba68536789b4a64a428ea0b31728a
Gerrit-Change-Number: 21653
Gerrit-PatchSet: 5
Gerrit-Owner: lynxis lazus
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: lynxis lazus
Gerrit-MessageType: merged
Change in libosmocore[master]: gprs_ns2_sns: introduce SNS Size/Config retries
lynxis lazus has submitted this change. (
https://gerrit.osmocom.org/c/libosmocore/+/21575 )
Change subject: gprs_ns2_sns: introduce SNS Size/Config retries
..
gprs_ns2_sns: introduce SNS Size/Config retries
According to 3GPP Size and Config procedure can
have retries in case the timeout of the procedure runs out.
Change-Id: I00e9023a6e7adc6ad48f4016fcaef189ac8b353e
---
M src/gb/gprs_ns2.c
M src/gb/gprs_ns2_internal.h
M src/gb/gprs_ns2_sns.c
3 files changed, 19 insertions(+), 5 deletions(-)
Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/gb/gprs_ns2.c b/src/gb/gprs_ns2.c
index 5e5dd83..fd016e6 100644
--- a/src/gb/gprs_ns2.c
+++ b/src/gb/gprs_ns2.c
@@ -1153,6 +1153,8 @@
nsi->timeout[NS_TOUT_TNS_ALIVE] = 3;
nsi->timeout[NS_TOUT_TNS_ALIVE_RETRIES] = 10;
nsi->timeout[NS_TOUT_TSNS_PROV] = 3; /* 1..10 */
+ nsi->timeout[NS_TOUT_TSNS_SIZE_RETRIES] = 3;
+ nsi->timeout[NS_TOUT_TSNS_CONFIG_RETRIES] = 3;
return nsi;
}
diff --git a/src/gb/gprs_ns2_internal.h b/src/gb/gprs_ns2_internal.h
index d12c663..9e63c70 100644
--- a/src/gb/gprs_ns2_internal.h
+++ b/src/gb/gprs_ns2_internal.h
@@ -15,10 +15,8 @@
struct gprs_ns2_vc_driver;
struct gprs_ns2_vc_bind;
-
-
-#define NS_TIMERS_COUNT 8
-#define NS_TIMERS
"(tns-block|tns-block-retries|tns-reset|tns-reset-retries|tns-test|tns-alive|tns-alive-retries|tsns-prov)"
+#define NS_TIMERS_COUNT 10
+#define NS_TIMERS
"(tns-block|tns-block-retries|tns-reset|tns-reset-retries|tns-test|tns-alive|tns-alive-retries|tsns-prov|tsns-prov-retries)"
#define NS_TIMERS_HELP \
"(un)blocking Timer (Tns-block) timeout\n" \
"(un)blocking Timer (Tns-block) number of retries\n"\
@@ -27,7 +25,9 @@
"Test Timer (Tns-test) timeout\n" \
"Alive Timer (Tns-alive) timeout\n" \
"Alive Timer (Tns-alive) number of retries\n" \
- "SNS Provision Timer (Tsns-prov) timeout\n"
+ "SNS Provision Timer (Tsns-prov) timeout\n" \
+ "SNS Size number of retries\n" \
+ "SNS Config number of retries\n"\
/* Educated guess - LLC user payload is 1500 bytes plus possible headers */
#define NS_ALLOC_SIZE 3072
@@ -42,6 +42,8 @@
NS_TOUT_TNS_ALIVE,
NS_TOUT_TNS_ALIVE_RETRIES,
NS_TOUT_TSNS_PROV,
+ NS_TOUT_TSNS_SIZE_RETRIES,
+ NS_TOUT_TSNS_CONFIG_RETRIES,
};
enum nsvc_timer_mode {
diff --git a/src/gb/gprs_ns2_sns.c b/src/gb/gprs_ns2_sns.c
index 0676b61..f25d93a 100644
--- a/src/gb/gprs_ns2_sns.c
+++ b/src/gb/gprs_ns2_sns.c
@@ -119,6 +119,8 @@
struct gprs_ns2_vc *sns_nsvc;
/* iterate over the binds after all remote has been tested */
int bind_offset;
+ /* timer N */
+ int N;
/* local configuration to send to the remote end */
struct gprs_ns_ie_ip4_elem *ip4_local;
@@ -1304,14 +1306,22 @@
static int ns2_sns_fsm_bss_timer_cb(struct osmo_fsm_inst *fi)
{
+ struct ns2_sns_state *gss = (struct ns2_sns_state *) fi->priv;
struct gprs_ns2_nse *nse = nse_inst_from_fi(fi);
struct gprs_ns2_inst *nsi = nse->nsi;
+ gss->N++;
switch (fi->T) {
case 1:
+ if (gss->N >= nsi->timeout[NS_TOUT_TSNS_SIZE_RETRIES])
+ osmo_fsm_inst_dispatch(fi, GPRS_SNS_EV_SELECT_ENDPOINT,
NULL);
+
osmo_fsm_inst_state_chg(fi, GPRS_SNS_ST_SIZE,
nsi->timeout[NS_TOUT_TSNS_PROV], 1);
break;
case 2:
+ if (gss->N >= nsi->timeout[NS_TOUT_TSNS_CONFIG_RETRIES])
+ osmo_fsm_inst_dispatch(fi, GPRS_SNS_EV_SELECT_ENDPOINT,
NULL);
+
osmo_fsm_inst_state_chg(fi, GPRS_SNS_ST_CONFIG_BSS,
nsi->timeout[NS_TOUT_TSNS_PROV], 2);
break;
}
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21575
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I00e9023a6e7adc6ad48f4016fcaef189ac8b353e
Gerrit-Change-Number: 21575
Gerrit-PatchSet: 12
Gerrit-Owner: lynxis lazus
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: lynxis lazus
Gerrit-MessageType: merged
Change in libosmocore[master]: gprs_ns2: make nsvc argument const
lynxis lazus has submitted this change. (
https://gerrit.osmocom.org/c/libosmocore/+/21652 )
Change subject: gprs_ns2: make nsvc argument const
..
gprs_ns2: make nsvc argument const
The nsvc isn't change. It can be const
Change-Id: Ie5052f02781d7fdc639456c6f02515a927cee1f3
---
M include/osmocom/gprs/gprs_ns2.h
M src/gb/gprs_ns2_fr.c
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/include/osmocom/gprs/gprs_ns2.h b/include/osmocom/gprs/gprs_ns2.h
index 8dd5699..ef9a56a 100644
--- a/include/osmocom/gprs/gprs_ns2.h
+++ b/include/osmocom/gprs/gprs_ns2.h
@@ -245,7 +245,7 @@
int dscp,
struct gprs_ns2_vc_bind **result);
int gprs_ns2_is_frgre_bind(struct gprs_ns2_vc_bind *bind);
-uint16_t gprs_ns2_fr_nsvc_dlci(struct gprs_ns2_vc *nsvc);
+uint16_t gprs_ns2_fr_nsvc_dlci(const struct gprs_ns2_vc *nsvc);
struct gprs_ns2_vc *gprs_ns2_nsvc_by_sockaddr_nse(
struct gprs_ns2_nse *nse,
diff --git a/src/gb/gprs_ns2_fr.c b/src/gb/gprs_ns2_fr.c
index b62b5af..925d5ed 100644
--- a/src/gb/gprs_ns2_fr.c
+++ b/src/gb/gprs_ns2_fr.c
@@ -714,7 +714,7 @@
* \param[in] nsvc
* \return the dlci or 0 on error. 0 is not a valid dlci.
*/
-uint16_t gprs_ns2_fr_nsvc_dlci(struct gprs_ns2_vc *nsvc)
+uint16_t gprs_ns2_fr_nsvc_dlci(const struct gprs_ns2_vc *nsvc)
{
struct priv_vc *vcpriv;
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21652
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ie5052f02781d7fdc639456c6f02515a927cee1f3
Gerrit-Change-Number: 21652
Gerrit-PatchSet: 5
Gerrit-Owner: lynxis lazus
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in libosmocore[master]: gprs_ns2_sns: use different binds for the initial connection
lynxis lazus has submitted this change. (
https://gerrit.osmocom.org/c/libosmocore/+/21574 )
Change subject: gprs_ns2_sns: use different binds for the initial connection
..
gprs_ns2_sns: use different binds for the initial connection
In case the first bind is not working the SNS would never build a
succesful connection to the SGSN. Iterate over all binds by
using an offset.
Instead of tracking the binds use an offset instead of a direct pointer.
This might result in skipping the order of the next bind.
Change-Id: I4a0a0608dac6ad8b5769ada2a14ca23f61eb0bcb
---
M src/gb/gprs_ns2_sns.c
1 file changed, 13 insertions(+), 2 deletions(-)
Approvals:
laforge: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/src/gb/gprs_ns2_sns.c b/src/gb/gprs_ns2_sns.c
index b7fbbf8..0676b61 100644
--- a/src/gb/gprs_ns2_sns.c
+++ b/src/gb/gprs_ns2_sns.c
@@ -117,6 +117,8 @@
struct sns_endpoint *initial;
/* all SNS PDU will be sent over this nsvc */
struct gprs_ns2_vc *sns_nsvc;
+ /* iterate over the binds after all remote has been tested */
+ int bind_offset;
/* local configuration to send to the remote end */
struct gprs_ns_ie_ip4_elem *ip4_local;
@@ -714,9 +716,15 @@
return;
}
- bind = ns2_ip_get_bind_by_index(nsi, remote, 0);
+ bind = ns2_ip_get_bind_by_index(nsi, remote, gss->bind_offset);
if (!bind) {
- return;
+ if (gss->bind_offset) {
+ gss->bind_offset = 0;
+ bind = ns2_ip_get_bind_by_index(nsi, remote,
gss->bind_offset);
+ }
+
+ if (!bind)
+ return;
}
/* setup the NSVC */
@@ -1335,9 +1343,12 @@
return;
} else if (!gss->initial) {
gss->initial = llist_first_entry(&gss->sns_endpoints,
struct sns_endpoint, list);
+ gss->bind_offset = 0;
} else if (gss->initial->list.next == &gss->sns_endpoints) {
/* last entry, continue with first */
gss->initial = llist_first_entry(&gss->sns_endpoints,
struct sns_endpoint, list);
+ gss->bind_offset++;
+ gss->bind_offset %= ns2_ip_count_bind(nse->nsi,
&gss->initial->saddr);
} else {
/* next element is an entry */
gss->initial = llist_entry(gss->initial->list.next,
struct sns_endpoint, list);
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21574
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I4a0a0608dac6ad8b5769ada2a14ca23f61eb0bcb
Gerrit-Change-Number: 21574
Gerrit-PatchSet: 12
Gerrit-Owner: lynxis lazus
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: lynxis lazus
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in libosmocore[master]: gprs_ns2_sns: rework IP-SNS initial remote
lynxis lazus has submitted this change. (
https://gerrit.osmocom.org/c/libosmocore/+/21573 )
Change subject: gprs_ns2_sns: rework IP-SNS initial remote
..
gprs_ns2_sns: rework IP-SNS initial remote
The IP-SNS requires at least one initial remote address of the SGSN.
However it should be multiple initial remote address instead of a single
in case the interface might fail.
Rework the SNS to support multiple initial remote addresses.
Change-Id: I71cdbfb53e361e6112fed5e2712236d797ef3ab2
---
M include/osmocom/gprs/gprs_ns2.h
M src/gb/gprs_ns2.c
M src/gb/gprs_ns2_internal.h
M src/gb/gprs_ns2_sns.c
M src/gb/gprs_ns2_udp.c
M src/gb/libosmogb.map
6 files changed, 364 insertions(+), 190 deletions(-)
Approvals:
laforge: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/include/osmocom/gprs/gprs_ns2.h b/include/osmocom/gprs/gprs_ns2.h
index 00879d7..8dd5699 100644
--- a/include/osmocom/gprs/gprs_ns2.h
+++ b/include/osmocom/gprs/gprs_ns2.h
@@ -82,6 +82,7 @@
/* osmocom own causes */
NS_AFF_CAUSE_SNS_CONFIGURED,
NS_AFF_CAUSE_SNS_FAILURE,
+ NS_AFF_CAUSE_SNS_NO_ENDPOINTS,
};
extern const struct value_string gprs_ns2_aff_cause_prim_strs[];
@@ -218,9 +219,11 @@
void gprs_ns2_free_binds(struct gprs_ns2_inst *nsi);
/* create a VC SNS connection */
-int gprs_ns2_ip_connect_sns(struct gprs_ns2_vc_bind *bind,
- const struct osmo_sockaddr *remote,
- uint16_t nsei);
+int gprs_ns2_sns_count(struct gprs_ns2_nse *nse);
+int gprs_ns2_sns_add_endpoint(struct gprs_ns2_nse *nse,
+ const struct osmo_sockaddr *saddr);
+int gprs_ns2_sns_del_endpoint(struct gprs_ns2_nse *nse,
+ const struct osmo_sockaddr *saddr);
const struct osmo_sockaddr *gprs_ns2_nse_sns_remote(struct gprs_ns2_nse *nse);
const struct osmo_sockaddr *gprs_ns2_ip_vc_remote(const struct gprs_ns2_vc
*nsvc);
diff --git a/src/gb/gprs_ns2.c b/src/gb/gprs_ns2.c
index 21c69cb..5e5dd83 100644
--- a/src/gb/gprs_ns2.c
+++ b/src/gb/gprs_ns2.c
@@ -953,42 +953,6 @@
return gprs_ns2_ip_connect(bind, remote, nse, nsvci);
}
-/*! Create, connect and activate a new IP-SNS NSE.
- * \param[in] bind bind in which the new NS-VC is to be created
- * \param[in] remote remote address to which to connect
- * \param[in] nsei NSEI of the NS Entity in which the NS-VC is to be created
- * \return 0 on success; negative on error */
-int gprs_ns2_ip_connect_sns(struct gprs_ns2_vc_bind *bind,
- const struct osmo_sockaddr *remote,
- uint16_t nsei)
-{
- struct gprs_ns2_nse *nse = gprs_ns2_nse_by_nsei(bind->nsi, nsei);
- struct gprs_ns2_vc *nsvc;
-
- if (!nse) {
- nse = gprs_ns2_create_nse(bind->nsi, nsei, GPRS_NS2_LL_UDP,
NS2_DIALECT_SNS);
- if (!nse)
- return -1;
- }
-
- if (nse->ll != GPRS_NS2_LL_UDP) {
- return -2;
- }
-
- if (nse->dialect != NS2_DIALECT_SNS) {
- return -2;
- }
-
- if (!nse->bss_sns_fi)
- return -1;
-
- nsvc = gprs_ns2_ip_bind_connect(bind, nse, remote);
- if (!nsvc)
- return -1;
-
- return ns2_sns_bss_fsm_start(nse, nsvc, remote);
-}
-
/*! Find NS-VC for given socket address.
* \param[in] nse NS Entity in which to search
* \param[in] sockaddr socket address to search for
diff --git a/src/gb/gprs_ns2_internal.h b/src/gb/gprs_ns2_internal.h
index 9bfe0b0..d12c663 100644
--- a/src/gb/gprs_ns2_internal.h
+++ b/src/gb/gprs_ns2_internal.h
@@ -286,13 +286,15 @@
struct gprs_ns2_vc *gprs_ns2_ip_bind_connect(struct gprs_ns2_vc_bind *bind,
struct gprs_ns2_nse *nse,
const struct osmo_sockaddr
*remote);
+int ns2_ip_count_bind(struct gprs_ns2_inst *nsi, struct osmo_sockaddr *remote);
+struct gprs_ns2_vc_bind *ns2_ip_get_bind_by_index(struct gprs_ns2_inst *nsi,
+ struct osmo_sockaddr *remote,
+ int index);
/* sns */
int gprs_ns2_sns_rx(struct gprs_ns2_vc *nsvc, struct msgb *msg, struct
tlv_parsed *tp);
struct osmo_fsm_inst *ns2_sns_bss_fsm_alloc(struct gprs_ns2_nse *nse,
const char *id);
-int ns2_sns_bss_fsm_start(struct gprs_ns2_nse *nse, struct gprs_ns2_vc *nsvc,
- const struct osmo_sockaddr *remote);
void ns2_sns_free_nsvc(struct gprs_ns2_vc *nsvc);
/* vc */
diff --git a/src/gb/gprs_ns2_sns.c b/src/gb/gprs_ns2_sns.c
index 5d18d04..b7fbbf8 100644
--- a/src/gb/gprs_ns2_sns.c
+++ b/src/gb/gprs_ns2_sns.c
@@ -69,7 +69,7 @@
};
enum gprs_sns_event {
- GPRS_SNS_EV_START,
+ GPRS_SNS
Change in libosmocore[master]: gprs_ns2: add gprs_ns2_free_nsvcs() to free all NS-VC of a NSE
lynxis lazus has submitted this change. (
https://gerrit.osmocom.org/c/libosmocore/+/21572 )
Change subject: gprs_ns2: add gprs_ns2_free_nsvcs() to free all NS-VC of a NSE
..
gprs_ns2: add gprs_ns2_free_nsvcs() to free all NS-VC of a NSE
Change-Id: I909443b540dbf75146297f1d7f94940690be6c0d
---
M include/osmocom/gprs/gprs_ns2.h
M src/gb/gprs_ns2.c
M src/gb/libosmogb.map
3 files changed, 18 insertions(+), 6 deletions(-)
Approvals:
laforge: Looks good to me, but someone else must approve
daniel: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/include/osmocom/gprs/gprs_ns2.h b/include/osmocom/gprs/gprs_ns2.h
index 41587d3..00879d7 100644
--- a/include/osmocom/gprs/gprs_ns2.h
+++ b/include/osmocom/gprs/gprs_ns2.h
@@ -160,6 +160,7 @@
/* create vc */
void gprs_ns2_free_nsvc(struct gprs_ns2_vc *nsvc);
+void gprs_ns2_free_nsvcs(struct gprs_ns2_nse *nse);
struct gprs_ns2_vc *gprs_ns2_nsvc_by_nsvci(struct gprs_ns2_inst *nsi, uint16_t
nsvci);
/* generic VL driver */
diff --git a/src/gb/gprs_ns2.c b/src/gb/gprs_ns2.c
index bd69acf..21c69cb 100644
--- a/src/gb/gprs_ns2.c
+++ b/src/gb/gprs_ns2.c
@@ -562,6 +562,21 @@
talloc_free(nsvc);
}
+/*! Destroy/release all NS-VC of given NSE
+ * \param[in] nse NSE
+ */
+void gprs_ns2_free_nsvcs(struct gprs_ns2_nse *nse)
+{
+ struct gprs_ns2_vc *nsvc, *tmp;
+
+ if (!nse)
+ return;
+
+ llist_for_each_entry_safe(nsvc, tmp, &nse->nsvc, list) {
+ gprs_ns2_free_nsvc(nsvc);
+ }
+}
+
/*! Allocate a message buffer for use with the NS2 stack. */
struct msgb *gprs_ns2_msgb_alloc(void)
{
@@ -722,15 +737,10 @@
* \param[in] nse NS Entity to destroy */
void gprs_ns2_free_nse(struct gprs_ns2_nse *nse)
{
- struct gprs_ns2_vc *nsvc, *tmp;
-
if (!nse)
return;
- llist_for_each_entry_safe(nsvc, tmp, &nse->nsvc, list) {
- gprs_ns2_free_nsvc(nsvc);
- }
-
+ gprs_ns2_free_nsvcs(nse);
ns2_prim_status_ind(nse, NULL, 0, NS_AFF_CAUSE_FAILURE);
llist_del(&nse->list);
diff --git a/src/gb/libosmogb.map b/src/gb/libosmogb.map
index 7cc1cc8..d4114df 100644
--- a/src/gb/libosmogb.map
+++ b/src/gb/libosmogb.map
@@ -120,6 +120,7 @@
gprs_ns2_free_nse;
gprs_ns2_free_nses;
gprs_ns2_free_nsvc;
+gprs_ns2_free_nsvcs;
gprs_ns2_frgre_bind;
gprs_ns2_fr_bind;
gprs_ns2_fr_bind_netif;
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21572
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I909443b540dbf75146297f1d7f94940690be6c0d
Gerrit-Change-Number: 21572
Gerrit-PatchSet: 12
Gerrit-Owner: lynxis lazus
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel
Gerrit-Reviewer: laforge
Gerrit-Reviewer: lynxis lazus
Gerrit-MessageType: merged
Change in libosmocore[master]: gprs_ns2: rework gprs_ns2_fr_connect*()
lynxis lazus has submitted this change. (
https://gerrit.osmocom.org/c/libosmocore/+/21486 )
Change subject: gprs_ns2: rework gprs_ns2_fr_connect*()
..
gprs_ns2: rework gprs_ns2_fr_connect*()
Add gprs_ns2_fr_connect2() and change gprs_ns2_fr_connect() to
be similar to gprs_ns2_ip_connect() and gprs_ns2_connect2().
This is an API break but there wasn't yet a release with NS2.
Change-Id: I4e1374b0e979b3293302c5ed46a91a58f3a5a916
---
M include/osmocom/gprs/gprs_ns2.h
M src/gb/gprs_ns2_fr.c
M src/gb/gprs_ns2_vty.c
3 files changed, 44 insertions(+), 1 deletion(-)
Approvals:
laforge: Looks good to me, but someone else must approve
daniel: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/include/osmocom/gprs/gprs_ns2.h b/include/osmocom/gprs/gprs_ns2.h
index 86bf1ae..41587d3 100644
--- a/include/osmocom/gprs/gprs_ns2.h
+++ b/include/osmocom/gprs/gprs_ns2.h
@@ -189,6 +189,10 @@
int gprs_ns2_is_fr_bind(struct gprs_ns2_vc_bind *bind);
struct gprs_ns2_vc *gprs_ns2_fr_nsvc_by_dlci(struct gprs_ns2_vc_bind *bind,
uint16_t dlci);
struct gprs_ns2_vc *gprs_ns2_fr_connect(struct gprs_ns2_vc_bind *bind,
+ struct gprs_ns2_nse *nse,
+ uint16_t nsvci,
+ uint16_t dlci);
+struct gprs_ns2_vc *gprs_ns2_fr_connect2(struct gprs_ns2_vc_bind *bind,
uint16_t nsei,
uint16_t nsvci,
uint16_t dlci);
diff --git a/src/gb/gprs_ns2_fr.c b/src/gb/gprs_ns2_fr.c
index 5da6fce..b62b5af 100644
--- a/src/gb/gprs_ns2_fr.c
+++ b/src/gb/gprs_ns2_fr.c
@@ -606,6 +606,45 @@
* \param[in] dlci Data Link connection identifier
* \return pointer to newly-allocated, connected and activated NS-VC; NULL on
error */
struct gprs_ns2_vc *gprs_ns2_fr_connect(struct gprs_ns2_vc_bind *bind,
+ struct gprs_ns2_nse *nse,
+ uint16_t nsvci,
+ uint16_t dlci)
+{
+ struct gprs_ns2_vc *nsvc = NULL;
+ struct priv_vc *priv = NULL;
+
+ nsvc = gprs_ns2_fr_nsvc_by_dlci(bind, dlci);
+ if (nsvc) {
+ goto err;
+ }
+
+ nsvc = ns2_vc_alloc(bind, nse, true, NS2_VC_MODE_BLOCKRESET);
+ if (!nsvc)
+ goto err;
+
+ nsvc->priv = priv = fr_alloc_vc(bind, nsvc, dlci);
+ if (!priv)
+ goto err;
+
+ nsvc->nsvci = nsvci;
+ nsvc->nsvci_is_valid = true;
+
+ gprs_ns2_vc_fsm_start(nsvc);
+
+ return nsvc;
+
+err:
+ gprs_ns2_free_nsvc(nsvc);
+ return NULL;
+}
+
+
+/*! Create, connect and activate a new FR-based NS-VC
+ * \param[in] bind bind in which the new NS-VC is to be created
+ * \param[in] nsei NSEI of the NS Entity in which the NS-VC is to be created
+ * \param[in] dlci Data Link connection identifier
+ * \return pointer to newly-allocated, connected and activated NS-VC; NULL on
error */
+struct gprs_ns2_vc *gprs_ns2_fr_connect2(struct gprs_ns2_vc_bind *bind,
uint16_t nsei,
uint16_t nsvci,
uint16_t dlci)
diff --git a/src/gb/gprs_ns2_vty.c b/src/gb/gprs_ns2_vty.c
index fdb6b0b..87284c2 100644
--- a/src/gb/gprs_ns2_vty.c
+++ b/src/gb/gprs_ns2_vty.c
@@ -969,7 +969,7 @@
}
}
- nsvc = gprs_ns2_fr_connect(fr, vtyvc->nsei,
vtyvc->nsvci, vtyvc->frdlci);
+ nsvc = gprs_ns2_fr_connect(fr, nse, vtyvc->nsvci,
vtyvc->frdlci);
if (!nsvc) {
/* Could not create NSVC, connect failed */
continue;
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21486
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I4e1374b0e979b3293302c5ed46a91a58f3a5a916
Gerrit-Change-Number: 21486
Gerrit-PatchSet: 12
Gerrit-Owner: lynxis lazus
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel
Gerrit-Reviewer: laforge
Gerrit-Reviewer: lynxis lazus
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in libosmocore[master]: gprs_ns2: move allocation of the SNS fsm into create_nse
lynxis lazus has submitted this change. (
https://gerrit.osmocom.org/c/libosmocore/+/21571 )
Change subject: gprs_ns2: move allocation of the SNS fsm into create_nse
..
gprs_ns2: move allocation of the SNS fsm into create_nse
The allocation of the SNS fsm can be done in create_nse
because the dialect is now known at that time.
Change-Id: I64e1f3dcc63d38e65bb486c9ac08d4032b7ad222
---
M src/gb/gprs_ns2.c
1 file changed, 13 insertions(+), 6 deletions(-)
Approvals:
laforge: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/src/gb/gprs_ns2.c b/src/gb/gprs_ns2.c
index 920fa68..890b656 100644
--- a/src/gb/gprs_ns2.c
+++ b/src/gb/gprs_ns2.c
@@ -677,6 +677,7 @@
enum gprs_ns2_ll linklayer, enum
gprs_ns2_dialect dialect)
{
struct gprs_ns2_nse *nse;
+ char sns[16];
nse = gprs_ns2_nse_by_nsei(nsi, nsei);
if (nse) {
@@ -688,6 +689,15 @@
if (!nse)
return NULL;
+ if (dialect == NS2_DIALECT_SNS) {
+ snprintf(sns, sizeof(sns), "NSE%05u-SNS", nsei);
+ nse->bss_sns_fi = ns2_sns_bss_fsm_alloc(nse, sns);
+ if (!nse->bss_sns_fi) {
+ talloc_free(nse);
+ return NULL;
+ }
+ }
+
nse->dialect = dialect;
nse->ll = linklayer;
nse->nsei = nsei;
@@ -959,14 +969,11 @@
return -2;
}
- nsvc = gprs_ns2_ip_bind_connect(bind, nse, remote);
- if (!nsvc)
+ if (!nse->bss_sns_fi)
return -1;
- if (!nse->bss_sns_fi)
- nse->bss_sns_fi = ns2_sns_bss_fsm_alloc(nse, NULL);
-
- if (!nse->bss_sns_fi)
+ nsvc = gprs_ns2_ip_bind_connect(bind, nse, remote);
+ if (!nsvc)
return -1;
return ns2_sns_bss_fsm_start(nse, nsvc, remote);
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21571
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I64e1f3dcc63d38e65bb486c9ac08d4032b7ad222
Gerrit-Change-Number: 21571
Gerrit-PatchSet: 8
Gerrit-Owner: lynxis lazus
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel
Gerrit-Reviewer: laforge
Gerrit-Reviewer: lynxis lazus
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in libosmocore[master]: gprs_ns2: add member name to bind
lynxis lazus has submitted this change. (
https://gerrit.osmocom.org/c/libosmocore/+/21485 )
Change subject: gprs_ns2: add member name to bind
..
gprs_ns2: add member name to bind
Every bind will have a unique name. Add a name argument
to all bind creating functions and require them to be unique.
This is an API break but there wasn't yet a release with NS2.
Change-Id: I8f1d66b7b3b12da12db8b5e6bd08c1beff085b3e
---
M include/osmocom/gprs/gprs_ns2.h
M src/gb/gprs_ns2.c
M src/gb/gprs_ns2_fr.c
M src/gb/gprs_ns2_frgre.c
M src/gb/gprs_ns2_internal.h
M src/gb/gprs_ns2_udp.c
M src/gb/gprs_ns2_vty.c
M src/gb/libosmogb.map
8 files changed, 75 insertions(+), 4 deletions(-)
Approvals:
laforge: Looks good to me, but someone else must approve
daniel: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/include/osmocom/gprs/gprs_ns2.h b/include/osmocom/gprs/gprs_ns2.h
index 6140da2..86bf1ae 100644
--- a/include/osmocom/gprs/gprs_ns2.h
+++ b/include/osmocom/gprs/gprs_ns2.h
@@ -162,8 +162,13 @@
void gprs_ns2_free_nsvc(struct gprs_ns2_vc *nsvc);
struct gprs_ns2_vc *gprs_ns2_nsvc_by_nsvci(struct gprs_ns2_inst *nsi, uint16_t
nsvci);
+/* generic VL driver */
+struct gprs_ns2_vc_bind *gprs_ns2_bind_by_name(struct gprs_ns2_inst *nsi,
+ const char *name);
+
/* IP VL driver */
int gprs_ns2_ip_bind(struct gprs_ns2_inst *nsi,
+const char *name,
const struct osmo_sockaddr *local,
int dscp,
struct gprs_ns2_vc_bind **result);
@@ -176,6 +181,7 @@
const char *netif);
const char *gprs_ns2_fr_bind_netif(struct gprs_ns2_vc_bind *bind);
int gprs_ns2_fr_bind(struct gprs_ns2_inst *nsi,
+const char *name,
const char *netif,
struct osmo_fr_network *fr_network,
enum osmo_fr_role fr_role,
@@ -226,6 +232,7 @@
const struct osmo_sockaddr *saddr);
int gprs_ns2_frgre_bind(struct gprs_ns2_inst *nsi,
+ const char *name,
const struct osmo_sockaddr *local,
int dscp,
struct gprs_ns2_vc_bind **result);
diff --git a/src/gb/gprs_ns2.c b/src/gb/gprs_ns2.c
index 890b656..bd69acf 100644
--- a/src/gb/gprs_ns2.c
+++ b/src/gb/gprs_ns2.c
@@ -1239,6 +1239,7 @@
bind->driver->free_bind(bind);
llist_del(&bind->list);
+ talloc_free((char *)bind->name);
talloc_free(bind);
}
@@ -1251,6 +1252,24 @@
}
}
+/*! Search for a bind with a unique name
+ * \param[in] nsi NS instance on which we operate
+ * \param[in] name The unique bind name to search for
+ * \return the bind or NULL if not found
+ */
+struct gprs_ns2_vc_bind *gprs_ns2_bind_by_name(
+ struct gprs_ns2_inst *nsi, const char *name)
+{
+ struct gprs_ns2_vc_bind *bind;
+
+ llist_for_each_entry(bind, &nsi->binding, list) {
+ if (!strcmp(bind->name, name))
+ return bind;
+ }
+
+ return NULL;
+}
+
enum gprs_ns2_vc_mode gprs_ns2_dialect_to_vc_mode(
enum gprs_ns2_dialect dialect)
{
diff --git a/src/gb/gprs_ns2_fr.c b/src/gb/gprs_ns2_fr.c
index 6b4fa52..5da6fce 100644
--- a/src/gb/gprs_ns2_fr.c
+++ b/src/gb/gprs_ns2_fr.c
@@ -453,19 +453,33 @@
* \param[out] result pointer to created bind
* \return 0 on success; negative on error */
int gprs_ns2_fr_bind(struct gprs_ns2_inst *nsi,
+const char *name,
const char *netif,
struct osmo_fr_network *fr_network,
enum osmo_fr_role fr_role,
struct gprs_ns2_vc_bind **result)
{
- struct gprs_ns2_vc_bind *bind = talloc_zero(nsi, struct
gprs_ns2_vc_bind);
+ struct gprs_ns2_vc_bind *bind;
struct priv_bind *priv;
struct osmo_fr_link *fr_link;
int rc = 0;
+ if (!name)
+ return -EINVAL;
+
+ if (gprs_ns2_bind_by_name(nsi, name))
+ return -EALREADY;
+
+ bind = talloc_zero(nsi, struct gprs_ns2_vc_bind);
if (!bind)
return -ENOSPC;
+ bind->name = talloc_strdup(bind, name);
+ if (!bind->name) {
+ rc = -ENOSPC;
+ goto err_bind;
+ }
+
bind->driver = &vc_driver_fr;
bind->ll = GPRS_NS2_LL_FR;
bind->send_vc = fr_vc_sendmsg;
@@ -475,7 +489,7 @@
priv = bind->priv = talloc_zero(bind, struct priv_bind);
if (!priv) {
rc = -ENOSPC;
- goto err_bind;
+ goto err_name;
}
priv->fd.cb = fr_fd_cb;
@@ -536,6 +550,8 @@
osmo_fr_link_free(fr_link);
err_priv:
talloc_free(priv);
+err_name:
+ talloc_free((char *)bind->name);
err_bind:
talloc_free(bind);
diff
Change in libosmocore[master]: gprs_ns2: introduce NS dialects
lynxis lazus has submitted this change. (
https://gerrit.osmocom.org/c/libosmocore/+/21484 )
Change subject: gprs_ns2: introduce NS dialects
..
gprs_ns2: introduce NS dialects
A NS dialect describes how the NS Entity interacts with
different virtual circuits. E.g. ipaccess use reset/block on udp
and is a dynamic connection.
A single NS Entity can only support one dialect. This can be later
used to protect a NS Entity against dynamic NS virtual circuits of a
different type.
It further allows a bind to support multiple dialects at the same time.
Change-Id: Ia118bb6f994845d84db09de7a94856f5ca573404
---
M include/osmocom/gprs/gprs_ns2.h
M src/gb/gprs_ns2.c
M src/gb/gprs_ns2_fr.c
M src/gb/gprs_ns2_frgre.c
M src/gb/gprs_ns2_internal.h
M src/gb/gprs_ns2_udp.c
M src/gb/gprs_ns2_vty.c
M src/gb/libosmogb.map
8 files changed, 79 insertions(+), 86 deletions(-)
Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/include/osmocom/gprs/gprs_ns2.h b/include/osmocom/gprs/gprs_ns2.h
index 4575329..6140da2 100644
--- a/include/osmocom/gprs/gprs_ns2.h
+++ b/include/osmocom/gprs/gprs_ns2.h
@@ -32,6 +32,14 @@
NS2_VC_MODE_ALIVE,
};
+enum gprs_ns2_dialect {
+ NS2_DIALECT_UNDEF,
+ NS2_DIALECT_STATIC_ALIVE,
+ NS2_DIALECT_STATIC_RESETBLOCK,
+ NS2_DIALECT_IPACCESS,
+ NS2_DIALECT_SNS,
+};
+
/*! Osmocom NS link layer types */
enum gprs_ns2_ll {
GPRS_NS2_LL_UDP,/*!< NS/UDP/IP */
@@ -144,7 +152,8 @@
gprs_ns2_foreach_nsvc_cb cb, void *cb_data);
struct gprs_ns2_nse *gprs_ns2_nse_by_nsei(struct gprs_ns2_inst *nsi, uint16_t
nsei);
struct gprs_ns2_nse *gprs_ns2_create_nse(struct gprs_ns2_inst *nsi, uint16_t
nsei,
-enum gprs_ns2_ll linklayer);
+enum gprs_ns2_ll linklayer,
+enum gprs_ns2_dialect dialect);
uint16_t gprs_ns2_nse_nsei(struct gprs_ns2_nse *nse);
void gprs_ns2_free_nse(struct gprs_ns2_nse *nse);
void gprs_ns2_free_nses(struct gprs_ns2_inst *nsi);
@@ -160,7 +169,6 @@
struct gprs_ns2_vc_bind **result);
struct gprs_ns2_vc_bind *gprs_ns2_ip_bind_by_sockaddr(struct gprs_ns2_inst
*nsi,
const struct
osmo_sockaddr *sockaddr);
-void gprs_ns2_bind_set_mode(struct gprs_ns2_vc_bind *bind, enum
gprs_ns2_vc_mode mode);
/* FR VL driver */
struct gprs_ns2_vc_bind *gprs_ns2_fr_bind_by_netif(
@@ -188,7 +196,8 @@
struct gprs_ns2_vc *gprs_ns2_ip_connect2(struct gprs_ns2_vc_bind *bind,
const struct osmo_sockaddr *remote,
uint16_t nsei,
-uint16_t nsvci);
+uint16_t nsvci,
+enum gprs_ns2_dialect dialect);
struct gprs_ns2_vc *gprs_ns2_ip_connect_inactive(struct gprs_ns2_vc_bind *bind,
const struct osmo_sockaddr *remote,
struct gprs_ns2_nse *nse,
@@ -238,7 +247,5 @@
int gprs_ns2_vty_init(struct gprs_ns2_inst *nsi,
const struct osmo_sockaddr_str *default_bind);
int gprs_ns2_vty_create();
-void gprs_ns2_vty_force_vc_mode(bool force, enum gprs_ns2_vc_mode mode, const
char *reason);
-
/*! @} */
diff --git a/src/gb/gprs_ns2.c b/src/gb/gprs_ns2.c
index d90ba85..920fa68 100644
--- a/src/gb/gprs_ns2.c
+++ b/src/gb/gprs_ns2.c
@@ -492,7 +492,8 @@
* \param[in] nse The NS Entity on which we operate
* \param[in] initiater - if this is an incoming remote (!initiater) or a
local outgoing connection (initater)
* \return newly allocated NS-VC on success; NULL on error */
-struct gprs_ns2_vc *ns2_vc_alloc(struct gprs_ns2_vc_bind *bind, struct
gprs_ns2_nse *nse, bool initiater)
+struct gprs_ns2_vc *ns2_vc_alloc(struct gprs_ns2_vc_bind *bind, struct
gprs_ns2_nse *nse, bool initiater,
+enum gprs_ns2_vc_mode vc_mode)
{
struct gprs_ns2_vc *nsvc = talloc_zero(bind, struct gprs_ns2_vc);
@@ -501,7 +502,7 @@
nsvc->bind = bind;
nsvc->nse = nse;
- nsvc->mode = bind->vc_mode;
+ nsvc->mode = vc_mode;
nsvc->sig_weight = 1;
nsvc->data_weight = 1;
@@ -672,7 +673,8 @@
* \param[in] nsi NS instance in which to create NS Entity
* \param[in] nsei NS Entity Identifier of to-be-created NSE
* \returns newly-allocated NS-E in successful case; NULL on error */
-struct gprs_ns2_nse *gprs_ns2_create_nse(struct gprs_ns2_inst *nsi, uint16_t
nsei, enum gprs_ns2_ll linklayer)
+struct gprs_ns2_nse *gprs_ns2_create_nse(struct gprs_ns2_inst *nsi, uint16_t
nsei,
+enum gprs_ns2_ll linklayer, enum
gprs_ns2_dialect dialect)
{
struct gprs_ns2_nse *nse
Change in osmo-sgsn[master]: sgsn: check for NULL of gprs_subscr_get_or_create()
lynxis lazus has submitted this change. (
https://gerrit.osmocom.org/c/osmo-sgsn/+/21639 )
Change subject: sgsn: check for NULL of gprs_subscr_get_or_create()
..
sgsn: check for NULL of gprs_subscr_get_or_create()
gprs_subscr_get_or_create() can return NULL if no memory can
be allocated. Detected by the compiler on Ubuntu s390x.
Signed-off-by: Steve Langasek
Signed-off-by: Alexander Couzens
Change-Id: I86b3652d46bdd581fe6cbab16b52395a0daaa082
---
M src/sgsn/gprs_subscriber.c
M src/sgsn/sgsn_vty.c
2 files changed, 10 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
daniel: Looks good to me, approved
diff --git a/src/sgsn/gprs_subscriber.c b/src/sgsn/gprs_subscriber.c
index c23b332..943fbc3 100644
--- a/src/sgsn/gprs_subscriber.c
+++ b/src/sgsn/gprs_subscriber.c
@@ -870,6 +870,8 @@
if (!subscr) {
subscr = gprs_subscr_get_or_create(mmctx->imsi);
+ if (!subscr)
+ return NULL;
subscr->flags |= GPRS_SUBSCRIBER_FIRST_CONTACT;
subscr->flags &= ~GPRS_SUBSCRIBER_ENABLE_PURGE;
}
@@ -893,6 +895,8 @@
LOGMMCTXP(LOGL_DEBUG, mmctx, "Requesting subscriber data update\n");
subscr = gprs_subscr_get_or_create_by_mmctx(mmctx);
+ if (!subscr)
+ return -ENOMEM;
subscr->flags |= GPRS_SUBSCRIBER_UPDATE_LOCATION_PENDING;
@@ -918,6 +922,8 @@
LOGMMCTXP(LOGL_DEBUG, mmctx, "Requesting subscriber authentication
info\n");
subscr = gprs_subscr_get_or_create_by_mmctx(mmctx);
+ if (!subscr)
+ return -ENOMEM;
subscr->flags |= GPRS_SUBSCRIBER_UPDATE_AUTH_INFO_PENDING;
diff --git a/src/sgsn/sgsn_vty.c b/src/sgsn/sgsn_vty.c
index 33a652c..fee328e 100644
--- a/src/sgsn/sgsn_vty.c
+++ b/src/sgsn/sgsn_vty.c
@@ -1020,6 +1020,10 @@
}
subscr = gprs_subscr_get_or_create(imsi);
+ if (!subscr) {
+ vty_out(vty, "Can not create subscriber. Out of memory.%s",
imsi);
+ return CMD_WARNING;
+ }
subscr->keep_in_ram = 1;
gprs_subscr_put(subscr);
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21639
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I86b3652d46bdd581fe6cbab16b52395a0daaa082
Gerrit-Change-Number: 21639
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel
Gerrit-Reviewer: laforge
Gerrit-Reviewer: lynxis lazus
Gerrit-MessageType: merged
Change in osmo-sgsn[master]: sgsn: check for NULL of gprs_subscr_get_or_create()
lynxis lazus has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-sgsn/+/21639 )
Change subject: sgsn: check for NULL of gprs_subscr_get_or_create()
..
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/c/osmo-sgsn/+/21639/2/src/sgsn/sgsn_vty.c
File src/sgsn/sgsn_vty.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/21639/2/src/sgsn/sgsn_vty.c@1023
PS2, Line 1023: if (subscr) {
> Missing "!"!!
Ack
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21639
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I86b3652d46bdd581fe6cbab16b52395a0daaa082
Gerrit-Change-Number: 21639
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel
Gerrit-Reviewer: laforge
Gerrit-Comment-Date: Tue, 15 Dec 2020 11:45:22 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: daniel
Gerrit-MessageType: comment
Change in docker-playground[master]: Introduce osmo-ran docker image set up
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/21263 ) Change subject: Introduce osmo-ran docker image set up .. Patch Set 6: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/21263 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If5d22e9fa818310cbb4adc34bd7aceb4416ec969 Gerrit-Change-Number: 21263 Gerrit-PatchSet: 6 Gerrit-Owner: pespin Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 15 Dec 2020 11:30:30 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-sgsn[master]: sgsn: Use the new NS2 api
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/20397 ) Change subject: sgsn: Use the new NS2 api .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/20397 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I92a3bcaf166b091a22d74c7c1586964d33d7cc9d Gerrit-Change-Number: 20397 Gerrit-PatchSet: 8 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 15 Dec 2020 11:17:58 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-sgsn[master]: sgsn: Use the new NS2 api
Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/20397 to look at the new patch set (#8). Change subject: sgsn: Use the new NS2 api .. sgsn: Use the new NS2 api The new NS2 api supports NSE with multiple NS-VC and contains a NS-VC fsm. FR/GRE support is not working. The configuration is compatible except for FR/GRE. Relates: OS#4629 Depends-on: Iaad7b53d44338e5dd81dc2202f23bdcb715af804 (libosmocore) Depends-on: I6cef42749555e577d5573f2ed8b8bce4cf842a98 (libosmocore) Change-Id: I92a3bcaf166b091a22d74c7c1586964d33d7cc9d --- M include/osmocom/sgsn/gprs_gb.h M include/osmocom/sgsn/sgsn.h M src/gprs/gprs_utils.c M src/sgsn/gprs_gb.c M src/sgsn/gprs_ranap.c M src/sgsn/gprs_sgsn.c M src/sgsn/sgsn_main.c M src/sgsn/sgsn_vty.c M tests/vty_test_runner.py 9 files changed, 117 insertions(+), 61 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/97/20397/8 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/20397 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I92a3bcaf166b091a22d74c7c1586964d33d7cc9d Gerrit-Change-Number: 20397 Gerrit-PatchSet: 8 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmo-sgsn[master]: sgsn: check for NULL of gprs_subscr_get_or_create()
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/21639 ) Change subject: sgsn: check for NULL of gprs_subscr_get_or_create() .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21639 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I86b3652d46bdd581fe6cbab16b52395a0daaa082 Gerrit-Change-Number: 21639 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 15 Dec 2020 11:06:18 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: gprs_bssgp: add handling for BSSGP RIM primitives
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21722 ) Change subject: gprs_bssgp: add handling for BSSGP RIM primitives .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/21722/1/include/osmocom/gprs/gprs_bssgp.h File include/osmocom/gprs/gprs_bssgp.h: https://gerrit.osmocom.org/c/libosmocore/+/21722/1/include/osmocom/gprs/gprs_bssgp.h@59 PS1, Line 59: PRIM_BSSGP_RIM Add , at the end. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21722 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Idfd0a65872a2cc6089885afd8d31b0b029d85d47 Gerrit-Change-Number: 21722 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 15 Dec 2020 10:59:00 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-sgsn[master]: sgsn: check for NULL of gprs_subscr_get_or_create()
Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21639 to look at the new patch set (#3). Change subject: sgsn: check for NULL of gprs_subscr_get_or_create() .. sgsn: check for NULL of gprs_subscr_get_or_create() gprs_subscr_get_or_create() can return NULL if no memory can be allocated. Detected by the compiler on Ubuntu s390x. Signed-off-by: Steve Langasek Signed-off-by: Alexander Couzens Change-Id: I86b3652d46bdd581fe6cbab16b52395a0daaa082 --- M src/sgsn/gprs_subscriber.c M src/sgsn/sgsn_vty.c 2 files changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/39/21639/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21639 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I86b3652d46bdd581fe6cbab16b52395a0daaa082 Gerrit-Change-Number: 21639 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: daniel Gerrit-MessageType: newpatchset
Change in libosmocore[master]: gprs_bssgp: add IE parser for RIM Routing Information
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21721 ) Change subject: gprs_bssgp: add IE parser for RIM Routing Information .. Patch Set 1: Code-Review-1 (7 comments) https://gerrit.osmocom.org/c/libosmocore/+/21721/1/src/gb/gprs_bssgp.c File src/gb/gprs_bssgp.c: https://gerrit.osmocom.org/c/libosmocore/+/21721/1/src/gb/gprs_bssgp.c@340 PS1, Line 340: return 0; -EINVAL? https://gerrit.osmocom.org/c/libosmocore/+/21721/1/src/gb/gprs_bssgp.c@347 PS1, Line 347: return -1; return codes are not marching documentation. https://gerrit.osmocom.org/c/libosmocore/+/21721/1/src/gb/gprs_bssgp.c@350 PS1, Line 350: break; unneeded break. https://gerrit.osmocom.org/c/libosmocore/+/21721/1/src/gb/gprs_bssgp.c@357 PS1, Line 357: break; uneeded break. https://gerrit.osmocom.org/c/libosmocore/+/21721/1/src/gb/gprs_bssgp.c@359 PS1, Line 359: if (len < 7) You can probable merge both conditions in one if. https://gerrit.osmocom.org/c/libosmocore/+/21721/1/src/gb/gprs_bssgp.c@374 PS1, Line 374: break; unneeded break https://gerrit.osmocom.org/c/libosmocore/+/21721/1/src/gb/gprs_bssgp.c@379 PS1, Line 379: return 0; This cannot happen, you can remove it (or remove default above) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21721 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6f88a9aeeb50a612d32e9efd23040c9740bc4f11 Gerrit-Change-Number: 21721 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Tue, 15 Dec 2020 10:56:46 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: gprs_ns2: improve handling of TLV errors on new nsvcs
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21724 ) Change subject: gprs_ns2: improve handling of TLV errors on new nsvcs .. Patch Set 2: Code-Review-1 (1 comment) Looks like this commit needs more work. https://gerrit.osmocom.org/c/libosmocore/+/21724/2/src/gb/gprs_ns2.c File src/gb/gprs_ns2.c: https://gerrit.osmocom.org/c/libosmocore/+/21724/2/src/gb/gprs_ns2.c@807 PS2, Line 807: rc = reject_status_msg(msg, &tp, reject, NS_CAUSE_PDU_INCOMP_PSTATE); so you may end up passing &tp in an incorrect/unknwon state here? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21724 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2992d06b37ed122b7ff315d4852e86acc936800b Gerrit-Change-Number: 21724 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 15 Dec 2020 10:49:32 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: gprs_ns2: on ns2_create_vc parse the tlv before using it
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21723 ) Change subject: gprs_ns2: on ns2_create_vc parse the tlv before using it .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21723 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I82cab518966b8b49c3522ff5f7b6f82d1027a526 Gerrit-Change-Number: 21723 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 15 Dec 2020 10:46:35 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-e1-hardware[master]: icE1usb fw: Have e1_rx_need_data() optionally return FIFO position
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21716 ) Change subject: icE1usb fw: Have e1_rx_need_data() optionally return FIFO position .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21716 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: I9e59d86a2e8f4e85ca84c592438ad79966b49448 Gerrit-Change-Number: 21716 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: pespin Gerrit-Reviewer: tnt Gerrit-Comment-Date: Tue, 15 Dec 2020 10:42:36 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-e1-hardware[master]: icE1usb fw: Expose error conditions from E1 driver
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21715 ) Change subject: icE1usb fw: Expose error conditions from E1 driver .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21715 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: Iba3e00a2b28a2fef6dbd986bfc706c1619c3a3ed Gerrit-Change-Number: 21715 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: pespin Gerrit-Reviewer: tnt Gerrit-Comment-Date: Tue, 15 Dec 2020 10:42:01 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-e1-hardware[master]: icE1usb: Use register bit #define instead of magic number
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21707 ) Change subject: icE1usb: Use register bit #define instead of magic number .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21707 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: Ic824ce5a6605c96989fefbf92f365bff618dccb2 Gerrit-Change-Number: 21707 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: pespin Gerrit-Reviewer: tnt Gerrit-Comment-Date: Tue, 15 Dec 2020 10:41:14 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-e1-hardware[master]: ice1usb: define e1_data_ptr() using e1_data_ofs()
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21706 ) Change subject: ice1usb: define e1_data_ptr() using e1_data_ofs() .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21706 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: I9a6cce07ea8b6eff1527215de00621da960b0472 Gerrit-Change-Number: 21706 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: pespin Gerrit-Reviewer: tnt Gerrit-Comment-Date: Tue, 15 Dec 2020 10:41:06 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-e1-hardware[master]: cosmetic: more comments in the code
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21704 ) Change subject: cosmetic: more comments in the code .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21704 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: I445bb2f92b6dcfe29ac20109ea2e63efb31051a1 Gerrit-Change-Number: 21704 Gerrit-PatchSet: 3 Gerrit-Owner: laforge Gerrit-Reviewer: pespin Gerrit-Reviewer: tnt Gerrit-Comment-Date: Tue, 15 Dec 2020 10:39:42 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-sgsn[master]: sgsn: check for NULL of gprs_subscr_get_or_create()
daniel has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-sgsn/+/21639 )
Change subject: sgsn: check for NULL of gprs_subscr_get_or_create()
..
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/c/osmo-sgsn/+/21639/2/src/sgsn/sgsn_vty.c
File src/sgsn/sgsn_vty.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/21639/2/src/sgsn/sgsn_vty.c@1023
PS2, Line 1023: if (subscr) {
Missing "!"!!
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21639
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I86b3652d46bdd581fe6cbab16b52395a0daaa082
Gerrit-Change-Number: 21639
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-CC: daniel
Gerrit-Comment-Date: Tue, 15 Dec 2020 10:35:36 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Build failure of network:osmocom:nightly/osmo-sip-connector in Raspbian_10/armv7l
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sip-connector/Raspbian_10/armv7l Package network:osmocom:nightly/osmo-sip-connector failed to build in Raspbian_10/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-sip-connector Last lines of build log: getoldpackages: connect to back-other-opensuse:5253: Connection timed out (worker was obs-arm-5:7) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Change in libosmocore[master]: protocol/gsm_08_58.h: add Osmocom specific EWMA AVG algo
laforge has submitted this change. (
https://gerrit.osmocom.org/c/libosmocore/+/21727 )
Change subject: protocol/gsm_08_58.h: add Osmocom specific EWMA AVG algo
..
protocol/gsm_08_58.h: add Osmocom specific EWMA AVG algo
Change-Id: Ib436fd8b81afdb06c6d936f6839f847a705d00e2
Related: SYS#4918
---
M include/osmocom/gsm/protocol/gsm_08_58.h
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/include/osmocom/gsm/protocol/gsm_08_58.h
b/include/osmocom/gsm/protocol/gsm_08_58.h
index aeaa6ff..0f7af92 100644
--- a/include/osmocom/gsm/protocol/gsm_08_58.h
+++ b/include/osmocom/gsm/protocol/gsm_08_58.h
@@ -406,7 +406,9 @@
enum {
IPAC_UNWEIGHTED_AVE = 0,
IPAC_WEIGHTED_AVE,
- IPAC_MEDIAN_AVE
+ IPAC_MEDIAN_AVE,
+ /* EWMA is an Osmocom specific extension */
+ IPAC_OSMO_EWMA_AVE,
};
/* IPAC MEAS_PREPROC AVERAGING PARAMID */
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21727
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib436fd8b81afdb06c6d936f6839f847a705d00e2
Gerrit-Change-Number: 21727
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-MessageType: merged
Change in libosmocore[master]: protocol/gsm_08_58.h: add ip.access Power Control structures
laforge has submitted this change. (
https://gerrit.osmocom.org/c/libosmocore/+/21726 )
Change subject: protocol/gsm_08_58.h: add ip.access Power Control structures
..
protocol/gsm_08_58.h: add ip.access Power Control structures
Change-Id: I9430bcb79c269efb4f9527f565cf4e12e940
Related: SYS#4918
---
M include/osmocom/gsm/protocol/gsm_08_58.h
1 file changed, 44 insertions(+), 0 deletions(-)
Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/include/osmocom/gsm/protocol/gsm_08_58.h
b/include/osmocom/gsm/protocol/gsm_08_58.h
index 1ed4438..aeaa6ff 100644
--- a/include/osmocom/gsm/protocol/gsm_08_58.h
+++ b/include/osmocom/gsm/protocol/gsm_08_58.h
@@ -780,6 +780,22 @@
#endif
}__attribute__ ((packed));
+/*! MS/BS Power Control Thresholds */
+struct ipac_preproc_pc_thresh {
+#if OSMO_IS_LITTLE_ENDIAN
+ uint8_t l_rxlev:6, reserved_l_rxlev:2;
+ uint8_t u_rxlev:6, reserved_u_rxlev:2;
+ uint8_t l_rxqual:3, reserved_l_rxqual:1,
+ u_rxqual:3, reserved_u_rxqual:1;
+#elif OSMO_IS_BIG_ENDIAN
+ uint8_t reserved_l_rxlev:2, l_rxlev:6;
+ uint8_t reserved_u_rxlev:2, u_rxlev:6;
+ uint8_t reserved_l_rxqual:1, l_rxqual:3,
+ reserved_u_rxqual:1, u_rxqual:3;
+#endif
+}__attribute__ ((packed));
+
+/*! Handover Thresholds */
struct ipac_preproc_ho_thresh {
#if OSMO_IS_LITTLE_ENDIAN
uint8_t l_rxlev_ul_h:6,
@@ -807,6 +823,34 @@
#endif
}__attribute__ ((packed));
+/*! PC Threshold Comparators */
+struct ipac_preproc_pc_comp {
+#if OSMO_IS_LITTLE_ENDIAN
+ uint8_t p1:5, reserved_p1:3;
+ uint8_t n1:5, reserved_n1:3;
+ uint8_t p2:5, reserved_p2:3;
+ uint8_t n2:5, reserved_n2:3;
+ uint8_t p3:5, reserved_p3:3;
+ uint8_t n3:5, reserved_n3:3;
+ uint8_t p4:5, reserved_p4:3;
+ uint8_t n4:5, reserved_n4:3;
+ uint8_t pc_interval:5, reserved_pc:3;
+ uint8_t red_step_size:4, inc_step_size:4;
+#elif OSMO_IS_BIG_ENDIAN
+ uint8_t reserved_p1:3, p1:5;
+ uint8_t reserved_n1:3, n1:5;
+ uint8_t reserved_p2:3, p2:5;
+ uint8_t reserved_n2:3, n2:5;
+ uint8_t reserved_p3:3, p3:5;
+ uint8_t reserved_n3:3, n3:5;
+ uint8_t reserved_p4:3, p4:5;
+ uint8_t reserved_n4:3, n4:5;
+ uint8_t reserved_pc:3, pc_interval:5;
+ uint8_t inc_step_size:4, red_step_size:4;
+#endif
+}__attribute__ ((packed));
+
+/*! HO Threshold Comparators */
struct ipac_preproc_ho_comp {
#if OSMO_IS_LITTLE_ENDIAN
uint8_t p5:5,
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21726
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I9430bcb79c269efb4f9527f565cf4e12e940
Gerrit-Change-Number: 21726
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-MessageType: merged
Change in libosmocore[master]: protocol/gsm_08_58.h: add ip.access Power Control structures
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21726 ) Change subject: protocol/gsm_08_58.h: add ip.access Power Control structures .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21726 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9430bcb79c269efb4f9527f565cf4e12e940 Gerrit-Change-Number: 21726 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 15 Dec 2020 09:52:24 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: protocol/gsm_08_58.h: add Osmocom specific EWMA AVG algo
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21727 ) Change subject: protocol/gsm_08_58.h: add Osmocom specific EWMA AVG algo .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21727 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib436fd8b81afdb06c6d936f6839f847a705d00e2 Gerrit-Change-Number: 21727 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 15 Dec 2020 09:52:18 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: gprs_ns2: introduce NS dialects
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21484 ) Change subject: gprs_ns2: introduce NS dialects .. Patch Set 10: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21484 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia118bb6f994845d84db09de7a94856f5ca573404 Gerrit-Change-Number: 21484 Gerrit-PatchSet: 10 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 15 Dec 2020 09:49:47 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: gprs_ns2: introduce NS dialects
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21484 ) Change subject: gprs_ns2: introduce NS dialects .. Patch Set 10: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21484 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia118bb6f994845d84db09de7a94856f5ca573404 Gerrit-Change-Number: 21484 Gerrit-PatchSet: 10 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 15 Dec 2020 09:49:40 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: GPRS Cell Options (SI13): Add REL-4 CCN_ACTIVE bit
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21713 ) Change subject: GPRS Cell Options (SI13): Add REL-4 CCN_ACTIVE bit .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21713 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2aaa8c1107c977f711c2d7530034f57e36e3a237 Gerrit-Change-Number: 21713 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 15 Dec 2020 09:48:33 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: gsm: append_eutran_neib_cell: Fix SI2quater EARFCN list
laforge has submitted this change. (
https://gerrit.osmocom.org/c/libosmocore/+/21712 )
Change subject: gsm: append_eutran_neib_cell: Fix SI2quater EARFCN list
..
gsm: append_eutran_neib_cell: Fix SI2quater EARFCN list
Commit bd6e7a9f2dd5d4e881a0a21ebdb29b7a76ebdc9a did the initial porting
of rest_octet APIs from osmo-bsc, but introduced a bug when moving
bts->e_offset to a generic pointer independent of bts structure.
As a result, using this API from osmo-bsc makes gsm0408 unit test fail
due to bad encoding of several EARFCNs in si2quater.
Fixes: bd6e7a9f2dd5d4e881a0a21ebdb29b7a76ebdc9a
Change-Id: I2bf5635b8536b11d69774d17ac1908019633e3af
---
M src/gsm/gsm48_rest_octets.c
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/src/gsm/gsm48_rest_octets.c b/src/gsm/gsm48_rest_octets.c
index 5c7d77a..1f9c2b5 100644
--- a/src/gsm/gsm48_rest_octets.c
+++ b/src/gsm/gsm48_rest_octets.c
@@ -64,6 +64,7 @@
uint8_t budget)
{
unsigned i, skip = 0;
+ size_t offset = *e_offset;
int16_t rem = budget - 6; /* account for mandatory stop bit and
THRESH_E-UTRAN_high */
uint8_t earfcn_budget;
@@ -94,7 +95,7 @@
/* now we can proceed with actually adding EARFCNs within adjusted
budget limit */
for (i = 0; i < e->length; i++) {
if (e->arfcn[i] != OSMO_EARFCN_INVALID) {
- if (skip < *e_offset) {
+ if (skip < offset) {
skip++; /* ignore EARFCNs added on previous
calls */
} else {
earfcn_budget = 17; /* compute budget
per-EARFCN */
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21712
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I2bf5635b8536b11d69774d17ac1908019633e3af
Gerrit-Change-Number: 21712
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: neels
Gerrit-MessageType: merged
Change in libosmocore[master]: si2quater: fix budget calculation for multiple EARFCNs
laforge has submitted this change. (
https://gerrit.osmocom.org/c/libosmocore/+/21710 )
Change subject: si2quater: fix budget calculation for multiple EARFCNs
..
si2quater: fix budget calculation for multiple EARFCNs
In rest_octets.c append_earfcn(), the unconditional bits added are 40, not 25.
Removing only 25 bits from the budget resulted in malformed SI2quater starting
with 4 configured EARFCNs, by adding more EARFCNs than fit in 20 bits.
These malformed SI2quater were also expected in gsm0408_test.c. Update the
expected SI2quater to what is being generated now. This patch passes the ttcn3
testing added in I45382f88686ca60e68569e93569fc4cfb63a0e0d, which provides some
confidence that the coding expected in gsm0408_test.c is now correct.
This commit is a cherry-pick of osmo-bsc.git
6589f7c3a8dfdaaf66dda3afa6bbb1118ec825f9
Change-Id: Icc1ece39ad162d09720e104c5cbc12b07d6771a8
Related: OS#4652
---
M src/gsm/gsm48_rest_octets.c
1 file changed, 9 insertions(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, approved
diff --git a/src/gsm/gsm48_rest_octets.c b/src/gsm/gsm48_rest_octets.c
index 84b7589..5c7d77a 100644
--- a/src/gsm/gsm48_rest_octets.c
+++ b/src/gsm/gsm48_rest_octets.c
@@ -165,7 +165,7 @@
{
bool appended;
unsigned int old = bv->cur_bit; /* save current position to make
rollback possible */
- int rem = budget - 25;
+ int rem = ((int)budget) - 40;
if (rem <= 0)
return;
@@ -193,6 +193,8 @@
/* Priority and E-UTRAN Parameters Description */
bitvec_set_bit(bv, 1);
+ /* budget: 10 bits used above */
+
/* Serving Cell Priority Parameters Descr. is Present,
* see also: 3GPP TS 44.018, Table 10.5.2.33b.1 */
bitvec_set_bit(bv, 1);
@@ -212,6 +214,8 @@
/* T_Reselection */
bitvec_set_uint(bv, 0, 2);
+ /* budget: 26 bits used above */
+
/* No 3G Priority Parameters Description */
bitvec_set_bit(bv, 0);
/* E-UTRAN Parameters Description */
@@ -235,12 +239,16 @@
/* Repeated E-UTRAN Neighbour Cells */
bitvec_set_bit(bv, 1);
+ /* budget: 34 bits used above */
+
appended = append_eutran_neib_cell(bv, e, e_offset, rem);
if (!appended) { /* appending is impossible within current budget:
rollback */
bv->cur_bit = old;
return;
}
+ /* budget: further 6 bits used below, totalling 40 bits */
+
/* stop bit - end of Repeated E-UTRAN Neighbour Cells sequence: */
bitvec_set_bit(bv, 0);
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21710
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Icc1ece39ad162d09720e104c5cbc12b07d6771a8
Gerrit-Change-Number: 21710
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: laforge
Gerrit-Reviewer: neels
Gerrit-MessageType: merged
Change in libosmocore[master]: gsm: si13: Fix encode of EGPRS_PACKET_CHANNEL_REQUEST
laforge has submitted this change. (
https://gerrit.osmocom.org/c/libosmocore/+/21709 )
Change subject: gsm: si13: Fix encode of EGPRS_PACKET_CHANNEL_REQUEST
..
gsm: si13: Fix encode of EGPRS_PACKET_CHANNEL_REQUEST
Cherry-pick from osmo-bsc.git e981f17200bf3a5d5114f46d9f7515fd10b96dbb
Change-Id: I0aae385a427205cc73f60feca161e38608e608d8
---
M src/gsm/gsm48_rest_octets.c
1 file changed, 2 insertions(+), 7 deletions(-)
Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, approved
diff --git a/src/gsm/gsm48_rest_octets.c b/src/gsm/gsm48_rest_octets.c
index dd14d28..84b7589 100644
--- a/src/gsm/gsm48_rest_octets.c
+++ b/src/gsm/gsm48_rest_octets.c
@@ -909,13 +909,8 @@
/* EGPRS supported in the cell */
bitvec_set_bit(bv, 1);
- /* 1bit EGPRS PACKET CHANNEL REQUEST */
- if (gco->supports_egprs_11bit_rach == 0) {
- bitvec_set_bit(bv,
- gco->ext_info.use_egprs_p_ch_req);
- } else {
- bitvec_set_bit(bv, 0);
- }
+ /* 1bit EGPRS PACKET CHANNEL REQUEST (inverted logic) */
+ bitvec_set_bit(bv, !gco->ext_info.use_egprs_p_ch_req);
/* 4bit BEP PERIOD */
bitvec_set_uint(bv, gco->ext_info.bep_period, 4);
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21709
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I0aae385a427205cc73f60feca161e38608e608d8
Gerrit-Change-Number: 21709
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: laforge
Gerrit-MessageType: merged
Change in libosmocore[master]: rest_octets: add Serving Cell Priority Parameters
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21708 ) Change subject: rest_octets: add Serving Cell Priority Parameters .. rest_octets: add Serving Cell Priority Parameters When we add an EARFCN to to the SI2quater struct we do not add Serving Cell Priority Parameters. This essentially causes to MS to ignore the EARFCN because it is still undefined under which conditions the MS should change to LTE. This is a cherry-pick from osmo-bsc.git 295c965c063a8c431507191f6aef1ef78b720685 Related: SYS#4510 Change-Id: If9134759e9bc4ae0920800972632fd8c5dc9c2d9 --- M src/gsm/gsm48_rest_octets.c 1 file changed, 19 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved dexter: Looks good to me, but someone else must approve diff --git a/src/gsm/gsm48_rest_octets.c b/src/gsm/gsm48_rest_octets.c index a527598..dd14d28 100644 --- a/src/gsm/gsm48_rest_octets.c +++ b/src/gsm/gsm48_rest_octets.c @@ -193,8 +193,25 @@ /* Priority and E-UTRAN Parameters Description */ bitvec_set_bit(bv, 1); - /* No Serving Cell Priority Parameters Descr. */ - bitvec_set_bit(bv, 0); + /* Serving Cell Priority Parameters Descr. is Present, + * see also: 3GPP TS 44.018, Table 10.5.2.33b.1 */ + bitvec_set_bit(bv, 1); + + /* GERAN_PRIORITY */ + bitvec_set_uint(bv, 0, 3); + + /* THRESH_Priority_Search */ + bitvec_set_uint(bv, 0, 4); + + /* THRESH_GSM_low */ + bitvec_set_uint(bv, 0, 4); + + /* H_PRIO */ + bitvec_set_uint(bv, 0, 2); + + /* T_Reselection */ + bitvec_set_uint(bv, 0, 2); + /* No 3G Priority Parameters Description */ bitvec_set_bit(bv, 0); /* E-UTRAN Parameters Description */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21708 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If9134759e9bc4ae0920800972632fd8c5dc9c2d9 Gerrit-Change-Number: 21708 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: merged
