Build failure of network:osmocom:latest/osmo-iuh in Debian_Unstable/x86_64

2021-01-08 Thread OBS Notification
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-iuh/Debian_Unstable/x86_64

Package network:osmocom:latest/osmo-iuh failed to build in 
Debian_Unstable/x86_64

Check out the package for editing:
  osc checkout network:osmocom:latest osmo-iuh

Last lines of build log:
1-ranap.a/RANAP_RAB-SetupItem-RelocReq.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-SetupItem-RelocReqAck.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-SetupList-EnhRelocInfoReq.o
 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-SetupList-EnhRelocInfoRes.o
 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-SetupList-EnhancedRelocCompleteReq.o
 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-SetupList-EnhancedRelocCompleteRes.o
 .libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-SetupList-RelocReq.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-SetupList-RelocReqAck.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-SetupOrModifiedItem.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-SetupOrModifiedList.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-SetupOrModifyItemFirst.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-SetupOrModifyItemSecond.o
 .libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-SetupOrModifyList.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-SubflowCombinationBitRate.o
 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-ToBeReleasedItem-EnhancedRelocCompleteRes.o
 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-ToBeReleasedList-EnhancedRelocCompleteRes.o
 .libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-TrCH-Mapping.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-TrCH-MappingItem.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RABDataVolumeReport.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RABParametersList.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RABased.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RABs-ContextFailedtoTransferItem.o
 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RABs-ContextFailedtoTransferList.o
 .libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RABs-failed-to-reportItem.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RABs-failed-to-reportList.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAC.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAI-List.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAI.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAListofIdleModeUEs.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAListwithNoIdleModeUEsAnyMore.o
 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RANAP-EnhancedRelocationInformationRequest.o
 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RANAP-EnhancedRelocationInformationResponse.o
 .libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RANAP-PDU.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RANAP-RelocationInformation.o
 .libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAT-Type.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAofIdleModeUEs.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RIM-Transfer.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RIMInformation.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RIMRoutingAddress.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RNC-ID.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RNCTraceInformation.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RNSAPRelocationParameters.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RRC-Container.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RSRQ-Extension.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RSRQ-Type.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RSRVCC-HO-Indication.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RSRVCC-Information.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RSRVCC-Operation-Possible.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RTLoadValue.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RateControlAllowed.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RedirectAttemptFlag.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RedirectionCompleted.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RedirectionIndication.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RejectCauseValue.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RelocationCancel.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RelocationCancelAcknowledge.o
 .libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RelocationCommand.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RelocationComplete.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RelocationDetect.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RelocationFailure.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RelocationPreparationFailure.o
 .libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RelocationRe

Build failure of network:osmocom:latest/osmo-iuh in Debian_Testing/x86_64

2021-01-08 Thread OBS Notification
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-iuh/Debian_Testing/x86_64

Package network:osmocom:latest/osmo-iuh failed to build in Debian_Testing/x86_64

Check out the package for editing:
  osc checkout network:osmocom:latest osmo-iuh

Last lines of build log:
/RANAP_RAB-SetupItem-RelocReq.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-SetupItem-RelocReqAck.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-SetupList-EnhRelocInfoReq.o
 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-SetupList-EnhRelocInfoRes.o
 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-SetupList-EnhancedRelocCompleteReq.o
 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-SetupList-EnhancedRelocCompleteRes.o
 .libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-SetupList-RelocReq.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-SetupList-RelocReqAck.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-SetupOrModifiedItem.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-SetupOrModifiedList.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-SetupOrModifyItemFirst.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-SetupOrModifyItemSecond.o
 .libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-SetupOrModifyList.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-SubflowCombinationBitRate.o
 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-ToBeReleasedItem-EnhancedRelocCompleteRes.o
 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-ToBeReleasedList-EnhancedRelocCompleteRes.o
 .libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-TrCH-Mapping.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-TrCH-MappingItem.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RABDataVolumeReport.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RABParametersList.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RABased.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RABs-ContextFailedtoTransferItem.o
 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RABs-ContextFailedtoTransferList.o
 .libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RABs-failed-to-reportItem.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RABs-failed-to-reportList.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAC.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAI-List.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAI.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAListofIdleModeUEs.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAListwithNoIdleModeUEsAnyMore.o
 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RANAP-EnhancedRelocationInformationRequest.o
 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RANAP-EnhancedRelocationInformationResponse.o
 .libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RANAP-PDU.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RANAP-RelocationInformation.o
 .libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAT-Type.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAofIdleModeUEs.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RIM-Transfer.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RIMInformation.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RIMRoutingAddress.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RNC-ID.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RNCTraceInformation.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RNSAPRelocationParameters.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RRC-Container.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RSRQ-Extension.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RSRQ-Type.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RSRVCC-HO-Indication.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RSRVCC-Information.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RSRVCC-Operation-Possible.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RTLoadValue.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RateControlAllowed.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RedirectAttemptFlag.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RedirectionCompleted.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RedirectionIndication.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RejectCauseValue.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RelocationCancel.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RelocationCancelAcknowledge.o
 .libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RelocationCommand.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RelocationComplete.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RelocationDetect.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RelocationFailure.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RelocationPreparationFailure.o
 .libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RelocationRequest.o 
.li

Build failure of network:osmocom:latest/osmo-iuh in Debian_Unstable/x86_64

2021-01-08 Thread OBS Notification
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-iuh/Debian_Unstable/x86_64

Package network:osmocom:latest/osmo-iuh failed to build in 
Debian_Unstable/x86_64

Check out the package for editing:
  osc checkout network:osmocom:latest osmo-iuh

Last lines of build log:
1-ranap.a/RANAP_RAB-SetupItem-RelocReq.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-SetupItem-RelocReqAck.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-SetupList-EnhRelocInfoReq.o
 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-SetupList-EnhRelocInfoRes.o
 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-SetupList-EnhancedRelocCompleteReq.o
 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-SetupList-EnhancedRelocCompleteRes.o
 .libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-SetupList-RelocReq.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-SetupList-RelocReqAck.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-SetupOrModifiedItem.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-SetupOrModifiedList.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-SetupOrModifyItemFirst.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-SetupOrModifyItemSecond.o
 .libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-SetupOrModifyList.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-SubflowCombinationBitRate.o
 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-ToBeReleasedItem-EnhancedRelocCompleteRes.o
 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-ToBeReleasedList-EnhancedRelocCompleteRes.o
 .libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-TrCH-Mapping.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAB-TrCH-MappingItem.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RABDataVolumeReport.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RABParametersList.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RABased.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RABs-ContextFailedtoTransferItem.o
 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RABs-ContextFailedtoTransferList.o
 .libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RABs-failed-to-reportItem.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RABs-failed-to-reportList.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAC.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAI-List.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAI.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAListofIdleModeUEs.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAListwithNoIdleModeUEsAnyMore.o
 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RANAP-EnhancedRelocationInformationRequest.o
 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RANAP-EnhancedRelocationInformationResponse.o
 .libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RANAP-PDU.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RANAP-RelocationInformation.o
 .libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAT-Type.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RAofIdleModeUEs.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RIM-Transfer.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RIMInformation.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RIMRoutingAddress.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RNC-ID.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RNCTraceInformation.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RNSAPRelocationParameters.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RRC-Container.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RSRQ-Extension.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RSRQ-Type.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RSRVCC-HO-Indication.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RSRVCC-Information.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RSRVCC-Operation-Possible.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RTLoadValue.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RateControlAllowed.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RedirectAttemptFlag.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RedirectionCompleted.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RedirectionIndication.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RejectCauseValue.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RelocationCancel.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RelocationCancelAcknowledge.o
 .libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RelocationCommand.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RelocationComplete.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RelocationDetect.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RelocationFailure.o 
.libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RelocationPreparationFailure.o
 .libs/libosmo-ranap.lax/libosmo-asn1-ranap.a/RANAP_RelocationRe

Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_20.10/x86_64

2021-01-08 Thread OBS Notification
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_20.10/x86_64

Package network:osmocom:nightly/simtrace2 failed to build in 
xUbuntu_20.10/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  157s] [COMPILING apps/dfu/main.c]
[  157s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu.c]
[  157s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_desc.c]
[  157s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_driver.c]
[  158s] Memory region Used Size  Region Size  %age Used
[  158s]  rom:   16580 B16 KB101.20%
[  158s]  ram:   11672 B48 KB 
23.75/usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: warning: 
changing start of section .stack by 4 bytes
[  158s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: 
warning: changing start of section .stack by 4 bytes
[  158s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: 
bin/qmod-dfu-flash.elf section `.text' will not fit in region `rom'
[  158s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: 
warning: changing start of section .stack by 4 bytes
[  158s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: 
warning: changing start of section .stack by 4 bytes
[  158s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: 
warning: changing start of section .stack by 4 bytes
[  158s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: region 
`rom' overflowed by 196 bytes
[  158s] collect2: error: ld returned 1 exit status
[  158s] %
[  158s] make[2]: *** [Makefile:234: flash] Error 1
[  158s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware'
[  158s] make[1]: *** [Makefile:13: fw-qmod-dfu] Error 2
[  158s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  158s] dh_auto_build: error: make -j1 returned exit code 2
[  158s] make: *** [debian/rules:16: build] Error 25
[  158s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  158s] ### VM INTERACTION START ###
[  161s] [  148.409319] sysrq: Power Off
[  161s] [  148.415319] reboot: Power down
[  161s] ### VM INTERACTION END ###
[  161s] 
[  161s] lamb16 failed "build simtrace2_0.7.0.69.aadd.dsc" at Sat Jan  9 
01:43:01 UTC 2021.
[  161s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)


Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_20.04/x86_64

2021-01-08 Thread OBS Notification
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_20.04/x86_64

Package network:osmocom:nightly/simtrace2 failed to build in 
xUbuntu_20.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  165s] [COMPILING libboard/qmod/source/wwan_perst.c]
[  165s] [COMPILING libboard/qmod/source/card_pres.c]
[  165s] [COMPILING libboard/qmod/source/wwan_led.c]
[  165s] [COMPILING libboard/qmod/source/i2c.c]
[  165s] [COMPILING libboard/qmod/source/board_qmod.c]
[  165s] [COMPILING apps/dfu/main.c]
[  165s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu.c]
[  165s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_desc.c]
[  166s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_driver.c]
[  166s] Memory region Used Size  Region Size  %age Used
[  166s]  rom:   16588 B16 KB101.25%
[  166s]  ram:   11672 B48 KB 
23.75/usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: 
bin/qmod-dfu-flash.elf section `.text' will not fit in region `rom'
[  166s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: region 
`rom' overflowed by 204 bytes
[  166s] collect2: error: ld returned 1 exit status
[  166s] %
[  166s] make[2]: *** [Makefile:234: flash] Error 1
[  166s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware'
[  166s] make[1]: *** [Makefile:13: fw-qmod-dfu] Error 2
[  166s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  166s] dh_auto_build: error: make -j1 returned exit code 2
[  166s] make: *** [debian/rules:16: build] Error 25
[  166s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  166s] ### VM INTERACTION START ###
[  169s] [  156.478272] sysrq: Power Off
[  169s] [  156.485495] reboot: Power down
[  169s] ### VM INTERACTION END ###
[  169s] 
[  169s] lamb28 failed "build simtrace2_0.7.0.69.aadd.dsc" at Sat Jan  9 
01:42:40 UTC 2021.
[  169s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)


Change in libosmocore[master]: bssgp_rim: move bssgp_parse_rim_ri and bssgp_create_rim_ri to gprs_bs...

2021-01-08 Thread dexter
Hello Jenkins Builder, pespin,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/libosmocore/+/21863

to look at the new patch set (#8).

Change subject: bssgp_rim: move bssgp_parse_rim_ri and bssgp_create_rim_ri to 
gprs_bssgp_rim
..

bssgp_rim: move bssgp_parse_rim_ri and bssgp_create_rim_ri to gprs_bssgp_rim

The function bssgp_parse_rim_ri() and bssgp_create_rim_ri() are located
in gprs_bssgp.c, since there is now a gprs_bssgp_rim.c module it makes
more sense to put them there.

Change-Id: Icd667f41d5735de56cd9fb257670337c679dd258
Related: SYS#5103
---
M include/osmocom/gprs/gprs_bssgp.h
M include/osmocom/gprs/gprs_bssgp_rim.h
M src/gb/gprs_bssgp.c
M src/gb/gprs_bssgp_rim.c
M tests/gb/gprs_bssgp_rim_test.c
M tests/gb/gprs_bssgp_rim_test.ok
M tests/gb/gprs_bssgp_test.c
M tests/gb/gprs_bssgp_test.ok
8 files changed, 311 insertions(+), 310 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/63/21863/8
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21863
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Icd667f41d5735de56cd9fb257670337c679dd258
Gerrit-Change-Number: 21863
Gerrit-PatchSet: 8
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-MessageType: newpatchset


Change in libosmocore[master]: bssgp_rim: add encoder/decoder for NACC related RIM containers

2021-01-08 Thread dexter
Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/libosmocore/+/21862

to look at the new patch set (#8).

Change subject: bssgp_rim: add encoder/decoder for NACC related RIM containers
..

bssgp_rim: add encoder/decoder for NACC related RIM containers

BSSGP RIM uses a number of nested containers to signal RIM application
specific payload information in a generic way. Lets add the container
structurs required for NACC.

Depends: libosmocore If48f412c32e8e5a3e604a78d12b74787a4786374
Change-Id: Ibbc7fd67658e3040c12abb5706fe9d1f31894352
Related: SYS#5103
---
M include/Makefile.am
A include/osmocom/gprs/gprs_bssgp_rim.h
M src/gb/Makefile.am
A src/gb/gprs_bssgp_rim.c
M src/gb/libosmogb.map
M tests/Makefile.am
A tests/gb/gprs_bssgp_rim_test.c
A tests/gb/gprs_bssgp_rim_test.ok
M tests/testsuite.at
9 files changed, 1,853 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/62/21862/8
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21862
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibbc7fd67658e3040c12abb5706fe9d1f31894352
Gerrit-Change-Number: 21862
Gerrit-PatchSet: 8
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge 
Gerrit-CC: pespin 
Gerrit-MessageType: newpatchset


Change in libosmocore[master]: bssgp_rim: add encoder/decoder for NACC related RIM containers

2021-01-08 Thread dexter
dexter has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/21862 )

Change subject: bssgp_rim: add encoder/decoder for NACC related RIM containers
..


Patch Set 7:

(18 comments)

Thanks for reviewing!

https://gerrit.osmocom.org/c/libosmocore/+/21862/6/include/osmocom/gprs/gprs_bssgp_rim.h
File include/osmocom/gprs/gprs_bssgp_rim.h:

https://gerrit.osmocom.org/c/libosmocore/+/21862/6/include/osmocom/gprs/gprs_bssgp_rim.h@2
PS6, Line 2:
> license/copyright statement?
Done


https://gerrit.osmocom.org/c/libosmocore/+/21862/6/include/osmocom/gprs/gprs_bssgp_rim.h@7
PS6, Line 7:struct {
> You could reuse "struct osmo_cell_global_id_ps" from https://gerrit.osmocom. 
> […]
Makes sense, but I could not find a parsing function for the struct. I re-used 
the existing ones now.


https://gerrit.osmocom.org/c/libosmocore/+/21862/6/include/osmocom/gprs/gprs_bssgp_rim.h@73
PS6, Line 73: Si3
> I don't recall the details: But won't we need SI3 as part of the NACC 
> feature? We have been waiting  […]
The SI3 application container is not used by the NACC application, since the 
NACC application will only use NACC application containers. To me the SI3 
application seems a bit redundant. The SI3 can also be requested within an NACC 
application container. Maybe it is for some other purpose when only SI3 is 
required. (8c.6.2 SI3 application)

If we add new application containers at some later point we will make the ABI 
incompatible, but the API will still work. From what I can see SI3 is not 
needed for NACC and we do not need it now. I have placed the TODOs as a hint 
where new application containers would go.


https://gerrit.osmocom.org/c/libosmocore/+/21862/6/src/gb/gprs_bssgp_rim.c
File src/gb/gprs_bssgp_rim.c:

https://gerrit.osmocom.org/c/libosmocore/+/21862/6/src/gb/gprs_bssgp_rim.c@4
PS6, Line 4:  * (C) 2020 by sysmocom - s.f.m.c. GmbH
> -2021 now I guess?
Done


https://gerrit.osmocom.org/c/libosmocore/+/21862/6/src/gb/gprs_bssgp_rim.c@144
PS6, Line 144: buf++;
> so now buf point s to index '1' but the length check above passed with len == 
> 1, i.e. […]
Done


https://gerrit.osmocom.org/c/libosmocore/+/21862/6/src/gb/gprs_bssgp_rim.c@145
PS6, Line 145:  c
> I think we should set cont->err_app_cont to NULL if the length was only '1'?
Done


https://gerrit.osmocom.org/c/libosmocore/+/21862/6/src/gb/gprs_bssgp_rim.c@159
PS6, Line 159:  1)
> shouldnt' this be +1, i.e. […]
Done


https://gerrit.osmocom.org/c/libosmocore/+/21862/6/src/gb/gprs_bssgp_rim.c@217
PS6, Line 217:  DE
> I think somebody else already meantioned that those macros don't really look 
> all that great and shou […]
I have replaced the macros now - I used macros because I was afraid that I 
couldn't use different struct types as parameters, but I found a way now to 
cast the structs.


https://gerrit.osmocom.org/c/libosmocore/+/21862/6/src/gb/gprs_bssgp_rim.c@256
PS6, Line 256:  if (len <
> please try to use less magic numbers but instead sizeof() or offsetof() 
> macros to gt to those 15 / 3 […]
Done


https://gerrit.osmocom.org/c/libosmocore/+/21862/6/src/gb/gprs_bssgp_rim.c@259
PS6, Line 259:  EN
> same here regarding one line
Done


https://gerrit.osmocom.org/c/libosmocore/+/21862/6/src/gb/gprs_bssgp_rim.c@300
PS6, Line 300:  DE
> why on one line?
Done


https://gerrit.osmocom.org/c/libosmocore/+/21862/6/src/gb/gprs_bssgp_rim.c@355
PS6, Line 355:  uint
> putting 32kBytes on the stack didn't look very good to me. […]
Done


https://gerrit.osmocom.org/c/libosmocore/+/21862/6/src/gb/gprs_bssgp_rim.c@359
PS6, Line 359:  if (le
> magic numbers
Done


https://gerrit.osmocom.org/c/libosmocore/+/21862/6/src/gb/gprs_bssgp_rim.c@362
PS6, Line 362:  ENC_RIM
> magic numbers
Done


https://gerrit.osmocom.org/c/libosmocore/+/21862/6/src/gb/gprs_bssgp_rim.c@461
PS6, Line 461:  if (le
> magic numbers
Done


https://gerrit.osmocom.org/c/libosmocore/+/21862/6/src/gb/gprs_bssgp_rim.c@466
PS6, Line 466: & s
> no space, this looks like a logical "and" otherwise.
Done


https://gerrit.osmocom.org/c/libosmocore/+/21862/6/src/gb/gprs_bssgp_rim.c@532
PS6, Line 532:  if (len
> magic numbers
Done


https://gerrit.osmocom.org/c/libosmocore/+/21862/6/src/gb/gprs_bssgp_rim.c@601
PS6, Line 601: 3
> ?
Done



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21862
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibbc7fd67658e3040c12abb5706fe9d1f31894352
Gerrit-Change-Number: 21862
Gerrit-PatchSet: 7
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge 
Gerrit-CC: pespin 
Gerrit-Comment-Date: Fri, 08 Jan 2021 22:58:14 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge 
Comment-In-Reply-To: pespin 
Gerrit-MessageType: comment


Change in libosmocore[master]: bssgp_rim: move bssgp_parse_rim_ri and bssgp_create_rim_ri to gprs_bs...

2021-01-08 Thread dexter
Hello Jenkins Builder, pespin,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/libosmocore/+/21863

to look at the new patch set (#7).

Change subject: bssgp_rim: move bssgp_parse_rim_ri and bssgp_create_rim_ri to 
gprs_bssgp_rim
..

bssgp_rim: move bssgp_parse_rim_ri and bssgp_create_rim_ri to gprs_bssgp_rim

The function bssgp_parse_rim_ri() and bssgp_create_rim_ri() are located
in gprs_bssgp.c, since there is now a gprs_bssgp_rim.c module it makes
more sense to put them there.

Change-Id: Icd667f41d5735de56cd9fb257670337c679dd258
Related: SYS#5103
---
M include/osmocom/gprs/gprs_bssgp.h
M include/osmocom/gprs/gprs_bssgp_rim.h
M src/gb/gprs_bssgp.c
M src/gb/gprs_bssgp_rim.c
M tests/gb/gprs_bssgp_rim_test.c
M tests/gb/gprs_bssgp_rim_test.ok
M tests/gb/gprs_bssgp_test.c
M tests/gb/gprs_bssgp_test.ok
8 files changed, 311 insertions(+), 310 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/63/21863/7
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21863
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Icd667f41d5735de56cd9fb257670337c679dd258
Gerrit-Change-Number: 21863
Gerrit-PatchSet: 7
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-MessageType: newpatchset


Build failure of network:osmocom:nightly/libgtpnl in openSUSE_Factory_ARM/armv7l

2021-01-08 Thread OBS Notification
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libgtpnl/openSUSE_Factory_ARM/armv7l

Package network:osmocom:nightly/libgtpnl failed to build in 
openSUSE_Factory_ARM/armv7l

Check out the package for editing:
  osc checkout network:osmocom:nightly libgtpnl

Last lines of build log:
getbinaries: missing packages: libisl22
(worker was obs-arm-6:10)

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)


Build failure of network:osmocom:nightly/libsmpp34 in openSUSE_Factory_ARM/armv7l

2021-01-08 Thread OBS Notification
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libsmpp34/openSUSE_Factory_ARM/armv7l

Package network:osmocom:nightly/libsmpp34 failed to build in 
openSUSE_Factory_ARM/armv7l

Check out the package for editing:
  osc checkout network:osmocom:nightly libsmpp34

Last lines of build log:
getbinaries: missing packages: libisl22
(worker was obs-arm-6:17)

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)


Build failure of network:osmocom:nightly/orcania in openSUSE_Factory_ARM/armv7l

2021-01-08 Thread OBS Notification
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/orcania/openSUSE_Factory_ARM/armv7l

Package network:osmocom:nightly/orcania failed to build in 
openSUSE_Factory_ARM/armv7l

Check out the package for editing:
  osc checkout network:osmocom:nightly orcania

Last lines of build log:
getbinaries: missing packages: libisl22
(worker was armbuild13:1)

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)


Change in osmo-gsm-tester[master]: enb: add abstract method stop()

2021-01-08 Thread srs_andre
Hello Jenkins Builder, pespin,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22054

to look at the new patch set (#3).

Change subject: enb: add abstract method stop()
..

enb: add abstract method stop()

implement as noop for Amarisoft eNB, srsENB will send q+Enter to stdin,
which is implemented in class srslte_common()

Change-Id: Ide606e1a6b523997215aa2fa39d4d56ae1f49181
---
M src/osmo_gsm_tester/obj/enb.py
M src/osmo_gsm_tester/obj/enb_amarisoft.py
M src/osmo_gsm_tester/obj/enb_srs.py
M src/osmo_gsm_tester/obj/srslte_common.py
4 files changed, 14 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester 
refs/changes/54/22054/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22054
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: Ide606e1a6b523997215aa2fa39d4d56ae1f49181
Gerrit-Change-Number: 22054
Gerrit-PatchSet: 3
Gerrit-Owner: srs_andre 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-MessageType: newpatchset


Change in osmo-bts[master]: power_control: use more reasonable reduce step size

2021-01-08 Thread fixeria
fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/22079 )

Change subject: power_control: use more reasonable reduce step size
..


Patch Set 1:

> Patch Set 1: Code-Review+1
>
> Fine about the rationale, but you also basically divided by 2 the step size 
> on both. is that also expected? is there any reasoning behind it, specially 
> regarding to timings? it may take too long for changes to take effect.

The increase step size remains unchanged (4 dB), so no timing change here. The 
decrease step (was 8 dB, now becomes 2 dB) is the minimum premitted by 3GPP TS 
45.008, it could also be 4 dB. The less this step is, the more time it would 
take to reach the maximum attenuation, yes. But I think the service quality 
here, i.e. the minimal risk to attenuate MS or BS power too much, is more 
important than the time needed to reach the optimal power levels...  I am 
trying to make it consistent with the default values in osmo-bsc and with the 
recommendations we give in documentation (not yet merged patches for osmo-bsc).


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/22079
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ie358fd828a68bfa1d23559197e8df8478fb4535e
Gerrit-Change-Number: 22079
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Fri, 08 Jan 2021 19:45:19 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment


Change in osmo-bts[master]: power_control: rework handling of DL RxQual measurements

2021-01-08 Thread pespin
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/22080 )

Change subject: power_control: rework handling of DL RxQual measurements
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/22080
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ib3c740b9a0f3ba5dfb027e144dc13f456cb26ae2
Gerrit-Change-Number: 22080
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Fri, 08 Jan 2021 19:30:37 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in osmo-bts[master]: power_control: use more reasonable reduce step size

2021-01-08 Thread pespin
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/22079 )

Change subject: power_control: use more reasonable reduce step size
..


Patch Set 1: Code-Review+1

Fine about the rationale, but you also basically divided by 2 the step size on 
both. is that also expected? is there any reasoning behind it, specially 
regarding to timings? it may take too long for changes to take effect.


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/22079
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ie358fd828a68bfa1d23559197e8df8478fb4535e
Gerrit-Change-Number: 22079
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Fri, 08 Jan 2021 19:28:25 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in osmo-bts[master]: power_control: use more reasonable reduce step size

2021-01-08 Thread fixeria
fixeria has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/22079 )


Change subject: power_control: use more reasonable reduce step size
..

power_control: use more reasonable reduce step size

It makes more sense to use a reduce step size that is smaller than
the increase step size.  This way both MS/BS power control loops
would be able to react quickly of the signal gets weaker, while
the good signal would not trigger radical power reduction.

Change-Id: Ie358fd828a68bfa1d23559197e8df8478fb4535e
Related: SYS#4918
---
M include/osmo-bts/power_control.h
M src/common/gsm_data.c
M tests/power/bs_power_loop_test.c
M tests/power/bs_power_loop_test.err
M tests/power/bs_power_loop_test.ok
M tests/power/ms_power_loop_test.err
M tests/power/ms_power_loop_test.ok
7 files changed, 124 insertions(+), 85 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/79/22079/1

diff --git a/include/osmo-bts/power_control.h b/include/osmo-bts/power_control.h
index ab107b8..f2e14cf 100644
--- a/include/osmo-bts/power_control.h
+++ b/include/osmo-bts/power_control.h
@@ -3,10 +3,6 @@
 #include 
 #include 

-/* How many dB do we raise/lower power as maximum */
-#define PWR_RAISE_MAX_DB 4
-#define PWR_LOWER_MAX_DB 8
-
 int lchan_ms_pwr_ctrl(struct gsm_lchan *lchan,
  const uint8_t ms_power_lvl,
  const int8_t ul_rssi_dbm);
diff --git a/src/common/gsm_data.c b/src/common/gsm_data.c
index 44ed7e9..b3f9f2d 100644
--- a/src/common/gsm_data.c
+++ b/src/common/gsm_data.c
@@ -423,9 +423,9 @@

 /* Default MS/BS Power Control parameters (see 3GPP TS 45.008, table A.1) */
 const struct gsm_power_ctrl_params power_ctrl_params_def = {
-   /* Power increasing/reducing step size */
-   .inc_step_size_db = 4, /* FIXME: PWR_RAISE_MAX_DB */
-   .red_step_size_db = 8, /* FIXME: PWR_LOWER_MAX_DB */
+   /* Power increasing/reducing step size (optimal defaults) */
+   .inc_step_size_db = 4, /* quickly increase MS/BS power */
+   .red_step_size_db = 2, /* slowly decrease MS/BS power */

/* RxLev measurement parameters */
.rxlev_meas = {
diff --git a/tests/power/bs_power_loop_test.c b/tests/power/bs_power_loop_test.c
index ecd83e7..06b53da 100644
--- a/tests/power/bs_power_loop_test.c
+++ b/tests/power/bs_power_loop_test.c
@@ -197,16 +197,17 @@
init_test(name);

struct gsm_lchan *lchan = &g_trx->ts[0].lchan[0];
+   struct gsm_power_ctrl_params *params = &lchan->bs_dpc_params;

-   lchan->bs_dpc_params = (struct gsm_power_ctrl_params) {
-   /* NOTE: raise/lower values are intentionally swapped here,
-* as it makes more sense in the context of BS Power Control. */
-   .inc_step_size_db = PWR_LOWER_MAX_DB,
-   .red_step_size_db = PWR_RAISE_MAX_DB,
+   /* Default BS power control parameters */
+   memcpy(params, &power_ctrl_params_def, sizeof(*params));

-   /* RxLev pre-processing parameters */
-   .rxlev_meas = { PWR_TEST_CFG_RXLEV_THRESH(0) },
-   };
+   /* No RxLev hysteresis: lower == upper */
+   params->rxlev_meas.lower_thresh = PWR_TEST_RXLEV_TARGET;
+   params->rxlev_meas.upper_thresh = PWR_TEST_RXLEV_TARGET;
+
+   /* No RxLev pre-processing by default */
+   params->rxlev_meas.algo = GSM_PWR_CTRL_MEAS_AVG_ALGO_NONE;

for (n = 0; n < num_steps; n++)
rc |= exec_power_step(lchan, n, &steps[n]);
@@ -249,17 +250,24 @@
{ .type = PWR_TEST_ST_SET_STATE,
  .state = { .current = 0, .max = 2 * 10 } },

-   /* MS indicates high RxLev values (-50 dBm) */
+   /* MS indicates high RxLev values (-50 dBm), inc step is 2 dB */
+   { .meas = DL_MEAS_FULL_SUB(0, 60),  .exp_txred =  2 },
{ .meas = DL_MEAS_FULL_SUB(0, 60),  .exp_txred =  4 },
+   { .meas = DL_MEAS_FULL_SUB(0, 60),  .exp_txred =  6 },
{ .meas = DL_MEAS_FULL_SUB(0, 60),  .exp_txred =  8 },
+   { .meas = DL_MEAS_FULL_SUB(0, 60),  .exp_txred = 10 },
{ .meas = DL_MEAS_FULL_SUB(0, 60),  .exp_txred = 12 },
+   { .meas = DL_MEAS_FULL_SUB(0, 60),  .exp_txred = 14 },
{ .meas = DL_MEAS_FULL_SUB(0, 60),  .exp_txred = 16 },
+   { .meas = DL_MEAS_FULL_SUB(0, 60),  .exp_txred = 18 },
{ .meas = DL_MEAS_FULL_SUB(0, 60),  .exp_txred = 20 }, /* max */
{ .meas = DL_MEAS_FULL_SUB(0, 60),  .exp_txred = 20 }, /* max */
{ .meas = DL_MEAS_FULL_SUB(0, 60),  .exp_txred = 20 }, /* max */

-   /* MS indicates low RxLev values (-100 dBm) */
+   /* MS indicates low RxLev values (-100 dBm), red step is 4 dB */
+   { .meas = DL_MEAS_FULL_SUB(0, 10),  .exp_txred = 16 },
{ .meas = DL_MEAS_FULL_SUB(0, 10),  .exp_txred = 12 },
+   { .meas = DL_MEAS_FULL_SUB(0, 10),  .exp_txred =  8 },
{ .meas = DL_ME

Change in osmo-bts[master]: power_control: rework handling of DL RxQual measurements

2021-01-08 Thread fixeria
fixeria has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/22080 )


Change subject: power_control: rework handling of DL RxQual measurements
..

power_control: rework handling of DL RxQual measurements

This change makes BS power control loop:

  - take the lower RxQual threshold (L_RXQUAL_XX_P) into account, so
the BS power is increased only if RxQual exceeds this threshold;

  - apply the configured increase step size instead of reducing the
current attenuation by half.

MS power loop is not affected, it does not even handle RxQual yet.

Change-Id: Ib3c740b9a0f3ba5dfb027e144dc13f456cb26ae2
Related: SYS#4918
---
M src/common/power_control.c
M tests/power/bs_power_loop_test.c
M tests/power/bs_power_loop_test.err
M tests/power/bs_power_loop_test.ok
4 files changed, 98 insertions(+), 70 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/80/22080/1

diff --git a/src/common/power_control.c b/src/common/power_control.c
index 5e2e85e..6620add 100644
--- a/src/common/power_control.c
+++ b/src/common/power_control.c
@@ -274,12 +274,23 @@
rxlev = rxlev_full;
}

-   /* Bit Error Rate > 0 => reduce by 2 */
-   if (rxqual > 0) { /* FIXME: take RxQual threshold into account */
-   LOGPLCHAN(lchan, DLOOP, LOGL_INFO, "Reducing Downlink 
attenuation "
- "by half: %u -> %u dB due to RXQUAL %u > 0\n",
- state->current, state->current / 2, rxqual);
-   state->current /= 2;
+   /* If RxQual > L_RXQUAL_XX_P, try to increase Tx power */
+   if (rxqual > params->rxqual_meas.lower_thresh) {
+   uint8_t old = state->current;
+
+   /* Tx power has reached the maximum, nothing to do */
+   if (state->current == 0)
+   return 0;
+
+   /* Increase Tx power by reducing Tx attenuation */
+   if (state->current >= params->inc_step_size_db)
+   state->current -= params->inc_step_size_db;
+   else
+   state->current = 0;
+
+   LOGPLCHAN(lchan, DLOOP, LOGL_INFO, "Reducing Downlink 
attenuation: "
+ "%u -> %d dB due to RxQual %u worse than 
L_RXQUAL_XX_P %u\n",
+ old, state->current, rxqual, 
params->rxqual_meas.lower_thresh);
return 1;
}

diff --git a/tests/power/bs_power_loop_test.c b/tests/power/bs_power_loop_test.c
index 06b53da..7301b7f 100644
--- a/tests/power/bs_power_loop_test.c
+++ b/tests/power/bs_power_loop_test.c
@@ -291,7 +291,7 @@
{ .meas = { DL_MEAS_FULL(0, 63), DL_MEAS_SUB(0, PWR_TEST_RXLEV_TARGET) 
} },
 };

-/* Verify that RxQual > 0 reduces the current attenuation value. */
+/* Verify that high RxQual reduces the current attenuation value. */
 static const struct power_test_step TC_rxqual_ber[] = {
/* Initial state: 16 dB, up to 20 dB */
{ .type = PWR_TEST_ST_SET_STATE,
@@ -301,25 +301,30 @@
{ .meas = DL_MEAS_FULL_SUB(0, PWR_TEST_RXLEV_TARGET),   .exp_txred = 16 
},
{ .meas = DL_MEAS_FULL_SUB(0, PWR_TEST_RXLEV_TARGET),   .exp_txred = 16 
},

-   /* MS indicates target RxLev, but RxQual values > 0 */
-   { .meas = DL_MEAS_FULL_SUB(7, PWR_TEST_RXLEV_TARGET),   .exp_txred = 16 
/ 2 },
-   { .meas = DL_MEAS_FULL_SUB(4, PWR_TEST_RXLEV_TARGET),   .exp_txred = 16 
/ 4 },
-   { .meas = DL_MEAS_FULL_SUB(1, PWR_TEST_RXLEV_TARGET),   .exp_txred = 16 
/ 8 },
+   /* MS indicates target RxLev, but RxQual values better than 
L_RXQUAL_XX_P=3 */
+   { .meas = DL_MEAS_FULL_SUB(1, PWR_TEST_RXLEV_TARGET),   .exp_txred = 16 
},
+   { .meas = DL_MEAS_FULL_SUB(2, PWR_TEST_RXLEV_TARGET),   .exp_txred = 16 
},
+   { .meas = DL_MEAS_FULL_SUB(3, PWR_TEST_RXLEV_TARGET),   .exp_txred = 16 
},

-   /* MS indicates target RxLev, and no bit errors anymore */
-   { .meas = DL_MEAS_FULL_SUB(0, PWR_TEST_RXLEV_TARGET),   .exp_txred = 16 
/ 8 },
-   { .meas = DL_MEAS_FULL_SUB(0, PWR_TEST_RXLEV_TARGET),   .exp_txred = 16 
/ 8 },
+   /* MS indicates target RxLev, but RxQual values worse than 
L_RXQUAL_XX_P=3 */
+   { .meas = DL_MEAS_FULL_SUB(4, PWR_TEST_RXLEV_TARGET +  0),  .exp_txred 
= 16 -  4 },
+   { .meas = DL_MEAS_FULL_SUB(5, PWR_TEST_RXLEV_TARGET +  4),  .exp_txred 
= 16 -  8 },
+   { .meas = DL_MEAS_FULL_SUB(6, PWR_TEST_RXLEV_TARGET +  8),  .exp_txred 
= 16 - 12 },
+   { .meas = DL_MEAS_FULL_SUB(7, PWR_TEST_RXLEV_TARGET + 12),  .exp_txred 
= 16 - 16 }, /* max */
+   { .meas = DL_MEAS_FULL_SUB(7, PWR_TEST_RXLEV_TARGET + 16),  .exp_txred 
= 16 - 16 }, /* max */

-   /* Reset state: 16 dB, up to 20 dB */
+   /* MS indicates target RxLev, but no bit errors anymore => reducing Tx 
power */
+   { .meas = DL_MEAS_FULL_SUB(0, PWR_TEST_RXLEV_TARGET + 16),  .exp_txred 
= 2 },
+   { .meas

Change in libosmocore[master]: gprs_bssgp: add utilities to send and parse BSSGP rim PDUs

2021-01-08 Thread pespin
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/22046 )

Change subject: gprs_bssgp: add utilities to send and parse BSSGP rim PDUs
..


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/22046/2/include/osmocom/gprs/gprs_bssgp.h
File include/osmocom/gprs/gprs_bssgp.h:

https://gerrit.osmocom.org/c/libosmocore/+/22046/2/include/osmocom/gprs/gprs_bssgp.h@45
PS2, Line 45: struct bssgp_ran_information_pdu {
> I'm not really liking the current approach with one struct having pointers to 
> already encoded IEs, i […]
struct bssgp_ran_information_pdu {
  struct bssgp_rim_routing_info dst;
  struct bssgp_rim_routing_info src;
  enum rim_container_type cont_type;
  union {
struct struct bssgp_ran_inf_req_rim_cont ran_info_req;
  };
}



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22046
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I18134fd9938040d2facb6beee3732628b167ce8c
Gerrit-Change-Number: 22046
Gerrit-PatchSet: 2
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Fri, 08 Jan 2021 17:09:20 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Gerrit-MessageType: comment


Change in libosmocore[master]: gprs_bssgp: add utilities to send and parse BSSGP rim PDUs

2021-01-08 Thread pespin
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/22046 )

Change subject: gprs_bssgp: add utilities to send and parse BSSGP rim PDUs
..


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/22046/2/include/osmocom/gprs/gprs_bssgp.h
File include/osmocom/gprs/gprs_bssgp.h:

https://gerrit.osmocom.org/c/libosmocore/+/22046/2/include/osmocom/gprs/gprs_bssgp.h@45
PS2, Line 45: struct bssgp_ran_information_pdu {
I'm not really liking the current approach with one struct having pointers to 
already encoded IEs, it's kind of cumbersome because you have to iteratively 
encode stuff and store it in temporary buffers in code using it. See for 
instance the draft I wrote for osmo-pcu:

"""
static void fill_rim_ri(struct bssgp_rim_routing_info *info, const struct 
osmo_cell_global_id_ps *cgi_ps)
{
*info = {
.discr = BSSGP_RIM_ROUTING_INFO_GERAN,
.geran = {
.raid = {
.mcc = cgi_ps->rai.lac.plmn.mcc,
.mnc = cgi_ps->rai.lac.plmn.mnc,
.mnc_3_digits = 
cgi_ps->rai.lac.plmn.mnc_3_digits,
.lac = cgi_ps->rai.lac.lac,
.rac = cgi_ps->rai.rac,
},
.cid = cgi_ps->cell_identity,
},
};
}

static struct ran_information_pdu *gen_rim_ran_info_req(struct nacc_fsm_ctx 
*ctx)
{
struct ran_information_pdu *req = talloc_zero(ctx, struct 
ran_information_pdu);
struct gprs_rlcmac_bts *bts = bts_data(ctx->ms->bts);
struct bssgp_rim_routing_info src, dst;
uint8_t *src_buf = talloc_size(ctx, 64);
uint8_t *dst_buf = talloc_size(ctx, 64);
uint8_t *cont_buf = talloc_size(ctx, 64);
int rc, src_len, dst_len, cont_len;

fill_rim_ri(&dst, ctx->cgi_ps);
dst_len = bssgp_create_rim_ri(dst_buf, &dst);
if (dst_len <= 0)
goto err_ret;

memset(&src, 0, sizeof(src)); //TODO: fill correctly from BTS data
src->discr = BSSGP_RIM_ROUTING_INFO_GERAN;
src_len = bssgp_create_rim_ri(src_buf, &src);
if (src_len <= 0)
goto err_ret;

struct bssgp_ran_inf_req_rim_cont cont = {
.app_id = BSSGP_RAN_INF_APP_ID_NACC;
.seq_num = 1;
.pdu_ind.ack_requested = 0;
.pdu_ind.pdu_type_ext = 1;
.prot_ver = 1;
.son_trans_app_id = NULL;
.son_trans_app_id_len = 0;
.u = {
.app_cont_nacc = {
.reprt_cell = {
.raid = {
.mcc = 
ctx->cgi_ps.rai.lac.plmn.mcc,
.mnc = 
ctx->cgi_ps.rai.lac.plmn.mnc,
.mnc_3_digits = false, //FIXME, 
how to say true/false here?
.lac = ctx->cgi_ps.rai.lac.lac,
.rac= ctx->cgi_ps.rai.rac,
},
.cid = bts->cell_id,
},
},
},
};
cont_len = bssgp_enc_ran_inf_req_rim_cont(cont_buf, 64, &cont);
if (cont_len <= 0)
goto err_ret;

struct ran_information_pdu rim = {
.bssgp_pdu_type = BSSGP_PDUT_RAN_INFO_REQ,
.d_cid = dst_buf,
.d_cid_len = dst_len,
.s_cid = src_buf,
.s_cid_len = src_len,
.rim_cont = cont,
.rim_cont_len = cont_len,
.rim_cont_iei = 0x57,
}

return req;

err_ret:
talloc_free(req);
return NULL;
}
"""


So why not having the relevant decoded structs (such as struct 
bssgp_rim_routing_info) into the struct and do the encoding in 1 pass insterad 
of having several passes?

Same as per decoding. I would expect the decode function to already provide me 
with 1 full struct with all protocol related parts decoded.



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22046
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I18134fd9938040d2facb6beee3732628b167ce8c
Gerrit-Change-Number: 22046
Gerrit-PatchSet: 2
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Fri, 08 Jan 2021 17:06:22 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment


Change in libosmocore[master]: gprs_bssgp: add utilities to send and parse BSSGP rim PDUs

2021-01-08 Thread dexter
dexter has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/22046 )

Change subject: gprs_bssgp: add utilities to send and parse BSSGP rim PDUs
..


Patch Set 2:

(8 comments)

(make sure all comments are sent)

https://gerrit.osmocom.org/c/libosmocore/+/22046/1/include/osmocom/gprs/gprs_bssgp.h
File include/osmocom/gprs/gprs_bssgp.h:

https://gerrit.osmocom.org/c/libosmocore/+/22046/1/include/osmocom/gprs/gprs_bssgp.h@45
PS1, Line 45: struct bssgp_ran_information_pdu {
> shouldn't this be incorporated into struct osmo_bssgp_prim somehow?
Done


https://gerrit.osmocom.org/c/libosmocore/+/22046/1/src/gb/gprs_bssgp_util.c
File src/gb/gprs_bssgp_util.c:

https://gerrit.osmocom.org/c/libosmocore/+/22046/1/src/gb/gprs_bssgp_util.c@593
PS1, Line 593: struct bssgp_ran_information_pdu *pdu
> const
Done


https://gerrit.osmocom.org/c/libosmocore/+/22046/1/src/gb/gprs_bssgp_util.c@621
PS1, Line 621: LOGL_NOTICE
> DEBUG?
Done


https://gerrit.osmocom.org/c/libosmocore/+/22046/1/src/gb/gprs_bssgp_util.c@644
PS1, Line 644: struct msgb *msg
> const
Done


https://gerrit.osmocom.org/c/libosmocore/+/22046/1/src/gb/gprs_bssgp_util.c@653
PS1, Line 653: data_len
> I would better check if the resulting length is not negative.
Done


https://gerrit.osmocom.org/c/libosmocore/+/22046/1/src/gb/gprs_bssgp_util.c@661
PS1, Line 661:  pdu->routing_info_dest =
> Cosmetic: no need for line breaks here.
Done


https://gerrit.osmocom.org/c/libosmocore/+/22046/1/src/gb/gprs_bssgp_util.c@672 
PS1, Line 672: 0
> Wrong index, it should be 1!
Done


https://gerrit.osmocom.org/c/libosmocore/+/22046/1/src/gb/gprs_bssgp_util.c@704
PS1, Line 704:  return 0;
> Makes sense to check if the IEs are not empty.
Done



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22046
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I18134fd9938040d2facb6beee3732628b167ce8c
Gerrit-Change-Number: 22046
Gerrit-PatchSet: 2
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Fri, 08 Jan 2021 16:31:55 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Comment-In-Reply-To: fixeria 
Gerrit-MessageType: comment


Change in libosmocore[master]: Intoduce Packet Switch CGI

2021-01-08 Thread dexter
dexter has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/22013 )

Change subject: Intoduce Packet Switch CGI
..


Patch Set 6: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22013
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: If48f412c32e8e5a3e604a78d12b74787a4786374
Gerrit-Change-Number: 22013
Gerrit-PatchSet: 6
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Fri, 08 Jan 2021 16:30:42 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in libosmocore[master]: gprs_bssgp: add utilities to send and parse BSSGP rim PDUs

2021-01-08 Thread dexter
Hello Jenkins Builder, fixeria, pespin,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/libosmocore/+/22046

to look at the new patch set (#2).

Change subject: gprs_bssgp: add utilities to send and parse BSSGP rim PDUs
..

gprs_bssgp: add utilities to send and parse BSSGP rim PDUs

At the moment libosmogb offers no convinient way to send RIM PDUs. Also
parsing an incoming RIM messages into destination, source routing
info and RIM container is not available.

Change-Id: I18134fd9938040d2facb6beee3732628b167ce8c
Related: SYS#5103
---
M include/osmocom/gprs/gprs_bssgp.h
M src/gb/gprs_bssgp.c
M src/gb/gprs_bssgp_util.c
M src/gb/libosmogb.map
4 files changed, 144 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/46/22046/2
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22046
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I18134fd9938040d2facb6beee3732628b167ce8c
Gerrit-Change-Number: 22046
Gerrit-PatchSet: 2
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: newpatchset


Change in libosmocore[master]: Intoduce Packet Switch CGI

2021-01-08 Thread pespin
Hello Jenkins Builder, laforge, dexter,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/libosmocore/+/22013

to look at the new patch set (#6).

Change subject: Intoduce Packet Switch CGI
..

Intoduce Packet Switch CGI

This structure is needed in order to identify a given cell within the
BSS during RIM transactions.
The naming was made up by myself since I couldn't find any naming
reference for this kind of data (RAI + CI).
Since LAI + CI = CGI, then RAI + CI = CGI-PS

osmo_rai_name2 family of functions get a "2" suffix due to already
existing functions handling struct struct gprs_ra_id in gsm48.h

Change-Id: If48f412c32e8e5a3e604a78d12b74787a4786374
---
M include/osmocom/gsm/gsm0808_utils.h
M include/osmocom/gsm/gsm23003.h
M include/osmocom/gsm/protocol/gsm_08_08.h
M src/gsm/gsm0808_utils.c
M src/gsm/gsm23003.c
M src/gsm/libosmogsm.map
6 files changed, 136 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/13/22013/6
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22013
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: If48f412c32e8e5a3e604a78d12b74787a4786374
Gerrit-Change-Number: 22013
Gerrit-PatchSet: 6
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: laforge 
Gerrit-MessageType: newpatchset


Change in osmo-bts[master]: l1sap: include Uplink RSSI and C/I in GSMTAP packets

2021-01-08 Thread Hoernchen
Hoernchen has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/21935 )

Change subject: l1sap: include Uplink RSSI and C/I in GSMTAP packets
..


Patch Set 2:

I don't know what to do here, osmo-trx can't really measure the rssi because 
even though uhd exposes it as a sensor and reading it takes multiple timeslots 
so it's useless, while snr was never really properly specified, is it rssi of 
used ts vs rssi of unused ts? is it supposed to be c/i?


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21935
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ic48283fa76b682aee151a94ef7274ac96545e087
Gerrit-Change-Number: 21935
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Hoernchen 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-CC: laforge 
Gerrit-Comment-Date: Fri, 08 Jan 2021 16:25:28 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment


Change in osmo-ttcn3-hacks[master]: rlcmac: Add template to match receival of Dl Ctrl message

2021-01-08 Thread pespin
pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22057 )


Change subject: rlcmac: Add template to match receival of Dl Ctrl message
..

rlcmac: Add template to match receival of Dl Ctrl message

Change-Id: Ifd16e8129b4440542b82a47749df1547a061ae88
---
M library/RLCMAC_Templates.ttcn
1 file changed, 13 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/57/22057/1

diff --git a/library/RLCMAC_Templates.ttcn b/library/RLCMAC_Templates.ttcn
index d59c74e..981061c 100644
--- a/library/RLCMAC_Templates.ttcn
+++ b/library/RLCMAC_Templates.ttcn
@@ -505,6 +505,19 @@
usf := usf
}

+   template RlcmacDlBlock tr_RLCMAC_DL_CTRL(template uint3_t usf := ?, 
template RlcmacDlCtrlMsg dl_ctrl := ?) := {
+   ctrl := {
+   mac_hdr := {
+   payload_type := (MAC_PT_RLCMAC_NO_OPT, 
MAC_PT_RLCMAC_OPT),
+   rrbp:= ?,
+   rrbp_valid := ?,
+   usf := usf
+   },
+   opt := *,
+   payload := dl_ctrl
+   }
+   }
+
template RlcmacDlBlock tr_RLCMAC_DUMMY_CTRL(template uint3_t usf := ?, 
template PageMode page_mode := ?) := {
ctrl := {
mac_hdr := {

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22057
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ifd16e8129b4440542b82a47749df1547a061ae88
Gerrit-Change-Number: 22057
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange


Change in osmo-ttcn3-hacks[master]: rlcmac: introduce initial support for NACC related messages

2021-01-08 Thread pespin
pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22058 )


Change subject: rlcmac: introduce initial support for NACC related messages
..

rlcmac: introduce initial support for NACC related messages

Change-Id: I4d2f123479c34e6afffe0bc8d91409e6b0529a62
---
M library/RLCMAC_CSN1_Templates.ttcn
M library/RLCMAC_CSN1_Types.ttcn
2 files changed, 169 insertions(+), 7 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/58/22058/1

diff --git a/library/RLCMAC_CSN1_Templates.ttcn 
b/library/RLCMAC_CSN1_Templates.ttcn
index 64c709a..673a5e5 100644
--- a/library/RLCMAC_CSN1_Templates.ttcn
+++ b/library/RLCMAC_CSN1_Templates.ttcn
@@ -108,6 +108,84 @@
}
};

+   const CCNMesurementReport ccn_meas_rep_def := {
+   rxlev_servig_cell := 0,
+   zero := '0'B,
+   num_meas := 1,
+   meas := {
+   {
+   freq := 0,
+   bsic_presence := '1'B,
+   bsic := 43,
+   rxlev := 23
+   }
+   }
+   }
+
+   /* TS 44.060 sec 11.2.3a */
+   template (value) RlcmacUlCtrlMsg 
ts_RlcMacUlCtrl_PKT_CELL_CHG_NOTIF(uint5_t tfi,
+   GsmArfcn arfcn,
+   uint6_t bsic,
+   template (value) 
CCNMesurementReport ccn_meas_rep := ccn_meas_rep_def)
+   := {
+   msg_type := PACKET_CELL_CHANGE_NOTIFICATION,
+   u := {
+   cell_chg_notif := {
+   gtfi := {
+   is_dl_tfi := false,
+   tfi := tfi
+   },
+   arfcn_bsic_presence := '0'B,
+   arfcn := arfcn,
+   bsic := bsic,
+   ba_psi3_presence := '0'B,
+   ba_used := '0'B,
+   psi3_change_mark := omit,
+   pmo_used := '0'B,
+   pccn_sending := '0'B,
+   ccn_meas_rep := ccn_meas_rep
+   //ccn_meas_rep := omit
+   }
+   }
+   };
+
+   /* TS 44.060 sec 11.2.2a */
+   template RlcmacDlCtrlMsg tr_RlcMacDlCtrl_PKT_CELL_CHG_CONTINUE(template 
GlobalTfi tfi := ?)
+   := {
+   msg_type := PACKET_CELL_CHANGE_CONTINUE,
+   u := {
+   cell_chg_continue := {
+   page_mode := ?,
+   zero := '0'B,
+   gtfi := tfi,
+   arfcn_bsic_presence := ?,
+   arfcn := *,
+   bsic := *,
+   container_id := *
+   }
+   }
+   };
+
+   /* TS 44.060 sec 11.2.9e */
+   template RlcmacDlCtrlMsg tr_RlcMacDlCtrl_PKT_NEIGH_CELL_DATA(template 
GlobalTfi tfi := ?)
+   := {
+   msg_type := PACKET_NEIGHBOUR_CELL_DATA,
+   u := {
+   neighbour_cell_data := {
+   page_mode := ?,
+   zero := '0'B,
+   gtfi := tfi,
+   container_id := ?,
+   spare := '0'B,
+   container_index := ?,
+   arfcn_bsic_presence := ?,
+   arfcn := *,
+   bsic := *,
+   contaner_list := ?
+   }
+   }
+   };
+
private function f_presence_bit_tfi(template uint5_t tfi) return BIT1 {
if (istemplatekind(tfi, "omit")) {
return '0'B;
diff --git a/library/RLCMAC_CSN1_Types.ttcn b/library/RLCMAC_CSN1_Types.ttcn
index 14570bf..b0e8c66 100644
--- a/library/RLCMAC_CSN1_Types.ttcn
+++ b/library/RLCMAC_CSN1_Types.ttcn
@@ -32,6 +32,8 @@
PACKET_TBF_RELEASE  ('001000'B),
PACKET_UL_ACK_NACK  ('001001'B),
PACKET_UL_ASSIGNMENT('001010'B),
+   PACKET_CELL_CHANGE_CONTINUE ('001011'B),
+   PACKET_NEIGHBOUR_CELL_DATA  ('001100'B),
PACKET_DL_DUMMY_CTRL('100101'B)
} with { variant "FIELDLENGTH(6)" };

@@ -49,7 +51,7 @@
PACKET_EGPRS_DL_ACK_NACK('001000'B),
PACKET_PAUSE('001001'B),
   

Change in osmo-ttcn3-hacks[master]: library: Add templates to initialize CellId, RAI, LAI

2021-01-08 Thread pespin
pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22056 )


Change subject: library: Add templates to initialize CellId, RAI, LAI
..

library: Add templates to initialize CellId, RAI, LAI

Change-Id: Ie9d86e1b651dff279e7d50a4282bf14fbed5bb76
---
M library/GSM_Types.ttcn
M library/Osmocom_Gb_Types.ttcn
2 files changed, 13 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/56/22056/1

diff --git a/library/GSM_Types.ttcn b/library/GSM_Types.ttcn
index 34b6517..6cc3c08 100644
--- a/library/GSM_Types.ttcn
+++ b/library/GSM_Types.ttcn
@@ -420,12 +420,20 @@
BcdMccMnc   mcc_mnc,
uint16_tlac
 } with { variant "" };
+template (value) LocationAreaIdentification ts_LAI(BcdMccMnc mcc_mnc, uint16_t 
lac) := {
+   mcc_mnc := mcc_mnc,
+   lac := lac
+};

 /* 24.008 10.5.5.15 */
 type record RoutingAreaIdentification {
LocationAreaIdentification  lai,
uint8_t rac
 } with { variant "" };
+template (value) RoutingAreaIdentification ts_RAI(template (value) 
LocationAreaIdentification lai, uint8_t rac) := {
+   lai := lai,
+   rac := rac
+};

 external function enc_RoutingAreaIdentification(RoutingAreaIdentification rai) 
return octetstring
 with { extension "prototype(convert)" extension "encode(RAW)" }
diff --git a/library/Osmocom_Gb_Types.ttcn b/library/Osmocom_Gb_Types.ttcn
index b83131d..518d619 100644
--- a/library/Osmocom_Gb_Types.ttcn
+++ b/library/Osmocom_Gb_Types.ttcn
@@ -733,6 +733,11 @@
CellIdentitycell_id
} with { variant "" };

+   template (value) BssgpCellId ts_BssgpCellId(template (value) 
RoutingAreaIdentification rai, CellIdentity cell_id) := {
+   ra_id := rai,
+   cell_id := cell_id
+   };
+
type enumerated BssgpCause {
BSSGP_CAUSE_PROC_OVERLOAD   ('00'H),
BSSGP_CAUSE_EQUIMENT_FAILURE('01'H),

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22056
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie9d86e1b651dff279e7d50a4282bf14fbed5bb76
Gerrit-Change-Number: 22056
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange


Change in osmo-bsc[master]: Introduce Neighbor Resolution Service

2021-01-08 Thread fixeria
fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/21848 )

Change subject: Introduce Neighbor Resolution Service
..


Patch Set 6: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21848
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ib07c9d23026332a207d4b7a0f7b4e76c0094e379
Gerrit-Change-Number: 21848
Gerrit-PatchSet: 6
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-CC: laforge 
Gerrit-Comment-Date: Fri, 08 Jan 2021 16:02:41 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in osmo-bts[master]: power_control: properly track the first initial state

2021-01-08 Thread fixeria
fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/22051 )

Change subject: power_control: properly track the first initial state
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bts/+/22051/1/src/common/power_control.c
File src/common/power_control.c:

https://gerrit.osmocom.org/c/osmo-bts/+/22051/1/src/common/power_control.c@81
PS1, Line 81:   if (mps->meas_num++ == 0) {
> a boolean would be better, otherwise you are applying wrong value when it 
> overflows (not critical th […]
For other pre-processing methods (like unweighted average) it makes more sense 
to have a counter, so you know how many measurements you have in the buffer.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/22051
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I16e7474b5affbd90855a2e407b305e9dec581dfa
Gerrit-Change-Number: 22051
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Fri, 08 Jan 2021 15:57:57 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Gerrit-MessageType: comment


Change in docker-playground[master]: ttcn3-gbproxy-test: Fix pcap capture with dumpcap

2021-01-08 Thread pespin
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/docker-playground/+/22047 )

Change subject: ttcn3-gbproxy-test: Fix pcap capture with dumpcap
..


Patch Set 2: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/22047
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I11dcf9efd0b06544a82e31dec03fe76e182fd0d3
Gerrit-Change-Number: 22047
Gerrit-PatchSet: 2
Gerrit-Owner: daniel 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Fri, 08 Jan 2021 15:57:16 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in docker-playground[master]: ttcn3-gbproxy-test: Fix pcap capture with dumpcap

2021-01-08 Thread daniel
daniel has posted comments on this change. ( 
https://gerrit.osmocom.org/c/docker-playground/+/22047 )

Change subject: ttcn3-gbproxy-test: Fix pcap capture with dumpcap
..


Patch Set 2: Verified+1

(1 comment)

https://gerrit.osmocom.org/c/docker-playground/+/22047/1/ttcn3-gbproxy-test/jenkins.sh
File ttcn3-gbproxy-test/jenkins.sh:

https://gerrit.osmocom.org/c/docker-playground/+/22047/1/ttcn3-gbproxy-test/jenkins.sh@13
PS1, Line 13: # if we don't change permissiosn, dumpcap fails to write (despite 
starting it as root!)
> permissions
Fine



--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/22047
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I11dcf9efd0b06544a82e31dec03fe76e182fd0d3
Gerrit-Change-Number: 22047
Gerrit-PatchSet: 2
Gerrit-Owner: daniel 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-CC: pespin 
Gerrit-Comment-Date: Fri, 08 Jan 2021 15:52:30 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin 
Gerrit-MessageType: comment


Change in docker-playground[master]: ttcn3-gbproxy-test: Fix pcap capture with dumpcap

2021-01-08 Thread daniel
Hello laforge, lynxis lazus,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/docker-playground/+/22047

to look at the new patch set (#2).

Change subject: ttcn3-gbproxy-test: Fix pcap capture with dumpcap
..

ttcn3-gbproxy-test: Fix pcap capture with dumpcap

In commit 2279aac6 dumpcap is used to capture pcaps, but dumpcap fails
if the directory isn't writable for everyone.
Commit 62ac27779 only fixed this issue for frame relay, this simply
mirrors the change for ttcn3-gbproxy-test

Change-Id: I11dcf9efd0b06544a82e31dec03fe76e182fd0d3
Related: OS#4518 SYS#5115
---
M ttcn3-gbproxy-test-fr/jenkins.sh
M ttcn3-gbproxy-test/jenkins.sh
2 files changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/docker-playground 
refs/changes/47/22047/2
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/22047
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I11dcf9efd0b06544a82e31dec03fe76e182fd0d3
Gerrit-Change-Number: 22047
Gerrit-PatchSet: 2
Gerrit-Owner: daniel 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-CC: pespin 
Gerrit-MessageType: newpatchset


Change in osmo-bsc[master]: Introduce Neighbor Resolution Service

2021-01-08 Thread pespin
Hello Jenkins Builder, fixeria,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bsc/+/21848

to look at the new patch set (#6).

Change subject: Introduce Neighbor Resolution Service
..

Introduce Neighbor Resolution Service

This new CTRL interface allows users of this BSC (such as attached PCU)
to gather neighbor information.

This interface is needed for PCU to translate ARFCN+BSIC keys provided
by MS in the Um side into CGI + RAC keys used to identify target cells
in RIM procedures against SGSNs on the Gb interface.

This patch extends the already existing neighbor information storage in
the VTY by allowing storage of CGI + RAC (RAC couldn't be stored
beforehand).

Related: SYS#4909
Depends: libosmocore.git Change-Id If48f412c32e8e5a3e604a78d12b74787a4786374
Change-Id: Ib07c9d23026332a207d4b7a0f7b4e76c0094e379
---
M include/osmocom/bsc/gsm_data.h
M include/osmocom/bsc/neighbor_ident.h
M src/osmo-bsc/bsc_vty.c
M src/osmo-bsc/bts.c
M src/osmo-bsc/neighbor_ident.c
M src/osmo-bsc/neighbor_ident_vty.c
M src/osmo-bsc/osmo_bsc_main.c
M tests/bsc/Makefile.am
A tests/ctrl/osmo-bsc-neigh-test.cfg
M tests/ctrl_test_runner.py
M tests/gsm0408/Makefile.am
M tests/neighbor_ident.vty
12 files changed, 366 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/48/21848/6
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21848
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ib07c9d23026332a207d4b7a0f7b4e76c0094e379
Gerrit-Change-Number: 21848
Gerrit-PatchSet: 6
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-CC: laforge 
Gerrit-MessageType: newpatchset


Change in libosmocore[master]: Intoduce Packet Switch CGI

2021-01-08 Thread pespin
Hello Jenkins Builder, laforge, dexter,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/libosmocore/+/22013

to look at the new patch set (#5).

Change subject: Intoduce Packet Switch CGI
..

Intoduce Packet Switch CGI

This structure is needed in order to identify a given cell within the
BSS during RIM transactions.
The naming was made up by myself since I couldn't find any naming
reference for this kind of data (RAI + CI).
Since LAI + CI = CGI, then RAI + CI = CGI-PS

osmo_rai_name2 family of functions get a "2" suffix due to already
existing functions handling struct struct gprs_ra_id in gsm48.h

Change-Id: If48f412c32e8e5a3e604a78d12b74787a4786374
---
M include/osmocom/gsm/gsm0808_utils.h
M include/osmocom/gsm/gsm23003.h
M include/osmocom/gsm/protocol/gsm_08_08.h
M src/gsm/gsm0808_utils.c
M src/gsm/gsm23003.c
M src/gsm/libosmogsm.map
6 files changed, 136 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/13/22013/5
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22013
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: If48f412c32e8e5a3e604a78d12b74787a4786374
Gerrit-Change-Number: 22013
Gerrit-PatchSet: 5
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: laforge 
Gerrit-MessageType: newpatchset


Change in libosmocore[master]: Intoduce Packet Switch CGI

2021-01-08 Thread dexter
dexter has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/22013 )

Change subject: Intoduce Packet Switch CGI
..


Patch Set 4: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22013
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: If48f412c32e8e5a3e604a78d12b74787a4786374
Gerrit-Change-Number: 22013
Gerrit-PatchSet: 4
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Fri, 08 Jan 2021 15:26:36 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in osmo-gsm-tester[master]: enb: add abstract method stop()

2021-01-08 Thread pespin
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22054 )

Change subject: enb: add abstract method stop()
..


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22054/2/src/osmo_gsm_tester/obj/enb_srs.py
File src/osmo_gsm_tester/obj/enb_srs.py:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22054/2/src/osmo_gsm_tester/obj/enb_srs.py@122
PS2, Line 122: def stop(self):
This is wrong, you are overwritting the srslte_common code. You need to drop 
the method here in that case.



--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22054
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: Ide606e1a6b523997215aa2fa39d4d56ae1f49181
Gerrit-Change-Number: 22054
Gerrit-PatchSet: 2
Gerrit-Owner: srs_andre 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Fri, 08 Jan 2021 15:18:26 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in osmo-gsm-tester[master]: enb, ue, process: move stdout counter helper to process objects

2021-01-08 Thread pespin
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22042 )

Change subject: enb,ue,process: move stdout counter helper to process objects
..


Patch Set 4: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22042/4/src/osmo_gsm_tester/obj/enb.py
File src/osmo_gsm_tester/obj/enb.py:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22042/4/src/osmo_gsm_tester/obj/enb.py@351
PS4, Line 351: raise log.Error('get_counter() not implemented!')
this should simply be "pass". Then in all subclasses which don't have a proper 
implementation (amarisoft enb?) add the method with the raise line.



--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22042
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I434f072b8aa6f4dce9f90889c6b40832f6798ff8
Gerrit-Change-Number: 22042
Gerrit-PatchSet: 4
Gerrit-Owner: srs_andre 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Fri, 08 Jan 2021 15:16:04 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in libosmocore[master]: Intoduce Packet Switch CGI

2021-01-08 Thread pespin
Hello Jenkins Builder, laforge, dexter,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/libosmocore/+/22013

to look at the new patch set (#4).

Change subject: Intoduce Packet Switch CGI
..

Intoduce Packet Switch CGI

This structure is needed in order to identify a given cell within the
BSS during RIM transactions.
The naming was made up by myself since I couldn't find any naming
reference for this kind of data (RAI + CI).
Since LAI + CI = CGI, then RAI + CI = CGI-PS

osmo_rai_name2 family of functions get a "2" suffix due to already
existing functions handling struct struct gprs_ra_id in gsm48.h

Change-Id: If48f412c32e8e5a3e604a78d12b74787a4786374
---
M include/osmocom/gsm/gsm0808_utils.h
M include/osmocom/gsm/gsm23003.h
M include/osmocom/gsm/protocol/gsm_08_08.h
M src/gsm/gsm0808_utils.c
M src/gsm/gsm23003.c
5 files changed, 129 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/13/22013/4
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22013
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: If48f412c32e8e5a3e604a78d12b74787a4786374
Gerrit-Change-Number: 22013
Gerrit-PatchSet: 4
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: laforge 
Gerrit-MessageType: newpatchset


Change in libosmocore[master]: Intoduce Packet Switch CGI

2021-01-08 Thread dexter
dexter has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/22013 )

Change subject: Intoduce Packet Switch CGI
..


Patch Set 3: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22013
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: If48f412c32e8e5a3e604a78d12b74787a4786374
Gerrit-Change-Number: 22013
Gerrit-PatchSet: 3
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Fri, 08 Jan 2021 15:07:54 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in osmo-bsc[master]: Introduce Neighbor Resolution Service

2021-01-08 Thread pespin
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/21848 )

Change subject: Introduce Neighbor Resolution Service
..


Patch Set 5:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/21848/5/src/osmo-bsc/neighbor_ident.c
File src/osmo-bsc/neighbor_ident.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/21848/5/src/osmo-bsc/neighbor_ident.c@332
PS5, Line 332:  ctrl_cmd_reply_printf(cmd, "%u,%u,%u,%u,%u", 
cgi_ps->rai.lac.plmn.mcc,
I just thought it may make sense to return them using format "%u-%u-%u..." 
instead, that's a more common formatting.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21848
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ib07c9d23026332a207d4b7a0f7b4e76c0094e379
Gerrit-Change-Number: 21848
Gerrit-PatchSet: 5
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-CC: laforge 
Gerrit-Comment-Date: Fri, 08 Jan 2021 14:58:38 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment


Change in osmo-gsm-tester[master]: enb, ue, process: move stdout counter helper to process objects

2021-01-08 Thread srs_andre
Hello Jenkins Builder, pespin,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22042

to look at the new patch set (#4).

Change subject: enb,ue,process: move stdout counter helper to process objects
..

enb,ue,process: move stdout counter helper to process objects

this patch adds the stdout counter to count events happening
on the stdout (known from the UE already) to the common
process class so they can also be used from the eNB (and other objects)

In addition, we add a PRACH counter to be used for tests.

Change-Id: I434f072b8aa6f4dce9f90889c6b40832f6798ff8
---
M src/osmo_gsm_tester/core/process.py
M src/osmo_gsm_tester/obj/enb.py
M src/osmo_gsm_tester/obj/enb_amarisoft.py
M src/osmo_gsm_tester/obj/enb_srs.py
M src/osmo_gsm_tester/obj/ms_srs.py
M src/osmo_gsm_tester/obj/srslte_common.py
6 files changed, 31 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester 
refs/changes/42/22042/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22042
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I434f072b8aa6f4dce9f90889c6b40832f6798ff8
Gerrit-Change-Number: 22042
Gerrit-PatchSet: 4
Gerrit-Owner: srs_andre 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-MessageType: newpatchset


Change in osmo-gsm-tester[master]: enb: add abstract method stop()

2021-01-08 Thread srs_andre
Hello Jenkins Builder, pespin,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22054

to look at the new patch set (#2).

Change subject: enb: add abstract method stop()
..

enb: add abstract method stop()

implement as noop for Amarisoft eNB, srsENB will send q+Enter to stdin

Change-Id: Ide606e1a6b523997215aa2fa39d4d56ae1f49181
---
M src/osmo_gsm_tester/obj/enb.py
M src/osmo_gsm_tester/obj/enb_amarisoft.py
M src/osmo_gsm_tester/obj/enb_srs.py
3 files changed, 13 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester 
refs/changes/54/22054/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22054
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: Ide606e1a6b523997215aa2fa39d4d56ae1f49181
Gerrit-Change-Number: 22054
Gerrit-PatchSet: 2
Gerrit-Owner: srs_andre 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-MessageType: newpatchset


Change in osmo-bsc[master]: Introduce Neighbor Resolution Service

2021-01-08 Thread pespin
Hello Jenkins Builder, fixeria,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bsc/+/21848

to look at the new patch set (#5).

Change subject: Introduce Neighbor Resolution Service
..

Introduce Neighbor Resolution Service

This new CTRL interface allows users of this BSC (such as attached PCU)
to gather neighbor information.

This interface is needed for PCU to translate ARFCN+BSIC keys provided
by MS in the Um side into CGI + RAC keys used to identify target cells
in RIM procedures against SGSNs on the Gb interface.

This patch extends the already existing neighbor information storage in
the VTY by allowing storage of CGI + RAC (RAC couldn't be stored
beforehand).

Related: SYS#4909
Depends: libosmocore.git Change-Id If48f412c32e8e5a3e604a78d12b74787a4786374
Change-Id: Ib07c9d23026332a207d4b7a0f7b4e76c0094e379
---
M include/osmocom/bsc/gsm_data.h
M include/osmocom/bsc/neighbor_ident.h
M src/osmo-bsc/bsc_vty.c
M src/osmo-bsc/bts.c
M src/osmo-bsc/neighbor_ident.c
M src/osmo-bsc/neighbor_ident_vty.c
M src/osmo-bsc/osmo_bsc_main.c
M tests/bsc/Makefile.am
A tests/ctrl/osmo-bsc-neigh-test.cfg
M tests/ctrl_test_runner.py
M tests/gsm0408/Makefile.am
M tests/neighbor_ident.vty
12 files changed, 369 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/48/21848/5
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21848
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ib07c9d23026332a207d4b7a0f7b4e76c0094e379
Gerrit-Change-Number: 21848
Gerrit-PatchSet: 5
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-CC: laforge 
Gerrit-MessageType: newpatchset


Change in osmo-bsc[master]: Introduce Neighbor resolution service

2021-01-08 Thread pespin
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/21848 )

Change subject: Introduce Neighbor resolution service
..


Patch Set 4:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/21848/4/include/osmocom/bsc/neighbor_ident.h
File include/osmocom/bsc/neighbor_ident.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/21848/4/include/osmocom/bsc/neighbor_ident.h@64
PS4, Line 64: #include 
> Ack
the header is needed due to use of _LAST_CTRL_NODE too.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21848
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ib07c9d23026332a207d4b7a0f7b4e76c0094e379
Gerrit-Change-Number: 21848
Gerrit-PatchSet: 4
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-CC: laforge 
Gerrit-Comment-Date: Fri, 08 Jan 2021 13:55:13 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Comment-In-Reply-To: fixeria 
Gerrit-MessageType: comment


Change in osmo-ttcn3-hacks[master]: CTRL: Introduce support to run osmocom CTRL server

2021-01-08 Thread pespin
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22012 )

Change subject: CTRL: Introduce support to run osmocom CTRL server
..


Patch Set 2: Code-Review+2

Merging since I applied the only comment which showed up.


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22012
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I37db9962f51baf2c63bd58ec47ec89f773d7a255
Gerrit-Change-Number: 22012
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Fri, 08 Jan 2021 13:46:43 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in osmo-ttcn3-hacks[master]: CTRL: Introduce support to run osmocom CTRL server

2021-01-08 Thread pespin
pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22012 )

Change subject: CTRL: Introduce support to run osmocom CTRL server
..

CTRL: Introduce support to run osmocom CTRL server

Change-Id: I37db9962f51baf2c63bd58ec47ec89f773d7a255
---
M bsc-nat/BSCNAT_Tests.ttcn
M bsc/BSC_Tests.ttcn
M bts/BTS_Tests.ttcn
M hlr/HLR_Tests.ttcn
M library/Osmocom_CTRL_Adapter.ttcn
M library/Osmocom_CTRL_Functions.ttcn
M msc/BSC_ConnectionHandler.ttcn
M msc/MSC_Tests.ttcn
M sip/SIP_Tests.ttcn
9 files changed, 60 insertions(+), 22 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved



diff --git a/bsc-nat/BSCNAT_Tests.ttcn b/bsc-nat/BSCNAT_Tests.ttcn
index 41d58d7..1b24855 100644
--- a/bsc-nat/BSCNAT_Tests.ttcn
+++ b/bsc-nat/BSCNAT_Tests.ttcn
@@ -151,7 +151,7 @@

f_init_vty("VirtBSCNAT");
f_vty_allow_osmux(use_osmux);
-   f_ipa_ctrl_start(mp_nat_ip, mp_nat_ctrl_port);
+   f_ipa_ctrl_start_client(mp_nat_ip, mp_nat_ctrl_port);

for (i := 0; i < NUM_MSC; i := i+1) {
f_init_MscState(msc[i], mp_msc_pc +i, mp_bsc_pc, mp_msc_ssn, 
mp_bsc_ssn);
diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index a1fa4dd..2c02e36 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -1103,7 +1103,7 @@
/* start the test with exactly all enabled MSCs allowed to attach */
f_vty_msc_allow_attach(BSCVTY, allow_attach);

-   f_ipa_ctrl_start(mp_bsc_ip, mp_bsc_ctrl_port);
+   f_ipa_ctrl_start_client(mp_bsc_ip, mp_bsc_ctrl_port);

f_init_mgcp("VirtMSC");

@@ -3080,7 +3080,7 @@
bts[0].rsl.ccm_pars.name := "Osmocom TTCN-3 BTS Simulator";
bts[0].rsl.ccm_pars.unit_id := "99/0/0"; /* value which is unknown at 
BTS */
 
-   f_ipa_ctrl_start(mp_bsc_ip, mp_bsc_ctrl_port);
+   f_ipa_ctrl_start_client(mp_bsc_ip, mp_bsc_ctrl_port);

f_init_mgcp("VirtMSC");

diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index 16e3d71..c843032 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -547,7 +547,7 @@
f_init_rsl(id);
f_sleep(0.5);   /* workaround for OS#3000 */
f_init_vty(id);
-   f_ipa_ctrl_start(mp_ctrl_ip, mp_ctrl_port);
+   f_ipa_ctrl_start_client(mp_ctrl_ip, mp_ctrl_port);

/* Send SI3 to the BTS, it is needed for various computations */
f_rsl_bcch_fill(RSL_SYSTEM_INFO_3, ts_SI3_default);
@@ -5376,7 +5376,7 @@

/* re-connect CTRL port from BTS to BSC */
f_ipa_ctrl_stop();
-   f_ipa_ctrl_start(mp_bsc_ctrl_ip, mp_bsc_ctrl_port);
+   f_ipa_ctrl_start_client(mp_bsc_ctrl_ip, mp_bsc_ctrl_port);

/* Send that OML Alert */
PCU.send(t_SD_PCUIF(g_pcu_conn_id, ts_PCUIF_TXT_IND(0, PCU_OML_ALERT, 
testcasename(;
diff --git a/hlr/HLR_Tests.ttcn b/hlr/HLR_Tests.ttcn
index 36e28b8..ea450b3 100644
--- a/hlr/HLR_Tests.ttcn
+++ b/hlr/HLR_Tests.ttcn
@@ -245,7 +245,7 @@
f_init_gsup_server("HLR_Test");
}

-   f_ipa_ctrl_start(mp_hlr_ip, mp_hlr_ctrl_port);
+   f_ipa_ctrl_start_client(mp_hlr_ip, mp_hlr_ctrl_port);
 }

 /*! Start HLR_ConnHdlr from testCT in a separate thread.
diff --git a/library/Osmocom_CTRL_Adapter.ttcn 
b/library/Osmocom_CTRL_Adapter.ttcn
index 0be3ebb..fefff8b 100644
--- a/library/Osmocom_CTRL_Adapter.ttcn
+++ b/library/Osmocom_CTRL_Adapter.ttcn
@@ -26,12 +26,24 @@
port IPA_CTRL_PT IPA_CTRL;
 }

-
-/*! Start the CTRL connection to the specified BSC IP+Port */
-function f_ipa_ctrl_start(charstring bsc_host, PortNumber bsc_port)
+/* wait for IPA CTRL link to connect and send UP */
+function f_ipa_ctrl_wait_link_up()
 runs on CTRL_Adapter_CT {
-   var charstring id := "IPA-CTRL"
timer T := 10.0;
+   T.start;
+   alt {
+   [] IPA_CTRL.receive(tr_ASP_IPA_EV(ASP_IPA_EVENT_UP)) { }
+   [] T.timeout {
+   setverdict(fail, "Timeout CTRL waiting for ASP_IPA_EVENT_UP");
+   mtc.stop;
+   }
+   }
+}
+
+/*! Start the CTRL client connection to the specified CTRL IP+Port server*/
+function f_ipa_ctrl_start_client(charstring bsc_host, PortNumber bsc_port)
+runs on CTRL_Adapter_CT {
+   var charstring id := "IPA-CTRL-CLI"

vc_CTRL_IPA := IPA_Emulation_CT.create(id & "-IPA");

@@ -41,15 +53,21 @@
vc_CTRL_IPA.start(IPA_Emulation.main_client(bsc_host, bsc_port, "", 0,
c_IPA_default_ccm_pars, 
false));

-   /* wait for IPA CTRL link to connect and send UP */
-   T.start;
-   alt {
-   [] IPA_CTRL.receive(tr_ASP_IPA_EV(ASP_IPA_EVENT_UP)) { }
-   [] T.timeout {
-   setverdict(fail, "Timeout CTRL waiting for ASP_IPA_EVENT_UP");
-   mtc.stop;
-   }
-   }
+   f_ipa_ctrl_wait_link_up();
+}
+
+/*! Start the CTRL server on the specified CTRL I

Change in osmo-bsc[master]: Introduce Neighbor resolution service

2021-01-08 Thread pespin
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/21848 )

Change subject: Introduce Neighbor resolution service
..


Patch Set 4:

(5 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/21848/4/include/osmocom/bsc/neighbor_ident.h
File include/osmocom/bsc/neighbor_ident.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/21848/4/include/osmocom/bsc/neighbor_ident.h@64
PS4, Line 64: #include 
> Let's rather add a forward declaration for 'struct ctrl_handle' above, rather 
> than including a heade […]
Ack


https://gerrit.osmocom.org/c/osmo-bsc/+/21848/4/include/osmocom/bsc/neighbor_ident.h@70
PS4, Line 70:   _LAST_CTRL_NIDE_NEIGHBOR
typo: NODE


https://gerrit.osmocom.org/c/osmo-bsc/+/21848/4/src/osmo-bsc/neighbor_ident.c
File src/osmo-bsc/neighbor_ident.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/21848/4/src/osmo-bsc/neighbor_ident.c@337
PS4, Line 337:  return CTRL_CMD_REPLY;
> So if we reach this part, we leak the 'tmp'? Let's finally make use of 
> OTC_SELECT!
Ack


https://gerrit.osmocom.org/c/osmo-bsc/+/21848/4/src/osmo-bsc/neighbor_ident_vty.c
File src/osmo-bsc/neighbor_ident_vty.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/21848/4/src/osmo-bsc/neighbor_ident_vty.c@164
PS4, Line 164:  cell_id = (struct gsm0808_cell_id){
> This definition could be even shorter: […]
Ack


https://gerrit.osmocom.org/c/osmo-bsc/+/21848/4/src/osmo-bsc/osmo_bsc_main.c
File src/osmo-bsc/osmo_bsc_main.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/21848/4/src/osmo-bsc/osmo_bsc_main.c@966
PS4, Line 966: Failed to install neighbor control commands
> Something seems to be wrong here. […]
Ack



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21848
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ib07c9d23026332a207d4b7a0f7b4e76c0094e379
Gerrit-Change-Number: 21848
Gerrit-PatchSet: 4
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-CC: laforge 
Gerrit-Comment-Date: Fri, 08 Jan 2021 13:43:14 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria 
Gerrit-MessageType: comment


Change in osmo-gsm-tester[master]: scenarios: remove ncells@ scenario and define number of cells explicitly

2021-01-08 Thread pespin
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22055 )

Change subject: scenarios: remove ncells@ scenario and define number of cells 
explicitly
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22055
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: If022d9e8d239805ee1280fb52660e68dda7484a0
Gerrit-Change-Number: 22055
Gerrit-PatchSet: 1
Gerrit-Owner: srs_andre 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Fri, 08 Jan 2021 13:38:02 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in osmo-gsm-tester[master]: enb: add abstract method stop()

2021-01-08 Thread pespin
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22054 )

Change subject: enb: add abstract method stop()
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22054
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: Ide606e1a6b523997215aa2fa39d4d56ae1f49181
Gerrit-Change-Number: 22054
Gerrit-PatchSet: 1
Gerrit-Owner: srs_andre 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Fri, 08 Jan 2021 13:36:34 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in osmo-gsm-tester[master]: srsenb.conf.tmpl: set nof_of_prach_threds to 0 for ZMQ

2021-01-08 Thread pespin
pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22041 )

Change subject: srsenb.conf.tmpl: set nof_of_prach_threds to 0 for ZMQ
..

srsenb.conf.tmpl: set nof_of_prach_threds to 0 for ZMQ

this executed the PRACH search in the main thread so
PHY workers and PRACH processing don't diverge in loaded
scenarios

Change-Id: I97eddb5f9ca682251ded1f73093c2d0a49462bd6
---
M src/osmo_gsm_tester/templates/srsenb.conf.tmpl
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, approved



diff --git a/src/osmo_gsm_tester/templates/srsenb.conf.tmpl 
b/src/osmo_gsm_tester/templates/srsenb.conf.tmpl
index 5df432b..7ac75bb 100644
--- a/src/osmo_gsm_tester/templates/srsenb.conf.tmpl
+++ b/src/osmo_gsm_tester/templates/srsenb.conf.tmpl
@@ -271,6 +271,9 @@
 #
 #
 [expert]
+% if enb.rf_dev_type == 'zmq':
+nof_prach_threads = 0
+% endif
 #pusch_max_its= 8 # These are half iterations
 #pusch_8bit_decoder   = false
 #nof_phy_threads = 3

--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22041
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I97eddb5f9ca682251ded1f73093c2d0a49462bd6
Gerrit-Change-Number: 22041
Gerrit-PatchSet: 2
Gerrit-Owner: srs_andre 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged


Change in osmo-gsm-tester[master]: srsepc.conf.tmpl: increase default value of T3413 (paging timer)

2021-01-08 Thread pespin
pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22040 )

Change subject: srsepc.conf.tmpl: increase default value of T3413 (paging timer)
..

srsepc.conf.tmpl: increase default value of T3413 (paging timer)

we've seen that the default value of 2s might be a bit tight.
the value is network dependent so no real default value exists.
however, 6s seems to be a good compromise.

Change-Id: Icc75ee048c2cc605ab26c4c87a039519998f7e57
---
M src/osmo_gsm_tester/templates/srsepc.conf.tmpl
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, approved



diff --git a/src/osmo_gsm_tester/templates/srsepc.conf.tmpl 
b/src/osmo_gsm_tester/templates/srsepc.conf.tmpl
index 830cd32..62f9977 100644
--- a/src/osmo_gsm_tester/templates/srsepc.conf.tmpl
+++ b/src/osmo_gsm_tester/templates/srsepc.conf.tmpl
@@ -31,7 +31,7 @@
 dns_addr = 8.8.8.8
 encryption_algo = EEA0
 integrity_algo = EIA1
-paging_timer = 2
+paging_timer = 6

 #
 # HSS configuration

--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22040
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: Icc75ee048c2cc605ab26c4c87a039519998f7e57
Gerrit-Change-Number: 22040
Gerrit-PatchSet: 2
Gerrit-Owner: srs_andre 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged


Change in osmo-gsm-tester[master]: enb_srs: adopt throughput thresholds for QAM256

2021-01-08 Thread pespin
pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22039 )

Change subject: enb_srs: adopt throughput thresholds for QAM256
..

enb_srs: adopt throughput thresholds for QAM256

it turned out that we have to reduce the MCS when using QAM256,
especially for 6 PRB as subframe 0 and 5 contains PBCH and PSS
signals, so the available REs are reduced.

The eNB scheduler now has this limitation in mind and lowers the MCS.

Change-Id: I0e38fe28002fd68c768cc8dcffcf74f4f190df02
---
M src/osmo_gsm_tester/obj/enb_srs.py
1 file changed, 8 insertions(+), 8 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, approved



diff --git a/src/osmo_gsm_tester/obj/enb_srs.py 
b/src/osmo_gsm_tester/obj/enb_srs.py
index 1b17c3c..6afc873 100644
--- a/src/osmo_gsm_tester/obj/enb_srs.py
+++ b/src/osmo_gsm_tester/obj/enb_srs.py
@@ -276,14 +276,14 @@
 def ue_max_rate(self, downlink=True, num_carriers=1):
 # The max rate for a single UE per PRB configuration in TM1 with MCS 28
 if 'dl_qam256' in self.ue.features():
-max_phy_rate_tm1_dl = {6: 5.9e6,
-   15: 14.6e6,
-   25: 24.5e6,
-   50: 48.9e6,
-   75: 75.3e6,
-   100: 97.8e6}
+max_phy_rate_tm1_dl = {6: 4.4e6,
+   15: 14e6,
+   25: 24e6,
+   50: 49e6,
+   75: 75e6,
+   100: 98e6}
 else:
-max_phy_rate_tm1_dl = {6: 3.5e6,
+max_phy_rate_tm1_dl = {6: 3.3e6,
15: 11e6,
25: 18e6,
50: 36e6,
@@ -296,7 +296,7 @@
 25 : 14e6,
 50 : 32e6,
 75 : 34e6,
-100 : 70e6 }
+100 : 71e6 }
 else:
 max_phy_rate_tm1_ul = { 6 : 1.7e6,
 15 : 4.7e6,

--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22039
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I0e38fe28002fd68c768cc8dcffcf74f4f190df02
Gerrit-Change-Number: 22039
Gerrit-PatchSet: 2
Gerrit-Owner: srs_andre 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged


Change in osmo-gsm-tester[master]: enb_srs: only use QAM64 tables if both UE and eNB are configured for ...

2021-01-08 Thread pespin
pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22038 )

Change subject: enb_srs: only use QAM64 tables if both UE and eNB are 
configured for QAM64
..

enb_srs: only use QAM64 tables if both UE and eNB are configured for QAM64

this was causing failed tests because to achieve QAM64 rates both
eNB and UE need to support it and have it activated.

Change-Id: I599df92d69eeb56a5d44327de08f004222cff073
---
M src/osmo_gsm_tester/obj/enb_srs.py
1 file changed, 5 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, approved



diff --git a/src/osmo_gsm_tester/obj/enb_srs.py 
b/src/osmo_gsm_tester/obj/enb_srs.py
index 7fde719..1b17c3c 100644
--- a/src/osmo_gsm_tester/obj/enb_srs.py
+++ b/src/osmo_gsm_tester/obj/enb_srs.py
@@ -72,6 +72,7 @@
 self.remote_log_file = None
 self.remote_pcap_file = None
 self.enable_pcap = False
+self.enable_ul_qam64 = False
 self.metrics_file = None
 self.stop_sleep_time = 6 # We require at most 5s to stop
 self.testenv = testenv
@@ -192,7 +193,9 @@
 self.enable_pcap = util.str2bool(values['enb'].get('enable_pcap', 
'false'))
 config.overlay(values, dict(enb={'enable_pcap': self.enable_pcap}))

-config.overlay(values, dict(enb={'enable_ul_qam64': 
util.str2bool(values['enb'].get('enable_ul_qam64', 'false'))}))
+self.enable_ul_qam64 = 
util.str2bool(values['enb'].get('enable_ul_qam64', 'false'))
+config.overlay(values, dict(enb={'enable_ul_qam64': 
self.enable_ul_qam64}))
+
 config.overlay(values, dict(enb={'enable_dl_awgn': 
util.str2bool(values['enb'].get('enable_dl_awgn', 'false'))}))
 config.overlay(values, dict(enb={'rf_dev_sync': 
values['enb'].get('rf_dev_sync', None)}))

@@ -287,7 +290,7 @@
75: 55e6,
100: 75e6}

-if 'ul_qam64' in self.ue.features():
+if self.enable_ul_qam64 and 'ul_qam64' in self.ue.features():
 max_phy_rate_tm1_ul = { 6 : 2.7e6,
 15 : 6.5e6,
 25 : 14e6,

--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22038
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I599df92d69eeb56a5d44327de08f004222cff073
Gerrit-Change-Number: 22038
Gerrit-PatchSet: 2
Gerrit-Owner: srs_andre 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged


Change in osmo-gsm-tester[master]: srsue.conf.tmpl: disable TTI stats for ZMQ

2021-01-08 Thread pespin
pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22036 )

Change subject: srsue.conf.tmpl: disable TTI stats for ZMQ
..

srsue.conf.tmpl: disable TTI stats for ZMQ

since ZMQ runs are not using wall clock anyway, measuring
TTI execution isn't useful, disable it therefore to avoid
misleading warnings.

Change-Id: I5c2cb0abcfce0ee67806f6611356f4d5d180541d
---
M src/osmo_gsm_tester/templates/srsue.conf.tmpl
1 file changed, 5 insertions(+), 0 deletions(-)

Approvals:
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo_gsm_tester/templates/srsue.conf.tmpl 
b/src/osmo_gsm_tester/templates/srsue.conf.tmpl
index a57857b..a50f91e 100644
--- a/src/osmo_gsm_tester/templates/srsue.conf.tmpl
+++ b/src/osmo_gsm_tester/templates/srsue.conf.tmpl
@@ -381,3 +381,8 @@
 metrics_csv_enable  = true
 #metrics_period_secs = 1
 metrics_csv_filename = ${ue.metrics_filename}
+
+% if ue.rf_dev_type == 'zmq':
+[stack]
+have_tti_time_stats = false
+% endif

--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22036
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I5c2cb0abcfce0ee67806f6611356f4d5d180541d
Gerrit-Change-Number: 22036
Gerrit-PatchSet: 1
Gerrit-Owner: srs_andre 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged


Change in osmo-gsm-tester[master]: intraenb-intrafreq-ho.conf: add eNB to cell config

2021-01-08 Thread pespin
pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22035 )

Change subject: intraenb-intrafreq-ho.conf: add eNB to cell config
..

intraenb-intrafreq-ho.conf: add eNB to cell config

make sure to have the right eNB that matches the
cells neighbor ECIDs, otherwise the eNB may trigger
a S1 HO if the eNB ID is set elsewhere

Change-Id: Id494ac1984846e78a6456bb6a17e72d63c9dacf5
---
M sysmocom/scenarios/mod-enb-cells-intraenb-intrafreq-ho.conf
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/sysmocom/scenarios/mod-enb-cells-intraenb-intrafreq-ho.conf 
b/sysmocom/scenarios/mod-enb-cells-intraenb-intrafreq-ho.conf
index 8b6f569..f4223a5 100644
--- a/sysmocom/scenarios/mod-enb-cells-intraenb-intrafreq-ho.conf
+++ b/sysmocom/scenarios/mod-enb-cells-intraenb-intrafreq-ho.conf
@@ -1,7 +1,9 @@
 # Cell config for Intra eNB HO, two cells on same frequencey (same EARFCN) on 
different RF ports (srsENB)
 modifiers:
   enb:
-  - cell_list:
+  - id: 0x19B
+enable_measurements: true
+cell_list:
 - cell_id: 0x01
   pci: 0x01
   tac: 0x0007

--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22035
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: Id494ac1984846e78a6456bb6a17e72d63c9dacf5
Gerrit-Change-Number: 22035
Gerrit-PatchSet: 1
Gerrit-Owner: srs_andre 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged


Change in osmo-gsm-tester[master]: srsue.conf.tmpl: reorder conditions for setting RRC release

2021-01-08 Thread pespin
pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22034 )

Change subject: srsue.conf.tmpl: reorder conditions for setting RRC release
..

srsue.conf.tmpl: reorder conditions for setting RRC release

the order of checks needs to go from high to low, i.e. the higher
release feature (e.g. qam256) needs to be checked and set first.

in theory it should also be possible to have a CA-capable UE
that does not support QAM256, but for srsUE we announce both anyway.

Change-Id: I2fa49f0cb5d80db412a811ceeb380359c8ad67a7
---
M src/osmo_gsm_tester/templates/srsue.conf.tmpl
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo_gsm_tester/templates/srsue.conf.tmpl 
b/src/osmo_gsm_tester/templates/srsue.conf.tmpl
index 120b938..a57857b 100644
--- a/src/osmo_gsm_tester/templates/srsue.conf.tmpl
+++ b/src/osmo_gsm_tester/templates/srsue.conf.tmpl
@@ -147,14 +147,14 @@
 # mbms_service_port: Port of the MBMS service
 #
 [rrc]
-% if int(ue.num_carriers) > 1:
-ue_category   = 7
-release   = 10
-% elif "dl_qam256" in ue.features or "ul_qam64" in ue.features:
+% if "dl_qam256" in ue.features or "ul_qam64" in ue.features:
 ue_category   = 8
 release   = 13
 ue_category_dl= 14
 ue_category_ul= 5
+% elif int(ue.num_carriers) > 1:
+ue_category   = 7
+release   = 10
 % else:
 #ue_category   = 4
 #release   = 8

--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22034
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I2fa49f0cb5d80db412a811ceeb380359c8ad67a7
Gerrit-Change-Number: 22034
Gerrit-PatchSet: 1
Gerrit-Owner: srs_andre 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged


Change in osmo-gsm-tester[master]: srsenb_drb.conf.tmpl: add QCI1 DRB config

2021-01-08 Thread pespin
pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22032 )

Change subject: srsenb_drb.conf.tmpl: add QCI1 DRB config
..

srsenb_drb.conf.tmpl: add QCI1 DRB config

use default QCI1 config for real-time voice traffic

Change-Id: I43f408b1a3c172a5eb8327f03df49801e063e5cd
---
M src/osmo_gsm_tester/templates/srsenb_drb.conf.tmpl
1 file changed, 23 insertions(+), 1 deletion(-)

Approvals:
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo_gsm_tester/templates/srsenb_drb.conf.tmpl 
b/src/osmo_gsm_tester/templates/srsenb_drb.conf.tmpl
index 5167dab..b10ef31 100644
--- a/src/osmo_gsm_tester/templates/srsenb_drb.conf.tmpl
+++ b/src/osmo_gsm_tester/templates/srsenb_drb.conf.tmpl
@@ -1,7 +1,29 @@
 // All times are in ms. Use -1 for infinity, where available

 qci_config = (
-
+// UM - real time (RTP for VOIP)
+{
+  qci=1;
+  pdcp_config = {
+discard_timer = 100;
+pdcp_sn_size = 12;
+  }
+  rlc_config = {
+ul_um = {
+  sn_field_length = 5;
+};
+dl_um = {
+  sn_field_length = 5;
+  t_reordering= 45;
+};
+  };
+  logical_channel_config = {
+priority = 4;
+prioritized_bit_rate   = 256;
+bucket_size_duration  = 1000;
+log_chan_group = 1;
+  };
+},
 {
   qci=7;
   pdcp_config = {

--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22032
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I43f408b1a3c172a5eb8327f03df49801e063e5cd
Gerrit-Change-Number: 22032
Gerrit-PatchSet: 1
Gerrit-Owner: srs_andre 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged


Change in osmo-gsm-tester[master]: enb: include name label and run_addr in enb remote path

2021-01-08 Thread pespin
pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22033 )

Change subject: enb: include name label and run_addr in enb remote path
..

enb: include name label and run_addr in enb remote path

this allows to quickly identify the enb host in the logs

Change-Id: I9c979de852a23041e43692e97ebcbfb389b52fdb
---
M src/osmo_gsm_tester/obj/enb.py
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo_gsm_tester/obj/enb.py b/src/osmo_gsm_tester/obj/enb.py
index cdf9505..3944459 100644
--- a/src/osmo_gsm_tester/obj/enb.py
+++ b/src/osmo_gsm_tester/obj/enb.py
@@ -89,7 +89,10 @@
 if self._gtp_bind_addr is None:
 self._gtp_bind_addr = self._run_node.run_addr()
 label = conf.get('label', None)
-self.set_name('%s_%s' % (name, label if label is not None else 
self._run_node.run_addr()))
+if label is not None:
+self.set_name('%s_%s_%s' % (name, label, 
self._run_node.run_addr()))
+else:
+self.set_name('%s_%s' % (name, self._run_node.run_addr()))
 self._txmode = 0
 self._id = None
 self._duplex = None

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22033
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I9c979de852a23041e43692e97ebcbfb389b52fdb
Gerrit-Change-Number: 22033
Gerrit-PatchSet: 1
Gerrit-Owner: srs_andre 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged


Change in osmo-gsm-tester[master]: jenkins-build-srslte.sh: allow custom binaries

2021-01-08 Thread pespin
pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22031 )

Change subject: jenkins-build-srslte.sh: allow custom binaries
..

jenkins-build-srslte.sh: allow custom binaries

this allows to specify the environmental var
wanted_binaries_bin that will be included in the
trial package. if the variable isn't set, all three
main srsLTE binaries are included

Change-Id: I63f5799328435ce32b5bfd6dae6fd0b37e1e5397
---
M contrib/jenkins-build-srslte.sh
1 file changed, 5 insertions(+), 1 deletion(-)

Approvals:
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/contrib/jenkins-build-srslte.sh b/contrib/jenkins-build-srslte.sh
index 80e4ffc..365c3e4 100755
--- a/contrib/jenkins-build-srslte.sh
+++ b/contrib/jenkins-build-srslte.sh
@@ -1,6 +1,10 @@
 #!/bin/sh
 set -e -x

+if [ -z "$trial_binaries" ]; then
+  trial_binaries="srsue srsenb srsepc"
+fi
+
 base="$PWD"
 name="srslte"
 git_url="${git_url:-https://github.com/srsLTE}";
@@ -10,4 +14,4 @@
 #TODO: make sure libconfig, zeroMQ is installed
 build_repo $project_name $configure_opts

-create_bin_tgz "srsue srsenb srsepc"
+create_bin_tgz "$trial_binaries"

--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22031
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I63f5799328435ce32b5bfd6dae6fd0b37e1e5397
Gerrit-Change-Number: 22031
Gerrit-PatchSet: 1
Gerrit-Owner: srs_andre 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged


Change in osmo-ci[master]: scripts: repo-install-test: fix missing version of centos8 example

2021-01-08 Thread pespin
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ci/+/22052 )

Change subject: scripts: repo-install-test: fix missing version of centos8 
example
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/22052
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I5eee27a9ba1cca43e056ef0ac4ae4bbb4cd827d7
Gerrit-Change-Number: 22052
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Fri, 08 Jan 2021 13:33:34 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in osmo-bts[master]: power_control: properly track the first initial state

2021-01-08 Thread pespin
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/22051 )

Change subject: power_control: properly track the first initial state
..


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmo-bts/+/22051/1/src/common/power_control.c
File src/common/power_control.c:

https://gerrit.osmocom.org/c/osmo-bts/+/22051/1/src/common/power_control.c@81
PS1, Line 81:   if (mps->meas_num++ == 0) {
a boolean would be better, otherwise you are applying wrong value when it 
overflows (not critical though since it would take a long time, but still it's 
easy to fix as mentioned).



--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/22051
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I16e7474b5affbd90855a2e407b305e9dec581dfa
Gerrit-Change-Number: 22051
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Fri, 08 Jan 2021 13:31:53 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in osmo-bts[master]: power_control: migrate MS/BS control loops to the new params

2021-01-08 Thread pespin
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/21993 )

Change subject: power_control: migrate MS/BS control loops to the new params
..


Patch Set 2: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21993
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ib18f84c40227841d95a36063a6789bf63054fc2e
Gerrit-Change-Number: 21993
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Fri, 08 Jan 2021 13:29:42 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in osmo-bts[master]: power_control: generalize measurement pre-processing state

2021-01-08 Thread pespin
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/21907 )

Change subject: power_control: generalize measurement pre-processing state
..


Patch Set 6: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21907
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I439c00b394da670e314f217b3246cc85ce8213c6
Gerrit-Change-Number: 21907
Gerrit-PatchSet: 6
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Fri, 08 Jan 2021 13:28:04 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in osmo-sgsn[master]: gbproxy: Implement TLLI cache and use it for SUSPEND/RESUME

2021-01-08 Thread pespin
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/21960 )

Change subject: gbproxy: Implement TLLI cache and use it for SUSPEND/RESUME
..


Patch Set 3: Code-Review-1

(9 comments)

https://gerrit.osmocom.org/c/osmo-sgsn/+/21960/3/include/osmocom/sgsn/gb_proxy.h
File include/osmocom/sgsn/gb_proxy.h:

https://gerrit.osmocom.org/c/osmo-sgsn/+/21960/3/include/osmocom/sgsn/gb_proxy.h@175
PS3, Line 175: struct gbproxy_tlli_cache {
cache_entry or cache_item would be more descriptive imho


https://gerrit.osmocom.org/c/osmo-sgsn/+/21960/3/src/gbproxy/gb_proxy.c
File src/gbproxy/gb_proxy.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/21960/3/src/gbproxy/gb_proxy.c@896
PS3, Line 896:  tlli = osmo_load32be(TLVP_VAL(&tp, BSSGP_IE_TLLI));
would be great checking if TLLI is really there instead of directly 
de-referencing it.


https://gerrit.osmocom.org/c/osmo-sgsn/+/21960/3/src/gbproxy/gb_proxy.c@1164
PS3, Line 1164: uint32_t tlli = osmo_load32be(TLVP_VAL(&tp, 
BSSGP_IE_TLLI));
same


https://gerrit.osmocom.org/c/osmo-sgsn/+/21960/3/src/gbproxy/gb_proxy.c@1170
PS3, Line 1170: // FIXME
FIX what?


https://gerrit.osmocom.org/c/osmo-sgsn/+/21960/3/src/gbproxy/gb_proxy.c@1400
PS3, Line 1400: void tlli_cache_cleanup(void *data)
static


https://gerrit.osmocom.org/c/osmo-sgsn/+/21960/3/src/gbproxy/gb_proxy.c@1405
PS3, Line 1405: osmo_timer_schedule(&cfg->tlli_cache.timer, 2, 0);
Probably worth avoid reescheduling it if the tlli cache is empty, and 
reenabling it when first item is added.


https://gerrit.osmocom.org/c/osmo-sgsn/+/21960/3/src/gbproxy/gb_proxy_peer.c
File src/gbproxy/gb_proxy_peer.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/21960/3/src/gbproxy/gb_proxy_peer.c@270
PS3, Line 270:  // Update the entry if it already exists
/* */


https://gerrit.osmocom.org/c/osmo-sgsn/+/21960/3/src/gbproxy/gb_proxy_peer.c@320
PS3, Line 320:  expiry = now.tv_sec - cfg->tlli_cache.timeout;
I'd go or using timespec completely.
include  and you have there all the timespeccmp, 
timespecsub, etc. available.


https://gerrit.osmocom.org/c/osmo-sgsn/+/21960/3/src/gbproxy/gb_proxy_peer.c@323
PS3, Line 323:  if (tlli_cache->tstamp.tv_sec < expiry) {
timespeccmp



--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21960
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I42adf70f560d2bb358a9e1c7614281e8d2967568
Gerrit-Change-Number: 21960
Gerrit-PatchSet: 3
Gerrit-Owner: daniel 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-CC: laforge 
Gerrit-Comment-Date: Fri, 08 Jan 2021 13:26:42 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in osmo-gsm-tester[master]: enb: add abstract method stop()

2021-01-08 Thread srs_andre
srs_andre has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22054 )


Change subject: enb: add abstract method stop()
..

enb: add abstract method stop()

implement as noop for Amarisoft eNB, srsENB will send q+Enter to stdin

Change-Id: Ide606e1a6b523997215aa2fa39d4d56ae1f49181
---
M src/osmo_gsm_tester/obj/enb.py
M src/osmo_gsm_tester/obj/enb_amarisoft.py
2 files changed, 9 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester 
refs/changes/54/22054/1

diff --git a/src/osmo_gsm_tester/obj/enb.py b/src/osmo_gsm_tester/obj/enb.py
index 2eac0fe..1a5658d 100644
--- a/src/osmo_gsm_tester/obj/enb.py
+++ b/src/osmo_gsm_tester/obj/enb.py
@@ -327,6 +327,11 @@
 pass

 @abstractmethod
+def stop(self):
+'Stop ENB'
+pass
+
+@abstractmethod
 def ue_add(self, ue):
 pass

diff --git a/src/osmo_gsm_tester/obj/enb_amarisoft.py 
b/src/osmo_gsm_tester/obj/enb_amarisoft.py
index 60985f4..b7ede3b 100644
--- a/src/osmo_gsm_tester/obj/enb_amarisoft.py
+++ b/src/osmo_gsm_tester/obj/enb_amarisoft.py
@@ -130,6 +130,10 @@
 self.testenv.remember_to_stop(self.process)
 self.process.launch()

+def stop(self):
+# Not implemented
+pass
+
 def gen_conf_file(self, path, filename, values):
 self.dbg('AmarisoftENB ' + filename + ':\n' + pprint.pformat(values))
 with open(path, 'w') as f:

--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22054
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: Ide606e1a6b523997215aa2fa39d4d56ae1f49181
Gerrit-Change-Number: 22054
Gerrit-PatchSet: 1
Gerrit-Owner: srs_andre 
Gerrit-MessageType: newchange


Change in osmo-gsm-tester[master]: enb: Set cipher and integrity via scenario file

2021-01-08 Thread srs_andre
srs_andre has uploaded a new patch set (#4) to the change originally created by 
ninjab3s. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21582 )

Change subject: enb: Set cipher and integrity via scenario file
..

enb: Set cipher and integrity via scenario file

This patch enables setting cipher and integrity algorithms
in Amarisoft eNB and srsENB via scenario files. If no
settings are defined following defaults are applied:
- Cipher algorithm: EEA0, EEA2, EEA1
- Integrity algorithm: EIA2, EIA1, EIA0

Example of setting cipher algorithms:
- 
4g:srsue-rftype@uhd+srsenb-rftype@uhd+mod-enb-cipher@eea1+mod-enb-cipher@eea0+mod-enb-nprb@6

Change-Id: I595206b7d49016fb6d0aec175c828d9537c53886
---
M src/osmo_gsm_tester/core/schema.py
M src/osmo_gsm_tester/obj/bts.py
M src/osmo_gsm_tester/obj/enb.py
M src/osmo_gsm_tester/obj/enb_amarisoft.py
M src/osmo_gsm_tester/obj/ms.py
M src/osmo_gsm_tester/templates/amarisoft_enb.cfg.tmpl
M src/osmo_gsm_tester/templates/srsenb.conf.tmpl
M sysmocom/defaults.conf
A sysmocom/scenarios/mod-enb-cipher@.conf
A sysmocom/scenarios/mod-enb-integrity@.conf
10 files changed, 45 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester 
refs/changes/82/21582/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21582
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I595206b7d49016fb6d0aec175c828d9537c53886
Gerrit-Change-Number: 21582
Gerrit-PatchSet: 4
Gerrit-Owner: ninjab3s 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Reviewer: srs_andre 
Gerrit-MessageType: newpatchset


Change in osmo-gsm-tester[master]: scenarios: remove ncells@ scenario and define number of cells explicitly

2021-01-08 Thread srs_andre
srs_andre has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22055 )


Change subject: scenarios: remove ncells@ scenario and define number of cells 
explicitly
..

scenarios: remove ncells@ scenario and define number of cells explicitly

the specific cell scenarios files already contain cell-related
information so having a extra ncells scenario seems too much overhead.
furthermore, in more complex tests its helps to reduce the filename/path
lenght to avoid hitting the 255 character limit

Change-Id: If022d9e8d239805ee1280fb52660e68dda7484a0
---
M sysmocom/scenarios/mod-enb-cells-2ca.conf
M sysmocom/scenarios/mod-enb-cells-intra-freq-ho-sameport.conf
M sysmocom/scenarios/mod-enb-cells-intraenb-intrafreq-ho.conf
D sysmocom/scenarios/mod-enb-ncells@.conf
4 files changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester 
refs/changes/55/22055/1

diff --git a/sysmocom/scenarios/mod-enb-cells-2ca.conf 
b/sysmocom/scenarios/mod-enb-cells-2ca.conf
index c9468c6..916d0eb 100644
--- a/sysmocom/scenarios/mod-enb-cells-2ca.conf
+++ b/sysmocom/scenarios/mod-enb-cells-2ca.conf
@@ -2,6 +2,7 @@
 modifiers:
   enb:
   - id: 0x19B
+num_cells: 2
 cell_list:
 - cell_id: 0x00
   pci: 0x01
diff --git a/sysmocom/scenarios/mod-enb-cells-intra-freq-ho-sameport.conf 
b/sysmocom/scenarios/mod-enb-cells-intra-freq-ho-sameport.conf
index 899ec4b..2d629f9 100644
--- a/sysmocom/scenarios/mod-enb-cells-intra-freq-ho-sameport.conf
+++ b/sysmocom/scenarios/mod-enb-cells-intra-freq-ho-sameport.conf
@@ -2,6 +2,7 @@
 modifiers:
   enb:
   - id: 0x19B
+num_cells: 2
 cell_list:
 - cell_id: 0x01
   pci: 0x01
diff --git a/sysmocom/scenarios/mod-enb-cells-intraenb-intrafreq-ho.conf 
b/sysmocom/scenarios/mod-enb-cells-intraenb-intrafreq-ho.conf
index f4223a5..720b75b 100644
--- a/sysmocom/scenarios/mod-enb-cells-intraenb-intrafreq-ho.conf
+++ b/sysmocom/scenarios/mod-enb-cells-intraenb-intrafreq-ho.conf
@@ -3,6 +3,7 @@
   enb:
   - id: 0x19B
 enable_measurements: true
+num_cells: 2
 cell_list:
 - cell_id: 0x01
   pci: 0x01
diff --git a/sysmocom/scenarios/mod-enb-ncells@.conf 
b/sysmocom/scenarios/mod-enb-ncells@.conf
deleted file mode 100644
index b57b94a..000
--- a/sysmocom/scenarios/mod-enb-ncells@.conf
+++ /dev/null
@@ -1,3 +0,0 @@
-modifiers:
-  enb:
-  - num_cells: ${param1}

--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/22055
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: If022d9e8d239805ee1280fb52660e68dda7484a0
Gerrit-Change-Number: 22055
Gerrit-PatchSet: 1
Gerrit-Owner: srs_andre 
Gerrit-MessageType: newchange


Change in docker-playground[master]: ttcn3-gbproxy-test: Fix pcap capture with dumpcap

2021-01-08 Thread pespin
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/docker-playground/+/22047 )

Change subject: ttcn3-gbproxy-test: Fix pcap capture with dumpcap
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/docker-playground/+/22047/1/ttcn3-gbproxy-test/jenkins.sh
File ttcn3-gbproxy-test/jenkins.sh:

https://gerrit.osmocom.org/c/docker-playground/+/22047/1/ttcn3-gbproxy-test/jenkins.sh@13
PS1, Line 13: # if we don't change permissiosn, dumpcap fails to write (despite 
starting it as root!)
permissions



--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/22047
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I11dcf9efd0b06544a82e31dec03fe76e182fd0d3
Gerrit-Change-Number: 22047
Gerrit-PatchSet: 1
Gerrit-Owner: daniel 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-CC: pespin 
Gerrit-Comment-Date: Fri, 08 Jan 2021 13:12:05 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment


Change in osmo-ttcn3-hacks[master]: gbproxy: Fix TC_bvc_reset_sig_from_sgsn

2021-01-08 Thread pespin
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22049 )

Change subject: gbproxy: Fix TC_bvc_reset_sig_from_sgsn
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22049
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I1f2c76ae9bdc0267bfca60536e321fe88530803c
Gerrit-Change-Number: 22049
Gerrit-PatchSet: 1
Gerrit-Owner: daniel 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Fri, 08 Jan 2021 13:08:57 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in osmo-ttcn3-hacks[master]: Fix suspend/resume tests

2021-01-08 Thread pespin
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22048 )

Change subject: Fix suspend/resume tests
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22048
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie0fd81edb748d3c638e42c4418ca514095c55861
Gerrit-Change-Number: 22048
Gerrit-PatchSet: 1
Gerrit-Owner: daniel 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Fri, 08 Jan 2021 12:59:36 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in osmo-bsc[master]: power_control: add increase / reduce step size recommendations

2021-01-08 Thread pespin
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/21873 )

Change subject: power_control: add increase / reduce step size recommendations
..


Patch Set 4: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21873
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I82e762c0c2b5e0dd739850ee494ab0a798e353de
Gerrit-Change-Number: 21873
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Fri, 08 Jan 2021 12:57:32 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in osmo-bsc[master]: power_control: add documentation on available configuration params

2021-01-08 Thread pespin
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/21886 )

Change subject: power_control: add documentation on available configuration 
params
..


Patch Set 3: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21886
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ib65d33f0f1dd24d39e3be581e4e072a310bc906a
Gerrit-Change-Number: 21886
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Fri, 08 Jan 2021 12:57:04 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in osmo-trx[master]: osmo-trx.spec: move ipc-driver-test into package ipc-test

2021-01-08 Thread pespin
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-trx/+/22053 )

Change subject: osmo-trx.spec: move ipc-driver-test into package ipc-test
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/22053
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Iff91e09684167247c9c7de0141451a5b9344aa0d
Gerrit-Change-Number: 22053
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Fri, 08 Jan 2021 12:49:11 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_20.04/x86_64

2021-01-08 Thread OBS Notification
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_20.04/x86_64

Package network:osmocom:nightly/simtrace2 failed to build in 
xUbuntu_20.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  201s] [COMPILING libboard/qmod/source/wwan_perst.c]
[  201s] [COMPILING libboard/qmod/source/card_pres.c]
[  201s] [COMPILING libboard/qmod/source/wwan_led.c]
[  201s] [COMPILING libboard/qmod/source/i2c.c]
[  201s] [COMPILING libboard/qmod/source/board_qmod.c]
[  201s] [COMPILING apps/dfu/main.c]
[  202s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu.c]
[  202s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_desc.c]
[  202s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_driver.c]
[  202s] Memory region Used Size  Region Size  %age Used
[  202s]  rom:   16588 B16 KB101.25%
[  202s]  ram:   11672 B48 KB 
23.75/usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: 
bin/qmod-dfu-flash.elf section `.text' will not fit in region `rom'
[  202s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: region 
`rom' overflowed by 204 bytes
[  202s] collect2: error: ld returned 1 exit status
[  202s] %
[  202s] make[2]: *** [Makefile:234: flash] Error 1
[  202s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware'
[  202s] make[1]: *** [Makefile:13: fw-qmod-dfu] Error 2
[  202s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  202s] dh_auto_build: error: make -j1 returned exit code 2
[  202s] make: *** [debian/rules:16: build] Error 25
[  202s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  202s] ### VM INTERACTION START ###
[  205s] [  192.654665] sysrq: Power Off
[  205s] [  192.663043] reboot: Power down
[  205s] ### VM INTERACTION END ###
[  205s] 
[  205s] lamb22 failed "build simtrace2_0.7.0.69.aadd.dsc" at Fri Jan  8 
10:49:19 UTC 2021.
[  205s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)


Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_20.10/x86_64

2021-01-08 Thread OBS Notification
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_20.10/x86_64

Package network:osmocom:nightly/simtrace2 failed to build in 
xUbuntu_20.10/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly simtrace2

Last lines of build log:
[  113s] [COMPILING apps/dfu/main.c]
[  113s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu.c]
[  113s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_desc.c]
[  113s] [COMPILING ./atmel_softpack_libraries/usb/device/dfu/dfu_driver.c]
[  114s] Memory region Used Size  Region Size  %age Used
[  114s]  rom:   16580 B16 KB101.20%
[  114s]  ram:   11672 B48 KB 
23.75/usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: warning: 
changing start of section .stack by 4 bytes
[  114s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: 
warning: changing start of section .stack by 4 bytes
[  114s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: 
bin/qmod-dfu-flash.elf section `.text' will not fit in region `rom'
[  114s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: 
warning: changing start of section .stack by 4 bytes
[  114s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: 
warning: changing start of section .stack by 4 bytes
[  114s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: 
warning: changing start of section .stack by 4 bytes
[  114s] /usr/lib/gcc/arm-none-eabi/9.2.1/../../../arm-none-eabi/bin/ld: region 
`rom' overflowed by 196 bytes
[  114s] collect2: error: ld returned 1 exit status
[  114s] %
[  114s] make[2]: *** [Makefile:234: flash] Error 1
[  114s] make[2]: Leaving directory '/usr/src/packages/BUILD/firmware'
[  114s] make[1]: *** [Makefile:13: fw-qmod-dfu] Error 2
[  114s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  114s] dh_auto_build: error: make -j1 returned exit code 2
[  114s] make: *** [debian/rules:16: build] Error 25
[  114s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  114s] ### VM INTERACTION START ###
[  117s] [  107.112444] sysrq: Power Off
[  117s] [  107.116936] reboot: Power down
[  117s] ### VM INTERACTION END ###
[  117s] 
[  117s] sheep85 failed "build simtrace2_0.7.0.69.aadd.dsc" at Fri Jan  8 
10:46:51 UTC 2021.
[  117s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)


Change in libosmocore[master]: Revert "pkgconfig: link to mnl if available"

2021-01-08 Thread laforge
laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/22059 )

Change subject: Revert "pkgconfig: link to mnl if available"
..

Revert "pkgconfig: link to mnl if available"

This reverts commit 2253224b33ae9f54f14dc54f0098c4d5ee27fdbf.

Reason for revert: Causes massive build failure for osmo-pcu and osmo-sgsn on 
all the distributions/architectures we build for

Change-Id: I6dbe4507701bee013b29dcc26f32c4e1a3c23613
Closes: OS#4936
---
M libosmogb.pc.in
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/libosmogb.pc.in b/libosmogb.pc.in
index 4eebe42..a163cc4 100644
--- a/libosmogb.pc.in
+++ b/libosmogb.pc.in
@@ -6,6 +6,6 @@
 Name: Osmocom GPRS Gb Library
 Description: Osmocom GPRS Gb Interface (NS/BSSGP) Library
 Version: @VERSION@
-Libs: -L${libdir} @TALLOC_LIBS@ -losmogb -losmovty -losmocore @LIBMNL_LIBS@
+Libs: -L${libdir} @TALLOC_LIBS@ -losmogb -losmovty -losmocore
 Cflags: -I${includedir}/ -fno-strict-aliasing


--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22059
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I6dbe4507701bee013b29dcc26f32c4e1a3c23613
Gerrit-Change-Number: 22059
Gerrit-PatchSet: 2
Gerrit-Owner: laforge 
Gerrit-Reviewer: Hoernchen 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged


Change in libosmocore[master]: Revert "pkgconfig: link to mnl if available"

2021-01-08 Thread laforge
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/22059 )

Change subject: Revert "pkgconfig: link to mnl if available"
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22059
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I6dbe4507701bee013b29dcc26f32c4e1a3c23613
Gerrit-Change-Number: 22059
Gerrit-PatchSet: 1
Gerrit-Owner: laforge 
Gerrit-Reviewer: Hoernchen 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Fri, 08 Jan 2021 10:14:00 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in libosmocore[master]: Revert "pkgconfig: link to mnl if available"

2021-01-08 Thread laforge
Hello Jenkins Builder, Hoernchen, fixeria, pespin,

I'd like you to do a code review. Please visit

https://gerrit.osmocom.org/c/libosmocore/+/22059

to review the following change.


Change subject: Revert "pkgconfig: link to mnl if available"
..

Revert "pkgconfig: link to mnl if available"

This reverts commit 2253224b33ae9f54f14dc54f0098c4d5ee27fdbf.

Reason for revert: Causes massive build failure for osmo-pcu and osmo-sgsn on 
all the distributions/architectures we build for

Change-Id: I6dbe4507701bee013b29dcc26f32c4e1a3c23613
Closes: OS#4936
---
M libosmogb.pc.in
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/59/22059/1

diff --git a/libosmogb.pc.in b/libosmogb.pc.in
index 4eebe42..a163cc4 100644
--- a/libosmogb.pc.in
+++ b/libosmogb.pc.in
@@ -6,6 +6,6 @@
 Name: Osmocom GPRS Gb Library
 Description: Osmocom GPRS Gb Interface (NS/BSSGP) Library
 Version: @VERSION@
-Libs: -L${libdir} @TALLOC_LIBS@ -losmogb -losmovty -losmocore @LIBMNL_LIBS@
+Libs: -L${libdir} @TALLOC_LIBS@ -losmogb -losmovty -losmocore
 Cflags: -I${includedir}/ -fno-strict-aliasing


--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22059
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I6dbe4507701bee013b29dcc26f32c4e1a3c23613
Gerrit-Change-Number: 22059
Gerrit-PatchSet: 1
Gerrit-Owner: laforge 
Gerrit-Reviewer: Hoernchen 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: newchange


Change in libosmocore[master]: pkgconfig: link to mnl if available

2021-01-08 Thread laforge
laforge has created a revert of this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/22026 )

Change subject: pkgconfig: link to mnl if available
..
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22026
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib4df95d5c922f8edfa33e68645652fd30d321ff8
Gerrit-Change-Number: 22026
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen 
Gerrit-Reviewer: Hoernchen 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-CC: laforge 
Gerrit-MessageType: revert


Change in libosmocore[master]: pkgconfig: link to mnl if available

2021-01-08 Thread laforge
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/22026 )

Change subject: pkgconfig: link to mnl if available
..


Patch Set 2:

See https://osmocom.org/issues/4936


--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22026
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib4df95d5c922f8edfa33e68645652fd30d321ff8
Gerrit-Change-Number: 22026
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen 
Gerrit-Reviewer: Hoernchen 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-CC: laforge 
Gerrit-Comment-Date: Fri, 08 Jan 2021 10:07:32 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment


Build failure of network:osmocom:nightly/osmo-pcu in Debian_10/armv7l

2021-01-08 Thread OBS Notification
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/Debian_10/armv7l

Package network:osmocom:nightly/osmo-pcu failed to build in Debian_10/armv7l

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-pcu

Last lines of build log:
[  750s] /bin/bash ../libtool  --tag=CXX   --mode=compile g++ 
-DPACKAGE_NAME=\"osmo-pcu\" -DPACKAGE_TARNAME=\"osmo-pcu\" 
-DPACKAGE_VERSION=\"0.8.0.301-480c\" -DPACKAGE_STRING=\"osmo-pcu\ 
0.8.0.301-480c\" -DPACKAGE_BUGREPORT=\"osmocom-net-g...@lists.osmocom.org\" 
-DPACKAGE_URL=\"\" -DPACKAGE=\"osmo-pcu\" -DVERSION=\"0.8.0.301-480c\" 
-DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 
-DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 
-DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" 
-DSTDC_HEADERS=1 -I.  -I../include -Wall -pthread -I/usr/include/ 
-fno-strict-aliasing -I/usr/include/ -I/usr/include/   -Wdate-time 
-D_FORTIFY_SOURCE=2 -Wall -ldl -pthread -g -O2 
-fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat 
-Werror=format-security -std=gnu++03 -c -o egprs_rlc_compression.lo 
egprs_rlc_compression.cpp
[  751s] libtool: compile:  g++ -DPACKAGE_NAME=\"osmo-pcu\" 
-DPACKAGE_TARNAME=\"osmo-pcu\" -DPACKAGE_VERSION=\"0.8.0.301-480c\" 
"-DPACKAGE_STRING=\"osmo-pcu 0.8.0.301-480c\"" 
-DPACKAGE_BUGREPORT=\"osmocom-net-g...@lists.osmocom.org\" -DPACKAGE_URL=\"\" 
-DPACKAGE=\"osmo-pcu\" -DVERSION=\"0.8.0.301-480c\" -DSTDC_HEADERS=1 
-DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 
-DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 
-DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DSTDC_HEADERS=1 -I. 
-I../include -Wall -pthread -I/usr/include/ -fno-strict-aliasing 
-I/usr/include/ -I/usr/include/ -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -ldl 
-pthread -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. 
-fstack-protector-strong -Wformat -Werror=format-security -std=gnu++03 -c 
egprs_rlc_compression.cpp  -fPIC -DPIC -o .libs/egprs_rlc_compression.o
[  752s] libtool: compile:  g++ -DPACKAGE_NAME=\"osmo-pcu\" 
-DPACKAGE_TARNAME=\"osmo-pcu\" -DPACKAGE_VERSION=\"0.8.0.301-480c\" 
"-DPACKAGE_STRING=\"osmo-pcu 0.8.0.301-480c\"" 
-DPACKAGE_BUGREPORT=\"osmocom-net-g...@lists.osmocom.org\" -DPACKAGE_URL=\"\" 
-DPACKAGE=\"osmo-pcu\" -DVERSION=\"0.8.0.301-480c\" -DSTDC_HEADERS=1 
-DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 
-DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 
-DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DSTDC_HEADERS=1 -I. 
-I../include -Wall -pthread -I/usr/include/ -fno-strict-aliasing 
-I/usr/include/ -I/usr/include/ -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -ldl 
-pthread -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. 
-fstack-protector-strong -Wformat -Werror=format-security -std=gnu++03 -c 
egprs_rlc_compression.cpp -o egprs_rlc_compression.o >/dev/null 2>&1
[  752s] /bin/bash ../libtool  --tag=CXX   --mode=link g++ -Wall -ldl -pthread 
-g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong 
-Wformat -Werror=format-security -std=gnu++03 -lrt -Wl,-z,relro -Wl,-z,now -o 
libgprs.la  gprs_debug.lo csn1.lo gsm_rlcmac.lo gprs_bssgp_pcu.lo 
gprs_rlcmac.lo gprs_rlcmac_sched.lo gprs_rlcmac_meas.lo gprs_rlcmac_ts_alloc.lo 
gprs_ms.lo gprs_ms_storage.lo gsm_timer.lo pcu_l1_if.lo pcu_vty.lo 
pcu_vty_functions.lo mslot_class.lo tbf.lo tbf_ul.lo tbf_dl.lo bts.lo pdch.lo 
poll_controller.lo encoding.lo sba.lo decoding.lo llc.lo rlc.lo osmobts_sock.lo 
gprs_codel.lo coding_scheme.lo egprs_rlc_compression.lo gprs_rlcmac_sched.lo  
[  753s] copying selected object files to avoid basename conflicts...
[  753s] libtool: link: ln .libs/gprs_rlcmac_sched.o 
.libs/libgprs.lax/lt1-gprs_rlcmac_sched.o || cp .libs/gprs_rlcmac_sched.o 
.libs/libgprs.lax/lt1-gprs_rlcmac_sched.o
[  753s] libtool: link: ar cru .libs/libgprs.a .libs/gprs_debug.o .libs/csn1.o 
.libs/gsm_rlcmac.o .libs/gprs_bssgp_pcu.o .libs/gprs_rlcmac.o 
.libs/gprs_rlcmac_sched.o .libs/gprs_rlcmac_meas.o .libs/gprs_rlcmac_ts_alloc.o 
.libs/gprs_ms.o .libs/gprs_ms_storage.o .libs/gsm_timer.o .libs/pcu_l1_if.o 
.libs/pcu_vty.o .libs/pcu_vty_functions.o .libs/mslot_class.o .libs/tbf.o 
.libs/tbf_ul.o .libs/tbf_dl.o .libs/bts.o .libs/pdch.o .libs/poll_controller.o 
.libs/encoding.o .libs/sba.o .libs/decoding.o .libs/llc.o .libs/rlc.o 
.libs/osmobts_sock.o .libs/gprs_codel.o .libs/coding_scheme.o 
.libs/egprs_rlc_compression.o .libs/libgprs.lax/lt1-gprs_rlcmac_sched.o
[  753s] ar: `u' modifier ignored since `D' is the default (see `U')
[  753s] libtool: link: ranlib .libs/libgprs.a
[  753s] libtool: link: rm -fr .libs/libgprs.lax
[  753s] libtool: link: ( cd ".libs" && rm -f "libgprs.la" && ln -s 
"../libgprs.la" "libgprs.la" )
[  753s] /bin/bash ../libtool  --tag=CXX   --mode=link g++ -Wall -ldl -pthread 
-g -O2 -fdeb

Build failure of network:osmocom:nightly/osmo-pcu in Debian_9.0/armv7l

2021-01-08 Thread OBS Notification
Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/Debian_9.0/armv7l

Package network:osmocom:nightly/osmo-pcu failed to build in Debian_9.0/armv7l

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-pcu

Last lines of build log:
[  589s] copying selected object files to avoid basename conflicts...
[  589s] libtool: link: ln .libs/gprs_rlcmac_sched.o 
.libs/libgprs.lax/lt1-gprs_rlcmac_sched.o || cp .libs/gprs_rlcmac_sched.o 
.libs/libgprs.lax/lt1-gprs_rlcmac_sched.o
[  589s] libtool: link: ar cru .libs/libgprs.a .libs/gprs_debug.o .libs/csn1.o 
.libs/gsm_rlcmac.o .libs/gprs_bssgp_pcu.o .libs/gprs_rlcmac.o 
.libs/gprs_rlcmac_sched.o .libs/gprs_rlcmac_meas.o .libs/gprs_rlcmac_ts_alloc.o 
.libs/gprs_ms.o .libs/gprs_ms_storage.o .libs/gsm_timer.o .libs/pcu_l1_if.o 
.libs/pcu_vty.o .libs/pcu_vty_functions.o .libs/mslot_class.o .libs/tbf.o 
.libs/tbf_ul.o .libs/tbf_dl.o .libs/bts.o .libs/pdch.o .libs/poll_controller.o 
.libs/encoding.o .libs/sba.o .libs/decoding.o .libs/llc.o .libs/rlc.o 
.libs/osmobts_sock.o .libs/gprs_codel.o .libs/coding_scheme.o 
.libs/egprs_rlc_compression.o .libs/libgprs.lax/lt1-gprs_rlcmac_sched.o
[  589s] ar: `u' modifier ignored since `D' is the default (see `U')
[  589s] libtool: link: ranlib .libs/libgprs.a
[  589s] libtool: link: rm -fr .libs/libgprs.lax
[  589s] libtool: link: ( cd ".libs" && rm -f "libgprs.la" && ln -s 
"../libgprs.la" "libgprs.la" )
[  589s] g++ -DPACKAGE_NAME=\"osmo-pcu\" -DPACKAGE_TARNAME=\"osmo-pcu\" 
-DPACKAGE_VERSION=\"0.8.0.301-480c\" -DPACKAGE_STRING=\"osmo-pcu\ 
0.8.0.301-480c\" -DPACKAGE_BUGREPORT=\"osmocom-net-g...@lists.osmocom.org\" 
-DPACKAGE_URL=\"\" -DPACKAGE=\"osmo-pcu\" -DVERSION=\"0.8.0.301-480c\" 
-DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 
-DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 
-DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" 
-DSTDC_HEADERS=1 -I.  -I../include -Wall -pthread -I/usr/include/ 
-fno-strict-aliasing -I/usr/include/ -I/usr/include/   -Wdate-time 
-D_FORTIFY_SOURCE=2 -Wall -ldl -pthread -g -O2 
-fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat 
-Werror=format-security -std=gnu++03 -c -o pcu_main.o pcu_main.cpp
[  590s] /bin/bash ../libtool  --tag=CXX   --mode=link g++ -Wall -ldl -pthread 
-g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong 
-Wformat -Werror=format-security -std=gnu++03 -lrt -Wl,-z,relro -Wl,-z,now -o 
osmo-pcu pcu_main.olibgprs.la -ltalloc -losmogb -losmovty -losmocore -lmnl 
-ltalloc -losmocore -ltalloc -losmogsm -losmocore  
[  591s] libtool: link: g++ -Wall -pthread -g -O2 
-fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat 
-Werror=format-security -std=gnu++03 -Wl,-z -Wl,relro -Wl,-z -Wl,now -o 
osmo-pcu pcu_main.o  ./.libs/libgprs.a -ldl -lrt 
/usr/lib/arm-linux-gnueabihf/libosmogb.so 
/usr/lib/arm-linux-gnueabihf/libosmovty.so -lmnl -ltalloc 
/usr/lib/arm-linux-gnueabihf/libosmogsm.so 
/usr/lib/arm-linux-gnueabihf/libosmocore.so -pthread
[  591s] /usr/bin/ld: cannot find -lmnl
[  591s] collect2: error: ld returned 1 exit status
[  591s] Makefile:696: recipe for target 'osmo-pcu' failed
[  591s] make[2]: *** [osmo-pcu] Error 1
[  591s] make[2]: Leaving directory '/usr/src/packages/BUILD/src'
[  591s] Makefile:417: recipe for target 'all-recursive' failed
[  591s] make[1]: *** [all-recursive] Error 1
[  591s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  591s] dh_auto_build: make -j1 returned exit code 2
[  591s] debian/rules:12: recipe for target 'build' failed
[  591s] make: *** [build] Error 2
[  591s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  591s] ### VM INTERACTION START ###
[  594s] [  554.125995] sysrq: SysRq : Power Off
[  594s] [  554.128020] reboot: Power down
[  594s] ### VM INTERACTION END ###
[  594s] 
[  594s] armbuild02 failed "build osmo-pcu_0.8.0.301.480c.dsc" at Fri Jan  8 
09:42:31 UTC 2021.
[  594s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)


Change in osmo-trx[master]: osmo-trx.spec: move ipc-driver-test into package ipc-test

2021-01-08 Thread lynxis lazus
lynxis lazus has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-trx/+/22053 )

Change subject: osmo-trx.spec: move ipc-driver-test into package ipc-test
..


Patch Set 1:

Tested with the repo-install script.


--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/22053
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Iff91e09684167247c9c7de0141451a5b9344aa0d
Gerrit-Change-Number: 22053
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Fri, 08 Jan 2021 08:35:31 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment


Change in osmo-trx[master]: osmo-trx.spec: move ipc-driver-test into package ipc-test

2021-01-08 Thread lynxis lazus
lynxis lazus has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-trx/+/22053 )


Change subject: osmo-trx.spec: move ipc-driver-test into package ipc-test
..

osmo-trx.spec: move ipc-driver-test into package ipc-test

Allow to drop the uhd runtime dependency of osmo-trx-ipc.
uhd is only required for the driver-test utility.

Related: SYS#5266
Change-Id: Iff91e09684167247c9c7de0141451a5b9344aa0d
---
M contrib/osmo-trx.spec.in
1 file changed, 13 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/53/22053/1

diff --git a/contrib/osmo-trx.spec.in b/contrib/osmo-trx.spec.in
index ace7212..8f4bb48 100644
--- a/contrib/osmo-trx.spec.in
+++ b/contrib/osmo-trx.spec.in
@@ -149,6 +149,16 @@
 between different telecommunication associations for developing new
 generations of mobile phone networks. (post-2G/GSM)

+%package ipc-test
+Summary:SDR transceiver that implements Layer 1 of a GSM BTS (IPC) 
driver test utility
+Group:  Productivity/Telephony/Servers
+
+%description ipc-test
+OsmoTRX is a software-defined radio transceiver that implements the Layer 1
+physical layer of a BTS comprising the following 3GPP specifications:
+
+This package include the test tools for osmo-trx-ipc
+
 %prep
 %setup -q

@@ -234,9 +244,11 @@

 %files ipc
 %{_bindir}/osmo-trx-ipc
-%{_bindir}/ipc-driver-test
 %dir %{_sysconfdir}/osmocom
 %config(noreplace) %{_sysconfdir}/osmocom/osmo-trx-ipc.cfg
 %{_unitdir}/osmo-trx-ipc.service

+%files ipc-test
+%{_bindir}/ipc-driver-test
+
 %changelog

--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/22053
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Iff91e09684167247c9c7de0141451a5b9344aa0d
Gerrit-Change-Number: 22053
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-MessageType: newchange


Change in osmo-ci[master]: scripts: repo-install-test: fix missing version of centos8 example

2021-01-08 Thread lynxis lazus
lynxis lazus has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-ci/+/22052 )


Change subject: scripts: repo-install-test: fix missing version of centos8 
example
..

scripts: repo-install-test: fix missing version of centos8 example

Change-Id: I5eee27a9ba1cca43e056ef0ac4ae4bbb4cd827d7
---
M scripts/repo-install-test.sh
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/52/22052/1

diff --git a/scripts/repo-install-test.sh b/scripts/repo-install-test.sh
index ac8242d..0c08e15 100755
--- a/scripts/repo-install-test.sh
+++ b/scripts/repo-install-test.sh
@@ -8,7 +8,7 @@
 # Show usage
 if [ "$#" -ne 1 ]; then
echo "usage: repo-install-test.sh DISTRO"
-   echo "DISTRO: debian or centos"
+   echo "DISTRO: debian or centos8"
exit 1
 fi


--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/22052
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I5eee27a9ba1cca43e056ef0ac4ae4bbb4cd827d7
Gerrit-Change-Number: 22052
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-MessageType: newchange