Change in pysim[master]: contrib: Add sim-rest-{server,client}.py

[laforge]

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/pysim/+/24342

to look at the new patch set (#3).

Change subject: contrib: Add sim-rest-{server,client}.py
..

contrib: Add sim-rest-{server,client}.py

sim-rest-server.py can be used to provide a RESTful API to allow remote
clients to perform the authentication command against a SIM card in a
PC/SC reader.

sim-rest-client.py is an example client against sim-rest-server.py
which can be used to test the functionality of sim-rest-server.py.

Change-Id: I738ca3109ab038d4f5595cc1dab6a49087df5886
---
A contrib/sim-rest-client.py
A contrib/sim-rest-server.py
2 files changed, 247 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/42/24342/3
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/24342
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I738ca3109ab038d4f5595cc1dab6a49087df5886
Gerrit-Change-Number: 24342
Gerrit-PatchSet: 3
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-CC: fixeria 
Gerrit-MessageType: newpatchset

Change in pysim[master]: contrib: Add sim-rest-{server,client}.py

[laforge]

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/pysim/+/24342 )

Change subject: contrib: Add sim-rest-{server,client}.py
..


Patch Set 3: Code-Review+2

(4 comments)

https://gerrit.osmocom.org/c/pysim/+/24342/2/contrib/sim-rest-client.py
File contrib/sim-rest-client.py:

https://gerrit.osmocom.org/c/pysim/+/24342/2/contrib/sim-rest-client.py@39
PS2, Line 39: x2, x3 = struct.unpack('>IH', x)
> I guess you could do this without using struct at all: […]
tested, changed in next version.


https://gerrit.osmocom.org/c/pysim/+/24342/2/contrib/sim-rest-client.py@46
PS2, Line 46: return struct.pack('>IH', x2, x3)
> Also here: […]
tested, changed in next version.


https://gerrit.osmocom.org/c/pysim/+/24342/2/contrib/sim-rest-client.py@48
PS2, Line 48: dict
> If all values in this dict() are bytes, then: […]
Ack


https://gerrit.osmocom.org/c/pysim/+/24342/2/contrib/sim-rest-client.py@61
PS2, Line 61: def milenage_auts(opc:bytes, k:bytes, rand:bytes, auts:bytes):
> I would raise a RuntimeError directly from here, or alternatively: […]
Ack



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/24342
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I738ca3109ab038d4f5595cc1dab6a49087df5886
Gerrit-Change-Number: 24342
Gerrit-PatchSet: 3
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-CC: fixeria 
Gerrit-Comment-Date: Tue, 25 May 2021 07:44:58 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria 
Gerrit-MessageType: comment

Change in pysim[master]: add unit tests for BER-TLV encoder/decoder functions

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/24346 
)

Change subject: add unit tests for BER-TLV encoder/decoder functions
..

add unit tests for BER-TLV encoder/decoder functions

... and while at it resolve a bug in bertlv_parse_len()
discovered by those new tests.

Change-Id: I9f14dafab4f712c29224c4eb25cacab7885e2b68
---
M pySim/utils.py
M tests/test_utils.py
2 files changed, 25 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved



diff --git a/pySim/utils.py b/pySim/utils.py
index ff55642..1191983 100644
--- a/pySim/utils.py
+++ b/pySim/utils.py
@@ -132,7 +132,7 @@
for i in range(1, 1+num_len_oct):
length <<= 8
length |= binary[i]
-   return (length, binary[num_len_oct:])
+   return (length, binary[1+num_len_oct:])

 def bertlv_encode_len(length:int) -> bytes:
"""Encode a single Length value according to ITU-T X.690 8.1.3;
diff --git a/tests/test_utils.py b/tests/test_utils.py
index 0fb502c..24f0fc9 100755
--- a/tests/test_utils.py
+++ b/tests/test_utils.py
@@ -152,5 +152,29 @@
msisdn_decoded = 
utils.dec_msisdn("0bb121436587092143658709")
self.assertEqual(msisdn_decoded, (1, 3, "12345678901234567890"))

+class TestBerTlv(unittest.TestCase):
+def test_BerTlvTagDec(self):
+res = utils.bertlv_parse_tag(b'\x01')
+self.assertEqual(res, ({'tag':1, 'constructed':False, 'class': 0}, 
b''))
+res = utils.bertlv_parse_tag(b'\x21')
+self.assertEqual(res, ({'tag':1, 'constructed':True, 'class': 0}, b''))
+res = utils.bertlv_parse_tag(b'\x81\x23')
+self.assertEqual(res, ({'tag':1, 'constructed':False, 'class': 2}, 
b'\x23'))
+res = utils.bertlv_parse_tag(b'\x1f\x8f\x00\x23')
+self.assertEqual(res, ({'tag':0xf<<7, 'constructed':False, 'class': 
0}, b'\x23'))
+
+def test_BerTlvLenDec(self):
+self.assertEqual(utils.bertlv_encode_len(1), b'\x01')
+self.assertEqual(utils.bertlv_encode_len(127), b'\x7f')
+self.assertEqual(utils.bertlv_encode_len(128), b'\x81\x80')
+self.assertEqual(utils.bertlv_encode_len(0x123456), 
b'\x83\x12\x34\x56')
+
+def test_BerTlvLenEnc(self):
+self.assertEqual(utils.bertlv_parse_len(b'\x01\x23'), (1, b'\x23'))
+self.assertEqual(utils.bertlv_parse_len(b'\x7f'), (127, b''))
+self.assertEqual(utils.bertlv_parse_len(b'\x81\x80'), (128, b''))
+self.assertEqual(utils.bertlv_parse_len(b'\x83\x12\x34\x56\x78'), 
(0x123456, b'\x78'))
+
+
 if __name__ == "__main__":
unittest.main()

--
To view, visit https://gerrit.osmocom.org/c/pysim/+/24346
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I9f14dafab4f712c29224c4eb25cacab7885e2b68
Gerrit-Change-Number: 24346
Gerrit-PatchSet: 2
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-MessageType: merged

Change in pysim[master]: contrib: Add sim-rest-{server,client}.py

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/24342 
)

Change subject: contrib: Add sim-rest-{server,client}.py
..

contrib: Add sim-rest-{server,client}.py

sim-rest-server.py can be used to provide a RESTful API to allow remote
clients to perform the authentication command against a SIM card in a
PC/SC reader.

sim-rest-client.py is an example client against sim-rest-server.py
which can be used to test the functionality of sim-rest-server.py.

Change-Id: I738ca3109ab038d4f5595cc1dab6a49087df5886
---
A contrib/sim-rest-client.py
A contrib/sim-rest-server.py
2 files changed, 247 insertions(+), 0 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/contrib/sim-rest-client.py b/contrib/sim-rest-client.py
new file mode 100755
index 000..8f74adc
--- /dev/null
+++ b/contrib/sim-rest-client.py
@@ -0,0 +1,155 @@
+#!/usr/bin/env python3
+#
+# sim-rest-client.py: client program to test the sim-rest-server.py
+#
+# this will generate authentication tuples just like a HLR / HSS
+# and will then send the related challenge to the REST interface
+# of sim-rest-server.py
+#
+# sim-rest-server.py will then contact the SIM card to perform the
+# authentication (just like a 3GPP RAN), and return the results via
+# the REST to sim-rest-client.py.
+#
+# (C) 2021 by Harald Welte 
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see .
+
+from typing import Optional, Dict
+
+import sys
+import argparse
+import secrets
+import requests
+
+from CryptoMobile.Milenage import Milenage
+from CryptoMobile.utils import xor_buf
+
+def unpack48(x:bytes) -> int:
+"""Decode a big-endian 48bit number from binary to integer."""
+return int.from_bytes(x, byteorder='big')
+
+def pack48(x:int) -> bytes:
+"""Encode a big-endian 48bit number from integer to binary."""
+return x.to_bytes(48 // 8, byteorder='big')
+
+def milenage_generate(opc:bytes, amf:bytes, k:bytes, sqn:bytes, rand:bytes) -> 
Dict[str, bytes]:
+"""Generate an MILENAGE Authentication Tuple."""
+m = Milenage(None)
+m.set_opc(opc)
+mac_a = m.f1(k, rand, sqn, amf)
+res, ck, ik, ak = m.f2345(k, rand)
+
+# AUTN = (SQN ^ AK) || AMF || MAC
+sqn_ak = xor_buf(sqn, ak)
+autn = b''.join([sqn_ak, amf, mac_a])
+
+return {'res': res, 'ck': ck, 'ik': ik, 'autn': autn}
+
+def milenage_auts(opc:bytes, k:bytes, rand:bytes, auts:bytes) -> 
Optional[bytes]:
+"""Validate AUTS. If successful, returns SQN_MS"""
+amf = b'\x00\x00' # TS 33.102 Section 6.3.3
+m = Milenage(None)
+m.set_opc(opc)
+ak = m.f5star(k, rand)
+
+sqn_ak = auts[:6]
+sqn = xor_buf(sqn_ak, ak[:6])
+
+mac_s = m.f1star(k, rand, sqn, amf)
+if mac_s == auts[6:14]:
+return sqn
+else:
+return False
+
+
+def build_url(suffix:str) -> str:
+"""Build an URL from global server_host, server_port, BASE_PATH and 
suffix."""
+BASE_PATH= "/sim-auth-api/v1"
+return "http://%s:%u%s%s"; % (server_host, server_port, BASE_PATH, suffix)
+
+
+def rest_post(suffix:str, js:Optional[dict] = None):
+"""Perform a RESTful POST."""
+url = build_url(suffix)
+if verbose:
+print("POST %s (%s)" % (url, str(js)))
+resp = requests.post(url, json=js)
+if verbose:
+print("-> %s" % (resp))
+if not resp.ok:
+print("POST failed")
+return resp
+
+
+
+def main(argv):
+global server_port, server_host, verbose
+
+parser = argparse.ArgumentParser()
+parser.add_argument("-H", "--host", help="Host to connect to", 
default="localhost")
+parser.add_argument("-p", "--port", help="TCP port to connect to", 
default=8000)
+parser.add_argument("-v", "--verbose", help="increase output verbosity", 
action='count', default=0)
+parser.add_argument("-n", "--slot-nr", help="SIM slot number", type=int, 
default=0)
+parser.add_argument("-c", "--count", help="Auth count", type=int, 
default=10)
+
+parser.add_argument("-k", "--key", help="Secret key K (hex)", type=str, 
required=True)
+parser.add_argument("-o", "--opc", help="Secret OPc (hex)", type=str, 
required=True)
+parser.add_argument("-a", "--amf", help="AMF Field (hex)", type=str, 
default="")
+parser.add_argument("-s", "--sqn", help="SQN Field (hex)", type=str, 
default="")
+
+ 

Change in pysim[master]: Introduce unit test for bertlv_parse_one()

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/24348 
)

Change subject: Introduce unit test for bertlv_parse_one()
..

Introduce unit test for bertlv_parse_one()

Change-Id: I3adbe22afd4b6503a7454de39b7663e9ede8995f
---
M tests/test_utils.py
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved



diff --git a/tests/test_utils.py b/tests/test_utils.py
index 24f0fc9..17a9300 100755
--- a/tests/test_utils.py
+++ b/tests/test_utils.py
@@ -175,6 +175,10 @@
 self.assertEqual(utils.bertlv_parse_len(b'\x81\x80'), (128, b''))
 self.assertEqual(utils.bertlv_parse_len(b'\x83\x12\x34\x56\x78'), 
(0x123456, b'\x78'))

+def test_BerTlvParseOne(self):
+res = utils.bertlv_parse_one(b'\x81\x01\x01');
+self.assertEqual(res, ({'tag':1, 'constructed':False, 'class':2}, 1, 
b'\x01', b''))
+

 if __name__ == "__main__":
unittest.main()

--
To view, visit https://gerrit.osmocom.org/c/pysim/+/24348
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I3adbe22afd4b6503a7454de39b7663e9ede8995f
Gerrit-Change-Number: 24348
Gerrit-PatchSet: 2
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-MessageType: merged

Change in pysim[master]: bertlv_parse_one: Also return remainder after end of TLV

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/24347 
)

Change subject: bertlv_parse_one: Also return remainder after end of TLV
..

bertlv_parse_one: Also return remainder after end of TLV

Change-Id: I10ebd87f72ee934561118b768108e5dc76277660
---
M pySim-shell.py
M pySim/filesystem.py
M pySim/utils.py
3 files changed, 6 insertions(+), 4 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved



diff --git a/pySim-shell.py b/pySim-shell.py
index bbfe7e9..0069661 100755
--- a/pySim-shell.py
+++ b/pySim-shell.py
@@ -265,7 +265,7 @@
tags = self._cmd.rs.retrieve_tags()
for t in tags:
result = self._cmd.rs.retrieve_data(t)
-   (tag, l, val) = 
bertlv_parse_one(h2b(result[0]))
+   (tag, l, val, remainer) = 
bertlv_parse_one(h2b(result[0]))
self._cmd.poutput("set_data 0x%02x %s" 
% (t, b2h(val)))
else:
raise RuntimeError('Unsupported structure "%s" 
of file "%s"' % (structure, filename))
diff --git a/pySim/filesystem.py b/pySim/filesystem.py
index 780da26..8cdb23e 100644
--- a/pySim/filesystem.py
+++ b/pySim/filesystem.py
@@ -1260,7 +1260,7 @@
 if not isinstance(self.selected_file, BerTlvEF):
 raise TypeError("Only works with BER-TLV EF")
 data, sw = self.card._scc.retrieve_data(self.selected_file.fid, 0x5c)
-tag, length, value = bertlv_parse_one(h2b(data))
+tag, length, value, remainder = bertlv_parse_one(h2b(data))
 return list(value)

 def set_data(self, tag:int, data_hex:str):
diff --git a/pySim/utils.py b/pySim/utils.py
index 1191983..3d96580 100644
--- a/pySim/utils.py
+++ b/pySim/utils.py
@@ -155,7 +155,7 @@
else:
raise ValueError("Length > 32bits not supported")

-def bertlv_parse_one(binary:bytes) -> (dict, int, bytes):
+def bertlv_parse_one(binary:bytes) -> (dict, int, bytes, bytes):
"""Parse a single TLV IE at the start of the given binary data.
Args:
binary : binary input data of BER-TLV length field
@@ -164,7 +164,9 @@
"""
(tagdict, remainder) = bertlv_parse_tag(binary)
(length, remainder) = bertlv_parse_len(remainder)
-   return (tagdict, length, remainder)
+   value = remainder[:length]
+   remainder = remainder[length:]
+   return (tagdict, length, value, remainder)




--
To view, visit https://gerrit.osmocom.org/c/pysim/+/24347
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I10ebd87f72ee934561118b768108e5dc76277660
Gerrit-Change-Number: 24347
Gerrit-PatchSet: 2
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-MessageType: merged

Build failure of network:osmocom:nightly/osmo-cbc in Debian_Unstable/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-cbc/Debian_Unstable/x86_64

Package network:osmocom:nightly/osmo-cbc failed to build in 
Debian_Unstable/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-cbc

Last lines of build log:
[   70s] [325/510] installing libosmocoding0-1.5.1.122.155968.202105250026
[   70s] Processing triggers for libc-bin (2.31-12) ...
[   70s] [326/510] installing opensp-1.5.2-13+b2
[   70s] Processing triggers for sgml-base (1.30) ...
[   70s] [327/510] installing libosmoctrl0-1.5.1.122.155968.202105250026
[   70s] Processing triggers for libc-bin (2.31-12) ...
[   70s] [328/510] installing libosmogb12-1.5.1.122.155968.202105250026
[   71s] Processing triggers for libc-bin (2.31-12) ...
[   71s] [329/510] installing libosmonetif8-1.1.0.202105250026
[   71s] Processing triggers for libc-bin (2.31-12) ...
[   71s] [330/510] installing libosmosim2-1.5.1.122.155968.202105250026
[   71s] Processing triggers for libc-bin (2.31-12) ...
[   71s] [331/510] installing openjade-1.4devel1-22
[   71s] Processing triggers for sgml-base (1.30) ...
[   71s] [332/510] installing libatkmm-1.6-1v5-2.28.0-3
[   71s] Processing triggers for libc-bin (2.31-12) ...
[   71s] [333/510] installing libgdk-pixbuf-2.0-0-2.42.2+dfsg-1
[   71s] Processing triggers for libc-bin (2.31-12) ...
[   71s] [334/510] installing gcc-10-10.2.1-6
[   73s] [335/510] installing docbook5-xml-5.0-3
[   73s] Processing triggers for sgml-base (1.30) ...
[   73s] [336/510] installing tzdata-2021a-1
[28874s] qemu-kvm: terminating on signal 15 from pid 30058 ()


Job seems to be stuck here, killed. (after 28800 seconds of inactivity)
[28874s] ### VM INTERACTION END ###
[28874s] No buildstatus set, either the base system is broken 
(kernel/initrd/udev/glibc/bash/perl)
[28874s] or the build host has a kernel or hardware problem...

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)

Change in osmo-bsc[master]: ctrl: Avoid fclose() on NULL pointer

[pespin]

pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/24391 )


Change subject: ctrl: Avoid fclose() on NULL pointer
..

ctrl: Avoid fclose() on NULL pointer

Fixes: 25ff634b5eb06bc1411125dd01efae246e976c4a
Related: Coverity CID#236128
Change-Id: Ib23614c77ec039dd0812196fa4e5d1c3f8408087
---
M src/osmo-bsc/bsc_ctrl_commands.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/91/24391/1

diff --git a/src/osmo-bsc/bsc_ctrl_commands.c b/src/osmo-bsc/bsc_ctrl_commands.c
index 9038404..2d37b5d 100644
--- a/src/osmo-bsc/bsc_ctrl_commands.c
+++ b/src/osmo-bsc/bsc_ctrl_commands.c
@@ -62,7 +62,7 @@
LOGP(DCTRL, LOGL_NOTICE, "Applying VTY snippet from %s: fopen() 
failed: %d\n",
 cmd->value, errno);
cmd->reply = "NoFile";
-   goto close_ret;
+   return cmd_ret;
}

rc = vty_read_config_filep(cfile, NULL);

--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24391
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ib23614c77ec039dd0812196fa4e5d1c3f8408087
Gerrit-Change-Number: 24391
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange

Change in osmo-bts[master]: [VAMOS] rsl_rx_mode_modif(): handle Channel Identification IE

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/24339 )

Change subject: [VAMOS] rsl_rx_mode_modif(): handle Channel Identification IE
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24339
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I07f95e69e6230a1daca62cc0a7c64954f191fa8a
Gerrit-Change-Number: 24339
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 25 May 2021 09:56:31 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bts[master]: [VAMOS] rsl: call bts_supports_cm() from rsl_handle_chan_mod_ie()

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/24340 )

Change subject: [VAMOS] rsl: call bts_supports_cm() from 
rsl_handle_chan_mod_ie()
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24340
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I31a444592436705ec9d6ddade3cbfa7f8cb4bb91
Gerrit-Change-Number: 24340
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 25 May 2021 10:00:31 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bts[master]: [VAMOS] bts_supports_cm(): handle RSL_CMOD_CRT_OSMO_TCH_VAMOS_{Bm, Lm}

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/24341 )

Change subject: [VAMOS] bts_supports_cm(): handle 
RSL_CMOD_CRT_OSMO_TCH_VAMOS_{Bm,Lm}
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24341
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I61040df30246ff79c9b13055bb1fec92fe64f3dd
Gerrit-Change-Number: 24341
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 25 May 2021 10:01:07 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bts[master]: common/vty: facilitate finding duplicate PHY/TRX associations

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/24289 )

Change subject: common/vty: facilitate finding duplicate PHY/TRX associations
..


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/c/osmo-bts/+/24289/1/src/common/vty.c
File src/common/vty.c:

https://gerrit.osmocom.org/c/osmo-bts/+/24289/1/src/common/vty.c@993
PS1, Line 993:  /* Be tolerant in the interactive VTY mode */
why do you want to be tolerant? this may break running process from working 
correctly.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24289
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I132e08fc496abef278b94254cebfac7a4285a7c2
Gerrit-Change-Number: 24289
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 25 May 2021 10:04:51 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmo-abis[master]: ipa: do not open socket in nonblocking mode

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-abis/+/24332 )

Change subject: ipa: do not open socket in nonblocking mode
..


Patch Set 1: Code-Review-2

You need to do this asyncrhonously. See https://linux.die.net/man/2/connect:
"""
EINPROGRESS
The socket is nonblocking and the connection cannot be completed 
immediately. It is possible to select(2) or poll(2) for completion by selecting 
the socket for writing. After select(2) indicates writability, use 
getsockopt(2) to read the SO_ERROR option at level SOL_SOCKET to determine 
whether connect() completed successfully (SO_ERROR is zero) or unsuccessfully 
(SO_ERROR is one of the usual error codes listed here, explaining the reason 
for the failure). 
"""


--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/24332
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I926a75920f7a15c670f7445f2e74e876c5fad7be
Gerrit-Change-Number: 24332
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-CC: neels 
Gerrit-Comment-Date: Tue, 25 May 2021 10:10:43 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmo-abis[master]: ipa: do not open socket in nonblocking mode

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-abis/+/24332 )

Change subject: ipa: do not open socket in nonblocking mode
..


Patch Set 1:

It seems you can check at any tie whether the socket is connected by calling 
getpeername() (if not connected, you'll get an error).
See too https://cr.yp.to/docs/connect.html


--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/24332
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I926a75920f7a15c670f7445f2e74e876c5fad7be
Gerrit-Change-Number: 24332
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-CC: neels 
Gerrit-Comment-Date: Tue, 25 May 2021 10:15:26 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in osmo-mgw[master]: mgcp_network: refactor MGCP_DUMMY_LOAD

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-mgw/+/24315 )

Change subject: mgcp_network: refactor MGCP_DUMMY_LOAD
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-mgw/+/24315/1/include/osmocom/mgcp/mgcp_network.h
File include/osmocom/mgcp/mgcp_network.h:

https://gerrit.osmocom.org/c/osmo-mgw/+/24315/1/include/osmocom/mgcp/mgcp_network.h@18
PS1, Line 18: memcmp
> If it's always just one byte, why is it better to use memcmp()?
Ack



--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/24315
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I21d96cefeeb647958bfa1e22a0ea030884746fad
Gerrit-Change-Number: 24315
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-CC: fixeria 
Gerrit-Comment-Date: Tue, 25 May 2021 10:19:39 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria 
Gerrit-MessageType: comment

Change in osmo-bsc[master]: AMR config cleanup step 2: filter modes also for VTY

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/24357 )

Change subject: AMR config cleanup step 2: filter modes also for VTY
..


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/24357/2/src/osmo-bsc/lchan_fsm.c
File src/osmo-bsc/lchan_fsm.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/24357/2/src/osmo-bsc/lchan_fsm.c@575
PS2, Line 575:  /* If activated for VTY, there may not be a conn indicating an 
MSC AMR configuration. */
You mean "activated from VTY" or "activated by VTY" here?



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24357
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ia7519d2fa9e7f0b61b222d27d077bde4660c40b9
Gerrit-Change-Number: 24357
Gerrit-PatchSet: 2
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 25 May 2021 10:24:48 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: AMR config cleanup step 3: generate AMR LV on msg composition

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/24358 )

Change subject: AMR config cleanup step 3: generate AMR LV on msg composition
..


Patch Set 2: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/24358/2/src/osmo-bsc/gsm_04_08_rr.c
File src/osmo-bsc/gsm_04_08_rr.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/24358/2/src/osmo-bsc/gsm_04_08_rr.c@420
PS2, Line 420:  for (i = 1; i < num_modes; i++) {
this would ideally be a seprate commit


https://gerrit.osmocom.org/c/osmo-bsc/+/24358/2/src/osmo-bsc/gsm_04_08_rr.c@514
PS2, Line 514:  data[0] |= (modes_selected[1]->hysteresis & 0x0f) << 2;
You know you can do "data[0] = x | y;" right? ;)



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24358
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ie57f9d0e3912632903d9740291225bfd1634ed47
Gerrit-Change-Number: 24358
Gerrit-PatchSet: 2
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 25 May 2021 10:32:52 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: assignment_fsm: send BSSMAP response only after Assignment Request

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/24350 )

Change subject: assignment_fsm: send BSSMAP response only after Assignment 
Request
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24350
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ie0cddbdb00abcec78e153f4ae6d04ce75080a111
Gerrit-Change-Number: 24350
Gerrit-PatchSet: 2
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 25 May 2021 10:34:42 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: eliminate lchan->rsl_cmode

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/24354 )

Change subject: eliminate lchan->rsl_cmode
..


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/24354/2/src/osmo-bsc/abis_rsl.c
File src/osmo-bsc/abis_rsl.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/24354/2/src/osmo-bsc/abis_rsl.c@370
PS2, Line 370: %d
> 0x%02x? Also, why do you need temporary 'spd_ind' here?
Ack



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24354
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I1c167b22bb6638a929488d093bde0f1a5fb227ad
Gerrit-Change-Number: 24354
Gerrit-PatchSet: 2
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 25 May 2021 10:36:12 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria 
Gerrit-MessageType: comment

Change in osmo-bsc[master]: AMR config cleanup step 1: split lchan_mr_config()

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/24356 )

Change subject: AMR config cleanup step 1: split lchan_mr_config()
..


Patch Set 2: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24356
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Iebac2dc26412d877e5364f90d6f2ed7a7952351e
Gerrit-Change-Number: 24356
Gerrit-PatchSet: 2
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 25 May 2021 10:39:01 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: VTY: dump TSC Set and TSC for each timeslot

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/24370 )

Change subject: VTY: dump TSC Set and TSC for each timeslot
..


Patch Set 3: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24370
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I7842ff89bece6d88387dae056e350529bae6fc38
Gerrit-Change-Number: 24370
Gerrit-PatchSet: 3
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 25 May 2021 10:39:32 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Build failure of network:osmocom:nightly/osmo-cbc in Debian_9.0/armv7l

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-cbc/Debian_9.0/armv7l

Package network:osmocom:nightly/osmo-cbc failed to build in Debian_9.0/armv7l

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-cbc

Last lines of build log:
[   60s] Processing triggers for libc-bin (2.24-11+deb9u4) ...
[   60s] [195/449] installing libpsl5-0.17.0-3
[   60s] Processing triggers for libc-bin (2.24-11+deb9u4) ...
[   60s] [196/449] installing libssh2-1-1.7.0-1+deb9u1
[   60s] Processing triggers for libc-bin (2.24-11+deb9u4) ...
[   60s] [197/449] installing libxcb1-1.12-1
[   60s] Processing triggers for libc-bin (2.24-11+deb9u4) ...
[   60s] [198/449] installing libapt-inst2.0-1.4.10
[   60s] Processing triggers for libc-bin (2.24-11+deb9u4) ...
[   60s] [199/449] installing libunbound2-1.6.0-3+deb9u2
[   61s] Processing triggers for libc-bin (2.24-11+deb9u4) ...
[   61s] [200/449] installing libwpd-0.10-10-0.10.1-5+deb9u1
[   61s] Processing triggers for libc-bin (2.24-11+deb9u4) ...
[   61s] [201/449] installing libxml2-2.9.4+dfsg1-2.2+deb9u2
[   61s] dpkg-deb (subprocess): decompressing archive member: lzma error: 
compressed data is corrupt
[   61s] dpkg-deb: error: subprocess  returned error exit status 2
[   61s] dpkg: error processing archive .init_b_cache/libxml2.deb (--install):
[   61s]  cannot copy extracted data for 
'./usr/lib/arm-linux-gnueabihf/libxml2.so.2.9.4' to 
'/usr/lib/arm-linux-gnueabihf/libxml2.so.2.9.4.dpkg-new': unexpected end of 
file or stream
[   61s] Processing triggers for libc-bin (2.24-11+deb9u4) ...
[   61s] Errors were encountered while processing:
[   61s]  .init_b_cache/libxml2.deb
[   61s] exit ...
[   61s] ### VM INTERACTION START ###
[   64s] [   47.536824] sysrq: SysRq : Power Off
[   64s] [   47.538217] reboot: Power down
[   64s] ### VM INTERACTION END ###
[   64s] 
[   64s] armbuild04 failed "build osmo-cbc_0.2.2.202105250026.dsc" at Tue May 
25 10:40:40 UTC 2021.
[   64s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)

Change in osmo-bsc[master]: replace ts_*_for_each_lchan() with ts_for_n_lchans()

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/24372 )

Change subject: replace ts_*_for_each_lchan() with ts_for_n_lchans()
..


Patch Set 3: Code-Review-1

(3 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/24372/3/include/osmocom/bsc/gsm_data.h
File include/osmocom/bsc/gsm_data.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/24372/3/include/osmocom/bsc/gsm_data.h@567
PS3, Line 567:   ((lchan - (ts)->lchan) < ARRAY_SIZE((ts)->lchan)) \
Are you sure this is correct? AFAIR (lchan - (ts)->lchan) is a pointer distance 
in bytes, not in elements, while ARRAY_SIZE returns the number of elements?


https://gerrit.osmocom.org/c/osmo-bsc/+/24372/3/include/osmocom/bsc/gsm_data.h@568
PS3, Line 568:   && lchan->fi \
So if  an lchan has no fi, you early exit the loop? does that make sense? you 
should simply skip that lchan right?


https://gerrit.osmocom.org/c/osmo-bsc/+/24372/3/include/osmocom/bsc/gsm_data.h@569
PS3, Line 569:   && ((lchan - (ts)->lchan) < (N)); \
Same here, I'd say that's a distance in bytes, not in elements.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24372
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ib2c6baf73a81ba371143ba5adc912aef6f79238d
Gerrit-Change-Number: 24372
Gerrit-PatchSet: 3
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 25 May 2021 10:43:31 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: add VAMOS cmodes to chan_mode_to_rsl_cmod_spd()

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/24373 )

Change subject: add VAMOS cmodes to chan_mode_to_rsl_cmod_spd()
..


Patch Set 3: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24373
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I89c929e936151b4ed010114197cf8e6ea85193ff
Gerrit-Change-Number: 24373
Gerrit-PatchSet: 3
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 25 May 2021 10:43:52 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: RR Assignment for VAMOS: send TSC Set

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/24376 )

Change subject: RR Assignment for VAMOS: send TSC Set
..


Patch Set 4: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24376
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ibf3b6d276fadf724c16a5225c03e96a27a056153
Gerrit-Change-Number: 24376
Gerrit-PatchSet: 4
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 25 May 2021 10:44:53 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: RSL: look up lchan by sign_link, not trx, for VAMOS

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/24378 )

Change subject: RSL: look up lchan by sign_link, not trx, for VAMOS
..


Patch Set 4: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24378
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I872a3ed9ce0cdbd9fbe41a750081f54008eece8d
Gerrit-Change-Number: 24378
Gerrit-PatchSet: 4
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 25 May 2021 10:47:39 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: VTY: 'show lchan': show that lchan is in VAMOS mode

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/24379 )

Change subject: VTY: 'show lchan': show that lchan is in VAMOS mode
..


Patch Set 4: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24379
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I9f38712f941d60531526cc3395875655455909d9
Gerrit-Change-Number: 24379
Gerrit-PatchSet: 4
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 25 May 2021 10:47:53 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: log: assignment_fsm: drop newline from assignment_fail

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/24382 )

Change subject: log: assignment_fsm: drop newline from assignment_fail
..


Patch Set 4: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24382
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ib56e1f6a45c7e2c235f8ef0c8dea7151481677ab
Gerrit-Change-Number: 24382
Gerrit-PatchSet: 4
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 25 May 2021 10:48:47 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: log: assignment_fsm: tweak err msg for incompatible chan

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/24383 )

Change subject: log: assignment_fsm: tweak err msg for incompatible chan
..


Patch Set 4:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/24383/4/src/osmo-bsc/assignment_fsm.c
File src/osmo-bsc/assignment_fsm.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/24383/4/src/osmo-bsc/assignment_fsm.c@576
PS4, Line 576:  gsm_lchan_name(conn->lchan),
calling gsm_lchan_name twice in same function, make sure the buffer is not 
overwritten.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24383
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ifd8790923d54a27061708ff8077d509238b9c7dd
Gerrit-Change-Number: 24383
Gerrit-PatchSet: 4
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin 
Gerrit-Comment-Date: Tue, 25 May 2021 10:49:41 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in osmo-bsc[master]: log: assignment_fsm: tweak err msg for incompatible chan

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/24383 )

Change subject: log: assignment_fsm: tweak err msg for incompatible chan
..


Patch Set 4: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24383
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ifd8790923d54a27061708ff8077d509238b9c7dd
Gerrit-Change-Number: 24383
Gerrit-PatchSet: 4
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 25 May 2021 10:49:54 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: clarify bts_chan_load

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/24384 )

Change subject: clarify bts_chan_load
..


Patch Set 4: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24384
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I9bd80a08472018e69360ac5739979c7056d4f063
Gerrit-Change-Number: 24384
Gerrit-PatchSet: 4
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 25 May 2021 10:51:31 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: get_any_lchan(): reduce minor code dup

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/24385 )

Change subject: get_any_lchan(): reduce minor code dup
..


Patch Set 4:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/24385/4/src/osmo-bsc/abis_rsl.c
File src/osmo-bsc/abis_rsl.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/24385/4/src/osmo-bsc/abis_rsl.c@1646
PS4, Line 1646: if (lchan->fi->state == 
LCHAN_ST_ESTABLISHED){
spacing



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24385
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I304a7333adc265e156f04b42a10bac6912f58ad2
Gerrit-Change-Number: 24385
Gerrit-PatchSet: 4
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin 
Gerrit-Comment-Date: Tue, 25 May 2021 10:55:32 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Build failure of network:osmocom:nightly/osmo-pcu in Debian_9.0/armv7l

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/Debian_9.0/armv7l

Package network:osmocom:nightly/osmo-pcu failed to build in Debian_9.0/armv7l

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-pcu

Last lines of build log:
[  149s] Processing triggers for libc-bin (2.24-11+deb9u4) ...
[  149s] [366/408] installing libatkmm-1.6-1v5-2.24.2-2
[  149s] Processing triggers for libc-bin (2.24-11+deb9u4) ...
[  149s] [367/408] installing libgdk-pixbuf2.0-0-2.36.5-2+deb9u2
[  149s] Processing triggers for libc-bin (2.24-11+deb9u4) ...
[  149s] [368/408] installing gettext-0.19.8.1-2+deb9u1
[  150s] Processing triggers for man-db (2.7.6.1-2) ...
[  150s] [369/408] installing libmagickcore-6.q16-3-8:6.9.7.4+dfsg-11+deb9u8
[  150s] Processing triggers for libc-bin (2.24-11+deb9u4) ...
[  150s] [370/408] installing intltool-debian-0.35.0+20060710.4
[  150s] [371/408] installing gtk-update-icon-cache-3.22.11-1
[  151s] No diversion 'diversion of /usr/sbin/update-icon-caches to 
/usr/sbin/update-icon-caches.gtk2 by libgtk-3-bin', none removed.
[  151s] No diversion 'diversion of /usr/share/man/man8/update-icon-caches.8.gz 
to /usr/share/man/man8/update-icon-caches.gtk2.8.gz by libgtk-3-bin', none 
removed.
[  151s] Processing triggers for man-db (2.7.6.1-2) ...
[  151s] [372/408] installing libosmocore-dev-1.5.1.122.155968.202105250026
[  151s] dpkg-deb (subprocess): decompressing archive member: lzma error: 
compressed data is corrupt
[  151s] dpkg-deb: error: subprocess  returned error exit status 2
[  151s] dpkg: error processing archive .init_b_cache/libosmocore-dev.deb 
(--install):
[  151s]  cannot copy extracted data for 
'./usr/lib/arm-linux-gnueabihf/libosmoctrl.a' to 
'/usr/lib/arm-linux-gnueabihf/libosmoctrl.a.dpkg-new': unexpected end of file 
or stream
[  151s] Errors were encountered while processing:
[  151s]  .init_b_cache/libosmocore-dev.deb
[  151s] exit ...
[  151s] ### VM INTERACTION START ###
[  154s] [  138.652369] sysrq: SysRq : Power Off
[  154s] [  138.654605] reboot: Power down
[  154s] ### VM INTERACTION END ###
[  154s] 
[  154s] armbuild04 failed "build osmo-pcu_0.9.0.106.38f8.202105250026.dsc" at 
Tue May 25 10:56:11 UTC 2021.
[  154s] 

-- 
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)

Change in osmo-bsc[master]: add fields to reflect nr of lchans in ts struct

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/24371 )

Change subject: add fields to reflect nr of lchans in ts struct
..


Patch Set 3: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24371
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I08027d79db71a23e874b729c4e6173b0f269ee4f
Gerrit-Change-Number: 24371
Gerrit-PatchSet: 3
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 25 May 2021 10:59:30 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: add VAMOS secondary lchans to timeslot struct

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/24377 )

Change subject: add VAMOS secondary lchans to timeslot struct
..


Patch Set 4: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24377
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I928af99498bba488d317693f3144d4fccbbe9af3
Gerrit-Change-Number: 24377
Gerrit-PatchSet: 4
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 25 May 2021 11:04:11 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: implement Channel Mode Modify to VAMOS mode

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/24374 )

Change subject: implement Channel Mode Modify to VAMOS mode
..


Patch Set 4: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24374
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ibf53f4797d7491b17a33946fd7d920f038362b4c
Gerrit-Change-Number: 24374
Gerrit-PatchSet: 4
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 25 May 2021 11:05:32 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: implement CHANnel ACTIVate to VAMOS mode

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/24375 )

Change subject: implement CHANnel ACTIVate to VAMOS mode
..


Patch Set 4: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24375
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: If3ac584e4223ef7656c7fedc3bf11df87e4309ec
Gerrit-Change-Number: 24375
Gerrit-PatchSet: 4
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 25 May 2021 11:05:55 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: VTY: add 'vamos-subslot' to activate a secondary lchan

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/24380 )

Change subject: VTY: add 'vamos-subslot' to activate a secondary lchan
..


Patch Set 4: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24380
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: If44b6bdb78046502eb0b66529ae190a955d9978c
Gerrit-Change-Number: 24380
Gerrit-PatchSet: 4
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 25 May 2021 11:06:11 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: VTY: add lchan re-assignment command

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/24381 )

Change subject: VTY: add lchan re-assignment command
..


Patch Set 4: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24381
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: If006f5caaf83b07675f57e5665cfa79328da55e6
Gerrit-Change-Number: 24381
Gerrit-PatchSet: 4
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 25 May 2021 11:06:29 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: vty-test: osmo-bsc.vty: test doc of lchan activate cmd

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/24387 )

Change subject: vty-test: osmo-bsc.vty: test doc of lchan activate cmd
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24387
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I6379e306fb8fa6ec227125c6cf14893d674e7596
Gerrit-Change-Number: 24387
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 25 May 2021 11:06:48 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmocore[master]: gprs_ns2_sns: move selection of the next bind into own function

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/24122 )

Change subject: gprs_ns2_sns: move selection of the next bind into own function
..


Patch Set 4: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24122
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ic39f0e5474ecc055d9a1b6a7b30777574d8b741d
Gerrit-Change-Number: 24122
Gerrit-PatchSet: 4
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 25 May 2021 11:07:38 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: handover dot charts: fix wrong transitions regarding MGW

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/24359 )

Change subject: handover dot charts: fix wrong transitions regarding MGW
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24359
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I2ed9b3ca7fe145a930ca509e6b3943f5abf3aa62
Gerrit-Change-Number: 24359
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 25 May 2021 11:08:16 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: add secondary RSL link for VAMOS (shadow TEI)

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/24366 )

Change subject: add secondary RSL link for VAMOS (shadow TEI)
..


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/24366/3/include/osmocom/bsc/bts_trx.h
File include/osmocom/bsc/bts_trx.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/24366/3/include/osmocom/bsc/bts_trx.h@37
PS3, Line 37: rsl_tei_vamos
> Do you really need this field? It's always (rsl_tei_primary + 0x80) AFAICS.
VAMOS_SHADOW_TEI(rsl_tei_primary) can be used instead afaiu.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24366
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ic304924b017f4588f749268e99ed1326db4c9f47
Gerrit-Change-Number: 24366
Gerrit-PatchSet: 3
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-CC: pespin 
Gerrit-Comment-Date: Tue, 25 May 2021 11:09:57 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria 
Gerrit-MessageType: comment

Change in osmo-bsc[master]: gsm48_lchan2chan_desc(): expose TSC as param

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/24368 )

Change subject: gsm48_lchan2chan_desc(): expose TSC as param
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24368
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I49503a6f5d25bb3bc9a0505bd79ed1d5c4f50577
Gerrit-Change-Number: 24368
Gerrit-PatchSet: 3
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 25 May 2021 11:11:06 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bts[master]: [VAMOS] osmo-bts-trx: indicate BTS_FEAT_{MULTI_TSC, VAMOS} as supported

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/24390 )

Change subject: [VAMOS] osmo-bts-trx: indicate BTS_FEAT_{MULTI_TSC,VAMOS} as 
supported
..


Patch Set 3: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24390
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Iba3f9787c32c802cfab716176e6ada799f5f21df
Gerrit-Change-Number: 24390
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 25 May 2021 11:12:45 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bts[master]: [VAMOS] common/oml: generalize checking BTS_FEAT_MULTI_TSC

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/24389 )

Change subject: [VAMOS] common/oml: generalize checking BTS_FEAT_MULTI_TSC
..


Patch Set 3: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24389
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Iaa5aced70e166963106c27ebdb09adaae22daea4
Gerrit-Change-Number: 24389
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 25 May 2021 11:12:33 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bts[master]: [VAMOS] l1sap_chan_act(): handle Osmocom specific TSC IE

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/24329 )

Change subject: [VAMOS] l1sap_chan_act(): handle Osmocom specific TSC IE
..


Patch Set 5: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24329
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I717e5b2a6ca5b4faeaab9cae4bb971907945871b
Gerrit-Change-Number: 24329
Gerrit-PatchSet: 5
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 25 May 2021 11:13:43 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bts[master]: [VAMOS] osmo-bts-trx: rework handling of Training Sequence

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/24327 )

Change subject: [VAMOS] osmo-bts-trx: rework handling of Training Sequence
..


Patch Set 4: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24327
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I3744bc308b99ef941e6e9d139444e414abebc14b
Gerrit-Change-Number: 24327
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 25 May 2021 11:15:18 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bts[master]: [VAMOS] osmo-bts-trx: properly handle per-timeslot TSC values

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/24388 )

Change subject: [VAMOS] osmo-bts-trx: properly handle per-timeslot TSC values
..


Patch Set 3: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/c/osmo-bts/+/24388/3/src/osmo-bts-trx/l1_if.h
File src/osmo-bts-trx/l1_if.h:

https://gerrit.osmocom.org/c/osmo-bts/+/24388/3/src/osmo-bts-trx/l1_if.h@108
PS3, Line 108:  boolsetslot_valid[TRX_NR_TS];
Why not merging too the valid and sent into the new struct array you created? 
Feels like you went half way.


https://gerrit.osmocom.org/c/osmo-bts/+/24388/3/src/osmo-bts-trx/trx_provision_fsm.c
File src/osmo-bts-trx/trx_provision_fsm.c:

https://gerrit.osmocom.org/c/osmo-bts/+/24388/3/src/osmo-bts-trx/trx_provision_fsm.c@521
PS3, Line 521:  trx_if_cmd_setslot(l1h, ts_data->tn, l1if_setslot_cb);
shouldn't you send it only if it didn't change?



--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24388
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Idc5796151e3e83f42d60c2d4cb7c35890d76a7f5
Gerrit-Change-Number: 24388
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 25 May 2021 11:27:05 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-pcu[master]: tbf: Move existing tbf_state implementation to osmo_fsm

[fixeria]

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/24235 )

Change subject: tbf: Move existing tbf_state implementation to osmo_fsm
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/24235
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I6bb4baea2dee191ba5bbcbec2ea9dcf681aa1237
Gerrit-Change-Number: 24235
Gerrit-PatchSet: 3
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Tue, 25 May 2021 11:29:43 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-pcu[master]: tbf: Move existing tbf_state implementation to osmo_fsm

[pespin]

pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/24235 )

Change subject: tbf: Move existing tbf_state implementation to osmo_fsm
..

tbf: Move existing tbf_state implementation to osmo_fsm

This is only an initial implementation, where all state changes are
still done outside the FSM itself.
The idea is to do the move in several commits so that they can be
digested better in logical steps and avoid major break up.

Related: OS#2709
Change-Id: I6bb4baea2dee191ba5bbcbec2ea9dcf681aa1237
---
M doc/tbf.txt
M src/Makefile.am
M src/gprs_ms.h
M src/gprs_rlcmac_sched.cpp
M src/pdch.cpp
M src/tbf.cpp
M src/tbf.h
M src/tbf_dl.cpp
A src/tbf_fsm.c
A src/tbf_fsm.h
M src/tbf_ul.cpp
M tests/alloc/AllocTest.cpp
M tests/alloc/AllocTest.err
M tests/tbf/TbfTest.cpp
M tests/tbf/TbfTest.err
M tests/types/TypesTest.cpp
M tests/types/TypesTest.err
17 files changed, 125,013 insertions(+), 364 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved
  laforge: Looks good to me, but someone else must approve




--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/24235
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I6bb4baea2dee191ba5bbcbec2ea9dcf681aa1237
Gerrit-Change-Number: 24235
Gerrit-PatchSet: 3
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in osmo-pcu[master]: cosmetic: Fix typo s/TIMSI/TMSI/

[pespin]

pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/24321 )

Change subject: cosmetic: Fix typo s/TIMSI/TMSI/
..

cosmetic: Fix typo s/TIMSI/TMSI/

Change-Id: I64231311633b64d898625c49fdbf3f816dfbb97a
---
M src/gprs_bssgp_pcu.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved



diff --git a/src/gprs_bssgp_pcu.c b/src/gprs_bssgp_pcu.c
index 5d0a489..7ee2e45 100644
--- a/src/gprs_bssgp_pcu.c
+++ b/src/gprs_bssgp_pcu.c
@@ -191,7 +191,7 @@
}
req->mi_imsi_present = true;

-   /* TIMSI is optional */
+   /* TMSI is optional */
req->mi_tmsi_present = false;
if (TLVP_PRESENT(tp, BSSGP_IE_TMSI)) {
/* Be safe against an evil SGSN - check the length */

--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/24321
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I64231311633b64d898625c49fdbf3f816dfbb97a
Gerrit-Change-Number: 24321
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in osmo-bsc[master]: ctrl: Avoid fclose() on NULL pointer

[fixeria]

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/24391 )

Change subject: ctrl: Avoid fclose() on NULL pointer
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24391
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ib23614c77ec039dd0812196fa4e5d1c3f8408087
Gerrit-Change-Number: 24391
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Comment-Date: Tue, 25 May 2021 11:31:12 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: ctrl: Avoid fclose() on NULL pointer

[pespin]

pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/24391 )

Change subject: ctrl: Avoid fclose() on NULL pointer
..

ctrl: Avoid fclose() on NULL pointer

Fixes: 25ff634b5eb06bc1411125dd01efae246e976c4a
Related: Coverity CID#236128
Change-Id: Ib23614c77ec039dd0812196fa4e5d1c3f8408087
---
M src/osmo-bsc/bsc_ctrl_commands.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved



diff --git a/src/osmo-bsc/bsc_ctrl_commands.c b/src/osmo-bsc/bsc_ctrl_commands.c
index 9038404..2d37b5d 100644
--- a/src/osmo-bsc/bsc_ctrl_commands.c
+++ b/src/osmo-bsc/bsc_ctrl_commands.c
@@ -62,7 +62,7 @@
LOGP(DCTRL, LOGL_NOTICE, "Applying VTY snippet from %s: fopen() 
failed: %d\n",
 cmd->value, errno);
cmd->reply = "NoFile";
-   goto close_ret;
+   return cmd_ret;
}

rc = vty_read_config_filep(cfile, NULL);

--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24391
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ib23614c77ec039dd0812196fa4e5d1c3f8408087
Gerrit-Change-Number: 24391
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in osmo-bts[master]: bts: Clean up TS selection in sign_link_up

[pespin]

pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/24319 )

Change subject: bts: Clean up TS selection in sign_link_up
..

bts: Clean up TS selection in sign_link_up

Change-Id: I0c92dfd05bf2ae40887980ef10b7e4c679213b6a
---
M src/common/abis.c
M tests/handover/handover_test.c
2 files changed, 22 insertions(+), 18 deletions(-)

Approvals:
  fixeria: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/common/abis.c b/src/common/abis.c
index be7e906..55962bd 100644
--- a/src/common/abis.c
+++ b/src/common/abis.c
@@ -99,25 +99,27 @@
 static struct e1inp_sign_link *sign_link_up(void *unit, struct e1inp_line 
*line,
enum e1inp_sign_type type)
 {
-   struct e1inp_sign_link *sign_link = NULL;
+   struct e1inp_ts *sign_ts;
struct gsm_bts_trx *trx;
int trx_nr;

switch (type) {
case E1INP_SIGN_OML:
+   sign_ts = e1inp_line_ipa_oml_ts(line);
LOGP(DABIS, LOGL_INFO, "OML Signalling link up\n");
-   e1inp_ts_config_sign(&line->ts[E1INP_SIGN_OML-1], line);
-   sign_link = g_bts->oml_link =
-   e1inp_sign_link_create(&line->ts[E1INP_SIGN_OML-1],
-   E1INP_SIGN_OML, g_bts->c0, 255, 
0);
+   e1inp_ts_config_sign(sign_ts, line);
+   g_bts->oml_link = e1inp_sign_link_create(sign_ts, 
E1INP_SIGN_OML,
+   g_bts->c0, 
IPAC_PROTO_OML, 0);
if (clock_gettime(CLOCK_MONOTONIC, 
&g_bts->oml_conn_established_timestamp) != 0)
memset(&g_bts->oml_conn_established_timestamp, 0,
   sizeof(g_bts->oml_conn_established_timestamp));
drain_oml_queue(g_bts);
bts_link_estab(g_bts);
-   break;
-   default:
+   return g_bts->oml_link;
+
+   case E1INP_SIGN_RSL:
trx_nr = type - E1INP_SIGN_RSL;
+   sign_ts = e1inp_line_ipa_rsl_ts(line, trx_nr);
LOGP(DABIS, LOGL_INFO, "RSL Signalling link for TRX%d up\n",
trx_nr);
trx = gsm_bts_trx_num(g_bts, trx_nr);
@@ -126,16 +128,17 @@
trx_nr);
break;
}
-   e1inp_ts_config_sign(&line->ts[type-1], line);
-   sign_link = trx->rsl_link =
-   e1inp_sign_link_create(&line->ts[type-1],
-   E1INP_SIGN_RSL, trx,
-   trx->rsl_tei, 0);
+   e1inp_ts_config_sign(sign_ts, line);
+   trx->rsl_link = e1inp_sign_link_create(sign_ts, E1INP_SIGN_RSL,
+  trx, trx->rsl_tei, 0);
trx_link_estab(trx);
-   break;
-   }
+   return trx->rsl_link;

-   return sign_link;
+   default:
+   LOGP(DABIS, LOGL_ERROR, "Unknwon Signalling link up %d\n", 
(int)type);
+   return NULL;
+   }
+   return NULL;
 }

 static void sign_link_down(struct e1inp_line *line)
diff --git a/tests/handover/handover_test.c b/tests/handover/handover_test.c
index 6af8fac..9c9b020 100644
--- a/tests/handover/handover_test.c
+++ b/tests/handover/handover_test.c
@@ -58,6 +58,7 @@
 {
void *tall_bts_ctx;
struct e1inp_line *line;
+   struct e1inp_ts *sign_ts;
struct gsm_lchan *lchan;
struct osmo_phsap_prim nl1sap;
struct msgb *msg;
@@ -90,9 +91,9 @@

line = e1inp_line_create(0, "ipa");
OSMO_ASSERT(line);
-
-   e1inp_ts_config_sign(&line->ts[E1INP_SIGN_RSL-1], line);
-   trx->rsl_link = e1inp_sign_link_create(&line->ts[E1INP_SIGN_RSL-1], 
E1INP_SIGN_RSL, NULL, 0, 0);
+   sign_ts = e1inp_line_ipa_rsl_ts(line, 0);
+   e1inp_ts_config_sign(sign_ts, line);
+   trx->rsl_link = e1inp_sign_link_create(sign_ts, E1INP_SIGN_RSL, NULL, 
0, 0);
OSMO_ASSERT(trx->rsl_link);
trx->rsl_link->trx = trx;


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/24319
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I0c92dfd05bf2ae40887980ef10b7e4c679213b6a
Gerrit-Change-Number: 24319
Gerrit-PatchSet: 4
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in osmo-bsc[master]: get_any_lchan(): reduce minor code dup

[dexter]

dexter has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/24385 )

Change subject: get_any_lchan(): reduce minor code dup
..


Patch Set 4: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24385
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I304a7333adc265e156f04b42a10bac6912f58ad2
Gerrit-Change-Number: 24385
Gerrit-PatchSet: 4
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 
Gerrit-CC: pespin 
Gerrit-Comment-Date: Tue, 25 May 2021 14:16:19 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: AMR config cleanup step 2: filter modes also for VTY

[neels]

neels has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/24357 )

Change subject: AMR config cleanup step 2: filter modes also for VTY
..


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/24357/2/src/osmo-bsc/lchan_fsm.c
File src/osmo-bsc/lchan_fsm.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/24357/2/src/osmo-bsc/lchan_fsm.c@575
PS2, Line 575:  /* If activated for VTY, there may not be a conn indicating an 
MSC AMR configuration. */
> You mean "activated from VTY" or "activated by VTY" here?
the user entered some VTY command on telnet which ended up 
activating/modifying/re-assigning this lchan.
So we are probably activating an lchan for a VTY command.
For me all of "for VTY" "from VTY" "by VTY" mean exactly the same. Where is the 
difference for you?

The point in this patch however is to not care about VTY, but pivot on the lack 
of a BSSAP conn.
(incidentally this case happens only when some action was taken on the VTY 
without an MSC involved)



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24357
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ia7519d2fa9e7f0b61b222d27d077bde4660c40b9
Gerrit-Change-Number: 24357
Gerrit-PatchSet: 2
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 25 May 2021 14:26:09 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Gerrit-MessageType: comment

Change in osmo-ttcn3-hacks[master]: MGCP_Test: avoid crash in latest (TC_one_crcx_loopback_rtp_implicit)

[dexter]

dexter has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24392 )


Change subject: MGCP_Test: avoid crash in latest 
(TC_one_crcx_loopback_rtp_implicit)
..

MGCP_Test: avoid crash in latest (TC_one_crcx_loopback_rtp_implicit)

The testcase TC_one_crcx_loopback_rtp_implicit triggers a bug in older
osmo-mgw version that eventually leads into a crash of osmo-mgw. This
also means that all tests after TC_one_crcx_loopback_rtp_implicit will
also fail. Lets move TC_one_crcx_loopback_rtp_implicit to the end of the
control section to postpone the crash to the very end of the testrun.

Change-Id: I25abf30f8c49e580c46e7a61e887bd0add9a4cd4
Related: OS#5123
---
M mgw/MGCP_Test.ttcn
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/92/24392/1

diff --git a/mgw/MGCP_Test.ttcn b/mgw/MGCP_Test.ttcn
index c1e263a..6f9eb48 100644
--- a/mgw/MGCP_Test.ttcn
+++ b/mgw/MGCP_Test.ttcn
@@ -2445,7 +2445,6 @@
execute(TC_one_crcx_receive_only_rtp());
execute(TC_one_crcx_loopback_rtp());
execute(TC_one_crcx_loopback_rtp_ipv6());
-   execute(TC_one_crcx_loopback_rtp_implicit());
execute(TC_two_crcx_and_rtp());
execute(TC_two_crcx_and_rtp_bidir());
execute(TC_two_crcx_diff_pt_and_rtp());
@@ -2474,5 +2473,7 @@
execute(TC_two_crcx_mdcx_and_rtp_osmux_ipv6());
execute(TC_two_crcx_mdcx_and_rtp_osmux_ipv4_ipv6());
execute(TC_two_crcx_mdcx_and_rtp_osmux_ipv6_ipv4());
+
+   execute(TC_one_crcx_loopback_rtp_implicit());
}
 }

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24392
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I25abf30f8c49e580c46e7a61e887bd0add9a4cd4
Gerrit-Change-Number: 24392
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-MessageType: newchange

Change in libosmo-abis[master]: ipa: do not open socket in nonblocking mode

[laforge]

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-abis/+/24332 )

Change subject: ipa: do not open socket in nonblocking mode
..


Patch Set 1:

> It seems you can check at any tie whether the socket is connected by calling 
> getpeername() (if not connected, you'll get an error).


the method I'm aware is to register the file descriptor for exceptions, and 
when the exception is signalled to select/poll, you do a getsockopt SOL_SOCKET, 
SO_ERROR.  That will tell you if any error condition exists.


--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/24332
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I926a75920f7a15c670f7445f2e74e876c5fad7be
Gerrit-Change-Number: 24332
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-CC: neels 
Gerrit-Comment-Date: Tue, 25 May 2021 14:51:55 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in osmo-bsc[master]: hodec 2: do intra-cell congestion resolution by Assignment

[neels]

neels has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/24364 )

Change subject: hodec 2: do intra-cell congestion resolution by Assignment
..


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/24364/3/tests/handover/handover_test.c
File tests/handover/handover_test.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/24364/3/tests/handover/handover_test.c@584
PS3, Line 584:  buf = msgb_put(msg, 3);
> You could (ab)use msgb_tv16_put() here: […]
indeed. however this is just a copy of a different place in this file, so i'll 
just keep it the same



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24364
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Id56a890106b93fcee67ac9401b890e7b63bba421
Gerrit-Change-Number: 24364
Gerrit-PatchSet: 3
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Comment-Date: Tue, 25 May 2021 14:54:23 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria 
Gerrit-MessageType: comment

Change in osmo-bsc[master]: make sure channel mode and s15_s0 are updated only after an ACK

[neels]

neels has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/24352 )

Change subject: make sure channel mode and s15_s0 are updated only after an ACK
..


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/24352/2/src/osmo-bsc/bsc_vty.c
File src/osmo-bsc/bsc_vty.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/24352/2/src/osmo-bsc/bsc_vty.c@6086
PS2, Line 6086: amr_modes[amr_mode],
> Unrelated: below the 'amr_mode' is compared to -1. […]
wait a minute, i thought i had a separate patch to fix this...
this is a bug existing prior to this patch and i'm sure i removed that s15_s0 
line in a patch,
because AFAIU EFR doesn't use those bits anyway.

ah found it, it got lost on another branch, will include here



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24352
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ie0da36124d73efc28a8809b63d7c96e2167fc412
Gerrit-Change-Number: 24352
Gerrit-PatchSet: 2
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria 
Gerrit-Comment-Date: Tue, 25 May 2021 14:54:37 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria 
Gerrit-MessageType: comment

Change in osmo-bsc[master]: assignment_fsm: send BSSMAP response only after Assignment Request

[laforge]

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/24350 )

Change subject: assignment_fsm: send BSSMAP response only after Assignment 
Request
..


Patch Set 2: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24350
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ie0cddbdb00abcec78e153f4ae6d04ce75080a111
Gerrit-Change-Number: 24350
Gerrit-PatchSet: 2
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 25 May 2021 14:55:45 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: cosmetic scoping in reuse_existing_lchan()

[laforge]

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/24351 )

Change subject: cosmetic scoping in reuse_existing_lchan()
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24351
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I0d1000cf108b0dfdc690f7a59d9bdf40de9043d2
Gerrit-Change-Number: 24351
Gerrit-PatchSet: 2
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Tue, 25 May 2021 14:56:14 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: add secondary RSL link for VAMOS (shadow TEI)

[neels]

neels has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/24366 )

Change subject: add secondary RSL link for VAMOS (shadow TEI)
..


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/24366/3/include/osmocom/bsc/bts_trx.h
File include/osmocom/bsc/bts_trx.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/24366/3/include/osmocom/bsc/bts_trx.h@37
PS3, Line 37: rsl_tei_vamos
> VAMOS_SHADOW_TEI(rsl_tei_primary) can be used instead afaiu.
This is the current choice of things, but I was not certain that this would be 
the case.
I still prefer that this translation from TEI to VAMOS TEI happens only once,
and that all other code can just use the fixed value. Probably we don't need 
the macro then...



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24366
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ic304924b017f4588f749268e99ed1326db4c9f47
Gerrit-Change-Number: 24366
Gerrit-PatchSet: 3
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-CC: pespin 
Gerrit-Comment-Date: Tue, 25 May 2021 14:57:24 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Comment-In-Reply-To: fixeria 
Gerrit-MessageType: comment

Change in osmo-bsc[master]: make sure channel mode and s15_s0 are updated only after an ACK

[laforge]

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/24352 )

Change subject: make sure channel mode and s15_s0 are updated only after an ACK
..


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/24352/2/src/osmo-bsc/gsm_data.c
File src/osmo-bsc/gsm_data.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/24352/2/src/osmo-bsc/gsm_data.c@691
PS2, Line 691:  default:
> Cosmetic: it's unusual to see 'default' before the other 'case's.
Agreed


https://gerrit.osmocom.org/c/osmo-bsc/+/24352/2/src/osmo-bsc/gsm_data.c@692
PS2, Line 692:  return -1;
> Callers of this function do not check the returned value, so I would rather 
> add OSMO_ASSERT(0) here.
Agreed



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24352
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ie0da36124d73efc28a8809b63d7c96e2167fc412
Gerrit-Change-Number: 24352
Gerrit-PatchSet: 2
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria 
Gerrit-CC: laforge 
Gerrit-Comment-Date: Tue, 25 May 2021 14:57:45 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria 
Gerrit-MessageType: comment

Change in osmo-bsc[master]: remove special case from assignment_count_result()

[laforge]

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/24353 )

Change subject: remove special case from assignment_count_result()
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24353
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ic62e8a48d3c88a1966086240a41732d169328491
Gerrit-Change-Number: 24353
Gerrit-PatchSet: 2
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Tue, 25 May 2021 14:58:20 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: move lchan->csd_mode into channel_mode_and_rate

[laforge]

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/24355 )

Change subject: move lchan->csd_mode into channel_mode_and_rate
..


Patch Set 2: Code-Review+2

background: It is likely we will need to implement those towards the end of the 
year.

Also FYI, there was some limited CSD support patches in a branch by tobias a 
long time ago.

No action item associated with my comments above.


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24355
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ie0e065a5dca5f4a31d5d81e3528a539214a74170
Gerrit-Change-Number: 24355
Gerrit-PatchSet: 2
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Tue, 25 May 2021 14:59:47 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: AMR config cleanup step 1: split lchan_mr_config()

[laforge]

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/24356 )

Change subject: AMR config cleanup step 1: split lchan_mr_config()
..


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/24356/2/src/osmo-bsc/lchan_fsm.c
File src/osmo-bsc/lchan_fsm.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/24356/2/src/osmo-bsc/lchan_fsm.c@499
PS2, Line 499: logging
> This looks weird to me. I would keep the old naming.
once more I agree with fixeria.  LOG_LCHAN logs on a lchan.  And if I see a 
variable called lchan, I know what it is. "logging" looks like some kind of 
predicate boolean..



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24356
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Iebac2dc26412d877e5364f90d6f2ed7a7952351e
Gerrit-Change-Number: 24356
Gerrit-PatchSet: 2
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-CC: laforge 
Gerrit-Comment-Date: Tue, 25 May 2021 15:02:28 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria 
Gerrit-MessageType: comment

Change in osmo-bsc[master]: replace ts_*_for_each_lchan() with ts_for_n_lchans()

[neels]

neels has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/24372 )

Change subject: replace ts_*_for_each_lchan() with ts_for_n_lchans()
..


Patch Set 3:

(3 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/24372/3/include/osmocom/bsc/gsm_data.h
File include/osmocom/bsc/gsm_data.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/24372/3/include/osmocom/bsc/gsm_data.h@567
PS3, Line 567:   ((lchan - (ts)->lchan) < ARRAY_SIZE((ts)->lchan)) \
> Are you sure this is correct? AFAIR (lchan - (ts)->lchan) is a pointer 
> distance in bytes, not in ele […]
you *always* get a distance in pointer-type-sizeof. A distance in bytes will 
only be returned for e.g. uint8_t*. For gsm_lchan* you always get a distance in 
array indexes. I and we and everyone is using that all over the place and I am 
absolutely positively sure.

x = &lchan[3]
is identical to
x = lchan + 3


https://gerrit.osmocom.org/c/osmo-bsc/+/24372/3/include/osmocom/bsc/gsm_data.h@568
PS3, Line 568:   && lchan->fi \
> So if  an lchan has no fi, you early exit the loop? does that make sense? you 
> should simply skip tha […]
I'd like that, but we can't skip in a for loop macro like this : (

And actually there will never be a "fi gap" in the lchan array.
As soon as one NULL fi is encountered, the rest of them will also be NULL.


https://gerrit.osmocom.org/c/osmo-bsc/+/24372/3/include/osmocom/bsc/gsm_data.h@569
PS3, Line 569:   && ((lchan - (ts)->lchan) < (N)); \
> Same here, I'd say that's a distance in bytes, not in elements.
didn't expect this from you Pau ; )  ; )  ; )



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24372
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ib2c6baf73a81ba371143ba5adc912aef6f79238d
Gerrit-Change-Number: 24372
Gerrit-PatchSet: 3
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 25 May 2021 15:17:01 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Gerrit-MessageType: comment

Change in osmo-bsc[master]: log: assignment_fsm: tweak err msg for incompatible chan

[neels]

neels has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/24383 )

Change subject: log: assignment_fsm: tweak err msg for incompatible chan
..


Patch Set 4:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/24383/4/src/osmo-bsc/assignment_fsm.c
File src/osmo-bsc/assignment_fsm.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/24383/4/src/osmo-bsc/assignment_fsm.c@576
PS4, Line 576:  gsm_lchan_name(conn->lchan),
> calling gsm_lchan_name twice in same function, make sure the buffer is not 
> overwritten.
static inline char *gsm_lchan_name(const struct gsm_lchan *lchan)
{
return lchan->name;
}



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24383
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ifd8790923d54a27061708ff8077d509238b9c7dd
Gerrit-Change-Number: 24383
Gerrit-PatchSet: 4
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 25 May 2021 15:21:24 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Gerrit-MessageType: comment

Change in osmo-bsc[master]: make sure channel mode and s15_s0 are updated only after an ACK

[neels]

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bsc/+/24352

to look at the new patch set (#3).

Change subject: make sure channel mode and s15_s0 are updated only after an ACK
..

make sure channel mode and s15_s0 are updated only after an ACK

I noticed during testing that an lchan used as TCH/F in fact still had
its channel mode set to Signalling -- because on Assignment, the Speech
mode used to be placed in the *previous* lchan and the new lchan was
never updated after the Activ ACK. This is unbearable confusion which I
complained about numerous times, so far mostly for cosmetic reasons. But
implementing re-assignment properly actually requires this to be cleaned
up.

Keep all volatile chan mode settings in lchan->activate.* or
lchan->modify.*, and only update lchan->* members when an ACK has been
received for those settings. So a failed request keeps a sane state.

Make sure that those settings are in fact updated in the proper lchan,
upon an ACK, so that subsequent re-assignment or mode-modify know the
accurate lchan state.

Related are upcoming patches that sort out the AMR multirate
configuration in a similar fashion, see
Iebac2dc26412d877e5364f90d6f2ed7a7952351e
Ia7519d2fa9e7f0b61b222d27d077bde4660c40b9
Ie57f9d0e3912632903d9740291225bfd1634ed47.

Related: SYS#5315 OS#4940 OS#3787 OS#3833
Change-Id: Ie0da36124d73efc28a8809b63d7c96e2167fc412
---
M include/osmocom/bsc/gsm_data.h
M src/osmo-bsc/abis_rsl.c
M src/osmo-bsc/assignment_fsm.c
M src/osmo-bsc/bsc_vty.c
M src/osmo-bsc/gsm_04_08_rr.c
M src/osmo-bsc/gsm_data.c
M src/osmo-bsc/handover_decision_2.c
M src/osmo-bsc/handover_fsm.c
M src/osmo-bsc/lchan_fsm.c
M src/osmo-bsc/lchan_rtp_fsm.c
M src/osmo-bsc/osmo_bsc_bssap.c
M src/osmo-bsc/osmo_bsc_lcls.c
M tests/handover/handover_test.c
13 files changed, 186 insertions(+), 162 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/52/24352/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24352
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ie0da36124d73efc28a8809b63d7c96e2167fc412
Gerrit-Change-Number: 24352
Gerrit-PatchSet: 3
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria 
Gerrit-CC: laforge 
Gerrit-MessageType: newpatchset

Change in osmo-bsc[master]: AMR config cleanup step 1: split lchan_mr_config()

[neels]

Hello Jenkins Builder, pespin, fixeria,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bsc/+/24356

to look at the new patch set (#3).

Change subject: AMR config cleanup step 1: split lchan_mr_config()
..

AMR config cleanup step 1: split lchan_mr_config()

Split off two function from lchan_mr_config() which do not directly
manipulate struct gsm_lchan members. This allows subsequent patches to
re-use mr_config_filter() for Channel Mode Modify without depending on
lchan->activate.info; allows to filter AMR modes without modifying the
state of an already active lchan before sending a Channel Activation or
Channel Mode Modify; and allows to move mr_config_render_lv() to
gsm_04_08_rr.c so that the mr_ms_lv and mr_bts_lv no longer need to be
stored in struct gsm_lchan -- they essentially duplicate s15_s0.

Rationale:

This is a follow-up for the AMR configuration in the sense that previous
patch Ie0da36124d73efc28a8809b63d7c96e2167fc412 started for channel mode
and rate, and the s15_s0 bits:

The AMR mode filtering directly manipulates struct gsm_lchan members and
takes parameters from lchan->activate.info. This makes it hard to
separate lchan activation from the Channel Mode Modify procedure.

Related: SYS#5315 OS#4940 OS#3787 OS#3833
Change-Id: Iebac2dc26412d877e5364f90d6f2ed7a7952351e
---
M src/osmo-bsc/lchan_fsm.c
1 file changed, 85 insertions(+), 73 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/56/24356/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24356
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Iebac2dc26412d877e5364f90d6f2ed7a7952351e
Gerrit-Change-Number: 24356
Gerrit-PatchSet: 3
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-CC: laforge 
Gerrit-MessageType: newpatchset

Change in osmo-bsc[master]: eliminate lchan->rsl_cmode

[neels]

Hello Jenkins Builder, pespin, fixeria,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bsc/+/24354

to look at the new patch set (#3).

Change subject: eliminate lchan->rsl_cmode
..

eliminate lchan->rsl_cmode

Related: SYS#5315 OS#4940
Change-Id: I1c167b22bb6638a929488d093bde0f1a5fb227ad
---
M include/osmocom/bsc/gsm_data.h
M src/osmo-bsc/abis_rsl.c
M src/osmo-bsc/gsm_04_08_rr.c
M src/osmo-bsc/gsm_data.c
M src/osmo-bsc/lchan_fsm.c
5 files changed, 26 insertions(+), 43 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/54/24354/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24354
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I1c167b22bb6638a929488d093bde0f1a5fb227ad
Gerrit-Change-Number: 24354
Gerrit-PatchSet: 3
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: newpatchset

Change in osmo-bsc[master]: AMR config cleanup step 2: filter modes also for VTY

[neels]

Hello Jenkins Builder, pespin,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bsc/+/24357

to look at the new patch set (#3).

Change subject: AMR config cleanup step 2: filter modes also for VTY
..

AMR config cleanup step 2: filter modes also for VTY

The previous patch reshuffled the code without having any functional
change. In this patch, a functional change follows:

It does not really make sense to decide on AMR mode filtering based on
whether an activation request came from the VTY:
a) BTS: There is no need to skip AMR mode filtering for the BTS config
   at all. There is always a BTS.
b) MSC: Instead of testing for a VTY origin of the request, rather skip
   the MSC AMR config filtering exactly when there is no conn associated
   with the lchan.

Move the bts filtering directly into mr_config_filter().

Related: SYS#5315 OS#4940 OS#3787 OS#3833
Change-Id: Ia7519d2fa9e7f0b61b222d27d077bde4660c40b9
---
M src/osmo-bsc/lchan_fsm.c
1 file changed, 14 insertions(+), 18 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/57/24357/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24357
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ia7519d2fa9e7f0b61b222d27d077bde4660c40b9
Gerrit-Change-Number: 24357
Gerrit-PatchSet: 3
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-MessageType: newpatchset

Change in osmo-bsc[master]: AMR config cleanup step 3: generate AMR LV on msg composition

[neels]

Hello Jenkins Builder, pespin,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bsc/+/24358

to look at the new patch set (#3).

Change subject: AMR config cleanup step 3: generate AMR LV on msg composition
..

AMR config cleanup step 3: generate AMR LV on msg composition

Firstly, do not store the encoded AMR length-value bits in gsm_lchan->*
before an activation/modify has actually succeeded.

And secondly, do not store the AMR LV structure in struct gsm_lchan at
all, but only generate the TLV exactly when a message is being composed.

In gsm48_multirate_config(), generate the LV directly to a msgb instead
of a static buffer first. gsm0408_test.c expected output verifies that
the generated LV bytes remain unchanged.

In lchan_mr_config(), introduce a target mr_conf argument, so that Chan
Act and Mode Modify may generate the filtered AMR config to different
locations (lchan->{activate,modify}.mr_conf_filtered).

Only after receiving an ACK for Activate/Modify, set
lchan->current_mr_conf from lchan->{activate,modify}.mr_conf_filtered.

Use the properly scoped lchan->activate.mr_conf_filtered for Chan Act,
lchan->modify.mr_conf_filtered for Mode Modify and
new_lchan->current_mr_conf for Handover Command as appropriate.

Related: SYS#5315 OS#4940 OS#3787 OS#3833
Change-Id: Ie57f9d0e3912632903d9740291225bfd1634ed47
---
M include/osmocom/bsc/gsm_04_08_rr.h
M include/osmocom/bsc/gsm_data.h
M src/osmo-bsc/abis_rsl.c
M src/osmo-bsc/gsm_04_08_rr.c
M src/osmo-bsc/lchan_fsm.c
M tests/gsm0408/gsm0408_test.c
6 files changed, 140 insertions(+), 100 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/58/24358/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24358
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ie57f9d0e3912632903d9740291225bfd1634ed47
Gerrit-Change-Number: 24358
Gerrit-PatchSet: 3
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-MessageType: newpatchset

Change in osmo-bsc[master]: add secondary RSL link for VAMOS (shadow TEI)

[neels]

Hello Jenkins Builder, fixeria,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bsc/+/24366

to look at the new patch set (#4).

Change subject: add secondary RSL link for VAMOS (shadow TEI)
..

add secondary RSL link for VAMOS (shadow TEI)

Set up a secondary sign_link for BTS that have BTS_FEAT_VAMOS enabled.

There are no secondary lchans being set up yet, but this is all that is
needed to send RSL commands for VAMOS secondary lchans.

Related: SYS#5315 OS#4940
Change-Id: Ic304924b017f4588f749268e99ed1326db4c9f47
---
M include/osmocom/bsc/bts_trx.h
M include/osmocom/bsc/gsm_data.h
M src/osmo-bsc/abis_rsl.c
M src/osmo-bsc/bsc_vty.c
M src/osmo-bsc/bts_ipaccess_nanobts.c
M src/osmo-bsc/bts_trx.c
M src/osmo-bsc/e1_config.c
7 files changed, 42 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/66/24366/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24366
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ic304924b017f4588f749268e99ed1326db4c9f47
Gerrit-Change-Number: 24366
Gerrit-PatchSet: 4
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-CC: pespin 
Gerrit-MessageType: newpatchset

Change in osmo-bsc[master]: implement CHANnel ACTIVate to VAMOS mode

[neels]

Hello Jenkins Builder, pespin,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bsc/+/24375

to look at the new patch set (#5).

Change subject: implement CHANnel ACTIVate to VAMOS mode
..

implement CHANnel ACTIVate to VAMOS mode

Related: SYS#5315 OS#4940
Change-Id: If3ac584e4223ef7656c7fedc3bf11df87e4309ec
---
M include/osmocom/bsc/gsm_data.h
M src/osmo-bsc/abis_rsl.c
M src/osmo-bsc/bsc_vty.c
M src/osmo-bsc/lchan_fsm.c
M tests/osmo-bsc.vty
5 files changed, 45 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/75/24375/5
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24375
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: If3ac584e4223ef7656c7fedc3bf11df87e4309ec
Gerrit-Change-Number: 24375
Gerrit-PatchSet: 5
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-MessageType: newpatchset

Change in osmo-bsc[master]: get_any_lchan(): reduce minor code dup

[neels]

Hello Jenkins Builder, dexter,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bsc/+/24385

to look at the new patch set (#5).

Change subject: get_any_lchan(): reduce minor code dup
..

get_any_lchan(): reduce minor code dup

Change-Id: I304a7333adc265e156f04b42a10bac6912f58ad2
---
M src/osmo-bsc/abis_rsl.c
1 file changed, 4 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/85/24385/5
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24385
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I304a7333adc265e156f04b42a10bac6912f58ad2
Gerrit-Change-Number: 24385
Gerrit-PatchSet: 5
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 
Gerrit-CC: pespin 
Gerrit-MessageType: newpatchset

Change in osmo-bsc[master]: potential segfault: vty chan act: do not set AMR bits for EFR

[neels]

neels has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/24393 )


Change subject: potential segfault: vty chan act: do not set AMR bits for EFR
..

potential segfault: vty chan act: do not set AMR bits for EFR

The amr_mode parameter may be passed as -1 and is directly used as an
array index in amr_modes[]. The AMR related switch case properly checks
against a -1 index, but the EFR does not -- and should not use s15_s0.

Change-Id: I9bae5b4fb8ab8c2002fe785e130dc9faeeda892c
---
M src/osmo-bsc/bsc_vty.c
1 file changed, 0 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/93/24393/1

diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c
index c482fb9..b964dbc 100644
--- a/src/osmo-bsc/bsc_vty.c
+++ b/src/osmo-bsc/bsc_vty.c
@@ -6078,7 +6078,6 @@
info = (struct lchan_activate_info) {
.activ_for = ACTIVATE_FOR_VTY,
.chan_mode = GSM48_CMODE_SPEECH_EFR,
-   .s15_s0 = amr_modes[amr_mode],
.requires_voice_stream = false,
};
} else if (!strcmp(codec_str, "amr")) {

--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24393
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I9bae5b4fb8ab8c2002fe785e130dc9faeeda892c
Gerrit-Change-Number: 24393
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-MessageType: newchange

Change in osmo-bsc[master]: cosmetic loop simplification in gsm48_multirate_config()

[neels]

neels has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/24394 )


Change subject: cosmetic loop simplification in gsm48_multirate_config()
..

cosmetic loop simplification in gsm48_multirate_config()

Change-Id: I52424ad6a0bf499fe040cf0a1de00e636a0a40fe
---
M src/osmo-bsc/gsm_04_08_rr.c
1 file changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/94/24394/1

diff --git a/src/osmo-bsc/gsm_04_08_rr.c b/src/osmo-bsc/gsm_04_08_rr.c
index 4eb6be1..9dc33af 100644
--- a/src/osmo-bsc/gsm_04_08_rr.c
+++ b/src/osmo-bsc/gsm_04_08_rr.c
@@ -417,13 +417,13 @@
uint8_t *data;

/* Check if modes for consistency (order and duplicates) */
-   for (i = 0; i < num_modes; i++) {
-   if (i > 0 && modes[i - 1].mode > modes[i].mode) {
+   for (i = 1; i < num_modes; i++) {
+   if (modes[i - 1].mode > modes[i].mode) {
LOGP(DRR, LOGL_ERROR,
 "BUG: Multirate codec with inconsistent config 
(mode order).\n");
return -EINVAL;
}
-   if (i > 0 && modes[i - 1].mode == modes[i].mode) {
+   if (modes[i - 1].mode == modes[i].mode) {
LOGP(DRR, LOGL_ERROR,
 "BUG: Multirate codec with inconsistent config 
(duplicate modes).\n");
return -EINVAL;

--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24394
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I52424ad6a0bf499fe040cf0a1de00e636a0a40fe
Gerrit-Change-Number: 24394
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-MessageType: newchange

Change in osmo-bsc[master]: RSL: set default TEI according to TRX number

[neels]

neels has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/24395 )


Change subject: RSL: set default TEI according to TRX number
..

RSL: set default TEI according to TRX number

Change-Id: I3c500f7a5afc9143d4ea7102ab96e52aeb67b4b6
---
M src/osmo-bsc/bts_trx.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/95/24395/1

diff --git a/src/osmo-bsc/bts_trx.c b/src/osmo-bsc/bts_trx.c
index de1662a..8ad0a6f 100644
--- a/src/osmo-bsc/bts_trx.c
+++ b/src/osmo-bsc/bts_trx.c
@@ -67,7 +67,7 @@
trx->bts = bts;
trx->nr = bts->num_trx++;

-   gsm_bts_trx_set_tei(trx, 0);
+   gsm_bts_trx_set_tei(trx, trx->nr);

trx->mo.fi = osmo_fsm_inst_alloc(&nm_rcarrier_fsm, trx, trx,
 LOGL_INFO, NULL);

--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24395
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I3c500f7a5afc9143d4ea7102ab96e52aeb67b4b6
Gerrit-Change-Number: 24395
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-MessageType: newchange

Change in osmo-bsc[master]: make sure channel mode and s15_s0 are updated only after an ACK

[neels]

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bsc/+/24352

to look at the new patch set (#4).

Change subject: make sure channel mode and s15_s0 are updated only after an ACK
..

make sure channel mode and s15_s0 are updated only after an ACK

I noticed during testing that an lchan used as TCH/F in fact still had
its channel mode set to Signalling -- because on Assignment, the Speech
mode used to be placed in the *previous* lchan and the new lchan was
never updated after the Activ ACK. This is unbearable confusion which I
complained about numerous times, so far mostly for cosmetic reasons. But
implementing re-assignment properly actually requires this to be cleaned
up.

Keep all volatile chan mode settings in lchan->activate.* or
lchan->modify.*, and only update lchan->* members when an ACK has been
received for those settings. So a failed request keeps a sane state.

Make sure that those settings are in fact updated in the proper lchan,
upon an ACK, so that subsequent re-assignment or mode-modify know the
accurate lchan state.

Related are upcoming patches that sort out the AMR multirate
configuration in a similar fashion, see
Iebac2dc26412d877e5364f90d6f2ed7a7952351e
Ia7519d2fa9e7f0b61b222d27d077bde4660c40b9
Ie57f9d0e3912632903d9740291225bfd1634ed47.

Related: SYS#5315 OS#4940 OS#3787 OS#3833
Change-Id: Ie0da36124d73efc28a8809b63d7c96e2167fc412
---
M include/osmocom/bsc/gsm_data.h
M src/osmo-bsc/abis_rsl.c
M src/osmo-bsc/assignment_fsm.c
M src/osmo-bsc/bsc_vty.c
M src/osmo-bsc/gsm_04_08_rr.c
M src/osmo-bsc/gsm_data.c
M src/osmo-bsc/handover_decision_2.c
M src/osmo-bsc/handover_fsm.c
M src/osmo-bsc/lchan_fsm.c
M src/osmo-bsc/lchan_rtp_fsm.c
M src/osmo-bsc/osmo_bsc_bssap.c
M src/osmo-bsc/osmo_bsc_lcls.c
M tests/handover/handover_test.c
13 files changed, 186 insertions(+), 163 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/52/24352/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24352
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ie0da36124d73efc28a8809b63d7c96e2167fc412
Gerrit-Change-Number: 24352
Gerrit-PatchSet: 4
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria 
Gerrit-CC: laforge 
Gerrit-MessageType: newpatchset

Change in osmo-bsc[master]: add secondary RSL link for VAMOS (shadow TEI)

[neels]

Hello Jenkins Builder, fixeria,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bsc/+/24366

to look at the new patch set (#6).

Change subject: add secondary RSL link for VAMOS (shadow TEI)
..

add secondary RSL link for VAMOS (shadow TEI)

Set up a secondary sign_link for BTS that have BTS_FEAT_VAMOS enabled.

There are no secondary lchans being set up yet, but this is all that is
needed to send RSL commands for VAMOS secondary lchans.

Related: SYS#5315 OS#4940
Change-Id: Ic304924b017f4588f749268e99ed1326db4c9f47
---
M include/osmocom/bsc/bts_trx.h
M include/osmocom/bsc/gsm_data.h
M src/osmo-bsc/abis_rsl.c
M src/osmo-bsc/bsc_vty.c
M src/osmo-bsc/bts_ipaccess_nanobts.c
M src/osmo-bsc/bts_trx.c
M src/osmo-bsc/e1_config.c
7 files changed, 42 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/66/24366/6
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24366
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ic304924b017f4588f749268e99ed1326db4c9f47
Gerrit-Change-Number: 24366
Gerrit-PatchSet: 6
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-CC: pespin 
Gerrit-MessageType: newpatchset

Change in osmo-ttcn3-hacks[master]: ns: add test configuration for SNS

[lynxis lazus]

lynxis lazus has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24397 )


Change subject: ns: add test configuration for SNS
..

ns: add test configuration for SNS

Change-Id: Idda139c7adda3fb1fec0643a98cd6cf8b436a89e
---
A ns/NS_Tests.sns.cfg
1 file changed, 34 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/97/24397/1

diff --git a/ns/NS_Tests.sns.cfg b/ns/NS_Tests.sns.cfg
new file mode 100644
index 000..23b616b
--- /dev/null
+++ b/ns/NS_Tests.sns.cfg
@@ -0,0 +1,34 @@
+[ORDERED_INCLUDE]
+# Common configuration, shared between test suites
+"../Common.cfg"
+# testsuite specific configuration, not expected to change
+"./NS_Tests.default"
+
+[LOGGING]
+
+[MODULE_PARAMETERS]
+NS_Tests.mp_nsconfig := {
+   nsei := 1234,
+   nsvc := {
+   {
+   provider := {
+   ip := {
+   address_family := AF_INET,
+   local_ip := "127.0.0.1",
+   local_udp_port := 22000,
+   remote_ip := "127.0.0.1",
+   remote_udp_port := 23000
+   }
+   },
+   nsvci := 1234
+   }
+   }
+}
+NS_Tests.mp_dialect := NS2_DIALECT_SNS
+
+[TESTPORT_PARAMETERS]
+
+[MAIN_CONTROLLER]
+
+[EXECUTE]
+NS_Tests.control

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24397
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Idda139c7adda3fb1fec0643a98cd6cf8b436a89e
Gerrit-Change-Number: 24397
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-MessageType: newchange

Change in osmo-ttcn3-hacks[master]: RAW_NS: add missing idx to as_rx_alive_tx_ack

[lynxis lazus]

lynxis lazus has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24398 )


Change subject: RAW_NS: add missing idx to as_rx_alive_tx_ack
..

RAW_NS: add missing idx to as_rx_alive_tx_ack

Without the index the message got send and received
via the wrong NSVC.

Change-Id: Ic5d1f4aa5e8a2373a4f46feef44e71b9688035c9
---
M library/RAW_NS.ttcnpp
1 file changed, 7 insertions(+), 7 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/98/24398/1

diff --git a/library/RAW_NS.ttcnpp b/library/RAW_NS.ttcnpp
index ff73348..93c43f0 100644
--- a/library/RAW_NS.ttcnpp
+++ b/library/RAW_NS.ttcnpp
@@ -100,7 +100,7 @@
var default d := activate(ax_rx_fail_on_any_ns());
alt {
[] NSCP[idx].receive(PDU_NS: exp_rx) -> value nrf { }
-   [g_handle_rx_alive] as_rx_alive_tx_ack();
+   [g_handle_rx_alive] as_rx_alive_tx_ack(idx := idx);
}
deactivate(d);
return nrf;
@@ -111,7 +111,7 @@
NSCP[idx].send(t_NS_ALIVE);
alt {
[] NSCP[idx].receive(t_NS_ALIVE_ACK);
-   [g_handle_rx_alive] as_rx_alive_tx_ack();
+   [g_handle_rx_alive] as_rx_alive_tx_ack(idx := idx);
[] NSCP[idx].receive { repeat; }
}
 }
@@ -125,7 +125,7 @@
[] NSCP[idx].receive(t_NS_ALIVE_ACK) {
setverdict(fail, "Received unexpected NS-ALIVE ACK");
}
-   [g_handle_rx_alive] as_rx_alive_tx_ack();
+   [g_handle_rx_alive] as_rx_alive_tx_ack(idx := idx);
[] NSCP[idx].receive { repeat; }
[] T.timeout {
setverdict(pass);
@@ -142,7 +142,7 @@
[] NSCP[idx].receive(ts_NS_RESET_ACK(g_nsconfig.nsvc[idx].nsvci, 
g_nsconfig.nsei)) {
setverdict(pass);
}
-   [g_handle_rx_alive] as_rx_alive_tx_ack();
+   [g_handle_rx_alive] as_rx_alive_tx_ack(idx := idx);
[] NSCP[idx].receive { repeat; }
[] T.timeout {
setverdict(fail, "Failed to receive a RESET ACK");
@@ -155,7 +155,7 @@
NSCP[idx].send(ts_NS_BLOCK(cause, g_nsconfig.nsvc[idx].nsvci));
alt {
[] NSCP[idx].receive(tr_NS_BLOCK_ACK(g_nsconfig.nsvc[idx].nsvci));
-   [g_handle_rx_alive] as_rx_alive_tx_ack();
+   [g_handle_rx_alive] as_rx_alive_tx_ack(idx := idx);
[] NSCP[idx].receive { repeat; }
}
 }
@@ -165,7 +165,7 @@
NSCP[idx].send(t_NS_UNBLOCK);
alt {
[] NSCP[idx].receive(t_NS_UNBLOCK_ACK);
-   [g_handle_rx_alive] as_rx_alive_tx_ack();
+   [g_handle_rx_alive] as_rx_alive_tx_ack(idx := idx);
[] NSCP[idx].receive { repeat; }
}
 }
@@ -205,7 +205,7 @@
[not exp_ack] T.timeout {
setverdict(pass);
}
-   [g_handle_rx_alive] as_rx_alive_tx_ack();
+   [g_handle_rx_alive] as_rx_alive_tx_ack(idx := idx);
[] NSCP[idx].receive { repeat; }
}
 }

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24398
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic5d1f4aa5e8a2373a4f46feef44e71b9688035c9
Gerrit-Change-Number: 24398
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-MessageType: newchange

Change in osmo-ttcn3-hacks[master]: RAW_NS: add support for an incoming SNS DELETE procedure

[lynxis lazus]

lynxis lazus has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24400 )


Change subject: RAW_NS: add support for an incoming SNS DELETE procedure
..

RAW_NS: add support for an incoming SNS DELETE procedure

Change-Id: Ia682522fe583a82e16a9c8008972f660f03243f7
---
M library/RAW_NS.ttcnpp
1 file changed, 22 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/00/24400/1

diff --git a/library/RAW_NS.ttcnpp b/library/RAW_NS.ttcnpp
index d601ccd..8f986e4 100644
--- a/library/RAW_NS.ttcnpp
+++ b/library/RAW_NS.ttcnpp
@@ -468,6 +468,28 @@
}
 }

+/* perform inbound SNS-DELETE procedure */
+function f_incoming_sns_del(integer idx_del, uint8_t w_sig := 1, uint8_t 
w_user := 1, integer idx := 0, template (omit) NsCause cause := omit)
+runs on RAW_NS_CT {
+   log("f_incoming_sns_del(idx=", idx, ")");
+   var PDU_NS rx;
+   var NSVCConfiguration nsvc_cfg := g_nsconfig.nsvc[idx_del];
+
+   if (nsvc_cfg.provider.ip.address_family == AF_INET) {
+   var template (omit) IP4_Elements v4_elem := { 
ts_SNS_IPv4(nsvc_cfg.provider.ip.remote_ip,
+
nsvc_cfg.provider.ip.remote_udp_port,
+w_sig, 
w_user) };
+   rx := f_ns_exp(tr_SNS_DEL(g_nsconfig.nsei, ?, omit, v4 := 
v4_elem), idx);
+   } else {
+   var template (omit) IP6_Elements v6_elem := { 
ts_SNS_IPv6(nsvc_cfg.provider.ip.remote_ip,
+
nsvc_cfg.provider.ip.remote_udp_port,
+w_sig, 
w_user) };
+   rx := f_ns_exp(tr_SNS_DEL(g_nsconfig.nsei, ?, omit, omit, 
v6_elem), idx);
+   }
+   NSCP[idx].send(ts_SNS_ACK(g_nsconfig.nsei, 
rx.pDU_SNS_Delete.transactionID));
+}
+
+
 function f_outgoing_sns_del(integer idx_del, uint8_t w_sig := 1, uint8_t 
w_user := 1, integer idx := 0)
 runs on RAW_NS_CT {
log("f_outgoing_sns_del(idx_del=", idx_del, ")");

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24400
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia682522fe583a82e16a9c8008972f660f03243f7
Gerrit-Change-Number: 24400
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-MessageType: newchange

Change in osmo-ttcn3-hacks[master]: RAW_NS/NS_Provider_IPL4: allow to use the new NSVC interface

[lynxis lazus]

lynxis lazus has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24401 )


Change subject: RAW_NS/NS_Provider_IPL4: allow to use the new NSVC interface
..

RAW_NS/NS_Provider_IPL4: allow to use the new NSVC interface

RAW_NS used previous a single TTCN3 port for a single UDP port
(source/listen side).
This has the limitation that only a single NSVC could be tested for a
local UDP port. However SNS tests require multiple NSVCs over a single UDP port.
NS_Provider_IPL4 already supports multiple NSVCs for the NS_Emulation.
Extend the support in NS_Provider_IPL4 to also allow RAW_NS to use
multiple NSVCs.

Change-Id: Iafd9310e04066958914201da0cbdcd563bd5c976
---
M library/NS_Provider_IPL4.ttcn
M library/RAW_NS.ttcnpp
2 files changed, 92 insertions(+), 19 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/01/24401/1

diff --git a/library/NS_Provider_IPL4.ttcn b/library/NS_Provider_IPL4.ttcn
index 774c08a..31ad351 100644
--- a/library/NS_Provider_IPL4.ttcn
+++ b/library/NS_Provider_IPL4.ttcn
@@ -28,6 +28,7 @@
 import from Misc_Helpers all;
 import from NS_Emulation all;
 import from NS_Types all;
+import from RAW_NS all;

 import from IPL4asp_Types all;
 import from IPL4asp_PortType all;
@@ -51,10 +52,12 @@
 type record PerNsvcState {
charstring remote_ip,
PortNumber remote_port,
-   NSVC_CT vc_nsvc
+   NSVC_CT vc_nsvc,
+   RAW_NS_CT vc_raw,
+   integer vc_raw_idx
 };

-signature NSPIP_add_nsvc(charstring remote_ip, PortNumber remote_port, NSVC_CT 
vc_nsvc);
+signature NSPIP_add_nsvc(charstring remote_ip, PortNumber remote_port, NSVC_CT 
vc_nsvc, RAW_NS_CT vc_raw, integer vc_raw_idx);
 signature NSPIP_del_nsvc(charstring remote_ip, PortNumber remote_port);

 type port NSPIP_PROC_PT procedure {
@@ -65,9 +68,13 @@
 private function f_nsvc_add(PerNsvcState nsvc) runs on NS_Provider_IPL4_CT
 {
for (var integer i := 0; i < sizeof(g_nsvc); i := i+1) {
-   if (g_nsvc[i].vc_nsvc == null) {
+   if (g_nsvc[i].vc_nsvc == null and g_nsvc[i].vc_raw == null) {
g_nsvc[i] := nsvc;
-   connect(self:NSVC[i], nsvc.vc_nsvc:NSCP);
+   if (g_nsvc[i].vc_nsvc != null) {
+   connect(self:NSVC[i], nsvc.vc_nsvc:NSCP);
+   } else {
+   connect(self:NSVC[i], 
nsvc.vc_raw:NSCP[nsvc.vc_raw_idx]);
+   }
NSVC[i].send(NS_Provider_Evt:{link_status := 
NS_PROV_LINK_STATUS_UP});
return;
}
@@ -78,16 +85,22 @@
 private function f_nsvc_del(PerNsvcState nsvc) runs on NS_Provider_IPL4_CT
 {
for (var integer i := 0; i < sizeof(g_nsvc); i := i+1) {
-   if (g_nsvc[i].vc_nsvc != null and
+   if ((g_nsvc[i].vc_nsvc != null or g_nsvc[i].vc_raw != null) and
g_nsvc[i].remote_ip == nsvc.remote_ip and
g_nsvc[i].remote_port == nsvc.remote_port) {
g_nsvc[i] := {
remote_ip := -,
remote_port := -,
-   vc_nsvc := null
+   vc_nsvc := null,
+   vc_raw := null,
+   vc_raw_idx := -1
}
NSVC[i].send(NS_Provider_Evt:{link_status := 
NS_PROV_LINK_STATUS_DOWN});
-   disconnect(self:NSVC[i], nsvc.vc_nsvc:NSCP);
+   if (nsvc.vc_nsvc != null) {
+   disconnect(self:NSVC[i], nsvc.vc_nsvc:NSCP);
+   } else {
+   disconnect(self:NSVC[i], 
nsvc.vc_raw:NSCP[nsvc.vc_raw_idx]);
+   }
return;
}
}
@@ -98,7 +111,7 @@
 runs on NS_Provider_IPL4_CT return integer
 {
for (var integer i := 0; i < sizeof(g_nsvc); i := i+1) {
-   if (g_nsvc[i].vc_nsvc != null and
+   if ((g_nsvc[i].vc_nsvc != null or g_nsvc[i].vc_raw != null) and
g_nsvc[i].remote_ip == remote_ip and g_nsvc[i].remote_port 
== remote_port) {
return i;
}
@@ -109,6 +122,7 @@
 function main(NSVCConfiguration config, NSConfiguration nsconfig, charstring 
id) runs on NS_Provider_IPL4_CT {
for (var integer i := 0; i < sizeof(g_nsvc); i := i+1) {
g_nsvc[i].vc_nsvc := null;
+   g_nsvc[i].vc_raw := null;
}

/* in order to support any number of NSVC on this endpoiint, we only 
bind the socket
@@ -134,6 +148,8 @@
var charstring remote_ip;
var PortNumber remote_port;
var NSVC_CT vc_nsvc;
+   var RAW_NS_CT vc_raw;
+   var integer vc_raw_idx;
var NS_C

Change in osmo-ttcn3-hacks[master]: NS_Provider_IPL4: fix typos in comments

[lynxis lazus]

lynxis lazus has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24396 )


Change subject: NS_Provider_IPL4: fix typos in comments
..

NS_Provider_IPL4: fix typos in comments

Change-Id: I05ccbf2eb7387bc8c1277a53591efbf503d46051
---
M library/NS_Provider_IPL4.ttcn
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/96/24396/1

diff --git a/library/NS_Provider_IPL4.ttcn b/library/NS_Provider_IPL4.ttcn
index 8145c13..774c08a 100644
--- a/library/NS_Provider_IPL4.ttcn
+++ b/library/NS_Provider_IPL4.ttcn
@@ -16,10 +16,10 @@
  *exchange data with the next higher level component, such as a NSVC_CT
  *or a RAW_NS_CT.
  *
- * 2) the enew "endpoint" mode, where one provider can host a number of 
different
+ * 2) the new "endpoint" mode, where one provider can host a number of 
different
  *NSVCs.  This is needed in most non-trivial IP-SNS scenarios.   The 'NSE'
  *port of this component is no longer used.  Instead, there is a NSVC port
- *array, one of which will be used for each NSVC.   The NSVCs are 
dynamically
+ *array, one of which will be used for each NSVC. The NSVCs are dynamically
  *added and removed via the PROC procedure port, controlled by NS_CT.
  */


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24396
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I05ccbf2eb7387bc8c1277a53591efbf503d46051
Gerrit-Change-Number: 24396
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-MessageType: newchange

Change in osmo-ttcn3-hacks[master]: RAW_NS: add support for an incoming SNS ADD procedure

[lynxis lazus]

lynxis lazus has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24399 )


Change subject: RAW_NS: add support for an incoming SNS ADD procedure
..

RAW_NS: add support for an incoming SNS ADD procedure

Change-Id: I937b654d377e189ee811145474683b638153179e
---
M library/RAW_NS.ttcnpp
1 file changed, 21 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/99/24399/1

diff --git a/library/RAW_NS.ttcnpp b/library/RAW_NS.ttcnpp
index 93c43f0..d601ccd 100644
--- a/library/RAW_NS.ttcnpp
+++ b/library/RAW_NS.ttcnpp
@@ -427,6 +427,27 @@
 }


+/* perform inbound SNS-ADD procedure */
+function f_incoming_sns_add(integer idx_add, uint8_t w_sig := 1, uint8_t 
w_user := 1, integer idx := 0, template (omit) NsCause cause := omit)
+runs on RAW_NS_CT {
+   log("f_incoming_sns_add(idx=", idx, ")");
+   var PDU_NS rx;
+   var NSVCConfiguration nsvc_cfg := g_nsconfig.nsvc[idx_add];
+
+   if (nsvc_cfg.provider.ip.address_family == AF_INET) {
+   var template (omit) IP4_Elements v4_elem := { 
ts_SNS_IPv4(nsvc_cfg.provider.ip.remote_ip,
+
nsvc_cfg.provider.ip.remote_udp_port,
+w_sig, 
w_user) };
+   rx := f_ns_exp(tr_SNS_ADD(g_nsconfig.nsei, ?, v4 := v4_elem), 
idx);
+   } else {
+   var template (omit) IP6_Elements v6_elem := { 
ts_SNS_IPv6(nsvc_cfg.provider.ip.remote_ip,
+
nsvc_cfg.provider.ip.remote_udp_port,
+w_sig, 
w_user) };
+   rx := f_ns_exp(tr_SNS_ADD(g_nsconfig.nsei, ?, omit, v6_elem), 
idx);
+   }
+   NSCP[idx].send(ts_SNS_ACK(g_nsconfig.nsei, 
rx.pDU_SNS_Add.transactionID));
+}
+
 function f_outgoing_sns_add(integer idx_add, uint8_t w_sig := 1, uint8_t 
w_user := 1, integer idx := 0, template (omit) NsCause cause := omit)
 runs on RAW_NS_CT {
log("f_outgoing_sns_add(idx_add=", idx_add, ")");

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24399
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I937b654d377e189ee811145474683b638153179e
Gerrit-Change-Number: 24399
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-MessageType: newchange

Change in osmo-ttcn3-hacks[master]: NS_Tests: add testcases for incoming SNS_ADD/DEL procedures

[lynxis lazus]

lynxis lazus has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24402 )


Change subject: NS_Tests: add testcases for incoming SNS_ADD/DEL procedures
..

NS_Tests: add testcases for incoming SNS_ADD/DEL procedures

Allow to test add and remove a bind via vty.

Change-Id: I98c04c083521ab38b58e8df9f1aee89445ab536d
---
M ns/NS_Tests.sns.cfg
M ns/NS_Tests.ttcn
M ns/osmo-ns.sns.cfg
3 files changed, 69 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/02/24402/1

diff --git a/ns/NS_Tests.sns.cfg b/ns/NS_Tests.sns.cfg
index 23b616b..5ee5e1a 100644
--- a/ns/NS_Tests.sns.cfg
+++ b/ns/NS_Tests.sns.cfg
@@ -21,6 +21,18 @@
}
},
nsvci := 1234
+   },
+   {
+   provider := {
+   ip := {
+   address_family := AF_INET,
+   local_ip := "127.0.0.1",
+   local_udp_port := 22000,
+   remote_ip := "127.0.0.1",
+   remote_udp_port := 23001
+   }
+   },
+   nsvci := 1235
}
}
 }
diff --git a/ns/NS_Tests.ttcn b/ns/NS_Tests.ttcn
index f69bbe0..58b2dda 100644
--- a/ns/NS_Tests.ttcn
+++ b/ns/NS_Tests.ttcn
@@ -44,6 +44,20 @@
}
},
nsvci := 97
+   },
+   {
+   provider := {
+   ip := {
+   address_family := AF_INET,
+   local_udp_port := 21000,
+   local_ip := "127.0.0.1",
+   remote_udp_port := 23001,
+   remote_ip := "127.0.0.1",
+   data_weight := 1,
+   signalling_weight := 1
+   }
+   },
+   nsvci := 98
}
}
};
@@ -58,6 +72,7 @@
f_vty_set_prompts(NSVTY);
f_vty_transceive(NSVTY, "enable");
f_vty_transceive(NSVTY, "nsvc nsei " & int2str(mp_nsconfig.nsei) & " 
force-unconfigured");
+   f_vty_config2(NSVTY, {"ns", "nse " & int2str(mp_nsconfig.nsei)}, "no 
ip-sns-bind local2");
 }

 /* ensure no matching message is received within 'tout' */
@@ -527,6 +542,42 @@
f_clean_ns_codec();
 }

+testcase TC_sns_bss_add() runs on RAW_Test_CT {
+   g_handle_rx_alive := true;
+   f_init_vty();
+   f_init_ns_codec(mp_nsconfig);
+   f_init_ns_codec(mp_nsconfig, 1);
+   f_incoming_sns_size();
+   f_incoming_sns_config();
+   f_outgoing_sns_config();
+   activate(as_rx_alive_tx_ack());
+   f_vty_config2(NSVTY, {"ns", "nse " & int2str(g_nsconfig.nsei)}, 
"ip-sns-bind local2");
+   f_incoming_sns_add(idx_add := 1);
+   as_rx_alive_tx_ack(oneshot := true, idx := 1);
+   setverdict(pass);
+   f_clean_ns_codec();
+}
+
+testcase TC_sns_bss_del() runs on RAW_Test_CT {
+   g_handle_rx_alive := true;
+   f_init_vty();
+   f_init_ns_codec(mp_nsconfig);
+   f_init_ns_codec(mp_nsconfig, 1);
+   f_incoming_sns_size();
+   f_incoming_sns_config();
+   f_outgoing_sns_config();
+   activate(as_rx_alive_tx_ack());
+   f_vty_config2(NSVTY, {"ns", "nse " & int2str(g_nsconfig.nsei)}, 
"ip-sns-bind local2");
+   f_incoming_sns_add(idx_add := 1);
+   as_rx_alive_tx_ack(oneshot := true, idx := 1);
+
+   /* delete the endpoint */
+   f_vty_config2(NSVTY, {"ns", "nse " & int2str(g_nsconfig.nsei)}, "no 
ip-sns-bind local2");
+   f_incoming_sns_del(idx_del := 1);
+   setverdict(pass);
+   f_clean_ns_codec();
+}
+
 control {
if (mp_dialect == NS2_DIALECT_STATIC_RESETBLOCK or mp_dialect == 
NS2_DIALECT_IPACCESS) {
execute( TC_tx_reset() );
@@ -574,6 +625,8 @@
execute( TC_sns_config_success() );
execute( TC_sns_bss_change_weight() );
execute( TC_sns_bss_change_weight_timeout() );
+   execute( TC_sns_bss_add() );
+   execute( TC_sns_bss_del() );
}
 }

diff --git a/ns/osmo-ns.sns.cfg b/ns/osmo-ns.sns.cfg
index 58d306e..b342305 100644
--- a/ns/osmo-ns.sns.cfg
+++ b/ns/osmo-ns.sns.cfg
@@ -92,6 +92,10 @@
   listen 127.0.0.1 23000
   ip-sns signalling-weight 2 data-weight 2
   accept-ipaccess
+ bind udp local2
+  listen 127

Change in osmo-bsc[master]: replace ts_*_for_each_lchan() with ts_for_n_lchans()

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/24372 )

Change subject: replace ts_*_for_each_lchan() with ts_for_n_lchans()
..


Patch Set 6: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24372
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ib2c6baf73a81ba371143ba5adc912aef6f79238d
Gerrit-Change-Number: 24372
Gerrit-PatchSet: 6
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 25 May 2021 15:50:05 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: eliminate lchan->rsl_cmode

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/24354 )

Change subject: eliminate lchan->rsl_cmode
..


Patch Set 4: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24354
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I1c167b22bb6638a929488d093bde0f1a5fb227ad
Gerrit-Change-Number: 24354
Gerrit-PatchSet: 4
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 25 May 2021 15:51:01 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: AMR config cleanup step 2: filter modes also for VTY

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/24357 )

Change subject: AMR config cleanup step 2: filter modes also for VTY
..


Patch Set 4: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/24357/2/src/osmo-bsc/lchan_fsm.c
File src/osmo-bsc/lchan_fsm.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/24357/2/src/osmo-bsc/lchan_fsm.c@575
PS2, Line 575:  /* If activated for VTY, there may not be a conn indicating an 
MSC AMR configuration. */
> the user entered some VTY command on telnet which ended up 
> activating/modifying/re-assigning this lc […]
I just wanted to make sure I understood correctly. I wouldn't say "for" and 
"from" mean exactly the same, they are more like indicating opposite 
causalities here imho :) "from vty" means to me it was triggered through the 
VTY, so the VTY originated it, while "for VTY", seems like targeting or aiming 
at the VTY somehow, hence resolving into some VTY action afterwards, which is a 
bit weird imho. Not important though.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24357
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ia7519d2fa9e7f0b61b222d27d077bde4660c40b9
Gerrit-Change-Number: 24357
Gerrit-PatchSet: 4
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 25 May 2021 15:55:12 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: neels 
Comment-In-Reply-To: pespin 
Gerrit-MessageType: comment

Change in osmo-bsc[master]: AMR config cleanup step 1: split lchan_mr_config()

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/24356 )

Change subject: AMR config cleanup step 1: split lchan_mr_config()
..


Patch Set 4: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/24356/4/src/osmo-bsc/lchan_fsm.c
File src/osmo-bsc/lchan_fsm.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/24356/4/src/osmo-bsc/lchan_fsm.c@499
PS4, Line 499:  LOG_LCHAN(lchan_for_logging, LOGL_ERROR,
lol, this new naming looks like a political attempt to have everyone happy.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24356
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Iebac2dc26412d877e5364f90d6f2ed7a7952351e
Gerrit-Change-Number: 24356
Gerrit-PatchSet: 4
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-CC: laforge 
Gerrit-Comment-Date: Tue, 25 May 2021 15:56:39 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: AMR config cleanup step 3: generate AMR LV on msg composition

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/24358 )

Change subject: AMR config cleanup step 3: generate AMR LV on msg composition
..


Patch Set 4: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24358
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ie57f9d0e3912632903d9740291225bfd1634ed47
Gerrit-Change-Number: 24358
Gerrit-PatchSet: 4
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 25 May 2021 15:57:08 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: implement CHANnel ACTIVate to VAMOS mode

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/24375 )

Change subject: implement CHANnel ACTIVate to VAMOS mode
..


Patch Set 7: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24375
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: If3ac584e4223ef7656c7fedc3bf11df87e4309ec
Gerrit-Change-Number: 24375
Gerrit-PatchSet: 7
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 25 May 2021 15:57:55 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: get_any_lchan(): reduce minor code dup

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/24385 )

Change subject: get_any_lchan(): reduce minor code dup
..


Patch Set 7: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24385
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I304a7333adc265e156f04b42a10bac6912f58ad2
Gerrit-Change-Number: 24385
Gerrit-PatchSet: 7
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 25 May 2021 15:58:23 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: potential segfault: vty chan act: do not set AMR bits for EFR

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/24393 )

Change subject: potential segfault: vty chan act: do not set AMR bits for EFR
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24393
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I9bae5b4fb8ab8c2002fe785e130dc9faeeda892c
Gerrit-Change-Number: 24393
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 25 May 2021 15:58:45 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-ttcn3-hacks[master]: MGCP_Test: avoid crash in latest (TC_one_crcx_loopback_rtp_implicit)

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24392 )

Change subject: MGCP_Test: avoid crash in latest 
(TC_one_crcx_loopback_rtp_implicit)
..


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24392/1/mgw/MGCP_Test.ttcn
File mgw/MGCP_Test.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24392/1/mgw/MGCP_Test.ttcn@2477
PS1, Line 2477: execute(TC_one_crcx_loopback_rtp_implicit());
Please ass a comment here about the crash, otherwise people will add new tests 
after it.



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/24392
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I25abf30f8c49e580c46e7a61e887bd0add9a4cd4
Gerrit-Change-Number: 24392
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 25 May 2021 15:59:38 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: RSL: set default TEI according to TRX number

[pespin]

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/24395 )

Change subject: RSL: set default TEI according to TRX number
..


Patch Set 3: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24395
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I3c500f7a5afc9143d4ea7102ab96e52aeb67b4b6
Gerrit-Change-Number: 24395
Gerrit-PatchSet: 3
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 25 May 2021 15:59:57 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment