Change in osmo-pcu[master]: fix: handle NULL return of as_dl_tbf() and as_ul_tbf()
neels has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-pcu/+/25182 )
Change subject: fix: handle NULL return of as_dl_tbf() and as_ul_tbf()
..
fix: handle NULL return of as_dl_tbf() and as_ul_tbf()
Go through all callers of as_dl_tbf() and as_ul_tbf(), and make sure
they can handle the possible NULL return value.
OS#5205 reports a NULL deref crash of osmo-pcu at pdch.cpp:525. The
immediate cause is that as_dl_tbf() may well return NULL, which this
caller does not handle and instead dereferences immediately.
This is a code path that apparently assumes that a DL-TBF should always
be present. The higher level cause for the NULL DL-TBF has not been
identified.
Related: OS#5205 SYS#5561
Change-Id: I8ce21be6836549b47a606c00b793d6f005964c5c
---
M src/bts.cpp
M src/gprs_ms.c
M src/gprs_rlcmac_sched.cpp
M src/gprs_rlcmac_ts_alloc.cpp
M src/pdch.cpp
M src/tbf.cpp
6 files changed, 55 insertions(+), 35 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/82/25182/1
diff --git a/src/bts.cpp b/src/bts.cpp
index ee6b915..80e6e83 100644
--- a/src/bts.cpp
+++ b/src/bts.cpp
@@ -1157,14 +1157,13 @@
{
struct gprs_rlcmac_pdch *pdch = >trx[trx_no].pdch[ts];
struct pdch_ulc_node *poll = pdch_ulc_get_node(pdch->ulc, fn);
- struct gprs_rlcmac_ul_tbf *tbf;
+ struct gprs_rlcmac_ul_tbf *ul_tbf = as_ul_tbf(poll->tbf_poll.poll_tbf);
if (!poll || poll->type !=PDCH_ULC_NODE_TBF_POLL ||
poll->tbf_poll.poll_tbf->direction != GPRS_RLCMAC_UL_TBF)
LOGP(DL1IF, LOGL_DEBUG, "[%s] update TA = %u ignored due to "
"unknown UL TBF on TRX = %d, TS = %d, FN = %d\n",
p, ta, trx_no, ts, fn);
- else {
- tbf = as_ul_tbf(poll->tbf_poll.poll_tbf);
+ else if (ul_tbf) {
/* we need to distinguish TA information provided by L1
* from PH-DATA-IND and PHY-RA-IND so that we can properly
* update TA for given TBF
diff --git a/src/gprs_ms.c b/src/gprs_ms.c
index 0d6be4d..b9d130a 100644
--- a/src/gprs_ms.c
+++ b/src/gprs_ms.c
@@ -335,9 +335,13 @@
void ms_attach_tbf(struct GprsMs *ms, struct gprs_rlcmac_tbf *tbf)
{
- if (tbf_direction(tbf) == GPRS_RLCMAC_DL_TBF)
+ struct gprs_rlcmac_dl_tbf *dl_tbf = as_dl_tbf(tbf);
+ struct gprs_rlcmac_ul_tbf *ul_tbf = as_ul_tbf(tbf);
+ /* cannot be both DL and UL */
+ OSMO_ASSERT(!(dl_tbf && ul_tbf));
+ if (dl_tbf)
ms_attach_dl_tbf(ms, as_dl_tbf(tbf));
- else
+ if (ul_tbf)
ms_attach_ul_tbf(ms, as_ul_tbf(tbf));
}
diff --git a/src/gprs_rlcmac_sched.cpp b/src/gprs_rlcmac_sched.cpp
index 2adf1f3..b99ef9e 100644
--- a/src/gprs_rlcmac_sched.cpp
+++ b/src/gprs_rlcmac_sched.cpp
@@ -50,7 +50,8 @@
llist_for_each_entry(pos, >trx->ul_tbfs, list) {
ul_tbf = as_ul_tbf((struct gprs_rlcmac_tbf *)pos->entry);
- OSMO_ASSERT(ul_tbf);
+ if (!ul_tbf)
+ continue;
/* this trx, this ts */
if (!ul_tbf->is_control_ts(pdch->ts_no))
continue;
@@ -69,7 +70,8 @@
}
llist_for_each_entry(pos, >trx->dl_tbfs, list) {
dl_tbf = as_dl_tbf((struct gprs_rlcmac_tbf *)pos->entry);
- OSMO_ASSERT(dl_tbf);
+ if (!dl_tbf)
+ continue;
/* this trx, this ts */
if (!dl_tbf->is_control_ts(pdch->ts_no))
continue;
@@ -459,6 +461,7 @@
"single block allocation at FN=%d\n", fn, block_nr,
sba->fn);
/* else, check uplink resource for polling */
} else if ((poll_tbf = pdch_ulc_get_tbf_poll(pdch->ulc, poll_fn))) {
+ struct gprs_rlcmac_ul_tbf *ul_tbf;
LOGPDCH(pdch, DRLCMACSCHED, LOGL_DEBUG, "Received RTS for PDCH:
FN=%d "
"block_nr=%d scheduling free USF for polling at FN=%d
of %s\n",
fn, block_nr, poll_fn, tbf_name(poll_tbf));
@@ -466,8 +469,9 @@
* let's set its USF in the DL msg. This is not really needed,
* but it helps understand better the flow when looking at
* pcaps. */
- if (poll_tbf->direction == GPRS_RLCMAC_UL_TBF &&
as_ul_tbf(poll_tbf)->m_usf[ts] != USF_INVALID)
- usf_tbf = as_ul_tbf(poll_tbf);
+ ul_tbf = as_ul_tbf(poll_tbf);
+ if (ul_tbf && poll_tbf->direction == GPRS_RLCMAC_UL_TBF &&
ul_tbf->m_usf[ts] != USF_INVALID)
+ usf_tbf = ul_tbf;
/* else, search for uplink tbf */
} else if ((usf_tbf = sched_select_uplink(pdch, require_gprs_only))) {
LOGPDCH(pdch, DRLCMACSCHED, LOGL_DEBUG, "Received RTS for PDCH:
FN=%d "
diff --git
Change in osmo-ci[master]: repo-install-test: osmo-pcap-server: !latest
osmith has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ci/+/25181 )
Change subject: repo-install-test: osmo-pcap-server: !latest
..
repo-install-test: osmo-pcap-server: !latest
Disable osmo-pcap-server for latest again, as the port is still
conflicting there with osmo-bts.
Fixes: 7ca9c4 ("repo-install-test: clear SERVICES_NIGHTLY list")
Related: OS#5203
Change-Id: I711e0e13c3e3af30407b85fd10aca9446f2b94ba
---
M scripts/repo-install-test/run-inside-docker.sh
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/81/25181/1
diff --git a/scripts/repo-install-test/run-inside-docker.sh
b/scripts/repo-install-test/run-inside-docker.sh
index da0d27c..e47b4ec 100755
--- a/scripts/repo-install-test/run-inside-docker.sh
+++ b/scripts/repo-install-test/run-inside-docker.sh
@@ -22,15 +22,15 @@
osmo-mgw
osmo-msc
osmo-pcap-client
- osmo-pcap-server
osmo-pcu
osmo-sgsn
osmo-sip-connector
osmo-stp
"
# Services working in nightly, but not yet in latest
-# * (currently none)
+# * osmo-pcap-server 0.2.0: VTY port in default config conflicts with osmo-bts
(OS#5203)
SERVICES_NIGHTLY="
+ osmo-pcap-server
"
distro_obsdir() {
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/25181
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I711e0e13c3e3af30407b85fd10aca9446f2b94ba
Gerrit-Change-Number: 25181
Gerrit-PatchSet: 1
Gerrit-Owner: osmith
Gerrit-MessageType: newchange
Change in osmo-ttcn3-hacks[master]: osmo-mgw.cfg: add missing statsd configuration
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25180 ) Change subject: osmo-mgw.cfg: add missing statsd configuration .. osmo-mgw.cfg: add missing statsd configuration The recently added test TC_dlcx_wildcarded depends on statsd information from osmo-mgw but in the osmo-mgw configuration no statsd is configured. Change-Id: I35e07a6b1853234559ab4d7e044f3899e8d0a3e8 Related: SYS#5535 --- M mgw/osmo-mgw.cfg 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/80/25180/1 diff --git a/mgw/osmo-mgw.cfg b/mgw/osmo-mgw.cfg index 76525bc..8428cd3 100644 --- a/mgw/osmo-mgw.cfg +++ b/mgw/osmo-mgw.cfg @@ -17,6 +17,16 @@ no login bind 127.0.0.1 ! +stats interval 0 +stats reporter statsd + prefix TTCN3 + level global + remote-ip 127.0.0.1 + remote-port 8125 + flush-period 1 + mtu 1024 + enable +! mgcp bind ip 127.0.0.1 bind port 2427 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25180 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I35e07a6b1853234559ab4d7e044f3899e8d0a3e8 Gerrit-Change-Number: 25180 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange
Change in docker-playground[master]: osmo-mgw: add missing statsd configuration
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/25179 ) Change subject: osmo-mgw: add missing statsd configuration .. osmo-mgw: add missing statsd configuration The recently added test TC_dlcx_wildcarded depends on statsd information from osmo-mgw but in the osmo-mgw configuration no statsd is configured. Change-Id: Ic4f0c57f56fe400bdb9a1948917f0eeb1d7e7427 Related: SYS#5535 --- M ttcn3-mgw-test/osmo-mgw.cfg 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/79/25179/1 diff --git a/ttcn3-mgw-test/osmo-mgw.cfg b/ttcn3-mgw-test/osmo-mgw.cfg index f8e1a0d..13c477a 100644 --- a/ttcn3-mgw-test/osmo-mgw.cfg +++ b/ttcn3-mgw-test/osmo-mgw.cfg @@ -23,6 +23,16 @@ no login bind 0.0.0.0 ! +stats interval 0 +stats reporter statsd + prefix TTCN3 + level global + remote-ip 172.18.4.181 + remote-port 8125 + flush-period 1 + mtu 1024 + enable +! e1_input e1_line 0 driver ipa ! -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/25179 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ic4f0c57f56fe400bdb9a1948917f0eeb1d7e7427 Gerrit-Change-Number: 25179 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange
Change in simtrace2[master]: contrib: allow manually forcing bulk simtrace dissection
Hoernchen has uploaded this change for review. (
https://gerrit.osmocom.org/c/simtrace2/+/25178 )
Change subject: contrib: allow manually forcing bulk simtrace dissection
..
contrib: allow manually forcing bulk simtrace dissection
Change-Id: I5fcfe3c221b87b02e21c857ac51d0392c3b4de3c
---
M contrib/simtrace.lua
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/78/25178/1
diff --git a/contrib/simtrace.lua b/contrib/simtrace.lua
index 5a273d2..1ca1b0b 100644
--- a/contrib/simtrace.lua
+++ b/contrib/simtrace.lua
@@ -88,6 +88,5 @@
local usb_product_dissectors = DissectorTable.get("usb.product")
usb_product_dissectors:add(0x1d50616d, usb_simtrace_protocol)
usb_product_dissectors:add(0x1d50616e, usb_simtrace_protocol)
-
--- DissectorTable.get("usb.bulk"):add(0x, usb_simtrace_protocol)
+DissectorTable.get("usb.bulk"):add(0x, usb_simtrace_protocol)
end
--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/25178
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I5fcfe3c221b87b02e21c857ac51d0392c3b4de3c
Gerrit-Change-Number: 25178
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen
Gerrit-MessageType: newchange
Change in libosmocore[master]: gprs_ns2: dont use llist_for_each when freeing an element
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25147 ) Change subject: gprs_ns2: dont use llist_for_each when freeing an element .. Patch Set 1: (1 comment) I have used this exact technique for the same reasons. Freeing an item often has effects in FSMs / triggers cleanup actions which then tear down other instances as well. (re dexter: FSM events get processed inline immediately, not on the next select().) llist_for_each_entry_safe() is not actually safe: if the *next* entry gets deallocated from cleanup actions, then it falls on its face the same way llist_for_each_entry() does. Getting the first entry of an llist is always safe, so it is the simplest and safest way to clear a list. The alternatives would be to implement an *actually* safe llist_for_each_entry, e.g. to compare against active iterators on each llist_del(); would be quite complex, and would not match the thin simple nature of the llist implementation. For me personally, seeing this code is perfectly clear and I wouldn't ask for spreading comments explaining the same concept on every such clearing loop. But would be nicer to have a single function like gprs_ns2_clear() instead of duplicating the loop all over. (Then there could also be a single comment in that function, explaining for the other reviewers...) https://gerrit.osmocom.org/c/libosmocore/+/25147/1/src/gb/gprs_ns2.c File src/gb/gprs_ns2.c: https://gerrit.osmocom.org/c/libosmocore/+/25147/1/src/gb/gprs_ns2.c@1490 PS1, Line 1490: looks like moving this free loop is fixing a separate issue? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25147 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I902557fb6e56e6588728a46e43a9cbe3215d5c68 Gerrit-Change-Number: 25147 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-CC: laforge Gerrit-CC: neels Gerrit-Comment-Date: Mon, 09 Aug 2021 12:30:29 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-mgw[master]: mgcp_protocol: get rid of policy_cb and change_cb
dexter has submitted this change. (
https://gerrit.osmocom.org/c/osmo-mgw/+/25126 )
Change subject: mgcp_protocol: get rid of policy_cb and change_cb
..
mgcp_protocol: get rid of policy_cb and change_cb
The two callback functions policy_cb and change_cb are essentially dead
code. They also make the code more difficult to read and understand.
Lets remove them.
Change-Id: I19f67db1c56473f47338b56114f6bbae8981d067
---
M include/osmocom/mgcp/mgcp.h
M include/osmocom/mgcp/mgcp_protocol.h
M src/libosmo-mgcp/mgcp_protocol.c
M tests/mgcp/mgcp_test.c
4 files changed, 17 insertions(+), 110 deletions(-)
Approvals:
Jenkins Builder: Verified
osmith: Looks good to me, but someone else must approve
daniel: Looks good to me, approved
diff --git a/include/osmocom/mgcp/mgcp.h b/include/osmocom/mgcp/mgcp.h
index 29963cc..b3f2eb5 100644
--- a/include/osmocom/mgcp/mgcp.h
+++ b/include/osmocom/mgcp/mgcp.h
@@ -62,8 +62,6 @@
#define MGCP_POLICY_REJECT 5
#define MGCP_POLICY_DEFER 6
-typedef int (*mgcp_change)(struct mgcp_endpoint *endp, int state);
-typedef int (*mgcp_policy)(struct mgcp_endpoint *endp, int state, const char
*transaction_id);
typedef int (*mgcp_reset)(struct mgcp_trunk *cfg);
typedef int (*mgcp_rqnt)(struct mgcp_endpoint *endp, char tone);
@@ -147,8 +145,6 @@
int force_ptime;
- mgcp_change change_cb;
- mgcp_policy policy_cb;
mgcp_reset reset_cb;
mgcp_rqnt rqnt_cb;
void *data;
diff --git a/include/osmocom/mgcp/mgcp_protocol.h
b/include/osmocom/mgcp/mgcp_protocol.h
index 7ab283d..df134ab 100644
--- a/include/osmocom/mgcp/mgcp_protocol.h
+++ b/include/osmocom/mgcp/mgcp_protocol.h
@@ -16,6 +16,8 @@
int pkt_period_max; /* time in ms */
};
+char *mgcp_debug_get_last_endpoint_name(void);
+
char *get_lco_identifier(const char *options);
int check_local_cx_options(void *ctx, const char *options);
diff --git a/src/libosmo-mgcp/mgcp_protocol.c b/src/libosmo-mgcp/mgcp_protocol.c
index e69c00f..b7368b2 100644
--- a/src/libosmo-mgcp/mgcp_protocol.c
+++ b/src/libosmo-mgcp/mgcp_protocol.c
@@ -46,6 +46,16 @@
#include
#include
+/* Contains the last successfully resolved endpoint name. This variable is used
+ * for the unit-tests to verify that the endpoint was correctly resolved. */
+static char debug_last_endpoint_name[MGCP_ENDPOINT_MAXLEN];
+
+/* Called from unit-tests only */
+char *mgcp_debug_get_last_endpoint_name(void)
+{
+ return debug_last_endpoint_name;
+}
+
/* A combination of LOGPENDP and LOGPTRUNK that automatically falls back to
* LOGPTRUNK when the endp parameter is NULL */
#define LOGPEPTR(endp, trunk, cat, level, fmt, args...) \
@@ -328,6 +338,8 @@
struct msgb *resp = NULL;
char *data;
+ debug_last_endpoint_name[0] = '\0';
+
/* Count all messages, even incorect ones */
rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs,
MGCP_GENERAL_RX_MSGS_TOTAL));
@@ -395,6 +407,7 @@
return create_err_response(NULL, -rq.mgcp_cause,
rq.name, pdata.trans);
}
} else {
+ osmo_strlcpy(debug_last_endpoint_name, rq.endp->name,
sizeof(debug_last_endpoint_name));
rq.trunk = rq.endp->trunk;
rq.mgcp_cause = 0;
@@ -1050,32 +1063,8 @@
goto error2;
}
- /* policy CB */
- if (pdata->cfg->policy_cb) {
- int rc;
- rc = pdata->cfg->policy_cb(endp, MGCP_ENDP_CRCX, pdata->trans);
- switch (rc) {
- case MGCP_POLICY_REJECT:
- LOGPCONN(_conn, DLMGCP, LOGL_NOTICE,
-"CRCX: CRCX rejected by policy\n");
- mgcp_endp_release(endp);
- rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs,
MGCP_CRCX_FAIL_REJECTED_BY_POLICY));
- return create_err_response(endp, 400, "CRCX",
pdata->trans);
- break;
- case MGCP_POLICY_DEFER:
- /* stop processing */
- return NULL;
- break;
- case MGCP_POLICY_CONT:
- /* just continue */
- break;
- }
- }
-
LOGPCONN(conn->conn, DLMGCP, LOGL_DEBUG,
"CRCX: Creating connection: port: %u\n", conn->end.local_port);
- if (pdata->cfg->change_cb)
- pdata->cfg->change_cb(endp, MGCP_ENDP_CRCX);
/* Send dummy packet, see also comments in mgcp_keepalive_timer_cb() */
OSMO_ASSERT(trunk->keepalive_interval >= MGCP_KEEPALIVE_ONCE);
@@ -1290,40 +1279,11 @@
goto error3;
}
-
- /* policy CB */
- if (pdata->cfg->policy_cb) {
- int rc;
- rc = pdata->cfg->policy_cb(endp, MGCP_ENDP_MDCX, pdata->trans);
- switch (rc) {
- case
Change in osmo-mgw[master]: mgcp_ratectr: do not set talloc destructor on library allocated item
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25103 ) Change subject: mgcp_ratectr: do not set talloc destructor on library allocated item .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25103 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ifc5091e9f95cc721e58d1eb2e55b97102c497706 Gerrit-Change-Number: 25103 Gerrit-PatchSet: 7 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 09 Aug 2021 12:11:36 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-mgw[master]: mgcp_client: refactor function init_socket
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25125 ) Change subject: mgcp_client: refactor function init_socket .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25125 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ifd65511daa92fbe610f52da1c4c3b6a7c761d890 Gerrit-Change-Number: 25125 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 09 Aug 2021 12:09:53 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-mgw[master]: mgcp_client: allow to reset endpoints on startup
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25008 ) Change subject: mgcp_client: allow to reset endpoints on startup .. Patch Set 13: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25008 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I47e7ff858d5067b46d52329be5f362ff61c0dff8 Gerrit-Change-Number: 25008 Gerrit-PatchSet: 13 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-CC: neels Gerrit-Comment-Date: Mon, 09 Aug 2021 12:05:43 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: pcu: test counter bts.0.pch.requests
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25158 ) Change subject: pcu: test counter bts.0.pch.requests .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25158 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I366b5c699708a69ca0e9d8c74319a241a46ed842 Gerrit-Change-Number: 25158 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 09 Aug 2021 12:04:51 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: gprs_ns2: dont use llist_for_each when freeing an element
dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/25147 )
Change subject: gprs_ns2: dont use llist_for_each when freeing an element
..
Patch Set 1: Code-Review+1
(1 comment)
The new way of freeing all the nsvc elements looks a bit strange to me.
I think the event will not be processed while llist_for_each() is running, but
maybe in the next select loop cycle.
In any case, I think this patch would not break anything but I do not really
understand what it is fixing exactly.
https://gerrit.osmocom.org/c/libosmocore/+/25147/1/src/gb/gprs_ns2_sns.c
File src/gb/gprs_ns2_sns.c:
https://gerrit.osmocom.org/c/libosmocore/+/25147/1/src/gb/gprs_ns2_sns.c@1584
PS1, Line 1584: while (!llist_empty(>nsvc)) {
is this because gprs_ns2_free_nsvc() may free multiple nsvc from the list so
that it is impossible to iterate the list normally? You always check if the
list is empty, then you get the first entry to free it and then again. A
comment why this has to be handled this way might be helpful.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25147
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I902557fb6e56e6588728a46e43a9cbe3215d5c68
Gerrit-Change-Number: 25147
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter
Gerrit-CC: laforge
Gerrit-Comment-Date: Mon, 09 Aug 2021 12:01:49 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Change in simtrace2[master]: contrib/jenkins.sh: build ngff_Cardem dfu bootloader
laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/25176 ) Change subject: contrib/jenkins.sh: build ngff_Cardem dfu bootloader .. contrib/jenkins.sh: build ngff_Cardem dfu bootloader It does fit with some compiler versions, while others overflow the bl region, so just reduce the trace level a bit to make it fits all the time. Change-Id: I168a847da8dfc585aaeef0030f95fc225a713147 --- M contrib/jenkins.sh 1 file changed, 7 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 46482f2..5f68cf1 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -32,7 +32,7 @@ BUILDS+="qmod/dfu qmod/cardem " BUILDS+="owhw/dfu owhw/cardem " BUILDS+="octsimtest/cardem " -BUILDS+="ngff_cardem/cardem " +BUILDS+="ngff_cardem/dfu ngff_cardem/cardem " cd $TOPDIR/firmware for build in $BUILDS; do @@ -40,7 +40,12 @@ app=`echo $build | cut -d "/" -f 2` echo echo "=== $board / $app START ==" - make BOARD="$board" APP="$app" + # reduce the trace level so the bl fits + if [ $board = "ngff_cardem" ] && [ $app = "dfu" ]; then + make BOARD="$board" APP="$app" TRACE_LEVEL=2 + else + make BOARD="$board" APP="$app" + fi echo "=== $board / $app RES:$? ==" done -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/25176 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I168a847da8dfc585aaeef0030f95fc225a713147 Gerrit-Change-Number: 25176 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged
Change in simtrace2[master]: contrib/jenkins.sh: build ngff_Cardem dfu bootloader
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/25176 ) Change subject: contrib/jenkins.sh: build ngff_Cardem dfu bootloader .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/25176 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I168a847da8dfc585aaeef0030f95fc225a713147 Gerrit-Change-Number: 25176 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 09 Aug 2021 11:50:54 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: gprs_ns2: add correct filename/linenr to sns failed log message
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25149 ) Change subject: gprs_ns2: add correct filename/linenr to sns failed log message .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25149 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I117eaf8340fca50cb14392a3f05ea8feac1af3ed Gerrit-Change-Number: 25149 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 09 Aug 2021 11:41:05 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: ns2: mark TC_sns_bss_all_signalling_nsvcs_failed as broken
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25141 ) Change subject: ns2: mark TC_sns_bss_all_signalling_nsvcs_failed as broken .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25141 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ice79a038b0b8df9e69232bb24b2f2b18b3632758 Gerrit-Change-Number: 25141 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 09 Aug 2021 11:36:46 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-mgw[master]: mgcp_ratectr: do not set talloc destructor on library allocated item
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25103 ) Change subject: mgcp_ratectr: do not set talloc destructor on library allocated item .. Patch Set 7: (2 comments) https://gerrit.osmocom.org/c/osmo-mgw/+/25103/6/src/libosmo-mgcp/mgcp_ratectr.c File src/libosmo-mgcp/mgcp_ratectr.c: https://gerrit.osmocom.org/c/osmo-mgw/+/25103/6/src/libosmo-mgcp/mgcp_ratectr.c@178 PS6, Line 178: * \returns 0 on success, -EINVAL on failure. */ > returns nothing :) Done https://gerrit.osmocom.org/c/osmo-mgw/+/25103/6/src/libosmo-mgcp/mgcp_ratectr.c@243 PS6, Line 243: > (added on purpose?) Done -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25103 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ifc5091e9f95cc721e58d1eb2e55b97102c497706 Gerrit-Change-Number: 25103 Gerrit-PatchSet: 7 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 09 Aug 2021 11:30:00 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith Gerrit-MessageType: comment
Change in osmo-mgw[master]: mgcp_ratectr: do not set talloc destructor on library allocated item
Hello osmith, Jenkins Builder, laforge, pespin, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/25103 to look at the new patch set (#7). Change subject: mgcp_ratectr: do not set talloc destructor on library allocated item .. mgcp_ratectr: do not set talloc destructor on library allocated item The rate counter and stats item groups, which are allocated in mgcp_ratectr.c are freed using a talloc destructor that is set in the context of the item we just allocated using the stats / rate counter API functions. When we do that, we risk overwriting an already existing talloc destructor. Lets instead implement own free functions and set those as talloc_destructor from above (trunk and MGCP config) Change-Id: Ifc5091e9f95cc721e58d1eb2e55b97102c497706 Related: OS#5201 --- M include/osmocom/mgcp/mgcp_ratectr.h M src/libosmo-mgcp/mgcp_protocol.c M src/libosmo-mgcp/mgcp_ratectr.c M src/libosmo-mgcp/mgcp_trunk.c 4 files changed, 80 insertions(+), 21 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/03/25103/7 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25103 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ifc5091e9f95cc721e58d1eb2e55b97102c497706 Gerrit-Change-Number: 25103 Gerrit-PatchSet: 7 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmo-mgw[master]: mgcp_client: refactor function init_socket
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25125 ) Change subject: mgcp_client: refactor function init_socket .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-mgw/+/25125/1/src/libosmo-mgcp-client/mgcp_client.c File src/libosmo-mgcp-client/mgcp_client.c: https://gerrit.osmocom.org/c/osmo-mgw/+/25125/1/src/libosmo-mgcp-client/mgcp_client.c@835 PS1, Line 835: mgcp->actual.local_port++; > I'd wrap this in […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25125 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ifd65511daa92fbe610f52da1c4c3b6a7c761d890 Gerrit-Change-Number: 25125 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 09 Aug 2021 11:15:42 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith Gerrit-MessageType: comment
Change in osmo-mgw[master]: mgcp_client: refactor function init_socket
Hello osmith, Jenkins Builder, pespin, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/25125 to look at the new patch set (#2). Change subject: mgcp_client: refactor function init_socket .. mgcp_client: refactor function init_socket The function init_socket has an arbitrary retry count when opening the socket. After each retry the local port is incremented by one. The intention behind this is to find a useable local port in case the configured port is used by another process. The maximum number of retrys is hardcoded. The upcomming MGW pooling patch requires to set the maximum retry count. Change-Id: Ifd65511daa92fbe610f52da1c4c3b6a7c761d890 Related: SYS#5091 --- M src/libosmo-mgcp-client/mgcp_client.c 1 file changed, 23 insertions(+), 17 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/25/25125/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25125 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ifd65511daa92fbe610f52da1c4c3b6a7c761d890 Gerrit-Change-Number: 25125 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in simtrace2[master]: --amed
Hoernchen has abandoned this change. ( https://gerrit.osmocom.org/c/simtrace2/+/25177 ) Change subject: --amed .. Abandoned -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/25177 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I4754ad8acf05a4268d15b076b42056ca160f288f Gerrit-Change-Number: 25177 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: abandon
Change in simtrace2[master]: contrib/jenkins.sh: build ngff_Cardem dfu bootloader
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/simtrace2/+/25176 to look at the new patch set (#4). Change subject: contrib/jenkins.sh: build ngff_Cardem dfu bootloader .. contrib/jenkins.sh: build ngff_Cardem dfu bootloader It does fit with some compiler versions, while others overflow the bl region, so just reduce the trace level a bit to make it fits all the time. Change-Id: I168a847da8dfc585aaeef0030f95fc225a713147 --- M contrib/jenkins.sh 1 file changed, 7 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/76/25176/4 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/25176 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I168a847da8dfc585aaeef0030f95fc225a713147 Gerrit-Change-Number: 25176 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset
Change in simtrace2[master]: --amed
Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/25177 ) Change subject: --amed .. --amed Change-Id: I4754ad8acf05a4268d15b076b42056ca160f288f --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/77/25177/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index ed09c9f..5f68cf1 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -41,7 +41,7 @@ echo echo "=== $board / $app START ==" # reduce the trace level so the bl fits - if [ board = "ngff_cardem" ] && [ app = "dfu" ]; then + if [ $board = "ngff_cardem" ] && [ $app = "dfu" ]; then make BOARD="$board" APP="$app" TRACE_LEVEL=2 else make BOARD="$board" APP="$app" -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/25177 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I4754ad8acf05a4268d15b076b42056ca160f288f Gerrit-Change-Number: 25177 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-MessageType: newchange
Change in osmo-mgw[master]: mgcp_protocol: get rid of policy_cb and change_cb
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25126 ) Change subject: mgcp_protocol: get rid of policy_cb and change_cb .. Patch Set 2: Code-Review+2 > Patch Set 2: > > Has this ever been used anywhere? I can see the old osmo-bsc_nat installed a > custom policy_cb (bsc_mgcp_policy_cb in bsc_mgcp_utils.c). > See SYS#5560 which sounds like osmo-bsc_nat will be used in the future so > maybe we'll need a policy_cb then. We just discused this and came to the conclusion that it can be removed. The old osmo-bsc_nat had the mgw built-in and used policy_cb to use osmux on the backhaul. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25126 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I19f67db1c56473f47338b56114f6bbae8981d067 Gerrit-Change-Number: 25126 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 09 Aug 2021 10:41:13 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in simtrace2[master]: contrib/jenkins.sh: build ngff_Cardem dfu bootloader
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/simtrace2/+/25176 to look at the new patch set (#3). Change subject: contrib/jenkins.sh: build ngff_Cardem dfu bootloader .. contrib/jenkins.sh: build ngff_Cardem dfu bootloader It does fit with some compiler versions, while others overflow the bl region, so just reduce the trace level a bit to make it fits all the time. Change-Id: I168a847da8dfc585aaeef0030f95fc225a713147 --- M contrib/jenkins.sh 1 file changed, 7 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/76/25176/3 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/25176 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I168a847da8dfc585aaeef0030f95fc225a713147 Gerrit-Change-Number: 25176 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset
Change in simtrace2[master]: contrib/jenkins.sh: build ngff_Cardem dfu bootloader
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/simtrace2/+/25176 to look at the new patch set (#2). Change subject: contrib/jenkins.sh: build ngff_Cardem dfu bootloader .. contrib/jenkins.sh: build ngff_Cardem dfu bootloader It does fit with some compiler versions, while others overflow the bl region, so just reduce the trace level a bit to make it fits all the time. Change-Id: I168a847da8dfc585aaeef0030f95fc225a713147 --- M contrib/jenkins.sh 1 file changed, 7 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/76/25176/2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/25176 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I168a847da8dfc585aaeef0030f95fc225a713147 Gerrit-Change-Number: 25176 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset
Change in simtrace2[master]: contrib/jenkins.sh: build ngff_Cardem dfu bootloader
Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/25176 ) Change subject: contrib/jenkins.sh: build ngff_Cardem dfu bootloader .. contrib/jenkins.sh: build ngff_Cardem dfu bootloader It does fit with some compiler versions, while others overflow the bl region, so just reduce the trace level a bit to make it fits all the time. Change-Id: I168a847da8dfc585aaeef0030f95fc225a713147 --- M contrib/jenkins.sh 1 file changed, 7 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/76/25176/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 46482f2..ed09c9f 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -32,7 +32,7 @@ BUILDS+="qmod/dfu qmod/cardem " BUILDS+="owhw/dfu owhw/cardem " BUILDS+="octsimtest/cardem " -BUILDS+="ngff_cardem/cardem " +BUILDS+="ngff_cardem/dfu ngff_cardem/cardem " cd $TOPDIR/firmware for build in $BUILDS; do @@ -40,7 +40,12 @@ app=`echo $build | cut -d "/" -f 2` echo echo "=== $board / $app START ==" - make BOARD="$board" APP="$app" + # reduce the trace level so the bl fits + if [ board = "ngff_cardem" ] && [ app = "dfu" ]; then + make BOARD="$board" APP="$app" TRACE_LEVEL=2 + else + make BOARD="$board" APP="$app" + fi echo "=== $board / $app RES:$? ==" done -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/25176 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I168a847da8dfc585aaeef0030f95fc225a713147 Gerrit-Change-Number: 25176 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-MessageType: newchange
Change in osmo-mgw[master]: mgcp_client: allow to reset endpoints on startup
dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-mgw/+/25008 )
Change subject: mgcp_client: allow to reset endpoints on startup
..
Patch Set 13:
(2 comments)
https://gerrit.osmocom.org/c/osmo-mgw/+/25008/12/src/libosmo-mgcp-client/mgcp_client.c
File src/libosmo-mgcp-client/mgcp_client.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/25008/12/src/libosmo-mgcp-client/mgcp_client.c@836
PS12, Line 836: void
> static void
Done
https://gerrit.osmocom.org/c/osmo-mgw/+/25008/11/src/libosmo-mgcp-client/mgcp_client_vty.c
File src/libosmo-mgcp-client/mgcp_client_vty.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/25008/11/src/libosmo-mgcp-client/mgcp_client_vty.c@208
PS11, Line 208: llist_for_each_entry(reset_ep,
_mgcp_client_conf->reset_epnames, list) {
> llist_for_each_entry_safe could be used here to remove the endpoint inside
> the loop. […]
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25008
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I47e7ff858d5067b46d52329be5f362ff61c0dff8
Gerrit-Change-Number: 25008
Gerrit-PatchSet: 13
Gerrit-Owner: dexter
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel
Gerrit-Reviewer: laforge
Gerrit-Reviewer: osmith
Gerrit-Reviewer: pespin
Gerrit-CC: neels
Gerrit-Comment-Date: Mon, 09 Aug 2021 09:44:39 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: daniel
Gerrit-MessageType: comment
Change in osmo-mgw[master]: mgcp_client: allow to reset endpoints on startup
Hello osmith, Jenkins Builder, laforge, pespin, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/25008 to look at the new patch set (#13). Change subject: mgcp_client: allow to reset endpoints on startup .. mgcp_client: allow to reset endpoints on startup Depending on the usecase of osmo_mpcg_client it may be helpful to send a DLCX to certain endpoints. Usually this would be a wildcarded endpoint that resets the entire trunk to drop lingering RTP flows which may still present after a restart/crash, but it might be also a group of specific endpoints. The user may specify an arbitrary amount of endpoints where the mgcp client will send a DLCX to. It does not matter if the endpoints are wildcarded or not. Change-Id: I47e7ff858d5067b46d52329be5f362ff61c0dff8 Related: SYS#5535 --- M TODO-RELEASE M include/osmocom/mgcp_client/mgcp_client.h M src/libosmo-mgcp-client/mgcp_client.c M src/libosmo-mgcp-client/mgcp_client_vty.c 4 files changed, 134 insertions(+), 20 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/08/25008/13 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25008 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I47e7ff858d5067b46d52329be5f362ff61c0dff8 Gerrit-Change-Number: 25008 Gerrit-PatchSet: 13 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-CC: neels Gerrit-MessageType: newpatchset
Change in osmo-bsc[master]: osmo_bsc_main: remove unused commandline option -l
dexter has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/25122 )
Change subject: osmo_bsc_main: remove unused commandline option -l
..
osmo_bsc_main: remove unused commandline option -l
The option -l ("The local address of the MGCP") is still present in the
commandline help and the manual, but it is used nowhere and osmo-bsc
exists when it is used. Lets remove it.
Change-Id: Ia295f4414e0d6e78b388c0c72f1a5b8df8bc3d7e
---
M doc/manuals/chapters/running.adoc
M src/osmo-bsc/osmo_bsc_main.c
2 files changed, 0 insertions(+), 4 deletions(-)
Approvals:
Jenkins Builder: Verified
osmith: Looks good to me, but someone else must approve
daniel: Looks good to me, approved
diff --git a/doc/manuals/chapters/running.adoc
b/doc/manuals/chapters/running.adoc
index 3e48c4a..327e0bd 100644
--- a/doc/manuals/chapters/running.adoc
+++ b/doc/manuals/chapters/running.adoc
@@ -35,8 +35,6 @@
Set the global log level for logging to stderr. This has mostly
been deprecated by VTY based logging configuration, see
<> for more information.
-*-l, --local='IP'*::
- Specify the local IP address of the OsmoBSC-MGCP
*-r, --rf-ctl 'RFCTL'*::
Offer a Unix domain socket for RF control at the path/filename
'RFCTL' in the file system.
diff --git a/src/osmo-bsc/osmo_bsc_main.c b/src/osmo-bsc/osmo_bsc_main.c
index 2a6c501..b97c7a1 100644
--- a/src/osmo-bsc/osmo_bsc_main.c
+++ b/src/osmo-bsc/osmo_bsc_main.c
@@ -104,7 +104,6 @@
printf(" -T --timestampPrint a timestamp in the debug
output.\n");
printf(" -V --version Print the version of
OsmoBSC.\n");
printf(" -c --config-file filename The config file to use.\n");
- printf(" -l --local IP The local address of the
MGCP.\n");
printf(" -e --log-level number Set a global loglevel.\n");
printf(" -r --rf-ctl NAME A unix domain socket to listen
for cmds.\n");
printf(" -t --testmode A special mode to provoke
failures at the MSC.\n");
@@ -152,7 +151,6 @@
{"disable-color", 0, 0, 's'},
{"timestamp", 0, 0, 'T'},
{"version", 0, 0, 'V' },
- {"local", 1, 0, 'l'},
{"log-level", 1, 0, 'e'},
{"rf-ctl", 1, 0, 'r'},
{"testmode", 0, 0, 't'},
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25122
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ia295f4414e0d6e78b388c0c72f1a5b8df8bc3d7e
Gerrit-Change-Number: 25122
Gerrit-PatchSet: 1
Gerrit-Owner: dexter
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel
Gerrit-Reviewer: dexter
Gerrit-Reviewer: neels
Gerrit-Reviewer: osmith
Gerrit-MessageType: merged
Change in osmo-bsc[master]: running.adoc: explain mgw reset-endpoint VTY setting
dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25118 ) Change subject: running.adoc: explain mgw reset-endpoint VTY setting .. running.adoc: explain mgw reset-endpoint VTY setting When OsmoBSC is restarted, it does not automatically clear the calls on the MGW. However, this is an important part of the configuration to avoid trouble with resource leakage on the MGW, so lets make (especially novice) users aware of that option. Change-Id: I19c499c6ac83d7f9437b18b372977f6f2d518adf Depends: osmo-mgw I47e7ff858d5067b46d52329be5f362ff61c0dff8 Related: SYS#5535 --- M doc/manuals/chapters/running.adoc 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/doc/manuals/chapters/running.adoc b/doc/manuals/chapters/running.adoc index ae177a9..3e48c4a 100644 --- a/doc/manuals/chapters/running.adoc +++ b/doc/manuals/chapters/running.adoc @@ -139,7 +139,12 @@ msc 0 mgw remote-ip 10.9.8.7 mgw remote-port 2427 + mgw reset-endpoint rtpbridge/* <1> +<1> The 'reset-endpoint' setting instructs the OsmoBSC to send a wildcarded +DLCX to the media gateway. This helps to clear lingering calls from the +media gateway when the OsmoBSC is restarted. + Configure Lb to connect to an SMLC -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25118 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I19c499c6ac83d7f9437b18b372977f6f2d518adf Gerrit-Change-Number: 25118 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged
Change in osmo-ttcn3-hacks[master]: pcap-client: set VTY port to 4227
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25174 ) Change subject: pcap-client: set VTY port to 4227 .. pcap-client: set VTY port to 4227 Adjust the VTY port to the new default, 4227, in case somebody uses the configs from this repository instead of the ones from docker-playground.git (where it is also adjusted). Depends: docker-playground I6d45340429925fe5e98cc4e597a01ef51e8322ae Change-Id: I50af5d0c0930b9bc906a8b909910bc38f025648e --- M pcap-client/OPCAP_CLIENT_Tests.default M pcap-client/osmo-pcap-client.cfg 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/pcap-client/OPCAP_CLIENT_Tests.default b/pcap-client/OPCAP_CLIENT_Tests.default index 2b1677b..3fd3ac8 100644 --- a/pcap-client/OPCAP_CLIENT_Tests.default +++ b/pcap-client/OPCAP_CLIENT_Tests.default @@ -4,7 +4,7 @@ [TESTPORT_PARAMETERS] *.VTY.CTRL_MODE := "client" *.VTY.CTRL_HOSTNAME := "127.0.0.1" -*.VTY.CTRL_PORTNUM := "4237" +*.VTY.CTRL_PORTNUM := "4227" *.VTY.CTRL_LOGIN_SKIPPED := "yes" *.VTY.CTRL_DETECT_SERVER_DISCONNECTED := "yes" *.VTY.CTRL_READMODE := "buffered" diff --git a/pcap-client/osmo-pcap-client.cfg b/pcap-client/osmo-pcap-client.cfg index 89f1801..09201fc 100644 --- a/pcap-client/osmo-pcap-client.cfg +++ b/pcap-client/osmo-pcap-client.cfg @@ -5,6 +5,7 @@ ! line vty no login + bind 127.0.0.1 4227 ! client pcap device lo -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25174 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I50af5d0c0930b9bc906a8b909910bc38f025648e Gerrit-Change-Number: 25174 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: merged
Change in docker-playground[master]: ttcn3-pcap-client-test: set vty port to 4227
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/25173 ) Change subject: ttcn3-pcap-client-test: set vty port to 4227 .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/25173 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I6d45340429925fe5e98cc4e597a01ef51e8322ae Gerrit-Change-Number: 25173 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Mon, 09 Aug 2021 08:57:56 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in docker-playground[master]: ttcn3-pcap-client-test: set vty port to 4227
osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/25173 ) Change subject: ttcn3-pcap-client-test: set vty port to 4227 .. ttcn3-pcap-client-test: set vty port to 4227 After moving the default VTY port for osmo-pcap-client from 4237 to 4227, it is different in nightly and latest. Configure the SUT and testsuite to use 4227 for both nightly and latest. Related: OS#5203 Change-Id: I6d45340429925fe5e98cc4e597a01ef51e8322ae --- M ttcn3-pcap-client-test/OPCAP_CLIENT_Tests.cfg M ttcn3-pcap-client-test/osmo-pcap-client.cfg 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved osmith: Verified diff --git a/ttcn3-pcap-client-test/OPCAP_CLIENT_Tests.cfg b/ttcn3-pcap-client-test/OPCAP_CLIENT_Tests.cfg index e76fc4f..9946c5c 100644 --- a/ttcn3-pcap-client-test/OPCAP_CLIENT_Tests.cfg +++ b/ttcn3-pcap-client-test/OPCAP_CLIENT_Tests.cfg @@ -8,6 +8,7 @@ [TESTPORT_PARAMETERS] *.VTY.CTRL_HOSTNAME := "172.18.31.20"; +*.VTY.CTRL_PORTNUM := "4227" [MODULE_PARAMETERS] OPCAP_CLIENT_Tests.mp_local_opcap_ip := "172.18.31.10"; diff --git a/ttcn3-pcap-client-test/osmo-pcap-client.cfg b/ttcn3-pcap-client-test/osmo-pcap-client.cfg index 7394c96..5628b9e 100644 --- a/ttcn3-pcap-client-test/osmo-pcap-client.cfg +++ b/ttcn3-pcap-client-test/osmo-pcap-client.cfg @@ -5,7 +5,7 @@ ! line vty no login - bind 0.0.0.0 + bind 0.0.0.0 4227 ! client pcap device eth0 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/25173 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I6d45340429925fe5e98cc4e597a01ef51e8322ae Gerrit-Change-Number: 25173 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: merged
Change in docker-playground[master]: ttcn3-pcap-client-test: set vty port to 4227
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/25173 ) Change subject: ttcn3-pcap-client-test: set vty port to 4227 .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/25173 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I6d45340429925fe5e98cc4e597a01ef51e8322ae Gerrit-Change-Number: 25173 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 09 Aug 2021 08:53:30 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: pcap-client: set VTY port to 4227
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25174 ) Change subject: pcap-client: set VTY port to 4227 .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25174 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I50af5d0c0930b9bc906a8b909910bc38f025648e Gerrit-Change-Number: 25174 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 09 Aug 2021 08:53:17 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: vty/ports: prepare formatting for a long define
osmith has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25133 ) Change subject: vty/ports: prepare formatting for a long define .. vty/ports: prepare formatting for a long define Add one more tab between the define and the port number, to prepare for longer defines in the next patch. Related: OS#5203 Change-Id: I46655e33651814f41a1fea93406a83334d2fc529 --- M include/osmocom/vty/ports.h 1 file changed, 22 insertions(+), 22 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/include/osmocom/vty/ports.h b/include/osmocom/vty/ports.h index b3550d1..cca2dd3 100644 --- a/include/osmocom/vty/ports.h +++ b/include/osmocom/vty/ports.h @@ -9,32 +9,32 @@ #pragma once /* 4236 used by control interface */ -#define OSMO_VTY_PORT_TRX 4237 +#define OSMO_VTY_PORT_TRX 4237 /* 4238 used by osmo-bts control interface */ -#define OSMO_VTY_PORT_STP 4239 -#define OSMO_VTY_PORT_PCU 4240/* also: osmo_pcap_client */ -#define OSMO_VTY_PORT_BTS 4241/* also: osmo_pcap_server */ -#define OSMO_VTY_PORT_NITB_BSC 4242 -#define OSMO_VTY_PORT_BSC_MGCP 4243 -#define OSMO_VTY_PORT_MGW OSMO_VTY_PORT_BSC_MGCP -#define OSMO_VTY_PORT_BSC_NAT 4244 -#define OSMO_VTY_PORT_SGSN 4245 -#define OSMO_VTY_PORT_GBPROXY 4246 -#define OSMO_VTY_PORT_BB 4247 +#define OSMO_VTY_PORT_STP 4239 +#define OSMO_VTY_PORT_PCU 4240/* also: osmo_pcap_client */ +#define OSMO_VTY_PORT_BTS 4241/* also: osmo_pcap_server */ +#define OSMO_VTY_PORT_NITB_BSC 4242 +#define OSMO_VTY_PORT_BSC_MGCP 4243 +#define OSMO_VTY_PORT_MGW OSMO_VTY_PORT_BSC_MGCP +#define OSMO_VTY_PORT_BSC_NAT 4244 +#define OSMO_VTY_PORT_SGSN 4245 +#define OSMO_VTY_PORT_GBPROXY 4246 +#define OSMO_VTY_PORT_BB 4247 /* 4249-4251 used by control interface */ -#define OSMO_VTY_PORT_BTSMGR 4252 -#define OSMO_VTY_PORT_GTPHUB 4253 -#define OSMO_VTY_PORT_MSC 4254 +#define OSMO_VTY_PORT_BTSMGR 4252 +#define OSMO_VTY_PORT_GTPHUB 4253 +#define OSMO_VTY_PORT_MSC 4254 /* 4255 used by control interface */ -#define OSMO_VTY_PORT_MNCC_SIP 4256 +#define OSMO_VTY_PORT_MNCC_SIP 4256 /* 4257 used by control interface */ -#define OSMO_VTY_PORT_HLR 4258 +#define OSMO_VTY_PORT_HLR 4258 /* 4259 used by control interface */ -#define OSMO_VTY_PORT_GGSN 4260 -#define OSMO_VTY_PORT_HNBGW4261 +#define OSMO_VTY_PORT_GGSN 4260 +#define OSMO_VTY_PORT_HNBGW4261 /* 4262-4263 used by control interface */ -#define OSMO_VTY_PORT_CBC 4264 -#define OSMO_VTY_PORT_UECUPS 4268 -#define OSMO_VTY_PORT_E1D 4269 -#define OSMO_VTY_PORT_SMLC 4271 +#define OSMO_VTY_PORT_CBC 4264 +#define OSMO_VTY_PORT_UECUPS 4268 +#define OSMO_VTY_PORT_E1D 4269 +#define OSMO_VTY_PORT_SMLC 4271 /* When adding/changing port numbers, keep docs and wiki in sync. See above. */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25133 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I46655e33651814f41a1fea93406a83334d2fc529 Gerrit-Change-Number: 25133 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: merged
Change in libosmocore[master]: vty/ports: move pcap server/client ports
osmith has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25128 ) Change subject: vty/ports: move pcap server/client ports .. vty/ports: move pcap server/client ports Resolve conflict with other Osmocom software by moving ports: osmo-pcap-client 4237 -> 4227 osmo-pcap-server 4238 -> 4228 Remove wrong previous comments that claimed 4240 and 4241 were used. Related: OS#5203 Related: osmo-pcap I3b18b1fbbca2799f868f28104e2f5d513f93d46c Change-Id: I098f211370bba61995ce424ab64029bdd4c49e2d --- M include/osmocom/vty/ports.h 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/include/osmocom/vty/ports.h b/include/osmocom/vty/ports.h index cca2dd3..580e642 100644 --- a/include/osmocom/vty/ports.h +++ b/include/osmocom/vty/ports.h @@ -8,12 +8,14 @@ #pragma once +#define OSMO_VTY_PORT_PCAP_CLIENT 4227 +#define OSMO_VTY_PORT_PCAP_SERVER 4228 /* 4236 used by control interface */ #define OSMO_VTY_PORT_TRX 4237 /* 4238 used by osmo-bts control interface */ #define OSMO_VTY_PORT_STP 4239 -#define OSMO_VTY_PORT_PCU 4240/* also: osmo_pcap_client */ -#define OSMO_VTY_PORT_BTS 4241/* also: osmo_pcap_server */ +#define OSMO_VTY_PORT_PCU 4240 +#define OSMO_VTY_PORT_BTS 4241 #define OSMO_VTY_PORT_NITB_BSC 4242 #define OSMO_VTY_PORT_BSC_MGCP 4243 #define OSMO_VTY_PORT_MGW OSMO_VTY_PORT_BSC_MGCP -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25128 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I098f211370bba61995ce424ab64029bdd4c49e2d Gerrit-Change-Number: 25128 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: merged
Change in libosmocore[master]: vty/ports: move pcap server/client ports
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25128 ) Change subject: vty/ports: move pcap server/client ports .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25128 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I098f211370bba61995ce424ab64029bdd4c49e2d Gerrit-Change-Number: 25128 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 09 Aug 2021 08:52:14 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: vty/ports: prepare formatting for a long define
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25133 ) Change subject: vty/ports: prepare formatting for a long define .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25133 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I46655e33651814f41a1fea93406a83334d2fc529 Gerrit-Change-Number: 25133 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 09 Aug 2021 08:51:59 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: ns2: mark TC_sns_bss_all_signalling_nsvcs_failed as broken
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25141 ) Change subject: ns2: mark TC_sns_bss_all_signalling_nsvcs_failed as broken .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25141 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ice79a038b0b8df9e69232bb24b2f2b18b3632758 Gerrit-Change-Number: 25141 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 09 Aug 2021 08:51:14 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: ns2: add TC_sns_sgsn_add to test SNS ADD on the SGSN side
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25140 ) Change subject: ns2: add TC_sns_sgsn_add to test SNS ADD on the SGSN side .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25140 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7474ea81ee905fb9fffb6c413b312e0b3547ea14 Gerrit-Change-Number: 25140 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 09 Aug 2021 08:50:52 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-dev[master]: ttcn3.sh: get_program_repo: add osmo-pcap-*
osmith has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-dev/+/25175 ) Change subject: ttcn3.sh: get_program_repo: add osmo-pcap-* .. ttcn3.sh: get_program_repo: add osmo-pcap-* Make "ttcn3.sh osmo-pcap-client" work. Change-Id: I61f1b9f8ce9157f34cefad093b7ae7d445834961 --- M ttcn3/ttcn3.sh 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/75/25175/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/25175 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I61f1b9f8ce9157f34cefad093b7ae7d445834961 Gerrit-Change-Number: 25175 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-MessageType: newpatchset
Change in osmo-dev[master]: ttcn3.sh: get_program_repo: add osmo-pcap-client
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-dev/+/25175 ) Change subject: ttcn3.sh: get_program_repo: add osmo-pcap-client .. ttcn3.sh: get_program_repo: add osmo-pcap-client Make "ttcn3.sh osmo-pcap-client" work. Change-Id: I61f1b9f8ce9157f34cefad093b7ae7d445834961 --- M ttcn3/ttcn3.sh 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/75/25175/1 diff --git a/ttcn3/ttcn3.sh b/ttcn3/ttcn3.sh index 07a7adc..9b2b1f4 100755 --- a/ttcn3/ttcn3.sh +++ b/ttcn3/ttcn3.sh @@ -71,6 +71,7 @@ case "$1" in fake_trx.py) echo "osmocom-bb" ;; osmo-bts-*) echo "osmo-bts" ;; + osmo-pcap-client) echo "osmo-pcap" ;; osmo-stp) echo "libosmo-sccp" ;; trxcon) echo "osmocom-bb" ;; virtphy) echo "osmocom-bb" ;; -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/25175 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I61f1b9f8ce9157f34cefad093b7ae7d445834961 Gerrit-Change-Number: 25175 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange
Change in osmo-ttcn3-hacks[master]: pcap-client: set VTY port to 4227
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25174 ) Change subject: pcap-client: set VTY port to 4227 .. pcap-client: set VTY port to 4227 Adjust the VTY port to the new default, 4227, in case somebody uses the configs from this repository instead of the ones from docker-playground.git (where it is also adjusted). Depends: docker-playground I6d45340429925fe5e98cc4e597a01ef51e8322ae Change-Id: I50af5d0c0930b9bc906a8b909910bc38f025648e --- M pcap-client/OPCAP_CLIENT_Tests.default M pcap-client/osmo-pcap-client.cfg 2 files changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/74/25174/1 diff --git a/pcap-client/OPCAP_CLIENT_Tests.default b/pcap-client/OPCAP_CLIENT_Tests.default index 2b1677b..3fd3ac8 100644 --- a/pcap-client/OPCAP_CLIENT_Tests.default +++ b/pcap-client/OPCAP_CLIENT_Tests.default @@ -4,7 +4,7 @@ [TESTPORT_PARAMETERS] *.VTY.CTRL_MODE := "client" *.VTY.CTRL_HOSTNAME := "127.0.0.1" -*.VTY.CTRL_PORTNUM := "4237" +*.VTY.CTRL_PORTNUM := "4227" *.VTY.CTRL_LOGIN_SKIPPED := "yes" *.VTY.CTRL_DETECT_SERVER_DISCONNECTED := "yes" *.VTY.CTRL_READMODE := "buffered" diff --git a/pcap-client/osmo-pcap-client.cfg b/pcap-client/osmo-pcap-client.cfg index 89f1801..09201fc 100644 --- a/pcap-client/osmo-pcap-client.cfg +++ b/pcap-client/osmo-pcap-client.cfg @@ -5,6 +5,7 @@ ! line vty no login + bind 127.0.0.1 4227 ! client pcap device lo -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25174 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I50af5d0c0930b9bc906a8b909910bc38f025648e Gerrit-Change-Number: 25174 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange
Change in docker-playground[master]: ttcn3-pcap-client-test: set vty port to 4227
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/25173 ) Change subject: ttcn3-pcap-client-test: set vty port to 4227 .. ttcn3-pcap-client-test: set vty port to 4227 After moving the default VTY port for osmo-pcap-client from 4237 to 4227, it is different in nightly and latest. Configure the SUT and testsuite to use 4227 for both nightly and latest. Related: OS#5203 Change-Id: I6d45340429925fe5e98cc4e597a01ef51e8322ae --- M ttcn3-pcap-client-test/OPCAP_CLIENT_Tests.cfg M ttcn3-pcap-client-test/osmo-pcap-client.cfg 2 files changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/73/25173/1 diff --git a/ttcn3-pcap-client-test/OPCAP_CLIENT_Tests.cfg b/ttcn3-pcap-client-test/OPCAP_CLIENT_Tests.cfg index e76fc4f..9946c5c 100644 --- a/ttcn3-pcap-client-test/OPCAP_CLIENT_Tests.cfg +++ b/ttcn3-pcap-client-test/OPCAP_CLIENT_Tests.cfg @@ -8,6 +8,7 @@ [TESTPORT_PARAMETERS] *.VTY.CTRL_HOSTNAME := "172.18.31.20"; +*.VTY.CTRL_PORTNUM := "4227" [MODULE_PARAMETERS] OPCAP_CLIENT_Tests.mp_local_opcap_ip := "172.18.31.10"; diff --git a/ttcn3-pcap-client-test/osmo-pcap-client.cfg b/ttcn3-pcap-client-test/osmo-pcap-client.cfg index 7394c96..5628b9e 100644 --- a/ttcn3-pcap-client-test/osmo-pcap-client.cfg +++ b/ttcn3-pcap-client-test/osmo-pcap-client.cfg @@ -5,7 +5,7 @@ ! line vty no login - bind 0.0.0.0 + bind 0.0.0.0 4227 ! client pcap device eth0 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/25173 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I6d45340429925fe5e98cc4e597a01ef51e8322ae Gerrit-Change-Number: 25173 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange
Change in osmo-ttcn3-hacks[master]: ns2: add first sgsn test case TC_sns_sgsn_config_success
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25139 ) Change subject: ns2: add first sgsn test case TC_sns_sgsn_config_success .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25139 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibacc2f6ad3053ff7b1e00054cabb9ec7010ffab2 Gerrit-Change-Number: 25139 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 09 Aug 2021 06:40:53 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-sgsn[master]: vty: add "page imsi"
osmith has submitted this change. (
https://gerrit.osmocom.org/c/osmo-sgsn/+/25161 )
Change subject: vty: add "page imsi"
..
vty: add "page imsi"
Make it easy to manually test pagings from SGSN to the PCU.
Related: SYS#4878
Change-Id: I8a73caa234f6b841e641be866e22e7fa03152eb7
---
M src/sgsn/sgsn_vty.c
1 file changed, 21 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/src/sgsn/sgsn_vty.c b/src/sgsn/sgsn_vty.c
index 30bd864..e0e2677 100644
--- a/src/sgsn/sgsn_vty.c
+++ b/src/sgsn/sgsn_vty.c
@@ -35,6 +35,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -1209,6 +1210,25 @@
return CMD_SUCCESS;
}
+DEFUN(page_subscr, page_subscr_info_cmd,
+ "page imsi IMSI",
+ "Send a PS paging request to subscriber\n"
+ "Use the IMSI to select the subscriber\n"
+ "The IMSI\n")
+{
+ const char *imsi = argv[0];
+ struct sgsn_mm_ctx *mm;
+
+ mm = sgsn_mm_ctx_by_imsi(imsi);
+ if (!mm) {
+ vty_out(vty, "No MM context for IMSI %s%s", imsi, VTY_NEWLINE);
+ return CMD_WARNING;
+ }
+
+ gprs_gb_page_ps_ra(mm);
+ return CMD_SUCCESS;
+}
+
DEFUN(cfg_gsup_ipa_name,
cfg_gsup_ipa_name_cmd,
"gsup ipa-name NAME",
@@ -1675,6 +1695,7 @@
install_element(ENABLE_NODE, _subscr_cancel_cmd);
install_element(ENABLE_NODE, _subscr_update_location_result_cmd);
install_element(ENABLE_NODE, _subscr_update_auth_info_cmd);
+ install_element(ENABLE_NODE, _subscr_info_cmd);
install_element(ENABLE_NODE, _sgsn_state_cmd);
install_element(CONFIG_NODE, _sgsn_cmd);
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/25161
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I8a73caa234f6b841e641be866e22e7fa03152eb7
Gerrit-Change-Number: 25161
Gerrit-PatchSet: 1
Gerrit-Owner: osmith
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: osmith
Gerrit-MessageType: merged
Change in osmo-ttcn3-hacks[master]: ns2: introduce module parameter SnsSide
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25138 )
Change subject: ns2: introduce module parameter SnsSide
..
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25138/1/ns/NS_Tests.ttcn
File ns/NS_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25138/1/ns/NS_Tests.ttcn@27
PS1, Line 27: type enumerated SnsSide {
I think we call this "role" in the C implementation, might be good to use the
same here?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25138
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: If8162f256428e2e1f353ffbf42a7c0cd24bcecd9
Gerrit-Change-Number: 25138
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge
Gerrit-Comment-Date: Mon, 09 Aug 2021 06:40:32 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: ns2: rename TC_sns_config_success -> TC_sns_bss_config_success
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25137 ) Change subject: ns2: rename TC_sns_config_success -> TC_sns_bss_config_success .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25137 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I56b074649e64d8e8469ff133d4f298ebf07707ae Gerrit-Change-Number: 25137 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 09 Aug 2021 06:40:01 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: ns2: add a dummy test case TC_idle() for manual test cases
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25136 ) Change subject: ns2: add a dummy test case TC_idle() for manual test cases .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25136 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie1b5936447755dcaebd65396b7bb5cc3f31c17b5 Gerrit-Change-Number: 25136 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 09 Aug 2021 06:39:40 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: ns2: add test case to call force unconfigured after SNS Size received
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25135 ) Change subject: ns2: add test case to call force unconfigured after SNS Size received .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25135 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I16d89391c0d665485cf453c260531023de6096fb Gerrit-Change-Number: 25135 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 09 Aug 2021 06:39:26 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ttcn3-hacks[master]: fr/fr-net: use correct DLCI range for test cases
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25134 ) Change subject: fr/fr-net: use correct DLCI range for test cases .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25134 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia155f346beb4f2be1392d3204b73a0d3b00aaa08 Gerrit-Change-Number: 25134 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 09 Aug 2021 06:39:16 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: test: add 'make update_exp' target
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25152 ) Change subject: test: add 'make update_exp' target .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25152 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I225dd3746200cad748ea09b2c3e1c7f9d006d32f Gerrit-Change-Number: 25152 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 09 Aug 2021 06:38:17 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: gprs_ns2_sns: ensure the SNS fsm behave correct when no signalling NS...
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25151 ) Change subject: gprs_ns2_sns: ensure the SNS fsm behave correct when no signalling NSVCs are present .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25151 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I95e6bbb7a418d647a8426804879571597ae06ff8 Gerrit-Change-Number: 25151 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 09 Aug 2021 06:37:43 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: gprs_ns2: improve reselection protection
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25150 ) Change subject: gprs_ns2: improve reselection protection .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25150 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I375a7639fb8e0f92fd67bb4176bd6219978aa428 Gerrit-Change-Number: 25150 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 09 Aug 2021 06:37:20 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: gprs_ns2: add correct filename/linenr to sns failed log message
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25149 ) Change subject: gprs_ns2: add correct filename/linenr to sns failed log message .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25149 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I117eaf8340fca50cb14392a3f05ea8feac1af3ed Gerrit-Change-Number: 25149 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 09 Aug 2021 06:36:56 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: gprs_ns2: calculate the nse->*_sums before notifing the sns fsm
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25148 ) Change subject: gprs_ns2: calculate the nse->*_sums before notifing the sns fsm .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25148 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7b115921780bd1ae895d8b9d0d4aec3e1cbaaf58 Gerrit-Change-Number: 25148 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 09 Aug 2021 06:36:39 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: gprs_ns2_sns: implement outbound SNS ADD procedures
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/24123 ) Change subject: gprs_ns2_sns: implement outbound SNS ADD procedures .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24123 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I71c33200bd1f0307ceb943ee958db5ebe3623d36 Gerrit-Change-Number: 24123 Gerrit-PatchSet: 8 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-CC: daniel Gerrit-Comment-Date: Mon, 09 Aug 2021 06:36:12 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: gprs_ns2_sns: implement local change weight procedure
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/23187 ) Change subject: gprs_ns2_sns: implement local change weight procedure .. Patch Set 11: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23187 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icec4dabb46bc198f68f91bfe09ba279fbe68d454 Gerrit-Change-Number: 23187 Gerrit-PatchSet: 11 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 09 Aug 2021 06:35:15 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: gprs_ns2: dont use llist_for_each when freeing an element
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/25147 )
Change subject: gprs_ns2: dont use llist_for_each when freeing an element
..
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/c/libosmocore/+/25147/1/src/gb/gprs_ns2.c
File src/gb/gprs_ns2.c:
https://gerrit.osmocom.org/c/libosmocore/+/25147/1/src/gb/gprs_ns2.c@680
PS1, Line 680: while (!llist_empty(>nsvc)) {
would be good to explain in a comment why we don't use the normal
llist_for_each_entry_safe here. [and same below]
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25147
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I902557fb6e56e6588728a46e43a9cbe3215d5c68
Gerrit-Change-Number: 25147
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge
Gerrit-Comment-Date: Mon, 09 Aug 2021 06:33:42 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Change in libosmocore[master]: gprs_ns2: use an event to free the nsvscs when using SNS
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25146 ) Change subject: gprs_ns2: use an event to free the nsvscs when using SNS .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25146 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie99ba5fe8a84519fe8a8c0abdf875606715ab7f6 Gerrit-Change-Number: 25146 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 09 Aug 2021 06:32:31 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: gprs_ns2_sns: rework sns clean up
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25145 ) Change subject: gprs_ns2_sns: rework sns clean up .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25145 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2639345fdf3cd300a934238d676c543065ceaa8b Gerrit-Change-Number: 25145 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 09 Aug 2021 06:31:56 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: gprs_ns2: move sns_event into internal.h to direct emit events
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25144 ) Change subject: gprs_ns2: move sns_event into internal.h to direct emit events .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/25144/1/src/gb/gprs_ns_sns.c File src/gb/gprs_ns_sns.c: https://gerrit.osmocom.org/c/libosmocore/+/25144/1/src/gb/gprs_ns_sns.c@276 PS1, Line 276: enum g so we have tow different definitions for the same enum ?!? one here and one in gprs_ns2_internal.h? Doesn't sound like a good idea to me. Why should the old gprs_ns_sns.c code share the enum with the new code, but have a different definiton? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25144 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8e3fae4367c112b5a71bffb33c302d903855cddc Gerrit-Change-Number: 25144 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-Comment-Date: Mon, 09 Aug 2021 06:30:29 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in libosmocore[master]: gprs_ns2: add recursive anchor to protect against double free
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25143 ) Change subject: gprs_ns2: add recursive anchor to protect against double free .. Patch Set 1: wold be good to expand in the commitlog on the paths in which we currently have or suspect double-frees. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25143 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If9823aadaa936e136aa43e88cee925ddd5974841 Gerrit-Change-Number: 25143 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-Comment-Date: Mon, 09 Aug 2021 06:27:55 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in libosmocore[master]: gprs_ns2_sns: refactor SNS failures into a function
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/24649 ) Change subject: gprs_ns2_sns: refactor SNS failures into a function .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24649 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1896f6c3ddb4f98ca261139c1cc77aa8f1558c6f Gerrit-Change-Number: 24649 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Comment-Date: Mon, 09 Aug 2021 06:26:43 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: gprs_ns2_udp: don't start the NSVC fsm for SNS
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25142 ) Change subject: gprs_ns2_udp: don't start the NSVC fsm for SNS .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25142 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I86275c99432262b3c19c1ded9a77090b74303bc8 Gerrit-Change-Number: 25142 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 09 Aug 2021 06:25:46 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: error log: improve lchan lookup error msg
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25167 ) Change subject: error log: improve lchan lookup error msg .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25167 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I46b660cd51a41e561712a0bd849ce0ee8d1a9588 Gerrit-Change-Number: 25167 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 09 Aug 2021 06:24:36 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: early IMM ASS 3/n: implement 'pre-ts-ack'
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25166 ) Change subject: early IMM ASS 3/n: implement 'pre-ts-ack' .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25166 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I19e6a3d614aa5ae24d64eed96caf53e6f0e8bb74 Gerrit-Change-Number: 25166 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 09 Aug 2021 06:24:15 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: early IMM ASS 2/n: implement 'pre-chan-ack'
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25165 ) Change subject: early IMM ASS 2/n: implement 'pre-chan-ack' .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25165 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I56c25cde152040fb66bdba44399bd37671ae3df2 Gerrit-Change-Number: 25165 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 09 Aug 2021 06:23:38 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: early IMM ASS 1/n: add vty config option
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25164 ) Change subject: early IMM ASS 1/n: add vty config option .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25164 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I710343d1728153faf3db9758ff5a1ef26bb8d3d4 Gerrit-Change-Number: 25164 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 09 Aug 2021 06:22:48 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: introduce gsm48_lchan_and_pchan2chan_desc()
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25163 ) Change subject: introduce gsm48_lchan_and_pchan2chan_desc() .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25163 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I67f178c8160cdda1f2ab5513ac4f65c027d4012f Gerrit-Change-Number: 25163 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 09 Aug 2021 06:21:49 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: lchan_fsm_post_activ_ack(): return upon release
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25162 ) Change subject: lchan_fsm_post_activ_ack(): return upon release .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25162 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4674752ab4f1c8e8147ef3366f90e9ea2abd5aec Gerrit-Change-Number: 25162 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 09 Aug 2021 06:20:25 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
