date:20210811

Change in osmo-pcu[master]: fix: handle NULL return of as_dl_tbf() and as_ul_tbf()

2021-08-11 Thread osmith

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/25182 )

Change subject: fix: handle NULL return of as_dl_tbf() and as_ul_tbf()
..


Patch Set 2: Code-Review+1

Patch looks sane to me.

Maybe log a message if as_dl_tbf and as_ul_tbf are NULL instead of silently 
doing nothing? That hopefully helps with figuring out why this happens.

Note that Pau has patches pending to completely refactor TBF logic to use FSM: 
https://gerrit.osmocom.org/c/osmo-pcu/+/25011


--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25182
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I8ce21be6836549b47a606c00b793d6f005964c5c
Gerrit-Change-Number: 25182
Gerrit-PatchSet: 2
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Wed, 11 Aug 2021 07:44:56 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in simtrace2[master]: contrib: allow manually forcing bulk simtrace dissection

2021-08-11 Thread osmith

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/simtrace2/+/25178 )

Change subject: contrib: allow manually forcing bulk simtrace dissection
..


Patch Set 1: Code-Review+1

LGTM.

Why was it disabled in the initial version in 
https://gerrit.osmocom.org/c/simtrace2/+/24737? (would be helpful in the commit 
message)


--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/25178
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I5fcfe3c221b87b02e21c857ac51d0392c3b4de3c
Gerrit-Change-Number: 25178
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Wed, 11 Aug 2021 08:04:36 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: lchan_fsm_post_activ_ack(): return upon release

2021-08-11 Thread osmith

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/25162 )

Change subject: lchan_fsm_post_activ_ack(): return upon release
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25162
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I4674752ab4f1c8e8147ef3366f90e9ea2abd5aec
Gerrit-Change-Number: 25162
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Wed, 11 Aug 2021 08:06:59 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: introduce gsm48_lchan_and_pchan2chan_desc()

2021-08-11 Thread osmith

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/25163 )

Change subject: introduce gsm48_lchan_and_pchan2chan_desc()
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25163
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I67f178c8160cdda1f2ab5513ac4f65c027d4012f
Gerrit-Change-Number: 25163
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Wed, 11 Aug 2021 08:16:45 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: early IMM ASS 1/n: add vty config option

2021-08-11 Thread osmith

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/25164 )

Change subject: early IMM ASS 1/n: add vty config option
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25164
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I710343d1728153faf3db9758ff5a1ef26bb8d3d4
Gerrit-Change-Number: 25164
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Wed, 11 Aug 2021 08:25:29 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: early IMM ASS 2/n: implement 'pre-chan-ack'

2021-08-11 Thread osmith

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/25165 )

Change subject: early IMM ASS 2/n: implement 'pre-chan-ack'
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25165
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I56c25cde152040fb66bdba44399bd37671ae3df2
Gerrit-Change-Number: 25165
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Wed, 11 Aug 2021 08:30:22 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: early IMM ASS 3/n: implement 'pre-ts-ack'

2021-08-11 Thread osmith

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/25166 )

Change subject: early IMM ASS 3/n: implement 'pre-ts-ack'
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25166
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I19e6a3d614aa5ae24d64eed96caf53e6f0e8bb74
Gerrit-Change-Number: 25166
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Wed, 11 Aug 2021 08:35:08 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: error log: improve lchan lookup error msg

2021-08-11 Thread osmith

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/25167 )

Change subject: error log: improve lchan lookup error msg
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25167
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I46b660cd51a41e561712a0bd849ce0ee8d1a9588
Gerrit-Change-Number: 25167
Gerrit-PatchSet: 1
Gerrit-Owner: neels 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Wed, 11 Aug 2021 08:37:04 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: osmo_bsc_main: integrate MGW pooling into osmo-bsc

2021-08-11 Thread dexter

Hello osmith, Jenkins Builder, laforge,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-bsc/+/25123

to look at the new patch set (#4).

Change subject: osmo_bsc_main: integrate MGW pooling into osmo-bsc
..

osmo_bsc_main: integrate MGW pooling into osmo-bsc

Since the libosmo-mgcp-client now supports MGW pooling, lets use this
feature in osmo-bsc. Large RAN installations may benefit from
distributing the RTP voice stream load on multiple media gateways.

Depends: osmo-mgw Icaaba0e470e916eefddfee750b83f5f65291a6b0
Change-Id: I8f33ab2cea04b545c403a6fe479aa963a0fc0d0d
Related: SYS#5091
---
A doc/manuals/chapters/mgwpool.adoc
M doc/manuals/chapters/running.adoc
M doc/manuals/osmobsc-usermanual.adoc
M include/osmocom/bsc/gsm_data.h
M include/osmocom/bsc/vty.h
M src/osmo-bsc/bsc_subscr_conn_fsm.c
M src/osmo-bsc/bsc_vty.c
M src/osmo-bsc/osmo_bsc_main.c
8 files changed, 320 insertions(+), 18 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/23/25123/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25123
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I8f33ab2cea04b545c403a6fe479aa963a0fc0d0d
Gerrit-Change-Number: 25123
Gerrit-PatchSet: 4
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-MessageType: newpatchset

Change in osmo-mgw[master]: libosmo-mgcp-client: extend the mgcp_client for MGW pooling

2021-08-11 Thread dexter

Hello osmith, Jenkins Builder, neels, laforge, pespin,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-mgw/+/25120

to look at the new patch set (#12).

Change subject: libosmo-mgcp-client: extend the mgcp_client for MGW pooling
..

libosmo-mgcp-client: extend the mgcp_client for MGW pooling

At the moment the MGCP Client only supports one MGW per application.
Depending on the requirements of the application one MGW might not offer
the performance needed. Lets add support for an MGCP Client pool that is
backward compatible to existing applications.

Change-Id: Icaaba0e470e916eefddfee750b83f5f65291a6b0
Related: SYS#5091
---
M include/Makefile.am
M include/osmocom/mgcp_client/Makefile.am
M include/osmocom/mgcp_client/mgcp_client.h
M include/osmocom/mgcp_client/mgcp_client_endpoint_fsm.h
M include/osmocom/mgcp_client/mgcp_client_fsm.h
M include/osmocom/mgcp_client/mgcp_client_internal.h
A include/osmocom/mgcp_client/mgcp_client_pool.h
A include/osmocom/mgcp_client/mgcp_client_pool_internal.h
M src/libosmo-mgcp-client/Makefile.am
M src/libosmo-mgcp-client/mgcp_client.c
M src/libosmo-mgcp-client/mgcp_client_endpoint_fsm.c
M src/libosmo-mgcp-client/mgcp_client_fsm.c
A src/libosmo-mgcp-client/mgcp_client_pool.c
M src/libosmo-mgcp-client/mgcp_client_vty.c
14 files changed, 593 insertions(+), 27 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/20/25120/12
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25120
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Icaaba0e470e916eefddfee750b83f5f65291a6b0
Gerrit-Change-Number: 25120
Gerrit-PatchSet: 12
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: newpatchset

Change in osmo-mgw[master]: libosmo-mgcp-client: extend the mgcp_client for MGW pooling

2021-08-11 Thread dexter

dexter has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-mgw/+/25120 )

Change subject: libosmo-mgcp-client: extend the mgcp_client for MGW pooling
..


Patch Set 12:

(1 comment)

https://gerrit.osmocom.org/c/osmo-mgw/+/25120/9/include/osmocom/mgcp_client/mgcp_client_pool.h
File include/osmocom/mgcp_client/mgcp_client_pool.h:

https://gerrit.osmocom.org/c/osmo-mgw/+/25120/9/include/osmocom/mgcp_client/mgcp_client_pool.h@9
PS9, Line 9: void mgcp_client_pool_register_single(struct mgcp_client_pool 
*pool, struct mgcp_client *mgcp_client);
> the naming of those function is inconsistent.  Either you first put the 
> object first, i.e. […]
Done



--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25120
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Icaaba0e470e916eefddfee750b83f5f65291a6b0
Gerrit-Change-Number: 25120
Gerrit-PatchSet: 12
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Wed, 11 Aug 2021 08:54:04 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge 
Gerrit-MessageType: comment

Change in osmo-mgw[master]: libosmo-mgcp-client: extend the mgcp_client for MGW pooling

2021-08-11 Thread osmith

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-mgw/+/25120 )

Change subject: libosmo-mgcp-client: extend the mgcp_client for MGW pooling
..


Patch Set 12: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25120
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Icaaba0e470e916eefddfee750b83f5f65291a6b0
Gerrit-Change-Number: 25120
Gerrit-PatchSet: 12
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Wed, 11 Aug 2021 08:56:56 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bsc[master]: osmo_bsc_main: integrate MGW pooling into osmo-bsc

2021-08-11 Thread osmith

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/25123 )

Change subject: osmo_bsc_main: integrate MGW pooling into osmo-bsc
..


Patch Set 4: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25123
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I8f33ab2cea04b545c403a6fe479aa963a0fc0d0d
Gerrit-Change-Number: 25123
Gerrit-PatchSet: 4
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Wed, 11 Aug 2021 08:57:21 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in simtrace2[master]: contrib: allow manually forcing bulk simtrace dissection

2021-08-11 Thread Hoernchen

Hoernchen has posted comments on this change. ( 
https://gerrit.osmocom.org/c/simtrace2/+/25178 )

Change subject: contrib: allow manually forcing bulk simtrace dissection
..


Patch Set 1:

It was just useless because the pid/vid version was strictly better and 
automatically dissects the packets - the problem is that this only works as 
long as wireshark sees the descriptors, so if you manually cut your capture and 
omit them it does not work, and it's not possible to force "decode as.." -> but 
"decode as.." works when adding it to the generic bulk table.


--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/25178
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I5fcfe3c221b87b02e21c857ac51d0392c3b4de3c
Gerrit-Change-Number: 25178
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Wed, 11 Aug 2021 09:57:45 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in osmo-pcu[master]: Add counters: pcu.bts.N.pch.requests.timeout

2021-08-11 Thread dexter

dexter has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/25155 )

Change subject: Add counters: pcu.bts.N.pch.requests.timeout
..


Patch Set 3: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25155
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I97475c3dbe2cf00b9cbfec39e93a3c65cb7f749f
Gerrit-Change-Number: 25155
Gerrit-PatchSet: 3
Gerrit-Owner: osmith 
Gerrit-Reviewer: Hoernchen 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: dexter 
Gerrit-Comment-Date: Wed, 11 Aug 2021 09:57:41 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-pcu[master]: Add counters: pcu.bts.N.pch.requests.timeout

2021-08-11 Thread osmith

Hello Jenkins Builder, Hoernchen, daniel, dexter,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-pcu/+/25155

to look at the new patch set (#4).

Change subject: Add counters: pcu.bts.N.pch.requests.timeout
..

Add counters: pcu.bts.N.pch.requests.timeout

Implement T3113 for paging over PCH with default value of 7s (same as
T3113 in OsmoBSC). Increase the new counter on timeout.

Related: SYS#4878
Change-Id: I97475c3dbe2cf00b9cbfec39e93a3c65cb7f749f
---
M src/Makefile.am
M src/bts.cpp
M src/bts.h
A src/bts_pch_timer.c
A src/bts_pch_timer.h
M src/gprs_pcu.c
M src/gprs_rlcmac.cpp
M src/tbf_ul.cpp
8 files changed, 142 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/55/25155/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25155
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I97475c3dbe2cf00b9cbfec39e93a3c65cb7f749f
Gerrit-Change-Number: 25155
Gerrit-PatchSet: 4
Gerrit-Owner: osmith 
Gerrit-Reviewer: Hoernchen 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: dexter 
Gerrit-MessageType: newpatchset

Change in osmo-ci[master]: repo-install-test: osmo-pcap-server: !latest

2021-08-11 Thread osmith

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ci/+/25181 )

Change subject: repo-install-test: osmo-pcap-server: !latest
..


Patch Set 1: Verified+1 Code-Review+2

Trivial, merging now so the repo-install-test doesn't fail every day.


--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/25181
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I711e0e13c3e3af30407b85fd10aca9446f2b94ba
Gerrit-Change-Number: 25181
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Wed, 11 Aug 2021 11:45:12 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-ci[master]: repo-install-test: osmo-pcap-server: !latest

2021-08-11 Thread osmith

osmith has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-ci/+/25181 )

Change subject: repo-install-test: osmo-pcap-server: !latest
..

repo-install-test: osmo-pcap-server: !latest

Disable osmo-pcap-server for latest again, as the port is still
conflicting there with osmo-bts.

Fixes: 7ca9c4 ("repo-install-test: clear SERVICES_NIGHTLY list")
Related: OS#5203
Change-Id: I711e0e13c3e3af30407b85fd10aca9446f2b94ba
---
M scripts/repo-install-test/run-inside-docker.sh
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  daniel: Looks good to me, but someone else must approve
  osmith: Looks good to me, approved; Verified



diff --git a/scripts/repo-install-test/run-inside-docker.sh 
b/scripts/repo-install-test/run-inside-docker.sh
index da0d27c..e47b4ec 100755
--- a/scripts/repo-install-test/run-inside-docker.sh
+++ b/scripts/repo-install-test/run-inside-docker.sh
@@ -22,15 +22,15 @@
osmo-mgw
osmo-msc
osmo-pcap-client
-   osmo-pcap-server
osmo-pcu
osmo-sgsn
osmo-sip-connector
osmo-stp
 "
 # Services working in nightly, but not yet in latest
-# * (currently none)
+# * osmo-pcap-server 0.2.0: VTY port in default config conflicts with osmo-bts 
(OS#5203)
 SERVICES_NIGHTLY="
+   osmo-pcap-server
 "

 distro_obsdir() {

--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/25181
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I711e0e13c3e3af30407b85fd10aca9446f2b94ba
Gerrit-Change-Number: 25181
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: osmith 
Gerrit-MessageType: merged

Change in osmo-pcu[master]: Add counters: pcu.bts.N.pch.requests.timeout

2021-08-11 Thread osmith

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/25155 )

Change subject: Add counters: pcu.bts.N.pch.requests.timeout
..


Patch Set 4: Code-Review+2

re-applying 1+1=2 after adding author comment


--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25155
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I97475c3dbe2cf00b9cbfec39e93a3c65cb7f749f
Gerrit-Change-Number: 25155
Gerrit-PatchSet: 4
Gerrit-Owner: osmith 
Gerrit-Reviewer: Hoernchen 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: osmith 
Gerrit-Comment-Date: Wed, 11 Aug 2021 14:47:25 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-pcu[master]: Add counters: pcu.bts.N.pch.requests.timeout

2021-08-11 Thread osmith

osmith has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/25155 )

Change subject: Add counters: pcu.bts.N.pch.requests.timeout
..

Add counters: pcu.bts.N.pch.requests.timeout

Implement T3113 for paging over PCH with default value of 7s (same as
T3113 in OsmoBSC). Increase the new counter on timeout.

Related: SYS#4878
Change-Id: I97475c3dbe2cf00b9cbfec39e93a3c65cb7f749f
---
M src/Makefile.am
M src/bts.cpp
M src/bts.h
A src/bts_pch_timer.c
A src/bts_pch_timer.h
M src/gprs_pcu.c
M src/gprs_rlcmac.cpp
M src/tbf_ul.cpp
8 files changed, 142 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  osmith: Looks good to me, approved



diff --git a/src/Makefile.am b/src/Makefile.am
index 8070fda..f05daaf 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -62,6 +62,7 @@
tbf_ul.cpp \
tbf_dl.cpp \
bts.cpp \
+   bts_pch_timer.c \
pdch.cpp \
pdch_ul_controller.c \
encoding.cpp \
@@ -101,6 +102,7 @@
tbf_ul.h \
tbf_dl.h \
bts.h \
+   bts_pch_timer.h \
pdch.h \
pdch_ul_controller.h \
encoding.h \
diff --git a/src/bts.cpp b/src/bts.cpp
index 4e3b770..a96fe24 100644
--- a/src/bts.cpp
+++ b/src/bts.cpp
@@ -133,6 +133,7 @@
{ "llc:dl_bytes",   "RLC encapsulated PDUs"},
{ "llc:ul_bytes",   "full PDUs received   "},
{ "pch:requests",   "PCH requests sent"},
+   { "pch:requests:timeout",   "PCH requests timeout "},
{ "rach:requests",  "RACH requests received"},
{ "11bit_rach:requests","11BIT_RACH requests received"},
{ "spb:uplink_first_segment",   "First seg of UL SPB  "},
@@ -283,6 +284,8 @@

llist_add_tail(&bts->list, &pcu->bts_list);

+   INIT_LLIST_HEAD(&bts->pch_timer);
+
return bts;
 }

diff --git a/src/bts.h b/src/bts.h
index c28bd97..5e45527 100644
--- a/src/bts.h
+++ b/src/bts.h
@@ -126,6 +126,7 @@
CTR_LLC_DL_BYTES,
CTR_LLC_UL_BYTES,
CTR_PCH_REQUESTS,
+   CTR_PCH_REQUESTS_TIMEDOUT,
CTR_RACH_REQUESTS,
CTR_11BIT_RACH_REQUESTS,
CTR_SPB_UL_FIRST_SEGMENT,
@@ -263,6 +264,9 @@
struct osmo_stat_item_group *statg;

struct GprsMsStorage *ms_store;
+
+   /* List of struct bts_pch_timer for active PCH pagings */
+   struct llist_head pch_timer;
 };

 #ifdef __cplusplus
diff --git a/src/bts_pch_timer.c b/src/bts_pch_timer.c
new file mode 100644
index 000..386a583
--- /dev/null
+++ b/src/bts_pch_timer.c
@@ -0,0 +1,85 @@
+/*
+ * Copyright (C) 2021 by sysmocom - s.f.m.c. GmbH 
+ * Author: Oliver Smith
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as published by
+ * the Free Software Foundation; either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see .
+ *
+ */
+#include 
+
+#include 
+#include 
+#include 
+#include 
+
+#include 
+#include 
+#include 
+
+static struct bts_pch_timer *bts_pch_timer_get(struct gprs_rlcmac_bts *bts, 
const char *imsi)
+{
+   struct bts_pch_timer *p;
+
+   llist_for_each_entry(p, &bts->pch_timer, entry) {
+   if (strcmp(p->imsi, imsi) == 0)
+   return p;
+   }
+
+   return NULL;
+}
+
+static void bts_pch_timer_remove(struct bts_pch_timer *p)
+{
+   osmo_timer_del(&p->T3113);
+   llist_del(&p->entry);
+
+   LOGP(DPCU, LOGL_DEBUG, "PCH paging timer stopped for IMSI=%s\n", 
p->imsi);
+   talloc_free(p);
+}
+
+static void T3113_callback(void *data)
+{
+   struct bts_pch_timer *p = data;
+
+   LOGP(DPCU, LOGL_INFO, "PCH paging timeout for IMSI=%s\n", p->imsi);
+   bts_do_rate_ctr_inc(p->bts, CTR_PCH_REQUESTS_TIMEDOUT);
+   bts_pch_timer_remove(p);
+}
+
+void bts_pch_timer_start(struct gprs_rlcmac_bts *bts, const char *imsi)
+{
+   if (bts_pch_timer_get(bts, imsi))
+   return;
+
+   struct bts_pch_timer *p;
+   p = talloc_zero(bts, struct bts_pch_timer);
+   llist_add_tail(&p->entry, &bts->pch_timer);
+   osmo_strlcpy(p->imsi, imsi, sizeof(p->imsi));
+   p->bts = bts;
+
+   struct osmo_tdef *tdef = osmo_tdef_get_entry(the_pcu->T_defs, 3113);
+   OSMO_ASSERT(tdef);
+   osmo_timer_setup(&p->T3113, T3113_callback, p);
+   osmo_timer_schedule(&p->T3113, tdef->val, 0);
+
+   LOGP(DPCU, LOGL_DEBUG, "PCH paging timer started for IMSI=%s\n", 
p->imsi);
+}

Change in osmo-ttcn3-hacks[master]: ns2: introduce module parameter SnsSide

2021-08-11 Thread lynxis lazus

lynxis lazus has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25138 )

Change subject: ns2: introduce module parameter SnsSide
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25138/1/ns/NS_Tests.ttcn
File ns/NS_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25138/1/ns/NS_Tests.ttcn@27
PS1, Line 27: type enumerated SnsSide {
> I think we call this "role" in the C implementation, might be good to use the 
> same here?
Ack



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25138
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: If8162f256428e2e1f353ffbf42a7c0cd24bcecd9
Gerrit-Change-Number: 25138
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge 
Gerrit-Comment-Date: Thu, 12 Aug 2021 02:01:26 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge 
Gerrit-MessageType: comment

Change in osmo-ttcn3-hacks[master]: ns2: introduce module parameter SnsRole

2021-08-11 Thread lynxis lazus

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25138

to look at the new patch set (#2).

Change subject: ns2: introduce module parameter SnsRole
..

ns2: introduce module parameter SnsRole

Allow the .cfg to define which tests should be run.
The new SGSN role SNS tests have their own configurations for
TTCN3 and osmo-nsdummy.

Change-Id: If8162f256428e2e1f353ffbf42a7c0cd24bcecd9
---
M ns/NS_Tests.ttcn
1 file changed, 17 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/38/25138/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25138
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: If8162f256428e2e1f353ffbf42a7c0cd24bcecd9
Gerrit-Change-Number: 25138
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge 
Gerrit-MessageType: newpatchset

Change in osmo-ttcn3-hacks[master]: ns2: add first sgsn test case TC_sns_sgsn_config_success

2021-08-11 Thread lynxis lazus

Hello Jenkins Builder, laforge,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25139

to look at the new patch set (#2).

Change subject: ns2: add first sgsn test case TC_sns_sgsn_config_success
..

ns2: add first sgsn test case TC_sns_sgsn_config_success

Checks if the SGSN can success configures a SNS.

Change-Id: Ibacc2f6ad3053ff7b1e00054cabb9ec7010ffab2
---
A ns/NS_Tests.sgsn.sns.cfg
M ns/NS_Tests.ttcn
A ns/osmo-ns.sgsn.sns.cfg
3 files changed, 160 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/39/25139/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25139
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ibacc2f6ad3053ff7b1e00054cabb9ec7010ffab2
Gerrit-Change-Number: 25139
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-MessageType: newpatchset

Change in osmo-ttcn3-hacks[master]: ns2: mark TC_sns_bss_all_signalling_nsvcs_failed as broken

2021-08-11 Thread lynxis lazus

Hello Jenkins Builder, laforge, dexter,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25141

to look at the new patch set (#3).

Change subject: ns2: mark TC_sns_bss_all_signalling_nsvcs_failed as broken
..

ns2: mark TC_sns_bss_all_signalling_nsvcs_failed as broken

The test case tests the wrong side. The signalling
and data weight are valid for the other side. The correct
test case needs to add a second bind on the ttcn3 side because
the signalling and data weight is valid for the remote side.

Change-Id: Ice79a038b0b8df9e69232bb24b2f2b18b3632758
---
M ns/NS_Tests.ttcn
1 file changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/41/25141/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25141
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ice79a038b0b8df9e69232bb24b2f2b18b3632758
Gerrit-Change-Number: 25141
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: laforge 
Gerrit-MessageType: newpatchset

Change in osmo-ttcn3-hacks[master]: ns2: add test case to call force unconfigured after SNS Size received

2021-08-11 Thread lynxis lazus

lynxis lazus has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25135 )

Change subject: ns2: add test case to call force unconfigured after SNS Size 
received
..

ns2: add test case to call force unconfigured after SNS Size received

The old ns dummy crashed when calling force unconfigured while sending
SNS SIZE.

Change-Id: I16d89391c0d665485cf453c260531023de6096fb
---
M ns/NS_Tests.ttcn
1 file changed, 16 insertions(+), 0 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/ns/NS_Tests.ttcn b/ns/NS_Tests.ttcn
index 9fbd5ab..a0b9216 100644
--- a/ns/NS_Tests.ttcn
+++ b/ns/NS_Tests.ttcn
@@ -626,6 +626,21 @@
f_clean_ns_codec();
 }

+/* Ensure the ns2 code doesn't crash when calling force unconfigured while 
sending SNS SIZE */
+testcase TC_sns_rx_size_force_unconf() runs on RAW_Test_CT {
+   g_handle_rx_alive := true;
+   f_init_vty();
+   f_init_ns_codec(mp_nsconfig);
+   f_init_ns_codec(mp_nsconfig, 1);
+   f_ns_exp(tr_SNS_SIZE(mp_nsconfig.nsei, rst_flag := true, max_nsvcs := ?,
+   num_v4 := ?, num_v6 := omit));
+   f_vty_transceive(NSVTY, "nsvc nsei " & int2str(mp_nsconfig.nsei) & " 
force-unconfigured");
+   f_ns_exp(tr_SNS_SIZE(mp_nsconfig.nsei, rst_flag := true, max_nsvcs := ?,
+   num_v4 := ?, num_v6 := omit));
+   setverdict(pass);
+   f_clean_ns_codec();
+}
+
 /* Test if SNS fails when all signalling NSVCs failes
  * 3GPP TS 48.016 § 7.4b.1.1
  * 1. do success SNS configuration
@@ -712,6 +727,7 @@
execute( TC_sns_bss_del() );
execute( TC_sns_bss_add_change_del() );
execute( TC_sns_bss_all_signalling_nsvcs_failed() );
+   execute( TC_sns_rx_size_force_unconf() );
}
 }


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25135
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I16d89391c0d665485cf453c260531023de6096fb
Gerrit-Change-Number: 25135
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-MessageType: merged

Change in osmo-ttcn3-hacks[master]: fr/fr-net: use correct DLCI range for test cases

2021-08-11 Thread lynxis lazus

lynxis lazus has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25134 )

Change subject: fr/fr-net: use correct DLCI range for test cases
..

fr/fr-net: use correct DLCI range for test cases

DLCIs are only valid >= 16.

Change-Id: Ia155f346beb4f2be1392d3204b73a0d3b00aaa08
---
M fr-net/FRNET_Tests.ttcn
M fr/FR_Tests.ttcn
2 files changed, 8 insertions(+), 8 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/fr-net/FRNET_Tests.ttcn b/fr-net/FRNET_Tests.ttcn
index c3ec468..614750f 100644
--- a/fr-net/FRNET_Tests.ttcn
+++ b/fr-net/FRNET_Tests.ttcn
@@ -21,7 +21,7 @@
provider := {
fr := {
netdev := "hdlcnet1",
-   dlci := 1
+   dlci := 21
}
},
nsvci := 101
@@ -29,7 +29,7 @@
provider := {
fr := {
netdev := "hdlcnet2",
-   dlci := 2
+   dlci := 22
}
},
nsvci := 102
@@ -37,7 +37,7 @@
provider := {
fr := {
netdev := "hdlcnet3",
-   dlci := 3
+   dlci := 23
}
},
nsvci := 103
@@ -45,7 +45,7 @@
provider := {
fr := {
netdev := "hdlcnet4",
-   dlci := 4
+   dlci := 24
}
},
nsvci := 104
diff --git a/fr/FR_Tests.ttcn b/fr/FR_Tests.ttcn
index 5e4f9e8..1e662fe 100644
--- a/fr/FR_Tests.ttcn
+++ b/fr/FR_Tests.ttcn
@@ -27,7 +27,7 @@
provider := {
fr := {
netdev := "hdlc1",
-   dlci := 1
+   dlci := 21
}
},
nsvci := 101
@@ -35,7 +35,7 @@
provider := {
fr := {
netdev := "hdlc2",
-   dlci := 2
+   dlci := 22
}
},
nsvci := 102
@@ -43,7 +43,7 @@
provider := {
fr := {
netdev := "hdlc3",
-   dlci := 3
+   dlci := 23
}
},
nsvci := 103
@@ -51,7 +51,7 @@
provider := {
fr := {
netdev := "hdlc4",
-   dlci := 4
+   dlci := 24
}
},
nsvci := 104

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25134
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia155f346beb4f2be1392d3204b73a0d3b00aaa08
Gerrit-Change-Number: 2

Change in osmo-ttcn3-hacks[master]: ns2: add a dummy test case TC_idle() for manual test cases

2021-08-11 Thread lynxis lazus

lynxis lazus has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25136 )

Change subject: ns2: add a dummy test case TC_idle() for manual test cases
..

ns2: add a dummy test case TC_idle() for manual test cases

The TC_idle() won't be call by the control as this TC is only intended for 
manual
human based testing.

Change-Id: Ie1b5936447755dcaebd65396b7bb5cc3f31c17b5
---
M ns/NS_Tests.ttcn
1 file changed, 16 insertions(+), 0 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/ns/NS_Tests.ttcn b/ns/NS_Tests.ttcn
index a0b9216..af28cf1 100644
--- a/ns/NS_Tests.ttcn
+++ b/ns/NS_Tests.ttcn
@@ -676,6 +676,22 @@
f_clean_ns_codec();
 }

+testcase TC_idle() runs on RAW_Test_CT {
+   f_init_vty();
+   f_init_ns_codec(mp_nsconfig, guard_secs := 30.0);
+
+   /* do a NS Reset procedure */
+   f_outgoing_ns_reset();
+   activate(as_rx_alive_tx_ack());
+
+   f_outgoing_ns_unblock();
+   f_sleep(30.0);
+
+   setverdict(pass);
+   f_sleep(1.0);
+   f_clean_ns_codec();
+}
+
 control {
if (mp_dialect == NS2_DIALECT_STATIC_RESETBLOCK or mp_dialect == 
NS2_DIALECT_IPACCESS) {
execute( TC_tx_reset() );

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25136
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie1b5936447755dcaebd65396b7bb5cc3f31c17b5
Gerrit-Change-Number: 25136
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-MessageType: merged

Change in osmo-ttcn3-hacks[master]: ns2: rename TC_sns_config_success -> TC_sns_bss_config_success

2021-08-11 Thread lynxis lazus

lynxis lazus has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25137 )

Change subject: ns2: rename TC_sns_config_success -> TC_sns_bss_config_success
..

ns2: rename TC_sns_config_success -> TC_sns_bss_config_success

SGSN test cases will be introduced later. Prefix all bss testcases

Change-Id: I56b074649e64d8e8469ff133d4f298ebf07707ae
---
M ns/NS_Tests.ttcn
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/ns/NS_Tests.ttcn b/ns/NS_Tests.ttcn
index af28cf1..d42ef8c 100644
--- a/ns/NS_Tests.ttcn
+++ b/ns/NS_Tests.ttcn
@@ -475,7 +475,7 @@
 /* 48.016 SNS test cases */

 /* do a succesful SNS configuration */
-testcase TC_sns_config_success() runs on RAW_Test_CT {
+testcase TC_sns_bss_config_success() runs on RAW_Test_CT {
f_init_vty();
f_init_ns_codec(mp_nsconfig);
f_incoming_sns_size();
@@ -736,7 +736,8 @@
}

if (mp_dialect == NS2_DIALECT_SNS) {
-   execute( TC_sns_config_success() );
+   /* BSS test cases */
+   execute( TC_sns_bss_config_success() );
execute( TC_sns_bss_change_weight() );
execute( TC_sns_bss_change_weight_timeout() );
execute( TC_sns_bss_add() );

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25137
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I56b074649e64d8e8469ff133d4f298ebf07707ae
Gerrit-Change-Number: 25137
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-MessageType: merged

Change in osmo-ttcn3-hacks[master]: ns2: add TC_sns_sgsn_add to test SNS ADD on the SGSN role

2021-08-11 Thread lynxis lazus

Hello Jenkins Builder, laforge,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25140

to look at the new patch set (#3).

Change subject: ns2: add TC_sns_sgsn_add to test SNS ADD on the SGSN role
..

ns2: add TC_sns_sgsn_add to test SNS ADD on the SGSN role

Change-Id: I7474ea81ee905fb9fffb6c413b312e0b3547ea14
---
M ns/NS_Tests.ttcn
1 file changed, 20 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/40/25140/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25140
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I7474ea81ee905fb9fffb6c413b312e0b3547ea14
Gerrit-Change-Number: 25140
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-MessageType: newpatchset

Change in libosmocore[master]: gprs_ns2_sns: free the NSE if the SIZE PDU is not valid

2021-08-11 Thread lynxis lazus

lynxis lazus has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/24650 )

Change subject: gprs_ns2_sns: free the NSE if the SIZE PDU is not valid
..


Patch Set 4:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/24650/2/src/gb/gprs_ns2_sns.c
File src/gb/gprs_ns2_sns.c:

https://gerrit.osmocom.org/c/libosmocore/+/24650/2/src/gb/gprs_ns2_sns.c@2254
PS2, Line 2254: sns_failed(fi, "Rx Size: 
Missing Enssential IE");
> I think in 3gpp speak this should be "Missing mandatory IE", but I don't know 
> that for sure.
48.016 says "Missing essential IE" in table 10.3.2.1. But you're right for 
other specs I know the "Missing mandatory IE".



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24650
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ife889091ecba4180a90743deb786767008fe863d
Gerrit-Change-Number: 24650
Gerrit-PatchSet: 4
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 12 Aug 2021 02:14:18 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter 
Gerrit-MessageType: comment

Change in libosmocore[master]: gprs_ns2_udp: don't start the NSVC fsm for SNS

2021-08-11 Thread lynxis lazus

Hello Jenkins Builder, laforge, daniel,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/libosmocore/+/25142

to look at the new patch set (#2).

Change subject: gprs_ns2_udp: don't start the NSVC fsm for SNS
..

gprs_ns2_udp: don't start the NSVC fsm for SNS

The SNS code will always create NSVC on it's own. The only case
when the SNS dialect allows dynamic NSE/NSVC is on the SGSN side when accepting
dynamic NSE and receiving the first SNS SIZE. In this case the NSVC FSM must 
not be started yet.
Prevents sending NS_ALIVE before the SNS configuration has been
finished.

Change-Id: I86275c99432262b3c19c1ded9a77090b74303bc8
---
M src/gb/gprs_ns2_udp.c
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/42/25142/2
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25142
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I86275c99432262b3c19c1ded9a77090b74303bc8
Gerrit-Change-Number: 25142
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: laforge 
Gerrit-MessageType: newpatchset

Change in libosmocore[master]: gprs_ns2_sns: refactor SNS failures into a function

2021-08-11 Thread lynxis lazus

Hello Jenkins Builder, laforge, daniel,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/libosmocore/+/24649

to look at the new patch set (#4).

Change subject: gprs_ns2_sns: refactor SNS failures into a function
..

gprs_ns2_sns: refactor SNS failures into a function

The SNS fsm is similar for BSS and SGSN.
Terminate the SGSN failures by freeing the NSE.

Change-Id: I1896f6c3ddb4f98ca261139c1cc77aa8f1558c6f
---
M src/gb/gprs_ns2_sns.c
1 file changed, 25 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/49/24649/4
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24649
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I1896f6c3ddb4f98ca261139c1cc77aa8f1558c6f
Gerrit-Change-Number: 24649
Gerrit-PatchSet: 4
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-MessageType: newpatchset

Change in libosmocore[master]: gprs_ns2: add recursive anchor to protect against double free

2021-08-11 Thread lynxis lazus

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/libosmocore/+/25143

to look at the new patch set (#2).

Change subject: gprs_ns2: add recursive anchor to protect against double free
..

gprs_ns2: add recursive anchor to protect against double free

When free'ing a NSE/NSVC/BIND ensure there can't be a double
free by using a free anchor in the struct.

Recursive free's can happen when the NS user reacts on an event
(e.g. GPRS_NS2_AFF_CAUSE_VC_FAILURE) and calls the free().
Or when the user free's a NSVC when the NSE uses SNS as configuration,
the fsm tries to free it again.

Change-Id: If9823aadaa936e136aa43e88cee925ddd5974841
---
M src/gb/gprs_ns2.c
M src/gb/gprs_ns2_internal.h
2 files changed, 20 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/43/25143/2
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25143
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: If9823aadaa936e136aa43e88cee925ddd5974841
Gerrit-Change-Number: 25143
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge 
Gerrit-MessageType: newpatchset

Change in libosmocore[master]: gprs_ns2_sns: free the NSE if the SIZE PDU is not valid

2021-08-11 Thread lynxis lazus

Hello Jenkins Builder, laforge, pespin, dexter,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/libosmocore/+/24650

to look at the new patch set (#5).

Change subject: gprs_ns2_sns: free the NSE if the SIZE PDU is not valid
..

gprs_ns2_sns: free the NSE if the SIZE PDU is not valid

The SGSN fsm should be freed when becoming invalid instead of going
into the unconfigured state. The unconfigured states should be only used
when creating the NSE (on the SGSN side).

Change-Id: Ife889091ecba4180a90743deb786767008fe863d
---
M src/gb/gprs_ns2_sns.c
1 file changed, 14 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/50/24650/5
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24650
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ife889091ecba4180a90743deb786767008fe863d
Gerrit-Change-Number: 24650
Gerrit-PatchSet: 5
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: newpatchset

Change in libosmocore[master]: gprs_ns2_sns: rework sns clean up

2021-08-11 Thread lynxis lazus

Hello Jenkins Builder, laforge,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/libosmocore/+/25145

to look at the new patch set (#2).

Change subject: gprs_ns2_sns: rework sns clean up
..

gprs_ns2_sns: rework sns clean up

Move the cleanup into it's own state. Also changing the
SGSN unconfigured state which won't be triggered when a
SIZE is received.

Change-Id: I2639345fdf3cd300a934238d676c543065ceaa8b
---
M src/gb/gprs_ns2_sns.c
1 file changed, 33 insertions(+), 16 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/45/25145/2
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25145
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I2639345fdf3cd300a934238d676c543065ceaa8b
Gerrit-Change-Number: 25145
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-MessageType: newpatchset

Change in libosmocore[master]: gprs_ns2: move sns_event into internal.h to direct emit events

2021-08-11 Thread lynxis lazus

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/libosmocore/+/25144

to look at the new patch set (#2).

Change subject: gprs_ns2: move sns_event into internal.h to direct emit events
..

gprs_ns2: move sns_event into internal.h to direct emit events

Creating just a proxy function seems more overhead instead of calling it direct.

Change-Id: I8e3fae4367c112b5a71bffb33c302d903855cddc
---
M src/gb/gprs_ns2_internal.h
M src/gb/gprs_ns2_sns.c
M src/gb/gprs_ns_sns.c
3 files changed, 18 insertions(+), 18 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/44/25144/2
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25144
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I8e3fae4367c112b5a71bffb33c302d903855cddc
Gerrit-Change-Number: 25144
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge 
Gerrit-MessageType: newpatchset

Change in libosmocore[master]: gprs_ns2: use an event to free the nsvscs when using SNS

2021-08-11 Thread lynxis lazus

Hello Jenkins Builder, laforge,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/libosmocore/+/25146

to look at the new patch set (#2).

Change subject: gprs_ns2: use an event to free the nsvscs when using SNS
..

gprs_ns2: use an event to free the nsvscs when using SNS

Otherwise there could be recursive loop when free'ing NSVCs which
in the end create an event which the SNS want to free the NSVCs a
second time

Change-Id: Ie99ba5fe8a84519fe8a8c0abdf875606715ab7f6
---
M src/gb/gprs_ns2.c
M src/gb/gprs_ns2_internal.h
M src/gb/gprs_ns2_sns.c
3 files changed, 18 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/46/25146/2
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25146
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ie99ba5fe8a84519fe8a8c0abdf875606715ab7f6
Gerrit-Change-Number: 25146
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-MessageType: newpatchset

Change in libosmocore[master]: gprs_ns2: dont use llist_for_each when freeing an element

2021-08-11 Thread lynxis lazus

Hello Jenkins Builder, dexter,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/libosmocore/+/25147

to look at the new patch set (#2).

Change subject: gprs_ns2: dont use llist_for_each when freeing an element
..

gprs_ns2: dont use llist_for_each when freeing an element

The problem are recursive execution because a free generates an event which 
could
allow the use to free a nsvcs while the llist_for_each() is still running

Change-Id: I902557fb6e56e6588728a46e43a9cbe3215d5c68
---
M src/gb/gprs_ns2.c
M src/gb/gprs_ns2_sns.c
2 files changed, 21 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/47/25147/2
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25147
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I902557fb6e56e6588728a46e43a9cbe3215d5c68
Gerrit-Change-Number: 25147
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 
Gerrit-CC: laforge 
Gerrit-CC: neels 
Gerrit-MessageType: newpatchset

Change in libosmocore[master]: gprs_ns2_sns: implement local change weight procedure

2021-08-11 Thread lynxis lazus

Hello Jenkins Builder, laforge, pespin, daniel,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/libosmocore/+/23187

to look at the new patch set (#12).

Change subject: gprs_ns2_sns: implement local change weight procedure
..

gprs_ns2_sns: implement local change weight procedure

When changing the bind ip-sns weight, initiate a
SNS CHANGE WEIGHT procedure to inform the other side.

Related: OS#5036
Change-Id: Icec4dabb46bc198f68f91bfe09ba279fbe68d454
---
M src/gb/gprs_ns2.c
M src/gb/gprs_ns2_internal.h
M src/gb/gprs_ns2_sns.c
M src/gb/gprs_ns2_vty.c
M tests/gb/gprs_ns2_vty.vty
5 files changed, 462 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/87/23187/12
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23187
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Icec4dabb46bc198f68f91bfe09ba279fbe68d454
Gerrit-Change-Number: 23187
Gerrit-PatchSet: 12
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: newpatchset

Change in libosmocore[master]: gprs_ns2_sns: implement outbound SNS ADD procedures

2021-08-11 Thread lynxis lazus

Hello Jenkins Builder, laforge, pespin,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/libosmocore/+/24123

to look at the new patch set (#9).

Change subject: gprs_ns2_sns: implement outbound SNS ADD procedures
..

gprs_ns2_sns: implement outbound SNS ADD procedures

When adding a bind, the remote side needs to be
informed via the SNS ADD procedure.

Related: OS#5036
Change-Id: I71c33200bd1f0307ceb943ee958db5ebe3623d36
---
M src/gb/gprs_ns2_sns.c
1 file changed, 191 insertions(+), 37 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/23/24123/9
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24123
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I71c33200bd1f0307ceb943ee958db5ebe3623d36
Gerrit-Change-Number: 24123
Gerrit-PatchSet: 9
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: pespin 
Gerrit-CC: daniel 
Gerrit-MessageType: newpatchset

Change in libosmocore[master]: gprs_ns2_sns: implement outbound SNS DEL procedures

2021-08-11 Thread lynxis lazus

Hello Jenkins Builder, pespin, daniel, dexter,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/libosmocore/+/24591

to look at the new patch set (#6).

Change subject: gprs_ns2_sns: implement outbound SNS DEL procedures
..

gprs_ns2_sns: implement outbound SNS DEL procedures

When removing a bind the remote side needs to be
informed via the SNS DELETE procedure.

Related: OS#5036
Change-Id: I53cd54dfd262c70c425c3f13dad3b29526daa523
---
M src/gb/gprs_ns2_sns.c
1 file changed, 76 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/91/24591/6
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24591
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I53cd54dfd262c70c425c3f13dad3b29526daa523
Gerrit-Change-Number: 24591
Gerrit-PatchSet: 6
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: newpatchset

Change in libosmocore[master]: gprs_ns2: add correct filename/linenr to sns failed log message

2021-08-11 Thread lynxis lazus

Hello Jenkins Builder, laforge, dexter,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/libosmocore/+/25149

to look at the new patch set (#2).

Change subject: gprs_ns2: add correct filename/linenr to sns failed log message
..

gprs_ns2: add correct filename/linenr to sns failed log message

Change-Id: I117eaf8340fca50cb14392a3f05ea8feac1af3ed
---
M src/gb/gprs_ns2_sns.c
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/49/25149/2
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25149
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I117eaf8340fca50cb14392a3f05ea8feac1af3ed
Gerrit-Change-Number: 25149
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: laforge 
Gerrit-MessageType: newpatchset

Change in libosmocore[master]: gprs_ns2: calculate the nse->*_sums before notifing the sns fsm

2021-08-11 Thread lynxis lazus

Hello Jenkins Builder, laforge,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/libosmocore/+/25148

to look at the new patch set (#2).

Change subject: gprs_ns2: calculate the nse->*_sums before notifing the sns fsm
..

gprs_ns2: calculate the nse->*_sums before notifing the sns fsm

The sns fsm needs these information to determine if there is a signalling nsvc 
left

Change-Id: I7b115921780bd1ae895d8b9d0d4aec3e1cbaaf58
---
M src/gb/gprs_ns2.c
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/48/25148/2
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25148
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I7b115921780bd1ae895d8b9d0d4aec3e1cbaaf58
Gerrit-Change-Number: 25148
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-MessageType: newpatchset

Change in libosmocore[master]: gprs_ns2: improve reselection protection

2021-08-11 Thread lynxis lazus

Hello Jenkins Builder, laforge,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/libosmocore/+/25150

to look at the new patch set (#2).

Change subject: gprs_ns2: improve reselection protection
..

gprs_ns2: improve reselection protection

Change-Id: I375a7639fb8e0f92fd67bb4176bd6219978aa428
---
M src/gb/gprs_ns2_sns.c
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/50/25150/2
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25150
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I375a7639fb8e0f92fd67bb4176bd6219978aa428
Gerrit-Change-Number: 25150
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-MessageType: newpatchset

Change in libosmocore[master]: gprs_ns2_sns: ensure the SNS fsm behave correct when no signalling NS...

2021-08-11 Thread lynxis lazus

Hello Jenkins Builder, laforge,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/libosmocore/+/25151

to look at the new patch set (#2).

Change subject: gprs_ns2_sns: ensure the SNS fsm behave correct when no 
signalling NSVCs are present
..

gprs_ns2_sns: ensure the SNS fsm behave correct when no signalling NSVCs are 
present

When no remaining signalling NSVCs are available the SNS must be
restarted (BSS) or go into unconfigured state (SGSN).

Change-Id: I95e6bbb7a418d647a8426804879571597ae06ff8
---
M src/gb/gprs_ns2_sns.c
1 file changed, 25 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/51/25151/2
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25151
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I95e6bbb7a418d647a8426804879571597ae06ff8
Gerrit-Change-Number: 25151
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-MessageType: newpatchset

45 matches

Mail list logo