Change in osmo-bsc[master]: bsc_ctrl_commands: fix uninitialized value (mode)
osmith has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-bsc/+/26094 )
Change subject: bsc_ctrl_commands: fix uninitialized value (mode)
..
bsc_ctrl_commands: fix uninitialized value (mode)
Fixes: CID#240848
Change-Id: I571055b350d343318ef1ae469ae92475925d1910
---
M src/osmo-bsc/bsc_ctrl_commands.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/94/26094/1
diff --git a/src/osmo-bsc/bsc_ctrl_commands.c b/src/osmo-bsc/bsc_ctrl_commands.c
index f379bd2..fb8bd0c 100644
--- a/src/osmo-bsc/bsc_ctrl_commands.c
+++ b/src/osmo-bsc/bsc_ctrl_commands.c
@@ -753,7 +753,7 @@
static int set_bts_neighbor_list_mode(struct ctrl_cmd *cmd, void *data)
{
struct gsm_bts *bts = cmd->node;
- int mode;
+ int mode = NL_MODE_AUTOMATIC;
if (!strcmp(cmd->value, "automatic"))
mode = NL_MODE_AUTOMATIC;
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26094
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I571055b350d343318ef1ae469ae92475925d1910
Gerrit-Change-Number: 26094
Gerrit-PatchSet: 1
Gerrit-Owner: osmith
Gerrit-MessageType: newchange
Change in osmo-bts[master]: abis: Try one reconnect to previously connected BSC before trying nex...
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26093 ) Change subject: abis: Try one reconnect to previously connected BSC before trying next one .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26093 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I16b75da5987584d099edc3a640f3a5cd61f3ad69 Gerrit-Change-Number: 26093 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 04 Nov 2021 08:58:32 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: bsc_ctrl_commands: fix uninitialized value (mode)
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26094 ) Change subject: bsc_ctrl_commands: fix uninitialized value (mode) .. Patch Set 1: Code-Review+2 Not really a bug ;-) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26094 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I571055b350d343318ef1ae469ae92475925d1910 Gerrit-Change-Number: 26094 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Comment-Date: Thu, 04 Nov 2021 09:01:31 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: abis: Drop unneded if condition in else clause
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26092 ) Change subject: abis: Drop unneded if condition in else clause .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26092 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I0a6519f7b93f0b45c67d19fef4f50daeeefc7340 Gerrit-Change-Number: 26092 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 04 Nov 2021 09:05:08 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: bts-trx: sched_lchan_tchf: Change log level to debug for line informi...
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26091 ) Change subject: bts-trx: sched_lchan_tchf: Change log level to debug for line informing about missing dl prim .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26091 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ib7f274b97cc66d671316eae429ee4baf16831534 Gerrit-Change-Number: 26091 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 04 Nov 2021 09:06:24 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: bsc_ctrl_commands: fix uninitialized value (mode)
osmith has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/26094 )
Change subject: bsc_ctrl_commands: fix uninitialized value (mode)
..
bsc_ctrl_commands: fix uninitialized value (mode)
Fixes: CID#240848
Change-Id: I571055b350d343318ef1ae469ae92475925d1910
---
M src/osmo-bsc/bsc_ctrl_commands.c
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
dexter: Looks good to me, approved
diff --git a/src/osmo-bsc/bsc_ctrl_commands.c b/src/osmo-bsc/bsc_ctrl_commands.c
index f379bd2..fb8bd0c 100644
--- a/src/osmo-bsc/bsc_ctrl_commands.c
+++ b/src/osmo-bsc/bsc_ctrl_commands.c
@@ -753,7 +753,7 @@
static int set_bts_neighbor_list_mode(struct ctrl_cmd *cmd, void *data)
{
struct gsm_bts *bts = cmd->node;
- int mode;
+ int mode = NL_MODE_AUTOMATIC;
if (!strcmp(cmd->value, "automatic"))
mode = NL_MODE_AUTOMATIC;
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26094
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I571055b350d343318ef1ae469ae92475925d1910
Gerrit-Change-Number: 26094
Gerrit-PatchSet: 1
Gerrit-Owner: osmith
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter
Gerrit-Reviewer: osmith
Gerrit-MessageType: merged
Change in osmo-bsc[master]: tweak intra-bsc ho counter descriptions
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26071 ) Change subject: tweak intra-bsc ho counter descriptions .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26071 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I00eaf42fcd705cf3f4e06e8c7434fd05dbad4b84 Gerrit-Change-Number: 26071 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 09:08:15 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: drop unused gsm48_tx_mm_serv_ack()
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26069 ) Change subject: drop unused gsm48_tx_mm_serv_ack() .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26069 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia9d841a8243adca347e7ea79d31e3cd65eab27ea Gerrit-Change-Number: 26069 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 09:12:09 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Build failure of network:osmocom:nightly/osmo-gsm-manuals in Debian_Unstable/x86_64
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-gsm-manuals/Debian_Unstable/x86_64
Package network:osmocom:nightly/osmo-gsm-manuals failed to build in
Debian_Unstable/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-gsm-manuals
Last lines of build log:
[ 405s] # we create a symlink at ./srcfile.adoc pointing at
[ 405s] # ./srcfile.adoc. test-usermanual.adoc is the ./srcfile.adoc,
[ 405s] # is like basename from coreutils, and . is WD.
[ 405s] if ! [ -f test-usermanual.adoc ]; then \
[ 405s]ln -s test-usermanual.adoc test-usermanual.adoc; \
[ 405s] fi
[ 405s] # TEXINPUTS: find LaTeX includes like
\includegraphics{./common/images/sysmocom.pdf}
[ 405s] # in ...
[ 405s] TEXINPUTS=".." \
[ 405s]a2x -vv -L --asciidoc-opts="-f ../build/mscgen-filter.conf -f
../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -a
srcdir='/usr/src/packages/BUILD/tests' -a commondir='../common'"
--dblatex-opts="-s ../build/custom-dblatex.sty -P draft.mode=yes -P
draft.watermark=0" -a docinfo -a revnumber="DRAFT " -a revdate="unknown"
test-usermanual.adoc
[ 406s] a2x: args: ['-vv', '-L', "--asciidoc-opts=-f
../build/mscgen-filter.conf -f ../build/diag-filter.conf -f
../build/docinfo-releaseinfo.conf -a srcdir='/usr/src/packages/BUILD/tests' -a
commondir='../common'", '--dblatex-opts=-s ../build/custom-dblatex.sty -P
draft.mode=yes -P draft.watermark=0', '-a', 'docinfo', '-a', 'revnumber=DRAFT
', '-a', 'revdate=unknown', 'test-usermanual.adoc']
[ 406s] a2x: resource files: []
[ 406s] a2x: resource directories: ['/etc/asciidoc/stylesheets']
[ 406s] make[3]: *** [../build/Makefile.asciidoc.inc:70: test-usermanual.pdf]
Error 1
[ 406s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[ 406s] make[2]: *** [Makefile:439: all-recursive] Error 1
[ 406s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[ 406s] make[1]: *** [Makefile:363: all] Error 2
[ 406s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[ 406s] dh_auto_build: error: make -j1 returned exit code 2
[ 406s] make: *** [debian/rules:5: binary] Error 25
[ 406s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess
returned exit status 2
[ 406s] ### VM INTERACTION START ###
[ 407s] Powering off.
[ 407s] [ 387.120813] reboot: Power down
[ 407s] ### VM INTERACTION END ###
[ 407s]
[ 407s] lamb26 failed "build
osmo-gsm-manuals-dev_1.1.0.17.b92c.202111040908.dsc" at Thu Nov 4 09:19:25 UTC
2021.
[ 407s]
--
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)
Change in osmo-bsc[master]: add chreq:successful_ rate counters
dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/26068 )
Change subject: add chreq:successful_ rate counters
..
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/c/osmo-bsc/+/26068/1/src/osmo-bsc/abis_rsl.c
File src/osmo-bsc/abis_rsl.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/26068/1/src/osmo-bsc/abis_rsl.c@2155
PS1, Line 2155: switch (lchan->activate.info.chreq_reason) {
> sounds like an excellent idea, but that could be a further cleanup on top of
> this patch.
Ack
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26068
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I32c2c197a6199617a82986480b686c515fa40d62
Gerrit-Change-Number: 26068
Gerrit-PatchSet: 1
Gerrit-Owner: neels
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-Comment-Date: Thu, 04 Nov 2021 09:20:43 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge
Comment-In-Reply-To: pespin
Gerrit-MessageType: comment
Change in osmo-bsc[master]: Revert "Turn some compiler warnings into errors"
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26095 ) Change subject: Revert "Turn some compiler warnings into errors" .. Revert "Turn some compiler warnings into errors" Do not turn some compiler warnings into errors by default. This patch was added before --enable-werror was available. We build with --enable-werror during development and in CI. If the code is built with a different compiler that throws additional warnings, it should not stop the build. This reverts commit 34f012639ddf41470714ae74ae961d158670a4c7. Related: OS#5289 Change-Id: I6b143b803349b97e783c586615d7f2ed4e1ff058 --- M configure.ac 1 file changed, 0 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/95/26095/1 diff --git a/configure.ac b/configure.ac index 195acfe..bcf91ba 100644 --- a/configure.ac +++ b/configure.ac @@ -36,11 +36,6 @@ fi PKG_PROG_PKG_CONFIG([0.20]) -dnl check for AX_CHECK_COMPILE_FLAG -m4_ifdef([AX_CHECK_COMPILE_FLAG], [], [ - AC_MSG_ERROR([Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect.]) - ]) - dnl checks for libraries AC_SEARCH_LIBS([dlopen], [dl dld], [LIBRARY_DL="$LIBS";LIBS=""]) AC_SUBST(LIBRARY_DL) @@ -120,13 +115,6 @@ CFLAGS="$saved_CFLAGS" AC_SUBST(SYMBOL_VISIBILITY) -AX_CHECK_COMPILE_FLAG([-Werror=implicit], [CFLAGS="$CFLAGS -Werror=implicit"]) -AX_CHECK_COMPILE_FLAG([-Werror=maybe-uninitialized], [CFLAGS="$CFLAGS -Werror=maybe-uninitialized"]) -AX_CHECK_COMPILE_FLAG([-Werror=memset-transposed-args], [CFLAGS="$CFLAGS -Werror=memset-transposed-args"]) -AX_CHECK_COMPILE_FLAG([-Wnull-dereference], [CFLAGS="$CFLAGS -Wnull-dereference"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-array-argument], [CFLAGS="$CFLAGS -Werror=sizeof-array-argument"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-pointer-memaccess], [CFLAGS="$CFLAGS -Werror=sizeof-pointer-memaccess"]) - # Coverage build taken from WebKit's configure.in AC_MSG_CHECKING([whether to enable code coverage support]) AC_ARG_ENABLE(coverage, -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26095 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6b143b803349b97e783c586615d7f2ed4e1ff058 Gerrit-Change-Number: 26095 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange
Change in osmo-msc[master]: Revert "Turn some compiler warnings into errors"
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/26096 ) Change subject: Revert "Turn some compiler warnings into errors" .. Revert "Turn some compiler warnings into errors" Do not turn some compiler warnings into errors by default. This patch was added before --enable-werror was available. We build with --enable-werror during development and in CI. If the code is built with a different compiler that throws additional warnings, it should not stop the build. This reverts commit 34f012639ddf41470714ae74ae961d158670a4c7. Related: OS#5289 Change-Id: Ideff462157a034e053e5e7049605dd8d24440905 --- M configure.ac 1 file changed, 0 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/96/26096/1 diff --git a/configure.ac b/configure.ac index 1207171..702be9f 100644 --- a/configure.ac +++ b/configure.ac @@ -36,12 +36,6 @@ fi PKG_PROG_PKG_CONFIG([0.20]) -dnl check for AX_CHECK_COMPILE_FLAG -m4_ifdef([AX_CHECK_COMPILE_FLAG], [], [ - AC_MSG_ERROR([Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect.]) - ]) - - PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.5.0) PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.5.0) PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.5.0) @@ -119,15 +113,6 @@ AC_HEADER_STDC AC_CHECK_HEADERS(dbi/dbd.h,,AC_MSG_ERROR(DBI library is not installed)) - -dnl Checks for typedefs, structures and compiler characteristics -AX_CHECK_COMPILE_FLAG([-Werror=implicit], [CFLAGS="$CFLAGS -Werror=implicit"]) -AX_CHECK_COMPILE_FLAG([-Werror=maybe-uninitialized], [CFLAGS="$CFLAGS -Werror=maybe-uninitialized"]) -AX_CHECK_COMPILE_FLAG([-Werror=memset-transposed-args], [CFLAGS="$CFLAGS -Werror=memset-transposed-args"]) -AX_CHECK_COMPILE_FLAG([-Wnull-dereference], [CFLAGS="$CFLAGS -Wnull-dereference"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-array-argument], [CFLAGS="$CFLAGS -Werror=sizeof-array-argument"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-pointer-memaccess], [CFLAGS="$CFLAGS -Werror=sizeof-pointer-memaccess"]) - # Coverage build taken from WebKit's configure.in AC_MSG_CHECKING([whether to enable code coverage support]) AC_ARG_ENABLE(coverage, -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26096 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ideff462157a034e053e5e7049605dd8d24440905 Gerrit-Change-Number: 26096 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange
Change in osmo-mgw[master]: Revert "Turn some compiler warnings into errors"
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26097 ) Change subject: Revert "Turn some compiler warnings into errors" .. Revert "Turn some compiler warnings into errors" Do not turn some compiler warnings into errors by default. This patch was added before --enable-werror was available. We build with --enable-werror during development and in CI. If the code is built with a different compiler that throws additional warnings, it should not stop the build. This reverts commit 34f012639ddf41470714ae74ae961d158670a4c7. Related: OS#5289 Change-Id: I6042f917a5a891dd13cb96d9477a45a45a7b35fe --- M configure.ac 1 file changed, 0 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/97/26097/1 diff --git a/configure.ac b/configure.ac index b996e87..ddd8862 100644 --- a/configure.ac +++ b/configure.ac @@ -36,11 +36,6 @@ fi PKG_PROG_PKG_CONFIG([0.20]) -dnl check for AX_CHECK_COMPILE_FLAG -m4_ifdef([AX_CHECK_COMPILE_FLAG], [], [ - AC_MSG_ERROR([Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect.]) - ]) - dnl checks for libraries AC_SEARCH_LIBS([dlopen], [dl dld], [LIBRARY_DL="$LIBS";LIBS=""]) AC_SUBST(LIBRARY_DL) @@ -90,16 +85,6 @@ CPPFLAGS="$CPPFLAGS $WERROR_FLAGS" fi -dnl Checks for typedefs, structures and compiler characteristics - -AX_CHECK_COMPILE_FLAG([-Werror=implicit], [CFLAGS="$CFLAGS -Werror=implicit"]) -AX_CHECK_COMPILE_FLAG([-Werror=maybe-uninitialized], [CFLAGS="$CFLAGS -Werror=maybe-uninitialized"],,[-Werror]) -AX_CHECK_COMPILE_FLAG([-Werror=sometimes-uninitialized], [CFLAGS="$CFLAGS -Werror=sometimes-uninitialized"],,[-Werror]) -AX_CHECK_COMPILE_FLAG([-Werror=memset-transposed-args], [CFLAGS="$CFLAGS -Werror=memset-transposed-args"]) -AX_CHECK_COMPILE_FLAG([-Wnull-dereference], [CFLAGS="$CFLAGS -Wnull-dereference"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-array-argument], [CFLAGS="$CFLAGS -Werror=sizeof-array-argument"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-pointer-memaccess], [CFLAGS="$CFLAGS -Werror=sizeof-pointer-memaccess"]) - # Coverage build taken from WebKit's configure.in AC_MSG_CHECKING([whether to enable code coverage support]) AC_ARG_ENABLE(coverage, -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26097 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6042f917a5a891dd13cb96d9477a45a45a7b35fe Gerrit-Change-Number: 26097 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange
Change in osmo-sgsn[master]: Revert "Turn some compiler warnings into errors"
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/26098 ) Change subject: Revert "Turn some compiler warnings into errors" .. Revert "Turn some compiler warnings into errors" Do not turn some compiler warnings into errors by default. This patch was added before --enable-werror was available. We build with --enable-werror during development and in CI. If the code is built with a different compiler that throws additional warnings, it should not stop the build. This reverts commit 34f012639ddf41470714ae74ae961d158670a4c7. Related: OS#5289 Change-Id: I24e0a0d7f93f196dc642e37b03f68464024c09d4 --- M configure.ac 1 file changed, 0 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/98/26098/1 diff --git a/configure.ac b/configure.ac index c29bacb..9607373 100644 --- a/configure.ac +++ b/configure.ac @@ -34,11 +34,6 @@ fi PKG_PROG_PKG_CONFIG([0.20]) -dnl check for AX_CHECK_COMPILE_FLAG -m4_ifdef([AX_CHECK_COMPILE_FLAG], [], [ - AC_MSG_ERROR([Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect.]) - ]) - dnl use a defined standard across all builds and don't depend on compiler default CFLAGS="$CFLAGS -std=gnu11" @@ -124,13 +119,6 @@ CPPFLAGS="$CPPFLAGS -Wall -Wno-trigraphs" CFLAGS="$CFLAGS -Wall -Wno-trigraphs" -AX_CHECK_COMPILE_FLAG([-Werror=implicit], [CFLAGS="$CFLAGS -Werror=implicit"]) -AX_CHECK_COMPILE_FLAG([-Werror=maybe-uninitialized], [CFLAGS="$CFLAGS -Werror=maybe-uninitialized"]) -AX_CHECK_COMPILE_FLAG([-Werror=memset-transposed-args], [CFLAGS="$CFLAGS -Werror=memset-transposed-args"]) -AX_CHECK_COMPILE_FLAG([-Wnull-dereference], [CFLAGS="$CFLAGS -Wnull-dereference"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-array-argument], [CFLAGS="$CFLAGS -Werror=sizeof-array-argument"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-pointer-memaccess], [CFLAGS="$CFLAGS -Werror=sizeof-pointer-memaccess"]) - # Coverage build taken from WebKit's configure.in AC_MSG_CHECKING([whether to enable code coverage support]) AC_ARG_ENABLE(coverage, -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/26098 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I24e0a0d7f93f196dc642e37b03f68464024c09d4 Gerrit-Change-Number: 26098 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange
Change in osmo-e1-recorder[master]: configure: don't turn some warnings into errors
osmith has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-e1-recorder/+/26099 )
Change subject: configure: don't turn some warnings into errors
..
configure: don't turn some warnings into errors
Do not turn some compiler warnings into errors by default. This part was
copied from openbsc.git 34f012 ("Turn some compiler warnings into
errors"), where it was added before --enable-werror was available.
We build with --enable-werror during development and in CI. If the code
is built with a different compiler that throws additional warnings, it
should not stop the build.
Related: OS#5289
Change-Id: Ib5602017545d68f0fdb0b4df7ed3087a2cb1775c
---
M configure.ac
1 file changed, 0 insertions(+), 12 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-e1-recorder
refs/changes/99/26099/1
diff --git a/configure.ac b/configure.ac
index e986809..cec703f 100644
--- a/configure.ac
+++ b/configure.ac
@@ -31,11 +31,6 @@
fi
PKG_PROG_PKG_CONFIG([0.20])
-dnl check for AX_CHECK_COMPILE_FLAG
-m4_ifdef([AX_CHECK_COMPILE_FLAG], [], [
- AC_MSG_ERROR([Please install autoconf-archive; re-run 'autoreconf -fi'
for it to take effect.])
- ])
-
PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.2.0)
PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.2.0)
PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.2.0)
@@ -87,13 +82,6 @@
CFLAGS="$saved_CFLAGS"
AC_SUBST(SYMBOL_VISIBILITY)
-AX_CHECK_COMPILE_FLAG([-Werror=implicit], [CFLAGS="$CFLAGS -Werror=implicit"])
-AX_CHECK_COMPILE_FLAG([-Werror=maybe-uninitialized], [CFLAGS="$CFLAGS
-Werror=maybe-uninitialized"])
-AX_CHECK_COMPILE_FLAG([-Werror=memset-transposed-args], [CFLAGS="$CFLAGS
-Werror=memset-transposed-args"])
-AX_CHECK_COMPILE_FLAG([-Wnull-dereference], [CFLAGS="$CFLAGS
-Wnull-dereference"])
-AX_CHECK_COMPILE_FLAG([-Werror=sizeof-array-argument], [CFLAGS="$CFLAGS
-Werror=sizeof-array-argument"])
-AX_CHECK_COMPILE_FLAG([-Werror=sizeof-pointer-memaccess], [CFLAGS="$CFLAGS
-Werror=sizeof-pointer-memaccess"])
-
# Coverage build taken from WebKit's configure.in
AC_MSG_CHECKING([whether to enable code coverage support])
AC_ARG_ENABLE(coverage,
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1-recorder/+/26099
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1-recorder
Gerrit-Branch: master
Gerrit-Change-Id: Ib5602017545d68f0fdb0b4df7ed3087a2cb1775c
Gerrit-Change-Number: 26099
Gerrit-PatchSet: 1
Gerrit-Owner: osmith
Gerrit-MessageType: newchange
Change in osmo-gbproxy[master]: Revert "Turn some compiler warnings into errors"
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/26100 ) Change subject: Revert "Turn some compiler warnings into errors" .. Revert "Turn some compiler warnings into errors" Do not turn some compiler warnings into errors by default. This patch was added before --enable-werror was available. We build with --enable-werror during development and in CI. If the code is built with a different compiler that throws additional warnings, it should not stop the build. This reverts commit 34f012639ddf41470714ae74ae961d158670a4c7. Related: OS#5289 Change-Id: I2fb777410ffc181feabd6aee3beda3ed05ba5c90 --- M configure.ac 1 file changed, 0 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gbproxy refs/changes/00/26100/1 diff --git a/configure.ac b/configure.ac index 309d3f7..11ebac4 100644 --- a/configure.ac +++ b/configure.ac @@ -34,11 +34,6 @@ fi PKG_PROG_PKG_CONFIG([0.20]) -dnl check for AX_CHECK_COMPILE_FLAG -m4_ifdef([AX_CHECK_COMPILE_FLAG], [], [ - AC_MSG_ERROR([Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect.]) - ]) - dnl use a defined standard across all builds and don't depend on compiler default CFLAGS="$CFLAGS -std=gnu11" @@ -105,13 +100,6 @@ CPPFLAGS="$CPPFLAGS -Wall -Wno-trigraphs" CFLAGS="$CFLAGS -Wall -Wno-trigraphs" -AX_CHECK_COMPILE_FLAG([-Werror=implicit], [CFLAGS="$CFLAGS -Werror=implicit"]) -AX_CHECK_COMPILE_FLAG([-Werror=maybe-uninitialized], [CFLAGS="$CFLAGS -Werror=maybe-uninitialized"]) -AX_CHECK_COMPILE_FLAG([-Werror=memset-transposed-args], [CFLAGS="$CFLAGS -Werror=memset-transposed-args"]) -AX_CHECK_COMPILE_FLAG([-Wnull-dereference], [CFLAGS="$CFLAGS -Wnull-dereference"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-array-argument], [CFLAGS="$CFLAGS -Werror=sizeof-array-argument"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-pointer-memaccess], [CFLAGS="$CFLAGS -Werror=sizeof-pointer-memaccess"]) - # Coverage build taken from WebKit's configure.in AC_MSG_CHECKING([whether to enable code coverage support]) AC_ARG_ENABLE(coverage, -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26100 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I2fb777410ffc181feabd6aee3beda3ed05ba5c90 Gerrit-Change-Number: 26100 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange
Change in osmo-smlc[master]: configure: don't turn some warnings into errors
osmith has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-smlc/+/26101 )
Change subject: configure: don't turn some warnings into errors
..
configure: don't turn some warnings into errors
Do not turn some compiler warnings into errors by default. This part was
copied from openbsc.git 34f012 ("Turn some compiler warnings into
errors"), where it was added before --enable-werror was available.
We build with --enable-werror during development and in CI. If the code
is built with a different compiler that throws additional warnings, it
should not stop the build.
Related: OS#5289
Change-Id: I22f6f4d3d4b81d4791a72a7bce130035bef58c31
---
M configure.ac
1 file changed, 0 insertions(+), 12 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-smlc refs/changes/01/26101/1
diff --git a/configure.ac b/configure.ac
index e4b902b..eed5ee9 100644
--- a/configure.ac
+++ b/configure.ac
@@ -34,11 +34,6 @@
fi
PKG_PROG_PKG_CONFIG([0.20])
-dnl check for AX_CHECK_COMPILE_FLAG
-m4_ifdef([AX_CHECK_COMPILE_FLAG], [], [
- AC_MSG_ERROR([Please install autoconf-archive; re-run 'autoreconf -fi'
for it to take effect.])
- ])
-
PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.5.0)
PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.5.0)
PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.5.0)
@@ -92,13 +87,6 @@
CFLAGS="$saved_CFLAGS"
AC_SUBST(SYMBOL_VISIBILITY)
-AX_CHECK_COMPILE_FLAG([-Werror=implicit], [CFLAGS="$CFLAGS -Werror=implicit"])
-AX_CHECK_COMPILE_FLAG([-Werror=maybe-uninitialized], [CFLAGS="$CFLAGS
-Werror=maybe-uninitialized"])
-AX_CHECK_COMPILE_FLAG([-Werror=memset-transposed-args], [CFLAGS="$CFLAGS
-Werror=memset-transposed-args"])
-AX_CHECK_COMPILE_FLAG([-Wnull-dereference], [CFLAGS="$CFLAGS
-Wnull-dereference"])
-AX_CHECK_COMPILE_FLAG([-Werror=sizeof-array-argument], [CFLAGS="$CFLAGS
-Werror=sizeof-array-argument"])
-AX_CHECK_COMPILE_FLAG([-Werror=sizeof-pointer-memaccess], [CFLAGS="$CFLAGS
-Werror=sizeof-pointer-memaccess"])
-
# Coverage build taken from WebKit's configure.in
AC_MSG_CHECKING([whether to enable code coverage support])
AC_ARG_ENABLE(coverage,
--
To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/26101
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-smlc
Gerrit-Branch: master
Gerrit-Change-Id: I22f6f4d3d4b81d4791a72a7bce130035bef58c31
Gerrit-Change-Number: 26101
Gerrit-PatchSet: 1
Gerrit-Owner: osmith
Gerrit-MessageType: newchange
Change in osmo-sysmon[master]: configure: don't turn some warnings into errors
osmith has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-sysmon/+/26102 )
Change subject: configure: don't turn some warnings into errors
..
configure: don't turn some warnings into errors
Do not turn some compiler warnings into errors by default. This part was
copied from openbsc.git 34f012 ("Turn some compiler warnings into
errors"), where it was added before --enable-werror was available.
We build with --enable-werror during development and in CI. If the code
is built with a different compiler that throws additional warnings, it
should not stop the build.
Related: OS#5289
Change-Id: I56fb9de59174344b2cb11c60226ae3db43d68766
---
M configure.ac
1 file changed, 0 insertions(+), 12 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-sysmon refs/changes/02/26102/1
diff --git a/configure.ac b/configure.ac
index 63615b8..2546b61 100644
--- a/configure.ac
+++ b/configure.ac
@@ -30,11 +30,6 @@
fi
PKG_PROG_PKG_CONFIG([0.20])
-dnl check for AX_CHECK_COMPILE_FLAG
-m4_ifdef([AX_CHECK_COMPILE_FLAG], [], [
- AC_MSG_ERROR([Please install autoconf-archive; re-run 'autoreconf -fi'
for it to take effect.])
- ])
-
dnl checks for libraries
AC_SEARCH_LIBS([dlopen], [dl dld], [LIBRARY_DL="$LIBS";LIBS=""])
AC_SUBST(LIBRARY_DL)
@@ -96,13 +91,6 @@
CFLAGS="$saved_CFLAGS"
AC_SUBST(SYMBOL_VISIBILITY)
-AX_CHECK_COMPILE_FLAG([-Werror=implicit], [CFLAGS="$CFLAGS -Werror=implicit"])
-AX_CHECK_COMPILE_FLAG([-Werror=maybe-uninitialized], [CFLAGS="$CFLAGS
-Werror=maybe-uninitialized"])
-AX_CHECK_COMPILE_FLAG([-Werror=memset-transposed-args], [CFLAGS="$CFLAGS
-Werror=memset-transposed-args"])
-AX_CHECK_COMPILE_FLAG([-Werror=null-dereference], [CFLAGS="$CFLAGS
-Werror=null-dereference"])
-AX_CHECK_COMPILE_FLAG([-Werror=sizeof-array-argument], [CFLAGS="$CFLAGS
-Werror=sizeof-array-argument"])
-AX_CHECK_COMPILE_FLAG([-Werror=sizeof-pointer-memaccess], [CFLAGS="$CFLAGS
-Werror=sizeof-pointer-memaccess"])
-
# Coverage build taken from WebKit's configure.in
AC_MSG_CHECKING([whether to enable code coverage support])
AC_ARG_ENABLE(coverage,
--
To view, visit https://gerrit.osmocom.org/c/osmo-sysmon/+/26102
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-Change-Id: I56fb9de59174344b2cb11c60226ae3db43d68766
Gerrit-Change-Number: 26102
Gerrit-PatchSet: 1
Gerrit-Owner: osmith
Gerrit-MessageType: newchange
Change in osmo-uecups[master]: configure: don't turn some warnings into errors
osmith has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-uecups/+/26103 )
Change subject: configure: don't turn some warnings into errors
..
configure: don't turn some warnings into errors
Do not turn some compiler warnings into errors by default. This part was
copied from openbsc.git 34f012 ("Turn some compiler warnings into
errors"), where it was added before --enable-werror was available.
We build with --enable-werror during development and in CI. If the code
is built with a different compiler that throws additional warnings, it
should not stop the build.
Related: OS#5289
Change-Id: Idb04e85d1e241f8b53cf338d9e79da198028565d
---
M configure.ac
1 file changed, 0 insertions(+), 12 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-uecups refs/changes/03/26103/1
diff --git a/configure.ac b/configure.ac
index 94bde9d..ba36b3f 100644
--- a/configure.ac
+++ b/configure.ac
@@ -26,11 +26,6 @@
fi
PKG_PROG_PKG_CONFIG([0.20])
-dnl check for AX_CHECK_COMPILE_FLAG
-m4_ifdef([AX_CHECK_COMPILE_FLAG], [], [
-AC_MSG_ERROR([Please install autoconf-archive; re-run 'autoreconf -fi'
for it to take effect.])
-])
-
PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.1.0)
PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.1.0)
PKG_CHECK_MODULES(LIBOSMONETIF, libosmo-netif >= 0.7.0)
@@ -80,13 +75,6 @@
CFLAGS="$saved_CFLAGS"
AC_SUBST(SYMBOL_VISIBILITY)
-AX_CHECK_COMPILE_FLAG([-Werror=implicit], [CFLAGS="$CFLAGS -Werror=implicit"])
-AX_CHECK_COMPILE_FLAG([-Werror=maybe-uninitialized], [CFLAGS="$CFLAGS
-Werror=maybe-uninitialized"])
-AX_CHECK_COMPILE_FLAG([-Werror=memset-transposed-args], [CFLAGS="$CFLAGS
-Werror=memset-transposed-args"])
-AX_CHECK_COMPILE_FLAG([-Wnull-dereference], [CFLAGS="$CFLAGS
-Wnull-dereference"])
-AX_CHECK_COMPILE_FLAG([-Werror=sizeof-array-argument], [CFLAGS="$CFLAGS
-Werror=sizeof-array-argument"])
-AX_CHECK_COMPILE_FLAG([-Werror=sizeof-pointer-memaccess], [CFLAGS="$CFLAGS
-Werror=sizeof-pointer-memaccess"])
-
# Coverage build taken from WebKit's configure.in
AC_MSG_CHECKING([whether to enable code coverage support])
AC_ARG_ENABLE(coverage,
--
To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/26103
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-uecups
Gerrit-Branch: master
Gerrit-Change-Id: Idb04e85d1e241f8b53cf338d9e79da198028565d
Gerrit-Change-Number: 26103
Gerrit-PatchSet: 1
Gerrit-Owner: osmith
Gerrit-MessageType: newchange
Change in osmo-bsc[master]: add time_cc API: cumlative counter for time, reported as rate_ctr
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25973 ) Change subject: add time_cc API: cumlative counter for time, reported as rate_ctr .. Patch Set 1: Sorry for writing so much, but it seems necessary... First off, still open point, orthogonal to rate_ctr vs stat_item decision: Should I remove the configurability features and reduce to one fixed counting behavior? e.g. fix to granularity of seconds, and to the round() rounding scheme? (The customer expressed that either round() or ceil() would be suitable, and floor() is not desirable) ... I think it makes more sense to keep that configurability stuff, now that the code works correctly already. It is a bit of feature creep, the only two arguments to keep it is handwavy "maybe useful at some point in the future"/"maybe some user likes it idk", and a concrete "it would require investing even more effort to remove the features" > Well the question would then be: Can one still use the same external tools > (grafana, elastic search, etc) with rate_ctr? I'm not sure how are those > exported over statsd. Yes, of course! The customer expressed the preferred way of reporting would be a rate counter. Let me explain why, hopefully making more sense this time: In the stats exporting, the main difference is that - a stat_item is exported as the current value in each report. stat_item makes sense for values that rise and (possibly) fall, and where you want to read the actual current value, like number of active cells or say CPU load in percent, or uptime. - a rate_ctr is exported as nr of increments since the last stat report. Makes sense for counting spike events over time. It is suitable where one is interested in increments of a value per time, to see how busy a constantly rising value currently is, rather than the absolute value itself. A stat_item used for this cumulative time counter looks like a slope ramping up, like a staircase: staying a horizontal line at times of no chan exhaustion, and rising at times of chan exhaustion; taken to relative infinity, the value would at some point wrap the integer range. Imagine osmo-bsc ran for weeks, then the value could be a flat line at say 123000, and inc to 123001 when chan exhaustion occurs. For displaying such graph, if you're showing the entire y axis range, the increment is hardly visible. You need to zoom in on the y axis range say 123000 to 123100 to even be able to see that channels are currently exhausted. Or you need to employ math to graph the gradient of the line instead, so that you get 0 for non-exhausted times and spikes for exhausted times. We're interested in the gradient's spikes, i.e. in the "1", and not in the "123000" baseline. A rate_ctr looks like a city skyline, flat line at value 0 for no exhaustion, with spikes at times where chan exhaustion occurs, going back to zero when exhaustion is over. IOW it already *is* the gradient of the chan exhaustion time counter, which is exactly the interesting information: the number of exhausted seconds since the last stat report. A stat_item *would* make sense if it reported, say, the current percent of time where channels are exhausted. If you see the stat showing 100, you know the channels are currently all exhausted for all of the time. So something where the current value is the interesting metric. This however introduces complex design decisions: over what amount of time do we calculate the percentage? should that be configurable? when/how do we degrade the percentage when exhaustion is over? A rate_ctr *is* the simplest, least convoluted and true way of passing the actual useful information to an external stats tool, "and letting grafana figure it out" if the user wants some exhaustion percentage graph; and letting the user's infrastructure figure out whether to evaluate exhaustion over 5/15/30/60 minutes as the spec suggests, without actually introducing these choices to the osmo-bsc code base. > In general I think the main difference on how we see it, is that your focus > is to have it look nice when using VTY Not at all. Looking useful on the VTY is just a side argument. It is a compelling argument nevertheless, the main point being to visualize to you that a rate counter is the proper design choice. Read: "even the VTY output becomes more useful". If I want to quickly check channel exhaustion without graphana, a stat item is very much harder to interpret than a rate counter: you need to repeatedly watch the value change. A rate counter gives you instant information about the gradient, as explained earlier. I have asked a number of times, but you have still not explained to me how a stat_item value should be designed in a useful and simple way. As I'm pointing out, a forever rising value is not very useful. > while my point is that it should in first place be usable for extern
Change in osmo-bts[master]: l1sap: rework handling of DATA.ind on SACCH
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26046 ) Change subject: l1sap: rework handling of DATA.ind on SACCH .. Patch Set 3: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26046 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ifed91f87fd653debc87a09da3fd31ad64a13f330 Gerrit-Change-Number: 26046 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 12:18:53 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-bsc[master]: add chreq:successful_ rate counters
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26068 ) Change subject: add chreq:successful_ rate counters .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/26068/1/src/osmo-bsc/abis_rsl.c File src/osmo-bsc/abis_rsl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/26068/1/src/osmo-bsc/abis_rsl.c@2157 PS1, Line 2157: rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHREQ_ATTEMPTED_EMERG)); BTW, i always dislike these long lines of rate_ctr_inc(rate_ctr_group_get_ctr()) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26068 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I32c2c197a6199617a82986480b686c515fa40d62 Gerrit-Change-Number: 26068 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 12:22:13 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-bts[master]: scheduler: Fix FACCH msg with l2len==0 going to lower layers and logg...
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26090 ) Change subject: scheduler: Fix FACCH msg with l2len==0 going to lower layers and logging errors .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26090 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I43152bc8484a35cd004d3303d3a6e6efcdefa890 Gerrit-Change-Number: 26090 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 12:29:31 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: abis: Try one reconnect to previously connected BSC before trying nex...
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26093 ) Change subject: abis: Try one reconnect to previously connected BSC before trying next one .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26093 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I16b75da5987584d099edc3a640f3a5cd61f3ad69 Gerrit-Change-Number: 26093 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 12:29:44 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: bts-trx: sched_lchan_tchf: Change log level to debug for line informi...
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26091 ) Change subject: bts-trx: sched_lchan_tchf: Change log level to debug for line informing about missing dl prim .. bts-trx: sched_lchan_tchf: Change log level to debug for line informing about missing dl prim This scenario is actually expected when the call is being set up or torn down, since we may not be receiving RTP from the MGW to send to the MS. Hence, let's lower the log level to DEBUG to avoid having log clogged for each call start/stop if INFO is used. Related: SYS#5676 Change-Id: Ib7f274b97cc66d671316eae429ee4baf16831534 --- M src/osmo-bts-trx/sched_lchan_tchf.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve dexter: Looks good to me, approved diff --git a/src/osmo-bts-trx/sched_lchan_tchf.c b/src/osmo-bts-trx/sched_lchan_tchf.c index a6fcd7a..85ab321 100644 --- a/src/osmo-bts-trx/sched_lchan_tchf.c +++ b/src/osmo-bts-trx/sched_lchan_tchf.c @@ -537,7 +537,7 @@ 0x2b, 0x2b, 0x2b, 0x2b, 0x2b, 0x2b, 0x2b, 0x2b, 0x2b, 0x2b, }; - LOGL1SB(DL1P, LOGL_INFO, l1ts, br, "No TCH or FACCH prim for transmit.\n"); + LOGL1SB(DL1P, LOGL_DEBUG, l1ts, br, "No TCH or FACCH prim for transmit.\n"); gsm0503_tch_fr_encode(*bursts_p, dummy, sizeof(dummy), 1); goto send_burst; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26091 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ib7f274b97cc66d671316eae429ee4baf16831534 Gerrit-Change-Number: 26091 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged
Change in osmo-bts[master]: scheduler: Fix FACCH msg with l2len==0 going to lower layers and logg...
pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/26090 )
Change subject: scheduler: Fix FACCH msg with l2len==0 going to lower layers
and logging errors
..
scheduler: Fix FACCH msg with l2len==0 going to lower layers and logging errors
Recent commit (see below) changed a check to avoid weird results for msg
which had l2h=NULL, since l2len would return unexpected results there.
However, some code branches like FACCH or TCH seem to be always setting
l2h even if len=0. Hence, we must test either of the 2 scenarios (null
pointer and l2len()).
This commit fixes the following message appearing all the time during
calls:
"""
TCH/F: Prim has odd len=0 != 23
"""
Fixes: fb905b8d235ff2efe6c1cd9fde2b488b311c1cd7
Related: SYS#5676
Related: SYS#4919
Change-Id: I43152bc8484a35cd004d3303d3a6e6efcdefa890
---
M src/common/scheduler.c
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, but someone else must approve
fixeria: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
diff --git a/src/common/scheduler.c b/src/common/scheduler.c
index 0388445..ba5c18a 100644
--- a/src/common/scheduler.c
+++ b/src/common/scheduler.c
@@ -869,7 +869,7 @@
OSMO_ASSERT(l1sap->oph.msg);
/* ignore empty frame */
- if (!l1sap->oph.msg->l2h) {
+ if (!l1sap->oph.msg->l2h || msgb_l2len(l1sap->oph.msg) == 0) {
msgb_free(l1sap->oph.msg);
return 0;
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26090
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I43152bc8484a35cd004d3303d3a6e6efcdefa890
Gerrit-Change-Number: 26090
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-bts[master]: abis: Drop unneded if condition in else clause
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26092 ) Change subject: abis: Drop unneded if condition in else clause .. abis: Drop unneded if condition in else clause priv->current_bsc will for sure be != last, otherwise it would have entered the if clause above it. Change-Id: I0a6519f7b93f0b45c67d19fef4f50daeeefc7340 --- M src/common/abis.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved dexter: Looks good to me, approved diff --git a/src/common/abis.c b/src/common/abis.c index c0cd18c..06e6f3b 100644 --- a/src/common/abis.c +++ b/src/common/abis.c @@ -126,7 +126,7 @@ if (!priv->current_bsc || priv->current_bsc == last) /* Pick first one (wrap around): */ priv->current_bsc = (struct bsc_oml_host *)llist_first_entry(&bts->bsc_oml_hosts, struct bsc_oml_host, list); - else if (priv->current_bsc != last) + else priv->current_bsc = (struct bsc_oml_host *)llist_entry(priv->current_bsc->list.next, struct bsc_oml_host, list); return 0; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26092 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I0a6519f7b93f0b45c67d19fef4f50daeeefc7340 Gerrit-Change-Number: 26092 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged
Change in osmo-bts[master]: bts-trx: sched_lchan_tchf: Drop impossible code path
pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/26088 )
Change subject: bts-trx: sched_lchan_tchf: Drop impossible code path
..
bts-trx: sched_lchan_tchf: Drop impossible code path
It cannot happen that msg1 is NULL and msg2 is not null, since they are
deuqueed from same place. Only possible combinations are:
msg1!=NULL && msg2!=NULL
msg1!=NULL && msg2==NULL
Change-Id: Ifd789844b1a7dfba596664de440d4c20b9f4c78f
---
M src/osmo-bts-trx/sched_lchan_tchf.c
1 file changed, 0 insertions(+), 6 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, but someone else must approve
fixeria: Looks good to me, approved
diff --git a/src/osmo-bts-trx/sched_lchan_tchf.c
b/src/osmo-bts-trx/sched_lchan_tchf.c
index 20a4077..a6fcd7a 100644
--- a/src/osmo-bts-trx/sched_lchan_tchf.c
+++ b/src/osmo-bts-trx/sched_lchan_tchf.c
@@ -398,12 +398,6 @@
msg_tch = msg2;
}
}
- } else if (msg2) {
- l1sap = msgb_l1sap_prim(msg2);
- if (l1sap->oph.primitive == PRIM_TCH)
- msg_tch = msg2;
- else
- msg_facch = msg2;
}
/* check validity of message */
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26088
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ifd789844b1a7dfba596664de440d4c20b9f4c78f
Gerrit-Change-Number: 26088
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-bts[master]: abis: Try one reconnect to previously connected BSC before trying nex...
pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/26093 )
Change subject: abis: Try one reconnect to previously connected BSC before
trying next one
..
abis: Try one reconnect to previously connected BSC before trying next one
This way we keep all BTS connected to the same BSC if there was a
spurious network problem.
Related: SYS#4971
Change-Id: I16b75da5987584d099edc3a640f3a5cd61f3ad69
---
M src/common/abis.c
1 file changed, 11 insertions(+), 0 deletions(-)
Approvals:
laforge: Looks good to me, but someone else must approve
fixeria: Looks good to me, but someone else must approve
dexter: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/common/abis.c b/src/common/abis.c
index 06e6f3b..4afe81a 100644
--- a/src/common/abis.c
+++ b/src/common/abis.c
@@ -82,6 +82,7 @@
struct bsc_oml_host *current_bsc;
struct gsm_bts *bts;
char *model_name;
+ bool reconnect_to_current_bsc;
};
static void reset_oml_link(struct gsm_bts *bts)
@@ -122,6 +123,13 @@
return -1;
}
+ /* Keep current pointer to priv->current_bsc: */
+ if (priv->reconnect_to_current_bsc) {
+ OSMO_ASSERT(priv->current_bsc);
+ priv->reconnect_to_current_bsc = false;
+ return 0;
+ }
+
last = (struct bsc_oml_host *)llist_last_entry(&bts->bsc_oml_hosts,
struct bsc_oml_host, list);
if (!priv->current_bsc || priv->current_bsc == last) /* Pick first one
(wrap around): */
@@ -233,6 +241,9 @@
* line when something goes wrong... */
}
bts_model_abis_close(bts);
+
+ /* We want to try reconnecting to the current BSC at least once before
switching to a new one: */
+ priv->reconnect_to_current_bsc = true;
osmo_fsm_inst_state_chg(fi, ABIS_LINK_ST_WAIT_RECONNECT,
OML_RETRY_TIMER, 0);
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26093
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I16b75da5987584d099edc3a640f3a5cd61f3ad69
Gerrit-Change-Number: 26093
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-bsc[master]: Revert "Turn some compiler warnings into errors"
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26095 ) Change subject: Revert "Turn some compiler warnings into errors" .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26095 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6b143b803349b97e783c586615d7f2ed4e1ff058 Gerrit-Change-Number: 26095 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 12:32:53 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-msc[master]: Revert "Turn some compiler warnings into errors"
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26096 ) Change subject: Revert "Turn some compiler warnings into errors" .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26096 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ideff462157a034e053e5e7049605dd8d24440905 Gerrit-Change-Number: 26096 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 12:32:59 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-mgw[master]: Revert "Turn some compiler warnings into errors"
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26097 ) Change subject: Revert "Turn some compiler warnings into errors" .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26097 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6042f917a5a891dd13cb96d9477a45a45a7b35fe Gerrit-Change-Number: 26097 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 12:33:06 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-gbproxy[master]: Revert "Turn some compiler warnings into errors"
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/26100 ) Change subject: Revert "Turn some compiler warnings into errors" .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26100 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I2fb777410ffc181feabd6aee3beda3ed05ba5c90 Gerrit-Change-Number: 26100 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 12:33:19 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-sgsn[master]: Revert "Turn some compiler warnings into errors"
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/26098 ) Change subject: Revert "Turn some compiler warnings into errors" .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/26098 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I24e0a0d7f93f196dc642e37b03f68464024c09d4 Gerrit-Change-Number: 26098 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 12:33:12 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-e1-recorder[master]: configure: don't turn some warnings into errors
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/26099 ) Change subject: configure: don't turn some warnings into errors .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-recorder/+/26099 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-recorder Gerrit-Branch: master Gerrit-Change-Id: Ib5602017545d68f0fdb0b4df7ed3087a2cb1775c Gerrit-Change-Number: 26099 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 12:33:27 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-smlc[master]: configure: don't turn some warnings into errors
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-smlc/+/26101 ) Change subject: configure: don't turn some warnings into errors .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/26101 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: I22f6f4d3d4b81d4791a72a7bce130035bef58c31 Gerrit-Change-Number: 26101 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 12:33:33 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-sysmon[master]: configure: don't turn some warnings into errors
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sysmon/+/26102 ) Change subject: configure: don't turn some warnings into errors .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sysmon/+/26102 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-Change-Id: I56fb9de59174344b2cb11c60226ae3db43d68766 Gerrit-Change-Number: 26102 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 12:33:40 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-uecups[master]: configure: don't turn some warnings into errors
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-uecups/+/26103 ) Change subject: configure: don't turn some warnings into errors .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/26103 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-uecups Gerrit-Branch: master Gerrit-Change-Id: Idb04e85d1e241f8b53cf338d9e79da198028565d Gerrit-Change-Number: 26103 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 12:33:47 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: add chreq:successful_ rate counters
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26068 ) Change subject: add chreq:successful_ rate counters .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/26068/1/src/osmo-bsc/abis_rsl.c File src/osmo-bsc/abis_rsl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/26068/1/src/osmo-bsc/abis_rsl.c@2157 PS1, Line 2157: rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHREQ_ATTEMPTED_EMERG)); > BTW, i always dislike these long lines of > rate_ctr_inc(rate_ctr_group_get_ctr()) Feel free to add a rate_ctr_group_ctr_inc() or alike: rate_ctr_group_ctr_inc(bts->bts_ctrs, BTS_CTR_CHREQ_ATTEMPTED_CALL); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26068 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I32c2c197a6199617a82986480b686c515fa40d62 Gerrit-Change-Number: 26068 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 12:36:07 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels Gerrit-MessageType: comment
Change in osmo-bts[master]: measurement: get rid of *le in lchan_meas_handle_sacch()
Hello Jenkins Builder, laforge, pespin, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/26051 to look at the new patch set (#3). Change subject: measurement: get rid of *le in lchan_meas_handle_sacch() .. measurement: get rid of *le in lchan_meas_handle_sacch() The current Timing Advance value can be obtained either from the L1 SACCH header (if received) or from lchan->ta_ctrl.current. Change-Id: I2b3693a0e49f03f2b4496c9dbd30cf47e9bc86b5 --- M src/common/measurement.c 1 file changed, 3 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/51/26051/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26051 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I2b3693a0e49f03f2b4496c9dbd30cf47e9bc86b5 Gerrit-Change-Number: 26051 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmo-bts[master]: l1sap: rework handling of DATA.ind on SACCH
Hello Jenkins Builder, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-bts/+/26046
to look at the new patch set (#4).
Change subject: l1sap: rework handling of DATA.ind on SACCH
..
l1sap: rework handling of DATA.ind on SACCH
Currently an Uplink SACCH block is being passed to LAPDm first, and
then gets forwareded to the BSC in handle_ms_meas_report(), together
with the Uplink measurements collected so far.
This approach has a serious flaw: handle_ms_meas_report() won't be
called if an Uplink block contains SAPI=3 data (SMS) or was not
decoded at all (len=0) fow whatever reason. Therefore, no RSL
MEASurement RESult message will be sent to the BSC.
Rename handle_ms_meas_report() to lchan_meas_handle_sacch(), and call
it from l1sap_ph_data_ind(). This way perioduc RSL MEASurement RESult
messages will be sent regardless of what happens on Uplink SACCH.
Change-Id: Ifed91f87fd653debc87a09da3fd31ad64a13f330
Fixes: TC_meas_res_speech_{tchf,tchh}_sapi3
Related: SYS#5319
---
M include/osmo-bts/measurement.h
M src/common/l1sap.c
M src/common/measurement.c
M src/common/rsl.c
4 files changed, 84 insertions(+), 74 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/46/26046/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26046
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ifed91f87fd653debc87a09da3fd31ad64a13f330
Gerrit-Change-Number: 26046
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: newpatchset
Change in osmo-bts[master]: l1sap: rework handling of DATA.ind on SACCH
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26046 ) Change subject: l1sap: rework handling of DATA.ind on SACCH .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26046 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ifed91f87fd653debc87a09da3fd31ad64a13f330 Gerrit-Change-Number: 26046 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 13:00:16 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: measurement: get rid of *le in lchan_meas_handle_sacch()
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26051 ) Change subject: measurement: get rid of *le in lchan_meas_handle_sacch() .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26051 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I2b3693a0e49f03f2b4496c9dbd30cf47e9bc86b5 Gerrit-Change-Number: 26051 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 13:00:40 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-uecups[master]: configure: don't turn some warnings into errors
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-uecups/+/26103 ) Change subject: configure: don't turn some warnings into errors .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/26103 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-uecups Gerrit-Branch: master Gerrit-Change-Id: Idb04e85d1e241f8b53cf338d9e79da198028565d Gerrit-Change-Number: 26103 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 13:01:36 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: add time_cc API: cumlative counter for time, reported as rate_ctr
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25973 ) Change subject: add time_cc API: cumlative counter for time, reported as rate_ctr .. Patch Set 1: Configurability features: Ok fine to keep them. So AFAIU the problem boils down to not wanting an ever increasing value, which means stat_item would need to be reset to 0 when you stop counting, but then sub-period increases would be lost (not announced/visible to statsd). Fine then, please do the documentation improvements you already ACKed. I'd really add structure wrappers to allocate/free the struct, so that users don't need to care about details and we can later on expand them as we see is needed. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25973 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icdd36f27cb54b2e1b940c9e6404ba9dd3692a310 Gerrit-Change-Number: 25973 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 13:01:51 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-uecups[master]: configure: don't turn some warnings into errors
laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-uecups/+/26103 )
Change subject: configure: don't turn some warnings into errors
..
configure: don't turn some warnings into errors
Do not turn some compiler warnings into errors by default. This part was
copied from openbsc.git 34f012 ("Turn some compiler warnings into
errors"), where it was added before --enable-werror was available.
We build with --enable-werror during development and in CI. If the code
is built with a different compiler that throws additional warnings, it
should not stop the build.
Related: OS#5289
Change-Id: Idb04e85d1e241f8b53cf338d9e79da198028565d
---
M configure.ac
1 file changed, 0 insertions(+), 12 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
diff --git a/configure.ac b/configure.ac
index 94bde9d..ba36b3f 100644
--- a/configure.ac
+++ b/configure.ac
@@ -26,11 +26,6 @@
fi
PKG_PROG_PKG_CONFIG([0.20])
-dnl check for AX_CHECK_COMPILE_FLAG
-m4_ifdef([AX_CHECK_COMPILE_FLAG], [], [
-AC_MSG_ERROR([Please install autoconf-archive; re-run 'autoreconf -fi'
for it to take effect.])
-])
-
PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.1.0)
PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.1.0)
PKG_CHECK_MODULES(LIBOSMONETIF, libosmo-netif >= 0.7.0)
@@ -80,13 +75,6 @@
CFLAGS="$saved_CFLAGS"
AC_SUBST(SYMBOL_VISIBILITY)
-AX_CHECK_COMPILE_FLAG([-Werror=implicit], [CFLAGS="$CFLAGS -Werror=implicit"])
-AX_CHECK_COMPILE_FLAG([-Werror=maybe-uninitialized], [CFLAGS="$CFLAGS
-Werror=maybe-uninitialized"])
-AX_CHECK_COMPILE_FLAG([-Werror=memset-transposed-args], [CFLAGS="$CFLAGS
-Werror=memset-transposed-args"])
-AX_CHECK_COMPILE_FLAG([-Wnull-dereference], [CFLAGS="$CFLAGS
-Wnull-dereference"])
-AX_CHECK_COMPILE_FLAG([-Werror=sizeof-array-argument], [CFLAGS="$CFLAGS
-Werror=sizeof-array-argument"])
-AX_CHECK_COMPILE_FLAG([-Werror=sizeof-pointer-memaccess], [CFLAGS="$CFLAGS
-Werror=sizeof-pointer-memaccess"])
-
# Coverage build taken from WebKit's configure.in
AC_MSG_CHECKING([whether to enable code coverage support])
AC_ARG_ENABLE(coverage,
--
To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/26103
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-uecups
Gerrit-Branch: master
Gerrit-Change-Id: Idb04e85d1e241f8b53cf338d9e79da198028565d
Gerrit-Change-Number: 26103
Gerrit-PatchSet: 1
Gerrit-Owner: osmith
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-sysmon[master]: configure: don't turn some warnings into errors
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sysmon/+/26102 ) Change subject: configure: don't turn some warnings into errors .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sysmon/+/26102 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-Change-Id: I56fb9de59174344b2cb11c60226ae3db43d68766 Gerrit-Change-Number: 26102 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 13:02:14 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-sysmon[master]: configure: don't turn some warnings into errors
laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-sysmon/+/26102 )
Change subject: configure: don't turn some warnings into errors
..
configure: don't turn some warnings into errors
Do not turn some compiler warnings into errors by default. This part was
copied from openbsc.git 34f012 ("Turn some compiler warnings into
errors"), where it was added before --enable-werror was available.
We build with --enable-werror during development and in CI. If the code
is built with a different compiler that throws additional warnings, it
should not stop the build.
Related: OS#5289
Change-Id: I56fb9de59174344b2cb11c60226ae3db43d68766
---
M configure.ac
1 file changed, 0 insertions(+), 12 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
diff --git a/configure.ac b/configure.ac
index 63615b8..2546b61 100644
--- a/configure.ac
+++ b/configure.ac
@@ -30,11 +30,6 @@
fi
PKG_PROG_PKG_CONFIG([0.20])
-dnl check for AX_CHECK_COMPILE_FLAG
-m4_ifdef([AX_CHECK_COMPILE_FLAG], [], [
- AC_MSG_ERROR([Please install autoconf-archive; re-run 'autoreconf -fi'
for it to take effect.])
- ])
-
dnl checks for libraries
AC_SEARCH_LIBS([dlopen], [dl dld], [LIBRARY_DL="$LIBS";LIBS=""])
AC_SUBST(LIBRARY_DL)
@@ -96,13 +91,6 @@
CFLAGS="$saved_CFLAGS"
AC_SUBST(SYMBOL_VISIBILITY)
-AX_CHECK_COMPILE_FLAG([-Werror=implicit], [CFLAGS="$CFLAGS -Werror=implicit"])
-AX_CHECK_COMPILE_FLAG([-Werror=maybe-uninitialized], [CFLAGS="$CFLAGS
-Werror=maybe-uninitialized"])
-AX_CHECK_COMPILE_FLAG([-Werror=memset-transposed-args], [CFLAGS="$CFLAGS
-Werror=memset-transposed-args"])
-AX_CHECK_COMPILE_FLAG([-Werror=null-dereference], [CFLAGS="$CFLAGS
-Werror=null-dereference"])
-AX_CHECK_COMPILE_FLAG([-Werror=sizeof-array-argument], [CFLAGS="$CFLAGS
-Werror=sizeof-array-argument"])
-AX_CHECK_COMPILE_FLAG([-Werror=sizeof-pointer-memaccess], [CFLAGS="$CFLAGS
-Werror=sizeof-pointer-memaccess"])
-
# Coverage build taken from WebKit's configure.in
AC_MSG_CHECKING([whether to enable code coverage support])
AC_ARG_ENABLE(coverage,
--
To view, visit https://gerrit.osmocom.org/c/osmo-sysmon/+/26102
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-Change-Id: I56fb9de59174344b2cb11c60226ae3db43d68766
Gerrit-Change-Number: 26102
Gerrit-PatchSet: 1
Gerrit-Owner: osmith
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-smlc[master]: configure: don't turn some warnings into errors
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-smlc/+/26101 ) Change subject: configure: don't turn some warnings into errors .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/26101 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: I22f6f4d3d4b81d4791a72a7bce130035bef58c31 Gerrit-Change-Number: 26101 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 13:02:24 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-smlc[master]: configure: don't turn some warnings into errors
laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-smlc/+/26101 )
Change subject: configure: don't turn some warnings into errors
..
configure: don't turn some warnings into errors
Do not turn some compiler warnings into errors by default. This part was
copied from openbsc.git 34f012 ("Turn some compiler warnings into
errors"), where it was added before --enable-werror was available.
We build with --enable-werror during development and in CI. If the code
is built with a different compiler that throws additional warnings, it
should not stop the build.
Related: OS#5289
Change-Id: I22f6f4d3d4b81d4791a72a7bce130035bef58c31
---
M configure.ac
1 file changed, 0 insertions(+), 12 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
diff --git a/configure.ac b/configure.ac
index e4b902b..eed5ee9 100644
--- a/configure.ac
+++ b/configure.ac
@@ -34,11 +34,6 @@
fi
PKG_PROG_PKG_CONFIG([0.20])
-dnl check for AX_CHECK_COMPILE_FLAG
-m4_ifdef([AX_CHECK_COMPILE_FLAG], [], [
- AC_MSG_ERROR([Please install autoconf-archive; re-run 'autoreconf -fi'
for it to take effect.])
- ])
-
PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.5.0)
PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.5.0)
PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.5.0)
@@ -92,13 +87,6 @@
CFLAGS="$saved_CFLAGS"
AC_SUBST(SYMBOL_VISIBILITY)
-AX_CHECK_COMPILE_FLAG([-Werror=implicit], [CFLAGS="$CFLAGS -Werror=implicit"])
-AX_CHECK_COMPILE_FLAG([-Werror=maybe-uninitialized], [CFLAGS="$CFLAGS
-Werror=maybe-uninitialized"])
-AX_CHECK_COMPILE_FLAG([-Werror=memset-transposed-args], [CFLAGS="$CFLAGS
-Werror=memset-transposed-args"])
-AX_CHECK_COMPILE_FLAG([-Wnull-dereference], [CFLAGS="$CFLAGS
-Wnull-dereference"])
-AX_CHECK_COMPILE_FLAG([-Werror=sizeof-array-argument], [CFLAGS="$CFLAGS
-Werror=sizeof-array-argument"])
-AX_CHECK_COMPILE_FLAG([-Werror=sizeof-pointer-memaccess], [CFLAGS="$CFLAGS
-Werror=sizeof-pointer-memaccess"])
-
# Coverage build taken from WebKit's configure.in
AC_MSG_CHECKING([whether to enable code coverage support])
AC_ARG_ENABLE(coverage,
--
To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/26101
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-smlc
Gerrit-Branch: master
Gerrit-Change-Id: I22f6f4d3d4b81d4791a72a7bce130035bef58c31
Gerrit-Change-Number: 26101
Gerrit-PatchSet: 1
Gerrit-Owner: osmith
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-e1-recorder[master]: configure: don't turn some warnings into errors
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/26099 ) Change subject: configure: don't turn some warnings into errors .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-recorder/+/26099 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-recorder Gerrit-Branch: master Gerrit-Change-Id: Ib5602017545d68f0fdb0b4df7ed3087a2cb1775c Gerrit-Change-Number: 26099 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 13:02:30 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-e1-recorder[master]: configure: don't turn some warnings into errors
laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-e1-recorder/+/26099 )
Change subject: configure: don't turn some warnings into errors
..
configure: don't turn some warnings into errors
Do not turn some compiler warnings into errors by default. This part was
copied from openbsc.git 34f012 ("Turn some compiler warnings into
errors"), where it was added before --enable-werror was available.
We build with --enable-werror during development and in CI. If the code
is built with a different compiler that throws additional warnings, it
should not stop the build.
Related: OS#5289
Change-Id: Ib5602017545d68f0fdb0b4df7ed3087a2cb1775c
---
M configure.ac
1 file changed, 0 insertions(+), 12 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
diff --git a/configure.ac b/configure.ac
index e986809..cec703f 100644
--- a/configure.ac
+++ b/configure.ac
@@ -31,11 +31,6 @@
fi
PKG_PROG_PKG_CONFIG([0.20])
-dnl check for AX_CHECK_COMPILE_FLAG
-m4_ifdef([AX_CHECK_COMPILE_FLAG], [], [
- AC_MSG_ERROR([Please install autoconf-archive; re-run 'autoreconf -fi'
for it to take effect.])
- ])
-
PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.2.0)
PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.2.0)
PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.2.0)
@@ -87,13 +82,6 @@
CFLAGS="$saved_CFLAGS"
AC_SUBST(SYMBOL_VISIBILITY)
-AX_CHECK_COMPILE_FLAG([-Werror=implicit], [CFLAGS="$CFLAGS -Werror=implicit"])
-AX_CHECK_COMPILE_FLAG([-Werror=maybe-uninitialized], [CFLAGS="$CFLAGS
-Werror=maybe-uninitialized"])
-AX_CHECK_COMPILE_FLAG([-Werror=memset-transposed-args], [CFLAGS="$CFLAGS
-Werror=memset-transposed-args"])
-AX_CHECK_COMPILE_FLAG([-Wnull-dereference], [CFLAGS="$CFLAGS
-Wnull-dereference"])
-AX_CHECK_COMPILE_FLAG([-Werror=sizeof-array-argument], [CFLAGS="$CFLAGS
-Werror=sizeof-array-argument"])
-AX_CHECK_COMPILE_FLAG([-Werror=sizeof-pointer-memaccess], [CFLAGS="$CFLAGS
-Werror=sizeof-pointer-memaccess"])
-
# Coverage build taken from WebKit's configure.in
AC_MSG_CHECKING([whether to enable code coverage support])
AC_ARG_ENABLE(coverage,
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1-recorder/+/26099
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1-recorder
Gerrit-Branch: master
Gerrit-Change-Id: Ib5602017545d68f0fdb0b4df7ed3087a2cb1775c
Gerrit-Change-Number: 26099
Gerrit-PatchSet: 1
Gerrit-Owner: osmith
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-gbproxy[master]: Revert "Turn some compiler warnings into errors"
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/26100 ) Change subject: Revert "Turn some compiler warnings into errors" .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26100 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I2fb777410ffc181feabd6aee3beda3ed05ba5c90 Gerrit-Change-Number: 26100 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 13:02:50 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-gbproxy[master]: Revert "Turn some compiler warnings into errors"
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/26100 ) Change subject: Revert "Turn some compiler warnings into errors" .. Revert "Turn some compiler warnings into errors" Do not turn some compiler warnings into errors by default. This patch was added before --enable-werror was available. We build with --enable-werror during development and in CI. If the code is built with a different compiler that throws additional warnings, it should not stop the build. This reverts commit 34f012639ddf41470714ae74ae961d158670a4c7. Related: OS#5289 Change-Id: I2fb777410ffc181feabd6aee3beda3ed05ba5c90 --- M configure.ac 1 file changed, 0 insertions(+), 12 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/configure.ac b/configure.ac index 309d3f7..11ebac4 100644 --- a/configure.ac +++ b/configure.ac @@ -34,11 +34,6 @@ fi PKG_PROG_PKG_CONFIG([0.20]) -dnl check for AX_CHECK_COMPILE_FLAG -m4_ifdef([AX_CHECK_COMPILE_FLAG], [], [ - AC_MSG_ERROR([Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect.]) - ]) - dnl use a defined standard across all builds and don't depend on compiler default CFLAGS="$CFLAGS -std=gnu11" @@ -105,13 +100,6 @@ CPPFLAGS="$CPPFLAGS -Wall -Wno-trigraphs" CFLAGS="$CFLAGS -Wall -Wno-trigraphs" -AX_CHECK_COMPILE_FLAG([-Werror=implicit], [CFLAGS="$CFLAGS -Werror=implicit"]) -AX_CHECK_COMPILE_FLAG([-Werror=maybe-uninitialized], [CFLAGS="$CFLAGS -Werror=maybe-uninitialized"]) -AX_CHECK_COMPILE_FLAG([-Werror=memset-transposed-args], [CFLAGS="$CFLAGS -Werror=memset-transposed-args"]) -AX_CHECK_COMPILE_FLAG([-Wnull-dereference], [CFLAGS="$CFLAGS -Wnull-dereference"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-array-argument], [CFLAGS="$CFLAGS -Werror=sizeof-array-argument"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-pointer-memaccess], [CFLAGS="$CFLAGS -Werror=sizeof-pointer-memaccess"]) - # Coverage build taken from WebKit's configure.in AC_MSG_CHECKING([whether to enable code coverage support]) AC_ARG_ENABLE(coverage, -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/26100 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I2fb777410ffc181feabd6aee3beda3ed05ba5c90 Gerrit-Change-Number: 26100 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged
Change in osmo-sgsn[master]: Revert "Turn some compiler warnings into errors"
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/26098 ) Change subject: Revert "Turn some compiler warnings into errors" .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/26098 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I24e0a0d7f93f196dc642e37b03f68464024c09d4 Gerrit-Change-Number: 26098 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 13:03:01 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-sgsn[master]: Revert "Turn some compiler warnings into errors"
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/26098 ) Change subject: Revert "Turn some compiler warnings into errors" .. Revert "Turn some compiler warnings into errors" Do not turn some compiler warnings into errors by default. This patch was added before --enable-werror was available. We build with --enable-werror during development and in CI. If the code is built with a different compiler that throws additional warnings, it should not stop the build. This reverts commit 34f012639ddf41470714ae74ae961d158670a4c7. Related: OS#5289 Change-Id: I24e0a0d7f93f196dc642e37b03f68464024c09d4 --- M configure.ac 1 file changed, 0 insertions(+), 12 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/configure.ac b/configure.ac index c29bacb..9607373 100644 --- a/configure.ac +++ b/configure.ac @@ -34,11 +34,6 @@ fi PKG_PROG_PKG_CONFIG([0.20]) -dnl check for AX_CHECK_COMPILE_FLAG -m4_ifdef([AX_CHECK_COMPILE_FLAG], [], [ - AC_MSG_ERROR([Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect.]) - ]) - dnl use a defined standard across all builds and don't depend on compiler default CFLAGS="$CFLAGS -std=gnu11" @@ -124,13 +119,6 @@ CPPFLAGS="$CPPFLAGS -Wall -Wno-trigraphs" CFLAGS="$CFLAGS -Wall -Wno-trigraphs" -AX_CHECK_COMPILE_FLAG([-Werror=implicit], [CFLAGS="$CFLAGS -Werror=implicit"]) -AX_CHECK_COMPILE_FLAG([-Werror=maybe-uninitialized], [CFLAGS="$CFLAGS -Werror=maybe-uninitialized"]) -AX_CHECK_COMPILE_FLAG([-Werror=memset-transposed-args], [CFLAGS="$CFLAGS -Werror=memset-transposed-args"]) -AX_CHECK_COMPILE_FLAG([-Wnull-dereference], [CFLAGS="$CFLAGS -Wnull-dereference"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-array-argument], [CFLAGS="$CFLAGS -Werror=sizeof-array-argument"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-pointer-memaccess], [CFLAGS="$CFLAGS -Werror=sizeof-pointer-memaccess"]) - # Coverage build taken from WebKit's configure.in AC_MSG_CHECKING([whether to enable code coverage support]) AC_ARG_ENABLE(coverage, -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/26098 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I24e0a0d7f93f196dc642e37b03f68464024c09d4 Gerrit-Change-Number: 26098 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged
Change in osmo-mgw[master]: Revert "Turn some compiler warnings into errors"
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26097 ) Change subject: Revert "Turn some compiler warnings into errors" .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26097 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6042f917a5a891dd13cb96d9477a45a45a7b35fe Gerrit-Change-Number: 26097 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 13:03:09 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-msc[master]: Revert "Turn some compiler warnings into errors"
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26096 ) Change subject: Revert "Turn some compiler warnings into errors" .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26096 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ideff462157a034e053e5e7049605dd8d24440905 Gerrit-Change-Number: 26096 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 13:03:14 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-mgw[master]: Revert "Turn some compiler warnings into errors"
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26097 ) Change subject: Revert "Turn some compiler warnings into errors" .. Revert "Turn some compiler warnings into errors" Do not turn some compiler warnings into errors by default. This patch was added before --enable-werror was available. We build with --enable-werror during development and in CI. If the code is built with a different compiler that throws additional warnings, it should not stop the build. This reverts commit 34f012639ddf41470714ae74ae961d158670a4c7. Related: OS#5289 Change-Id: I6042f917a5a891dd13cb96d9477a45a45a7b35fe --- M configure.ac 1 file changed, 0 insertions(+), 15 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/configure.ac b/configure.ac index b996e87..ddd8862 100644 --- a/configure.ac +++ b/configure.ac @@ -36,11 +36,6 @@ fi PKG_PROG_PKG_CONFIG([0.20]) -dnl check for AX_CHECK_COMPILE_FLAG -m4_ifdef([AX_CHECK_COMPILE_FLAG], [], [ - AC_MSG_ERROR([Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect.]) - ]) - dnl checks for libraries AC_SEARCH_LIBS([dlopen], [dl dld], [LIBRARY_DL="$LIBS";LIBS=""]) AC_SUBST(LIBRARY_DL) @@ -90,16 +85,6 @@ CPPFLAGS="$CPPFLAGS $WERROR_FLAGS" fi -dnl Checks for typedefs, structures and compiler characteristics - -AX_CHECK_COMPILE_FLAG([-Werror=implicit], [CFLAGS="$CFLAGS -Werror=implicit"]) -AX_CHECK_COMPILE_FLAG([-Werror=maybe-uninitialized], [CFLAGS="$CFLAGS -Werror=maybe-uninitialized"],,[-Werror]) -AX_CHECK_COMPILE_FLAG([-Werror=sometimes-uninitialized], [CFLAGS="$CFLAGS -Werror=sometimes-uninitialized"],,[-Werror]) -AX_CHECK_COMPILE_FLAG([-Werror=memset-transposed-args], [CFLAGS="$CFLAGS -Werror=memset-transposed-args"]) -AX_CHECK_COMPILE_FLAG([-Wnull-dereference], [CFLAGS="$CFLAGS -Wnull-dereference"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-array-argument], [CFLAGS="$CFLAGS -Werror=sizeof-array-argument"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-pointer-memaccess], [CFLAGS="$CFLAGS -Werror=sizeof-pointer-memaccess"]) - # Coverage build taken from WebKit's configure.in AC_MSG_CHECKING([whether to enable code coverage support]) AC_ARG_ENABLE(coverage, -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26097 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6042f917a5a891dd13cb96d9477a45a45a7b35fe Gerrit-Change-Number: 26097 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged
Change in osmo-msc[master]: Revert "Turn some compiler warnings into errors"
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/26096 ) Change subject: Revert "Turn some compiler warnings into errors" .. Revert "Turn some compiler warnings into errors" Do not turn some compiler warnings into errors by default. This patch was added before --enable-werror was available. We build with --enable-werror during development and in CI. If the code is built with a different compiler that throws additional warnings, it should not stop the build. This reverts commit 34f012639ddf41470714ae74ae961d158670a4c7. Related: OS#5289 Change-Id: Ideff462157a034e053e5e7049605dd8d24440905 --- M configure.ac 1 file changed, 0 insertions(+), 15 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/configure.ac b/configure.ac index 1207171..702be9f 100644 --- a/configure.ac +++ b/configure.ac @@ -36,12 +36,6 @@ fi PKG_PROG_PKG_CONFIG([0.20]) -dnl check for AX_CHECK_COMPILE_FLAG -m4_ifdef([AX_CHECK_COMPILE_FLAG], [], [ - AC_MSG_ERROR([Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect.]) - ]) - - PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.5.0) PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.5.0) PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.5.0) @@ -119,15 +113,6 @@ AC_HEADER_STDC AC_CHECK_HEADERS(dbi/dbd.h,,AC_MSG_ERROR(DBI library is not installed)) - -dnl Checks for typedefs, structures and compiler characteristics -AX_CHECK_COMPILE_FLAG([-Werror=implicit], [CFLAGS="$CFLAGS -Werror=implicit"]) -AX_CHECK_COMPILE_FLAG([-Werror=maybe-uninitialized], [CFLAGS="$CFLAGS -Werror=maybe-uninitialized"]) -AX_CHECK_COMPILE_FLAG([-Werror=memset-transposed-args], [CFLAGS="$CFLAGS -Werror=memset-transposed-args"]) -AX_CHECK_COMPILE_FLAG([-Wnull-dereference], [CFLAGS="$CFLAGS -Wnull-dereference"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-array-argument], [CFLAGS="$CFLAGS -Werror=sizeof-array-argument"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-pointer-memaccess], [CFLAGS="$CFLAGS -Werror=sizeof-pointer-memaccess"]) - # Coverage build taken from WebKit's configure.in AC_MSG_CHECKING([whether to enable code coverage support]) AC_ARG_ENABLE(coverage, -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26096 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ideff462157a034e053e5e7049605dd8d24440905 Gerrit-Change-Number: 26096 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged
Change in osmo-bsc[master]: Revert "Turn some compiler warnings into errors"
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26095 ) Change subject: Revert "Turn some compiler warnings into errors" .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26095 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6b143b803349b97e783c586615d7f2ed4e1ff058 Gerrit-Change-Number: 26095 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 13:03:23 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: Revert "Turn some compiler warnings into errors"
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26095 ) Change subject: Revert "Turn some compiler warnings into errors" .. Revert "Turn some compiler warnings into errors" Do not turn some compiler warnings into errors by default. This patch was added before --enable-werror was available. We build with --enable-werror during development and in CI. If the code is built with a different compiler that throws additional warnings, it should not stop the build. This reverts commit 34f012639ddf41470714ae74ae961d158670a4c7. Related: OS#5289 Change-Id: I6b143b803349b97e783c586615d7f2ed4e1ff058 --- M configure.ac 1 file changed, 0 insertions(+), 12 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/configure.ac b/configure.ac index 195acfe..bcf91ba 100644 --- a/configure.ac +++ b/configure.ac @@ -36,11 +36,6 @@ fi PKG_PROG_PKG_CONFIG([0.20]) -dnl check for AX_CHECK_COMPILE_FLAG -m4_ifdef([AX_CHECK_COMPILE_FLAG], [], [ - AC_MSG_ERROR([Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect.]) - ]) - dnl checks for libraries AC_SEARCH_LIBS([dlopen], [dl dld], [LIBRARY_DL="$LIBS";LIBS=""]) AC_SUBST(LIBRARY_DL) @@ -120,13 +115,6 @@ CFLAGS="$saved_CFLAGS" AC_SUBST(SYMBOL_VISIBILITY) -AX_CHECK_COMPILE_FLAG([-Werror=implicit], [CFLAGS="$CFLAGS -Werror=implicit"]) -AX_CHECK_COMPILE_FLAG([-Werror=maybe-uninitialized], [CFLAGS="$CFLAGS -Werror=maybe-uninitialized"]) -AX_CHECK_COMPILE_FLAG([-Werror=memset-transposed-args], [CFLAGS="$CFLAGS -Werror=memset-transposed-args"]) -AX_CHECK_COMPILE_FLAG([-Wnull-dereference], [CFLAGS="$CFLAGS -Wnull-dereference"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-array-argument], [CFLAGS="$CFLAGS -Werror=sizeof-array-argument"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-pointer-memaccess], [CFLAGS="$CFLAGS -Werror=sizeof-pointer-memaccess"]) - # Coverage build taken from WebKit's configure.in AC_MSG_CHECKING([whether to enable code coverage support]) AC_ARG_ENABLE(coverage, -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26095 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6b143b803349b97e783c586615d7f2ed4e1ff058 Gerrit-Change-Number: 26095 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged
Change in osmo-bts[master]: lchan_meas_handle_sacch(): check if Measurement Result is valid
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/26047 )
Change subject: lchan_meas_handle_sacch(): check if Measurement Result is valid
..
Patch Set 5:
(1 comment)
https://gerrit.osmocom.org/c/osmo-bts/+/26047/4/src/common/measurement.c
File src/common/measurement.c:
https://gerrit.osmocom.org/c/osmo-bts/+/26047/4/src/common/measurement.c@958
PS4, Line 958: if (dtxu_used) {
> You're right. This is actually a fault of https://gerrit.osmocom. […]
Fixed in the new patch set. Looks like we build without
-Werror=maybe-uninitialized?
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26047
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I4aaac742674ce3ac15e9a4a32fe7c72db81d32d2
Gerrit-Change-Number: 26047
Gerrit-PatchSet: 5
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-CC: pespin
Gerrit-Comment-Date: Thu, 04 Nov 2021 13:09:12 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria
Comment-In-Reply-To: pespin
Gerrit-MessageType: comment
Change in osmo-pcu[master]: bts: Fix misleading log line in bts_rcv_rach()
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26060 ) Change subject: bts: Fix misleading log line in bts_rcv_rach() .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26060 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ic6beb6dcfebb77fd264b179b028f99a29c644fb1 Gerrit-Change-Number: 26060 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 04 Nov 2021 13:19:11 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: tbf_ul: Document context where tbf_alloc_ul_ccch() is used
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26061 ) Change subject: tbf_ul: Document context where tbf_alloc_ul_ccch() is used .. Patch Set 2: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/26061/2/src/tbf_ul.cpp File src/tbf_ul.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/26061/2/src/tbf_ul.cpp@171 PS2, Line 171: by on? -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26061 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Id83bfd78c88fa9e4fa98268cc726298c276e6f20 Gerrit-Change-Number: 26061 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 04 Nov 2021 13:19:55 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: bts: Rename 11bit RACH request counter
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26073 ) Change subject: bts: Rename 11bit RACH request counter .. Patch Set 1: Is it safe to change counter names in general? AFAIU, if we do so, we may break external monitoring tools for the users. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26073 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ibdfb10dcc65d71e98e2fe8b05001cafea786f071 Gerrit-Change-Number: 26073 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 04 Nov 2021 13:22:36 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-pcu[master]: tbf_ul: Document context where tbf_alloc_ul_ccch() is used
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26061 ) Change subject: tbf_ul: Document context where tbf_alloc_ul_ccch() is used .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/26061/2/src/tbf_ul.cpp File src/tbf_ul.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/26061/2/src/tbf_ul.cpp@171 PS2, Line 171: by > on? I guess it depends on whether you want to consider a request the subject calling it or simply consider it timing where the event happening. I don't really care :P -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26061 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Id83bfd78c88fa9e4fa98268cc726298c276e6f20 Gerrit-Change-Number: 26061 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 04 Nov 2021 13:23:19 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment
Change in osmo-pcu[master]: bts: Improve logging to clarify RACH req is for 2 phase access
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26075 ) Change subject: bts: Improve logging to clarify RACH req is for 2 phase access .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26075 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I047b688197a07e3592f19888f0ca71b9c3d2b3fd Gerrit-Change-Number: 26075 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Thu, 04 Nov 2021 13:24:09 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: bts: Count RACH Request with unexpected content
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26076 ) Change subject: bts: Count RACH Request with unexpected content .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26076 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I86420b08a9a634ca2e1f5a1c7e66ec3d3c08ce0b Gerrit-Change-Number: 26076 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Thu, 04 Nov 2021 13:25:04 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: bts: Add counters for successful 1, 2 phase pkt access
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26077 ) Change subject: bts: Add counters for successful 1,2 phase pkt access .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26077 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I494afab337f2557ffa38e4c7ff2c15a1647a1e04 Gerrit-Change-Number: 26077 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Thu, 04 Nov 2021 13:25:41 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: pdch::rcv_resource_request(): Use local var to store bts pointer
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26078 ) Change subject: pdch::rcv_resource_request(): Use local var to store bts pointer .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/26078/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-pcu/+/26078/1//COMMIT_MSG@7 PS1, Line 7: pdch::rcv_resource_request(): Use local var to store bts pointer So what's your motivation, and how it makes the code better? -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26078 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ica727c4b70cecc0ddb5d2a235bfc416735754b61 Gerrit-Change-Number: 26078 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria Gerrit-Comment-Date: Thu, 04 Nov 2021 13:26:50 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-pcu[master]: tbf_ul: Improve documentation of tbf_alloc_ul_pacch()
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26079 ) Change subject: tbf_ul: Improve documentation of tbf_alloc_ul_pacch() .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26079 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I59493788b4a54610a70f3eb4c31fd05f6e39e63d Gerrit-Change-Number: 26079 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Thu, 04 Nov 2021 13:27:24 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: Add counter for successful contention resolution procedures
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26080 ) Change subject: Add counter for successful contention resolution procedures .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26080 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I3d67e3e68907921b43f2ca4398ad9578c0b2618c Gerrit-Change-Number: 26080 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Thu, 04 Nov 2021 13:28:59 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: bts: Fix misleading log line in bts_rcv_rach()
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26060 ) Change subject: bts: Fix misleading log line in bts_rcv_rach() .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26060 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ic6beb6dcfebb77fd264b179b028f99a29c644fb1 Gerrit-Change-Number: 26060 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 04 Nov 2021 13:29:47 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: tbf_ul: Document context where tbf_alloc_ul_ccch() is used
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26061 ) Change subject: tbf_ul: Document context where tbf_alloc_ul_ccch() is used .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26061 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Id83bfd78c88fa9e4fa98268cc726298c276e6f20 Gerrit-Change-Number: 26061 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 04 Nov 2021 13:30:43 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: l1sap: rework handling of DATA.ind on SACCH
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26046 ) Change subject: l1sap: rework handling of DATA.ind on SACCH .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26046 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ifed91f87fd653debc87a09da3fd31ad64a13f330 Gerrit-Change-Number: 26046 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 13:35:40 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: lchan_meas_handle_sacch(): check if Measurement Result is valid
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26047 ) Change subject: lchan_meas_handle_sacch(): check if Measurement Result is valid .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26047 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I4aaac742674ce3ac15e9a4a32fe7c72db81d32d2 Gerrit-Change-Number: 26047 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 13:36:09 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: measurement: pass *mr to lchan_bs_pwr_ctrl()
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26049 ) Change subject: measurement: pass *mr to lchan_bs_pwr_ctrl() .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26049 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I937117cf26fb718d57920382f6972390ad498c51 Gerrit-Change-Number: 26049 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 13:37:19 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: l1sap: rework handling of DATA.ind on SACCH
fixeria has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/26046 )
Change subject: l1sap: rework handling of DATA.ind on SACCH
..
l1sap: rework handling of DATA.ind on SACCH
Currently an Uplink SACCH block is being passed to LAPDm first, and
then gets forwareded to the BSC in handle_ms_meas_report(), together
with the Uplink measurements collected so far.
This approach has a serious flaw: handle_ms_meas_report() won't be
called if an Uplink block contains SAPI=3 data (SMS) or was not
decoded at all (len=0) fow whatever reason. Therefore, no RSL
MEASurement RESult message will be sent to the BSC.
Rename handle_ms_meas_report() to lchan_meas_handle_sacch(), and call
it from l1sap_ph_data_ind(). This way perioduc RSL MEASurement RESult
messages will be sent regardless of what happens on Uplink SACCH.
Change-Id: Ifed91f87fd653debc87a09da3fd31ad64a13f330
Fixes: TC_meas_res_speech_{tchf,tchh}_sapi3
Related: SYS#5319
---
M include/osmo-bts/measurement.h
M src/common/l1sap.c
M src/common/measurement.c
M src/common/rsl.c
4 files changed, 84 insertions(+), 74 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
diff --git a/include/osmo-bts/measurement.h b/include/osmo-bts/measurement.h
index f63a05a..ad86d8d 100644
--- a/include/osmo-bts/measurement.h
+++ b/include/osmo-bts/measurement.h
@@ -20,8 +20,6 @@
int is_meas_complete(struct gsm_lchan *lchan, uint32_t fn);
-int handle_ms_meas_report(struct gsm_lchan *lchan,
- const struct gsm48_hdr *gh,
- unsigned int len);
+void lchan_meas_handle_sacch(struct gsm_lchan *lchan, struct msgb *msg);
#endif
diff --git a/src/common/l1sap.c b/src/common/l1sap.c
index f983b62..8dee209 100644
--- a/src/common/l1sap.c
+++ b/src/common/l1sap.c
@@ -33,7 +33,6 @@
#include
#include
#include
-#include
#include
#include
#include
@@ -1470,7 +1469,6 @@
uint8_t tn;
uint32_t fn;
enum osmo_ph_pres_info_type pr_info = data_ind->pdch_presence_info;
- struct gsm_sacch_l1_hdr *l1_hdr;
chan_nr = data_ind->chan_nr;
link_id = data_ind->link_id;
@@ -1529,48 +1527,33 @@
if (bts_internal_flag_get(trx->bts,
BTS_INTERNAL_FLAG_MEAS_PAYLOAD_COMB))
process_l1sap_meas_data(lchan, l1sap, PRIM_PH_DATA);
- if (L1SAP_IS_LINK_SACCH(link_id))
+ if (L1SAP_IS_LINK_SACCH(link_id)) {
repeated_ul_sacch_active_decision(lchan, data_ind->ber10k);
- /* bad frame */
- if (len == 0) {
- if (L1SAP_IS_LINK_SACCH(link_id)) {
- /* In case we loose a SACCH block, we must take care
-* that the related measurement report is sent via RSL.
-* This is a fallback method. The report will also
-* lack the measurement report from the MS side. See
-* also rsl.c:lapdm_rll_tx_cb() */
- LOGPGT(DL1P, LOGL_INFO, &g_time, "Lost SACCH block,
faking meas reports and ms pwr\n");
- handle_ms_meas_report(lchan, NULL, 0);
-
+ /* Radio Link Timeout counter */
+ if (len == 0) {
+ LOGPGT(DL1P, LOGL_INFO, &g_time, "%s Lost SACCH
block\n",
+ gsm_lchan_name(lchan));
radio_link_timeout(lchan, true);
+ } else {
+ radio_link_timeout(lchan, false);
}
- return -EINVAL;
+
+ /* Trigger the measurement reporting/processing logic */
+ lchan_meas_handle_sacch(lchan, msg);
}
+ /* bad frame */
+ if (len == 0)
+ return -EINVAL;
+
/* report first valid received frame to handover process */
if (lchan->ho.active == HANDOVER_WAIT_FRAME)
handover_frame(lchan);
- if (L1SAP_IS_LINK_SACCH(link_id)) {
- radio_link_timeout(lchan, false);
+ if (L1SAP_IS_LINK_SACCH(link_id))
le = &lchan->lapdm_ch.lapdm_acch;
- /* save the SACCH L1 header in the lchan struct for RSL MEAS
RES */
- if (len != GSM_MACBLOCK_LEN) {
- LOGPGT(DL1P, LOGL_NOTICE, &g_time, "SACCH with odd
len=%u!?!\n", len);
- return -EINVAL;
- }
- /* Some brilliant engineer decided that the ordering of
-* fields on the Um interface is different from the
-* order of fields in RSL. See 3GPP TS 44.004 (section 7.2)
-* vs. 3GPP TS 48.058 (section 9.3.10). */
- l1_hdr = (struct gsm_sacch_l1_hdr*)data;
- lchan->meas.l1_info.ms_pwr = l1_hdr->ms_pwr;
- lchan->meas.l1_info.fpc_epc = l1_hdr->fpc_epc;
-
Change in osmo-bts[master]: lchan_meas_handle_sacch(): check if Measurement Result is valid
fixeria has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/26047 )
Change subject: lchan_meas_handle_sacch(): check if Measurement Result is valid
..
lchan_meas_handle_sacch(): check if Measurement Result is valid
We should not rely on measurement data marked as invalid.
Change-Id: I4aaac742674ce3ac15e9a4a32fe7c72db81d32d2
---
M src/common/measurement.c
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, approved
laforge: Looks good to me, but someone else must approve
diff --git a/src/common/measurement.c b/src/common/measurement.c
index 3aeb901..73c5e43 100644
--- a/src/common/measurement.c
+++ b/src/common/measurement.c
@@ -951,7 +951,8 @@
*/
if (gh && gh->msg_type == GSM48_MT_RR_MEAS_REP) {
mr = (const struct gsm48_meas_res *)gh->data;
- dtxu_used = mr->dtx_used;
+ if (mr->meas_valid == 0) /* 0 = valid */
+ dtxu_used = mr->dtx_used;
}
if (dtxu_used) {
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26047
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I4aaac742674ce3ac15e9a4a32fe7c72db81d32d2
Gerrit-Change-Number: 26047
Gerrit-PatchSet: 5
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-bts[master]: measurement: get rid of *le in lchan_meas_handle_sacch()
fixeria has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/26051 )
Change subject: measurement: get rid of *le in lchan_meas_handle_sacch()
..
measurement: get rid of *le in lchan_meas_handle_sacch()
The current Timing Advance value can be obtained either from the
L1 SACCH header (if received) or from lchan->ta_ctrl.current.
Change-Id: I2b3693a0e49f03f2b4496c9dbd30cf47e9bc86b5
---
M src/common/measurement.c
1 file changed, 3 insertions(+), 6 deletions(-)
Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/common/measurement.c b/src/common/measurement.c
index 73c5e43..042f8b9 100644
--- a/src/common/measurement.c
+++ b/src/common/measurement.c
@@ -782,9 +782,9 @@
lchan->meas.last_fn = LCHAN_FN_DUMMY;
}
-static inline uint8_t ms_to2rsl(const struct gsm_lchan *lchan, const struct
lapdm_entity *le)
+static inline uint8_t ms_to2rsl(const struct gsm_lchan *lchan, uint8_t ta)
{
- return (lchan->ms_t_offs >= 0) ? lchan->ms_t_offs : (lchan->p_offs -
le->ta);
+ return (lchan->ms_t_offs >= 0) ? lchan->ms_t_offs : (lchan->p_offs -
ta);
}
static inline bool ms_to_valid(const struct gsm_lchan *lchan)
@@ -898,7 +898,6 @@
const struct gsm48_meas_res *mr = NULL;
const struct gsm48_hdr *gh = NULL;
int timing_offset, rc;
- struct lapdm_entity *le;
bool dtxu_used = true; /* safe default assumption */
uint8_t ms_pwr;
uint8_t ms_ta;
@@ -932,9 +931,7 @@
ms_ta = lchan->ta_ctrl.current;
}
- le = &lchan->lapdm_ch.lapdm_acch;
-
- timing_offset = ms_to_valid(lchan) ? ms_to2rsl(lchan, le) : -1;
+ timing_offset = ms_to_valid(lchan) ? ms_to2rsl(lchan, ms_ta) : -1;
rc = rsl_tx_meas_res(lchan, msgb_l3(msg), msgb_l3len(msg),
timing_offset);
if (rc == 0) /* Count successful transmissions */
lchan->meas.res_nr++;
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26051
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I2b3693a0e49f03f2b4496c9dbd30cf47e9bc86b5
Gerrit-Change-Number: 26051
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-bts[master]: measurement: pass *mr to repeated_dl_facch_active_decision()
fixeria has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/26048 )
Change subject: measurement: pass *mr to repeated_dl_facch_active_decision()
..
measurement: pass *mr to repeated_dl_facch_active_decision()
Change-Id: Idbf5f95d632aa2270c49b351ad5561ca2182bf9a
Related: SYS#5114
---
M src/common/measurement.c
1 file changed, 3 insertions(+), 10 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
diff --git a/src/common/measurement.c b/src/common/measurement.c
index 042f8b9..c5d60b2 100644
--- a/src/common/measurement.c
+++ b/src/common/measurement.c
@@ -795,9 +795,8 @@
/* Decide if repeated FACCH should be applied or not. If RXQUAL level, that the
* MS reports is high enough, FACCH repetition is not needed. */
static void repeated_dl_facch_active_decision(struct gsm_lchan *lchan,
- const struct gsm48_hdr *gh)
+ const struct gsm48_meas_res
*meas_res)
{
- const struct gsm48_meas_res *meas_res;
uint8_t upper;
uint8_t lower;
uint8_t rxqual;
@@ -828,14 +827,8 @@
}
/* Parse MS measurement results */
- if (gh == NULL)
+ if (meas_res == NULL)
goto out;
- /* Check if this is a Measurement Report */
- if (gh->proto_discr != GSM48_PDISC_RR)
- goto out;
- if (gh->msg_type != GSM48_MT_RR_MEAS_REP)
- goto out;
- meas_res = (const struct gsm48_meas_res *) gh->data;
if (meas_res->meas_valid != 0) /* 0 = valid */
goto out;
@@ -964,7 +957,7 @@
if (gh)
lchan_bs_pwr_ctrl(lchan, gh);
- repeated_dl_facch_active_decision(lchan, gh);
+ repeated_dl_facch_active_decision(lchan, mr);
/* Reset state for next iteration */
lchan->tch.dtx.dl_active = false;
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26048
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Idbf5f95d632aa2270c49b351ad5561ca2182bf9a
Gerrit-Change-Number: 26048
Gerrit-PatchSet: 5
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-bts[master]: measurement: pass *mr to lchan_bs_pwr_ctrl()
fixeria has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/26049 )
Change subject: measurement: pass *mr to lchan_bs_pwr_ctrl()
..
measurement: pass *mr to lchan_bs_pwr_ctrl()
As a side effect, we have to sacrifice a unit test (TC_inval_dummy)
because it becomes impossible to pass a dummy or invalid SACCH block
to lchan_bs_pwr_ctrl().
Change-Id: I937117cf26fb718d57920382f6972390ad498c51
Related: SYS#4918
---
M include/osmo-bts/power_control.h
M src/common/measurement.c
M src/common/power_control.c
M tests/power/bs_power_loop_test.c
M tests/power/bs_power_loop_test.err
M tests/power/bs_power_loop_test.ok
6 files changed, 19 insertions(+), 112 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, approved
laforge: Looks good to me, but someone else must approve
diff --git a/include/osmo-bts/power_control.h b/include/osmo-bts/power_control.h
index e8b035d..0764ba7 100644
--- a/include/osmo-bts/power_control.h
+++ b/include/osmo-bts/power_control.h
@@ -87,4 +87,4 @@
const int16_t ul_lqual_cb);
int lchan_bs_pwr_ctrl(struct gsm_lchan *lchan,
- const struct gsm48_hdr *gh);
+ const struct gsm48_meas_res *mr);
diff --git a/src/common/measurement.c b/src/common/measurement.c
index c5d60b2..8f33eaa 100644
--- a/src/common/measurement.c
+++ b/src/common/measurement.c
@@ -954,8 +954,8 @@
}
lchan_ms_ta_ctrl(lchan, ms_ta, lchan->meas.ms_toa256);
lchan_ms_pwr_ctrl(lchan, ms_pwr, ul_rssi, ul_ci_cb);
- if (gh)
- lchan_bs_pwr_ctrl(lchan, gh);
+ if (mr && mr->meas_valid == 0) /* 0 = valid */
+ lchan_bs_pwr_ctrl(lchan, mr);
repeated_dl_facch_active_decision(lchan, mr);
diff --git a/src/common/power_control.c b/src/common/power_control.c
index a81000e..42d9d07 100644
--- a/src/common/power_control.c
+++ b/src/common/power_control.c
@@ -311,46 +311,26 @@
/*! compute the new Downlink attenuation value for the given logical channel.
* \param lchan logical channel for which to compute (and in which to store)
new power value.
- * \param[in] gh pointer to the beginning of (presumably) a Measurement
Report.
+ * \param[in] mr pointer to a *valid* Measurement Report.
*/
int lchan_bs_pwr_ctrl(struct gsm_lchan *lchan,
- const struct gsm48_hdr *gh)
+ const struct gsm48_meas_res *mr)
{
struct lchan_power_ctrl_state *state = &lchan->bs_power_ctrl;
const struct gsm_power_ctrl_params *params = state->dpc_params;
- uint8_t rxqual_full, rxqual_sub;
- uint8_t rxlev_full, rxlev_sub;
uint8_t rxqual, rxqual_avg, rxlev, rxlev_avg;
int new_att;
/* Check if dynamic BS Power Control is enabled */
if (params == NULL)
return 0;
- /* Check if this is a Measurement Report */
- if (gh->proto_discr != GSM48_PDISC_RR)
- return 0;
- if (gh->msg_type != GSM48_MT_RR_MEAS_REP)
- return 0;
-
- /* Check if the measurement results are valid */
- if ((gh->data[1] & 0x40) == 0x40) {
- LOGPLCHAN(lchan, DLOOP, LOGL_DEBUG,
- "The measurement results are not valid\n");
- return 0;
- }
-
- /* See 3GPP TS 44.018, section 10.5.2.20 */
- rxqual_full = (gh->data[2] >> 4) & 0x7;
- rxqual_sub = (gh->data[2] >> 1) & 0x7;
-
- rxlev_full = gh->data[0] & 0x3f;
- rxlev_sub = gh->data[1] & 0x3f;
LOGPLCHAN(lchan, DLOOP, LOGL_DEBUG, "Rx DL Measurement Report: "
"RXLEV-FULL(%02u), RXQUAL-FULL(%u), "
"RXLEV-SUB(%02u), RXQUAL-SUB(%u), "
"DTx is %s => using %s\n",
- rxlev_full, rxqual_full, rxlev_sub, rxqual_sub,
+ mr->rxlev_full, mr->rxqual_full,
+ mr->rxlev_sub, mr->rxqual_sub,
lchan->tch.dtx.dl_active ? "enabled" : "disabled",
lchan->tch.dtx.dl_active ? "SUB" : "FULL");
@@ -360,11 +340,11 @@
/* If DTx is active on Downlink, use the '-SUB' */
if (lchan->tch.dtx.dl_active) {
- rxqual = rxqual_sub;
- rxlev = rxlev_sub;
+ rxqual = mr->rxqual_sub;
+ rxlev = mr->rxlev_sub;
} else { /* ... otherwise use the '-FULL' */
- rxqual = rxqual_full;
- rxlev = rxlev_full;
+ rxqual = mr->rxqual_full;
+ rxlev = mr->rxlev_full;
}
rxlev_avg = do_avg_algo(¶ms->rxlev_meas, &state->rxlev_meas_proc,
rxlev);
diff --git a/tests/power/bs_power_loop_test.c b/tests/power/bs_power_loop_test.c
index 6b67ba2..06fe3ed 100644
--- a/tests/power/bs_power_loop_test.c
+++ b/tests/power/bs_power_loop_test.c
@@ -47,14 +47,8 @@
{ DL_MEAS_FULL(rxqual, rxlev), \
DL_MEAS_SUB(rxqual, rxlev)
Change in osmo-bts[master]: [overpower] Turn it on and off depending on DL RxQual
fixeria has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/25899 )
Change subject: [overpower] Turn it on and off depending on DL RxQual
..
[overpower] Turn it on and off depending on DL RxQual
Change-Id: Iaa812d4661ee17c4cd4a8c4ae4bd3e94c1a2e6cc
Depends: Ia28293a12de0af71f55e701fb65c46e905dae217
Related: SYS#5319
---
M include/osmo-bts/lchan.h
M src/common/measurement.c
M src/common/rsl.c
M src/common/scheduler.c
4 files changed, 57 insertions(+), 3 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
diff --git a/include/osmo-bts/lchan.h b/include/osmo-bts/lchan.h
index 754dc7c..3aaa75a 100644
--- a/include/osmo-bts/lchan.h
+++ b/include/osmo-bts/lchan.h
@@ -293,8 +293,9 @@
struct gsm_power_ctrl_params ms_dpc_params;
struct gsm_power_ctrl_params bs_dpc_params;
- /* Temporary ACCH overpower capabilities */
+ /* Temporary ACCH overpower capabilities and state */
struct abis_rsl_osmo_temp_ovp_acch_cap top_acch_cap;
+ bool top_acch_active;
struct msgb *pending_rel_ind_msg;
diff --git a/src/common/measurement.c b/src/common/measurement.c
index 8f33eaa..4341be7 100644
--- a/src/common/measurement.c
+++ b/src/common/measurement.c
@@ -861,6 +861,43 @@
LOGPLCHAN(lchan, DL1P, LOGL_DEBUG, "DL-FACCH repetition: active
=> inactive\n");
}
+static void acch_overpower_active_decision(struct gsm_lchan *lchan,
+ const struct gsm48_meas_res
*meas_res)
+{
+ const bool old = lchan->top_acch_active;
+ uint8_t upper, lower, rxqual;
+
+ /* ACCH overpower is not allowed => nothing to do */
+ if (lchan->top_acch_cap.overpower_db == 0)
+ return;
+ /* RxQual threshold is disabled => overpower is always on */
+ if (lchan->top_acch_cap.rxqual == 0)
+ return;
+
+ /* If DTx is active on Downlink, use the '-SUB' */
+ if (meas_res->dtx_used)
+ rxqual = meas_res->rxqual_sub;
+ else /* ... otherwise use the '-FULL' */
+ rxqual = meas_res->rxqual_full;
+
+ upper = lchan->top_acch_cap.rxqual;
+ if (upper > 2)
+ lower = upper - 2;
+ else
+ lower = 0;
+
+ if (rxqual >= upper)
+ lchan->top_acch_active = true;
+ else if (rxqual <= lower)
+ lchan->top_acch_active = false;
+
+ if (lchan->top_acch_active != old) {
+ LOGPLCHAN(lchan, DL1P, LOGL_DEBUG, "Temporary ACCH overpower:
%s\n",
+ lchan->top_acch_active ? "inactive => active"
+ : "active => inactive");
+ }
+}
+
static bool data_is_rr_meas_rep(const uint8_t *data)
{
const struct gsm48_hdr *gh = (void *)(data + 5);
@@ -954,8 +991,10 @@
}
lchan_ms_ta_ctrl(lchan, ms_ta, lchan->meas.ms_toa256);
lchan_ms_pwr_ctrl(lchan, ms_pwr, ul_rssi, ul_ci_cb);
- if (mr && mr->meas_valid == 0) /* 0 = valid */
+ if (mr && mr->meas_valid == 0) { /* 0 = valid */
lchan_bs_pwr_ctrl(lchan, mr);
+ acch_overpower_active_decision(lchan, mr);
+ }
repeated_dl_facch_active_decision(lchan, mr);
diff --git a/src/common/rsl.c b/src/common/rsl.c
index 5d069c2..4c84f21 100644
--- a/src/common/rsl.c
+++ b/src/common/rsl.c
@@ -1928,6 +1928,13 @@
if (rc < 0)
return rsl_tx_chan_act_acknack(lchan, -rc);
+ /* Take the first ACCH overpower decision (if allowed): it can be
+* enabled immediately if the RxQual threshold is disabled (0). */
+ if (lchan->top_acch_cap.overpower_db > 0)
+ lchan->top_acch_active = !lchan->top_acch_cap.rxqual;
+ else
+ lchan->top_acch_active = false;
+
/* actually activate the channel in the BTS */
rc = l1sap_chan_act(lchan->ts->trx, dch->chan_nr, &tp);
if (rc < 0)
@@ -2198,6 +2205,13 @@
if (rc < 0)
return rsl_tx_mode_modif_nack(lchan, -rc);
+ /* Immediately disable ACCH overpower if the value is 0 dB,
+* or enable if the RxQual threshold becomes disabled (0). */
+ if (lchan->top_acch_cap.overpower_db == 0)
+ lchan->top_acch_active = false;
+ else if (lchan->top_acch_cap.rxqual == 0)
+ lchan->top_acch_active = true;
+
l1sap_chan_modify(lchan->ts->trx, dch->chan_nr);
/* FIXME: delay this until L1 says OK? */
diff --git a/src/common/scheduler.c b/src/common/scheduler.c
index ba5c18a..d8048b5 100644
--- a/src/common/scheduler.c
+++ b/src/common/scheduler.c
@@ -1310,7 +1310,7 @@
br->att = lchan->bs_power_ctrl.current;
/* Temporary Overpower for SACCH/FACCH bursts */
- if (lchan->top_acch_cap.overpower_db == 0)
+ if
Change in osmo-pcu[master]: bts: Rename 11bit RACH request counter
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26073 ) Change subject: bts: Rename 11bit RACH request counter .. Patch Set 1: Code-Review+1 > Patch Set 1: > > Is it safe to change counter names in general? > AFAIU, if we do so, we may break external monitoring tools for the users. I agree with the concern, but think the change still makes sense. Better do it before the per-type splitting than after. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26073 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ibdfb10dcc65d71e98e2fe8b05001cafea786f071 Gerrit-Change-Number: 26073 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 04 Nov 2021 14:15:17 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: gsm/protocol/gsm_04_08.h: add gsm48_meas_res_is_valid() macro
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmocore/+/26104 )
Change subject: gsm/protocol/gsm_04_08.h: add gsm48_meas_res_is_valid() macro
..
gsm/protocol/gsm_04_08.h: add gsm48_meas_res_is_valid() macro
Change-Id: Iae2bd508a08c4b5093d36e514c22218763e11edf
---
M include/osmocom/gsm/protocol/gsm_04_08.h
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/04/26104/1
diff --git a/include/osmocom/gsm/protocol/gsm_04_08.h
b/include/osmocom/gsm/protocol/gsm_04_08.h
index 3fa9419..e54ce42 100644
--- a/include/osmocom/gsm/protocol/gsm_04_08.h
+++ b/include/osmocom/gsm/protocol/gsm_04_08.h
@@ -593,6 +593,10 @@
#endif
} __attribute__ ((packed));
+/* Check if the given mr contains valid measurement results */
+#define gsm48_meas_res_is_valid(mr) \
+ ((mr)->meas_valid == 0) /* 0 means valid */
+
/* Chapter 10.5.2.21aa */
struct gsm48_multi_rate_conf {
#if OSMO_IS_LITTLE_ENDIAN
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26104
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Iae2bd508a08c4b5093d36e514c22218763e11edf
Gerrit-Change-Number: 26104
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
Change in osmo-pcu[master]: bts: Rename 11bit RACH request counter
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26073 ) Change subject: bts: Rename 11bit RACH request counter .. Patch Set 1: > Patch Set 1: Code-Review+1 > > > Patch Set 1: > > > > Is it safe to change counter names in general? > > AFAIU, if we do so, we may break external monitoring tools for the users. > > I agree with the concern, but think the change still makes sense. Better do > it before the per-type splitting than after. Agree with Daniel, I checked no TTCN3 is using it, and I doubt anyone is really using them systematically yet. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26073 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ibdfb10dcc65d71e98e2fe8b05001cafea786f071 Gerrit-Change-Number: 26073 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 04 Nov 2021 14:39:52 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in libosmocore[master]: gsm/protocol/gsm_04_08.h: add gsm48_meas_res_is_valid() macro
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26104 ) Change subject: gsm/protocol/gsm_04_08.h: add gsm48_meas_res_is_valid() macro .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/26104/1/include/osmocom/gsm/protocol/gsm_04_08.h File include/osmocom/gsm/protocol/gsm_04_08.h: https://gerrit.osmocom.org/c/libosmocore/+/26104/1/include/osmocom/gsm/protocol/gsm_04_08.h@597 PS1, Line 597: #define gsm48_meas_res_is_valid(mr) \ maybe a static inline would be clearer here, but fine anyway. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26104 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iae2bd508a08c4b5093d36e514c22218763e11edf Gerrit-Change-Number: 26104 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 14:41:00 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-msc[master]: Make UTRAN encryption algorithms configurable
lynxis lazus has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-msc/+/22766 )
Change subject: Make UTRAN encryption algorithms configurable
..
Patch Set 4:
(5 comments)
https://gerrit.osmocom.org/c/osmo-msc/+/22766/1/src/libmsc/gsm_04_08.c
File src/libmsc/gsm_04_08.c:
https://gerrit.osmocom.org/c/osmo-msc/+/22766/1/src/libmsc/gsm_04_08.c@415
PS1, Line 415: is_utran ? net->uea_encryption_mask >
0x01 : net->a5_encryption_mask > 0x01,
> This logic > 0x01 is a bit confusion to read. […]
i would like to replace it in a patch after this one
https://gerrit.osmocom.org/c/osmo-msc/+/22766/4/src/libmsc/gsm_04_08.c
File src/libmsc/gsm_04_08.c:
https://gerrit.osmocom.org/c/osmo-msc/+/22766/4/src/libmsc/gsm_04_08.c@1296
PS4, Line 1296: is_utran ? net->uea_encryption_mask >
0x01 : net->a5_encryption_mask > 0x01,
> it may make sense to have an msc_a_encryption_enabled(msc_a) function, since
> you do this complex tes […]
i would like to replace it in a patch
https://gerrit.osmocom.org/c/osmo-msc/+/22766/4/src/libmsc/msc_vty.c
File src/libmsc/msc_vty.c:
https://gerrit.osmocom.org/c/osmo-msc/+/22766/4/src/libmsc/msc_vty.c@172
PS4, Line 172: /* So far just a boolean switch, a future patch might add
individual config for UEA1 and UEA2, see OS#4143 */
> This comment is not true anymore.
Done
https://gerrit.osmocom.org/c/osmo-msc/+/22766/4/src/libmsc/msc_vty.c@371
PS4, Line 371: for (i = 0; i < 8; i++) {
> So in the command above we only support UEA0/1/2, but here we go up to 8.
is it a problem? so far we never set it to anything > UEA2 because the vty
validates the range and the default is also correct.
https://gerrit.osmocom.org/c/osmo-msc/+/22766/3/src/libmsc/ran_msg_iu.c
File src/libmsc/ran_msg_iu.c:
https://gerrit.osmocom.org/c/osmo-msc/+/22766/3/src/libmsc/ran_msg_iu.c@375
PS3, Line 375: return ranap_new_msg_sec_mod_cmd2(cm->vec->ik,
cm->utran.uea_encryption_mask > 0x01 ? cm->vec->ck : NULL,
> You mismatched the arguments. The keystatus needs to be in fron of 0x06. […]
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/22766
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I91f9e50f9c1439aa19528f887b83ae9de628fcfd
Gerrit-Change-Number: 22766
Gerrit-PatchSet: 4
Gerrit-Owner: laforge
Gerrit-Assignee: lynxis lazus
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: laforge
Gerrit-Reviewer: lynxis lazus
Gerrit-Reviewer: neels
Gerrit-Reviewer: pespin
Gerrit-Comment-Date: Thu, 04 Nov 2021 14:41:06 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin
Comment-In-Reply-To: fixeria
Comment-In-Reply-To: lynxis lazus
Comment-In-Reply-To: dexter
Gerrit-MessageType: comment
Change in osmo-bts[master]: measurement: make use of gsm48_meas_res_is_valid() macro
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-bts/+/26105 )
Change subject: measurement: make use of gsm48_meas_res_is_valid() macro
..
measurement: make use of gsm48_meas_res_is_valid() macro
Change-Id: Iea6ab7b69defd7ce88c2aa92fcf2b84370a4c135
Depends: Iae2bd508a08c4b5093d36e514c22218763e11edf
---
M src/common/measurement.c
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/05/26105/1
diff --git a/src/common/measurement.c b/src/common/measurement.c
index 4341be7..1a5992b 100644
--- a/src/common/measurement.c
+++ b/src/common/measurement.c
@@ -829,7 +829,7 @@
/* Parse MS measurement results */
if (meas_res == NULL)
goto out;
- if (meas_res->meas_valid != 0) /* 0 = valid */
+ if (!gsm48_meas_res_is_valid(meas_res))
goto out;
/* If the RXQUAL level at the MS drops under a certain threshold
@@ -978,7 +978,7 @@
*/
if (gh && gh->msg_type == GSM48_MT_RR_MEAS_REP) {
mr = (const struct gsm48_meas_res *)gh->data;
- if (mr->meas_valid == 0) /* 0 = valid */
+ if (gsm48_meas_res_is_valid(mr))
dtxu_used = mr->dtx_used;
}
@@ -991,7 +991,7 @@
}
lchan_ms_ta_ctrl(lchan, ms_ta, lchan->meas.ms_toa256);
lchan_ms_pwr_ctrl(lchan, ms_pwr, ul_rssi, ul_ci_cb);
- if (mr && mr->meas_valid == 0) { /* 0 = valid */
+ if (mr && gsm48_meas_res_is_valid(mr)) {
lchan_bs_pwr_ctrl(lchan, mr);
acch_overpower_active_decision(lchan, mr);
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26105
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Iea6ab7b69defd7ce88c2aa92fcf2b84370a4c135
Gerrit-Change-Number: 26105
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
Change in osmo-bts[master]: measurement: make use of gsm48_meas_res_is_valid() macro
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26105 ) Change subject: measurement: make use of gsm48_meas_res_is_valid() macro .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26105 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iea6ab7b69defd7ce88c2aa92fcf2b84370a4c135 Gerrit-Change-Number: 26105 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: pespin Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 04 Nov 2021 14:42:25 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: gsm/protocol/gsm_04_08.h: add gsm48_meas_res_is_valid()
Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/26104 to look at the new patch set (#2). Change subject: gsm/protocol/gsm_04_08.h: add gsm48_meas_res_is_valid() .. gsm/protocol/gsm_04_08.h: add gsm48_meas_res_is_valid() Change-Id: Iae2bd508a08c4b5093d36e514c22218763e11edf --- M include/osmocom/gsm/protocol/gsm_04_08.h 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/04/26104/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26104 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iae2bd508a08c4b5093d36e514c22218763e11edf Gerrit-Change-Number: 26104 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmo-bts[master]: measurement: make use of gsm48_meas_res_is_valid()
Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/26105 to look at the new patch set (#2). Change subject: measurement: make use of gsm48_meas_res_is_valid() .. measurement: make use of gsm48_meas_res_is_valid() Change-Id: Iea6ab7b69defd7ce88c2aa92fcf2b84370a4c135 Depends: Iae2bd508a08c4b5093d36e514c22218763e11edf --- M src/common/measurement.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/05/26105/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26105 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iea6ab7b69defd7ce88c2aa92fcf2b84370a4c135 Gerrit-Change-Number: 26105 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in libosmocore[master]: gsm/protocol/gsm_04_08.h: add gsm48_meas_res_is_valid()
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26104 ) Change subject: gsm/protocol/gsm_04_08.h: add gsm48_meas_res_is_valid() .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26104 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iae2bd508a08c4b5093d36e514c22218763e11edf Gerrit-Change-Number: 26104 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 14:47:53 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: measurement: make use of gsm48_meas_res_is_valid()
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/26105 ) Change subject: measurement: make use of gsm48_meas_res_is_valid() .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26105 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iea6ab7b69defd7ce88c2aa92fcf2b84370a4c135 Gerrit-Change-Number: 26105 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 14:48:04 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: gsm/protocol/gsm_04_08.h: add gsm48_meas_res_is_valid()
fixeria has submitted this change. (
https://gerrit.osmocom.org/c/libosmocore/+/26104 )
Change subject: gsm/protocol/gsm_04_08.h: add gsm48_meas_res_is_valid()
..
gsm/protocol/gsm_04_08.h: add gsm48_meas_res_is_valid()
Change-Id: Iae2bd508a08c4b5093d36e514c22218763e11edf
---
M include/osmocom/gsm/protocol/gsm_04_08.h
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/include/osmocom/gsm/protocol/gsm_04_08.h
b/include/osmocom/gsm/protocol/gsm_04_08.h
index 3fa9419..ea77e76 100644
--- a/include/osmocom/gsm/protocol/gsm_04_08.h
+++ b/include/osmocom/gsm/protocol/gsm_04_08.h
@@ -593,6 +593,12 @@
#endif
} __attribute__ ((packed));
+/*! Check if the given mr contains valid measurement results */
+static inline bool gsm48_meas_res_is_valid(const struct gsm48_meas_res *mr)
+{
+ return (mr->meas_valid == 0); /* 0 means valid */
+}
+
/* Chapter 10.5.2.21aa */
struct gsm48_multi_rate_conf {
#if OSMO_IS_LITTLE_ENDIAN
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26104
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Iae2bd508a08c4b5093d36e514c22218763e11edf
Gerrit-Change-Number: 26104
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in libosmocore[master]: include: add enum for UTRAN cipher
lynxis lazus has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmocore/+/26106 )
Change subject: include: add enum for UTRAN cipher
..
include: add enum for UTRAN cipher
Change-Id: I4b9baff2c2fbd0e339fc769cc69cce58d3a72cdf
---
M include/Makefile.am
A include/osmocom/crypt/utran_cipher.h
2 files changed, 19 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/06/26106/1
diff --git a/include/Makefile.am b/include/Makefile.am
index 7df651a..49402d0 100644
--- a/include/Makefile.am
+++ b/include/Makefile.am
@@ -64,6 +64,7 @@
osmocom/crypt/auth.h \
osmocom/crypt/gprs_cipher.h \
osmocom/crypt/kdf.h \
+ osmocom/crypt/utran_cipher.h \
osmocom/ctrl/control_cmd.h \
osmocom/ctrl/control_if.h \
osmocom/ctrl/ports.h \
diff --git a/include/osmocom/crypt/utran_cipher.h
b/include/osmocom/crypt/utran_cipher.h
new file mode 100644
index 000..9c14da8
--- /dev/null
+++ b/include/osmocom/crypt/utran_cipher.h
@@ -0,0 +1,18 @@
+/*! \file utran_cipher.h */
+
+#pragma once
+
+/* 3GPP TS 25.413 § 9.2.1.11 */
+enum utran_integrity_algo {
+ UTRAN_UIA1 = 0,
+ UTRAN_UIA2 = 1,
+ _UTRAN_UIA_NUM
+};
+/* 3GPP TS 25.413 § 9.2.1.12 */
+enum utran_encryption_algo {
+ UTRAN_UEA0 = 0,
+ UTRAN_UEA1 = 1,
+ UTRAN_UEA2 = 2,
+ _UTRAN_UEA_NUM
+};
+
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26106
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I4b9baff2c2fbd0e339fc769cc69cce58d3a72cdf
Gerrit-Change-Number: 26106
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus
Gerrit-MessageType: newchange
Change in osmo-bts[master]: measurement: make use of gsm48_meas_res_is_valid()
fixeria has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/26105 )
Change subject: measurement: make use of gsm48_meas_res_is_valid()
..
measurement: make use of gsm48_meas_res_is_valid()
Change-Id: Iea6ab7b69defd7ce88c2aa92fcf2b84370a4c135
Depends: Iae2bd508a08c4b5093d36e514c22218763e11edf
---
M src/common/measurement.c
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/common/measurement.c b/src/common/measurement.c
index 4341be7..1a5992b 100644
--- a/src/common/measurement.c
+++ b/src/common/measurement.c
@@ -829,7 +829,7 @@
/* Parse MS measurement results */
if (meas_res == NULL)
goto out;
- if (meas_res->meas_valid != 0) /* 0 = valid */
+ if (!gsm48_meas_res_is_valid(meas_res))
goto out;
/* If the RXQUAL level at the MS drops under a certain threshold
@@ -978,7 +978,7 @@
*/
if (gh && gh->msg_type == GSM48_MT_RR_MEAS_REP) {
mr = (const struct gsm48_meas_res *)gh->data;
- if (mr->meas_valid == 0) /* 0 = valid */
+ if (gsm48_meas_res_is_valid(mr))
dtxu_used = mr->dtx_used;
}
@@ -991,7 +991,7 @@
}
lchan_ms_ta_ctrl(lchan, ms_ta, lchan->meas.ms_toa256);
lchan_ms_pwr_ctrl(lchan, ms_pwr, ul_rssi, ul_ci_cb);
- if (mr && mr->meas_valid == 0) { /* 0 = valid */
+ if (mr && gsm48_meas_res_is_valid(mr)) {
lchan_bs_pwr_ctrl(lchan, mr);
acch_overpower_active_decision(lchan, mr);
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26105
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Iea6ab7b69defd7ce88c2aa92fcf2b84370a4c135
Gerrit-Change-Number: 26105
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in libosmocore[master]: include: add enum for UTRAN cipher
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26106 ) Change subject: include: add enum for UTRAN cipher .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26106 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4b9baff2c2fbd0e339fc769cc69cce58d3a72cdf Gerrit-Change-Number: 26106 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 15:14:51 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-msc[master]: Make UTRAN encryption algorithms configurable
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/22766 ) Change subject: Make UTRAN encryption algorithms configurable .. Patch Set 4: (1 comment) https://gerrit.osmocom.org/c/osmo-msc/+/22766/1/src/libmsc/msc_net_init.c File src/libmsc/msc_net_init.c: https://gerrit.osmocom.org/c/osmo-msc/+/22766/1/src/libmsc/msc_net_init.c@71 PS1, Line 71: net->uea_encryption_mask = (1 << 2) | (1 << 1); > > Is uea_encryption_mask a mask of discrete bits or does it contain the > > algorithm number? […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/22766 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I91f9e50f9c1439aa19528f887b83ae9de628fcfd Gerrit-Change-Number: 22766 Gerrit-PatchSet: 4 Gerrit-Owner: laforge Gerrit-Assignee: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Nov 2021 15:48:06 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Comment-In-Reply-To: dexter Gerrit-MessageType: comment
