Build failure of network:osmocom:nightly/osmo-msc in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-msc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-msc Last lines of build log: Reading from filehandle failed at ./bs_worker line 1379. (worker was cloud118:4) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-msc in openSUSE_Tumbleweed/i586
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/openSUSE_Tumbleweed/i586 Package network:osmocom:nightly/osmo-msc failed to build in openSUSE_Tumbleweed/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-msc Last lines of build log: /var/cache/obs/worker/root_3/.pkgs/attr.rpm: Input/output error (worker was cloud118:3) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-hlr in xUbuntu_20.04/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hlr/xUbuntu_20.04/x86_64 Package network:osmocom:nightly/osmo-hlr failed to build in xUbuntu_20.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hlr Last lines of build log: /var/cache/obs/worker/root_1/.pkgs/libgomp1.deb: Input/output error (worker was cloud118:1) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-hlr in Debian_Testing/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hlr/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-hlr failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hlr Last lines of build log: /var/cache/obs/worker/root_4/.pkgs/libgomp1.deb: Input/output error (worker was cloud118:4) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-e1d in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-e1d/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-e1d failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-e1d Last lines of build log: /var/cache/obs/worker/root_1/.pkgs/libgomp1.deb: Input/output error (worker was cloud118:1) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-hnodeb in CentOS_8/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hnodeb/CentOS_8/x86_64 Package network:osmocom:nightly/osmo-hnodeb failed to build in CentOS_8/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnodeb Last lines of build log: /var/cache/obs/worker/root_2/.pkgs/python-srpm-macros.rpm: Input/output error (worker was cloud118:2) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-pcap in xUbuntu_19.04/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcap/xUbuntu_19.04/x86_64 Package network:osmocom:nightly/osmo-pcap failed to build in xUbuntu_19.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcap Last lines of build log: /var/cache/obs/worker/root_1/.pkgs/libgomp1.deb: Input/output error (worker was cloud118:1) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-hlr in openSUSE_Leap_15.1/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hlr/openSUSE_Leap_15.1/x86_64 Package network:osmocom:nightly/osmo-hlr failed to build in openSUSE_Leap_15.1/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hlr Last lines of build log: /var/cache/obs/worker/root_4/.pkgs/attr.rpm: Input/output error (worker was cloud118:4) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-gsm-manuals in Debian_11/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-gsm-manuals/Debian_11/x86_64 Package network:osmocom:nightly/osmo-gsm-manuals failed to build in Debian_11/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-gsm-manuals Last lines of build log: /var/cache/obs/worker/root_4/.pkgs/libgomp1.deb: Input/output error (worker was cloud118:4) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-iuh in openSUSE_Tumbleweed/i586
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-iuh/openSUSE_Tumbleweed/i586 Package network:osmocom:nightly/osmo-iuh failed to build in openSUSE_Tumbleweed/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-iuh Last lines of build log: /var/cache/obs/worker/root_2/.pkgs/attr.rpm: Input/output error (worker was cloud118:2) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-cbc in openSUSE_Tumbleweed/i586
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-cbc/openSUSE_Tumbleweed/i586 Package network:osmocom:nightly/osmo-cbc failed to build in openSUSE_Tumbleweed/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-cbc Last lines of build log: /var/cache/obs/worker/root_2/.pkgs/attr.rpm: Input/output error (worker was cloud118:2) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-pcu in openSUSE_Leap_15.2/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/openSUSE_Leap_15.2/x86_64 Package network:osmocom:nightly/osmo-pcu failed to build in openSUSE_Leap_15.2/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build log: /var/cache/obs/worker/root_1/.pkgs/libgcrypt20.rpm: Input/output error (worker was cloud118:1) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/libosmo-dsp in Debian_9.0/i586
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-dsp/Debian_9.0/i586 Package network:osmocom:nightly/libosmo-dsp failed to build in Debian_9.0/i586 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-dsp Last lines of build log: /var/cache/obs/worker/root_4/.pkgs/libgomp1.deb: Input/output error (worker was cloud118:4) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/libasn1c in openSUSE_Leap_15.1/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libasn1c/openSUSE_Leap_15.1/x86_64 Package network:osmocom:nightly/libasn1c failed to build in openSUSE_Leap_15.1/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libasn1c Last lines of build log: /var/cache/obs/worker/root_3/.pkgs/attr.rpm: Input/output error (worker was cloud118:3) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/libusrp in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libusrp/Debian_Unstable/x86_64 Package network:osmocom:nightly/libusrp failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libusrp Last lines of build log: /var/cache/obs/worker/root_4/.pkgs/libgomp1.deb: Input/output error (worker was cloud118:4) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Change in libgtpnl[master]: fix some cases of rc == 0 on error
laforge has submitted this change. (
https://gerrit.osmocom.org/c/libgtpnl/+/26990 )
Change subject: fix some cases of rc == 0 on error
..
fix some cases of rc == 0 on error
When genl_socket_talk() fails, return rc != 0.
While testing the new osmo-upf program, I noticed that I failed to get a
"Operation not permitted" error when forgetting to set cap_net_admin on
the osmo-upf binary. It looked like everything should work, but doesn't.
It is possible to catch these error cases without this patch, by
monitoring errno. That may well be the intention of the API? I'm still
submitting this patch because it seems better to return rc != 0.
Here is a code example that also catches all error cases without this
patch:
errno = 0;
rc = gtp_add_tunnel(genl_id, nl, t);
if (errno) {
rc = -errno;
} else if (rc) {
rc = -EINVAL;
} else {
tun->active = true;
}
return rc;
Related: SYS#5599
Change-Id: I22fd69709e023572c6c616a4184340a554456faf
---
M src/gtp-genl.c
1 file changed, 7 insertions(+), 3 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/src/gtp-genl.c b/src/gtp-genl.c
index f12f872..b8edc72 100644
--- a/src/gtp-genl.c
+++ b/src/gtp-genl.c
@@ -77,8 +77,10 @@
GTP_CMD_NEWPDP);
gtp_build_payload(nlh, t);
- if (genl_socket_talk(nl, nlh, seq, NULL, NULL) < 0)
+ if (genl_socket_talk(nl, nlh, seq, NULL, NULL) < 0) {
perror("genl_socket_talk");
+ return -1;
+ }
return 0;
}
@@ -94,8 +96,10 @@
GTP_CMD_DELPDP);
gtp_build_payload(nlh, t);
- if (genl_socket_talk(nl, nlh, seq, NULL, NULL) < 0)
+ if (genl_socket_talk(nl, nlh, seq, NULL, NULL) < 0) {
perror("genl_socket_talk");
+ return -1;
+ }
return 0;
}
@@ -200,7 +204,7 @@
if (genl_socket_talk(nl, nlh, seq, genl_gtp_attr_cb, NULL) < 0) {
perror("genl_socket_talk");
- return 0;
+ return -1;
}
return 0;
--
To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/26990
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libgtpnl
Gerrit-Branch: master
Gerrit-Change-Id: I22fd69709e023572c6c616a4184340a554456faf
Gerrit-Change-Number: 26990
Gerrit-PatchSet: 2
Gerrit-Owner: neels
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pablo
Gerrit-CC: pespin
Gerrit-MessageType: merged
Change in osmo-bsc[master]: bts.c: prevent signed integer overflow in depends_on code
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28058 ) Change subject: bts.c: prevent signed integer overflow in depends_on code .. bts.c: prevent signed integer overflow in depends_on code bts.c:818:37: runtime error: left shift of 1 by 31 places cannot be represented in type 'int' Change-Id: Ic68e6eb11fb70bf68d3f075fe2e467aedcbfaba8 --- M src/osmo-bsc/bts.c 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c index 5786833..df8d93d 100644 --- a/src/osmo-bsc/bts.c +++ b/src/osmo-bsc/bts.c @@ -798,7 +798,7 @@ int idx, bit; depends_calc_index_bit(dep, &idx, &bit); - bts->depends_on[idx] |= 1 << bit; + bts->depends_on[idx] |= 1U << bit; } void bts_depend_clear(struct gsm_bts *bts, int dep) @@ -806,7 +806,7 @@ int idx, bit; depends_calc_index_bit(dep, &idx, &bit); - bts->depends_on[idx] &= ~(1 << bit); + bts->depends_on[idx] &= ~(1U << bit); } int bts_depend_is_depedency(struct gsm_bts *base, struct gsm_bts *other) @@ -815,7 +815,7 @@ depends_calc_index_bit(other->nr, &idx, &bit); /* Check if there is a depends bit */ - return (base->depends_on[idx] & (1 << bit)) > 0; + return (base->depends_on[idx] & (1U << bit)) > 0; } static int bts_is_online(struct gsm_bts *bts) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28058 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic68e6eb11fb70bf68d3f075fe2e467aedcbfaba8 Gerrit-Change-Number: 28058 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged
Change in osmo-bsc[master]: bts.c: prevent signed integer overflow in depends_on code
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28058 ) Change subject: bts.c: prevent signed integer overflow in depends_on code .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28058 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic68e6eb11fb70bf68d3f075fe2e467aedcbfaba8 Gerrit-Change-Number: 28058 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sat, 07 May 2022 19:20:56 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Build failure of network:osmocom:latest/libosmocore in openSUSE_Tumbleweed/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmocore/openSUSE_Tumbleweed/x86_64 Package network:osmocom:latest/libosmocore failed to build in openSUSE_Tumbleweed/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libosmocore Last lines of build log: /var/cache/obs/worker/root_2/.pkgs/attr.rpm: Input/output error (worker was cloud118:2) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/libosmocore in openSUSE_Tumbleweed/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/openSUSE_Tumbleweed/x86_64 Package network:osmocom:nightly/libosmocore failed to build in openSUSE_Tumbleweed/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of build log: /var/cache/obs/worker/root_3/.pkgs/libcap2.rpm: Input/output error (worker was cloud118:3) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/libasn1c in openSUSE_Tumbleweed/i586
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libasn1c/openSUSE_Tumbleweed/i586 Package network:osmocom:nightly/libasn1c failed to build in openSUSE_Tumbleweed/i586 Check out the package for editing: osc checkout network:osmocom:nightly libasn1c Last lines of build log: /var/cache/obs/worker/root_1/.pkgs/libcap2.rpm: Input/output error (worker was cloud118:1) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/libosmocore in openSUSE_Tumbleweed/i586
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/openSUSE_Tumbleweed/i586 Package network:osmocom:nightly/libosmocore failed to build in openSUSE_Tumbleweed/i586 Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of build log: /var/cache/obs/worker/root_2/.pkgs/attr.rpm: Input/output error (worker was cloud118:2) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Change in libosmo-abis[master]: input/unixsocket: Remove write delay timer
Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/28064 ) Change subject: input/unixsocket: Remove write delay timer .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/28064 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I642d2e4495a08ce45e9a4492e98255aacd0be39a Gerrit-Change-Number: 28064 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Attention: laforge Gerrit-Comment-Date: Sat, 07 May 2022 08:46:33 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
