Change in libosmo-gprs[master]: debian: clarify license/copyright for CSN.1 codec by ST-Ericsson
Attention is currently required from: osmith, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29071 ) Change subject: debian: clarify license/copyright for CSN.1 codec by ST-Ericsson .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29071 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ia76edccdfc14b06297fe7a306bc19ca52c7db3bd Gerrit-Change-Number: 29071 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Attention: osmith Gerrit-Attention: fixeria Gerrit-Comment-Date: Wed, 17 Aug 2022 06:02:36 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-hnbgw[master]: configure.ac: do not require unused dlopen
Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29104 ) Change subject: configure.ac: do not require unused dlopen .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29104 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ia23cee40fd63f708e7a7391417ec8604f51a20a7 Gerrit-Change-Number: 29104 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Attention: fixeria Gerrit-Comment-Date: Wed, 17 Aug 2022 06:00:55 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-gbproxy[master]: configure.ac: do not require unused dlsym/dlopen
Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/29106 ) Change subject: configure.ac: do not require unused dlsym/dlopen .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/29106 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: Ib1a208c40ba9c3667980e5c404087e801a4eaaf1 Gerrit-Change-Number: 29106 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Attention: fixeria Gerrit-Comment-Date: Wed, 17 Aug 2022 06:00:46 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-upf[master]: configure.ac: do not require unused dlopen
Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/29103 ) Change subject: configure.ac: do not require unused dlopen .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/29103 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ied459216cc13f1481e8b0db978a284363197f32a Gerrit-Change-Number: 29103 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Attention: fixeria Gerrit-Comment-Date: Wed, 17 Aug 2022 05:59:49 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmo-gprs[master]: configure.ac: do require unused dlopen
Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29100 ) Change subject: configure.ac: do require unused dlopen .. Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: looks like we don't have jenkins build verification yet? This should be done first so we get this for all patch review. -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29100 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Iaf9729156ace5f8dc9134094ab3c0a185c7184d5 Gerrit-Change-Number: 29100 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: laforge Gerrit-Attention: fixeria Gerrit-Comment-Date: Wed, 17 Aug 2022 05:59:36 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-sgsn[master]: configure.ac: do not require unused dlsym/dlopen
Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/29102 ) Change subject: configure.ac: do not require unused dlsym/dlopen .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/29102 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I90b383ed45b27d8b59272116dd81acb72912349d Gerrit-Change-Number: 29102 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Attention: fixeria Gerrit-Comment-Date: Wed, 17 Aug 2022 05:59:01 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: configure.ac: do not require unused dlopen
Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29101 ) Change subject: configure.ac: do not require unused dlopen .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29101 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I528ed8d7b61b39a474376c21fccc47a8531027b7 Gerrit-Change-Number: 29101 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Attention: fixeria Gerrit-Comment-Date: Wed, 17 Aug 2022 05:58:50 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmo-pfcp[master]: configure.ac: do not require unused dlopen
Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/29107 ) Change subject: configure.ac: do not require unused dlopen .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29107 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: Ic012f7b19a46ee38db0172b07bad2098567192b0 Gerrit-Change-Number: 29107 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Attention: fixeria Gerrit-Comment-Date: Wed, 17 Aug 2022 05:58:38 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-pcu[master]: Migrate to libosmocsn1 and libosmo-gprs-rlcmac
Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/28972 ) Change subject: Migrate to libosmocsn1 and libosmo-gprs-rlcmac .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/28972 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Icba62ad8649e78acab711392dfd74fe571474381 Gerrit-Change-Number: 28972 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Attention: fixeria Gerrit-Comment-Date: Wed, 17 Aug 2022 05:58:22 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-upf[master]: debian: add missing changelog
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/29111 ) Change subject: debian: add missing changelog .. debian: add missing changelog Change-Id: I53551ce1a6d3176d480a56f8f5d2441da7346711 --- M debian/changelog 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/debian/changelog b/debian/changelog index e69de29..ca2e0ba 100644 --- a/debian/changelog +++ b/debian/changelog @@ -0,0 +1,5 @@ +osmo-upf (0.1.0) testing; urgency=low + + Create new Debian package. + + -- Neels Hofmeyr Tue, 16 Aug 2022 23:17:05 +0200 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/29111 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I53551ce1a6d3176d480a56f8f5d2441da7346711 Gerrit-Change-Number: 29111 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged
Change in osmo-upf[master]: debian: add missing changelog
Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/29111 ) Change subject: debian: add missing changelog .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/29111 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I53551ce1a6d3176d480a56f8f5d2441da7346711 Gerrit-Change-Number: 29111 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Attention: neels Gerrit-Comment-Date: Wed, 17 Aug 2022 05:56:33 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in docker-playground[master]: osmo-hlr-master: install libsqlite3-dev/sqlite-devel
laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/29112 ) Change subject: osmo-hlr-master: install libsqlite3-dev/sqlite-devel .. osmo-hlr-master: install libsqlite3-dev/sqlite-devel osmo-hlr is using libsqlite3 directly, not via libdbd. Change-Id: I99e43dff8f94fbef1a2dd9934caf6ba1fa7cc1f7 --- M osmo-hlr-master/Dockerfile 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/osmo-hlr-master/Dockerfile b/osmo-hlr-master/Dockerfile index 9ddc193..1c3251a 100644 --- a/osmo-hlr-master/Dockerfile +++ b/osmo-hlr-master/Dockerfile @@ -8,7 +8,7 @@ debian*) \ apt-get update && \ apt-get install -y --no-install-recommends \ - libdbd-sqlite3 \ + libsqlite3-dev \ libosmo-abis-dev \ libosmo-netif-dev \ libosmo-sigtran-dev \ @@ -22,6 +22,7 @@ "pkgconfig(libosmoctrl)" \ "pkgconfig(libosmogsm)" \ "pkgconfig(libosmovty)" \ + sqlite-devel \ python3 \ ;; \ esac -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29112 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I99e43dff8f94fbef1a2dd9934caf6ba1fa7cc1f7 Gerrit-Change-Number: 29112 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged
Change in docker-playground[master]: osmo-msc-master: install libsqlite3-dev/sqlite-devel
laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/29113 ) Change subject: osmo-msc-master: install libsqlite3-dev/sqlite-devel .. osmo-msc-master: install libsqlite3-dev/sqlite-devel Since recenly, osmo-msc is using libsqlite3 directly. Change-Id: I4b0ecfcc9a25797eb8e12f07e039160dfc296d4c --- M osmo-msc-master/Dockerfile 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/osmo-msc-master/Dockerfile b/osmo-msc-master/Dockerfile index 1ad4684..7d79988 100644 --- a/osmo-msc-master/Dockerfile +++ b/osmo-msc-master/Dockerfile @@ -9,8 +9,7 @@ apt-get update && \ apt-get install -y --no-install-recommends \ libasn1c-dev \ - libdbd-sqlite3 \ - libdbi-dev \ + libsqlite3-dev \ libosmo-abis-dev \ libosmo-mgcp-client-dev \ libosmo-gsup-client-dev \ @@ -37,6 +36,7 @@ "pkgconfig(libosmogsm)" \ "pkgconfig(libosmovty)" \ "pkgconfig(libsmpp34)" \ + sqlite-devel \ ;; \ esac -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29113 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I4b0ecfcc9a25797eb8e12f07e039160dfc296d4c Gerrit-Change-Number: 29113 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged
Change in docker-playground[master]: osmo-msc-master: install libsqlite3-dev/sqlite-devel
Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/29113 ) Change subject: osmo-msc-master: install libsqlite3-dev/sqlite-devel .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29113 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I4b0ecfcc9a25797eb8e12f07e039160dfc296d4c Gerrit-Change-Number: 29113 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Attention: fixeria Gerrit-Comment-Date: Wed, 17 Aug 2022 05:56:17 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in docker-playground[master]: osmo-hlr-master: install libsqlite3-dev/sqlite-devel
Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/29112 ) Change subject: osmo-hlr-master: install libsqlite3-dev/sqlite-devel .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29112 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I99e43dff8f94fbef1a2dd9934caf6ba1fa7cc1f7 Gerrit-Change-Number: 29112 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Attention: fixeria Gerrit-Comment-Date: Wed, 17 Aug 2022 05:56:09 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmo-pfcp[master]: RPM: fix configure and typo "gltv" in .spec.in
Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/29115 ) Change subject: RPM: fix configure and typo "gltv" in .spec.in .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29115 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: Ideff7942a3250fa6541cfa6252a1c2927afdfc45 Gerrit-Change-Number: 29115 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Attention: neels Gerrit-Comment-Date: Wed, 17 Aug 2022 05:55:35 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-hnbgw[master]: ps_rab_fsm: check use cb success
Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29072 ) Change subject: ps_rab_fsm: check use cb success .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29072 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Idcb3d6796326b059280b0e552eb36067ba15b3ac Gerrit-Change-Number: 29072 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Attention: neels Gerrit-Comment-Date: Wed, 17 Aug 2022 05:54:46 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-hnbgw[master]: optimize: decode PS msgs only when PFCP is enabled
Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29003 ) Change subject: optimize: decode PS msgs only when PFCP is enabled .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29003 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ifb57bad6a0d5ff263e4c6c3facc51620e110e7d2 Gerrit-Change-Number: 29003 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Attention: neels Gerrit-Comment-Date: Wed, 17 Aug 2022 05:54:25 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-hnbgw[master]: manual: update IuCS/IuPS protocol stack chart
Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29093 ) Change subject: manual: update IuCS/IuPS protocol stack chart .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29093 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I4496a6ffdda511875208bebbe68dbc9e69541fc0 Gerrit-Change-Number: 29093 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Attention: neels Gerrit-Comment-Date: Wed, 17 Aug 2022 05:53:39 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-hnbgw[master]: manual: update overview chart with PFCP
Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29076 ) Change subject: manual: update overview chart with PFCP .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29076 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ifd8843aeb8ff28fec53323c8fb37b10d4d1f2f9b Gerrit-Change-Number: 29076 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Attention: neels Gerrit-Comment-Date: Wed, 17 Aug 2022 05:53:28 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-hnbgw[master]: manual: explain the PFCP port
Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29075 ) Change subject: manual: explain the PFCP port .. Patch Set 2: (1 comment) File doc/manuals/chapters/running.adoc: https://gerrit.osmocom.org/c/osmo-hnbgw/+/29075/comment/ce9a44fb_63eea54d PS2, Line 147: optionally supports if this is a compile-time option, it should be stated here to avoid users assuming they can just always use the below config snippet without using any special compile options. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29075 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I383befb226caa49e4a2577657806aef1ee11faa3 Gerrit-Change-Number: 29075 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-CC: laforge Gerrit-Attention: neels Gerrit-Comment-Date: Wed, 17 Aug 2022 05:53:14 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-hnbgw[master]: manual: add missing bit on the MGCP port
Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29074 ) Change subject: manual: add missing bit on the MGCP port .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29074 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ic18180793f0c1497b020e5f4a8cd34d6b519b85f Gerrit-Change-Number: 29074 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Attention: neels Gerrit-Comment-Date: Wed, 17 Aug 2022 05:51:52 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-hnbgw[master]: osmo-hnbgw.cfg example: add pfcp
Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29073 ) Change subject: osmo-hnbgw.cfg example: add pfcp .. Patch Set 2: Code-Review-1 (1 comment) Patchset: PS2: well, actually we made this optional, right? I think if pfcp support is not enabled in a default build, then the default example config file should also not use it. Feel free to add a separate example config file for that situation. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29073 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I62c4935bcc7f684bfe850f88f1b80e8970e0e098 Gerrit-Change-Number: 29073 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Attention: neels Gerrit-Comment-Date: Wed, 17 Aug 2022 05:51:40 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-hnbgw[master]: osmo-hnbgw.cfg example: add pfcp
Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29073 ) Change subject: osmo-hnbgw.cfg example: add pfcp .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29073 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I62c4935bcc7f684bfe850f88f1b80e8970e0e098 Gerrit-Change-Number: 29073 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Attention: neels Gerrit-Comment-Date: Wed, 17 Aug 2022 05:50:40 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-hnbgw[master]: make: fix -l order: first libosmo-pfcp, then -gtlv
Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29118 ) Change subject: make: fix -l order: first libosmo-pfcp, then -gtlv .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29118 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ibbddef02edbd6eb58828ca496f3b36613d4285fc Gerrit-Change-Number: 29118 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Attention: neels Gerrit-Comment-Date: Wed, 17 Aug 2022 05:50:27 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: BSSMAP: make sure we don't try to reset non-existent entity
Attention is currently required from: pespin, msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28892 ) Change subject: BSSMAP: make sure we don't try to reset non-existent entity .. Patch Set 2: (1 comment) Patchset: PS2: I didm't do a thorough analysis myself, but agree with neels, if he thinks there is no code path leading to this. Certainly we don't want to check everything for NULL in our code base. On the other hand, if we are sure that it's never NULL, we might add an OSMO_ASSERT(). -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28892 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I235bdd42ea82e7b5a1a40f437ca34c49ad239c48 Gerrit-Change-Number: 28892 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Attention: pespin Gerrit-Attention: msuraev Gerrit-Comment-Date: Wed, 17 Aug 2022 05:50:04 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in libosmo-sccp[master]: SIGTRAN: add function to check connection existence
Attention is currently required from: neels, fixeria, msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29087 ) Change subject: SIGTRAN: add function to check connection existence .. Patch Set 9: Code-Review-1 (1 comment) Patchset: PS9: this doesn't just add a function, but it also adds additional debug output on the message size. I'm fine with the function and adding log output in error situations. But I don't like the additonal debug logging, see my comment to the other patch. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29087 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Iffedf55b4c292ee6b2f97bcdeef6dc13c050ce01 Gerrit-Change-Number: 29087 Gerrit-PatchSet: 9 Gerrit-Owner: msuraev Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-CC: fixeria Gerrit-Attention: neels Gerrit-Attention: fixeria Gerrit-Attention: msuraev Gerrit-Comment-Date: Wed, 17 Aug 2022 05:41:48 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmo-sccp[master]: Log more data on CR and N-CONNECT
Attention is currently required from: neels, msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29085 ) Change subject: Log more data on CR and N-CONNECT .. Patch Set 8: Code-Review-1 (1 comment) Patchset: PS8: I also think it's not entirely customary to log the size of each message we're sending. This can easily be done with wireshark, or with a debugger/tracepoint or (like I'd do it these days) some kind of bfptrace program attached to the specific funciton. the latter can even draw you nice histogram of message sizes with something like 5 lines of code. At zero overhead for the normal non-debug use case. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29085 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I4d7fc44fde5b900907ec5ebec0450040a764802a Gerrit-Change-Number: 29085 Gerrit-PatchSet: 8 Gerrit-Owner: msuraev Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Attention: neels Gerrit-Attention: msuraev Gerrit-Comment-Date: Wed, 17 Aug 2022 05:40:23 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmo-sccp[master]: SCCP: enforce optional data length limits
Attention is currently required from: neels, msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29083 ) Change subject: SCCP: enforce optional data length limits .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29083 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Icc3bd0a71b29cf61a259c5d97e7dd85beb4397bd Gerrit-Change-Number: 29083 Gerrit-PatchSet: 5 Gerrit-Owner: msuraev Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-CC: neels Gerrit-Attention: neels Gerrit-Attention: msuraev Gerrit-Comment-Date: Wed, 17 Aug 2022 05:28:44 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: Revert "Add osmo_sockaddr_strs_to_str()"
Attention is currently required from: neels, pespin, msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29123 ) Change subject: Revert "Add osmo_sockaddr_strs_to_str()" .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29123 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I263dfd68313b896c5b474025fbca13c22ce41cdc Gerrit-Change-Number: 29123 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: msuraev Gerrit-Reviewer: pespin Gerrit-Attention: neels Gerrit-Attention: pespin Gerrit-Attention: msuraev Gerrit-Comment-Date: Wed, 17 Aug 2022 05:25:32 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: Revert "Add function to guess AF_UNSPEC address"
Attention is currently required from: neels, fixeria, msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29122 ) Change subject: Revert "Add function to guess AF_UNSPEC address" .. Patch Set 1: (1 comment) Patchset: PS1: > I disagree - see osmo_ip_str_type(): this function is just convenience > wrapper over it. […] osmo_ip_str_type operates on a text string, which will contain an address. i guess the perceived danger of this new function is that there is code that doesnt set the AF?more explanation and/or examples required -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29122 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ifadd614604cf9d0c2ed1a405493c1c3fcb37ae23 Gerrit-Change-Number: 29122 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: msuraev Gerrit-CC: pespin Gerrit-Attention: neels Gerrit-Attention: fixeria Gerrit-Attention: msuraev Gerrit-Comment-Date: Wed, 17 Aug 2022 05:22:57 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: msuraev Gerrit-MessageType: comment
Change in osmo-ci[master]: obs: tweak logging output
Attention is currently required from: osmith, neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29117 ) Change subject: obs: tweak logging output .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29117 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I203cb7f0aa21b59b06973e8f329cffdc64aa8d47 Gerrit-Change-Number: 29117 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Attention: osmith Gerrit-Attention: neels Gerrit-Comment-Date: Wed, 17 Aug 2022 05:18:56 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ci[master]: obs: add README
Attention is currently required from: osmith, neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29110 ) Change subject: obs: add README .. Patch Set 3: (1 comment) File scripts/obs/README: https://gerrit.osmocom.org/c/osmo-ci/+/29110/comment/1e69c512_cad09fc0 PS3, Line 35: Replace "api.opensuse.org" with "obs.osmocom.org" in two places: Isn't the "-A https://lobs.osmocom.org"; the proper way to do this? -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29110 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4d1303e0c04e827200b48a9fe4aea3680c9c9f84 Gerrit-Change-Number: 29110 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-CC: laforge Gerrit-Attention: osmith Gerrit-Attention: neels Gerrit-Comment-Date: Wed, 17 Aug 2022 05:17:24 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-ci[master]: obs: add explicit --git-branch arg
Attention is currently required from: osmith, neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29116 ) Change subject: obs: add explicit --git-branch arg .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29116 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I612c18e533542f442e0571927fee8b8be9fb8c2b Gerrit-Change-Number: 29116 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Attention: osmith Gerrit-Attention: neels Gerrit-Comment-Date: Wed, 17 Aug 2022 05:15:15 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-ci[master]: obs: add libosmo-pfcp, osmo-upf
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29047 ) Change subject: obs: add libosmo-pfcp, osmo-upf .. obs: add libosmo-pfcp, osmo-upf Change-Id: I7192f4c9e77035cebb147b8186296bcd741d419b --- M scripts/obs/lib/config.py 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved osmith: Looks good to me, but someone else must approve neels: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/scripts/obs/lib/config.py b/scripts/obs/lib/config.py index a4a10c5..997fff2 100644 --- a/scripts/obs/lib/config.py +++ b/scripts/obs/lib/config.py @@ -44,6 +44,7 @@ "libosmo-abis", "libosmo-dsp", "libosmo-netif", +"libosmo-pfcp", "libosmo-sccp", "libosmocore", "libsmpp34", @@ -72,6 +73,7 @@ "osmo-sysmon", "osmo-trx", "osmo-uecups", +"osmo-upf", "python/osmo-python-tests", "rtl-sdr", "simtrace2", -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29047 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I7192f4c9e77035cebb147b8186296bcd741d419b Gerrit-Change-Number: 29047 Gerrit-PatchSet: 5 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-MessageType: merged
Change in osmo-ci[master]: obs: add libosmo-pfcp, osmo-upf
Attention is currently required from: osmith, neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29047 ) Change subject: obs: add libosmo-pfcp, osmo-upf .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29047 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I7192f4c9e77035cebb147b8186296bcd741d419b Gerrit-Change-Number: 29047 Gerrit-PatchSet: 5 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Attention: osmith Gerrit-Attention: neels Gerrit-Comment-Date: Wed, 17 Aug 2022 05:13:36 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: Revert "Add function to guess AF_UNSPEC address"
Attention is currently required from: neels, laforge, fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29122 ) Change subject: Revert "Add function to guess AF_UNSPEC address" .. Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: I disagree - see osmo_ip_str_type(): this function is just convenience wrapper over it. So we should either remove both or keep both of them. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29122 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ifadd614604cf9d0c2ed1a405493c1c3fcb37ae23 Gerrit-Change-Number: 29122 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: msuraev Gerrit-CC: pespin Gerrit-Attention: neels Gerrit-Attention: laforge Gerrit-Attention: fixeria Gerrit-Comment-Date: Wed, 17 Aug 2022 04:54:46 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmo-sccp[master]: cosmetic: improve usage help of example code
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29086 ) Change subject: cosmetic: improve usage help of example code .. Patch Set 10: (1 comment) File examples/sccp_demo_user.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29086/comment/83d9b85b_8c90a043 PS9, Line 124: , > nice catch! Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29086 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I342dc227afbfe6c3540eb3285677c568d2fe3166 Gerrit-Change-Number: 29086 Gerrit-PatchSet: 10 Gerrit-Owner: msuraev Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: msuraev Gerrit-Reviewer: neels Gerrit-Comment-Date: Wed, 17 Aug 2022 04:50:10 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels Gerrit-MessageType: comment
Change in libosmo-sccp[master]: cosmetic: improve usage help of example code
msuraev has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29086 ) Change subject: cosmetic: improve usage help of example code .. cosmetic: improve usage help of example code * document -C option for example server * move misplaced comma * drop empty #define from example code Change-Id: I342dc227afbfe6c3540eb3285677c568d2fe3166 --- M examples/sccp_demo_user.c 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified neels: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/examples/sccp_demo_user.c b/examples/sccp_demo_user.c index 1a4ebac..df6c9af 100644 --- a/examples/sccp_demo_user.c +++ b/examples/sccp_demo_user.c @@ -105,7 +105,6 @@ #define DEFAULT_LOCAL_PORT_CLIENT M3UA_PORT #define DEFAULT_REMOTE_PORT_CLIENT DEFAULT_LOCAL_PORT_SERVER #define DEFAULT_REMOTE_PORT_SERVER DEFAULT_LOCAL_PORT_CLIENT -#define DEFAULT_REMOTE_PORT_SERVER_STR DEFAULT_LOCAL_PORT_CLIENT_STR #define DEFAULT_PC_SERVER 1 #define DEFAULT_PC_CLIENT 23 @@ -116,13 +115,14 @@ "Options:\n" " -p: protocol to use (m3ua, sua, ipa; default is ipa)\n" " -c: Run in client mode (default is server mode)\n" + " -C filename The config file to use\n" " -l: local IP address and SCTP port (default is %s:%d in server mode,\n" " %s:%d in client mode)\n" " -r: remote IP address and SCTP port (default is %s:%d in server mode,\n" " %s:%d in client mode)\n" " -L: local point code (default is %d in server mode, %d in client mode)\n" - " -R: remote point code (default is %d in server mode, %d in client mode)\n", - " -d: LOGMASK (libosmocore log mask string, e.g. -d DLINP,1:DLSS7,2)\n" + " -R: remote point code (default is %d in server mode, %d in client mode)\n" + " -d: LOGMASK (libosmocore log mask string, e.g. -d DLINP,1:DLSS7,2)\n", DEFAULT_LOCAL_ADDRESS_SERVER, DEFAULT_LOCAL_PORT_SERVER, DEFAULT_LOCAL_ADDRESS_CLIENT, DEFAULT_LOCAL_PORT_CLIENT, DEFAULT_REMOTE_ADDRESS_SERVER, DEFAULT_REMOTE_PORT_SERVER, 9 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29086 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I342dc227afbfe6c3540eb3285677c568d2fe3166 Gerrit-Change-Number: 29086 Gerrit-PatchSet: 10 Gerrit-Owner: msuraev Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: msuraev Gerrit-Reviewer: neels Gerrit-MessageType: merged
Change in libosmo-sccp[master]: SCCP: enforce optional data length limits
Attention is currently required from: neels. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29083 ) Change subject: SCCP: enforce optional data length limits .. Patch Set 5: (1 comment) File src/sccp.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29083/comment/c80251cb_d07e3355 PS4, Line 234: return -EBADSLT; > EBADSLT "Invalid slot"? how about EMSGSIZE Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29083 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Icc3bd0a71b29cf61a259c5d97e7dd85beb4397bd Gerrit-Change-Number: 29083 Gerrit-PatchSet: 5 Gerrit-Owner: msuraev Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-CC: neels Gerrit-Attention: neels Gerrit-Comment-Date: Wed, 17 Aug 2022 04:48:43 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels Gerrit-MessageType: comment
Change in libosmo-sccp[master]: Log more data on CR and N-CONNECT
Attention is currently required from: neels. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29085 ) Change subject: Log more data on CR and N-CONNECT .. Patch Set 8: (1 comment) Patchset: PS7: > i'd solve this question by looking at wireshark instead of logging? Those're not mutually exclusive. Although I should try GSMTAP log target to see both at the same place. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29085 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I4d7fc44fde5b900907ec5ebec0450040a764802a Gerrit-Change-Number: 29085 Gerrit-PatchSet: 8 Gerrit-Owner: msuraev Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Attention: neels Gerrit-Comment-Date: Wed, 17 Aug 2022 04:48:27 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels Gerrit-MessageType: comment
Change in libosmo-sccp[master]: SIGTRAN: add function to check connection existence
Attention is currently required from: neels, fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29087 ) Change subject: SIGTRAN: add function to check connection existence .. Patch Set 9: (1 comment) File examples/sccp_test_vty.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29087/comment/35adf953_392149f8 PS8, Line 44: int conn_id = atoi(argv[0]), ret; > please declare 'int ret;' on a separate line Why? I don't recall anything about it from Linux kernel coding style. Having it on the same line makes it easier to read. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29087 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Iffedf55b4c292ee6b2f97bcdeef6dc13c050ce01 Gerrit-Change-Number: 29087 Gerrit-PatchSet: 9 Gerrit-Owner: msuraev Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-CC: fixeria Gerrit-Attention: neels Gerrit-Attention: fixeria Gerrit-Comment-Date: Wed, 17 Aug 2022 04:47:00 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels Gerrit-MessageType: comment
Change in libosmo-sccp[master]: SIGTRAN: enforce length limits on SCCP Optional Data
Attention is currently required from: neels. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 ) Change subject: SIGTRAN: enforce length limits on SCCP Optional Data .. Patch Set 4: (2 comments) Commit Message: https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/7f33be80_6ebfb2a4 PS4, Line 7: SIGTRAN: enforce optional data length limits > "enforce length limits on SCCP Optional Data" ? Done File src/sccp_scoc.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/5066f7ee_e94b5471 PS4, Line 617: /* optional: hop coun */ > "count" ? Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I0033faf9da393418930252233ce74d62cd1cef8a Gerrit-Change-Number: 29084 Gerrit-PatchSet: 4 Gerrit-Owner: msuraev Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-Attention: neels Gerrit-Comment-Date: Wed, 17 Aug 2022 04:45:15 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels Gerrit-MessageType: comment
Change in libosmo-sccp[master]: SIGTRAN: add function to check connection existence
Attention is currently required from: fixeria, msuraev. Hello Jenkins Builder, neels, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29087 to look at the new patch set (#9). Change subject: SIGTRAN: add function to check connection existence .. SIGTRAN: add function to check connection existence Add convenience helper to check if particular connection ID exists and use it to properly report errors when attempting to send messages over non-existent connections. Change-Id: Iffedf55b4c292ee6b2f97bcdeef6dc13c050ce01 --- M examples/sccp_test_vty.c M include/osmocom/sigtran/sccp_helpers.h M src/sccp_helpers.c M src/sccp_scoc.c 4 files changed, 41 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/87/29087/9 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29087 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Iffedf55b4c292ee6b2f97bcdeef6dc13c050ce01 Gerrit-Change-Number: 29087 Gerrit-PatchSet: 9 Gerrit-Owner: msuraev Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-CC: fixeria Gerrit-Attention: fixeria Gerrit-Attention: msuraev Gerrit-MessageType: newpatchset
Change in libosmo-sccp[master]: SIGTRAN: enforce length limits on SCCP Optional Data
Attention is currently required from: msuraev. Hello Jenkins Builder, neels, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 to look at the new patch set (#5). Change subject: SIGTRAN: enforce length limits on SCCP Optional Data .. SIGTRAN: enforce length limits on SCCP Optional Data Limit length of optional Data parameter to 130 bytes to conform with ITU-T Rec Q.713 §4.2..§4.5 while sending SCCP messages. Related: OS#5579 Change-Id: I0033faf9da393418930252233ce74d62cd1cef8a --- M src/sccp_scoc.c 1 file changed, 31 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/84/29084/5 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I0033faf9da393418930252233ce74d62cd1cef8a Gerrit-Change-Number: 29084 Gerrit-PatchSet: 5 Gerrit-Owner: msuraev Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-Attention: msuraev Gerrit-MessageType: newpatchset
Change in libosmo-sccp[master]: SCCP: enforce optional data length limits
Attention is currently required from: msuraev. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29083 to look at the new patch set (#5). Change subject: SCCP: enforce optional data length limits .. SCCP: enforce optional data length limits Limit length of optional Data parameter to 130 bytes to conform with ITU-T Rec Q.713 §4.2..§4.5 while receiving SCCP messages. Related: OS#5579 Change-Id: Icc3bd0a71b29cf61a259c5d97e7dd85beb4397bd --- M include/osmocom/sccp/sccp_types.h M src/sccp.c 2 files changed, 29 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/83/29083/5 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29083 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Icc3bd0a71b29cf61a259c5d97e7dd85beb4397bd Gerrit-Change-Number: 29083 Gerrit-PatchSet: 5 Gerrit-Owner: msuraev Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-CC: neels Gerrit-Attention: msuraev Gerrit-MessageType: newpatchset
Change in osmo-hnbgw[master]: make: fix -l order: first libosmo-pfcp, then -gtlv
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29118 ) Change subject: make: fix -l order: first libosmo-pfcp, then -gtlv .. make: fix -l order: first libosmo-pfcp, then -gtlv During debian package building on OBS, the package build fails if libosmo-gtlv is listed before libosmo-pfcp. Change-Id: Ibbddef02edbd6eb58828ca496f3b36613d4285fc --- M src/osmo-hnbgw/Makefile.am 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/18/29118/1 diff --git a/src/osmo-hnbgw/Makefile.am b/src/osmo-hnbgw/Makefile.am index 1d907ba..3f397ec 100644 --- a/src/osmo-hnbgw/Makefile.am +++ b/src/osmo-hnbgw/Makefile.am @@ -62,12 +62,12 @@ if ENABLE_PFCP AM_CFLAGS += \ - $(LIBOSMOGTLV_CFLAGS) \ $(LIBOSMOPFCP_CFLAGS) \ + $(LIBOSMOGTLV_CFLAGS) \ $(NULL) osmo_hnbgw_LDADD += \ - $(LIBOSMOGTLV_LIBS) \ $(LIBOSMOPFCP_LIBS) \ + $(LIBOSMOGTLV_LIBS) \ $(NULL) osmo_hnbgw_SOURCES += \ hnbgw_pfcp.c \ -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29118 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ibbddef02edbd6eb58828ca496f3b36613d4285fc Gerrit-Change-Number: 29118 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-MessageType: newchange
Change in osmo-ci[master]: obs: add README
Attention is currently required from: osmith. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29110 ) Change subject: obs: add README .. Patch Set 3: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29110 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4d1303e0c04e827200b48a9fe4aea3680c9c9f84 Gerrit-Change-Number: 29110 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Attention: osmith Gerrit-Comment-Date: Wed, 17 Aug 2022 02:12:54 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-ci[master]: obs: add explicit --git-branch arg
neels has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ci/+/29116 )
Change subject: obs: add explicit --git-branch arg
..
obs: add explicit --git-branch arg
Change-Id: I612c18e533542f442e0571927fee8b8be9fb8c2b
---
M scripts/obs/build_srcpkg.py
M scripts/obs/lib/__init__.py
M scripts/obs/lib/srcpkg.py
M scripts/obs/update_obs_project.py
4 files changed, 22 insertions(+), 13 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/16/29116/1
diff --git a/scripts/obs/build_srcpkg.py b/scripts/obs/build_srcpkg.py
index ccf82d7..ea7ab34 100755
--- a/scripts/obs/build_srcpkg.py
+++ b/scripts/obs/build_srcpkg.py
@@ -40,7 +40,7 @@
lib.metapkg.build(args.feed, args.conflict_version)
if args.package:
-lib.srcpkg.build(args.package, args.feed, args.conflict_version,
+lib.srcpkg.build(args.package, args.feed, args.git_branch,
args.conflict_version,
args.git_fetch)
diff --git a/scripts/obs/lib/__init__.py b/scripts/obs/lib/__init__.py
index 193c248..8473ab9 100644
--- a/scripts/obs/lib/__init__.py
+++ b/scripts/obs/lib/__init__.py
@@ -16,6 +16,9 @@
parser.add_argument("-f", "--feed", help="package feed (default: nightly)",
metavar="FEED", default="nightly",
choices=lib.config.feeds)
+parser.add_argument("-b", "--git-branch", help="instead of using a branch"
+ " named like the feed, checkout this git branch",
+metavar="BRANCH", default=None)
parser.add_argument("-d", "--docker",
help="run in docker to avoid installing required pkgs",
action="store_true")
diff --git a/scripts/obs/lib/srcpkg.py b/scripts/obs/lib/srcpkg.py
index 468a240..6148883 100644
--- a/scripts/obs/lib/srcpkg.py
+++ b/scripts/obs/lib/srcpkg.py
@@ -7,9 +7,11 @@
import lib.rpm_spec
-def checkout_for_feed(project, feed):
+def checkout_for_feed(project, feed, branch=None):
""" checkout a commit, either latest tag or master or 20YY branch """
-if feed == "latest":
+if branch:
+lib.git.checkout(project, branch)
+elif feed == "latest":
lib.git.checkout_latest_tag(project)
elif feed == "nightly":
lib.git.checkout_default_branch(project)
@@ -118,10 +120,12 @@
f.write(f"{version}\n")
-def build(project, feed, conflict_version, fetch):
+def build(project, feed, branch, conflict_version, fetch):
+if not branch:
+branch = feed
lib.git.clone(project, fetch)
lib.git.clean(project)
-checkout_for_feed(project, feed)
+checkout_for_feed(project, feed, branch)
version = get_version_for_feed(project, feed, conflict_version)
epoch = get_epoch(project)
version_epoch = f"{epoch}:{version}" if epoch else version
@@ -132,6 +136,7 @@
if project in lib.config.projects_osmocom:
metapkg = f"osmocom-{feed}"
+
lib.debian.control_add_depend(project, metapkg, conflict_version)
if has_rpm_spec:
lib.rpm_spec.add_depend(project, metapkg, conflict_version)
diff --git a/scripts/obs/update_obs_project.py
b/scripts/obs/update_obs_project.py
index 759acfe..02db7ce 100755
--- a/scripts/obs/update_obs_project.py
+++ b/scripts/obs/update_obs_project.py
@@ -32,7 +32,7 @@
return ret
-def build_srcpkg(feed, package, conflict_version, fetch, is_meta_pkg):
+def build_srcpkg(feed, branch, package, conflict_version, fetch, is_meta_pkg):
global srcpkgs_built
global srcpkgs_failed_build
@@ -42,7 +42,7 @@
if is_meta_pkg:
version = lib.metapkg.build(feed, conflict_version)
else:
-version = lib.srcpkg.build(package, feed, conflict_version, fetch)
+version = lib.srcpkg.build(package, feed, branch,
conflict_version, fetch)
srcpkgs_built[package] = version
except Exception as ex:
traceback.print_exception(type(ex), ex, ex.__traceback__)
@@ -62,7 +62,7 @@
return False
-def build_srcpkg_if_needed(proj, feed, pkgs_remote, package, conflict_version,
+def build_srcpkg_if_needed(proj, feed, branch, pkgs_remote, package,
conflict_version,
fetch, is_meta_pkg, skip_up_to_date):
global srcpkgs_skipped
@@ -96,7 +96,7 @@
print(f"{package}: building source package (outdated:"
f" {latest_version} <=> {obs_version} in OBS)")
-build_srcpkg(feed, package, conflict_version, fetch, is_meta_pkg)
+build_srcpkg(feed, branch, package, conflict_version, fetch, is_meta_pkg)
def upload_srcpkg(proj, feed, pkgs_remote, package, version):
@@ -105,18 +105,18 @@
lib.osc.update_package(proj, package, version)
-def build_srcpkgs(proj, feed, pkgs_remote, packages, conflict_version, fetch,
+def build_srcpkgs(proj, feed, branch, pkgs_remote, packages, conflict
Change in osmo-ci[master]: obs: tweak logging output
neels has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ci/+/29117 )
Change subject: obs: tweak logging output
..
obs: tweak logging output
Change-Id: I203cb7f0aa21b59b06973e8f329cffdc64aa8d47
---
M scripts/obs/lib/git.py
1 file changed, 5 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/17/29117/1
diff --git a/scripts/obs/lib/git.py b/scripts/obs/lib/git.py
index 67f1d5e..29c183b 100644
--- a/scripts/obs/lib/git.py
+++ b/scripts/obs/lib/git.py
@@ -28,10 +28,10 @@
if os.path.exists(repo_path):
if fetch:
-print(f"{project}: cloning {url} (cached, fetching)")
+print(f"{project}: 'git fetch'")
lib.run_cmd(["git", "fetch"], cwd=repo_path)
else:
-print(f"{project}: cloning {url} (cached, not fetching)")
+print(f"{project}: using cached {url} (not cloning, not fetching)")
return
print(f"{project}: cloning {url}")
@@ -46,13 +46,15 @@
def clean(project):
repo_path = get_repo_path(project)
+print(f"{project}: 'git clean -ffxd'")
lib.run_cmd(["git", "clean", "-ffxd"], cwd=repo_path)
def checkout(project, branch):
repo_path = get_repo_path(project)
-print(f"{project}: checking out {branch}")
+print(f"{project}: 'git checkout -f {branch}'")
lib.run_cmd(["git", "checkout", "-f", branch], cwd=repo_path)
+print(f"{project}: 'git reset --hard {branch}'")
lib.run_cmd(["git", "reset", "--hard", branch], cwd=repo_path)
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29117
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I203cb7f0aa21b59b06973e8f329cffdc64aa8d47
Gerrit-Change-Number: 29117
Gerrit-PatchSet: 1
Gerrit-Owner: neels
Gerrit-MessageType: newchange
Change in osmo-bsc[master]: BSSMAP: make sure we don't try to reset non-existent entity
Attention is currently required from: pespin, msuraev.
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/28892 )
Change subject: BSSMAP: make sure we don't try to reset non-existent entity
..
Patch Set 2: Code-Review-1
(3 comments)
Patchset:
PS2:
in OS#5551 i explain why this fix seems to be not needed.
If there is ever a situation where bssmap_reset == NULL,
we need to find that and fix it.
I currently don't see how that is possible at all.
There is not even uncertainty, race or async things going on, it is simply not
possible.
File src/osmo-bsc/bsc_vty.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/28892/comment/e679b15c_f951f808
PS2, Line 3393: if (!msc->a.bssmap_reset) {
Wording confusion:
- this is not about "Resetting the BSSMAP interface", it is about sending a
BSSMAP Reset message to the peer.
- this is not about an unallocated MSC.
If the MSC is not allocated, above 'if (!msc)' triggers.
If bssmap_reset is NULL, then the RESET message handling FSM instance has not
been initialized / already torn down.
The code below is about sending a BSSMAP RESET message, so the log should say
something like
"Unable to send BSSMAP RESET message, bssmap_reset FSM not allocated"
But did you actually face a situation like this? Seems unlikely to happen.
File src/osmo-bsc/bssmap_reset.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/28892/comment/ef077194_f2e3c53d
PS2, Line 249: LOGP(DMSC, LOGL_ERROR, "Attempt to reset non-existent
BSSMAP\n");
No caller should call this function with a NULL argument.
Otherwise we'd need to add such NULL checks to all of the API functions
everywhere.
If it is really plausible, then:
Wording confusion: rather "Unable to send BSSMAP RESET message, no FSM instance
present"
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28892
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I235bdd42ea82e7b5a1a40f437ca34c49ad239c48
Gerrit-Change-Number: 28892
Gerrit-PatchSet: 2
Gerrit-Owner: msuraev
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: neels
Gerrit-Reviewer: pespin
Gerrit-Attention: pespin
Gerrit-Attention: msuraev
Gerrit-Comment-Date: Wed, 17 Aug 2022 02:09:58 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Change in osmo-msc[master]: cosmetic: use proper name for SMPP handlers
Attention is currently required from: msuraev. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28840 ) Change subject: cosmetic: use proper name for SMPP handlers .. Patch Set 25: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28840 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I0d714e927e287a0ea9362008ed050a492510e22b Gerrit-Change-Number: 28840 Gerrit-PatchSet: 25 Gerrit-Owner: msuraev Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Attention: msuraev Gerrit-Comment-Date: Wed, 17 Aug 2022 01:47:57 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-msc[master]: Make esme struct shared
Attention is currently required from: pespin, msuraev, dexter.
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-msc/+/28846 )
Change subject: Make esme struct shared
..
Patch Set 19: Code-Review-1
(4 comments)
File include/osmocom/smpp/smpp.h:
https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/75e5796c_038ce042
PS19, Line 14: struct esme {
prefer 'struct smpp_esme' since it is from smpp.h
File include/osmocom/smpp/smpp_smsc.h:
https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/eb66d78b_c63ea6c8
PS19, Line 32: struct esme *esme;
just 'struct esme esme;' (non-pointer) to avoid extra talloc,
then smpp_esme_init(&osmo_esme.esme) instead of esme_alloc()
File src/libsmpputil/smpp_smsc.c:
https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/dcef0350_bd4e35a1
PS19, Line 900: esme->esme = esme_alloc(esme);
...because the esme_alloc() appears to unconditionally take place after
talloc(struct osmo_esme) anyway.
File src/utils/Makefile.am:
https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/f65950f5_9b47607a
PS19, Line 45: $(top_builddir)/src/libvlr/libvlr.a \
smpp_mirror certainly does not need libvlr.a.
also looks weird to require libmsc.a.
and pull in ASN1C, SIGTRAN and SQLITE3 below...
can you find a way to not pull in all sorts of unrelated dependencies?
just guessing, maybe move the esme implementation from libmsc to libsmpputil?
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28846
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I8f7ac2c00d16660925dd0b03aa1a0973edf9eb70
Gerrit-Change-Number: 28846
Gerrit-PatchSet: 19
Gerrit-Owner: msuraev
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter
Gerrit-Reviewer: neels
Gerrit-CC: pespin
Gerrit-Attention: pespin
Gerrit-Attention: msuraev
Gerrit-Attention: dexter
Gerrit-Comment-Date: Wed, 17 Aug 2022 01:47:18 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Build failure of network:osmocom:nightly/osmo-iuh in Raspbian_11/armv7l
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-iuh/Raspbian_11/armv7l Package network:osmocom:nightly/osmo-iuh failed to build in Raspbian_11/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-iuh Last lines of build log: [ 196s] update-alternatives: using /usr/share/docutils/scripts/python3/rst2xml to provide /usr/bin/rst2xml (rst2xml) in auto mode [ 196s] update-alternatives: using /usr/share/docutils/scripts/python3/rstpep2html to provide /usr/bin/rstpep2html (rstpep2html) in auto mode [ 197s] [452/485] installing python3-reportlab-3.5.59-2 [ 199s] [453/485] installing g++-4:10.2.1-1+rpi1 [ 199s] update-alternatives: using /usr/bin/g++ to provide /usr/bin/c++ (c++) in auto mode [ 199s] [454/485] installing libosmo-netif-dev-1.2.0.7.c824.202208170052 [ 200s] [455/485] installing mount-2.36.1-8+deb11u1 [ 200s] [456/485] installing texlive-latex-extra-2020.20210202-3 [ 203s] [457/485] installing debhelper-13.3.4 [ 204s] [458/485] installing bash-5.1-2+deb11u1 [ 205s] update-alternatives: using /usr/share/man/man7/bash-builtins.7.gz to provide /usr/share/man/man7/builtins.7.gz (builtins.7.gz) in auto mode [ 205s] [459/485] installing libosmo-sigtran-dev-1.6.0.1.e6ce.202208170052 [ 205s] [460/485] installing build-essential-12.9 [ 205s] [461/485] installing python3-blockdiag-2.0.1+dfsg-1 [ 206s] [462/485] installing texlive-xetex-2020.20210202-3 [ 208s] dpkg-deb (subprocess): decompressing archive '.init_b_cache/texlive-xetex.deb' (size=12542520) member 'data.tar': lzma error: compressed data is corrupt [ 208s] dpkg-deb: error: subprocess returned error exit status 2 [ 208s] dpkg: error processing archive .init_b_cache/texlive-xetex.deb (--install): [ 208s] cannot copy extracted data for './usr/share/doc/texlive-doc/xetex/xesearch/xesearch.pdf' to '/usr/share/doc/texlive-doc/xetex/xesearch/xesearch.pdf.dpkg-new': unexpected end of file or stream [ 208s] Errors were encountered while processing: [ 208s] .init_b_cache/texlive-xetex.deb [ 208s] exit ... [ 208s] ### VM INTERACTION START ### [ 208s] [ 183.908582] sysrq: SysRq : Power Off [ 208s] [ 183.910438] reboot: Power down [ 208s] ### VM INTERACTION END ### [ 208s] [ 208s] armbuild02 failed "build osmo-iuh_1.3.0.2.a9c38.202208170052.dsc" at Wed Aug 17 01:36:59 UTC 2022. [ 208s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)
Change in osmo-msc[master]: Use libsmpputil functions in smpp_mirror tool
Attention is currently required from: msuraev. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28847 ) Change subject: Use libsmpputil functions in smpp_mirror tool .. Patch Set 26: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28847 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Icb046570803acb3eff89e2a4eb979c4899d485f7 Gerrit-Change-Number: 28847 Gerrit-PatchSet: 26 Gerrit-Owner: msuraev Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Attention: msuraev Gerrit-Comment-Date: Wed, 17 Aug 2022 01:28:05 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmo-sccp[master]: SIGTRAN: enforce optional data length limits
Attention is currently required from: msuraev.
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 )
Change subject: SIGTRAN: enforce optional data length limits
..
Patch Set 4: Code-Review-1
(5 comments)
Commit Message:
https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/06c69059_3b261ef1
PS4, Line 7: SIGTRAN: enforce optional data length limits
"enforce length limits on SCCP Optional Data" ?
File src/sccp_scoc.c:
https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/c270a568_6601112b
PS4, Line 580: if (prim && msgb_l2(prim->oph.msg) &&
msgb_l2len(prim->oph.msg)) {
exit early
if (!(...))
return true;
if (msgb...) {
...
}
xua_msg_add_data(...);
return true;
https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/3dbb9804_bdfbc6b7
PS4, Line 585: xua_msg_free(xua);
freeing here is very confusing memory management. The caller should do this
free when receiving an error rc.
https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/d876a623_fb00d419
PS4, Line 615: if (!xua_add_data(prim, xua, "4.2"))
this looks like a mem leak of above xua_msg_alloc().
the free should not be in xua_add_data()
https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/0191abbb_68985a90
PS4, Line 617: /* optional: hop coun */
"count" ?
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29084
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I0033faf9da393418930252233ce74d62cd1cef8a
Gerrit-Change-Number: 29084
Gerrit-PatchSet: 4
Gerrit-Owner: msuraev
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels
Gerrit-Attention: msuraev
Gerrit-Comment-Date: Wed, 17 Aug 2022 01:26:38 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Change in libosmo-sccp[master]: SCCP: enforce optional data length limits
Attention is currently required from: msuraev. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29083 ) Change subject: SCCP: enforce optional data length limits .. Patch Set 4: (1 comment) File src/sccp.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29083/comment/c02401cf_f835e08c PS4, Line 234: return -EBADSLT; EBADSLT "Invalid slot"? how about EMSGSIZE -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29083 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Icc3bd0a71b29cf61a259c5d97e7dd85beb4397bd Gerrit-Change-Number: 29083 Gerrit-PatchSet: 4 Gerrit-Owner: msuraev Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-CC: neels Gerrit-Attention: msuraev Gerrit-Comment-Date: Wed, 17 Aug 2022 01:19:22 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in libosmo-sccp[master]: Log more data on CR and N-CONNECT
Attention is currently required from: msuraev. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29085 ) Change subject: Log more data on CR and N-CONNECT .. Patch Set 7: Code-Review+1 (1 comment) Patchset: PS7: i'd solve this question by looking at wireshark instead of logging? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29085 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I4d7fc44fde5b900907ec5ebec0450040a764802a Gerrit-Change-Number: 29085 Gerrit-PatchSet: 7 Gerrit-Owner: msuraev Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Attention: msuraev Gerrit-Comment-Date: Wed, 17 Aug 2022 01:15:14 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmo-sccp[master]: cosmetic: improve usage help of example code
Attention is currently required from: msuraev. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29086 ) Change subject: cosmetic: improve usage help of example code .. Patch Set 9: Code-Review+2 (1 comment) File examples/sccp_demo_user.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29086/comment/4870380e_37b52936 PS9, Line 124: , nice catch! -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29086 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I342dc227afbfe6c3540eb3285677c568d2fe3166 Gerrit-Change-Number: 29086 Gerrit-PatchSet: 9 Gerrit-Owner: msuraev Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Attention: msuraev Gerrit-Comment-Date: Wed, 17 Aug 2022 01:12:57 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmo-sccp[master]: SIGTRAN: add function to check connection existence
Attention is currently required from: fixeria, msuraev. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29087 ) Change subject: SIGTRAN: add function to check connection existence .. Patch Set 8: Code-Review-1 (2 comments) Patchset: PS8: the added function and the changed VTY behavior have to be two separate patches File examples/sccp_test_vty.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29087/comment/59fb8c4d_6b3379bb PS8, Line 44: int conn_id = atoi(argv[0]), ret; please declare 'int ret;' on a separate line. we usually call it rc. (ret only when it gets returned, rc for functions we are calling) -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29087 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Iffedf55b4c292ee6b2f97bcdeef6dc13c050ce01 Gerrit-Change-Number: 29087 Gerrit-PatchSet: 8 Gerrit-Owner: msuraev Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-CC: fixeria Gerrit-Attention: fixeria Gerrit-Attention: msuraev Gerrit-Comment-Date: Wed, 17 Aug 2022 01:09:47 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: Add osmo_sockaddr_strs_to_str()
Attention is currently required from: msuraev. neels has created a revert of this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28992 ) Change subject: Add osmo_sockaddr_strs_to_str() .. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28992 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic0d7c08f669994e37a2314555ecac85d28c42c89 Gerrit-Change-Number: 28992 Gerrit-PatchSet: 8 Gerrit-Owner: msuraev Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: msuraev Gerrit-Reviewer: pespin Gerrit-CC: neels Gerrit-Attention: msuraev Gerrit-MessageType: revert
Change in libosmocore[master]: Revert "Add osmo_sockaddr_strs_to_str()"
Attention is currently required from: laforge, pespin, msuraev.
Hello Jenkins Builder, laforge, pespin, msuraev,
I'd like you to do a code review. Please visit
https://gerrit.osmocom.org/c/libosmocore/+/29123
to review the following change.
Change subject: Revert "Add osmo_sockaddr_strs_to_str()"
..
Revert "Add osmo_sockaddr_strs_to_str()"
This reverts commit e145e28a91eeca65d34d7b82caa2190fa89492b4.
Reason for revert:
The function osmo_sockaddr_strs_to_str() should not be part of the
osmo_sockaddr_str API. The implementation of this should live in
the function multiaddr_snprintf() added in patch
Icef53fe4b6e51563d97a1bc48001d67679b3b6e9
and should not use dynamic allocation.
Change-Id: I263dfd68313b896c5b474025fbca13c22ce41cdc
---
M include/osmocom/core/sockaddr_str.h
M src/sockaddr_str.c
M tests/sockaddr_str/sockaddr_str_test.c
M tests/sockaddr_str/sockaddr_str_test.ok
4 files changed, 8 insertions(+), 115 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/23/29123/1
diff --git a/include/osmocom/core/sockaddr_str.h
b/include/osmocom/core/sockaddr_str.h
index 604f926..a46ad59 100644
--- a/include/osmocom/core/sockaddr_str.h
+++ b/include/osmocom/core/sockaddr_str.h
@@ -59,14 +59,12 @@
* struct osmo_sockaddr_str *my_sockaddr_str = ...;
* printf("got " OSMO_SOCKADDR_STR_FMT "\n",
OSMO_SOCKADDR_STR_FMT_ARGS(my_sockaddr_str));
*/
-#define OSMO_SOCKADDR_STR_NO_PORT_FMT "%s%s%s"
-#define OSMO_SOCKADDR_STR_NO_PORT_FMT_ARGS(R) \
- ((R) && (R)->af == AF_INET6) ? "[" : "", \
- (R) ? (R)->ip : "NULL", \
- ((R) && (R)->af == AF_INET6) ? "]" : ""
-
-#define OSMO_SOCKADDR_STR_FMT OSMO_SOCKADDR_STR_NO_PORT_FMT ":%u"
-#define OSMO_SOCKADDR_STR_FMT_ARGS(R) OSMO_SOCKADDR_STR_NO_PORT_FMT_ARGS(R),
(R) ? (R)->port : 0
+#define OSMO_SOCKADDR_STR_FMT "%s%s%s:%u"
+#define OSMO_SOCKADDR_STR_FMT_ARGS(R) \
+ ((R) && (R)->af == AF_INET6)? "[" : "", \
+ (R)? (R)->ip : "NULL", \
+ ((R) && (R)->af == AF_INET6)? "]" : "", \
+ (R)? (R)->port : 0
bool osmo_sockaddr_str_is_set(const struct osmo_sockaddr_str *sockaddr_str);
bool osmo_sockaddr_str_is_nonzero(const struct osmo_sockaddr_str
*sockaddr_str);
@@ -90,7 +88,6 @@
int osmo_sockaddr_str_to_sockaddr_in(const struct osmo_sockaddr_str
*sockaddr_str, struct sockaddr_in *dst);
int osmo_sockaddr_str_to_sockaddr_in6(const struct osmo_sockaddr_str
*sockaddr_str, struct sockaddr_in6 *dst);
int osmo_sockaddr_str_to_sockaddr(const struct osmo_sockaddr_str
*sockaddr_str, struct sockaddr_storage *dst);
-int osmo_sockaddr_strs_to_str(char *buf, size_t buf_len, const struct
osmo_sockaddr_str **sa_str, size_t sa_str_count);
int osmo_sockaddr_str_from_32n(struct osmo_sockaddr_str *sockaddr_str,
uint32_t ip, uint16_t port)
OSMO_DEPRECATED("osmo_sockaddr_str_from_32n() actually uses *host* byte
order. Use osmo_sockaddr_str_from_32h() instead");
diff --git a/src/sockaddr_str.c b/src/sockaddr_str.c
index b5007c3..70927a7 100644
--- a/src/sockaddr_str.c
+++ b/src/sockaddr_str.c
@@ -541,48 +541,5 @@
}
}
-/*! Convert array of osmo_sockaddr_str address strings into a string
representation of the address set, in the form:
- * buf_len == 0: "()"
- * buf_len == 1: "hostA"
- * buf_len >= 2: (hostA|hostB|...|...)
- * The port information is ignored.
- * \param[out] buf The buffer to store address set representation in.
- * \param[in] buf_len The size of buffer for address set representation.
- * \param[in] sa_str The array of osmo_sockaddr_str structs.
- * \param[in] sa_str_count Number of osmo_sockaddr_str structs to convert.
- * \return 0 on success, negative on error.
- */
-int osmo_sockaddr_strs_to_str(char *buf, size_t buf_len, const struct
osmo_sockaddr_str **sa_str, size_t sa_str_count)
-{
- size_t i;
- struct osmo_strbuf sb = { .buf = buf, .len = buf_len };
- char *after;
-
- if (buf_len < 3)
- return -ENOMEM;
-
- if (sa_str_count != 1)
- OSMO_STRBUF_PRINTF(sb, "(");
-
- for (i = 0; i < sa_str_count; i++) {
- if (sa_str_count == 1)
- after = "";
- else
- after = (i == (sa_str_count - 1)) ? ")" : "|";
-
- if (sa_str[i])
- OSMO_STRBUF_PRINTF(sb, OSMO_SOCKADDR_STR_NO_PORT_FMT
"%s",
-
OSMO_SOCKADDR_STR_NO_PORT_FMT_ARGS(sa_str[i]), after);
- }
-
- if (sa_str_count == 0)
- OSMO_STRBUF_PRINTF(sb, ")");
-
- if (sb.chars_needed >= buf_len)
- return -ENOSPC;
-
- return sb.chars_needed;
-}
-
/*! @} */
#endif // HAVE_NETINET_IN_H
diff --git a/tests/sockaddr_str/sockaddr_str_test.c
b/tests/sockaddr_str/sockaddr_str_test.c
index 8077b9a..0d0674b 100644
--- a/tests/sockaddr_str/sockaddr_str_test.c
+++ b/tests/sockaddr_str/sockaddr_str_t
Change in libosmocore[master]: Revert "Add function to guess AF_UNSPEC address"
Attention is currently required from: laforge, fixeria, msuraev.
Hello Jenkins Builder, laforge, fixeria, msuraev,
I'd like you to do a code review. Please visit
https://gerrit.osmocom.org/c/libosmocore/+/29122
to review the following change.
Change subject: Revert "Add function to guess AF_UNSPEC address"
..
Revert "Add function to guess AF_UNSPEC address"
This reverts commit a4063efa7deb6632c228037c47effca22ad0f781.
Reason for revert: It is not possible to guess the IP address
family from uninitialized memory. This function simply glorifies
random noise into an IPv6 address. It makes no sense to have it.
Change-Id: Ifadd614604cf9d0c2ed1a405493c1c3fcb37ae23
---
M include/osmocom/core/sockaddr_str.h
M src/sockaddr_str.c
2 files changed, 2 insertions(+), 35 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/22/29122/1
diff --git a/include/osmocom/core/sockaddr_str.h
b/include/osmocom/core/sockaddr_str.h
index a46ad59..f474fa0 100644
--- a/include/osmocom/core/sockaddr_str.h
+++ b/include/osmocom/core/sockaddr_str.h
@@ -41,7 +41,6 @@
*/
int osmo_ip_str_type(const char *ip);
-unsigned osmo_sockaddr_guess_unspec(const struct sockaddr *src);
struct osmo_sockaddr_str {
/*! AF_INET for IPv4 address, or AF_INET6 for IPv6 address. */
diff --git a/src/sockaddr_str.c b/src/sockaddr_str.c
index 70927a7..9f1e897 100644
--- a/src/sockaddr_str.c
+++ b/src/sockaddr_str.c
@@ -184,38 +184,6 @@
return AF_UNSPEC;
}
-/*! Guess whether struct sockaddr with AF_UNSPEC family has valid IPv4 or IPv6
address.
- * The IPv6 is tried first to take into account "IPv4 mapped addresses".
- * \param[in] src Generic struct sockaddr pointer.
- * \return AF_INET or AF_INET6, AF_UNSPEC or original sa_family which are
unsigned type according to .
- */
-unsigned osmo_sockaddr_guess_unspec(const struct sockaddr *src)
-{
- int rc;
- struct osmo_sockaddr_str sa;
- struct osmo_sockaddr_str *tmp = &sa;
- const struct sockaddr_in6 *src6 = (const struct sockaddr_in6 *)src;
- const struct sockaddr_in *src4 = (const struct sockaddr_in *)src;
-
- if (!src)
- return AF_UNSPEC;
-
- if (src->sa_family != AF_UNSPEC)
- return src->sa_family;
-
- /* IPv6? */
- rc = osmo_sockaddr_str_from_in6_addr(tmp, &src6->sin6_addr,
osmo_ntohs(src6->sin6_port));
- if (rc == 0 && osmo_ip_str_type(tmp->ip) == AF_INET6)
- return AF_INET6;
-
- /* IPv4? */
- rc = osmo_sockaddr_str_from_in_addr(tmp, &src4->sin_addr,
osmo_ntohs(src4->sin_port));
- if (rc == 0 && osmo_ip_str_type(tmp->ip) == AF_INET)
- return AF_INET;
-
- return AF_UNSPEC;
-}
-
/*! Safely copy the given ip string to sockaddr_str, classify to AF_INET or
AF_INET6.
* Data will be written to sockaddr_str even if an error is returned.
* \param[out] sockaddr_str The instance to copy to.
@@ -349,7 +317,7 @@
return -ENOSPC;
if (!src)
return -EINVAL;
- if (src->sin_family != AF_INET && osmo_sockaddr_guess_unspec((const
struct sockaddr *)src) != AF_INET)
+ if (src->sin_family != AF_INET)
return -EINVAL;
return osmo_sockaddr_str_from_in_addr(sockaddr_str, &src->sin_addr,
osmo_ntohs(src->sin_port));
}
@@ -365,7 +333,7 @@
return -ENOSPC;
if (!src)
return -EINVAL;
- if (src->sin6_family != AF_INET6 && osmo_sockaddr_guess_unspec((const
struct sockaddr *)src) != AF_INET6)
+ if (src->sin6_family != AF_INET6)
return -EINVAL;
return osmo_sockaddr_str_from_in6_addr(sockaddr_str, &src->sin6_addr,
osmo_ntohs(src->sin6_port));
}
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29122
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ifadd614604cf9d0c2ed1a405493c1c3fcb37ae23
Gerrit-Change-Number: 29122
Gerrit-PatchSet: 1
Gerrit-Owner: neels
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: laforge
Gerrit-Reviewer: msuraev
Gerrit-CC: pespin
Gerrit-Attention: laforge
Gerrit-Attention: fixeria
Gerrit-Attention: msuraev
Gerrit-MessageType: newchange
Change in libosmocore[master]: Add function to guess AF_UNSPEC address
Attention is currently required from: msuraev. neels has created a revert of this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28994 ) Change subject: Add function to guess AF_UNSPEC address .. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28994 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1c90c56ce832f53b65e0d18d3cea94621c02a69a Gerrit-Change-Number: 28994 Gerrit-PatchSet: 5 Gerrit-Owner: msuraev Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: msuraev Gerrit-CC: neels Gerrit-CC: pespin Gerrit-Attention: msuraev Gerrit-MessageType: revert
Change in libosmocore[master]: Add function to guess AF_UNSPEC address
Attention is currently required from: msuraev. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28994 ) Change subject: Add function to guess AF_UNSPEC address .. Patch Set 5: (1 comment) Patchset: PS5: I'm sorry that I am late for code review here. As Pau has explained, this function has a flaw in principles, and it makes no sense to have it. I would welcome if we could revert this commit before the next release. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28994 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1c90c56ce832f53b65e0d18d3cea94621c02a69a Gerrit-Change-Number: 28994 Gerrit-PatchSet: 5 Gerrit-Owner: msuraev Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: msuraev Gerrit-CC: neels Gerrit-CC: pespin Gerrit-Attention: msuraev Gerrit-Comment-Date: Wed, 17 Aug 2022 00:55:33 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in libosmocore[master]: Make osmo_sockaddr_str_from_sockaddr() less picky
Attention is currently required from: pespin, msuraev, dexter. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28995 ) Change subject: Make osmo_sockaddr_str_from_sockaddr() less picky .. Patch Set 8: Code-Review-2 (1 comment) Patchset: PS8: AF_UNSPEC is not valid and should return an error rc. Do not turn uninitialized memory into an IPv6 address representation! -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28995 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I36f20701663c3c7eae7fedc6551da44800b325bf Gerrit-Change-Number: 28995 Gerrit-PatchSet: 8 Gerrit-Owner: msuraev Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-CC: dexter Gerrit-Attention: pespin Gerrit-Attention: msuraev Gerrit-Attention: dexter Gerrit-Comment-Date: Wed, 17 Aug 2022 00:52:31 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: Use osmo_sockaddr_strs_to_str() for multiaddr helper
Attention is currently required from: msuraev.
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/28993 )
Change subject: Use osmo_sockaddr_strs_to_str() for multiaddr helper
..
Patch Set 8: Code-Review-1
(3 comments)
Patchset:
PS8:
the code added in https://gerrit.osmocom.org/c/libosmocore/+/28992 should move
to this function, as indicated below
File src/socket.c:
https://gerrit.osmocom.org/c/libosmocore/+/28993/comment/dda0b532_5a697daa
PS8, Line 208: * buf_len >= 2: (hostA|hostB|...|...)
(this doc is wrong)
https://gerrit.osmocom.org/c/libosmocore/+/28993/comment/16eeb34d_42c05fa7
PS8, Line 211: {
if you use an implementation like this here, we don't need to add
osmo_sockaddr_strs_to_str() at all and save a lot of dynamic allocations:
struct osmo_strbuf sb = { ... };
if (i != 1)
OSMO_STRBUF_PRINTF(sb, "(");
for (...) {
struct osmo_sockaddr_str ss;
if (i)
OSMO_STRBUF_PRINTF(sb, "|");
osmo_sockaddr_str_from_str2(&ss, hosts[i]);
OSMO_STRBUF_PRINTF(sb, OSMO_SOCKADDR_STR_FMT,
OSMO_SOCKADDR_STR_FMT_ARGS(&ss));
}
if (i != 1)
OSMO_STRBUF_PRINTF(sb, ")");
return sb.chars_needed;
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28993
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Icef53fe4b6e51563d97a1bc48001d67679b3b6e9
Gerrit-Change-Number: 28993
Gerrit-PatchSet: 8
Gerrit-Owner: msuraev
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: neels
Gerrit-Reviewer: pespin
Gerrit-Attention: msuraev
Gerrit-Comment-Date: Wed, 17 Aug 2022 00:48:15 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Change in libosmocore[master]: Diversify osmo_sockaddr_str_*() error codes
Attention is currently required from: laforge, pespin, msuraev. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28996 ) Change subject: Diversify osmo_sockaddr_str_*() error codes .. Patch Set 6: Code-Review-2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28996 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic1be25a076776de5b417cb5ac66f954ac5680e10 Gerrit-Change-Number: 28996 Gerrit-PatchSet: 6 Gerrit-Owner: msuraev Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Attention: laforge Gerrit-Attention: pespin Gerrit-Attention: msuraev Gerrit-Comment-Date: Wed, 17 Aug 2022 00:39:57 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: Add osmo_sockaddr_strs_to_str()
Attention is currently required from: msuraev.
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/28992 )
Change subject: Add osmo_sockaddr_strs_to_str()
..
Patch Set 8:
(9 comments)
Patchset:
PS8:
I'm sorry that I'm late for this patch review.
This patch has a number of rough edges,
I would welcome if we could revert it and get some more review cycles.
File src/sockaddr_str.c:
https://gerrit.osmocom.org/c/libosmocore/+/28992/comment/6219adc6_145bfcb8
PS8, Line 547: * buf_len >= 2: (hostA|hostB|...|...)
buf_len is the buffer size of the output string buffer *buf.
A buf_len == 0 cannot return any "()" string, it has zero size.
buf_len == 1 cannot contain "hostA".
Did you mean sa_str_count?
https://gerrit.osmocom.org/c/libosmocore/+/28992/comment/d27293a9_acbb2b9e
PS8, Line 555: int osmo_sockaddr_strs_to_str(char *buf, size_t buf_len, const
struct osmo_sockaddr_str **sa_str, size_t sa_str_count)
i find it odd that you want to pass an array of osmo_sockaddr_str POINTERS,
instead of an array of osmo_sockaddr_str instances.
i.e. i would expect an arg like 'const struct osmo_sockaddr_str *sa_strs',
not '**'.
https://gerrit.osmocom.org/c/libosmocore/+/28992/comment/316d840f_674d4fd8
PS8, Line 562: return -ENOMEM;
this check should not be here. The idea is to always return the nr of
characters needed to output the full string, regardless of the underlying
buffer length. If you return -ENOMEM on some specific buffer lengths, you
destroy the ability of finding a sufficient buffer length from the return
value. The OSMO_STRBUF macros deal with all cases of insufficient buffer
length, just let it play through to the end, so that the proper sb.chars_needed
is returned.
https://gerrit.osmocom.org/c/libosmocore/+/28992/comment/fdcd0fdd_b3bde8dc
PS8, Line 567: for (i = 0; i < sa_str_count; i++) {
for (...) {
if (i)
OSMO_STRBUF_PRINTF(sb, "|");
if (sa_str[i])
OSMO_STRBUF_PRINTF(sb, OSMO_SOCKADDR_STR_NO_PORT_FMT,
OSMO_SOCKADDR_STR_NO_PORT_FMT_ARGS(sa_str[i]));
}
if (sa_str_count != 1)
OSMO_STRBUF_PRINTF(sb, ")");
File tests/sockaddr_str/sockaddr_str_test.c:
https://gerrit.osmocom.org/c/libosmocore/+/28992/comment/078d4d8b_e4da2349
PS8, Line 28: #include
why add application and logging?
there should be no select loop.
nothing about osmo_sockaddr_str should ever cause osmocom logging.
https://gerrit.osmocom.org/c/libosmocore/+/28992/comment/a57e7473_891bec86
PS8, Line 268: struct osmo_sockaddr_str *sa_strs[OSMO_SOCK_MAX_ADDRS];
(...and here just a struct osmo_sockaddr_str sa_strs[N], no need to talloc
instances below)
https://gerrit.osmocom.org/c/libosmocore/+/28992/comment/998f5771_bdf3e063
PS8, Line 271: for (i = 0, j = 0; j < count && i < OSMO_SOCK_MAX_ADDRS; j++)
{//ARRAY_SIZE(oip_data)
can we drop the // comments?
https://gerrit.osmocom.org/c/libosmocore/+/28992/comment/146c54fa_9c1e2c65
PS8, Line 290: };
why add logging infrastructure??
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28992
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ic0d7c08f669994e37a2314555ecac85d28c42c89
Gerrit-Change-Number: 28992
Gerrit-PatchSet: 8
Gerrit-Owner: msuraev
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: msuraev
Gerrit-Reviewer: pespin
Gerrit-CC: neels
Gerrit-Attention: msuraev
Gerrit-Comment-Date: Wed, 17 Aug 2022 00:34:54 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Change in libosmo-pfcp[master]: RPM: fix configure and typo "gltv" in .spec.in
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/29115 ) Change subject: RPM: fix configure and typo "gltv" in .spec.in .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29115 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: Ideff7942a3250fa6541cfa6252a1c2927afdfc45 Gerrit-Change-Number: 29115 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: neels Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Wed, 17 Aug 2022 00:11:57 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmo-pfcp[master]: RPM: fix configure and typo "gltv" in .spec.in
neels has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmo-pfcp/+/29115 )
Change subject: RPM: fix configure and typo "gltv" in .spec.in
..
RPM: fix configure and typo "gltv" in .spec.in
Change-Id: Ideff7942a3250fa6541cfa6252a1c2927afdfc45
---
M contrib/libosmo-pfcp.spec.in
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-pfcp refs/changes/15/29115/1
diff --git a/contrib/libosmo-pfcp.spec.in b/contrib/libosmo-pfcp.spec.in
index 9e2c06a..286a644 100644
--- a/contrib/libosmo-pfcp.spec.in
+++ b/contrib/libosmo-pfcp.spec.in
@@ -71,7 +71,8 @@
%build
echo "%{version}" >.tarball-version
autoreconf -fi
-%configure
+%configure \
+ --includedir="%_includedir/%name"
make %{?_smp_mflags}
%install
@@ -87,7 +88,7 @@
%postun -n libosmo-pfcp0 -p /sbin/ldconfig
%files -n libosmo-gtlv0
-%{_libdir}/libosmo-gltv.so.0*
+%{_libdir}/libosmo-gtlv.so.0*
%files -n libosmo-gtlv-devel
%dir %{_includedir}/%{name}
--
To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29115
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: Ideff7942a3250fa6541cfa6252a1c2927afdfc45
Gerrit-Change-Number: 29115
Gerrit-PatchSet: 1
Gerrit-Owner: neels
Gerrit-MessageType: newchange
Change in libosmo-gprs[master]: contrib/libosmo-gprs.spec.in: properly define RPM packages
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmo-gprs/+/29114 )
Change subject: contrib/libosmo-gprs.spec.in: properly define RPM packages
..
contrib/libosmo-gprs.spec.in: properly define RPM packages
Change-Id: I9be45c43ba3e342e1dba4b60561880c00841f549
---
M contrib/libosmo-gprs.spec.in
1 file changed, 74 insertions(+), 5 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/14/29114/1
diff --git a/contrib/libosmo-gprs.spec.in b/contrib/libosmo-gprs.spec.in
index 1a85f9e..6cc8c47 100644
--- a/contrib/libosmo-gprs.spec.in
+++ b/contrib/libosmo-gprs.spec.in
@@ -10,12 +10,59 @@
BuildRequires: automake >= 1.9
BuildRequires: libtool >= 2
BuildRequires: pkgconfig >= 0.20
-BuildRequires: pkgconfig(libosmocore) >= 1.6.0
+BuildRequires: pkgconfig(libosmocore) >= 1.7.0
BuildRequires: pkgconfig(talloc)
%description
libosmo-gprs: Osmocom GPRS libraries (CSN.1, RLC/MAC)
+This package provides Osmocom GPRS libraries used by osmocom-bb and
+osmo-pcu: libosmo-csn1, libosmo-gprs-rlcmac.
+
+
+%package -n libosmo-csn1-0
+Summary: CSN.1 (Concrete Syntax Notation 1) codec
+License: GPL-2.0-or-later
+Group: System/Libraries
+
+%description -n libosmo-csn1-0
+This package provides facilities for encoding, decoding, and declarative
+definition of protocols using CSN.1 (Concrete Syntax Notation 1). This
+implementation was originally developed by ST-Ericsson (Jari Sassi) and
+later adopted by Wireshark and osmo-pcu.
+
+
+%package -n libosmo-csn1-devel
+Summary: Development files for libosmo-csn1
+License: GPL-2.0-or-later
+Group: Development/Libraries/C and C++
+Requires: libosmo-csn1-0 = %{version}
+
+%description -n libosmo-csn1-devel
+This package provides development files for compiling a program using
+libosmo-csn1 - CSN.1 (Concrete Syntax Notation 1) codec.
+
+
+%package -n libosmo-gprs-rlcmac0
+Summary: CSN.1 (Concrete Syntax Notation 1) codec
+License: GPL-2.0-or-later
+Group: System/Libraries
+
+%description -n libosmo-gprs-rlcmac0
+This package provides RLC/MAC protocol definitions for (E)GPRS.
+
+%package -n libosmo-gprs-rlcmac-devel
+Summary: Development files for libosmo-gprs-rlcmac
+License: GPL-2.0-or-later
+Group: Development/Libraries/C and C++
+Requires: libosmo-gprs-rlcmac0 = %{version}
+Requires: libosmo-csn1-devel = %{version}
+
+%description -n libosmo-gprs-rlcmac-devel
+This package provides development files for compiling a program using
+libosmo-gprs-rlcmac - RLC/MAC protocol definitions for (E)GPRS.
+
+
%prep
%setup -q
@@ -31,9 +78,31 @@
%check
make %{?_smp_mflags} check || (find . -name testsuite.log -exec cat {} +)
-%files
-%license COPYING
-%doc README.md
-%{_bindir}/libosmo-gprs
+%post -n libosmo-csn1-0 -p /sbin/ldconfig
+%postun -n libosmo-csn1-0 -p /sbin/ldconfig
+%post -n libosmo-gprs-rlcmac0 -p /sbin/ldconfig
+%postun -n libosmo-gprs-rlcmac0 -p /sbin/ldconfig
+
+%files -n libosmo-csn1-0
+%{_libdir}/libosmo-csn1.so.0*
+
+%files -n libosmo-csn1-devel
+%dir %{_includedir}/%{name}
+%dir %{_includedir}/%{name}/osmocom
+%{_includedir}/%{name}/osmocom/csn1
+%{_libdir}/libosmo-csn1.so
+%{_libdir}/libosmo-csn1.a
+%{_libdir}/pkgconfig/libosmo-csn1.pc
+
+%files -n libosmo-gprs-rlcmac0
+%{_libdir}/libosmo-gprs-rlcmac.so.0*
+
+%files -n libosmo-gprs-rlcmac-devel
+%dir %{_includedir}/%{name}
+%dir %{_includedir}/%{name}/osmocom
+%{_includedir}/%{name}/osmocom/gprs/rlcmac
+%{_libdir}/libosmo-gprs-rlcmac.so
+%{_libdir}/libosmo-gprs-rlcmac.a
+%{_libdir}/pkgconfig/libosmo-gprs-rlcmac.pc
%changelog
--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29114
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I9be45c43ba3e342e1dba4b60561880c00841f549
Gerrit-Change-Number: 29114
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
Change in docker-playground[master]: osmo-hlr-master: install libsqlite3-dev/sqlite-devel
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/29112 ) Change subject: osmo-hlr-master: install libsqlite3-dev/sqlite-devel .. osmo-hlr-master: install libsqlite3-dev/sqlite-devel osmo-hlr is using libsqlite3 directly, not via libdbd. Change-Id: I99e43dff8f94fbef1a2dd9934caf6ba1fa7cc1f7 --- M osmo-hlr-master/Dockerfile 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/12/29112/1 diff --git a/osmo-hlr-master/Dockerfile b/osmo-hlr-master/Dockerfile index 9ddc193..1c3251a 100644 --- a/osmo-hlr-master/Dockerfile +++ b/osmo-hlr-master/Dockerfile @@ -8,7 +8,7 @@ debian*) \ apt-get update && \ apt-get install -y --no-install-recommends \ - libdbd-sqlite3 \ + libsqlite3-dev \ libosmo-abis-dev \ libosmo-netif-dev \ libosmo-sigtran-dev \ @@ -22,6 +22,7 @@ "pkgconfig(libosmoctrl)" \ "pkgconfig(libosmogsm)" \ "pkgconfig(libosmovty)" \ + sqlite-devel \ python3 \ ;; \ esac -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29112 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I99e43dff8f94fbef1a2dd9934caf6ba1fa7cc1f7 Gerrit-Change-Number: 29112 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange
Change in docker-playground[master]: osmo-msc-master: install libsqlite3-dev/sqlite-devel
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/29113 ) Change subject: osmo-msc-master: install libsqlite3-dev/sqlite-devel .. osmo-msc-master: install libsqlite3-dev/sqlite-devel Since recenly, osmo-msc is using libsqlite3 directly. Change-Id: I4b0ecfcc9a25797eb8e12f07e039160dfc296d4c --- M osmo-msc-master/Dockerfile 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/13/29113/1 diff --git a/osmo-msc-master/Dockerfile b/osmo-msc-master/Dockerfile index 1ad4684..7d79988 100644 --- a/osmo-msc-master/Dockerfile +++ b/osmo-msc-master/Dockerfile @@ -9,8 +9,7 @@ apt-get update && \ apt-get install -y --no-install-recommends \ libasn1c-dev \ - libdbd-sqlite3 \ - libdbi-dev \ + libsqlite3-dev \ libosmo-abis-dev \ libosmo-mgcp-client-dev \ libosmo-gsup-client-dev \ @@ -37,6 +36,7 @@ "pkgconfig(libosmogsm)" \ "pkgconfig(libosmovty)" \ "pkgconfig(libsmpp34)" \ + sqlite-devel \ ;; \ esac -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29113 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I4b0ecfcc9a25797eb8e12f07e039160dfc296d4c Gerrit-Change-Number: 29113 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange
Change in osmo-ci[master]: readme, and sanitize feed name
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/29110 to look at the new patch set (#2). Change subject: readme, and sanitize feed name .. readme, and sanitize feed name In a README, explain how to use these scripts to test a private branch. The README suggests using a private branch as feed. I am not sure whether a forward slash is allowed in a feed name, but I know that the feed name is put in a sed 's/../../' command, hence sanitize feed name. Change-Id: I4d1303e0c04e827200b48a9fe4aea3680c9c9f84 --- A scripts/obs/README M scripts/obs/lib/config.py M scripts/obs/lib/srcpkg.py 3 files changed, 122 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/10/29110/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29110 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4d1303e0c04e827200b48a9fe4aea3680c9c9f84 Gerrit-Change-Number: 29110 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset
Change in osmo-upf[master]: debian: add missing changelog
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-upf/+/29111 ) Change subject: debian: add missing changelog .. debian: add missing changelog Change-Id: I53551ce1a6d3176d480a56f8f5d2441da7346711 --- M debian/changelog 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/11/29111/1 diff --git a/debian/changelog b/debian/changelog index e69de29..ca2e0ba 100644 --- a/debian/changelog +++ b/debian/changelog @@ -0,0 +1,5 @@ +osmo-upf (0.1.0) testing; urgency=low + + Create new Debian package. + + -- Neels Hofmeyr Tue, 16 Aug 2022 23:17:05 +0200 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/29111 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I53551ce1a6d3176d480a56f8f5d2441da7346711 Gerrit-Change-Number: 29111 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-MessageType: newchange
Change in osmo-ci[master]: readme, and sanitize feed name
neels has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ci/+/29110 )
Change subject: readme, and sanitize feed name
..
readme, and sanitize feed name
In a README, explain how to use these scripts to test a private branch.
The README suggests using a private branch as feed. I am not sure
whether a forward slash is allowed in a feed name, but I know that the
feed name is put in a sed 's/../../' command, hence sanitize feed name.
Change-Id: I4d1303e0c04e827200b48a9fe4aea3680c9c9f84
---
A scripts/obs/README
M scripts/obs/lib/config.py
M scripts/obs/lib/srcpkg.py
3 files changed, 121 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/10/29110/1
diff --git a/scripts/obs/README b/scripts/obs/README
new file mode 100644
index 000..995344a
--- /dev/null
+++ b/scripts/obs/README
@@ -0,0 +1,115 @@
+Submitting source packages to Osmocom's OBS build server
+
+
+Dependencies:
+
+ apt-get install dh-python meson osc rebar3
+
+Usage Example
+=
+
+I want to test changes to the packaging of osmo-hnbgw.
+They are committed on a private branch osmo-hnbgw.git:neels/gtpmap.
+I want to test this in my OBS "Home Project" called home:nhofmeyr:test.
+
+Here are the steps of what I do:
+
+OBS home project
+
+
+Sign up / sign in to obs.osmocom.org and create the "test" project under the
+"Home Project" link (right next to the "Logout" link on the OBS web interface),
+so that https://obs.osmocom.org/project/show/home:nhofmeyr:test exists.
+
+Make sure I can list the project using the 'osc' tool.
+That requires an osc config file.
+Easiest is to let osc create one and then edit it:
+
+ $ osc list home:nhofmeyr:test
+ Username: nhofmeyr
+ Password:
+ Select credentials manager: 4
+ Server returned an error: HTTP Error 401: Unauthorized
+
+Now edit ~/.config/osc/oscrc and set the API URL to obs.osmocom.org:
+Replace "api.opensuse.org" with "obs.osmocom.org" in two places:
+
+ sed -i 's/api\.opensuse\.org/obs.osmocom.org/' ~/.config/osc/oscrc
+
+Now the 'osc list' command should no longer fail:
+
+ $ osc list home:nhofmeyr:test
+ libosmo-pfcp
+
+Publish patches in private branch
+-
+
+Push my private branch to Osmocom's git upstream -- not submit for review, just
+push a private branch.
+
+Why is that? The obs scripts here modify the git tree, so it is better to build
+the source packages on a separate git clone.
+
+ cd ~/osmo-dev/src/osmo-hnbgw
+ git push --set-upstream origin neels/gtpmap
+
+Clone source tree into the cache
+
+
+ cd ~/osmo-dev/src/osmo-ci/scripts/obs/
+ ./build_srcpkg.py osmo-hnbgw
+
+Now there is a git clone in ./_cache/osmo-hnbgw/
+
+Checkout my branch
+--
+
+#if 0
+ git -C _cache/osmo-hnbgw checkout neels/gtpmap
+#else
+One step of update_obs_project.py is to checkout the right branch.
+In order to checkout my branch, I add my branch as a feed to
+./lib/config.py:
+
+ ...
+ feeds = [
+ "2022q1",
+ "2022q2",
+ "latest",
+ "nightly",
+ "neels/gtpmap",
+ ]
+ ...
+
+Now I can tell update_obs_project.py to build my branch using the -f option
(see
+below).
+#endif
+
+Build and upload source package to OBS
+--
+
+ ./update_obs_project.py -f neels/gtpmap home:nhofmeyr:test osmo-hnbgw
+
+See results
+---
+
+I can now see my hnbgw package listed:
+
+ $ osc list home:nhofmeyr:test
+ libosmo-pfcp
+ osmo-hnbgw
+
+I could query things via the osc tool:
+
+ $ osc results home:nhofmeyr:test osmo-hnbgw
+ neels_test2 aarch64unresolvable
+ neels_test2 armv7l broken
+ neels_test2 i586 broken
+ neels_test2 x86_64 unresolvable
+ neels_test aarch64unresolvable
+ neels_test armv7l unresolvable
+ neels_test i586 unresolvable
+ neels_test x86_64 failed
+
+Or point my web browser at
+https://obs.osmocom.org/project/show/home:nhofmeyr:test
diff --git a/scripts/obs/lib/config.py b/scripts/obs/lib/config.py
index 997fff2..517fe48 100644
--- a/scripts/obs/lib/config.py
+++ b/scripts/obs/lib/config.py
@@ -32,6 +32,7 @@
"2022q2",
"latest",
"nightly",
+"neels/gtpmap",
]
# Osmocom projects: generated source packages will depend on a meta package,
diff --git a/scripts/obs/lib/srcpkg.py b/scripts/obs/lib/srcpkg.py
index 468a240..3fce993 100644
--- a/scripts/obs/lib/srcpkg.py
+++ b/scripts/obs/lib/srcpkg.py
@@ -132,6 +132,11 @@
if project in lib.config.projects_osmocom:
metapkg = f"osmocom-{feed}"
+
+# replace special chars with '_' in the feed name,
+# e.g. from a user's private git branch 'johndoe/wip'
+metapkg = [c for c in metapkg if c.isalnum() else '_']
+
lib.debian.control_add_depend(pr
Change in osmo-ci[master]: obs: add libosmo-pfcp, osmo-upf
Attention is currently required from: osmith. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29047 ) Change subject: obs: add libosmo-pfcp, osmo-upf .. Patch Set 4: Code-Review+2 (1 comment) Patchset: PS4: combine votes -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29047 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I7192f4c9e77035cebb147b8186296bcd741d419b Gerrit-Change-Number: 29047 Gerrit-PatchSet: 4 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Attention: osmith Gerrit-Comment-Date: Tue, 16 Aug 2022 21:13:17 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmo-gprs[master]: tests/testsuite.at: remove $OSMO_QEMU, it's not used
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29098 ) Change subject: tests/testsuite.at: remove $OSMO_QEMU, it's not used .. tests/testsuite.at: remove $OSMO_QEMU, it's not used Change-Id: If7332b347c0f08252b130ca7f6e7ec4fe6d78b59 --- M tests/testsuite.at 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: fixeria: Looks good to me, approved; Verified diff --git a/tests/testsuite.at b/tests/testsuite.at index 47a3e36..4669a00 100644 --- a/tests/testsuite.at +++ b/tests/testsuite.at @@ -5,5 +5,5 @@ AT_KEYWORDS([rlcmac]) cat $abs_srcdir/rlcmac/RLCMACTest.ok > expout cat $abs_srcdir/rlcmac/RLCMACTest.err > experr -AT_CHECK([$OSMO_QEMU $abs_top_builddir/tests/rlcmac/RLCMACTest], [0], [expout], [experr]) +AT_CHECK([$abs_top_builddir/tests/rlcmac/RLCMACTest], [0], [expout], [experr]) AT_CLEANUP -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29098 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: If7332b347c0f08252b130ca7f6e7ec4fe6d78b59 Gerrit-Change-Number: 29098 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: fixeria Gerrit-MessageType: merged
Change in libosmo-gprs[master]: tests/rlcmac: fix incorrect RLCMACTest.{ok,err} paths in EXTRA_DIST
fixeria has submitted this change. (
https://gerrit.osmocom.org/c/libosmo-gprs/+/29099 )
Change subject: tests/rlcmac: fix incorrect RLCMACTest.{ok,err} paths in
EXTRA_DIST
..
tests/rlcmac: fix incorrect RLCMACTest.{ok,err} paths in EXTRA_DIST
Change-Id: I175bd6494e2a7a6f6977388d760e790b7dd2c1ae
---
M tests/rlcmac/Makefile.am
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
fixeria: Looks good to me, approved; Verified
diff --git a/tests/rlcmac/Makefile.am b/tests/rlcmac/Makefile.am
index a7193c2..633f090 100644
--- a/tests/rlcmac/Makefile.am
+++ b/tests/rlcmac/Makefile.am
@@ -13,8 +13,8 @@
$(NULL)
EXTRA_DIST = \
- rlcmac/RLCMACTest.ok \
- rlcmac/RLCMACTest.err \
+ RLCMACTest.ok \
+ RLCMACTest.err \
$(NULL)
RLCMACTest_SOURCES = RLCMACTest.c
--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29099
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I175bd6494e2a7a6f6977388d760e790b7dd2c1ae
Gerrit-Change-Number: 29099
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria
Gerrit-Reviewer: fixeria
Gerrit-MessageType: merged
Change in libosmo-gprs[master]: tests/testsuite.at: remove $OSMO_QEMU, it's not used
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29098 ) Change subject: tests/testsuite.at: remove $OSMO_QEMU, it's not used .. Patch Set 2: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29098 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: If7332b347c0f08252b130ca7f6e7ec4fe6d78b59 Gerrit-Change-Number: 29098 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Tue, 16 Aug 2022 17:40:29 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmo-gprs[master]: tests/rlcmac: fix incorrect RLCMACTest.{ok,err} paths in EXTRA_DIST
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-gprs/+/29099 )
Change subject: tests/rlcmac: fix incorrect RLCMACTest.{ok,err} paths in
EXTRA_DIST
..
Patch Set 2: Verified+1 Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29099
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I175bd6494e2a7a6f6977388d760e790b7dd2c1ae
Gerrit-Change-Number: 29099
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria
Gerrit-Reviewer: fixeria
Gerrit-Comment-Date: Tue, 16 Aug 2022 17:40:22 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Change in osmo-dev[master]: Add ccache.opts: CC/CXX ccache wrappers
Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/29092 ) Change subject: Add ccache.opts: CC/CXX ccache wrappers .. Patch Set 1: Verified+1 Code-Review+2 (1 comment) Patchset: PS1: > Personally I just set […] I don't like this approach because this way ccache is used for everything you compile on your machine. Personally I prefer to use ccache only for something I compile regularly. Sometimes I even use separate CCACHE_DIRs... -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/29092 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Ic6c5a917da688b779979959ee199b6cf8bc971a9 Gerrit-Change-Number: 29092 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Attention: osmith Gerrit-Comment-Date: Tue, 16 Aug 2022 17:38:28 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith Gerrit-MessageType: comment
Change in osmo-dev[master]: Add ccache.opts: CC/CXX ccache wrappers
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/29092 ) Change subject: Add ccache.opts: CC/CXX ccache wrappers .. Add ccache.opts: CC/CXX ccache wrappers Change-Id: Ic6c5a917da688b779979959ee199b6cf8bc971a9 --- A ccache.opts 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: fixeria: Looks good to me, approved; Verified osmith: Looks good to me, but someone else must approve diff --git a/ccache.opts b/ccache.opts new file mode 100644 index 000..13dca45 --- /dev/null +++ b/ccache.opts @@ -0,0 +1 @@ +ALL CC="/usr/lib/ccache/bin/gcc" CXX="/usr/lib/ccache/bin/g++" -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/29092 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Ic6c5a917da688b779979959ee199b6cf8bc971a9 Gerrit-Change-Number: 29092 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-MessageType: merged
Change in osmo-pcu[master]: Migrate to libosmocsn1 and libosmo-gprs-rlcmac
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/28972 ) Change subject: Migrate to libosmocsn1 and libosmo-gprs-rlcmac .. Patch Set 6: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/28972 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Icba62ad8649e78acab711392dfd74fe571474381 Gerrit-Change-Number: 28972 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Tue, 16 Aug 2022 17:20:58 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in libosmo-pfcp[master]: configure.ac: do not require unused dlopen
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/29107 ) Change subject: configure.ac: do not require unused dlopen .. configure.ac: do not require unused dlopen Change-Id: Ic012f7b19a46ee38db0172b07bad2098567192b0 --- M configure.ac 1 file changed, 0 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-pfcp refs/changes/07/29107/1 diff --git a/configure.ac b/configure.ac index 446f0b1..6d51465 100644 --- a/configure.ac +++ b/configure.ac @@ -37,9 +37,6 @@ PKG_PROG_PKG_CONFIG([0.20]) dnl checks for libraries -AC_SEARCH_LIBS([dlopen], [dl dld], [LIBRARY_DL="$LIBS";LIBS=""]) -AC_SUBST(LIBRARY_DL) - PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.5.0) dnl checks for header files -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29107 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: Ic012f7b19a46ee38db0172b07bad2098567192b0 Gerrit-Change-Number: 29107 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange
Change in osmo-gbproxy[master]: configure.ac: do not require unused dlsym/dlopen
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/29106 ) Change subject: configure.ac: do not require unused dlsym/dlopen .. configure.ac: do not require unused dlsym/dlopen Change-Id: Ib1a208c40ba9c3667980e5c404087e801a4eaaf1 --- M configure.ac 1 file changed, 0 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gbproxy refs/changes/06/29106/1 diff --git a/configure.ac b/configure.ac index 48021aa..395248e 100644 --- a/configure.ac +++ b/configure.ac @@ -38,13 +38,6 @@ CFLAGS="$CFLAGS -std=gnu11" dnl checks for libraries -AC_SEARCH_LIBS([dlopen], [dl dld], [LIBRARY_DL="$LIBS";LIBS=""]) -AC_SUBST(LIBRARY_DL) - -AC_SEARCH_LIBS([dlsym], [dl dld], [LIBRARY_DLSYM="$LIBS";LIBS=""]) -AC_SUBST(LIBRARY_DLSYM) - - PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.7.0) PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.7.0) PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.7.0) -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/29106 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: Ib1a208c40ba9c3667980e5c404087e801a4eaaf1 Gerrit-Change-Number: 29106 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange
Change in osmo-hnodeb[master]: configure.ac: do not require unused dlopen
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/29105 ) Change subject: configure.ac: do not require unused dlopen .. configure.ac: do not require unused dlopen Change-Id: Idd4a816babcfb2e2302fbd21cb48989659940d5c --- M configure.ac 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnodeb refs/changes/05/29105/1 diff --git a/configure.ac b/configure.ac index 9e1e51a..4b9a299 100644 --- a/configure.ac +++ b/configure.ac @@ -37,8 +37,6 @@ PKG_PROG_PKG_CONFIG([0.20]) dnl checks for libraries -AC_SEARCH_LIBS([dlopen], [dl dld], [LIBRARY_DL="$LIBS";LIBS=""]) -AC_SUBST(LIBRARY_DL) old_LIBS=$LIBS AC_SEARCH_LIBS([sctp_recvmsg], [sctp], [ AC_DEFINE(HAVE_LIBSCTP, 1, [Define 1 to enable SCTP support]) -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/29105 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Idd4a816babcfb2e2302fbd21cb48989659940d5c Gerrit-Change-Number: 29105 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange
Change in osmo-hnbgw[master]: configure.ac: do not require unused dlopen
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29104 ) Change subject: configure.ac: do not require unused dlopen .. configure.ac: do not require unused dlopen Change-Id: Ia23cee40fd63f708e7a7391417ec8604f51a20a7 --- M configure.ac 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/04/29104/1 diff --git a/configure.ac b/configure.ac index 6bfb080..1a73496 100644 --- a/configure.ac +++ b/configure.ac @@ -37,8 +37,6 @@ PKG_PROG_PKG_CONFIG([0.20]) dnl checks for libraries -AC_SEARCH_LIBS([dlopen], [dl dld], [LIBRARY_DL="$LIBS";LIBS=""]) -AC_SUBST(LIBRARY_DL) old_LIBS=$LIBS AC_SEARCH_LIBS([sctp_recvmsg], [sctp], [ AC_DEFINE(HAVE_LIBSCTP, 1, [Define 1 to enable SCTP support]) -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29104 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ia23cee40fd63f708e7a7391417ec8604f51a20a7 Gerrit-Change-Number: 29104 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange
Change in osmo-upf[master]: configure.ac: do not require unused dlopen
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-upf/+/29103 ) Change subject: configure.ac: do not require unused dlopen .. configure.ac: do not require unused dlopen Change-Id: Ied459216cc13f1481e8b0db978a284363197f32a --- M configure.ac 1 file changed, 0 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/03/29103/1 diff --git a/configure.ac b/configure.ac index 3522af0..18e8d6b 100644 --- a/configure.ac +++ b/configure.ac @@ -36,9 +36,6 @@ PKG_PROG_PKG_CONFIG([0.20]) dnl checks for libraries -AC_SEARCH_LIBS([dlopen], [dl dld], [LIBRARY_DL="$LIBS";LIBS=""]) -AC_SUBST(LIBRARY_DL) - PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.5.0) PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.5.0) PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.5.0) -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/29103 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ied459216cc13f1481e8b0db978a284363197f32a Gerrit-Change-Number: 29103 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange
Change in osmo-ci[master]: obs: fix building srcpkg with empty debian/changelog
Attention is currently required from: osmith, neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29097 ) Change subject: obs: fix building srcpkg with empty debian/changelog .. Patch Set 2: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ci/+/29097/comment/a4f07b7b_d6956726 PS2, Line 9: empty debian/changelog AFAIK, dpkg would refuse to build a package with empty changelog. So I think osmo-upf needs to be fixed, not osmo-ci. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29097 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I294d844fa12599b6ba1def087e4a32d289e7 Gerrit-Change-Number: 29097 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Attention: osmith Gerrit-Attention: neels Gerrit-Comment-Date: Tue, 16 Aug 2022 16:40:11 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in libosmo-gprs[master]: configure.ac: do require unused dlopen
fixeria has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29100 ) Change subject: configure.ac: do require unused dlopen .. configure.ac: do require unused dlopen Change-Id: Iaf9729156ace5f8dc9134094ab3c0a185c7184d5 --- M configure.ac 1 file changed, 0 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/00/29100/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29100 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Iaf9729156ace5f8dc9134094ab3c0a185c7184d5 Gerrit-Change-Number: 29100 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-MessageType: newpatchset
Change in osmo-bsc[master]: configure.ac: do not require unused dlopen
fixeria has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-bsc/+/29101 ) Change subject: configure.ac: do not require unused dlopen .. configure.ac: do not require unused dlopen Change-Id: I528ed8d7b61b39a474376c21fccc47a8531027b7 --- M configure.ac 1 file changed, 1 insertion(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/01/29101/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29101 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I528ed8d7b61b39a474376c21fccc47a8531027b7 Gerrit-Change-Number: 29101 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset
Change in osmo-sgsn[master]: configure.ac: do not require unused dlsym/dlopen
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/29102 ) Change subject: configure.ac: do not require unused dlsym/dlopen .. configure.ac: do not require unused dlsym/dlopen Change-Id: I90b383ed45b27d8b59272116dd81acb72912349d --- M configure.ac 1 file changed, 0 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/02/29102/1 diff --git a/configure.ac b/configure.ac index caa66d3..64b74e3 100644 --- a/configure.ac +++ b/configure.ac @@ -38,13 +38,6 @@ CFLAGS="$CFLAGS -std=gnu11" dnl checks for libraries -AC_SEARCH_LIBS([dlopen], [dl dld], [LIBRARY_DL="$LIBS";LIBS=""]) -AC_SUBST(LIBRARY_DL) - -AC_SEARCH_LIBS([dlsym], [dl dld], [LIBRARY_DLSYM="$LIBS";LIBS=""]) -AC_SUBST(LIBRARY_DLSYM) - - PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.7.0) PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.7.0) PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.7.0) -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/29102 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I90b383ed45b27d8b59272116dd81acb72912349d Gerrit-Change-Number: 29102 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange
Change in osmo-bsc[master]: configure.ac: do not search for dlopen, it's not used nor needed
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29101 ) Change subject: configure.ac: do not search for dlopen, it's not used nor needed .. configure.ac: do not search for dlopen, it's not used nor needed Change-Id: I528ed8d7b61b39a474376c21fccc47a8531027b7 --- M configure.ac 1 file changed, 1 insertion(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/01/29101/1 diff --git a/configure.ac b/configure.ac index 07a9757..9ecd66d 100644 --- a/configure.ac +++ b/configure.ac @@ -36,16 +36,13 @@ fi PKG_PROG_PKG_CONFIG([0.20]) -dnl checks for libraries -AC_SEARCH_LIBS([dlopen], [dl dld], [LIBRARY_DL="$LIBS";LIBS=""]) -AC_SUBST(LIBRARY_DL) - # Enable/disable ipaccess-utils (src/ipacces/)? AC_ARG_ENABLE([ipaccess-utils], [AS_HELP_STRING([--enable-ipaccess-utils], [Build ipaccess utils: abisip-find, ipaccess-config, ...])], [osmo_ac_ipa_utils="$enableval"],[osmo_ac_ipa_utils="yes"]) AM_CONDITIONAL(BUILD_IPA_UTILS, test "x$osmo_ac_ipa_utils" = "xyes") AC_SUBST(osmo_ac_ipa_utils) +dnl checks for libraries PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.7.0) PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.7.0) PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.7.0) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29101 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I528ed8d7b61b39a474376c21fccc47a8531027b7 Gerrit-Change-Number: 29101 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange
Change in libosmo-gprs[master]: configure.ac: do not search for dlopen, it's not used nor needed
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29100 ) Change subject: configure.ac: do not search for dlopen, it's not used nor needed .. configure.ac: do not search for dlopen, it's not used nor needed Change-Id: Iaf9729156ace5f8dc9134094ab3c0a185c7184d5 --- M configure.ac 1 file changed, 0 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/00/29100/1 diff --git a/configure.ac b/configure.ac index 15974ee..a3570a9 100644 --- a/configure.ac +++ b/configure.ac @@ -31,9 +31,6 @@ PKG_PROG_PKG_CONFIG([0.20]) dnl checks for libraries -AC_SEARCH_LIBS([dlopen], [dl dld], [LIBRARY_DL="$LIBS";LIBS=""]) -AC_SUBST(LIBRARY_DL) - PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.7.0) dnl checks for header files -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29100 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Iaf9729156ace5f8dc9134094ab3c0a185c7184d5 Gerrit-Change-Number: 29100 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange
Change in libosmo-gprs[master]: tests/testsuite.at: remove $OSMO_QEMU, it's not used
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29098 ) Change subject: tests/testsuite.at: remove $OSMO_QEMU, it's not used .. tests/testsuite.at: remove $OSMO_QEMU, it's not used Change-Id: If7332b347c0f08252b130ca7f6e7ec4fe6d78b59 --- M tests/testsuite.at 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/98/29098/1 diff --git a/tests/testsuite.at b/tests/testsuite.at index 47a3e36..4669a00 100644 --- a/tests/testsuite.at +++ b/tests/testsuite.at @@ -5,5 +5,5 @@ AT_KEYWORDS([rlcmac]) cat $abs_srcdir/rlcmac/RLCMACTest.ok > expout cat $abs_srcdir/rlcmac/RLCMACTest.err > experr -AT_CHECK([$OSMO_QEMU $abs_top_builddir/tests/rlcmac/RLCMACTest], [0], [expout], [experr]) +AT_CHECK([$abs_top_builddir/tests/rlcmac/RLCMACTest], [0], [expout], [experr]) AT_CLEANUP -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29098 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: If7332b347c0f08252b130ca7f6e7ec4fe6d78b59 Gerrit-Change-Number: 29098 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange
Change in libosmo-gprs[master]: tests/rlcmac: fix incorrect RLCMACTest.{ok,err} paths in EXTRA_DIST
fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmo-gprs/+/29099 )
Change subject: tests/rlcmac: fix incorrect RLCMACTest.{ok,err} paths in
EXTRA_DIST
..
tests/rlcmac: fix incorrect RLCMACTest.{ok,err} paths in EXTRA_DIST
Change-Id: I175bd6494e2a7a6f6977388d760e790b7dd2c1ae
---
M tests/rlcmac/Makefile.am
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/99/29099/1
diff --git a/tests/rlcmac/Makefile.am b/tests/rlcmac/Makefile.am
index a7193c2..633f090 100644
--- a/tests/rlcmac/Makefile.am
+++ b/tests/rlcmac/Makefile.am
@@ -13,8 +13,8 @@
$(NULL)
EXTRA_DIST = \
- rlcmac/RLCMACTest.ok \
- rlcmac/RLCMACTest.err \
+ RLCMACTest.ok \
+ RLCMACTest.err \
$(NULL)
RLCMACTest_SOURCES = RLCMACTest.c
--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29099
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I175bd6494e2a7a6f6977388d760e790b7dd2c1ae
Gerrit-Change-Number: 29099
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-MessageType: newchange
Change in osmo-dev[master]: gen_makefile.py: use --long params for target 'regen'
fixeria has submitted this change. (
https://gerrit.osmocom.org/c/osmo-dev/+/29090 )
Change subject: gen_makefile.py: use --long params for target 'regen'
..
gen_makefile.py: use --long params for target 'regen'
This way the resulting Makefile is easier to read and understand,
no need to lookup short params in help of gen_makefile.py.
Change-Id: Iba7f148fb1880af2f05cf3ca74cfb0737befeea0
---
M gen_makefile.py
1 file changed, 8 insertions(+), 8 deletions(-)
Approvals:
osmith: Looks good to me, but someone else must approve
fixeria: Looks good to me, approved; Verified
diff --git a/gen_makefile.py b/gen_makefile.py
index 6459846..05bf9ff 100755
--- a/gen_makefile.py
+++ b/gen_makefile.py
@@ -391,11 +391,11 @@
regen:
{script} \
{configure_opts} \
- -m {make_dir} \
- -o {makefile} \
- -s {src_dir} \
- -b {build_dir} \
- -u
"{url}"{push_url}{sudo_make_install}{no_ldconfig}{ldconfig_without_sudo}{make_check}{docker_cmd}{build_debug}{auto_distclean}
+ --output {makefile} \
+ --src-dir {src_dir} \
+ --make-dir {make_dir} \
+ --build-dir {build_dir} \
+ --url
"{url}"{push_url}{sudo_make_install}{no_ldconfig}{ldconfig_without_sudo}{make_check}{docker_cmd}{build_debug}{auto_distclean}
'''.format(
script=os.path.relpath(sys.argv[0], make_dir),
@@ -405,9 +405,9 @@
src_dir=os.path.relpath(args.src_dir, make_dir),
build_dir=os.path.relpath(build_dir, make_dir),
url=args.url,
-push_url=(" \\\n\t\t-p '%s'"%args.push_url) if args.push_url else '',
-sudo_make_install=' \\\n\t\t-I' if args.sudo_make_install else '',
-no_ldconfig=' \\\n\t\t-L' if args.no_ldconfig else '',
+push_url=(" \\\n\t\t--push-url '%s'"%args.push_url) if args.push_url else
'',
+sudo_make_install=' \\\n\t\t--sudo-make-install' if args.sudo_make_install
else '',
+no_ldconfig=' \\\n\t\t--no-ldconfig' if args.no_ldconfig else '',
ldconfig_without_sudo=' \\\n\t\t--ldconfig-without-sudo' if
args.ldconfig_without_sudo else '',
make_check='' if args.make_check else " \\\n\t\t--no-make-check",
docker_cmd=f' \\\n\t\t--docker-cmd "{args.docker_cmd}"' if args.docker_cmd
else '',
--
To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/29090
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-Change-Id: Iba7f148fb1880af2f05cf3ca74cfb0737befeea0
Gerrit-Change-Number: 29090
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: osmith
Gerrit-MessageType: merged
Change in osmo-dev[master]: all.deps, {sanitize,werror}.opts: add project - libosmo-gprs
fixeria has submitted this change. (
https://gerrit.osmocom.org/c/osmo-dev/+/29089 )
Change subject: all.deps, {sanitize,werror}.opts: add project - libosmo-gprs
..
all.deps, {sanitize,werror}.opts: add project - libosmo-gprs
Change-Id: I707e6ee0af6bcb940d5e77475bc581c0d07de6d7
---
M all.deps
M sanitize.opts
M werror.opts
3 files changed, 4 insertions(+), 1 deletion(-)
Approvals:
osmith: Looks good to me, but someone else must approve
fixeria: Looks good to me, approved; Verified
diff --git a/all.deps b/all.deps
index 7e099cf..5cb4811 100644
--- a/all.deps
+++ b/all.deps
@@ -1,6 +1,7 @@
# project build these first
libosmocore
libosmo-abis libosmocore
+libosmo-gprs libosmocore
libosmo-netif libosmo-abis
libosmo-sccp libosmo-netif
libsmpp34
@@ -19,7 +20,7 @@
# When omitting --enable-sanitize from osmo-trx only, its 'make check' will
fail.
# So if you want osmo-trx, use no sanitize.opts, or use LD_PRELOAD for
osmo-trx binaries.
osmo-trx libosmocore
-osmo-pcu libosmocore
+osmo-pcu libosmocore libosmo-gprs
asn1c libasn1c
osmo-gbproxy libosmocore
osmo-pcap libosmocore
diff --git a/sanitize.opts b/sanitize.opts
index 51721bc..7abb8c6 100644
--- a/sanitize.opts
+++ b/sanitize.opts
@@ -1,6 +1,7 @@
libasn1c --enable-sanitize
libosmo-abis --enable-sanitize
libosmocore --enable-sanitize
+libosmo-gprs --enable-sanitize
libosmo-netif --enable-sanitize
libosmo-sccp --enable-sanitize
libosmo-pfcp --enable-sanitize
diff --git a/werror.opts b/werror.opts
index af7c8dd..1e7079a 100644
--- a/werror.opts
+++ b/werror.opts
@@ -1,6 +1,7 @@
libasn1c --enable-werror
libosmo-abis --enable-werror
libosmocore --enable-werror
+libosmo-gprs --enable-werror
libosmo-netif --enable-werror
libosmo-sccp --enable-werror
libosmo-pfcp --enable-werror
--
To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/29089
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-Change-Id: I707e6ee0af6bcb940d5e77475bc581c0d07de6d7
Gerrit-Change-Number: 29089
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: osmith
Gerrit-MessageType: merged
