Change in libgtpnl[master]: README: fix link to homepage

[fixeria]

Attention is currently required from: osmith.
fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libgtpnl/+/29262 )

Change subject: README: fix link to homepage
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/29262
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libgtpnl
Gerrit-Branch: master
Gerrit-Change-Id: I9ae4e9cb53618f4119170eb00e771c9033c52229
Gerrit-Change-Number: 29262
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-Attention: osmith 
Gerrit-Comment-Date: Thu, 01 Sep 2022 17:07:10 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bts[master]: cosmetic: Fix formatting of if-else block brackets

[pespin]

pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/29263 )

Change subject: cosmetic: Fix formatting of if-else block brackets
..

cosmetic: Fix formatting of if-else block brackets

Change-Id: Ifec6674ba04109f6b8a039679caff08f060d83d9
---
M src/osmo-bts-trx/sched_lchan_tchf.c
M src/osmo-bts-trx/sched_lchan_tchh.c
2 files changed, 6 insertions(+), 4 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved



diff --git a/src/osmo-bts-trx/sched_lchan_tchf.c 
b/src/osmo-bts-trx/sched_lchan_tchf.c
index b530d25..65f397d 100644
--- a/src/osmo-bts-trx/sched_lchan_tchf.c
+++ b/src/osmo-bts-trx/sched_lchan_tchf.c
@@ -505,7 +505,7 @@
if (msgb_l2len(msg) == GSM_MACBLOCK_LEN) {
gsm0503_tch_fr_encode(*bursts_p, msg->l2h, msgb_l2len(msg), 1);
chan_state->dl_facch_bursts = 8;
-   } else if (tch_mode == GSM48_CMODE_SPEECH_AMR)
+   } else if (tch_mode == GSM48_CMODE_SPEECH_AMR) {
/* the first FN 4,13,21 defines that CMI is included in frame,
 * the first FN 0,8,17 defines that CMR is included in frame.
 */
@@ -514,8 +514,9 @@
chan_state->codec, chan_state->codecs,
chan_state->dl_ft,
chan_state->dl_cmr);
-   else
+   } else {
gsm0503_tch_fr_encode(*bursts_p, msg->l2h, msgb_l2len(msg), 1);
+   }

/* free message */
msgb_free(msg);
diff --git a/src/osmo-bts-trx/sched_lchan_tchh.c 
b/src/osmo-bts-trx/sched_lchan_tchh.c
index 7b0f96a..a5f6747 100644
--- a/src/osmo-bts-trx/sched_lchan_tchh.c
+++ b/src/osmo-bts-trx/sched_lchan_tchh.c
@@ -432,7 +432,7 @@
gsm0503_tch_hr_encode(*bursts_p, msg->l2h, msgb_l2len(msg));
chan_state->dl_ongoing_facch = 1; /* first of two TCH frames */
chan_state->dl_facch_bursts = 6;
-   } else if (tch_mode == GSM48_CMODE_SPEECH_AMR)
+   } else if (tch_mode == GSM48_CMODE_SPEECH_AMR) {
/* the first FN 4,13,21 or 5,14,22 defines that CMI is included
 * in frame, the first FN 0,8,17 or 1,9,18 defines that CMR is
 * included in frame. */
@@ -441,8 +441,9 @@
chan_state->codec, chan_state->codecs,
chan_state->dl_ft,
chan_state->dl_cmr);
-   else
+   } else {
gsm0503_tch_hr_encode(*bursts_p, msg->l2h, msgb_l2len(msg));
+   }

/* free message */
msgb_free(msg);

--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29263
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ifec6674ba04109f6b8a039679caff08f060d83d9
Gerrit-Change-Number: 29263
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in osmo-bts[master]: cosmetic: Fix formatting of if-else block brackets

[fixeria]

Attention is currently required from: pespin.
fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/29263 )

Change subject: cosmetic: Fix formatting of if-else block brackets
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29263
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ifec6674ba04109f6b8a039679caff08f060d83d9
Gerrit-Change-Number: 29263
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Thu, 01 Sep 2022 16:37:32 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmo-bts[master]: cosmetic: Fix formatting of if-else block brackets

[pespin]

pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/29263 )


Change subject: cosmetic: Fix formatting of if-else block brackets
..

cosmetic: Fix formatting of if-else block brackets

Change-Id: Ifec6674ba04109f6b8a039679caff08f060d83d9
---
M src/osmo-bts-trx/sched_lchan_tchf.c
M src/osmo-bts-trx/sched_lchan_tchh.c
2 files changed, 6 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/63/29263/1

diff --git a/src/osmo-bts-trx/sched_lchan_tchf.c 
b/src/osmo-bts-trx/sched_lchan_tchf.c
index b530d25..65f397d 100644
--- a/src/osmo-bts-trx/sched_lchan_tchf.c
+++ b/src/osmo-bts-trx/sched_lchan_tchf.c
@@ -505,7 +505,7 @@
if (msgb_l2len(msg) == GSM_MACBLOCK_LEN) {
gsm0503_tch_fr_encode(*bursts_p, msg->l2h, msgb_l2len(msg), 1);
chan_state->dl_facch_bursts = 8;
-   } else if (tch_mode == GSM48_CMODE_SPEECH_AMR)
+   } else if (tch_mode == GSM48_CMODE_SPEECH_AMR) {
/* the first FN 4,13,21 defines that CMI is included in frame,
 * the first FN 0,8,17 defines that CMR is included in frame.
 */
@@ -514,8 +514,9 @@
chan_state->codec, chan_state->codecs,
chan_state->dl_ft,
chan_state->dl_cmr);
-   else
+   } else {
gsm0503_tch_fr_encode(*bursts_p, msg->l2h, msgb_l2len(msg), 1);
+   }

/* free message */
msgb_free(msg);
diff --git a/src/osmo-bts-trx/sched_lchan_tchh.c 
b/src/osmo-bts-trx/sched_lchan_tchh.c
index 7b0f96a..a5f6747 100644
--- a/src/osmo-bts-trx/sched_lchan_tchh.c
+++ b/src/osmo-bts-trx/sched_lchan_tchh.c
@@ -432,7 +432,7 @@
gsm0503_tch_hr_encode(*bursts_p, msg->l2h, msgb_l2len(msg));
chan_state->dl_ongoing_facch = 1; /* first of two TCH frames */
chan_state->dl_facch_bursts = 6;
-   } else if (tch_mode == GSM48_CMODE_SPEECH_AMR)
+   } else if (tch_mode == GSM48_CMODE_SPEECH_AMR) {
/* the first FN 4,13,21 or 5,14,22 defines that CMI is included
 * in frame, the first FN 0,8,17 or 1,9,18 defines that CMR is
 * included in frame. */
@@ -441,8 +441,9 @@
chan_state->codec, chan_state->codecs,
chan_state->dl_ft,
chan_state->dl_cmr);
-   else
+   } else {
gsm0503_tch_hr_encode(*bursts_p, msg->l2h, msgb_l2len(msg));
+   }

/* free message */
msgb_free(msg);

--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29263
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ifec6674ba04109f6b8a039679caff08f060d83d9
Gerrit-Change-Number: 29263
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange

Change in osmocom-bb[master]: trxcon: Fix printf type

[fixeria]

fixeria has submitted this change. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/29261 )

Change subject: trxcon: Fix printf type
..

trxcon: Fix printf type

data_len is a size_t, and gcc warns about it.

Change-Id: Ib0c1bfefc0371b8cfb3b7a2e74a6980dd3987931
---
M src/host/trxcon/src/trxcon_fsm.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  neels: Looks good to me, but someone else must approve
  fixeria: Looks good to me, approved



diff --git a/src/host/trxcon/src/trxcon_fsm.c b/src/host/trxcon/src/trxcon_fsm.c
index 40d5253..aa7193a 100644
--- a/src/host/trxcon/src/trxcon_fsm.c
+++ b/src/host/trxcon/src/trxcon_fsm.c
@@ -80,7 +80,7 @@
break;
}
if (req->data_len != GSM_MACBLOCK_LEN) {
-   LOGPFSML(fi, LOGL_ERROR, "Unexpected data length=%u\n", 
req->data_len);
+   LOGPFSML(fi, LOGL_ERROR, "Unexpected data 
length=%zu\n", req->data_len);
break;
}


--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/29261
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ib0c1bfefc0371b8cfb3b7a2e74a6980dd3987931
Gerrit-Change-Number: 29261
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: neels 
Gerrit-MessageType: merged

Change in osmocom-bb[master]: trxcon: Fix printf type

[fixeria]

Attention is currently required from: pespin.
fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/29261 )

Change subject: trxcon: Fix printf type
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/29261
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ib0c1bfefc0371b8cfb3b7a2e74a6980dd3987931
Gerrit-Change-Number: 29261
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: neels 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Thu, 01 Sep 2022 14:37:14 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libgtpnl[master]: README: fix link to homepage

[pespin]

Attention is currently required from: osmith.
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libgtpnl/+/29262 )

Change subject: README: fix link to homepage
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/29262
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libgtpnl
Gerrit-Branch: master
Gerrit-Change-Id: I9ae4e9cb53618f4119170eb00e771c9033c52229
Gerrit-Change-Number: 29262
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Attention: osmith 
Gerrit-Comment-Date: Thu, 01 Sep 2022 12:31:33 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libgtpnl[master]: README: fix link to homepage

[osmith]

osmith has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/libgtpnl/+/29262 )


Change subject: README: fix link to homepage
..

README: fix link to homepage

Old link is 404, so adjust it.

Change-Id: I9ae4e9cb53618f4119170eb00e771c9033c52229
---
M README.md
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/libgtpnl refs/changes/62/29262/1

diff --git a/README.md b/README.md
index 23c1d25..5d3b5bf 100644
--- a/README.md
+++ b/README.md
@@ -13,7 +13,7 @@
 ## Homepage

 The official homepage of the project is
-
+

 GIT Repository
 --

--
To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/29262
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libgtpnl
Gerrit-Branch: master
Gerrit-Change-Id: I9ae4e9cb53618f4119170eb00e771c9033c52229
Gerrit-Change-Number: 29262
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-MessageType: newchange

Change in libosmo-netif[master]: osmux: Drop long time deprecated APIs

[pespin]

Attention is currently required from: neels.
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-netif/+/29256 )

Change subject: osmux: Drop long time deprecated APIs
..


Patch Set 2:

(2 comments)

Commit Message:

https://gerrit.osmocom.org/c/libosmo-netif/+/29256/comment/1acc0f5e_25bb4b63
PS2, Line 10: been
> "not been"? […]
We'll require a major bump anyway since the whole API will be 
improved/extended/changed (see for instance the new _alloc() function in follow 
up commit).

The idea of deprecating APIs is not to keep them forever, but to signal users 
that the API will be removed at some point, and give some rational time to them 
to do move to the new APIs.
4 years of time given the amount of users of this API looks more than 
reasonable to me.


File src/osmux.c:

https://gerrit.osmocom.org/c/libosmo-netif/+/29256/comment/d9df38cb_756f393a
PS2, Line 49: #if 0
> this is "deprecated API" ?
Yes, it's implementation stuff from APIs being removed. After those are gone, 
this is not needed and hence it is removed as part of the API implementation.



--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29256
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Icbdd364a8161a8113dbf1406716946f684d0a853
Gerrit-Change-Number: 29256
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: neels 
Gerrit-Attention: neels 
Gerrit-Comment-Date: Thu, 01 Sep 2022 11:52:37 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels 
Gerrit-MessageType: comment

Change in libosmo-netif[master]: osmux: Move osmux_xfrm_output_set_tx_cb() further down to the xfrm_ou...

[neels]

Attention is currently required from: pespin.
neels has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-netif/+/29257 )

Change subject: osmux: Move osmux_xfrm_output_set_tx_cb() further down to the 
xfrm_output section
..


Patch Set 2: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29257
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I46628d1f712e9c5c56c306e27c34ff45731c0172
Gerrit-Change-Number: 29257
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Thu, 01 Sep 2022 11:46:27 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmo-netif[master]: osmux: Drop long time deprecated APIs

[neels]

Attention is currently required from: pespin.
neels has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-netif/+/29256 )

Change subject: osmux: Drop long time deprecated APIs
..


Patch Set 2:

(2 comments)

Commit Message:

https://gerrit.osmocom.org/c/libosmo-netif/+/29256/comment/feab05bb_7d3307bd
PS2, Line 10: been
"not been"?

what makes you so sure, the idea behind keeping deprecated API is to remain 
backwards compatible *forever*. dropping would require a major version bump.

if they make things hard to understand, maybe just move to the bottom / a new 
file


File src/osmux.c:

https://gerrit.osmocom.org/c/libosmo-netif/+/29256/comment/e8ca9dcc_88b9b269
PS2, Line 49: #if 0
this is "deprecated API" ?



--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29256
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Icbdd364a8161a8113dbf1406716946f684d0a853
Gerrit-Change-Number: 29256
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: neels 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Thu, 01 Sep 2022 11:45:54 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in libosmo-netif[master]: examples/osmux-test-output: Avoid using deprecated Osmux API

[neels]

Attention is currently required from: pespin.
neels has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-netif/+/29255 )

Change subject: examples/osmux-test-output: Avoid using deprecated Osmux API
..


Patch Set 1: Code-Review+1

(1 comment)

Commit Message:

https://gerrit.osmocom.org/c/libosmo-netif/+/29255/comment/63c1cdd9_9b68f823
PS1, Line 7: examples/osmux-test-output: Avoid using deprecated Osmux API
funny, just before also deprecating osmux_xfrm_output_init2()



--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29255
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I408bfc84b9c1740df946fa29191f0e286f5b46e1
Gerrit-Change-Number: 29255
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: neels 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Thu, 01 Sep 2022 11:41:42 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmo-netif[master]: osmux: Allocate struct osmux_out_handle through API

[neels]

Attention is currently required from: pespin.
neels has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-netif/+/29258 )

Change subject: osmux: Allocate struct osmux_out_handle through API
..


Patch Set 4: Code-Review+1

(1 comment)

File src/osmux.c:

https://gerrit.osmocom.org/c/libosmo-netif/+/29258/comment/e8054752_9c585571
PS4, Line 873: /* Returned pointer can be freed with regular talloc_free, queue 
will be flushed
should be doxygen comment?

 /*!



--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29258
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Ie8df581f375c9a183a7af60b431561bda82f6e34
Gerrit-Change-Number: 29258
Gerrit-PatchSet: 4
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Thu, 01 Sep 2022 11:38:51 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in osmocom-bb[master]: trxcon: Fix printf type

[neels]

Attention is currently required from: pespin, fixeria.
neels has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/29261 )

Change subject: trxcon: Fix printf type
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/29261
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ib0c1bfefc0371b8cfb3b7a2e74a6980dd3987931
Gerrit-Change-Number: 29261
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: neels 
Gerrit-Attention: pespin 
Gerrit-Attention: fixeria 
Gerrit-Comment-Date: Thu, 01 Sep 2022 11:29:18 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmo-sccp[master]: SIGTRAN: cache Optional Data for SCCP CR/CC/RLSD

[neels]

Attention is currently required from: laforge, pespin, fixeria, msuraev.
neels has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 )

Change subject: SIGTRAN: cache Optional Data for SCCP CR/CC/RLSD
..


Patch Set 16:

(9 comments)

File src/sccp_scoc.c:

https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/cef92837_7aa7730a
PS14, Line 1110:xua_opt_data_send_cache(conn, SUA_CO_CORE, 
xua->hdr.msg_class);
> I think I'm missing a point in here. […]
maybe i was misreading this code. It looks to me like below 
scu_gen_encode_and_send(N_CONNECT, CONFIRM) *sends* a Conn Conf; that made me 
assume this here is the side that received the Conn Req and is responding with 
a CC.
Then again above case "CC_IND" looks like this *receives* a Conn Conf, didn't 
see that before.. now i'm confused between the prims, which side is which.


File src/sccp_scoc.c:

https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/b76d4a42_2892dd9f
PS15, Line 642: /* optional: importance */
> The RLC does not have optional importance field.
like i said before, a patch should ideally do one thing.
To fix other bits along with it, just put it in a separate commit.
it is an act of courtesy to code reviewers; it is harder to read a complex 
patch when unrelated fixes go with it.
it also makes it possible to work with patches as "atoms", though we hardly 
ever need that part of it.


https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/e9d63318_a58c7883
PS15, Line 635: LOGP(DLSCCP, LOGL_ERROR, "replacing 
unsent %u bytes of optional data cache with %s optional data\n",
> AFAIU that's something coming from outside, from a peer, so not really an 
> error of the program itsel […]
I understand, this case is where we want to cache optional data, but there 
already is other data in the cache. Is this even possible to happen? ... maybe 
if we send a CR to the peer, but receive no response, and try again with the 
same CR. Then we already have data in the cache that could not be sent -- so 
seeing this error means that it is a software bug, did not clean up unsent 
cached data after a failure??

IMHO a comment and the log message could clarify this, like "ERROR: caching 
optional data for N-CONNECT, but there already is optional data occupying the 
cache. Dropping previous data."

ERROR category is good.


File src/sccp_scoc.c:

https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/264d5726_895dcaeb
PS16, Line 592: nt exp_type
could you explain a situation where there might be a mismatch from the expected 
type? Isn't it always DT1 to be sent at the right time?


https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/24694b57_c30425dc
PS16, Line 638: msgb_trim(conn->opt_data_cache, 0);
(i'd prefer sanitation: msgb_free() here, and always alloc a new one.)


https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/d76a2fe0_c812277d
PS16, Line 667:see Figure C.3 / Q.714 (sheet 2 of 
6) */
(osmocom asks to put '*' on every line of comment)


https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/d0fb57e1_5cc3e68f
PS16, Line 673: if (xua_drop_data_check_drop(prim, 
SCCP_MAX_DATA, "cache overrun"))
the optional data is larger than the upper limit of an SCCP DATA section -- 
this is not related to cache at all, the conn is still open and no cache is 
ever involved. it is a protocol error caused by the caller. Is it even possible 
/ likely?

Also not an overrun. There is plenty of space in a msgb, there is no previous 
data in the cache...


https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/2949a077_4679ee42
PS16, Line 675: /* There's no need to cache the 
optional data since the connection is still active at this point */
/* Send the Optional Data in a DT1 ahead of the RLSD, because it is too large 
to be sent in one message. */


https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/c84d1859_9f367b02
PS16, Line 712: ount
(again modifying unrelated comments)



--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29084
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I0033faf9da393418930252233ce74d62cd1cef8a
Gerrit-Change-Number: 29084
Gerrit-PatchSet: 16
Gerrit-Owner: msuraev 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-CC: pespin 
Gerrit-Attention: laforge 
Gerrit-Attention: pespin 
Gerrit-Attention: fixeria 
Gerrit-Attention: msuraev 
Gerrit-Comment-Date: Thu, 01 Sep 2022 11:27:45 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels 
Comment-In-Reply-To: pespin 
Comment-In-Reply-To: msuraev 
Gerrit-MessageType: comment

Change in osmocom-bb[master]: trxcon: Fix printf type

[pespin]

pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/29261 )


Change subject: trxcon: Fix printf type
..

trxcon: Fix printf type

data_len is a size_t, and gcc warns about it.

Change-Id: Ib0c1bfefc0371b8cfb3b7a2e74a6980dd3987931
---
M src/host/trxcon/src/trxcon_fsm.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/61/29261/1

diff --git a/src/host/trxcon/src/trxcon_fsm.c b/src/host/trxcon/src/trxcon_fsm.c
index 40d5253..aa7193a 100644
--- a/src/host/trxcon/src/trxcon_fsm.c
+++ b/src/host/trxcon/src/trxcon_fsm.c
@@ -80,7 +80,7 @@
break;
}
if (req->data_len != GSM_MACBLOCK_LEN) {
-   LOGPFSML(fi, LOGL_ERROR, "Unexpected data length=%u\n", 
req->data_len);
+   LOGPFSML(fi, LOGL_ERROR, "Unexpected data 
length=%zu\n", req->data_len);
break;
}


--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/29261
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ib0c1bfefc0371b8cfb3b7a2e74a6980dd3987931
Gerrit-Change-Number: 29261
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange