Change in osmo-hlr[master]: Add vty `reject-cause` to set the reject cause
Attention is currently required from: pespin, lynxis lazus. keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16808 ) Change subject: Add vty `reject-cause` to set the reject cause .. Patch Set 11: (1 comment) Patchset: PS11: > Hi @keith, maybe what I'm missing here is the rationale on WHY is this > needed. […] Hi @pespin. I my case, I was interested to see how the phones were actually behaving with the different LU Reject reasons. It seems like they don't really behave as in the spec. (TS24.008 4.4.4.7) I got bored of recompiling osmo-msc with hard coded reject causes and then I noticed this patch in CR from @lynxis. Given the patch originally almost made it through CR, and it seems like it was something that lynxis wanted at a c3 event for whatever reason, I decided to fix it up and submit a patchset. It might be interesting to know if lynxis remembers or still has any interest. >From my point of view, there is one use case where I might want to configure >the LU reject cause at runtime, which has to do with dGSM. If I reject an MS because no HLR responds to a distributed request for a home HLR; this may have happened because, 1) there is no home HLR or 2) the home HLR was offline/unreachable at the moment of the LUR. In the first case, I guess I would like the phone to go away and never LUR again, (at least until T3245 expires), in the second case, I might like it to try again rather soon. Now, as I said, accord the the spec i mentioned above, if I were to send a cause @2 "IMSI unknown in HLR" - which is the current default, I would expect: "The mobile station shall set the update status to ROAMING NOT ALLOWED (and store it in the SIM/USIM and delete any TMSI, stored LAI [etc] consider the SIM/USIM as invalid for non-GPRS services until switch-off or the SIM/USIM is removed or the timer T3245 expires as described in subclause 4.1.1.6." Howver, All the ME I tried DON'T do this, but rather they try again every 20 seconds up to 8 times and then continuously on what seems like the T3212 timer. However, with cause #13 the ME seems to NOT retry in the cell again, at least not immediately. Anyway, seems like one might like to do some trial and error with one's own situation in this and therefore being able to configure this via the vty might be "handy" (sorry for unintended bad pun, German speakers) We have some sites that don't have many phones trying to connect, we also have some that have 1000s, so on the busy site, I might prefer to set a cuase then makes them back off, at the expense of loosing the odd "orphan" "roaming" user (until they power cycles/toggle airplane mode) - whereas on the not busy site, I might set a reject cause like CONGESTION that allows that phone to keep trying in the hope their home HLR came back online. @pespin, if you'ld like any of the above in the commit msg for this patchset, please feel free to copy and paste, I also have a series of commits related to dGSM in the works, including documentation update, so I can include some of the above text there also. -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16808 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a Gerrit-Change-Number: 16808 Gerrit-PatchSet: 11 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-CC: keith Gerrit-CC: pespin Gerrit-Attention: pespin Gerrit-Attention: lynxis lazus Gerrit-Comment-Date: Wed, 18 Jan 2023 20:48:32 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
Change in libosmocore[master]: isdndlc: Fix documentation
Attention is currently required from: laforge. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30761 ) Change subject: isdndlc: Fix documentation .. Patch Set 3: (7 comments) File src/core/isdnhdlc.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2859): https://gerrit.osmocom.org/c/libosmocore/+/30761/comment/152d7397_58920891 PS3, Line 100: excluding the CRC. please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2859): https://gerrit.osmocom.org/c/libosmocore/+/30761/comment/4b9d8d9c_696ad1b3 PS3, Line 104: returns -OSMO_HDLC_FRAMING_ERROR. please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2859): https://gerrit.osmocom.org/c/libosmocore/+/30761/comment/16757f4d_9eb8ee83 PS3, Line 104: returns -OSMO_HDLC_FRAMING_ERROR. Avoid multiple line dereference - prefer 'CRC.returns' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2859): https://gerrit.osmocom.org/c/libosmocore/+/30761/comment/21f8b94c_a50a2d78 PS3, Line 104: returns -OSMO_HDLC_FRAMING_ERROR. need consistent spacing around '-' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2859): https://gerrit.osmocom.org/c/libosmocore/+/30761/comment/92556437_724d57d0 PS3, Line 105: If a CRC error is found the function returns -OSMO_HDLC_CRC_ERROR. please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2859): https://gerrit.osmocom.org/c/libosmocore/+/30761/comment/511b8970_805be2dd PS3, Line 105: If a CRC error is found the function returns -OSMO_HDLC_CRC_ERROR. Avoid multiple line dereference - prefer 'OSMO_HDLC_FRAMING_ERROR.If' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2859): https://gerrit.osmocom.org/c/libosmocore/+/30761/comment/ef148630_f1600a16 PS3, Line 105: If a CRC error is found the function returns -OSMO_HDLC_CRC_ERROR. need consistent spacing around '-' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30761 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib5def2ae3c79f408f2ee0bb4c20fba1437d30c64 Gerrit-Change-Number: 30761 Gerrit-PatchSet: 3 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge Gerrit-Comment-Date: Wed, 18 Jan 2023 20:19:29 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in libosmocore[master]: isdn: Add V.110 encoder/decoder
Attention is currently required from: laforge. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30762 ) Change subject: isdn: Add V.110 encoder/decoder .. Patch Set 3: (3 comments) File src/isdn/v110.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2857): https://gerrit.osmocom.org/c/libosmocore/+/30762/comment/a7a2adef_450e3dc2 PS3, Line 1: /* V.110 frames according to ITU-T V.110 trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2857): https://gerrit.osmocom.org/c/libosmocore/+/30762/comment/a48bca79_a664df47 PS3, Line 82: ra_bits[2*8 +7] = fr->x_bits[0]; need consistent spacing around '+' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2857): https://gerrit.osmocom.org/c/libosmocore/+/30762/comment/90d3e9b0_b16d0ccd PS3, Line 83: ra_bits[7*8 +7] = fr->x_bits[1]; need consistent spacing around '+' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30762 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1b5fd3847d3bfb0a0f763e0574893962ec699680 Gerrit-Change-Number: 30762 Gerrit-PatchSet: 3 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Attention: laforge Gerrit-Comment-Date: Wed, 18 Jan 2023 20:19:25 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in libosmocore[master]: create libosmoisdn sub-library
Attention is currently required from: laforge. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/30376 to look at the new patch set (#5). Change subject: create libosmoisdn sub-library .. create libosmoisdn sub-library There are some parts of libosmogsm which are not really GSM specific, but rather ISDN bits that were inherited by GSM. This includes the I.460 multiplex as well as the core LAPD protocol. Let's move those bits to its own libosmoisdn library, before we add more ISDN specific bits to the wrong place. Backwards-compatibility is created by making libosmogsm depend on libosmoisdn, and by providing wrapper include files for source compatibility. Change-Id: Ib1a6c762322fd5047be3188b1df22408ef06aa50 --- M .gitignore M Doxyfile.codec.in M Doxyfile.coding.in M Doxyfile.core.in M Doxyfile.ctrl.in M Doxyfile.gb.in M Doxyfile.gsm.in A Doxyfile.isdn.in M Doxyfile.vty.in M Makefile.am M configure.ac M contrib/libosmocore.spec.in M debian/control M debian/copyright M debian/libosmocore.dirs A debian/libosmoisdn-doc.doc-base A debian/libosmoisdn-doc.install A debian/libosmoisdn0.install M debian/rules M include/Makefile.am M include/osmocom/gsm/i460_mux.h M include/osmocom/gsm/lapd_core.h A include/osmocom/isdn/i460_mux.h A include/osmocom/isdn/lapd_core.h M libosmogsm.pc.in A libosmoisdn.pc.in M src/Makefile.am M src/gsm/Makefile.am A src/isdn/Makefile.am R src/isdn/i460_mux.c R src/isdn/lapd_core.c A src/isdn/libosmoisdn.map M tests/Makefile.am M tests/i460_mux/i460_mux_test.c 34 files changed, 2,206 insertions(+), 311 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/76/30376/5 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30376 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib1a6c762322fd5047be3188b1df22408ef06aa50 Gerrit-Change-Number: 30376 Gerrit-PatchSet: 5 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-CC: pespin Gerrit-Attention: laforge Gerrit-MessageType: newpatchset
Change in libosmocore[master]: isdn: Add V.110 encoder/decoder
Attention is currently required from: laforge. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30762 ) Change subject: isdn: Add V.110 encoder/decoder .. Patch Set 2: (3 comments) File src/isdn/v110.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2856): https://gerrit.osmocom.org/c/libosmocore/+/30762/comment/84541867_d4cc8735 PS2, Line 1: /* V.110 frames according to ITU-T V.110 trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2856): https://gerrit.osmocom.org/c/libosmocore/+/30762/comment/0ae92df2_5c2d66d2 PS2, Line 82: ra_bits[2*8 +7] = fr->x_bits[0]; need consistent spacing around '+' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2856): https://gerrit.osmocom.org/c/libosmocore/+/30762/comment/51aee926_f58a287c PS2, Line 83: ra_bits[7*8 +7] = fr->x_bits[1]; need consistent spacing around '+' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30762 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1b5fd3847d3bfb0a0f763e0574893962ec699680 Gerrit-Change-Number: 30762 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Attention: laforge Gerrit-Comment-Date: Wed, 18 Jan 2023 19:59:32 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in libosmocore[master]: isdndlc: Fix documentation
Attention is currently required from: laforge. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30761 ) Change subject: isdndlc: Fix documentation .. Patch Set 2: (7 comments) File src/core/isdnhdlc.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2855): https://gerrit.osmocom.org/c/libosmocore/+/30761/comment/b3ca4b20_850d00e9 PS2, Line 100: excluding the CRC. please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2855): https://gerrit.osmocom.org/c/libosmocore/+/30761/comment/60f55d8f_4cf01765 PS2, Line 104: returns -OSMO_HDLC_FRAMING_ERROR. please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2855): https://gerrit.osmocom.org/c/libosmocore/+/30761/comment/3530f739_e48e10bf PS2, Line 104: returns -OSMO_HDLC_FRAMING_ERROR. Avoid multiple line dereference - prefer 'CRC.returns' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2855): https://gerrit.osmocom.org/c/libosmocore/+/30761/comment/d066a567_e5b8bbbf PS2, Line 104: returns -OSMO_HDLC_FRAMING_ERROR. need consistent spacing around '-' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2855): https://gerrit.osmocom.org/c/libosmocore/+/30761/comment/3728caef_7ea15c1b PS2, Line 105: If a CRC error is found the function returns -OSMO_HDLC_CRC_ERROR. please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2855): https://gerrit.osmocom.org/c/libosmocore/+/30761/comment/c5cbe466_d6532933 PS2, Line 105: If a CRC error is found the function returns -OSMO_HDLC_CRC_ERROR. Avoid multiple line dereference - prefer 'OSMO_HDLC_FRAMING_ERROR.If' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2855): https://gerrit.osmocom.org/c/libosmocore/+/30761/comment/a8633806_9b30c9d7 PS2, Line 105: If a CRC error is found the function returns -OSMO_HDLC_CRC_ERROR. need consistent spacing around '-' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30761 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib5def2ae3c79f408f2ee0bb4c20fba1437d30c64 Gerrit-Change-Number: 30761 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge Gerrit-Comment-Date: Wed, 18 Jan 2023 19:59:29 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in libosmocore[master]: create libosmoisdn sub-library
Attention is currently required from: laforge. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/30376 to look at the new patch set (#4). Change subject: create libosmoisdn sub-library .. create libosmoisdn sub-library There are some parts of libosmogsm which are not really GSM specific, but rather ISDN bits that were inherited by GSM. This includes the I.460 multiplex as well as the core LAPD protocol. Let's move those bits to its own libosmoisdn library, before we add more ISDN specific bits to the wrong place. Backwards-compatibility is created by making libosmogsm depend on libosmoisdn, and by providing wrapper include files for source compatibility. Change-Id: Ib1a6c762322fd5047be3188b1df22408ef06aa50 --- M .gitignore M Doxyfile.codec.in M Doxyfile.coding.in M Doxyfile.core.in M Doxyfile.ctrl.in M Doxyfile.gb.in M Doxyfile.gsm.in A Doxyfile.isdn.in M Doxyfile.vty.in M Makefile.am M configure.ac M contrib/libosmocore.spec.in M debian/control M debian/copyright M debian/libosmocore.dirs A debian/libosmoisdn-doc.doc-base A debian/libosmoisdn-doc.install A debian/libosmoisdn0.install M debian/rules M include/Makefile.am M include/osmocom/gsm/i460_mux.h M include/osmocom/gsm/lapd_core.h A include/osmocom/isdn/i460_mux.h A include/osmocom/isdn/lapd_core.h M libosmogsm.pc.in A libosmoisdn.pc.in M src/Makefile.am M src/gsm/Makefile.am A src/isdn/Makefile.am R src/isdn/i460_mux.c R src/isdn/lapd_core.c A src/isdn/libosmoisdn.map M tests/Makefile.am M tests/i460_mux/i460_mux_test.c 34 files changed, 2,206 insertions(+), 311 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/76/30376/4 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30376 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib1a6c762322fd5047be3188b1df22408ef06aa50 Gerrit-Change-Number: 30376 Gerrit-PatchSet: 4 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-CC: pespin Gerrit-Attention: laforge Gerrit-MessageType: newpatchset
Change in libosmocore[master]: isdndlc: Fix documentation
Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/30761 to look at the new patch set (#2). Change subject: isdndlc: Fix documentation .. isdndlc: Fix documentation The documentation was copied 1:1 from the Linux kernel, where it already was wrong and apparently described an earlier implementation. Change-Id: Ib5def2ae3c79f408f2ee0bb4c20fba1437d30c64 --- M src/core/isdnhdlc.c 1 file changed, 3 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/61/30761/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30761 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib5def2ae3c79f408f2ee0bb4c20fba1437d30c64 Gerrit-Change-Number: 30761 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge Gerrit-MessageType: newpatchset
Change in libosmocore[master]: Fix all references to config.h
Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31018 ) Change subject: Fix all references to config.h .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31018 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie9ea38bb009bc715b01cde4d66d181f7bec2e7bd Gerrit-Change-Number: 31018 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Attention: pespin Gerrit-Comment-Date: Wed, 18 Jan 2023 19:24:46 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: Makefile.am: Remove unexsiting all_includes variable
Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31017 ) Change subject: Makefile.am: Remove unexsiting all_includes variable .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31017 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9bc7de6f85558e55265c6cc965bc7fe97a6736ee Gerrit-Change-Number: 31017 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Attention: pespin Gerrit-Comment-Date: Wed, 18 Jan 2023 19:23:11 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: Split include/Makefile.am content into subdirs
Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31015 ) Change subject: Split include/Makefile.am content into subdirs .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31015 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I785891c2f89114bf8303c799094b637d3d25ac71 Gerrit-Change-Number: 31015 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Attention: laforge Gerrit-Attention: pespin Gerrit-Comment-Date: Wed, 18 Jan 2023 19:20:00 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: Makefile.am: Remove unexsiting all_includes variable
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31017 ) Change subject: Makefile.am: Remove unexsiting all_includes variable .. Patch Set 1: (1 comment) Patchset: PS1: Note: this all_includes variable is also present in some other projects. We may want to remove it from there too. $ ag all_include -l | wc -l 180 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31017 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9bc7de6f85558e55265c6cc965bc7fe97a6736ee Gerrit-Change-Number: 31017 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Wed, 18 Jan 2023 18:07:04 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in libosmocore[master]: Fix all references to config.h
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmocore/+/31018 )
Change subject: Fix all references to config.h
..
Fix all references to config.h
config.h is created in $(top_buildir)/config.h.
Let's make sure all CPPFLAGS add correct -Ipath includes,
and that all code includes the correct file.
Change-Id: Ie9ea38bb009bc715b01cde4d66d181f7bec2e7bd
---
M src/codec/Makefile.am
M src/coding/Makefile.am
M src/core/Makefile.am
M src/core/gsmtap_util.c
M src/core/it_q.c
M src/core/logging.c
M src/core/logging_gsmtap.c
M src/core/logging_syslog.c
M src/core/panic.c
M src/core/plugin.c
M src/core/select.c
M src/core/socket.c
M src/core/utils.c
M src/ctrl/Makefile.am
M src/gb/Makefile.am
M src/gsm/gsm0411_utils.c
M src/gsm/gsm_utils.c
M src/gsm/kdf.c
M src/gsm/mncc.c
M src/pseudotalloc/Makefile.am
M src/sim/Makefile.am
M src/usb/Makefile.am
M src/vty/Makefile.am
M src/vty/cpu_sched_vty.c
M src/vty/fsm_vty.c
M src/vty/logging_vty.c
M src/vty/stats_vty.c
M tests/Makefile.am
M tests/socket/socket_sctp_test.c
M tests/socket/socket_test.c
M tests/timer/timer_test.c
M utils/osmo-stat-dummy/osmo-stat-dummy.c
32 files changed, 34 insertions(+), 32 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/18/31018/1
diff --git a/src/codec/Makefile.am b/src/codec/Makefile.am
index c16ce9a..f05ac1f 100644
--- a/src/codec/Makefile.am
+++ b/src/codec/Makefile.am
@@ -3,7 +3,7 @@
# before making any modifications:
https://www.gnu.org/software/libtool/manual/html_node/Versioning.html
LIBVERSION=3:1:3
-AM_CPPFLAGS = -I$(top_srcdir)/include -I$(top_builddir)/include
+AM_CPPFLAGS = -I$(top_srcdir)/include -I$(top_builddir)/include
-I$(top_builddir)
AM_CFLAGS = -Wall $(TALLOC_CFLAGS)
if ENABLE_PSEUDOTALLOC
diff --git a/src/coding/Makefile.am b/src/coding/Makefile.am
index d856918..42b16e8 100644
--- a/src/coding/Makefile.am
+++ b/src/coding/Makefile.am
@@ -5,7 +5,9 @@
AM_CPPFLAGS = \
-I"$(top_srcdir)/include" \
- -I"$(top_builddir)/include"
+ -I"$(top_builddir)/include" \
+ -I"$(top_builddir)" \
+ $(NULL)
AM_CFLAGS = -Wall $(TALLOC_CFLAGS)
if ENABLE_PSEUDOTALLOC
diff --git a/src/core/Makefile.am b/src/core/Makefile.am
index 2cfb281..9b812ce 100644
--- a/src/core/Makefile.am
+++ b/src/core/Makefile.am
@@ -3,7 +3,7 @@
# before making any modifications:
https://www.gnu.org/software/libtool/manual/html_node/Versioning.html
LIBVERSION=19:0:0
-AM_CPPFLAGS = -I$(top_srcdir)/include -I$(top_builddir)/include
+AM_CPPFLAGS = -I$(top_srcdir)/include -I$(top_builddir)/include
-I$(top_builddir)
AM_CFLAGS = -Wall $(TALLOC_CFLAGS) $(PTHREAD_CFLAGS) $(LIBSCTP_CFLAGS)
$(LIBMNL_CFLAGS)
if ENABLE_PSEUDOTALLOC
diff --git a/src/core/gsmtap_util.c b/src/core/gsmtap_util.c
index 2571b85..cb7538b 100644
--- a/src/core/gsmtap_util.c
+++ b/src/core/gsmtap_util.c
@@ -19,7 +19,7 @@
*
*/
-#include "../config.h"
+#include "config.h"
#include
#include
diff --git a/src/core/it_q.c b/src/core/it_q.c
index fda6c1f..a3ff420 100644
--- a/src/core/it_q.c
+++ b/src/core/it_q.c
@@ -32,7 +32,7 @@
* and call a queue-specific callback function.
*/
-#include "../config.h"
+#include "config.h"
#ifdef HAVE_SYS_EVENTFD_H
diff --git a/src/core/logging.c b/src/core/logging.c
index ce42e4c..938c65f 100644
--- a/src/core/logging.c
+++ b/src/core/logging.c
@@ -25,7 +25,7 @@
*
* \file logging.c */
-#include "../config.h"
+#include "config.h"
#include
#include
diff --git a/src/core/logging_gsmtap.c b/src/core/logging_gsmtap.c
index cc95388..dfd059b 100644
--- a/src/core/logging_gsmtap.c
+++ b/src/core/logging_gsmtap.c
@@ -27,7 +27,7 @@
* @{
* \file logging_gsmtap.c */
-#include "../config.h"
+#include "config.h"
#include
#include
diff --git a/src/core/logging_syslog.c b/src/core/logging_syslog.c
index 2090856..1153bdf 100644
--- a/src/core/logging_syslog.c
+++ b/src/core/logging_syslog.c
@@ -22,7 +22,7 @@
* @{
* \file logging_syslog.c */
-#include "../config.h"
+#include "config.h"
#ifdef HAVE_SYSLOG_H
diff --git a/src/core/panic.c b/src/core/panic.c
index 6c92522..bbf6d08 100644
--- a/src/core/panic.c
+++ b/src/core/panic.c
@@ -27,7 +27,7 @@
#include
#include
-#include "../config.h"
+#include "config.h"
static osmo_panic_handler_t osmo_panic_handler = (void*)0;
diff --git a/src/core/plugin.c b/src/core/plugin.c
index 5f44a40..687ad40 100644
--- a/src/core/plugin.c
+++ b/src/core/plugin.c
@@ -23,7 +23,7 @@
* @{
* \file plugin.c */
-#include "../config.h"
+#include "config.h"
#if HAVE_DLFCN_H
diff --git a/src/core/select.c b/src/core/select.c
index 026d457..72f794f 100644
--- a/src/core/select.c
+++ b/src/core/select.c
@@ -36,7 +36,7 @@
#include
#include
-#include "../config.h"
+#include "config.h"
#if defined(HAVE_SYS_SELECT_H) && defined(HAVE_POLL_H)
#include
diff --git a/src/core/socket.c b/src/core/socket.c
index
Change in osmo-hnbgw[master]: fix possible leak of ue_context on UE REGISTER error
Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/31016 ) Change subject: fix possible leak of ue_context on UE REGISTER error .. Patch Set 1: (1 comment) File src/osmo-hnbgw/hnbgw_hnbap.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/31016/comment/81c3eca7_efa326d7 PS1, Line 335: ue = ue_allocated = ue_context_alloc(hnb, NULL, tmsi); what's the point in having 2 different variables here? I see no benefit and added complexity. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/31016 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Icf4b82f9a904d56332c567f7ccfb24231ee66270 Gerrit-Change-Number: 31016 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Attention: neels Gerrit-Comment-Date: Wed, 18 Jan 2023 18:00:36 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in libosmocore[master]: Add osmo_io with initial poll backend
Attention is currently required from: Hoernchen, neels, pespin, fixeria, daniel. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30934 ) Change subject: Add osmo_io with initial poll backend .. Patch Set 3: (3 comments) File src/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/a198e86e_38f0e34e PS3, Line 75: OSMO_ASSERT(0); I suggest printing an error message and exit(1) here, since this may be the result of an unexpected value in the env var https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/47b73328_8f30fc2f PS3, Line 171: allways always File src/osmo_io_poll.c: https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/a2c4b60e_98b2fb3c PS3, Line 40: what might be just me, but I find "flags" much more descriptive than "what" -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30934 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I50d73cf550d6ce8154bf827bf47408131cf5b0a0 Gerrit-Change-Number: 30934 Gerrit-PatchSet: 3 Gerrit-Owner: daniel Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Attention: Hoernchen Gerrit-Attention: neels Gerrit-Attention: pespin Gerrit-Attention: fixeria Gerrit-Attention: daniel Gerrit-Comment-Date: Wed, 18 Jan 2023 17:39:50 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in libosmocore[master]: Split include/Makefile.am content into subdirs
Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31015 ) Change subject: Split include/Makefile.am content into subdirs .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31015 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I785891c2f89114bf8303c799094b637d3d25ac71 Gerrit-Change-Number: 31015 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Attention: laforge Gerrit-Comment-Date: Wed, 18 Jan 2023 17:36:45 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-hnbgw[master]: fix msgb leak for RANAP RAB Ass. Req.
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/31009 ) Change subject: fix msgb leak for RANAP RAB Ass. Req. .. fix msgb leak for RANAP RAB Ass. Req. Fix leaked msgb introduced by the MGW support recently added, and from there copied to the UPF support added after that. Fixes leaked "RANAP Tx" msgb, one per RAB Assignment that involves an MGW or UPF proxying of user data. Related: SYS#6297 Change-Id: Ie30e880301346ffca72f98f8c467e56d622fb03f --- M src/osmo-hnbgw/mgw_fsm.c M src/osmo-hnbgw/ps_rab_ass_fsm.c 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved pespin: Looks good to me, approved diff --git a/src/osmo-hnbgw/mgw_fsm.c b/src/osmo-hnbgw/mgw_fsm.c index f09300e..764e9a7 100644 --- a/src/osmo-hnbgw/mgw_fsm.c +++ b/src/osmo-hnbgw/mgw_fsm.c @@ -256,6 +256,7 @@ LOGPFSML(fi, LOGL_DEBUG, "forwarding modified RAB-AssignmentRequest to HNB\n"); rua_tx_dt(map->hnb_ctx, map->is_ps, map->rua_ctx_id, msg->data, msg->len); + msgb_free(msg); } static void mgw_fsm_assign(struct osmo_fsm_inst *fi, uint32_t event, void *data) diff --git a/src/osmo-hnbgw/ps_rab_ass_fsm.c b/src/osmo-hnbgw/ps_rab_ass_fsm.c index b298e45..e676c2c 100644 --- a/src/osmo-hnbgw/ps_rab_ass_fsm.c +++ b/src/osmo-hnbgw/ps_rab_ass_fsm.c @@ -352,6 +352,7 @@ return; } rua_tx_dt(rab_ass->map->hnb_ctx, rab_ass->map->is_ps, rab_ass->map->rua_ctx_id, msg->data, msg->len); + msgb_free(msg); /* The request message has been forwarded. The response will be handled by a new FSM instance. * We are done. */ osmo_fsm_inst_term(rab_ass->fi, OSMO_FSM_TERM_REGULAR, NULL); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/31009 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ie30e880301346ffca72f98f8c467e56d622fb03f Gerrit-Change-Number: 31009 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: merged
Change in osmo-hnbgw[master]: fix segfault on MGCP timeout
neels has submitted this change. (
https://gerrit.osmocom.org/c/osmo-hnbgw/+/31008 )
Change subject: fix segfault on MGCP timeout
..
fix segfault on MGCP timeout
bisect shows that the segfault was introduced by using the MGCP client
pool:
e62af4d46a74af4a98dc9399082f4277fb6379e5 is the first bad commit
Author: Pau Espin Pedrol
Introduce support for libosmo-mgcp-client MGW pooling
Change-Id I371dc773b58788ee21037dc25d77f556c89c6b61
The segfault:
20230117224550365 DLMGCP DEBUG
MGCP_CONN(to-HNB)[0x61203ca0]{ST_CRCX_RESP}: Timeout of T1 (fsm.c:317)
[...]
20230117224550366 DLMGCP DEBUG
mgw-endp(mgw-fsm-14429752-0)[0x61203b20]{WAIT_MGW_RESPONSE}: Deallocated
(fsm.c:568)
20230117224550366 DMGW DEBUG
mgw(mgw-fsm-14429752-0)[0x61203820]{MGW_ST_CRCX_HNB}: Received Event
MGW_EV_MGCP_TERM (mgcp_client_endpoint_fsm.c:869)
=
==255699==ERROR: AddressSanitizer: heap-use-after-free on address
0x62b00260 at pc 0x7f282a6ee143 bp 0x7fff0d9bcae0 sp 0x7fff0d9bcad8
READ of size 8 at 0x62b00260 thread T0
#0 0x7f282a6ee142 in osmo_mgcpc_ep_client
../../../../src/osmo-mgw/src/libosmo-mgcp-client/mgcp_client_endpoint_fsm.c:223
#1 0x55e2a84f1889 in mgw_fsm_allstate_action
../../../../src/osmo-hnbgw/src/osmo-hnbgw/mgw_fsm.c:504
#2 0x7f2829d50c56 in _osmo_fsm_inst_dispatch
../../../src/libosmocore/src/fsm.c:863
#3 0x7f2829d55a08 in _osmo_fsm_inst_term
../../../src/libosmocore/src/fsm.c:962
#4 0x7f282a72679a in osmo_mgcpc_ep_fsm_check_state_chg_after_response
../../../../src/osmo-mgw/src/libosmo-mgcp-client/mgcp_client_endpoint_fsm.c:869
#5 0x7f282a6f1869 in on_failure
../../../../src/osmo-mgw/src/libosmo-mgcp-client/mgcp_client_endpoint_fsm.c:414
#6 0x7f282a727ac6 in osmo_mgcpc_ep_fsm_handle_ci_events
../../../../src/osmo-mgw/src/libosmo-mgcp-client/mgcp_client_endpoint_fsm.c:935
[...]
When a CRCX times out, MGCP_CONN fsm terminates (libosmo-mgcp-client).
In turn the parent mgw-endp fsm terminates (libosmo-mgcp-client).
This generates an MGW_EV_MGCP_TERM event to the mgw_fsm (osmo-ttcn3-hacks).
This attempts to retrieve a pointer from mgw_fsm state:
mgw_fsm_priv->mgcpc_ep->mgcp_client
where the middle one, mgcpc_ep, is the 'mgw-endp' that already deallocated
above.
To fix, add to /osmo-hnbgw/mgw_fsm.c a separate pointer to the
mgcp_client, to call mgcp_client_pool_put() on it. Do not use mgcpc_ep
to get the mgcp_client, because mgcpc_ep deallocates independently.
Related: OS#5862
Change-Id: I460d7249f4fc7edcfd94f6084fc8f933b491520c
---
M src/osmo-hnbgw/mgw_fsm.c
1 file changed, 9 insertions(+), 8 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, but someone else must approve
fixeria: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
diff --git a/src/osmo-hnbgw/mgw_fsm.c b/src/osmo-hnbgw/mgw_fsm.c
index 656066b..f09300e 100644
--- a/src/osmo-hnbgw/mgw_fsm.c
+++ b/src/osmo-hnbgw/mgw_fsm.c
@@ -115,6 +115,7 @@
struct osmo_prim_hdr *ranap_rab_ass_resp_oph;
/* MGW context */
+ struct mgcp_client *mgcpc;
struct osmo_mgcpc_ep *mgcpc_ep;
struct osmo_mgcpc_ep_ci *mgcpc_ep_ci_hnb;
struct osmo_mgcpc_ep_ci *mgcpc_ep_ci_msc;
@@ -141,7 +142,6 @@
RANAP_RAB_AssignmentRequestIEs_t *ies;
const char *epname;
struct mgcp_conn_peer mgw_info;
- struct mgcp_client *mgcp_client;
int rc;
LOGPFSML(fi, LOGL_DEBUG, "RAB-AssignmentRequest received, creating HNB
side call-leg on MGW...\n");
@@ -173,16 +173,16 @@
mgw_info.codecs[0] = CODEC_IUFP;
mgw_info.codecs_len = 1;
- mgcp_client = mgcp_client_pool_get(map->hnb_ctx->gw->mgw_pool);
- if (!mgcp_client) {
+ mgw_fsm_priv->mgcpc = mgcp_client_pool_get(map->hnb_ctx->gw->mgw_pool);
+ if (!mgw_fsm_priv->mgcpc) {
LOGPFSML(fi, LOGL_ERROR,
"cannot ensure MGW endpoint -- no MGW configured,
check configuration!\n");
osmo_fsm_inst_state_chg(fi, MGW_ST_FAILURE, 0, 0);
return;
}
- epname = mgcp_client_rtpbridge_wildcard(mgcp_client);
+ epname = mgcp_client_rtpbridge_wildcard(mgw_fsm_priv->mgcpc);
mgw_fsm_priv->mgcpc_ep =
- osmo_mgcpc_ep_alloc(fi, MGW_EV_MGCP_TERM, mgcp_client,
mgw_fsm_T_defs, fi->id, "%s", epname);
+ osmo_mgcpc_ep_alloc(fi, MGW_EV_MGCP_TERM, mgw_fsm_priv->mgcpc,
mgw_fsm_T_defs, fi->id, "%s", epname);
mgw_fsm_priv->mgcpc_ep_ci_hnb =
osmo_mgcpc_ep_ci_add(mgw_fsm_priv->mgcpc_ep, "to-HNB");
osmo_mgcpc_ep_ci_request(mgw_fsm_priv->mgcpc_ep_ci_hnb, MGCP_VERB_CRCX,
_info, fi, MGW_EV_MGCP_OK,
@@ -496,13 +496,14 @@
static void mgw_fsm_allstate_action(struct osmo_fsm_inst *fi, uint32_t event,
void *data)
{
struct mgw_fsm_priv *mgw_fsm_priv =
Change in libosmocore[master]: Move src/*.{c,h} to src/core/
pespin has submitted this change. (
https://gerrit.osmocom.org/c/libosmocore/+/31013 )
Change subject: Move src/*.{c,h} to src/core/
..
Move src/*.{c,h} to src/core/
This way we have all libosmocore.so in an own subdir instead of having
lots of files in the parent dir, which also contains subdirs to other
libraries.
This also matches the schema under include/osmocom/.
Change-Id: I6c76fafebdd5e961aed88bbecd2c16bc69d580e2
---
M Doxyfile.core.in
M Makefile.am
M configure.ac
M debian/copyright
M src/Makefile.am
M src/codec/Makefile.am
M src/coding/Makefile.am
A src/core/Makefile.am
R src/core/application.c
R src/core/backtrace.c
R src/core/base64.c
R src/core/bitcomp.c
R src/core/bits.c
R src/core/bitvec.c
R src/core/context.c
R src/core/conv.c
R src/core/conv_acc.c
R src/core/conv_acc_generic.c
R src/core/conv_acc_neon.c
R src/core/conv_acc_neon_impl.h
R src/core/conv_acc_sse.c
R src/core/conv_acc_sse_avx.c
R src/core/conv_acc_sse_impl.h
R src/core/counter.c
R src/core/crc16.c
R src/core/crcXXgen.c.tpl
R src/core/exec.c
R src/core/fsm.c
R src/core/gsmtap_util.c
R src/core/isdnhdlc.c
R src/core/it_q.c
R src/core/logging.c
R src/core/logging_gsmtap.c
R src/core/logging_syslog.c
R src/core/logging_systemd.c
R src/core/loggingrb.c
R src/core/macaddr.c
R src/core/mnl.c
R src/core/msgb.c
R src/core/msgfile.c
R src/core/panic.c
R src/core/plugin.c
R src/core/prbs.c
R src/core/prim.c
R src/core/probes.d
R src/core/rate_ctr.c
R src/core/rbtree.c
R src/core/select.c
R src/core/sercomm.c
R src/core/serial.c
R src/core/signal.c
R src/core/sockaddr_str.c
R src/core/socket.c
R src/core/stat_item.c
R src/core/stat_item_internal.h
R src/core/stats.c
R src/core/stats_statsd.c
R src/core/stats_tcp.c
R src/core/strrb.c
R src/core/tdef.c
R src/core/thread.c
R src/core/time_cc.c
R src/core/timer.c
R src/core/timer_clockgettime.c
R src/core/timer_gettimeofday.c
R src/core/use_count.c
R src/core/utils.c
R src/core/write_queue.c
M src/ctrl/Makefile.am
M src/gb/Makefile.am
M src/gsm/Makefile.am
M src/sim/Makefile.am
M src/usb/Makefile.am
M src/vty/Makefile.am
M tests/Makefile.am
M utils/Makefile.am
M utils/osmo-stat-dummy/Makefile.am
77 files changed, 148 insertions(+), 142 deletions(-)
Approvals:
Jenkins Builder: Verified
osmith: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
diff --git a/Doxyfile.core.in b/Doxyfile.core.in
index c2bfcd5..29507e0 100644
--- a/Doxyfile.core.in
+++ b/Doxyfile.core.in
@@ -610,7 +610,7 @@
# directories like "/usr/src/myproject". Separate the files or directories
# with spaces.
-INPUT = @srcdir@/include/osmocom/core @srcdir@/src
+INPUT = @srcdir@/include/osmocom/core @srcdir@/src/core
# This tag can be used to specify the character encoding of the source files
# that doxygen parses. Internally doxygen uses the UTF-8 encoding, which is
diff --git a/Makefile.am b/Makefile.am
index b3663ba..4347807 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -4,15 +4,6 @@
SUBDIRS = \
include \
src \
- src/vty \
- src/codec \
- src/gsm \
- src/coding \
- src/gb \
- src/ctrl \
- src/sim \
- src/pseudotalloc \
- src/usb \
utils \
tapset \
tests \
@@ -90,8 +81,8 @@
$(top_builddir)/doc/libosmocore.tag.prep: $(top_builddir)/Doxyfile.core \
$(top_srcdir)/include/osmocom/core/*.h \
- $(top_srcdir)/src/*.[hc] \
- $(top_srcdir)/src/crcXXgen.c.tpl \
+ $(top_srcdir)/src/core/*.[hc] \
+ $(top_srcdir)/src/core/crcXXgen.c.tpl \
$(top_srcdir)/src/pseudotalloc/*.[hc]
rm -rf $(top_builddir)/doc/core; mkdir -p $(top_builddir)/doc/core
rm -rf $(top_builddir)/doc/libosmocore.map
diff --git a/configure.ac b/configure.ac
index 3d9492e..5f70fca 100644
--- a/configure.ac
+++ b/configure.ac
@@ -586,6 +586,7 @@
libosmousb.pc
include/Makefile
src/Makefile
+ src/core/Makefile
src/vty/Makefile
src/codec/Makefile
src/coding/Makefile
diff --git a/debian/copyright b/debian/copyright
index 79c5876..31a2946 100644
--- a/debian/copyright
+++ b/debian/copyright
@@ -13,23 +13,23 @@
Files: include/osmocom/core/loggingrb.h
include/osmocom/core/strrb.h
- src/strrb.c
- src/loggingrb.c
+ src/core/strrb.c
+ src/core/loggingrb.c
Copyright: 2012-2013 Katerina Barone-Adesi
License: GPL-2+
Files: include/osmocom/core/linuxrbtree.h
- src/rbtree.c
+ src/core/rbtree.c
Copyright: 1999 Andrea Arcangeli
2002 David Woodhouse
License: GPL-2+
Files: include/osmocom/core/crc16.h
- src/crc16.c
+ src/core/crc16.c
Copyright: 2005 Ben Gardner
License: GPL-2
-Files: src/utils.c
+Files: src/core/utils.c
Copyright: 2011 Harald Welte
2011 Sylvain Munaut
2014 Nils O.
Change in libosmocore[master]: src/core/Makefile.am: reformat SOURCES list
pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31014 ) Change subject: src/core/Makefile.am: reformat SOURCES list .. src/core/Makefile.am: reformat SOURCES list Have one per line and order items in an alphabetical order. Change-Id: Ib14396e9a1a744cdad2f35f7241eb2ab3212c0cb --- M src/core/Makefile.am 1 file changed, 62 insertions(+), 23 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/core/Makefile.am b/src/core/Makefile.am index 2c73af6..2cfb281 100644 --- a/src/core/Makefile.am +++ b/src/core/Makefile.am @@ -12,29 +12,68 @@ lib_LTLIBRARIES = libosmocore.la -libosmocore_la_LIBADD = $(BACKTRACE_LIB) $(TALLOC_LIBS) $(LIBRARY_RT) $(PTHREAD_LIBS) $(LIBSCTP_LIBS) -libosmocore_la_SOURCES = context.c timer.c timer_gettimeofday.c timer_clockgettime.c \ -select.c signal.c msgb.c bits.c \ -bitvec.c bitcomp.c counter.c fsm.c \ -write_queue.c utils.c socket.c \ -logging.c logging_syslog.c logging_gsmtap.c rate_ctr.c \ -gsmtap_util.c crc16.c panic.c backtrace.c \ -conv.c application.c rbtree.c strrb.c \ -loggingrb.c crc8gen.c crc16gen.c crc32gen.c crc64gen.c \ -macaddr.c stat_item.c stats.c stats_statsd.c prim.c \ -stats_tcp.c \ -conv_acc.c conv_acc_generic.c sercomm.c prbs.c \ -isdnhdlc.c \ -tdef.c \ -thread.c \ -time_cc.c \ -sockaddr_str.c \ -use_count.c \ -exec.c \ -it_q.c \ -probes.d \ -base64.c \ -$(NULL) +libosmocore_la_LIBADD = \ + $(BACKTRACE_LIB) \ + $(TALLOC_LIBS) \ + $(LIBRARY_RT) \ + $(PTHREAD_LIBS) \ + $(LIBSCTP_LIBS) \ + $(NULL) + +libosmocore_la_SOURCES = \ + application.c \ + backtrace.c \ + base64.c \ + bits.c \ + bitvec.c \ + bitcomp.c \ + context.c \ + conv.c \ + conv_acc.c \ + conv_acc_generic.c \ + counter.c \ + crc16.c \ + crc8gen.c \ + crc16gen.c \ + crc32gen.c \ + crc64gen.c \ + exec.c \ + fsm.c \ + gsmtap_util.c \ + isdnhdlc.c \ + it_q.c \ + logging.c \ + logging_syslog.c \ + logging_gsmtap.c \ + loggingrb.c \ + macaddr.c \ + msgb.c \ + panic.c \ + prbs.c \ + prim.c \ + rate_ctr.c \ + rbtree.c \ + select.c \ + sercomm.c \ + signal.c \ + sockaddr_str.c \ + socket.c \ + stat_item.c \ + stats.c \ + stats_statsd.c \ + stats_tcp.c \ + strrb.c \ + tdef.c \ + thread.c \ + time_cc.c \ + timer.c \ + timer_gettimeofday.c \ + timer_clockgettime.c \ + use_count.c \ + utils.c \ + write_queue.c \ + probes.d \ + $(NULL) if HAVE_SSSE3 libosmocore_la_SOURCES += conv_acc_sse.c -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31014 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib14396e9a1a744cdad2f35f7241eb2ab3212c0cb Gerrit-Change-Number: 31014 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged
Change in libosmocore[master]: Split include/Makefile.am content into subdirs
Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31015 ) Change subject: Split include/Makefile.am content into subdirs .. Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/31015/comment/eb8a9d14_2b8017a1 PS1, Line 11: Furthermoe spelling -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31015 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I785891c2f89114bf8303c799094b637d3d25ac71 Gerrit-Change-Number: 31015 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Attention: pespin Gerrit-Comment-Date: Wed, 18 Jan 2023 17:17:11 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: src/core/Makefile.am: reformat SOURCES list
Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31014 ) Change subject: src/core/Makefile.am: reformat SOURCES list .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31014 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib14396e9a1a744cdad2f35f7241eb2ab3212c0cb Gerrit-Change-Number: 31014 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Attention: pespin Gerrit-Comment-Date: Wed, 18 Jan 2023 17:16:34 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: Move src/*.{c,h} to src/core/
Attention is currently required from: pespin, fixeria.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/31013 )
Change subject: Move src/*.{c,h} to src/core/
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31013
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I6c76fafebdd5e961aed88bbecd2c16bc69d580e2
Gerrit-Change-Number: 31013
Gerrit-PatchSet: 3
Gerrit-Owner: pespin
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: laforge
Gerrit-Reviewer: osmith
Gerrit-Attention: pespin
Gerrit-Attention: fixeria
Gerrit-Comment-Date: Wed, 18 Jan 2023 17:16:24 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Change in libosmocore[master]: Split include/Makefile.am content into subdirs
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/31015 ) Change subject: Split include/Makefile.am content into subdirs .. Split include/Makefile.am content into subdirs When someone is modifying a given library there's no need to be looking at a common file contains tons of lines from different libraries. Furthermoe, this removes the need of "nobase" autofoo prefix, hence following the usual directive of having one Makefile per directory. Change-Id: I785891c2f89114bf8303c799094b637d3d25ac71 --- M configure.ac M include/Makefile.am A include/osmocom/Makefile.am A include/osmocom/codec/Makefile.am A include/osmocom/coding/Makefile.am A include/osmocom/core/Makefile.am A include/osmocom/crypt/Makefile.am A include/osmocom/ctrl/Makefile.am A include/osmocom/gprs/Makefile.am A include/osmocom/gprs/protocol/Makefile.am A include/osmocom/gsm/Makefile.am A include/osmocom/gsm/protocol/Makefile.am A include/osmocom/sim/Makefile.am A include/osmocom/usb/Makefile.am A include/osmocom/vty/Makefile.am 15 files changed, 282 insertions(+), 225 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/15/31015/1 diff --git a/configure.ac b/configure.ac index 5f70fca..9c9681d 100644 --- a/configure.ac +++ b/configure.ac @@ -585,6 +585,19 @@ libosmosim.pc libosmousb.pc include/Makefile + include/osmocom/Makefile + include/osmocom/codec/Makefile + include/osmocom/coding/Makefile + include/osmocom/core/Makefile + include/osmocom/crypt/Makefile + include/osmocom/ctrl/Makefile + include/osmocom/gprs/Makefile + include/osmocom/gprs/protocol/Makefile + include/osmocom/gsm/Makefile + include/osmocom/gsm/protocol/Makefile + include/osmocom/sim/Makefile + include/osmocom/usb/Makefile + include/osmocom/vty/Makefile src/Makefile src/core/Makefile src/vty/Makefile diff --git a/include/Makefile.am b/include/Makefile.am index a234014..77b4ddc 100644 --- a/include/Makefile.am +++ b/include/Makefile.am @@ -1,225 +1 @@ -BUILT_SOURCES = osmocom/gsm/gsm0503.h - -nobase_include_HEADERS = \ - osmocom/codec/ecu.h \ - osmocom/codec/codec.h \ - osmocom/codec/gsm610_bits.h \ - osmocom/core/application.h \ - osmocom/core/backtrace.h \ - osmocom/core/base64.h \ - osmocom/core/bit16gen.h \ - osmocom/core/bit32gen.h \ - osmocom/core/bit64gen.h \ - osmocom/core/bits.h \ - osmocom/core/bitvec.h \ - osmocom/core/bitcomp.h \ - osmocom/core/byteswap.h \ - osmocom/core/conv.h \ - osmocom/core/counter.h \ - osmocom/core/crc16.h \ - osmocom/core/crc16gen.h \ - osmocom/core/crc32gen.h \ - osmocom/core/crc64gen.h \ - osmocom/core/crc8gen.h \ - osmocom/core/crcgen.h \ - osmocom/core/endian.h \ - osmocom/core/defs.h \ - osmocom/core/exec.h \ - osmocom/core/fsm.h \ - osmocom/core/gsmtap.h \ - osmocom/core/gsmtap_util.h \ - osmocom/core/hash.h \ - osmocom/core/hashtable.h \ - osmocom/core/isdnhdlc.h \ - osmocom/core/it_q.h \ - osmocom/core/linuxlist.h \ - osmocom/core/linuxrbtree.h \ - osmocom/core/log2.h \ - osmocom/core/logging.h \ - osmocom/core/loggingrb.h \ - osmocom/core/stats.h \ - osmocom/core/macaddr.h \ - osmocom/core/msgb.h \ - osmocom/core/panic.h \ - osmocom/core/prbs.h \ - osmocom/core/prim.h \ - osmocom/core/process.h \ - osmocom/core/rate_ctr.h \ - osmocom/core/stat_item.h \ - osmocom/core/stats_tcp.h \ - osmocom/core/select.h \ - osmocom/core/sercomm.h \ - osmocom/core/signal.h \ - osmocom/core/socket.h \ - osmocom/core/statistics.h \ - osmocom/core/strrb.h \ - osmocom/core/talloc.h \ - osmocom/core/tdef.h \ - osmocom/core/thread.h \ - osmocom/core/timer.h \ -
Change in libosmocore[master]: src/core/Makefile.am: reformat SOURCES list
Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31014 ) Change subject: src/core/Makefile.am: reformat SOURCES list .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31014 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib14396e9a1a744cdad2f35f7241eb2ab3212c0cb Gerrit-Change-Number: 31014 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Attention: pespin Gerrit-Comment-Date: Wed, 18 Jan 2023 16:36:04 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: Move src/*.{c,h} to src/core/
Attention is currently required from: laforge, pespin, fixeria.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/31013 )
Change subject: Move src/*.{c,h} to src/core/
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31013
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I6c76fafebdd5e961aed88bbecd2c16bc69d580e2
Gerrit-Change-Number: 31013
Gerrit-PatchSet: 3
Gerrit-Owner: pespin
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: laforge
Gerrit-Reviewer: osmith
Gerrit-Attention: laforge
Gerrit-Attention: pespin
Gerrit-Attention: fixeria
Gerrit-Comment-Date: Wed, 18 Jan 2023 16:34:52 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Change in libosmocore[master]: src/core/Makefile.am: reformat SOURCES list
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/31014 ) Change subject: src/core/Makefile.am: reformat SOURCES list .. src/core/Makefile.am: reformat SOURCES list Have one per line and order items in an alphabetical order. Change-Id: Ib14396e9a1a744cdad2f35f7241eb2ab3212c0cb --- M src/core/Makefile.am 1 file changed, 62 insertions(+), 23 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/14/31014/1 diff --git a/src/core/Makefile.am b/src/core/Makefile.am index 2c73af6..2cfb281 100644 --- a/src/core/Makefile.am +++ b/src/core/Makefile.am @@ -12,29 +12,68 @@ lib_LTLIBRARIES = libosmocore.la -libosmocore_la_LIBADD = $(BACKTRACE_LIB) $(TALLOC_LIBS) $(LIBRARY_RT) $(PTHREAD_LIBS) $(LIBSCTP_LIBS) -libosmocore_la_SOURCES = context.c timer.c timer_gettimeofday.c timer_clockgettime.c \ -select.c signal.c msgb.c bits.c \ -bitvec.c bitcomp.c counter.c fsm.c \ -write_queue.c utils.c socket.c \ -logging.c logging_syslog.c logging_gsmtap.c rate_ctr.c \ -gsmtap_util.c crc16.c panic.c backtrace.c \ -conv.c application.c rbtree.c strrb.c \ -loggingrb.c crc8gen.c crc16gen.c crc32gen.c crc64gen.c \ -macaddr.c stat_item.c stats.c stats_statsd.c prim.c \ -stats_tcp.c \ -conv_acc.c conv_acc_generic.c sercomm.c prbs.c \ -isdnhdlc.c \ -tdef.c \ -thread.c \ -time_cc.c \ -sockaddr_str.c \ -use_count.c \ -exec.c \ -it_q.c \ -probes.d \ -base64.c \ -$(NULL) +libosmocore_la_LIBADD = \ + $(BACKTRACE_LIB) \ + $(TALLOC_LIBS) \ + $(LIBRARY_RT) \ + $(PTHREAD_LIBS) \ + $(LIBSCTP_LIBS) \ + $(NULL) + +libosmocore_la_SOURCES = \ + application.c \ + backtrace.c \ + base64.c \ + bits.c \ + bitvec.c \ + bitcomp.c \ + context.c \ + conv.c \ + conv_acc.c \ + conv_acc_generic.c \ + counter.c \ + crc16.c \ + crc8gen.c \ + crc16gen.c \ + crc32gen.c \ + crc64gen.c \ + exec.c \ + fsm.c \ + gsmtap_util.c \ + isdnhdlc.c \ + it_q.c \ + logging.c \ + logging_syslog.c \ + logging_gsmtap.c \ + loggingrb.c \ + macaddr.c \ + msgb.c \ + panic.c \ + prbs.c \ + prim.c \ + rate_ctr.c \ + rbtree.c \ + select.c \ + sercomm.c \ + signal.c \ + sockaddr_str.c \ + socket.c \ + stat_item.c \ + stats.c \ + stats_statsd.c \ + stats_tcp.c \ + strrb.c \ + tdef.c \ + thread.c \ + time_cc.c \ + timer.c \ + timer_gettimeofday.c \ + timer_clockgettime.c \ + use_count.c \ + utils.c \ + write_queue.c \ + probes.d \ + $(NULL) if HAVE_SSSE3 libosmocore_la_SOURCES += conv_acc_sse.c -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31014 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib14396e9a1a744cdad2f35f7241eb2ab3212c0cb Gerrit-Change-Number: 31014 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange
Change in osmo-bts[master]: contrib/jenkins: build libosmo-abis without dahdi
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31012 ) Change subject: contrib/jenkins: build libosmo-abis without dahdi .. contrib/jenkins: build libosmo-abis without dahdi Looks like this is not needed, so make the jenkins build work without installing dahdi-source. Related: OS#5863 Change-Id: I61c483983a4793e0429bb37804dee0a128125daf --- M contrib/jenkins_bts_trx.sh M contrib/jenkins_lc15.sh M contrib/jenkins_oc2g.sh M contrib/jenkins_oct.sh M contrib/jenkins_oct_and_bts_trx.sh M contrib/jenkins_sysmobts.sh 6 files changed, 6 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/contrib/jenkins_bts_trx.sh b/contrib/jenkins_bts_trx.sh index a98a633..9ac820d 100755 --- a/contrib/jenkins_bts_trx.sh +++ b/contrib/jenkins_bts_trx.sh @@ -9,7 +9,7 @@ osmo-build-dep.sh libosmocore "" --disable-doxygen -osmo-build-dep.sh libosmo-abis +osmo-build-dep.sh libosmo-abis "" --disable-dahdi osmo-build-dep.sh libosmo-netif "" --disable-doxygen cd "$deps" diff --git a/contrib/jenkins_lc15.sh b/contrib/jenkins_lc15.sh index 4454f65..89dd54b 100755 --- a/contrib/jenkins_lc15.sh +++ b/contrib/jenkins_lc15.sh @@ -9,7 +9,7 @@ export PKG_CONFIG_PATH="$inst/lib/pkgconfig:$PKG_CONFIG_PATH" export LD_LIBRARY_PATH="$inst/lib" -osmo-build-dep.sh libosmo-abis +osmo-build-dep.sh libosmo-abis "" --disable-dahdi osmo-build-dep.sh libosmo-netif "" --disable-doxygen cd "$deps" diff --git a/contrib/jenkins_oc2g.sh b/contrib/jenkins_oc2g.sh index af2f8a0..e4795cf 100755 --- a/contrib/jenkins_oc2g.sh +++ b/contrib/jenkins_oc2g.sh @@ -9,7 +9,7 @@ export PKG_CONFIG_PATH="$inst/lib/pkgconfig:$PKG_CONFIG_PATH" export LD_LIBRARY_PATH="$inst/lib" -osmo-build-dep.sh libosmo-abis +osmo-build-dep.sh libosmo-abis "" --disable-dahdi osmo-build-dep.sh libosmo-netif "" --disable-doxygen cd "$deps" diff --git a/contrib/jenkins_oct.sh b/contrib/jenkins_oct.sh index 0984e20..d1b6aee 100755 --- a/contrib/jenkins_oct.sh +++ b/contrib/jenkins_oct.sh @@ -9,7 +9,7 @@ export PKG_CONFIG_PATH="$inst/lib/pkgconfig:$PKG_CONFIG_PATH" export LD_LIBRARY_PATH="$inst/lib" -osmo-build-dep.sh libosmo-abis +osmo-build-dep.sh libosmo-abis "" --disable-dahdi osmo-build-dep.sh libosmo-netif "" --disable-doxygen cd "$deps" diff --git a/contrib/jenkins_oct_and_bts_trx.sh b/contrib/jenkins_oct_and_bts_trx.sh index 3f4efae..f188147 100755 --- a/contrib/jenkins_oct_and_bts_trx.sh +++ b/contrib/jenkins_oct_and_bts_trx.sh @@ -9,7 +9,7 @@ osmo-build-dep.sh libosmocore "" --disable-doxygen -osmo-build-dep.sh libosmo-abis +osmo-build-dep.sh libosmo-abis "" --disable-dahdi osmo-build-dep.sh libosmo-netif "" --disable-doxygen cd "$deps" diff --git a/contrib/jenkins_sysmobts.sh b/contrib/jenkins_sysmobts.sh index 2e5ab8d..87a98f3 100755 --- a/contrib/jenkins_sysmobts.sh +++ b/contrib/jenkins_sysmobts.sh @@ -9,7 +9,7 @@ export PKG_CONFIG_PATH="$inst/lib/pkgconfig:$PKG_CONFIG_PATH" export LD_LIBRARY_PATH="$inst/lib" -osmo-build-dep.sh libosmo-abis +osmo-build-dep.sh libosmo-abis "" --disable-dahdi osmo-build-dep.sh libosmo-netif "" --disable-doxygen cd "$deps" -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31012 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I61c483983a4793e0429bb37804dee0a128125daf Gerrit-Change-Number: 31012 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Reviewer: tnt Gerrit-MessageType: merged
Change in osmo-bts[master]: contrib/jenkins: build libosmo-abis without dahdi
Attention is currently required from: tnt. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31012 ) Change subject: contrib/jenkins: build libosmo-abis without dahdi .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31012 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I61c483983a4793e0429bb37804dee0a128125daf Gerrit-Change-Number: 31012 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Reviewer: tnt Gerrit-Attention: tnt Gerrit-Comment-Date: Wed, 18 Jan 2023 16:28:41 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in docker-playground[master]: ttcn3-bts-test: replace subnets during 'make cfg'
osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/31011 ) Change subject: ttcn3-bts-test: replace subnets during 'make cfg' .. ttcn3-bts-test: replace subnets during 'make cfg' Make ttcn3-bts-test work as expected again by replacing the subnets hardcoded in the confmerge files and Makefile. Related: OS#5802 Change-Id: I733619f80b4e2456da070649634d3c942bb6d95f --- M jenkins-common.sh M ttcn3-bts-test/jenkins.sh 2 files changed, 7 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/jenkins-common.sh b/jenkins-common.sh index 08d4e4e..ef0a3fc 100644 --- a/jenkins-common.sh +++ b/jenkins-common.sh @@ -270,10 +270,13 @@ "$VOL_BASE_DIR" \ -name '*.cfg' -o \ -name '*.conf' -o \ + -name '*.confmerge' -o \ + -name '*.inc' -o \ -name '*.scm' -o \ -name '*.sh' -o \ -name '*.txt' -o \ - -name '*.yaml' \ + -name '*.yaml' -o \ + -name 'Makefile' \ )" if [ -z "$files" ]; then diff --git a/ttcn3-bts-test/jenkins.sh b/ttcn3-bts-test/jenkins.sh index 691c753..7d4d3dc 100755 --- a/ttcn3-bts-test/jenkins.sh +++ b/ttcn3-bts-test/jenkins.sh @@ -140,7 +140,9 @@ $VOL_BASE_DIR/bts-tester-hopping/BTS_Tests.cfg.inc # (re)generate the configuration files -make cfg +cp Makefile $VOL_BASE_DIR/Makefile +network_replace_subnet_in_configs +make -f $VOL_BASE_DIR/Makefile cfg mkdir $VOL_BASE_DIR/bsc cp generic/osmo-bsc.gen.cfg $VOL_BASE_DIR/bsc/ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31011 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I733619f80b4e2456da070649634d3c942bb6d95f Gerrit-Change-Number: 31011 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged
Change in libosmocore[master]: Move src/*.{c,h} to src/core/
Attention is currently required from: pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmocore/+/31013
to look at the new patch set (#3).
Change subject: Move src/*.{c,h} to src/core/
..
Move src/*.{c,h} to src/core/
This way we have all libosmocore.so in an own subdir instead of having
lots of files in the parent dir, which also contains subdirs to other
libraries.
This also matches the schema under include/osmocom/.
Change-Id: I6c76fafebdd5e961aed88bbecd2c16bc69d580e2
---
M Doxyfile.core.in
M Makefile.am
M configure.ac
M debian/copyright
M src/Makefile.am
M src/codec/Makefile.am
M src/coding/Makefile.am
A src/core/Makefile.am
R src/core/application.c
R src/core/backtrace.c
R src/core/base64.c
R src/core/bitcomp.c
R src/core/bits.c
R src/core/bitvec.c
R src/core/context.c
R src/core/conv.c
R src/core/conv_acc.c
R src/core/conv_acc_generic.c
R src/core/conv_acc_neon.c
R src/core/conv_acc_neon_impl.h
R src/core/conv_acc_sse.c
R src/core/conv_acc_sse_avx.c
R src/core/conv_acc_sse_impl.h
R src/core/counter.c
R src/core/crc16.c
R src/core/crcXXgen.c.tpl
R src/core/exec.c
R src/core/fsm.c
R src/core/gsmtap_util.c
R src/core/isdnhdlc.c
R src/core/it_q.c
R src/core/logging.c
R src/core/logging_gsmtap.c
R src/core/logging_syslog.c
R src/core/logging_systemd.c
R src/core/loggingrb.c
R src/core/macaddr.c
R src/core/mnl.c
R src/core/msgb.c
R src/core/msgfile.c
R src/core/panic.c
R src/core/plugin.c
R src/core/prbs.c
R src/core/prim.c
R src/core/probes.d
R src/core/rate_ctr.c
R src/core/rbtree.c
R src/core/select.c
R src/core/sercomm.c
R src/core/serial.c
R src/core/signal.c
R src/core/sockaddr_str.c
R src/core/socket.c
R src/core/stat_item.c
R src/core/stat_item_internal.h
R src/core/stats.c
R src/core/stats_statsd.c
R src/core/stats_tcp.c
R src/core/strrb.c
R src/core/tdef.c
R src/core/thread.c
R src/core/time_cc.c
R src/core/timer.c
R src/core/timer_clockgettime.c
R src/core/timer_gettimeofday.c
R src/core/use_count.c
R src/core/utils.c
R src/core/write_queue.c
M src/ctrl/Makefile.am
M src/gb/Makefile.am
M src/gsm/Makefile.am
M src/sim/Makefile.am
M src/usb/Makefile.am
M src/vty/Makefile.am
M tests/Makefile.am
M utils/Makefile.am
M utils/osmo-stat-dummy/Makefile.am
77 files changed, 148 insertions(+), 142 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/13/31013/3
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31013
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I6c76fafebdd5e961aed88bbecd2c16bc69d580e2
Gerrit-Change-Number: 31013
Gerrit-PatchSet: 3
Gerrit-Owner: pespin
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: pespin
Gerrit-MessageType: newpatchset
Change in libosmocore[master]: Move src/*.{c,h} to src/core/
Attention is currently required from: pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmocore/+/31013
to look at the new patch set (#2).
Change subject: Move src/*.{c,h} to src/core/
..
Move src/*.{c,h} to src/core/
This way we have all libosmocore.so in an own subdir instead of having
lots of files in the parent dir, which also contains subdirs to other
libraries.
This also matches the schema under include/osmocom/.
Change-Id: I6c76fafebdd5e961aed88bbecd2c16bc69d580e2
---
M Doxyfile.core.in
M Makefile.am
M configure.ac
M debian/copyright
M src/Makefile.am
M src/codec/Makefile.am
M src/coding/Makefile.am
A src/core/Makefile.am
R src/core/application.c
R src/core/backtrace.c
R src/core/base64.c
R src/core/bitcomp.c
R src/core/bits.c
R src/core/bitvec.c
R src/core/context.c
R src/core/conv.c
R src/core/conv_acc.c
R src/core/conv_acc_generic.c
R src/core/conv_acc_neon.c
R src/core/conv_acc_neon_impl.h
R src/core/conv_acc_sse.c
R src/core/conv_acc_sse_avx.c
R src/core/conv_acc_sse_impl.h
R src/core/counter.c
R src/core/crc16.c
R src/core/crcXXgen.c.tpl
R src/core/exec.c
R src/core/fsm.c
R src/core/gsmtap_util.c
R src/core/isdnhdlc.c
R src/core/it_q.c
R src/core/logging.c
R src/core/logging_gsmtap.c
R src/core/logging_syslog.c
R src/core/logging_systemd.c
R src/core/loggingrb.c
R src/core/macaddr.c
R src/core/mnl.c
R src/core/msgb.c
R src/core/msgfile.c
R src/core/panic.c
R src/core/plugin.c
R src/core/prbs.c
R src/core/prim.c
R src/core/probes.d
R src/core/rate_ctr.c
R src/core/rbtree.c
R src/core/select.c
R src/core/sercomm.c
R src/core/serial.c
R src/core/signal.c
R src/core/sockaddr_str.c
R src/core/socket.c
R src/core/stat_item.c
R src/core/stat_item_internal.h
R src/core/stats.c
R src/core/stats_statsd.c
R src/core/stats_tcp.c
R src/core/strrb.c
R src/core/tdef.c
R src/core/thread.c
R src/core/time_cc.c
R src/core/timer.c
R src/core/timer_clockgettime.c
R src/core/timer_gettimeofday.c
R src/core/use_count.c
R src/core/utils.c
R src/core/write_queue.c
M src/ctrl/Makefile.am
M src/gb/Makefile.am
M src/gsm/Makefile.am
M src/sim/Makefile.am
M src/usb/Makefile.am
M src/vty/Makefile.am
M tests/Makefile.am
M utils/Makefile.am
M utils/osmo-stat-dummy/Makefile.am
77 files changed, 146 insertions(+), 140 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/13/31013/2
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31013
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I6c76fafebdd5e961aed88bbecd2c16bc69d580e2
Gerrit-Change-Number: 31013
Gerrit-PatchSet: 2
Gerrit-Owner: pespin
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: pespin
Gerrit-MessageType: newpatchset
Change in libosmocore[master]: Move src/*.{c,h} to src/core/
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmocore/+/31013 )
Change subject: Move src/*.{c,h} to src/core/
..
Move src/*.{c,h} to src/core/
This way we have all libosmocore.so in an own subdir instead of having
lots of files in the parent dir, which also contains subdirs to other
libraries.
This also matches the schema under include/osmocom/.
Change-Id: I6c76fafebdd5e961aed88bbecd2c16bc69d580e2
---
M Makefile.am
M configure.ac
M src/Makefile.am
M src/codec/Makefile.am
M src/coding/Makefile.am
A src/core/Makefile.am
R src/core/application.c
R src/core/backtrace.c
R src/core/base64.c
R src/core/bitcomp.c
R src/core/bits.c
R src/core/bitvec.c
R src/core/context.c
R src/core/conv.c
R src/core/conv_acc.c
R src/core/conv_acc_generic.c
R src/core/conv_acc_neon.c
R src/core/conv_acc_neon_impl.h
R src/core/conv_acc_sse.c
R src/core/conv_acc_sse_avx.c
R src/core/conv_acc_sse_impl.h
R src/core/counter.c
R src/core/crc16.c
R src/core/crcXXgen.c.tpl
R src/core/exec.c
R src/core/fsm.c
R src/core/gsmtap_util.c
R src/core/isdnhdlc.c
R src/core/it_q.c
R src/core/logging.c
R src/core/logging_gsmtap.c
R src/core/logging_syslog.c
R src/core/logging_systemd.c
R src/core/loggingrb.c
R src/core/macaddr.c
R src/core/mnl.c
R src/core/msgb.c
R src/core/msgfile.c
R src/core/panic.c
R src/core/plugin.c
R src/core/prbs.c
R src/core/prim.c
R src/core/probes.d
R src/core/rate_ctr.c
R src/core/rbtree.c
R src/core/select.c
R src/core/sercomm.c
R src/core/serial.c
R src/core/signal.c
R src/core/sockaddr_str.c
R src/core/socket.c
R src/core/stat_item.c
R src/core/stat_item_internal.h
R src/core/stats.c
R src/core/stats_statsd.c
R src/core/stats_tcp.c
R src/core/strrb.c
R src/core/tdef.c
R src/core/thread.c
R src/core/time_cc.c
R src/core/timer.c
R src/core/timer_clockgettime.c
R src/core/timer_gettimeofday.c
R src/core/use_count.c
R src/core/utils.c
R src/core/write_queue.c
M src/ctrl/Makefile.am
M src/gb/Makefile.am
M src/gsm/Makefile.am
M src/sim/Makefile.am
M src/usb/Makefile.am
M src/vty/Makefile.am
M tests/Makefile.am
M utils/Makefile.am
M utils/osmo-stat-dummy/Makefile.am
75 files changed, 138 insertions(+), 132 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/13/31013/1
diff --git a/Makefile.am b/Makefile.am
index b3663ba..ffb30b7 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -4,15 +4,6 @@
SUBDIRS = \
include \
src \
- src/vty \
- src/codec \
- src/gsm \
- src/coding \
- src/gb \
- src/ctrl \
- src/sim \
- src/pseudotalloc \
- src/usb \
utils \
tapset \
tests \
diff --git a/configure.ac b/configure.ac
index 3d9492e..5f70fca 100644
--- a/configure.ac
+++ b/configure.ac
@@ -586,6 +586,7 @@
libosmousb.pc
include/Makefile
src/Makefile
+ src/core/Makefile
src/vty/Makefile
src/codec/Makefile
src/coding/Makefile
diff --git a/src/Makefile.am b/src/Makefile.am
index 2c73af6..5d8343c 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -1,108 +1,12 @@
-# This is _NOT_ the library release version, it's an API version.
-# Please read chapter "Library interface versions" of the libtool documentation
-# before making any modifications:
https://www.gnu.org/software/libtool/manual/html_node/Versioning.html
-LIBVERSION=19:0:0
-
-AM_CPPFLAGS = -I$(top_srcdir)/include -I$(top_builddir)/include
-AM_CFLAGS = -Wall $(TALLOC_CFLAGS) $(PTHREAD_CFLAGS) $(LIBSCTP_CFLAGS)
$(LIBMNL_CFLAGS)
-
-if ENABLE_PSEUDOTALLOC
-AM_CPPFLAGS += -I$(top_srcdir)/src/pseudotalloc
-endif
-
-lib_LTLIBRARIES = libosmocore.la
-
-libosmocore_la_LIBADD = $(BACKTRACE_LIB) $(TALLOC_LIBS) $(LIBRARY_RT)
$(PTHREAD_LIBS) $(LIBSCTP_LIBS)
-libosmocore_la_SOURCES = context.c timer.c timer_gettimeofday.c
timer_clockgettime.c \
-select.c signal.c msgb.c bits.c \
-bitvec.c bitcomp.c counter.c fsm.c \
-write_queue.c utils.c socket.c \
-logging.c logging_syslog.c logging_gsmtap.c rate_ctr.c
\
-gsmtap_util.c crc16.c panic.c backtrace.c \
-conv.c application.c rbtree.c strrb.c \
-loggingrb.c crc8gen.c crc16gen.c crc32gen.c crc64gen.c
\
-macaddr.c stat_item.c stats.c stats_statsd.c prim.c \
-stats_tcp.c \
-conv_acc.c conv_acc_generic.c sercomm.c prbs.c \
-isdnhdlc.c \
-tdef.c \
-thread.c \
-time_cc.c \
-sockaddr_str.c \
-use_count.c \
-exec.c \
-it_q.c \
-probes.d \
-base64.c \
-$(NULL)
-
-if HAVE_SSSE3
Change in osmo-bts[master]: contrib/jenkins: build libosmo-abis without dahdi
Attention is currently required from: osmith, tnt. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31012 ) Change subject: contrib/jenkins: build libosmo-abis without dahdi .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31012 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I61c483983a4793e0429bb37804dee0a128125daf Gerrit-Change-Number: 31012 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Reviewer: tnt Gerrit-Attention: osmith Gerrit-Attention: tnt Gerrit-Comment-Date: Wed, 18 Jan 2023 15:13:45 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bts[master]: contrib/jenkins: build libosmo-abis without dahdi
Attention is currently required from: osmith, tnt. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31012 ) Change subject: contrib/jenkins: build libosmo-abis without dahdi .. Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: > why is "this not needed"? DAHDI is the primary E1 input driver we use, for > example in commercial gbp […] ah, nevermind. I failed to see that this is about osmo-bts. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31012 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I61c483983a4793e0429bb37804dee0a128125daf Gerrit-Change-Number: 31012 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: tnt Gerrit-CC: pespin Gerrit-Attention: osmith Gerrit-Attention: tnt Gerrit-Comment-Date: Wed, 18 Jan 2023 15:13:14 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge Gerrit-MessageType: comment
Change in osmo-bts[master]: contrib/jenkins: build libosmo-abis without dahdi
Attention is currently required from: osmith, tnt. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31012 ) Change subject: contrib/jenkins: build libosmo-abis without dahdi .. Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: why is "this not needed"? DAHDI is the primary E1 input driver we use, for example in commercial gbproxy deployments of sysmocom. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31012 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I61c483983a4793e0429bb37804dee0a128125daf Gerrit-Change-Number: 31012 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: tnt Gerrit-CC: pespin Gerrit-Attention: osmith Gerrit-Attention: tnt Gerrit-Comment-Date: Wed, 18 Jan 2023 15:12:48 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in docker-playground[master]: ttcn3-bts-test: replace subnets during 'make cfg'
Attention is currently required from: osmith, daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/31011 ) Change subject: ttcn3-bts-test: replace subnets during 'make cfg' .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31011 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I733619f80b4e2456da070649634d3c942bb6d95f Gerrit-Change-Number: 31011 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Attention: daniel Gerrit-Comment-Date: Wed, 18 Jan 2023 14:58:14 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-hlr[master]: Add vty `reject-cause` to set the reject cause
Attention is currently required from: keith, lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16808 ) Change subject: Add vty `reject-cause` to set the reject cause .. Patch Set 11: (1 comment) Patchset: PS11: Hi @keith, maybe what I'm missing here is the rationale on WHY is this needed. What's the rationale behind wanting to change the reported cause? -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16808 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a Gerrit-Change-Number: 16808 Gerrit-PatchSet: 11 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-CC: keith Gerrit-CC: pespin Gerrit-Attention: keith Gerrit-Attention: lynxis lazus Gerrit-Comment-Date: Wed, 18 Jan 2023 14:57:44 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-hnbgw[master]: fix msgb leak for RANAP RAB Ass. Req.
Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/31009 ) Change subject: fix msgb leak for RANAP RAB Ass. Req. .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/31009 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ie30e880301346ffca72f98f8c467e56d622fb03f Gerrit-Change-Number: 31009 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: neels Gerrit-Comment-Date: Wed, 18 Jan 2023 14:55:13 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-hnbgw[master]: fix segfault on MGCP timeout
Attention is currently required from: neels, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/31008 ) Change subject: fix segfault on MGCP timeout .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/31008 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I460d7249f4fc7edcfd94f6084fc8f933b491520c Gerrit-Change-Number: 31008 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: neels Gerrit-Attention: dexter Gerrit-Comment-Date: Wed, 18 Jan 2023 14:54:31 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmocom-bb[master]: layer23: Introduce tun.{c,h}
pespin has removed a vote from this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/30994 )
Change subject: layer23: Introduce tun.{c,h}
..
Removed Code-Review+1 by pespin
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30994
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Id8611b720ada17a3c602872fe095bb91eeb17bcd
Gerrit-Change-Number: 30994
Gerrit-PatchSet: 5
Gerrit-Owner: pespin
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter
Gerrit-Reviewer: laforge
Gerrit-Reviewer: osmith
Gerrit-Reviewer: pespin
Gerrit-MessageType: deleteVote
Change in osmocom-bb[master]: layer23: Introduce tun.{c,h}
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/30994 )
Change subject: layer23: Introduce tun.{c,h}
..
Patch Set 5: Verified+1
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30994
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Id8611b720ada17a3c602872fe095bb91eeb17bcd
Gerrit-Change-Number: 30994
Gerrit-PatchSet: 5
Gerrit-Owner: pespin
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter
Gerrit-Reviewer: laforge
Gerrit-Reviewer: osmith
Gerrit-Reviewer: pespin
Gerrit-Comment-Date: Wed, 18 Jan 2023 14:51:30 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Change in osmocom-bb[master]: layer23: Introduce netdev.{c,h}
Attention is currently required from: laforge.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/30993 )
Change subject: layer23: Introduce netdev.{c,h}
..
Patch Set 5: Verified+1
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30993
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I6085dc6861687bd4e9c32e86221c0375ad95ba22
Gerrit-Change-Number: 30993
Gerrit-PatchSet: 5
Gerrit-Owner: pespin
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: osmith
Gerrit-Reviewer: pespin
Gerrit-Attention: laforge
Gerrit-Comment-Date: Wed, 18 Jan 2023 14:51:23 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Change in osmocom-bb[master]: layer23: main: Log line about using config file before parsing it
pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/31006 )
Change subject: layer23: main: Log line about using config file before parsing
it
..
layer23: main: Log line about using config file before parsing it
Change-Id: I66b5b18887b8deb37c3784fec90644470498d7b5
---
M src/host/layer23/src/common/main.c
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, but someone else must approve
fixeria: Looks good to me, approved
diff --git a/src/host/layer23/src/common/main.c
b/src/host/layer23/src/common/main.c
index 2cdf5d4..82bbc60 100644
--- a/src/host/layer23/src/common/main.c
+++ b/src/host/layer23/src/common/main.c
@@ -231,6 +231,7 @@
if (app->vty_init)
app->vty_init();
if (config_file) {
+ LOGP(DLGLOBAL, LOGL_INFO, "Using configuration from '%s'\n",
config_file);
l23_vty_reading = true;
rc = vty_read_config_file(config_file, NULL);
l23_vty_reading = false;
@@ -239,7 +240,6 @@
"Failed to parse the configuration file
'%s'\n", config_file);
return rc;
}
- LOGP(DLGLOBAL, LOGL_INFO, "Using configuration from '%s'\n",
config_file);
}
rc = telnet_init_default(l23_ctx, NULL, OSMO_VTY_PORT_BB);
if (rc < 0) {
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31006
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I66b5b18887b8deb37c3784fec90644470498d7b5
Gerrit-Change-Number: 31006
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-hnbgw[master]: drop bogus error log 'no MGW fsm'
Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/30688 ) Change subject: drop bogus error log 'no MGW fsm' .. Patch Set 2: Code-Review+1 (1 comment) File src/osmo-hnbgw/mgw_fsm.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/30688/comment/58ecf845_3ec8b068 PS2, Line 785: if (!map->mgw_fi) > I disagree here. The common pattern I am thinking of here is: when cleaned > up, NULL the pointer. […] Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/30688 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I89dd4fb6913bfb84b6667b159e09968734e2102a Gerrit-Change-Number: 30688 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Attention: neels Gerrit-Comment-Date: Wed, 18 Jan 2023 14:49:50 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels Comment-In-Reply-To: dexter Gerrit-MessageType: comment
Change in osmo-bts[master]: contrib/jenkins: build libosmo-abis without dahdi
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/31012 ) Change subject: contrib/jenkins: build libosmo-abis without dahdi .. contrib/jenkins: build libosmo-abis without dahdi Looks like this is not needed, so make the jenkins build work without installing dahdi-source. Related: OS#5863 Change-Id: I61c483983a4793e0429bb37804dee0a128125daf --- M contrib/jenkins_bts_trx.sh M contrib/jenkins_lc15.sh M contrib/jenkins_oc2g.sh M contrib/jenkins_oct.sh M contrib/jenkins_oct_and_bts_trx.sh M contrib/jenkins_sysmobts.sh 6 files changed, 6 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/12/31012/1 diff --git a/contrib/jenkins_bts_trx.sh b/contrib/jenkins_bts_trx.sh index a98a633..9ac820d 100755 --- a/contrib/jenkins_bts_trx.sh +++ b/contrib/jenkins_bts_trx.sh @@ -9,7 +9,7 @@ osmo-build-dep.sh libosmocore "" --disable-doxygen -osmo-build-dep.sh libosmo-abis +osmo-build-dep.sh libosmo-abis "" --disable-dahdi osmo-build-dep.sh libosmo-netif "" --disable-doxygen cd "$deps" diff --git a/contrib/jenkins_lc15.sh b/contrib/jenkins_lc15.sh index 4454f65..89dd54b 100755 --- a/contrib/jenkins_lc15.sh +++ b/contrib/jenkins_lc15.sh @@ -9,7 +9,7 @@ export PKG_CONFIG_PATH="$inst/lib/pkgconfig:$PKG_CONFIG_PATH" export LD_LIBRARY_PATH="$inst/lib" -osmo-build-dep.sh libosmo-abis +osmo-build-dep.sh libosmo-abis "" --disable-dahdi osmo-build-dep.sh libosmo-netif "" --disable-doxygen cd "$deps" diff --git a/contrib/jenkins_oc2g.sh b/contrib/jenkins_oc2g.sh index af2f8a0..e4795cf 100755 --- a/contrib/jenkins_oc2g.sh +++ b/contrib/jenkins_oc2g.sh @@ -9,7 +9,7 @@ export PKG_CONFIG_PATH="$inst/lib/pkgconfig:$PKG_CONFIG_PATH" export LD_LIBRARY_PATH="$inst/lib" -osmo-build-dep.sh libosmo-abis +osmo-build-dep.sh libosmo-abis "" --disable-dahdi osmo-build-dep.sh libosmo-netif "" --disable-doxygen cd "$deps" diff --git a/contrib/jenkins_oct.sh b/contrib/jenkins_oct.sh index 0984e20..d1b6aee 100755 --- a/contrib/jenkins_oct.sh +++ b/contrib/jenkins_oct.sh @@ -9,7 +9,7 @@ export PKG_CONFIG_PATH="$inst/lib/pkgconfig:$PKG_CONFIG_PATH" export LD_LIBRARY_PATH="$inst/lib" -osmo-build-dep.sh libosmo-abis +osmo-build-dep.sh libosmo-abis "" --disable-dahdi osmo-build-dep.sh libosmo-netif "" --disable-doxygen cd "$deps" diff --git a/contrib/jenkins_oct_and_bts_trx.sh b/contrib/jenkins_oct_and_bts_trx.sh index 3f4efae..f188147 100755 --- a/contrib/jenkins_oct_and_bts_trx.sh +++ b/contrib/jenkins_oct_and_bts_trx.sh @@ -9,7 +9,7 @@ osmo-build-dep.sh libosmocore "" --disable-doxygen -osmo-build-dep.sh libosmo-abis +osmo-build-dep.sh libosmo-abis "" --disable-dahdi osmo-build-dep.sh libosmo-netif "" --disable-doxygen cd "$deps" diff --git a/contrib/jenkins_sysmobts.sh b/contrib/jenkins_sysmobts.sh index 2e5ab8d..87a98f3 100755 --- a/contrib/jenkins_sysmobts.sh +++ b/contrib/jenkins_sysmobts.sh @@ -9,7 +9,7 @@ export PKG_CONFIG_PATH="$inst/lib/pkgconfig:$PKG_CONFIG_PATH" export LD_LIBRARY_PATH="$inst/lib" -osmo-build-dep.sh libosmo-abis +osmo-build-dep.sh libosmo-abis "" --disable-dahdi osmo-build-dep.sh libosmo-netif "" --disable-doxygen cd "$deps" -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31012 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I61c483983a4793e0429bb37804dee0a128125daf Gerrit-Change-Number: 31012 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange
Change in osmo-ci[master]: jobs/gerrit-verifications: post comment on start
osmith has submitted this change. (
https://gerrit.osmocom.org/c/osmo-ci/+/30988 )
Change subject: jobs/gerrit-verifications: post comment on start
..
jobs/gerrit-verifications: post comment on start
Post a link to gerrit when starting the build that contains the link to
the pipeline, without sending mail notifications.
This is useful when a gerrit verification build takes rather long, and
it's not clear if a build for gerrit verification was actually started
or not. Also I find this useful when debugging the CI scripts.
Change-Id: I75c5b8874f606739ff557ff0711bb9449a2b4259
---
M jobs/gerrit-verifications-comment.yml
M jobs/gerrit-verifications.yml
M scripts/jenkins-gerrit/comment_generate.py
M scripts/jenkins-gerrit/comment_send.sh
4 files changed, 52 insertions(+), 10 deletions(-)
Approvals:
laforge: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/jobs/gerrit-verifications-comment.yml
b/jobs/gerrit-verifications-comment.yml
index 1c672b9..f781bf8 100644
--- a/jobs/gerrit-verifications-comment.yml
+++ b/jobs/gerrit-verifications-comment.yml
@@ -1,5 +1,6 @@
-# This job runs at the end of the pipeline in gerrit-verififactions.yml, to
-# post a list of failed/successful job links to gerrit and to vote +V/-V.
+# This job runs at the start/end of the pipeline in gerrit-verifications.yml.
+# On start it posts a link to the pipeline to gerrit, and on end a list of
+# failed/successful job links together with a vote +V/-V.
- project:
name: gerrit-verifications-comment
@@ -18,7 +19,7 @@
artifact-days-to-keep: -1
artifact-num-to-keep: -1
description: |
- Result job of CI for patches sent to https://gerrit.osmocom.org;>gerrit.
+ Send start and result comments to https://gerrit.osmocom.org;>gerrit.
Related issue: https://osmocom.org/issues/2385;>OS#2385
@@ -29,6 +30,9 @@
osmo-ci.git branch
default: 'master'
- string:
+ name: COMMENT_TYPE
+ description: set by gerrit verification pipeline job
+ - string:
name: GERRIT_PROJECT
description: set by gerrit verification pipeline job
- string:
diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml
index 1896a98..b83b5aa 100644
--- a/jobs/gerrit-verifications.yml
+++ b/jobs/gerrit-verifications.yml
@@ -416,6 +416,29 @@
stages {{
stage("Verification") {{
parallel {{
+ stage("Start Comment") {{
+steps {{
+ // Run the comment job to add the pipeline link to gerrit
+ script {{
+// Keep going on failure
+catchError(buildResult: 'SUCCESS', stageResult: 'FAILURE')
{{
+ build job: 'gerrit-verifications-comment', parameters: [
+string(name: "COMMENT_TYPE", value: "start"),
+string(name: "GERRIT_PROJECT", value:
"${{env.GERRIT_PROJECT}}"),
+string(name: "GERRIT_CHANGE_NUMBER", value:
"${{env.GERRIT_CHANGE_NUMBER}}"),
+string(name: "GERRIT_PATCHSET_NUMBER", value:
"${{env.GERRIT_PATCHSET_NUMBER}}"),
+string(name: "GERRIT_BRANCH", value:
"${{env.GERRIT_BRANCH}}"),
+string(name: "GERRIT_HOST", value:
"${{env.GERRIT_HOST}}"),
+string(name: "GERRIT_PATCHSET_REVISION", value:
"${{env.GERRIT_PATCHSET_REVISION}}"),
+string(name: "GERRIT_PATCHSET_UPLOADER_NAME", value:
"${{env.GERRIT_PATCHSET_UPLOADER_NAME}}"),
+string(name: "GERRIT_PORT", value:
"${{env.GERRIT_PORT}}"),
+string(name: "GERRIT_REFSPEC", value:
"${{env.GERRIT_REFSPEC}}"),
+string(name: "PIPELINE_BUILD_URL", value:
"${{env.BUILD_URL}}"),
+ ]
+}}
+ }}
+}}
+ }}
stage("Build") {{
when {{
expression {{ params.PIPELINE_BUILD }}
@@ -512,6 +535,7 @@
// comment + vote to gerrit
script {{
build job: 'gerrit-verifications-comment', parameters: [
+ string(name: "COMMENT_TYPE", value: "result"),
string(name: "GERRIT_PROJECT", value:
"${{env.GERRIT_PROJECT}}"),
string(name: "GERRIT_CHANGE_NUMBER", value:
"${{env.GERRIT_CHANGE_NUMBER}}"),
string(name: "GERRIT_PATCHSET_NUMBER", value:
"${{env.GERRIT_PATCHSET_NUMBER}}"),
diff --git a/scripts/jenkins-gerrit/comment_generate.py
b/scripts/jenkins-gerrit/comment_generate.py
index d4937c0..dc69f8f 100755
--- a/scripts/jenkins-gerrit/comment_generate.py
+++ b/scripts/jenkins-gerrit/comment_generate.py
@@
Change in osmo-ci[master]: jobs/gerrit-verifications-comment: rename
osmith has submitted this change. (
https://gerrit.osmocom.org/c/osmo-ci/+/30987 )
Change subject: jobs/gerrit-verifications-comment: rename
..
jobs/gerrit-verifications-comment: rename
Rename the jenkins job from gerrit-pipeline-result to
gerrit-verifications-comment, as the next patch will not only use this
job to post a comment at the end of the gerrit verification, but also at
the beginning when the pipeline starts.
Give the pipeline_summary* scripts more generic names as well.
Change-Id: I1b947522aa5f2bb21f5e438db9df3420c998f1bc
---
R jobs/gerrit-verifications-comment.yml
M jobs/gerrit-verifications.yml
R scripts/jenkins-gerrit/comment_generate.py
R scripts/jenkins-gerrit/comment_send.sh
4 files changed, 9 insertions(+), 9 deletions(-)
Approvals:
laforge: Looks good to me, approved
fixeria: Looks good to me, but someone else must approve
pespin: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/jobs/gerrit-pipeline-result.yml
b/jobs/gerrit-verifications-comment.yml
similarity index 92%
rename from jobs/gerrit-pipeline-result.yml
rename to jobs/gerrit-verifications-comment.yml
index e1a7a74..1c672b9 100644
--- a/jobs/gerrit-pipeline-result.yml
+++ b/jobs/gerrit-verifications-comment.yml
@@ -2,12 +2,12 @@
# post a list of failed/successful job links to gerrit and to vote +V/-V.
- project:
-name: gerrit-pipeline-result
+name: gerrit-verifications-comment
jobs:
- - 'gerrit-pipeline-result'
+ - 'gerrit-verifications-comment'
- job:
-name: 'gerrit-pipeline-result'
+name: 'gerrit-verifications-comment'
project-type: freestyle
node: osmocom-gerrit
retry-count: 3 # scm checkout
@@ -68,7 +68,7 @@
wipe-workspace: true
builders:
- - shell: 'cd scripts/jenkins-gerrit && ./pipeline_summary_send.sh'
+ - shell: 'cd scripts/jenkins-gerrit && ./comment_send.sh'
wrappers:
- ansicolor:
diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml
index 0f35fcd..1896a98 100644
--- a/jobs/gerrit-verifications.yml
+++ b/jobs/gerrit-verifications.yml
@@ -501,17 +501,17 @@
}}
}}
}}
- stage("Result") {{
+ stage("Result Comment") {{
steps {{
echo "PIPELINE_BUILD_PASSED=${{env.PIPELINE_BUILD_PASSED}}"
echo "PIPELINE_LINT_PASSED=${{env.PIPELINE_LINT_PASSED}}"
echo "PIPELINE_DEB_PASSED=${{env.PIPELINE_DEB_PASSED}}"
echo "PIPELINE_RPM_PASSED=${{env.PIPELINE_RPM_PASSED}}"
- // Run the result job to get successful/failed links and add a
+ // Run the comment job to get successful/failed links and add a
// comment + vote to gerrit
script {{
- build job: 'gerrit-pipeline-result', parameters: [
+ build job: 'gerrit-verifications-comment', parameters: [
string(name: "GERRIT_PROJECT", value:
"${{env.GERRIT_PROJECT}}"),
string(name: "GERRIT_CHANGE_NUMBER", value:
"${{env.GERRIT_CHANGE_NUMBER}}"),
string(name: "GERRIT_PATCHSET_NUMBER", value:
"${{env.GERRIT_PATCHSET_NUMBER}}"),
diff --git a/scripts/jenkins-gerrit/pipeline_summary.py
b/scripts/jenkins-gerrit/comment_generate.py
similarity index 98%
rename from scripts/jenkins-gerrit/pipeline_summary.py
rename to scripts/jenkins-gerrit/comment_generate.py
index 53c0f4a..d4937c0 100755
--- a/scripts/jenkins-gerrit/pipeline_summary.py
+++ b/scripts/jenkins-gerrit/comment_generate.py
@@ -28,7 +28,7 @@
def stage_from_job_name(job_name):
-if job_name == "gerrit-pipeline-result":
+if job_name == "gerrit-verifications-comment":
# The job that runs this script. Don't include it in the summary.
return None
if job_name == "gerrit-lint":
diff --git a/scripts/jenkins-gerrit/pipeline_summary_send.sh
b/scripts/jenkins-gerrit/comment_send.sh
similarity index 92%
rename from scripts/jenkins-gerrit/pipeline_summary_send.sh
rename to scripts/jenkins-gerrit/comment_send.sh
index 29ea860..bd7b81d 100755
--- a/scripts/jenkins-gerrit/pipeline_summary_send.sh
+++ b/scripts/jenkins-gerrit/comment_send.sh
@@ -16,7 +16,7 @@
set -x
-./pipeline_summary.py "$PIPELINE_BUILD_URL" \
+./comment_generate.py "$PIPELINE_BUILD_URL" \
-o gerrit_report.json \
$arg_notify
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30987
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I1b947522aa5f2bb21f5e438db9df3420c998f1bc
Gerrit-Change-Number: 30987
Gerrit-PatchSet: 2
Gerrit-Owner: osmith
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: laforge
Gerrit-Reviewer: osmith
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in osmo-ci[master]: jobs/gerrit-verifications: post comment on start
Attention is currently required from: osmith, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30988 ) Change subject: jobs/gerrit-verifications: post comment on start .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30988 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I75c5b8874f606739ff557ff0711bb9449a2b4259 Gerrit-Change-Number: 30988 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: osmith Gerrit-Attention: fixeria Gerrit-Comment-Date: Wed, 18 Jan 2023 12:33:03 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in docker-playground[master]: ttcn3-bts-test: replace subnets during 'make cfg'
Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/31011 ) Change subject: ttcn3-bts-test: replace subnets during 'make cfg' .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31011 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I733619f80b4e2456da070649634d3c942bb6d95f Gerrit-Change-Number: 31011 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Attention: osmith Gerrit-Comment-Date: Wed, 18 Jan 2023 12:03:19 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in docker-playground[master]: ttcn3-bts-test: replace subnets during 'make cfg'
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/31011 to look at the new patch set (#2). Change subject: ttcn3-bts-test: replace subnets during 'make cfg' .. ttcn3-bts-test: replace subnets during 'make cfg' Make ttcn3-bts-test work as expected again by replacing the subnets hardcoded in the confmerge files and Makefile. Related: OS#5802 Change-Id: I733619f80b4e2456da070649634d3c942bb6d95f --- M jenkins-common.sh M ttcn3-bts-test/jenkins.sh 2 files changed, 7 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/11/31011/2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31011 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I733619f80b4e2456da070649634d3c942bb6d95f Gerrit-Change-Number: 31011 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset
Change in docker-playground[master]: ttcn3-bts-test: replace subnets during 'make cfg'
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/31011 ) Change subject: ttcn3-bts-test: replace subnets during 'make cfg' .. ttcn3-bts-test: replace subnets during 'make cfg' Make ttcn3-bts-test work as expected again by replacing the subnets hardcoded in the confmerge files and Makefile. Related: OS#5802 Change-Id: I733619f80b4e2456da070649634d3c942bb6d95f --- M jenkins-common.sh M ttcn3-bts-test/jenkins.sh 2 files changed, 6 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/11/31011/1 diff --git a/jenkins-common.sh b/jenkins-common.sh index 08d4e4e..d566b23 100644 --- a/jenkins-common.sh +++ b/jenkins-common.sh @@ -270,10 +270,12 @@ "$VOL_BASE_DIR" \ -name '*.cfg' -o \ -name '*.conf' -o \ + -name '*.confmerge' -o \ -name '*.scm' -o \ -name '*.sh' -o \ -name '*.txt' -o \ - -name '*.yaml' \ + -name '*.yaml' -o \ + -name 'Makefile' \ )" if [ -z "$files" ]; then diff --git a/ttcn3-bts-test/jenkins.sh b/ttcn3-bts-test/jenkins.sh index 691c753..7d4d3dc 100755 --- a/ttcn3-bts-test/jenkins.sh +++ b/ttcn3-bts-test/jenkins.sh @@ -140,7 +140,9 @@ $VOL_BASE_DIR/bts-tester-hopping/BTS_Tests.cfg.inc # (re)generate the configuration files -make cfg +cp Makefile $VOL_BASE_DIR/Makefile +network_replace_subnet_in_configs +make -f $VOL_BASE_DIR/Makefile cfg mkdir $VOL_BASE_DIR/bsc cp generic/osmo-bsc.gen.cfg $VOL_BASE_DIR/bsc/ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31011 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I733619f80b4e2456da070649634d3c942bb6d95f Gerrit-Change-Number: 31011 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange
Change in osmo-hlr[master]: Add vty `reject-cause` to set the reject cause
Attention is currently required from: keith, lynxis lazus. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16808 ) Change subject: Add vty `reject-cause` to set the reject cause .. Patch Set 11: Code-Review+2 (5 comments) Patchset: PS6: > CR-1 for incomplete command description. […] Done File src/hlr_vty.c: https://gerrit.osmocom.org/c/osmo-hlr/+/16808/comment/f3deb0b1_35c2f6af PS4, Line 85: get_value_string_or_null > We should not get NULL if everything is correct I think. Done https://gerrit.osmocom.org/c/osmo-hlr/+/16808/comment/70fe5a9a_2f73a111 PS4, Line 356: imsi unknown cause > Given that you're adding a value-string array now, it would be better to > generate the command and he […] Done https://gerrit.osmocom.org/c/osmo-hlr/+/16808/comment/982d00c0_09315dd9 PS4, Line 357: GSUP cause > Saying GSUP/GMM is an option ;) But I don't want to block you here, so you > can keep this as is. Done File src/hlr_vty.c: https://gerrit.osmocom.org/c/osmo-hlr/+/16808/comment/262e98ac_6b0de870 PS6, Line 381: imsi unknown cause > Here I would recommend concatenating all three words using '-', i.e. > 'imsi-unknown-cause'. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16808 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a Gerrit-Change-Number: 16808 Gerrit-PatchSet: 11 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-CC: keith Gerrit-CC: pespin Gerrit-Attention: keith Gerrit-Attention: lynxis lazus Gerrit-Comment-Date: Wed, 18 Jan 2023 11:00:03 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria Comment-In-Reply-To: lynxis lazus Gerrit-MessageType: comment
Change in osmo-hnbgw[master]: fix msgb leak for RANAP RAB Ass. Req.
Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/31009 ) Change subject: fix msgb leak for RANAP RAB Ass. Req. .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/31009 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ie30e880301346ffca72f98f8c467e56d622fb03f Gerrit-Change-Number: 31009 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Attention: neels Gerrit-Comment-Date: Wed, 18 Jan 2023 10:47:54 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-hnbgw[master]: fix segfault on MGCP timeout
Attention is currently required from: neels, pespin, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/31008 ) Change subject: fix segfault on MGCP timeout .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/31008 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I460d7249f4fc7edcfd94f6084fc8f933b491520c Gerrit-Change-Number: 31008 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: neels Gerrit-Attention: pespin Gerrit-Attention: dexter Gerrit-Comment-Date: Wed, 18 Jan 2023 10:47:26 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmocom-bb[master]: layer23: main: Log line about using config file before parsing it
Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31006 ) Change subject: layer23: main: Log line about using config file before parsing it .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31006 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I66b5b18887b8deb37c3784fec90644470498d7b5 Gerrit-Change-Number: 31006 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Attention: pespin Gerrit-Comment-Date: Wed, 18 Jan 2023 10:44:32 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in docker-playground[master]: debian-buster-jenkins: install ccache
osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/31010 ) Change subject: debian-buster-jenkins: install ccache .. debian-buster-jenkins: install ccache Make ccache available inside debian-buster-jenkins. An upcoming osmo-ci patch will make use of it in gerrit-verification and master jobs. With this docker-playground patch alone it's not used yet since /usr/lib/ccache is not in the default PATH. Related: OS#5848 Change-Id: I164c7835f99436e8d768a864f36118eaf799d109 --- M debian-buster-jenkins/Dockerfile 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified Hoernchen: Looks good to me, approved diff --git a/debian-buster-jenkins/Dockerfile b/debian-buster-jenkins/Dockerfile index 44c2ee3..ddd14f4 100644 --- a/debian-buster-jenkins/Dockerfile +++ b/debian-buster-jenkins/Dockerfile @@ -30,6 +30,7 @@ bison \ bzip2 \ ca-certificates \ + ccache \ cmake \ coccinelle \ cppcheck \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31010 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I164c7835f99436e8d768a864f36118eaf799d109 Gerrit-Change-Number: 31010 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-MessageType: merged
Change in docker-playground[master]: debian-buster-jenkins: install ccache
Attention is currently required from: osmith. Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/31010 ) Change subject: debian-buster-jenkins: install ccache .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31010 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I164c7835f99436e8d768a864f36118eaf799d109 Gerrit-Change-Number: 31010 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: osmith Gerrit-Comment-Date: Wed, 18 Jan 2023 09:17:42 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in docker-playground[master]: debian-buster-jenkins: install ccache
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/31010 ) Change subject: debian-buster-jenkins: install ccache .. debian-buster-jenkins: install ccache Make ccache available inside debian-buster-jenkins. An upcoming osmo-ci patch will make use of it in gerrit-verification and master jobs. With this docker-playground patch alone it's not used yet since /usr/lib/ccache is not in the default PATH. Related: OS#5848 Change-Id: I164c7835f99436e8d768a864f36118eaf799d109 --- M debian-buster-jenkins/Dockerfile 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/10/31010/1 diff --git a/debian-buster-jenkins/Dockerfile b/debian-buster-jenkins/Dockerfile index 44c2ee3..ddd14f4 100644 --- a/debian-buster-jenkins/Dockerfile +++ b/debian-buster-jenkins/Dockerfile @@ -30,6 +30,7 @@ bison \ bzip2 \ ca-certificates \ + ccache \ cmake \ coccinelle \ cppcheck \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31010 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I164c7835f99436e8d768a864f36118eaf799d109 Gerrit-Change-Number: 31010 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange
