[S] Change in pysim[master]: Add swig to Debian installation instructions
Attention is currently required from: Sebastian Schmidt. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34600?usp=email ) Change subject: Add swig to Debian installation instructions .. Patch Set 1: Code-Review-2 (1 comment) Patchset: PS1: pySim is not using `swig` directly, so I don't see why would we want to have this dependency, sorry. It's a dependency of `pyscard`, so your package manager should pull `swig` when installing it automatically? I cannot reproduce this in a virtual env with python 3.11.5 and pip 23.2, `pyscard 2.0.7` installs without `swig` just fine. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34600?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I989dd8ccf8d089c784d566fe0359b85df7575fc3 Gerrit-Change-Number: 34600 Gerrit-PatchSet: 1 Gerrit-Owner: Sebastian Schmidt Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Attention: Sebastian Schmidt Gerrit-Comment-Date: Sat, 30 Sep 2023 16:36:15 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in pysim[master]: Add pyshark to requirements.
Attention is currently required from: Sebastian Schmidt. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34601?usp=email ) Change subject: Add pyshark to requirements. .. Patch Set 1: (1 comment) Patchset: PS1: Hello and thanks for your contribution! Unfortunately, we cannot merge this patch. There has already been a discussion on this and we decided to not require `pyshark` dependency. Please see: https://gerrit.osmocom.org/c/pysim/+/33831 https://gerrit.osmocom.org/c/pysim/+/33834 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34601?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic93e83195feb7ada3b364bae86442dae90d81d90 Gerrit-Change-Number: 34601 Gerrit-PatchSet: 1 Gerrit-Owner: Sebastian Schmidt Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria Gerrit-Attention: Sebastian Schmidt Gerrit-Comment-Date: Sat, 30 Sep 2023 16:27:47 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
[S] Change in libosmo-netif[master]: stream_test: Disable nagling
arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/34599?usp=email ) Change subject: stream_test: Disable nagling .. Patch Set 1: (1 comment) Patchset: PS1: TCP_NODELAY was never set for the preexisting test (`test_recon()`), but I suppose that never caused timestamp problems there, because the server side isn't sending any TCP data in this test that could be nagled; it's only reconnects initiated by the client side. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/34599?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I7e8f6851df28e006fcb714673b97cf7b6be367bf Gerrit-Change-Number: 34599 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Sat, 30 Sep 2023 13:43:15 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
[S] Change in pysim[master]: Add pyshark to requirements.
Sebastian Schmidt has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/34601?usp=email ) Change subject: Add pyshark to requirements. .. Add pyshark to requirements. Is required by pySim-trace.py. Change-Id: Ic93e83195feb7ada3b364bae86442dae90d81d90 --- M requirements.txt 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/01/34601/1 diff --git a/requirements.txt b/requirements.txt index 4332b66..700a504 100644 --- a/requirements.txt +++ b/requirements.txt @@ -12,3 +12,4 @@ pycryptodomex packaging git+https://github.com/hologram-io/smpp.pdu +pyshark -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34601?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic93e83195feb7ada3b364bae86442dae90d81d90 Gerrit-Change-Number: 34601 Gerrit-PatchSet: 1 Gerrit-Owner: Sebastian Schmidt Gerrit-MessageType: newchange
[S] Change in pysim[master]: Add swig to Debian installation instructions
Sebastian Schmidt has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/34600?usp=email ) Change subject: Add swig to Debian installation instructions .. Add swig to Debian installation instructions The `pip install` command (at least in a virtualenv) installs pyscard, which in turn requires swig: × Running setup.py install for pyscard did not run successfully. │ exit code: 1 ╰─> [10 lines of output] running install /home/yath/sim/pysim/pyenv/lib/python3.11/site-packages/setuptools/command/install.py:34: SetuptoolsDeprecationWarning: setup.py install is deprecated. Use build and pip and other standards-based tools. warnings.warn( running build running build_py running build_ext building 'smartcard.scard._scard' extension swigging smartcard/scard/scard.i to smartcard/scard/scard_wrap.c swig -python -outdir smartcard/scard -DPCSCLITE -o smartcard/scard/scard_wrap.c smartcard/scard/scard.i error: command 'swig' failed: No such file or directory [end of output] Change-Id: I989dd8ccf8d089c784d566fe0359b85df7575fc3 --- M README.md 1 file changed, 28 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/00/34600/1 diff --git a/README.md b/README.md index 7801283..62f7594 100644 --- a/README.md +++ b/README.md @@ -91,7 +91,7 @@ Example for Debian: ```sh sudo apt-get install --no-install-recommends \ - pcscd libpcsclite-dev \ + swig pcscd libpcsclite-dev \ python3 \ python3-setuptools \ python3-pycryptodome \ -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34600?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I989dd8ccf8d089c784d566fe0359b85df7575fc3 Gerrit-Change-Number: 34600 Gerrit-PatchSet: 1 Gerrit-Owner: Sebastian Schmidt Gerrit-MessageType: newchange
[S] Change in libosmo-netif[master]: stream: Fix endless loop on server on client disconnect
arehbein has abandoned this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33196?usp=email ) Change subject: stream: Fix endless loop on server on client disconnect .. Abandoned Alternate patch created by daniel -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33196?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I012ddf14ae17642a52d34026d85ab6958cf488a1 Gerrit-Change-Number: 33196 Gerrit-PatchSet: 3 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-MessageType: abandon
[S] Change in libosmo-netif[master]: stream_test: Disable nagling
arehbein has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmo-netif/+/34599?usp=email )
Change subject: stream_test: Disable nagling
..
stream_test: Disable nagling
Disable nagling to make kernel packet processing time more predictable
Change-Id: I7e8f6851df28e006fcb714673b97cf7b6be367bf
---
M tests/stream/stream_test.c
1 file changed, 12 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/99/34599/1
diff --git a/tests/stream/stream_test.c b/tests/stream/stream_test.c
index 0977fde..be0b278 100644
--- a/tests/stream/stream_test.c
+++ b/tests/stream/stream_test.c
@@ -667,6 +667,7 @@
osmo_stream_srv_link_set_addr(srv, host);
osmo_stream_srv_link_set_port(srv, port);
osmo_stream_srv_link_set_accept_cb(srv, accept_cb_srv);
+ osmo_stream_srv_link_set_nodelay(srv, true);
if (osmo_stream_srv_link_open(srv) < 0) {
printf("Unable to open server\n");
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/34599?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I7e8f6851df28e006fcb714673b97cf7b6be367bf
Gerrit-Change-Number: 34599
Gerrit-PatchSet: 1
Gerrit-Owner: arehbein
Gerrit-MessageType: newchange
[M] Change in libosmo-netif[master]: stream: Add and use IPA send function
Attention is currently required from: arehbein, fixeria, pespin. Hello Jenkins Builder, fixeria, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/33201?usp=email to look at the new patch set (#20). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: stream: Add and use IPA send function .. stream: Add and use IPA send function Related OS#5753, OS#5751 Change-Id: I61e1fe59166c46595efe8c1f32b8f2607cb6c529 --- M examples/ipa-stream-client.c M examples/ipa-stream-server.c M include/osmocom/netif/ipa.h M src/ipa.c M tests/stream/stream_test.c 5 files changed, 68 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/01/33201/20 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33201?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I61e1fe59166c46595efe8c1f32b8f2607cb6c529 Gerrit-Change-Number: 33201 Gerrit-PatchSet: 20 Gerrit-Owner: arehbein Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: daniel Gerrit-Attention: arehbein Gerrit-Attention: pespin Gerrit-Attention: fixeria Gerrit-MessageType: newpatchset
[S] Change in osmocom-bb[master]: fixup ASCI: Add group receive and transmit mode support to MM laye
jolly has abandoned this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34556?usp=email ) Change subject: fixup ASCI: Add group receive and transmit mode support to MM laye .. Abandoned Patch from work in progress. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34556?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia6d0ac341b4b80199b344e04068ac152d7cc2ee7 Gerrit-Change-Number: 34556 Gerrit-PatchSet: 2 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-MessageType: abandon
[L] Change in osmocom-bb[master]: ASCI: Add group receive and transmit mode support to MM layer
Attention is currently required from: jolly, laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34492?usp=email ) Change subject: ASCI: Add group receive and transmit mode support to MM layer .. Patch Set 13: (1 comment) File src/host/layer23/src/mobile/gsm48_mm.c: https://gerrit.osmocom.org/c/osmocom-bb/+/34492/comment/f45e4363_881815b3 PS10, Line 4854:// There are event handlers for group call in this implementation. > v13 still hasn't this rephreased afaict. Fixed in https://gerrit.osmocom.org/c/osmocom-bb/+/34556, which should be squashed here. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34492?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I05957182a57423ad947ab200b52f65fde859e110 Gerrit-Change-Number: 34492 Gerrit-PatchSet: 13 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Attention: jolly Gerrit-Attention: laforge Gerrit-Attention: pespin Gerrit-Comment-Date: Sat, 30 Sep 2023 09:17:19 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly Comment-In-Reply-To: pespin Gerrit-MessageType: comment
[L] Change in osmocom-bb[master]: ASCI: Add ASCI notification support to RR layer
Attention is currently required from: jolly, laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34530?usp=email ) Change subject: ASCI: Add ASCI notification support to RR layer .. Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34530?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I49df02cb4d99d9aab1ea3ca13beb2ea00ae4c9f4 Gerrit-Change-Number: 34530 Gerrit-PatchSet: 7 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Attention: laforge Gerrit-Attention: pespin Gerrit-Comment-Date: Sat, 30 Sep 2023 09:16:13 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmocom-bb[master]: fixup ASCI: Add group receive and transmit mode support to MM laye
Attention is currently required from: jolly. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34556?usp=email ) Change subject: fixup ASCI: Add group receive and transmit mode support to MM laye .. Patch Set 2: (1 comment) Patchset: PS2: This patch should be squashed into https://gerrit.osmocom.org/c/osmocom-bb/+/34492, which is not yet merged. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34556?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia6d0ac341b4b80199b344e04068ac152d7cc2ee7 Gerrit-Change-Number: 34556 Gerrit-PatchSet: 2 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Attention: jolly Gerrit-Comment-Date: Sat, 30 Sep 2023 09:15:52 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
[XL] Change in osmocom-bb[master]: ASCI: Add GCC/BCC layer to support voice group/broadcast calls
Attention is currently required from: jolly. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34494?usp=email ) Change subject: ASCI: Add GCC/BCC layer to support voice group/broadcast calls .. Patch Set 14: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34494?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I22eacd018f18c18ba83dbd3dd874cf029344674d Gerrit-Change-Number: 34494 Gerrit-PatchSet: 14 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Comment-Date: Sat, 30 Sep 2023 09:13:51 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[L] Change in osmocom-bb[master]: ASCI: Add group receive and transmit mode support to MM layer
Attention is currently required from: jolly, laforge.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/34492?usp=email )
Change subject: ASCI: Add group receive and transmit mode support to MM layer
..
Patch Set 13:
(1 comment)
File src/host/layer23/src/mobile/gsm48_mm.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/34492/comment/908d9e92_e20214e9
PS8, Line 4643: if (rr_prim != -1) {
> Good idea. Lets see how it looks like.
Done
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34492?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I05957182a57423ad947ab200b52f65fde859e110
Gerrit-Change-Number: 34492
Gerrit-PatchSet: 13
Gerrit-Owner: jolly
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-CC: fixeria
Gerrit-Attention: jolly
Gerrit-Attention: laforge
Gerrit-Comment-Date: Sat, 30 Sep 2023 09:01:48 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: jolly
Comment-In-Reply-To: fixeria
Gerrit-MessageType: comment
[L] Change in osmocom-bb[master]: ASCI: Add group transmit mode support to RR layer
Attention is currently required from: jolly. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34545?usp=email ) Change subject: ASCI: Add group transmit mode support to RR layer .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34545?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I9b62eef5d877e5d9dcf349717efd2cce28862c58 Gerrit-Change-Number: 34545 Gerrit-PatchSet: 5 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Comment-Date: Sat, 30 Sep 2023 09:00:01 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[L] Change in osmocom-bb[master]: ASCI: Add group receive mode support to RR layer
Attention is currently required from: jolly, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34531?usp=email ) Change subject: ASCI: Add group receive mode support to RR layer .. Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34531?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia7d806b354fb3be5729bff8ac9aa1c7ad7a8b539 Gerrit-Change-Number: 34531 Gerrit-PatchSet: 7 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Attention: laforge Gerrit-Comment-Date: Sat, 30 Sep 2023 08:59:33 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[L] Change in osmocom-bb[master]: ASCI: Add ASCI notification support to RR layer
Attention is currently required from: jolly, laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34530?usp=email ) Change subject: ASCI: Add ASCI notification support to RR layer .. Patch Set 7: Code-Review+1 (2 comments) File src/host/layer23/src/mobile/gsm48_rr.c: https://gerrit.osmocom.org/c/osmocom-bb/+/34530/comment/7009c366_ea936d66 PS3, Line 1440: return -ENOMEM; > The allocation is not leaked. There is a timer running for every > notification. When it times out, the notification is removed from the list > [...] Ok, fine then! Marking as resolved. https://gerrit.osmocom.org/c/osmocom-bb/+/34530/comment/e37b4bf8_4a00ac93 PS3, Line 1519: msgb_l3len(msg) - sizeof(*nn); > There is no check. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34530?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I49df02cb4d99d9aab1ea3ca13beb2ea00ae4c9f4 Gerrit-Change-Number: 34530 Gerrit-PatchSet: 7 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Attention: laforge Gerrit-Attention: pespin Gerrit-Comment-Date: Sat, 30 Sep 2023 08:57:22 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: jolly Comment-In-Reply-To: pespin Comment-In-Reply-To: fixeria Gerrit-MessageType: comment
[M] Change in osmocom-bb[master]: ASCI: Prepare gsm48_rr_rx_acch for voice group channel
Attention is currently required from: jolly, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34529?usp=email ) Change subject: ASCI: Prepare gsm48_rr_rx_acch for voice group channel .. Patch Set 7: Code-Review+2 (2 comments) File src/host/layer23/src/mobile/gsm48_rr.c: https://gerrit.osmocom.org/c/osmocom-bb/+/34529/comment/ea0b0f9a_d50706cc PS3, Line 4895: sgh = msgb_l3(msg); > No, the header is only one byte. […] Ah, indeed. Marking as resolved. https://gerrit.osmocom.org/c/osmocom-bb/+/34529/comment/f0a47ec1_2780820f PS3, Line 4909: sih = msgb_l3(msg); > No, similar as above. B4 frame length is already checked. The header is way > smaller. I overlooked the check, sorry. Marking as resolved. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34529?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I39b27396a31137b3c4bdcb40dccdf3de60458fe2 Gerrit-Change-Number: 34529 Gerrit-PatchSet: 7 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Attention: laforge Gerrit-Comment-Date: Sat, 30 Sep 2023 08:49:05 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: jolly Comment-In-Reply-To: fixeria Gerrit-MessageType: comment
[S] Change in osmocom-bb[master]: Add header length check to received CCCH messages
Attention is currently required from: jolly. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34555?usp=email ) Change subject: Add header length check to received CCCH messages .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34555?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I3bc6b0b997e6ea1048c3357d276adfcc1638b02b Gerrit-Change-Number: 34555 Gerrit-PatchSet: 2 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Comment-Date: Sat, 30 Sep 2023 08:46:45 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[XL] Change in osmo-bts[master]: meas: also match stderr logging for meas_test
fixeria has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-bts/+/34597?usp=email ) Change subject: meas: also match stderr logging for meas_test .. meas: also match stderr logging for meas_test Change-Id: Id1ce154a65b194ce5fd9257c9c1b26d62aad1e0d Related: OS#6168 --- M tests/meas/Makefile.am M tests/meas/meas_test.c A tests/meas/meas_test.err M tests/testsuite.at 4 files changed, 8,438 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/97/34597/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34597?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id1ce154a65b194ce5fd9257c9c1b26d62aad1e0d Gerrit-Change-Number: 34597 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset
[L] Change in libosmo-sccp[master]: Split osmo_ss7_as functionalities to its own file
Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34590?usp=email ) Change subject: Split osmo_ss7_as functionalities to its own file .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34590?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I6e39dcb594ffe918ba117fce08cae7b5a6fd2dcc Gerrit-Change-Number: 34590 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Attention: pespin Gerrit-Comment-Date: Sat, 30 Sep 2023 08:36:49 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in libosmo-sccp[master]: Factor our osmo_ss7_as allocation to its own function
Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34589?usp=email ) Change subject: Factor our osmo_ss7_as allocation to its own function .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34589?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ie237ec8ac4b2e15b76fce3b3a56f47a59fdcc76e Gerrit-Change-Number: 34589 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Attention: pespin Gerrit-Comment-Date: Sat, 30 Sep 2023 08:35:44 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[L] Change in libosmo-sccp[master]: Split osmo_ss7_asp_peer functionalities to its own file
Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34588?usp=email ) Change subject: Split osmo_ss7_asp_peer functionalities to its own file .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34588?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I4fe457dc0ee1e904e05423557cfba2505b315a75 Gerrit-Change-Number: 34588 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Attention: pespin Gerrit-Comment-Date: Sat, 30 Sep 2023 08:34:25 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in libosmo-sccp[master]: asp: Factor out helper function to match host in asp_peer
Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34587?usp=email ) Change subject: asp: Factor out helper function to match host in asp_peer .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34587?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I6f13b285be09982ec83107ff96ade4dabf843815 Gerrit-Change-Number: 34587 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Attention: pespin Gerrit-Comment-Date: Sat, 30 Sep 2023 08:33:51 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[M] Change in libosmo-sccp[master]: cosmetic: src/Makefile: reformat to one item per line
Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34586?usp=email ) Change subject: cosmetic: src/Makefile: reformat to one item per line .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34586?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I9efb883d2a56723300a66b7e13c7aa079f2e4600 Gerrit-Change-Number: 34586 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Attention: pespin Gerrit-Comment-Date: Sat, 30 Sep 2023 08:32:37 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[XL] Change in osmo-bts[master]: meas: lchan_meas_sub_num_expected(): proper cmode enforcement
Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/34592?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: meas: lchan_meas_sub_num_expected(): proper cmode enforcement .. meas: lchan_meas_sub_num_expected(): proper cmode enforcement 3GPP TS 45.008, section 8.3 defines TDMA Fn subsets, which shall always be transmitted when DTX is employed, only for: * TCH/F in signalling mode (but not for TCH/H), * TCH/H and TCH/F in data mode (CSD) [*], * TCH/FS, TCH/EFS, and TCH/HS. For channel modes employing AMR codec, in particular: * TCH/AFS, TCH/WFS, O-TCH/WFS, * TCH/AHS, O-TCH/AHS, O-TCH/WHS, there exist no fixed TDMA Fn subsets, but DTX is still permitted. For those we expect at least one SACCH frame, plus a variable number of speech frames (0 or more). [*] Handling of data modes is fixed in a follow-up patch. Change-Id: Ied477528d77871dd7e3b5b7b433a4e33bca40011 Related: OS#6168 --- M src/common/measurement.c M tests/meas/meas_test.err 2 files changed, 764 insertions(+), 747 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/92/34592/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34592?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ied477528d77871dd7e3b5b7b433a4e33bca40011 Gerrit-Change-Number: 34592 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: fixeria Gerrit-MessageType: newpatchset
[XL] Change in osmo-bts[master]: meas: also match stderr logging for meas_test
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/34597?usp=email ) Change subject: meas: also match stderr logging for meas_test .. meas: also match stderr logging for meas_test Change-Id: Id1ce154a65b194ce5fd9257c9c1b26d62aad1e0d Related: OS#6168 --- M tests/meas/meas_test.c A tests/meas/meas_test.err M tests/testsuite.at 3 files changed, 8,437 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/97/34597/1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34597?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id1ce154a65b194ce5fd9257c9c1b26d62aad1e0d Gerrit-Change-Number: 34597 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange
